| *** germs has quit IRC | 00:04 | |
| *** fragatina has quit IRC | 00:04 | |
| *** salv-orlando has joined #openstack-nova | 00:05 | |
| *** Swami has quit IRC | 00:06 | |
| *** fragatina has joined #openstack-nova | 00:06 | |
| *** salv-orlando has quit IRC | 00:10 | |
| *** fragatina has quit IRC | 00:10 | |
| *** liverpooler has joined #openstack-nova | 00:11 | |
| *** yamamoto has joined #openstack-nova | 00:12 | |
| *** openstack has joined #openstack-nova | 00:15 | |
| *** ChanServ sets mode: +o openstack | 00:15 | |
| *** sdague has quit IRC | 00:17 | |
| *** yamamoto has quit IRC | 00:17 | |
| *** stakeda has joined #openstack-nova | 00:20 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:21 | |
| *** dave-mccowan has joined #openstack-nova | 00:22 | |
| openstackgerrit | Merged openstack/nova-specs master: Add serial numbers for local disks https://review.openstack.org/556565 | 00:29 |
|---|---|---|
| *** gyee has quit IRC | 00:33 | |
| *** yamahata has joined #openstack-nova | 00:38 | |
| *** yamamoto has joined #openstack-nova | 00:38 | |
| *** fragatina has joined #openstack-nova | 00:39 | |
| *** fragatina has quit IRC | 00:43 | |
| *** yamamoto has quit IRC | 00:45 | |
| *** vladikr has quit IRC | 00:48 | |
| *** vladikr has joined #openstack-nova | 00:49 | |
| *** yamahata has quit IRC | 00:49 | |
| *** jichen has joined #openstack-nova | 00:50 | |
| *** odyssey4me has quit IRC | 00:53 | |
| *** odyssey4me has joined #openstack-nova | 00:53 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove duplicative implementation of temporary directories. https://review.openstack.org/554791 | 00:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete. https://review.openstack.org/554792 | 00:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: Use a pythonic delete, with a retry. https://review.openstack.org/554793 | 00:55 |
| *** yamamoto has joined #openstack-nova | 00:56 | |
| *** yangyapeng has joined #openstack-nova | 00:58 | |
| *** tuanla____ has joined #openstack-nova | 01:01 | |
| *** chyka has joined #openstack-nova | 01:02 | |
| *** yangyapeng has quit IRC | 01:03 | |
| *** gjayavelu has quit IRC | 01:04 | |
| *** chyka has quit IRC | 01:06 | |
| *** itlinux has joined #openstack-nova | 01:07 | |
| *** tiendc has joined #openstack-nova | 01:08 | |
| *** gyankum has joined #openstack-nova | 01:12 | |
| *** yangyapeng has joined #openstack-nova | 01:14 | |
| *** yamamoto has quit IRC | 01:14 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 01:14 |
| *** itlinux has quit IRC | 01:15 | |
| *** gongysh has joined #openstack-nova | 01:16 | |
| *** Matias has quit IRC | 01:20 | |
| *** hongbin has joined #openstack-nova | 01:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (2/3) https://review.openstack.org/550648 | 01:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc (3/3) https://review.openstack.org/550659 | 01:24 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 01:25 |
| *** suresh12 has quit IRC | 01:34 | |
| *** sree has quit IRC | 01:36 | |
| *** sree has joined #openstack-nova | 01:37 | |
| *** gongysh has quit IRC | 01:38 | |
| *** vivsoni has quit IRC | 01:39 | |
| *** gouthamr has joined #openstack-nova | 01:40 | |
| *** vivsoni has joined #openstack-nova | 01:41 | |
| *** sree has quit IRC | 01:41 | |
| *** liusheng has quit IRC | 01:51 | |
| *** liusheng has joined #openstack-nova | 01:52 | |
| *** takashin has quit IRC | 01:53 | |
| *** _ix has quit IRC | 01:56 | |
| Spaz-Home | Morning novafriends | 01:58 |
| *** germs has joined #openstack-nova | 02:00 | |
| *** germs has quit IRC | 02:00 | |
| *** germs has joined #openstack-nova | 02:00 | |
| *** hshiina has quit IRC | 02:02 | |
| *** tbachman has quit IRC | 02:02 | |
| *** tbachman has joined #openstack-nova | 02:03 | |
| *** germs has quit IRC | 02:04 | |
| *** liusheng has quit IRC | 02:06 | |
| *** salv-orlando has joined #openstack-nova | 02:07 | |
| *** liusheng has joined #openstack-nova | 02:07 | |
| *** dikonoo has joined #openstack-nova | 02:09 | |
| *** psachin has joined #openstack-nova | 02:11 | |
| *** salv-orlando has quit IRC | 02:12 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:12 | |
| *** yamamoto has joined #openstack-nova | 02:15 | |
| *** AlexeyAbashkin has quit IRC | 02:16 | |
| *** yamamoto has quit IRC | 02:21 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 02:21 |
| *** suresh12 has joined #openstack-nova | 02:28 | |
| *** zhurong has joined #openstack-nova | 02:32 | |
| *** suresh12 has quit IRC | 02:33 | |
| *** gongysh has joined #openstack-nova | 02:35 | |
| *** hshiina has joined #openstack-nova | 02:36 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Extract generate_hostid method into utils.py https://review.openstack.org/555282 | 02:36 |
| *** yamamoto has joined #openstack-nova | 02:37 | |
| *** ccamacho|PTO has quit IRC | 02:38 | |
| *** sree has joined #openstack-nova | 02:39 | |
| *** sree has quit IRC | 02:39 | |
| *** sree has joined #openstack-nova | 02:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 02:42 |
| *** fragatina has joined #openstack-nova | 02:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 02:45 |
| *** fragatin_ has joined #openstack-nova | 02:46 | |
| *** takashin has joined #openstack-nova | 02:48 | |
| *** fragatina has quit IRC | 02:48 | |
| *** tbachman has joined #openstack-nova | 02:50 | |
| *** tbachman_ has joined #openstack-nova | 02:53 | |
| *** tbachman has quit IRC | 02:54 | |
| *** tbachman_ is now known as tbachman | 02:54 | |
| *** vladikr has quit IRC | 02:59 | |
| *** vladikr has joined #openstack-nova | 02:59 | |
| *** licanwei has joined #openstack-nova | 03:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for Granular API policy https://review.openstack.org/547850 | 03:10 |
| *** ccamacho has joined #openstack-nova | 03:11 | |
| *** takashin has quit IRC | 03:14 | |
| *** takashin has joined #openstack-nova | 03:15 | |
| *** itlinux has joined #openstack-nova | 03:18 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo https://review.openstack.org/551802 | 03:18 |
| *** yamamoto has quit IRC | 03:18 | |
| *** tbachman has quit IRC | 03:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 03:20 |
| *** yingjun has joined #openstack-nova | 03:26 | |
| *** takashin has quit IRC | 03:26 | |
| *** janki has joined #openstack-nova | 03:32 | |
| openstackgerrit | Jianle He proposed openstack/nova-specs master: Back up volume-backed-instance https://review.openstack.org/530214 | 03:33 |
| *** hongbin has quit IRC | 03:43 | |
| *** andreas_s has joined #openstack-nova | 03:46 | |
| *** andreas_s has quit IRC | 03:51 | |
| *** dave-mccowan has quit IRC | 03:55 | |
| *** jaosorior has joined #openstack-nova | 03:56 | |
| *** yangyapeng has quit IRC | 03:56 | |
| *** udesale has joined #openstack-nova | 03:57 | |
| *** germs has joined #openstack-nova | 04:01 | |
| *** germs has quit IRC | 04:01 | |
| *** germs has joined #openstack-nova | 04:01 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Fix typo in GET os-instance-actions url. https://review.openstack.org/557143 | 04:02 |
| *** germs has quit IRC | 04:06 | |
| *** stakeda has quit IRC | 04:07 | |
| *** yingjun has quit IRC | 04:08 | |
| *** salv-orlando has joined #openstack-nova | 04:08 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Add host/hostId to instance action events API https://review.openstack.org/557145 | 04:09 |
| *** salv-orlando has quit IRC | 04:13 | |
| *** yamamoto has joined #openstack-nova | 04:19 | |
| *** gongysh has quit IRC | 04:19 | |
| *** gouthamr has quit IRC | 04:22 | |
| *** suresh12 has joined #openstack-nova | 04:24 | |
| *** yamamoto has quit IRC | 04:25 | |
| *** psachin has quit IRC | 04:25 | |
| *** namnh has joined #openstack-nova | 04:27 | |
| *** abhishekk has joined #openstack-nova | 04:29 | |
| *** Eran_Kuris has joined #openstack-nova | 04:35 | |
| *** Spazmotic1 has joined #openstack-nova | 04:38 | |
| *** sdeath has joined #openstack-nova | 04:41 | |
| *** Spaz-Home has quit IRC | 04:42 | |
| *** psachin has joined #openstack-nova | 04:43 | |
| *** links has joined #openstack-nova | 04:46 | |
| *** ratailor has joined #openstack-nova | 04:48 | |
| *** takashin has joined #openstack-nova | 04:48 | |
| *** sdeath has quit IRC | 04:49 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195 | 04:51 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: remove unnecessary short cut in placement https://review.openstack.org/553122 | 04:51 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396 | 04:51 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider nested RPs in get_all_with_shared https://review.openstack.org/556450 | 04:51 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates https://review.openstack.org/556514 | 04:51 |
| *** ratailor_ has joined #openstack-nova | 04:52 | |
| *** Zames has joined #openstack-nova | 04:53 | |
| *** lpetrut has joined #openstack-nova | 04:55 | |
| *** ratailor has quit IRC | 04:57 | |
| *** udesale has quit IRC | 04:58 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 04:58 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | 04:58 |
| *** udesale has joined #openstack-nova | 04:59 | |
| *** Dinesh_Bhor has quit IRC | 05:00 | |
| *** Zames has quit IRC | 05:01 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:06 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 05:08 |
| *** salv-orlando has joined #openstack-nova | 05:09 | |
| *** salv-orlando has quit IRC | 05:09 | |
| *** salv-orlando has joined #openstack-nova | 05:09 | |
| *** yangyapeng has joined #openstack-nova | 05:14 | |
| *** yangyapeng has quit IRC | 05:19 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.openstack.org/541152 | 05:20 |
| *** yamamoto has joined #openstack-nova | 05:21 | |
| *** moshele has joined #openstack-nova | 05:22 | |
| *** lpetrut has quit IRC | 05:26 | |
| *** lpetrut has joined #openstack-nova | 05:27 | |
| *** yamamoto has quit IRC | 05:27 | |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: allow compute nodes to be associated with host agg https://review.openstack.org/526753 | 05:30 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Remove server group sched filter support caching https://review.openstack.org/529200 | 05:30 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: get instance group's aggregate associations https://review.openstack.org/531243 | 05:30 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Support aggregate affinity filters https://review.openstack.org/529201 | 05:30 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Add nodes to group hosts to be checked against aggregation https://review.openstack.org/556761 | 05:30 |
| openstackgerrit | Roman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity. https://review.openstack.org/556762 | 05:30 |
| *** liusheng has quit IRC | 05:35 | |
| *** liusheng has joined #openstack-nova | 05:36 | |
| *** lpetrut has quit IRC | 05:39 | |
| *** takashin has quit IRC | 05:43 | |
| *** tbachman has joined #openstack-nova | 05:44 | |
| *** takashin has joined #openstack-nova | 05:45 | |
| *** yingjun has joined #openstack-nova | 05:45 | |
| *** licanwei has quit IRC | 05:46 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | 05:47 |
| *** lpetrut has joined #openstack-nova | 05:52 | |
| *** suresh12 has quit IRC | 05:53 | |
| *** trinaths has joined #openstack-nova | 05:53 | |
| *** belmoreira has joined #openstack-nova | 05:55 | |
| *** claudiub|2 has joined #openstack-nova | 05:59 | |
| *** gaoyan has joined #openstack-nova | 06:00 | |
| *** kholkina has joined #openstack-nova | 06:01 | |
| *** germs has joined #openstack-nova | 06:02 | |
| *** germs has quit IRC | 06:02 | |
| *** germs has joined #openstack-nova | 06:02 | |
| *** gongysh has joined #openstack-nova | 06:02 | |
| *** luckybird1 has joined #openstack-nova | 06:03 | |
| *** luckybird1 has left #openstack-nova | 06:03 | |
| *** luckybird1 has joined #openstack-nova | 06:03 | |
| *** luckybird1 has left #openstack-nova | 06:05 | |
| *** germs has quit IRC | 06:06 | |
| *** licanwei has joined #openstack-nova | 06:08 | |
| *** suresh12 has joined #openstack-nova | 06:09 | |
| *** swamireddy has quit IRC | 06:11 | |
| *** suresh12 has quit IRC | 06:13 | |
| *** Gorian has quit IRC | 06:14 | |
| *** moshele has quit IRC | 06:14 | |
| *** tbachman has quit IRC | 06:16 | |
| *** voelzmo has joined #openstack-nova | 06:18 | |
| *** Gorian has joined #openstack-nova | 06:21 | |
| *** yamamoto has joined #openstack-nova | 06:23 | |
| *** sahid has joined #openstack-nova | 06:24 | |
| *** claudiub has joined #openstack-nova | 06:26 | |
| *** udesale_ has joined #openstack-nova | 06:28 | |
| *** lajoskatona has joined #openstack-nova | 06:28 | |
| *** yamamoto has quit IRC | 06:28 | |
| *** claudiub|2 has quit IRC | 06:29 | |
| *** jaosorior has quit IRC | 06:29 | |
| *** udesale has quit IRC | 06:30 | |
| *** udesale__ has joined #openstack-nova | 06:30 | |
| *** udesale_ has quit IRC | 06:33 | |
| *** pcaruana has joined #openstack-nova | 06:38 | |
| *** alexchadin has joined #openstack-nova | 06:39 | |
| *** ccamacho has quit IRC | 06:41 | |
| *** yangyapeng has joined #openstack-nova | 06:42 | |
| *** xinliang has quit IRC | 06:52 | |
| *** voelzmo has quit IRC | 06:55 | |
| *** andreas_s has joined #openstack-nova | 06:55 | |
| *** voelzmo has joined #openstack-nova | 06:55 | |
| *** lpetrut has quit IRC | 06:58 | |
| *** ccamacho has joined #openstack-nova | 06:59 | |
| *** yangyapeng has quit IRC | 07:00 | |
| *** yangyapeng has joined #openstack-nova | 07:01 | |
| *** gongysh has quit IRC | 07:04 | |
| *** xinliang has joined #openstack-nova | 07:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 07:06 |
| *** zhurong has quit IRC | 07:08 | |
| *** voelzmo has quit IRC | 07:08 | |
| *** jaosorior has joined #openstack-nova | 07:10 | |
| *** gongysh has joined #openstack-nova | 07:10 | |
| openstackgerrit | do3meli proposed openstack/nova-specs master: Adds resize on shared storage without ssh keys https://review.openstack.org/551927 | 07:10 |
| *** voelzmo has joined #openstack-nova | 07:10 | |
| *** voelzmo has quit IRC | 07:11 | |
| *** rcernin has quit IRC | 07:15 | |
| *** priya__ has joined #openstack-nova | 07:15 | |
| *** voelzmo has joined #openstack-nova | 07:15 | |
| priya__ | Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike? | 07:16 |
| *** pooja_jadhav has quit IRC | 07:21 | |
| *** salv-orlando has quit IRC | 07:22 | |
| *** mdnadeem has joined #openstack-nova | 07:22 | |
| *** pooja_jadhav has joined #openstack-nova | 07:22 | |
| *** salv-orlando has joined #openstack-nova | 07:22 | |
| *** yamamoto has joined #openstack-nova | 07:25 | |
| *** tesseract has joined #openstack-nova | 07:25 | |
| *** alexchadin has quit IRC | 07:26 | |
| *** tssurya has joined #openstack-nova | 07:26 | |
| *** salv-orlando has quit IRC | 07:27 | |
| *** Zames has joined #openstack-nova | 07:29 | |
| *** zz9pzza has joined #openstack-nova | 07:29 | |
| *** yamamoto has quit IRC | 07:30 | |
| *** alexchadin has joined #openstack-nova | 07:31 | |
| *** Zames has quit IRC | 07:32 | |
| priya__ | Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike? | 07:35 |
| *** voelzmo has quit IRC | 07:36 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 07:42 |
| priya__ | Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike? | 07:43 |
| *** damien_r has joined #openstack-nova | 07:43 | |
| *** udesale__ is now known as udesale | 07:43 | |
| *** salv-orlando has joined #openstack-nova | 07:45 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add request_id to instance action notifications https://review.openstack.org/553288 | 07:48 |
| *** belmoreira has quit IRC | 07:49 | |
| *** mdnadeem has quit IRC | 07:51 | |
| Kevin_Zheng | gibi, Hi, thanks for the advice in https://review.openstack.org/553288 , but it still cannot work, so I still mocked the req_id generation call | 07:53 |
| Kevin_Zheng | I put the reason in comment reply | 07:54 |
| *** salv-orlando has quit IRC | 07:54 | |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** salv-orlando has joined #openstack-nova | 07:54 | |
| kaisers1 | mikal: ping (reg. https://review.openstack.org/#/c/554195/7/nova/privsep/libvirt.py comments from Stephen) | 07:56 |
| *** lucas-afk is now known as lucasagomes | 07:56 | |
| *** salv-orlando has quit IRC | 07:59 | |
| bauzas | good morning folks | 07:59 |
| *** AlexeyAbashkin has joined #openstack-nova | 08:00 | |
| *** takashin has left #openstack-nova | 08:01 | |
| bauzas | jianghuaw_: here ? | 08:02 |
| * bauzas was looking at http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#view-gpu-group-object-details-citrix-xenserver-xe | 08:02 | |
| bauzas | jianghuaw_: IIUC, a pGPU group is having multiple types, right? | 08:02 |
| *** germs has joined #openstack-nova | 08:03 | |
| *** germs has quit IRC | 08:03 | |
| *** germs has joined #openstack-nova | 08:03 | |
| jianghuaw_ | bauzas. good morning. | 08:03 |
| jianghuaw_ | yes. | 08:03 |
| *** sar has quit IRC | 08:04 | |
| jianghuaw_ | XenServer supply vGPUs from GPU groups. | 08:04 |
| *** voelzmo has joined #openstack-nova | 08:04 | |
| bauzas | jianghuaw_: okay, so I don't understand your comment in https://review.openstack.org/#/c/557065/1/specs/rocky/approved/vgpu-rocky.rst@47 | 08:04 |
| *** ktibi has joined #openstack-nova | 08:05 | |
| bauzas | how can you know which type to use for that group ? | 08:05 |
| jianghuaw_ | just treat a group in xenserver as a pGPU in kvm. | 08:05 |
| *** belmoreira has joined #openstack-nova | 08:06 | |
| jianghuaw_ | the enabled_vgpu_types listed the enabled vGPU types. | 08:07 |
| jianghuaw_ | we only put one vGPU type from the supported list by GPU group. | 08:07 |
| jianghuaw_ | in the configure option. | 08:07 |
| *** germs has quit IRC | 08:08 | |
| jianghuaw_ | If there are multiple types of PGPUs, there will be multiple GPU group. | 08:08 |
| *** derekh has joined #openstack-nova | 08:08 | |
| jianghuaw_ | e.g. PGPU type 1 => grp1 (support type1-1, type1-2); pGPU type 2 => grp 2 (support type2-1, type2-2); | 08:09 |
| jianghuaw_ | then we set enabled_vgpu_types = type1-1, type2-1 | 08:10 |
| jianghuaw_ | It's able to ensure each group will expose one type of VGPUs. | 08:10 |
| bauzas | sec | 08:10 |
| *** mdnadeem has joined #openstack-nova | 08:11 | |
| sahid | bauzas: i think we have an agreement here, if you can take a moment for https://review.openstack.org/#/c/511188/ | 08:12 |
| bauzas | jianghuaw_: hah, that's because pGPU groups in Xen are mutually exclusive | 08:13 |
| bauzas | ? | 08:13 |
| bauzas | ie. you can't have both two groups sharing the same type ? | 08:13 |
| bauzas | sahid: sure, it's in my radar, like I said ;) | 08:14 |
| bauzas | sahid: I have to follow up on some specs :) | 08:14 |
| sahid | bauzas: cool thanks | 08:14 |
| *** yingjun has quit IRC | 08:15 | |
| jianghuaw_ | bauzas, yes. | 08:16 |
| *** yingjun has joined #openstack-nova | 08:16 | |
| bauzas | jianghuaw_: okay, so what if the operator says enabled_vgpu_types = type1-1, type1-2 ? | 08:16 |
| bauzas | jianghuaw_: taking the example of http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#view-gpu-group-object-details-citrix-xenserver-xe | 08:17 |
| jianghuaw_ | Then follow the behavior as Queens, choose the first type supported by the group. | 08:17 |
| bauzas | jianghuaw_: but then it won't use the second type for a second pGPU in the same group ? | 08:18 |
| jianghuaw_ | yes. | 08:18 |
| jianghuaw_ | That's expected. the type in group must be predictable. | 08:20 |
| jianghuaw_ | Otherwise it's not able to calculate the inventories' total. | 08:20 |
| *** priteau has joined #openstack-nova | 08:20 | |
| bauzas | jianghuaw_: but then it's unfortunate for the operator | 08:21 |
| bauzas | because they can do something like http://docs.nvidia.com/grid/5.0/grid-vgpu-user-guide/index.html#homogeneous-grid-vgpus | 08:21 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Add host/hostId to instance action events API https://review.openstack.org/557145 | 08:21 |
| bauzas | jianghuaw_: (first valid config) | 08:21 |
| *** voelzmo has quit IRC | 08:22 | |
| *** voelzmo has joined #openstack-nova | 08:22 | |
| *** mdbooth has joined #openstack-nova | 08:22 | |
| *** ccamacho has quit IRC | 08:23 | |
| *** voelzmo has quit IRC | 08:23 | |
| *** gongysh has quit IRC | 08:23 | |
| *** voelzmo has joined #openstack-nova | 08:23 | |
| *** voelzmo has quit IRC | 08:24 | |
| *** voelzmo has joined #openstack-nova | 08:24 | |
| *** rcernin has joined #openstack-nova | 08:24 | |
| *** voelzmo has quit IRC | 08:24 | |
| * gibi reads back | 08:25 | |
| *** voelzmo has joined #openstack-nova | 08:25 | |
| *** voelzmo has quit IRC | 08:25 | |
| *** voelzmo has joined #openstack-nova | 08:25 | |
| *** voelzmo has quit IRC | 08:26 | |
| *** yamamoto has joined #openstack-nova | 08:26 | |
| *** tianhui has quit IRC | 08:29 | |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: Fix spelling mistake of HTTPNotFound exception https://review.openstack.org/557187 | 08:29 |
| *** tianhui has joined #openstack-nova | 08:29 | |
| *** yamamoto has quit IRC | 08:30 | |
| jianghuaw_ | bauzas, Do you mean we can't create different type vGPUs on different pgpu belong to a group? | 08:32 |
| bauzas | jianghuaw_: a group is multiple pGPUs, right? | 08:33 |
| jianghuaw_ | yes. | 08:33 |
| jianghuaw_ | with same type | 08:33 |
| bauzas | jianghuaw_: so, you can have one type per pGPU | 08:33 |
| bauzas | jianghuaw_: no, not the same type, you just said there are multiple types per group | 08:33 |
| *** oanson has quit IRC | 08:34 | |
| jianghuaw_ | I mean a group can be multiple PGPUs which belong to the same PGPU type e.g. all are "Tesla M60" | 08:34 |
| *** oanson has joined #openstack-nova | 08:36 | |
| jianghuaw_ | Each PGPU can support multiple vGPU types; as we make group as the unit to expose vGPUs, we have to restrict each group having only one vgpu type enabled. | 08:37 |
| *** lpetrut has joined #openstack-nova | 08:40 | |
| jianghuaw_ | bauzas, with the new configure option, we can't enable multiple types in each group either. | 08:41 |
| *** rcernin has quit IRC | 08:42 | |
| *** hoangcx has quit IRC | 08:42 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 08:43 |
| *** ccamacho has joined #openstack-nova | 08:46 | |
| *** lpetrut has quit IRC | 08:47 | |
| *** hoangcx has joined #openstack-nova | 08:47 | |
| *** lpetrut has joined #openstack-nova | 08:47 | |
| *** sdague has joined #openstack-nova | 08:55 | |
| *** ccamacho has quit IRC | 08:56 | |
| *** alexchadin has quit IRC | 08:57 | |
| *** udesale has quit IRC | 08:58 | |
| *** alexchadin has joined #openstack-nova | 08:58 | |
| kashyap | sean-k-mooney[m]: ^ Can you re-ACK it, please | 09:02 |
| kashyap | (Since I moved the 'choices' stuff into config, I just removed the uppercase/lowercase check in driver.py; small mechanical change.) | 09:02 |
| *** udesale has joined #openstack-nova | 09:05 | |
| *** bhujay has joined #openstack-nova | 09:10 | |
| *** cdent has joined #openstack-nova | 09:11 | |
| *** ragiman has joined #openstack-nova | 09:12 | |
| kashyap | imacdonn: stvnoyes1 Follow-up from last night, please update the versions of libvirt, QEMU, libguestfs for Oracle Linux here: https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix | 09:16 |
| *** maciejjozefczyk has quit IRC | 09:17 | |
| openstackgerrit | garyk proposed openstack/nova master: VMware: add log message for VIF info details https://review.openstack.org/557256 | 09:17 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 09:18 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:18 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 09:18 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 09:18 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 09:18 |
| bauzas | jianghuaw_: anyway, I don't want to rathole on Xen specifics | 09:25 |
| bauzas | jianghuaw_: if you feel you don't need that spec, all fair, I'll make that conf opt libvirt-specific | 09:25 |
| *** yamamoto has joined #openstack-nova | 09:27 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API https://review.openstack.org/511825 | 09:28 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 09:28 |
| *** Spazmotic1 has quit IRC | 09:30 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rescue https://review.openstack.org/532410 | 09:31 |
| *** yingjun has quit IRC | 09:32 | |
| jianghuaw_ | bauzas, thanks. | 09:32 |
| *** yamamoto has quit IRC | 09:32 | |
| *** alexchadin has quit IRC | 09:34 | |
| *** swamireddy has joined #openstack-nova | 09:34 | |
| *** yingjun has joined #openstack-nova | 09:36 | |
| *** itlinux has quit IRC | 09:36 | |
| *** Dinesh_Bhor has quit IRC | 09:36 | |
| *** _ix has joined #openstack-nova | 09:37 | |
| *** lpetrut_ has joined #openstack-nova | 09:41 | |
| *** trinaths has quit IRC | 09:44 | |
| *** dtantsur|afk is now known as dtantsur | 09:46 | |
| *** chyka has joined #openstack-nova | 09:48 | |
| *** yingjun has quit IRC | 09:50 | |
| *** hoangcx has quit IRC | 09:51 | |
| *** chyka has quit IRC | 09:52 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API https://review.openstack.org/511825 | 09:54 |
| *** hoangcx has joined #openstack-nova | 09:56 | |
| jianghuaw_ | bauzas, In the queens vGPU spec, we have display heads as consumable resource. Now we will make it as a trait. | 09:56 |
| openstackgerrit | jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152 | 09:56 |
| *** sree has quit IRC | 09:56 | |
| jianghuaw_ | Should we just update the queens spec or should make a new spec in Rocky? | 09:57 |
| *** sree has joined #openstack-nova | 09:57 | |
| *** salv-orlando has joined #openstack-nova | 09:58 | |
| *** liverpooler has quit IRC | 09:59 | |
| *** ratailor_ is now known as rtailor | 10:00 | |
| *** sree has quit IRC | 10:02 | |
| *** germs has joined #openstack-nova | 10:03 | |
| *** hoangcx has quit IRC | 10:03 | |
| *** namnh has quit IRC | 10:03 | |
| *** jichen has quit IRC | 10:06 | |
| *** germs has quit IRC | 10:08 | |
| *** suresh12 has joined #openstack-nova | 10:09 | |
| *** hoangcx has joined #openstack-nova | 10:10 | |
| *** cdent has quit IRC | 10:12 | |
| *** suresh12 has quit IRC | 10:14 | |
| *** sambetts|afk is now known as sambetts | 10:18 | |
| *** yamamoto has joined #openstack-nova | 10:29 | |
| *** yamamoto has quit IRC | 10:34 | |
| *** alexchadin has joined #openstack-nova | 10:35 | |
| *** gaoyan has quit IRC | 10:36 | |
| *** moshele has joined #openstack-nova | 10:36 | |
| *** sahid has quit IRC | 10:39 | |
| *** rmart04 has joined #openstack-nova | 10:42 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 10:43 |
| *** abhishekk has quit IRC | 10:45 | |
| *** udesale_ has joined #openstack-nova | 10:46 | |
| *** Zames has joined #openstack-nova | 10:46 | |
| *** udesale has quit IRC | 10:49 | |
| *** Zames has quit IRC | 10:49 | |
| *** swamireddy has quit IRC | 10:51 | |
| *** tiendc has quit IRC | 10:52 | |
| *** udesale_ has quit IRC | 10:52 | |
| *** salv-orl_ has joined #openstack-nova | 10:53 | |
| *** zhurong has joined #openstack-nova | 10:55 | |
| *** salv-orlando has quit IRC | 10:56 | |
| *** gyankum has quit IRC | 10:56 | |
| *** salv-orlando has joined #openstack-nova | 10:58 | |
| *** lajoskatona has quit IRC | 10:58 | |
| *** salv-orl_ has quit IRC | 10:58 | |
| *** cdent has joined #openstack-nova | 11:01 | |
| *** Conqueror has joined #openstack-nova | 11:03 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 11:03 |
| *** abalutoiu_ has quit IRC | 11:03 | |
| *** mdnadeem_ has joined #openstack-nova | 11:03 | |
| *** ratailor_ has joined #openstack-nova | 11:03 | |
| *** rtailor has quit IRC | 11:04 | |
| *** mdnadeem has quit IRC | 11:04 | |
| *** links has quit IRC | 11:04 | |
| *** salv-orlando has quit IRC | 11:05 | |
| *** links has joined #openstack-nova | 11:05 | |
| *** ratailor__ has joined #openstack-nova | 11:05 | |
| *** salv-orlando has joined #openstack-nova | 11:06 | |
| *** abalutoiu has joined #openstack-nova | 11:06 | |
| *** shaohe_feng has quit IRC | 11:08 | |
| *** mdnadeem_ has quit IRC | 11:08 | |
| *** ratailor_ has quit IRC | 11:08 | |
| *** dave-mccowan has joined #openstack-nova | 11:09 | |
| *** yingjun has joined #openstack-nova | 11:09 | |
| *** shaohe_feng has joined #openstack-nova | 11:13 | |
| *** sree has joined #openstack-nova | 11:14 | |
| *** READ10 has quit IRC | 11:17 | |
| *** lajoskatona has joined #openstack-nova | 11:19 | |
| *** sree has quit IRC | 11:19 | |
| *** Zames has joined #openstack-nova | 11:21 | |
| *** mdnadeem_ has joined #openstack-nova | 11:21 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 11:22 |
| *** tuanla____ has quit IRC | 11:23 | |
| *** Zames has quit IRC | 11:24 | |
| *** tianhui has quit IRC | 11:24 | |
| *** tianhui has joined #openstack-nova | 11:25 | |
| *** shaohe_feng has quit IRC | 11:25 | |
| *** sree has joined #openstack-nova | 11:29 | |
| *** sahid has joined #openstack-nova | 11:30 | |
| *** yamamoto has joined #openstack-nova | 11:31 | |
| *** dtantsur is now known as dtantsur|brb | 11:31 | |
| *** sree_ has joined #openstack-nova | 11:32 | |
| *** sree_ is now known as Guest40822 | 11:33 | |
| *** Zames has joined #openstack-nova | 11:35 | |
| *** yamamoto has quit IRC | 11:35 | |
| *** mvk has quit IRC | 11:35 | |
| *** sree has quit IRC | 11:35 | |
| *** salv-orl_ has joined #openstack-nova | 11:36 | |
| *** avolkov has joined #openstack-nova | 11:37 | |
| *** Zames has quit IRC | 11:37 | |
| priya__ | Hi team, my code breaks with "flavor not found" issue. It is seen that instance_types table is empty. The same code works in Mitaka. Is there any issue/upgrade for pike? | 11:38 |
| *** salv-orlando has quit IRC | 11:41 | |
| *** moshele has quit IRC | 11:47 | |
| *** efried has quit IRC | 11:47 | |
| *** efried has joined #openstack-nova | 11:48 | |
| *** ktibi has quit IRC | 11:54 | |
| Kevin_Zheng | priya__ seems related with cells v2 structure, | 11:55 |
| *** lucasagomes is now known as lucas-hungry | 11:55 | |
| Kevin_Zheng | pike reads api_db for flavor, mitaka reads nova db, so it will work with mitaka but cannot work with pike | 11:58 |
| Kevin_Zheng | should perform data migration | 11:58 |
| priya__ | Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) is the call which breaks. how do i perform data migration? | 12:00 |
| *** andreas_s has quit IRC | 12:01 | |
| Kevin_Zheng | priya__ how did you install your nova? | 12:02 |
| Kevin_Zheng | with source code or packages? | 12:02 |
| *** udesale has joined #openstack-nova | 12:02 | |
| *** andreas_s_ has joined #openstack-nova | 12:02 | |
| Kevin_Zheng | or devstack | 12:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Make everything work with Python 3 https://review.openstack.org/556894 | 12:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Speed things up and document them https://review.openstack.org/534382 | 12:03 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | 12:03 |
| Kevin_Zheng | another thing is that the default flavors are removed after mitaka | 12:03 |
| Kevin_Zheng | so you have to create your own flavor before use | 12:03 |
| *** andreas__ has joined #openstack-nova | 12:03 | |
| *** lajoskatona has quit IRC | 12:03 | |
| *** germs has joined #openstack-nova | 12:04 | |
| *** germs has quit IRC | 12:04 | |
| *** germs has joined #openstack-nova | 12:04 | |
| *** cdent has quit IRC | 12:05 | |
| *** edmondsw has joined #openstack-nova | 12:06 | |
| *** sapd__ has joined #openstack-nova | 12:06 | |
| *** andreas_s_ has quit IRC | 12:07 | |
| *** ragiman has quit IRC | 12:08 | |
| *** germs has quit IRC | 12:08 | |
| *** sapd_ has quit IRC | 12:09 | |
| *** kolesovdv has joined #openstack-nova | 12:10 | |
| *** ragiman has joined #openstack-nova | 12:11 | |
| *** abalutoiu_ has joined #openstack-nova | 12:11 | |
| *** abalutoiu has quit IRC | 12:15 | |
| *** lpetrut_ has quit IRC | 12:15 | |
| *** sapd__ has quit IRC | 12:17 | |
| *** sapd_ has joined #openstack-nova | 12:17 | |
| *** moshele has joined #openstack-nova | 12:18 | |
| *** odyssey4me has quit IRC | 12:22 | |
| *** odyssey4me has joined #openstack-nova | 12:22 | |
| *** yamamoto has joined #openstack-nova | 12:22 | |
| *** moshele has quit IRC | 12:23 | |
| priya__ | Kevin_Zheng through package | 12:25 |
| Kevin_Zheng | Then I guess you should create your own flavor before use | 12:25 |
| Kevin_Zheng | because there will be no default flavors after mitaka | 12:26 |
| *** sapd_ has quit IRC | 12:27 | |
| *** sapd_ has joined #openstack-nova | 12:27 | |
| priya__ | Kevin_Zheng yes i have created a flavor, and that shows up in nova_api,flavors table. But it is not updated in instance_types. | 12:28 |
| priya__ | Kevin_Zheng flavor = db.flavor_get(context, inst_type_id) refers to instance_types table and my code breaks here..i dont understand why | 12:28 |
| Kevin_Zheng | where is this code? | 12:30 |
| priya__ | this is my custom code | 12:31 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 12:31 |
| kashyap | alex_xu_: Thanks for the eagle eyes; I think '20' is the lucky number :-) | 12:31 |
| Kevin_Zheng | OK then you access the wrong db | 12:31 |
| Kevin_Zheng | because in Pike the flavor is not in that table anymore | 12:31 |
| Kevin_Zheng | it moved to flavors in api_db | 12:32 |
| *** sapd_ has quit IRC | 12:32 | |
| *** sapd_ has joined #openstack-nova | 12:32 | |
| Kevin_Zheng | you should query that | 12:32 |
| *** _ix has quit IRC | 12:32 | |
| alex_xu_ | kashyap: hah | 12:32 |
| priya__ | Kevin_Zheng how do i change the database to access? because db.flavor_get is in nova api code | 12:33 |
| kashyap | alex_xu_: Thank you! | 12:33 |
| Kevin_Zheng | but you said it is your cutom code? | 12:33 |
| *** zhurong has quit IRC | 12:34 | |
| *** abalutoiu__ has joined #openstack-nova | 12:34 | |
| *** andreas__ has quit IRC | 12:35 | |
| priya__ | Kevin_Zheng The call is in my custom code, howevr the db.flavor_get method def refers to nova/db/api.py(1579)flavor_get() | 12:35 |
| *** andreas_s has joined #openstack-nova | 12:35 | |
| *** pchavva has joined #openstack-nova | 12:36 | |
| *** lajoskatona has joined #openstack-nova | 12:36 | |
| Kevin_Zheng | which nova api did your code call? | 12:37 |
| *** andreas_s has quit IRC | 12:37 | |
| *** _ix has joined #openstack-nova | 12:38 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 12:38 |
| *** abalutoiu_ has quit IRC | 12:39 | |
| *** andreas_s has joined #openstack-nova | 12:39 | |
| *** jackie-truong has joined #openstack-nova | 12:39 | |
| *** cdent has joined #openstack-nova | 12:40 | |
| Kevin_Zheng | priya__ sorry I have to go | 12:40 |
| priya__ | Kevin_Zheng thank you for the help. | 12:41 |
| priya__ | Kevin_Zheng i have used the db api | 12:41 |
| gibi | stephenfin: I left some questions in the numa aware switches spec https://review.openstack.org/#/c/541290 | 12:41 |
| *** _ix has quit IRC | 12:47 | |
| *** MarkMielke has joined #openstack-nova | 12:48 | |
| cdent | jaypipes, stephenfin: quick test coverage win in placement one +2 already: https://review.openstack.org/#/c/513264/ | 12:50 |
| jaypipes | cdent: cool. | 12:50 |
| *** hshiina is now known as hshiina|afk | 12:51 | |
| *** sapd__ has joined #openstack-nova | 12:52 | |
| cdent | thanks jaypipes | 12:52 |
| *** sapd_ has quit IRC | 12:52 | |
| *** lucas-hungry is now known as lucasagomes | 12:55 | |
| *** salv-orlando has joined #openstack-nova | 12:56 | |
| *** salv-or__ has joined #openstack-nova | 12:57 | |
| efried | mikal: I do not accept your admonishment. I may have been mistaken or talked out of the more substantive issues, but taken at face value, those would have justified further work on the patch. | 12:58 |
| *** salv-orl_ has quit IRC | 12:58 | |
| *** mvk has joined #openstack-nova | 12:58 | |
| efried | mikal: Thank you for the updates. Hugs! | 12:58 |
| jaypipes | efried: so... | 13:00 |
| jaypipes | efried: on https://review.openstack.org/#/c/557187/ I'm torn | 13:01 |
| jaypipes | efried: we don't have a good set of unit tests for the placement HTTP handlers | 13:01 |
| cdent | (on purpose) | 13:01 |
| *** salv-orlando has quit IRC | 13:02 | |
| jaypipes | efried: and asking Johannes to create one from scratch is a bit much for a one-byte patch | 13:02 |
| jaypipes | efried: I would just as much say let's merge the thing | 13:02 |
| *** salv-or__ has quit IRC | 13:02 | |
| efried | That's fair, I didn't realize we didn't have a framework in place that would make it trivial (I didn't look). | 13:02 |
| jaypipes | efried: yeah, we don't have unit tests for this stuff really. | 13:03 |
| *** salv-orlando has joined #openstack-nova | 13:03 | |
| jaypipes | efried: that said, we could ask for a gabbit to be added that would force this code path | 13:03 |
| cdent | Just so it is clear, the lack of unit tests is supposed to reflect that anything that ought to have a unit test is in a different file | 13:03 |
| jaypipes | I think.. | 13:03 |
| cdent | jaypipes: it won't work without multiple processes | 13:03 |
| efried | But in any case, not in this patch. | 13:04 |
| jaypipes | cdent: right. | 13:04 |
| cdent | delicately controlled multiple processes | 13:04 |
| efried | jaypipes, cdent: I flipped to +1. | 13:04 |
| efried | thanks for setting me straight there. | 13:04 |
| *** lbragstad has joined #openstack-nova | 13:04 | |
| * cdent adds something to his to do list for the placement contrib docs | 13:04 | |
| jaypipes | efried: like I said, I'm a bit torn, but I think I land on the "just merge this" side. | 13:05 |
| efried | jaypipes: I'm fine with that, especially given it's a clearly correct fix to a clear mistake in the code. | 13:05 |
| efried | If writing the test were trivial, that would be one thing. | 13:05 |
| *** mriedem has joined #openstack-nova | 13:06 | |
| jaypipes | efried: right, agreed. | 13:07 |
| *** salv-orlando has quit IRC | 13:08 | |
| *** _ix has joined #openstack-nova | 13:09 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 13:09 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 13:10 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | 13:10 |
| *** lyan has joined #openstack-nova | 13:12 | |
| *** lyan is now known as Guest33320 | 13:13 | |
| *** Zames has joined #openstack-nova | 13:13 | |
| *** _ix has quit IRC | 13:14 | |
| *** eharney has joined #openstack-nova | 13:14 | |
| *** dtantsur|brb is now known as dtantsur | 13:15 | |
| *** Zames has quit IRC | 13:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 13:17 |
| *** gouthamr has joined #openstack-nova | 13:19 | |
| efried | jaypipes, edleafe: turns out we're not restricting characters on RP names. I just created RPs with names chr(0)-chr(127). Do we have a SQL injection hole, or is sqla providing the necessary escaping security blanket so we don't have to worry about it? | 13:25 |
| *** Guest40822 has quit IRC | 13:27 | |
| *** sree has joined #openstack-nova | 13:28 | |
| jaypipes | efried: sqlalchemy (and in fact the Python DB API) provides the protection against SQL injection attacks. | 13:29 |
| *** psachin has quit IRC | 13:30 | |
| mriedem | dansmith: regarding that [database]/connection setting in nova.conf for the api / controller services, i just noticed that the install guide for the controller tells you to set the [database]/connection to the 'nova' db, rather than nova_cell0 https://docs.openstack.org/nova/latest/install/controller-install-ubuntu.html#install-and-configure-components | 13:31 |
| mriedem | which, if you're not doing 'superconductor' mode, isn't a big deal | 13:32 |
| dansmith | mriedem: probably from pre-cells switchover though | 13:32 |
| dansmith | like we never updated it | 13:32 |
| *** udesale has quit IRC | 13:32 | |
| *** sree has quit IRC | 13:33 | |
| *** olivenwk has joined #openstack-nova | 13:33 | |
| mriedem | yeah, https://docs.openstack.org/nova/latest/user/cells.html#first-time-setup says, "If your databases are on separate hosts then you should specify --database_connection or make certain that the nova.conf being used has the [database]/connection value pointing to the same user/password/host that will work for the cell0 database." | 13:33 |
| *** kolesovdv has quit IRC | 13:34 | |
| mriedem | with the current install guide instructions, i don't think cell0 db sync ever runs | 13:34 |
| dansmith | ack, we should probably audit all that stuff in modern times | 13:35 |
| *** yangyapeng has quit IRC | 13:35 | |
| *** alexchadin has quit IRC | 13:37 | |
| mriedem | oh nvm, db sync defaults to find the cell0 mapping and sync it | 13:37 |
| *** zhaochao has joined #openstack-nova | 13:37 | |
| olivenwk | Hello, I try to add aliases in nova. Why alias ={ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" } followed by alias ={ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" } works and not alias=[{ "vendor_id":"1002", "product_id":"6938", "device_type":"type-PCI", "name":"R9-380X" },{ "vendor_id":"10de", "product_id":"1b06", "device_type":"type-PCI", "name":"GTX1080Ti" }] | 13:37 |
| olivenwk | but if I write my alias in the array fashion ONLY on the compute node it works | 13:38 |
| olivenwk | seems to be controller node related, any ideas? | 13:38 |
| *** alexchadin has joined #openstack-nova | 13:39 | |
| *** damien_r has quit IRC | 13:40 | |
| *** liverpooler has joined #openstack-nova | 13:41 | |
| *** damien_r has joined #openstack-nova | 13:42 | |
| *** damien_r has quit IRC | 13:43 | |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova master: Add `hide_hypervisor_id` flavor extra_spec https://review.openstack.org/555861 | 13:45 |
| *** tbachman has joined #openstack-nova | 13:46 | |
| *** cdent has quit IRC | 13:47 | |
| *** amodi has joined #openstack-nova | 13:48 | |
| *** damien_r has joined #openstack-nova | 13:49 | |
| *** burt has joined #openstack-nova | 13:49 | |
| *** tbachman_ has joined #openstack-nova | 13:49 | |
| *** tbachman has quit IRC | 13:51 | |
| *** tbachman_ is now known as tbachman | 13:51 | |
| *** damien_r has quit IRC | 13:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 13:52 |
| gibi | jaypipes: I left two questions in the nested a_c spec https://review.openstack.org/#/c/556873/ | 13:52 |
| *** salv-orlando has joined #openstack-nova | 13:53 | |
| *** _ix has joined #openstack-nova | 13:53 | |
| *** Spazmotic has joined #openstack-nova | 13:54 | |
| *** awaugama has joined #openstack-nova | 13:54 | |
| mriedem | eric-young: https://review.openstack.org/#/c/554679/ is now released in os-brick 2.4.0, you should push a change to the openstack/requirements repo to bump the minimum required version to 2.4.0 in global-requirements | 13:55 |
| *** cdent has joined #openstack-nova | 13:55 | |
| mriedem | and then make https://review.openstack.org/#/c/554679/ depend on it | 13:55 |
| *** efried has quit IRC | 13:56 | |
| *** efried has joined #openstack-nova | 13:56 | |
| *** damien_r has joined #openstack-nova | 13:56 | |
| *** ratailor_ has joined #openstack-nova | 13:58 | |
| dansmith | hmm, someone removed the placement-req series from the runways etherpad queue | 13:58 |
| dansmith | oh, nevermind, it got moved down apparently | 13:59 |
| mriedem | heh, the glory of etherpads | 14:00 |
| mriedem | pre-emptible runways | 14:00 |
| mriedem | so uh, do we wait for melwitt to move things from the queue into the actual slots? | 14:00 |
| *** yassine has quit IRC | 14:00 | |
| dansmith | yeah I went to look because I expected she moved things into the slots after yesterday | 14:01 |
| dansmith | we have a meeting at 8 so she should be around then-ish I think | 14:01 |
| *** ratailor__ has quit IRC | 14:01 | |
| mriedem | there is a procedure on L24 so i guess anyone could just follow that | 14:01 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 14:02 |
| *** yassine has joined #openstack-nova | 14:02 | |
| bauzas | do we really need slots for priority series ? | 14:02 |
| mriedem | efried: please confirm your availability for the update_provider_tree bp for runways slot numero uno for the next dos weeks | 14:02 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 14:02 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 14:02 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | 14:02 |
| efried | cdent: edleafe: Any idea how I can finagle my string so that json encoding doesn't bounce with UnicodeDecodeError for characters >127? | 14:02 |
| efried | mriedem: Confirmed. | 14:03 |
| bauzas | I mean, I can review those priority series without needing a slot | 14:03 |
| efried | mriedem: Confirmado? | 14:03 |
| *** jackie-truong has quit IRC | 14:03 | |
| bauzas | because I know about the implementations, and I don't need to understand it | 14:03 |
| cdent | efried: I'm non in-conext. Have you got code to point at? | 14:04 |
| mriedem | ANNOUNCEMENT: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/update-provider-tree is now in runway slow #1 | 14:04 |
| efried | mriedem: Nice freudian slip there. | 14:04 |
| *** damien_r has quit IRC | 14:04 | |
| mriedem | ha | 14:04 |
| mriedem | oh well, it's not recorded | 14:04 |
| mriedem | i mean, it is | 14:04 |
| mriedem | but not via bot | 14:04 |
| mriedem | is kashyap going to write a runway bot? | 14:04 |
| * kashyap hides | 14:05 | |
| mriedem | that would actually be kind of nice...to post to a wiki rather than etherpad | 14:05 |
| *** udesale has joined #openstack-nova | 14:05 | |
| dansmith | we could tweak the channel topic | 14:05 |
| *** germs has joined #openstack-nova | 14:05 | |
| *** germs has quit IRC | 14:05 | |
| *** germs has joined #openstack-nova | 14:05 | |
| *** udesale has quit IRC | 14:05 | |
| dansmith | I dunno that release schedule is that necessary as it's easily google-able | 14:05 |
| *** dklyle has joined #openstack-nova | 14:05 | |
| *** david-lyle has quit IRC | 14:05 | |
| *** udesale has joined #openstack-nova | 14:05 | |
| efried | cdent: In writing https://review.openstack.org/#/c/556628/ I was brought to realize we're not restricting characters for RP names. I tried chr(0)-chr(127) and they all worked fine. But when I start trying chr(128)-chr(256) I get UnicodeDecodeError from the ksa session json encoder. | 14:05 |
| *** esberglu has joined #openstack-nova | 14:05 | |
| cdent | 128-256 is not valid unicode | 14:06 |
| mriedem | dansmith: or just link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking in the channel topic and link the runways etherpad from the top of that | 14:06 |
| mriedem | or a gerrit dashboard link, | 14:06 |
| mriedem | where mel controls the starred patches per runway that go into said dashboard | 14:06 |
| mriedem | or something | 14:06 |
| *** hongbin has joined #openstack-nova | 14:06 | |
| dansmith | well, it'd just be nice to see names as reminders instead of the same url week to week, is what I meant | 14:07 |
| dansmith | (hence the irc announcement part of that procedure) | 14:07 |
| *** dklyle has quit IRC | 14:07 | |
| mriedem | so like, current runways: update-provider-tree, placement-req, foobars | 14:07 |
| dansmith | cha | 14:07 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Functional test for regression bug #1713783 https://review.openstack.org/505160 | 14:07 |
| openstack | bug 1713783 in OpenStack Compute (nova) ocata "After failed evacuation the recovered source compute tries to delete the instance" [High,In progress] https://launchpad.net/bugs/1713783 - Assigned to Balazs Gibizer (balazs-gibizer) | 14:07 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Set error state after failed evacuation https://review.openstack.org/518733 | 14:07 |
| *** dklyle has joined #openstack-nova | 14:07 | |
| *** damien_r has joined #openstack-nova | 14:08 | |
| mriedem | wfm | 14:08 |
| *** ChanServ sets mode: +o dansmith | 14:08 | |
| *** hemna_ has joined #openstack-nova | 14:08 | |
| efried | cdent: So JSON strings have to be unicode I take it. | 14:08 |
| *** dansmith changes topic to "Current runways: update-provider-tree / <EMPTY> / <EMPTY> -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 14:08 | |
| mriedem | so i guess next in line is privsep | 14:08 |
| cdent | efried: it depends on which layer you're at, over the wire JSON is supposed to always be utf-8 encode unicode | 14:09 |
| *** dansmith changes topic to "Current runways: update-provider-tree / hurrah-for-privsep-again / <EMPTY> -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 14:09 | |
| *** germs has quit IRC | 14:09 | |
| *** jbernard has quit IRC | 14:09 | |
| mriedem | mikal: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/hurrah-for-privsep-again reviews for the next 2 weeks | 14:09 |
| *** jbernard has joined #openstack-nova | 14:10 | |
| *** jackie-truong has joined #openstack-nova | 14:10 | |
| *** damien_r has quit IRC | 14:10 | |
| mriedem | likely not to hear about that for several hours | 14:10 |
| dansmith | mriedem: heh, that answer won't come for 10 hours | 14:10 |
| dansmith | yeah | 14:10 |
| *** yangyapeng has joined #openstack-nova | 14:10 | |
| cdent | efried: once you see the results in python, it should be unicode strings (or numbers) | 14:10 |
| dansmith | since the queue is fresh I tend to think we can assume in this case, but... | 14:10 |
| mriedem | dansmith: please confirm your availability for https://blueprints.launchpad.net/nova/+spec/placement-req-filter reviews for the next 2 weeks | 14:11 |
| *** ratailor_ has quit IRC | 14:11 | |
| dansmith | mriedem: I will be available with the exception of this coming friday which is a company holiday, but I don't anticipate that being significant | 14:11 |
| mriedem | EASTER! | 14:11 |
| efried | dansmith, mriedem: FWIW mikal has been responsive to those patches within a couple days up to this point. And with I think one or two exceptions, they've all been scrubbed to multiple-+1-ness at this point. | 14:11 |
| dansmith | efried: aye | 14:12 |
| mriedem | CONFIRMED | 14:12 |
| edleafe | Heh - "slow" [t2LP0] | 14:12 |
| *** dansmith changes topic to "Current runways: update-provider-tree / hurrah-for-privsep-again / placement-req-filter -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 14:12 | |
| edleafe | Lemme fix that [t 2LP0] | 14:12 |
| purplerbot | <mriedem> ANNOUNCEMENT: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/update-provider-tree is now in runway slow #1 [2018-03-28 14:04:13.785517] [n 2LP0] | 14:12 |
| * mriedem goes to review non-runway stuff | 14:12 | |
| dansmith | heh | 14:12 |
| efried | dansmith: I happened to notice that mikal (whether on purpose or not) changed the commit message tags from 'hurrah-for-privsep-again' to 'hurrah-for-privsep' in the last spin. | 14:13 |
| efried | I didn't go and check what the bp is actually called. | 14:13 |
| dansmith | efried: that's likely git-review | 14:13 |
| efried | it was in the commit message, not the topic | 14:13 |
| dansmith | oh | 14:15 |
| *** mchlumsky has joined #openstack-nova | 14:17 | |
| bhagyashris | mriedem, alex_xu_: Hi, Thanks for review! Addressed review comments on spec https://review.openstack.org/#/c/511825/ request to re-visit | 14:18 |
| *** mlavalle has joined #openstack-nova | 14:18 | |
| mriedem | ok | 14:18 |
| kashyap | 20 is the lucky number, if anyone looking for a trivial feature to +2 (it already has +2 from Alex): https://review.openstack.org/#/c/534384/ | 14:21 |
| kashyap | Zuul has to bless & kiss it, though | 14:23 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348 | 14:23 |
| *** alexchadin has quit IRC | 14:24 | |
| bauzas | efried: I don't know if it's you that wrote https://etherpad.openstack.org/p/nova-runways-rocky L39 but I think virt driver changes using nested resources shoukdn't be using that slot | 14:25 |
| mriedem | the placement aggregates api confuses me every time i look at it | 14:25 |
| efried | bauzas: It was, and I agree they shouldn't. | 14:25 |
| efried | mriedem: How so? Maybe we can fix the docs. | 14:25 |
| bauzas | efried: because those need specific domain expertise, and I think it's a separate runway slot then | 14:25 |
| efried | bauzas: They're also a separate piece of work, *using* the upt bp, not part of its implementation. | 14:26 |
| mriedem | efried: i think it's just because there is no POST for aggregates | 14:26 |
| *** damien_r has joined #openstack-nova | 14:26 | |
| mriedem | but i know that's intentional | 14:26 |
| efried | mriedem: Yeah, they get created (but not deleted!) dynamically. | 14:26 |
| *** jogo has quit IRC | 14:26 | |
| mriedem | PUT /resource_providers/{uuid}/aggregates means to just associate a resource provider with an aggregate uuid which may or may not exist | 14:26 |
| efried | cdent, mriedem: by the same token, I think https://review.openstack.org/#/c/556669/ is not technically part of bp/placement-aggregate-generation, in which case that bp can be marked as implemented. | 14:27 |
| efried | bauzas: ^ | 14:27 |
| *** r-daneel has joined #openstack-nova | 14:28 | |
| *** ralonsoh has quit IRC | 14:29 | |
| efried | mriedem: disregard, I see it already is. | 14:30 |
| * efried doesn't know how to read blueprints. | 14:30 | |
| *** r-daneel has quit IRC | 14:32 | |
| *** r-daneel has joined #openstack-nova | 14:33 | |
| *** felipemonteiro has joined #openstack-nova | 14:33 | |
| *** jogo has joined #openstack-nova | 14:33 | |
| *** moshele has joined #openstack-nova | 14:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Remove usage of kwarg retry_on_request in API https://review.openstack.org/557348 | 14:34 |
| cdent | efried: did you figure out the unicode thing? I'm timeslicing, so not sure if that loop is closed | 14:34 |
| efried | cdent: I was about to go start playing with u'\xXXX' strings. I'll pester you again, I'm sure :) | 14:35 |
| cdent | ✔ | 14:35 |
| *** sapd__ has quit IRC | 14:37 | |
| *** sapd__ has joined #openstack-nova | 14:38 | |
| *** sapd__ has quit IRC | 14:40 | |
| *** moshele has quit IRC | 14:40 | |
| *** sapd__ has joined #openstack-nova | 14:41 | |
| *** sapd__ has quit IRC | 14:41 | |
| *** kholkina has quit IRC | 14:41 | |
| *** sapd__ has joined #openstack-nova | 14:41 | |
| *** sapd__ has quit IRC | 14:41 | |
| *** sapd__ has joined #openstack-nova | 14:42 | |
| *** damien_r has quit IRC | 14:42 | |
| *** moshele has joined #openstack-nova | 14:43 | |
| *** moshele has quit IRC | 14:45 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | 14:45 |
| cdent | jaypipes, efried: the aforementioned to do list item related to handler unit testing ^ | 14:45 |
| cdent | sigh, had to be at least one typo | 14:47 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | 14:48 |
| mriedem | i need a non-lee stable core to approve https://review.openstack.org/#/c/555029/ so we can do a queens release | 14:50 |
| mriedem | there is also a bunch more https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | 14:50 |
| mriedem | if someone were so inclined | 14:50 |
| *** udesale has quit IRC | 14:50 | |
| *** efried has quit IRC | 14:51 | |
| dansmith | mriedem: got that one | 14:51 |
| *** efried has joined #openstack-nova | 14:52 | |
| *** damien_r has joined #openstack-nova | 14:54 | |
| *** Conqueror has quit IRC | 14:55 | |
| *** Spaz-Home has joined #openstack-nova | 14:55 | |
| * alex_xu_ gives up today | 14:57 | |
| *** kevinbenton has quit IRC | 14:58 | |
| *** udesale has joined #openstack-nova | 14:59 | |
| *** damien_r has quit IRC | 14:59 | |
| *** Spazmotic has quit IRC | 14:59 | |
| *** r-daneel has quit IRC | 15:00 | |
| efried | cdent: FYI, using unichr(x) let me run numbers over 127 just fine. | 15:01 |
| efried | cdent, jaypipes: I created RPs with names up to unichr(64K) and they all succeeded. | 15:01 |
| efried | JFYI. | 15:01 |
| * cdent wonders what promped efried to not believe in python | 15:02 | |
| efried | which part was me not believing in python? | 15:02 |
| cdent | is unichr codepoints or byte descriptions of unicode encodings | 15:02 |
| efried | You're just talking gibberish now. | 15:02 |
| edleafe | efried: please use six.unichr() | 15:02 |
| edleafe | 'unichr' is undefined in python3 | 15:03 |
| efried | I'm not using it for code edleafe, was just using it for testing purposes. | 15:03 |
| *** links has quit IRC | 15:03 | |
| cdent | efried: do you mean you don't know what a codepoint is? | 15:03 |
| edleafe | efried: ok, I thought that this was going in your slugify stuff | 15:03 |
| *** udesale has quit IRC | 15:03 | |
| efried | though edleafe cdent it makes me wonder whether https://review.openstack.org/#/c/556628/ is going to DTRT when translating a unicode input. | 15:03 |
| efried | cdent: I don't really even know what unicode is. | 15:04 |
| *** felipemonteiro_ has joined #openstack-nova | 15:04 | |
| efried | cdent: I mean, beyond "a big freaking table of character encodings" | 15:04 |
| cdent | efried: then you've answered my question about beliving in python | 15:04 |
| melwitt | dansmith, mriedem: I had been thinking that anyone in the core team could move things from the queue into the runways, not only me | 15:04 |
| *** damien_r has joined #openstack-nova | 15:05 | |
| edleafe | cdent: to answer your question, bytes | 15:05 |
| cdent | efried: I will look at that code for real when I get home, but it looks like overkill. Is there associated brokenness that demands it (other than length) | 15:05 |
| efried | edleafe, cdent: Answer: it breaks handily. | 15:05 |
| kashyap | mriedem: dansmith: Thanks for the thorough review, I'll address the comments tomm; today I have to head out early | 15:05 |
| *** kevinbenton has joined #openstack-nova | 15:06 | |
| kashyap | dansmith: BTW, if I use a warning, instead of 'exception.Invalid', would you still want a test for that? -- https://review.openstack.org/#/c/534384/20/nova/virt/libvirt/driver.py | 15:06 |
| efried | cdent: The commit message explains the need for it. Basically, I don't want every impl of update_provider_tree (or other things that need to generate names for placement entities) to have to be aware of character restrictions and length rules, and write their own slugifier. | 15:06 |
| dansmith | kashyap: yes | 15:06 |
| kashyap | dansmith: Not that I _don't_ want to write, just trying to keep things as minimal as possible :-) | 15:06 |
| *** r-daneel has joined #openstack-nova | 15:07 | |
| * cdent nods and heads home | 15:07 | |
| kashyap | dansmith: Alright | 15:07 |
| *** felipemonteiro has quit IRC | 15:07 | |
| kashyap | mriedem: Especially, appreciate the eagle eyes on wording. I agree with all those points. | 15:08 |
| *** pcaruana has quit IRC | 15:09 | |
| *** cdent has quit IRC | 15:10 | |
| kashyap | mriedem: On expanding acroynms ... I have a handy little package (less than 1MB) on my linux distribution. That goes like: | 15:10 |
| kashyap | $> wtf is wrt | 15:11 |
| kashyap | WRT: with respect to | 15:11 |
| kashyap | $> wtf is iirc | 15:11 |
| kashyap | IIRC: if I {recall,remember} correctly | 15:11 |
| kashyap | And lastly: | 15:11 |
| kashyap | $> wtf is wtf | 15:11 |
| kashyap | WTF: where's the food | 15:11 |
| kashyap | {what,when,where,who,why} the fuck | 15:11 |
| * kashyap stops the spam | 15:11 | |
| kashyap | The RPM is called: | 15:11 |
| kashyap | $> rpm -qf `which wtf` | 15:11 |
| kashyap | bsd-games-2.17-53.fc26.x86_64 | 15:11 |
| *** gyankum has joined #openstack-nova | 15:11 | |
| mriedem | i know what wrt means | 15:12 |
| mriedem | i wouldn't assume that all non-native english speakers have that nifty package | 15:12 |
| kashyap | mriedem: Only joking; I know what you meant: "Be sensitive to non-native speakers" | 15:12 |
| *** zhaochao has quit IRC | 15:13 | |
| bauzas | mriedem: will look at stable changes soon or later | 15:13 |
| *** Spazmotic has joined #openstack-nova | 15:13 | |
| *** Spaz-Home has quit IRC | 15:14 | |
| mriedem | bauzas: that's a time range i can bank on | 15:15 |
| * bauzas tries to duplicate himself | 15:15 | |
| bauzas | but for the moment, kids are too young to code | 15:16 |
| bauzas | that's a shame | 15:16 |
| bauzas | I'm pretty sure a 7-yo kid can code better than me | 15:16 |
| *** bhujay has quit IRC | 15:18 | |
| * edleafe notices no one is arguing that point | 15:18 | |
| bauzas | if you consider it that way, algorithms are easily understood by young children, and sometimes they can guess patterns better than adults | 15:21 |
| bauzas | so yeah I affirm some kid can beat me on that | 15:21 |
| *** rmart04 has left #openstack-nova | 15:23 | |
| dansmith | lyarwood: can you hit this? https://review.openstack.org/#/c/554600/ | 15:24 |
| * lyarwood looking | 15:24 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Handling a down cell https://review.openstack.org/557369 | 15:26 |
| *** imacdonn has quit IRC | 15:26 | |
| *** imacdonn has joined #openstack-nova | 15:27 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 15:29 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 15:29 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 15:29 |
| *** olivenwk has quit IRC | 15:30 | |
| mriedem | so i guess the placement api-ref hasn't been updated for 1.21 yet? https://docs.openstack.org/nova/latest/user/placement.html#support-member-of-aggregates-queryparam-on-get-allocation-candidates | 15:30 |
| mriedem | https://developer.openstack.org/api-ref/placement/#list-allocation-candidates | 15:30 |
| *** jaypipes is now known as jaypipes-away | 15:30 | |
| claudiub | welp, I've found a bug in the vmware driver because of the mock autospec patch. :D https://review.openstack.org/#/c/470775/28/nova/virt/vmwareapi/driver.py | 15:31 |
| *** lajoskatona has quit IRC | 15:31 | |
| claudiub | should create a bug report. | 15:31 |
| mriedem | bauzas: in the time you spent talking about your kid out-coding you, you could have just looked at those stable patches | 15:31 |
| bauzas | for 2 mins ? | 15:32 |
| * bauzas hides then | 15:32 | |
| mriedem | edleafe: can you push a fix for this? https://review.openstack.org/#/c/552098/9/placement-api-ref/source/allocation_candidates.inc@35 | 15:33 |
| *** sahid has quit IRC | 15:34 | |
| edleafe | mriedem: in a meeting - will get to it soon | 15:35 |
| mriedem | jaypipes-away: dansmith: alex_xu_: efried: edleafe: did i miss the point about https://review.openstack.org/#/c/555413/ being ok to change the member_of behavior in the 1.21 microversion? | 15:36 |
| dansmith | mriedem: it's not going to change 1.21 | 15:36 |
| efried | mriedem: You're right, we weren't being particularly precise, but it was understood that we were going to cut a new microversion. | 15:37 |
| mriedem | ok https://review.openstack.org/#/c/555413/3/specs/rocky/approved/alloc-candidates-member-of.rst@172 | 15:37 |
| mriedem | i see that now | 15:37 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: NUMA-aware live migration https://review.openstack.org/552722 | 15:37 |
| mriedem | whew | 15:37 |
| melwitt | dansmith: can you hit these queens backports pls https://review.openstack.org/#/c/555914 | 15:38 |
| dansmith | melwitt: when I'm done with downstream bug paperwork :/ | 15:39 |
| melwitt | :( | 15:39 |
| mriedem | so i guess we should re-open https://blueprints.launchpad.net/nova/+spec/alloc-candidates-member-of | 15:40 |
| mriedem | right? | 15:40 |
| dansmith | mriedem: I don't care what we do for the process | 15:42 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557377 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 15:44 |
| claudiub | who's working on the vmware driver? | 15:44 |
| *** sree has joined #openstack-nova | 15:44 | |
| claudiub | so i can add them as reviewers to the patch | 15:45 |
| *** sahid has joined #openstack-nova | 15:45 | |
| mriedem | claudiub: cdent is the gateway | 15:45 |
| mriedem | b/c the others aren't ever in channel | 15:45 |
| claudiub | ah, cool. | 15:45 |
| claudiub | thanks. :) | 15:45 |
| claudiub | added him to the vmware driver patch, he doesn't seem to be here though. | 15:46 |
| openstackgerrit | Merged openstack/nova master: Add more functional test for placement.usage https://review.openstack.org/513264 | 15:46 |
| openstackgerrit | Merged openstack/nova master: Fix spelling mistake of HTTPNotFound exception https://review.openstack.org/557187 | 15:46 |
| openstackgerrit | Merged openstack/nova-specs master: Amend the member_of spec for multiple query sets https://review.openstack.org/555413 | 15:47 |
| *** abhishekk has joined #openstack-nova | 15:48 | |
| melwitt | claudiub: thanks for the patch, I'll take a look at it too | 15:49 |
| *** sree has quit IRC | 15:49 | |
| claudiub | np. :) | 15:50 |
| *** andreas_s has quit IRC | 15:51 | |
| claudiub | IMO, we should merge the autospec stuff as soon as possible, so we can avoid simple stuff like this. :) | 15:51 |
| mriedem | so uh, | 15:51 |
| mriedem | this means you basically can't attach/detach volumes with the vmware driver, | 15:51 |
| *** andreas_s has joined #openstack-nova | 15:51 | |
| mriedem | since...who knows how long, right? | 15:51 |
| *** Zames has joined #openstack-nova | 15:51 | |
| mriedem | and their CI never caught this? | 15:51 |
| claudiub | yeah, that's pretty much what I get from it as well. | 15:51 |
| mriedem | should be a -2 on all vmware driver specs until they can fix their CI then | 15:52 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 15:52 |
| melwitt | yeah, I'm trying to find what's up with their CI. maybe it only runs on vmware driver patches? | 15:52 |
| claudiub | that method is called in destroy | 15:52 |
| melwitt | I noticed the xen driver CI works like that. it only runs on xen driver patches | 15:52 |
| claudiub | i think that they can still attach / detach volumes, but it will fail when they're destroying instances with volumes attached. | 15:53 |
| claudiub | still should have been caught by their CI in boot-from-volume cases | 15:54 |
| *** Zames has quit IRC | 15:54 | |
| mriedem | so maybe just got lucky by tempest always detaching volumes before they were deleted | 15:54 |
| *** itlinux has joined #openstack-nova | 15:54 | |
| claudiub | can you detach a volume which is used as boot-from-volume? | 15:54 |
| melwitt | I didn't think so | 15:55 |
| mriedem | no | 15:55 |
| *** Eran_Kuris has quit IRC | 15:55 | |
| *** andreas_s_ has joined #openstack-nova | 15:55 | |
| mriedem | their CI doesn't usually report at all | 15:55 |
| mriedem | https://review.openstack.org/#/c/553411/ was posted on march 15 | 15:55 |
| mriedem | no CI response | 15:55 |
| melwitt | ah, bummer. I checked on the xen one recently and it has recent runs but only on xen patches | 15:56 |
| *** andreas_s has quit IRC | 15:56 | |
| mriedem | i'm personally fine with 3rd party CI running on restricted sets of the tree | 15:56 |
| mriedem | for the most part | 15:56 |
| mriedem | but to not run on changes for that driver at all, is unacceptable | 15:57 |
| melwitt | yup, same. the only downside is it's harder to notice when it goes MIA | 15:57 |
| mriedem | i used to have to post a quarterly thing to the ML about how the vmware CI wasn't running or was broken | 15:57 |
| melwitt | but that's a lot more minor thing | 15:57 |
| *** belmoreira has quit IRC | 15:57 | |
| melwitt | yeah, I remember | 15:57 |
| * mriedem posts patch to warn about quality on startup | 15:58 | |
| *** chyka has joined #openstack-nova | 15:59 | |
| *** chyka has quit IRC | 15:59 | |
| melwitt | I'll mail the list about the vmware CI, see if anyone responds this time | 16:00 |
| *** chyka has joined #openstack-nova | 16:00 | |
| *** felipemonteiro_ has quit IRC | 16:00 | |
| *** andreas_s_ has quit IRC | 16:00 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: vmware: Fixes _detach_instance_volumes method https://review.openstack.org/557377 | 16:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: vmware: log quality warning on startup https://review.openstack.org/557398 | 16:02 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 16:04 |
| *** fragatin_ has quit IRC | 16:05 | |
| *** gyee has joined #openstack-nova | 16:06 | |
| *** andreas_s has joined #openstack-nova | 16:06 | |
| *** sahid has quit IRC | 16:08 | |
| *** amodi has quit IRC | 16:10 | |
| *** andreas_s has quit IRC | 16:10 | |
| *** gjayavelu has joined #openstack-nova | 16:12 | |
| mriedem | edleafe: nvm, the docs thing for placement and 1.21 can be fixed in https://review.openstack.org/#/c/554357/ | 16:12 |
| edleafe | mriedem: heh, I was just about to push a fix | 16:13 |
| *** lucasagomes is now known as lucas-afk | 16:13 | |
| edleafe | I'll just combine them | 16:13 |
| *** yingjun has quit IRC | 16:17 | |
| *** ragiman has quit IRC | 16:18 | |
| *** cdent has joined #openstack-nova | 16:18 | |
| lyarwood | dansmith: https://review.openstack.org/#/c/557348/ - would you mind looking at this retry_on_request removal backport to stable/pike that came up internally earlier? | 16:18 |
| dansmith | lyarwood: I assume we don't need to do that in upstream stable because of g-r right? | 16:18 |
| dansmith | (if it's not already broken I mean) | 16:19 |
| lyarwood | dansmith: well upstream outside of TripleO no we don't need to do this | 16:19 |
| lyarwood | dansmith: but even with g-r I think this is broken for TripleO | 16:20 |
| dansmith | I would defer to mriedem on that | 16:20 |
| dansmith | if it's capped by u-c I think we're fine as-is, and if not, we broke ourselves | 16:20 |
| dansmith | I would suspect maybe upstream tripleo isn't honoring u-c? | 16:21 |
| lyarwood | very likely | 16:21 |
| lyarwood | it's all RPMs there and I don't recall seeing the same u-c rules in the specs | 16:21 |
| mriedem | - | 16:23 |
| mriedem | -1 | 16:23 |
| mriedem | -5 | 16:23 |
| mriedem | b/c of what dan said | 16:23 |
| mriedem | the decorator was removed in oslo.db 4.30, | 16:23 |
| mriedem | stable/pike is capped at 4.25.1 https://github.com/openstack/requirements/blob/stable/pike/upper-constraints.txt#L433 | 16:23 |
| mriedem | so tripleo should be relying on u-c | 16:23 |
| lyarwood | mriedem: nice thanks | 16:23 |
| edleafe | ugh, heavy lightning around here - power drops have kicked me off the internet 3 times already. | 16:24 |
| * mriedem waits for the 30 tripleo cores to explain why they are special | 16:24 | |
| dansmith | mriedem: oh they're special alright | 16:25 |
| *** diga has joined #openstack-nova | 16:25 | |
| cdent | mriedem, melwitt: all I'm able to update on the vmware sitiuation is that you've got their attention, so reasonable strategy | 16:28 |
| *** sshwarts has quit IRC | 16:28 | |
| *** jackie-truong has quit IRC | 16:28 | |
| melwitt | cdent: ack | 16:29 |
| openstackgerrit | Merged openstack/nova stable/queens: Preserve multiattach flag when refreshing connection_info https://review.openstack.org/555029 | 16:29 |
| mriedem | dansmith: tssurya: melwitt: i assume we're having a cells meeting today? | 16:30 |
| mriedem | there is at least one new bug i wanted to talk about | 16:30 |
| dansmith | mriedem: I was going to ask if we needed to | 16:31 |
| dansmith | sounds like we do | 16:31 |
| melwitt | yeah, if we have topics, we can meet | 16:31 |
| *** yangyapeng has quit IRC | 16:32 | |
| mriedem | unless we just want to skip and talk about the specific bug here | 16:32 |
| melwitt | either way wfm | 16:32 |
| dansmith | I'm good to skip if it's just one bug | 16:33 |
| dansmith | I got nothing else | 16:33 |
| mriedem | wait to see what tssurya says, she's the busy one | 16:37 |
| *** Spaz-Home has joined #openstack-nova | 16:37 | |
| tssurya | I am good to skip too | 16:37 |
| mriedem | hot dog | 16:38 |
| mriedem | ok so just wanted to talk about options for https://bugs.launchpad.net/nova/+bug/1759316 | 16:38 |
| openstack | Launchpad bug 1759316 in OpenStack Compute (nova) queens "pre-cells_v2 nova-osapi_compute service in database breaks instance lookup" [Medium,Confirmed] | 16:38 |
| dansmith | okay | 16:38 |
| mriedem | basically an upgrade issue for someone that was hard to figure out since there are no logs | 16:38 |
| mriedem | upgrading newton->ocata | 16:38 |
| mriedem | at this point, if you're not using cells v1 and you get here, https://github.com/openstack/nova/blob/ed55dcad83d5db2fa7e43fc3d5465df1550b554c/nova/compute/api.py#L2269 - i think we should log a warning | 16:39 |
| mriedem | ^ was added in newton | 16:39 |
| mriedem | so if you're hitting that in ocata+ it likely means you're going to have issues | 16:39 |
| dansmith | so, I thought we removed some of this recently | 16:39 |
| dansmith | when I did the instance list bit | 16:39 |
| mriedem | i've had some patches to try and remove some things from the cells v2 transition but they are in limbo, | 16:40 |
| *** fragatina has joined #openstack-nova | 16:40 | |
| mriedem | there was also a thing i tried removing from the local delete flow and was hitting weird errors, but i forget the details | 16:40 |
| dansmith | but on ocata we can't eliminate that check just yet | 16:40 |
| *** yamahata has joined #openstack-nova | 16:40 | |
| dansmith | so yeah, you want to warn if we take that path and we're not on cellsv1 right? | 16:40 |
| mriedem | i'm not saying remove it, | 16:40 |
| mriedem | yes | 16:40 |
| mriedem | warn and backport that warning | 16:41 |
| dansmith | yeah I think that makes sense | 16:41 |
| melwitt | yeah, warning makes sense | 16:41 |
| mriedem | ok | 16:41 |
| mriedem | they were also asking if nova-status could check for this, | 16:41 |
| mriedem | which isn't unreasonable | 16:41 |
| dansmith | if you will do the nova-status change I'll do the warning :D | 16:41 |
| mriedem | ha | 16:41 |
| *** Spazmotic has quit IRC | 16:41 | |
| mriedem | i'm ok with nova-status, but need input on how the check is going to work, see 2nd paragraph in https://bugs.launchpad.net/nova/+bug/1759316/comments/1 | 16:41 |
| openstack | Launchpad bug 1759316 in OpenStack Compute (nova) queens "pre-cells_v2 nova-osapi_compute service in database breaks instance lookup" [Medium,Confirmed] | 16:41 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357 | 16:42 |
| edleafe | jaypipes-away: mriedem: ^^ Addressed the outstanding issues | 16:43 |
| dansmith | you can just return "maybe a problem" with basically that text right? "I found an old entry in cell foo and it might be a problem or might not, but fyi" | 16:43 |
| *** germs has joined #openstack-nova | 16:43 | |
| *** germs has quit IRC | 16:43 | |
| *** germs has joined #openstack-nova | 16:43 | |
| mriedem | dansmith: yeah that's what i was thinking, we have ok, warning and error for nova-status | 16:43 |
| mriedem | so this would be a warning | 16:43 |
| mriedem | since we aren't sure how you've configured the api | 16:43 |
| dansmith | righ | 16:43 |
| *** germs has quit IRC | 16:43 | |
| mriedem | alright i can work up a nova-status patch for that | 16:44 |
| mriedem | or die trying | 16:44 |
| *** germs has joined #openstack-nova | 16:44 | |
| *** germs has quit IRC | 16:44 | |
| *** germs has joined #openstack-nova | 16:44 | |
| dansmith | cool | 16:44 |
| melwitt | lol, pls don't die | 16:44 |
| *** ChanServ sets mode: -o dansmith | 16:44 | |
| *** lpetrut has quit IRC | 16:45 | |
| tssurya | melwitt: https://review.openstack.org/#/c/557369/ | 16:45 |
| tssurya | Just informing | 16:45 |
| melwitt | okay, cool. spec for handling a down cell, we can start reviewing that. and I can depend on it for my related quotas-from-placement-and-instance-mappings spec | 16:47 |
| melwitt | thanks | 16:47 |
| tssurya | dansmith: this is the re-rebase after the UUID shift revert, https://review.openstack.org/#/c/539501/ , whenever you have the time have a look | 16:49 |
| dansmith | okay | 16:49 |
| mriedem | bhagyashris: so i guess we don't send notifications for createBackup? | 16:51 |
| *** diga has quit IRC | 16:51 | |
| openstackgerrit | Merged openstack/nova stable/queens: Add --by-service to discover_hosts https://review.openstack.org/554600 | 16:52 |
| mriedem | bhagyashris: replies in https://review.openstack.org/#/c/511825/ | 16:53 |
| *** trozet has quit IRC | 16:53 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information https://review.openstack.org/312626 | 16:54 |
| *** tssurya has quit IRC | 16:54 | |
| *** gouthamr has quit IRC | 16:55 | |
| *** mvk has quit IRC | 16:56 | |
| melwitt | mriedem, dansmith: on this spec ^ it's about changing 'ip_address' in the metadata API to 'ip_addresses' to include all available interfaces for the guest, in a new metadata API version. there was a related issue about changing the metadata API to to show IP addresses even if there is a DHCP server present (currently it does not). there was a question on the spec about whether those two issues should be combined in one spec and one | 16:58 |
| melwitt | new metadata API version or if they should be separated into two specs and versions | 16:58 |
| melwitt | I had been thinking they two things would be separate specs and metadata API versions, but more input would be helpful | 16:59 |
| dansmith | metadata changes have to be purely additive, | 16:59 |
| dansmith | and in the past we've only ever had one metadata version per release AFAIK | 16:59 |
| *** r-daneel_ has joined #openstack-nova | 16:59 | |
| melwitt | okay, I wasn't aware of that. so it would not be allowed to change ip_address -> ip_addresses, but instead the possibility would be to add ip_addresses | 17:00 |
| dansmith | right | 17:00 |
| *** r-daneel has quit IRC | 17:01 | |
| *** r-daneel_ is now known as r-daneel | 17:01 | |
| melwitt | okay. and then on the "show IP addresses even if DHCP server is present", is that type of change never allowed then? or maybe it would be because that is technically additive. that is, the behavior in the past would be "didn't show IP addresses if DHCP server" and it changes to "shows IP addresses if DHCP server" | 17:01 |
| melwitt | (the use case there is, there is a DHCP server present but it's not being leveraged and IPs were statically configured) | 17:02 |
| melwitt | currently, the presence of the DHCP server makes the API hide the static IP addresses | 17:02 |
| dansmith | it's hard to say.. does cloud-init use the presence of that (or absence) to decide if it should try dhcp? | 17:02 |
| dansmith | any custom-rolled cloud-init-like thing could though, so.. | 17:03 |
| dansmith | it's less additive really | 17:03 |
| melwitt | that, I don't know | 17:03 |
| dansmith | but dan-init could have, | 17:04 |
| dansmith | which means it's probably not a great change | 17:04 |
| melwitt | yeah. I see | 17:04 |
| melwitt | there is some discussion about breaking compat on the spec, so now I understand in the metadata API we can never break compat. I had been thinking it would be like microversions | 17:05 |
| *** mdbooth has quit IRC | 17:06 | |
| melwitt | mgagne ^ | 17:06 |
| dansmith | yeah, not microversions | 17:06 |
| *** derekh has quit IRC | 17:07 | |
| mgagne | melwitt: I was under the impression that there is already a versioning system in place based on release date | 17:07 |
| melwitt | mgagne: there is, but apparently it can only be additive and cannot break backward compat | 17:07 |
| melwitt | I didn't know this before | 17:07 |
| mgagne | melwitt: that's news to me too :O | 17:07 |
| dansmith | there isn't | 17:07 |
| dansmith | the date thing is just because that's how EC2 metadata is used, | 17:07 |
| dansmith | but we don't really do it right | 17:07 |
| dansmith | so it's once per release, and additive because we don't really generate the backward-looking versions properly | 17:08 |
| melwitt | okay. I mistook the release date version to be microversion-like | 17:08 |
| *** Swami has joined #openstack-nova | 17:08 | |
| *** AlexeyAbashkin has quit IRC | 17:08 | |
| *** janki has quit IRC | 17:09 | |
| dansmith | melwitt: look at the comment above the version definitions | 17:09 |
| melwitt | mgagne: so we can add 'ip_addresses' but have to also keep 'ip_address' there. and we can't change the behavior of the DHCP server + IP address show/not show | 17:09 |
| dansmith | that doesn't fully explain the details I guess, but you can kinda see the "meh, this is .. meh" | 17:09 |
| *** amodi has joined #openstack-nova | 17:10 | |
| mriedem | we've had more than one version in a release i think, | 17:10 |
| *** dtantsur is now known as dtantsur|afk | 17:10 | |
| mriedem | and the $release version alias had to point at the newer one i think | 17:10 |
| mgagne | NEWTON_ONE = '2016-06-30' | 17:10 |
| mgagne | NEWTON_TWO = '2016-10-06' | 17:10 |
| mriedem | right | 17:10 |
| mgagne | but can't find comment about backward compatibility | 17:11 |
| mriedem | mgagne: probably unwritten, | 17:12 |
| dansmith | mriedem: that was because we had some problem.. it was an exception but I don't recall the details | 17:12 |
| mriedem | but b/c it doesn't have microversions, that's about the only option | 17:12 |
| melwitt | yeah, I'm guessing cloud-init and friends don't do anything to specify a version, so if you upgrade metadata API and compat is broken, everything breaks if you haven't grabbed the latest cloud-init that can handle it | 17:13 |
| *** sambetts is now known as sambetts|afk | 17:13 | |
| mriedem | if you don't specify a version, | 17:13 |
| mgagne | what's microversion? a number you can increase to indicate a change? it's already done with date, just a different format. other than a different philosophical pov, I don't see the difference. | 17:13 |
| mriedem | i believe you get a versioned dict back | 17:14 |
| mriedem | or maybe that's just config drive | 17:14 |
| mriedem | having said all this, mikal should probably be roped in | 17:14 |
| mriedem | he's an old school metadata API guy | 17:14 |
| mgagne | oh, I'm not familiar with metadata api at all, I only consume configdrive which does have all date/version in there | 17:14 |
| melwitt | yeah, I was about to say, we need a mikal | 17:14 |
| *** gjayavelu has quit IRC | 17:15 | |
| *** vivsoni_ has joined #openstack-nova | 17:15 | |
| *** gjayavelu has joined #openstack-nova | 17:16 | |
| dansmith | I don't think we do | 17:16 |
| dansmith | I mean, we need him in the cosmic sense | 17:16 |
| dansmith | but we need to be additive here | 17:16 |
| mgagne | ok, I don't mind update spec | 17:17 |
| *** stvnoyes has joined #openstack-nova | 17:17 | |
| mgagne | but this needs to be documented somewhere because I thought for years that you could break compat | 17:18 |
| melwitt | agreed, we should add explanation of that under the existing comment above the version list, at least | 17:18 |
| *** stvnoyes1 has quit IRC | 17:18 | |
| mgagne | and cloud-init consumes configdrive by date: https://github.com/cloud-init/cloud-init/blob/master/cloudinit/sources/helpers/openstack.py | 17:19 |
| melwitt | I'd appreciate a sanity check from mikal since those comments about the versioning are from him | 17:19 |
| *** gjayavelu has quit IRC | 17:20 | |
| dansmith | mgagne: it also has a latest, which we honor and use the latest field | 17:22 |
| openstackgerrit | Merged openstack/nova stable/queens: Fix and update compute schedulers config guide https://review.openstack.org/548873 | 17:22 |
| mgagne | dansmith: yes and IMO, it's like using master from git, if you want stability/predictability, don't use it. | 17:23 |
| *** bhujay has joined #openstack-nova | 17:27 | |
| *** mvk has joined #openstack-nova | 17:28 | |
| *** mdnadeem_ has quit IRC | 17:28 | |
| *** yamamoto has quit IRC | 17:29 | |
| *** gouthamr has joined #openstack-nova | 17:29 | |
| melwitt | lyarwood, dansmith: may I get reviews on this stable backport pls https://review.openstack.org/#/c/550498 for saving admin password to sysmeta | 17:30 |
| *** moshele has joined #openstack-nova | 17:30 | |
| *** lpetrut has joined #openstack-nova | 17:30 | |
| melwitt | er sorry, didn't realize queens backport didn't merge yet. dansmith https://review.openstack.org/#/c/550489 instead | 17:31 |
| *** suresh12 has joined #openstack-nova | 17:31 | |
| *** gouthamr has quit IRC | 17:32 | |
| lyarwood | melwitt: np, noted in the review for now | 17:33 |
| melwitt | lyarwood: perfect thanks | 17:33 |
| *** fragatina has quit IRC | 17:35 | |
| *** bhujay has quit IRC | 17:35 | |
| *** tesseract has quit IRC | 17:35 | |
| *** yamahata has quit IRC | 17:38 | |
| *** abhishekk has quit IRC | 17:41 | |
| *** felipemonteiro has joined #openstack-nova | 17:43 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:43 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345 | 17:45 |
| efried | mriedem: Let's see how that shakes out ^ | 17:45 |
| *** trozet has joined #openstack-nova | 17:45 | |
| *** gjayavelu has joined #openstack-nova | 17:45 | |
| *** yamamoto has joined #openstack-nova | 17:46 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: mask InjectionInfo.admin_pass https://review.openstack.org/548289 | 17:47 |
| *** felipemonteiro has quit IRC | 17:47 | |
| *** moshele has quit IRC | 17:49 | |
| mriedem | efried: hmm, we do need a backportable fix for bug 1752152 though | 17:51 |
| openstack | bug 1752152 in OpenStack Compute (nova) "Attach Volume Fails with secure call to cinder" [Undecided,In progress] https://launchpad.net/bugs/1752152 - Assigned to Eric Fried (efried) | 17:51 |
| mriedem | i also don't understand why our CI jobs don't fail with that bug | 17:51 |
| *** r-daneel_ has joined #openstack-nova | 17:51 | |
| efried | mriedem: The problem with backportability is that I can't use the _SESSION if I... don't have a _SESSION. | 17:52 |
| *** psachin has joined #openstack-nova | 17:52 | |
| *** r-daneel has quit IRC | 17:53 | |
| *** r-daneel_ is now known as r-daneel | 17:53 | |
| efried | mriedem: It's a chicken/egg: I would have to use the CinderClient to make the request, cause that guy handles https already. But the microversion check is *before* the CinderClient is created. Soooo.... | 17:53 |
| efried | mriedem: Are you sure the CIs are using https? If it were me, I would have switched that off first thing to make things easier. | 17:53 |
| mriedem | i thought there was a backportable way to fix this when i was posting stuff in the bug report before, but that's exited my brain so would have to look at all of this again, but in the middle of something | 17:54 |
| mriedem | pretty sure yes | 17:54 |
| mriedem | http://logs.openstack.org/45/508345/13/check/nova-next/aa61d86/logs/screen-c-api.txt.gz#_Mar_15_20_00_06_201395 | 17:54 |
| efried | mriedem: The backportable way would have been to s/https/http/ for the version discovery. | 17:54 |
| efried | which is not a good solution. | 17:54 |
| efried | mriedem: I'm not well versed on ssl etc, but isn't there a way to use https without a cert file? | 17:55 |
| mriedem | don't konw | 17:55 |
| dansmith | efried: no | 17:56 |
| mriedem | another thing i mentioned as a hack workaround for backports, is use the internal cinderclient.Client.session | 17:56 |
| mriedem | to get the version doc | 17:56 |
| mriedem | then we replace all of that with the KSA thing in master | 17:56 |
| mriedem | then it's just a session.get() | 17:56 |
| *** vladikr has quit IRC | 17:56 | |
| *** tssurya has joined #openstack-nova | 17:56 | |
| efried | cinderclient.Client.session doesn't exist until we've created the client though, does it? | 17:57 |
| efried | that's the chicken/egg | 17:57 |
| *** itlinux has quit IRC | 18:00 | |
| *** lpetrut has quit IRC | 18:02 | |
| efried | mriedem: (I know you're busy, but when you're available...) Any reason not to move the microversion check to after the client construction? | 18:03 |
| mriedem | i think that was my idea from the bug report | 18:03 |
| mriedem | "The alternative is on the nova side, we just construct a cinderclient Client object and use it's internal client (session) to make a request, or use a keystoneauth1 adapter to make the request." | 18:03 |
| efried | okey, I'll see if I can work that up. | 18:05 |
| *** swamireddy has joined #openstack-nova | 18:08 | |
| *** vladikr has joined #openstack-nova | 18:10 | |
| *** liverpooler has quit IRC | 18:11 | |
| *** yamamoto has quit IRC | 18:12 | |
| *** itlinux has joined #openstack-nova | 18:15 | |
| *** yamahata has joined #openstack-nova | 18:16 | |
| *** lpetrut has joined #openstack-nova | 18:16 | |
| *** psachin has quit IRC | 18:16 | |
| *** suresh12 has quit IRC | 18:19 | |
| *** yamamoto has joined #openstack-nova | 18:21 | |
| *** suresh12 has joined #openstack-nova | 18:23 | |
| *** yamamoto has quit IRC | 18:26 | |
| *** fragatina has joined #openstack-nova | 18:27 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 18:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 18:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 18:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 18:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 18:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 18:29 |
| *** vivsoni_ has quit IRC | 18:31 | |
| *** gjayavelu has quit IRC | 18:33 | |
| *** voelzmo has joined #openstack-nova | 18:33 | |
| *** gyankum has quit IRC | 18:36 | |
| *** yamamoto has joined #openstack-nova | 18:36 | |
| *** gyankum has joined #openstack-nova | 18:40 | |
| *** yamamoto has quit IRC | 18:41 | |
| *** corvus is now known as kermitf | 18:42 | |
| *** kermitf is now known as corvus | 18:42 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 18:43 |
| *** gyankum has quit IRC | 18:48 | |
| *** voelzmo has quit IRC | 18:48 | |
| *** yamamoto has joined #openstack-nova | 18:52 | |
| *** moshele has joined #openstack-nova | 18:54 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:54 | |
| *** lpetrut has quit IRC | 18:54 | |
| *** moshele has quit IRC | 18:56 | |
| *** yamamoto has quit IRC | 18:56 | |
| *** AlexeyAbashkin has quit IRC | 18:59 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 19:02 |
| *** yamahata has quit IRC | 19:11 | |
| *** yamahata has joined #openstack-nova | 19:12 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information https://review.openstack.org/312626 | 19:15 |
| *** avolkov has quit IRC | 19:16 | |
| *** yamamoto has joined #openstack-nova | 19:17 | |
| *** yamamoto has quit IRC | 19:17 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 19:17 |
| openstackgerrit | melanie witt proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | 19:17 |
| *** sree has joined #openstack-nova | 19:19 | |
| *** dikonoo has quit IRC | 19:19 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990 | 19:20 |
| openstackgerrit | melanie witt proposed openstack/nova master: Update layout docs for running console proxies https://review.openstack.org/557489 | 19:20 |
| dansmith | mriedem: do you have a recent devstack running by chance? | 19:21 |
| dansmith | (or anyone) | 19:21 |
| mriedem | nope | 19:21 |
| dansmith | okay I was asking you since I'm writing the docs you demand and I don't have a recent one myself | 19:23 |
| *** sree has quit IRC | 19:23 | |
| *** esberglu has quit IRC | 19:25 | |
| *** esberglu has joined #openstack-nova | 19:26 | |
| *** yamamoto has joined #openstack-nova | 19:28 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 19:30 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 19:30 |
| *** esberglu has quit IRC | 19:31 | |
| *** yamamoto has quit IRC | 19:32 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 19:33 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 19:33 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 19:33 |
| *** MarkMielke has quit IRC | 19:37 | |
| *** esberglu has joined #openstack-nova | 19:38 | |
| efried | mriedem, jgriffith: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3964 Is this here to avoid a DB lookup? | 19:39 |
| *** felipemonteiro_ has quit IRC | 19:40 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:40 | |
| efried | It looks to me like the guts of _check_volume_already_attached_to_instance don't actually depend on cinder microversion 3.44 -- and we're just doing this because, if 3.44 isn't supported, we couldn't possibly have >1 volume attached, so there's no need to do _check_volume_already_attached_to_instance. | 19:40 |
| jgriffith | efried: well, no.. not really; the cinder mv can be dynamic | 19:40 |
| jgriffith | efried: yeah, once that attachment is made we use the bdm entry for determining which flow is in use | 19:41 |
| jgriffith | efried: sorry, I might not understand completely what you're looking for | 19:42 |
| mriedem | efried: the point is the comment in the else block below it | 19:42 |
| * efried reads again... | 19:42 | |
| jgriffith | Oh, specifically that call right there :) | 19:43 |
| *** yamamoto has joined #openstack-nova | 19:43 | |
| mriedem | i'm having a hard time remembering too | 19:44 |
| efried | Lemme make sure I have the logic right: | 19:44 |
| efried | If multiattach not supported by cinder, proceed. | 19:44 |
| efried | Otherwise, fail if the volume is attached. | 19:44 |
| mriedem | 3.44 isn't about multiattach | 19:44 |
| mriedem | it starts with https://review.openstack.org/#/c/525622/ | 19:44 |
| mriedem | with the new attachments api stuff, cinder will let us create multiple attachments between the same volume and instance | 19:44 |
| mriedem | to enable things like live migration where the instance is attached to the volume on different hosts | 19:45 |
| mriedem | but because of that, we found we had a bug where you could attach the same volume to the instance via the api multiple times | 19:45 |
| mriedem | so we had to add a specific check for that | 19:45 |
| jgriffith | mriedem: yeah, the comment actually is pretty good :) | 19:46 |
| mriedem | before using new style attachments, cinder would not allow this | 19:46 |
| mriedem | that's why in https://review.openstack.org/#/c/525622/ we have to rely on the bdm table | 19:46 |
| *** awaugama has quit IRC | 19:46 | |
| *** yamamoto has quit IRC | 19:47 | |
| efried | Ultimately I was trying to figure out if I could get rid of that microversion check :) I think I now understand why I can't. | 19:47 |
| mriedem | so going back to https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3964 | 19:47 |
| efried | Which kinda sucks, because it means I'm gonna have to build up a whole cinder client just to do that microversion check. | 19:48 |
| mriedem | if 3.44 is supported, we know we're doing the new style attachment_create, and we have to make sure the instance isn't already attached to that volume, so we call _check_volume_already_attached_to_instance | 19:48 |
| mriedem | if 3.44 isn't available, we'll do the old style reserve flow | 19:48 |
| mriedem | which cinder enforces you can only have the instance attached to the volume once | 19:48 |
| *** yamahata has quit IRC | 19:48 | |
| mriedem | efried: yeah but that is only temporary for the backport, | 19:49 |
| mriedem | and we can replace that stuff with ksa in master right? | 19:49 |
| efried | mriedem: Except I still haven't figured out how to get ksa stuff working for cinder, period. | 19:49 |
| mriedem | heh | 19:49 |
| mriedem | well, | 19:49 |
| mriedem | it's just code right?! | 19:49 |
| efried | Sigh. Right. | 19:49 |
| mriedem | sylvain's daughter will have it done by tomorrow | 19:50 |
| efried | I know, I can't let her show me up like that. Not again. | 19:50 |
| *** felipemonteiro__ has joined #openstack-nova | 19:53 | |
| dansmith | cripes | 19:54 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 19:56 |
| *** yamamoto has joined #openstack-nova | 19:57 | |
| *** yamamoto has quit IRC | 19:57 | |
| *** felipemonteiro_ has quit IRC | 19:58 | |
| *** moshele has joined #openstack-nova | 20:11 | |
| mriedem | dansmith: not sure if you care about any of the comments in https://review.openstack.org/#/c/544730/15 | 20:12 |
| *** eharney has quit IRC | 20:13 | |
| dansmith | mriedem: sorry hadn't seen those | 20:14 |
| dansmith | replied | 20:14 |
| mriedem | i've got this nova-status check ready to go basically for the cells api service version check thing, i think i'll just munge the api log warning into the same patch | 20:18 |
| dansmith | seems reasonable | 20:20 |
| *** awaugama has joined #openstack-nova | 20:23 | |
| *** tssurya has quit IRC | 20:26 | |
| *** sapd__ has quit IRC | 20:30 | |
| *** sapd__ has joined #openstack-nova | 20:31 | |
| *** r-daneel_ has joined #openstack-nova | 20:32 | |
| *** r-daneel has quit IRC | 20:33 | |
| *** r-daneel_ is now known as r-daneel | 20:33 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 20:38 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 20:38 |
| *** nicolasbock has joined #openstack-nova | 20:39 | |
| mikal | mriedem: yeah, I can be around to interate on privsep for the next couple of weeks. Noting that both of the next two weeks are short because of easter. | 20:40 |
| openstackgerrit | Merged openstack/nova stable/queens: Avoid exploding if guest refuses to detach a volume https://review.openstack.org/551948 | 20:41 |
| mikal | mriedem: what's blocking removing nova-net? The last couple of privsep patches aren't mergable until nova-net is gone, but I can WIP those or something. It would be nice to get them landed this cycle though. | 20:41 |
| *** pchavva has quit IRC | 20:41 | |
| mriedem | mikal: nothing is blocking it | 20:43 |
| mriedem | mikal: but, | 20:43 |
| mriedem | i imagine it's not trivial since a ton of the test code in-tree assumes nova-net | 20:43 |
| mriedem | and that's including non-nova-net things | 20:44 |
| mikal | Is anyone working on it? | 20:44 |
| mriedem | so all of that has to be unwound | 20:44 |
| mriedem | mikal: not that i know of, | 20:44 |
| mriedem | i got the cells v1 job running with neutron and that was step 1 | 20:44 |
| *** moshele has quit IRC | 20:44 | |
| *** andreas_s has joined #openstack-nova | 20:45 | |
| mriedem | which reminds me, | 20:46 |
| mriedem | melwitt: dansmith: efried: i'm out on monday and tuesday | 20:47 |
| dansmith | orly | 20:47 |
| melwitt | k, thanks for the heads up | 20:47 |
| dansmith | I'm out friday for "GENERIC SPRING HOLIDAY" | 20:47 |
| melwitt | me too | 20:47 |
| efried | roger that, mriedem. Means you have to review this bug fix tonight/tomorrow I guess. | 20:47 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions https://review.openstack.org/557506 | 20:49 |
| mriedem | SamYaple: ^ for your bug from yesterday, i hope i get a bag of jelly beans for this | 20:49 |
| *** andreas_s has quit IRC | 20:49 | |
| SamYaple | oh snap! | 20:50 |
| SamYaple | that was quick. i promise you regular flavored jelly beans | 20:50 |
| mriedem | is there such a thing as unflavored jelly beans? | 20:52 |
| SamYaple | i said "regular". as opposed to.... other flavors | 20:52 |
| mriedem | oh right | 20:53 |
| mriedem | yeah brachs | 20:53 |
| mriedem | not that new fangled starburts stuff | 20:53 |
| mriedem | *starbursts | 20:53 |
| SamYaple | haha | 20:53 |
| dansmith | starburts? | 20:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 20:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 20:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 20:53 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 20:54 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 20:54 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 20:54 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | 20:54 |
| dansmith | (man I suck) | 20:54 |
| efried | mriedem: ^ | 20:54 |
| efried | Hahaha | 20:54 |
| mriedem | ? | 20:54 |
| mriedem | starburts are burt reynolds flavored candies | 20:54 |
| mriedem | mostly taste like oil and stache | 20:54 |
| mikal | Does anyone else see pep8 failures with master by the way? | 20:55 |
| efried | mriedem: I was pointing out the bug fix patch I just posted. But crossed streams with dansmith, so it looked like I was bringing your attention to the fact that dansmith, by his own admission, sucks. | 20:55 |
| mikal | Running flake8 on all files | 20:55 |
| mikal | ./nova/tests/unit/virt/libvirt/volume/test_quobyte.py:230:18: E211 whitespace before '(' | 20:55 |
| mikal | ./nova/virt/libvirt/guest.py:664:68: F821 undefined name 'unicode' | 20:55 |
| mriedem | mikal: nope | 20:55 |
| mikal | Herm, how odd. | 20:55 |
| dansmith | efried: I ain't swordfightin' with you dude.. ever. | 20:55 |
| openstackgerrit | Merged openstack/nova stable/pike: Avoid exploding if guest refuses to detach a volume https://review.openstack.org/551950 | 20:55 |
| efried | Promises promises. | 20:55 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1746509 https://review.openstack.org/555914 | 20:56 |
| openstack | bug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,In progress] https://launchpad.net/bugs/1746509 - Assigned to melanie witt (melwitt) | 20:56 |
| openstackgerrit | Merged openstack/nova stable/queens: Move _make_instance_list call outside of DB transaction context https://review.openstack.org/555915 | 20:56 |
| openstackgerrit | Merged openstack/nova master: tox: Make everything work with Python 3 https://review.openstack.org/556894 | 20:56 |
| openstackgerrit | Merged openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 20:56 |
| *** gjayavelu has joined #openstack-nova | 20:57 | |
| openstackgerrit | Merged openstack/nova stable/queens: Save admin password to sysmeta in libvirt driver https://review.openstack.org/550489 | 20:57 |
| *** yamamoto has joined #openstack-nova | 20:57 | |
| mriedem | mordred must have just flushed the zuul toilet | 20:57 |
| *** yamahata has joined #openstack-nova | 20:58 | |
| * mordred passes the communal roll of toilet paper to mriedem | 20:58 | |
| melwitt | mriedem, dansmith: pike backports ready2rock https://review.openstack.org/#/c/555058 | 20:59 |
| efried | dansmith: Did you mean to do this or not? https://review.openstack.org/#/c/544730/15..16/nova/scheduler/manager.py | 21:00 |
| efried | Am I just failing to detect sarcasm via gerrit? | 21:00 |
| dansmith | efried: no, I meant I meant to do what mriedem was suggesting | 21:00 |
| efried | ight | 21:00 |
| efried | cause he seems to have taken you at face value also. | 21:00 |
| *** r-daneel_ has joined #openstack-nova | 21:01 | |
| dansmith | melwitt: why is that patch strikeouted | 21:02 |
| dansmith | ? | 21:02 |
| melwitt | I dunno. usually that means it merged but it didn't merge | 21:03 |
| *** r-daneel has quit IRC | 21:03 | |
| *** r-daneel_ is now known as r-daneel | 21:03 | |
| *** yamahata has quit IRC | 21:03 | |
| *** yamamoto has quit IRC | 21:03 | |
| melwitt | or no, that's the dot that means it merged. | 21:03 |
| melwitt | it's not strikeouted anymore now. not sure what that was | 21:04 |
| efried | Were you looking at the cherry-picks tabbydoo? | 21:04 |
| melwitt | yes | 21:04 |
| melwitt | Related Changes | 21:04 |
| melwitt | so no, but similar | 21:05 |
| efried | The Cherry Picks one (rightly) shows black-dotted patches from the other branches. I don't see black dots under Related Changes. | 21:05 |
| mriedem | dansmith: one more time through the ringer https://review.openstack.org/#/c/547990/ | 21:05 |
| efried | You say temporary glitch. I say it never happened. Need new glasses. | 21:06 |
| melwitt | earlier before mriedem +2ed it, it was strikeouted in the Related Changes tabbydoo | 21:06 |
| mriedem | i saw it | 21:06 |
| *** moshele has joined #openstack-nova | 21:08 | |
| mriedem | efried: since we don't have that https failure in devstack, we'll likely need divya to assert it fixes the bug | 21:09 |
| mriedem | i don't have the setup for it | 21:09 |
| efried | mriedem: Roger that. If it looks okay to you at a glance, I'll send it that way. | 21:09 |
| mikal | mriedem: its not just unit tests, look at nova.virt.xenapi.firewall for example. | 21:10 |
| mriedem | mikal: yeah linux_net is going to be mingled into everything | 21:11 |
| mriedem | so i'm not really sure what the best way is to unwind the nova-net stuff since it's mixed into everything | 21:11 |
| mikal | Orbital nukes? | 21:12 |
| mikal | For a start, do we even know if xen people still use the dom0 firewalling stuff? Its copyright 8 years ago now. | 21:12 |
| mriedem | well, what i know i don't want to see is a single giant patch that just deletes everything | 21:12 |
| mriedem | mikal: would have to ask BobBall or jianghuaw_ | 21:12 |
| mikal | I think you just did? | 21:12 |
| cdent | dansmith or mriedem : were either of you aware of jaypipes-away asking about some tweaks to oslo config to know if an option's value was coming from a default or elsewhere (even if the value was the same)? dhellman implemented a feature to support that in oslo_config but it seems to have bad mojo and maybe it can die: https://bugs.launchpad.net/oslo.config/+bug/1759689 | 21:13 |
| openstack | Launchpad bug 1759689 in oslo.config "In 1.6.0 startup can be extremely slow when checking many config items" [Undecided,New] | 21:13 |
| *** itlinux has quit IRC | 21:14 | |
| mikal | This nova.virt.firewall thing is news to me and is going to be an issue I think | 21:14 |
| mikal | Its used quite widely. | 21:14 |
| mriedem | cdent: nope | 21:14 |
| cdent | (sorry that's 6.0.0 above, not 1.6.0) | 21:14 |
| mriedem | i saw the ML thread | 21:14 |
| mikal | Oh, its security groups | 21:15 |
| mikal | That makes sense. Why not just call it that then? | 21:15 |
| mriedem | i will be amused when i found out that you wrote most of this mikal | 21:15 |
| mikal | I did not | 21:15 |
| mikal | I am innocent. My tech debt is elsewhere. | 21:16 |
| mriedem | efried: i think https://review.openstack.org/#/c/557508/ looks ok for the most part | 21:22 |
| efried | mriedem: Thanks. | 21:22 |
| mriedem | i think the diff could be smaller, | 21:22 |
| mriedem | but it's ready for divya to test | 21:22 |
| *** yamahata has joined #openstack-nova | 21:24 | |
| efried | mriedem: It's really just gerrit being silly. I didn't move the method - just put the new stuff in front of it (because it makes more sense ordered that way). | 21:24 |
| mriedem | ok | 21:25 |
| mriedem | or, | 21:25 |
| mikal | mriedem: looking at this, I think the first step is like privsep. Remove nova-net support from just one driver (presumably libvirt). Learn what it looks like by doing that, and then repeat for other drivers. | 21:25 |
| mriedem | you're anal about functions being defined before they are used, like in | 21:25 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357 | 21:25 |
| mriedem | c | 21:25 |
| mriedem | mikal: yeah you're probably right | 21:25 |
| mriedem | also, | 21:25 |
| mriedem | the apis that are solely nova-net only will need to be cleansed to just fast-fail at any microversion | 21:26 |
| mriedem | can't remember if we 404 or 405 for those today after the deprecation versions | 21:26 |
| *** moshele has quit IRC | 21:26 | |
| mikal | It looks to me like linux_net and nova-net are also not synonyms like I thought they were. nova.virt.libvirt.vif uses linux-net to plug devices for example. | 21:27 |
| mriedem | yes, dansmith loves that | 21:27 |
| mriedem | i think for the deprecated apis, you get a 404 https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L739 | 21:28 |
| mriedem | so one thing one could start with, is neutering all of those APIs | 21:28 |
| mikal | I had assumed for privsep I could ignore nova-net, but I don't think that's true now that I learn that vif plugging calls into it. | 21:29 |
| mikal | This is a tangled mess. | 21:29 |
| mikal | i.e. I might be forced to privsep a bunch of "nova-net" in order to land the final couple of privsep patches. | 21:30 |
| mriedem | mikal: or just help with the nova-net removal | 21:31 |
| mikal | Perhaps, but I'm a hobbyist. Any critical part of nova's roadmap depending on me is going to be a problem. | 21:32 |
| *** cdent has quit IRC | 21:37 | |
| mriedem | ok, let's drop privsep from runways then :) | 21:39 |
| mriedem | or, be OK with saying privsep won't be done by the end of your runway | 21:39 |
| mikal | mriedem: sure, if you want. You've been saying its a low priority the whole time though. You can't have it both ways. | 21:39 |
| mriedem | b/c of the nova-net stuff | 21:39 |
| *** sticker has joined #openstack-nova | 21:40 | |
| mriedem | what do i want both ways? | 21:40 |
| mriedem | my point is, | 21:40 |
| mriedem | i don't think you should do more privsep stuff for nova-net specific things when we're going to drop nova-net, | 21:40 |
| mikal | Either you want privsep or you don't. I don't really care either way any more. | 21:40 |
| mriedem | and if that means the privsep conversion isn't done at the end of your current runway, i think that's ok | 21:40 |
| mriedem | also, i'm not the only person here | 21:41 |
| mikal | I've said all along that privsep wouldn't be done at the end of the runway. The last couple of patches which need nova-net to go can just sit around until someone removes nova-net. | 21:41 |
| *** edmondsw has quit IRC | 21:43 | |
| *** sree has joined #openstack-nova | 21:45 | |
| efried | This seems simple to me. The scope of the runway is the privsep series up to but not including the patches that require nova-net removal. Runways don't have to encompass an entire blueprint. That was something we talked about early on, but later relaxed our stance on. | 21:46 |
| *** sree has quit IRC | 21:51 | |
| -openstackstatus- NOTICE: the zuul web dashboard will experience a short downtime as we roll out some changes - no job execution should be affected | 21:52 | |
| *** harlowja has joined #openstack-nova | 21:53 | |
| melwitt | agreed, privsep up until the nova-net requiring ones can be done as part of the runway and that's it | 21:59 |
| *** yamamoto has joined #openstack-nova | 21:59 | |
| *** yamamoto has quit IRC | 22:04 | |
| *** yamahata has quit IRC | 22:04 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | 22:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | 22:10 |
| mriedem | efried: maybe you'd like to rev https://review.openstack.org/#/c/546813/ ? | 22:14 |
| mriedem | i'm itching to +2 that | 22:14 |
| efried | mriedem: sec... | 22:15 |
| melwitt | mikal: earlier today we were talking about metadata API versioning because of a spec review where the proposal wants to change the network_data.json format in a new version. dansmith said new versions can be only additive and that was news to me and mgagne. is that also your understanding? we see this code comment by you above the version list https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L60 | 22:16 |
| melwitt | and I'm not aware of any other documentation about the versioning | 22:17 |
| esberglu | mriedem: efried: Sorry I've been caught up in some other stuff. Was planning on hitting that either tonight or 1st thing in the am | 22:17 |
| efried | esberglu: I can punch it rn if you like. | 22:17 |
| mikal | melwitt: I don't think we've ever done a non-additive change, but I'd have to check. The scheme is inherited from ec2, so I guess what they've done might also matter. Mostly this comes down to looking at the cloud-init implementation and seeing how it would handle the data changing. | 22:19 |
| *** mlavalle has quit IRC | 22:19 | |
| esberglu | efried: If you want to go for it. I'm trying to finish out a bunch system upgrades today | 22:20 |
| mriedem | Kevin_Zheng: just a small change to add to https://review.openstack.org/#/c/536722/ about older computes | 22:21 |
| mriedem | then i'll be +2 again | 22:21 |
| melwitt | mikal: yeah, I think you're right that we haven't done a non-additive change. ack on having to look at cloud-init. although there might be other things consuming the API that might not handle a compat change even if cloud-init does | 22:21 |
| mikal | melwitt: very true. You can totally write a shell script to parse metadata, that's the whole idea. | 22:22 |
| mikal | melwitt: the original cloud-init was in fact a shell script. | 22:22 |
| mgagne | melwitt, mikal: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html | 22:25 |
| mgagne | "The earlier versions are available to you in case you have scripts that rely on the structure and information present in a previous version." | 22:26 |
| *** Guest33320 has quit IRC | 22:26 | |
| mgagne | my understanding of this statement is that newer versions can remove information or change structure in non-backward compatible ways | 22:26 |
| *** rcernin has joined #openstack-nova | 22:28 | |
| efried | mriedem: Does that reno need to say anything beyond "The PowerVM driver now supports hot plugging/unplugging of network interfaces." ? | 22:29 |
| mriedem | efried: nope | 22:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: Network interface attach/detach https://review.openstack.org/546813 | 22:29 |
| efried | mriedem: ight. ^ | 22:29 |
| mriedem | thanks | 22:29 |
| efried | My daughter cooked me a steak. I'm out. | 22:29 |
| * efried waves | 22:30 | |
| esberglu | efried: tx | 22:30 |
| melwitt | mgagne: I interpret it the same way. so, the source material for this API was intended to be able to change things between versions and break compat. it will be interesting to see how cloud-init is written and whether it would be insulated to such an API change. (and that's aside from all of the other things people may have written to consume the metadata API) | 22:30 |
| mikal | cloud-init has heavy contributions from amazon, so we're probably ok then | 22:30 |
| mikal | Although the openstack implementation in cloud-init probably doesn't get much love from amazon | 22:31 |
| melwitt | yeah, that's my concern | 22:31 |
| mikal | I do think asking someone to check cloud-init as part of the spec review is reasonable | 22:31 |
| mgagne | melwitt: supported versions are hardcoded: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/xenial#n44 | 22:31 |
| mikal | LOL, they're quite far behind. | 22:32 |
| *** jaypipes-away is now known as jaypipes | 22:32 | |
| mikal | Unless xenial is shipping an old version? | 22:32 |
| mgagne | that's for xenial, should check for latest | 22:32 |
| *** esberglu has quit IRC | 22:32 | |
| mgagne | but it supports network_data.json so I'm happy =) | 22:32 |
| *** awaugama has quit IRC | 22:32 | |
| *** priteau has quit IRC | 22:33 | |
| mgagne | same for latest version it seems: https://git.launchpad.net/cloud-init/tree/cloudinit/sources/helpers/openstack.py?h=ubuntu/devel#n44 | 22:33 |
| mikal | https://github.com/cloud-init/cloud-init/blob/master/cloudinit/sources/helpers/openstack.py | 22:33 |
| mikal | Trunk is just as far behind | 22:33 |
| mikal | I guess maybe they expect us to be keeping that stuff up to date | 22:34 |
| mikal | That means no vendordata v2 for anyone in cloud-init land for example | 22:34 |
| mgagne | up to date => support older versions ? | 22:34 |
| *** mriedem has quit IRC | 22:34 | |
| mgagne | if nobody asks ¯\_(ツ)_/¯ | 22:34 |
| mgagne | had to ask for network_data.json and contribute, wasn't easy | 22:34 |
| *** priteau has joined #openstack-nova | 22:35 | |
| *** mriedem has joined #openstack-nova | 22:36 | |
| dansmith | mikal: melwitt mgagne: we've not done non-additive changes in the past, and I don't really see any reason to make that change here.. we can totally do it additive-ly | 22:37 |
| dansmith | we could re-audit all that stuff and make those checks more explicit about version spans (i.e start doing a thing in X, stop doing it in Y) but I don't see the point | 22:38 |
| dansmith | yes, anything consuming latest is playing with fire, but.. shell scripts | 22:38 |
| mgagne | dansmith: sure, just want to make sure we don't force ourselves to abide ourselves to some non-written rules which happens to have no reasons to exist | 22:39 |
| mgagne | I updated spec to keep backward compat | 22:39 |
| *** priteau has quit IRC | 22:40 | |
| *** felipemonteiro__ has quit IRC | 22:43 | |
| melwitt | yeah, ip_address and ip_addresses would be redundant but maybe that's not that big of a deal | 22:43 |
| melwitt | or, ip_address would be redundant | 22:43 |
| *** mriedem has quit IRC | 22:47 | |
| *** ansiwen[q] has joined #openstack-nova | 22:47 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Start untangling network utilities. https://review.openstack.org/557542 | 22:52 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move two more generic network utilities to a move obvious place. https://review.openstack.org/557543 | 22:52 |
| mikal | melwitt: ^--- that's the sort of untangling I was talking about | 22:52 |
| melwitt | ah, okay. thanks for getting that started | 22:53 |
| mikal | melwitt: some of that makes it more apparently that there is some privsep to do in nova.network, event if nova-net is nuked from orbit | 22:54 |
| *** hongbin has quit IRC | 22:54 | |
| mikal | melwitt: which wasn't as obvious before | 22:54 |
| melwitt | mikal: so that means, some privsep work is needed to support the utils that are not really part of nova-net? | 22:55 |
| mikal | melwitt: yes, as we split out the bits of nova-net that we need post nova-net, we will find things that need to be privsep'ed | 22:55 |
| mikal | melwitt: none of them look hard to do, but the previous assumption was that all of nova-net was just getting deleted | 22:56 |
| mikal | melwitt: which is not true | 22:56 |
| melwitt | mikal: understood | 22:56 |
| mikal | melwitt: so, these ones got the remove-nova-network bp tag, but could have had the privsep one if we'd wanted to, they're all tangled up together | 22:56 |
| mikal | I don't think you can tag two blueprints. Maybe you can? | 22:57 |
| melwitt | I think you can, but from what I can tell, they make more sense under nova-net removal being that they're decoupling things that need to remain after removing nova-net | 22:57 |
| mikal | Yeah | 22:57 |
| mikal | I also don't care how they're tagged as long as they get reviewed one day | 22:58 |
| melwitt | that work would have to be done anyway to remove nova-net, even without privsep | 22:58 |
| mikal | I'mma just going to keep rebasing them and smashing the gate until someone gives in and reviews them | 22:58 |
| melwitt | yeah, same | 22:58 |
| mikal | Given we're up to 13 interrelated patches so far, and that list will grow | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 22:58 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | 22:58 |
| *** yamamoto has joined #openstack-nova | 23:00 | |
| *** cfriesen has quit IRC | 23:03 | |
| *** yamamoto has quit IRC | 23:06 | |
| *** salv-orlando has quit IRC | 23:21 | |
| *** salv-orlando has joined #openstack-nova | 23:22 | |
| *** salv-orlando has quit IRC | 23:27 | |
| *** chyka has quit IRC | 23:32 | |
| *** gyee has quit IRC | 23:32 | |
| *** chyka has joined #openstack-nova | 23:33 | |
| *** chyka has quit IRC | 23:37 | |
| *** Zames has joined #openstack-nova | 23:45 | |
| *** Zames has quit IRC | 23:48 | |
| *** tbachman has quit IRC | 23:52 | |
| *** claudiub has quit IRC | 23:52 | |
| -openstackstatus- NOTICE: Zuul has been restarted to update to the latest code; existing changes have been re-enqueued, you may need to recheck changes uploaded in the past 10 minutes | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!