Monday, 2018-03-19

openstackgerritTetsuro Nakamura proposed openstack/nova-specs master: Report KVM hypervisor_type in hypervisor API  https://review.openstack.org/55407500:01
openstackgerritTetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver  https://review.openstack.org/53104900:02
openstackgerritTetsuro Nakamura proposed openstack/nova master: enable cpu pinning with libvirt/qemu driver  https://review.openstack.org/55407600:02
*** odyssey4me has quit IRC00:09
*** odyssey4me has joined #openstack-nova00:09
*** fgsukhe has joined #openstack-nova00:10
*** xinliang has quit IRC00:11
*** hongbin has joined #openstack-nova00:12
*** Zames has joined #openstack-nova00:12
*** yamamoto has joined #openstack-nova00:13
*** yamamoto has quit IRC00:18
*** Zames has quit IRC00:22
*** xinliang has joined #openstack-nova00:24
*** claudiub|2 has quit IRC00:27
*** hshiina has joined #openstack-nova00:28
*** amodi has quit IRC00:29
*** vladikr has quit IRC00:35
*** vladikr has joined #openstack-nova00:36
*** amodi has joined #openstack-nova00:46
*** amodi has quit IRC00:50
*** liuzz has joined #openstack-nova00:55
*** phuongnh has joined #openstack-nova00:56
*** gouthamr has quit IRC01:03
*** r-daneel has joined #openstack-nova01:06
openstackgerritMichael Still proposed openstack/nova master: Move configurable mkfs to privsep.  https://review.openstack.org/55192101:08
openstackgerritMichael Still proposed openstack/nova master: Move xenapi xenstore_read's to privsep.  https://review.openstack.org/55224101:08
openstackgerritMichael Still proposed openstack/nova master: Move xenapi disk resizing to privsep.  https://review.openstack.org/55224201:08
openstackgerritMichael Still proposed openstack/nova master: Move xenapi partition copies to privsep.  https://review.openstack.org/55360501:08
openstackgerritMichael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck.  https://review.openstack.org/55407801:08
*** zhaochao has joined #openstack-nova01:10
*** yamamoto has joined #openstack-nova01:13
*** tiendc has joined #openstack-nova01:14
*** zhurong has joined #openstack-nova01:16
*** yamamoto has quit IRC01:19
openstackgerritZhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.openstack.org/50748601:24
*** gouthamr has joined #openstack-nova01:25
*** r-daneel_ has joined #openstack-nova01:32
*** r-daneel has quit IRC01:33
*** r-daneel_ is now known as r-daneel01:33
*** yamamoto has joined #openstack-nova01:41
*** OctopusZhang__ has joined #openstack-nova01:45
*** elmaciej has quit IRC01:51
*** hoangcx has joined #openstack-nova01:54
*** tbachman has joined #openstack-nova01:55
*** annp has joined #openstack-nova02:27
*** zhurong has quit IRC02:36
*** zhurong has joined #openstack-nova02:37
*** tbachman has quit IRC02:40
*** esberglu has joined #openstack-nova02:43
*** jichen has joined #openstack-nova02:50
*** psachin has joined #openstack-nova02:50
*** salv-orl_ has joined #openstack-nova02:51
*** salv-orlando has quit IRC02:53
jichenmelwitt: hi, could you please help to review https://review.openstack.org/#/q/topic:bp/add-zvm-driver-rocky+(status:open+OR+status:merged) as it's listed https://etherpad.openstack.org/p/rocky-nova-priorities-tracking 'Non-priority approved blueprints'  but no review since PTG end and I think better to request review/approval before cores get busy ....02:54
*** esberglu has quit IRC02:58
openstackgerritYaoZheng proposed openstack/nova master: remove _cleanup_running_deleted_instances repeat detach volume  https://review.openstack.org/55409003:01
*** sapd has joined #openstack-nova03:02
openstackgerritHironori Shiina proposed openstack/nova master: ironic: Proxy a few attributes of block device mapping  https://review.openstack.org/55409303:08
*** germs has joined #openstack-nova03:17
*** germs has quit IRC03:17
*** germs has joined #openstack-nova03:17
*** namnh has joined #openstack-nova03:21
*** germs has quit IRC03:22
*** rcernin_ has joined #openstack-nova03:23
*** rcernin has quit IRC03:25
*** rcernin_ has quit IRC03:29
*** rcernin has joined #openstack-nova03:29
*** rcernin has quit IRC03:33
*** Zames has joined #openstack-nova03:34
*** vladikr has quit IRC03:36
*** vladikr has joined #openstack-nova03:36
*** Zames has quit IRC03:37
*** esberglu has joined #openstack-nova03:39
*** sree has joined #openstack-nova03:40
*** Kevin_Zheng has quit IRC03:40
*** pooja_jadhav has joined #openstack-nova03:43
*** esberglu has quit IRC03:43
*** hongbin has quit IRC03:44
*** udesale has joined #openstack-nova03:46
openstackgerritTetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode()  https://review.openstack.org/52990603:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset()  https://review.openstack.org/52763103:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver  https://review.openstack.org/53045103:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: trivial: omit condition evaluations  https://review.openstack.org/54524803:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver  https://review.openstack.org/53104903:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: enable cpu pinning with libvirt/qemu driver  https://review.openstack.org/55407603:47
*** rcernin has joined #openstack-nova03:49
*** janki has joined #openstack-nova03:50
*** janki is now known as janki|office_ina03:51
*** wxy has quit IRC03:56
*** Dinesh_Bhor has joined #openstack-nova04:13
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix comments in get_all_with_shared()  https://review.openstack.org/53319504:17
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix hypervisor_type in /os-hypervisors/details  https://review.openstack.org/53132804:21
*** sree_ has joined #openstack-nova04:29
*** sree_ is now known as Guest3142104:29
*** abhishekk has joined #openstack-nova04:31
*** sree has quit IRC04:32
*** sapd has quit IRC04:32
*** bhagyashri_s is now known as bhagyashris04:33
*** bhagyashris is now known as bhagyashri_s04:33
*** bhagyashri_s is now known as bhagyashris04:33
*** Zames has joined #openstack-nova04:35
*** itlinux has quit IRC04:39
*** sapd has joined #openstack-nova04:47
*** suresh12 has joined #openstack-nova04:50
*** claudiub has joined #openstack-nova04:52
*** sridharg has joined #openstack-nova04:53
*** gouthamr has quit IRC04:54
*** Dinesh__Bhor has joined #openstack-nova04:59
*** Dinesh_Bhor has quit IRC05:00
*** lpetrut has joined #openstack-nova05:01
*** zhurong has quit IRC05:04
openstackgerritMerged openstack/nova master: Add --by-service to discover_hosts  https://review.openstack.org/55269105:07
*** suresh12 has quit IRC05:14
*** imacdonn has quit IRC05:14
*** imacdonn has joined #openstack-nova05:14
*** suresh12 has joined #openstack-nova05:14
*** germs has joined #openstack-nova05:18
*** ratailor has joined #openstack-nova05:18
openstackgerritwangqi proposed openstack/nova master: use http code constant instead of int  https://review.openstack.org/55412105:20
*** suresh12 has quit IRC05:22
*** Zames has quit IRC05:22
*** germs has quit IRC05:23
*** sree_ has joined #openstack-nova05:33
*** sree_ is now known as Guest588805:34
*** Guest31421 has quit IRC05:37
*** mdnadeem has joined #openstack-nova05:39
*** sidx64 has joined #openstack-nova05:47
*** openstackgerrit has quit IRC05:49
*** lpetrut has quit IRC05:50
*** udesale has quit IRC05:51
*** udesale has joined #openstack-nova05:52
*** trinaths has joined #openstack-nova05:54
*** kholkina has joined #openstack-nova05:55
*** kholkina has quit IRC05:59
*** Dinesh__Bhor has quit IRC05:59
*** Dinesh_Bhor has joined #openstack-nova06:01
*** openstackgerrit has joined #openstack-nova06:03
openstackgerritHironori Shiina proposed openstack/nova master: ironic: Proxy a few attributes of block device mapping  https://review.openstack.org/55409306:03
*** gaurangt has quit IRC06:04
*** sapd has quit IRC06:09
*** cfriesen has quit IRC06:12
*** amodi has joined #openstack-nova06:18
*** Dinesh_Bhor has quit IRC06:22
*** Dinesh_Bhor has joined #openstack-nova06:25
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/54877206:26
openstackgerritYikun Jiang (Kero) proposed openstack/nova-specs master: Amend the "add extra-specs to flavor" for create and update API  https://review.openstack.org/55413406:29
*** Dinesh_Bhor has quit IRC06:29
openstackgerritYikun Jiang (Kero) proposed openstack/nova-specs master: Amend the "add extra-specs to flavor" for create and update API  https://review.openstack.org/55413406:30
*** Dinesh_Bhor has joined #openstack-nova06:31
*** lajoskatona has joined #openstack-nova06:32
*** udesale_ has joined #openstack-nova06:34
openstackgerritwangqi proposed openstack/nova master: use http code constant instead of int  https://review.openstack.org/55412106:37
*** udesale has quit IRC06:38
*** sidx64_ has joined #openstack-nova06:38
*** alexchadin has joined #openstack-nova06:39
*** Zames has joined #openstack-nova06:40
*** sidx64 has quit IRC06:40
*** fragatina has quit IRC06:42
*** sidx64_ has quit IRC06:43
*** sidx64 has joined #openstack-nova06:44
openstackgerritAndrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name  https://review.openstack.org/52779106:45
*** udesale_ is now known as udesale06:47
*** kholkina has joined #openstack-nova06:49
*** Zames has quit IRC06:50
*** zhurong has joined #openstack-nova07:00
*** sidx64 has quit IRC07:04
*** rcernin has quit IRC07:07
*** sidx64 has joined #openstack-nova07:11
*** Shilpa has joined #openstack-nova07:14
*** suresh12 has joined #openstack-nova07:17
*** sidx64 has quit IRC07:17
*** udesale_ has joined #openstack-nova07:18
*** udesale has quit IRC07:18
*** sidx64 has joined #openstack-nova07:18
*** germs has joined #openstack-nova07:18
*** germs has quit IRC07:18
*** germs has joined #openstack-nova07:18
*** sidx64 has quit IRC07:20
*** suresh12 has quit IRC07:21
*** germs has quit IRC07:23
*** sidx64 has joined #openstack-nova07:23
*** sidx64 has quit IRC07:24
*** sidx64 has joined #openstack-nova07:26
*** sidx64 has quit IRC07:26
*** amodi has quit IRC07:27
*** sidx64 has joined #openstack-nova07:28
*** andreas_s has joined #openstack-nova07:38
*** Zames has joined #openstack-nova07:38
*** Zames has quit IRC07:38
*** pcaruana has joined #openstack-nova07:39
openstackgerritAndrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name  https://review.openstack.org/52779107:41
*** claudiub has quit IRC07:48
*** trinaths has quit IRC07:53
*** AlexeyAbashkin has joined #openstack-nova07:54
*** zhurong has quit IRC07:54
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Remove dependency to the old aggregate-based-pools  https://review.openstack.org/55415407:55
*** OctopusZhang has joined #openstack-nova07:55
*** lpetrut has joined #openstack-nova07:57
*** brault_ has joined #openstack-nova07:57
*** OctopusZhang is now known as yufei07:59
openstackgerritwangqi proposed openstack/nova master: use http code constant instead of int  https://review.openstack.org/55412107:59
*** brault has quit IRC07:59
*** OctopusZhang__ has quit IRC07:59
*** lpetrut_ has joined #openstack-nova08:00
*** lpetrut has quit IRC08:00
*** vivsoni_ has joined #openstack-nova08:01
openstackgerritShilpa Devharakar proposed openstack/nova master: Update docs, API samples for noVNC 1.0.0  https://review.openstack.org/55017308:08
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [WIP] Add microversion to support extra_specs in flavor API.  https://review.openstack.org/55415908:11
*** maciejjozefczyk has joined #openstack-nova08:14
*** tesseract has joined #openstack-nova08:17
openstackgerritjichenjc proposed openstack/nova master: Move test_allocation_candidates.py  https://review.openstack.org/55314908:22
*** udesale_ has quit IRC08:23
openstackgerritsahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready  https://review.openstack.org/49745708:23
*** elmaciej has joined #openstack-nova08:24
*** aloga has quit IRC08:24
*** janki|office_ina has quit IRC08:25
*** udesale_ has joined #openstack-nova08:30
*** sidx64 has quit IRC08:33
*** sidx64 has joined #openstack-nova08:33
*** sidx64 has quit IRC08:34
*** Dinesh_Bhor has quit IRC08:34
*** Tom-Tom has joined #openstack-nova08:35
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Remove dependency to the old aggregate-based-pools  https://review.openstack.org/55415408:36
*** ccamacho has joined #openstack-nova08:36
*** lyarwood has joined #openstack-nova08:37
*** tetsuro has joined #openstack-nova08:38
*** slaweq has quit IRC08:38
*** jaosorior has joined #openstack-nova08:40
*** Dinesh_Bhor has joined #openstack-nova08:40
openstackgerritZhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.openstack.org/50748608:41
*** claudiub has joined #openstack-nova08:42
openstackgerritYaoZheng proposed openstack/nova master: remove _cleanup_running_deleted_instances repeat detach volume  https://review.openstack.org/55409008:44
*** amoralej|off is now known as amoralej08:45
openstackgerritlicanwei proposed openstack/nova master: Make nova-manage capable of syncing all cell databases  https://review.openstack.org/51927508:48
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415408:48
*** ragiman has joined #openstack-nova08:50
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment  https://review.openstack.org/48945108:50
openstackgerritjichenjc proposed openstack/nova master: Move placement test cases from db to placement  https://review.openstack.org/55314908:52
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415408:53
*** Tom-Tom has quit IRC08:54
*** maciejjozefczyk has quit IRC08:54
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415408:54
*** maciejjozefczyk has joined #openstack-nova08:55
*** Eran_Kuris has joined #openstack-nova08:56
*** elod_off is now known as elod08:56
*** yamahata has quit IRC08:58
*** jpena|off is now known as jpena08:59
*** Guest5888 has quit IRC09:00
*** slaweq has joined #openstack-nova09:00
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment  https://review.openstack.org/48945109:00
*** sree_ has joined #openstack-nova09:04
*** sree_ is now known as Guest4566209:04
*** sar has joined #openstack-nova09:06
*** Guest45662 has quit IRC09:08
*** salv-orl_ has quit IRC09:09
*** salv-orlando has joined #openstack-nova09:09
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415409:13
*** hshiina has quit IRC09:13
*** salv-orlando has quit IRC09:14
*** tssurya has joined #openstack-nova09:16
*** psachin has quit IRC09:19
*** hoonetorg has quit IRC09:19
*** rmart04 has joined #openstack-nova09:20
*** psachin has joined #openstack-nova09:24
openstackgerritzhufl proposed openstack/nova master: Fix typos in release notes  https://review.openstack.org/55417509:25
*** sahid has joined #openstack-nova09:25
*** Eran_Kuris has quit IRC09:28
*** danpawlik has joined #openstack-nova09:29
*** mgoddard has joined #openstack-nova09:29
*** udesale_ has quit IRC09:30
*** gibi_ is now known as gibi09:30
gibigood morning09:30
openstackgerritYikun Jiang (Kero) proposed openstack/nova-specs master: Amend the "add extra-specs to flavor" for create and update API  https://review.openstack.org/55413409:31
*** ragiman has quit IRC09:31
*** Eran_Kuris has joined #openstack-nova09:31
*** udesale has joined #openstack-nova09:32
*** hoonetorg has joined #openstack-nova09:32
*** BlackDex has quit IRC09:34
*** Dinesh_Bhor has quit IRC09:34
*** BlackDex has joined #openstack-nova09:35
*** yufei has quit IRC09:37
*** cdent has joined #openstack-nova09:37
*** trinaths has joined #openstack-nova09:42
*** gus has quit IRC09:43
*** yufei has joined #openstack-nova09:44
*** sidx64 has joined #openstack-nova09:44
*** gus has joined #openstack-nova09:44
*** ragiman has joined #openstack-nova09:45
*** yufei has quit IRC09:48
openstackgerritBence Romsics proposed openstack/osc-placement master: Do not depend on jenkins user in devstack gate  https://review.openstack.org/55247609:49
gibibauzas: regarding the https://github.com/openstack/oslo.versionedobjects/commit/0e3526710f67b3b4ebab60864ea060fa9caf9537 and the hypens in UUIDs. My intention in that ovo patch was to fix the usage error of the warning filter in ovo09:50
cdentmornin'09:51
openstackgerritTetiana Lashchova proposed openstack/nova-specs master: Allow modification of user-data via the server update  https://review.openstack.org/54796409:56
*** diranerpi has joined #openstack-nova10:00
diranerpiHi all There is a way to use instance metadata to schedule instance deployment on a specific host?10:02
openstackgerritLee Yarwood proposed openstack/nova stable/queens: docs: Disable smartquotes  https://review.openstack.org/55418810:05
*** namnh has quit IRC10:05
openstackgerritLee Yarwood proposed openstack/nova stable/pike: docs: Disable smartquotes  https://review.openstack.org/55418910:05
diranerpior on a specific host aggregate ?10:05
*** trinaths has quit IRC10:05
*** hoangcx has quit IRC10:08
*** sambetts_ is now known as sambetts10:08
*** mvk has joined #openstack-nova10:13
*** yamamoto has quit IRC10:16
*** dtantsur|afk is now known as dtantsur10:19
johnthetubaguydiranerpi: there are almost too many options right now, have a look at most of the filters with the word "aggregate" in them: https://docs.openstack.org/nova/latest/user/filter-scheduler.html10:24
bhagyashrisjohnthetubguy: Hi,10:25
bhagyashrisjohnthetubguy: I just want to discuss deeply regarding "Skip instance backup image creation when rotation 0" as we discussed in Dublin PTG #link: https://etherpad.openstack.org/p/nova-ptg-rocky so as per the suggestion I am following the the idea mentioned in etherpad  1.  add a microversion to disallow 0 using the schema validation while creating the backup image10:29
bhagyashrisjohnthetubguy: 2. add a new API for "purge all backups" to be used instead of passing 0 so for this I have introduce new cleanup-backup api to delete the backup images of specified instance in command10:31
bhagyashrisjohnthetubguy: so i am on the right patch about this idea10:31
bhagyashrisjohnthetubguy: s/patch/path10:32
*** phuongnh has quit IRC10:33
bhagyashrisjohnthetubaguy: Hi, Sorry for spelling mistake in name ^10:37
*** annp has quit IRC10:37
diranerpijohnthetubaguy: hi, i've read those filter but no one responds to my use case (i want to use instance metadata to choose which host aggregate will be used)10:37
*** ragiman has quit IRC10:38
*** avolkov has joined #openstack-nova10:38
diranerpiSo for example, if in my instance data i create a metadata like "service = database", i want this instance to be deployed on a specific aggregate host10:38
*** tiendc has quit IRC10:39
diranerpijohnthetubaguy: So for example, if in my instance data i create a metadata like "service = database", i want this instance to be deployed on a specific aggregate host10:39
*** tbachman has joined #openstack-nova10:40
*** sree has joined #openstack-nova10:43
*** sree has quit IRC10:48
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419510:50
*** ragiman has joined #openstack-nova10:50
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385710:54
*** sdague has joined #openstack-nova10:55
*** yamamoto has joined #openstack-nova11:02
*** salv-orlando has joined #openstack-nova11:05
*** abhishekk has quit IRC11:06
johnthetubaguybhagyashris: hi11:09
johnthetubaguybhagyashris: that sounds spot on11:09
*** edmondsw has joined #openstack-nova11:14
bhagyashrisjohnthetubaguy: ok thank you :) actually cleanup-backup api will purge all the backup images of instance so is that be ok? or should i give the provision to cleanup the backup images for example cleanup last two backups etc?11:17
*** edmondsw has quit IRC11:18
*** germs has joined #openstack-nova11:20
*** germs has quit IRC11:20
*** germs has joined #openstack-nova11:20
*** alexchadin has quit IRC11:21
*** alexchadin has joined #openstack-nova11:21
*** alexchadin has quit IRC11:21
*** alexchadin has joined #openstack-nova11:22
*** alexchadin has quit IRC11:22
*** alexchadin has joined #openstack-nova11:23
*** alexchadin has quit IRC11:23
*** alexchadin has joined #openstack-nova11:24
*** alexchadin has quit IRC11:24
bhagyashrisjohnthetubaguy: and on current master at the time of createbackup the delete image backup is implementated so should i remove that implementation from create backup so should i kept it as it is?11:24
*** alexchadin has joined #openstack-nova11:24
*** alexchadin has quit IRC11:24
*** germs has quit IRC11:25
gibimelwitt: regarding the nova onboarding session in Vancouver. I can only give a tentative yes as my company haven't approved my travel yet.11:32
*** alexchadin has joined #openstack-nova11:35
*** vladikr has quit IRC11:37
kashyapIs it just me, fetching from: https://git.openstack.org/openstack/nova.git fails?11:39
kashyapIt's just me11:42
cdentworks for me11:42
kashyapFir me, it's just hung here:11:44
kashyapRunning: `GIT_CURL_VERBOSE=1 GIT_TRACE=1 git pull`11:44
kashyaphttp://paste.openstack.org/show/704380/11:44
*** alexchadin has quit IRC11:49
*** logan- has quit IRC11:52
*** logan- has joined #openstack-nova11:52
*** aloga has joined #openstack-nova11:53
johnthetubaguybhagyashris: the old API has to keep working like it does today11:54
*** aloga has quit IRC11:54
johnthetubaguykashyap: you tried doing http rather than https?11:55
kashyapjohnthetubaguy: I tried all three, git, https, http.11:55
kashyapNone works for me, bizarrely11:55
johnthetubaguybummer11:55
bhagyashrisjohnthetubaguy: ok . i just need to add the functionality of roatation parameter value 0 in cleanup backup api right?11:56
johnthetubaguybhagyashris: yes, that sounds correct. Will be easier to review the spec with all the details, to make sure I haven't missed a bit :)11:57
bhagyashrisjohnthetubaguy: ok thank you for your inputs will upload spec ASAP :)11:59
johnthetubaguybhagyashris: no problem, sounds good11:59
*** beagles_biab is now known as beagesl12:00
*** beagesl is now known as beagles12:00
*** psachin has quit IRC12:00
*** efried has quit IRC12:03
*** tetsuro has left #openstack-nova12:06
*** aloga has joined #openstack-nova12:07
*** sidx64 has quit IRC12:08
*** psachin has joined #openstack-nova12:11
*** sidx64 has joined #openstack-nova12:12
*** edmondsw has joined #openstack-nova12:15
*** sidx64 has quit IRC12:22
*** gyankum has joined #openstack-nova12:22
*** suresh12 has joined #openstack-nova12:23
openstackgerritTheodoros Tsioutsias proposed openstack/nova-specs master: Add PENDING vm state  https://review.openstack.org/55421212:24
*** sidx64 has joined #openstack-nova12:25
*** suresh12 has quit IRC12:27
*** READ10 has joined #openstack-nova12:27
openstackgerritChris Dent proposed openstack/nova-specs master: Provide error codes for placement API  https://review.openstack.org/41839312:28
*** cdent has quit IRC12:34
*** liverpooler has joined #openstack-nova12:39
*** ratailor has quit IRC12:40
*** liverpooler has quit IRC12:40
*** liverpooler has joined #openstack-nova12:40
*** odyssey4me has quit IRC12:42
*** odyssey4me has joined #openstack-nova12:42
*** vladikr has joined #openstack-nova12:42
*** mvk has quit IRC12:44
*** pchavva has joined #openstack-nova12:46
openstackgerritTheodoros Tsioutsias proposed openstack/nova-specs master: Enable rebuild for instances in cell0  https://review.openstack.org/55421812:55
*** jpena is now known as jpena|lunch12:56
*** moshele has joined #openstack-nova12:56
*** danpawlik has quit IRC12:57
*** cdent has joined #openstack-nova12:59
*** mriedem has joined #openstack-nova13:06
*** amoralej is now known as amoralej|lunch13:08
*** yamamoto has quit IRC13:08
*** sidx64 has quit IRC13:12
*** efried has joined #openstack-nova13:13
*** ioni has left #openstack-nova13:14
*** sidx64 has joined #openstack-nova13:15
*** sidx64 has quit IRC13:15
*** lyan has joined #openstack-nova13:18
*** lyan is now known as Guest6846113:18
*** sidx64 has joined #openstack-nova13:19
*** germs has joined #openstack-nova13:21
*** germs has quit IRC13:21
*** germs has joined #openstack-nova13:21
*** psachin has quit IRC13:24
*** jichen has quit IRC13:25
*** germs has quit IRC13:26
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542313:29
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137013:29
openstackgerritMatt Riedemann proposed openstack/nova master: Port binding based on events during live migration  https://review.openstack.org/43487013:29
openstackgerritMatt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method  https://review.openstack.org/55217013:29
openstackgerritMatt Riedemann proposed openstack/nova master: compute: use port binding extended API during live migration  https://review.openstack.org/55137113:29
*** sidx64 has quit IRC13:29
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253713:29
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Turn on new port binding extended live migrate flow  https://review.openstack.org/55217313:29
openstackgerritZhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware  https://review.openstack.org/50748613:30
*** sidx64 has joined #openstack-nova13:30
*** sidx64 has quit IRC13:34
*** eharney has joined #openstack-nova13:42
*** jroll has quit IRC13:42
*** jroll has joined #openstack-nova13:43
*** hamzy__ is now known as hamzy13:43
kaisers1efried: Hi! Regarding https://review.openstack.org/#/c/554195/ : I looked into using privsep but as the spec says true root user context will continue to use rootwrap i went with that. If privsep does offer a root execution mechanism i can go that way. Do you have a hint on docs/examples of that for me?13:44
*** sidx64 has joined #openstack-nova13:44
efriedkaisers1: mikal is the expert on that.  I believe he's in Australia, so time zones may be a bit of a challenge.  I'm sure I can at least dig up the spec for the privsep work.  Stand by...13:45
*** yamamoto has joined #openstack-nova13:45
efriedkaisers1: Meanwhile, if you want to see some examples for how mikal has transitioned existing code over to privsep: https://review.openstack.org/#/q/topic:bp/hurrah-for-privsep+(status:open+OR+status:merged)13:45
dansmithkaisers1: you should be using privsep not rootwrap for new things13:47
dansmithkaisers1: the whole point of privsep is to replace rootwrap, and doing so does indeed get you root escalation for your code13:47
*** psachin has joined #openstack-nova13:47
*** esberglu has joined #openstack-nova13:47
efrieddansmith: Is there a spec (I can't find one) or documentation for how to use privsep?13:47
dansmithefried: there's lots of code now13:48
kaisers1I did read the spec13:48
kaisers1dansmith: thanks for the inputs!13:48
*** yamamoto_ has joined #openstack-nova13:48
efriedkaisers1: For my edification, where did you find that spec?13:48
kaisers1efried: https://specs.openstack.org/openstack/oslo-specs/specs/liberty/privsep.html13:49
dansmithprivsep was born of lots of conversation and design, I'm sure there are things to read, but I expect a lot of the formal documentation focuses on capability contexts, which we've short-circuited to a single root one,13:49
efriedah, in oslo.13:49
dansmithso it may be more reading than you need13:49
efriedSo yeah, kaisers1 you may do best following the code examples I linked above.13:49
kaisers1efried: will do, thanks!13:50
dansmithdefinitely13:50
efriedenjoy13:50
*** yamamoto has quit IRC13:52
*** mvk has joined #openstack-nova13:54
jaypipesugh, the warnings barfed out in py36 test runs is getting ridiculous.13:54
edleafeScheduler subteam meeting in 5 minutes in #openstack-meeting-alt13:55
cdentjaypipes: fun, isn't it?13:55
*** dtantsur is now known as dtantsur|brb13:56
*** amoralej|lunch is now known as amoralej13:56
tssuryadansmith: I am really sorry about this accidental rebase : https://review.openstack.org/#/c/553831/; could you please rebase it to the right topic before someone +W's it ?13:57
jaypipescdent: makes it very annoying to run tests.13:57
cdentjaypipes: I keep meaning to find some to fix and then forget for whatever reason13:58
dansmithtssurya: it doesn't really matter13:58
tssuryadansmith: ok, yea still sorry13:59
dansmithtssurya: it's not a problem, gerrit-review does that13:59
dansmithtssurya: in the future -R will prevent you from rebasing the thing underneath you if you intentionally don't want it to move13:59
tssuryadansmith: yep will keep that in mind next time14:00
tssuryathank you14:00
dansmithnp14:00
*** hongbin has joined #openstack-nova14:00
*** beekneemech is now known as bnemec14:02
*** awaugama has joined #openstack-nova14:03
*** Maddy has joined #openstack-nova14:04
MaddyHello, I was hitting this bug https://bugs.launchpad.net/nova/+bug/1717547 and I see that the workaround for that is not using the image parameters name as 'version', 'context' and 'method'.14:05
openstackLaunchpad bug 1717547 in OpenStack Compute (nova) "Creating snapshot fails when image metadata has version field" [Low,Confirmed]14:05
MaddyThis is not good because the user needs to be aware of that. One solution is make Glance to deny use of these parameters name on it's images. Other solution is to rename the variables in Nova 'Call' function to begin with '_' (underscore), but for that we also need to enforce Glance to now allow parameters beginning with '_' (underscore).14:05
Maddy What's your thoughts about that? Any better solution? In case not, what do you think about implementing one the above solutions?14:05
*** sree has joined #openstack-nova14:06
*** jpena|lunch is now known as jpena14:06
*** psachin has quit IRC14:06
*** afaranha has joined #openstack-nova14:10
*** sree has quit IRC14:10
*** diga has joined #openstack-nova14:11
*** felipemonteiro_ has joined #openstack-nova14:12
*** gouthamr has joined #openstack-nova14:13
*** felipemonteiro__ has joined #openstack-nova14:14
openstackgerritJay Pipes proposed openstack/nova master: tests for alloc candidates with nested and traits  https://review.openstack.org/53189914:14
openstackgerritJay Pipes proposed openstack/nova master: add test for scenario with sum of child resources  https://review.openstack.org/53433914:14
openstackgerritJay Pipes proposed openstack/nova master: _get_trees_matching_all_resources() sum children  https://review.openstack.org/53486614:14
openstackgerritJay Pipes proposed openstack/nova master: add _get_usages_from_trees() function  https://review.openstack.org/53496714:14
openstackgerritJay Pipes proposed openstack/nova master: validate provider summary structure  https://review.openstack.org/53651614:14
openstackgerritJay Pipes proposed openstack/nova master: WIP - populate alloc cands for trees  https://review.openstack.org/53496814:14
*** Zames has joined #openstack-nova14:15
*** psachin has joined #openstack-nova14:17
*** tbachman has quit IRC14:17
*** felipemonteiro_ has quit IRC14:18
*** Zames has quit IRC14:20
*** namnh has joined #openstack-nova14:20
openstackgerritJay Pipes proposed openstack/nova master: tests for alloc candidates with nested and traits  https://review.openstack.org/53189914:20
openstackgerritJay Pipes proposed openstack/nova master: add test for scenario with sum of child resources  https://review.openstack.org/53433914:20
openstackgerritJay Pipes proposed openstack/nova master: _get_trees_matching_all_resources() sum children  https://review.openstack.org/53486614:20
openstackgerritJay Pipes proposed openstack/nova master: add _get_usages_from_trees() function  https://review.openstack.org/53496714:20
openstackgerritJay Pipes proposed openstack/nova master: validate provider summary structure  https://review.openstack.org/53651614:20
openstackgerritJay Pipes proposed openstack/nova master: WIP - populate alloc cands for trees  https://review.openstack.org/53496814:20
*** amodi has joined #openstack-nova14:23
openstackgerritMerged openstack/nova-specs master: Add host info to instance action events  https://review.openstack.org/54327714:23
*** psachin has quit IRC14:23
jaypipesefried: ^^ I'm getting that nested providers in allocation candidates series back inline...14:27
efriedjaypipes: Cool dude.14:27
efriedDid you see my potentially earth-shattering dissenting opinion on the "split one resource across multiple providers" thing?14:28
jaypipesefried: no. link?14:28
efriedjaypipes: https://review.openstack.org/#/c/534339/ -- my last comment, on PS5 before rebases14:29
*** tssurya has quit IRC14:29
*** yamamoto_ has quit IRC14:30
*** amodi has quit IRC14:30
*** cfriesen has joined #openstack-nova14:31
*** jackie-truong has joined #openstack-nova14:32
*** moshele has quit IRC14:32
*** salv-orlando has quit IRC14:32
*** salv-orlando has joined #openstack-nova14:33
*** ccamacho has quit IRC14:33
*** ttsiouts_ has joined #openstack-nova14:33
*** felipemonteiro__ has quit IRC14:34
*** gyankum has quit IRC14:36
*** takedakn has joined #openstack-nova14:37
*** sree has joined #openstack-nova14:38
mriedemdansmith: replied in https://review.openstack.org/#/c/543277/14:38
mriedemstill don't see the need for hostId in the action events API, but people at the PTG wanted it14:38
dansmithmriedem: I'm commenting about the rst syntax, using `` instead of "14:38
mriedemoh, heh14:40
*** mlavalle has joined #openstack-nova14:40
mriedemi can push a doc cleanup patch on that14:40
kashyapmriedem: melwitt: Heya, I've read the full chat between you both, dansmith, et al (including the quip: "besides the fix, you can also configure nova for other goodies!").14:41
kashyapNot to discuss this to death, but 3 quick points:14:41
dansmithmriedem: that's all I was saying :)14:42
* kashyap copy / pastes the 3 points from editor:14:42
kashyap(1) I want to do the Right Thing & not rush anything in.14:42
kashyap(2) The two Nova config options thing just causes untold pain for all vendors with all their unique deployment tools; and just wastes precious time all around for little gain.14:42
kashyap(3) On your point: "well, what I mean is if you use it and it breaks something in queens/pike/ocata then we're probably not going to fix things to accommodate the various flags they enable" — That's a good point.  Yes, we have to loudly and clearly document that "NB: There's a huge combination of CPU flags possible, just by virtue of them being available in a given CPU.  It's not reasonable to14:42
kashyaptest all combinations; so if an Operator wants to try certain flags, it's their responsibility to test if that works in their environment".14:42
*** felipemonteiro_ has joined #openstack-nova14:42
* kashyap crawls back to his cave to address the technical bits14:43
openstackgerritChris Dent proposed openstack/nova master: Move placement exceptions into the placement package  https://review.openstack.org/54986214:44
kashyapmelwitt: mriedem: As a last point, as dansmith also said in different words on Friday here —14:44
*** tssurya has joined #openstack-nova14:44
kashyapIt is not sensible to create an intentionally incompatible syntax in the Nova config file when the actual Nova code to process the config options is largely identical in both cases.14:44
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276614:45
*** yamamoto has joined #openstack-nova14:46
*** salv-orlando has quit IRC14:46
*** sidx64 has quit IRC14:47
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143514:47
*** mlavalle has quit IRC14:47
*** salv-orlando has joined #openstack-nova14:47
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385714:47
*** mlavalle has joined #openstack-nova14:48
*** yamahata has joined #openstack-nova14:50
*** udesale has quit IRC14:50
openstackgerritLenny Verkhovsky proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264014:51
*** salv-orlando has quit IRC14:51
*** yamamoto has quit IRC14:51
*** sree_ has joined #openstack-nova14:52
*** sree_ is now known as Guest8244814:52
*** ccamacho has joined #openstack-nova14:53
*** chyka has joined #openstack-nova14:55
*** sree has quit IRC14:55
*** itlinux has joined #openstack-nova15:00
*** takedakn has quit IRC15:01
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Address review comments from afdc828db3c9d0205b6ded268db24f5cdf857fa6  https://review.openstack.org/55425115:01
*** mdnadeem has quit IRC15:03
*** yamamoto has joined #openstack-nova15:04
openstackgerritSilvan Kaiser proposed openstack/nova master: Exec systemd-run with privileges in Quobyte driver  https://review.openstack.org/55419515:04
*** felipemonteiro_ has quit IRC15:04
*** felipemonteiro_ has joined #openstack-nova15:05
*** takedakn has joined #openstack-nova15:05
*** elmaciej has quit IRC15:05
kaisers1efried: fyi https://review.openstack.org/#/c/554195/215:06
*** cdent has quit IRC15:06
openstackgerritEric Fried proposed openstack/nova master: Report client: Remove version discovery comment  https://review.openstack.org/55425315:06
efriedjaypipes, mriedem, cdent ^15:06
efriedkaisers1: ack15:06
efriededleafe: also --^15:06
cfriesenis github.com enforcing ssh versions now?  I just got a "Peer reports incompatible or unsupported protocol version."15:06
efriedCould that be what kashyap was running into earlier?15:07
kashyapefried: Probably; it's gone now.  I'm able to fetch 'https' from git.o.o.15:08
*** liverpooler has quit IRC15:08
kashyapcfriesen: I also had troubles this morning w/ GitHub as my 'origin' for Nova15:08
cfriesenlooks like they're "weak crypto" versions of https15:08
cfriesenbah, they're *disabling*15:09
kashyapYeah, apparently15:09
efriedCause it's crucial that the content of a public repo be strongly encrypted.15:09
efriedIs that, what, so we don't get MITMs injecting viruses into the codebase for us?15:10
*** dtantsur|brb is now known as dtantsur15:10
efriedtox -e py27 -- trojan_horse  ?15:11
jaypipesedleafe, cdent: do we have a bug in placement that diga might be able to pick up? he's looking for some work in placement/scheduler.15:11
cfriesenis it possible to use SSH URLs with github?15:12
*** abalutoiu has joined #openstack-nova15:12
cfriesenI don't see any on the nova page15:12
jrollcfriesen: yep, git@github.com:openstack/nova15:12
jrollneed to add your public key in settings15:13
edleafejaypipes: diga: there's always https://bugs.launchpad.net/nova/+bugs?field.tag=placement as a starting point15:13
cfriesenjroll: thanks15:13
jrollnp15:13
digaedleafe: Sure, will go through it15:13
*** amodi has joined #openstack-nova15:14
*** ameeda has quit IRC15:14
digajaypipes: Thank you for your help15:14
*** takedakn has quit IRC15:16
jaypipesdiga: if I come across something for you, I will let you know.15:16
digajaypipes: Sure15:17
*** cdent has joined #openstack-nova15:20
*** eharney has quit IRC15:21
digajaypipes: I also know NFV technologies like hugepages, numa, dpdk very well. If you have something on that, let me know15:21
*** germs has joined #openstack-nova15:22
*** germs has quit IRC15:22
*** germs has joined #openstack-nova15:22
jaypipesdiga: cool. can you review this spec please? https://review.openstack.org/#/c/552924/15:23
digajaypipes: sure15:24
*** eharney has joined #openstack-nova15:26
*** liverpooler has joined #openstack-nova15:26
*** germs has quit IRC15:26
Spaz-HomeMorning folks15:28
openstackgerritChris Dent proposed openstack/nova master: Move placement exceptions into the placement package  https://review.openstack.org/54986215:29
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276615:29
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143515:29
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385715:29
*** chyka has quit IRC15:30
*** chyka has joined #openstack-nova15:30
Spaz-HomeActually taking a relax weekend.. no coding.. just boiling 55 Habaneros, 2 Ghost Peppers, and trying to make a hot sauce without killing myself.  Enjoy your day Cloud Creators :p15:32
*** gjayavelu has joined #openstack-nova15:35
*** gjayavelu has joined #openstack-nova15:35
cdentjaypipes: what's the status of your "standardized provider descriptor file" spec/idea? Where on the scale or need<->experimental fishing is that?15:38
jaypipescdent: it's dead.15:38
*** Guest82448 has quit IRC15:38
jaypipescdent: I'll abandon it.15:38
cdentdead fish15:38
jaypipescdent: smelly dead fish.15:38
* cdent kinda liked it15:38
*** sree has joined #openstack-nova15:38
jaypipescdent: I did too :) but I understand why dansmith doesn't.15:39
*** kholkina has quit IRC15:40
*** elmaciej has joined #openstack-nova15:41
mriedemsahid: there are a couple of issues in the tests for https://review.openstack.org/#/c/497457/215:42
mriedemhttps://review.openstack.org/#/c/497457/15:42
mriedemsahid: specifically self.assertEqual(0, guest.migrate_configure_max_speed.called)15:42
mriedem.called is a boolean15:42
mriedemit's probably better to use guest.migrate_configure_max_speed.assert_not_called()15:43
*** sree has quit IRC15:43
mriedemif you're about done for the day i could clean those up and then just approve15:44
sahidoh i was sure of that "called" returns a number15:44
sahidno no, i will15:44
*** artom has joined #openstack-nova15:44
mriedemcall_count returns a number15:44
sahidbut thanks for asking :)15:45
sahidack15:45
*** diga has quit IRC15:45
mriedemthanks for finding that issue in the multinode job config15:45
*** jmlowe_ has quit IRC15:46
sahidmriedem: yeah, it's that g-api service which looked very strange15:46
*** felipemonteiro_ has quit IRC15:46
*** gjayavelu has quit IRC15:46
openstackgerritJay Pipes proposed openstack/nova master: validate provider summary structure  https://review.openstack.org/53651615:47
openstackgerritJay Pipes proposed openstack/nova master: WIP - populate alloc cands for trees  https://review.openstack.org/53496815:47
kashyapsahid: One more nit there: s/TAPs devices/TAP devices/ :-)15:47
kashyap(In driver.py)15:47
*** josecastroleon has joined #openstack-nova15:47
cfriesenhas anyone run into problems with setuptools recently?  I got a report that 39.0.1 didn't work with our version of pike, wondering if it's a general problem.15:48
sahidkashyap: :) sure i will address that too15:49
kashyapThx15:49
dansmithcfriesen: I had an issue downstream last week where the parse_version was returning a tuple instead of a string15:50
dansmithcfriesen: migi was looking at it, in case you or he know anything else15:50
*** Maddy has quit IRC15:52
*** ttsiouts_ has quit IRC15:53
cfriesendansmith: we ended up pinning it to 38.5.1 for now, which seems to work okay15:53
*** r-daneel has quit IRC15:54
*** markvoelker_ has joined #openstack-nova15:56
*** markvoelker has quit IRC15:56
*** tbachman has joined #openstack-nova15:57
*** sree has joined #openstack-nova15:57
*** gyankum has joined #openstack-nova15:59
*** markvoelker has joined #openstack-nova15:59
*** gyankum has quit IRC16:00
mriedemjaypipes: on that vmware resource pools spec, https://review.openstack.org/#/c/549067/6/specs/rocky/approved/vmware-resource-pool-placement.rst@21016:00
*** markvoelker_ has quit IRC16:01
mriedemjaypipes: finally just realized that this is proposing that the admin changes things *in vcenter*, not placement directly, and that's all proxied through the virt driver16:01
mriedemwhich kind of goes against something we've always said we woudn't do, which is support out of band changes on the hypervisor16:01
*** namnh has quit IRC16:02
*** dtruong has joined #openstack-nova16:02
cdentmriedem: I think those sorts of changes are pretty much why upt exists?16:02
cdentthe hardware underlaying the hypervisor changes in some fashion16:02
jaypipesmriedem: vcenter virt driver is virtually identical (pun intended) to how ironic virt driver wants to do things. i.e. the virt driver (not the compute service worker ala the resource tracker) creates the compute node resource provider records.16:02
cdentupt notices16:02
cdentefried: powervm is much the same, yeah? ^16:03
mriedemjaypipes: this isn't creating the compute node resource provider record,16:03
mriedemit's seeing, oh the admin created some resource pools in this cluster in vcenter directly, and now the virt driver needs to mirror that into placement,16:03
mriedemand what happens when the admin decides to delete those pools in vcenter? nova would also need to mirror that16:04
dansmithcdent: powervm only has one node16:04
*** salv-orlando has joined #openstack-nova16:05
mriedempowervm wants to manage shared storage pool aggregates from what i remember16:05
dansmithjaypipes: I read that spec as not exposing more nodes, but exposing a cluster as a very NUMA single node16:05
*** tbachman has quit IRC16:05
*** afaranha has quit IRC16:05
cdentdansmith: not talking about the node here, just what the node is aware of: efried has mentioned that the powervm driver wants to ... yeah what mriedem said16:05
*** sree has quit IRC16:05
dansmithmriedem: right, but not multiple nodes from one service as it stands in tree right now16:05
mriedemthese would be nested RPs16:05
dansmithyeah, I think jaypipes is saying multiple nodes a-la ironic16:06
*** tbachman has joined #openstack-nova16:06
dansmithand I don't think that's on the table for either16:06
mriedemcompute node RP (created by nova) -> nested tenant-specific resource pool providers, created by the virt driver, proxied from vcenter16:06
mriedemthe 1:M compute node thing isn't in this16:06
dansmithyep16:06
dansmithright16:06
cfriesenmriedem: is there anything in particular blocking https://review.openstack.org/#/c/465787/ ?  I notice it hasn't really gotten any reviews other than me.16:06
dansmithI think jaypipes was asserting that it was16:06
*** pcaruana has quit IRC16:07
jaypipesdansmith: sorry, on a video call for 45 mintues16:07
mriedemi guess since we don't model numa as a nested RP for the libvirt driver yet, i'm not sure how much proxy we'll be doing to compare to the vcenter thing16:07
dansmiththe difference here I think,16:07
dansmithis that libvirt will report the static nature of the system as nested NUMA RPs,16:08
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt  https://review.openstack.org/54423816:08
dansmithwhere vmware would be representing cluster config, which is mutable16:08
dansmithand I agree that sucks, and I don't know what would happen if vmware swizzled things after instances are booted16:08
dansmithbut..16:08
dansmithwhat we have today is also wrong (exposing a cluster as a single uniform set of resources)16:08
elodcfriesen: it's general and there's this patch https://review.openstack.org/#/c/554053/ (which unfortunately ends up in another bug with pip... see depends-on)16:09
*** salv-orlando has quit IRC16:09
mriedemthis spec also bakes business logic into the driver about how those resource pools are created in vcenter, i think16:10
cdentdansmith: since I'm not aware of the many bits of history involved with this stuff (either internal or external to vmware) why is that "wrong" instead of "different"?16:10
mriedembasically based on the name of the resource pool, it's encoded into the pool name which tells the virt driver what to do about it16:10
*** lpetrut_ has quit IRC16:10
dansmithcdent: because you can't schedule instances to it that span what nova thinks are uniform resources16:10
dansmithcdent: at least, that's my understanding of it at the moment16:11
openstackgerritLee Yarwood proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens  https://review.openstack.org/54356916:11
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver  https://review.openstack.org/52609416:11
dansmithcdent: i.e. if you have a cluster with two 1G nodes, nova thinks you should be able to boot a 2G instance there but you can't16:11
cdentthat's recently fixed via inventory handling with max_unit16:12
dansmiths/fixed/hacked16:12
cdentno16:12
*** tbachman has quit IRC16:12
cdentyou're asserting that targeting a cluster is wrong, and what I'm trying to understand why that's wrong16:12
dansmithit is a hack, because if you have memory available on one and cpu available on another, you can't represent that16:12
dansmithno, that's not what I'm saying16:12
dansmithI'm saying nova thinks the cluster is a single bag of resources that can be combined and that's wrong16:13
dansmithand I'm saying that I think the spec we're discussing is trying to rectify that by using multiple providers with the proper amounts of inventory each16:13
mriedemyeah it's trying to break the single cluster into multiple pools16:14
cdentthe spec is trying to allow resource pools (a vmware thing that enables tenanted clusters) to work16:14
mriedembut it's also tying those pools to specific tenants16:14
mriedemlike the aggregate multitenenancy isolation filter16:14
mriedemi think16:14
dansmithif it's purely for the tenantization, then that's not what I think it's trying to do, and isn't really a thing the virt driver should be doing16:14
cdentthere will likely be other specs that try to turn clusters into hierarchies of nested providers so that an esxi host works much the same as targeting a particular numa setup16:14
dansmith^that is what I thought the actual goal was under the covers16:15
mriedemso if the admin creates a resource pool A_foo in cluster 1, i think it means that nova is supposed to restrict all requests from tenant foo to resource pool A_foo in cluster 116:15
dansmithbut if not, that's disappointing16:15
cdentokay, stepping back a bit: why do we care what a virt driver does if it follows the interface and allows things to land16:15
cdentI'm asking that as a real question, not as a rhetorical device16:15
dansmithbecause nova is an abstraction?16:16
cdentright, if the abstraction works and continues to work, what does it matter?16:16
dansmiththe virt driver has to do more than mechanically implement the python interface to be something that a user can depend on16:16
*** fragatina has joined #openstack-nova16:16
*** s1061123 has quit IRC16:17
dansmithas an example, it doesn't work properly right now but it does implement the interface16:17
cdentand it is working to get better16:17
cdentusing the tools that the interface provides16:17
dansmiththis tenant grouping doesn't make it better16:17
dansmithit makes it more different in behavior than the others16:17
mriedemmaybe the tenant isolation part of this should be split out16:18
*** salv-orlando has joined #openstack-nova16:18
mriedemso it's just a generic way to model nested resource pools in a single cluster (which is represented by the compute node provider root in nova)16:18
mriedemand then the compute node RP for vmware doesn't have cpu/ram/disk, the nested resource pool providers do16:18
*** gjayavelu has joined #openstack-nova16:18
*** rmart04 has quit IRC16:19
mriedemand then later bake tenant isolation logic into it16:19
mriedemsorry for the bad timing but i've got a thing i've got to run to, back in awhile16:19
*** mriedem is now known as mriedem_away16:19
dansmithat that point, the tenant isolation becomes much the same problem as efried pointed out with ensuring that you get CPU and memory from the same numa node on a regular box,16:19
dansmithwhich probably helps, if we decide that the virt drivers should draw aggregates around those groupings or whatever,16:19
dansmithor something16:20
cdentI suspect the tenant isolation is on the spec at all so that the resource pool stuff can be justified: it's a use case for wanting to represent resource pools16:20
cdentif that's needed and reasource pools are groovy, that's great16:20
*** ragiman has quit IRC16:20
efriedAs I commented on https://review.openstack.org/#/c/534339/ the 1GB-from-each-of-two-children-to-make-one-2GB-instance thing shouldn't be a problem.16:20
efriedBUT the "get my CPU from one RP and my disk from another" would be.16:20
dansmithefried: currently the former is a problem with the vmware driver AFAIK16:21
dansmithcdent: implementing the structurally separated resources in a cluster as nested providers of the root would make progress towards fixing that ^ and then makes the tenant isolation thing a smaller delta we can probably have a more reasonable discussion over16:22
efriedTo mitigate in UPT-land, you would have to do subtree lassoing like we talked about needing for NUMA; or you would have to model the cluster members as NOT being in the same tree.16:22
cdentdansmith: that's not what the spec does16:22
cdentresource pools are not physical16:22
dansmithefried: that's what I'm saying would be an improvement over what it does today16:22
efriedwhich one dansmith?16:22
cdentif you have a problem with the cluster presented agglomerated resources as a single thing, then you'd have a problem with resource pools too16:22
dansmithefried: representing cluster members as children under the root16:23
*** yamamoto has quit IRC16:23
cdentmax_unit, on either the cluster or the resource pool "fixes" that16:23
efrieddansmith: Only if we have the subtree-lassoing technology.  I haven't caught up on my specs yet - did someone propose that yet?16:23
dansmithcdent: max_unit does not prevent nova from thinking it can get cpu and memory from two different cluster members16:23
efriedAgree ^^16:23
cdentdansmith: yes, and?16:24
dansmithefried: right, I'm assuming the lassoing thing as well as changing this vmware RP exposure.. the two together would be required16:24
dansmithcdent: so max_unit has not "fixed" the vmware driver reporting a whole cluster as a single RP/node16:24
efriedIn that case, yes, I agree we can do this with nested.16:24
cdentthe only way we get what you seem to want is for every esxi host to represent all its resources, which breaks the DRS, unless the virt driver can write allocations16:25
dansmithcdent: yeah, I think we've asserted that DRS under nova is broken, for that reason exactly16:25
dansmithbroken fundamentally I mean16:25
efriedcdent: I thought we talked about the fact that you want to hide the whole cluster-ness anyway?16:25
*** jackie-truong has quit IRC16:26
efriedRepresent the whole thing as a single RP, and then vmware virt would do the individual node business under the covers.16:26
cdentefried: yes, dan's saying that's broken16:26
dansmithefried: that's what it does today, and it's breakable16:26
dansmithefried: because nova will not know that one node is out of CPU but has some memory available, where another node has the opposite.. nova will think it can schedule to that, but it can't16:26
gjayavelu@cdent @dansmith @efried I'm catching up on the discussions about the resource pools spec16:27
*** andreas_s has quit IRC16:27
*** r-daneel has joined #openstack-nova16:27
efrieddansmith: Okay, I agree with that.  But I think the virt can probably mitigate16:27
dansmithefried: it can't16:27
efried...by cleverly spoofing the inventories.16:27
dansmithoh, it could work around it that way sure16:28
*** andreas_s has joined #openstack-nova16:28
dansmiththat's fairly wasteful though :)16:28
efriedBasically by representing the least common denominator of the pool, as the inventory.16:28
efriedIs it?16:28
*** tbachman has joined #openstack-nova16:28
dansmithsure16:28
efriedBecause you wouldn't be able to schedule more than that anyway, wouldja?16:28
dansmithwell, maybe you're right16:28
cdentyeah, you either fail to get allocation candidates, or you fail later16:29
dansmithwell, no,16:29
cdentbetter to fail to get allocation candidates16:29
*** lajoskatona has quit IRC16:29
dansmithyou could have a node with small memory, small cpu, lots of disk, and another node with zero disk but lots of other resources.. you have to report yourself as fully committed at that point right?16:29
efriedOkay, I see, if you had one node with 1VCPU/1024MEM and one with 2VCPU/512MEM, you would wind up representing 1/512 even though you could technically schedule 1/1024 or 2/512.16:29
dansmithcdent: also that16:29
efrieddansmith: Yeah, I think we're saying the same thing.16:30
dansmithyar16:30
*** s1061123 has joined #openstack-nova16:30
cdentat the moment that is an accepted shortcoming16:30
cdentmostly because the common case is for everything in the cluster to be the same16:30
efriedYeah, was gonna say, homogeneity would make most of the issue moot.16:30
dansmithright but your flavors have to basically fit together perfectly like puzzle pieces to avoid too much fragmentation16:31
cdentENOPARSE16:31
openstackgerritsahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready  https://review.openstack.org/49745716:31
efriedI think it's a pretty solid 80/20 that's worth going forward with.16:31
efriedHypothetically the DRS will also reshuffle things to maintain/restore homogeneity, nah?  That's kind of its job?16:32
cdentyes16:32
cdentwell16:32
cdentit will shuffle things. but it can't move hardware16:33
efriedunderstood.16:33
dansmiththat doesn't fix anything if your flavors are different sizes16:33
efriedIt can16:33
efriedbecause it can consolidate VMs in ways that maximize utilization of a node.16:33
efriedIf it's clever enough.16:33
dansmithit may be able to if things fit right, yes16:34
cdenteven if its not clever enough, if vmware is being wasteful, that's vmware's problem, right?16:34
efriedBut anyway, IMO it's acceptable to state that we know this solution is not 100% perfect, and move forward with it, because it will work *mostly* well, *most* of the time.16:34
openstackgerritMerged openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot"  https://review.openstack.org/55303516:34
*** jpena is now known as jpena|brb16:43
*** andreas_s has quit IRC16:45
melwittcool, thanks gibi16:46
melwittgibi, bauzas: I'd like to bring to your attention the draft for runways during the rocky cycle, if you have any feedback about it https://etherpad.openstack.org/p/nova-runways-rocky I'd like to kick of the process later this week so we can try it out and adjust it as we go16:48
*** gyee has joined #openstack-nova16:49
*** dikonoor has joined #openstack-nova16:51
*** AlexeyAbashkin has quit IRC16:51
gibimelwitt: I opened that etherpad and I will try to check it tomorrow16:53
*** hemna_ has joined #openstack-nova16:53
*** fragatina has quit IRC16:53
gibimelwitt: seem like a pretty comprehensive doc16:53
melwittgibi: cool, thanks. yeah, there's been a lot of feedback already last week, so np if there's nothing else you'd like to add or ask16:54
gibimelwitt: I will try to read it anyhow :)16:55
melwittthanks. I'll ping bauzas again tomorrow as it looks like he's on PTO today16:55
*** cdent has quit IRC16:55
*** sahid has quit IRC16:56
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver  https://review.openstack.org/52609416:57
*** fragatina has joined #openstack-nova16:58
gibimriedem_away, alex_xu_ , mlavalle: thanks for the awesome review feedback on the bandwidth spec. I tried to answer the questions inline https://review.openstack.org/#/c/50230616:58
mlavallegibi: will take a look again soon. Thanks!16:59
*** jackie-truong has joined #openstack-nova16:59
gibimlavalle: thanks17:00
*** gjayavelu has quit IRC17:01
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Remove version/date from CLI documentation  https://review.openstack.org/55390317:03
*** weshay is now known as weshay_brb17:05
*** yamahata has quit IRC17:05
*** dtruong has quit IRC17:05
*** elmaciej has quit IRC17:09
jaypipessorry y'all. off phone call now. reading back..17:10
*** diranerpi has quit IRC17:10
*** lpetrut has joined #openstack-nova17:12
tssuryadansmith: I had a question about the reset cache implementation on the scheduler manager as a part of the cell disable spec, is it a good time now ? If you are busy I can come back later17:13
dansmithtssurya: sure17:14
tssuryaSo I was implementing the reset cache option on the scheduler manager , however when using the scheduler client from nova manage to call this reset on the cache in the manager, doesn’t this become an upcall which we don’t support ?17:14
tssuryaor am I not supposed to call this using the client from nova-manage ?17:15
dansmithtssurya: I was saying this should be done in a reset() handler on scheduler manager, which gets triggered on SIGHUP17:15
dansmithtssurya: correct, not from nova-manage or anything else, I thought I commented to that effect on the spec17:15
tssuryayes you did, I guess I didn't understand the SIGHUP very well17:15
dansmithtssurya: this is the example of a similar thing we have: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L543-L54617:15
dansmithtssurya: so you can SIGHUP compute manager now to get it to clear the service version cache and rpc pin, which is the same sort of activity you're doing17:16
tssuryaright,17:17
tssuryaI need to "SIGHUP" the scheduler manager basically17:17
dansmithtssurya: yeah, we have a couple other signal handlers for things like guru meditation, etc17:20
*** cdent has joined #openstack-nova17:29
*** esberglu_ has joined #openstack-nova17:32
*** eharney has quit IRC17:33
lennybHi, my nova instance got stuck in 'deleting' when I try to delete instance that failed to be deployed via ironic n-cell-child.service.log17:33
lennyb   http://paste.openstack.org/show/704774/17:33
*** gjayavelu has joined #openstack-nova17:34
*** elmaciej has joined #openstack-nova17:35
*** esberglu has quit IRC17:35
*** jpena|brb is now known as jpena17:37
*** mriedem_away is now known as mriedem17:37
*** jmlowe has joined #openstack-nova17:38
openstackgerritEric Fried proposed openstack/nova-specs master: Mention (no) granular support for image traits  https://review.openstack.org/55430517:41
*** suresh12 has joined #openstack-nova17:41
*** jackie-truong has quit IRC17:41
*** oomichi has joined #openstack-nova17:42
*** jackie-truong has joined #openstack-nova17:42
efriedjaypipes, mriedem: ^17:42
*** felipemonteiro_ has joined #openstack-nova17:43
*** mvk has quit IRC17:44
*** dikonoor has quit IRC17:45
oomichimelwitt: cdent: hi, do we have an approval at the PTG for https://blueprints.launchpad.net/nova/+spec/placement-extract ?17:46
jaypipesdansmith, mriedem: would you mind looking at https://review.openstack.org/#/c/534339/ please and letting me know if you agree with efried? I'm thinking I agree with him and if so, will abandon that and the following patch to it.17:46
cdentoomichi: the decision at ptg was to make progress in rocky, but not complete it, and not as a priority17:46
*** eharney has joined #openstack-nova17:47
oomichicdent: I see, thanks. I just wanted to see the bp as approved17:47
cdentoomichi: I didn't actually create the bp until late last week, because efried suggested it would be useful. We hadn't really declared "let's have one" but it does seem like a good idea.17:48
*** jamesdenton has joined #openstack-nova17:49
*** suresh12 has quit IRC17:49
melwittoomichi, cdent: yeah, seems useful to have it to track the work. I'll approve it17:50
oomichicdent: yeah, bp is good for tracking patches17:50
oomichimelwitt: cool, thanks :)17:50
*** weshay_brb is now known as weshay17:50
*** suresh12 has joined #openstack-nova17:51
*** suresh12 has quit IRC17:52
*** suresh12 has joined #openstack-nova17:52
*** suresh12_ has joined #openstack-nova17:53
*** suresh12 has quit IRC17:53
efriedcdent, jaypipes: (how) does forbidden traits play into glance image traits?17:55
cdentefried: i would guess the same as flavors? I haven't put that much thought into that side of things, just the api side17:57
jaypipesefried: I would expect that the format of specifying a forbidden trait would be the same. I would also expect that if there was a conflict between flavor's forbidden traits and image required traits (and vice versa), that we would bomb out.17:57
efriedcdent: Oh, right (rereading the spec now), we haven't even tried to talk about how forbidden traits will be expressed in flavors, have we?17:57
efriedIs that simply not planned for R?17:58
* cdent doesn't know17:58
*** germs has joined #openstack-nova17:58
*** germs has quit IRC17:58
*** germs has joined #openstack-nova17:58
jaypipesefried: I would have thought that s//required/forbidden in the extra spec value field would be how we'd do it.17:59
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready  https://review.openstack.org/49745717:59
*** mvk has joined #openstack-nova17:59
*** lpetrut has quit IRC17:59
*** jackie-truong has quit IRC18:00
*** moshele has joined #openstack-nova18:02
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Fix typos in release notes  https://review.openstack.org/55417518:02
*** germs has quit IRC18:03
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot"  https://review.openstack.org/55381718:06
*** lpetrut has joined #openstack-nova18:06
*** elmaciej has quit IRC18:06
*** avolkov has quit IRC18:07
*** tesseract has quit IRC18:07
melwittdansmith, mriedem: looks like we have an interesting bug here during an upgrade ocata -> pike where while reading a service record, if it doesn't have a uuid, we generate one and try to save it back to the object, but that fails with "Can't upgrade a READER transaction to a WRITE" because a read will start off with @pick_context_manager_reader and we can't upgrade to a writer in the middle of the transaction https://bugs.launchpad.net/n18:09
melwittova/+bug/1746509/comments/418:09
melwittdangit18:09
melwitthttps://bugs.launchpad.net/nova/+bug/1746509/comments/418:09
openstackLaunchpad bug 1722404 in OpenStack Compute (nova) ocata "duplicate for #1746509 Database transactions can fail with "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" because of scatter_gather_cells" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem)18:09
*** dtantsur is now known as dtantsur|afk18:09
dansmithhmm, I'm not sure why it'd be different for scatter/gather18:10
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot"  https://review.openstack.org/55381718:10
*** tbachman has quit IRC18:11
melwittI don't think it's different. I think this is a separate different bug, but was highlighting the comment where someone explained what was going on18:11
*** moshele has quit IRC18:11
dansmithyeah, that explanation makes sense but I'm not sure why we weren't hitting that immediately is what I mean18:11
melwittI think we fixed the scatter gather problem but this service record thing is separate and different18:11
melwittoh18:12
*** eharney has quit IRC18:12
*** sambetts is now known as sambetts|afk18:12
melwittI assume we were ... trying to think if this scenario is covered by grenade or how it wouldn't be18:13
dansmithwell, it should have manifested even in functional tests I would think18:13
dansmithwe must be in a nested call where we're already in a reader transaction and we call to do a write, right?18:14
melwittyeah, that would be the condition for that error being raised18:14
dansmithblanking out the context dumps that so we get a new transaction for the write18:14
*** esberglu_ is now known as esberglu18:16
*** sridharg has quit IRC18:16
melwittyou mean the way that the commenter patched nova/objects/service.py? yeah18:18
dansmithyeah they used a new context18:18
melwittyeah18:19
*** AlexeyAbashkin has joined #openstack-nova18:20
*** AlexeyAbashkin has quit IRC18:24
*** eharney has joined #openstack-nova18:26
*** dave-mccowan has joined #openstack-nova18:28
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot"  https://review.openstack.org/55381818:31
*** wolverineav has joined #openstack-nova18:32
*** moshele has joined #openstack-nova18:32
*** felipemonteiro__ has joined #openstack-nova18:32
*** wolverineav has quit IRC18:33
*** wolverineav has joined #openstack-nova18:33
openstackgerritMatt Riedemann proposed openstack/nova master: Use Queens UCA for nova-multiattach job  https://review.openstack.org/55431718:35
*** vladikr has quit IRC18:36
*** felipemonteiro_ has quit IRC18:37
mriedemdansmith: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128487.html for the setuptools thing you were talking about before18:37
mriedempkg_version18:37
dansmithah cool18:37
dansmithmigi: ^18:37
*** tssurya has quit IRC18:38
dansmithmriedem: did you see my comment on that patch for the obj_relationships thing?18:38
mriedemnot yet18:39
*** vladikr has joined #openstack-nova18:40
melwittdansmith: from what I can tell, we only have unit test coverage for the uuid generation for service where things are mocked (and would anyway be a write to begin with), or calling _from_db_object selectively https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_service.py#L14518:44
melwittto hit this, we'd have to have a functional test scenario where we read an already existing service record that has no uuid18:44
melwittI can try writing one18:45
*** yamahata has joined #openstack-nova18:46
dansmithhmm, I thought we did18:47
dansmithbecause that was mriedem18:47
dansmithand he looooves functional tests18:47
dansmithI would also have expected to hear more noise about this18:47
dansmithlike, wouldn't the first compute startup after that patch merged cause nova-compute to not update its service record?18:48
*** openstackgerrit has quit IRC18:48
mriedemit was dtp with me helping, but it's a pretty established pattern,18:49
mriedemi.e. he copied it from compute_nodes.uuid, and aggregates.uuid18:49
dansmithyeah18:49
dansmithwas just lookin gup the commit18:50
* melwitt looks around18:50
mriedemalso https://github.com/dpeschman18:50
mriedemhttps://avatars3.githubusercontent.com/u/145098?s=400&v=418:50
mriedemi would like to know what's going on there18:50
melwittlol18:50
dansmitheven still,18:51
dansmithwe're out of the db context at that point, so I'm not sure why this is happening anyway18:52
dansmithout of the pick_context_manager I mean18:52
*** tbachman has joined #openstack-nova18:52
*** krtaylor has joined #openstack-nova18:59
*** suresh12_ has quit IRC18:59
*** suresh12 has joined #openstack-nova19:00
*** suresh12 has quit IRC19:04
*** jmlowe has quit IRC19:05
*** READ10 has quit IRC19:05
*** READ10 has joined #openstack-nova19:06
*** jmlowe has joined #openstack-nova19:07
*** openstackgerrit has joined #openstack-nova19:11
openstackgerritMerged openstack/nova-specs master: Update placement aggregates spec to clarify generation handling  https://review.openstack.org/54823719:11
*** suresh12 has joined #openstack-nova19:13
*** jpena is now known as jpena|off19:15
*** suresh12 has quit IRC19:17
*** AlexeyAbashkin has joined #openstack-nova19:20
openstackgerritDan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method  https://review.openstack.org/54472819:23
openstackgerritDan Smith proposed openstack/nova master: Add aggregates list to Destination object  https://review.openstack.org/54472919:23
openstackgerritDan Smith proposed openstack/nova master: Add request filter functionality to scheduler  https://review.openstack.org/54473019:23
openstackgerritDan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions  https://review.openstack.org/54799019:23
openstackgerritDan Smith proposed openstack/nova master: [WIP] Add require_tenant_aggregate request filter  https://review.openstack.org/54500219:23
openstackgerritDan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement  https://review.openstack.org/54628219:23
*** felipemonteiro_ has joined #openstack-nova19:24
*** fragatina has quit IRC19:24
*** AlexeyAbashkin has quit IRC19:24
*** felipemonteiro_ has quit IRC19:25
*** felipemonteiro_ has joined #openstack-nova19:25
*** jmlowe has quit IRC19:26
*** felipemonteiro__ has quit IRC19:27
*** jmlowe has joined #openstack-nova19:27
*** suresh12 has joined #openstack-nova19:29
*** moshele has quit IRC19:29
*** suresh12 has quit IRC19:30
*** suresh12 has joined #openstack-nova19:30
mriedemdebugging weirdness during live migratoin would be a lot easier if we had thread ids in the logs...19:35
*** liverpooler has quit IRC19:36
*** vladikr has quit IRC19:36
*** vladikr has joined #openstack-nova19:39
mriedemsean-k-mooney: do you know if unbinding a port makes it automatically go to status=DOWN?19:40
*** ociuhandu has joined #openstack-nova19:41
*** _pewp_ has quit IRC19:41
*** tssurya has joined #openstack-nova19:42
mriedemsean-k-mooney: https://review.openstack.org/#/c/434870/11/nova/compute/manager.py@112619:44
mriedemseeing issues during live migration where we handle the migration completed lifecycle event from the hypervisor and start unbinding the port while we're also going through _post_live_migration19:44
mriedemwe blow up trying to unplug an unbound VIF19:45
sean-k-mooney[m]Im not sure. The status of an unbound port does not really have a meaning as it is effectively just a db entry when unbound. E. G. It dose not exist on the datapath when unbound.19:45
mriedemi ask because of https://github.com/openstack/neutron/blob/f2dced777acb7d87dc7048c3efec59dadf37930d/neutron/notifiers/nova.py#L18619:45
*** _pewp_ has joined #openstack-nova19:45
mriedemi'm seeing mysterious network-vif-plugged and network-vif-unplugged events around the time of the failure19:45
mriedembut they are coming before we unplug vifs on the source host19:46
mriedemmight be getting network-vif-plugged events on the source host from when they were plugged on the dest host in pre_live_migration,19:47
mriedemthe events are going to be routed to where the instance currrently lives, which is the source host until we switch19:48
*** openstackgerrit has quit IRC19:48
*** felipemonteiro__ has joined #openstack-nova19:48
mriedemthen we live migrate the guest,19:48
mriedemget the 'migration completed' lifecycle event from the hypervisor and start unbinding the port,19:49
dansmithmriedem: once there is a migration record, they'll be routed to both hosts19:49
sean-k-mooney[m]Well in the old workflow we don't unbind the port. We just update the host in the binding details. Yes i think the vif plugged events are from when the destination vif is plugged19:49
mriedemok, i was only checking the source host logs, can check the dest host logs19:49
*** bswrchrd has joined #openstack-nova19:50
mriedemsean-k-mooney[m]: this is the patch causing problems right now https://review.openstack.org/#/c/434870/19:50
mriedemthe thing that tried to do the early switch once were in post-copy19:50
mriedem*once we were in19:50
jrolljaypipes: dansmith: this is roughly what I recall from PTG about ironic RT stuff, does it make sense to you? https://review.openstack.org/#/c/545479/19:50
*** felipemonteiro_ has quit IRC19:52
mriedemdansmith: hmm, not seeing the same event routed to both hosts19:53
mriedembut we should have a migration record at this point because i see on the dest host logs that we've plugged the vifs there in pre_live_migration19:53
dansmithmriedem: hang on I'm piecing this back together in my head just a sec19:55
dansmithjroll: ack, will look ater19:55
dansmithmriedem: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4547-L455919:56
jrollthanks19:56
*** slagle has quit IRC19:56
mriedemfwiw, i don't see https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4556 in the logs19:56
dansmithmriedem: it will require migration_context to be set19:56
mriedemyeah that doesn't show up in the n-api logs http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-n-api.txt.gz19:56
mriedemdo we not lazy-load migration_context?19:56
dansmithokay, so maybe we haven't set migration context yet?19:56
dansmithmriedem: we query for it specifically in the api side:19:56
dansmithhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_external_events.py#L59-L6119:56
mriedemyup19:56
dansmithmore likely we haven't .save()d it yet or something19:57
mriedemi only see apply_migration_context called in evacuate and resize flows, not live migration,19:58
mriedemis it set in the RT?19:58
dansmithnot that I know of, so maybe we never set it for live migration?19:58
*** slagle has joined #openstack-nova19:58
sean-k-mooney[m]Right so it kindof makes sense when you activate the binding on the destination it deactivates the binding for the source which i guess results in vif unbound for the old host. How are we getting the vif on the source node that we pass to _nova_to_osvif_vif_unbound we should probably be cache the original vif object in the migration object19:59
mriedemright we don't do a move_claim for live migration,19:59
mriedemand RT.move_claim is what sets migration_context on the instance19:59
*** felipemonteiro__ has quit IRC19:59
*** germs has joined #openstack-nova20:00
mriedemsean-k-mooney[m]: heh way ahead of you https://review.openstack.org/#/c/515423/10/nova/objects/migrate_data.py@47 :)20:00
*** felipemonteiro_ has joined #openstack-nova20:00
*** felipemonteiro_ has quit IRC20:00
*** felipemonteiro_ has joined #openstack-nova20:01
sean-k-mooney[m]:)20:01
mriedemartom: fyi re the migration_context thing, since you wrote https://review.openstack.org/#/c/371048/20:02
mriedembut i think ^ was just for evac cases,20:02
mriedemwhere the source is dead so we can't rpc there20:02
dansmithblast from ye olde past20:02
mriedemreminds me i need to touch up some dings in the woodwork with olde english20:03
*** germs has quit IRC20:04
*** sean-k-mooney2 has joined #openstack-nova20:04
*** felipemonteiro__ has joined #openstack-nova20:06
*** jackie-truong has joined #openstack-nova20:06
*** felipemonteiro_ has quit IRC20:09
*** arvindn05 has joined #openstack-nova20:11
SamYapleother than a --hard reboot, is there a way to regenerate the libvirt.xml config? we changed the vnc listening address but we cannot migrate/live-migrate some instances due to pci passthrough of a sata controller20:12
*** awaugama has quit IRC20:13
sean-k-mooney2SamYaple: there is no way via nova to regenerate the xml that wont be equivalent to a reboot if you cant live migrate20:14
sean-k-mooney2SamYaple: you could likely just do a domain xml update out of band.20:14
*** ociuhandu has quit IRC20:14
SamYapleyea unfortunately not, but not for technical reasons20:15
SamYaplesean-k-mooney2: awesome. thought not. thanks for confirming20:15
sean-k-mooney2SamYaple: if you update the vnc adress in the nova.conf you will also need to restart nova compute as i dont think that is one of the mutable config options either.20:16
SamYapleoh no worries. its all rolled out, just in the "applying" phase20:17
SamYaplewe already live-mgirated 90% of the instances20:17
*** sree has joined #openstack-nova20:21
*** oomichi has quit IRC20:21
*** AlexeyAbashkin has joined #openstack-nova20:21
*** Sukhdev_ has joined #openstack-nova20:25
*** sree has quit IRC20:25
*** AlexeyAbashkin has quit IRC20:26
mriedemsean-k-mooney[m]: yeah so i think changing the port binding changes the status,20:26
mriedemthis is the source host neutron agent 2 seconds after nova updated the port binding to point at the dest host20:27
mriedemhttp://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-q-agt.txt.gz#_Mar_19_14_25_08_37452320:27
mriedembinding host and status changes on the port in there20:27
*** eharney has quit IRC20:28
mriedemwhich according to this: https://github.com/openstack/neutron/blob/f2dced777acb7d87dc7048c3efec59dadf37930d/neutron/notifiers/nova.py#L186 will trigger a network-vif-unplugged event20:28
sean-k-mooney2right so looking at that ports binding_details its an ovs vif with ovs_hybrid_plug": true so os-vif will plug the vif on the destination ovs during pre livemigrate and neutron will emit the vif plugged events as it wires them up20:29
mnaserdoes anyone know if there's some sort of variable you can use in docs to output the current version/release20:30
mnaserreason - https://docs.openstack.org/nova/queens/cli/nova-manage.html -- this doc and many others have old versions listed20:30
mnaseri can update it manually but it'll probably be forgotten again :>20:30
mriedemmnaser: https://review.openstack.org/#/c/553903/20:31
mnasermriedem: oh well there you go, that's a solution20:32
sean-k-mooney2mriedem: ok so the vif plugged event is coming from the pre livemigrate when os-vif adds the port to ovs and the unplug event is coming form activateing the binding on the destenation host. is that the order it happens in20:33
*** lpetrut has quit IRC20:34
*** lpetrut has joined #openstack-nova20:34
*** openstackgerrit has joined #openstack-nova20:35
openstackgerritMerged openstack/nova master: Don't filter out sibling sets with one core  https://review.openstack.org/53736120:35
mriedemsean-k-mooney2: yes i think so,20:37
mriedemsean-k-mooney2: i'm confused as to why neutron thinks the port is unbound though20:37
mriedemthis is on both the source and dest neutron agent20:37
mriedemhttp://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-q-agt.txt.gz#_Mar_19_14_25_08_82175420:37
mriedemhttp://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/subnode-2/screen-q-agt.txt.gz#_Mar_19_14_25_09_15048320:37
sean-k-mooney2subnode-2 is the source node correct20:38
mriedemyes20:38
sean-k-mooney2this is where the vif is pulled on the destination in prelivemigrate http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-n-cpu.txt.gz#_Mar_19_14_25_03_10524520:38
mriedemthis is where the source n-cpu changes the port binding host_id to the dest host http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/subnode-2/screen-n-cpu.txt.gz#_Mar_19_14_25_06_83868120:41
mriedemin q-svc, i see this http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-q-svc.txt.gz#_Mar_19_14_25_06_99110620:41
mriedemDevice cd0afcf3-c654-488e-b578-6d3c45f3a5a5 not bound to the agent host ubuntu-xenial-rax-dfw-000305555020:41
mriedemso i guess that's why the vif type is 'unbound'?20:42
mriedembut i'm not sure why that is because we plugged the vif on the dest host before all that20:42
sean-k-mooney2well this is where we plug it on the destination in the q-agt log http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-q-agt.txt.gz#_Mar_19_14_25_03_12695220:48
sean-k-mooney2and then right after it updates the vif_type to unbound http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/screen-q-agt.txt.gz#_Mar_19_14_25_04_00823420:49
openstackgerritMerged openstack/nova master: Ensure emulator threads are always calculated  https://review.openstack.org/53736320:49
openstackgerritMerged openstack/nova master: [libvirt] Add _get_numa_memnode()  https://review.openstack.org/52990620:50
mriedemsean-k-mooney2: hmm yeah wtf20:50
sean-k-mooney2so its the neutron agent on the destination that is seting the status to down and vif_type to unbound.20:50
*** gouthamr has quit IRC20:51
*** jmlowe has quit IRC20:51
sean-k-mooney2it kind of makes sense. at this point the vif is still bound on the host and we have not activated the vif on the dest but we just plugged it20:51
mriedemthis is all before nova hits the lifecycle post-copy event and switches the port binding, so presumably this already all happens today during live migration20:51
openstackgerritEd Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c  https://review.openstack.org/55435720:51
edleafeefried: ^^ gift-wrapped just for you20:51
*** fragatina has joined #openstack-nova20:52
sean-k-mooney2mriedem: do we do the vif plugging in pre_livemigrate today or is it down after we bind the port on the destination after livemigration  completes20:52
mriedemthe dest host plugs the vif in pre_live_migration today20:53
mriedemsource rpc calls to dest pre_live_migration, and then once that rpc call returns, the source starts live migrating the guest in the hypervisor20:53
sean-k-mooney2ok so ya we should be seeing the same bevavior.20:54
mriedemthis was part of the thing where the source host needs to wait for the vif plugged event from the dest20:54
*** tbachman has quit IRC20:54
mriedembefore it starts transferring the guest20:54
mriedemi haven't coded that part up yet20:54
mriedemfor all i know, given https://review.openstack.org/#/c/553035/ - can we even reliably wait for vif-plugged on the source if the host binding hasn't changed?20:55
sean-k-mooney2when you call self.network_api.migrate_instance_finish(context, instance,...) does that activate the port binding on the dest20:55
mriedemor will opendaylight never send a vif-plugged event in that case?20:55
mriedemsean-k-mooney2: it switches the binding host_id yeah, sec20:55
*** pchavva has quit IRC20:55
*** amoralej is now known as amoralej|off20:55
mriedemhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L257720:56
mriedemin this case, that host variable is the dest host20:56
mriedemthat's what we see here http://logs.openstack.org/71/551371/6/check/legacy-tempest-dsvm-multinode-live-migration/4d466b2/logs/subnode-2/screen-n-cpu.txt.gz#_Mar_19_14_25_06_83868120:56
mriedemon the source host20:56
sean-k-mooney2mriedem: im not sure if odl will remit the event but i dont think that would be an unreasonable expectation.20:57
mriedemsean-k-mooney2: from what i remember of the discussion leading up to https://review.openstack.org/#/c/553035/ with mnaser, ODL will only emit events for host binding changes, not vif unplug/plug20:57
*** _ix has joined #openstack-nova20:58
mriedemwhich really kind of kills us as the consumer of this workflow...20:58
sean-k-mooney2yes and when we activate the binding for the dest that should be considered a binding change as we update the host_id in the port bindings_details field on the port20:58
*** dtruong has joined #openstack-nova20:59
mriedemyeah, but the plan was to not start migrating the guest in the hypervisor until the source got the event that the plug, initiated from the dest, is done21:00
_ixGood afternoon, folks. Can anyone explain the pipeline from the fine work that's going into nova and the end repositories at say http://mirror.centos.org/centos/7/cloud/x86_64/openstack-pike/21:00
*** burt has quit IRC21:01
sean-k-mooney2mriedem: right so we might have to start the migrate on a timeout and have the event short circute it, instead of waiting21:01
mriedemreally kind of need an admin-only field on the port to tell clients, like nova, if we can expect vif plug events or not21:01
_ixI'm only seeing latest as 16.0.3 in that repo -- is there a different repository that you mgith be able to recommend for 16.1.0 ?21:02
mriedemsean-k-mooney2: we could, but then anyone using ODL is going to wait up to 5 minutes for an event that's not going to come21:02
mriedem_ix: you could try asking in #openstack-rpm-packaging21:02
sean-k-mooney2mriedem: ill double check the odl code. ill be back in the office tomorrow so i can try and set up an odl environment21:03
mriedem_ix: or maybe #rdo21:03
mriedemsean-k-mooney2: ok for now i'm just going to neuter this lifecycle event callback code that calls migrate_instance_finish21:03
sean-k-mooney2well we can still activate the dest binding when we get the hyperviors event that it just paused the source and is about to unpause the dest right21:05
sean-k-mooney2we just dont wait for the vif plugged event21:05
mriedemtwo separate issues,21:05
mriedemi'm going to neuter the first right now because it's causing this vif unbound explosion in _post_live_migrate21:06
*** itlinux has quit IRC21:06
mriedemthe latter issue is not something we're hitting right now, but was in the plan as part of this spec21:06
sean-k-mooney2ah ok21:06
*** mgoddard has quit IRC21:14
*** suresh12 has quit IRC21:15
openstackgerritMerged openstack/nova master: Move placement exceptions into the placement package  https://review.openstack.org/54986221:17
_ixmriedem: Thanks for the tips.21:17
*** elmaciej has joined #openstack-nova21:21
jaypipesphew, my brain is melting today...21:27
*** suresh12 has joined #openstack-nova21:30
*** felipemonteiro__ has quit IRC21:32
*** jmlowe has joined #openstack-nova21:34
*** lpetrut has quit IRC21:34
*** sar has quit IRC21:35
cdentwas it the videophone jaypipes ?21:38
*** elmaciej has quit IRC21:39
*** sean-k-mooney2 has quit IRC21:39
edleafeefried: ugh - I had all those changes, and then rebased poorly after the original member_of patch merged. Fixing...21:40
efriededleafe: Here to keep you honest.  I feel your rebase pain, homey.21:41
edleafeefried: heh, trying to keep things straight while half-paying attention to meetings21:42
cdentefried: "I have looked at this." beyond that and the typos, do you think I'm on the right track?21:45
efriedcdent: The unedited version was something like, "I have looked at this.  I have no idea what I'm looking at, so I am abstaining from voting."21:46
cdentah, that makes a bit more sense21:46
efriedcdent: "...and the time it would take me to figure out what I'm looking at doesn't fit in my current budget (still ploughing through vacation backlog)."21:47
cdentif/when you surface from that and you want a tour, let me know21:47
cdentthanks for looking in any case, I'm always glad to have your proofing21:48
*** gyee has quit IRC21:50
*** tssurya has quit IRC21:51
*** Guest68461 has quit IRC21:54
*** jackie-truong has quit IRC21:58
*** germs has joined #openstack-nova22:00
*** germs has quit IRC22:00
*** germs has joined #openstack-nova22:00
*** suresh12 has quit IRC22:03
*** germs has quit IRC22:05
edleafeefried: let22:08
edleafeoops22:08
openstackgerritEd Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c  https://review.openstack.org/55435722:08
edleafeefried: let's try this again ^^22:08
efriedack22:08
jaypipescdent: nah, trying to fix the nested providers alloc candidates stuff22:09
*** Darky1UVFKE has joined #openstack-nova22:13
*** liusheng has quit IRC22:14
*** liusheng has joined #openstack-nova22:14
efriedmriedem: 1.19 was for bp placement-aggregate-generation.  Gerrit likes to overwrite the topic for all patches when submitting a series, which is how 1.19 ended up in the whiteboard for https://blueprints.launchpad.net/nova/+spec/generation-from-create-provider.  FTFY.22:19
*** mlavalle has quit IRC22:20
*** AlexeyAbashkin has joined #openstack-nova22:20
efriedmriedem: You can mark https://blueprints.launchpad.net/nova/+spec/placement-aggregate-generation done too.22:22
mriedemmelwitt: totally random but i was just doing some blame game and came across https://review.openstack.org/#/c/377093/1/nova/rpc.py22:22
mriedemmelwitt: ever noticed that RequestContext(overwrite) kwarg is not used at all in that patch?22:22
mriedemhttps://review.openstack.org/#/c/377093/1/nova/context.py@7222:23
mriedemefried: done22:24
efriedthx22:24
*** AlexeyAbashkin has quit IRC22:25
melwittmriedem: yeah, it's used in the base context class from oslo https://github.com/openstack/oslo.context/blob/a8d86df/oslo_context/context.py#L22522:25
mriedemoh i see22:26
melwittit's kind of unclear though, being lumped into **kwargs like that22:26
mriedemhave been trying to figure out wtf periodic tasks are running with a request id which is the same request id i'm tracking for an instance create operation22:26
*** suresh12 has joined #openstack-nova22:27
melwittah, okay. I'd like to know how that happens too22:27
mriedemwell, when the periodics run, they call get_admin_context22:27
mriedemwhich doesn't overwrite the thread local context22:28
mriedemso i guess that's why22:28
melwittoh, so they just get whatever was there. yeah22:28
mriedemhttps://github.com/openstack/nova/blob/master/nova/service.py#L29522:28
mriedemwhich are run from this thread group timer https://github.com/openstack/nova/blob/master/nova/service.py#L21322:28
mriedembut it makes tracing a failed operation for a specific instance really frustrating if everything else picks up the thread local version22:29
melwittright22:29
melwittI have this old patch up around generating an admin context up front and storing it on the service for use in periodic tasks (to help us get to configuring CellDatabases differently). I'm not sure if it would do any better than the current situation though https://review.openstack.org/#/c/52430622:30
melwittlike, I'm not sure if that initial get_admin_context in the service creation might also get tied to some unhelpful request id22:30
melwitter, service.start() I mean22:31
*** suresh12 has quit IRC22:31
openstackgerritMatt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration  https://review.openstack.org/51542322:32
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration  https://review.openstack.org/55137022:32
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration  https://review.openstack.org/43487022:32
openstackgerritMatt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method  https://review.openstack.org/55217022:32
openstackgerritMatt Riedemann proposed openstack/nova master: compute: use port binding extended API during live migration  https://review.openstack.org/55137122:32
openstackgerritMatt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate  https://review.openstack.org/52253722:32
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Turn on new port binding extended live migrate flow  https://review.openstack.org/55217322:32
mriedemit shouldn't if we're not calling get_admin_context() every time the periodic runs22:33
*** rcernin has joined #openstack-nova22:34
mriedemi was going to try setting the request_id='req-%s' % self.service_ref.uuid so we'd have a predictable request id in periodics, but that would just be ignored since get_admin_context uses overwrite=False22:34
melwittokay, then that patch might help then. it got stalled on me not providing a reliable poison fixture for making sure nothing in periodics tries to get_admin_context on their own. and gibi proposed something better around that. but I haven't gotten back to it22:35
*** elmaciej has joined #openstack-nova22:37
*** suresh12 has joined #openstack-nova22:39
*** edmondsw has quit IRC22:49
dansmithmriedem: I'm still not sure how that makes sense,22:49
dansmiththe periodics are their own (eventlet) thread, they should have their own TLS22:49
*** hongbin has quit IRC22:49
dansmithnot sure why they shouldn't be able to set their TLS there22:49
dansmithI'd guess that overwrite=False is actually for the case where some user operation needs an admin context to do something specific, and you don't want to leave them with admin when you're done22:50
dansmithbut periodics probably *should* overwrite TLS in that case22:50
dansmithI would also expect TLS to be reset on each spawn/switch of a thread, otherwise you leak things between requests until you set TLS _to_ something22:51
mriedemi assume overwrite=False was added to get_admin_context() for a wholly different reason than why we're using get_admin_context() for periodics22:51
dansmiththat's what I'm saing22:52
dansmithfor a localized "okay, do this thing for the user as admin"22:52
dansmithlooking up a fixedip before assignment, etc22:52
dansmiththat's why I'm saying we probably want overwrite=True for periodics22:52
dansmiththat kinda goes against the original supposition of melwitt's patch to client RPC though22:53
melwitthere's the original bug that led to using overwrite=False https://bugs.launchpad.net/nova/+bug/162783822:53
openstackLaunchpad bug 1627838 in OpenStack Compute (nova) newton "Context is reset to by ClientRouter in nova/rpc.py" [High,Fix committed] - Assigned to Matt Riedemann (mriedem)22:53
dansmithhmm, I don't get that22:54
*** suresh12 has quit IRC22:55
*** suresh12 has joined #openstack-nova22:56
melwittyeah, I guess that was a different thing. normally we run periodics with get_admin_context which does an overwrite=False and when I added a different unrelated periodic I didn't use get_admin_context and inadvertently made it overwrite=True without realizing it23:00
melwittand the reported problem was that the periodic was blowing away other requests auth token in-flight23:01
*** david-lyle has joined #openstack-nova23:01
dansmithalthough ClientRouter does schedule periodics quite differently from service it seems23:01
melwittyeah, maybe there is something wrong with how it's running periodics?23:03
dansmithwell,23:03
*** hemna_ has quit IRC23:03
dansmithI'm wondering if that's why it needed overwrite=False, but our periodics in compute manager need overwrite=True23:03
melwittoh, I see23:04
dansmithmelwitt: that thing needed periodics to age out clients but that code seems gone I think, so can we remove thatl ine anyway?23:04
melwittyeah, I was thinking that too23:04
dansmithso we're running periodics in our managers via threadgroup timers, which I assume run in threads of their own, but I should check23:06
dansmithmriedem: yeah, so that _remove_stale_clients() periodic was removed later, so we should nuke that line23:06
dansmither, melwitt ^23:06
melwittack. I can propose that23:07
openstackgerritMatt Riedemann proposed openstack/nova master: Remove RequestContext.instance_lock_checked  https://review.openstack.org/55437823:10
mriedemmore cleanup while i was poking around ^23:10
dansmithso I'm not exactly seeing how the way periodics are used in ClientRouter would have worked, other than the single go of them run via __init__23:11
dansmithbut my guess is that they're not run the way we run them in our service23:11
dansmithmelwitt: do we know for sure that those periodics ever ran more than once?23:11
dansmiththat code wasn't in the tree for very long, so..23:11
dansmithit sure looks like we just fired them off once during __init_ and never ran them again23:12
*** cdent has quit IRC23:12
dansmithwhich is also puzzling as to why that would be a problem needing to be reported, but the bug doesn't have much info23:13
melwittdansmith: maybe not. ClientRouter inherits from oslo PeriodicTasks, so it would do this https://github.com/openstack/oslo.service/blob/master/oslo_service/periodic_task.py#L19323:13
dansmithmelwitt: well, it does that once when you run it in __init__23:13
dansmithbut I don't see where that gets scheduled any other place23:14
dansmithservice.py will do it, but you're not a service there23:14
dansmithand the tests just fire the handler manually23:16
melwitthm23:16
dansmith(as expected, we don't really have good coverage over periodics)23:16
dansmithhttps://www.youtube.com/watch?v=C9MG9b4mEU023:17
melwittlol, great movie23:18
dansmiththe only thing I can think of,23:18
dansmithwould be that we instantiate a new compute rpc class for certain things at runtime,23:19
dansmithand maybe we blow away whatever context was current at that time,23:19
dansmithbecause anything running ComputeRPCAPI.__init() will run ClientRouter.__init__(), which will instantiate a context with overwrite=True before your patch23:19
dansmither, rpcapi.ComputeAPI() I mean23:20
*** AlexeyAbashkin has joined #openstack-nova23:20
melwittyeah :\23:20
dansmithmriedem: so I think maybe chatting with someone like dhellmann might be a good idea, but I kinda think we should be running with overwrite=True on those periodics' context23:22
dansmithI'd also like someone to tell me why TLS isn't cleared when a new thread is spawned and/or would like to confirm that timers as we use them to start periodics in our services are actually running in their own threads and not as if they were signal handlers23:24
*** AlexeyAbashkin has quit IRC23:24
openstackgerritMatt Riedemann proposed openstack/nova master: Fix message for unexpected external event  https://review.openstack.org/55438023:26
mriedemok, but not tonight23:27
*** masber has joined #openstack-nova23:27
*** yamamoto has joined #openstack-nova23:27
*** chyka has quit IRC23:30
*** chyka has joined #openstack-nova23:31
openstackgerritmelanie witt proposed openstack/nova master: Remove useless run_periodic_tasks call in ClientRouter  https://review.openstack.org/55438123:31
melwittdansmith, mriedem ^ I left the related overwrite=False regression test case alone thinking we would address that when we get answers about what we should be doing with overwrite + periodics later23:34
dansmithmelwitt: hmm, I'm not sure what that test is testing TBH23:35
dansmithI'm pretty fried and well past punkin time, so I'll look tomorrow with a fresh head23:35
melwittit's testing that we don't overwrite=True during periodics because at the time we thought that was messing up things23:35
melwittokay, cool23:36
*** suresh12 has quit IRC23:39
dansmithI don't think it does though, because we just start the service and then assert our thing,23:42
dansmithI don't think we know that the periodics have run yet23:42
dansmithwe don't run service.periodic_tasks() until the first time we fire the timer, which is delayed from startup, and that's where context gets generated for the periodic run23:43
*** claudiub has quit IRC23:44
*** Sukhdev_ has quit IRC23:44
*** r-daneel has quit IRC23:49
*** elmaciej has quit IRC23:51
*** mriedem has quit IRC23:52
*** elmaciej has joined #openstack-nova23:52
*** elmaciej_ has joined #openstack-nova23:55
*** elmaciej has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!