| *** chyka has quit IRC | 00:06 | |
| *** trinaths has joined #openstack-nova | 00:09 | |
| Spazmotic | Morning novers | 00:11 |
|---|---|---|
| *** hiro-kobayashi has joined #openstack-nova | 00:16 | |
| *** rcernin has joined #openstack-nova | 00:27 | |
| *** moshele has joined #openstack-nova | 00:27 | |
| *** yangyapeng has quit IRC | 00:31 | |
| *** yangyapeng has joined #openstack-nova | 00:32 | |
| *** hshiina|afk is now known as hshiina | 00:32 | |
| *** masahisa has quit IRC | 00:32 | |
| *** masahisa has joined #openstack-nova | 00:33 | |
| *** chyka has joined #openstack-nova | 00:36 | |
| *** yangyapeng has quit IRC | 00:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 00:39 |
| *** masayukig has quit IRC | 00:40 | |
| *** chyka has quit IRC | 00:40 | |
| *** masayukig has joined #openstack-nova | 00:41 | |
| *** mlavalle has quit IRC | 00:42 | |
| *** zhaochao has joined #openstack-nova | 01:01 | |
| *** moshele has quit IRC | 01:05 | |
| *** priteau has joined #openstack-nova | 01:08 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** priteau has quit IRC | 01:12 | |
| *** liuzz has joined #openstack-nova | 01:14 | |
| *** liuzz_ has quit IRC | 01:14 | |
| *** slaweq has quit IRC | 01:15 | |
| openstackgerrit | Merged openstack/nova master: Fix invalid UUIDs in remaining tests https://review.openstack.org/539254 | 01:16 |
| *** clayton has quit IRC | 01:22 | |
| *** tiendc has joined #openstack-nova | 01:23 | |
| *** zhurong has joined #openstack-nova | 01:24 | |
| *** clayton has joined #openstack-nova | 01:25 | |
| *** yangyapeng has joined #openstack-nova | 01:26 | |
| *** Swami has quit IRC | 01:31 | |
| *** Sandy619 has joined #openstack-nova | 01:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823 | 01:37 |
| *** masahisa_ has joined #openstack-nova | 01:40 | |
| *** masahisa has quit IRC | 01:41 | |
| *** masahisa_ has quit IRC | 01:42 | |
| *** dave-mccowan has joined #openstack-nova | 01:42 | |
| *** masahisa has joined #openstack-nova | 01:42 | |
| *** gongysh has joined #openstack-nova | 01:43 | |
| *** vladikr has joined #openstack-nova | 01:43 | |
| *** lei-zh has joined #openstack-nova | 01:48 | |
| *** slaweq has joined #openstack-nova | 01:49 | |
| *** crushil has joined #openstack-nova | 01:49 | |
| *** Tom-Tom has joined #openstack-nova | 01:49 | |
| *** trinaths has quit IRC | 01:50 | |
| *** salv-orlando has joined #openstack-nova | 01:50 | |
| *** slaweq has quit IRC | 01:53 | |
| *** salv-orlando has quit IRC | 01:55 | |
| *** Tom-Tom_ has joined #openstack-nova | 01:57 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 01:57 |
| *** XueFeng has joined #openstack-nova | 02:00 | |
| *** Tom-Tom has quit IRC | 02:00 | |
| *** yikun_ has quit IRC | 02:00 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/539841 | 02:02 |
| openstackgerrit | Merged openstack/nova master: trivial: Fix few policy doc https://review.openstack.org/539780 | 02:02 |
| *** claudiub|2 has quit IRC | 02:02 | |
| openstackgerrit | Merged openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | 02:02 |
| *** gjayavelu has quit IRC | 02:04 | |
| Spazmotic | Hey jianghuaw if you get a chance today could you take a look at Bob's comment on the Live Migration commit? If he's correct here we can just remove almost everythign except the swallow on this | 02:22 |
| Spazmotic | Hopefully in that case with such a simple fix we can get it pushed through the gate quickly and move on with our lives for right now :D | 02:23 |
| *** amodi has quit IRC | 02:23 | |
| *** annp has joined #openstack-nova | 02:26 | |
| *** chyka has joined #openstack-nova | 02:26 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258 | 02:27 |
| *** imacdonn has joined #openstack-nova | 02:28 | |
| *** Spazmotic has quit IRC | 02:30 | |
| *** SpazZz has joined #openstack-nova | 02:30 | |
| *** SpazZz is now known as Spazmotic | 02:30 | |
| *** chyka has quit IRC | 02:31 | |
| *** lei-zh has quit IRC | 02:33 | |
| *** gongysh has quit IRC | 02:43 | |
| *** gongysh has joined #openstack-nova | 02:44 | |
| *** SpazZz has joined #openstack-nova | 02:44 | |
| *** Spazmotic has quit IRC | 02:45 | |
| *** SpazZz is now known as Spazmotic | 02:45 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | 02:46 |
| *** namnh has joined #openstack-nova | 02:46 | |
| *** lei-zh has joined #openstack-nova | 02:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 02:50 |
| jianghuaw | Spazmotic, for OpenStack live-migration, the VDI_NOT_IN_MAP exception was found in the XS7 and forwarding releases. | 02:54 |
| Spazmotic | So no way for it to get thrown previous to that? | 02:55 |
| jianghuaw | Spazmotic, but the error type was added long ago: https://github.com/xapi-project/xen-api/commit/6eaad3b6745c0392ac3b3ef91c33451b1f110aed | 02:55 |
| Spazmotic | That was my concern.. can we assume it is possible for it to trigger legitimately still outside of that path? | 02:55 |
| jianghuaw | So I wondering there is case to trigger this error somehow; but I don't know how to trigger it in OpenSTack. | 02:56 |
| Spazmotic | hehe same here.. | 02:56 |
| Spazmotic | I have access to some 6.5 test boxes, I could run some fake asserts directly through Python i guess | 02:56 |
| *** hongbin has joined #openstack-nova | 02:56 | |
| jianghuaw | yes, it's worthy for the test. | 02:57 |
| Spazmotic | I'll give it a try tonight, try with some empty sets and such and see if I can emulate it. I think it may be worthwhile to keep the logic in either way though considering this fault did exist since 6.0 | 02:57 |
| Spazmotic | Evne if we don't know how to cause it lol | 02:58 |
| jianghuaw | agree. | 02:58 |
| Spazmotic | Thanks for your time sir :) | 02:59 |
| jianghuaw | np:-) | 02:59 |
| *** liuzz has quit IRC | 03:06 | |
| *** priteau has joined #openstack-nova | 03:09 | |
| *** Sandy619 has quit IRC | 03:11 | |
| *** markvoelker has quit IRC | 03:12 | |
| *** priteau has quit IRC | 03:13 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 03:18 |
| *** sree has joined #openstack-nova | 03:22 | |
| *** lennyb has quit IRC | 03:22 | |
| *** sapd__ has joined #openstack-nova | 03:23 | |
| *** sapd_ has quit IRC | 03:23 | |
| *** zhurong has quit IRC | 03:24 | |
| *** zhurong has joined #openstack-nova | 03:26 | |
| *** yamamoto has joined #openstack-nova | 03:37 | |
| *** janki has joined #openstack-nova | 03:38 | |
| *** dave-mccowan has quit IRC | 03:39 | |
| openstackgerrit | Merged openstack/nova master: Migrate "launch instance" user guide docs https://review.openstack.org/540048 | 03:40 |
| openstackgerrit | Merged openstack/nova master: Cleanup launch instance and manage IPs docs https://review.openstack.org/540121 | 03:40 |
| openstackgerrit | Merged openstack/nova stable/pike: Use UEFI as the default boot for AArch64 https://review.openstack.org/531481 | 03:41 |
| *** takashin has quit IRC | 03:41 | |
| *** takashin has joined #openstack-nova | 03:44 | |
| *** moshele has joined #openstack-nova | 03:47 | |
| *** jaypipes has quit IRC | 03:48 | |
| *** salv-orlando has joined #openstack-nova | 03:51 | |
| *** abhishekk has joined #openstack-nova | 03:53 | |
| *** armax has quit IRC | 03:55 | |
| *** armax has joined #openstack-nova | 03:55 | |
| *** salv-orlando has quit IRC | 03:55 | |
| *** armax has quit IRC | 03:56 | |
| *** armax has joined #openstack-nova | 03:56 | |
| *** armax has quit IRC | 03:56 | |
| *** armax has joined #openstack-nova | 03:57 | |
| *** armax has quit IRC | 03:57 | |
| *** armax has joined #openstack-nova | 03:58 | |
| *** armax has quit IRC | 03:58 | |
| *** armax has joined #openstack-nova | 03:59 | |
| *** armax has quit IRC | 03:59 | |
| *** bhujay has joined #openstack-nova | 04:01 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 04:04 |
| *** gongysh has quit IRC | 04:06 | |
| *** amodi has joined #openstack-nova | 04:07 | |
| *** harlowja_ has quit IRC | 04:09 | |
| *** moshele has quit IRC | 04:11 | |
| *** amodi has quit IRC | 04:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 04:14 |
| *** felipemonteiro has joined #openstack-nova | 04:15 | |
| *** Tom-Tom_ has quit IRC | 04:18 | |
| *** sree has quit IRC | 04:23 | |
| *** masahisa_ has joined #openstack-nova | 04:30 | |
| *** sree has joined #openstack-nova | 04:30 | |
| *** masahisa has quit IRC | 04:31 | |
| *** lpetrut has joined #openstack-nova | 04:34 | |
| *** jmlowe_ has quit IRC | 04:40 | |
| *** jmlowe has joined #openstack-nova | 04:41 | |
| *** felipemonteiro has quit IRC | 04:42 | |
| *** trinaths has joined #openstack-nova | 04:44 | |
| Spazmotic | jianghuaw - One more question sir, sorry. It looks like this change is for the actual migrate_send method, does the assert try that when it runs assert_can_migrate, or does it have its own method for that test? | 04:44 |
| *** lei-zh has quit IRC | 04:48 | |
| *** lei-zh1 has joined #openstack-nova | 04:51 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/ocata: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513721 | 04:53 |
| *** jmlowe has quit IRC | 04:54 | |
| *** jmlowe has joined #openstack-nova | 04:55 | |
| *** lpetrut has quit IRC | 04:55 | |
| *** harlowja has joined #openstack-nova | 04:56 | |
| *** zhurong has quit IRC | 04:56 | |
| Spazmotic | Interesting in my test environment running into relaxed SR errors.. thought that was default on now.. | 04:59 |
| *** hongbin has quit IRC | 05:00 | |
| Spazmotic | Ahh.. yeah Huan did a change to this that i bet we don't have | 05:01 |
| Spazmotic | eugh. .yeah | 05:03 |
| openstackgerrit | Merged openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 05:03 |
| *** lpetrut has joined #openstack-nova | 05:04 | |
| *** psachin has joined #openstack-nova | 05:07 | |
| *** ratailor has joined #openstack-nova | 05:08 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** markvoelker has joined #openstack-nova | 05:13 | |
| *** izombie has joined #openstack-nova | 05:13 | |
| *** janki has quit IRC | 05:14 | |
| *** izombie has quit IRC | 05:15 | |
| *** links has joined #openstack-nova | 05:15 | |
| *** jmlowe has quit IRC | 05:15 | |
| *** gongysh has joined #openstack-nova | 05:15 | |
| *** slaweq has quit IRC | 05:15 | |
| *** jmlowe has joined #openstack-nova | 05:17 | |
| *** lpetrut has quit IRC | 05:17 | |
| *** Tom-Tom has joined #openstack-nova | 05:20 | |
| *** masahisa has joined #openstack-nova | 05:20 | |
| *** masahisa_ has quit IRC | 05:21 | |
| *** Tom-Tom has quit IRC | 05:24 | |
| *** yangyapeng has quit IRC | 05:25 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/540256 | 05:30 |
| Spazmotic | Well that's literally the only result for VDI_NOT_IN_MAP in the git log for xenapi so i'm guessing that's the one hehe | 05:31 |
| *** takashin has left #openstack-nova | 05:34 | |
| *** mdnadeem has joined #openstack-nova | 05:34 | |
| *** gongysh has quit IRC | 05:35 | |
| *** sticker has quit IRC | 05:39 | |
| *** slaweq has joined #openstack-nova | 05:41 | |
| *** jmlowe has quit IRC | 05:42 | |
| *** jmlowe has joined #openstack-nova | 05:43 | |
| *** janki has joined #openstack-nova | 05:43 | |
| *** slaweq has quit IRC | 05:46 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Make InstanceGroup.get_hosts query all cells https://review.openstack.org/540258 | 05:47 |
| *** markvoelker has quit IRC | 05:47 | |
| openstackgerrit | Merged openstack/nova master: Reduce policy deprecation warnings in test runs https://review.openstack.org/537603 | 05:51 |
| openstackgerrit | Merged openstack/nova master: Remove deprecated policy items from fake_policy https://review.openstack.org/537600 | 05:51 |
| *** salv-orlando has joined #openstack-nova | 05:52 | |
| *** xinliang has quit IRC | 05:52 | |
| *** gongysh has joined #openstack-nova | 05:54 | |
| *** lpetrut has joined #openstack-nova | 05:55 | |
| *** salv-orlando has quit IRC | 05:56 | |
| *** jmlowe has quit IRC | 05:57 | |
| *** Tom-Tom has joined #openstack-nova | 05:58 | |
| *** takedakn has joined #openstack-nova | 05:58 | |
| *** jmlowe has joined #openstack-nova | 06:00 | |
| *** yangyapeng has joined #openstack-nova | 06:00 | |
| openstackgerrit | Merged openstack/nova master: Log the events we timed out waiting for while plugging vifs https://review.openstack.org/538103 | 06:02 |
| *** xinliang has joined #openstack-nova | 06:04 | |
| *** takedakn has quit IRC | 06:05 | |
| *** lpetrut has quit IRC | 06:07 | |
| *** jmlowe has quit IRC | 06:10 | |
| *** gongysh has quit IRC | 06:10 | |
| *** jmlowe has joined #openstack-nova | 06:12 | |
| *** zhurong has joined #openstack-nova | 06:15 | |
| *** rcernin has quit IRC | 06:20 | |
| *** jmlowe has quit IRC | 06:22 | |
| *** tiendc has quit IRC | 06:23 | |
| openstackgerrit | chenxiangui proposed openstack/nova master: Fix the wrong description https://review.openstack.org/540265 | 06:23 |
| *** jmlowe has joined #openstack-nova | 06:24 | |
| *** udesale has joined #openstack-nova | 06:25 | |
| *** slaweq has joined #openstack-nova | 06:32 | |
| *** jmlowe has quit IRC | 06:34 | |
| *** jafeha__ is now known as jafeha | 06:39 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix instance lookup in hide_server_addresses extension https://review.openstack.org/518996 | 06:40 |
| openstackgerrit | Merged openstack/nova stable/pike: Only log not correcting allocation once per period https://review.openstack.org/526477 | 06:40 |
| *** lajoskatona has joined #openstack-nova | 06:41 | |
| *** swamireddy_ has joined #openstack-nova | 06:41 | |
| *** crushil has quit IRC | 06:43 | |
| *** markvoelker has joined #openstack-nova | 06:44 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (3) https://review.openstack.org/531280 | 06:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in get https://review.openstack.org/531299 | 06:46 |
| *** jmlowe has joined #openstack-nova | 06:48 | |
| *** sridharg has joined #openstack-nova | 06:48 | |
| *** alexchadin has joined #openstack-nova | 06:53 | |
| *** traskat has quit IRC | 06:53 | |
| *** lpetrut has joined #openstack-nova | 06:54 | |
| openstackgerrit | Ameed Ashour proposed openstack/nova stable/ocata: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/540274 | 06:56 |
| *** claudiub|2 has joined #openstack-nova | 06:58 | |
| *** jmlowe has quit IRC | 07:00 | |
| openstackgerrit | Ameed Ashour proposed openstack/nova stable/pike: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539880 | 07:03 |
| *** threestrands has quit IRC | 07:05 | |
| *** jmlowe has joined #openstack-nova | 07:07 | |
| *** priteau has joined #openstack-nova | 07:10 | |
| *** brault has quit IRC | 07:14 | |
| *** priteau has quit IRC | 07:15 | |
| *** jmlowe has quit IRC | 07:17 | |
| *** markvoelker has quit IRC | 07:17 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:18 | |
| *** rgerganov has quit IRC | 07:27 | |
| *** jmlowe has joined #openstack-nova | 07:29 | |
| *** alexchadin has quit IRC | 07:38 | |
| *** zhenglingwu has joined #openstack-nova | 07:40 | |
| *** zhenglingwu has left #openstack-nova | 07:40 | |
| *** moshele has joined #openstack-nova | 07:43 | |
| *** salv-orlando has joined #openstack-nova | 07:43 | |
| openstackgerrit | James E. Blair proposed openstack/python-novaclient master: Zuul: Remove project name https://review.openstack.org/540304 | 07:45 |
| *** moshele has quit IRC | 07:45 | |
| *** jmlowe has quit IRC | 07:46 | |
| *** AlexeyAbashkin has quit IRC | 07:47 | |
| openstackgerrit | Merged openstack/nova master: Pass limit to /allocation_requests https://review.openstack.org/531517 | 07:47 |
| *** tuanla____ has joined #openstack-nova | 07:48 | |
| *** alexchadin has joined #openstack-nova | 07:51 | |
| *** jmlowe has joined #openstack-nova | 07:52 | |
| *** chyka has joined #openstack-nova | 07:54 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:55 | |
| *** ccamacho has joined #openstack-nova | 07:58 | |
| *** brault has joined #openstack-nova | 07:59 | |
| *** jmlowe has quit IRC | 07:59 | |
| *** chyka has quit IRC | 07:59 | |
| *** zhenguo has joined #openstack-nova | 07:59 | |
| *** ttsiouts_ has quit IRC | 08:02 | |
| *** Tom-Tom_ has joined #openstack-nova | 08:02 | |
| *** Tom-Tom has quit IRC | 08:05 | |
| *** pcaruana has joined #openstack-nova | 08:09 | |
| *** ralonsoh has joined #openstack-nova | 08:15 | |
| *** sahid has joined #openstack-nova | 08:23 | |
| *** jmlowe has joined #openstack-nova | 08:23 | |
| *** alexchadin has quit IRC | 08:23 | |
| *** hiro-kobayashi has quit IRC | 08:24 | |
| *** tesseract has joined #openstack-nova | 08:26 | |
| *** alexchadin has joined #openstack-nova | 08:33 | |
| *** moshele has joined #openstack-nova | 08:35 | |
| *** masahisa has quit IRC | 08:36 | |
| openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 08:38 |
| bauzas | good Friday everyone | 08:38 |
| bauzas | let's take my casual dress | 08:38 |
| *** bauzas is now known as bauwser | 08:38 | |
| *** aloga has quit IRC | 08:39 | |
| *** jmlowe has quit IRC | 08:39 | |
| ameeda | bauzas: good Friday :) | 08:41 |
| ameeda | bauwser: also :D | 08:41 |
| Spazmotic | Morning bauwser | 08:41 |
| Spazmotic | Oi... | 08:41 |
| Spazmotic | not you.. I take back my morning to you! | 08:41 |
| Spazmotic | :) | 08:42 |
| *** abhishekk is now known as abhishekk|meetin | 08:42 | |
| gibi | happy Friday everyone :) | 08:42 |
| Spazmotic | Morning gibi | 08:42 |
| Spazmotic | If anyone gets some time to review this today I would appreciate it. https://review.openstack.org/#/c/538415/ Would like to try to pack this one away before I leave for my trip | 08:43 |
| Spazmotic | johnthetubaguy if you're working today and have time, that is the one that we discussed before, with live migration assert_can_migrate | 08:45 |
| *** moshele has quit IRC | 08:45 | |
| *** jpena|off is now known as jpena | 08:50 | |
| *** yangyapeng has quit IRC | 08:55 | |
| *** abhishekk|meetin has quit IRC | 08:55 | |
| *** yangyapeng has joined #openstack-nova | 08:55 | |
| ameeda | cloud you please help me to figure out this issue https://review.openstack.org/#/c/526900/ ? the error of functional test appears after I added | 08:56 |
| ameeda | https://review.openstack.org/#/c/526900/28/nova/db/sqlalchemy/migrate_repo/versions/378_instance_system_metadata_sqlite_upgrade.sql | 08:56 |
| *** jmlowe has joined #openstack-nova | 08:56 | |
| *** ttsiouts_ has joined #openstack-nova | 08:58 | |
| *** ttsiouts_ has quit IRC | 08:59 | |
| *** mgoddard_ has joined #openstack-nova | 09:03 | |
| *** josecastroleon1 has joined #openstack-nova | 09:03 | |
| *** josecastroleon has quit IRC | 09:03 | |
| *** udesale has quit IRC | 09:05 | |
| *** abhishekk|meetin has joined #openstack-nova | 09:08 | |
| *** udesale has joined #openstack-nova | 09:09 | |
| *** stakeda has quit IRC | 09:12 | |
| *** jmlowe has quit IRC | 09:12 | |
| *** abhishekk|meetin has quit IRC | 09:13 | |
| *** hshiina is now known as hshiina|afk | 09:13 | |
| *** udesale_ has joined #openstack-nova | 09:13 | |
| *** markvoelker has joined #openstack-nova | 09:14 | |
| *** abhishekk has joined #openstack-nova | 09:15 | |
| *** udesale has quit IRC | 09:15 | |
| *** jmlowe has joined #openstack-nova | 09:17 | |
| *** moshele has joined #openstack-nova | 09:18 | |
| *** udesale_ has quit IRC | 09:18 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 09:19 |
| *** yamahata has quit IRC | 09:21 | |
| *** moshele has quit IRC | 09:21 | |
| *** aloga has joined #openstack-nova | 09:22 | |
| *** lei-zh1 has quit IRC | 09:23 | |
| *** Tom-Tom has joined #openstack-nova | 09:23 | |
| *** alexchadin has quit IRC | 09:24 | |
| *** elmaciej has joined #openstack-nova | 09:24 | |
| *** jmlowe has quit IRC | 09:26 | |
| *** Tom-Tom_ has quit IRC | 09:26 | |
| gibi | edleafe: thanks for simplification in https://review.openstack.org/#/c/539323 , LGTM | 09:43 |
| *** derekh has joined #openstack-nova | 09:44 | |
| openstackgerrit | James E. Blair proposed openstack/nova master: Zuul: Remove project name https://review.openstack.org/540326 | 09:48 |
| *** markvoelker has quit IRC | 09:48 | |
| *** jmlowe has joined #openstack-nova | 09:48 | |
| *** tovin07 has quit IRC | 09:55 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | 09:55 |
| *** yangyapeng has quit IRC | 09:55 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Stop _undefine_domain erroring if domain not found https://review.openstack.org/508640 | 09:55 |
| openstackgerrit | Merged openstack/nova master: doc: placement upgrade notes for queens https://review.openstack.org/539658 | 09:56 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Marker reset option for nova-manage map_instances https://review.openstack.org/539501 | 09:59 |
| *** hshiina|afk has quit IRC | 09:59 | |
| *** tssurya has joined #openstack-nova | 10:00 | |
| *** hoangcx has quit IRC | 10:03 | |
| *** lpetrut_ has joined #openstack-nova | 10:03 | |
| *** bjolo has quit IRC | 10:03 | |
| *** annp has quit IRC | 10:03 | |
| *** tuanla____ has quit IRC | 10:03 | |
| *** josecastroleon1 has quit IRC | 10:03 | |
| *** jmlowe has quit IRC | 10:04 | |
| *** lpetrut has quit IRC | 10:05 | |
| *** udesale has joined #openstack-nova | 10:13 | |
| *** hieulq_ has quit IRC | 10:13 | |
| *** AlexeyAbashkin has quit IRC | 10:14 | |
| *** AlexeyAbashkin has joined #openstack-nova | 10:14 | |
| lyarwood | mdbooth / kashyap ; would you mind taking a look at the following LM tempest changes regarding encrypted volumes - https://review.openstack.org/#/q/status:open+project:openstack/tempest+branch:master+topic:bp/libvirt-qemu-native-luks | 10:18 |
| kashyap | lyarwood: Hiya. Racing to do the slides for FOSDEM tomm :-( | 10:18 |
| lyarwood | just want to ensure I'm not confusing live migration, live block migration, live migration with volumes attached etc | 10:18 |
| lyarwood | k np | 10:19 |
| kashyap | Sure, will look | 10:19 |
| ildikov | gibi: hi :) | 10:19 |
| mdbooth | lyarwood: Sure | 10:19 |
| kashyap | But Monday I'll have full concentration back here | 10:19 |
| ildikov | gibi: if you have a minute this multi-attach related change needs one more +2: https://review.openstack.org/#/c/532689/ :) | 10:19 |
| Spazmotic | Opened page for FOSDEM and thought it said Bruges | 10:19 |
| lyarwood | urgh so the cleanup duplicates the above test, sorry missed that | 10:20 |
| lyarwood | ah no it doesn't, think I might need more coffee | 10:20 |
| lyarwood | brb | 10:20 |
| *** josecastroleon has joined #openstack-nova | 10:21 | |
| kashyap | Spazmotic: It is Brussels, not Bruges :-) | 10:22 |
| Spazmotic | Hehe yeah I saw that after.. but made me audible go, "In Bruges!?" | 10:22 |
| *** AlexeyAbashkin has quit IRC | 10:23 | |
| *** AlexeyAbashkin has joined #openstack-nova | 10:23 | |
| *** jmlowe has joined #openstack-nova | 10:25 | |
| *** priteau has joined #openstack-nova | 10:29 | |
| *** abhishekk has quit IRC | 10:29 | |
| *** abhishekk has joined #openstack-nova | 10:29 | |
| *** priteau has quit IRC | 10:30 | |
| *** priteau has joined #openstack-nova | 10:30 | |
| *** zhurong has quit IRC | 10:32 | |
| *** stvnoyes has joined #openstack-nova | 10:33 | |
| *** jmlowe has quit IRC | 10:38 | |
| *** sree has quit IRC | 10:43 | |
| *** markvoelker has joined #openstack-nova | 10:45 | |
| andreaf | mriedem_parent, ildikov: wow, https://review.openstack.org/#/c/266605/ merged! 266605! I didn't see a number in the 200k in a while :] | 10:49 |
| andreaf | it surely is a pain to merge a patch in Tempest :P | 10:49 |
| *** bhagyashris has quit IRC | 10:49 | |
| gibi | ildikov: hello :) I will try to look at it before end of today | 10:50 |
| *** Tom-Tom has quit IRC | 10:53 | |
| *** sree has joined #openstack-nova | 10:55 | |
| *** xinliang has quit IRC | 10:56 | |
| *** Tom-Tom has joined #openstack-nova | 10:56 | |
| ildikov | andreaf: lol, I would say cross-project work has its challenges :) | 10:59 |
| *** cdent has joined #openstack-nova | 10:59 | |
| ildikov | andreaf: I mean overall | 11:00 |
| *** Tom-Tom has quit IRC | 11:00 | |
| ildikov | gibi: sounds good, thanks :) | 11:00 |
| ildikov | gibi: the patch is small, but an important one for testing the new multi-attach stuff constantly | 11:01 |
| andreaf | ildikov yes especially if QA is one of the projects :D | 11:01 |
| ildikov | andreaf: that was the easy part this time :D | 11:01 |
| Spazmotic | Ugh just found a more simple way to do my own commit | 11:01 |
| Spazmotic | damn you eyes | 11:01 |
| *** sree has quit IRC | 11:01 | |
| *** lucas-afk is now known as lucasagomes | 11:03 | |
| *** sree has joined #openstack-nova | 11:03 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Remove microversion fallback code from report client https://review.openstack.org/528794 | 11:04 |
| *** sree has quit IRC | 11:08 | |
| *** abhishekk has quit IRC | 11:08 | |
| *** sree has joined #openstack-nova | 11:09 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 11:10 |
| *** sree has quit IRC | 11:13 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | 11:18 |
| *** markvoelker has quit IRC | 11:18 | |
| *** udesale has quit IRC | 11:23 | |
| *** Tom-Tom has joined #openstack-nova | 11:23 | |
| *** Tom-Tom has quit IRC | 11:27 | |
| *** chyka has joined #openstack-nova | 11:30 | |
| *** xinliang has joined #openstack-nova | 11:30 | |
| *** ratailor has quit IRC | 11:31 | |
| *** chyka has quit IRC | 11:35 | |
| *** sambett|afk is now known as sambetts | 11:41 | |
| *** bhagyashris has joined #openstack-nova | 11:43 | |
| *** tbachman has quit IRC | 11:50 | |
| *** trinaths has quit IRC | 11:54 | |
| *** lajoskatona has quit IRC | 11:56 | |
| *** lajoskatona has joined #openstack-nova | 11:57 | |
| *** namnh has quit IRC | 11:57 | |
| *** sdague has joined #openstack-nova | 11:58 | |
| *** dtantsur|afk is now known as dtantsur | 11:58 | |
| *** pcaruana has quit IRC | 12:04 | |
| *** dave-mccowan has joined #openstack-nova | 12:06 | |
| *** dave-mccowan has quit IRC | 12:11 | |
| *** jmlowe has joined #openstack-nova | 12:15 | |
| *** markvoelker has joined #openstack-nova | 12:16 | |
| *** edmondsw has joined #openstack-nova | 12:17 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 12:17 |
| *** dave-mccowan has joined #openstack-nova | 12:17 | |
| *** pcaruana has joined #openstack-nova | 12:23 | |
| *** vladikr has quit IRC | 12:26 | |
| *** vladikr has joined #openstack-nova | 12:27 | |
| *** jmlowe has quit IRC | 12:30 | |
| *** masahisa has joined #openstack-nova | 12:31 | |
| *** alexchadin has joined #openstack-nova | 12:34 | |
| *** udesale has joined #openstack-nova | 12:35 | |
| *** lpetrut__ has joined #openstack-nova | 12:37 | |
| *** jmlowe has joined #openstack-nova | 12:38 | |
| *** udesale has quit IRC | 12:39 | |
| *** udesale has joined #openstack-nova | 12:40 | |
| *** jpena is now known as jpena|lunch | 12:40 | |
| *** lpetrut_ has quit IRC | 12:40 | |
| *** lajoskatona has quit IRC | 12:40 | |
| *** yangyapeng has joined #openstack-nova | 12:42 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | 12:45 |
| *** jmlowe has quit IRC | 12:48 | |
| *** markvoelker has quit IRC | 12:50 | |
| *** jmlowe has joined #openstack-nova | 12:51 | |
| *** lajoskatona has joined #openstack-nova | 12:53 | |
| *** bjolo has joined #openstack-nova | 12:55 | |
| *** sree has joined #openstack-nova | 12:56 | |
| *** gcb has quit IRC | 12:57 | |
| *** liverpooler has joined #openstack-nova | 12:57 | |
| *** sree has quit IRC | 13:00 | |
| *** elmaciej has quit IRC | 13:03 | |
| *** jmlowe has quit IRC | 13:03 | |
| *** jmlowe has joined #openstack-nova | 13:03 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Marker reset option for nova-manage map_instances https://review.openstack.org/539501 | 13:09 |
| *** gibi is now known as giblet | 13:10 | |
| *** tbachman has joined #openstack-nova | 13:11 | |
| *** hamzy has quit IRC | 13:13 | |
| *** jmlowe has quit IRC | 13:14 | |
| *** ameeda has quit IRC | 13:14 | |
| *** alexchadin has quit IRC | 13:15 | |
| *** jmlowe has joined #openstack-nova | 13:15 | |
| *** janki has quit IRC | 13:15 | |
| *** tbachman has quit IRC | 13:16 | |
| *** tbachman has joined #openstack-nova | 13:16 | |
| *** jaypipes has joined #openstack-nova | 13:17 | |
| *** hamzy has joined #openstack-nova | 13:18 | |
| Spazmotic | giblet always makes me think of a tiny pig. | 13:19 |
| Spazmotic | like real tiny, like ant sized | 13:19 |
| *** efried has joined #openstack-nova | 13:20 | |
| efried | @/ | 13:20 |
| giblet | Spazmotic: this giblet is full of birthday cake today so it is not so small of a pig now | 13:21 |
| Spazmotic | Birthday pig.. sounds delicious. | 13:22 |
| Spazmotic | Happy birthday man, if it is your own cake :) | 13:22 |
| giblet | the cake was delicious too. :) | 13:22 |
| giblet | Spazmotic: Yes, it is. Thank you | 13:22 |
| cdent | happy birthday giblet | 13:23 |
| giblet | cdent: thanks | 13:24 |
| *** markvoelker has joined #openstack-nova | 13:24 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax (Rocky) https://review.openstack.org/540179 | 13:25 |
| efried | Wow, is it Friday already?? | 13:26 |
| *** efried is now known as fried_rice | 13:26 | |
| *** alexchadin has joined #openstack-nova | 13:26 | |
| *** jmlowe has quit IRC | 13:27 | |
| *** jmlowe has joined #openstack-nova | 13:29 | |
| Spazmotic | That spec made my eyes fall out of my head so I assume it's super good | 13:30 |
| fried_rice | Which one? | 13:32 |
| Spazmotic | Yours.. impressive I feel dumber for even being too close to it.. I'll save that for when I want to make one later hehe | 13:32 |
| *** alexchadin has quit IRC | 13:33 | |
| fried_rice | Spazmotic: I wouldn't model your bp off of that one. *Some* folks thought it was too long. | 13:34 |
| *** moshele has joined #openstack-nova | 13:34 | |
| *** elmaciej has joined #openstack-nova | 13:36 | |
| *** moshele has quit IRC | 13:37 | |
| *** salv-orlando has quit IRC | 13:37 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | 13:38 |
| *** salv-orlando has joined #openstack-nova | 13:38 | |
| *** psachin has quit IRC | 13:40 | |
| *** salv-orlando has quit IRC | 13:42 | |
| *** Tom-Tom has joined #openstack-nova | 13:42 | |
| *** jpena|lunch is now known as jpena | 13:44 | |
| *** masahisa has quit IRC | 13:44 | |
| *** pcaruana has quit IRC | 13:46 | |
| *** mlavalle has joined #openstack-nova | 13:48 | |
| *** jaypipes is now known as leakypipes | 13:48 | |
| *** artom has quit IRC | 13:49 | |
| *** jpena is now known as jpena|off | 13:50 | |
| *** Spazmotic has quit IRC | 13:53 | |
| *** mriedem_parent is now known as mriedem | 13:54 | |
| *** Spazmotic has joined #openstack-nova | 13:54 | |
| *** Spazmotic is now known as SpazZz | 13:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 13:57 |
| *** udesale has quit IRC | 13:57 | |
| *** udesale has joined #openstack-nova | 13:58 | |
| *** mriedem has quit IRC | 13:58 | |
| giblet | edleafe: I figured out how can we ensure that no new UUID validation warning is merged to nova: https://review.openstack.org/#/c/540386 | 13:59 |
| *** josecastroleon has quit IRC | 13:59 | |
| *** josecastroleon has joined #openstack-nova | 13:59 | |
| *** artom has joined #openstack-nova | 14:03 | |
| *** jpena|off is now known as jpena | 14:05 | |
| *** pcaruana has joined #openstack-nova | 14:06 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax (Rocky) https://review.openstack.org/540179 | 14:08 |
| *** sree has joined #openstack-nova | 14:09 | |
| *** mriedem has joined #openstack-nova | 14:11 | |
| mriedem | lyarwood: mdbooth: can you comment on melwitt's question here https://review.openstack.org/#/c/539739/2/nova/virt/libvirt/driver.py@7430 | 14:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Avoid inventory DELETE API (no conflict detection) https://review.openstack.org/539712 | 14:11 |
| *** edleafe is now known as figleaf | 14:11 | |
| mriedem | i don't see anything ever setting connection_info['volume_id'] | 14:11 |
| figleaf | giblet: nice | 14:12 |
| mdbooth | mriedem: When I was working on an HLR for a telco many, many moons ago, we'd have called that sort of request tromboning :) | 14:13 |
| figleaf | giblet: working on fixing the merge conflict | 14:13 |
| *** sree has quit IRC | 14:13 | |
| mriedem | mdbooth: ok i don't know what that means | 14:13 |
| ildikov | mriedem: when we did the connection_info translation for the new attach API we didn't explicitly add the volume_id field to 'data' there so it doesn't seem to come from Cinder either | 14:14 |
| lyarwood | mriedem: yup looking now | 14:14 |
| mdbooth | mriedem: It was a request sent externally only to be bounced back to an internal source :) | 14:15 |
| mdbooth | mriedem: Ah, that's interesting. I made some comments about that in review. | 14:16 |
| mriedem | mdbooth: ok? i asked you guys because you were reviewing/working on the luks patch that i'm trying to fix. | 14:16 |
| mdbooth | mriedem: Sorry, IRC failure. My mind was just wandering... | 14:16 |
| mdbooth | mriedem: So I don't think we should be fetching stuff out of connection_info at all | 14:17 |
| mriedem | this line specifically can be using bdm.volume_id | 14:17 |
| mdbooth | I let it pass in review because I believed we always set volume_id in practise | 14:17 |
| mdbooth | in connection_info | 14:17 |
| mriedem | i was just asking if there was some specific logic as to why it was using connection_info | 14:17 |
| lyarwood | mriedem: vol['id'] no? | 14:17 |
| cdent | fried_rice: you'll probably appreciate the fun of https://bugs.launchpad.net/nova/+bug/1747001 | 14:18 |
| openstack | Launchpad bug 1747001 in OpenStack Compute (nova) "Use of parse.urlencode with dict in nova/tests/unit/scheduler/client/test_report.py can result in unpredictable query strings and thus unreliable tests" [Low,Triaged] | 14:18 |
| mdbooth | No, it was only out of expediency to avoid a larger refactor | 14:18 |
| lyarwood | mriedem: we don't set the id on these LibvirtLiveMigrateBDMInfo objects | 14:18 |
| mriedem | lyarwood: vol['id'] would be the primary key of the bdm | 14:18 |
| mriedem | block_device_mapping = driver.block_device_info_get_mapping( | 14:18 |
| mriedem | block_device_info) | 14:18 |
| mdbooth | Although not *much* larger... | 14:18 |
| lyarwood | right sorry, volume_id | 14:18 |
| mriedem | so i'll fix in my change, good thing mel noticed it, | 14:19 |
| mriedem | was just wondering if there was any good reason behind this being here, and i guess there isn't | 14:19 |
| lyarwood | that and the detach lookup | 14:19 |
| fried_rice | cdent: Appreciating the fun... | 14:19 |
| lyarwood | mdbooth: which refactor? Do you have a link to the comment talking about that? | 14:19 |
| mdbooth | mriedem: If we're going to change that code, we should entirely stop poking around inside connection_info, because we *always* have volume_id in the caller context | 14:19 |
| mdbooth | mriedem: i.e. we can just pass in volume_id | 14:19 |
| lyarwood | nack, lets fix the bug and then talk about that refactor | 14:20 |
| fried_rice | cdent: I thought I had dealt with that issue... | 14:20 |
| mriedem | mdbooth: with 6 days to RC1, i want to just fix the bug | 14:20 |
| mdbooth | It's really not a big refactor, just shuffling some argument | 14:20 |
| giblet | ildikov, mriedem: I left some comments in https://review.openstack.org/#/c/532689 | 14:20 |
| mdbooth | And it will be more robust as you're no longer beholden to the vagiaries of connection_info | 14:20 |
| lyarwood | mriedem's suggested change isn't | 14:21 |
| mdbooth | With 6 days to RC1, personally I'd just buckle down and do it. No heuristics means no late surprises. | 14:21 |
| mriedem | with 6 days to RC1 how about we just revert https://review.openstack.org/#/c/523958/ ? | 14:22 |
| mriedem | would that help? | 14:22 |
| bauwser | FWIW, we have more than 50 open bugs | 14:22 |
| bauwser | 6 days before RC1 | 14:22 |
| bauwser | that's what it tramples me | 14:22 |
| bauwser | 50 "new" bugs, my bad | 14:22 |
| bauwser | and I don't have so much time reviewing those bug reports | 14:23 |
| mriedem | lee answered my question so i'll just make this fix and we can move on | 14:23 |
| bauwser | so, if anyone can help me on that, many thanks | 14:23 |
| lyarwood | please, thanks :) | 14:23 |
| mriedem | bauwser: several of those new bugs are old-ish at this point | 14:23 |
| mriedem | like, "should instance group policies be empty?" | 14:23 |
| bauwser | several, but I don't know if we have regressions yet | 14:24 |
| mriedem | i don't know if that's a bug or what so i didn't know how to triage it | 14:24 |
| bauwser | okay, I'll really need to help you | 14:24 |
| mdbooth | Meh, this is how we play virt driver Jenga :( | 14:24 |
| bauwser | ... once I'm done with other internal work :) | 14:24 |
| mriedem | bauwser: i went through these after the meeting yesterday, there is only one new one in there since then | 14:24 |
| bauwser | cool then | 14:25 |
| bauwser | anyway, let's not diverge | 14:25 |
| *** esberglu has joined #openstack-nova | 14:26 | |
| *** lucasagomes is now known as lucas-hungry | 14:26 | |
| ildikov | giblet: tnx | 14:26 |
| mriedem | lyarwood: looks like there were no tests for that pre_live_migration code | 14:28 |
| mriedem | i was thinking it would be in https://review.openstack.org/#/c/523958/18/nova/tests/unit/virt/libvirt/test_migration.py but those don't actually call the driver from what i can tell | 14:28 |
| mriedem | i added an exception to where volume_id was set in that block in pre_live_migratoin and nothing failed | 14:28 |
| mriedem | will see if i can wrangle some existing test to add that condition | 14:29 |
| cdent | fried_rice: this one is fun too https://bugs.launchpad.net/nova/+bug/1747003 | 14:29 |
| openstack | Launchpad bug 1747003 in OpenStack Compute (nova) "A bad _RC_CACHE can rarely cause unit tests to fail" [Undecided,New] | 14:29 |
| lyarwood | mriedem: is there nothing in _test_pre_live_migration_works_correctly_mocked ? | 14:30 |
| * lyarwood checks | 14:30 | |
| *** links has quit IRC | 14:30 | |
| fried_rice | cdent: Are you proposing fixes, or setting me up to review them? | 14:31 |
| mriedem | no | 14:31 |
| *** SpazZz is now known as Spazmotic | 14:31 | |
| mriedem | i'll update https://review.openstack.org/#/c/523958/18/nova/tests/unit/virt/libvirt/test_migration.py | 14:32 |
| mriedem | oops, test_pre_live_migration_vol_backed_works_correctly_mocked | 14:32 |
| cdent | fried_rice: I'm making conversation. I'll propose fixes at some point. The RC_CACHE one is easy, the other one somewhat more effortful. | 14:32 |
| Spazmotic | And just in time for my pre-sleepytime begging session to bother the first shift folks - If any core gets a chance to review this Live Migration XenAPI commit i'd apprecaite it. https://review.openstack.org/#/c/538415/ | 14:32 |
| fried_rice | cdent: Okay. I wasn't ragging on you, just didn't want to duplicate effort if I decided to go off and work on one of 'em. | 14:33 |
| Spazmotic | I know ya'lls busy, but just figured i'd throw it out there while I eat cereal :D | 14:33 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in test_compute.py https://review.openstack.org/531479 | 14:33 |
| lyarwood | mriedem: re the connection_info.get('volume_id') lookup, I'm pretty sure that actually works, I can't find where but I recall one of the bdm layers using connection_info to store connection_info['data'] | 14:33 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 14:34 |
| *** lajoskatona has quit IRC | 14:35 | |
| mriedem | connection_info['data'] != connection_info['volume_id'] | 14:35 |
| mriedem | lyarwood: i'm assuming you meant that line of code to be the same as the others that looked for connection_info['data']['volume_id'] | 14:35 |
| *** hemna_ has joined #openstack-nova | 14:36 | |
| mriedem | it was probably a typo, that wasn't tested so it wasn't noticed | 14:36 |
| *** salv-orlando has joined #openstack-nova | 14:39 | |
| lyarwood | mriedem: right, I'm pretty confused how the tempest tests I've been working on have passed without this | 14:40 |
| mriedem | lyarwood: volume-backed live migratoin isn't enabled in tempest by default | 14:41 |
| mriedem | so the tests likely aren't getting run | 14:41 |
| lyarwood | mriedem: it is in my DNM change | 14:41 |
| lyarwood | mriedem: and locally | 14:41 |
| lyarwood | mriedem: where these tests have been passing | 14:41 |
| lyarwood | http://logs.openstack.org/50/536350/5/check/legacy-tempest-dsvm-multinode-live-migration/539c51d/job-output.txt.gz for example | 14:41 |
| *** salv-orlando has quit IRC | 14:43 | |
| mriedem | idk, i don't see the lvm volume driver setting connection_info['volume_id'] | 14:44 |
| lyarwood | mriedem: right, anyway, ignore that, I'll look into how these actually passed now, it doesn't change the fix and lack of unit tests | 14:45 |
| lyarwood | mriedem: happy to take over the updating the fix if you don't have time today btw | 14:46 |
| lyarwood | mriedem: this is my mess, I should really be the one to clean it up | 14:46 |
| mriedem | i've got it, just updating test_pre_live_migration_vol_backed_works_correctly_mocked so it doesn't fake out the bdm stuff that the compute manager is doing, | 14:47 |
| mriedem | i.e. actually going to make that test go through driver.get_block_device_info | 14:47 |
| mriedem | bauwser: question in https://review.openstack.org/#/c/540168/ | 14:47 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Reset the _RC_CACHE between tests https://review.openstack.org/540404 | 14:47 |
| *** masahisa has joined #openstack-nova | 14:48 | |
| leakypipes | lyarwood: on Fridays, I always see your IRC nick and think of pirates. "Yarrr" wood is here. | 14:48 |
| *** abalutoiu has joined #openstack-nova | 14:49 | |
| * leakypipes goes to check himself into mental hospital | 14:50 | |
| lyarwood | leakypipes: haha, yeah you're not the first to suggest that, had a guy in consulting who would scream that across the office while I was on the phone back in my support days | 14:50 |
| *** zhaochao has quit IRC | 14:50 | |
| *** kristian__ has joined #openstack-nova | 14:51 | |
| *** lyarwood is now known as yaaaaarwood | 14:51 | |
| leakypipes | lyarwood: you should wear a pirate hat on Fridays. just sayin'. | 14:51 |
| leakypipes | :) yay! \o/ | 14:51 |
| *** kristian__ has quit IRC | 14:51 | |
| Spazmotic | I've started putting commits into my monthly planner since I have such a backlog and don't want to merge conflict the poop out of xenapi.vmops hehe | 14:51 |
| *** pchavva has joined #openstack-nova | 14:52 | |
| *** r-daneel has joined #openstack-nova | 14:52 | |
| *** awaugama has joined #openstack-nova | 14:53 | |
| bauwser | mriedem: I'm not a specialist on VIF plugging and unplugging, so I could be wrong | 14:53 |
| *** masahisa has quit IRC | 14:53 | |
| bauwser | mriedem: but from what I can see, we destroy and cleanup the instance (hence the VIF unplugs) when we hard reboot | 14:53 |
| bauwser | what happens behind the VIF unplug call is unbound territory to me | 14:54 |
| bauwser | I'm just saying that the change melwitt provides makes it consistent with all the other server actions | 14:54 |
| * bauwser desperatly needs coffee | 14:55 | |
| *** mdnadeem has quit IRC | 14:56 | |
| bauwser | 2 mins for making me coffee before an internal meeting, I can do | 14:57 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 14:58 |
| *** david-lyle has quit IRC | 15:01 | |
| *** r-daneel has quit IRC | 15:01 | |
| openstackgerrit | rahul bardia proposed openstack/python-novaclient master: nova limits ERROR (Exception): Field names must be unique https://review.openstack.org/527922 | 15:03 |
| melwitt | mriedem: when I read your original comment and when I rewrote it I was thinking 'locally' meant plugging vifs through os-vif only and not making any neutron api calls. plugging locally on the libvirt domain | 15:04 |
| *** josecastroleon has quit IRC | 15:07 | |
| *** Tom-Tom has quit IRC | 15:08 | |
| mriedem | we don't make any neutron api calls when plugging/unplugging vifs | 15:09 |
| *** Tom-Tom has joined #openstack-nova | 15:09 | |
| mriedem | i'm looking back on https://github.com/openstack/nova/commit/e4e1c6a2f060a91899549b9643132abde27d033e | 15:09 |
| *** amodi has joined #openstack-nova | 15:09 | |
| mriedem | "this is the explanation I've come up with, albeit not a great one, and indicates a gap in some of the nova/neutron integration story." | 15:09 |
| mriedem | heh | 15:09 |
| mriedem | thanks past me | 15:09 |
| *** salv-orlando has joined #openstack-nova | 15:09 | |
| *** lajoskatona has joined #openstack-nova | 15:09 | |
| *** lajoskatona has quit IRC | 15:10 | |
| *** belmoreira has joined #openstack-nova | 15:11 | |
| melwitt | mriedem: I know, I mean plugging a vif with no contact with neutron at all. on instance boot we create a port. honestly, I don't really know but from the other code comments, we've run into this before it looks like, and it must work at least *some* of the time otherwise reboot would be 100% broken right now. we really need a neutron expert to explain when/how events are/aren't emitted | 15:11 |
| bauwser | mriedem: the fact that we don't call Neutron when we unplug is understandable, but don't we emit something about the port itself ? | 15:11 |
| bauwser | because if we don't, why should we wait for Neutron ? it's a non-sense | 15:11 |
| mriedem | no we don't update the port | 15:11 |
| mriedem | we plug/unplug, | 15:11 |
| bauwser | so, definitely no need to wait for Neutron, right? | 15:11 |
| fried_rice | cdent: If this isn't already on your radar... https://review.openstack.org/#/c/539712/ | 15:12 |
| mriedem | then neutron agent picks up that change, tells the server, and the server sends an event to nova when it's done | 15:12 |
| bauwser | ah-ha | 15:12 |
| melwitt | the neutron agent doesn't always pick up the change, but we don't know why not | 15:12 |
| melwitt | I assume some kind of race or something | 15:12 |
| mriedem | then we likely refresh out nw info cache on the instance to say if the port is gone or not or up/down | 15:12 |
| cdent | fried_rice: yeah, it's in my queue, but may not be seen until monday | 15:12 |
| mriedem | *our | 15:12 |
| fried_rice | ight | 15:12 |
| *** yamahata has joined #openstack-nova | 15:12 | |
| fried_rice | Hey, what's the lib I need to install to get around this pcre thing in py35? | 15:12 |
| bauwser | mriedem: I see | 15:13 |
| bauwser | mriedem: thanks for the explanations | 15:13 |
| bauwser | it was black magic to me | 15:13 |
| *** Tom-Tom has quit IRC | 15:13 | |
| *** pcaruana has quit IRC | 15:13 | |
| melwitt | either way, I feel like this isn't in our control. if we can't depend on the neutron agent to detect a unplug/plug, then I'm not sure what else we can do other than not depend on the events | 15:13 |
| mriedem | melwitt: i guess what you're talking about might be this part of my comment: | 15:13 |
| mriedem | and the status change in the port might go undetected by the neutron + # L2 agent (or neutron server) so neutron may not know that the VIF was + # unplugged in the first place and never send an event. | 15:13 |
| melwitt | yeah | 15:14 |
| mriedem | ok i'll come back to your fix after i get those luks patch fixed up | 15:14 |
| melwitt | I was thinking that part came out of a convo with a neutron person long ago | 15:14 |
| bauwser | question I have out of my mind | 15:14 |
| *** pcaruana has joined #openstack-nova | 15:14 | |
| bauwser | how the agent notices that unplug/plug ? | 15:14 |
| bauwser | don't we somehow notify it ? | 15:15 |
| melwitt | I don't know how it would | 15:15 |
| mriedem | we don't notify the agent | 15:15 |
| *** david-lyle has joined #openstack-nova | 15:15 | |
| bauwser | that's fun | 15:15 |
| mriedem | i think the agent is polling for changes, or gets a notification from the backend | 15:15 |
| melwitt | but it must because hard reboot does work most of the time i.e. we do get plug events | 15:15 |
| mriedem | like ovs | 15:15 |
| bauwser | so we rely on something that's not using Nova as the single source of truth | 15:15 |
| mriedem | mlavalle: how does the neutron agent pick up changes for plugged/unplugged vifs? | 15:15 |
| mriedem | polling? | 15:15 |
| mriedem | sean-k-mooney: ^ | 15:15 |
| Spazmotic | ... I feel like I need to look at some quark logs while rebooting a server over and over now.. | 15:16 |
| melwitt | it's just *sometimes* doesn't send the event and if it doesn't, we timeout waiting | 15:16 |
| bauwser | yeah, so again, what's the purpose of waiting Neutron in case of a reboot ? | 15:18 |
| bauwser | we're grown-ups, we can do the unplug/plug ourselves | 15:18 |
| bauwser | if Neutron catches it, cool | 15:18 |
| *** yamamoto has quit IRC | 15:18 | |
| bauwser | but that shouldn't be a blocking situation | 15:18 |
| Spazmotic | what is neutron need to update on the port? Just the state field? | 15:18 |
| Spazmotic | It's too late to english | 15:19 |
| melwitt | bauwser: originally it was just because we wait during instance boot so I thought that's the normal flow is plug and wait for vif-plugged. but then this bug cropped up and then I found the other comment from mriedem in the file and realized there are situations where we should not wait | 15:20 |
| *** sree has joined #openstack-nova | 15:20 | |
| *** sree has quit IRC | 15:20 | |
| bauwser | melwitt: for the boot case, I agree, it's important | 15:20 |
| *** damien_r has quit IRC | 15:20 | |
| mriedem | this does likely mean that after a reboot, we say the instance is active but it's not really, since you can't ssh into it, | 15:21 |
| bauwser | melwitt: for a reboot, the unplug is transient because we want to just cleanup the instance | 15:21 |
| mriedem | which was the problem we had with initial create | 15:21 |
| *** sree has joined #openstack-nova | 15:21 | |
| bauwser | arf, I need to do some parenting for 20-ish mins | 15:21 |
| * bauwser rushes to the school | 15:21 | |
| melwitt | that's still true, fwiw. there's going to be some time until ssh is possible. but I guess you mean not even getting connection refused | 15:21 |
| *** sridharg has quit IRC | 15:22 | |
| melwitt | bauwser: I know, just saying why the wait was put there initially | 15:22 |
| melwitt | I don't think it should be there now, based on how it behaves and based on the other comment in the file | 15:22 |
| bauwser | melwitt: yup, I just said in the review that with your patch, the only case now where we wait is boot | 15:22 |
| melwitt | yeah | 15:23 |
| mriedem | what did we do before the "blow everything away on reboot"? did we wait, or we just didn't touch the vifs at all? | 15:23 |
| melwitt | didn't touch the vifs | 15:23 |
| *** burt has joined #openstack-nova | 15:24 | |
| melwitt | well, the code has always called plug_vifs for some reason, but before, we didn't *unplug* them | 15:24 |
| melwitt | so we'd call plug_vifs on vifs that were already plugged | 15:24 |
| *** ccamacho has quit IRC | 15:24 | |
| melwitt | (since _create_domain_and_network calls plug_vifs unconditionally) | 15:25 |
| *** sree has quit IRC | 15:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix native luks encryption failure to find volume_id https://review.openstack.org/539739 | 15:25 |
| mriedem | yaaaaarwood: melwitt: ^ now handling pre_live_migration also and unfuckified the test | 15:26 |
| *** bhujay has quit IRC | 15:26 | |
| *** sree has joined #openstack-nova | 15:26 | |
| melwitt | ack | 15:28 |
| Spazmotic | Alright well. goodnight then folks. | 15:28 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 15:28 |
| figleaf | giblet: ^^ I'm not seeing the exception being raised for bad UUIDs | 15:29 |
| *** lucas-hungry is now known as lucasagomes | 15:29 | |
| *** sree has quit IRC | 15:30 | |
| *** READ10 has joined #openstack-nova | 15:30 | |
| mriedem | melwitt: reading back over the related bug for that comment i left in the resize code, https://bugs.launchpad.net/nova/+bug/1323658 | 15:31 |
| openstack | Launchpad bug 1323658 in neutron "Nova resize/restart results in guest ending up in inconsistent state with Neutron" [Medium,Fix released] - Assigned to Dariusz Smigiel (smigiel-dariusz) | 15:31 |
| mriedem | phil day linked this related change https://review.openstack.org/#/c/68942/ | 15:31 |
| *** tidwellr has joined #openstack-nova | 15:31 | |
| mriedem | to wait for the guest to stop | 15:31 |
| mriedem | if we're blowing away the guest on a reboot, i wonder if we should be doing that also, although if you're doing a soft reboot i think we give the guest os some time and then hard reboot just blows it away | 15:31 |
| melwitt | yeah, our case is a hard reboot | 15:32 |
| melwitt | meaning you're right, the soft reboot does the graceful shutdown thing and hard reboot doesn't | 15:32 |
| melwitt | I'm trying asking in #openstack-neutron | 15:36 |
| sean-k-mooney | mriedem: in the case of ovs the neutron ovs agent spawns a monitor process that recives noticiation every time a new interfaces is added to ovs | 15:36 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Don't rely on parse.urlencode in url comparisons https://review.openstack.org/540420 | 15:37 |
| mriedem | melwitt: this is the closest i get in the history on that other bug for an explanation on why we don't wait for vif plugged on resize https://bugs.launchpad.net/nova/+bug/1323658/comments/57 | 15:38 |
| openstack | Launchpad bug 1323658 in neutron "Nova resize/restart results in guest ending up in inconsistent state with Neutron" [Medium,Fix released] - Assigned to Dariusz Smigiel (smigiel-dariusz) | 15:38 |
| belmoreira | melwitt mriedem we upgraded to Ocata yesterday and I'm observing that "memory_mb_used" in "compute_nodes" tables is not correct. However, the resourcetracker log in the hypervisor is correct. | 15:39 |
| belmoreira | Is there a known bug that you are aware about this issue? | 15:39 |
| melwitt | mriedem: nice sleuthing | 15:40 |
| *** READ10 has quit IRC | 15:41 | |
| mriedem | melwitt: so in the resize case, we don't wait for vif-plugged events on the destination host because the vifs are already plugged on the source host, and the source host vifs aren't unplugged until the user confirms the resize and we cleanup the guest from the source | 15:41 |
| melwitt | ihar said that if os-vif doesn't rebind the port, neutron would probably not be aware of the unplug/plug. I'm not sure whether it rebinds it | 15:41 |
| *** armax has joined #openstack-nova | 15:41 | |
| *** lpetrut__ has quit IRC | 15:43 | |
| *** lucasxu has joined #openstack-nova | 15:43 | |
| sean-k-mooney | mriedem: so when os-vif adds a port we set the neurtorn port uuid in the external_ids field and wehn it get the notification fo the port added the neutron agent looks up the port and does the binding | 15:44 |
| *** armax_ has joined #openstack-nova | 15:44 | |
| sean-k-mooney | melwitt: os-vif should not be binding the port port binding and port plugging are 2 different things | 15:44 |
| *** lucasxu has quit IRC | 15:44 | |
| sean-k-mooney | melwitt: you cannont call os-vif wiht an unbound port | 15:44 |
| melwitt | thanks sean-k-mooney. I really need to read a book about this stuff | 15:45 |
| sean-k-mooney | melwitt: if you do you proably will wish you had not :P | 15:45 |
| melwitt | heh, fair | 15:45 |
| *** udesale has quit IRC | 15:45 | |
| mriedem | sean-k-mooney: it sounds like this behavior is different based on if you're using linuxbridge or not | 15:45 |
| *** yamamoto has joined #openstack-nova | 15:46 | |
| *** armax has quit IRC | 15:46 | |
| *** armax_ is now known as armax | 15:46 | |
| * bauwser is back | 15:46 | |
| sean-k-mooney | mriedem: kind of. the general patteren is the same but some of the details are different | 15:46 |
| Spazmotic | melwitt, you happen to have time to talk? | 15:46 |
| melwitt | Spazmotic: that sounds mysterious | 15:47 |
| *** slaweq has quit IRC | 15:47 | |
| sean-k-mooney | mriedem: for ovs neuton can subscrible to notification form the ovsdb for port add/remove events | 15:47 |
| *** abalutoiu has quit IRC | 15:47 | |
| *** josecastroleon has joined #openstack-nova | 15:47 | |
| Spazmotic | Lol nah nah I assure you, just a quick conversation about nova related activities | 15:47 |
| *** abalutoiu has joined #openstack-nova | 15:47 | |
| sean-k-mooney | melwitt: for linuxbridge i belive they have to poll | 15:47 |
| sean-k-mooney | * mriedem ^ | 15:47 |
| Spazmotic | If you're too busy it's no rush :) | 15:47 |
| melwitt | Spazmotic: go ahead | 15:47 |
| mriedem | sean-k-mooney: really just trying to figure out if/why vif plug events from neutron might be different in the case of a hard reboot if you're using LB or OVS | 15:48 |
| mriedem | since the wait logic on the nova side would suck if we had to know it changes per network backend | 15:48 |
| *** sree has joined #openstack-nova | 15:48 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 15:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 15:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 15:49 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 15:49 |
| *** felipemonteiro has joined #openstack-nova | 15:49 | |
| sean-k-mooney | mriedem: if you do a hard reboot we will actully terminate the qemu process and remove the tap and re add it | 15:50 |
| *** owalsh_ has joined #openstack-nova | 15:50 | |
| sean-k-mooney | if you are polling you may miss that | 15:50 |
| sean-k-mooney | with ovs you will get the notifcation from the ovsdb for the add and remove | 15:50 |
| *** mdnadeem has joined #openstack-nova | 15:51 | |
| *** josecastroleon has quit IRC | 15:51 | |
| sean-k-mooney | mriedem: is this all in relation to https://bugs.launchpad.net/nova/+bug/1323658 | 15:52 |
| openstack | Launchpad bug 1323658 in neutron "Nova resize/restart results in guest ending up in inconsistent state with Neutron" [Medium,Fix released] - Assigned to Dariusz Smigiel (smigiel-dariusz) | 15:52 |
| *** READ10 has joined #openstack-nova | 15:52 | |
| mriedem | sean-k-mooney: no, https://review.openstack.org/#/c/540168 | 15:52 |
| *** owalsh- has joined #openstack-nova | 15:52 | |
| *** owalsh has quit IRC | 15:52 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:53 | |
| *** sree has quit IRC | 15:53 | |
| *** owalsh_ has quit IRC | 15:54 | |
| *** yamahata has quit IRC | 15:54 | |
| *** owalsh has joined #openstack-nova | 15:55 | |
| *** armax has quit IRC | 15:55 | |
| *** damien_r has joined #openstack-nova | 15:56 | |
| *** felipemonteiro has quit IRC | 15:56 | |
| *** armax has joined #openstack-nova | 15:56 | |
| bauwser | damn, interesting convo about vif pluging and neutron agents | 15:57 |
| giblet | figleaf: Locally it raises for me if I pull the oslo ovo patch into my env (Depends-On: https://review.openstack.org/540344) | 15:57 |
| giblet | figleaf: I mean it raised before the rebase | 15:57 |
| giblet | figleaf: let me try with the new patch | 15:57 |
| *** owalsh_ has joined #openstack-nova | 15:58 | |
| bauwser | mriedem: yeah, I guess the crux of the problem is how linuxbridge notifies the events | 15:58 |
| bauwser | since that bug report is all about it | 15:58 |
| * bauwser tries to remember his early days when he started playing with lb | 15:58 | |
| *** owalsh- has quit IRC | 15:58 | |
| bauwser | I mean for Quantum | 15:59 |
| sean-k-mooney | welll so i think we are conflating too things here | 15:59 |
| sean-k-mooney | vif pluging and vif binding | 15:59 |
| *** salv-orlando has quit IRC | 15:59 | |
| bauwser | vif binding is the allocation, right? | 15:59 |
| sean-k-mooney | vif plugging is the act of adding the tap to the backend | 15:59 |
| bauwser | vif plugging is the fact to attach the vif to the guest ? | 15:59 |
| *** salv-orlando has joined #openstack-nova | 15:59 | |
| sean-k-mooney | vif binding id that ack of the neutron ml2 direver populating the port details with a vif_type and vif_binding_details | 16:00 |
| mriedem | this might be closer to the issue https://review.openstack.org/#/c/540168/1/nova/virt/libvirt/driver.py@5372 | 16:00 |
| mriedem | for one, we're operating on a stale cache to determine which vifs to wait for | 16:00 |
| mriedem | b/c we never wait for the vifs to be unplugged and refresh the nw info cache | 16:00 |
| mriedem | based on that, it's likely better to yes just ignore the vif plugged event, | 16:01 |
| *** owalsh has quit IRC | 16:01 | |
| mriedem | in the server create case, we have the async network info wrapper that is waiting for the nw_info cache updates during port binding, | 16:01 |
| * bauwser reads | 16:01 | |
| mriedem | and then the virt driver spawn is waiting on those | 16:01 |
| mriedem | so the nw info cache is up to date in the server create case, but we have nothing like that in the case of hard reboot | 16:01 |
| *** salv-orlando has quit IRC | 16:01 | |
| *** salv-orlando has joined #openstack-nova | 16:01 | |
| *** r-daneel has joined #openstack-nova | 16:02 | |
| melwitt | yeah, IIUC we get the network_info fresh at the beginning of a reboot and then that's it | 16:02 |
| sean-k-mooney | mriedem: well one thing im not clear on. when we do a hard reboot do we redo the neutron port binding or jsut reuse the old one | 16:02 |
| mriedem | re-use the existing one | 16:02 |
| sean-k-mooney | well the neutron event is sent when neutron finish wirieing up a prot for the first time after portbinding. i dont know if neutron will send it again if we dont rebind | 16:03 |
| mriedem | it must, otherwise this would be 100% fail in the gate | 16:04 |
| mriedem | what we have is a race right now | 16:04 |
| sean-k-mooney | mriedem: oh thats good to know | 16:04 |
| mriedem | melwitt: i think we should probably not copy the comment from finish_migration | 16:05 |
| mriedem | i bet this is primarily an issue based on (1) which network backend you're using and (2) the fact we're operating on a stale nw info cache, which is different from how spawn() works and waits for vif plug events | 16:06 |
| *** tbachman has quit IRC | 16:06 | |
| bauwser | mriedem: melwitt: good point, the nw_info is only accurate when we call hard_reboot, not when it comes to _create_domain_and_nw() | 16:06 |
| melwitt | okay | 16:06 |
| mriedem | and therefore we should assume the vifs are already plugged and we don't need to wait for them | 16:06 |
| mriedem | if we wanted to be thorough, | 16:06 |
| mriedem | we'd (1) wait for the vif-unplugged event, and then (2) refresh the nw-info cache before moving on to plug the vifs | 16:07 |
| bauwser | right | 16:07 |
| mriedem | i'm not advocating that we do that in this patch, since we have to backport this | 16:07 |
| * melwitt looks to see if neutron sends an unplug event | 16:07 | |
| mriedem | melwitt: so if you wanted to just update the comments, i'd be cool with that | 16:07 |
| bauwser | fair enough | 16:07 |
| melwitt | I was scrutinizing the logs of a failed run yesterday | 16:07 |
| sean-k-mooney | mriedem: when you say the vif are already plugged you mean from a neutron point of view correct. not that the vif is added to the backend which is done by os-vif | 16:10 |
| mriedem | sean-k-mooney: i'm talking about this vifs_already_plugged kwarg in the libvirt driver code | 16:10 |
| *** pcaruana has quit IRC | 16:11 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 16:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 16:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 16:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 16:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 16:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 16:11 |
| sean-k-mooney | mriedem: yes but im trying to figure out if this opens a security hole | 16:11 |
| *** mdnadeem has quit IRC | 16:11 | |
| sean-k-mooney | mriedem: if that arge is set to True we will not wait for neutron | 16:11 |
| bauwser | sean-k-mooney: well, all other server actions do the same, y'kno< | 16:12 |
| bauwser | know* | 16:12 |
| sean-k-mooney | os-vif will add the port when we call plug | 16:12 |
| bauwser | sean-k-mooney: we're only able to correctly wait for Neutron in the boot case only because we have a fresh network info | 16:12 |
| sean-k-mooney | but we wait for neutron to make sure the firewal rules are active on the port before unpasing the vm | 16:12 |
| bauwser | fixing that in other server action calls would require far more | 16:12 |
| bauwser | we == os-vif ? | 16:13 |
| sean-k-mooney | we == nova | 16:13 |
| melwitt | mriedem: he's the run I was looking at yesterday. there are no network-vif-unplugged events for the instance for the failed test (the hard reboot) http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-q-svc.txt.gz#_Jan_29_16_01_28_170964 | 16:13 |
| sean-k-mooney | os-vif does not talk to neutron ever | 16:13 |
| melwitt | I linked to a network-changed but if you look further in the log there are no unplug events | 16:13 |
| *** AlexeyAbashkin has quit IRC | 16:14 | |
| melwitt | so I don't expect things would work if we tried to wait for an unplug event because neutron never sends one | 16:14 |
| * melwitt goes to update comments now | 16:14 | |
| *** owalsh_ is now known as owalsh | 16:14 | |
| *** liusheng has quit IRC | 16:15 | |
| *** yangyapeng has quit IRC | 16:15 | |
| sean-k-mooney | melwitt: correct but wen we delete the tap any iprules create by the neutron security group driver are removed. if neutron never sees the device is unplugged and plugged again i dont think it will ever recreate them | 16:16 |
| *** yangyapeng has joined #openstack-nova | 16:16 | |
| *** liusheng has joined #openstack-nova | 16:16 | |
| *** links has joined #openstack-nova | 16:18 | |
| melwitt | sean-k-mooney: os-vif unplug deletes the tap, is what you are saying? | 16:18 |
| mriedem | giblet: thanks for reviewing the nova-multiattach job change, replies inline https://review.openstack.org/#/c/532689/ | 16:18 |
| sean-k-mooney | melwitt: actully qemu doing a hard reboot does but os-vif will also remove it form the linux bridge | 16:18 |
| sean-k-mooney | or ovs bridge depending on your life choices | 16:19 |
| melwitt | sean-k-mooney: okay. and then the os-vif plug call will create *not* create the iprules again? | 16:19 |
| sean-k-mooney | melwitt: the ip routes are created by the neutron security group driver not os-vif | 16:19 |
| melwitt | hm | 16:20 |
| giblet | mriedem: cool. looking in a minute | 16:20 |
| sean-k-mooney | so if nova does not notify neutron i dont think it will reinstall them | 16:20 |
| *** yangyapeng has quit IRC | 16:20 | |
| sean-k-mooney | melwitt: we may be able to simply rebind the port to the same host as part of the reboot | 16:20 |
| melwitt | sean-k-mooney: if that's the case, I think that would be a latent bug because the behavior before this "re-initialize everything" approach still destroyed and undefined the libvirt domain. it just didn't do any os-vif unplug/plug | 16:21 |
| mriedem | should we just not destroy_vifs on hard reboot and avoid this mess? | 16:21 |
| bauwser | mriedem: well, looks like we somehow decided in the past to destroy everything | 16:22 |
| sean-k-mooney | mriedem: the tap will still be delete by qemu/kvm/libvirt so its not an os-vif issue | 16:22 |
| mriedem | bauwser: decided in the last 6 months | 16:22 |
| mriedem | bauwser: this is a regression introduced in queens, | 16:22 |
| bauwser | interesting | 16:22 |
| mriedem | which is why i'm -W on the ocata backport | 16:23 |
| melwitt | no, the handling of the libvirt domain did not change | 16:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 16:23 |
| giblet | figleaf: now your new unit test also passes in my local env ^^ | 16:23 |
| giblet | figleaf: btw thanks for that unit test. I did not now that we have tests for the fixtures | 16:23 |
| sean-k-mooney | so i think we dont see this on ovs because of the ovsdb monitor which will see the port remved and readded by libvirt/os-vif. the gap seams to be that we dont have a reliable way to notify neutron that this happened for linuxbridge | 16:25 |
| melwitt | if we're losing iptables rules upon reboot, we've always been losing them, if it has to do with destroying the libvirt domain because we have always been destroying the domain on a reboot and we also destroy it for a stop, etc | 16:26 |
| bauwser | yeah, stop/start calls hard_reboot | 16:27 |
| bauwser | fun | 16:27 |
| sean-k-mooney | mlavalle: but only with linuxbridge when the polling intergave misses the removal and addtion | 16:27 |
| sean-k-mooney | /intergave/interval/ that was bad even for me | 16:28 |
| melwitt | my point is that is not new, that was not changed in the last 6 months. the change was doing os-vif unplug/plug and volume detach/attach | 16:29 |
| mriedem | melwitt: i think you pointed this out before but this is likely a bogus debug message https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L346 | 16:29 |
| mriedem | _events being empty could just mean we already processed the event | 16:29 |
| sean-k-mooney | melwitt: oh ok | 16:29 |
| mriedem | _events == None means we are shutting down compute | 16:29 |
| * bauwser needs to leave | 16:30 | |
| *** yamamoto has quit IRC | 16:30 | |
| bauwser | melwitt: ping me when you're done with your new rev and I'll review it when I'm back | 16:30 |
| *** yangyapeng has joined #openstack-nova | 16:30 | |
| *** belmoreira has quit IRC | 16:31 | |
| sean-k-mooney | mriedem: you are correct the os-vif is new but the code in the linuxbidge pluging was copied directly from nova so i think the logic should be the same. | 16:31 |
| sean-k-mooney | * melwitt ^ | 16:31 |
| *** yamamoto has joined #openstack-nova | 16:31 | |
| figleaf | giblet: We shouldn't have to use the WarningsFixture, as the TestCase class already uses it | 16:32 |
| melwitt | sean-k-mooney: what I was trying to say is that we didn't do anything new about the libvirt domain part in the last 6 months. we have always done the equivalent of a 'virsh destroy' when we do a hard reboot or stop/start | 16:32 |
| figleaf | giblet: Here's what I get when I runt the test: http://paste.openstack.org/show/658860/ | 16:33 |
| melwitt | so if that messes up iptables rules, then they've always been getting messed up and it's latent | 16:33 |
| sean-k-mooney | melwitt: oh i know. and we should be doing the equivelent of virsh destroy that is the main difference between soft reboot and hard as far as i am concurened | 16:34 |
| *** elmaciej has quit IRC | 16:34 | |
| giblet | figleaf: testtools.TestCase does not use the nova's warning fixture just nova.test.TestCase uses it | 16:34 |
| sean-k-mooney | melwitt: yes that is also true | 16:34 |
| melwitt | sean-k-mooney: should or shouldn't? sorry I'm confused. the 'virsh destroy' will indeed wipe out iptables rules? | 16:35 |
| giblet | mriedem: responeded in https://review.openstack.org/#/c/532689 | 16:35 |
| sean-k-mooney | a hard reboot should entirely tear down the vm the same way virsh destroy would | 16:35 |
| melwitt | if it does, then I'm surprised we haven't heard about people complaining | 16:35 |
| giblet | mriedem: I'm OK to +W this and continue discussing the run.yaml issue separately as it seems the job works | 16:36 |
| *** yamamoto has quit IRC | 16:36 | |
| giblet | mriedem: and the rest of the nits can be handled in a follow up (like naming) | 16:36 |
| sean-k-mooney | the soft reboot should jsut send an achi reboot command to the guest but not destry and recreate the entire vm | 16:36 |
| giblet | figleaf: have you tried runnig PS4 in your env or just PS3? | 16:37 |
| melwitt | mriedem: I'm trying to understand how we even get that "Unexpected attempt to pop events during shutdown" in that test run | 16:37 |
| mriedem | giblet: works for me | 16:37 |
| mriedem | melwitt: looking at the n-cpu log, it looks like because we get a network-changed event before that which we process and pop the event, but not sure | 16:37 |
| melwitt | sean-k-mooney: yeah, it does. just trying to understand whether any of that blows away iptables rules | 16:37 |
| melwitt | since that would be bad | 16:38 |
| sean-k-mooney | melwitt: if qemu removes the tap. then any ip tables rules associated with the tap will be removed for the kernel when the tap is removed | 16:38 |
| mriedem | but network-changed shouldn't mess with the _events stuff at all... | 16:38 |
| giblet | mriedem: OK. I've +Wd it | 16:39 |
| mriedem | melwitt: we're probably just getting a network-vif-plugged event that we weren't expecting, so there was nothing in _events | 16:39 |
| melwitt | sean-k-mooney: okay. I don't know what makes qemu decide to remove a tap | 16:39 |
| mriedem | giblet: thanks | 16:39 |
| ildikov | mriedem: giblet: thanks | 16:39 |
| melwitt | mriedem: we did get an unexpected one. we weirdly get network-change AND network-vif-plugged during the hard reboot while we are 'virsh destroy'ing and BEFORE we unplug anything. I don't understand it | 16:39 |
| mriedem | melwitt: yeah was looking at that, | 16:40 |
| mriedem | and after that, the nw info cache says the port is active=false | 16:40 |
| melwitt | right | 16:40 |
| mriedem | so that's why we wait for vif-plugged | 16:40 |
| mriedem | but we aren't going to get that, | 16:40 |
| melwitt | which is how we go into waiting mode | 16:40 |
| mriedem | because we alreayd got a vif-plugged | 16:40 |
| mriedem | yeah... | 16:40 |
| melwitt | I don't get how we get a vif plugged from ... not plugging anything yet | 16:41 |
| melwitt | because you can see the first vif-plugged from the instance boot, then after the reboot starts but before even the unplug, we get vif-plugged again | 16:41 |
| sean-k-mooney | melwitt: well unplug for linux bridge in os-vif is a noop https://github.com/openstack/os-vif/blob/stable/queens/vif_plug_linux_bridge/linux_bridge.py#L114-L117 which is why i dont that that os-vif is the issue here. | 16:41 |
| melwitt | hah, a no-op | 16:42 |
| mriedem | so after the instance is created but before we reboot, we get network-changed here: | 16:42 |
| mriedem | http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_35_168999 | 16:42 |
| mriedem | which forces us to refresh the nw info cache | 16:42 |
| melwitt | ah, so that's where the active=True -> active=False change comes from | 16:43 |
| melwitt | I was wondering how that happens | 16:43 |
| figleaf | giblet: no, I was testing on PS3 | 16:43 |
| mriedem | then we start rebooting http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_35_600736 | 16:43 |
| *** acormier has joined #openstack-nova | 16:43 | |
| figleaf | giblet: if you need to explicitly add that to every test class in order to catch invalid UUIDs, then I don't think that's very useful | 16:44 |
| mriedem | at that point, it says the vif is active | 16:44 |
| mriedem | "active": true | 16:44 |
| melwitt | yes | 16:44 |
| mriedem | then we get a vif-plugged event, from god knwos where http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_36_665892 | 16:44 |
| melwitt | yep | 16:44 |
| mriedem | which we were'nt expecting and that's why we see "Unexpected attempt to pop events during shutdown" | 16:45 |
| melwitt | right | 16:45 |
| giblet | figleaf: nova tests are derived from nova.tests.TestCase and that automatically sets up the warning fixture. The test case you added does not derive from nova.tests.TestCase but derives from testools.TestCase | 16:45 |
| mriedem | at that point the vif is not active | 16:45 |
| mriedem | "active": false | 16:45 |
| mriedem | and we've refreshed the nw info cache | 16:45 |
| mriedem | i'm not sure what is event making us refresh the nw info cache there | 16:46 |
| *** cgoncalves has joined #openstack-nova | 16:46 | |
| giblet | figleaf: we can try to make TestWarningsFixture derive from nova.tests.TestCase then we don't need the extra test setup test_invalid_uuid_errors | 16:46 |
| melwitt | mriedem: do we do it for any event? maybe the vif plugged refreshed it? | 16:46 |
| mriedem | no, _process_instance_event doesn't do that | 16:47 |
| melwitt | and I see now the erroneous "pop event during shutdown", I agree it would log that any time we got an unexpected event | 16:47 |
| melwitt | okay, so external_instance_event in compute is what decides whether to refresh the info_cache | 16:48 |
| melwitt | I see it for network-changed only | 16:48 |
| melwitt | but something did update the info_cache right after we got the random plug event | 16:50 |
| *** slaweq has joined #openstack-nova | 16:51 | |
| sean-k-mooney | i wonder if its related to this change in neutron https://review.openstack.org/#/c/246898/22/neutron/plugins/ml2/rpc.py | 16:51 |
| *** chyka has joined #openstack-nova | 16:51 | |
| *** liusheng has quit IRC | 16:52 | |
| mriedem | this is where neutron sends that mystery vif-plugged event http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-q-svc.txt.gz#_Jan_29_16_01_36_514905 | 16:52 |
| *** liusheng has joined #openstack-nova | 16:52 | |
| sean-k-mooney | that chagne was done for live migration but it emits that event every time a port state is modified | 16:52 |
| melwitt | mriedem: yeah, saw that | 16:52 |
| *** amodi has quit IRC | 16:53 | |
| mriedem | sean-k-mooney: hmm, that's been around since newton | 16:53 |
| melwitt | I wish I could tell what refreshed the info_cache in this mystery refresh. doesn't look like it was from a periodic heal else we'd see a log message about that | 16:53 |
| *** tssurya has quit IRC | 16:53 | |
| sean-k-mooney | mriedem: yes though i dont think we use it in nova yet | 16:53 |
| sean-k-mooney | melwitt: sahid has some patches related to it currently | 16:54 |
| mriedem | hmm http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-q-svc.txt.gz#_Jan_29_16_01_36_095844 | 16:54 |
| mriedem | Jan 29 16:01:36.095844 ubuntu-xenial-rax-ord-0002240582 neutron-server[21191]: DEBUG neutron.notifiers.nova [None req-1655d8dd-b810-4510-ba6a-fb2a5019a84a None None] Ignoring state change previous_port_status: ACTIVE current_port_status: BUILD port_id 8de74fd2-a3bc-4d41-9c11-c04f25b52b6d {{(pid=21288) record_port_status_changed /opt/stack/new/neutron/neutron/notifiers/nova.py:208}} | 16:54 |
| *** chyka_ has joined #openstack-nova | 16:54 | |
| *** FL1SK has quit IRC | 16:55 | |
| *** chyka has quit IRC | 16:55 | |
| *** AlexeyAbashkin has joined #openstack-nova | 16:56 | |
| sean-k-mooney | mriedem: ya that looks... interesting. perhaps neutron does not allow an active port to go back to build? | 16:56 |
| melwitt | mriedem: the mystery refresh might be this? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3152 | 16:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Escalate UUID validation warning to error in test https://review.openstack.org/540386 | 16:58 |
| mriedem | melwitt: for that call, it's this http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_36_172052 | 16:59 |
| mriedem | same request id as for the rebooting instance message | 16:59 |
| giblet | figleaf: ^^ now the test derives from nova.test.TestCase and therefore I could remove the explicit fixture setup from this test as well | 16:59 |
| melwitt | oh :\ | 16:59 |
| *** slaweq has quit IRC | 16:59 | |
| mriedem | melwitt: what i'm confused about is the mystery vif-plugged happens, and the request id being used is here http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_37_230004 | 16:59 |
| mriedem | Jan 29 16:01:36.673427 ubuntu-xenial-rax-ord-0002240582 nova-compute[29444]: WARNING nova.compute.manager [None req-1cb07971-b6f2-41f9-b34b-bc03b867abdb service nova] [instance: 3fa55d94-b1f4-42f4-8ba0-9ca46c71d7c0] Received unexpected event network-vif-plugged-8de74fd2-a3bc-4d41-9c11-c04f25b52b6d for instance with vm_state active and task_state rebooting_hard. | 16:59 |
| mriedem | Jan 29 16:01:37.230004 ubuntu-xenial-rax-ord-0002240582 nova-compute[29444]: DEBUG nova.network.base_api [None req-1cb07971-b6f2-41f9-b34b-bc03b867abdb service nova] [instance: 3fa55d94-b1f4-42f4-8ba0-9ca46c71d7c0] Updating instance_info_cache with network_info: | 17:00 |
| mriedem | those are the same request id | 17:00 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add generation support in aggregate association https://review.openstack.org/540447 | 17:00 |
| mriedem | in the neutron logs, that's this request http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-q-svc.txt.gz#_Jan_29_16_01_37_142123 | 17:01 |
| mriedem | RESP BODY: {"events": [{"status": "completed", "tag": "8de74fd2-a3bc-4d41-9c11-c04f25b52b6d", "name": "network-vif-plugged", "server_uuid": "3fa55d94-b1f4-42f4-8ba0-9ca46c71d7c0", "code": 200}]} | 17:01 |
| *** slaweq has joined #openstack-nova | 17:01 | |
| mriedem | maybe there is just a bug in logging with request ids getting mixed up, idk, but i feel like i've seen that before | 17:02 |
| melwitt | mriedem: how do you know the first one is the call from the compute manager reboot method? | 17:02 |
| sean-k-mooney | mriedem: https://github.com/openstack/neutron/blob/3f1a9846d23198f4a89f89bac73ba80ef201dea0/neutron/notifiers/nova.py#L178-L215 if we go directly from active to build the unpugged event will not be sent | 17:02 |
| mriedem | melwitt: same request id | 17:02 |
| sean-k-mooney | melwitt: that is why we are seeing the ignored event http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-q-svc.txt.gz#_Jan_29_16_01_36_095844 | 17:03 |
| melwitt | oh derp, I see now | 17:03 |
| melwitt | got it | 17:03 |
| mriedem | i don't know why we'd go from active to build | 17:03 |
| melwitt | well, the external instance events are REST API calls to nova from neutron so they'd have separate request ids, right? | 17:03 |
| mriedem | they shoud | 17:04 |
| mriedem | *should | 17:04 |
| melwitt | but yeah why the vif plug event call and the refresh info cache call have the same id doesn't make sense if we don't refresh for a plug event | 17:04 |
| mriedem | i don't really trust the request id logging lately | 17:05 |
| *** sree has joined #openstack-nova | 17:06 | |
| mriedem | so, again, idk wtf is going on - and since we can't rely on this, it seems we just can't wait for vif plugged events during hard reboot and have to punt on that | 17:07 |
| mriedem | definitely some weird timing issues | 17:07 |
| mriedem | this is likely also something one might not see in the real world, | 17:08 |
| mriedem | because tempest is creating an instance and then immediately hard rebooting it | 17:08 |
| mriedem | which is probably not helping the timing issue with the various events and such | 17:08 |
| mriedem | which we could then argue, our code *should* wait for a vif plugged event during hard reboot...but it fails in the gate | 17:09 |
| melwitt | yeah, agree | 17:09 |
| melwitt | I'm working on the comment update, just was also examining logs and discussing about it in the middle of it | 17:09 |
| mriedem | we could make vif plugging timeout be non-fatal in the LB job, but that's also a hack, and likely the test would timeout by then anyway b/c we're waiting 5 minutes for something to happen | 17:10 |
| *** r-daneel has quit IRC | 17:10 | |
| *** sree has quit IRC | 17:10 | |
| melwitt | yeah | 17:11 |
| figleaf | giblet: just pulled down PS5, and it still fails locally for me. I don't know what could be the difference. | 17:14 |
| mriedem | totally unrelated, but noticed https://review.openstack.org/#/c/274869/ - in what case does _heal_instance_info_cache() care about the instance.flavor? | 17:14 |
| melwitt | does it send any notifications? that's the only thing that comes to mind | 17:15 |
| mriedem | there must be a notification getting sent when the instance is updated as a result of updating the nw info cache i guess | 17:15 |
| *** fried_rice is now known as fried_rolls | 17:16 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Don't wait for vif plug events during _hard_reboot https://review.openstack.org/540168 | 17:20 |
| melwitt | mriedem bauwser ^ | 17:20 |
| *** gyee has joined #openstack-nova | 17:23 | |
| *** sahid has quit IRC | 17:23 | |
| mriedem | heading to lunch, will take a look when i'm back | 17:24 |
| melwitt | cool, thanks | 17:24 |
| *** yamahata has joined #openstack-nova | 17:24 | |
| mriedem | btw, do we get a network-changed event at least from neutron during reboot after we unplug the vifs? | 17:24 |
| mriedem | i didn't look for that yet in the logs | 17:24 |
| *** mriedem is now known as mriedem_afk | 17:24 | |
| melwitt | we don't. as sean-k-mooney mentioned, the os-vif unplug method for linuxbridge is a no-op, it just does a pass, so that seems consistent with the lack of any event about it | 17:25 |
| melwitt | here's the unplug http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_37_704617 | 17:27 |
| *** lpetrut has joined #openstack-nova | 17:27 | |
| *** r-daneel has joined #openstack-nova | 17:28 | |
| *** derekh has quit IRC | 17:29 | |
| *** tesseract has quit IRC | 17:30 | |
| *** yamamoto has joined #openstack-nova | 17:32 | |
| *** slaweq has quit IRC | 17:32 | |
| *** yamamoto has quit IRC | 17:36 | |
| *** harlowja has quit IRC | 17:37 | |
| *** jpena is now known as jpena|off | 17:38 | |
| *** AlexeyAbashkin has quit IRC | 17:39 | |
| *** sambetts is now known as sambetts|afk | 17:40 | |
| *** ttsiouts has quit IRC | 17:40 | |
| *** elmaciej has joined #openstack-nova | 17:41 | |
| *** yamamoto has joined #openstack-nova | 17:45 | |
| *** yamamoto has quit IRC | 17:45 | |
| *** damien_r has quit IRC | 17:46 | |
| *** elmaciej has quit IRC | 17:52 | |
| figleaf | giblet: looks like zuul's environment matches mine: http://logs.openstack.org/86/540386/5/check/openstack-tox-py27/2b58498/job-output.txt.gz#_2018-02-02_17_26_13_388933 | 17:56 |
| *** yamahata has quit IRC | 17:56 | |
| *** mgoddard_ has quit IRC | 17:59 | |
| *** amodi has joined #openstack-nova | 18:00 | |
| *** jaosorior has quit IRC | 18:07 | |
| *** vladikr has quit IRC | 18:09 | |
| *** vladikr has joined #openstack-nova | 18:10 | |
| *** lpetrut has quit IRC | 18:11 | |
| *** abalutoiu_ has joined #openstack-nova | 18:13 | |
| *** abalutoiu has quit IRC | 18:16 | |
| *** dklyle has joined #openstack-nova | 18:16 | |
| *** harlowja has joined #openstack-nova | 18:21 | |
| *** dtantsur is now known as dtantsur|afk | 18:23 | |
| sean-k-mooney | melwitt: looking at http://logs.openstack.org/42/525842/11/check/neutron-tempest-linuxbridge/2502b64/logs/screen-n-cpu.txt.gz#_Jan_29_16_01_37_811903 we are configuring libvirt to add the interface to the bridge iteself. the linuxbridge os-vif plugin plug method seams to be doing a lot of work that is not strictly require for neutron and presuable is there for nova network | 18:28 |
| *** ralonsoh has quit IRC | 18:30 | |
| sean-k-mooney | for example it also addes the vm port to the bridge if not already done so and also ensure the bridge existis and has an uplink port (phyical or vlan) added and brings up the bridge | 18:30 |
| sean-k-mooney | the only thing its doing that is really required is setting the mtu and making sure ip adresses are not configured on the tap on the host. | 18:31 |
| sean-k-mooney | i would guess we can make that driver alot smaller once nova-networks support can be dropped. | 18:32 |
| *** links has quit IRC | 18:41 | |
| *** yangyape_ has joined #openstack-nova | 18:41 | |
| *** yangyapeng has quit IRC | 18:45 | |
| *** yamamoto has joined #openstack-nova | 18:45 | |
| *** cdent has quit IRC | 18:49 | |
| *** yamamoto has quit IRC | 18:58 | |
| *** Swami has joined #openstack-nova | 19:03 | |
| *** mvenesio has joined #openstack-nova | 19:05 | |
| *** lucasagomes is now known as lucas-afk | 19:05 | |
| *** mvenesio has quit IRC | 19:05 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:11 | |
| *** bpoulos has joined #openstack-nova | 19:12 | |
| *** gjayavelu has joined #openstack-nova | 19:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: doc: Add user index page https://review.openstack.org/540494 | 19:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Migrate "launch instance" user guide docs https://review.openstack.org/540495 | 19:18 |
| *** sdague has quit IRC | 19:19 | |
| *** sdague has joined #openstack-nova | 19:24 | |
| *** felipemonteiro_ has quit IRC | 19:28 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:29 | |
| *** moshele has joined #openstack-nova | 19:53 | |
| *** gjayavelu has quit IRC | 19:53 | |
| *** lpetrut has joined #openstack-nova | 19:57 | |
| *** moshele has quit IRC | 19:57 | |
| *** AlexeyAbashkin has quit IRC | 19:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix native luks encryption failure to find volume_id https://review.openstack.org/539739 | 20:01 |
| *** gjayavelu has joined #openstack-nova | 20:01 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:04 | |
| *** yaaaaarwood is now known as lyarwood | 20:06 | |
| *** david-lyle_ has joined #openstack-nova | 20:11 | |
| *** dklyle has quit IRC | 20:11 | |
| *** david-lyle_ is now known as dklyle | 20:11 | |
| *** yamahata has joined #openstack-nova | 20:13 | |
| *** tssurya has joined #openstack-nova | 20:14 | |
| *** moshele has joined #openstack-nova | 20:16 | |
| *** lyarwood is now known as yaaaaarwood | 20:17 | |
| *** fried_rolls is now known as fried_rice | 20:17 | |
| *** owalsh_ has joined #openstack-nova | 20:18 | |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: docs: Add booting from an encrypted volume https://review.openstack.org/540506 | 20:18 |
| *** AlexeyAbashkin has quit IRC | 20:19 | |
| *** owalsh has quit IRC | 20:21 | |
| *** owalsh has joined #openstack-nova | 20:23 | |
| *** liverpooler has quit IRC | 20:24 | |
| *** fullmetaljackiet has joined #openstack-nova | 20:26 | |
| *** owalsh_ has quit IRC | 20:26 | |
| *** Guest99280 has quit IRC | 20:27 | |
| *** salv-orlando has quit IRC | 20:28 | |
| *** salv-orlando has joined #openstack-nova | 20:28 | |
| *** gjayavelu has quit IRC | 20:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix test_get_allocation_candidates tests https://review.openstack.org/540513 | 20:30 |
| mriedem_afk | ^ fixes a gate issue that was introduced yesterday | 20:30 |
| *** mriedem_afk is now known as mriedem | 20:30 | |
| *** salv-orlando has quit IRC | 20:33 | |
| *** READ10 has quit IRC | 20:35 | |
| *** pchavva has quit IRC | 20:38 | |
| *** felipemonteiro__ has joined #openstack-nova | 20:39 | |
| *** gjayavelu has joined #openstack-nova | 20:40 | |
| *** hongbin has joined #openstack-nova | 20:41 | |
| *** felipemonteiro_ has quit IRC | 20:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: Add booting from an encrypted volume https://review.openstack.org/540506 | 20:43 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: docs: Add booting from an encrypted volume https://review.openstack.org/540506 | 20:43 |
| mriedem | d'oh! | 20:43 |
| *** tbachman has joined #openstack-nova | 20:45 | |
| bpoulos | mriedem: looks like you just beat me to it :) | 20:47 |
| mriedem | np, thanks for moving that over | 20:48 |
| imacdonn | wow, race condition ;) | 20:48 |
| fried_rice | leakypipes: It happened again: http://logs.openstack.org/60/531260/27/check/nova-tox-functional-py35/cdf1b02/job-output.txt.gz | 20:49 |
| fried_rice | mriedem: Is https://bugs.launchpad.net/nova/+bug/1747063 / https://review.openstack.org/#/c/540513 a duplicate of https://bugs.launchpad.net/nova/+bug/1747001 / https://review.openstack.org/#/c/540420 ? | 20:52 |
| openstack | Launchpad bug 1747063 in OpenStack Compute (nova) "TestProviderOperations.test_get_allocation_candidates randomly fails AssertionError because of hash seed" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 20:52 |
| openstack | Launchpad bug 1747001 in OpenStack Compute (nova) "Use of parse.urlencode with dict in nova/tests/unit/scheduler/client/test_report.py can result in unpredictable query strings and thus unreliable tests" [Low,In progress] - Assigned to Chris Dent (cdent) | 20:52 |
| *** moshele has quit IRC | 20:54 | |
| *** sean-k-mooney has quit IRC | 20:56 | |
| *** lyan has joined #openstack-nova | 20:57 | |
| *** mchlumsky has quit IRC | 20:58 | |
| *** mchlumsky has joined #openstack-nova | 21:03 | |
| *** dave-mccowan has quit IRC | 21:04 | |
| tssurya | dansmith, mriedem : after the upgrade to Ocata yesterday and we are observing that "memory_mb_used" in "compute_nodes" tables is not correct. However, the resource_tracker log in the hypervisor is correct. Was wondering if there is a known bug or if you have heard anything similar to this issue? | 21:07 |
| mriedem | fried_rice: yes looks like it, i'll close mine | 21:09 |
| fried_rice | rgr | 21:10 |
| mriedem | tssurya: maybe | 21:11 |
| mriedem | tssurya: likely https://review.openstack.org/#/c/520024/ | 21:11 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1729621 | 21:11 |
| openstack | Launchpad bug 1729621 in OpenStack Compute (nova) "Inconsistent value for vcpu_used" [High,In progress] - Assigned to Maciej Jozefczyk (maciej.jozefczyk) | 21:11 |
| *** hemna_ has quit IRC | 21:14 | |
| bauwser | melwitt: https://review.openstack.org/#/c/540168/ +2d | 21:14 |
| bauwser | call it a week | 21:14 |
| bauwser | \o | 21:14 |
| *** bauwser is now known as bauzas | 21:15 | |
| *** dave-mccowan has joined #openstack-nova | 21:17 | |
| *** dave-mccowan has quit IRC | 21:24 | |
| *** bpoulos has quit IRC | 21:24 | |
| *** gjayavelu has quit IRC | 21:26 | |
| *** lpetrut has quit IRC | 21:26 | |
| tssurya | mriedem : thank you, the issue we have looks related to the one you pointed. | 21:27 |
| *** salv-orlando has joined #openstack-nova | 21:29 | |
| *** lyan has quit IRC | 21:31 | |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: improve support matrix notes https://review.openstack.org/540534 | 21:32 |
| *** owalsh has quit IRC | 21:32 | |
| *** priteau has quit IRC | 21:33 | |
| *** owalsh has joined #openstack-nova | 21:33 | |
| *** salv-orlando has quit IRC | 21:33 | |
| yaaaaarwood | mriedem: evening | 21:46 |
| yaaaaarwood | mriedem: back for a few hours, finally worked out why I didn't see failures due to https://review.openstack.org/#/c/539739/ in my LM tests | 21:47 |
| * mriedem moves to the edge of the seat | 21:47 | |
| yaaaaarwood | mriedem: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L153-L159 - without encryption_secret_uuid we just skip adding the encryption XML | 21:48 |
| yaaaaarwood | mriedem: that's impossible to see in the logs at present | 21:48 |
| yaaaaarwood | mriedem: mriedem the LM still completes, the instance just has an encrypted volume attached on the dest | 21:48 |
| mriedem | unencrypted you mean? | 21:49 |
| yaaaaarwood | yamahata: very much encrypted, the encrypted XML decrypts, without it the volume is presented as encrypted to the guest | 21:50 |
| yaaaaarwood | encryption XML* | 21:50 |
| mriedem | so is this another bug? | 21:50 |
| yaaaaarwood | mriedem: no, it's not another bug | 21:51 |
| mriedem | or just, the connection_info['volume_id'] was wrong but the LM tests weren't failing on it? | 21:51 |
| mriedem | b/c ^reasons | 21:51 |
| *** owalsh has quit IRC | 21:52 | |
| yaaaaarwood | mriedem: correct, without the volume_id set we didn't lookup the local secret and stash the UUID | 21:52 |
| yaaaaarwood | mriedem: that's then used on the source to update the XML | 21:52 |
| mriedem | ok so https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L153 evals to False and we just, whatever | 21:52 |
| mriedem | don't care | 21:52 |
| mriedem | how would a user notice this? not be able to use the encrypted volume? | 21:53 |
| *** dave-mccowan has joined #openstack-nova | 21:53 | |
| *** owalsh has joined #openstack-nova | 21:53 | |
| yaaaaarwood | yeah, they would see a LUKS block device within the instance | 21:53 |
| mriedem | ok | 21:54 |
| mriedem | well my patch should be all happy now | 21:54 |
| yaaaaarwood | kk, thanks, I'll try to get it tested in the DNM change pulling in the various tempest and devstack changes now | 21:55 |
| yaaaaarwood | for LM testing | 21:55 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | 21:59 |
| *** abalutoiu__ has joined #openstack-nova | 21:59 | |
| *** mriedem has quit IRC | 21:59 | |
| *** awaugama has quit IRC | 22:02 | |
| *** abalutoiu_ has quit IRC | 22:03 | |
| *** dave-mccowan has quit IRC | 22:03 | |
| *** gjayavelu has joined #openstack-nova | 22:07 | |
| *** itlinux has joined #openstack-nova | 22:08 | |
| openstackgerrit | Merged openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907 | 22:09 |
| *** Tom-Tom has joined #openstack-nova | 22:10 | |
| *** Tom-Tom has quit IRC | 22:14 | |
| *** amodi has quit IRC | 22:22 | |
| openstackgerrit | AJAY KALAMBUR proposed openstack/nova master: Fix incorrect port unbind request in nova on instance delete https://review.openstack.org/387687 | 22:22 |
| openstackgerrit | AJAY KALAMBUR proposed openstack/nova master: Fix incorrect port unbind request in nova on instance delete https://review.openstack.org/387687 | 22:26 |
| *** felipemonteiro_ has joined #openstack-nova | 22:26 | |
| *** felipemonteiro__ has quit IRC | 22:26 | |
| *** tidwellr has quit IRC | 22:28 | |
| *** acormier has quit IRC | 22:30 | |
| *** acormier has joined #openstack-nova | 22:31 | |
| *** salv-orlando has joined #openstack-nova | 22:31 | |
| *** slaweq has joined #openstack-nova | 22:32 | |
| *** yaaaaarwood is now known as lyarwood | 22:32 | |
| *** esberglu has quit IRC | 22:34 | |
| *** acormier has quit IRC | 22:35 | |
| *** salv-orlando has quit IRC | 22:36 | |
| *** fullmetaljackiet has quit IRC | 22:39 | |
| *** itlinux has quit IRC | 22:41 | |
| *** felipemonteiro__ has joined #openstack-nova | 22:48 | |
| *** felipemonteiro_ has quit IRC | 22:52 | |
| *** figleaf is now known as edleafe | 22:58 | |
| *** tssurya has quit IRC | 23:00 | |
| *** mchlumsky has quit IRC | 23:00 | |
| *** tssurya has joined #openstack-nova | 23:01 | |
| *** felipemonteiro__ has quit IRC | 23:04 | |
| *** brault has quit IRC | 23:09 | |
| *** edmondsw has quit IRC | 23:09 | |
| openstackgerrit | Merged openstack/nova master: Don't rely on parse.urlencode in url comparisons https://review.openstack.org/540420 | 23:14 |
| openstackgerrit | Merged openstack/nova master: Add the nova-multiattach job https://review.openstack.org/532689 | 23:14 |
| *** burt has quit IRC | 23:14 | |
| *** acormier has joined #openstack-nova | 23:17 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104 | 23:22 |
| *** acormier has quit IRC | 23:22 | |
| openstackgerrit | Merged openstack/nova master: Don't wait for vif plug events during _hard_reboot https://review.openstack.org/540168 | 23:23 |
| *** slaweq has quit IRC | 23:29 | |
| *** priteau has joined #openstack-nova | 23:34 | |
| *** salv-orlando has joined #openstack-nova | 23:37 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Ensure resource classes correctly https://review.openstack.org/539738 | 23:39 |
| *** priteau has quit IRC | 23:39 | |
| fried_rice | leakypipes: Still needing some guidance on what to mock for that test ^ | 23:39 |
| fried_rice | (regardless of which approach we land on) | 23:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Don't wait for vif plug events during _hard_reboot https://review.openstack.org/540555 | 23:42 |
| *** elmaciej has joined #openstack-nova | 23:50 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Ensure resource classes correctly https://review.openstack.org/539738 | 23:55 |
| *** tbachman has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!