| *** yamamoto has joined #openstack-nova | 00:06 | |
| *** david-lyle has quit IRC | 00:10 | |
| *** dklyle has joined #openstack-nova | 00:10 | |
| *** liverpooler has joined #openstack-nova | 00:19 | |
| openstackgerrit | Hongbin Lu proposed openstack/nova master: [WIP] Handle IpAddressAlreadyAllocated exception https://review.openstack.org/535532 | 00:27 |
|---|---|---|
| *** hongbin has quit IRC | 00:28 | |
| *** READ10 has joined #openstack-nova | 00:33 | |
| *** mlavalle has quit IRC | 00:35 | |
| *** liuzz has joined #openstack-nova | 00:36 | |
| *** penick_ has quit IRC | 00:37 | |
| * alex_xu has too much items in the to-do list | 00:43 | |
| *** tuanla____ has joined #openstack-nova | 00:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Move body examples to an isolated directory https://review.openstack.org/529998 | 00:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 00:45 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix missing marker functions https://review.openstack.org/514579 | 00:46 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 00:46 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | 00:46 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 00:47 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201 | 00:47 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 00:48 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 00:48 |
| *** dklyle is now known as david-lyle | 00:52 | |
| *** zhaochao has joined #openstack-nova | 00:57 | |
| *** Swami has quit IRC | 01:00 | |
| *** READ10 has quit IRC | 01:01 | |
| *** READ10 has joined #openstack-nova | 01:03 | |
| *** hieulq_ has joined #openstack-nova | 01:03 | |
| *** pramodrj07 has joined #openstack-nova | 01:05 | |
| *** hiro-kobayashi has joined #openstack-nova | 01:05 | |
| *** hieulq has quit IRC | 01:06 | |
| *** crushil has joined #openstack-nova | 01:06 | |
| *** chyka has joined #openstack-nova | 01:07 | |
| *** smatzek has joined #openstack-nova | 01:08 | |
| *** lbragstad has joined #openstack-nova | 01:09 | |
| *** chyka_ has quit IRC | 01:11 | |
| *** yamahata has quit IRC | 01:11 | |
| *** chyka has quit IRC | 01:12 | |
| *** smatzek has quit IRC | 01:12 | |
| *** edmondsw has joined #openstack-nova | 01:12 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 01:12 |
| *** mdnadeem has joined #openstack-nova | 01:13 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 01:13 |
| *** bigdogstl has quit IRC | 01:14 | |
| *** edmondsw has quit IRC | 01:16 | |
| *** hoangcx has quit IRC | 01:24 | |
| *** tuanla____ has quit IRC | 01:24 | |
| *** tuanla____ has joined #openstack-nova | 01:25 | |
| *** hoangcx has joined #openstack-nova | 01:25 | |
| *** yasemin has quit IRC | 01:25 | |
| *** tiendc has joined #openstack-nova | 01:27 | |
| *** zhurong has joined #openstack-nova | 01:30 | |
| *** mdnadeem has quit IRC | 01:37 | |
| *** smatzek has joined #openstack-nova | 01:39 | |
| *** yasemin has joined #openstack-nova | 01:44 | |
| *** bigdogstl has joined #openstack-nova | 01:45 | |
| *** smatzek has quit IRC | 01:46 | |
| *** mdnadeem has joined #openstack-nova | 01:48 | |
| *** bigdogstl has quit IRC | 01:50 | |
| *** Tom-Tom has quit IRC | 01:53 | |
| *** Tom-Tom has joined #openstack-nova | 01:53 | |
| *** hshiina has joined #openstack-nova | 01:55 | |
| *** tbachman has quit IRC | 01:55 | |
| *** bigdogstl has joined #openstack-nova | 01:57 | |
| *** kukacz_ has quit IRC | 02:00 | |
| *** weshay|dentist is now known as weshay|ruck | 02:00 | |
| *** READ10 has quit IRC | 02:01 | |
| *** kukacz_ has joined #openstack-nova | 02:01 | |
| *** READ10 has joined #openstack-nova | 02:02 | |
| *** chyka has joined #openstack-nova | 02:02 | |
| *** READ10 has quit IRC | 02:02 | |
| *** chyka has quit IRC | 02:07 | |
| *** pramodrj07 has quit IRC | 02:08 | |
| *** crushil has quit IRC | 02:09 | |
| *** bigdogstl has quit IRC | 02:09 | |
| *** tinwood has quit IRC | 02:10 | |
| *** tinwood has joined #openstack-nova | 02:11 | |
| *** gcb has joined #openstack-nova | 02:28 | |
| Spazmotic | Morning | 02:29 |
| *** harlowja has quit IRC | 02:31 | |
| *** Guest56304 has quit IRC | 02:38 | |
| *** Guest56304 has joined #openstack-nova | 02:38 | |
| *** hongbin has joined #openstack-nova | 02:39 | |
| *** namnh has joined #openstack-nova | 02:40 | |
| *** bigdogstl has joined #openstack-nova | 02:40 | |
| *** bigdogstl has quit IRC | 02:45 | |
| *** owalsh_ is now known as owalsh | 02:45 | |
| *** threestrands_ has joined #openstack-nova | 02:49 | |
| *** threestrands_ has quit IRC | 02:49 | |
| *** threestrands_ has joined #openstack-nova | 02:49 | |
| *** threestrands has quit IRC | 02:51 | |
| *** bhujay has joined #openstack-nova | 03:03 | |
| *** bigdogstl has joined #openstack-nova | 03:03 | |
| *** liverpooler has quit IRC | 03:07 | |
| *** andreaf has quit IRC | 03:07 | |
| *** lbragstad has quit IRC | 03:08 | |
| *** bigdogstl has quit IRC | 03:13 | |
| *** gouthamr has joined #openstack-nova | 03:17 | |
| *** Tom-Tom has quit IRC | 03:18 | |
| *** bhujay has quit IRC | 03:21 | |
| *** gouthamr has quit IRC | 03:21 | |
| *** gouthamr has joined #openstack-nova | 03:27 | |
| *** chyka has joined #openstack-nova | 03:29 | |
| *** psachin has joined #openstack-nova | 03:32 | |
| *** yamahata has joined #openstack-nova | 03:35 | |
| *** andreaf has joined #openstack-nova | 03:36 | |
| *** bigdogstl has joined #openstack-nova | 03:37 | |
| *** fragatina has quit IRC | 03:38 | |
| *** fragatina has joined #openstack-nova | 03:39 | |
| *** sree has joined #openstack-nova | 03:40 | |
| *** fragatina has quit IRC | 03:41 | |
| *** tbachman has joined #openstack-nova | 03:43 | |
| *** AlexeyAbashkin has joined #openstack-nova | 03:44 | |
| *** jappleii__ has joined #openstack-nova | 03:44 | |
| *** jappleii__ has quit IRC | 03:45 | |
| *** jappleii__ has joined #openstack-nova | 03:45 | |
| *** tbachman_ has joined #openstack-nova | 03:45 | |
| *** jappleii__ has quit IRC | 03:46 | |
| *** threestrands_ has quit IRC | 03:46 | |
| *** lbragstad has joined #openstack-nova | 03:46 | |
| *** jappleii__ has joined #openstack-nova | 03:47 | |
| *** tbachman has quit IRC | 03:48 | |
| *** tbachman_ is now known as tbachman | 03:48 | |
| *** jappleii__ has quit IRC | 03:48 | |
| *** AlexeyAbashkin has quit IRC | 03:48 | |
| *** jappleii__ has joined #openstack-nova | 03:48 | |
| *** rcernin has quit IRC | 03:49 | |
| *** rcernin has joined #openstack-nova | 03:49 | |
| *** bigdogstl has quit IRC | 03:51 | |
| *** chyka has quit IRC | 03:57 | |
| *** fragatina has joined #openstack-nova | 03:59 | |
| *** purplerbot has quit IRC | 04:01 | |
| *** lbragstad has quit IRC | 04:02 | |
| *** vladikr has quit IRC | 04:03 | |
| *** vladikr has joined #openstack-nova | 04:03 | |
| *** hamzy_ has joined #openstack-nova | 04:03 | |
| *** fragatina has quit IRC | 04:04 | |
| *** ameeda has quit IRC | 04:04 | |
| *** felipemonteiro_ has joined #openstack-nova | 04:05 | |
| *** abhishekk has joined #openstack-nova | 04:07 | |
| *** gouthamr has quit IRC | 04:08 | |
| *** gouthamr has joined #openstack-nova | 04:09 | |
| *** bhujay has joined #openstack-nova | 04:10 | |
| *** purplerbot has joined #openstack-nova | 04:11 | |
| *** gouthamr has quit IRC | 04:12 | |
| *** gouthamr has joined #openstack-nova | 04:13 | |
| *** bigdogstl has joined #openstack-nova | 04:17 | |
| *** Tom-Tom has joined #openstack-nova | 04:18 | |
| *** bigdogstl has quit IRC | 04:22 | |
| *** diga has joined #openstack-nova | 04:22 | |
| *** Tom-Tom has quit IRC | 04:22 | |
| *** gouthamr has quit IRC | 04:23 | |
| *** bigdogstl has joined #openstack-nova | 04:24 | |
| *** gouthamr has joined #openstack-nova | 04:25 | |
| *** armax has quit IRC | 04:26 | |
| *** felipemonteiro_ has quit IRC | 04:26 | |
| *** janki has joined #openstack-nova | 04:26 | |
| *** armax has joined #openstack-nova | 04:27 | |
| *** chyka has joined #openstack-nova | 04:28 | |
| *** bigdogstl has quit IRC | 04:29 | |
| *** gouthamr has quit IRC | 04:29 | |
| *** gouthamr has joined #openstack-nova | 04:29 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:30 | |
| *** gouthamr has quit IRC | 04:32 | |
| *** gouthamr has joined #openstack-nova | 04:33 | |
| *** chyka has quit IRC | 04:33 | |
| *** chyka has joined #openstack-nova | 04:35 | |
| *** bigdogstl has joined #openstack-nova | 04:35 | |
| *** vladikr has quit IRC | 04:37 | |
| *** links has joined #openstack-nova | 04:37 | |
| *** vladikr has joined #openstack-nova | 04:37 | |
| *** namnh has quit IRC | 04:38 | |
| *** Dinesh_Bhor has quit IRC | 04:39 | |
| *** zhurong has quit IRC | 04:39 | |
| *** chyka has quit IRC | 04:40 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary arguments in notification methods https://review.openstack.org/535599 | 04:42 |
| *** vladikr has quit IRC | 04:43 | |
| *** archit has joined #openstack-nova | 04:43 | |
| *** vladikr has joined #openstack-nova | 04:43 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:45 | |
| *** Dinesh_Bhor has quit IRC | 04:53 | |
| *** andreas_s has joined #openstack-nova | 04:54 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:55 | |
| *** bigdogstl has quit IRC | 04:57 | |
| *** andreas_s has quit IRC | 04:58 | |
| Spazmotic | Spent most of my day still thinking about Placement, especially the RP Inventory Schema. Feels like we need a state field in there at least. | 05:03 |
| Spazmotic | The best option to main API only with the project would be to at least allow evacuation type API calls to solve local delete problems to clear out a host. | 05:03 |
| Spazmotic | or a resource provider I should say. | 05:03 |
| *** ratailor has joined #openstack-nova | 05:06 | |
| Spazmotic | i still need to think on it more while i'm reading some of these features though.. | 05:10 |
| *** yingjun has joined #openstack-nova | 05:13 | |
| *** diga has quit IRC | 05:16 | |
| *** zhurong has joined #openstack-nova | 05:19 | |
| *** Tom-Tom has joined #openstack-nova | 05:20 | |
| *** harlowja has joined #openstack-nova | 05:21 | |
| *** hongbin has quit IRC | 05:24 | |
| *** Tom-Tom has quit IRC | 05:25 | |
| *** diga has joined #openstack-nova | 05:26 | |
| *** takashin has left #openstack-nova | 05:32 | |
| *** vladikr has quit IRC | 05:43 | |
| *** Dinesh_Bhor has quit IRC | 05:43 | |
| *** crushil has joined #openstack-nova | 05:43 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:43 | |
| *** Dinesh_Bhor has quit IRC | 05:47 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:49 | |
| *** jappleii__ has quit IRC | 05:52 | |
| *** archit has quit IRC | 05:54 | |
| *** bigdogstl has joined #openstack-nova | 05:56 | |
| *** hiro-kobayashi has quit IRC | 06:01 | |
| *** armax has quit IRC | 06:03 | |
| *** bigdogstl has quit IRC | 06:07 | |
| *** trinaths has joined #openstack-nova | 06:11 | |
| *** jaosorior has joined #openstack-nova | 06:11 | |
| *** logan- has quit IRC | 06:16 | |
| *** itlinux has joined #openstack-nova | 06:16 | |
| *** crushil has quit IRC | 06:22 | |
| *** gouthamr has quit IRC | 06:28 | |
| *** trinaths has left #openstack-nova | 06:29 | |
| *** trinaths has joined #openstack-nova | 06:29 | |
| *** harlowja has quit IRC | 06:29 | |
| *** annp has joined #openstack-nova | 06:33 | |
| *** logan- has joined #openstack-nova | 06:40 | |
| *** pcaruana has joined #openstack-nova | 06:44 | |
| Spazmotic | If anyone has got some free cycles would still love a review on my XenAPI commit: https://review.openstack.org/#/c/533168/ -- I know you're all busy with Queens and pushing through things before the freeze though. | 06:45 |
| *** andreas_s has joined #openstack-nova | 06:49 | |
| *** ankit_ has joined #openstack-nova | 06:58 | |
| *** sridharg has joined #openstack-nova | 07:00 | |
| *** bigdogstl has joined #openstack-nova | 07:02 | |
| *** namnh has joined #openstack-nova | 07:03 | |
| *** sridharg has quit IRC | 07:06 | |
| *** sridharg has joined #openstack-nova | 07:08 | |
| *** diga has quit IRC | 07:11 | |
| *** bigdogstl has quit IRC | 07:14 | |
| *** Dinesh_Bhor has quit IRC | 07:19 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:20 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: support traits in allocation candidates API https://review.openstack.org/535642 | 07:22 |
| *** Tom-Tom has joined #openstack-nova | 07:22 | |
| *** bigdogstl has joined #openstack-nova | 07:25 | |
| *** Tom-Tom has quit IRC | 07:27 | |
| *** fragatina has joined #openstack-nova | 07:28 | |
| *** itlinux has quit IRC | 07:29 | |
| *** bigdogstl has quit IRC | 07:30 | |
| *** sahid has joined #openstack-nova | 07:30 | |
| *** lajoskatona has joined #openstack-nova | 07:30 | |
| *** fragatina has quit IRC | 07:33 | |
| *** bigdogstl has joined #openstack-nova | 07:37 | |
| *** slaweq has joined #openstack-nova | 07:40 | |
| *** rcernin has quit IRC | 07:43 | |
| *** bigdogstl has quit IRC | 07:44 | |
| *** janki has quit IRC | 07:45 | |
| *** tbh_ has joined #openstack-nova | 07:59 | |
| *** rm_work has quit IRC | 08:08 | |
| *** bigdogstl has joined #openstack-nova | 08:10 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:13 | |
| *** sree has quit IRC | 08:13 | |
| *** sree has joined #openstack-nova | 08:13 | |
| *** markvoelker has quit IRC | 08:14 | |
| *** tesseract has joined #openstack-nova | 08:16 | |
| *** alexchadin has joined #openstack-nova | 08:16 | |
| *** harlowja has joined #openstack-nova | 08:17 | |
| *** sree has quit IRC | 08:18 | |
| *** rm_work has joined #openstack-nova | 08:20 | |
| *** bigdogstl has quit IRC | 08:20 | |
| openstackgerrit | xulei proposed openstack/nova master: resolve confusing state when rebuilding https://review.openstack.org/535665 | 08:22 |
| *** tetsuro has quit IRC | 08:24 | |
| *** tuanla_____ has joined #openstack-nova | 08:25 | |
| *** namnh_ has joined #openstack-nova | 08:26 | |
| *** sdake has quit IRC | 08:27 | |
| openstackgerrit | xulei proposed openstack/nova master: resolve confusing state when rebuilding https://review.openstack.org/535665 | 08:27 |
| *** gus has quit IRC | 08:27 | |
| *** flwang has quit IRC | 08:28 | |
| *** kholkina has joined #openstack-nova | 08:28 | |
| *** StevenK has quit IRC | 08:28 | |
| *** annp has quit IRC | 08:28 | |
| *** tuanla____ has quit IRC | 08:28 | |
| *** tuanla_____ has quit IRC | 08:28 | |
| *** namnh has quit IRC | 08:28 | |
| *** hoangcx has quit IRC | 08:28 | |
| *** tiendc has quit IRC | 08:28 | |
| *** gus has joined #openstack-nova | 08:29 | |
| *** tuanla_____ has joined #openstack-nova | 08:29 | |
| *** annp has joined #openstack-nova | 08:29 | |
| *** tiendc has joined #openstack-nova | 08:29 | |
| *** hoangcx has joined #openstack-nova | 08:29 | |
| *** StevenK has joined #openstack-nova | 08:29 | |
| *** sdake has joined #openstack-nova | 08:33 | |
| *** sdake has quit IRC | 08:33 | |
| *** sdake has joined #openstack-nova | 08:33 | |
| *** matrohon has quit IRC | 08:33 | |
| openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/534335 | 08:35 |
| *** harlowja has quit IRC | 08:37 | |
| *** namnh has joined #openstack-nova | 08:40 | |
| *** Dinesh_Bhor has quit IRC | 08:42 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:42 | |
| *** namnh_ has quit IRC | 08:43 | |
| *** flwang has joined #openstack-nova | 08:44 | |
| *** ralonsoh has joined #openstack-nova | 08:47 | |
| *** namnh has quit IRC | 08:54 | |
| *** jpena|off is now known as jpena | 08:54 | |
| *** rm_work has quit IRC | 08:56 | |
| * gibi finally got approval to go to Dublin | 08:58 | |
| Spazmotic | congrats :) | 08:59 |
| *** josecastroleon has joined #openstack-nova | 08:59 | |
| Spazmotic | More i'm looking over my code the more i'm thinking about doing it a new way | 08:59 |
| Spazmotic | I made it look like similar code.. but the code is old and needs refactor anyway.. heh | 09:00 |
| Spazmotic | Question is to let it go and refactor later or redesign now.. | 09:00 |
| Spazmotic | CinderV3 stuff introduction in June changes the way a lot of this stuff can work but Xenapi drivers arn't using it anywhere since no one works on them hehe | 09:00 |
| gibi | Spazmotic: in my experience refactoring is better long term than redesign | 09:01 |
| bauzas | gibi: cool | 09:01 |
| gibi | Spazmotic: redesign becomes a lot more work at the end | 09:01 |
| *** homeski has quit IRC | 09:02 | |
| bauzas | gibi: FWIW, finding flights was hectic for me | 09:02 |
| Spazmotic | True enough.. part of redesign would immediately deprecate a few volume_util funcs as well.. might be worth a few commit to phase it out and implement CinderV3 | 09:02 |
| bauzas | I was supposing Dublin was a big hub, it's not | 09:02 |
| gibi | bauzas: yeah, that is the next step, but first I have to sync with my wife as we plan a bit of free time before the ptg in Dublin | 09:02 |
| bauzas | so, most of the flights from Geneva were having a hop | 09:03 |
| *** lajoskatona has quit IRC | 09:03 | |
| gibi | bauzas: there is a Budapest - Dublin direct Ryanair flight couple of times a week | 09:03 |
| Spazmotic | You might wind up in Dublin even | 09:03 |
| gibi | bauzas: so I'm hoping to catch one of those | 09:03 |
| bauzas | gibi: that was my assumption | 09:04 |
| bauzas | lots of drunk Irish folks are visiting Grenoble, y'know | 09:04 |
| bauzas | mostly for a starting place for skiing | 09:04 |
| bauzas | but, when I looked at all the flights, most of them were either on Saturdays or like super early | 09:04 |
| bauzas | none were fitting my requirements | 09:04 |
| bauzas | because I'll be skiing on Saturday morning before catching my flight | 09:05 |
| bauzas | so I needed an afternoon 6pm-ish flight | 09:05 |
| bauzas | (we have an internal meeting on Sunday) | 09:05 |
| bauzas | and then, finding a flight departing late on Friday was f**รน hard | 09:05 |
| Spazmotic | Finally starting to get my head wrapped around Placements API.. Really need a functional env with it since my companies deployments don't utilize it. | 09:06 |
| *** avolkov` has joined #openstack-nova | 09:06 | |
| *** avolkov` has quit IRC | 09:06 | |
| bauzas | Spazmotic: there are functional tests and fixtures you can use for playing | 09:06 |
| *** avolkov` has joined #openstack-nova | 09:06 | |
| bauzas | Spazmotic: or just spin a devstack, you'll get for free | 09:06 |
| Spazmotic | Yeah hehe devstack is where I was going to go and play with some the funcs to get a good visual on mostly the DB layout in nova | 09:06 |
| bauzas | gibi: so, I'll need to bail out from the conf on noon, which is a shame in my opinion | 09:06 |
| *** ankit_ has quit IRC | 09:07 | |
| bauzas | gibi: I was expecting to find a 6pm flight leaving on Friday which would leave me arrive by 10pm-ish, it was not the case | 09:07 |
| bauzas | Spazmotic: DB layout(s) (you have 3 DBs when spinning a devstack) | 09:07 |
| bauzas | two different schedmas and 3 instances, I'd rather say | 09:08 |
| bauzas | (oh, and good morning stackers btw.) | 09:08 |
| Spazmotic | Ah.. i'll spin up an onmetal and get the installation going to take a look :D | 09:08 |
| gibi | bauzas: yeah, wanting a flight at an exact time sucks if you are not super rich | 09:09 |
| *** tianhui_ is now known as tianhui | 09:10 | |
| amorin | hey all | 09:11 |
| bauzas | gibi: worst than that | 09:11 |
| Spazmotic | Morning | 09:11 |
| bauzas | gibi: it's not a money problem | 09:11 |
| bauzas | gibi: it's rather that you have to consider spending 6+ hours in flights for doing a short haul distance | 09:11 |
| *** lajoskatona has joined #openstack-nova | 09:11 | |
| bauzas | gibi: and remember, Ryanair changed their carry-on baggage policy | 09:12 |
| bauzas | if you have a laptop bag *and* a carry-on baggage, then the latter goes as checked-in baggage | 09:12 |
| amorin | is there any reason for a tempest job to be killed by timeout? | 09:12 |
| gibi | bauzas: thanks for the baggage heads up, I have to check on that | 09:13 |
| amorin | http://logs.openstack.org/40/508640/6/check/legacy-tempest-dsvm-cells/5c83769/job-output.txt.gz | 09:13 |
| amorin | ERROR: the main setup script run by this job failed - exit code: 137 | 09:13 |
| gibi | bauzas: if you are super rich you can have private jet ;) | 09:13 |
| *** bigdogstl has joined #openstack-nova | 09:13 | |
| bauzas | amorin: there are some gate timeout issues AFAICT | 09:13 |
| bauzas | gibi: my company travel policy forbids it | 09:13 |
| bauzas | :p | 09:13 |
| amorin | bauzas: thanks | 09:13 |
| amorin | should I wait or can I recheck now> | 09:14 |
| amorin | ? | 09:14 |
| alex_xu | jaypipes: gibi bauzas, hi guys, the API patch for expose traits https://review.openstack.org/#/c/535642/, appreciate if you can take a look at | 09:14 |
| bauzas | gibi: but I'm living litterally 500 meters away from a very small air field | 09:14 |
| bauzas | gibi: I have as a wish to pass my private pilot license :) | 09:14 |
| bauzas | amorin: which change ? | 09:15 |
| bauzas | alex_xu: sure, I'll mostly focus on priorities | 09:15 |
| bauzas | as gibi +Wd some of my changes :p | 09:15 |
| alex_xu | bauzas: thanks | 09:16 |
| bauzas | oh fuuuuuuu*** I need to rebadse | 09:16 |
| Spazmotic | Zuuuuuuuuuuuul! heh | 09:17 |
| gibi | bauzas: having a pilot license, that sounds a cool plan | 09:17 |
| *** hshiina has quit IRC | 09:17 | |
| ildikov | bauzas: morning, do you plan to get through the multi-attach patches today too? :) | 09:18 |
| bauzas | gibi: that's just super expensive :p | 09:18 |
| gibi | bauzas: I can imagine | 09:18 |
| bauzas | ildikov: today is like a busy day for me, but as soon as I can tackle internal stuff (again) and rebase on my own changes, I'll focus on priority changes reviews | 09:18 |
| amorin | bauzas: https://review.openstack.org/#/c/508640/ | 09:19 |
| bauzas | amorin: I've seen that a couple of times | 09:22 |
| bauzas | amorin: the fact that we stop running tempest if we are too much delayed | 09:22 |
| bauzas | amorin: try a recheck | 09:22 |
| amorin | ok thanks | 09:23 |
| ildikov | bauzas: if you could put this on top of the pile that would be great as I travel on Monday and the gate will be crazy next week too, so I would like to be able to fix comments in case needed before that | 09:24 |
| *** bigdogstl has quit IRC | 09:24 | |
| ildikov | bauzas: thanks in advance | 09:24 |
| *** Tom-Tom has joined #openstack-nova | 09:24 | |
| bauzas | ildikov: no promise, but I'll try | 09:26 |
| Spazmotic | I would love to get my Xenapi piddly poop in the gate this week but I definately don't see it happening hehe. So will just learn Placements code and maybe fix this local delete bug | 09:26 |
| ildikov | bauzas: thanks | 09:27 |
| bauzas | Spazmotic: bugs are not impacted by the queens-3 deadline | 09:27 |
| Spazmotic | Well I just mean because the core reviewers are so busy, sir :) | 09:27 |
| *** Tom-Tom has quit IRC | 09:29 | |
| *** fragatina has joined #openstack-nova | 09:30 | |
| bauzas | Spazmotic: I'm French, we did cut the head of all our lords in the past, so you don't need to call me "sir" | 09:31 |
| bauzas | I'm neither too old nor too lordy | 09:31 |
| *** Dinesh_Bhor has quit IRC | 09:31 | |
| Spazmotic | Hehe it's a respect thing, I'll do my best. | 09:32 |
| *** fragatina has quit IRC | 09:35 | |
| *** rm_work has joined #openstack-nova | 09:36 | |
| *** tuanla____ has joined #openstack-nova | 09:40 | |
| *** derekh has joined #openstack-nova | 09:41 | |
| *** tuanla_____ has quit IRC | 09:44 | |
| *** xinliang has quit IRC | 09:44 | |
| *** alexchadin has quit IRC | 09:46 | |
| *** karthiks has quit IRC | 09:47 | |
| *** alexchadin has joined #openstack-nova | 09:47 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 09:47 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Recreate mediated devices on reboot https://review.openstack.org/533642 | 09:47 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: pass the mdevs when rebooting the guest https://review.openstack.org/533818 | 09:47 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Fix suspending guest with attached vGPUs https://review.openstack.org/535693 | 09:47 |
| Spazmotic | Ah yeah I meant to tell you those hit merge conflictr | 09:48 |
| Spazmotic | Sorry I Forgot | 09:48 |
| *** tuanla____ has quit IRC | 09:48 | |
| *** pcaruana has quit IRC | 09:50 | |
| *** tuanla____ has joined #openstack-nova | 09:50 | |
| *** bigdogstl has joined #openstack-nova | 09:52 | |
| bauzas | gibi: need again your +W, I needed to rebase https://review.openstack.org/#/c/528832/ | 09:53 |
| bauzas | (merge conflict) | 09:53 |
| *** pcaruana has joined #openstack-nova | 09:53 | |
| *** pcaruana has quit IRC | 09:53 | |
| bauzas | gibi: also, I just rebased https://review.openstack.org/#/c/533642 but it lost your +2 due to a merge solve | 09:54 |
| *** pcaruana has joined #openstack-nova | 09:54 | |
| *** vish_18 has joined #openstack-nova | 09:55 | |
| *** tuanla____ has quit IRC | 09:56 | |
| *** xinliang has joined #openstack-nova | 09:56 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/523958/11/nova/tests/unit/virt/libvirt/test_driver.py@6604 - remind me again what you mean by autospec here? | 09:57 |
| mdbooth | lyarwood: IIRC I wasn't overly exercised by that as we don't do it consistently | 09:57 |
| mdbooth | However, I was just wondering if you wanted to mock the class with an autospec | 09:57 |
| mdbooth | Which you've done in a few other places, and is generally awesome | 09:57 |
| vish_18 | frickler: hello | 09:57 |
| vish_18 | frickler: https://bugs.launchpad.net/keystone/+bug/1714937. i am not able to reproduce this issue on Pike | 09:58 |
| openstack | Launchpad bug 1714937 in OpenStack Identity (keystone) "keystone returns 500 on password change" [Low,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 09:58 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: support traits in allocation candidates API https://review.openstack.org/535642 | 09:58 |
| gibi | bauzas: I will check those soon | 09:59 |
| lyarwood | mdbooth: kk, can you actually do that with @mock.patch directly? | 09:59 |
| vish_18 | frickler: kindly help me to reproduce | 09:59 |
| * lyarwood should RTFM | 09:59 | |
| *** karthiks has joined #openstack-nova | 09:59 | |
| mdbooth | lyarwood: I think so, but as I say it wasn't a top priority to me | 10:00 |
| bauzas | gibi: cool thanks | 10:00 |
| * mdbooth needs a formal scale of review comments | 10:00 | |
| bauzas | gibi: oh, fuuuuu, did you run a nova meeting yesterday evening ? | 10:00 |
| bauzas | totally forgot it | 10:00 |
| *** jafeha has quit IRC | 10:00 | |
| *** jafeha has joined #openstack-nova | 10:01 | |
| mdbooth | Over my dead body > problem > would prefer > nit > suggestion | 10:01 |
| *** bigdogstl has quit IRC | 10:01 | |
| lyarwood | mdbooth: haha :) | 10:02 |
| * mdbooth would rate the autospec as 'would prefer' | 10:02 | |
| lyarwood | mdbooth: cool, so I'm obviously sorting the tests out this morning, I've given up on the P to Q LM tests for now, I think we can add them to the legacy-grenade-dsvm-neutron-multinode-live-migration pretty easily, just can't get grenade to play nice with f26 at the moment | 10:03 |
| gibi | bauzas: no I didn't but I think efried did | 10:03 |
| *** lucas-pto is now known as lucasagomes | 10:03 | |
| bauzas | k | 10:03 |
| bauzas | will look at the minutes then | 10:03 |
| mdbooth | lyarwood: Yeah. I wanted to do the tests for you yesterday but got unexpectedly bogged down. Sorry about that. | 10:03 |
| lyarwood | mdbooth: np | 10:03 |
| *** janki has joined #openstack-nova | 10:05 | |
| *** hieulq_ has quit IRC | 10:05 | |
| *** tbh_ has quit IRC | 10:09 | |
| openstackgerrit | Deepak Mourya proposed openstack/nova master: Handle TZ change in iso8601 >=1.12.0 https://review.openstack.org/535700 | 10:11 |
| *** gszasz has joined #openstack-nova | 10:11 | |
| *** markvoelker has joined #openstack-nova | 10:15 | |
| *** alexchadin has quit IRC | 10:21 | |
| *** hoangcx has quit IRC | 10:21 | |
| *** cdent has joined #openstack-nova | 10:25 | |
| gmann | vish_18: better to ask on keystone channel. | 10:27 |
| *** tiendc has quit IRC | 10:30 | |
| *** alexchadin has joined #openstack-nova | 10:31 | |
| *** sdague has joined #openstack-nova | 10:33 | |
| *** yingjun has quit IRC | 10:34 | |
| *** rmart04 has joined #openstack-nova | 10:35 | |
| *** liuzz has quit IRC | 10:39 | |
| *** zhurong has quit IRC | 10:41 | |
| *** cdent has quit IRC | 10:46 | |
| *** alexchadin has quit IRC | 10:46 | |
| *** markvoelker has quit IRC | 10:49 | |
| *** bauzas_ has joined #openstack-nova | 10:50 | |
| *** bauzas_ has quit IRC | 10:51 | |
| *** abhishekk has quit IRC | 10:53 | |
| *** dtantsur|afk is now known as dtantsur | 10:54 | |
| *** shuail has joined #openstack-nova | 11:00 | |
| *** bigdogstl has joined #openstack-nova | 11:03 | |
| *** shuail has quit IRC | 11:03 | |
| *** yamahata has quit IRC | 11:04 | |
| *** alexchadin has joined #openstack-nova | 11:07 | |
| *** ttallgren has joined #openstack-nova | 11:08 | |
| *** mdnadeem has quit IRC | 11:08 | |
| *** jangutter has joined #openstack-nova | 11:13 | |
| *** jangutter has quit IRC | 11:13 | |
| *** bigdogstl has quit IRC | 11:14 | |
| *** ratailor has quit IRC | 11:15 | |
| *** claudiub has joined #openstack-nova | 11:23 | |
| *** Tom-Tom has joined #openstack-nova | 11:25 | |
| *** Tom-Tom has quit IRC | 11:30 | |
| *** fragatina has joined #openstack-nova | 11:32 | |
| *** fragatina has quit IRC | 11:37 | |
| *** tbachman has quit IRC | 11:39 | |
| *** smatzek has joined #openstack-nova | 11:40 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/535030 | 11:41 |
| openstackgerrit | Merged openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | 11:41 |
| *** markvoelker has joined #openstack-nova | 11:46 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | 11:47 |
| lyarwood | mdbooth, stephenfin; ^ if you have time, should be almost ready to go now | 11:47 |
| mdbooth | lyarwood: Looking now | 11:48 |
| lyarwood | hmmm merge conflict, let me rebase the series | 11:49 |
| lyarwood | oh nice, the multi-attach stuff landed overnight :) | 11:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Collocate encryptor and volume driver calls https://review.openstack.org/460243 | 11:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Introduce disk encryption config classes https://review.openstack.org/464008 | 11:52 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | 11:52 |
| lyarwood | aaaaaaaaaand done. | 11:52 |
| *** annp has quit IRC | 11:55 | |
| Spazmotic | There are so few ways to clean up allocations in the current Placement API to a point that i think i'm missing something here | 11:57 |
| Spazmotic | How in the world are single allocations cleaned up.. | 11:58 |
| *** bigdogstl has joined #openstack-nova | 12:00 | |
| *** jafeha__ has joined #openstack-nova | 12:01 | |
| *** jafeha has quit IRC | 12:01 | |
| Spazmotic | ew.. | 12:02 |
| Spazmotic | Ew so it's just zeroing out the allocations | 12:09 |
| *** trinaths has left #openstack-nova | 12:11 | |
| Spazmotic | This can't be the openstack way to handle this.. | 12:12 |
| Spazmotic | Allocations are not using the updated_at and deleted_at standards and in order to update an allocation you have to pass the entire list of their current allocations plus changes into the JSON because it purges the entire list for a "Clean slate"? | 12:13 |
| Spazmotic | The only other place i've seen this is how neutron handles Static IP addresses in Ports which isn't so bad since it's an internal dictionary.. not database sets. | 12:13 |
| Spazmotic | This must be ridiculously unwieldy for large consumers.. not to mention dangerous. | 12:14 |
| Spazmotic | And I don't understand why ad esire for a clean slate every time a minor new allocation wants to be set for a consumer. | 12:15 |
| Spazmotic | efried, can you shine any light on this? | 12:15 |
| *** andreas_s has quit IRC | 12:18 | |
| Spazmotic | This local delete issue.. the best way I can see to resolve this is to allow a new API call to empty a resource provider, but the way that allocations are being handled is incredibly gross and would make that process extremely top heavy. Each alloc per RP would have to pull the consumer, then pull their allocs and reconstruct the allocs without the chosen alloc and then submit the entire list. | 12:18 |
| *** markvoelker has quit IRC | 12:20 | |
| *** lpetrut has joined #openstack-nova | 12:23 | |
| *** artom_ has joined #openstack-nova | 12:24 | |
| ttallgren | Hi all, I hit a bug in Nova 17.0.0.1b2 with automated Ansible testing (OPNFV XCI): http://p.ip.fi/a733 | 12:24 |
| *** smatzek_ has joined #openstack-nova | 12:25 | |
| rabel | hi there. there seems to be a problem with building the docs in nova. running tox -e docs i get an error message: | 12:26 |
| ttallgren | It is calling nova-manage cell_v2 discover_hosts and the final error is Duplicate entry 'compute01' for key 'uniq_host_mappings0host | 12:26 |
| rabel | nova/nova/policies/config_drive.py", line 46, in <module> deprecated_since='17.0.0'),TypeError: __init__() got an unexpected keyword argument 'deprecated_since' | 12:26 |
| *** hogepodge has quit IRC | 12:26 | |
| *** rmart04 has quit IRC | 12:27 | |
| *** antonym has quit IRC | 12:27 | |
| *** andreykurilin has quit IRC | 12:27 | |
| *** jdurgin has quit IRC | 12:27 | |
| *** rmart04_ has joined #openstack-nova | 12:27 | |
| *** dansmith has quit IRC | 12:27 | |
| *** smatzek has quit IRC | 12:27 | |
| *** artom has quit IRC | 12:27 | |
| *** d34dh0r53 has quit IRC | 12:27 | |
| *** ericyoung has quit IRC | 12:27 | |
| *** gcb has quit IRC | 12:28 | |
| *** d34dh0r53 has joined #openstack-nova | 12:28 | |
| *** antonym has joined #openstack-nova | 12:28 | |
| *** dansmith has joined #openstack-nova | 12:28 | |
| *** dansmith is now known as Guest86649 | 12:28 | |
| *** hogepodge has joined #openstack-nova | 12:28 | |
| *** ericyoung has joined #openstack-nova | 12:28 | |
| *** andreykurilin has joined #openstack-nova | 12:29 | |
| *** jdurgin has joined #openstack-nova | 12:29 | |
| *** dgonzalez has quit IRC | 12:30 | |
| *** lajoskatona has quit IRC | 12:31 | |
| frickler | vish_18: commented on the bug report. also lyarwood is right, this is a keystone issue | 12:31 |
| *** dgonzalez has joined #openstack-nova | 12:32 | |
| *** bigdogstl has quit IRC | 12:32 | |
| *** MikeG451 has joined #openstack-nova | 12:36 | |
| *** bhujay has quit IRC | 12:38 | |
| *** vladikr has joined #openstack-nova | 12:42 | |
| *** lajoskatona has joined #openstack-nova | 12:46 | |
| *** psachin has quit IRC | 12:50 | |
| *** yangyapeng has quit IRC | 12:55 | |
| *** yangyapeng has joined #openstack-nova | 12:55 | |
| *** tbachman has joined #openstack-nova | 12:59 | |
| *** bhujay has joined #openstack-nova | 12:59 | |
| *** yangyapeng has quit IRC | 12:59 | |
| *** tssurya has quit IRC | 13:00 | |
| *** bigdogstl has joined #openstack-nova | 13:02 | |
| *** bhujay has quit IRC | 13:04 | |
| efried | Spazmotic \o Gimme a sec to catch up... | 13:05 |
| *** efried is now known as fried_rice | 13:05 | |
| Spazmotic | Hehe no worries.. just trying to make sure I understand correctly because it seems crazy | 13:05 |
| fried_rice | bauzas Yes, I ran the meeting yesterday, such as it was. Got minutes? http://eavesdrop.openstack.org/meetings/nova/2018/nova.2018-01-18-21.00.log.html | 13:07 |
| *** jpena is now known as jpena|lunch | 13:07 | |
| *** andreas_s has joined #openstack-nova | 13:07 | |
| *** szaher has quit IRC | 13:07 | |
| jaypipes | alex_xu: will make it a priority this morning. | 13:09 |
| *** jaypipes is now known as leakypipes | 13:10 | |
| fried_rice | gibi Congrats, add self to https://etherpad.openstack.org/p/nova-ptg-rocky attendance list | 13:10 |
| Spazmotic | The korean word for fried rice is ๋ณถ์๋ฐฅ .. for the curious hehehe | 13:10 |
| *** bhujay has joined #openstack-nova | 13:13 | |
| *** liverpooler has joined #openstack-nova | 13:13 | |
| fried_rice | lyarwood I can help you with autospeccing. Though claudiub is the real expert. | 13:13 |
| claudiub | o/ | 13:14 |
| claudiub | wassup | 13:14 |
| Spazmotic | poor man now I feel bad for spamming you :D | 13:15 |
| *** lpetrut has quit IRC | 13:15 | |
| *** andreas_s has quit IRC | 13:15 | |
| *** lpetrut has joined #openstack-nova | 13:15 | |
| fried_rice | Spazmotic Okay, now I'm caught up. But not sure I'm fully understanding which part you're saying is gross. | 13:16 |
| *** bigdogstl has quit IRC | 13:17 | |
| Spazmotic | Doesn't really feel like it follows any of the standards of how we handle data sets generally and doesn't allow for granular level of control over allocations without touching entire consumers data sets | 13:17 |
| Spazmotic | Feels dirty | 13:17 |
| *** markvoelker has joined #openstack-nova | 13:17 | |
| *** claudiub|2 has joined #openstack-nova | 13:18 | |
| fried_rice | Spazmotic You mean because you have to set/replace an entire consumer_uuid's allocations all at once? | 13:18 |
| Spazmotic | Yeah | 13:18 |
| Spazmotic | Is that really the elegant solution? | 13:18 |
| Spazmotic | I guess i'm not sure what we gain by clean sweeping | 13:18 |
| *** tssurya has joined #openstack-nova | 13:18 | |
| fried_rice | Spazmotic I can see where that's going to be suboptimal in the long game of placement, where we could have multiple control points managing resources for a single consumer. Each one would have to GET the current state, make its changes, PUT back the changed set, and deal with 409s if a concurrent update beat them to it. | 13:19 |
| fried_rice | Spazmotic I'm guessing it was designed this way as the most expeditious and convenient for the initial use case, which is nova compute host as single resource provider, nova instance as consumer. | 13:20 |
| *** claudiub has quit IRC | 13:20 | |
| Spazmotic | It defiantely could get racey, it also allows for less control of allocations except for directly outside of consumers which may make it a little more unwiedy in a larger multi-control point environment for same tenant | 13:21 |
| fried_rice | Spazmotic Actually, yeah, I don't see a consistency marker like we have for traits & inventories. | 13:22 |
| *** alexchadin has quit IRC | 13:22 | |
| fried_rice | leakypipes Has this been considered ^ ? | 13:22 |
| mdbooth | lyarwood: Hey, found a test problem. Still reviewing but I'm going to drop what I've got right now as I think you need to fix it. | 13:23 |
| *** crushil has joined #openstack-nova | 13:24 | |
| lyarwood | mdbooth: the py35 failures? | 13:24 |
| mdbooth | I hadn't even seen those. | 13:25 |
| lyarwood | mdbooth: awesome, so more issues to fix :) | 13:25 |
| mdbooth | The problem in test_migration. I don't think that test is right. | 13:25 |
| *** sahid has quit IRC | 13:25 | |
| lyarwood | mdbooth: kk | 13:25 |
| lyarwood | mdbooth: right, the old secret should be replaced by the new secret but we aren't creating a new secret UUID here, that's just passed in via migrate_data | 13:27 |
| *** alexchadin has joined #openstack-nova | 13:27 | |
| *** Tom-Tom has joined #openstack-nova | 13:27 | |
| lyarwood | the device replace is odd and something copied over from the above test | 13:27 |
| mdbooth | Yeah, I saw that. It's weird there, too. | 13:28 |
| *** links has quit IRC | 13:28 | |
| Spazmotic | Would be very nice if we could extend that API a bit for more functionality and ease of use. | 13:28 |
| mdbooth | lyarwood: The pattern of those tests is xml=old xml | 13:28 |
| *** andreas_s has joined #openstack-nova | 13:28 | |
| mdbooth | new_xml = s/old thing/thing which should be changed upon migration in this test/ | 13:29 |
| mdbooth | assert(we got new_xml) | 13:29 |
| *** yangyapeng has joined #openstack-nova | 13:29 | |
| *** markvoelker has quit IRC | 13:29 | |
| *** edmondsw has joined #openstack-nova | 13:29 | |
| *** markvoelker has joined #openstack-nova | 13:29 | |
| mdbooth | I didn't look hard at why the test above would expect device name to change on live migration. I can't imagine why we'd ever want that. However, it's SEP right now. | 13:30 |
| lyarwood | mdbooth: ah, the sdb / sdc thing is also a migrate_data thing | 13:31 |
| mdbooth | Yes. It's passed in. | 13:31 |
| lyarwood | mdbooth: so it's the target device changing | 13:31 |
| mdbooth | Still looks bogus. | 13:31 |
| lyarwood | mdbooth: not in the instance | 13:31 |
| lyarwood | mdbooth: so on the host, the block device is just wired up under /dev/sdc | 13:31 |
| lyarwood | mdbooth: that's valid | 13:31 |
| *** Tom-Tom has quit IRC | 13:31 | |
| lyarwood | mdbooth: just confusing as the test is using rbd | 13:31 |
| mdbooth | Ah... you looked harder :) | 13:32 |
| mdbooth | Ok, that makes sense | 13:32 |
| *** yangyapeng has quit IRC | 13:32 | |
| *** yangyapeng has joined #openstack-nova | 13:32 | |
| Spazmotic | fried_rice, it also feels a little bit like they intended to use the zeroing out of the resources in the allocation for something but forgot. If no allocations are set for a tenant it assumes you want a clean sweep so it goes through and sets them all to 0, but then goes through and deletes them anyway from the dB after that | 13:32 |
| mdbooth | lyarwood: Anyway, following the pattern of those tests, the search/replace we want to see there is old secret for new secret | 13:33 |
| Spazmotic | Kinda wierd.. i'll need to continue looking but it's almost time for me to head to bed and dream about the process hehe | 13:33 |
| lyarwood | mdbooth: ack, done | 13:33 |
| fried_rice | Spazmotic That may have been for the original migration case | 13:33 |
| fried_rice | Spazmotic Which was found to have some pretty hairy implications (read: bugs). Which is why we introduced the POST API there, to allow us to "move" the allocations from one consumer to another in a single atomic operation. | 13:34 |
| *** fragatina has joined #openstack-nova | 13:34 | |
| fried_rice | dansmith and cdent (neither of whom is here at the moment) ought to be able to shed more light on what happened there. | 13:34 |
| lyarwood | mdbooth: re https://review.openstack.org/#/c/523958/15/nova/tests/unit/virt/libvirt/test_driver.py@10526 - the only values of src_supports_native_luks are True and None, testing both of these above | 13:35 |
| Spazmotic | Sounds good sir.. i'll continue to poke it and will read scrollback when I wake up to see if anything new :) | 13:35 |
| mdbooth | lyarwood: Is it never set to False? | 13:35 |
| Spazmotic | I see now what you mean about the migrations.. that would be useful in that case. | 13:35 |
| *** bigdogstl has joined #openstack-nova | 13:35 | |
| fried_rice | Spazmotic But I can definitely see the need for concurrency management of allocations; and also the usefulness of a more granular API to add/remove/update individual allocations - but concurrency management would have to be a prereq of that. | 13:36 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/523958/15/nova/virt/libvirt/driver.py@6253 - nope | 13:36 |
| lyarwood | mdbooth: it's really checking that n-cpu is >= Queens | 13:36 |
| lyarwood | mdbooth: not that the src host can actually decrypt LUKS via QEMU | 13:36 |
| lyarwood | mdbooth: as we are only creating the volume config on the src | 13:36 |
| * Spazmotic nods. | 13:36 | |
| Spazmotic | Alrighty, i'll think on it man.. thanks for helping me clarity what was happening | 13:36 |
| fried_rice | Spazmotic Glad to bounce around ideas, for what it's worth :) | 13:37 |
| mdbooth | lyarwood: Yep, I'd forgotten that detail. Ignore me. | 13:37 |
| *** edleafe is now known as figleaf | 13:37 | |
| mdbooth | lyarwood: Ah, reading on... I didn't forget, you changed it :) | 13:38 |
| mdbooth | But that's cool | 13:38 |
| *** chyka has joined #openstack-nova | 13:38 | |
| lyarwood | mdbooth: ^_^ yeah I think it did check the installed versions in a different PS | 13:38 |
| Spazmotic | Going ot be another night laying in bed thinking about this damn API hehe.. night everyone. Tonight I shall think of Semaphores for this system | 13:39 |
| *** fragatina has quit IRC | 13:39 | |
| Spazmotic | I will need to look at how Nova handles its semaphores.. not something i've messed with too much | 13:40 |
| *** bigdogstl has quit IRC | 13:40 | |
| mdbooth | lyarwood: Do we have a test for adding native encryption to xml which doesn't currently have it? | 13:40 |
| mdbooth | lyarwood: I think the answer's no. | 13:40 |
| lyarwood | mdbooth: during LM? No. | 13:41 |
| * lyarwood adds that | 13:42 | |
| *** ralonsoh has quit IRC | 13:42 | |
| *** bigdogstl has joined #openstack-nova | 13:42 | |
| mdbooth | lyarwood: Should be mostly cut/paste hopefully | 13:42 |
| *** chyka has quit IRC | 13:42 | |
| *** lajoskatona has quit IRC | 13:43 | |
| *** sambetts|afk is now known as sambetts | 13:44 | |
| mdbooth | lyarwood: Couple more nits. If you're respinning, you probably ought to remove the unrelated whitespace change. | 13:44 |
| Spazmotic | And before I goto bed will ask again for good luck, if anyone knows XenAPI well and has some free cycles away from their important reviews, feel free to take a look at https://review.openstack.org/#/c/533168/ :) | 13:45 |
| lyarwood | mdbooth: ack, already have :) | 13:46 |
| *** bigdogstl has quit IRC | 13:46 | |
| Spazmotic | I think this eventaully needs to be changed to use nova.objects.block_device.is_volume() but that's something that can be resolved a bit later to pull in CinderV3 into VMOps | 13:47 |
| Spazmotic | Have a good night everyone :) | 13:47 |
| *** bigdogstl has joined #openstack-nova | 13:47 | |
| *** xinliang has quit IRC | 13:50 | |
| *** sahid has joined #openstack-nova | 13:50 | |
| *** ralonsoh has joined #openstack-nova | 13:51 | |
| *** xinliang has joined #openstack-nova | 13:52 | |
| *** mlavalle has joined #openstack-nova | 13:52 | |
| rabel | is the default quota-class deprecated by now? it seems not to be considered by nova in any way | 13:59 |
| *** tssurya has quit IRC | 14:01 | |
| *** bigdogstl has quit IRC | 14:02 | |
| *** claudiub has joined #openstack-nova | 14:03 | |
| claudiub | lyarwood: sorry, i was in a meeting. did you need any help with mock autospec? | 14:04 |
| lyarwood | claudiub: no sorry, I'm fine, I was just talking to mdbooth about them earlier and I fried_rice was offering help :) | 14:04 |
| *** alexchadin has quit IRC | 14:04 | |
| lyarwood | I think* | 14:04 |
| claudiub | cool. :) | 14:05 |
| claudiub | anyways, it's been a lingering issue since last year. recently, we've merged a patch to oslotest which should help with it. you can take a look here: https://github.com/openstack/oslotest/blob/master/doc/source/user/mock-autospec.rst | 14:05 |
| claudiub | and this is the 1st patch addressing autospec issues in nova: https://review.openstack.org/#/c/447505/37 | 14:05 |
| mdbooth | lyarwood: It's not a high priority given that we almost never use autospec, btw. I have had autospec catch a couple of bugs for me in the past, though. | 14:06 |
| *** pchavva has joined #openstack-nova | 14:06 | |
| *** claudiub|2 has quit IRC | 14:06 | |
| mdbooth | lyarwood: I was thinking of it as I thought I'd seen you using it. | 14:06 |
| claudiub | i do recommend using autospecs whenever possible, especially when you're using external libraries which might change over time. mocking them normally will make your unit tests pass even if the method signatures changed, which is not ok. :) | 14:08 |
| *** weshay|ruck is now known as weshay|rover | 14:08 | |
| *** lbragstad has joined #openstack-nova | 14:10 | |
| fried_rice | mdbooth Yeah, one of the reasons we don't use autospec as much as we could/should is because there were bugs in it. claudiub just fixed some of those, so let the floodgates open! | 14:10 |
| artom_ | bauzas, https://bugs.launchpad.net/nova/+bug/1744325 | 14:11 |
| openstack | Launchpad bug 1744325 in OpenStack Compute (nova) "If a rebuild is refused by the scheduler, the instance's imageref is not rolled back" [Undecided,New] | 14:11 |
| *** artom_ is now known as artom | 14:11 | |
| artom | mdbooth, ^^ if you care | 14:11 |
| bauzas | artom: yup, I saw your internal discussion | 14:11 |
| mdbooth | artom: I do, thanks | 14:11 |
| *** lyan has joined #openstack-nova | 14:12 | |
| TheJulia | Greetings nova folks! Over in the land of ironic, we've been encountering a condition in our multinode grenade job where while underlying libraries are being upgraded and nova is not upgraded from pike to master. What we're seeing is the nova conductor exiting with SEGV, and then looping causing all sorts of other issues. Has anyone seen anything like this? | 14:12 |
| *** jpena|lunch is now known as jpena | 14:13 | |
| * fried_rice hasn't seen SEGV since his C days | 14:14 | |
| leakypipes | Spazmotic: we don't "zero out the resources" in allocations. | 14:14 |
| TheJulia | Likewise :\ | 14:14 |
| leakypipes | fried_rice: the consistency marker is the resource provider's generation. | 14:14 |
| *** alexchadin has joined #openstack-nova | 14:14 | |
| fried_rice | leakypipes Is it updated when allocations are made? | 14:15 |
| leakypipes | fried_rice: of course. | 14:15 |
| openstackgerrit | David Rabel proposed openstack/nova master: Fix format in flavors.rst https://review.openstack.org/535777 | 14:15 |
| fried_rice | leakypipes But the documentation says the RP generation is ignored in alloc requests. | 14:15 |
| fried_rice | leakypipes ...for PUT. And it appears to be entirely absent for POST. | 14:16 |
| fried_rice | leakypipes Bug? | 14:17 |
| leakypipes | fried_rice: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L2085 | 14:17 |
| artom | I can't even begin to think about the fix | 14:17 |
| artom | We're setting a whole bunch of instance attributes in the compute API | 14:17 |
| artom | And *then* doing the rebuild | 14:17 |
| leakypipes | fried_rice: there is no POST. | 14:17 |
| artom | With no checks whether it passed the scheduler or not | 14:18 |
| fried_rice | leakypipes https://developer.openstack.org/api-ref/placement/#manage-allocations | 14:18 |
| leakypipes | fried_rice: there is only PUT /allocations/{consumer_uuid} | 14:18 |
| artom | Maybe the easiest would be to just revert the CVE "fix" and leave it as WONTFIX :/ | 14:18 |
| TheJulia | fried_rice: my guess is some piece of compiled c is getting loaded in from the upgraded underlying modules, and the conductor goes sideways at that point | 14:18 |
| fried_rice | TheJulia Fo sho. I was just being glib, though - I certainly haven't seen the behavior you describe. | 14:19 |
| leakypipes | fried_rice: oh, that is for when we move instances. | 14:19 |
| leakypipes | fried_rice: it is not used anywhere else. | 14:19 |
| fried_rice | By nova. At the moment. But not the point. | 14:19 |
| leakypipes | fried_rice: what is your point? | 14:20 |
| *** bigdogstl has joined #openstack-nova | 14:20 | |
| fried_rice | leakypipes Getting there, finding code, one sec. | 14:20 |
| fried_rice | leakypipes Yeah, so link above convinces me we're incrementing the generation when we do allocationey stuff, which is dandy. | 14:21 |
| fried_rice | leakypipes But if the allocation APIs don't accept a generation, how are we detecting conflicts? | 14:21 |
| fried_rice | leakypipes Or reporting them (409s)? | 14:21 |
| rabel | can anyone please help me with quotas? is the default quota class used for anything? a GET call to /os-quota-sets/{tenant_id}/defaults does not seem to return it, but i'm not sure what it returns instead. | 14:21 |
| leakypipes | fried_rice: we detect conflicts in terms of whether capacity is exceeded, that's all. | 14:21 |
| *** tssurya has joined #openstack-nova | 14:21 | |
| leakypipes | fried_rice: i.e. does the original constraint that there was existing capacity for the allocated resources on these set of resource providers still hold. | 14:22 |
| fried_rice | leakypipes That's cool. But if two threads are trying to e.g. modify allocations for the same consumer_uuid at the same time, the second one will "win". | 14:23 |
| *** crushil has quit IRC | 14:23 | |
| fried_rice | leakypipes Not a problem in today's world where everything is funneled through report client, and there's one compute node RP, and the consumer is an instance. | 14:23 |
| leakypipes | fried_rice: no, that's not possible. one of those threads would get a 409 because the provider generation increment would fail. | 14:24 |
| fried_rice | leakypipes How and why would the increment fail if we're not passing the generation into the API? | 14:24 |
| *** bigdogstl has quit IRC | 14:25 | |
| *** alexchadin has quit IRC | 14:25 | |
| leakypipes | fried_rice: because the provider generations are *read* at the start of the transaction that inserts/deletes allocation records. after those allocation records are changed, the provider generations are incremented for all providers involved in the transaction. if another thread had inserted/deleted allocation records (for that consumer or another consumer) against those same resource providers, the increment would fail. | 14:26 |
| leakypipes | fried_rice: specifically, this would happen: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L281-L282 | 14:26 |
| fried_rice | leakypipes I'm not talking about multiple threads in the placement code at the same time. I'm talking about multiple consumer threads making single individual atomic calls to completion. | 14:27 |
| *** david-lyle has quit IRC | 14:27 | |
| *** jackie-truong has joined #openstack-nova | 14:27 | |
| *** david-lyle has joined #openstack-nova | 14:29 | |
| leakypipes | fried_rice: I'm going to go back to reviewing the patch series I need to get reviewed today :) you are welcome to walk through the code paths in there and identify a particular concurrency bug. | 14:29 |
| *** alexchadin has joined #openstack-nova | 14:29 | |
| leakypipes | fried_rice: you are also welcome to put a discussion on all the concurrency topics up at the PTG. I think that would be a good discussion. it's just I need to focus today on these reviews. | 14:30 |
| *** jistr is now known as jistr|mtg | 14:30 | |
| fried_rice | leakypipes Here's the flow: Existing instance. Shared disk manager A wants to add some disk resource. sean-k-mooney's neutron thingy B wants to add a vif or whatever. A does a GET of the current allocations. B does a GET of the current allocations. A adds his disk and PUTs back. Placement happily replaces the allocations, which now include the disk, and increments the generation. B adds his vif to the original (d | 14:30 |
| fried_rice | isk-less) payload and PUTs back. Placement happily replaces with B's version of the allocation, which has the vif but doesn't have the disk. | 14:30 |
| leakypipes | alex_xu: are you still around? that patch you wanted a review on is dependent on this one which needs a rebase: https://review.openstack.org/#/c/479776/. are you planning on getting to that? | 14:30 |
| *** kholkina has quit IRC | 14:32 | |
| sean-k-mooney | fried_rice: why would you not request both the disk and vif in the same allocation request? | 14:32 |
| fried_rice | sean-k-mooney Because different entities are "owning" those resources. | 14:32 |
| leakypipes | alex_xu: never mind. it's not a dependent patch, it's just in the same topic. damn gerrit... :( | 14:32 |
| *** alexchadin has quit IRC | 14:32 | |
| sean-k-mooney | fried_rice: differnet entityes are creating the resouce providers but the nova sechduler/conductor will be claiming both on behalf of the instance | 14:33 |
| fried_rice | sean-k-mooney Sure, you *could* have it set up that way. Or, you know, not. | 14:33 |
| fried_rice | sean-k-mooney At the moment, this is not a danger. | 14:33 |
| fried_rice | sean-k-mooney In the future.... | 14:34 |
| fried_rice | Certainly for the general case usage of the placement API. | 14:34 |
| sean-k-mooney | we could technically make the neutron port the owner of the vif which would then result in two owners | 14:34 |
| *** alexchadin has joined #openstack-nova | 14:34 | |
| sean-k-mooney | *vif allocation | 14:35 |
| fried_rice | The solution would be fairly simple I think: just add the generation for each RP to PUT /allocations/{consumer_uuid} and POST /allocations | 14:35 |
| *** josecastroleon has quit IRC | 14:35 | |
| openstackgerrit | Merged openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 14:37 |
| fried_rice | Basically, it works as long as all the allocations for a given consumer are always only managed by one thread at a time. Which is a constraint that happens to be true today, but certainly isn't documented as a limitation of using the API. | 14:38 |
| *** damien_r has quit IRC | 14:38 | |
| *** lucasagomes is now known as lucas-hungry | 14:38 | |
| sean-k-mooney | leakypipes: alex_xu https://review.openstack.org/#/c/535642 seams to add suport for required to get /allocation_candiates but i dont see support for the Resouce1..,Required1 syntax needed for different traits per resouce. is there a followup patch for that | 14:38 |
| leakypipes | sean-k-mooney: yes, we're not targeting that for queens. fried_rice has a patch up for that. | 14:39 |
| *** damien_r has joined #openstack-nova | 14:39 | |
| *** swamireddy has quit IRC | 14:39 | |
| fried_rice | leakypipes Quit saying that. We *are* targeting it for Queens, until something changes. We have an approved blueprint and 95% of the code merged. | 14:40 |
| *** burt has joined #openstack-nova | 14:40 | |
| leakypipes | fried_rice: I won't hold up non-granular requests with traits for granular requests. | 14:41 |
| leakypipes | fried_rice: does that sound more accurate? | 14:41 |
| sean-k-mooney | leakypipes: ya i saw fried_rice's patch i assumed it superceeded alex's instead of building on it.thats problematic but ok. ill cherry pick fried_rice patch if i need it. | 14:41 |
| fried_rice | leakypipes Agree with that (see -dev ml) | 14:41 |
| fried_rice | sean-k-mooney ditto (http://lists.openstack.org/pipermail/openstack-dev/2018-January/126393.html) | 14:42 |
| sean-k-mooney | so how does required work wiht nrp | 14:43 |
| fried_rice | sean-k-mooney The reason my patch doesn't build on alex_xu's is because mine is 2.5 months older :) | 14:43 |
| fried_rice | sean-k-mooney You get candidates such that a) all resources come from providers in the same tree, and b) the union of all the traits on providers you actually get resources from is a superset of the traits you asked for. | 14:44 |
| sean-k-mooney | fried_rice: ok the union is the important bit | 14:45 |
| fried_rice | sean-k-mooney Which is obviously limited e.g. you can't say I want one VIF with trait CUSTOM_PHYSNET_A and one with CUSTOM_PHYSNET_B -- for that you would need granular, period. | 14:45 |
| *** bhagyashris has quit IRC | 14:46 | |
| sean-k-mooney | yes but i can say one vif and one cpu with CUSTOM_PHYSNET_A and cpu_trait_x | 14:46 |
| fried_rice | sean-k-mooney Yes. And you'd better hope that your CPU doesn't have trait CUSTOM_PHYSNET_A | 14:46 |
| fried_rice | (silly example in this case) | 14:46 |
| sean-k-mooney | why what would happen if it did? | 14:47 |
| fried_rice | You could still get a vif from physnet B and placement will think it did its job. | 14:47 |
| sean-k-mooney | ah | 14:47 |
| sean-k-mooney | ok | 14:47 |
| *** tbachman has quit IRC | 14:47 | |
| sean-k-mooney | well without traits at all we would get to the compute node try to bind the port and get a vif_binding_failed from neutron then hit the retry loop until we hit max retries or got lucky | 14:48 |
| fried_rice | heh, yeah | 14:48 |
| *** awaugama has joined #openstack-nova | 14:48 | |
| fried_rice | Oh, I'm not disputing that having traits support is better than not having traits support. | 14:49 |
| fried_rice | Just that single-request-group has limitations no amount of trait-finagling will overcome. | 14:49 |
| sean-k-mooney | fried_rice: ya i know but that example is precisly the one im trying to avoid in my poc as a first pass use of traits | 14:49 |
| fried_rice | sean-k-mooney Well, that's why we need granular :) | 14:50 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: WIP: hacky negotiation of ironic microversion https://review.openstack.org/535786 | 14:50 |
| *** alexchadin has quit IRC | 14:50 | |
| sean-k-mooney | the minimal support will work for the simple case e.g. all interfaces on same physnet which is enough for demos | 14:50 |
| fried_rice | yuh | 14:50 |
| fried_rice | on the same physnet and same everything else that matters. | 14:50 |
| *** kholkina has joined #openstack-nova | 14:51 | |
| *** bigdogstl has joined #openstack-nova | 14:51 | |
| sean-k-mooney | well we can have multiple physnets in the cloud and show that placement found the correct node | 14:51 |
| fried_rice | Yup. | 14:51 |
| sean-k-mooney | we would have had to use availablity zones with out tratis to do the same thing | 14:51 |
| sean-k-mooney | or atleast some host_aggregate based filter | 14:52 |
| *** ttallgren has quit IRC | 14:52 | |
| *** jmlowe has quit IRC | 14:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | 14:52 |
| fried_rice | And you can *probably* even ask for multiple vifs on separate subnets in the same request. As long as you only want one of each. And don't share those traits with any other provider. Which is probably doable. | 14:52 |
| fried_rice | brb | 14:53 |
| sean-k-mooney | ill cross that bridge when i come to it but ya granular resouce requests in queens will support all of these usecase more cleanly/correctly | 14:54 |
| sean-k-mooney | * in rocky | 14:54 |
| *** bigdogstl has quit IRC | 14:56 | |
| *** lyan has quit IRC | 14:56 | |
| *** jmlowe has joined #openstack-nova | 15:00 | |
| *** lyan has joined #openstack-nova | 15:00 | |
| *** armax has joined #openstack-nova | 15:01 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: WIP: hacky negotiation of ironic microversion https://review.openstack.org/535786 | 15:01 |
| leakypipes | alex_xu: review done. | 15:02 |
| *** jistr|mtg is now known as jistr | 15:04 | |
| *** bigdogstl has joined #openstack-nova | 15:04 | |
| *** yamamoto has quit IRC | 15:05 | |
| *** yamamoto has joined #openstack-nova | 15:06 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:07 | |
| *** bigdogstl has quit IRC | 15:09 | |
| *** bigdogstl has joined #openstack-nova | 15:13 | |
| *** swamireddy has joined #openstack-nova | 15:13 | |
| *** archit has joined #openstack-nova | 15:14 | |
| *** sree has joined #openstack-nova | 15:14 | |
| rabel | hm. why is a PUT to /os-quota-sets/default working? this does not make sense in my brain | 15:14 |
| *** yamamoto has quit IRC | 15:17 | |
| *** crushil_ has joined #openstack-nova | 15:18 | |
| *** sree has quit IRC | 15:19 | |
| *** READ10 has joined #openstack-nova | 15:21 | |
| leakypipes | fried_rice: just confirming... mgoddard's patches for "Call get_traits() in the resource tracker" and "Add get_traits() method to ComputeDriver" are obseleted with the update_provider_tree() work, correct? | 15:25 |
| fried_rice | leakypipes Eventually, but when I asked him about it, apparently he's wanting to move forward more quickly than that. | 15:26 |
| fried_rice | leakypipes Right now he's working toward what's described in his blueprint. | 15:27 |
| fried_rice | leakypipes And that stuff will coexist with update_provider_tree until it doesn't. | 15:27 |
| leakypipes | hmm, ok | 15:28 |
| fried_rice | leakypipes Though xen is counting on using update_provider_tree, and I just found out vmware is as well. | 15:28 |
| leakypipes | fried_rice: yeah, my preference for sure would be to have everyone on update_provider_tree() | 15:28 |
| leakypipes | asap | 15:28 |
| fried_rice | leakypipes I didn't love the idea of that redundant/extra compute driver method coming into existence for such a limited use and (hopefully) limited time... | 15:28 |
| fried_rice | yeah, same | 15:28 |
| leakypipes | k, at least we're on the same page. | 15:29 |
| leakypipes | fried_rice: your series is looking great | 15:29 |
| fried_rice | Thanks! | 15:29 |
| *** Tom-Tom has joined #openstack-nova | 15:29 | |
| leakypipes | I'm hoping we can get gibi or stephenfin on it. | 15:29 |
| *** bigdogstl has quit IRC | 15:29 | |
| fried_rice | Late on a Friday... and both of them forgot their Friday nicks... | 15:30 |
| *** rgerganov has joined #openstack-nova | 15:31 | |
| leakypipes | fried_rice: well that is COMPLETELY UNACCEPTABLE. | 15:31 |
| *** kholkina has quit IRC | 15:31 | |
| fried_rice | ikr | 15:32 |
| fried_rice | At least figleaf is on board | 15:32 |
| rgerganov | fried_rice, i am trying to implement update_provider_tree for the vmware driver and I'll be happy to work with you on https://review.openstack.org/#/c/520246 and the rest | 15:34 |
| * gibi feels bad | 15:34 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Cleanup redundant want_version assignment. https://review.openstack.org/535801 | 15:34 |
| *** Tom-Tom has quit IRC | 15:34 | |
| *** lucas-hungry is now known as lucasagomes | 15:34 | |
| fried_rice | rgerganov Ah, I was looking for rado - is that not also you? | 15:34 |
| rgerganov | fried_rice, well i was also looking for efried but found fried_rice :) | 15:34 |
| fried_rice | gibi You can redeem yourself by reviewing the series behind leakypipes | 15:34 |
| fried_rice | rgerganov I make no apologies for my Fun Friday nickname | 15:35 |
| *** kholkina has joined #openstack-nova | 15:35 | |
| *** fragatina has joined #openstack-nova | 15:36 | |
| fried_rice | rgerganov I'm going to need to rebase the top of the series to account for some stuff takashin did for including request IDs in deletion calls. | 15:36 |
| *** yamahata has joined #openstack-nova | 15:36 | |
| fried_rice | Which leaves me in kind of a bind because the bottom of the series is close to mergeable, and I don't want to rebase it and set back the review process. | 15:37 |
| *** matrohon has joined #openstack-nova | 15:37 | |
| *** ssurana has joined #openstack-nova | 15:37 | |
| fried_rice | Though I guess if I do it now, as long as it's auto-rebase-able, I keep reviews... | 15:37 |
| rgerganov | fried_rice, yeah understood | 15:37 |
| *** stephenfin is now known as finucannot | 15:38 | |
| *** eharney has joined #openstack-nova | 15:38 | |
| finucannot | leakypipes: What was this now? | 15:38 |
| fried_rice | finucannot Welcome! | 15:38 |
| leakypipes | finucannot: starting here: https://review.openstack.org/#/c/533244/ | 15:38 |
| fried_rice | finucannot Please and thank you. | 15:39 |
| finucannot | Yup, I'll tackle that this evening | 15:39 |
| *** bigdogstl has joined #openstack-nova | 15:39 | |
| gibi | finucannot: I'm also started looking at it, but I don't know when and where I run out of steam | 15:40 |
| *** fragatina has quit IRC | 15:40 | |
| fried_rice | gibi finucannot Thank you for whatever you can manage. | 15:41 |
| leakypipes | gibi: where's giblet today? :P | 15:41 |
| *** gibi is now known as giblet | 15:41 | |
| leakypipes | \o/ | 15:41 |
| giblet | leakypipes: sorry, I always forget | 15:41 |
| * giblet takes a note to automate it | 15:42 | |
| fried_rice | giblet finucannot leakypipes I'm going to rebase the series real quick to get rid of the merge conflicts on the top few patches... | 15:42 |
| giblet | fried_rice: thanks for the headsup | 15:42 |
| leakypipes | ok dokey | 15:42 |
| *** hongbin has joined #openstack-nova | 15:42 | |
| *** jackie-truong is now known as jackiet | 15:42 | |
| *** bhujay has quit IRC | 15:42 | |
| fried_rice | leakypipes Your +2s will ride. Only the _delete_provider patch was manual. | 15:43 |
| leakypipes | ack | 15:43 |
| fried_rice | Here it comes. | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.data => ProviderData https://review.openstack.org/533244 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 15:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 15:43 |
| rgerganov | cool | 15:43 |
| fried_rice | leakypipes giblet finucannot ^ done. Thanks. | 15:43 |
| finucannot | (y) | 15:43 |
| leakypipes | fried_rice: and you just killed your clean check run ;) | 15:44 |
| fried_rice | rgerganov I still haven't addressed your comments. I can start on that now. But I also had some other stuff I was gonna do to those WIPs today. | 15:44 |
| leakypipes | but alas, c'est la vie | 15:44 |
| fried_rice | leakypipes Ah, dang, that too :( | 15:44 |
| * fried_rice prayz to ze zuul godz | 15:44 | |
| *** bigdogstl has quit IRC | 15:44 | |
| rgerganov | fried_rice, no rush, I will head out soon. Will ping you on monday at 1300 UTC | 15:45 |
| fried_rice | rgerganov Roger wilco. At 1400 is the scheduler meeting, where some of this stuff might get discussed, if you're interested in joining. | 15:46 |
| *** tssurya has quit IRC | 15:46 | |
| rgerganov | ah, thanks for letting me know, I will consider it | 15:46 |
| fried_rice | rgerganov https://wiki.openstack.org/wiki/Meetings/NovaScheduler -- feel free to add agenda items if you think of something that needs to be addressed. | 15:47 |
| rgerganov | ok, thanks | 15:47 |
| *** yamamoto has joined #openstack-nova | 15:48 | |
| *** zhaochao has quit IRC | 15:49 | |
| openstackgerrit | Merged openstack/nova master: Fix format in flavors.rst https://review.openstack.org/535777 | 15:50 |
| * giblet feels a bit less bad | 15:51 | |
| leakypipes | rgerganov: I mean... what ELSE would you rather do on a Monday afternoon other than spend time with me and fried_rice? ;) | 15:51 |
| *** sridharg has quit IRC | 15:51 | |
| * fried_rice has no choice but to spend time with himself | 15:52 | |
| rgerganov | leakypipes, lol | 15:52 |
| fried_rice | Thanks giblet! It's all downhill from here. | 15:53 |
| *** rgerganov has quit IRC | 15:53 | |
| cfriesen | anyone feel like a fairly quick code review? https://review.openstack.org/#/c/484381/ has been sitting with a single +2 for a couple weeks now | 15:53 |
| *** felipemonteiro__ has joined #openstack-nova | 15:54 | |
| cfriesen | ^ this is related to instance evacuation with PCI devices | 15:54 |
| leakypipes | cfriesen: evacuate? PCI devices? oh hell, sign me up! | 15:54 |
| cfriesen | leakypipes: it's under 20 lines. :) | 15:54 |
| leakypipes | cfriesen: I'm looking at it :) | 15:54 |
| cfriesen | sweet, thanks | 15:55 |
| *** tidwellr has joined #openstack-nova | 15:55 | |
| giblet | fried_rice: I have left like 15 minutes then boardgame night... | 15:55 |
| *** tidwellr has quit IRC | 15:55 | |
| fried_rice | ooo :) | 15:56 |
| *** tidwellr has joined #openstack-nova | 15:56 | |
| fried_rice | cfriesen How does this actually fix anything? | 15:56 |
| fried_rice | cfriesen Oh, it passes in a thing that's being checked by something that happened in a different patch? | 15:56 |
| fried_rice | got it. | 15:57 |
| cfriesen | fried_rice: not actually my patch, but I think it's passing in a thing that something else already in the code is looking for | 15:57 |
| *** felipemonteiro_ has quit IRC | 15:57 | |
| finucannot | fried_rice: Yup. Something we already do for one code path (cold migration, resize) should now being done for another (evacuation) | 15:58 |
| fried_rice | cfriesen Yeah, I see _update_port_binding_for_instance takes a migration kwarg | 15:58 |
| leakypipes | cfriesen: +Wallaby'd | 15:58 |
| cfriesen | leakypipes: awesome, thanks | 15:58 |
| * leakypipes goes back to -2'ing all of fried_rice's work | 15:58 | |
| *** kukacz_ has quit IRC | 15:58 | |
| fried_rice | cfriesen Left a passive-aggressive +0 with a nit. | 15:59 |
| *** kukacz has joined #openstack-nova | 15:59 | |
| cfriesen | lol | 15:59 |
| *** esberglu has joined #openstack-nova | 15:59 | |
| *** tidwellr has quit IRC | 16:00 | |
| leakypipes | jackiet: how about "fullmetaljackie"? ;) | 16:00 |
| leakypipes | jackiet: though that might be too long for irc. | 16:00 |
| *** sahid has quit IRC | 16:01 | |
| *** sahid has joined #openstack-nova | 16:01 | |
| *** jackiet is now known as fullmetaljackiet | 16:01 | |
| fried_rice | ++! | 16:01 |
| fullmetaljackiet | leakypipes: niceeee I like it | 16:01 |
| leakypipes | heh | 16:01 |
| leakypipes | :) | 16:02 |
| leakypipes | fullmetaljackiet: glad to be of service. | 16:02 |
| cfriesen | leakypipes: want me to quick make the change suggested by fried_rice? | 16:02 |
| leakypipes | cfriesen: meh? the way the gate is I'd prefer to just leave it for now. | 16:02 |
| cfriesen | works for me | 16:03 |
| cfriesen | figured I'd offer | 16:03 |
| leakypipes | fried_rice is right, of course. | 16:03 |
| *** bigdogstl has joined #openstack-nova | 16:03 | |
| leakypipes | but it's a nit | 16:03 |
| fried_rice | Not even worth a followon. | 16:03 |
| * fried_rice settles for being right. | 16:04 | |
| *** ttsiouts has quit IRC | 16:04 | |
| *** jlvillal has quit IRC | 16:04 | |
| leakypipes | fried_rice: so, your comment on this one unit test "_get_provider_aggregates and _traits were called thrice" just makes me think of the monty python holy hand grenade scene. | 16:04 |
| fried_rice | leakypipes Five is RIGHT OUT. | 16:05 |
| leakypipes | "The number shall be THREE!" | 16:05 |
| leakypipes | :) | 16:05 |
| fried_rice | Then lobbest thou the holy hand grenade... | 16:05 |
| fried_rice | okay okay. | 16:05 |
| leakypipes | hehe | 16:05 |
| fried_rice | Back to Airplane! quotes. | 16:05 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: Fix bad autospec usage https://review.openstack.org/535806 | 16:06 |
| *** crushil_ has quit IRC | 16:06 | |
| edmondsw | claudiub I would prefer ^ to the oslotest fixture | 16:07 |
| edmondsw | but it's at least a first step even if you want to continue to push use of that fixture | 16:07 |
| edmondsw | (which could be done subsequently) | 16:07 |
| *** bigdogstl has quit IRC | 16:07 | |
| *** pchavva has quit IRC | 16:08 | |
| bauzas | ildikov: I don't see any change in the series that does things at the driver level with https://review.openstack.org/#/c/531244/10/nova/compute/manager.py@5190 | 16:08 |
| bauzas | ildikov: I mean, you and matt made the RPC changes for asking for multiattach, sure | 16:09 |
| bauzas | but then, how do we pass that down to libvirt? I'm confused | 16:09 |
| bauzas | oh f***, nevermind | 16:10 |
| ildikov | bauzas: it's in the capabilities | 16:10 |
| ildikov | bauzas: I guess you found it :) | 16:10 |
| bauzas | ildikov: yeah, so basically the RPC change is just for asking whether the compute driver supports it | 16:10 |
| ildikov | bauzas: yes | 16:10 |
| bauzas | if not, raise | 16:10 |
| ildikov | exactly | 16:10 |
| bauzas | if yes, let's the volume say whether it's multiattached | 16:10 |
| bauzas | gotcha | 16:10 |
| claudiub | edmondsw: sure, that works too, but i've had nightmares with mock.create_autospec | 16:10 |
| bauzas | ildikov: sorry, I'm in general used to see things happening at the manager level once you pass a new attribute | 16:11 |
| ildikov | bauzas: yeah, many pieces to put together | 16:11 |
| bauzas | a new *RPC* attribute | 16:11 |
| claudiub | I've had run times increase exponentially because of mock.create_autospec | 16:11 |
| bauzas | ildikov: yeah, https://review.openstack.org/#/c/532928/4/nova/compute/manager.py does that | 16:11 |
| *** pchavva has joined #openstack-nova | 16:12 | |
| edmondsw | claudiub hmm | 16:12 |
| ildikov | bauzas: we tried to look into failing as quick as possible if either bit is not there | 16:12 |
| claudiub | at one time, i've had an execution time of 4000 seconds for ~300 unit tests. :) | 16:13 |
| claudiub | aprox. | 16:13 |
| ildikov | bauzas: as we don't have all the info at the API we needed some tricks :) | 16:13 |
| *** jlvillal has joined #openstack-nova | 16:14 | |
| bauzas | ildikov: I'll +W it, but I think you should add a NOTE in the manager explaining why you don't really care doing things after the RPC call | 16:14 |
| bauzas | ildikov: just because it took me some time to understand that, some other people wanting to contribute could be confused by that new attribute we don't really use | 16:15 |
| bauzas | it's just a flag | 16:15 |
| ildikov | bauzas: sure, I guess you added a comment already, so I will do it in a follow up patch | 16:15 |
| ildikov | bauzas: thank you | 16:16 |
| bauzas | ildikov: yup, no rush | 16:16 |
| *** tidwellr has joined #openstack-nova | 16:16 | |
| bauzas | ildikov: that can totally be a follow-up | 16:16 |
| ildikov | bauzas: cool :) | 16:16 |
| bauzas | but I'd be happy if we could keep sort of the logic in the code | 16:16 |
| bauzas | matt did a good job doing that in the conductor | 16:16 |
| *** itlinux has joined #openstack-nova | 16:16 | |
| ildikov | yeah, it always starts simple and then we give it more and more thoughts... | 16:16 |
| bauzas | ildikov: for example https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L896-L903 | 16:17 |
| ildikov | the tricks are all on him here too and I mean it the best way possible | 16:17 |
| bauzas | and https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L913-L921 | 16:17 |
| bauzas | ildikov: sure, I don't deny it | 16:18 |
| ildikov | nice, good examples | 16:18 |
| bauzas | ildikov: I'm just saying, we somehow need to remember what we did | 16:18 |
| ildikov | bauzas: I completely agree | 16:18 |
| *** bigdogstl has joined #openstack-nova | 16:18 | |
| bauzas | anyway, I'm calling it a day | 16:18 |
| bauzas | the API change is hairy and not my expertise, so it'll require a bit more thoughts | 16:19 |
| bauzas | not for a friday thing | 16:19 |
| bauzas | ++ folks | 16:19 |
| *** crushil_ has joined #openstack-nova | 16:19 | |
| ildikov | bauzas: makes sense, thanks for looking into the series | 16:19 |
| ildikov | bauzas: have a great weekend! | 16:20 |
| lyarwood | mdbooth: http://logs.openstack.org/58/523958/16/check/openstack-tox-py35/db3ef07/testr_results.html.gz - if you have time, any thoughts on these failures? hasattr is failing on o.vo objects on py35, works on py27. | 16:21 |
| mdbooth | lyarwood: Yeah, will look now. | 16:22 |
| *** bigdogstl has quit IRC | 16:23 | |
| mdbooth | lyarwood: I'm hacking on it right now. Ping me if you fix it before I do. | 16:27 |
| lyarwood | mdbooth: the race is on | 16:27 |
| mdbooth | Hehe | 16:27 |
| mdbooth | If you've got other stuff to do, feel free :) | 16:27 |
| lyarwood | mdbooth: but given I pinged as I was stuck I think you might win | 16:27 |
| *** penick has joined #openstack-nova | 16:30 | |
| *** ilyashakhat has joined #openstack-nova | 16:30 | |
| *** jaosorior has quit IRC | 16:30 | |
| *** slaweq has quit IRC | 16:31 | |
| *** felipemonteiro__ has quit IRC | 16:31 | |
| *** rmart04_ has quit IRC | 16:32 | |
| *** damien_r has quit IRC | 16:34 | |
| *** itlinux has quit IRC | 16:34 | |
| *** AlexeyAbashkin has quit IRC | 16:35 | |
| *** fragatina has joined #openstack-nova | 16:37 | |
| *** itlinux has joined #openstack-nova | 16:40 | |
| *** bigdogstl has joined #openstack-nova | 16:41 | |
| *** fragatina has quit IRC | 16:41 | |
| edmondsw | claudiub I ran the UTs for test_compute (which take the longest of the files changed) for both master and my proposal with create_autospec. No significant perf impact | 16:42 |
| edmondsw | not saying there couldn't be an impact somewhere else, but not substantial in that file anyway | 16:43 |
| *** andreas_s has quit IRC | 16:43 | |
| edmondsw | ran 1934 tests in 336s without and 360s with create_autospec (on my slow laptop env) | 16:44 |
| *** cdent has joined #openstack-nova | 16:46 | |
| *** chyka has joined #openstack-nova | 16:48 | |
| *** cdent has quit IRC | 16:50 | |
| *** kholkina has quit IRC | 16:50 | |
| *** kholkina has joined #openstack-nova | 16:51 | |
| *** bigdogstl has quit IRC | 16:52 | |
| mdbooth | lyarwood: I've found the root cause | 16:53 |
| mdbooth | lyarwood: It's a difference in the implementation of hasattr between python2 and python3: http://paste.openstack.org/show/647153/ | 16:54 |
| *** kholkina has quit IRC | 16:55 | |
| mdbooth | What the hell do you do about that? is question 2 | 16:55 |
| * mdbooth wonders if writing python3 off as an utterly stupid idea is a valid solution. | 16:56 | |
| * mdbooth finds a SO about it | 16:57 | |
| *** tbachman has joined #openstack-nova | 16:57 | |
| lyarwood | mdbooth: cool thanks, I was sure I hit something like this before but can't seem to find anything | 16:57 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/342111/13 for example, actually introduced hasattr to get py34 passing at the time | 16:58 |
| *** gyee has joined #openstack-nova | 16:58 | |
| *** andreas_s has joined #openstack-nova | 16:58 | |
| mdbooth | It's a bug in OVO imho | 17:00 |
| mdbooth | It seems python expects you to raise AttributeError in a __gettattr__ | 17:01 |
| mdbooth | But obj_load_attr is raising NotImplementedError | 17:01 |
| lyarwood | mdbooth: right and 2.7 catches any exception | 17:02 |
| lyarwood | mdbooth: https://docs.python.org/2/library/functions.html?highlight=hasattr#hasattr | 17:02 |
| lyarwood | 99% sure I've hit this before and there was a workaround | 17:02 |
| mdbooth | The Nova fix would be to override obj_load_attr() and raise AttributeError instead of NotImplementedError | 17:02 |
| mdbooth | However, we should also submit a patch to ovo | 17:03 |
| openstackgerrit | Merged openstack/os-traits master: Add CPU features for AArch64 https://review.openstack.org/523665 | 17:03 |
| *** andreas_s has quit IRC | 17:03 | |
| mdbooth | https://docs.python.org/3/library/functions.html#hasattr | 17:03 |
| mdbooth | lyarwood: Hmm, it's messier than that because we also call it in other contexts. Some subclasses raise ObjectActionError | 17:06 |
| mdbooth | lyarwood: So I think this calls for ocean-boiling-avoidance | 17:06 |
| mdbooth | Although it is a bug in OVO | 17:07 |
| claudiub | edmondsw: sounds ok in that case, but in other cases, it can really drive up the execution time. I've tried it now for nova.tests.unit.virt.hyperv.test_vmops, only using mock.create_autospec for a few instance attributes, and the execution time jumped from 3.8 sec / 121 tests to 7.5 sec / 121 tests. Again, not everything was autospec'd :) | 17:07 |
| lyarwood | mdbooth: using obj_load_attr you mean? | 17:08 |
| * mdbooth curses python3 | 17:08 | |
| edmondsw | claudiub is that comparing to master or to the oslotests fixture? | 17:08 |
| mdbooth | lyarwood: ovo should handle the lack of contract for obj_load_attr | 17:08 |
| mdbooth | If we're going to port OpenStack to a new language, there are better options than python3 | 17:09 |
| claudiub | mdbooth: mock.create_autospec autospecs literally everything in the given object / class, which is not really necessary for every single test | 17:09 |
| claudiub | while mock.Mock(autospec=) only autospecs something when accessed. | 17:09 |
| *** sahid has quit IRC | 17:09 | |
| edmondsw | claudiub and I'm not sure that's a big deal... you can look at as twice as long (bad) or as 4 extra seconds (insignificant). Would need to see impact on a larger scale | 17:09 |
| mdbooth | claudiub: nice | 17:10 |
| edmondsw | claudiub that does sound nice though | 17:11 |
| claudiub | edmondsw: 3.929s per 121 tests | 17:11 |
| claudiub | ok, so, 3.8 sec with no change. 3.929 with mock.Mock(autospec) (oslotest), and 7.5 sec with mock.create_autospec | 17:13 |
| *** bnemec is now known as beekneemech | 17:13 | |
| *** fullmetaljackiet has quit IRC | 17:13 | |
| *** lpetrut has quit IRC | 17:13 | |
| *** matrohon has quit IRC | 17:14 | |
| *** fried_rice is now known as fried_rolls | 17:14 | |
| mdbooth | lyarwood: The workaround is to use getattr instead, because that has consistent behaviour | 17:15 |
| mdbooth | i.e. it raises an exception | 17:15 |
| *** tidwellr_ has joined #openstack-nova | 17:16 | |
| *** tidwellr has quit IRC | 17:16 | |
| *** Tom-Tom has joined #openstack-nova | 17:16 | |
| mdbooth | lyarwood: Assuming you've got local changes, I'll leave ^^^ in a review comment | 17:16 |
| lyarwood | mdbooth: yeah thanks | 17:16 |
| mdbooth | https://bugs.launchpad.net/oslo.versionedobjects/+bug/1552927 | 17:18 |
| openstack | Launchpad bug 1552927 in oslo.versionedobjects "hasattr() function behavior differences between Py27 and Py34" [Undecided,New] | 17:18 |
| mdbooth | lyarwood: Already been reported ^^^^ | 17:18 |
| mdbooth | obj.attr_is_set()... | 17:19 |
| *** Tom-Tom has quit IRC | 17:20 | |
| lyarwood | mdbooth: ah! | 17:21 |
| mdbooth | Just testing that | 17:21 |
| mdbooth | lyarwood: Works, at least for that test | 17:22 |
| lyarwood | mdbooth: yeah works for me | 17:22 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | 17:23 |
| *** penick has quit IRC | 17:25 | |
| *** mvenesio has joined #openstack-nova | 17:27 | |
| *** yamamoto has quit IRC | 17:31 | |
| claudiub | mdbooth: gonna send you a link soon. already 60 seconds passed while trying to execute unittests which shouldn't last more than 10 seconds. :) | 17:35 |
| *** pcaruana has quit IRC | 17:36 | |
| *** fragatina has joined #openstack-nova | 17:36 | |
| *** fragatina has quit IRC | 17:37 | |
| *** fragatina has joined #openstack-nova | 17:37 | |
| *** yamamoto has joined #openstack-nova | 17:38 | |
| *** yamamoto has quit IRC | 17:38 | |
| *** gouthamr has joined #openstack-nova | 17:39 | |
| *** tidwellr_ has quit IRC | 17:42 | |
| *** tidwellr has joined #openstack-nova | 17:42 | |
| claudiub | mdbooth: https://github.com/bclau/nova/tree/autospec-issue | 17:42 |
| mdbooth | lyarwood: I'd have left you a +1 if Jenkins had voted already. I'd appreciate if you consider the readability of the new test, though. | 17:43 |
| mdbooth | My eyeballs aren't good at computing diffs. | 17:43 |
| claudiub | execution time: vanilla: ~10 seconds. oslotest mock.MagicMock(autospec): ~14.5 sec. mock.create_autospec: I dunno, a few hundred seconds, still running. | 17:43 |
| *** bigdogstl has joined #openstack-nova | 17:44 | |
| mdbooth | claudiub: That's great info, and definitely something I hadn't appreciated. | 17:44 |
| mdbooth | I think I've used create_autospec in a few places in the past. | 17:45 |
| claudiub | it's definetely great, but the fact that it autospecs literally everything can be problematic. | 17:45 |
| claudiub | and I have sent pull requests to python 3 and the mock library, but no response for at least half a year | 17:46 |
| *** yamahata has quit IRC | 17:46 | |
| claudiub | and there hasn't been any updates to the mock library since more than 12-13 months | 17:46 |
| *** tidwellr has quit IRC | 17:46 | |
| claudiub | Ran 364 tests in 434.626s | 17:47 |
| *** lpetrut has joined #openstack-nova | 17:49 | |
| *** bigdogstl has quit IRC | 17:51 | |
| openstackgerrit | David Rabel proposed openstack/nova stable/pike: Fix format in live-migration-usage.rst https://review.openstack.org/535871 | 17:53 |
| *** penick has joined #openstack-nova | 17:56 | |
| *** crushil_ has quit IRC | 17:59 | |
| *** r-daneel has joined #openstack-nova | 17:59 | |
| mdbooth | Incoming | 18:00 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Remove redundant swap_volume tests https://review.openstack.org/531179 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Use real block_device_info data in libvirt tests https://review.openstack.org/527916 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config https://review.openstack.org/530786 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787 | 18:01 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | 18:01 |
| *** derekh has quit IRC | 18:01 | |
| *** yamahata has joined #openstack-nova | 18:01 | |
| *** lpetrut has quit IRC | 18:04 | |
| *** ralonsoh has quit IRC | 18:06 | |
| *** gouthamr has quit IRC | 18:08 | |
| *** bigdogstl has joined #openstack-nova | 18:09 | |
| *** bigdogstl has quit IRC | 18:13 | |
| *** janki has quit IRC | 18:14 | |
| lyarwood | mdbooth: ack, I might rewrite both tests using the conf objects and format_dom calls | 18:15 |
| *** AlexeyAbashkin has joined #openstack-nova | 18:16 | |
| *** jackie-truong has joined #openstack-nova | 18:16 | |
| *** jackie-truong is now known as fullmetaljackiet | 18:16 | |
| *** gouthamr has joined #openstack-nova | 18:17 | |
| *** bigdogstl has joined #openstack-nova | 18:17 | |
| *** AlexeyAbashkin has quit IRC | 18:20 | |
| *** gouthamr has quit IRC | 18:20 | |
| *** bigdogstl has quit IRC | 18:22 | |
| *** bigdogstl has joined #openstack-nova | 18:23 | |
| *** dtantsur is now known as dtantsur|afk | 18:24 | |
| *** bigdogstl has quit IRC | 18:28 | |
| *** weshay|rover is now known as weshay|bbiab | 18:31 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: negotiate microversion to allow downgrade to Pike https://review.openstack.org/535786 | 18:38 |
| *** yamamoto has joined #openstack-nova | 18:39 | |
| *** bigdogstl has joined #openstack-nova | 18:43 | |
| *** bigdogstl has quit IRC | 18:47 | |
| *** sambetts is now known as sambetts|afk | 18:48 | |
| *** bigdogstl has joined #openstack-nova | 18:50 | |
| *** yamamoto has quit IRC | 18:50 | |
| *** lpetrut has joined #openstack-nova | 18:51 | |
| *** dave-mcc_ has joined #openstack-nova | 18:52 | |
| *** bigdogstl has quit IRC | 18:56 | |
| *** lucasagomes is now known as lucas-afk | 18:58 | |
| *** lpetrut has quit IRC | 19:00 | |
| *** penick has quit IRC | 19:01 | |
| *** lpetrut has joined #openstack-nova | 19:01 | |
| *** sree has joined #openstack-nova | 19:01 | |
| *** bigdogstl has joined #openstack-nova | 19:01 | |
| *** penick has joined #openstack-nova | 19:03 | |
| *** tidwellr has joined #openstack-nova | 19:05 | |
| *** sree has quit IRC | 19:07 | |
| *** mvenesio has quit IRC | 19:08 | |
| cfriesen | found an interesting glance/nova interworking issue. if doing a snapshot, and cinder/glance are both on ceph, nova tries to shortcut the snapshot then set the location in glance. But by default glance won't let you set the location of an image, so this fails. | 19:13 |
| *** bigdogstl has quit IRC | 19:13 | |
| cfriesen | correction, not cinder, but when instance backend is ceph. | 19:16 |
| *** Tom-Tom has joined #openstack-nova | 19:18 | |
| *** sdague has quit IRC | 19:19 | |
| *** itlinux has quit IRC | 19:20 | |
| *** bigdogstl has joined #openstack-nova | 19:21 | |
| *** Tom-Tom has quit IRC | 19:23 | |
| *** sree has joined #openstack-nova | 19:23 | |
| *** felipemonteiro has joined #openstack-nova | 19:24 | |
| *** bigdogstl has quit IRC | 19:25 | |
| *** sdague has joined #openstack-nova | 19:27 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:28 | |
| *** itlinux has joined #openstack-nova | 19:29 | |
| *** sree has quit IRC | 19:29 | |
| *** harlowja has joined #openstack-nova | 19:31 | |
| *** felipemonteiro has quit IRC | 19:31 | |
| *** Guest56304 has quit IRC | 19:33 | |
| *** jpena is now known as jpena|afk | 19:33 | |
| *** avolkov`` has joined #openstack-nova | 19:34 | |
| *** avolkov` has quit IRC | 19:36 | |
| *** READ10 has quit IRC | 19:38 | |
| *** sree has joined #openstack-nova | 19:39 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:45 | |
| *** sree has quit IRC | 19:46 | |
| *** tbachman has quit IRC | 19:46 | |
| *** AlexeyAbashkin has quit IRC | 19:49 | |
| *** ssurana has left #openstack-nova | 19:52 | |
| cburgess | cfriesen Sounds like nova is doing the right thing but glance just isn't configured properly. Sounds like maybe a release note or something is needed? | 19:57 |
| *** ssurana1 has joined #openstack-nova | 19:57 | |
| *** ssurana1 has quit IRC | 19:57 | |
| cburgess | cfriesen I suspect cinder will run into the same issue. | 19:57 |
| *** smatzek_ has quit IRC | 19:58 | |
| *** bigdogstl has joined #openstack-nova | 19:58 | |
| *** sree has joined #openstack-nova | 20:01 | |
| *** bigdogstl has quit IRC | 20:03 | |
| *** tidwellr_ has joined #openstack-nova | 20:05 | |
| *** tidwellr has quit IRC | 20:05 | |
| *** sree has quit IRC | 20:05 | |
| *** slaweq has joined #openstack-nova | 20:05 | |
| *** sree has joined #openstack-nova | 20:06 | |
| *** pramodrj07 has joined #openstack-nova | 20:07 | |
| *** lpetrut has quit IRC | 20:10 | |
| *** manjeets has joined #openstack-nova | 20:10 | |
| *** lpetrut has joined #openstack-nova | 20:10 | |
| *** felipemonteiro__ has joined #openstack-nova | 20:14 | |
| *** sree has quit IRC | 20:15 | |
| *** felipemonteiro_ has quit IRC | 20:17 | |
| *** tbachman has joined #openstack-nova | 20:18 | |
| *** archit has quit IRC | 20:21 | |
| fried_rolls | you gotta be effin kidding me. The bottom three patches, all +W'd, got zuul -1 with (three *different*) spurious failures. The fourth patch - the first one with a -1 - passed. | 20:22 |
| *** fried_rolls is now known as fried_rice | 20:23 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/535919 | 20:24 |
| *** jpena|afk is now known as jpena|off | 20:24 | |
| ildikov | fried_rice: mine got a time_out error on the gate, sooo close, but no... | 20:25 |
| fried_rice | Boo. I feel your pain. | 20:26 |
| *** AlexeyAbashkin has joined #openstack-nova | 20:27 | |
| *** gszasz has quit IRC | 20:27 | |
| *** bigdogstl has joined #openstack-nova | 20:29 | |
| *** AlexeyAbashkin has quit IRC | 20:31 | |
| *** fragatina has quit IRC | 20:34 | |
| *** weshay|bbiab is now known as weshay | 20:38 | |
| *** weshay is now known as weshay|ruck | 20:38 | |
| *** weshay|ruck is now known as weshay|rover | 20:38 | |
| *** fullmetaljackiet has quit IRC | 20:38 | |
| *** sree has joined #openstack-nova | 20:39 | |
| *** archit has joined #openstack-nova | 20:39 | |
| *** penick_ has joined #openstack-nova | 20:40 | |
| *** bigdogstl has quit IRC | 20:40 | |
| *** smatzek has joined #openstack-nova | 20:41 | |
| *** penick has quit IRC | 20:42 | |
| *** mvenesio has joined #openstack-nova | 20:42 | |
| fried_rice | figleaf regarding https://review.openstack.org/#/c/526540/17/nova/scheduler/client/report.py@390 -- the only possible reason I can see for it having been split out before was LOG.warning vs .error. | 20:43 |
| fried_rice | figleaf But given that the error text is (at least) as descriptive as what was there before, are you cool with it? | 20:43 |
| *** sree has quit IRC | 20:44 | |
| *** smatzek has quit IRC | 20:44 | |
| *** smatzek has joined #openstack-nova | 20:45 | |
| *** eharney has quit IRC | 20:45 | |
| *** mvenesio has quit IRC | 20:46 | |
| *** mvenesio has joined #openstack-nova | 20:47 | |
| *** smatzek has quit IRC | 20:51 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/nova master: DNM testing whether lib/neutron switch breaks this repo https://review.openstack.org/535947 | 20:55 |
| *** fullmetaljackiet has joined #openstack-nova | 20:55 | |
| *** penick_ has quit IRC | 20:58 | |
| *** penick has joined #openstack-nova | 20:59 | |
| *** bigdogstl has joined #openstack-nova | 21:02 | |
| cfriesen | cburgess: I've been diving down into the rathole of the nova/glance interaction. turns out glance's policy stuff is all mucked up, so that enabling nova's snapshot in this case requires glance to be configured insecurely. It might be possible to use service tokens to fix it, but nova doesn't send them by default. | 21:02 |
| cfriesen | speaking of which...anyone know why send_service_user_token is False by default? | 21:02 |
| cfriesen | cburgess: the glance folks suggested a workaround of a separate glance node that is configured less secure, which is only accessible by other openstack components. kind of icky if you ask me. | 21:03 |
| *** bigdogstl has quit IRC | 21:06 | |
| *** fullmetaljackiet has quit IRC | 21:07 | |
| *** sree has joined #openstack-nova | 21:07 | |
| figleaf | fried_rice: It just seemed like a bigger behavior change than it set out to be | 21:08 |
| figleaf | fried_rice: it's not a showstopper by any stretch | 21:08 |
| fried_rice | coolcool. | 21:08 |
| leakypipes | fried_rice: k, your patches are now reviewed up to the WIPs. | 21:09 |
| fried_rice | leakypipes Thanks dude. Starting to work through 'em. | 21:10 |
| leakypipes | yup, np | 21:10 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: Fix bad autospec usage https://review.openstack.org/535806 | 21:11 |
| *** sree has quit IRC | 21:11 | |
| *** beekneemech has quit IRC | 21:14 | |
| edmondsw | claudiub ^ fixed a pep8 error. Interested in how you feel about that patch | 21:15 |
| *** crushil_ has joined #openstack-nova | 21:15 | |
| edmondsw | I'm not against using the fixture you got in oslotests if the performance is better, but this might be quicker to merge and doesn't preclude your changes coming later | 21:16 |
| edmondsw | doesn't have a significant performance impact at this small scale that I've detected | 21:16 |
| *** bnemec has joined #openstack-nova | 21:17 | |
| *** lpetrut has quit IRC | 21:17 | |
| *** Tom-Tom has joined #openstack-nova | 21:19 | |
| edmondsw | cfriesen send_service_user_token is False by default simply because you have to configure credentials for that to work | 21:20 |
| edmondsw | I'd like for send_service_user_token to go away, and just have the code detect whether it has credentials or not and use that as the determining factor, but that's a nit | 21:21 |
| openstackgerrit | Hongbin Lu proposed openstack/nova master: Handle RPC timeout on get_console_output https://review.openstack.org/525335 | 21:22 |
| *** tidwellr_ has quit IRC | 21:23 | |
| *** tidwellr has joined #openstack-nova | 21:24 | |
| *** Tom-Tom has quit IRC | 21:24 | |
| cburgess | cfriesen Thats very icky, especially considering that its worked this way for a while (the nova side I mean). | 21:28 |
| cburgess | nova merged this stuff shortly after Tokyo | 21:28 |
| *** sree has joined #openstack-nova | 21:28 | |
| *** tidwellr has quit IRC | 21:28 | |
| *** mvenesio has quit IRC | 21:29 | |
| *** sree has quit IRC | 21:32 | |
| *** bigdogstl has joined #openstack-nova | 21:36 | |
| cfriesen | cburgess: I think it might be related to the glance v1/v2 stuff | 21:37 |
| cburgess | cfriesen Hmm yeah I think you might be right. | 21:38 |
| *** bigdogstl has quit IRC | 21:45 | |
| *** sree has joined #openstack-nova | 21:54 | |
| *** sree has quit IRC | 21:58 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: negotiate microversion to allow downgrade to Pike https://review.openstack.org/535786 | 21:59 |
| *** eharney has joined #openstack-nova | 22:00 | |
| *** crushil_ has quit IRC | 22:01 | |
| *** tesseract has quit IRC | 22:01 | |
| *** bigdogstl has joined #openstack-nova | 22:06 | |
| *** avolkov`` has quit IRC | 22:07 | |
| *** bigdogstl has quit IRC | 22:11 | |
| *** fragatina has joined #openstack-nova | 22:13 | |
| *** penick_ has joined #openstack-nova | 22:28 | |
| *** penick has quit IRC | 22:31 | |
| *** penick has joined #openstack-nova | 22:32 | |
| *** sree has joined #openstack-nova | 22:33 | |
| *** penick_ has quit IRC | 22:33 | |
| *** edmondsw has quit IRC | 22:37 | |
| *** sree has quit IRC | 22:37 | |
| *** bigdogstl has joined #openstack-nova | 22:37 | |
| *** bigdogstl has quit IRC | 22:43 | |
| *** pchavva has quit IRC | 22:45 | |
| *** figleaf is now known as edleafe | 22:55 | |
| *** dave-mcc_ has quit IRC | 22:58 | |
| *** felipemonteiro__ has quit IRC | 22:59 | |
| fried_rice | leakypipes Still around? | 23:00 |
| *** itlinux has quit IRC | 23:00 | |
| *** lyan has quit IRC | 23:01 | |
| *** itlinux has joined #openstack-nova | 23:02 | |
| fried_rice | leakypipes Cancel, I see it now. | 23:04 |
| *** bigdogstl has joined #openstack-nova | 23:05 | |
| *** esberglu has quit IRC | 23:07 | |
| *** burt has quit IRC | 23:08 | |
| *** leakypipes has quit IRC | 23:14 | |
| *** bigdogstl has quit IRC | 23:16 | |
| *** karthiks has quit IRC | 23:16 | |
| *** bigdogstl has joined #openstack-nova | 23:20 | |
| *** Tom-Tom has joined #openstack-nova | 23:21 | |
| *** archit has quit IRC | 23:21 | |
| *** AlexeyAbashkin has joined #openstack-nova | 23:22 | |
| *** Tom-Tom has quit IRC | 23:26 | |
| *** sree has joined #openstack-nova | 23:26 | |
| *** AlexeyAbashkin has quit IRC | 23:26 | |
| *** bigdogstl has quit IRC | 23:27 | |
| *** slaweq has quit IRC | 23:27 | |
| *** bigdogstl has joined #openstack-nova | 23:27 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 23:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 23:28 |
| *** sree has quit IRC | 23:30 | |
| *** karthiks has joined #openstack-nova | 23:35 | |
| *** bigdogstl has quit IRC | 23:40 | |
| *** yamamoto has joined #openstack-nova | 23:40 | |
| -openstackstatus- NOTICE: Zuul will be offline over the next 20 minutes to perform maintenance; active changes will be reenqueued once work completes, but new patch sets or approvals during that timeframe may need to be rechecked or reapplied as appropriate | 23:43 | |
| *** corvus is now known as mr_book | 23:45 | |
| *** mr_book is now known as corvus | 23:45 | |
| *** itlinux has quit IRC | 23:47 | |
| *** bigdogstl has joined #openstack-nova | 23:49 | |
| Spazmotic | Hrm. | 23:50 |
| fried_rice | Do tell | 23:50 |
| *** itlinux has joined #openstack-nova | 23:50 | |
| Spazmotic | Just reading over what leaky said | 23:50 |
| fried_rice | Yeah, I still think there's a hole there. | 23:51 |
| fried_rice | I meant to put it on the PTG agenda, but I think I forgot. | 23:51 |
| fried_rice | ... | 23:51 |
| Spazmotic | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/allocation.py#L335-L343 | 23:51 |
| Spazmotic | This is what I see.. It's if the set allocations POST call doesn't receive any data, it pulls all the consumers allocations that exist and runs allocation.used = 0 | 23:52 |
| fried_rice | Spazmotic You going to be at the PTG? | 23:52 |
| Spazmotic | Nah i'll be in Korea and honestly i think i'm too new to the scene to cause a fuss :D | 23:52 |
| Spazmotic | I will re-read the code tonight, maybe I just don't understand it properly | 23:53 |
| *** claudiub has quit IRC | 23:53 | |
| fried_rice | Spazmotic Oh, and the other thing was a way to add/update/delete individual pieces of allocation rather than the whole payload. | 23:55 |
| fried_rice | Spazmotic I'm not sure there's really a good use case for that. | 23:55 |
| fried_rice | ...IF we have proper concurrency management | 23:55 |
| fried_rice | The amount of data just isn't that onerous. And you'd want to have the existing allocation before you tried sending an update anyway. If for no other reason than to have the current generation :) | 23:56 |
| Spazmotic | Hmm. I guess I can understand that to ensure no double allocations. | 23:56 |
| Spazmotic | I think the only use case that I could think of immediately was the ability to manage the allocations of a resource provider without having to touch multi-tenant full libraries of allocations, which just feels a bit top heavy for that ability. But without a redesign of how taht works it seems unavoidable for the immediate future. | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!