| mriedem | gmann: replied on the spec | 00:02 |
|---|---|---|
| mriedem | as for the 2.0 thing, like i said, i think there are several API schema checks like that with 2.1 as the min version, | 00:02 |
| mriedem | so if they should all be 2.0, we should fix them at the same time and have something in the docs or tests for making sure 2.0 is used rather than 2.1 | 00:02 |
| *** andreas_s has joined #openstack-nova | 00:03 | |
| *** markvoelker has joined #openstack-nova | 00:04 | |
| gmann | mriedem: got your point on spec. not fully convinced but ok as per previous spec and patch proposal | 00:07 |
| gmann | mriedem: on schema, i agree there might be few. for query it is just server index and all other are validating schema for legacy comp mode also | 00:08 |
| *** kenperkins has joined #openstack-nova | 00:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | 00:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle swapping to a multiattach volume https://review.openstack.org/532928 | 00:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | 00:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 00:08 |
| gmann | mriedem: whatever used to be validating com mode we should not make them from v2.1 only | 00:08 |
| gmann | mriedem: because this used to validate the legacy mode also before this change | 00:09 |
| *** andreas_s has quit IRC | 00:09 | |
| *** gouthamr has quit IRC | 00:10 | |
| *** bigdogstl has quit IRC | 00:11 | |
| *** bigdogstl has joined #openstack-nova | 00:11 | |
| *** sree has joined #openstack-nova | 00:14 | |
| *** sdague has quit IRC | 00:16 | |
| *** sree has quit IRC | 00:19 | |
| *** nicolasbock has joined #openstack-nova | 00:19 | |
| *** bigdogstl has quit IRC | 00:21 | |
| *** moshele has joined #openstack-nova | 00:21 | |
| *** moshele has quit IRC | 00:26 | |
| *** hshiina has joined #openstack-nova | 00:26 | |
| *** bigdogstl has joined #openstack-nova | 00:27 | |
| *** claudiub has quit IRC | 00:27 | |
| *** hiro-kobayashi has joined #openstack-nova | 00:27 | |
| *** yangyapeng has quit IRC | 00:30 | |
| *** yangyapeng has joined #openstack-nova | 00:30 | |
| *** chyka has quit IRC | 00:31 | |
| *** tetsuro has joined #openstack-nova | 00:31 | |
| *** bigdogstl has quit IRC | 00:31 | |
| *** jobewan has quit IRC | 00:34 | |
| *** yangyapeng has quit IRC | 00:34 | |
| *** vladikr has joined #openstack-nova | 00:35 | |
| *** edmondsw has joined #openstack-nova | 00:37 | |
| *** bigdogstl has joined #openstack-nova | 00:41 | |
| *** edmondsw has quit IRC | 00:42 | |
| *** sree has joined #openstack-nova | 00:45 | |
| *** oomichi_ has quit IRC | 00:46 | |
| *** bigdogstl has quit IRC | 00:46 | |
| *** kenperkins has quit IRC | 00:49 | |
| *** sree has quit IRC | 00:50 | |
| *** bigdogstl has joined #openstack-nova | 00:50 | |
| *** markvoelker has quit IRC | 00:53 | |
| *** markvoelker has joined #openstack-nova | 00:54 | |
| *** zhaochao has joined #openstack-nova | 00:56 | |
| *** threestrands has quit IRC | 00:58 | |
| *** markvoelker has quit IRC | 00:58 | |
| *** Apoorva has quit IRC | 01:00 | |
| *** itlinux has joined #openstack-nova | 01:01 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:01 | |
| *** ljjjustin has joined #openstack-nova | 01:02 | |
| *** threestrands has joined #openstack-nova | 01:02 | |
| openstackgerrit | Merged openstack/python-novaclient master: Fix being able to create a reno using tox -e venv https://review.openstack.org/532971 | 01:03 |
| *** threestrands has quit IRC | 01:03 | |
| *** threestrands has joined #openstack-nova | 01:04 | |
| *** markvoelker has joined #openstack-nova | 01:04 | |
| *** markvoelker has quit IRC | 01:09 | |
| *** mdnadeem has joined #openstack-nova | 01:10 | |
| *** phuongnh has joined #openstack-nova | 01:11 | |
| *** mlavalle has quit IRC | 01:11 | |
| *** threestrands has quit IRC | 01:11 | |
| *** vladikr has quit IRC | 01:13 | |
| *** markvoelker_ has joined #openstack-nova | 01:13 | |
| *** BenderRodriguez has quit IRC | 01:15 | |
| *** hamzy has joined #openstack-nova | 01:17 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644 | 01:20 |
| *** yangyapeng has joined #openstack-nova | 01:21 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated MigrationManager.list cell_name kwarg https://review.openstack.org/532972 | 01:21 |
| *** threestrands has joined #openstack-nova | 01:24 | |
| *** threestrands has quit IRC | 01:24 | |
| *** threestrands has joined #openstack-nova | 01:24 | |
| *** threestrands has quit IRC | 01:25 | |
| *** threestrands has joined #openstack-nova | 01:26 | |
| *** gyee has quit IRC | 01:26 | |
| *** hongbin has joined #openstack-nova | 01:41 | |
| *** zhurong has joined #openstack-nova | 01:45 | |
| *** dave-mccowan has joined #openstack-nova | 01:46 | |
| *** sree has joined #openstack-nova | 01:48 | |
| *** liverpooler has joined #openstack-nova | 01:49 | |
| *** chyka has joined #openstack-nova | 01:52 | |
| *** sree has quit IRC | 01:53 | |
| *** threestrands has quit IRC | 01:54 | |
| *** mm6021 has quit IRC | 01:56 | |
| *** threestrands has joined #openstack-nova | 01:56 | |
| *** chyka has quit IRC | 01:57 | |
| *** felipemonteiro_ has joined #openstack-nova | 01:59 | |
| *** kukacz has quit IRC | 02:00 | |
| *** Apoorva has joined #openstack-nova | 02:00 | |
| *** kukacz_ has joined #openstack-nova | 02:01 | |
| *** yamahata has quit IRC | 02:09 | |
| *** tinwood has quit IRC | 02:10 | |
| *** tinwood has joined #openstack-nova | 02:11 | |
| *** sree has joined #openstack-nova | 02:12 | |
| *** pmannidi has joined #openstack-nova | 02:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated os-hosts CLIs and python API bindings https://review.openstack.org/532989 | 02:16 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs https://review.openstack.org/532999 | 02:16 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated services binary CLI arg https://review.openstack.org/533005 | 02:16 |
| *** liverpooler has quit IRC | 02:16 | |
| *** sree has quit IRC | 02:17 | |
| *** takashin has quit IRC | 02:19 | |
| *** Tom-Tom has joined #openstack-nova | 02:20 | |
| *** jianghuaw_ has quit IRC | 02:29 | |
| *** jianghuaw has joined #openstack-nova | 02:29 | |
| *** markvoelker_ has quit IRC | 02:31 | |
| *** BenderRodriguez has joined #openstack-nova | 02:34 | |
| *** annp has joined #openstack-nova | 02:39 | |
| *** mriedem has quit IRC | 02:42 | |
| *** suresh12 has quit IRC | 02:44 | |
| *** Dinesh_Bhor has quit IRC | 02:44 | |
| *** vladikr has joined #openstack-nova | 02:44 | |
| *** suresh12_ has joined #openstack-nova | 02:45 | |
| *** Apoorva has quit IRC | 02:46 | |
| *** Tom-Tom has quit IRC | 02:46 | |
| *** Tom-Tom has joined #openstack-nova | 02:47 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:47 | |
| *** suresh12_ has quit IRC | 02:50 | |
| *** Tom-Tom has quit IRC | 02:51 | |
| *** sree has joined #openstack-nova | 02:59 | |
| *** takashin has joined #openstack-nova | 03:02 | |
| *** andreas_s has joined #openstack-nova | 03:02 | |
| *** yamahata has joined #openstack-nova | 03:02 | |
| *** Dinesh_Bhor has quit IRC | 03:02 | |
| *** sree has quit IRC | 03:03 | |
| *** andreas_s has quit IRC | 03:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/533046 | 03:11 |
| *** bigdogstl has quit IRC | 03:14 | |
| *** edmondsw has joined #openstack-nova | 03:14 | |
| *** bigdogstl has joined #openstack-nova | 03:18 | |
| *** edmondsw has quit IRC | 03:18 | |
| *** itlinux has quit IRC | 03:19 | |
| *** felipemonteiro_ has quit IRC | 03:20 | |
| *** ljjjustin has quit IRC | 03:24 | |
| *** felipemonteiro_ has joined #openstack-nova | 03:25 | |
| *** suresh12 has joined #openstack-nova | 03:28 | |
| *** amotoki has joined #openstack-nova | 03:30 | |
| *** sree has joined #openstack-nova | 03:31 | |
| *** slaweq has joined #openstack-nova | 03:32 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 03:32 |
| *** bigdogstl has quit IRC | 03:33 | |
| *** dave-mccowan has quit IRC | 03:33 | |
| *** suresh12 has quit IRC | 03:33 | |
| *** sree has quit IRC | 03:36 | |
| *** slaweq has quit IRC | 03:37 | |
| *** fragatina has quit IRC | 03:37 | |
| *** bigdogstl has joined #openstack-nova | 03:48 | |
| *** jichen has joined #openstack-nova | 03:54 | |
| *** larsks has quit IRC | 03:56 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:56 | |
| *** larsks has joined #openstack-nova | 03:56 | |
| *** sree has joined #openstack-nova | 03:57 | |
| *** bigdogstl has quit IRC | 03:57 | |
| *** bigdogstl has joined #openstack-nova | 03:58 | |
| *** Dinesh_Bhor has quit IRC | 03:58 | |
| *** abhishekk has joined #openstack-nova | 03:58 | |
| *** felipemonteiro_ has quit IRC | 04:01 | |
| *** zhurong has quit IRC | 04:03 | |
| *** yamamoto has joined #openstack-nova | 04:03 | |
| *** bigdogstl has quit IRC | 04:05 | |
| *** sree has quit IRC | 04:06 | |
| *** bigdogstl has joined #openstack-nova | 04:07 | |
| *** Apoorva has joined #openstack-nova | 04:07 | |
| *** markvoelker has joined #openstack-nova | 04:11 | |
| *** bigdogstl has quit IRC | 04:12 | |
| *** sree has joined #openstack-nova | 04:12 | |
| *** edmondsw has joined #openstack-nova | 04:18 | |
| *** nicolasbock has quit IRC | 04:21 | |
| *** sree has quit IRC | 04:22 | |
| *** sree has joined #openstack-nova | 04:22 | |
| *** edmondsw has quit IRC | 04:22 | |
| *** felipemonteiro_ has joined #openstack-nova | 04:24 | |
| *** links has joined #openstack-nova | 04:31 | |
| *** bigdogstl has joined #openstack-nova | 04:32 | |
| *** itlinux has joined #openstack-nova | 04:32 | |
| *** bigdogstl has quit IRC | 04:37 | |
| *** pmannidi has quit IRC | 04:38 | |
| *** vivsoni has quit IRC | 04:50 | |
| *** namnh has joined #openstack-nova | 04:51 | |
| *** psachin has joined #openstack-nova | 04:51 | |
| *** vladikr has quit IRC | 04:55 | |
| *** vivsoni has joined #openstack-nova | 04:58 | |
| *** sridharg has joined #openstack-nova | 04:59 | |
| *** pmannidi has joined #openstack-nova | 05:00 | |
| *** Apoorva has quit IRC | 05:02 | |
| *** bigdogstl has joined #openstack-nova | 05:04 | |
| *** suresh12 has joined #openstack-nova | 05:08 | |
| *** bigdogstl has quit IRC | 05:15 | |
| *** hongbin has quit IRC | 05:18 | |
| *** Tom-Tom has joined #openstack-nova | 05:19 | |
| *** chyka has joined #openstack-nova | 05:19 | |
| *** claudiub has joined #openstack-nova | 05:19 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 05:22 |
| *** yjk has joined #openstack-nova | 05:22 | |
| *** Tom-Tom has quit IRC | 05:23 | |
| *** chyka has quit IRC | 05:24 | |
| *** ratailor has joined #openstack-nova | 05:24 | |
| yjk | Hi, I have a openstack newton setup on which nova evacuate of a VM booted from a volume fails due to iSCSI login failure. Complete details: http://paste.openstack.org/show/643500/. Any help on this is very much appreciated. Thanks! | 05:25 |
| *** felipemonteiro_ has quit IRC | 05:29 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector from ports/portgroups https://review.openstack.org/517322 | 05:33 |
| *** Dinesh_Bhor has joined #openstack-nova | 05:39 | |
| *** liuzz has joined #openstack-nova | 05:42 | |
| *** zhurong has joined #openstack-nova | 05:42 | |
| *** moshele has joined #openstack-nova | 05:43 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Enable NUMA Features for Libvirt/QEMU Driver https://review.openstack.org/533077 | 05:43 |
| *** Tom-Tom has joined #openstack-nova | 05:51 | |
| *** Dinesh_Bhor has quit IRC | 05:52 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:52 | |
| openstackgerrit | Merged openstack/nova master: Test allocation candidates: multiple aggregates https://review.openstack.org/518633 | 05:56 |
| *** andreas_s has joined #openstack-nova | 05:57 | |
| *** fragatina has joined #openstack-nova | 06:00 | |
| *** moshele has quit IRC | 06:02 | |
| *** andreas_s has quit IRC | 06:03 | |
| *** fragatina has quit IRC | 06:04 | |
| *** Dinesh_Bhor has quit IRC | 06:07 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:08 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156 | 06:09 |
| *** Dinesh_Bhor has quit IRC | 06:12 | |
| *** slaweq has joined #openstack-nova | 06:15 | |
| *** bigdogstl has joined #openstack-nova | 06:17 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:18 | |
| *** slaweq has quit IRC | 06:19 | |
| *** bigdogstl has quit IRC | 06:22 | |
| *** bigdogstl has joined #openstack-nova | 06:23 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Enable NUMA Features for Libvirt/QEMU Driver https://review.openstack.org/533077 | 06:30 |
| *** harlowja has quit IRC | 06:35 | |
| openstackgerrit | Chason Chan proposed openstack/nova master: Fix the incorrect description and sample https://review.openstack.org/528180 | 06:38 |
| *** bkopilov has quit IRC | 06:40 | |
| *** bigdogstl has quit IRC | 06:41 | |
| *** pmannidi has quit IRC | 06:51 | |
| *** Dinesh_Bhor has quit IRC | 06:54 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:55 | |
| *** Dinesh_Bhor has quit IRC | 06:56 | |
| *** annp has quit IRC | 06:57 | |
| *** annp has joined #openstack-nova | 06:58 | |
| *** yjk has quit IRC | 06:58 | |
| *** phuongnh has quit IRC | 06:58 | |
| *** hieulq has quit IRC | 06:58 | |
| *** hoangcx has quit IRC | 06:58 | |
| *** hieulq has joined #openstack-nova | 06:59 | |
| *** phuongnh has joined #openstack-nova | 06:59 | |
| *** hoangcx has joined #openstack-nova | 06:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:01 | |
| *** rha has quit IRC | 07:03 | |
| *** lajoskatona has joined #openstack-nova | 07:08 | |
| *** harlowja has joined #openstack-nova | 07:10 | |
| *** harlowja has quit IRC | 07:10 | |
| *** moshele has joined #openstack-nova | 07:10 | |
| *** bigdogstl has joined #openstack-nova | 07:16 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/482557 | 07:17 |
| *** rabel__b1 has joined #openstack-nova | 07:20 | |
| *** itlinux has quit IRC | 07:20 | |
| *** bigdogstl has quit IRC | 07:20 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771 | 07:22 |
| *** kholkina has joined #openstack-nova | 07:23 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128 | 07:23 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601 | 07:23 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168 | 07:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | 07:23 |
| *** rcernin has quit IRC | 07:28 | |
| *** pcaruana has joined #openstack-nova | 07:29 | |
| *** suresh12 has quit IRC | 07:32 | |
| *** Dinesh_Bhor has quit IRC | 07:35 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:37 | |
| *** Dinesh_Bhor has quit IRC | 07:41 | |
| *** bigdogstl has joined #openstack-nova | 07:46 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:46 | |
| *** slaweq has joined #openstack-nova | 07:49 | |
| *** rabel_b1 has joined #openstack-nova | 07:50 | |
| *** rabel__b1 has quit IRC | 07:52 | |
| *** archit has quit IRC | 07:52 | |
| *** threestrands has quit IRC | 07:56 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: add zvm document into https://review.openstack.org/532720 | 07:56 |
| *** bigdogstl has quit IRC | 07:57 | |
| *** takashin has left #openstack-nova | 08:01 | |
| *** sridharg has quit IRC | 08:07 | |
| *** tesseract has joined #openstack-nova | 08:08 | |
| *** damien_r has joined #openstack-nova | 08:09 | |
| *** sridharg has joined #openstack-nova | 08:10 | |
| *** archit has joined #openstack-nova | 08:11 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: Add zvm admin doc https://review.openstack.org/533125 | 08:11 |
| *** bigdogstl has joined #openstack-nova | 08:12 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix 'all_tenants' & 'all_projects' type in api-ref https://review.openstack.org/522918 | 08:13 |
| *** moshele has quit IRC | 08:13 | |
| *** bigdogstl has quit IRC | 08:16 | |
| *** gszasz has joined #openstack-nova | 08:20 | |
| *** pchavva has joined #openstack-nova | 08:21 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:23 | |
| openstackgerrit | Merged openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 08:23 |
| openstackgerrit | Merged openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 08:23 |
| openstackgerrit | Merged openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 08:24 |
| *** matrohon has joined #openstack-nova | 08:26 | |
| *** pchavva has quit IRC | 08:26 | |
| *** alexchadin has joined #openstack-nova | 08:30 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168 | 08:35 |
| *** sahid has joined #openstack-nova | 08:38 | |
| *** tetsuro has quit IRC | 08:41 | |
| *** hiro-kobayashi has quit IRC | 08:44 | |
| *** yamamoto_ has joined #openstack-nova | 08:45 | |
| *** Dinesh_Bhor has quit IRC | 08:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:47 | |
| *** yamamoto has quit IRC | 08:48 | |
| *** sahid has quit IRC | 08:49 | |
| *** sahid has joined #openstack-nova | 08:51 | |
| *** jpena|off is now known as jpena | 08:51 | |
| *** sahid has quit IRC | 08:52 | |
| *** sahid has joined #openstack-nova | 08:53 | |
| *** sahid has quit IRC | 08:54 | |
| *** sahid has joined #openstack-nova | 08:54 | |
| *** tbachman has quit IRC | 08:56 | |
| *** jangutter_ has joined #openstack-nova | 08:56 | |
| *** jangutter has quit IRC | 08:57 | |
| *** bigdogstl has joined #openstack-nova | 08:58 | |
| *** alexchad_ has joined #openstack-nova | 08:58 | |
| *** alexchadin has quit IRC | 08:59 | |
| *** ralonsoh has joined #openstack-nova | 09:02 | |
| *** jangutter_ has quit IRC | 09:03 | |
| *** jangutter has joined #openstack-nova | 09:03 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Update links in documents https://review.openstack.org/533134 | 09:05 |
| *** phuongnh has quit IRC | 09:07 | |
| *** tbachman has joined #openstack-nova | 09:09 | |
| *** jangutter has quit IRC | 09:10 | |
| *** bigdogstl has quit IRC | 09:10 | |
| *** jangutter has joined #openstack-nova | 09:11 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 09:14 |
| *** jangutter_ has joined #openstack-nova | 09:15 | |
| *** jangutter has quit IRC | 09:16 | |
| *** zhurong has quit IRC | 09:20 | |
| *** kwathore has quit IRC | 09:20 | |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 09:23 |
| openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 09:23 |
| *** tbachman has quit IRC | 09:23 | |
| *** dikonoor has joined #openstack-nova | 09:25 | |
| *** lucas-afk is now known as lucasagomes | 09:25 | |
| *** Dinesh_Bhor has quit IRC | 09:25 | |
| *** matrohon has quit IRC | 09:26 | |
| *** hshiina has quit IRC | 09:27 | |
| *** bigdogstl has joined #openstack-nova | 09:28 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:28 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | 09:29 |
| *** cdent has joined #openstack-nova | 09:30 | |
| *** bigdogstl has quit IRC | 09:33 | |
| *** slaweq has quit IRC | 09:33 | |
| *** slaweq has joined #openstack-nova | 09:34 | |
| *** kwathore has joined #openstack-nova | 09:35 | |
| openstackgerrit | Peter Penchev proposed openstack/nova master: Add the Nova libvirt StorPool attachment driver. https://review.openstack.org/140733 | 09:35 |
| Roamer` | (rebased onto the "updated from global requirements" commit for os-brick-2.2.0) | 09:37 |
| *** derekh has joined #openstack-nova | 09:39 | |
| *** Dinesh_Bhor has quit IRC | 09:40 | |
| *** moshele has joined #openstack-nova | 09:40 | |
| *** dtantsur|afk is now known as dtantsur | 09:42 | |
| openstackgerrit | Sriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number https://review.openstack.org/531674 | 09:52 |
| openstackgerrit | Merged openstack/nova master: Add regression test for resizing failing when using CachingScheduler https://review.openstack.org/531211 | 09:52 |
| openstackgerrit | Merged openstack/nova master: Handle no allocations during migrate https://review.openstack.org/531220 | 09:52 |
| openstackgerrit | Merged openstack/nova master: Remove confusing comment in compute_node_get API method https://review.openstack.org/526718 | 09:53 |
| openstackgerrit | Merged openstack/nova master: zuul: Move legacy jobs to project https://review.openstack.org/514309 | 09:53 |
| openstackgerrit | Merged openstack/nova stable/pike: Don't try to delete build request during a reschedule https://review.openstack.org/529697 | 09:53 |
| *** gcb has quit IRC | 09:55 | |
| *** bigdogstl has joined #openstack-nova | 10:00 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Send bytes to sockets https://review.openstack.org/531834 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 10:01 |
| *** mdrabe has quit IRC | 10:01 | |
| *** avolkov has joined #openstack-nova | 10:05 | |
| *** mdrabe has joined #openstack-nova | 10:05 | |
| *** yamamoto has joined #openstack-nova | 10:07 | |
| *** yamamoto_ has quit IRC | 10:10 | |
| *** bigdogstl has quit IRC | 10:12 | |
| *** yamahata has quit IRC | 10:14 | |
| *** namnh has quit IRC | 10:15 | |
| *** wxy has quit IRC | 10:16 | |
| *** moshele has quit IRC | 10:18 | |
| *** sambetts|afk is now known as sambetts | 10:23 | |
| *** avolkov has quit IRC | 10:25 | |
| *** avolkov has joined #openstack-nova | 10:27 | |
| *** hoangcx has quit IRC | 10:33 | |
| *** tbachman has joined #openstack-nova | 10:33 | |
| *** yamamoto_ has joined #openstack-nova | 10:36 | |
| *** liuzz has quit IRC | 10:38 | |
| *** yamamot__ has joined #openstack-nova | 10:38 | |
| *** yamamoto has quit IRC | 10:39 | |
| *** yamamoto_ has quit IRC | 10:42 | |
| *** ArchiFleKs has quit IRC | 10:44 | |
| *** markvoelker has quit IRC | 10:44 | |
| *** jsheeren has joined #openstack-nova | 10:45 | |
| *** Tom-Tom has quit IRC | 10:45 | |
| *** Tom-Tom has joined #openstack-nova | 10:46 | |
| *** tbachman has quit IRC | 10:48 | |
| *** abhishekk has quit IRC | 10:49 | |
| *** Tom-Tom has quit IRC | 10:50 | |
| *** mvk has quit IRC | 10:52 | |
| *** wxy has joined #openstack-nova | 10:54 | |
| *** sidx64 has joined #openstack-nova | 10:55 | |
| *** AlexeyAbashkin has quit IRC | 10:57 | |
| *** edmondsw has joined #openstack-nova | 11:03 | |
| *** mvk has joined #openstack-nova | 11:07 | |
| *** edmondsw has quit IRC | 11:08 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:12 | |
| *** yamamot__ has quit IRC | 11:12 | |
| *** sdague has joined #openstack-nova | 11:14 | |
| *** Tom-Tom has joined #openstack-nova | 11:16 | |
| *** tbachman has joined #openstack-nova | 11:16 | |
| *** bigdogstl has joined #openstack-nova | 11:16 | |
| *** yamamoto has joined #openstack-nova | 11:17 | |
| *** Tom-Tom has quit IRC | 11:21 | |
| *** yamamoto has quit IRC | 11:21 | |
| *** bigdogstl has quit IRC | 11:28 | |
| *** jsheeren has quit IRC | 11:30 | |
| *** jichen has quit IRC | 11:33 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated certs CLIs and python bindings https://review.openstack.org/532974 | 11:34 |
| *** nicolasbock has joined #openstack-nova | 11:36 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated cloudpipe CLIs and python API bindings https://review.openstack.org/532976 | 11:36 |
| *** sidx64 has quit IRC | 11:40 | |
| *** yamamoto has joined #openstack-nova | 11:43 | |
| *** tbachman has quit IRC | 11:47 | |
| *** lpetrut has joined #openstack-nova | 11:47 | |
| *** alexchad_ has quit IRC | 11:51 | |
| *** alexchadin has joined #openstack-nova | 11:52 | |
| *** yamamoto has quit IRC | 11:55 | |
| *** dtantsur is now known as dtantsur|brb | 11:59 | |
| *** moshele has joined #openstack-nova | 12:00 | |
| *** alexchadin has quit IRC | 12:03 | |
| *** annp has quit IRC | 12:07 | |
| *** ratailor has quit IRC | 12:08 | |
| *** alexchadin has joined #openstack-nova | 12:08 | |
| *** alexchadin has quit IRC | 12:10 | |
| *** edmondsw has joined #openstack-nova | 12:11 | |
| *** moshele has quit IRC | 12:11 | |
| *** yamamoto has joined #openstack-nova | 12:11 | |
| openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI/Stops the migration of volume backed VHDS https://review.openstack.org/533168 | 12:16 |
| *** bigdogstl has joined #openstack-nova | 12:16 | |
| *** yamamoto has quit IRC | 12:17 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Rename block_device_info_get_root https://review.openstack.org/529028 | 12:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346 | 12:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | 12:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | 12:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362 | 12:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | 12:18 |
| *** alexchadin has joined #openstack-nova | 12:18 | |
| *** lucasagomes is now known as lucas-hungry | 12:26 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: [libvirt] Allow multiple volume attachments https://review.openstack.org/267587 | 12:27 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Handle swapping to a multiattach volume https://review.openstack.org/532928 | 12:27 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name https://review.openstack.org/531244 | 12:27 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | 12:27 |
| ildikov | gibi: johnthetubaguy: rebased the multi-attach chain and bumped the API microversion that was in conflict ^^ | 12:29 |
| ildikov | gibi: thanks for the reviews! | 12:29 |
| *** bigdogstl has quit IRC | 12:30 | |
| *** chyka has joined #openstack-nova | 12:32 | |
| *** moshele has joined #openstack-nova | 12:33 | |
| *** chyka has quit IRC | 12:37 | |
| gibi | ildikov: cool. I saw the merge conflict on the last patch so I stopped there. Now I don't have this excuse any more | 12:38 |
| *** janki has joined #openstack-nova | 12:41 | |
| *** yamamoto has joined #openstack-nova | 12:42 | |
| *** psachin has quit IRC | 12:45 | |
| *** markvoelker has joined #openstack-nova | 12:45 | |
| openstackgerrit | Merged openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 12:48 |
| openstackgerrit | Merged openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/531381 | 12:48 |
| *** jpena is now known as jpena|lunch | 12:49 | |
| *** smatzek has joined #openstack-nova | 12:53 | |
| *** dave-mccowan has joined #openstack-nova | 12:54 | |
| *** matrohon has joined #openstack-nova | 13:00 | |
| *** bigdogstl has joined #openstack-nova | 13:02 | |
| *** matrohon has quit IRC | 13:05 | |
| *** tbachman has joined #openstack-nova | 13:05 | |
| ildikov | gibi: sorry :) | 13:06 |
| *** ameade has quit IRC | 13:09 | |
| *** ameade has joined #openstack-nova | 13:10 | |
| *** alexchadin has quit IRC | 13:12 | |
| *** lucas-hungry is now known as lucasagomes | 13:16 | |
| *** bigdogstl has quit IRC | 13:19 | |
| *** bigdogstl has joined #openstack-nova | 13:19 | |
| *** markvoelker has quit IRC | 13:20 | |
| *** matrohon has joined #openstack-nova | 13:20 | |
| *** vladikr has joined #openstack-nova | 13:22 | |
| *** moshele has quit IRC | 13:23 | |
| *** alexchadin has joined #openstack-nova | 13:24 | |
| *** dtantsur|brb is now known as dtantsur | 13:30 | |
| *** slaweq has quit IRC | 13:30 | |
| *** alexchadin has quit IRC | 13:30 | |
| *** slaweq has joined #openstack-nova | 13:31 | |
| *** alexchadin has joined #openstack-nova | 13:31 | |
| *** yangyapeng has quit IRC | 13:32 | |
| *** alexchadin has quit IRC | 13:36 | |
| *** efried is now known as fried_rice | 13:38 | |
| *** bigdogstl has quit IRC | 13:40 | |
| *** tbachman has quit IRC | 13:42 | |
| *** stephenfin is now known as finucannot | 13:44 | |
| *** jpena|lunch is now known as jpena | 13:49 | |
| *** david-lyle has quit IRC | 13:49 | |
| fried_rice | cdent Good morning. | 13:50 |
| cdent | mornin' | 13:50 |
| fried_rice | uh, afternoon for you, I guess. | 13:50 |
| *** gnuoy has joined #openstack-nova | 13:51 | |
| gnuoy | Does a nova review need 2 x +2 ? | 13:51 |
| kashyap | Yes | 13:52 |
| fried_rice | gnuoy Almost always | 13:52 |
| kashyap | gnuoy: Actually, not quite | 13:52 |
| gnuoy | ack, ta | 13:52 |
| kashyap | gnuoy: Someone can just merge it with a single +2 & a +W | 13:52 |
| kashyap | 2 +2s is a 'good pratcise' thing | 13:52 |
| fried_rice | Oh, right, it's not enforced by gerrit | 13:52 |
| fried_rice | It's by policy | 13:53 |
| cdent | fried_rice: it's always morning somewhere | 13:53 |
| gnuoy | ok, understood. thanks | 13:53 |
| bhagyashris | iawn: Hi, are you around? | 13:53 |
| fried_rice | gnuoy Sometimes trivial fixes are quick-approved, or a trivial patch set on a change that previously had multiple +2s, that kind of thing. | 13:53 |
| gnuoy | I see, makes sense | 13:54 |
| fried_rice | ianw ^ misspelled ping :) | 13:54 |
| bhagyashris | sorry sorry | 13:54 |
| bhagyashris | ianw: Hi, are you around? | 13:54 |
| gibi | I'm seening a lot of functional failures like on the gate like this: http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22u'host2'%20!%3D%20u'host1':%20path:%20root.payload.nova_object.data.host%5C%22 | 13:56 |
| gibi | I opened https://bugs.launchpad.net/nova/+bug/1742935 | 13:56 |
| openstack | Launchpad bug 1742935 in OpenStack Compute (nova) "TestServiceUpdateNotificationSample fails intermittently: u'host2' != u'host1': path: root.payload.nova_object.data.host " [Undecided,New] - Assigned to Balazs Gibizer (balazs-gibizer) | 13:56 |
| *** yangyapeng has joined #openstack-nova | 14:02 | |
| fried_rice | cdent Is report client single threaded today? | 14:04 |
| fried_rice | I thought it was, but started to think through it and realized it probably isn't. | 14:04 |
| *** esberglu has joined #openstack-nova | 14:04 | |
| cdent | greenthreaded | 14:05 |
| fried_rice | Because periodic tasks plus deploys | 14:05 |
| fried_rice | I meant in practice rather than by design | 14:05 |
| cdent | got somebody in the house, so gotta come back to it | 14:05 |
| *** lyan has joined #openstack-nova | 14:06 | |
| *** ralonsoh has quit IRC | 14:07 | |
| *** edleafe is now known as figleaf | 14:07 | |
| bhagyashris | sdague: Hi, Could you please review my devstack patch https://review.openstack.org/#/c/527907/ | 14:08 |
| *** ralonsoh has joined #openstack-nova | 14:10 | |
| *** bigdogstl has joined #openstack-nova | 14:10 | |
| bhagyashris | sdague: thank you :) | 14:12 |
| sdague | bhagyashris: no prob | 14:13 |
| *** eharney has joined #openstack-nova | 14:14 | |
| *** bigdogstl has quit IRC | 14:15 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Revert "Deduplicate service status notification samples" https://review.openstack.org/533190 | 14:18 |
| *** mriedem has joined #openstack-nova | 14:18 | |
| *** edmondsw has quit IRC | 14:19 | |
| gibi | cores, the nova functional jobs are broken on master due to https://bugs.launchpad.net/nova/+bug/1742935 the revert unblocking the gate is https://review.openstack.org/533190 | 14:19 |
| openstack | Launchpad bug 1742935 in OpenStack Compute (nova) "TestServiceUpdateNotificationSample fails intermittently: u'host2' != u'host1': path: root.payload.nova_object.data.host " [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 14:19 |
| *** edmondsw has joined #openstack-nova | 14:19 | |
| *** tianhui_ has joined #openstack-nova | 14:20 | |
| mriedem | gibi: +W | 14:21 |
| *** tianhui has quit IRC | 14:22 | |
| * gibi is opening a bug to fix the functional test definition | 14:22 | |
| * gibi is opening a bug to fix the functional test *job* definition | 14:23 | |
| *** liverpooler has joined #openstack-nova | 14:23 | |
| *** edmondsw has quit IRC | 14:24 | |
| gibi | mriedem: thank | 14:24 |
| gibi | mriedem: where do we store the functional test job definition? is it in the nova tree? | 14:24 |
| *** liverpooler has quit IRC | 14:25 | |
| *** smatzek has quit IRC | 14:25 | |
| *** liverpooler has joined #openstack-nova | 14:25 | |
| *** bigdogstl has joined #openstack-nova | 14:26 | |
| *** smatzek has joined #openstack-nova | 14:26 | |
| ildikov | mriedem: updated the multi-attach api patch to microversion 2.60 | 14:27 |
| *** smatzek has quit IRC | 14:30 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195 | 14:30 |
| *** moshele has joined #openstack-nova | 14:30 | |
| *** moshele has quit IRC | 14:33 | |
| gibi | mriedem: nvm, I found it https://github.com/openstack-infra/openstack-zuul-jobs/blob/21241aec13dd3d8eae2916518a5ad8933509a512/zuul.d/jobs.yaml#L352 | 14:35 |
| *** esberglu has quit IRC | 14:36 | |
| *** janki has quit IRC | 14:36 | |
| mriedem | gibi: that's the global one, there might be an override in project-config | 14:38 |
| mriedem | gibi: https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L10600 | 14:39 |
| mriedem | that's the nova-specific blacklist | 14:39 |
| *** jangutter_ has quit IRC | 14:39 | |
| gibi | mriedem: thanks, so we have to fix this line https://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10604 | 14:40 |
| mriedem | ok - don't forget the gate queue definition for the same | 14:40 |
| gibi | mriedem: hm, no | 14:40 |
| mriedem | https://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10797 | 14:41 |
| mriedem | ildikov: thanks | 14:41 |
| gibi | mriedem: these definitions looks correct, according to this the doc/notification_samples | 14:42 |
| gibi | mriedem: should trigger the functional test | 14:42 |
| mriedem | gibi: the parent override maybe? https://github.com/openstack-infra/openstack-zuul-jobs/blob/21241aec13dd3d8eae2916518a5ad8933509a512/zuul.d/jobs.yaml#L361 | 14:43 |
| mriedem | i would think the one in project-config overrides the definition in the openstack-zuul-jobs repo though | 14:44 |
| mriedem | you'd have to ask in infra | 14:44 |
| gibi | OK, i will do that | 14:44 |
| *** edmondsw has joined #openstack-nova | 14:52 | |
| *** markvoelker has joined #openstack-nova | 14:52 | |
| mriedem | need another core on the bottom 2 novaclient patches here for 2.57 and 2.58 https://review.openstack.org/#/c/528128/ | 14:53 |
| bauzas | mriedem: I was just about +Wing the 2.58 :-) | 14:57 |
| mriedem | bauzas: don't let me distract you | 14:58 |
| mriedem | ildikov: looky here logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/ | 14:58 |
| mriedem | http://logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/ | 14:58 |
| mriedem | finally ran | 14:59 |
| mriedem | stvnoyes: ^ | 14:59 |
| bauzas | mriedem: the 2.58 is far quickier to review than the big 2.57 | 14:59 |
| mriedem | yeah i know 2.57 wasn't fun | 14:59 |
| mriedem | wasn't fun to write it | 14:59 |
| ildikov | mriedem: I saw \o/ :) | 14:59 |
| mriedem | that's why it took me a year to do the file injection deprecation patch | 14:59 |
| *** smatzek has joined #openstack-nova | 14:59 | |
| stvnoyes | cool. working on the swap test now | 14:59 |
| *** awaugama has joined #openstack-nova | 15:00 | |
| mriedem | actually, weird, it ran a really small set of tempest tests http://logs.openstack.org/89/532689/1/experimental/nova-multiattach/720b3d4/job-output.txt.gz#_2018-01-12_03_10_33_860455 | 15:01 |
| *** esberglu has joined #openstack-nova | 15:02 | |
| cdent | fried_rice: I'm more available now | 15:03 |
| fried_rice | cdent Trying to understand how urgent proper generation management is. | 15:04 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Test trigger openstack-tox-functional https://review.openstack.org/533202 | 15:05 |
| fried_rice | cdent If we can't hit placement API calls for the same provider from multiple threads, not urgent at all. | 15:05 |
| mriedem | ahh missing DEVSTACK_GATE_TEMPEST_FULL=1 | 15:06 |
| fried_rice | cdent So there's some kind of periodic task that updates inventory for a compute, right? And then if say a deploy is happening, is there a mutex for the periodic? (I seem to recall seeing something like that in the logs - "skipping such-and-such for instance X because it is in the state Y") | 15:08 |
| ildikov | mriedem: I saw, but I didn't have time to think about what's missing :) | 15:08 |
| cdent | fried_rice: I used to know, but that memory is archived | 15:09 |
| mriedem | fried_rice: that's different | 15:09 |
| *** bigdogstl has quit IRC | 15:09 | |
| mriedem | the compute node provider inventory update is the update_available_resource periodic in the compute manager, | 15:09 |
| mriedem | the thing you're thinking of is the sync_power_state task | 15:10 |
| *** bigdogstl has joined #openstack-nova | 15:10 | |
| mriedem | which skips instances that have a task_state set | 15:10 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Further testing https://review.openstack.org/533206 | 15:10 |
| mriedem | *sync_instance_power_state, something like that | 15:10 |
| mriedem | the task that auto-stops your instances | 15:10 |
| fried_rice | ah, right, thanks mriedem. So *can* multiple report client threads try to hit placement at the same time for the same provider? | 15:10 |
| mriedem | for inventory? | 15:11 |
| *** elmaciej has joined #openstack-nova | 15:11 | |
| mriedem | the update_available_resource task is in a semaphore lock | 15:11 |
| mriedem | on the compute | 15:11 |
| fried_rice | Well, for inventory as the code stands today, but we're working on getting traits in there, so now we have to coordinate RP generation between inventory and traits (and eventually aggregates etc.) | 15:11 |
| mriedem | so when things like instance create/delete/move happens which require a claim or adjust inventory, those are in that shared lock | 15:11 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 15:11 |
| mriedem | and the update_available_resource task is in the same lock | 15:11 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L51 | 15:12 |
| mriedem | "the lock" | 15:12 |
| elmaciej | Hello! Maybe someone know how to achieve live-migration on libvirt lvm backend? I have shared lun between computes and using lvm as backend. But livemigration fails as it's saying it's not shared storage. | 15:12 |
| fried_rice | nice. So if we were to use that same semaphore for whatever providery thing we're mucking with, we should be safe with the current (loose/lacking) generation handling. | 15:13 |
| mriedem | i guess | 15:15 |
| mriedem | it is just a big dumb lock though, | 15:15 |
| mriedem | and there are known perf issues with holding that lock too long which starves other stuff | 15:16 |
| cdent | does "too long" have a value? | 15:16 |
| mriedem | at least 60 seconds yeah for default rpc timeout | 15:16 |
| fried_rice | mriedem Yeah, I'll want to solve the generation thing properly eventually; I'm trying to determine the urgency of doing that. | 15:16 |
| mriedem | we've had gate issues in the past where that lock was held for more than 60 seconds and we'd have messaging timeouts | 15:16 |
| mriedem | otherwise "too long" is when some operator tells us in a year that their compute with 70 instances on it is holding the lock for 45 seconds and that blows up their server create time on that compute host | 15:17 |
| mriedem | but of course that's hard to know ahead of time | 15:17 |
| mriedem | or test for | 15:17 |
| *** yamahata has joined #openstack-nova | 15:18 | |
| cdent | mriedem: is your vacation next week? back to mexico? | 15:21 |
| mriedem | yup | 15:21 |
| mriedem | ildikov: rebase looks good, nice work | 15:21 |
| mriedem | gibi: thanks for reviewing the multiattach patches | 15:22 |
| mriedem | gibi: just one more to go.... :) | 15:22 |
| ildikov | mriedem: cool, thanks for double checking! | 15:23 |
| *** tidwellr has joined #openstack-nova | 15:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the nova-multiattach experimental queue job https://review.openstack.org/532689 | 15:25 |
| mriedem | put the new CI job on top of the series | 15:25 |
| mriedem | wonder if i should make that non-voting check | 15:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Test how to override irrelevant-fiels in zuul jobs https://review.openstack.org/533210 | 15:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211 | 15:26 |
| gibi | mriedem: I will have not time to dig into the last multi attach patch today but I will check back on Monday | 15:27 |
| mriedem | cool, thanks | 15:28 |
| mriedem | johnthetubaguy: i think this is probably something you as an ironic loving person should probably look at https://review.openstack.org/#/c/527541/ - i think we need that before we can remove the ironic flavor migration routine, and we also likely should backport that to pike | 15:28 |
| openstackgerrit | Édouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with prisep https://review.openstack.org/533212 | 15:29 |
| gibi | mriedem: based on what I learned today in infra, the project-config job definitions does not override the jobs.yaml at all so it is possible that we have more cases where the proper jobs are not triggered | 15:30 |
| mriedem | gibi: so https://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10604 makes no difference? | 15:31 |
| gibi | 15:52 < smcginnis> gibi: Yep, if the job is added through a template, then you can't override that. | 15:31 |
| gibi | 15:52 < smcginnis> gibi: A confusing and frustrating "feature" to me. | 15:31 |
| *** dansmith is now known as superdan | 15:31 | |
| gibi | 15:53 < smcginnis> And based on the number of jobs in project-config that are attempting to override that, I think it's widely misunderstood. | 15:31 |
| mriedem | hmm, so where can we override it? or can't we? | 15:31 |
| mriedem | oh i guess we'd have to add a nova-tox-functional job | 15:32 |
| mriedem | with openstack-tox-functional as the parent | 15:32 |
| smcginnis | mriedem: Only at the source. | 15:32 |
| *** READ10 has joined #openstack-nova | 15:32 | |
| mriedem | and then do our overrides | 15:32 |
| smcginnis | Yep | 15:32 |
| mriedem | well, that's probably better anyway, because | 15:32 |
| gibi | mriedem: I got a tip to try to override via .zuul.yaml in nova tree | 15:32 |
| ildikov | mriedem: did you mean the multi-attach job as non-voting? | 15:32 |
| gibi | mriedem: not yet working in https://review.openstack.org/#/c/533210/1 | 15:32 |
| mriedem | if you look at openstack-tox-py27 here http://status.openstack.org/elastic-recheck/data/integrated_gate.html | 15:32 |
| smcginnis | But the sad thing there is, the other one will still get picked up from the template, so on some patches you will have extra job runs, IIUC. | 15:32 |
| mriedem | that is ^ on all different projects using the same job name | 15:33 |
| ildikov | mriedem: if yes, I support the idea :) | 15:33 |
| mriedem | where before we have like nova-py27 | 15:33 |
| mriedem | ildikov: yes, right now the patch puts the job in the experimental queue | 15:33 |
| mriedem | but people will forget to run that | 15:33 |
| mriedem | gibi: yeah i think https://review.openstack.org/#/c/533210/1/.zuul.yaml is exactly what we're looking for | 15:33 |
| ildikov | mriedem: cool, I think non-voting would be great | 15:33 |
| *** AlexeyAbashkin has quit IRC | 15:34 | |
| gibi | mriedem: something is still not correct in my override so I need a bit more digging how to do it properly | 15:36 |
| mriedem | ok | 15:36 |
| *** fragatina has joined #openstack-nova | 15:38 | |
| cfriesen | has anyone run into problems live-migrating a boot-from-volume instance, with a config drive, on a compute node with local storage? | 15:38 |
| *** david-lyle has joined #openstack-nova | 15:38 | |
| openstackgerrit | Édouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with privsep https://review.openstack.org/533212 | 15:42 |
| *** rabel_b1 has quit IRC | 15:42 | |
| *** fragatina has quit IRC | 15:42 | |
| fried_rice | Has anyone else been following the development of ProviderTree? superdan figleaf gibi ? | 15:43 |
| figleaf | fried_rice: a bit, but not in too much depth | 15:43 |
| gibi | fried_rice: I try to follow it as time allows | 15:43 |
| fried_rice | I ran into a design blockade yesterday and need to talk it out. | 15:44 |
| superdan | definitely not enough to discuss design issues | 15:44 |
| fried_rice | So we've been protecting _Provider very carefully, ostensibly for thread safety. | 15:45 |
| sean-k-mooney | fried_rice: via the generation count | 15:45 |
| fried_rice | sean-k-mooney Actually this is only superficially related to generation | 15:46 |
| fried_rice | I think it's just so report client can keep its ProviderTree (its local cache of providers) consistent | 15:46 |
| fried_rice | In order to consume ComputeDriver.update_provider_tree, resource tracker (via report client) is going to need to be able to get at the provider's details (inventory, traits, aggs, etc.). | 15:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Test how to override irrelevant-fiels in zuul jobs https://review.openstack.org/533210 | 15:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211 | 15:47 |
| fried_rice | Today the only way you can get at those things is via these kinda awkward has_X_changed() methods. | 15:47 |
| fried_rice | I.e. you have to have something to compare against. | 15:47 |
| fried_rice | But consuming update_provider_tree, I'm going to need to compare what's in the returned ProviderTree against what's in the report client's cached ProviderTree. So I need to peel e.g. the traits list out of the former so I have something to pass to have_traits_changed. | 15:48 |
| *** bauzas is now known as bauwser | 15:48 | |
| fried_rice | And then if I decide it *has* changed, I'm going to need that same thing in order to send it down to placement. | 15:48 |
| bauwser | superdan: I saw your comment on https://review.openstack.org/#/c/528832/7/nova/virt/libvirt/driver.py@4902, what would you prefer ? | 15:49 |
| bauwser | superdan: I actually copy-pasted the Xen docstring | 15:49 |
| superdan | bauwser: which comment? | 15:49 |
| superdan | oh | 15:50 |
| bauwser | L4902 | 15:50 |
| gibi | fried_rice: so you have a ProviderTree instance in the consumer and want to compare that with the ProviderTree instance in the cache | 15:50 |
| fried_rice | giblet: just so. | 15:50 |
| superdan | bauwser: oh that, I was just expressing frustration with the code, because I've been fighting with internal allocation stuff lately | 15:50 |
| superdan | bauwser: not really asking for a change | 15:50 |
| superdan | bauwser: it would be better if you put "allocations at microversion 1.x" I guess, but it's probably not worth it here | 15:51 |
| superdan | bauwser: they changed format in 1.13 or something around there | 15:51 |
| gibi | fried_rice: can we simply implement ProviderTree.diff(another_tree) function? | 15:51 |
| *** kumarmn has joined #openstack-nova | 15:51 | |
| gibi | fried_rice: do you need to know what is changed or you just have to updat what is changed? | 15:52 |
| gibi | fried_rice: I mean update in the cache | 15:52 |
| fried_rice | gibi a) that method would then still have to be able to get at another_tree.get_me_a_provider().get_me_its_fields(), and b) it would still have to return something that we can send to placement | 15:52 |
| bauwser | superdan: okay, no worries :-) | 15:52 |
| bauwser | I'll add more details and saying which rev | 15:52 |
| sean-k-mooney | gibi: its an versioned object right so you can jsut call to primitive on both and then use the dict diff method to see if they are in sync or not | 15:52 |
| bauwser | maciejjozefczyk_: my bad, just saw your ping | 15:52 |
| fried_rice | gibi I have to update the cache too, but I also have to send changes back to placement. | 15:52 |
| bauwser | gosh, I really need to resurrect my ZNC bouncer | 15:53 |
| bauwser | the one I currently use is missing me notifications | 15:53 |
| *** felipemonteiro_ has joined #openstack-nova | 15:53 | |
| gibi | fried_rice: so you have to know which RPs are changed and also have to know what fields (e.g. inventory, aggregate, trait) are changed | 15:54 |
| bauwser | maciejjozefczyk_: so we changed the opt values in order to signal whether it was changed by the operator or not | 15:54 |
| fried_rice | gibi yup | 15:54 |
| fried_rice | gibi None of this is a problem if I can get at the fields of the _Provider; but today there's no (legal) way to do that. | 15:54 |
| bauwser | maciejjozefczyk_: now that there is no longer upgrade concerns with old Newton computes, I think it's okay to set that back | 15:54 |
| bauwser | maciejjozefczyk_: thanks for helping on that ! | 15:55 |
| sean-k-mooney | fried_rice: no legal way because of the _ | 15:55 |
| fried_rice | sean-k-mooney Yeah, and the locking. | 15:55 |
| gibi | fried_rice: OK, I think I understand the problem | 15:55 |
| fried_rice | One idea I'm noodling with: Perhaps _Provider can return a read-only copy of itself. | 15:56 |
| fried_rice | you know, def __setattr__(): raise | 15:57 |
| *** kumarmn has quit IRC | 15:57 | |
| *** cburgess has quit IRC | 15:57 | |
| sean-k-mooney | fried_rice: does the method that updates placement auto update the cache if so then ya get readonly copy and then update placement if out of sync and have it update teh cache | 15:58 |
| *** dikonoor has quit IRC | 15:58 | |
| fried_rice | sean-k-mooney Yeah | 15:58 |
| *** cburgess has joined #openstack-nova | 15:59 | |
| *** dikonoor has joined #openstack-nova | 15:59 | |
| sean-k-mooney | of course that is racy without a gloal lock on the provider tree e.g. the generation count | 15:59 |
| gibi | fried_rice: read-only copy make sense. you can also add getters to ProviderTree returning read-only copy of the RP fields you need for your comparision | 15:59 |
| fried_rice | gibi Yeah, that had been my initial thought; I just don't love the idea of having to have a zillion accessors | 16:00 |
| fried_rice | If we do the copyout thing, we get new fields for free without having to implement new getters. That kind of thing. | 16:00 |
| *** hongbin has joined #openstack-nova | 16:02 | |
| *** felipemonteiro__ has joined #openstack-nova | 16:02 | |
| *** Apoorva has joined #openstack-nova | 16:02 | |
| gibi | fried_rice: hm, if you copy the whoile internals of the ProviderTree then that might expose things that you don't want to expose (maybe new internal fields in the future) | 16:03 |
| fried_rice | gibi _Provider, not ProviderTree. And I would be okay with handling that by making the internals of _Provider (or ReadOnlyProvider, or whatever) private. | 16:04 |
| figleaf | fried_rice: perhaps make a read-only class that implements the copy from the _Provider? | 16:04 |
| figleaf | just copy the relevant fields | 16:05 |
| fried_rice | figleaf Yuh. Though I'm having trouble figuring out how to make a read-only class that you can still initialize :) | 16:05 |
| *** kumarmn has joined #openstack-nova | 16:05 | |
| gibi | fried_rice: in general, if you do bulk copy you get every new thing by default and that can be too much. If you do selective copy the you will get no new things automatically which might be not enough | 16:05 |
| *** felipemonteiro_ has quit IRC | 16:05 | |
| finucannot | melwitt: Could you take another look through https://review.openstack.org/#/q/topic:bp/websocket-proxy-to-host-security today? Think I've answered all your questions on the base patch | 16:05 |
| gibi | fried_rice: so both copy strategy has its own edge case | 16:06 |
| sean-k-mooney | fried_rice: if you make a dedicated class it dows not need to be read only. just have a method that create a opject of ReadOnlyProvider form the provider | 16:06 |
| figleaf | fried_rice: make the __setattr__() conditional. Start with writing enabled, initialize, and then flip the switch. Once flipped, you can't flip it back | 16:06 |
| fried_rice | figleaf Yeah, that should work. Playing... | 16:07 |
| melwitt | finucannot: yes, thanks for the replies | 16:07 |
| fried_rice | sean-k-mooney Yeah, so like when you get it, you could technically modify it, but it wouldn't affect the original. | 16:07 |
| *** mlavalle has joined #openstack-nova | 16:07 | |
| mriedem | finucannot: melwitt: so am i ok to start reviewing the websocket-proxy-to-host-security series? | 16:09 |
| finucannot | mriedem: Can't speak for melwitt, but I think so, yes | 16:09 |
| mriedem | ok | 16:09 |
| mriedem | running https://review.openstack.org/#/c/530950/ again | 16:10 |
| sean-k-mooney | fried_rice: yep you could enven just use the same Provider class if you wanted just make a deep copy of it and return the copy | 16:10 |
| fried_rice | sean-k-mooney Just so. | 16:11 |
| melwitt | finucannot: did you link the wrong thing in your reply here about what fixed the original py35 job failure we saw? https://review.openstack.org/#/c/531834 | 16:11 |
| sean-k-mooney | fried_rice: that would be wasting some ram but either way you cant modify the original | 16:11 |
| melwitt | finucannot: because that link is to the same review. oh, you're saying you combined them into one review | 16:11 |
| melwitt | I got it | 16:11 |
| finucannot | mriedem: Go for it. I wonder if we can enable that by default in the gate at some point (i.e. override the DevStack default) | 16:11 |
| finucannot | melwitt: yup, 'zactly | 16:11 |
| *** itlinux has joined #openstack-nova | 16:12 | |
| finucannot | In hindsight, I probably should have kept it with the change that actually exercises the code (like it was), but it's done now | 16:12 |
| fried_rice | sean-k-mooney I have to copy anyway. I don't want to lock down the original. I still want to be able to modify it through legal means (via ProviderTree) | 16:12 |
| mriedem | finucannot: we should enable it in the nova-next job | 16:12 |
| mriedem | like in melwitt's patch | 16:12 |
| finucannot | Can move back if you'd rather that | 16:12 |
| mriedem | https://review.openstack.org/#/c/513160/ | 16:12 |
| melwitt | finucannot: okay so it looks like you only have test coverage for one of the convert-to-bytes and not the other? | 16:12 |
| fried_rice | figleaf That conditional setattr thing works a treat, thanks for that. | 16:13 |
| mriedem | melwitt: the test coverage for both would be in the devstack change testing all of this on the top right? | 16:13 |
| fried_rice | (whether I end up using it or not) | 16:13 |
| finucannot | melwitt: In that change, yes, because there aren't yet any callers for 'sendall' | 16:13 |
| finucannot | The callers come in latter patches and the tests are the functional ones | 16:13 |
| finucannot | ...which caught the issue in the first place | 16:13 |
| mriedem | honestly i'm mostly interested in seeing clean ci runs and getting the good enough version of this in | 16:13 |
| finucannot | mriedem: I thought nova-next was a neutron thing, i.e. run neutron with the next version of nova to make sure they still talk nicely? | 16:14 |
| mriedem | no | 16:14 |
| mriedem | nova-next == nova with fancy wizbangs | 16:14 |
| figleaf | fried_rice: kewl | 16:14 |
| *** zhaochao has quit IRC | 16:14 | |
| melwitt | mriedem: yeah. we were talking about unit tests for the bytes send stuff | 16:15 |
| *** suresh12 has joined #openstack-nova | 16:16 | |
| melwitt | finucannot: I see. I would think the unit test coverage should have gone along with the addition of 'sendall' originally, it's just we didn't anticipate anything being wrong with the context passed to sendall | 16:17 |
| *** jackie-truong has joined #openstack-nova | 16:17 | |
| *** slaweq has quit IRC | 16:18 | |
| melwitt | but yeah. I agree to focus on the devstack testing at this point | 16:18 |
| *** slaweq has joined #openstack-nova | 16:18 | |
| melwitt | s/content/context/ | 16:20 |
| gibi | mriedem: second try looks good now in https://review.openstack.org/#/c/533210/2 , I will create the proper patches (one for nova and one for the project-config) on Monday | 16:20 |
| melwitt | guh s/context/content/ | 16:20 |
| *** itlinux has quit IRC | 16:20 | |
| finucannot | melwitt: Yeah, there's no tests for 'TenantSock' because it was supposed to be just a shim around 'websockify.websocket.WebSocketRequestHandler'. Perhaps it's time we added them. | 16:21 |
| melwitt | finucannot: yeah, I realized the same. we should do that as a follow up later | 16:22 |
| *** hoonetorg has quit IRC | 16:22 | |
| *** slaweq has quit IRC | 16:22 | |
| superdan | bauwser: if you didn't see the pings from yesterday, this needs your eyes (and -2?) https://review.openstack.org/#/c/532924/ | 16:24 |
| melwitt | mriedem: on my consoles series, my reply was basically that we currently only invalidate console auths for delete instance and live migrate. and I was thinking not to change any behavior in my series since it's supposed to just be changing the backend of the console auth | 16:26 |
| *** jdillaman has quit IRC | 16:27 | |
| melwitt | I think you're right that we should be invalidating console auths for all instance moves including cold migrate and shelve but I was thinking that would be a separate change | 16:27 |
| *** sree has quit IRC | 16:27 | |
| cdent | mriedem: nova-next as py3 makes excellent and vaguely poetic sense | 16:28 |
| mriedem | cdent: did you just see my comment on stephen's patch? | 16:28 |
| cdent | yes | 16:28 |
| *** elmaciej has quit IRC | 16:28 | |
| mriedem | heh | 16:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | 16:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211 | 16:28 |
| mriedem | cdent: i think we can make that happen once newton is dead | 16:29 |
| mriedem | as nova-next should only run on pike+ | 16:29 |
| *** Guest83 has quit IRC | 16:29 | |
| *** elmaciej has joined #openstack-nova | 16:29 | |
| *** suresh12 has quit IRC | 16:33 | |
| *** ttsiouts has quit IRC | 16:33 | |
| *** damien_r has left #openstack-nova | 16:34 | |
| *** armax has joined #openstack-nova | 16:37 | |
| *** jistr has quit IRC | 16:37 | |
| *** dtantsur has quit IRC | 16:37 | |
| *** antonym has quit IRC | 16:37 | |
| *** carl_baldwin has quit IRC | 16:37 | |
| *** test222 has quit IRC | 16:37 | |
| *** sapd_ has quit IRC | 16:37 | |
| *** mgariepy has quit IRC | 16:37 | |
| *** figleaf has quit IRC | 16:37 | |
| *** asettle has quit IRC | 16:37 | |
| *** bfife has quit IRC | 16:37 | |
| *** StevenK has quit IRC | 16:37 | |
| *** mdbooth has quit IRC | 16:37 | |
| *** ansiwen has quit IRC | 16:37 | |
| *** dosaboy has quit IRC | 16:37 | |
| *** dosaboy has joined #openstack-nova | 16:37 | |
| *** bfife has joined #openstack-nova | 16:37 | |
| *** sapd_ has joined #openstack-nova | 16:37 | |
| *** StevenK has joined #openstack-nova | 16:37 | |
| *** asettle has joined #openstack-nova | 16:37 | |
| *** asettle is now known as Guest31532 | 16:37 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: Add PowerVM to feature-classification https://review.openstack.org/533237 | 16:37 |
| *** edleafe has joined #openstack-nova | 16:37 | |
| *** mgariepy has joined #openstack-nova | 16:38 | |
| *** carl_baldwin has joined #openstack-nova | 16:38 | |
| mriedem | finucannot: got some nits in https://review.openstack.org/#/c/345397/ but those could be dealt with in a cleanup patch at the end of the series | 16:38 |
| *** antonym has joined #openstack-nova | 16:38 | |
| *** links has quit IRC | 16:38 | |
| *** test222 has joined #openstack-nova | 16:39 | |
| *** mdbooth has joined #openstack-nova | 16:39 | |
| *** hoonetorg has joined #openstack-nova | 16:39 | |
| *** edleafe is now known as figleaf | 16:39 | |
| finucannot | mriedem: Cool. I can tackle those now | 16:39 |
| *** itlinux has joined #openstack-nova | 16:39 | |
| *** jistr has joined #openstack-nova | 16:40 | |
| *** ansiwen has joined #openstack-nova | 16:40 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | 16:42 |
| *** links has joined #openstack-nova | 16:43 | |
| fried_rice | gibi That host1 != host2 thing - is the fix merged at this point? | 16:43 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Testing if funct test is triggered https://review.openstack.org/533211 | 16:43 |
| *** corvus is now known as jeblair | 16:43 | |
| *** jeblair is now known as corvus | 16:43 | |
| superdan | several things in the gate have failing tests and zuul doesn't seem to be responding to status queries | 16:44 |
| superdan | might be headed for another reset | 16:44 |
| superdan | oh yep, here it comes | 16:44 |
| *** matrohon has quit IRC | 16:44 | |
| fried_rice | gibi Found it: https://review.openstack.org/#/c/533190/ -- Guess I can rebase on top of it, or wait for it to merge. | 16:45 |
| -openstackstatus- NOTICE: Zuul has been restarted and lost queue information; changes in progress will need to be rechecked. | 16:45 | |
| *** elmaciej has quit IRC | 16:47 | |
| *** kumarmn has quit IRC | 16:47 | |
| *** jackie-truong has quit IRC | 16:48 | |
| *** mdnadeem has quit IRC | 16:48 | |
| *** kumarmn has joined #openstack-nova | 16:50 | |
| *** slaweq has joined #openstack-nova | 16:52 | |
| *** chyka has joined #openstack-nova | 16:54 | |
| mriedem | finucannot: cool. some more in https://review.openstack.org/#/c/345398/ | 16:54 |
| *** fragatina has joined #openstack-nova | 16:54 | |
| finucannot | Sweet | 16:54 |
| * finucannot has actually tried integrating mypy into nova multiple times. Alas, it does not like mock | 16:54 | |
| *** kumarmn has quit IRC | 16:54 | |
| *** sree has joined #openstack-nova | 16:55 | |
| *** kholkina has quit IRC | 16:55 | |
| *** slaweq has quit IRC | 16:56 | |
| mriedem | finucannot: oh boy, what is this about https://review.openstack.org/#/c/345399/42/nova/cmd/novncproxy.py@43 ? | 16:57 |
| mriedem | is that asserting that is cool for all other virt drivers besides xen/ | 16:57 |
| mriedem | ? | 16:57 |
| finucannot | Yup, melwitt and I discussed that. The drivers that support VNC support 3.8, and the ones that don't support VNC don't matter, obviously. It's only Xen that supports 3.3 | 16:58 |
| mriedem | ok | 16:59 |
| *** sree has quit IRC | 16:59 | |
| finucannot | Yup, here's the thread https://review.openstack.org/#/c/345399/34/nova/cmd/novncproxy.py@43 | 16:59 |
| * finucannot disappears for 20 minutes | 17:00 | |
| *** sree has joined #openstack-nova | 17:02 | |
| *** pcaruana has quit IRC | 17:03 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ProviderTree.find => ReadOnlyProvider https://review.openstack.org/533244 | 17:07 |
| *** fragatina has quit IRC | 17:07 | |
| fried_rice | cdent figleaf gibi sean-k-mooney There's a start ^ | 17:07 |
| *** fried_rice is now known as fried_rolls | 17:07 | |
| *** fragatina has joined #openstack-nova | 17:07 | |
| *** tidwellr has quit IRC | 17:08 | |
| *** tidwellr has joined #openstack-nova | 17:08 | |
| *** sree has quit IRC | 17:11 | |
| *** tesseract has quit IRC | 17:12 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:12 | |
| *** gszasz has quit IRC | 17:13 | |
| *** tidwellr has quit IRC | 17:13 | |
| mriedem | finucannot: some questions in https://review.openstack.org/#/c/345399/ | 17:13 |
| mriedem | melwitt: i've gone through the meaty parts of the websocket proxy series | 17:15 |
| *** felipemonteiro__ has quit IRC | 17:15 | |
| mriedem | withholding +2 on the last rfb one until the questions are answered and CI results are done | 17:15 |
| *** felipemonteiro__ has joined #openstack-nova | 17:15 | |
| cdent | fried_rolls: noted, got it on my list for a looksee | 17:15 |
| *** AlexeyAbashkin has quit IRC | 17:17 | |
| melwitt | mriedem: just skimmed through your comments. originally, finucannot had enabled TLS for only the libvirt driver and I suggested changing it to not xen because I thought generally when we add these features we don't aim to target them at one driver only and that some consensus around at least more than one driver is reached before going ahead | 17:18 |
| melwitt | maybe I was mistaken on that | 17:18 |
| openstackgerrit | Mathieu Rohon proposed openstack/nova master: Allow VMs to use unaddressed port https://review.openstack.org/533249 | 17:19 |
| *** AlexeyAbashkin has joined #openstack-nova | 17:21 | |
| *** sree has joined #openstack-nova | 17:21 | |
| *** links has quit IRC | 17:24 | |
| *** AlexeyAbashkin has quit IRC | 17:25 | |
| *** sree has quit IRC | 17:26 | |
| *** slaweq has joined #openstack-nova | 17:28 | |
| *** slaweq has quit IRC | 17:29 | |
| *** slaweq has joined #openstack-nova | 17:30 | |
| *** slaweq has quit IRC | 17:30 | |
| *** suresh12 has joined #openstack-nova | 17:30 | |
| *** suresh12 has quit IRC | 17:31 | |
| *** suresh12 has joined #openstack-nova | 17:31 | |
| finucannot | mriedem: I've addressed all the questions. Will tackle the cleanups in the follow-up patch | 17:31 |
| *** slaweq has joined #openstack-nova | 17:31 | |
| *** slaweq has quit IRC | 17:31 | |
| *** Tom-Tom has joined #openstack-nova | 17:31 | |
| *** tidwellr has joined #openstack-nova | 17:33 | |
| sean-k-mooney | fried_rolls: the patch seams fine - the lack of any testing :) | 17:33 |
| *** slaweq has joined #openstack-nova | 17:33 | |
| *** Tom-Tom_ has joined #openstack-nova | 17:35 | |
| *** slaweq has quit IRC | 17:35 | |
| sean-k-mooney | fried_rolls: instead of _check_readonly and the current __setattr__ you could just asign a throwing __setattr__ at the end of the init. it might save some cycle during the copy of the childern that said the branch predictor should get this right 99% of the time | 17:35 |
| *** felipemonteiro_ has joined #openstack-nova | 17:37 | |
| *** Tom-Tom has quit IRC | 17:37 | |
| *** lpetrut has quit IRC | 17:40 | |
| *** felipemonteiro__ has quit IRC | 17:41 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:42 | |
| *** esberglu has quit IRC | 17:43 | |
| *** AlexeyAbashkin has quit IRC | 17:44 | |
| *** esberglu has joined #openstack-nova | 17:45 | |
| *** esberglu has quit IRC | 17:50 | |
| *** Apoorva_ has joined #openstack-nova | 17:55 | |
| *** mvk has quit IRC | 17:55 | |
| *** penick has joined #openstack-nova | 17:56 | |
| *** Apoorva has quit IRC | 17:57 | |
| *** derekh has quit IRC | 17:58 | |
| *** markvoelker has quit IRC | 18:00 | |
| *** tidwellr has quit IRC | 18:03 | |
| *** felipemonteiro_ has quit IRC | 18:03 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:04 | |
| *** ralonsoh has quit IRC | 18:05 | |
| *** lucasagomes is now known as lucas-afk | 18:07 | |
| *** tidwellr has joined #openstack-nova | 18:10 | |
| *** matrohon has joined #openstack-nova | 18:12 | |
| *** david-lyle has quit IRC | 18:12 | |
| *** gouthamr has joined #openstack-nova | 18:16 | |
| *** jackie-truong has joined #openstack-nova | 18:17 | |
| *** lyan has quit IRC | 18:24 | |
| *** READ10 has quit IRC | 18:24 | |
| *** sridharg has quit IRC | 18:29 | |
| *** lyan has joined #openstack-nova | 18:30 | |
| *** READ10 has joined #openstack-nova | 18:31 | |
| openstackgerrit | Mathieu Rohon proposed openstack/nova master: Allow VMs to use unaddressed ports https://review.openstack.org/533249 | 18:32 |
| *** sdague has quit IRC | 18:34 | |
| *** alaski has quit IRC | 18:34 | |
| *** d34dh0r53 has quit IRC | 18:34 | |
| *** d34dh0r53 has joined #openstack-nova | 18:34 | |
| *** alaski_ has joined #openstack-nova | 18:34 | |
| *** alaski_ is now known as alaski | 18:35 | |
| *** esberglu has joined #openstack-nova | 18:35 | |
| *** jpena is now known as jpena|off | 18:35 | |
| *** slaweq has joined #openstack-nova | 18:35 | |
| *** READ10 has quit IRC | 18:35 | |
| *** rhagarty has quit IRC | 18:37 | |
| *** matrohon has quit IRC | 18:37 | |
| *** tbachman has joined #openstack-nova | 18:37 | |
| *** amotoki has quit IRC | 18:37 | |
| *** READ10 has joined #openstack-nova | 18:38 | |
| *** amotoki has joined #openstack-nova | 18:39 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:40 | |
| *** matrohon has joined #openstack-nova | 18:40 | |
| mriedem | melwitt: no you're correct that we want features adopted by a majority of virt drivers | 18:41 |
| *** Tom-Tom_ has quit IRC | 18:42 | |
| *** rhagarty has joined #openstack-nova | 18:43 | |
| *** slaweq_ has joined #openstack-nova | 18:43 | |
| *** felipemonteiro_ has quit IRC | 18:44 | |
| *** slaweq__ has joined #openstack-nova | 18:46 | |
| *** slaweq has quit IRC | 18:47 | |
| *** lyan has quit IRC | 18:47 | |
| *** slaweq_ has quit IRC | 18:48 | |
| *** dtantsur has joined #openstack-nova | 18:50 | |
| *** avolkov has quit IRC | 18:50 | |
| *** sdague has joined #openstack-nova | 18:51 | |
| *** gyee has joined #openstack-nova | 18:52 | |
| *** matrohon has quit IRC | 18:57 | |
| *** felipemonteiro__ has quit IRC | 18:58 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:58 | |
| *** gouthamr has quit IRC | 19:01 | |
| *** lyan has joined #openstack-nova | 19:04 | |
| mriedem | melwitt: ok i'm +2 up through the rfb patch | 19:04 |
| mriedem | and ci is happy http://logs.openstack.org/50/530950/1/check/legacy-tempest-dsvm-py35/6f0c24d/logs/screen-n-novnc.txt.gz#_Jan_12_17_42_32_200099 | 19:04 |
| *** suresh12 has quit IRC | 19:04 | |
| melwitt | mriedem: sweet, I'll go through it again today | 19:06 |
| *** sree has joined #openstack-nova | 19:07 | |
| *** jackie-truong has quit IRC | 19:08 | |
| *** lyan has quit IRC | 19:08 | |
| mriedem | finucannot: comments in the docs patch and i'm done https://review.openstack.org/#/c/500544/ | 19:09 |
| *** READ10 has quit IRC | 19:09 | |
| *** sambetts is now known as sambetts|afk | 19:09 | |
| *** tbachman_ has joined #openstack-nova | 19:09 | |
| finucannot | mriedem: Excellent, thanks :) I'll address all the comments in a follow-up by Monday | 19:10 |
| mriedem | ack | 19:10 |
| mriedem | tell danpb the good news :) | 19:11 |
| mriedem | he is risen | 19:11 |
| finucannot | :D | 19:11 |
| * finucannot must get danpb to review a blog on all this stuff. It's obscure stuff, for sure | 19:11 | |
| *** READ10 has joined #openstack-nova | 19:12 | |
| *** sree has quit IRC | 19:12 | |
| *** tbachman has quit IRC | 19:12 | |
| *** tbachman_ is now known as tbachman | 19:12 | |
| *** penick has quit IRC | 19:14 | |
| *** gyee has quit IRC | 19:16 | |
| *** moshele has joined #openstack-nova | 19:18 | |
| *** penick has joined #openstack-nova | 19:20 | |
| *** suresh12 has joined #openstack-nova | 19:24 | |
| *** mriedem has quit IRC | 19:25 | |
| *** AlexeyAbashkin has joined #openstack-nova | 19:25 | |
| *** moshele has quit IRC | 19:26 | |
| *** harlowja has joined #openstack-nova | 19:27 | |
| *** claudiub has quit IRC | 19:30 | |
| *** mriedem has joined #openstack-nova | 19:32 | |
| *** david-lyle has joined #openstack-nova | 19:33 | |
| *** moshele has joined #openstack-nova | 19:37 | |
| *** jose-phi_ has quit IRC | 19:38 | |
| *** sree has joined #openstack-nova | 19:38 | |
| *** jose-phillips has joined #openstack-nova | 19:38 | |
| *** sahid has quit IRC | 19:39 | |
| *** lajoskatona has left #openstack-nova | 19:41 | |
| *** AlexeyAbashkin has quit IRC | 19:42 | |
| openstackgerrit | Sriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number https://review.openstack.org/531674 | 19:42 |
| *** lyan has joined #openstack-nova | 19:43 | |
| *** sree has quit IRC | 19:43 | |
| *** burt has quit IRC | 19:43 | |
| *** sree has joined #openstack-nova | 19:47 | |
| *** sree has quit IRC | 19:52 | |
| *** bigdogstl has quit IRC | 19:54 | |
| *** tidwellr has quit IRC | 19:58 | |
| *** cdent is now known as future_fungi | 19:58 | |
| *** future_fungi is now known as cdent | 19:59 | |
| superdan | mriedem: oh you're back | 20:00 |
| superdan | mriedem: wanna conduct a thought experiment with me? | 20:00 |
| mriedem | umm | 20:02 |
| superdan | you can have this lollipop if you get into my van... | 20:03 |
| *** harlowja has quit IRC | 20:04 | |
| mriedem | stvnoyes: nice work on https://review.openstack.org/#/c/533285/ | 20:05 |
| mriedem | superdan: shoot | 20:05 |
| mriedem | if it's overly complicated for my vacation brain i'll opt out | 20:06 |
| superdan | mriedem: you wanna do hangout for expediency or here? | 20:06 |
| mriedem | oh... | 20:06 |
| mriedem | i have migrated to the game of thrones final episode of season 7 viewing area... | 20:06 |
| mriedem | i didn't realize i'd have to put professional pants back on | 20:06 |
| superdan | you don't, I can explain here | 20:06 |
| superdan | it'd just be quicker via voice, but up to you | 20:07 |
| mriedem | sec, i'll move back to the office | 20:07 |
| superdan | mriedem: https://hangouts.google.com/call/BPfFHG1eYDY-HJyiblzMAAEE | 20:08 |
| superdan | melwitt ^ | 20:08 |
| *** sree has joined #openstack-nova | 20:08 | |
| *** yamahata has quit IRC | 20:10 | |
| *** sree has quit IRC | 20:13 | |
| mriedem | reminds me of this https://review.openstack.org/#/c/529626/ | 20:13 |
| *** bigdogstl has joined #openstack-nova | 20:13 | |
| *** bigdogstl has quit IRC | 20:19 | |
| superdan | sdague: please +W this backport ASAP kthx | 20:21 |
| superdan | https://review.openstack.org/#/c/529635 | 20:21 |
| *** sree has joined #openstack-nova | 20:24 | |
| *** alexchadin has joined #openstack-nova | 20:25 | |
| *** bigdogstl has joined #openstack-nova | 20:25 | |
| *** alexchadin has quit IRC | 20:26 | |
| *** alexchadin has joined #openstack-nova | 20:27 | |
| *** sree has quit IRC | 20:28 | |
| melwitt | mriedem: couple stable backports needing review https://review.openstack.org/#/q/topic:bug/1713857 and https://review.openstack.org/#/q/topic:bug/1724573 | 20:28 |
| melwitt | oh wait, you did the backports in the first bug so you can't review them. guh | 20:29 |
| *** bigdogstl has quit IRC | 20:30 | |
| fried_rolls | sean-k-mooney I actually tried that, and for some reason it didn't work. I'm actually not super worried about it; I'd almost be tempted to leave the read-only protections off entirely, since the point is for them not to be able to modify the original ProviderTree. | 20:31 |
| *** imacdonn has quit IRC | 20:33 | |
| *** imacdonn has joined #openstack-nova | 20:33 | |
| *** bigdogstl has joined #openstack-nova | 20:33 | |
| mriedem | mtreinish: want to hit this backport? https://review.openstack.org/#/c/523911/ | 20:34 |
| *** alexchadin has quit IRC | 20:35 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 20:37 |
| figleaf | mriedem: ^^ addressed your comments | 20:37 |
| *** fragatina has quit IRC | 20:38 | |
| openstackgerrit | Merged openstack/nova master: Revert "Deduplicate service status notification samples" https://review.openstack.org/533190 | 20:39 |
| openstackgerrit | Merged openstack/nova master: Add a warning in 'nova-manage cell_v2 delete_cell' https://review.openstack.org/513771 | 20:40 |
| openstackgerrit | Merged openstack/nova master: Update FAQs about listing hosts in cellv2 https://review.openstack.org/531559 | 20:40 |
| openstackgerrit | Merged openstack/nova master: Document lack of side-effects in AllocationList.create_all() https://review.openstack.org/530997 | 20:40 |
| mtreinish | mriedem: +A | 20:41 |
| *** READ10 has quit IRC | 20:42 | |
| *** Tom-Tom has joined #openstack-nova | 20:43 | |
| *** yamahata has joined #openstack-nova | 20:45 | |
| *** openstackstatus has quit IRC | 20:46 | |
| *** openstack has joined #openstack-nova | 20:48 | |
| *** ChanServ sets mode: +o openstack | 20:48 | |
| melwitt | lyarwood: your review needed please for the libvirt driver re-init on hard reboot backport https://review.openstack.org/#/c/531422 | 20:49 |
| *** lpetrut has joined #openstack-nova | 20:53 | |
| *** sree has joined #openstack-nova | 20:58 | |
| *** felipemonteiro has joined #openstack-nova | 21:00 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test helper: validate provider summaries https://review.openstack.org/518982 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix accumulated nits in refactor series https://review.openstack.org/521189 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add aggregates check in allocation candidates https://review.openstack.org/522407 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix missing rps in allocation candidates https://review.openstack.org/522409 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: func tests for multiple shared RPs https://review.openstack.org/498737 | 21:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195 | 21:00 |
| fried_rolls | Cores, can I please get re+Ws on ^ after rebasing to pick up gibi fix? | 21:01 |
| *** fried_rolls is now known as fried_rice | 21:01 | |
| *** matrohon has joined #openstack-nova | 21:02 | |
| *** itlinux has quit IRC | 21:02 | |
| *** sree has quit IRC | 21:02 | |
| mriedem | fried_rice: done | 21:03 |
| fried_rice | mriedem Thanks | 21:03 |
| *** felipemonteiro_ has quit IRC | 21:03 | |
| *** Jeffrey4l has quit IRC | 21:03 | |
| fried_rice | Considering how to deal with similar on https://review.openstack.org/#/c/521686/ series... | 21:03 |
| mriedem | figleaf: thanks, comments ilnine | 21:08 |
| mriedem | *inline | 21:08 |
| mriedem | fried_rice: w/o rechecking? | 21:09 |
| openstackgerrit | Merged openstack/nova master: Fix typo in release note https://review.openstack.org/531854 | 21:09 |
| fried_rice | mriedem That bottom one has been languishing all week; I kinda don't want to try a recheck only to find that I needed a rebase. I'm gonna rebase the series... | 21:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track provider traits in report client https://review.openstack.org/521686 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise conflict exception on RP create 409 https://review.openstack.org/532563 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 21:10 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 21:10 |
| *** moshele has quit IRC | 21:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 21:10 |
| fried_rice | mriedem Done, please re+W https://review.openstack.org/#/c/521686/ | 21:10 |
| *** sree has joined #openstack-nova | 21:10 | |
| *** Jeffrey4l has joined #openstack-nova | 21:11 | |
| *** sree has quit IRC | 21:15 | |
| *** liverpooler has quit IRC | 21:21 | |
| *** jackie-truong has joined #openstack-nova | 21:21 | |
| *** Jeffrey4l has quit IRC | 21:24 | |
| *** smatzek has quit IRC | 21:25 | |
| mriedem | fried_rice: it's just that one on the bottom right? | 21:25 |
| fried_rice | mriedem Yessir. | 21:25 |
| *** smatzek has joined #openstack-nova | 21:25 | |
| *** harlowja has joined #openstack-nova | 21:26 | |
| fried_rice | Been bouncing around zuul-land since Tuesday morning. | 21:26 |
| fried_rice | Thank you sir. | 21:26 |
| *** penick has quit IRC | 21:28 | |
| *** smatzek has quit IRC | 21:30 | |
| *** itlinux has joined #openstack-nova | 21:33 | |
| *** matrohon has quit IRC | 21:35 | |
| *** edmondsw has quit IRC | 21:36 | |
| figleaf | mriedem: about your comment on https://review.openstack.org/#/c/526436/23/nova/conductor/tasks/migrate.py@242 | 21:37 |
| *** Jeffrey4l has joined #openstack-nova | 21:37 | |
| figleaf | The _revert_allocation() method has already been called at that point | 21:37 |
| mriedem | figleaf: _revert_allocation on the compute deletes the source node allocation for the migration record and moves it back to the instance so the instance allocations are doubled up on the source and dest node | 21:38 |
| mriedem | it doesn't remove the allocation that the instance has on the dest node, just moves it back from migration->instance | 21:38 |
| mriedem | but once we're back in conductor, the instance allocation on the dest node is now the wrong dest node (the failed one), and we need to move it from that to the alternate | 21:39 |
| figleaf | I'm not seeing that in the tests | 21:39 |
| mriedem | unless claim_resources for the instance does a total rewrite of what the instance consumer has allocations on, | 21:39 |
| mriedem | that could be the case | 21:39 |
| mriedem | is it an update/overwrite> | 21:39 |
| *** lpetrut has quit IRC | 21:39 | |
| mriedem | ? | 21:39 |
| figleaf | It's a PUT, so overwrite | 21:40 |
| mriedem | ok, well that's excellent news | 21:40 |
| mriedem | then i think the only major thing is the migration obj lookup | 21:40 |
| figleaf | mriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1136 | 21:40 |
| figleaf | I added a filter on status, and also added some allocation tests to verify that only the host that succeeds has allocations | 21:41 |
| mriedem | figleaf: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1096 | 21:41 |
| mriedem | are you sure we don't hit https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1132 and it thinks we're doing a move | 21:41 |
| mriedem | and double the allocations for the instance again? | 21:41 |
| figleaf | mriedem: I put a break on that line and never hit it. Let me run it again to be sure | 21:42 |
| mriedem | and your test is asserting the failed hosts don't have any allocations on them when we're done rescheduling? | 21:43 |
| mriedem | i guess you said that already | 21:43 |
| figleaf | yeah | 21:43 |
| mriedem | the other thing is, dest_alloc_req is going to be in the new format here now https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L180 | 21:44 |
| mriedem | so i'd expect to hit some issues there, like superdan did in his patch | 21:44 |
| figleaf | I just re-ran the functional test with debug output for the current_allocs in the code, and it's empty every time | 21:44 |
| mriedem | i could have sworn we talked about this during the reschedules on the server create path | 21:44 |
| mriedem | *patch | 21:44 |
| mriedem | idk, doesn't make sense to me that that report client code doesn't think we're doing a move operation b/c the instance should still have the allocation on the originally chosen dest node | 21:45 |
| figleaf | mriedem: got the new format covered: https://review.openstack.org/#/c/526436/23/nova/tests/functional/test_servers.py@2730 | 21:45 |
| mriedem | unless something is deleting that before we get there | 21:46 |
| mriedem | figleaf: i don't understand why your functional test needs to stub any of that out | 21:46 |
| mriedem | kind of defeats the purpose of using a functional test | 21:47 |
| mriedem | anyway, i'm on serious vacation brain mode at this point and trying to wrap up some stuff around the house before i turn things off | 21:48 |
| mriedem | so can't really dig into this in detail | 21:48 |
| figleaf | mriedem: the only things that are stubbed/mocked are a) the prep_resize, so I can force it to pass/fail, and select_destinations, so I can return the selections and also verify that it only called once (i.e., alternates are used) | 21:50 |
| *** matrohon has joined #openstack-nova | 21:50 | |
| mriedem | we shouldn't have to stub out select_destinations | 21:50 |
| mriedem | i left a comment in the patch, | 21:50 |
| mriedem | if you need predictable sort order on the hosts, add a custom weigher to the test | 21:50 |
| mriedem | there are some examples in other tests | 21:50 |
| figleaf | and how can I verify that it isn't called repeatedly? | 21:51 |
| *** sree has joined #openstack-nova | 21:52 | |
| *** r-daneel has joined #openstack-nova | 21:52 | |
| mriedem | if prep_resize is called > len(hosts) then you'd know right? | 21:52 |
| mriedem | or max_attempts or whatever | 21:52 |
| figleaf | prep_resize will be called once for each attempted migration | 21:54 |
| figleaf | select_destinations is called from the task | 21:54 |
| *** sree has quit IRC | 21:56 | |
| *** jackie-truong has quit IRC | 21:58 | |
| *** slaweq__ has quit IRC | 22:06 | |
| *** burt has joined #openstack-nova | 22:06 | |
| *** slaweq has joined #openstack-nova | 22:08 | |
| *** fragatina has joined #openstack-nova | 22:08 | |
| *** archit has quit IRC | 22:09 | |
| *** itlinux has quit IRC | 22:10 | |
| *** Jeffrey4l has quit IRC | 22:11 | |
| *** Jeffrey4l has joined #openstack-nova | 22:14 | |
| mriedem | figleaf: i think you were right about _revert_allocation, | 22:14 |
| mriedem | i think that deletes the allocation for the migration record on the source node, and overwrites the instance allocation to only be on the source node, | 22:15 |
| mriedem | i remember why you were hitting the format issue where the reschedules on build thought we were doubling up again when claiming on the alterante, | 22:15 |
| mriedem | and it was because we hit that before the compute had removed the allocation the instance had on the failed node | 22:15 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4091 | 22:15 |
| mriedem | "either way we need to cleanup any allocations created # by the scheduler for the destination node." | 22:16 |
| mriedem | so yeah, that's why on the reschedule, claim_resources doesn't think we're doubling, because the instance doesn't have a claim on the old failed dest node | 22:16 |
| figleaf | mriedem: yeah, that was the racy part that I fixed by moving it earlier before the cast | 22:17 |
| figleaf | I ran some traces, and set_and_clear_allocations() is being called for each reschedule | 22:17 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 22:22 |
| figleaf | mriedem: ^^ if you still have brain cycles | 22:22 |
| fried_rice | figleaf It occurs to me I should be prepping the agenda for the sched meeting. Is ^ the only remaining thing for alternates? | 22:22 |
| *** felipemonteiro has quit IRC | 22:23 | |
| *** felipemonteiro has joined #openstack-nova | 22:23 | |
| figleaf | fried_rice: yes | 22:23 |
| fried_rice | k | 22:24 |
| mriedem | figleaf: comments inline, | 22:27 |
| mriedem | figleaf: plus a question about ordering, something for probably superdan to look at on monday for a 2nd opinion | 22:27 |
| *** fragatina has quit IRC | 22:28 | |
| *** fragatina has joined #openstack-nova | 22:28 | |
| *** weshay is now known as weshay_PTO | 22:29 | |
| *** lyan has quit IRC | 22:29 | |
| figleaf | mriedem: ok, thx | 22:30 |
| figleaf | mriedem: now turn off your brain and enjoy your holiday | 22:30 |
| *** fragatina has quit IRC | 22:33 | |
| *** awaugama has quit IRC | 22:34 | |
| *** matrohon has quit IRC | 22:34 | |
| *** fragatina has joined #openstack-nova | 22:35 | |
| *** sree has joined #openstack-nova | 22:36 | |
| *** dikonoor has quit IRC | 22:36 | |
| *** dikonoor has joined #openstack-nova | 22:36 | |
| *** dave-mccowan has quit IRC | 22:39 | |
| *** sree has quit IRC | 22:40 | |
| *** felipemonteiro_ has joined #openstack-nova | 22:44 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 22:45 |
| *** felipemonteiro has quit IRC | 22:48 | |
| ildikov | mriedem: if you have any homework for me too lemme know otherwise have fun!!! :) | 22:48 |
| *** slaweq has quit IRC | 22:49 | |
| mriedem | can't think of any | 22:50 |
| mriedem | melwitt: i updated the novaclient release patch to depend on the top of the series for the novaclient removal changes, once those are merged we'd just need to modify the hash in the release patch and then that should be good to go | 22:50 |
| *** mriedem has quit IRC | 22:54 | |
| *** AlexeyAbashkin has joined #openstack-nova | 22:54 | |
| *** archit has joined #openstack-nova | 22:55 | |
| *** esberglu has quit IRC | 22:57 | |
| *** slaweq has joined #openstack-nova | 22:58 | |
| *** AlexeyAbashkin has quit IRC | 22:59 | |
| *** figleaf is now known as edleafe | 22:59 | |
| *** harlowja has quit IRC | 23:01 | |
| *** yamamoto has quit IRC | 23:01 | |
| *** slaweq has quit IRC | 23:02 | |
| *** yamamoto has joined #openstack-nova | 23:04 | |
| *** burt has quit IRC | 23:05 | |
| *** sree has joined #openstack-nova | 23:05 | |
| *** eandersson has quit IRC | 23:09 | |
| *** yamamoto has quit IRC | 23:09 | |
| *** eandersson has joined #openstack-nova | 23:09 | |
| *** sree has quit IRC | 23:10 | |
| *** syjulian has quit IRC | 23:11 | |
| *** owalsh has quit IRC | 23:12 | |
| *** owalsh has joined #openstack-nova | 23:12 | |
| *** felipemonteiro_ has quit IRC | 23:17 | |
| *** felipemonteiro_ has joined #openstack-nova | 23:17 | |
| *** syjulian has joined #openstack-nova | 23:19 | |
| *** itlinux has joined #openstack-nova | 23:22 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot https://review.openstack.org/533244 | 23:27 |
| *** suresh12 has quit IRC | 23:30 | |
| *** suresh12 has joined #openstack-nova | 23:31 | |
| *** fried_rice is now known as efried | 23:35 | |
| *** r-daneel has quit IRC | 23:35 | |
| *** suresh12 has quit IRC | 23:36 | |
| *** itlinux has quit IRC | 23:39 | |
| *** sdague has quit IRC | 23:40 | |
| *** Apoorva_ has quit IRC | 23:42 | |
| *** mlavalle has quit IRC | 23:52 | |
| *** hongbin has quit IRC | 23:53 | |
| *** itlinux has joined #openstack-nova | 23:57 | |
| *** sree has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!