| *** ejat has joined #openstack-nova | 00:09 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** sree has joined #openstack-nova | 00:18 | |
| *** comstud has quit IRC | 00:19 | |
| *** claudiub has quit IRC | 00:20 | |
| *** masber has joined #openstack-nova | 00:21 | |
| *** comstud has joined #openstack-nova | 00:22 | |
| *** tbachman has quit IRC | 00:22 | |
| *** masber has quit IRC | 00:29 | |
| *** sree has quit IRC | 00:30 | |
| *** Apoorva has quit IRC | 00:40 | |
| *** tuanla____ has joined #openstack-nova | 00:40 | |
| *** sree has joined #openstack-nova | 00:42 | |
| *** jichen has joined #openstack-nova | 00:50 | |
| *** sree has quit IRC | 00:51 | |
| *** sree has joined #openstack-nova | 00:56 | |
| *** yassine has joined #openstack-nova | 00:56 | |
| *** yassine is now known as Guest20076 | 00:57 | |
| *** ljjjustin has joined #openstack-nova | 01:01 | |
| *** hoangcx has joined #openstack-nova | 01:04 | |
| *** dave-mccowan has joined #openstack-nova | 01:06 | |
| *** phuongnh has joined #openstack-nova | 01:09 | |
| *** yangyapeng has joined #openstack-nova | 01:10 | |
| *** masber has joined #openstack-nova | 01:10 | |
| *** sree has quit IRC | 01:13 | |
| *** jichen_ has joined #openstack-nova | 01:17 | |
| *** jichen has quit IRC | 01:19 | |
| *** jichen_ is now known as jichen | 01:19 | |
| *** liusheng has joined #openstack-nova | 01:19 | |
| *** edmondsw has joined #openstack-nova | 01:21 | |
| *** edmondsw has quit IRC | 01:26 | |
| *** sree has joined #openstack-nova | 01:33 | |
| *** sree has quit IRC | 01:37 | |
| *** leakypipes has quit IRC | 01:39 | |
| *** Rambo has joined #openstack-nova | 01:53 | |
| Rambo | hello,everyone | 01:54 |
|---|---|---|
| *** annp has joined #openstack-nova | 01:54 | |
| Rambo | Can you help me to review it ?The link is https://review.openstack.org/#/c/531524/ | 01:54 |
| Rambo | Another is :https://review.openstack.org/#/c/528740/ | 01:54 |
| Rambo | Thank you very much | 01:54 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration https://review.openstack.org/531633 | 01:55 |
| *** hongbin has joined #openstack-nova | 02:03 | |
| *** jafeha__ has joined #openstack-nova | 02:13 | |
| *** Tom-Tom has joined #openstack-nova | 02:13 | |
| *** jafeha has quit IRC | 02:16 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | 02:17 |
| alex_xu_ | yikun: sorry for reply late https://review.openstack.org/#/c/330406/78/api-ref/source/parameters.yaml@4148 | 02:21 |
| *** liusheng has quit IRC | 02:25 | |
| *** liusheng has joined #openstack-nova | 02:26 | |
| *** Rambo__ has joined #openstack-nova | 02:35 | |
| *** Rambo has quit IRC | 02:36 | |
| *** zhurong has joined #openstack-nova | 02:46 | |
| yikun | alex_xu_, ok, thanks, saw it, I will update and add the uuid on server migrations in this patch. | 02:54 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117 | 03:00 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429 | 03:00 |
| *** sree has joined #openstack-nova | 03:07 | |
| *** hongbin has quit IRC | 03:09 | |
| *** dave-mccowan has quit IRC | 03:09 | |
| *** hongbin has joined #openstack-nova | 03:09 | |
| *** edmondsw has joined #openstack-nova | 03:09 | |
| *** hongbin has quit IRC | 03:10 | |
| *** hongbin has joined #openstack-nova | 03:10 | |
| *** hongbin has quit IRC | 03:10 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration https://review.openstack.org/531633 | 03:11 |
| *** hongbin has joined #openstack-nova | 03:11 | |
| *** hongbin has quit IRC | 03:12 | |
| *** hongbin has joined #openstack-nova | 03:13 | |
| yikun | ^ I submit the separate one, just for convenient reviewing, and if all is ok, I will merge it into parent patch. | 03:13 |
| *** edmondsw has quit IRC | 03:14 | |
| *** hongbin has quit IRC | 03:14 | |
| *** hongbin has joined #openstack-nova | 03:15 | |
| *** amodi has quit IRC | 03:32 | |
| *** abhishekk has joined #openstack-nova | 03:40 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 03:54 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 03:54 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 03:54 |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration https://review.openstack.org/531633 | 03:54 |
| *** yamamoto has joined #openstack-nova | 03:58 | |
| *** Tom-Tom has quit IRC | 04:02 | |
| *** Tom-Tom has joined #openstack-nova | 04:03 | |
| *** yamamoto has quit IRC | 04:03 | |
| *** Tom-Tom has quit IRC | 04:07 | |
| *** pooja_jadhav has joined #openstack-nova | 04:11 | |
| *** hongbin has quit IRC | 04:19 | |
| *** moshele has joined #openstack-nova | 04:39 | |
| *** gcb has joined #openstack-nova | 04:41 | |
| gcb | alex_xu_, could you please help review https://review.openstack.org/528620 a simple adoption of oslo function | 04:43 |
| alex_xu_ | gcb: will check it after lunch | 04:43 |
| *** moshele has quit IRC | 04:44 | |
| *** sridharg has joined #openstack-nova | 04:44 | |
| gcb | alex_xu_: thanks | 04:45 |
| alex_xu_ | gcb: np | 04:45 |
| *** zhurong has quit IRC | 04:52 | |
| *** udesale has joined #openstack-nova | 04:54 | |
| *** edmondsw has joined #openstack-nova | 04:58 | |
| *** edmondsw has quit IRC | 05:02 | |
| *** yamamoto has joined #openstack-nova | 05:04 | |
| *** moshele has joined #openstack-nova | 05:04 | |
| *** bhagyashri_s is now known as bhagyashris | 05:05 | |
| *** yamamoto has quit IRC | 05:12 | |
| *** pooja_jadhav has quit IRC | 05:15 | |
| *** yangyapeng has quit IRC | 05:16 | |
| *** yangyapeng has joined #openstack-nova | 05:17 | |
| *** moshele has quit IRC | 05:18 | |
| *** Tom-Tom has joined #openstack-nova | 05:21 | |
| *** pooja_jadhav has joined #openstack-nova | 05:25 | |
| *** Tom-Tom has quit IRC | 05:25 | |
| *** janki has joined #openstack-nova | 05:28 | |
| *** mikal has quit IRC | 05:33 | |
| *** psachin has joined #openstack-nova | 05:33 | |
| *** shaohe_feng has quit IRC | 05:38 | |
| *** shaohe_feng has joined #openstack-nova | 05:42 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None https://review.openstack.org/530879 | 05:44 |
| *** zhurong has joined #openstack-nova | 05:52 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156 | 05:56 |
| *** Eran_Kuris has joined #openstack-nova | 05:58 | |
| *** Tom-Tom has joined #openstack-nova | 05:59 | |
| *** efried has quit IRC | 06:08 | |
| *** moshele has joined #openstack-nova | 06:09 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601 | 06:10 |
| *** ratailor has joined #openstack-nova | 06:14 | |
| *** liusheng has quit IRC | 06:14 | |
| *** janki has quit IRC | 06:17 | |
| *** janki has joined #openstack-nova | 06:18 | |
| *** efried has joined #openstack-nova | 06:18 | |
| *** bkopilov has joined #openstack-nova | 06:29 | |
| openstackgerrit | Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900 | 06:35 |
| *** khappone has joined #openstack-nova | 06:35 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | 06:37 |
| *** claudiub has joined #openstack-nova | 06:43 | |
| *** udesale__ has joined #openstack-nova | 06:45 | |
| *** edmondsw has joined #openstack-nova | 06:46 | |
| *** udesale has quit IRC | 06:48 | |
| *** edmondsw has quit IRC | 06:50 | |
| bhagyashris | ianw: Hi, are you around ? | 06:52 |
| *** udesale has joined #openstack-nova | 06:52 | |
| *** udesale__ has quit IRC | 06:54 | |
| *** liuyulong has joined #openstack-nova | 06:54 | |
| *** moshele has quit IRC | 07:03 | |
| *** moshele has joined #openstack-nova | 07:03 | |
| *** pcaruana has joined #openstack-nova | 07:04 | |
| *** moshele has quit IRC | 07:06 | |
| *** moshele has joined #openstack-nova | 07:12 | |
| *** Kevin_Zheng has quit IRC | 07:13 | |
| *** knikolla has quit IRC | 07:13 | |
| *** fyxim has quit IRC | 07:13 | |
| *** fyxim_ has joined #openstack-nova | 07:13 | |
| *** knikolla has joined #openstack-nova | 07:13 | |
| *** brad[] has quit IRC | 07:15 | |
| *** gaurangt has quit IRC | 07:15 | |
| *** Kevin_Zheng has joined #openstack-nova | 07:16 | |
| *** gaurangt has joined #openstack-nova | 07:18 | |
| *** tiendc has joined #openstack-nova | 07:20 | |
| *** liusheng has joined #openstack-nova | 07:22 | |
| openstackgerrit | Merged openstack/nova master: Use method validate_integer from oslo.utils https://review.openstack.org/528620 | 07:24 |
| *** moshele has quit IRC | 07:25 | |
| *** moshele has joined #openstack-nova | 07:27 | |
| *** karthiks has joined #openstack-nova | 07:36 | |
| *** rabel_b1 has joined #openstack-nova | 07:46 | |
| openstackgerrit | Sriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number https://review.openstack.org/531674 | 07:51 |
| *** lajoskatona has joined #openstack-nova | 07:56 | |
| *** hrw has joined #openstack-nova | 07:59 | |
| *** sridharg has quit IRC | 07:59 | |
| *** sridharg has joined #openstack-nova | 08:00 | |
| hrw | morning | 08:03 |
| *** jafeha__ has quit IRC | 08:04 | |
| *** sridharg has quit IRC | 08:08 | |
| *** sridharg has joined #openstack-nova | 08:08 | |
| *** tesseract has joined #openstack-nova | 08:09 | |
| *** ralonsoh has joined #openstack-nova | 08:09 | |
| *** namnh has joined #openstack-nova | 08:09 | |
| *** damien_r has joined #openstack-nova | 08:10 | |
| *** weshay has quit IRC | 08:19 | |
| *** trozet has quit IRC | 08:19 | |
| *** markmc has quit IRC | 08:19 | |
| *** lucas-afk has quit IRC | 08:19 | |
| *** sshwarts has joined #openstack-nova | 08:20 | |
| *** weshay has joined #openstack-nova | 08:20 | |
| *** lucasagomes has joined #openstack-nova | 08:20 | |
| *** trozet has joined #openstack-nova | 08:20 | |
| *** rabel__b1 has joined #openstack-nova | 08:23 | |
| *** markmc has joined #openstack-nova | 08:23 | |
| *** rabel_b1 has quit IRC | 08:26 | |
| *** Tom-Tom has quit IRC | 08:30 | |
| *** Tom-Tom has joined #openstack-nova | 08:30 | |
| *** Tom-Tom has quit IRC | 08:31 | |
| *** jafeha has joined #openstack-nova | 08:31 | |
| *** Tom-Tom has joined #openstack-nova | 08:31 | |
| *** edmondsw has joined #openstack-nova | 08:34 | |
| openstackgerrit | Mr Rambo proposed openstack/nova master: Support volume-backed server rebuild https://review.openstack.org/528740 | 08:35 |
| *** damien_r has quit IRC | 08:36 | |
| *** damien_r has joined #openstack-nova | 08:37 | |
| *** moshele has quit IRC | 08:37 | |
| *** moshele has joined #openstack-nova | 08:37 | |
| *** jpena has joined #openstack-nova | 08:38 | |
| *** edmondsw has quit IRC | 08:39 | |
| bauzas | good morning Nova | 08:44 |
| *** sahid has joined #openstack-nova | 08:44 | |
| * bauzas waves back from holidays | 08:44 | |
| gibi_away | good morning bauzas and Nova | 08:44 |
| *** gibi_away is now known as gibi | 08:44 | |
| * gibi just back from vacation too | 08:45 | |
| * bauzas has a thought for operators today | 08:47 | |
| hrw | speadup zuul, speed up... | 08:48 |
| *** rabel_b1 has joined #openstack-nova | 08:53 | |
| *** rabel__b1 has quit IRC | 08:55 | |
| *** ygl has joined #openstack-nova | 08:56 | |
| *** ygl has quit IRC | 09:01 | |
| *** rcernin has quit IRC | 09:07 | |
| *** fragatina has joined #openstack-nova | 09:08 | |
| *** fragatina has quit IRC | 09:08 | |
| bauzas | just in case people wanna give me a Christmas present, here is a series loving reviews https://review.openstack.org/#/c/514763/ | 09:08 |
| bauzas | :) | 09:08 |
| * bauzas working on a last patch for fixing some tech debt problems | 09:09 | |
| *** fragatina has joined #openstack-nova | 09:09 | |
| *** sbezverk has quit IRC | 09:11 | |
| * hrw curses at nova tests | 09:11 | |
| *** owalsh_ is now known as owalsh | 09:15 | |
| *** finucannot is now known as stephenfin | 09:16 | |
| *** ircuser-1 has joined #openstack-nova | 09:18 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | 09:19 |
| *** danpawlik has joined #openstack-nova | 09:23 | |
| *** fragatina has quit IRC | 09:23 | |
| openstackgerrit | Mr Rambo proposed openstack/nova master: Support volume-backed server rebuild https://review.openstack.org/528740 | 09:24 |
| *** john51_ has joined #openstack-nova | 09:44 | |
| *** Tom-Tom_ has joined #openstack-nova | 09:45 | |
| *** udesale has quit IRC | 09:45 | |
| *** aloga has joined #openstack-nova | 09:45 | |
| *** udesale has joined #openstack-nova | 09:46 | |
| *** john51 has quit IRC | 09:46 | |
| *** derekh has joined #openstack-nova | 09:46 | |
| *** Tom-Tom has quit IRC | 09:48 | |
| *** ameeda has joined #openstack-nova | 09:50 | |
| ameeda | hello | 09:50 |
| ameeda | can you please review my code here https://review.openstack.org/#/c/528069/ ? and let me know if I have to consider force_delete and soft_delete | 09:51 |
| *** rabel_b1 has quit IRC | 09:51 | |
| *** rabel_b1 has joined #openstack-nova | 09:51 | |
| *** sahid_ has joined #openstack-nova | 09:56 | |
| *** sahid has quit IRC | 09:56 | |
| *** sree has quit IRC | 10:02 | |
| *** gcb has quit IRC | 10:02 | |
| *** ljjjustin has quit IRC | 10:02 | |
| *** zhurong has quit IRC | 10:02 | |
| *** jichen has quit IRC | 10:03 | |
| *** hoangcx has quit IRC | 10:05 | |
| *** tinwood_ is now known as tinwood | 10:10 | |
| *** hoangcx has joined #openstack-nova | 10:11 | |
| *** cdent has joined #openstack-nova | 10:13 | |
| openstackgerrit | Lajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests https://review.openstack.org/527728 | 10:16 |
| openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rescue https://review.openstack.org/531524 | 10:17 |
| *** Tom-Tom_ has quit IRC | 10:17 | |
| *** namnh has quit IRC | 10:18 | |
| *** Tom-Tom has joined #openstack-nova | 10:18 | |
| *** fragatina has joined #openstack-nova | 10:20 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 10:22 |
| *** edmondsw has joined #openstack-nova | 10:22 | |
| *** Tom-Tom has quit IRC | 10:23 | |
| -openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate | 10:25 | |
| *** edmondsw has quit IRC | 10:27 | |
| *** annp has quit IRC | 10:32 | |
| *** udesale has quit IRC | 10:34 | |
| *** udesale has joined #openstack-nova | 10:35 | |
| *** ygl has joined #openstack-nova | 10:37 | |
| *** ygl has quit IRC | 10:39 | |
| *** sahid_ has quit IRC | 10:40 | |
| *** sahid has joined #openstack-nova | 10:40 | |
| *** ameeda has quit IRC | 10:45 | |
| *** ameeda has joined #openstack-nova | 10:45 | |
| *** phuongnh has quit IRC | 10:46 | |
| openstackgerrit | chenpengzi proposed openstack/nova master: For a pre-generated example of the latest policy.yaml https://review.openstack.org/531713 | 10:48 |
| *** sambetts|afk is now known as sambetts | 10:50 | |
| *** simondodsley has quit IRC | 10:50 | |
| *** simondodsley has joined #openstack-nova | 10:51 | |
| *** jamespage has quit IRC | 10:51 | |
| *** wolsen has quit IRC | 10:51 | |
| *** jamespage has joined #openstack-nova | 10:52 | |
| *** wolsen has joined #openstack-nova | 10:52 | |
| *** udesale has quit IRC | 10:54 | |
| *** moshele has quit IRC | 10:56 | |
| *** moshele has joined #openstack-nova | 10:57 | |
| *** abhishekk has quit IRC | 10:58 | |
| openstackgerrit | chenpengzi proposed openstack/nova master: For a pre-generated example of the latest policy.yaml https://review.openstack.org/531713 | 11:10 |
| *** mvk has quit IRC | 11:20 | |
| *** hoangcx has quit IRC | 11:23 | |
| *** cdent has quit IRC | 11:31 | |
| *** zhurong has joined #openstack-nova | 11:35 | |
| *** smatzek has joined #openstack-nova | 11:40 | |
| *** smatzek has quit IRC | 11:40 | |
| *** smatzek has joined #openstack-nova | 11:40 | |
| openstackgerrit | chenpengzi proposed openstack/nova master: Add reference to policy sample https://review.openstack.org/531713 | 11:41 |
| openstackgerrit | Jianle He proposed openstack/nova-specs master: Back up volume-backed-instance https://review.openstack.org/530214 | 11:45 |
| *** tuanla____ has quit IRC | 11:46 | |
| *** fragatina has quit IRC | 11:54 | |
| *** fragatina has joined #openstack-nova | 11:54 | |
| *** tiendc has quit IRC | 11:55 | |
| *** ratailor has quit IRC | 11:58 | |
| *** jistr is now known as jistr|mtg | 11:58 | |
| *** lucasagomes is now known as lucas-hungry | 12:00 | |
| *** sdague has joined #openstack-nova | 12:00 | |
| gibi | bauzas: left some questions / nits in https://review.openstack.org/#/c/514763/ Merry Christmas! ;) | 12:09 |
| *** cdent has joined #openstack-nova | 12:09 | |
| *** dave-mccowan has joined #openstack-nova | 12:09 | |
| *** edmondsw has joined #openstack-nova | 12:10 | |
| *** gcb has joined #openstack-nova | 12:13 | |
| openstackgerrit | Merged openstack/nova master: Remove 'nova-manage host' and 'nova-manage agent' https://review.openstack.org/521837 | 12:14 |
| *** edmondsw has quit IRC | 12:15 | |
| *** udesale has joined #openstack-nova | 12:16 | |
| ameeda | bauzas: can you please review my code here https://review.openstack.org/#/c/526900/ | 12:20 |
| *** liuyulong has quit IRC | 12:24 | |
| *** janki has quit IRC | 12:24 | |
| *** jpena is now known as jpena|lunch | 12:33 | |
| *** sree has joined #openstack-nova | 12:36 | |
| *** mvk has joined #openstack-nova | 12:37 | |
| *** sree has quit IRC | 12:41 | |
| hrw | stephenfin: https://review.openstack.org/#/c/530965/ got +1 from zuul, has test coverage. can you +2 again? | 12:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/531737 | 12:47 |
| ameeda | Hello | 12:47 |
| *** dave-mccowan has quit IRC | 12:47 | |
| ameeda | I got this error when I run tox -e py27 | 12:48 |
| ameeda | FutureWarning: fake is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See https://docs.openstack.org/oslo.versionedobjects/latest/reference/fields.html#oslo_versionedobjects.fields.UUIDField for further details | 12:48 |
| ameeda | any idea ? | 12:48 |
| *** dave-mccowan has joined #openstack-nova | 12:49 | |
| sean-k-mooney | ameeda: when using oslo versioned objects the validator for uuid fields check that the value is really a uuid. fake is not a uuid hence the error | 12:49 |
| sean-k-mooney | ameeda: is that from https://review.openstack.org/#/c/526900 | 12:49 |
| ameeda | sean-k-mooney: thanks for reply, no its from this https://review.openstack.org/#/c/528385/ when I move my code to _cleanup_volumes and modify the unit test for that | 12:51 |
| ameeda | sean-k-mooney: here is my edit http://paste.openstack.org/show/640858/ | 12:53 |
| sean-k-mooney | oh ok you can use uuidgen on the commandline to generate a uuid for the tests for example e21d0851-3c56-4b9d-a133-a2c1ba59778a whcich you can use instead of fake to resolve the warning | 12:53 |
| *** ktibi has joined #openstack-nova | 12:54 | |
| ameeda | sean-k-mooney: so I should use this uuid inside my code ? since the error appears in another file | 12:54 |
| sean-k-mooney | only if its cause by your code. if the warning is present without your patch you dont need to fix it. | 12:56 |
| ktibi | Hi, do you think it's good if nova doesn't check if neutron have free IP before spawn instance ? | 12:56 |
| ktibi | because I have a strange case where user spawn 200 vms with 50 free IP, and all my compute become disabled with "consecutive_build_service_disable_threshold" | 12:57 |
| sean-k-mooney | ameeda: oslo versioned objects uuid filed not emit this warning if invalid uuids are used but at present its only a warning to allow projects to fix there tests. in the future it will be changed to an error but only once most project have updated there tests | 12:57 |
| *** sahid has quit IRC | 12:58 | |
| ameeda | sean-k-mooney: when I remove my code, the test success completely, and the error appears at another file where I add my code | 12:58 |
| *** moshele has quit IRC | 12:59 | |
| *** sahid has joined #openstack-nova | 12:59 | |
| *** moshele has joined #openstack-nova | 12:59 | |
| sean-k-mooney | ktibi: strictly speaking nova has no requirement that a vm will have an ip. it just requires that vms have mac adressses. | 12:59 |
| *** rcernin has joined #openstack-nova | 13:00 | |
| ameeda | sean-k-mooney: if I do this http://paste.openstack.org/show/640870/ it will success ? | 13:00 |
| sean-k-mooney | ameeda: i would guess that uuids.instance on line 6 of http://paste.openstack.org/show/640858/ is the root of the warning | 13:00 |
| *** zhurong has quit IRC | 13:01 | |
| *** cdent has quit IRC | 13:01 | |
| sean-k-mooney | ameeda: try using e21d0851-3c56-4b9d-a133-a2c1ba59778a instead and see if it resolves the issue | 13:02 |
| ameeda | sean-k-mooney: thanks alot, I will try that and let you know | 13:02 |
| *** yasemin_ has quit IRC | 13:02 | |
| ameeda | sean-k-mooney: I have another issue with openstack overcloud image build in dib, can you help me with that ? | 13:03 |
| sean-k-mooney | ktibi: regarding your issue i dont think the compute nodes should become disabled just because a user ran our of ips in there subnet. was there any error reported in the n-cpu or n-sch logs? | 13:04 |
| ktibi | sean-k-mooney so, with the default value for consecutive_build_service_disable_threshold, any user can disable all compute ? | 13:04 |
| *** hieulq has quit IRC | 13:04 | |
| *** hieulq has joined #openstack-nova | 13:05 | |
| *** lucas-hungry is now known as lucasagomes | 13:05 | |
| sean-k-mooney | ktibi: interesting looks like that is a new option in pike https://review.openstack.org/#/c/463597/ | 13:06 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Fix possible TypeError in VIF.fixed_ips https://review.openstack.org/531745 | 13:06 |
| sean-k-mooney | ktibi: it is intended to disable a compute node if there is an issue with the hypervisor like libvirt crashed or something like that. this would seam to be an edgecase | 13:06 |
| ktibi | compute node fail to spawn instance with error ==>Failed to allocate the network(s), not rescheduling | 13:07 |
| bauzas | gibi: thanks for the review, will upload a new change in 1 hour-ish | 13:07 |
| *** moshele has quit IRC | 13:07 | |
| ktibi | sean-k-mooney user spawn 200 instances, so I have 20 fail on each compute, all my compte become disable !! very dangerous !! | 13:08 |
| sean-k-mooney | ktibi: as a work around you can set the config value to 0 to disable auto disable. | 13:08 |
| ktibi | I think this option need to be disable by default | 13:08 |
| *** cdent has joined #openstack-nova | 13:09 | |
| sean-k-mooney | ktibi: i actully tend to agree that this probably should not be enabled by default. that said i understand why you might want this | 13:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ocata: Fix possible TypeError in VIF.fixed_ips https://review.openstack.org/531746 | 13:10 |
| *** Tom-Tom has joined #openstack-nova | 13:11 | |
| ameeda | sean-k-mooney: same error after change instance.uuids to e21d0851-3c56-4b9d-a133-a2c1ba59778a . see the error here http://paste.openstack.org/show/640881/ | 13:11 |
| sean-k-mooney | stephenfin regarding https://review.openstack.org/#/c/463597/6 do you recall why consecutive_build_service_disable_threshold is not disabled by default. | 13:12 |
| *** sree has joined #openstack-nova | 13:13 | |
| *** lajoskatona has left #openstack-nova | 13:14 | |
| *** rcernin has quit IRC | 13:16 | |
| *** vladikr has joined #openstack-nova | 13:16 | |
| sean-k-mooney | ameeda: so it looke like the varning changed form fake is an invalid UUID to fake_vol so im guessing the volume id is not set in the bdms object | 13:22 |
| sean-k-mooney | ameeda: you are extending https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_mgr.py#L278-L304 | 13:22 |
| *** ratailor has joined #openstack-nova | 13:22 | |
| *** ratailor has quit IRC | 13:23 | |
| *** ygl has joined #openstack-nova | 13:24 | |
| *** pcaruana has quit IRC | 13:25 | |
| ameeda | sean-k-mooney: I try to do this http://paste.openstack.org/show/640891/, but it show me error said that instance doesn't has get_by_uuid attribute. | 13:25 |
| *** liverpooler has joined #openstack-nova | 13:25 | |
| *** pcaruana has joined #openstack-nova | 13:25 | |
| ameeda | sean-k-mooney: what you guess me to do ? if I remove my changes, everything working fine | 13:27 |
| *** cleong has joined #openstack-nova | 13:28 | |
| *** yamamoto has joined #openstack-nova | 13:28 | |
| ameeda | sean-k-mooney: when I do this http://paste.openstack.org/show/640894/ "note line 5" that will work fine. | 13:30 |
| sean-k-mooney | ameeda: am i have to run to a meeting sorry. | 13:30 |
| *** jackie-truong has joined #openstack-nova | 13:30 | |
| ameeda | sean-k-mooney: no worries. thanks for your time :) | 13:30 |
| stephenfin | sean-k-mooney: If I recall correctly, it's something to do with lack of upcall support with a cells v2 deployment | 13:31 |
| *** jpena|lunch is now known as jpena | 13:31 | |
| stephenfin | or because it happened often enough to warrant enabling that feature by default | 13:31 |
| stephenfin | I don't really recall, tbh :/ | 13:32 |
| *** jistr|mtg is now known as jistr | 13:35 | |
| *** diga has joined #openstack-nova | 13:36 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 13:41 |
| ygl | sean-k-mooney: hi, I need some help on nova | 13:41 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | 13:41 |
| *** sree has quit IRC | 13:41 | |
| *** sree has joined #openstack-nova | 13:41 | |
| ygl | stephenfin: hi, i need some help on nova | 13:42 |
| *** moshele has joined #openstack-nova | 13:45 | |
| *** sree has quit IRC | 13:46 | |
| ktibi | stephenfin sean-k-mooney I guess we have two solutions : 1/ disable by default this features 2/ change the detection which inscrease the trigger by detect only fail or error which does not concern quota or free IP | 13:47 |
| *** READ10 has joined #openstack-nova | 13:47 | |
| stephenfin | ktibi: IMO, you'd be better waiting for dansmith and/or mriedem to pop up in an hour or two. I don't think you're the first person to have issues with this | 13:48 |
| ktibi | because for now, I can disable all compute on a fresh install !! with a simple user. Create a network with 20 IP and spawn 90 instances ! | 13:48 |
| *** brault has joined #openstack-nova | 13:48 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763 | 13:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance https://review.openstack.org/528832 | 13:50 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt : Force a specificly static UUID for a mediated device https://review.openstack.org/531752 | 13:50 |
| *** edmondsw has joined #openstack-nova | 13:51 | |
| *** bhagyashris has quit IRC | 13:52 | |
| hrw | stephenfin: hello ;) | 13:53 |
| *** jaypipes has joined #openstack-nova | 13:55 | |
| *** yamamoto has quit IRC | 13:56 | |
| efried | Scheduler meeting in 4 minutes in #openstack-meeting-alt | 13:56 |
| bauzas | damn, needs coffee then | 13:57 |
| *** yamamoto has joined #openstack-nova | 13:57 | |
| *** takashin has joined #openstack-nova | 13:57 | |
| *** bhagyashris has joined #openstack-nova | 14:01 | |
| *** yamamoto has quit IRC | 14:01 | |
| *** Rambo__ has quit IRC | 14:01 | |
| *** esberglu has joined #openstack-nova | 14:03 | |
| *** fragatina has quit IRC | 14:11 | |
| *** fragatina has joined #openstack-nova | 14:11 | |
| *** yangyapeng has quit IRC | 14:11 | |
| *** stvnoyes has joined #openstack-nova | 14:12 | |
| *** lyan has joined #openstack-nova | 14:13 | |
| *** mriedem has joined #openstack-nova | 14:14 | |
| *** esberglu has quit IRC | 14:17 | |
| *** esberglu has joined #openstack-nova | 14:17 | |
| *** jmlowe has quit IRC | 14:19 | |
| *** smatzek has quit IRC | 14:21 | |
| *** esberglu has quit IRC | 14:22 | |
| *** eharney has joined #openstack-nova | 14:24 | |
| *** ygl has quit IRC | 14:28 | |
| *** lpetrut has joined #openstack-nova | 14:31 | |
| *** esberglu has joined #openstack-nova | 14:32 | |
| *** esberglu_ has joined #openstack-nova | 14:33 | |
| *** esberglu_ is now known as esberglu__ | 14:34 | |
| *** esberglu has quit IRC | 14:37 | |
| *** burt has joined #openstack-nova | 14:38 | |
| *** yamamoto has joined #openstack-nova | 14:42 | |
| *** psachin has quit IRC | 14:45 | |
| *** yamamoto has quit IRC | 14:47 | |
| *** AlexeyAbashkin has joined #openstack-nova | 14:53 | |
| *** yasemin has joined #openstack-nova | 14:54 | |
| *** esberglu__ is now known as esberglu | 14:54 | |
| openstackgerrit | Merged openstack/nova master: Add index on token_hash and instance_uuid for console_auth_tokens https://review.openstack.org/531477 | 14:55 |
| *** yamahata has joined #openstack-nova | 14:56 | |
| *** awaugama has joined #openstack-nova | 14:58 | |
| *** yangyapeng has joined #openstack-nova | 14:59 | |
| *** hongbin has joined #openstack-nova | 15:01 | |
| efried | cdent Yes, if update_provider_tree comes back with a provider removed, that means report client needs to delete that provider. | 15:01 |
| cdent | efried, jaypipes it would be great if we could do some of this discussion in email, so the results end up somewhere digestible. but if that's no good, we can carry on here (I'm in cafe land again, so don't want to hang out, now, but could another time) | 15:01 |
| *** Guest8485 is now known as dansmith | 15:02 | |
| cdent | doesn't it mean instead that it is not used in this context? If we're including sharing providers in the ProviderTree, is there weirdness? I don't know, it's hard to think about in the abstract, and without whiteboards etc | 15:02 |
| *** dansmith is now known as Guest62501 | 15:02 | |
| mriedem | yikun: https://review.openstack.org/#/c/531633/ looks ok once some nits are addressed and you can squash it into https://review.openstack.org/#/c/330406/ | 15:03 |
| *** sdague has quit IRC | 15:04 | |
| efried | cdent Yeah, that's a place we'll have to tread carefully. If a virt decides it's no longer going to be associated with a sharing provider, it should remove itself from that aggregate... but should it also remove that provider? | 15:04 |
| jaypipes | efried: if the provider is gone, then yeah. | 15:05 |
| jaypipes | efried: but if the virt driver doesn't *own* that provider, then no. | 15:05 |
| *** Guest62501 is now known as dansmith | 15:05 | |
| jaypipes | efried: I think this is highly dependent on the virt driver. | 15:05 |
| efried | jaypipes What does "own" mean? | 15:05 |
| jaypipes | efried: in the case of vCenter and PowerVM, the virt driver "owns" these shared pools of resources, right? so the virt driver can delete them. | 15:05 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 15:05 |
| efried | jaypipes But how does the driver know it's the last one associated with the sharing provider? | 15:06 |
| jaypipes | efried: but for libvirt, it doesn't own any sharing providers. something else does and therefore it shouldn't delete sharing providers. | 15:06 |
| jaypipes | efried: that's up to you, baby. | 15:06 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 15:06 |
| efried | jaypipes Without talking to placement... | 15:06 |
| jaypipes | efried: powervm and vcenter, being virt drivers for clustered resource nodes, are going to have to handle that on their own. | 15:07 |
| jaypipes | efried: zookeeper maybe? I don't know :) | 15:07 |
| cdent | of just talk to the local third party agent which is talking to placement anyway, even though nova want "let" them | 15:07 |
| cdent | s/want/won't/ | 15:07 |
| mriedem | vcenter is no longer a clustered thing right? and powervm never was | 15:08 |
| mriedem | ironic is our only 1:M virt driver | 15:08 |
| efried | mriedem Clustered shared storage pool | 15:08 |
| mriedem | oh | 15:08 |
| efried | The quintessential shared provider case. | 15:08 |
| mriedem | how would that not also affect libvirt? | 15:09 |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 15:09 |
| mriedem | if you're using NFS or Ceph for local disk/ | 15:09 |
| mriedem | ? | 15:09 |
| *** sbezverk has joined #openstack-nova | 15:09 | |
| efried | mriedem I think because those guys are going to manage the shared provider from some other control point. | 15:10 |
| cdent | mriedem: indeed. the assumption has been that "something else" is managing in that context, but I'm not sure we've really thought it all the way through | 15:10 |
| efried | mriedem PowerVM (and apparently vCenter) are planning to manage the shared provider from virt. | 15:10 |
| *** gouthamr has joined #openstack-nova | 15:11 | |
| mriedem | oh | 15:12 |
| *** AlexeyAbashkin has quit IRC | 15:13 | |
| mriedem | why do we care about shared storage providers right now? | 15:13 |
| mriedem | because of some design point being discussed in queens? | 15:13 |
| efried | mriedem Good question. | 15:13 |
| *** smatzek has joined #openstack-nova | 15:15 | |
| efried | We've had some shared provider code in the codebase for a couple of releases, so we've been dragging it along and keeping it "working" as we've been tackling NRP et al. | 15:15 |
| *** smatzek has quit IRC | 15:15 | |
| *** smatzek has joined #openstack-nova | 15:15 | |
| *** smatzek has quit IRC | 15:15 | |
| *** felipemonteiro has joined #openstack-nova | 15:15 | |
| efried | But if we're looking for opportunities to limit scope, we did agree not to implement/declare shared provider support in Q. | 15:15 |
| *** smatzek has joined #openstack-nova | 15:16 | |
| cdent | I think it is coming up because it was a nodal point in the discussion about whether virt drivers can or should be able to talk to placement themselves | 15:16 |
| mriedem | we don't need to intentionally make something not work in the future, but for places where we expect we'll need to change things later for shared providers to work, we should just leave TODOs - dansmith did some of that with the migration allocation swap series | 15:16 |
| efried | cdent Agree. But the question remains: do we need to solve this in Q? | 15:16 |
| *** Apoorva has joined #openstack-nova | 15:17 | |
| cdent | I don't think we _have_ to, no | 15:17 |
| cdent | But it often feels kike we push off design discussion too often | 15:17 |
| mriedem | edleafe: on https://review.openstack.org/#/c/531405/ - i pulled that down and made these changes http://paste.openstack.org/show/640953/ - if you don't think those are terrible, i could push those up | 15:17 |
| mriedem | maybe CastAsCall isn't something we really want to use since it masks real api behavior that the user would see | 15:18 |
| mriedem | cdent: we also have a tendency to over design and not get anything done | 15:18 |
| *** amodi has joined #openstack-nova | 15:19 | |
| cdent | efried: I need to change locations. I hope we can continue touching on this over time, but agree in the short term that shared providers is not something we're going to finish this cycle | 15:19 |
| mriedem | s/finish/even spend time on/ | 15:19 |
| efried | cdent Buzz me when you get back on, want to continue discussion. | 15:19 |
| cdent | mriedem: can you say that while simultaneously affirming that we merge more code than any other openstack project :) | 15:19 |
| cdent | efried: will do | 15:20 |
| *** ktibi has quit IRC | 15:20 | |
| mriedem | i don't know how much code we merge relative to other projects | 15:20 |
| *** cdent has quit IRC | 15:20 | |
| efried | Perpetual challenge to strike the right balance. I don't think it's a systemic problem in either direction; just needs to be managed on a case-by-case. | 15:21 |
| mriedem | i'm just commenting from the sidelines as i haven't been involved in coding or reviewing the NRP series, | 15:23 |
| mriedem | i'm just concerned that we're spending a lot of time designing the end thing right now and we'll miss the boat on getting anything functional in queens | 15:24 |
| efried | mriedem Well, we've already landed a *lot* of functional stuff in queens. And I think we're on track to get the rest done. (That was specifically brought up and agreed in the sched meeting.) | 15:24 |
| mriedem | i'm going to try and wrap up the series of changes i've been pushing/reviewing for the last few weeks to get done this week b/c i'm out next week | 15:25 |
| *** jmlowe has joined #openstack-nova | 15:25 | |
| mriedem | bauzas: are you back to help review stuff this week? | 15:26 |
| *** yamamoto has joined #openstack-nova | 15:27 | |
| *** eharney has quit IRC | 15:29 | |
| *** SamYaple_ has quit IRC | 15:30 | |
| *** SamYaple has joined #openstack-nova | 15:30 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/531233/ - FYI the bugfix from before the break | 15:30 |
| *** moshele has quit IRC | 15:30 | |
| mdbooth | lyarwood: Yes | 15:31 |
| *** rmart04 has joined #openstack-nova | 15:31 | |
| mdbooth | lyarwood: IIRC I preferred to attach/detach encryptors in attach/detach volume? | 15:32 |
| mdbooth | Because those 2 things should always happen together | 15:32 |
| *** yamamoto has quit IRC | 15:32 | |
| lyarwood | mdbooth: yeah I think the issue with that was wiring the request context into yet more places | 15:33 |
| *** takashin has quit IRC | 15:33 | |
| mdbooth | lyarwood: Well lets wire away, because the alternative is a trickle of bugs | 15:34 |
| mdbooth | It's probably not that many | 15:34 |
| *** diga has quit IRC | 15:34 | |
| mdbooth | Hmm, I thought I had some notes on this. | 15:35 |
| mdbooth | lyarwood: I literally just finished what I was doing earlier. Let me grab a coffee and look hard at this again. | 15:35 |
| lyarwood | mdbooth: kk, the refactor is the patch below this btw | 15:35 |
| mriedem | dansmith: want to hit this backport again? https://review.openstack.org/#/c/530982/ | 15:37 |
| dansmith | you know I do | 15:37 |
| hrw | mriedem: hello | 15:37 |
| hrw | mriedem: https://review.openstack.org/#/c/530965/ got +1 from Zuul ;) | 15:38 |
| mriedem | +2 again | 15:39 |
| hrw | thanks mriedem | 15:41 |
| hrw | stephenfin: your turn then ;D | 15:41 |
| *** ktibi has joined #openstack-nova | 15:42 | |
| stephenfin | hrw: and +W here | 15:43 |
| *** ameeda has quit IRC | 15:43 | |
| *** mlavalle has joined #openstack-nova | 15:43 | |
| stephenfin | Cheers for the quick follow-ups on that, hrw | 15:43 |
| hrw | stephenfin: ;) | 15:44 |
| hrw | stephenfin: like I said yesterday - it help keeping reviewers attention ;D | 15:44 |
| * hrw bbl | 15:45 | |
| *** nicolasbock has joined #openstack-nova | 15:45 | |
| openstackgerrit | Merged openstack/nova master: Optionalize instance_uuid in console_auth_token_get_valid() https://review.openstack.org/481700 | 15:47 |
| openstackgerrit | Merged openstack/nova master: Add ConsoleAuthToken object https://review.openstack.org/320063 | 15:47 |
| *** tidwellr has joined #openstack-nova | 15:47 | |
| *** gcb has quit IRC | 15:48 | |
| *** cfriesen has quit IRC | 15:49 | |
| *** Tom-Tom has quit IRC | 15:52 | |
| *** yamamoto has joined #openstack-nova | 15:53 | |
| *** yamamoto has quit IRC | 15:53 | |
| *** Tom-Tom has joined #openstack-nova | 15:53 | |
| *** matrohon has joined #openstack-nova | 15:53 | |
| *** felipemonteiro has quit IRC | 15:54 | |
| *** felipemonteiro has joined #openstack-nova | 15:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for resize failing during retries https://review.openstack.org/531405 | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race condition in retrying migrations https://review.openstack.org/531022 | 15:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | 15:55 |
| mriedem | edleafe: addressed my nits in the regression test patch, and fixed my -1 in the regression bug fix patch in the middle, rebased the series to master also ^ | 15:55 |
| matrohon | mriedem: hi | 15:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fixup! console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/531833 | 15:56 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Send bytes to sockets https://review.openstack.org/531834 | 15:56 |
| stephenfin | Oops | 15:57 |
| *** Tom-Tom has quit IRC | 15:57 | |
| *** SamYaple has quit IRC | 15:57 | |
| *** SamYaple has joined #openstack-nova | 15:57 | |
| mdbooth | Hehe | 15:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 15:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 15:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation https://review.openstack.org/345399 | 15:58 |
| *** SamYaple has quit IRC | 15:58 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | 15:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: Send bytes to sockets https://review.openstack.org/531834 | 15:58 |
| mriedem | matrohon: hi | 15:58 |
| *** SamYaple has joined #openstack-nova | 15:58 | |
| mriedem | dansmith: i'm +2 on edleafe's fix for the cold migration + reschedule regression (and the test patch below it) https://review.openstack.org/#/c/531022/ | 15:58 |
| matrohon | mriedem: I was trying to boot a VM without an IP, but I can't find a way to do so | 15:59 |
| mriedem | matrohon: use at least microversion 2.37 to create the server and pass networks='none' | 16:00 |
| mriedem | see the 'networks' parameter here https://developer.openstack.org/api-ref/compute/#create-server | 16:00 |
| matrohon | mriedem: great! I reported a related bug, but I'll try it the way you mention | 16:01 |
| matrohon | mriedem: However, I'm not sur my bug is pointless : https://bugs.launchpad.net/nova/+bug/1741575 | 16:01 |
| openstack | Launchpad bug 1741575 in OpenStack Compute (nova) "creating a VM without IP (ip_allocation=None)" [Undecided,New] | 16:01 |
| mriedem | matrohon: yeah https://bugs.launchpad.net/nova/+bug/1741575 is something else | 16:02 |
| *** AlexeyAbashkin has joined #openstack-nova | 16:02 | |
| mdbooth | lyarwood: Ah, yes | 16:02 |
| mdbooth | lyarwood: So, we call _connect_volume in _get_guest_xml, which is pretty unambigously a bug | 16:03 |
| *** rmart04 has quit IRC | 16:03 | |
| mdbooth | But it's a bug we rely on in a couple of places | 16:03 |
| mdbooth | I have some notes I made before the break about how to unwind that | 16:03 |
| mdbooth | Apart from that, we'd need context in swap_volume | 16:05 |
| matrohon | mriedem: I briefly discussed with carl_baldwin a long time ago, how told me he didn't finished the job on the nova side. At least, he didn't submit anything related to the case where "ip_allocation=none". | 16:05 |
| lyarwood | mdbooth: for the bugfix I'm now providing that | 16:05 |
| mdbooth | lyarwood: Which... we do anyway. Doesn't look like we're handling encryptors there. | 16:05 |
| *** chyka has joined #openstack-nova | 16:05 | |
| mdbooth | _create_domain_setup_lxc() | 16:05 |
| *** sridharg has quit IRC | 16:06 | |
| mdbooth | lyarwood: pre_live_migration() ? | 16:06 |
| *** AlexeyAbashkin has quit IRC | 16:06 | |
| mdbooth | I don't immediately see where we're attaching encryptors there | 16:07 |
| mdbooth | So my vote would be: | 16:07 |
| mdbooth | 1. unpick _connect_volume() in _get_guest_xml() | 16:08 |
| mdbooth | 2. pass context to swap_volume() | 16:08 |
| mdbooth | 3. Implement ajttach/detach encryptors in LibvirtDriver._connect/disconnect_volume | 16:08 |
| lyarwood | urgh, 1 would make this a risk to backport | 16:09 |
| mdbooth | Then we can be reasonably confident that we caught all the cases, and nobody will introduce any more in the future. | 16:09 |
| *** cdent has joined #openstack-nova | 16:09 | |
| mdbooth | lyarwood: I don't think it's as bad as you think | 16:09 |
| lyarwood | also another reason not to do this for the bugfix would be the change in error handling | 16:09 |
| lyarwood | we often don't connect/disconnect in the same try block as attaching/detaching encryptors | 16:09 |
| mdbooth | Well we should... | 16:10 |
| lyarwood | yeah agreed, but that's not part of this bugfix | 16:10 |
| mdbooth | That's only going to simplify error handling, no? | 16:10 |
| dansmith | mriedem: okay I'm going through bauzas' gpu set and then will circle back to that | 16:10 |
| lyarwood | mdbooth: yeah but the _get_guest_xml() cleanup and merging attach/detach encryptors into connect/disconnect volume just seems way over the top for a simple, easily backportable fix for swap_volume tbh | 16:11 |
| mdbooth | lyarwood: I don't think a 'proper' fix is all that messy in this case. My concern is that if we apply 4 more bits of band-aid we won't ever fix it. | 16:11 |
| cdent | efried: i'm back, for a while | 16:12 |
| mdbooth | What about pre_live_migration()? | 16:12 |
| lyarwood | mdbooth: it's hardly band-aid | 16:12 |
| mdbooth | Are we handling that somewhere else? | 16:12 |
| efried | cdent I'm writing up a summary and adding it to the review (https://review.openstack.org/#/c/526539/) | 16:12 |
| cdent | efried++ | 16:12 |
| lyarwood | mdbooth: https://bugs.launchpad.net/nova/+bug/1633033 - sorry that took a little digging | 16:15 |
| openstack | Launchpad bug 1633033 in OpenStack Compute (nova) "live migration with encrypted volume fails" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood) | 16:15 |
| mdbooth | lyarwood: Ok, so looks like that's broken too, same root cause | 16:16 |
| lyarwood | yup | 16:16 |
| mriedem | lyarwood: mdbooth: why don't you do the short-term backportable fix and then do the refactor on master which isn't backported? | 16:16 |
| mriedem | don't refactor a bunch of code that you're going to backport | 16:16 |
| mdbooth | Looking back over my notes, actually I think the _get_guest_xml fix is really easy | 16:16 |
| lyarwood | mriedem: I'm trying to suggest that, I really don't want to play around with _get_guest_xml in backports | 16:17 |
| mdbooth | lyarwood: The reason is that everywhere that calls _get_guest_xml either subsequently calls _create_domain_and_network, or doesn't pass block_device_info, so doesn't call _connect_volume | 16:17 |
| mdbooth | Which means that all you need to do is move _connect_volume from _get_guest_xml to _create_domain_and_network | 16:18 |
| mdbooth | Which is also totally intuitive | 16:18 |
| mdbooth | I've audited ^^^, but feel free to do the same | 16:18 |
| *** brad[] has joined #openstack-nova | 16:18 | |
| mdbooth | _create_domain_and_network already has context, which also makes sense | 16:18 |
| mdbooth | So that change isn't going to be invasive at all | 16:19 |
| matrohon | mriedem: I'm not sure networks=none would help me. My VM needs a port, but a port without IP. | 16:19 |
| mriedem | matrohon: yeah it won't | 16:19 |
| mriedem | networks=none means no ports | 16:19 |
| mriedem | i didn't know about ip_allocation='none' | 16:19 |
| mdbooth | lyarwood: Whatever way you look at it, we need context in swap_volume anyway | 16:20 |
| mdbooth | So that part needs to be done anyway | 16:20 |
| lyarwood | mdbooth: and is in the bugfix | 16:20 |
| mdbooth | lyarwood: I don't see it in that review stack | 16:20 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/531233/3/nova/virt/libvirt/driver.py | 16:20 |
| mdbooth | NP, now I do | 16:20 |
| matrohon | mriedem: ok, I can work on fixing 1741575, with the attached patch as a first step | 16:21 |
| mdbooth | lyarwood: Ok, that bit's already done. | 16:21 |
| *** armax has joined #openstack-nova | 16:21 | |
| mdbooth | With those bits in place, moving the encryptor call into _connect/_disconnect is trivial | 16:21 |
| mdbooth | And no harder to backport | 16:21 |
| mdbooth | And also fixes pre_live_migration | 16:21 |
| mdbooth | And anything else we missed | 16:22 |
| mdbooth | Does lxc have encryptors? | 16:22 |
| matrohon | mriedem: do you think I need something else than the bug report to start submitting code review? | 16:23 |
| lyarwood | mdbooth: well, the frontend encryptors are host level so yeah, I can't see why not. | 16:23 |
| lyarwood | mdbooth: not that they are tested anywhere. | 16:23 |
| mdbooth | lyarwood: Ok, that's probably a bug too, then | 16:23 |
| mdbooth | So it's a 3 for 1 fix | 16:23 |
| *** sshwarts has quit IRC | 16:24 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 16:24 |
| lyarwood | mdbooth: right, I'll respin without moving _connect_volume out of _get_guest_xml | 16:24 |
| mdbooth | I don't think you can do that | 16:24 |
| lyarwood | right, context | 16:24 |
| mdbooth | Actually it's already there | 16:25 |
| mdbooth | But you'd have to remove the encryptor stuff from _create_domain_and_network | 16:25 |
| mdbooth | Which is just backwards | 16:25 |
| mriedem | matrohon: no | 16:25 |
| mdbooth | Might as well go the other way | 16:25 |
| mriedem | bug fix is fine | 16:25 |
| matrohon | mriedem: ack, thanks | 16:25 |
| mriedem | matrohon: but i looked at the patch and it doesn't really make sense to me, unless a port with ip_allocation='none' results in port.get('ip_allocation') == None? | 16:25 |
| efried | jaypipes cdent What is the behavior when I try to delete a provider that has "stuff" associated with it? | 16:27 |
| *** krtaylor has quit IRC | 16:27 | |
| efried | I think I've seen some cases where we automatically delete the "stuff" and some where we bounce. | 16:27 |
| *** felipemonteiro has quit IRC | 16:27 | |
| *** krtaylor_ has joined #openstack-nova | 16:27 | |
| cdent | fails, if there are allocations we bounce | 16:27 |
| matrohon | mriedem: port.get('ip_allocation') == None is the unexpected result, I'm currently trying to find the reason why. I probably need to fix that first on the neutron side | 16:27 |
| cdent | I think that's the only one, but let confirm | 16:27 |
| efried | cdent I'm talking about inventory, aggregates, traits - but most especially aggregates at the moment. | 16:28 |
| *** kumarmn has joined #openstack-nova | 16:29 | |
| jaypipes | efried: we just delete. | 16:29 |
| jaypipes | efried: allocations are the only thing that prevents deletion (and child providers) | 16:29 |
| mriedem | matrohon: if neutron needs changes to support this case, then things get sticky with regards to interoperability | 16:29 |
| cdent | efried: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L816 | 16:29 |
| efried | jaypipes Okay. So this is tricky. | 16:29 |
| mriedem | because if you upgrade nova to handle this none scenario but neutron doesn't support it, things fail, and vice-versa | 16:29 |
| *** kumarmn has left #openstack-nova | 16:29 | |
| efried | cdent Thanks, it's all right there! | 16:30 |
| *** udesale has quit IRC | 16:30 | |
| edleafe | mriedem: just getting caught up (sitting in traffic is *so* productive!) | 16:31 |
| edleafe | mriedem: your changes look fine | 16:31 |
| edleafe | mriedem: some of the issues you asked about on the review were from the original test, which was supposed to test alternate host usage; hence the 4 computes and such | 16:32 |
| matrohon | mriedem: but ip_allocation | 16:33 |
| edleafe | I'm going to add that test to the resize patch | 16:33 |
| matrohon | mriedem: sorry | 16:33 |
| efried | cdent jaypipes So this might be okay. A virt that's "leaving" an aggregate should only delete the aggregate association from self, not delete it from the aggregate or delete the shared provider. The sharing provider will still show up in the ProviderTree, so report client won't delete it. Then the next time we pull the compute RP and its associations, that sharing provider will be absent (because no longer associated by a | 16:33 |
| efried | ggregate) so we'll... drop it from the local provider tree at that time, somehow. | 16:33 |
| *** jistr is now known as jistr|off|mtg | 16:33 | |
| mriedem | edleafe: add the test to the resize patch? | 16:33 |
| mriedem | edleafe: the test is already there since it comes before it in the series | 16:33 |
| edleafe | mriedem: the regression test really doesn | 16:33 |
| edleafe | doesn't check that the alternate hosts stuff is working as expected | 16:34 |
| edleafe | just that it doesn't blow up :) | 16:34 |
| cdent | efried: I think that sounds right, but as your patient, I'm going to the bath, will bbl | 16:34 |
| mriedem | so you're going to modify the regresssion test to add to it in the resize patch | 16:34 |
| efried | cdent Enjoy | 16:34 |
| edleafe | mriedem: no, more or less copy parts to make a new functional test that's alternate host-specific | 16:35 |
| ktibi | dansmith Hi do you know why consecutive_build_service_disable_threshold default value is 10 ? | 16:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 16:35 |
| *** cdent has quit IRC | 16:35 | |
| ktibi | because I found a method for disable all compute service with a simple user :/ | 16:35 |
| matrohon | mriedem: I'll keep on digging on the neutron side first, since not having the ip_allocation field set in port's attributes retrieved by a REST request, when it is explicitly set in the database is not really clean | 16:35 |
| dansmith | ktibi: yes, because I set it to 10 after discussion in the room with a bunch of operators | 16:36 |
| matrohon | mriedem: don't you think? | 16:36 |
| mriedem | matrohon: i agree that None != unset and there are differences in client side behavior potentially, yes | 16:36 |
| dansmith | ktibi: what's the method? might be something we need to exclude from the disable logic if it's not really a fault | 16:36 |
| mriedem | matrohon: but i don't really know how that's all used on the neutron side | 16:36 |
| ktibi | ok, 10 is good but for now, you can fool nova for disable all compute | 16:37 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Don't connect volumes in _get_guest_storage_config https://review.openstack.org/531852 | 16:37 |
| jaypipes | efried: yeah, that sounds about right to me, too. | 16:37 |
| mdbooth | lyarwood: ^^^ | 16:37 |
| efried | jaypipes Dangit, that still leaves us with orphan-able shared providers. | 16:37 |
| mdbooth | lyarwood: Lets see how that does against tempest, but that change would be extremely backportable | 16:37 |
| mriedem | ktibi: perhaps you'd like to share how users can do that | 16:38 |
| efried | (aside from being asymmetrical) | 16:38 |
| ktibi | dansmith if you spawn multi instances in a network with 0 free IP, nova fail to spawn and increase the trigger. if you deploy ~60 instances, you disable 6 computes | 16:38 |
| dansmith | ktibi: what's the method? | 16:38 |
| matrohon | mriedem: I'll have a look, but AFAIK, routed networks is the only feature really using the ip_allocation field for now | 16:38 |
| *** kmalloc has joined #openstack-nova | 16:38 | |
| ktibi | one user disable my 15 computes with spawn 200 instance on a /28 private network | 16:38 |
| jaypipes | efried: don't worry about that too much. | 16:39 |
| dansmith | ktibi: if you only have 6 computes or are packing tight I guess, but remember it has to be consecutive, so a cloud with reasonable activity will not suffer from that | 16:39 |
| jaypipes | efried: let's focus on the nested providers handling. | 16:39 |
| dansmith | ktibi: but if there's something we can catch about that specific case and not count it in the total, that would make sense | 16:39 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Use only existing mdevs if kernel race https://review.openstack.org/531853 | 16:39 |
| *** gyee has joined #openstack-nova | 16:39 | |
| jaypipes | efried: orphaned stuff can always be cleaned up by an external perioidic. | 16:39 |
| mdbooth | lyarwood: The importance of ^^^ is that the above is where we currently do connect_volume/attach_encryptors separately somewhat deliberately. We fix that, then everything remaining is a bug. | 16:39 |
| efried | jaypipes Ick. But okay. Guess that's not the worst thing in the world. | 16:40 |
| mriedem | ktibi: what is the error you get in the compute? PortLimitExceeded? | 16:40 |
| mriedem | the api should be checking the port quota based on the number of instances and selected network before doing scheduling | 16:40 |
| bauzas | dansmith: thanks for the reviews :) | 16:40 |
| mriedem | which is racy, but still it's a check that happens | 16:40 |
| bauzas | dansmith: I just added a new WIP change that will see the direction for the kernel race | 16:40 |
| ktibi | mriedem ailed to allocate the network(s), not rescheduling | 16:40 |
| *** Eran_Kuris has quit IRC | 16:41 | |
| mriedem | ktibi: yeah, but wondering what triggers that, a specific exception | 16:41 |
| ktibi | not quota check :/ just no more IP free in the pool | 16:41 |
| mriedem | do you have a stacktrace you can put in a paste? | 16:41 |
| ktibi | yep wait plz | 16:41 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix typo in release note https://review.openstack.org/531854 | 16:41 |
| mriedem | NoMoreFixedIps ? | 16:41 |
| ktibi | yes | 16:41 |
| bauzas | dansmith: I'll also add a follow-up that will try to find the existing mdev 'allocations' (ie. which mdev is used by which instance) at init_host() | 16:41 |
| stephenfin | jaypipes, mriedem: Could one of you push that reno typo fix through? https://review.openstack.org/531854 | 16:41 |
| mriedem | ktibi: can you report a bug? maybe we can build a whitelist of exception types that shouldn't be used to auto-disable a compute | 16:42 |
| dansmith | bauzas: not sure what kernel race you mean, but cool | 16:42 |
| bauzas | fun fact, I also discovered that the nvidia driver can't support the same physical GPU having more than 1 allocated mdev per guest | 16:42 |
| jaypipes | stephenfin: done | 16:42 |
| lyarwood | mdbooth: back sorry | 16:42 |
| stephenfin | jaypipes: Cheers :) | 16:42 |
| jaypipes | np | 16:42 |
| bauzas | dansmith: the fact that when calling sysfs, libvirtd doesn't get the update so it won't change the values of availableInstances and won't show up the newly created mdecs | 16:43 |
| lyarwood | mdbooth: that's going to break iSCSI volumes | 16:43 |
| ktibi | mriedem https://thepasteb.in/p/zmh8qDG2ZYJIZ | 16:43 |
| mdbooth | lyarwood: How? | 16:43 |
| dansmith | bauzas: oh I understand that bug.. is that why you're saying we can't/shouldn't do it in init_host() | 16:43 |
| dansmith | ? | 16:43 |
| dansmith | bauzas: and what's the status of a fix for that issue? | 16:44 |
| lyarwood | mdbooth: we need the volumes connected before we fetch the storage config | 16:44 |
| bauzas | dansmith: the reboot issue or the kernel issue ? | 16:44 |
| lyarwood | mdbooth: because of this wonderful connection_info stashing bs https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/iscsi.py#L67 | 16:44 |
| bauzas | dansmith: for the kernel, I have a race | 16:44 |
| bauzas | oops | 16:44 |
| bauzas | I have a change | 16:44 |
| mdbooth | lyarwood: That would bizarre | 16:44 |
| *** jpena is now known as jpena|brb | 16:44 | |
| dansmith | bauzas: the libvirt-does-not-notice-sysfs-changes issue | 16:44 |
| bauzas | dansmith: last patch I just uploaded couple of mins ago | 16:45 |
| ktibi | dansmith and I don't understand your comment, a cloud with "reasonable activity will not suffer from that" ! you think all openstack plateform have 50 instance creation/ min ? | 16:45 |
| mdbooth | lyarwood: Ah, we do that everywhere | 16:45 |
| bauzas | dansmith: for the init_host thingy, I'll try to use statically generated UUIDs | 16:45 |
| dansmith | bauzas: why does this only effect bootstrapping and not our actual allocation for guests? | 16:45 |
| mriedem | ktibi: hmm, that's less specific than i'd like | 16:45 |
| mriedem | ktibi: i thought it was failing when nova created the port | 16:45 |
| mriedem | but it's failing when nova plugs the vif | 16:45 |
| dansmith | bauzas: aren't the uuids stored in the guest xml already? | 16:45 |
| bauzas | dansmith: if the guest XML is not recreated, yes | 16:46 |
| mdbooth | lyarwood: So we need to ensure that in all cases we connect volumes before getting volume info, which makes sense | 16:46 |
| bauzas | but I think I discovered a couple of places where it's dangerous to count on that | 16:46 |
| bauzas | like hard reboot AFAIR | 16:46 |
| dansmith | ktibi: no, I understand a smaller cloud could hit that, but presumably those clouds are a little less concerned about real users launching a DoS, but I'm not arguing that it should be fixed | 16:46 |
| efried | jaypipes I added a summary on https://review.openstack.org/#/c/526539/ | 16:46 |
| dansmith | bauzas: right but on init_host(), we could find all the previously-used uuids | 16:46 |
| jaypipes | efried: danke | 16:47 |
| bauzas | dansmith: yeah, we can try | 16:47 |
| efried | jaypipes Is there anything else needed to get that patch going? | 16:47 |
| dansmith | bauzas: seems like the obvious thing to do, IMHO | 16:47 |
| jaypipes | efried: nope. | 16:47 |
| bauzas | dansmith: my point is, that run can last a while | 16:47 |
| efried | jaypipes (All action items related to that discussion will happen in later/other patches) | 16:47 |
| efried | jaypipes Cool. | 16:47 |
| bauzas | dansmith: anyway, let's try | 16:47 |
| jaypipes | efried: I just finishing up working on n-r-p in allocation candidates) | 16:47 |
| efried | ++ | 16:47 |
| dansmith | bauzas: if they aren't in the guest xml, then they weren't setup properly when we shut down the last time | 16:47 |
| *** david-lyle has quit IRC | 16:47 | |
| dansmith | bauzas: so if hard reboot blows the xml away, it was broken before reboot, thus init_host isn't making things worse | 16:48 |
| *** david-lyle has joined #openstack-nova | 16:48 | |
| bauzas | dansmith: that's also interesting to see that ovirt folks also had the approach of a deterministic UUID for the mdev | 16:48 |
| *** pcaruana has quit IRC | 16:48 | |
| bauzas | dansmith: FYI https://mpolednik.github.io/2017/05/21/vfio-mdev/ | 16:48 |
| *** yamahata has quit IRC | 16:48 | |
| dansmith | bauzas: I think a deterministic uuid is a bad idea, personally | 16:48 |
| ktibi | dansmith I have a private cloud plateform with ~1500 Vms, it's not very small for me :/ just a user create 200 instances at 4AM ^^ | 16:48 |
| dansmith | ktibi: again, I'm not arguing | 16:49 |
| *** damien_r has quit IRC | 16:49 | |
| bauzas | dansmith: I need to go to the doctor for 1 hour, but I'll work tonight | 16:49 |
| mriedem | ktibi: can you find the related failure from the neutron logs? | 16:49 |
| bauzas | let's wrap up that convo later | 16:49 |
| mriedem | ktibi: all nova gets back from neutron is an event saying vif plugging failed | 16:49 |
| dansmith | bauzas: okay | 16:49 |
| mriedem | which doesn't tell us why it failed at all | 16:49 |
| ktibi | dansmith yes no pb ;) just the issue can touch large cloud I think :/ | 16:49 |
| bauzas | dansmith: anyway, the deterministic UUID thingy is separated from the other changes in my series, so if we see it's a non-sense, I'm fine dropping it | 16:50 |
| dansmith | bauzas: ack | 16:50 |
| mdbooth | lyarwood: Ok, that's slightly more complex, but still not a showstopper. We need to pull host volume operations out of _create_domain_and_network, and explicitly call _connect_volume before getting guest xml if required. | 16:50 |
| mdbooth | Or just move it all into _get_guest_storage_config after all | 16:50 |
| ktibi | mriedem I'll try to get logs from neutron | 16:50 |
| mdbooth | Not what I had in mind, but would still be a consolidation | 16:50 |
| mriedem | mdbooth: is this a WIP? https://review.openstack.org/#/c/531852/ | 16:51 |
| mriedem | if so, can you WIPify it? | 16:51 |
| mdbooth | mriedem: Yep, will do | 16:52 |
| mriedem | thanks | 16:52 |
| lyarwood | mdbooth: yeah context down to _get_guest_storage_config and then merge the encryptor stuff into _connect/disconnect_volume | 16:52 |
| *** david-lyle has quit IRC | 16:52 | |
| *** amodi has quit IRC | 16:52 | |
| mdbooth | lyarwood: And *remove* it from _create_domain_and_network | 16:52 |
| * lyarwood nods | 16:52 | |
| mdbooth | We can already be confident that nothing is relying on that to do volume connection, because it never has | 16:53 |
| lyarwood | mdbooth: in one change? | 16:53 |
| mdbooth | Was just thinking about that. I don't see why not. | 16:53 |
| *** Tom-Tom has joined #openstack-nova | 16:53 | |
| *** yamamoto has joined #openstack-nova | 16:53 | |
| lyarwood | mdbooth: k, I'll reuse the refactor change | 16:53 |
| mdbooth | You might want the swap_volume patch first, though | 16:53 |
| mdbooth | And lxc | 16:53 |
| mdbooth | My WIP above? | 16:54 |
| lyarwood | ah true | 16:54 |
| lyarwood | mdbooth: no my original | 16:54 |
| mdbooth | If you're going to take it I'll just abandon that | 16:54 |
| ktibi | mdbooth nothing in neutron-server.log :/ 0warning 0 error | 16:54 |
| mdbooth | kk, cool | 16:54 |
| ktibi | oups sorrty for mriedem | 16:55 |
| mriedem | jaypipes: interested if adding an index is worth it for this https://review.openstack.org/#/c/531132/3/nova/db/sqlalchemy/migrate_repo/versions/376_add_migrations_updated_at_index.py - it's adding an index for listing migrations and filtering on updated_at (--changes-since); the query could have other columns/filters in it, so not sure if the index really helps or not | 16:58 |
| *** Tom-Tom has quit IRC | 16:59 | |
| jaypipes | mriedem: soon as I'm done with two other series reviews, will review. | 16:59 |
| mriedem | although my guess is if you just did "nova migration-list --changes-since x" it would help | 16:59 |
| *** slaweq has joined #openstack-nova | 17:00 | |
| *** yamamoto has quit IRC | 17:02 | |
| *** jmlowe has quit IRC | 17:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 17:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | 17:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 17:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | 17:06 |
| stephenfin | ralonsoh: Can we merge [1], given that [2] isn't working yet? [1] https://review.openstack.org/#/c/484386/ [2] https://review.openstack.org/#/c/530961/ | 17:06 |
| mriedem | dtantsur: re: CI testing for ironic+bfv https://review.openstack.org/#/c/468353/ - is there at least an existing job that ironic uses for this? if so, we can add that to nova's experimental queue | 17:08 |
| *** mvk has quit IRC | 17:09 | |
| dtantsur | mriedem: yep ironic-tempest-dsvm-bfv | 17:09 |
| *** slaweq has quit IRC | 17:11 | |
| dtantsur | wanna me propose a patch? | 17:14 |
| efried | jaypipes (and another core, maybe stephenfin or bauzas?) would you please add https://review.openstack.org/#/c/518633/ to your list? The patch above that is already +W, and it'll be nice to have for your nrp test case (https://review.openstack.org/#/c/531443/) | 17:14 |
| stephenfin | efried: Won't get to it myself today, but if it's still there tomorrow then I'll take a shot | 17:14 |
| efried | stephenfin Thanks | 17:14 |
| mriedem | dtantsur: sure | 17:15 |
| mriedem | efried: i'll take a look | 17:15 |
| efried | mriedem Thanks. | 17:15 |
| *** yamahata has joined #openstack-nova | 17:20 | |
| ralonsoh | stephenfin: sorry for the delay. [2] is working now | 17:20 |
| ralonsoh | stephenfin: openstack-tox-functional-with-sudoSUCCESS in 4m 00s | 17:20 |
| stephenfin | ralonsoh: Oh, congrats! Nice work | 17:21 |
| ralonsoh | stephenfin: Am I missing something? | 17:21 |
| ralonsoh | stephenfin: oooook! | 17:21 |
| * stephenfin spent an hour on that Friday with no success | 17:21 | |
| ralonsoh | stephenfin: Sean's magic.... you know | 17:21 |
| stephenfin | Oh, I know :) | 17:21 |
| stephenfin | Cool. I'll review that tomorrow morning so | 17:21 |
| ralonsoh | stephenfin: thanks! | 17:22 |
| stephenfin | np | 17:22 |
| *** jpena|brb is now known as jpena | 17:24 | |
| jaypipes | efried: just finishing up a review on that, yes. | 17:25 |
| *** itlinux_ has joined #openstack-nova | 17:27 | |
| jaypipes | efried: done | 17:29 |
| *** Apoorva has quit IRC | 17:29 | |
| EmilienM | mriedem: hey matt, I remember we had a thread about how to handles patches like https://review.openstack.org/531055 - I don't recall the outcome, do you have the link of the thread? | 17:29 |
| *** itlinux_ has quit IRC | 17:30 | |
| *** itlinux_ has joined #openstack-nova | 17:30 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 17:31 |
| *** itlinux_ has quit IRC | 17:31 | |
| *** itlinux_ has joined #openstack-nova | 17:31 | |
| *** matrohon has quit IRC | 17:31 | |
| mriedem | EmilienM: the eventual outcome was the first contact SIG | 17:31 |
| EmilienM | ok | 17:31 |
| mriedem | https://wiki.openstack.org/wiki/First_Contact_SIG | 17:32 |
| mriedem | and http://superuser.openstack.org/articles/sig-first-contact-openstack/ | 17:32 |
| mriedem | i guess point them at that? | 17:32 |
| EmilienM | mriedem: ok, thx | 17:33 |
| mriedem | should probably build something into the first-time contributor comment that people get on their patch too | 17:33 |
| EmilienM | mwhahaha: ^ | 17:33 |
| EmilienM | the thing is I'm not sure this is a new contributor: https://review.openstack.org/#/q/owner:shangxiaobj%2540inspur.com+status:merged | 17:33 |
| EmilienM | the person is doing http to https a lot and it waste so much CI resources imho | 17:34 |
| *** david-lyle has joined #openstack-nova | 17:34 | |
| mriedem | yeah they aren't, | 17:34 |
| *** itlinux_ has quit IRC | 17:34 | |
| mriedem | i'd probably ping huang zhipeng (howard) | 17:34 |
| mriedem | he's in china and on the first contact sig group | 17:34 |
| mriedem | i think a bunch of these contributors from chinese companies actually hang out in a wechat group for openstack, | 17:35 |
| *** tidwellr has quit IRC | 17:35 | |
| *** tidwellr_ has joined #openstack-nova | 17:35 | |
| mriedem | so he sometimes proxies stuff to that group where people are actually listening (and speaking the same language) | 17:35 |
| EmilienM | mriedem: ok thx for the advises | 17:35 |
| mriedem | yw | 17:35 |
| *** itlinux_ has joined #openstack-nova | 17:36 | |
| *** eharney has joined #openstack-nova | 17:37 | |
| *** itlinux_ has quit IRC | 17:37 | |
| *** itlinux_ has joined #openstack-nova | 17:38 | |
| *** itlinux_ has quit IRC | 17:42 | |
| *** itlinux_ has joined #openstack-nova | 17:42 | |
| jaypipes | tox -efast8 would be fast if it didn't try to reinstall all the global requirements each time I run it. | 17:42 |
| *** itlinux_ has quit IRC | 17:43 | |
| mriedem | it shouldn't try to re-install them | 17:43 |
| mriedem | pip + wheels should have all of that cached | 17:43 |
| *** yamamoto has joined #openstack-nova | 17:43 | |
| mriedem | plus your existing venv would have them | 17:43 |
| *** yamamoto has quit IRC | 17:43 | |
| *** felipemonteiro has joined #openstack-nova | 17:45 | |
| openstackgerrit | Merged openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 17:45 |
| *** amodi has joined #openstack-nova | 17:46 | |
| *** david-lyle has quit IRC | 17:47 | |
| *** itlinux_ has joined #openstack-nova | 17:49 | |
| *** itlinux_ has quit IRC | 17:49 | |
| *** itlinux has joined #openstack-nova | 17:50 | |
| mriedem | efried: so i got looking at https://review.openstack.org/#/c/509892/ again, | 17:50 |
| mriedem | and didn't realize it until now but we never leverage the session client stuff in neutronclient | 17:50 |
| mriedem | https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L251 | 17:50 |
| mriedem | oh nvm i guess that checks for a session kwarg https://github.com/openstack/python-neutronclient/blob/master/neutronclient/client.py#L389 | 17:51 |
| mriedem | confusing method name | 17:51 |
| jaypipes | mriedem: still takes 10+ seconds to run the "develop-inst-nodeps" part of the job :( | 17:52 |
| *** lucasagomes is now known as lucas-afk | 17:52 | |
| jaypipes | mriedem: which I presume is just comparing pip freeze outputs? | 17:53 |
| mriedem | no idea | 17:53 |
| dtantsur | jaypipes: also downloads upper-constraint, if it's a typical job | 17:54 |
| * dtantsur disappears again | 17:54 | |
| jaypipes | :) | 17:54 |
| *** AlexeyAbashkin has joined #openstack-nova | 17:54 | |
| *** itlinux has quit IRC | 17:55 | |
| *** itlinux has joined #openstack-nova | 17:56 | |
| mriedem | probably an easy +W on efried's neutronclient change to use the ksa adapter stuff https://review.openstack.org/#/c/509892/ | 17:56 |
| *** Apoorva has joined #openstack-nova | 17:57 | |
| *** AlexeyAbashkin has quit IRC | 17:58 | |
| *** rabel_b1 has quit IRC | 17:58 | |
| dtantsur | mriedem: oh, you guys haven't switched to in-tree zuul stuff, have you? | 17:58 |
| mriedem | dtantsur: started to | 17:59 |
| mriedem | but not much there yet | 17:59 |
| mriedem | actually nothing until https://review.openstack.org/#/c/514309/ | 17:59 |
| dtantsur | I see. so any changes still go to project-config? | 17:59 |
| mriedem | dtantsur: yeah | 17:59 |
| mriedem | unless you want to build it on top of https://review.openstack.org/#/c/514309/ | 17:59 |
| mriedem | melwitt: you want to get https://review.openstack.org/#/c/514309/ since you've looked at the zuulv3 in-repo stuff before? | 17:59 |
| dtantsur | lemme see what is easier | 18:00 |
| mriedem | stvnoyes: an update on multiattach testing - i added some more tests over the weekend to https://review.openstack.org/#/c/266605/ - the list multiple attachments one and boot from volume one are passing ( https://review.openstack.org/#/c/531386/ ) - the snapshot one is failing, looks like due to some response validation in tempest that doesn't handle 2.59 | 18:01 |
| *** derekh has quit IRC | 18:01 | |
| stvnoyes | mreidem- ok thanks for the update. I am running into a m-a attach failure when attaching to the second instance. debugging that now. | 18:02 |
| mriedem | stvnoyes: with libvirt 3.10? | 18:03 |
| stvnoyes | no, with 3.6 | 18:03 |
| mriedem | what version of qemu? | 18:03 |
| stvnoyes | 2.8 | 18:04 |
| mriedem | hmm | 18:04 |
| *** slaweq has joined #openstack-nova | 18:05 | |
| mriedem | i'm getting things to work with lvm as the backend, and qemu 2.5 and libvirt 3.6 | 18:05 |
| stvnoyes | may just be that I am missing a patch. I am running it down now | 18:05 |
| stvnoyes | this had been working for me before | 18:05 |
| *** ralonsoh has quit IRC | 18:05 | |
| dtantsur | mriedem: https://review.openstack.org/#/c/531868/ should do it. do you remember if Depends-On project-config changes works? | 18:08 |
| *** cdent has joined #openstack-nova | 18:08 | |
| mriedem | you can't depends-on a project-config change, no | 18:08 |
| * dtantsur #sadpanda | 18:09 | |
| mriedem | andreas is usually pretty quick to hit these though | 18:09 |
| dtantsur | yep | 18:10 |
| mriedem | dtantsur: does ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode also test the multitenant stuff? | 18:10 |
| mriedem | *multitenant network | 18:10 |
| dtantsur | mriedem: that's the correct name of that job, so yes | 18:10 |
| mriedem | oh maybe it was renamed and we just never noticd | 18:10 |
| dtantsur | I think so | 18:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 18:14 |
| jaypipes | mriedem, jgriffith_: your thoughts on this? https://review.openstack.org/#/c/528740/ | 18:15 |
| mriedem | jaypipes: we can't change that as a bug fix | 18:16 |
| mriedem | imo | 18:16 |
| mriedem | it's an api change | 18:16 |
| jaypipes | mriedem: oh, I agree... I don't think it's actually something we should do *at all*. | 18:16 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/volume-backed-server-rebuild | 18:16 |
| mriedem | i've -2ed for now just due to procedure | 18:17 |
| *** slaweq has quit IRC | 18:17 | |
| mriedem | i'm sure people want rebuild of volume-backed instances, but i'm not interested in that rats nest atm | 18:17 |
| *** ameeda has joined #openstack-nova | 18:17 | |
| *** READ10 has quit IRC | 18:17 | |
| *** jpena is now known as jpena|off | 18:18 | |
| cdent | efried, jaypipes I've stubbed in https://blueprints.launchpad.net/nova/+spec/placement-aggregate-generation . Since it is microversion, officially we need a spec. | 18:19 |
| ameeda | Hi , when I try to execute this command "mistral-db-manage --config-file /etc/mistral/mistral.conf populate", I got many errors as this http://paste.openstack.org/show/640994/ | 18:19 |
| *** jackie-truong has quit IRC | 18:19 | |
| *** dtantsur is now known as dtantsur|afk | 18:20 | |
| jaypipes | cdent: you want to handle the spec? | 18:20 |
| cdent | yeah, will do | 18:20 |
| mriedem | that's rocky at this point right? | 18:20 |
| jaypipes | ameeda: wrong channel... try #openstack-mistral | 18:20 |
| *** slaweq has joined #openstack-nova | 18:21 | |
| ameeda | Thanks ! | 18:21 |
| * cdent looks at jaypipes, efried | 18:21 | |
| jaypipes | mriedem: which one? | 18:21 |
| jaypipes | mriedem: the placement agg gen? | 18:21 |
| mriedem | aggregates generation | 18:21 |
| *** sahid has quit IRC | 18:21 | |
| mriedem | or is that blocking something for queens? | 18:21 |
| jaypipes | mriedem: well, not *really* but it can be seen as more of a bug fix that enables drivers like vcenter and powervm | 18:22 |
| *** mgoddard has joined #openstack-nova | 18:22 | |
| mriedem | ok, but we're not prioritizing sharing providers in rocky right? | 18:23 |
| mriedem | *queens | 18:23 |
| cdent | mriedem: it's discussed near here at today's meeting http://eavesdrop.openstack.org/meetings/nova_scheduler/2018/nova_scheduler.2018-01-08-14.00.log.html#l-127 | 18:23 |
| cdent | it's not clear what the time table is | 18:24 |
| mriedem | it's a rhetorical question :) | 18:24 |
| mriedem | we said in denver that we weren't focusing on sharing providers in queens | 18:24 |
| mriedem | and nested resource providers was the goal | 18:24 |
| cdent | sure, I'm not disputing that. I'm merely asking where management of aggregates fits in | 18:25 |
| mriedem | do aggregates butt up against nested providers? | 18:25 |
| cdent | I'm very happy to not do the work, but in the meeting it was wanted. If we don't want it, cool. | 18:25 |
| mriedem | "butt up" is the technical term | 18:25 |
| cdent | quite | 18:25 |
| mriedem | well, want is fine, | 18:25 |
| mriedem | i just don't want it to be a distraction for queens | 18:25 |
| mriedem | queuing it up for rocky is cool | 18:25 |
| mriedem | reminds me i need to start an etherpad for various rocky ptg stuff, to include spill over from queens | 18:26 |
| cdent | I'm happy to let jaypipes and efried decide. I simply volunteered to do the implementation. | 18:26 |
| jaypipes | mriedem: rocky is fine | 18:27 |
| *** moshele has joined #openstack-nova | 18:27 | |
| mriedem | cdent: jaypipes: https://etherpad.openstack.org/p/nova-ptg-rocky | 18:27 |
| cdent | ack | 18:28 |
| mriedem | now i've forgotten what i wanted to put on there from friday :( | 18:28 |
| mriedem | oh yeah | 18:28 |
| *** jackie-truong has joined #openstack-nova | 18:28 | |
| cdent | mriedem: If we're punting that to rocky, I don't reckon we need to put it on the ptg agenda, we talked it to deaht already today. I'm sure we'll have plenty of stuff more interesting. So I'll kill it. | 18:29 |
| mriedem | i'll at least target the bp to rocky in launchpad so it's in the list | 18:30 |
| jaypipes | mriedem: the aggregate-affinity one would be good to add to the ptg agenda. I'll do that. | 18:30 |
| mriedem | yeah definitely while we have ironic people around | 18:31 |
| *** slaweq has quit IRC | 18:31 | |
| *** slaweq has joined #openstack-nova | 18:34 | |
| *** beekneemech is now known as bnemec | 18:34 | |
| *** tesseract has quit IRC | 18:35 | |
| *** moshele has quit IRC | 18:36 | |
| *** corey_ has joined #openstack-nova | 18:39 | |
| *** cleong has quit IRC | 18:40 | |
| *** READ10 has joined #openstack-nova | 18:41 | |
| *** lpetrut has quit IRC | 18:41 | |
| *** yamamoto has joined #openstack-nova | 18:44 | |
| *** jafeha__ has joined #openstack-nova | 18:48 | |
| *** jafeha has quit IRC | 18:49 | |
| *** cdent has quit IRC | 18:49 | |
| *** yamamoto has quit IRC | 18:52 | |
| *** jmlowe has joined #openstack-nova | 18:53 | |
| *** fragatina has quit IRC | 18:55 | |
| *** fragatina has joined #openstack-nova | 18:55 | |
| *** Tom-Tom has joined #openstack-nova | 18:56 | |
| jaypipes | oh shitbuckets. | 18:57 |
| *** slaweq has quit IRC | 19:01 | |
| *** fragatina has quit IRC | 19:01 | |
| *** yamamoto has joined #openstack-nova | 19:01 | |
| *** slaweq has joined #openstack-nova | 19:02 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: func tests for nested providers in alloc candidate https://review.openstack.org/531443 | 19:03 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: add _has_provider_trees() utility function https://review.openstack.org/531474 | 19:03 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: _get_trees_matching_all() https://review.openstack.org/531512 | 19:03 |
| *** slaweq has quit IRC | 19:06 | |
| *** slaweq has joined #openstack-nova | 19:09 | |
| jaypipes | efried: for n-r-p traits handling, we agreed that the following is true, right? "if user requests traits X, Y, and Z and at least one provider within a tree has one of each of those traits associated with it, then collectively the tree meets the required traits constraint" | 19:10 |
| jaypipes | efried: or did we instead say "the providers **that end up providing the resources involved in the request** must collectively be associated with all of the required traits"? | 19:11 |
| jaypipes | edleafe, mriedem, dansmith: your thoughts welcome on ^^ | 19:12 |
| dansmith | until we have the more expressive query language, neither is really what we want, right? | 19:12 |
| dansmith | and we kinda have to do the "any" instead of "all" until that point I thought | 19:13 |
| jaypipes | dansmith: let's say I have a compute node with 24 VCPU and 32768G RAM with two child providers representing two PFs. One PF has trait X and one has trait Y. The one with trait X has inventory available for 2 VFs. the PF has no more inventory of VFs. If I request 2 VCPU, 1024 MEMORY_MB and 1 SRIOV_NET_VF, along with required_traits=Y. should the compute node be returned? I would say "no"... | 19:16 |
| dansmith | wow 32T of ram? | 19:16 |
| jaypipes | heh | 19:16 |
| jaypipes | you get my drift.. | 19:16 |
| dansmith | it just means we have to tag everything with every trait right? | 19:17 |
| dansmith | like you'd have to tag a compute node with "has-nvidia" so that you could ever get a gpu | 19:17 |
| jaypipes | dansmith: no, that's not quite what I'm getting at... I'm wondering whether the "collectively meets the required traits constraint" should only consider those (child) resource providers that would be providing the resources for the request. In the case described above, the child provider that has the required trait Y does not provide the inventory of SRIOV_NET_VF for the request. Instead, the child provider with trait X is providing that | 19:19 |
| jaypipes | inventory. | 19:19 |
| *** harlowja has joined #openstack-nova | 19:19 | |
| dansmith | well, I think I get that, I'm just not sure how you're going to scope it to the right thing, | 19:19 |
| jaypipes | but "collectively", the provider tree representing the compute node and all its child providers "meets the constraints" | 19:19 |
| *** slaweq has quit IRC | 19:19 | |
| dansmith | meaning how placement is going to know that "has required trait X" applies to the vif and not the disk | 19:20 |
| *** jackie-truong has quit IRC | 19:20 | |
| dansmith | since the query didn't scope it as such | 19:20 |
| jaypipes | dansmith: well, I can apply the filter on traits *after* already processing the filter for resource amounts. | 19:20 |
| dansmith | right, | 19:20 |
| dansmith | which will filter out disks without trait X yes? | 19:20 |
| jaypipes | right | 19:20 |
| dansmith | which means you don't get any disk, which isn't a useful thing if you're trying to boot an instance, no? | 19:21 |
| jaypipes | well, that would just mean that this compute node would not be returned in the GET /allocation_candidates query since the required traits are not associated with the providers that would end up providing the resources for the request | 19:22 |
| *** pramodrj07 has joined #openstack-nova | 19:22 | |
| dansmith | exactly | 19:22 |
| *** pramodrj07 has quit IRC | 19:22 | |
| dansmith | which is what I was saying: | 19:22 |
| dansmith | you'd have to tag everything with X to make it come out properly | 19:22 |
| dansmith | your disk and cpu and gpu would all have to have X applied so that you could ask for things with trait X, | 19:23 |
| dansmith | but that doesn't make sense, assuming X is a networky trait you're using to pick which VF/PF/whatever you're looking for | 19:23 |
| jaypipes | right | 19:23 |
| dansmith | okay now I'm confused that you agree | 19:23 |
| jaypipes | I think I've answered my own question :) | 19:23 |
| dansmith | ....mmmokay :) | 19:24 |
| jaypipes | just needed a willing sounding board. | 19:24 |
| jaypipes | or unwilling I suppose ;) | 19:24 |
| dansmith | heh | 19:24 |
| mriedem | jaypipes: i don't know the answer to that - it was one of the questions i asked when that change in the placement api merged, i.e. "what are the rules on this new query parameter?" | 19:26 |
| mriedem | specifically the "in_tree" parameter | 19:26 |
| jaypipes | mriedem: this isn't about that parameter (that parameter doesn't exist for GET /allocation_candidates | 19:26 |
| jaypipes | mriedem: but I can see a similar problem/point with that | 19:27 |
| *** slaweq has joined #openstack-nova | 19:28 | |
| *** rabel_b1 has joined #openstack-nova | 19:31 | |
| *** rabel__b1 has joined #openstack-nova | 19:32 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Collocate encryptor and volume driver calls https://review.openstack.org/460243 | 19:34 |
| *** rabel_b1 has quit IRC | 19:36 | |
| edleafe | jaypipes: (catching up) I wasn't clear if the tree for that compute node would contain everything (i.e., both child PFs), or only the children needed to satisfy the request | 19:36 |
| jaypipes | edleafe: yes, tree would contain both PFs. | 19:37 |
| edleafe | ah, ok | 19:38 |
| edleafe | Just the allocation_candidate would be "minimal" | 19:38 |
| *** lpetrut has joined #openstack-nova | 19:41 | |
| *** felipemonteiro_ has joined #openstack-nova | 19:41 | |
| jaypipes | edleafe: not sure I follow you.. | 19:43 |
| *** david-lyle has joined #openstack-nova | 19:43 | |
| *** felipemonteiro has quit IRC | 19:45 | |
| edleafe | jaypipes: I wasn't clear if the provider tree would only contain parts of the entire tree that were "relevant" | 19:45 |
| edleafe | since you were talking about meeting traits restraints | 19:46 |
| * edleafe needs to read up more on provider tree stuff | 19:46 | |
| jaypipes | edleafe: ah, so the provider_summaries will include all nodes in the tree, but the allocation_requests would only be the ones that were being consumed from. | 19:46 |
| jaypipes | edleafe: but what I was wondering about was how to winnow the set of provider trees to begin with... | 19:46 |
| edleafe | because the SQL can't be that specific? I.e., match trait to the PF with the inventory? | 19:49 |
| jaypipes | edleafe: no, it's not really a SQL thing... more of a "what order do I apply this filter" thing... don't worry about it. I've got tests coming that show the idea. should be easier to read the tests. | 19:49 |
| edleafe | jaypipes: ack | 19:51 |
| *** yamamoto has quit IRC | 19:53 | |
| *** jmlowe has quit IRC | 19:59 | |
| *** sdague has joined #openstack-nova | 20:00 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: add tests for _get_trees_matching_all() with trait https://review.openstack.org/531899 | 20:00 |
| jaypipes | edleafe, mriedem, dansmith, efried: ^^ try that test description on for size... | 20:01 |
| *** Apoorva has quit IRC | 20:01 | |
| *** Apoorva has joined #openstack-nova | 20:02 | |
| *** jgriffith_ is now known as jgriffith | 20:03 | |
| *** yamamoto has joined #openstack-nova | 20:04 | |
| stvnoyes | mriedem: (I figured my problem, I neglected to set MA on the disk) So I was able to create a VM with a vol and did a bfv. I then created a new vm and attached the first vm's boot disk to it (as a data disk). I then did a nova image-create for both vm's. It all worked without errors. Was this the test you were looking for? | 20:05 |
| *** jackie-truong has joined #openstack-nova | 20:06 | |
| mriedem | stvnoyes: yeah, that's what i have in https://review.openstack.org/266605 so far | 20:06 |
| mriedem | stvnoyes: here is another one: create a bootable multiattach volume, create server1 from that volume with delete_on_termination=True; then create another server (not bfv) and attach the volume to server2, then delete server1 | 20:07 |
| mriedem | assert that the volume is not deleted and still attached to server2, but server1 was deleted | 20:07 |
| stvnoyes | kk | 20:08 |
| mriedem | i'm going to add another test in here for resize with a multiattach volume attached | 20:08 |
| mriedem | and we likely also need a test for swap volume with a multiattach volume, but that's an admin-level test | 20:09 |
| *** yamamoto has quit IRC | 20:09 | |
| *** tbachman has joined #openstack-nova | 20:10 | |
| mriedem | sdague: got a pretty easy +W on efried's neutronclient changes for the ksa adapter https://review.openstack.org/#/c/509892/ | 20:13 |
| sdague | mriedem: looking | 20:14 |
| edmondsw | mriedem sdague the powervm SEA and OVS patches shouldn't merge until we get the CI working, which is waiting on a global req change to merge (already has +W), but they are otherwise ready to start reviewing | 20:18 |
| edmondsw | OVS: https://review.openstack.org/#/c/422512/ | 20:18 |
| edmondsw | SEA: https://review.openstack.org/#/c/523216/ | 20:18 |
| *** itlinux has quit IRC | 20:19 | |
| *** edmondsw has quit IRC | 20:26 | |
| *** itlinux has joined #openstack-nova | 20:29 | |
| *** jmlowe has joined #openstack-nova | 20:31 | |
| *** imacdonn has joined #openstack-nova | 20:38 | |
| *** penick has joined #openstack-nova | 20:38 | |
| * mriedem rechecks everything | 20:38 | |
| *** openstack has quit IRC | 20:38 | |
| *** openstack has joined #openstack-nova | 20:40 | |
| *** ChanServ sets mode: +o openstack | 20:40 | |
| stvnoyes | it's 3:07 in my time zone | 20:40 |
| mriedem | stvnoyes: mayhap you'd like to recreate and fix this https://bugs.launchpad.net/nova/+bug/1741476 | 20:40 |
| *** fragatina has joined #openstack-nova | 20:40 | |
| stvnoyes | ok I'll take a look | 20:41 |
| *** awaugama has quit IRC | 20:42 | |
| *** READ10 has quit IRC | 20:43 | |
| openstack | Launchpad bug 1741476 in OpenStack Compute (nova) "Attaching read-only volumes fails" [Undecided,New] | 20:44 |
| *** jmlowe has quit IRC | 20:45 | |
| efried | jaypipes Sorry, catching up. In the example you gave, I think you should *not* get that host back. We should construct trait presence as narrowly/strictly as possible in the nested scenario: i.e. the traits must exist in the set of providers we're actually *using*; it's not enough for some other (unused) provider in the tree to have that trait. | 20:49 |
| efried | jaypipes And when you (as an op) want to be strict about which traits belong to which resource classes, you have to use granular. | 20:50 |
| *** jmlowe has joined #openstack-nova | 20:50 | |
| jaypipes | efried: k, that matches the assumptions in the patch with the test case. | 20:50 |
| efried | excellent. | 20:51 |
| efried | jaypipes When you say, "check. test assertions (and commented out assertions) are correct and represent the bugs appropriately." -- are you asking for a code comment, or was this just acknowledging that you had looked at the test case and saw that it was good (in the Genesis sense)? | 20:52 |
| jaypipes | efried: no, I'm saying it was good. ++ | 20:53 |
| efried | jaypipes Roger, thanks. | 20:53 |
| jaypipes | efried: sometimes I mark reviews like that just to keep my place in the review. | 20:53 |
| efried | suresure. Just making sure I understood correctly, since you *were* asking for comment updates elsewhere. | 20:53 |
| jaypipes | ack | 20:54 |
| *** ktibi has quit IRC | 20:58 | |
| *** liverpooler has quit IRC | 20:58 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094 | 20:59 |
| *** openstackgerrit has quit IRC | 21:03 | |
| *** matrohon has joined #openstack-nova | 21:07 | |
| *** smatzek has quit IRC | 21:11 | |
| *** smatzek has joined #openstack-nova | 21:11 | |
| *** smatzek has quit IRC | 21:16 | |
| *** archit has joined #openstack-nova | 21:16 | |
| *** amodi has quit IRC | 21:16 | |
| *** archit is now known as amodi | 21:16 | |
| *** rcernin has joined #openstack-nova | 21:17 | |
| *** gouthamr has quit IRC | 21:22 | |
| *** jmlowe has quit IRC | 21:22 | |
| *** corey_ has quit IRC | 21:25 | |
| *** Anticimex has joined #openstack-nova | 21:27 | |
| *** r-daneel has joined #openstack-nova | 21:27 | |
| *** rabel__b1 has quit IRC | 21:28 | |
| *** david-lyle has quit IRC | 21:28 | |
| *** rabel_b1 has joined #openstack-nova | 21:28 | |
| *** alee has left #openstack-nova | 21:29 | |
| *** ameeda has quit IRC | 21:31 | |
| *** rcernin has quit IRC | 21:33 | |
| *** jackie-truong has quit IRC | 21:34 | |
| *** penick has quit IRC | 21:35 | |
| *** hemna_ has joined #openstack-nova | 21:37 | |
| *** rabel_b1 has quit IRC | 21:37 | |
| *** jmlowe has joined #openstack-nova | 21:37 | |
| *** gouthamr has joined #openstack-nova | 21:37 | |
| *** jmlowe has quit IRC | 21:39 | |
| *** yamamoto has joined #openstack-nova | 21:39 | |
| mriedem | nicolasbock: you're with suse right? is this something you can confirm and if so, update the nova install guide for suse? https://bugs.launchpad.net/nova/+bug/1741329 | 21:40 |
| openstack | Launchpad bug 1741329 in OpenStack Compute (nova) "Install and configure controller node for openSUSE and SUSE Linux Enterprise in nova" [Undecided,New] | 21:40 |
| *** yamamoto has quit IRC | 21:47 | |
| *** slaweq has quit IRC | 21:50 | |
| mriedem | lyarwood: hemna: added some notes to https://bugs.launchpad.net/nova/+bug/1741364 - but yeah, spot on, doesn't do anything with getting the ephemeral disk config when building the new guest xml | 21:52 |
| openstack | Launchpad bug 1741364 in OpenStack Compute (nova) "ceph ephemeral info not updated during live migrate" [Medium,Confirmed] | 21:52 |
| *** smatzek has joined #openstack-nova | 21:52 | |
| mriedem | and cold migration would do that of course, or a hard reboot | 21:52 |
| mriedem | but those involve downtime | 21:52 |
| *** itlinux has quit IRC | 21:52 | |
| *** eharney has quit IRC | 21:53 | |
| *** esberglu has quit IRC | 21:53 | |
| mriedem | would likely require something like https://github.com/openstack/nova/blob/74deea4d8f66a85e66ec79c72c9f257f562d5afd/nova/virt/libvirt/migration.py#L133 for non-volume disks | 21:54 |
| *** smatzek has quit IRC | 21:56 | |
| flwang1 | mriedem: could you please help me understand the relationship between cell and sockets in cpu topo? | 21:57 |
| mriedem | flwang1: i can't help you there | 21:58 |
| flwang1 | mriedem: who is the right person I should ask? | 21:58 |
| mriedem | probably need to talk to stephenfin or sahid when they are around | 21:58 |
| mriedem | UK timezone | 21:58 |
| flwang1 | mriedem: cool, thanks | 21:58 |
| mriedem | or cfriesen (canada | 21:58 |
| flwang1 | mriedem: great, and happy new year! | 21:59 |
| mriedem | same to you | 21:59 |
| *** matrohon has quit IRC | 22:00 | |
| *** burt has quit IRC | 22:00 | |
| *** esberglu has joined #openstack-nova | 22:04 | |
| bauzas | dansmith: still around ? | 22:06 |
| *** rcernin has joined #openstack-nova | 22:06 | |
| bauzas | dansmith: I'll upload a new PS tomorrow for https://review.openstack.org/#/c/528832/ based on your's and jaypipes's comments | 22:07 |
| bauzas | dansmith: but you had a main comment about how to recreate the existing mdevs with init_host() | 22:07 |
| bauzas | dansmith: basically the main concern I have is that we don't know if an existing mdev is used by an instance unless by looking at the guest XML | 22:20 |
| dansmith | bauzas: ...right, what's wrong with looking at the xml? that's what I was suggesting | 22:21 |
| bauzas | dansmith: the main point is that it could be a long verification | 22:21 |
| dansmith | bauzas: in what way? | 22:21 |
| dansmith | we already iterate instances on startup | 22:22 |
| dansmith | and do lots of db stuff for each | 22:22 |
| bauzas | a-ha | 22:22 |
| bauzas | in the libvirt init_host() or the compute service one ? | 22:22 |
| bauzas | lemme see | 22:22 |
| dansmith | we iterate instances in the compute manager init_host() | 22:23 |
| dansmith | and call init_instance() (or something like that) for each | 22:23 |
| dansmith | we could call into the driver in there, or just have the driver's init_host iterate instances again, tbh | 22:23 |
| dansmith | just listing all instances from libvirt and re-creating mdevs would be fine and not heavy, IMHO | 22:23 |
| bauzas | I see | 22:24 |
| dansmith | dan@falcon:~$ time (for i in $(seq 0 100); do virsh dumpxml 10 >/dev/null; done) | 22:25 |
| dansmith | real0m1.006s | 22:25 |
| dansmith | on my quite slow machine | 22:25 |
| bauzas | i just wonder how to verify the xml | 22:25 |
| dansmith | I think it'll be fine :) | 22:25 |
| bauzas | heh thanks | 22:25 |
| dansmith | how to verify what/ | 22:25 |
| bauzas | how to verify the guest XML whether it has some mdevs | 22:25 |
| dansmith | it was right when we shut down, we're in init/startup, why not just restore them to the way they were? we can't have processed any compute-side deletes yet | 22:25 |
| dansmith | isn't it in the guest xml? | 22:25 |
| bauzas | it will be | 22:26 |
| bauzas | anyway, lemme see how to do that | 22:26 |
| dansmith | okay, I'm confused about your confusion, | 22:26 |
| dansmith | but if I'm missing something, slap me with it | 22:26 |
| *** lpetrut has quit IRC | 22:27 | |
| bauzas | apologies if I'm confusing | 22:28 |
| bauzas | I'll work on that tomorrow morning so if I have better concerns, I'll tell you once you're up | 22:28 |
| bauzas | thanks | 22:28 |
| dansmith | okay | 22:29 |
| *** penick has joined #openstack-nova | 22:36 | |
| *** dave-mccowan has quit IRC | 22:37 | |
| *** fragatina has quit IRC | 22:38 | |
| *** lyan has quit IRC | 22:40 | |
| *** armax has quit IRC | 22:40 | |
| *** kumarmn has joined #openstack-nova | 22:42 | |
| *** hongbin has quit IRC | 22:45 | |
| *** kumarmn has quit IRC | 22:46 | |
| *** itlinux has joined #openstack-nova | 22:51 | |
| rybridges | Have a question guys. Where do the logs for this file go? https://github.com/openstack/nova/blob/stable/ocata/nova/compute/manager.py | 22:51 |
| rybridges | I do not see them in scheduler log, conductor log, or api log | 22:52 |
| mriedem | compute | 22:52 |
| *** openstackgerrit has joined #openstack-nova | 22:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the ability to get absolute limits from Cinder https://review.openstack.org/520122 | 22:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Check quota before creating volume snapshots https://review.openstack.org/520158 | 22:53 |
| rybridges | oh its on the hypervisor | 22:54 |
| rybridges | mriedem | 22:54 |
| rybridges | not on the api node | 22:54 |
| *** kumarmn has joined #openstack-nova | 22:54 | |
| mriedem | well, nova/compute, "compute" | 22:54 |
| mriedem | so yeah | 22:54 |
| rybridges | ok | 22:54 |
| mriedem | the directory structure is mostly laid out by service | 22:54 |
| mriedem | except nova/virt is also in compute | 22:54 |
| *** david-lyle has joined #openstack-nova | 22:55 | |
| *** stvnoyes has quit IRC | 22:56 | |
| *** slaweq has joined #openstack-nova | 22:58 | |
| *** kumarmn has quit IRC | 22:59 | |
| *** slaweq has quit IRC | 23:00 | |
| *** john51_ has quit IRC | 23:01 | |
| *** gcb has joined #openstack-nova | 23:01 | |
| *** john51 has joined #openstack-nova | 23:04 | |
| *** chyka_ has joined #openstack-nova | 23:06 | |
| *** kumarmn has joined #openstack-nova | 23:09 | |
| *** chyka has quit IRC | 23:09 | |
| *** jaypipes has quit IRC | 23:12 | |
| *** david-lyle has quit IRC | 23:12 | |
| *** tidwellr_ has quit IRC | 23:12 | |
| *** david-lyle has joined #openstack-nova | 23:13 | |
| *** chyka_ has quit IRC | 23:13 | |
| *** chyka has joined #openstack-nova | 23:14 | |
| *** amodi has quit IRC | 23:15 | |
| *** kumarmn has quit IRC | 23:20 | |
| *** gcb has quit IRC | 23:20 | |
| *** kumarmn has joined #openstack-nova | 23:21 | |
| *** jobewan has joined #openstack-nova | 23:22 | |
| *** sambetts is now known as sambetts|afk | 23:22 | |
| *** mlavalle has quit IRC | 23:23 | |
| *** kumarmn has quit IRC | 23:29 | |
| *** chyka_ has joined #openstack-nova | 23:32 | |
| *** takashin has joined #openstack-nova | 23:33 | |
| *** chyka has quit IRC | 23:35 | |
| *** jobewan has quit IRC | 23:36 | |
| *** penick has quit IRC | 23:38 | |
| *** Guest20076 has quit IRC | 23:44 | |
| *** felipemonteiro_ has quit IRC | 23:46 | |
| *** kumarmn has joined #openstack-nova | 23:47 | |
| *** chyka_ has quit IRC | 23:48 | |
| *** chyka has joined #openstack-nova | 23:49 | |
| *** kumarmn has quit IRC | 23:52 | |
| *** kumarmn has joined #openstack-nova | 23:53 | |
| *** itlinux has quit IRC | 23:54 | |
| *** chyka_ has joined #openstack-nova | 23:55 | |
| *** chyka has quit IRC | 23:55 | |
| *** moshele has joined #openstack-nova | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!