| *** mriedem has joined #openstack-nova | 00:01 | |
| *** amodi has quit IRC | 00:03 | |
| *** namnh has quit IRC | 00:03 | |
| *** cdent has quit IRC | 00:07 | |
| *** thorst has joined #openstack-nova | 00:08 | |
| *** thorst has quit IRC | 00:09 | |
| *** salv-orlando has quit IRC | 00:09 | |
| *** salv-orlando has joined #openstack-nova | 00:09 | |
| *** slaweq_ has joined #openstack-nova | 00:11 | |
| *** salv-orlando has quit IRC | 00:14 | |
| *** andreas_s has joined #openstack-nova | 00:16 | |
| *** slaweq_ has quit IRC | 00:16 | |
| *** andreas_s has quit IRC | 00:20 | |
| *** yangyapeng has quit IRC | 00:21 | |
| *** danice has quit IRC | 00:22 | |
| *** masber has quit IRC | 00:33 | |
| *** yamamoto has quit IRC | 00:36 | |
| *** yamamoto has joined #openstack-nova | 00:38 | |
| *** masber has joined #openstack-nova | 00:41 | |
| *** danpawlik has joined #openstack-nova | 00:42 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 00:43 |
|---|---|---|
| *** maciejjo1 has joined #openstack-nova | 00:43 | |
| Kevin_Zheng | mriedem Hi, could you check https://review.openstack.org/#/c/515631/ again when you got time? | 00:43 |
| *** yamamoto has quit IRC | 00:44 | |
| *** danpawlik_ has quit IRC | 00:44 | |
| *** maciejjozefczyk has quit IRC | 00:44 | |
| gmann | stephenfin: zuulv3- i did not find any other user for 'tempest-dsvm-neutron-src-oslo.versionedobject', we should move this to nova then, any specific reason for not moving it | 00:47 |
| *** masber has quit IRC | 00:47 | |
| *** armax has quit IRC | 00:47 | |
| *** hoangcx has joined #openstack-nova | 00:50 | |
| *** slaweq_ has joined #openstack-nova | 00:51 | |
| *** felipemonteiro has quit IRC | 00:51 | |
| mriedem | gmann: not nova, | 00:53 |
| mriedem | the oslo.versionedobject repo | 00:53 |
| gmann | mriedem: but they do not run this. its only needed by nova as of now | 00:53 |
| mriedem | it should be run by oslo.versionedobjects | 00:54 |
| gmann | but yea as its their lib testing then if they want to own | 00:54 |
| *** slaweq_ has quit IRC | 00:56 | |
| *** gyee has quit IRC | 00:56 | |
| gmann | mriedem: yea, as of now they do not run, they run only 'legacy-tempest-dsvm-neutron-src' | 00:57 |
| mriedem | isn't it the same thing? run the dsvm neutron job with src oslo.versionedobjects for the change in question? | 00:59 |
| mriedem | if the job is a duplicate, just drop it | 00:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention API behavior change when over quota limit https://review.openstack.org/515631 | 01:01 |
| mriedem | Kevin_Zheng: done | 01:01 |
| *** zhurong has joined #openstack-nova | 01:02 | |
| Kevin_Zheng | mriedem thanks, updating | 01:02 |
| mriedem | alex_xu: ^ want to get that? | 01:02 |
| mriedem | Kevin_Zheng: i already updated it | 01:02 |
| Kevin_Zheng | Ah, ok | 01:02 |
| gmann | mriedem: yea. as oslo run neutron job, it make sure their master src does not break anything. that is enough i think. | 01:06 |
| *** suresh12 has quit IRC | 01:08 | |
| *** chyka_ has joined #openstack-nova | 01:10 | |
| *** salv-orlando has joined #openstack-nova | 01:10 | |
| *** psachin has joined #openstack-nova | 01:10 | |
| *** phuongnh has joined #openstack-nova | 01:12 | |
| *** chyka has quit IRC | 01:13 | |
| *** fragatina has quit IRC | 01:14 | |
| *** fragatina has joined #openstack-nova | 01:15 | |
| *** salv-orlando has quit IRC | 01:15 | |
| *** chyka_ has quit IRC | 01:15 | |
| *** fragatina has quit IRC | 01:16 | |
| *** yangyapeng has joined #openstack-nova | 01:16 | |
| openstackgerrit | Merged openstack/nova-specs master: Remove the py27 tox target https://review.openstack.org/520680 | 01:17 |
| *** slaweq_ has joined #openstack-nova | 01:22 | |
| *** chyka has joined #openstack-nova | 01:24 | |
| *** chyka has quit IRC | 01:24 | |
| *** gouthamr has quit IRC | 01:24 | |
| *** slaweq_ has quit IRC | 01:27 | |
| mriedem | interesting fact, | 01:28 |
| *** ankit_ has joined #openstack-nova | 01:28 | |
| mriedem | my kid sings the star spangled banner when in the bathroom now, | 01:28 |
| mriedem | like all the time | 01:28 |
| *** trinaths has left #openstack-nova | 01:29 | |
| *** phuongnh has quit IRC | 01:35 | |
| mriedem | edleafe: https://review.openstack.org/#/c/495854/ for your morning | 01:37 |
| mriedem | missed something in my initial review | 01:37 |
| *** Apoorva_ has joined #openstack-nova | 01:37 | |
| mriedem | on the plus side, +2 on https://review.openstack.org/#/c/510159/ | 01:37 |
| *** Apoorva has quit IRC | 01:40 | |
| *** namnh has joined #openstack-nova | 01:40 | |
| *** namnh has quit IRC | 01:41 | |
| *** yamamoto has joined #openstack-nova | 01:41 | |
| *** Apoorva_ has quit IRC | 01:41 | |
| *** fragatina has joined #openstack-nova | 01:42 | |
| *** fragatina has quit IRC | 01:44 | |
| *** slaweq_ has joined #openstack-nova | 01:45 | |
| *** gouthamr has joined #openstack-nova | 01:45 | |
| *** yamamoto has quit IRC | 01:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 01:47 |
| *** lei-zh has joined #openstack-nova | 01:47 | |
| *** slaweq_ has quit IRC | 01:49 | |
| *** phuongnh has joined #openstack-nova | 01:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | 01:55 |
| mriedem | Kevin_Zheng: some more comments in https://review.openstack.org/524047 | 01:55 |
| Kevin_Zheng | mriedem: thx | 01:56 |
| *** Dinesh_Bhor has joined #openstack-nova | 01:56 | |
| *** mvk has quit IRC | 01:57 | |
| *** Shunli has joined #openstack-nova | 01:58 | |
| *** felipemonteiro has joined #openstack-nova | 01:58 | |
| *** mvk has joined #openstack-nova | 01:59 | |
| *** zhurong has quit IRC | 02:00 | |
| *** mriedem has quit IRC | 02:01 | |
| *** slaweq_ has joined #openstack-nova | 02:02 | |
| *** abalutoiu has quit IRC | 02:05 | |
| *** gcb has joined #openstack-nova | 02:06 | |
| *** slaweq_ has quit IRC | 02:07 | |
| *** armax has joined #openstack-nova | 02:08 | |
| *** cheneydc has joined #openstack-nova | 02:10 | |
| *** salv-orlando has joined #openstack-nova | 02:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix an error message in API validation https://review.openstack.org/524088 | 02:12 |
| *** salv-orlando has quit IRC | 02:16 | |
| *** felipemonteiro_ has joined #openstack-nova | 02:17 | |
| *** felipemonteiro has quit IRC | 02:20 | |
| *** felipemonteiro_ has quit IRC | 02:20 | |
| *** felipemonteiro_ has joined #openstack-nova | 02:21 | |
| *** amodi has joined #openstack-nova | 02:21 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix wrong argument order in functional test https://review.openstack.org/525363 | 02:24 |
| *** felipemonteiro_ has quit IRC | 02:25 | |
| *** suresh12 has joined #openstack-nova | 02:27 | |
| *** zhurong has joined #openstack-nova | 02:29 | |
| *** suresh12 has quit IRC | 02:31 | |
| *** annp has joined #openstack-nova | 02:33 | |
| alex_xu | Kevin_Zheng: should we doc that in the api-ref also? | 02:36 |
| Kevin_Zheng | alex_xu: which one? | 02:37 |
| alex_xu | Kevin_Zheng: https://review.openstack.org/#/c/515631/5 | 02:37 |
| alex_xu | Kevin_Zheng: since you said, it is user-noticeable API change...so I guess you want to get attention from the API user, not only the deployer? | 02:37 |
| *** slaweq_ has joined #openstack-nova | 02:38 | |
| Kevin_Zheng | I don't know, maybe it is too much details for normal users?> | 02:39 |
| *** masber has joined #openstack-nova | 02:39 | |
| alex_xu | Kevin_Zheng: yea, it shouldn't be too much detail, just something like after specific release, if overquota, you will get a error instance... | 02:39 |
| alex_xu | Kevin_Zheng: I guess that won't effect the API user too much | 02:40 |
| Kevin_Zheng | But we have only have a Master branch doc | 02:40 |
| alex_xu | Kevin_Zheng: actually more the end user, since they get an error instance, and they don't what happened. | 02:40 |
| Kevin_Zheng | it might be different for different versions | 02:41 |
| Kevin_Zheng | releases | 02:41 |
| alex_xu | Kevin_Zheng: ah, got it, there is config option | 02:41 |
| alex_xu | Kevin_Zheng: ok, just note in the release note, I think this is more important for the deployer/end user, I don't think that will break the API user app | 02:42 |
| alex_xu | Kevin_Zheng: done | 02:42 |
| *** suresh12 has joined #openstack-nova | 02:42 | |
| *** slaweq_ has quit IRC | 02:44 | |
| *** gouthamr has quit IRC | 02:46 | |
| *** gouthamr has joined #openstack-nova | 02:47 | |
| *** hongbin has joined #openstack-nova | 02:51 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/525006 | 02:52 |
| openstackgerrit | Merged openstack/nova master: Downgrade log for keystone verify client fail https://review.openstack.org/513243 | 02:52 |
| *** moshele has joined #openstack-nova | 02:53 | |
| *** cheneydc has quit IRC | 03:00 | |
| *** takashin has left #openstack-nova | 03:01 | |
| *** links has joined #openstack-nova | 03:07 | |
| *** slaweq_ has joined #openstack-nova | 03:10 | |
| *** suresh12 has quit IRC | 03:10 | |
| *** salv-orlando has joined #openstack-nova | 03:12 | |
| openstackgerrit | Wangpan proposed openstack/nova master: Handle glance exception during rotating instance backup https://review.openstack.org/523395 | 03:13 |
| *** slaweq_ has quit IRC | 03:15 | |
| *** salv-orlando has quit IRC | 03:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/525386 | 03:19 |
| *** abhishekk has joined #openstack-nova | 03:23 | |
| *** gouthamr has quit IRC | 03:23 | |
| *** edmondsw has quit IRC | 03:26 | |
| *** threestrands has joined #openstack-nova | 03:27 | |
| *** Apoorva has joined #openstack-nova | 03:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/525399 | 03:33 |
| *** gongysh has joined #openstack-nova | 03:43 | |
| *** slaweq_ has joined #openstack-nova | 03:44 | |
| *** thorst has joined #openstack-nova | 03:44 | |
| *** thorst has quit IRC | 03:46 | |
| *** slaweq_ has quit IRC | 03:48 | |
| *** yamamoto has joined #openstack-nova | 03:49 | |
| *** vladikr has quit IRC | 03:50 | |
| *** vladikr has joined #openstack-nova | 03:51 | |
| *** thorst has joined #openstack-nova | 03:53 | |
| *** thorst has quit IRC | 03:54 | |
| *** fragatina has joined #openstack-nova | 03:56 | |
| *** dave-mccowan has quit IRC | 04:00 | |
| *** fragatina has quit IRC | 04:01 | |
| *** gongysh has quit IRC | 04:06 | |
| *** hongbin has quit IRC | 04:07 | |
| *** coreywright has quit IRC | 04:07 | |
| *** amodi has quit IRC | 04:12 | |
| *** salv-orlando has joined #openstack-nova | 04:13 | |
| *** psachin has quit IRC | 04:15 | |
| *** fragatina has joined #openstack-nova | 04:17 | |
| *** slaweq_ has joined #openstack-nova | 04:17 | |
| *** salv-orlando has quit IRC | 04:18 | |
| *** hongbin has joined #openstack-nova | 04:20 | |
| *** slaweq_ has quit IRC | 04:22 | |
| *** coreywright has joined #openstack-nova | 04:25 | |
| *** tetsuro has joined #openstack-nova | 04:27 | |
| *** zhurong has quit IRC | 04:27 | |
| *** psachin has joined #openstack-nova | 04:30 | |
| *** yikun has quit IRC | 04:32 | |
| *** psachin has quit IRC | 04:32 | |
| *** yikun has joined #openstack-nova | 04:33 | |
| *** moshele has quit IRC | 04:37 | |
| *** hongbin has quit IRC | 04:39 | |
| *** nicolasbock has quit IRC | 04:48 | |
| *** yikun has quit IRC | 04:50 | |
| *** yikun has joined #openstack-nova | 04:51 | |
| *** udesale has joined #openstack-nova | 04:53 | |
| *** suresh12 has joined #openstack-nova | 04:53 | |
| *** slaweq_ has joined #openstack-nova | 04:54 | |
| *** zhurong has joined #openstack-nova | 04:54 | |
| *** jaosorior has joined #openstack-nova | 04:55 | |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** slaweq_ has quit IRC | 04:59 | |
| *** Dinesh_Bhor has quit IRC | 05:01 | |
| *** psachin has joined #openstack-nova | 05:10 | |
| *** salv-orlando has joined #openstack-nova | 05:14 | |
| *** edmondsw has joined #openstack-nova | 05:14 | |
| *** andreas_s has joined #openstack-nova | 05:16 | |
| *** moshele has joined #openstack-nova | 05:18 | |
| *** salv-orlando has quit IRC | 05:18 | |
| *** edmondsw has quit IRC | 05:18 | |
| *** andreas_s has quit IRC | 05:21 | |
| *** threestrands has quit IRC | 05:25 | |
| *** dklyle has joined #openstack-nova | 05:25 | |
| openstackgerrit | Merged openstack/nova master: Add regression test for rebuilding a volume-backed server https://review.openstack.org/521200 | 05:28 |
| *** david-lyle has quit IRC | 05:29 | |
| *** dklyle has quit IRC | 05:30 | |
| *** slaweq_ has joined #openstack-nova | 05:32 | |
| *** hshiina has joined #openstack-nova | 05:33 | |
| *** slaweq_ has quit IRC | 05:37 | |
| *** slaweq_ has joined #openstack-nova | 05:39 | |
| *** Apoorva has quit IRC | 05:41 | |
| *** vishwana_ has joined #openstack-nova | 05:41 | |
| *** sree has joined #openstack-nova | 05:41 | |
| *** slaweq_ has quit IRC | 05:44 | |
| *** fragatina has quit IRC | 05:44 | |
| *** vishwanathj has quit IRC | 05:45 | |
| *** gongysh has joined #openstack-nova | 05:47 | |
| *** lajoskatona has joined #openstack-nova | 05:50 | |
| *** janki has joined #openstack-nova | 05:58 | |
| *** chyka has joined #openstack-nova | 06:01 | |
| *** chyka has quit IRC | 06:06 | |
| *** sridharg has joined #openstack-nova | 06:09 | |
| *** Alex_Staf has joined #openstack-nova | 06:10 | |
| *** slaweq_ has joined #openstack-nova | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/524795 | 06:12 |
| *** salv-orlando has joined #openstack-nova | 06:14 | |
| *** slaweq_ has quit IRC | 06:15 | |
| *** coreywright has quit IRC | 06:16 | |
| *** coreywright has joined #openstack-nova | 06:18 | |
| *** salv-orlando has quit IRC | 06:19 | |
| *** oanson has quit IRC | 06:20 | |
| *** oanson has joined #openstack-nova | 06:20 | |
| *** gongysh has quit IRC | 06:25 | |
| *** jichen has joined #openstack-nova | 06:27 | |
| *** nore_rabel has joined #openstack-nova | 06:30 | |
| openstackgerrit | jichenjc proposed openstack/nova stable/pike: Downgrade log for keystone verify client fail https://review.openstack.org/525475 | 06:32 |
| *** alexchadin has joined #openstack-nova | 06:32 | |
| *** karthiks has joined #openstack-nova | 06:39 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:45 | |
| *** slaweq_ has joined #openstack-nova | 06:47 | |
| *** slaweq_ has quit IRC | 06:52 | |
| *** sree has quit IRC | 06:52 | |
| *** lei-zh has quit IRC | 06:53 | |
| *** lei-zh has joined #openstack-nova | 06:53 | |
| *** sree_ has joined #openstack-nova | 06:55 | |
| *** sree_ is now known as Guest18385 | 06:55 | |
| *** armax has quit IRC | 06:57 | |
| *** udesale__ has joined #openstack-nova | 06:58 | |
| *** udesale has quit IRC | 06:58 | |
| *** Guest18385 has quit IRC | 06:59 | |
| *** sree has joined #openstack-nova | 07:00 | |
| *** udesale has joined #openstack-nova | 07:00 | |
| *** vks1 has joined #openstack-nova | 07:00 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 07:00 |
| *** udesale__ has quit IRC | 07:02 | |
| *** edand has joined #openstack-nova | 07:02 | |
| *** jaianshu has joined #openstack-nova | 07:06 | |
| *** nore_rabel has quit IRC | 07:07 | |
| *** sree has quit IRC | 07:07 | |
| *** sree has joined #openstack-nova | 07:08 | |
| *** salv-orlando has joined #openstack-nova | 07:15 | |
| *** zhurong has quit IRC | 07:16 | |
| *** salv-orlando has quit IRC | 07:20 | |
| *** slaweq__ has joined #openstack-nova | 07:21 | |
| *** slaweq_ has joined #openstack-nova | 07:25 | |
| *** slaweq__ has quit IRC | 07:26 | |
| *** salv-orlando has joined #openstack-nova | 07:26 | |
| *** slaweq_ has quit IRC | 07:29 | |
| *** pcaruana has joined #openstack-nova | 07:32 | |
| *** tianhui is now known as hui | 07:36 | |
| *** sree has quit IRC | 07:37 | |
| *** sree has joined #openstack-nova | 07:37 | |
| *** andreas_s has joined #openstack-nova | 07:41 | |
| *** hui_ has joined #openstack-nova | 07:41 | |
| *** hui has quit IRC | 07:45 | |
| *** hui_ is now known as hui | 07:46 | |
| *** rcernin has quit IRC | 07:48 | |
| *** zhurong has joined #openstack-nova | 07:50 | |
| *** salv-orlando has quit IRC | 07:57 | |
| *** salv-orlando has joined #openstack-nova | 07:57 | |
| *** ralonsoh has joined #openstack-nova | 08:01 | |
| *** salv-orlando has quit IRC | 08:02 | |
| *** zsli_ has joined #openstack-nova | 08:02 | |
| *** sahid has quit IRC | 08:03 | |
| *** sahid has joined #openstack-nova | 08:03 | |
| *** artom_ has joined #openstack-nova | 08:04 | |
| *** vishwana_ has quit IRC | 08:04 | |
| *** vishwanathj has joined #openstack-nova | 08:04 | |
| *** edand has quit IRC | 08:04 | |
| *** zsli__ has joined #openstack-nova | 08:04 | |
| *** edand has joined #openstack-nova | 08:05 | |
| *** zsli__ has joined #openstack-nova | 08:05 | |
| *** lei-zh has quit IRC | 08:05 | |
| *** lei-zh1 has joined #openstack-nova | 08:05 | |
| *** Shunli has quit IRC | 08:05 | |
| *** artom has quit IRC | 08:07 | |
| *** zsli_ has quit IRC | 08:08 | |
| *** jaosorior_ has joined #openstack-nova | 08:10 | |
| *** NostawRm has quit IRC | 08:10 | |
| *** NostawRm has joined #openstack-nova | 08:10 | |
| *** jaosorior has quit IRC | 08:13 | |
| *** sshwarts has joined #openstack-nova | 08:13 | |
| *** brault has quit IRC | 08:17 | |
| *** slaweq_ has joined #openstack-nova | 08:19 | |
| *** tesseract has joined #openstack-nova | 08:24 | |
| *** mdnadeem has joined #openstack-nova | 08:27 | |
| *** priteau has joined #openstack-nova | 08:29 | |
| *** rcernin has joined #openstack-nova | 08:33 | |
| *** andreas_s has quit IRC | 08:35 | |
| *** andreas_s has joined #openstack-nova | 08:36 | |
| *** belmoreira has joined #openstack-nova | 08:37 | |
| *** brault has joined #openstack-nova | 08:37 | |
| *** suresh12 has quit IRC | 08:38 | |
| *** imacdonn has quit IRC | 08:39 | |
| *** imacdonn has joined #openstack-nova | 08:39 | |
| *** pcaruana has quit IRC | 08:40 | |
| *** alexchadin has quit IRC | 08:42 | |
| *** jaosorior_ is now known as jaosorior | 08:47 | |
| *** andreas_s has quit IRC | 08:47 | |
| *** salv-orlando has joined #openstack-nova | 08:47 | |
| *** andreas_s has joined #openstack-nova | 08:47 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2' https://review.openstack.org/484386 | 08:54 |
| *** jpena|off is now known as jpena | 08:55 | |
| *** gmann is now known as gmann_afk | 08:56 | |
| *** cdent has joined #openstack-nova | 08:57 | |
| *** salv-orlando has quit IRC | 08:57 | |
| *** salv-orlando has joined #openstack-nova | 08:57 | |
| *** abalutoiu has joined #openstack-nova | 08:58 | |
| *** zsli__ has quit IRC | 08:59 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [WIP] POC to use neutron port_list when filtering instance by ip https://review.openstack.org/525505 | 08:59 |
| *** salv-orlando has quit IRC | 09:02 | |
| *** diga has joined #openstack-nova | 09:02 | |
| *** hshiina has quit IRC | 09:07 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 09:10 |
| openstackgerrit | Merged openstack/nova master: Mention API behavior change when over quota limit https://review.openstack.org/515631 | 09:27 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova stable/pike: Mention API behavior change when over quota limit https://review.openstack.org/525511 | 09:28 |
| *** dtantsur|afk has quit IRC | 09:30 | |
| *** edand has quit IRC | 09:31 | |
| *** lucas-afk is now known as lucasagomes | 09:31 | |
| stephenfin | gmann_afk, mriedem: I left a big comment about the 'tempest-dsvm-neutron-src-oslo.versionedobject' job here https://review.openstack.org/#/c/514310/3/zuul.d/zuul-legacy-jobs.yaml | 09:32 |
| *** ttsiouts has quit IRC | 09:32 | |
| *** ttsiouts has joined #openstack-nova | 09:32 | |
| stephenfin | gmann_afk, mriedem: The tl;dr is that that job should be combined with a number of similar jobs and kept in a central location. There's nothing specific to o.v.o (or nova) about it | 09:33 |
| *** dtantsur has joined #openstack-nova | 09:33 | |
| *** dtantsur has quit IRC | 09:33 | |
| *** dtantsur has joined #openstack-nova | 09:33 | |
| *** dtantsur has quit IRC | 09:33 | |
| *** dtantsur has joined #openstack-nova | 09:38 | |
| *** derekh has joined #openstack-nova | 09:39 | |
| *** chyka has joined #openstack-nova | 09:40 | |
| *** Dinesh_Bhor has quit IRC | 09:44 | |
| *** chyka has quit IRC | 09:45 | |
| openstackgerrit | Merged openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306 | 09:45 |
| *** namnh has joined #openstack-nova | 09:45 | |
| *** owalsh_ is now known as owalsh | 09:52 | |
| *** mvk has quit IRC | 09:54 | |
| *** edand has joined #openstack-nova | 09:58 | |
| *** diga has quit IRC | 09:58 | |
| openstackgerrit | Merged openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | 10:03 |
| *** priteau has quit IRC | 10:03 | |
| *** priteau has joined #openstack-nova | 10:04 | |
| *** lei-zh1 has quit IRC | 10:05 | |
| *** vipul has quit IRC | 10:05 | |
| *** vipul has joined #openstack-nova | 10:08 | |
| *** priteau has quit IRC | 10:09 | |
| *** sambetts|afk is now known as sambetts | 10:14 | |
| *** priteau has joined #openstack-nova | 10:16 | |
| *** vipul has quit IRC | 10:19 | |
| *** vipul has joined #openstack-nova | 10:22 | |
| *** mvk has joined #openstack-nova | 10:22 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 10:23 |
| *** sree has quit IRC | 10:23 | |
| *** sree has joined #openstack-nova | 10:24 | |
| *** lei-zh has joined #openstack-nova | 10:24 | |
| *** namnh has quit IRC | 10:29 | |
| *** sree has quit IRC | 10:29 | |
| openstackgerrit | Merged openstack/nova master: Use ksa adapter for keystone conf & requests https://review.openstack.org/507693 | 10:29 |
| *** rcernin has quit IRC | 10:30 | |
| *** annp has quit IRC | 10:33 | |
| *** andreas_s has quit IRC | 10:47 | |
| *** andreas_s has joined #openstack-nova | 10:47 | |
| *** hoangcx has quit IRC | 10:49 | |
| *** lei-zh has quit IRC | 10:49 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Resolve review comments from I41b03a347 https://review.openstack.org/525255 | 10:50 |
| *** trungnv has quit IRC | 10:50 | |
| *** trungnv has joined #openstack-nova | 10:51 | |
| *** phuongnh has quit IRC | 10:52 | |
| *** phuongnh has joined #openstack-nova | 10:52 | |
| *** gszasz has joined #openstack-nova | 10:56 | |
| *** andreas_s has quit IRC | 10:56 | |
| *** abhishekk has quit IRC | 10:56 | |
| *** andreas_s has joined #openstack-nova | 10:57 | |
| *** Guest68950 has quit IRC | 10:58 | |
| *** hoangcx has joined #openstack-nova | 11:05 | |
| stephenfin | bauzas: Can you take a second look at this? https://review.openstack.org/#/c/466051/ | 11:05 |
| *** andreas_s has quit IRC | 11:07 | |
| cdent | stephenfin, bauzas, gibi : interesting grenade bug you might want to be aware of: https://bugs.launchpad.net/nova/+bug/1736385 | 11:09 |
| openstack | Launchpad bug 1736385 in OpenStack Compute (nova) "placement is not being properly restarted in grenade (pike to master)" [Undecided,New] | 11:09 |
| gibi | cdent: good catch | 11:11 |
| *** andreas_s has joined #openstack-nova | 11:12 | |
| cdent | I think it is a pretty easy fix in devstack, so gonna to try a test patch | 11:12 |
| gibi | cdent: I hope it did not hide a lot of undiscovered bugs | 11:13 |
| cdent | yeah, that’s my fear too | 11:13 |
| *** sree has joined #openstack-nova | 11:17 | |
| *** andreas_s has quit IRC | 11:22 | |
| *** andreas_s has joined #openstack-nova | 11:23 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Test devstack fix for process restart https://review.openstack.org/525534 | 11:25 |
| *** andreas_s has quit IRC | 11:27 | |
| *** yamamoto has quit IRC | 11:28 | |
| *** udesale has quit IRC | 11:29 | |
| openstackgerrit | Merged openstack/nova master: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/521391 | 11:30 |
| openstackgerrit | Merged openstack/nova master: [placement] Add aggregate link note in API ref https://review.openstack.org/521502 | 11:31 |
| openstackgerrit | Merged openstack/nova master: [placement] Fix foreign key constraint error https://review.openstack.org/516880 | 11:31 |
| *** vks1 has quit IRC | 11:31 | |
| *** phuongnh has quit IRC | 11:35 | |
| *** edand has quit IRC | 11:37 | |
| *** janki has quit IRC | 11:39 | |
| *** alexchadin has joined #openstack-nova | 11:42 | |
| *** andreas_s has joined #openstack-nova | 11:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add PowerVM to compute_driver options https://review.openstack.org/523978 | 11:43 |
| *** edand has joined #openstack-nova | 11:48 | |
| openstackgerrit | wanghongxu proposed openstack/nova master: Update cinder info when attach volume that attached https://review.openstack.org/525540 | 11:52 |
| *** tbachman has quit IRC | 11:53 | |
| openstackgerrit | Merged openstack/nova master: Make _Provider really private https://review.openstack.org/523932 | 11:55 |
| openstackgerrit | Merged openstack/nova master: ProviderTree.get_provider_uuids() https://review.openstack.org/520243 | 11:55 |
| *** edmondsw has joined #openstack-nova | 11:58 | |
| *** smatzek has joined #openstack-nova | 11:59 | |
| *** lei-zh has joined #openstack-nova | 12:01 | |
| *** nicolasbock has joined #openstack-nova | 12:03 | |
| *** sridharg has quit IRC | 12:04 | |
| *** lei-zh has quit IRC | 12:05 | |
| *** edmondsw has quit IRC | 12:05 | |
| *** tetsuro has quit IRC | 12:12 | |
| *** lucasagomes is now known as lucas-hungry | 12:13 | |
| *** yassine has joined #openstack-nova | 12:14 | |
| *** yassine is now known as Guest35678 | 12:14 | |
| *** yikun has quit IRC | 12:20 | |
| *** yamamoto has joined #openstack-nova | 12:28 | |
| *** yamamoto has quit IRC | 12:31 | |
| *** yamamoto has joined #openstack-nova | 12:31 | |
| *** alexchadin has quit IRC | 12:34 | |
| *** alexchadin has joined #openstack-nova | 12:35 | |
| cdent | stephenfin, bauzas : are you guys able to comment whether specless is okay for this blueprint? https://blueprints.launchpad.net/nova/+spec/vmware-boot-uefi there’s already an implementation and Ken’ichi (on the review) seemed to think so. | 12:36 |
| *** zhurong has quit IRC | 12:36 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 12:37 |
| *** yamamoto has quit IRC | 12:38 | |
| openstackgerrit | Hengqing Hu proposed openstack/nova master: Remove build_sphinx section from setup.cfg https://review.openstack.org/525587 | 12:38 |
| *** yamamoto has joined #openstack-nova | 12:40 | |
| *** alexchadin has quit IRC | 12:40 | |
| *** alexchadin has joined #openstack-nova | 12:41 | |
| *** ratailor has quit IRC | 12:43 | |
| *** mvenesio has joined #openstack-nova | 12:43 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: validate SCSI controller model https://review.openstack.org/525055 | 12:44 |
| *** sree has quit IRC | 12:44 | |
| *** zhurong has joined #openstack-nova | 12:44 | |
| *** david-lyle has joined #openstack-nova | 12:48 | |
| *** jpena is now known as jpena|lunch | 12:48 | |
| openstackgerrit | Alexandru Muresan proposed openstack/nova master: Fix driver tests on Windows https://review.openstack.org/518525 | 12:48 |
| *** tbachman has joined #openstack-nova | 12:50 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 12:52 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 12:52 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 12:52 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 12:52 |
| jaypipes | alex_xu: ^^ added additional func test that includes resources filter along with tree filter | 12:52 |
| jaypipes | alex_xu: I prefer just "tree" to "in_tree", but if everyone else wants to change it, I can | 12:53 |
| *** tbachman has quit IRC | 12:54 | |
| *** BryanS68 has joined #openstack-nova | 12:55 | |
| cdent | jaypipes, alex_xu : It is somewhat confusing, but I’m not sure what’s right. There’s a part of me that thinks ‘tree’ actually ought to be a boolean: give me the results and anything else which is a relative in the trees of any results | 12:59 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 13:00 |
| dmsimard | kashyap: ping ? | 13:00 |
| *** tbachman has joined #openstack-nova | 13:01 | |
| openstackgerrit | Merged openstack/nova master: Fix wrong argument order in functional test https://review.openstack.org/525363 | 13:01 |
| dmsimard | Was wondering if you had come across my question yesterday: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-12-04.log.html#t2017-12-04T17:26:46 | 13:01 |
| *** david-lyle has quit IRC | 13:01 | |
| *** zhurong has quit IRC | 13:02 | |
| *** zhurong has joined #openstack-nova | 13:02 | |
| kashyap | dmsimard: Hey | 13:04 |
| kashyap | dmsimard: I did have my proxy catch it, I just didn't get around to it. | 13:04 |
| * kashyap clicks now | 13:04 | |
| *** edmondsw has joined #openstack-nova | 13:06 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add an online migration for BDM.uuid https://review.openstack.org/525599 | 13:07 |
| dmsimard | kashyap: thanks, much appreciated. | 13:08 |
| kashyap | dmsimard: Reading the bug report, VM building can hang w/ libguestfs & TCG | 13:08 |
| kashyap | dmsimard: Still catching up on the bug report & libguestfs mailing list thread linked in there | 13:08 |
| dmsimard | Yeah.. I summarized the issue in the eavesdrop link | 13:09 |
| *** alexchadin has quit IRC | 13:09 | |
| kashyap | dmsimard: Ah-ha! So, TCG didn't fully take effect | 13:09 |
| *** lucas-hungry is now known as lucasagomes | 13:14 | |
| kashyap | dmsimard: Related aside: Do we have any plans (at least it has been talked about since Paris Summit) to test in a portion of Infra with actual Nested KVM? | 13:14 |
| kashyap | dmsimard: In the past, the argument was: "It's a bit unstable / buggy". But no bugs were filed. Probably it'd be useful to think about enabling actual nVMX (Intel) / nSVM (AMD) for a portion of the Infra Cloud. | 13:15 |
| dmsimard | Not sure, I'd love to of course but my opinion doesn't really matter :D | 13:16 |
| dmsimard | It's about nodepool providers supporting it or not | 13:16 |
| openstackgerrit | Merged openstack/nova master: Fix some incorrect option references for scheduler filters https://review.openstack.org/521645 | 13:16 |
| openstackgerrit | Merged openstack/nova master: Deprecate the IronicHostManager https://review.openstack.org/521648 | 13:16 |
| openstackgerrit | Merged openstack/nova master: Fix invalid minRam error message https://review.openstack.org/523142 | 13:16 |
| openstackgerrit | Merged openstack/nova master: Add description for resource class creation https://review.openstack.org/508083 | 13:17 |
| kashyap | dmsimard: Yeah, I know it's not in your hands; it's with node providers; Rackspace Infra uses Xen, so that's out of scope. | 13:18 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: DriverBlockDevice: make subclasses inherit _proxy_as_attr https://review.openstack.org/524167 | 13:19 |
| *** peter-hamilton has joined #openstack-nova | 13:19 | |
| *** alexchadin has joined #openstack-nova | 13:21 | |
| dmsimard | kashyap: need to brb | 13:22 |
| *** links has quit IRC | 13:22 | |
| kashyap | dmsimard: It's fine; I too need to be briefly AFK to finish some paperwork | 13:22 |
| kashyap | (Not now, in a few) | 13:22 |
| *** liverpooler has joined #openstack-nova | 13:26 | |
| *** zhurong has quit IRC | 13:27 | |
| *** pchavva has joined #openstack-nova | 13:28 | |
| *** jaianshu has quit IRC | 13:30 | |
| *** READ10 has joined #openstack-nova | 13:30 | |
| *** udesale has joined #openstack-nova | 13:32 | |
| openstackgerrit | Merged openstack/nova master: Add debug information to metadata requests https://review.openstack.org/511895 | 13:32 |
| openstackgerrit | Merged openstack/nova master: [placement]Enhance doc for placement allocation list https://review.openstack.org/511715 | 13:32 |
| openstackgerrit | Merged openstack/nova master: Fix TypeError in nova-manage db archive_deleted_rows https://review.openstack.org/520765 | 13:32 |
| *** psachin has quit IRC | 13:33 | |
| *** yangyapeng has quit IRC | 13:33 | |
| *** yangyapeng has joined #openstack-nova | 13:34 | |
| *** moshele has quit IRC | 13:37 | |
| alex_xu | cdent: so "tree=True&resources=...." means that give me the tree which match those resources? | 13:38 |
| *** yangyapeng has quit IRC | 13:38 | |
| stephenfin | cdent: I think it best to ask mriedem that | 13:38 |
| *** moshele has joined #openstack-nova | 13:39 | |
| alex_xu | jaypipes: thanks | 13:39 |
| cdent | alex_xu: sort of: for the resource providers that satisfy the resources request, return those resource providers and their trees | 13:39 |
| jaypipes | cdent: what do you mean by "and their trees"? | 13:40 |
| *** janki has joined #openstack-nova | 13:40 | |
| cdent | jaypipes: if rp X has a parent of Y and a sibling of Z, all of X Y and Z would return | 13:41 |
| cdent | (where X satisfies resources) | 13:41 |
| jaypipes | cdent: the problem with that is due to GET /resource_providers not returning information about inventory or allocations, you would have no idea *which* of the resource providers met the resources query. | 13:41 |
| *** sahid has quit IRC | 13:41 | |
| jaypipes | cdent: for GET /allocation_candidates, we will return the provider information (in the provider summaries section) for all providers in the tree of resource providers included in allocation requests. | 13:42 |
| cdent | yeah, I know. It’s how tree “feels” as a param though | 13:42 |
| cdent | the meaning you’ve made is “limit to tree”, yes? | 13:42 |
| jaypipes | cdent: do you prefer "in_tree" then? or something else entirely? | 13:42 |
| cdent | I can’t decide. I’m trying to talk out loud to see if anything reasonable leaks out | 13:43 |
| jaypipes | cdent: the meaning of "tree=X" is "get the root provider UUID of X and return all providers in that tree" | 13:43 |
| jaypipes | cdent: so yeah, "limit to this provider's tree" is what the filter says. | 13:43 |
| jaypipes | cdent: just want to be clear that "X" doesn't need to be the root provider UUID. | 13:44 |
| jaypipes | cdent: it can be any old resource provider UUID. we look up that provider's root UUID. | 13:44 |
| cdent | and if some other parameter (like resources) is present, and X isn’t in the resource satisfyng rps, no resource, right? | 13:44 |
| cdent | s/no resource/no results/ | 13:45 |
| jaypipes | correct | 13:45 |
| efried_cya_wed | I was thinking ?tree=X&resources=Y would mean, "find me only the providers from within tree X that have resources Y" | 13:45 |
| cdent | efried_cya_wed: it is not wed, go away | 13:45 |
| efried_cya_wed | I.e. explicitly *not* the whole tree. | 13:45 |
| jaypipes | efried_cya_wed: that is precisely what it means. | 13:45 |
| jaypipes | efried_cya_wed: filters are "ANDed" together... | 13:45 |
| cdent | I reckon in_tree is better | 13:46 |
| cdent | but not hugely so | 13:46 |
| alex_xu | cdent: X isn't in the resource satisfying rps, there may have result, for the case, the other rps match the resource in the tree | 13:46 |
| *** yamamoto has quit IRC | 13:47 | |
| jaypipes | alex_xu: yes, that's true. if X is a grandchild and Y is a child, and Y has all the resources needed, then Y would be returned, yes. | 13:48 |
| alex_xu | jaypipes: yea | 13:48 |
| *** liverpooler has quit IRC | 13:49 | |
| *** liverpooler has joined #openstack-nova | 13:49 | |
| jaypipes | alex_xu: we could call the filter 木 :) | 13:50 |
| cdent | so a) in_tree is beginning to sound better to me, b) what’s the use case? when does a client want to do this? | 13:50 |
| jaypipes | cdent: this is primarily going to be called by the scheduler report client's get_providers_in_tree() method which will populate a ProviderTree structure that is passed to the virt driver to populate | 13:51 |
| alex_xu | jaypipes: you mean tree? it should be 树，木 is wood :) | 13:51 |
| cdent | jaypipes: so in that case only the tree param is used, yes? | 13:51 |
| jaypipes | alex_xu: crap! there's like 15 symbols that are "tree" in Google translate ;) | 13:52 |
| alex_xu | haha | 13:52 |
| *** artom_ has quit IRC | 13:52 | |
| * jaypipes picked the wrong one apparently. | 13:52 | |
| *** mlavalle has joined #openstack-nova | 13:53 | |
| jaypipes | cdent: yeah, in that case, only the tree filter is used | 13:53 |
| *** mriedem has joined #openstack-nova | 13:53 | |
| alex_xu | the chinese version 'GET /资源_提供者?树=...&资源=...' | 13:53 |
| *** jpena|lunch is now known as jpena | 13:57 | |
| *** dave-mcc_ has joined #openstack-nova | 13:58 | |
| alex_xu | jaypipes: I guess cdent is asking the use case of tree+resources | 13:59 |
| *** jichen has quit IRC | 13:59 | |
| *** gongysh has joined #openstack-nova | 13:59 | |
| cdent | not really. I agree that if we have filters, they should all be allowed and all should be and-ed | 13:59 |
| cdent | I also agree that some combinations are weird | 13:59 |
| cdent | but as long as we are and-ing correctly it is okay | 14:00 |
| cdent | I don’t want us to be saying that some filter combinations are disallowed | 14:00 |
| efried_cya_wed | ++ | 14:00 |
| efried_cya_wed | Realistically, there are combinations consumers won't use because they don't make any sense. And that should be fine. | 14:01 |
| alex_xu | cdent: +1 | 14:02 |
| *** esberglu has joined #openstack-nova | 14:03 | |
| *** artom has joined #openstack-nova | 14:04 | |
| *** gongysh has quit IRC | 14:04 | |
| *** lyan has joined #openstack-nova | 14:08 | |
| *** thorst has joined #openstack-nova | 14:09 | |
| *** yamamoto has joined #openstack-nova | 14:11 | |
| * efried_cya_wed is actually leaving now. Have a great day! | 14:13 | |
| *** abhishekk has joined #openstack-nova | 14:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: [placement] Fix foreign key constraint error https://review.openstack.org/525620 | 14:17 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 14:20 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 14:20 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Add a new check to volume attach https://review.openstack.org/525622 | 14:20 |
| ildikov | mriedem: first attempt ^^ | 14:21 |
| mriedem | ack | 14:22 |
| ildikov | mriedem: I might've bumped the service version too early... :/ | 14:22 |
| mriedem | yup | 14:23 |
| mriedem | https://review.openstack.org/#/c/525622/1/nova/objects/service.py shouldn't be in there | 14:23 |
| ildikov | yeah, I realized 5 minutes ago... | 14:24 |
| mriedem | what is this? https://review.openstack.org/#/c/525622/1/nova/volume/cinder.py | 14:24 |
| *** vks1 has joined #openstack-nova | 14:24 | |
| ildikov | checking the cinder microversion | 14:24 |
| ildikov | or well, making it possible to do so | 14:24 |
| ildikov | independently from the attachment_* calls | 14:25 |
| mriedem | i don't think we want/need that in this patch, | 14:25 |
| mriedem | what i was thinking was in the change that introduces _check_volume_already_attached_to_instance, | 14:25 |
| mriedem | we'd just implement the usage of that in swap_volume, | 14:25 |
| mriedem | because in swap volume we know if we're doing old or new flow based on the bdm.attachment_id, | 14:25 |
| mriedem | in attach_volume we don't | 14:25 |
| mriedem | so we need to leave the attach_volume changes for the last patch that adds the new flow | 14:26 |
| *** gszasz has quit IRC | 14:26 | |
| ildikov | ah, ok | 14:27 |
| ildikov | so you wanted to split out like 10 lines of code change? | 14:27 |
| mriedem | it's more than that | 14:28 |
| mriedem | it's the new method, plus the usage in swap_volume, plus tests | 14:28 |
| ildikov | ok, 20 | 14:28 |
| mriedem | ok - just leave it all in a 2K LOC change and we won't merge any of it if that's what you want | 14:28 |
| ildikov | Jesus, Mary, St Joseph and the camel | 14:29 |
| ildikov | sigh, no, I'll go and start over | 14:29 |
| mriedem | i'm trying to help you split the things out that can be split out to make the main end patch more manageable for reviewers, | 14:29 |
| mriedem | if we don't want to do that, then i'll give up | 14:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix ValueError if invalid max_rows passed to db purge https://review.openstack.org/525628 | 14:31 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix TypeError in nova-manage db archive_deleted_rows https://review.openstack.org/525629 | 14:31 |
| ildikov | no, don't, I'm sorry, flying freaks me out, so I'm a few levels up regarding stress right now | 14:31 |
| ildikov | and I've just uploaded the 167th revision which gives my stomach an extra bump... :/ :) | 14:32 |
| ildikov | will ping you when I have a next version | 14:33 |
| mriedem | ok | 14:33 |
| *** alexchadin has quit IRC | 14:35 | |
| *** sahid has joined #openstack-nova | 14:36 | |
| sambetts | jaypipes: Is there a bug in Nova tracking the placement race condition we identified at the PTG between nova releasing the allocation and the ironic virt driver setting the number of resources available to zero? | 14:38 |
| jaypipes | sambetts: not sure I follow you... | 14:40 |
| *** udesale has quit IRC | 14:40 | |
| *** BryanS68 has quit IRC | 14:41 | |
| sambetts | jaypipes: the race condition where on "nova delete" of an instance the allocation in placement is released so the node becomes free again, but its not actually free because Ironic is cleaning the node, so we set the resources to zero but for a brief period of time the node in placement can be reallocated because the resources are updated in a timed loop | 14:42 |
| *** abhishekk has quit IRC | 14:43 | |
| jaypipes | sambetts: but the node is not "available" according to the Ironic virt driver when it's being cleaned and therefore will not appear to the scheduler as passing the compute filter. | 14:44 |
| *** moshele has quit IRC | 14:44 | |
| *** edand has quit IRC | 14:44 | |
| *** abalutoiu has quit IRC | 14:44 | |
| *** abalutoiu has joined #openstack-nova | 14:45 | |
| sambetts | jaypipes: its only not avaiable because we set the avaiable resources for that node to zero, but the avaiable resources isn't refreshed instantly after an instance is deleted, but the allocation in placement is freed | 14:46 |
| *** jaosorior has quit IRC | 14:46 | |
| sambetts | so the node in placement can be reallocated until the resource tracker updates the avaiable resources | 14:46 |
| jaypipes | sambetts: the allocation is deleted properly (the instance is no longer consuming resources on that node). it is the node itself that is marked as not available and therefore won't be scheduled to. | 14:47 |
| sambetts | jaypipes: I'm not sure what you mean the node is marked as not avaiable, as far as I'm aware that happens by setting the resources to zero and then that causes the code to remove it from placement so it can't be scheduled too, is that what you are refering too | 14:49 |
| sambetts | ? | 14:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for rebuilding a volume-backed server https://review.openstack.org/525632 | 14:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Only query BDMs once in API during rebuild https://review.openstack.org/525633 | 14:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/525634 | 14:49 |
| *** udesale has joined #openstack-nova | 14:50 | |
| jaypipes | sambetts: I'm referring to the scheduler, not placement. the scheduler checks to see whether a compute node/service is up and available to take requests before it attempts to schedule an instance to it. that check will return False for an Ironic node that is cleaning state. | 14:51 |
| openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/525399 | 14:51 |
| sambetts | jaypipes: is that new? I've never heard of that before | 14:52 |
| jaypipes | sambetts: so placement might return that Ironic node to the scheduler as having space (now that the allocation was deleted), but the scheduler won't pick it until the node is available. | 14:52 |
| jaypipes | sambetts: no, that's been like that since the beginning. | 14:53 |
| *** gcb has quit IRC | 14:53 | |
| jaypipes | sambetts: https://github.com/openstack/nova/blob/master/nova/scheduler/driver.py#L55-L61 | 14:54 |
| *** gcb has joined #openstack-nova | 14:54 | |
| jaypipes | though I'm looking at that now and seeing it's referring to the service (i.e. the nova-compute), not the baremetal node | 14:54 |
| jaypipes | ffs | 14:54 |
| *** BryanS68 has joined #openstack-nova | 14:54 | |
| jaypipes | this is why we can't ever have nice code... | 14:54 |
| sambetts | :/ never seen anything like that in our driver, its all done based on resources | 14:55 |
| *** lpetrut has joined #openstack-nova | 14:55 | |
| sambetts | yeah :/ | 14:55 |
| *** armax has joined #openstack-nova | 14:56 | |
| jaypipes | sambetts: well, there's this patch which should at least help with the Ironic situation: https://review.openstack.org/#/c/513526/ | 14:57 |
| *** awaugama has joined #openstack-nova | 14:57 | |
| jaypipes | sambetts: that randomizes the returned results from placement so that (as is the case with Ironic) you won't always get back the same top node. | 14:57 |
| *** jmlowe has joined #openstack-nova | 14:59 | |
| *** udesale has quit IRC | 14:59 | |
| sambetts | that'll certainly help, the other thing I think we suggested at the PTG was that we somehow instead of the resources getting marked as zero and then removed from placement all the time, we use the reserved field (although I'm still not sure that solves the race) | 14:59 |
| *** slaweq_ is now known as slaweq | 15:00 | |
| *** gszasz has joined #openstack-nova | 15:01 | |
| sambetts | the race occurs because the resource tracker is async from the allocation getting deleted, so I'm sure what the right thing to do is there, unless we can force an refresh of that as soon as the resources are freed but then there is still a small period of time while the resource tracker runs | 15:01 |
| sambetts | someone mentioned at the PTG that there are some hypervisors that have the same behaviour as this where even though an allocation has been deleted the resources aren't actually available for use yet | 15:03 |
| sambetts | I'm trying to dig up the notes from the PTG session on it | 15:03 |
| *** amodi has joined #openstack-nova | 15:08 | |
| *** Tom-Tom has joined #openstack-nova | 15:08 | |
| *** Alex_Staf has quit IRC | 15:09 | |
| sambetts | hmmm I can't find any notes on the topic in the etherpads :( johnthetubaguy do you remember this conversation at the PTG ^ | 15:10 |
| *** edand has joined #openstack-nova | 15:13 | |
| *** janki has quit IRC | 15:13 | |
| *** david-lyle has joined #openstack-nova | 15:13 | |
| *** diga has joined #openstack-nova | 15:13 | |
| *** janki has joined #openstack-nova | 15:14 | |
| *** janki has quit IRC | 15:14 | |
| *** janki has joined #openstack-nova | 15:15 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Add a new check to volume attach https://review.openstack.org/525622 | 15:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 15:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 15:19 |
| ildikov | mriedem: ^^ | 15:20 |
| *** sree has joined #openstack-nova | 15:21 | |
| *** Yingxin has quit IRC | 15:23 | |
| *** Yingxin has joined #openstack-nova | 15:25 | |
| *** sree has quit IRC | 15:26 | |
| mriedem | ack | 15:26 |
| *** gouthamr has joined #openstack-nova | 15:29 | |
| *** lajoskatona has left #openstack-nova | 15:31 | |
| *** rm_work has quit IRC | 15:32 | |
| *** Apoorva has joined #openstack-nova | 15:32 | |
| *** hongbin has joined #openstack-nova | 15:33 | |
| *** udesale has joined #openstack-nova | 15:36 | |
| *** rm_work has joined #openstack-nova | 15:36 | |
| *** Apoorva has quit IRC | 15:37 | |
| *** sree has joined #openstack-nova | 15:37 | |
| *** gszasz has quit IRC | 15:38 | |
| *** david-lyle has quit IRC | 15:39 | |
| *** Apoorva has joined #openstack-nova | 15:39 | |
| *** udesale has quit IRC | 15:41 | |
| *** udesale has joined #openstack-nova | 15:42 | |
| *** sree has quit IRC | 15:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add regression test for rebuilding a volume-backed server https://review.openstack.org/525664 | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Only query BDMs once in API during rebuild https://review.openstack.org/525665 | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Get original image_id from volume for volume-backed instance rebuild https://review.openstack.org/525666 | 15:44 |
| *** openstackgerrit has quit IRC | 15:48 | |
| *** openstackgerrit has joined #openstack-nova | 15:48 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 15:48 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 15:48 |
| *** tidwellr has joined #openstack-nova | 15:49 | |
| *** gszasz has joined #openstack-nova | 15:50 | |
| *** jmlowe has quit IRC | 15:56 | |
| *** jmlowe has joined #openstack-nova | 15:57 | |
| *** slaweq is now known as slaweq_ | 15:58 | |
| *** jmlowe has quit IRC | 15:59 | |
| *** jmlowe_ has joined #openstack-nova | 16:01 | |
| edleafe | mriedem: time for a question re: alternates for migration? | 16:01 |
| *** hamzy has quit IRC | 16:02 | |
| *** jmlowe_ has quit IRC | 16:02 | |
| edleafe | if I set return_alternates to True as you suggest, what should then happen to the alternates? | 16:02 |
| mriedem | cold migrate / resize right? | 16:03 |
| edleafe | mriedem: yeah: https://review.openstack.org/#/c/516707/17/nova/conductor/tasks/migrate.py@244 | 16:03 |
| mriedem | well, presumably the same thing as happens when build_and_run_instances gets alternates and sends them to compute, which can send them back to build_instances on a reschedule | 16:04 |
| *** belmoreira has quit IRC | 16:04 | |
| mriedem | so we have 2 reschedule loops: | 16:04 |
| edleafe | well, I'm unfamiliar with those code pathways, so IYO will that be a major change to those methods? | 16:05 |
| mriedem | 1. superconductor:schedule_and_build_instances -> compute:build_and_run_instance -> cellconductor:build_instances | 16:05 |
| mriedem | 2. superconductor:resize_instance -> compute:prep_resize -> cellconductor:resize_instance | 16:05 |
| mriedem | well, looking at https://review.openstack.org/#/c/511358/29/nova/compute/manager.py | 16:06 |
| mriedem | it looks like it would be a matter of passing host_list to prep_resize in the compute | 16:06 |
| mriedem | and like what you have here in conductor manager (this is cell conductor at this point during a reschedule): | 16:07 |
| mriedem | https://review.openstack.org/#/c/511358/29/nova/conductor/manager.py@517 | 16:07 |
| mriedem | you would have to do the same for the resize reschedule here https://review.openstack.org/#/c/511358/29/nova/conductor/api.py@87 | 16:07 |
| *** coreywright has quit IRC | 16:07 | |
| edleafe | ok, next question: should I add that all to the existing patches, or split it into two? | 16:07 |
| mriedem | now, we could arguably do the build and resize + alternates in separate patches | 16:08 |
| mriedem | heh | 16:08 |
| mriedem | split is obviously easier for review | 16:08 |
| mriedem | it would mean 2 compute rpc version bumps | 16:08 |
| mriedem | but service version bumps are free, so i don't think that's a big deal | 16:08 |
| mriedem | dansmith: ^ agree? | 16:08 |
| edleafe | ok, so I'll leave return_alternates=False in the current patch, and then flip it when in a new patch that bumps the compute RPC again. | 16:09 |
| mriedem | makes sense | 16:10 |
| edleafe | ok | 16:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix doubling allocations on rebuild https://review.openstack.org/521662 | 16:11 |
| mriedem | jaypipes: ^ is that cve fix (now disclosed) with the bug link and a release note; melwitt can you also look at ^ | 16:11 |
| melwitt | mriedem: sure | 16:12 |
| dansmith | mriedem: I like to avoid bumps of both rpc and service version when possible, and it usually is.. but yes, they're free | 16:13 |
| *** gbarros has quit IRC | 16:13 | |
| *** gbarros has joined #openstack-nova | 16:13 | |
| *** thorst has quit IRC | 16:15 | |
| *** diga has quit IRC | 16:15 | |
| *** coreywright has joined #openstack-nova | 16:20 | |
| *** suresh12 has joined #openstack-nova | 16:22 | |
| *** udesale has quit IRC | 16:23 | |
| bauzas | mriedem: just +2d the cve fix | 16:24 |
| mriedem | bauzas: thanks | 16:24 |
| bauzas | now the bug is disclosed, we can move on | 16:24 |
| bauzas | sorry for having paid a lot of attention for that bug tho, but the overall direction looked good to me a while ago | 16:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for rebuild with new image doubling allocations https://review.openstack.org/523213 | 16:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix doubling allocations on rebuild https://review.openstack.org/523214 | 16:25 |
| bauzas | ie. using the hints for passing whether it's a rebuild or not | 16:25 |
| *** Tom-Tom has quit IRC | 16:25 | |
| *** andreas_s has quit IRC | 16:26 | |
| *** andreas_s has joined #openstack-nova | 16:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix doubling allocations on rebuild https://review.openstack.org/523214 | 16:30 |
| *** andreas_s has quit IRC | 16:31 | |
| mriedem | sdague: can you hit https://review.openstack.org/#/c/523194/ again? alex had pointed out something so i lost your +2 | 16:32 |
| *** hamzy_ has joined #openstack-nova | 16:37 | |
| *** mvk has quit IRC | 16:42 | |
| *** hamzy has joined #openstack-nova | 16:42 | |
| *** READ10 has quit IRC | 16:43 | |
| *** READ10 has joined #openstack-nova | 16:44 | |
| *** hamzy_ has quit IRC | 16:46 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Refactor the code to check for sufficient hosts https://review.openstack.org/520242 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the to_dict() method to the Selection object https://review.openstack.org/523492 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Modify select_destinations() to return objects and alts https://review.openstack.org/510159 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/516707 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 16:46 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 16:46 |
| edleafe | mriedem: ^^ addresses your concerns | 16:46 |
| edleafe | mriedem: I'll start on the migrate/resize patch next | 16:47 |
| jaypipes | mriedem: cool, will look shortly, soon as I finish up a rebase of efried_cya_wed's series | 16:47 |
| mriedem | edleafe: ok | 16:48 |
| *** sahid has quit IRC | 16:48 | |
| *** chyka has joined #openstack-nova | 16:49 | |
| *** chyka_ has joined #openstack-nova | 16:53 | |
| *** hamzy has quit IRC | 16:54 | |
| *** chyka has quit IRC | 16:57 | |
| *** gszasz has quit IRC | 16:57 | |
| *** rmart04 has joined #openstack-nova | 16:59 | |
| *** rmart04 has quit IRC | 17:00 | |
| *** diga has joined #openstack-nova | 17:01 | |
| *** fragatina has joined #openstack-nova | 17:01 | |
| *** janki has quit IRC | 17:02 | |
| *** fragatin_ has joined #openstack-nova | 17:02 | |
| *** derekh has quit IRC | 17:03 | |
| *** fragatina has quit IRC | 17:06 | |
| *** suresh12 has quit IRC | 17:07 | |
| *** Guest35678 has quit IRC | 17:07 | |
| *** Apoorva has quit IRC | 17:07 | |
| *** suresh12 has joined #openstack-nova | 17:08 | |
| *** moshele has joined #openstack-nova | 17:11 | |
| melwitt | mriedem: now that we're pulling in the dependent os-brick changes, I'm +2 on https://review.openstack.org/#/c/400384 | 17:11 |
| *** suresh12 has quit IRC | 17:14 | |
| *** mvk has joined #openstack-nova | 17:14 | |
| *** moshele has quit IRC | 17:16 | |
| *** slaweq_ has quit IRC | 17:19 | |
| *** damien_r has quit IRC | 17:19 | |
| *** suresh12 has joined #openstack-nova | 17:19 | |
| *** mdnadeem has quit IRC | 17:20 | |
| *** pcaruana has joined #openstack-nova | 17:22 | |
| *** suresh12 has quit IRC | 17:22 | |
| *** sshwarts has quit IRC | 17:22 | |
| *** suresh12 has joined #openstack-nova | 17:23 | |
| *** lpetrut has quit IRC | 17:23 | |
| *** BryanS68 has quit IRC | 17:23 | |
| *** pcaruana has quit IRC | 17:26 | |
| *** lucasagomes is now known as lucas-afk | 17:27 | |
| *** pcaruana has joined #openstack-nova | 17:27 | |
| *** dtantsur is now known as dtantsur|afk | 17:27 | |
| *** suresh12 has quit IRC | 17:28 | |
| jaypipes | cdent: still around? | 17:32 |
| cdent | yessir, still fighting with this grenade stuff | 17:32 |
| jaypipes | cdent: so I don't believe those comments on the API ref thing on the nested resource providers work are correct... | 17:33 |
| cdent | was just reading your responses, one sec | 17:33 |
| jaypipes | I'm also getting sort of annoyed with this :) | 17:34 |
| cdent | jaypipes: I think the confusion is whether what’s listed at /resource_providers is the full rep or not | 17:35 |
| cdent | and up to now it has been: generation, uuid, name, links | 17:35 |
| cdent | https://developer.openstack.org/api-ref/placement/#list-resource-providers | 17:35 |
| jaypipes | no, up until now it's been incorrect. it lists resource_providers (the collective attribute), along with the singular attirbutes | 17:35 |
| cdent | which “it” do you mean? | 17:36 |
| jaypipes | GET /resource_providers response | 17:36 |
| cdent | so you’re saying that for the past 13 microversions what we’ve had at that link above (expand the response example) has been wrong? | 17:36 |
| jaypipes | cdent: I don't see how listing *both* resource_providers (the collective attribute) AND the singular attributes at the same time can be correct. | 17:37 |
| cdent | it’s a list of resource provider objects: | 17:37 |
| jaypipes | yes... | 17:37 |
| jaypipes | and that's all | 17:37 |
| cdent | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/resource_provider.py#L110 | 17:37 |
| cdent | and the api_ref is set up to list anything, not just the top level things | 17:38 |
| jaypipes | cdent: since when? | 17:38 |
| cdent | since the dawn | 17:38 |
| cdent | we have made expections in the past | 17:38 |
| jaypipes | cdent: why bother having the top-level element at all then? that's just silly IMHO | 17:38 |
| jaypipes | cdent: with no indication of the "level" the attribute is expected to appear at | 17:39 |
| cdent | don’t look at me man, I think the rules on the api-ref are … weird | 17:39 |
| cdent | there has been work done in the nova api-ref (I think?) to indicate path.to.attribute but we’ve not picked it up in placement | 17:40 |
| * cdent looks for patch | 17:40 | |
| jaypipes | meh, screw it, I'll just make the damn changes (again, again) | 17:41 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | 17:41 |
| cdent | jaypipes: I think the descending paths thing was worked on near: https://review.openstack.org/#/c/464277/ but I’m not sure if it got anywhere | 17:42 |
| jaypipes | cdent: so is Takashi asking me to put a required: true line in for parent_provider_uuid/root_provider_uuid but only in the response parameter listings? | 17:42 |
| *** tssurya_ has joined #openstack-nova | 17:43 | |
| cdent | my read was that he wants the response body to be fully described and the usual way to do that in the case when it is optional is the request body is to inherit the yaml anchor and changed required: false to true | 17:43 |
| *** vks1 has quit IRC | 17:44 | |
| cdent | jaypipes: I think it would probably be okay to punt it to a followup (one that perhaps someone else did) | 17:44 |
| *** fragatin_ has quit IRC | 17:44 | |
| jaypipes | cdent: I just don't know what is being asked of me. | 17:45 |
| cdent | jaypipes: the reasons require: true isn’t marked on those guys is because required is the default, isn’t it? | 17:45 |
| *** BryanS68 has joined #openstack-nova | 17:45 | |
| *** Apoorva has joined #openstack-nova | 17:45 | |
| *** Apoorva has quit IRC | 17:45 | |
| cdent | in that case I’d say let’s punt and do it in a followup so it can be looked at separately and more clearly understood | 17:45 |
| *** sambetts is now known as sambetts|afk | 17:45 | |
| jaypipes | cdent: I think he's saying that the *response* always has parent_provider_uuid and therefore the *response* parameter list should have required: true. | 17:45 |
| cdent | my brain is not in that frame right now so can’t tell you something clear and straightforward | 17:46 |
| *** Apoorva has joined #openstack-nova | 17:46 | |
| cdent | effectively yes | 17:46 |
| cdent | I’ve changed my vote for now, in case that helps move things along | 17:47 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler set_inventory_for_provider does nested https://review.openstack.org/520643 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: SchedulerReportClient._get_providers_in_tree https://review.openstack.org/520663 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: SchedulerReportClient._get_providers_in_aggregates https://review.openstack.org/521097 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Scheduler[Report]Client.get_provider_tree https://review.openstack.org/521098 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: WIP: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 17:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 17:49 |
| jaypipes | cdent: would you mind looking at https://review.openstack.org/#/c/377215/ and making sure I've added everything you wanted please? | 17:52 |
| cdent | jaypipes: I think your rebase has gone funk as ps70 has the same stuff as ps62 (in the test file), but there were changes in the middle :( | 17:54 |
| jaypipes | god damn this. | 17:55 |
| *** gbarros has quit IRC | 17:56 | |
| jaypipes | I am so fucking sick of this bullshit sliced up and frankensteined set of patches at this point. | 17:57 |
| *** gszasz has joined #openstack-nova | 17:57 | |
| jaypipes | all this to try and get Eric's WIP patches aligned with what's already been merged. :( | 17:58 |
| *** pcaruana has quit IRC | 17:58 | |
| edleafe | jaypipes: welcome to my world :) | 17:58 |
| *** itlinux has joined #openstack-nova | 17:58 | |
| jaypipes | edleafe: how's that? doesn't your series only have like 4 patches in it? are there 7 different branches of that series? | 17:59 |
| jaypipes | cdent: also, it's not ps62. it was fine in ps69 and then ps70 undid all that work :(* | 18:00 |
| jaypipes | clarkb: you had a shortcut for how to essentially revert just the last revision on a series... can you tell me what that was again? | 18:01 |
| cdent | jaypipes: 62 was my reference point as that’s where I made my comments so I compared changes between 62 and 70 and there were none in the test file | 18:01 |
| jaypipes | cdent: look at 69... | 18:01 |
| edleafe | jaypipes: didn't mean to imply that mine was as bad as yours. Just the same set of headaches. | 18:01 |
| jaypipes | edleafe: well, at least you don't have 5 people *actively* pushing stuff in your series. | 18:01 |
| clarkb | jaypipes: `git review -d 123456,1 && git commit --amend #update commit message because gerrit && git review` | 18:02 |
| cdent | jaypipes: yeah, already did, it looks like what I hoped for | 18:02 |
| *** jose-phillips has quit IRC | 18:02 | |
| clarkb | that downloads into a local branch then you edit the commit message so that gerrit doesn't reject it as an existing patchset, then push to gerrit | 18:02 |
| jaypipes | clarkb: ack, thanks | 18:02 |
| *** ralonsoh has quit IRC | 18:03 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 18:04 |
| jaypipes | clarkb: oddly, Gerrit changed the topic of the patch to bp/nested-resource-providers-patch69 | 18:05 |
| clarkb | I think that may have been git review being a little too smart | 18:06 |
| clarkb | you can chagne it in the ui if you want (and in the future use git review -t some-topic to override git review) | 18:06 |
| *** jose-phillips has joined #openstack-nova | 18:06 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 18:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 18:06 |
| jaypipes | alex_xu, edleafe, mriedem, dansmith, cdent, bauzas, gibi, melwitt: OK, well if we can focus on getting up to https://review.openstack.org/#/c/385693/ merged, that would be cool. thanks in advance. | 18:08 |
| cdent | ✔ | 18:08 |
| *** diga has quit IRC | 18:12 | |
| *** suresh12 has joined #openstack-nova | 18:14 | |
| *** moshele has joined #openstack-nova | 18:14 | |
| edleafe | ✔ | 18:14 |
| *** tssurya_ has quit IRC | 18:16 | |
| *** mvenesio has quit IRC | 18:16 | |
| *** mvenesio has joined #openstack-nova | 18:17 | |
| *** tesseract has quit IRC | 18:21 | |
| *** jose-phillips has quit IRC | 18:23 | |
| *** lpetrut has joined #openstack-nova | 18:25 | |
| mriedem | melwitt: jaypipes: ack | 18:32 |
| *** jpena is now known as jpena|off | 18:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Modify _poll_shelved_instances periodic task call _shelve_offload_instance() https://review.openstack.org/524047 | 18:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for shelve_offload instances https://review.openstack.org/523653 | 18:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 18:35 |
| *** Alex_Staf has joined #openstack-nova | 18:38 | |
| *** BryanS68 has quit IRC | 18:41 | |
| *** burt has joined #openstack-nova | 18:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for shelve_offload instances https://review.openstack.org/523653 | 18:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 18:48 |
| *** BryanS68 has joined #openstack-nova | 18:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add instance action record for backup instances https://review.openstack.org/523676 | 18:53 |
| *** david-lyle has joined #openstack-nova | 18:55 | |
| *** Tom-Tom has joined #openstack-nova | 18:56 | |
| *** suresh12 has quit IRC | 18:59 | |
| *** david-lyle has quit IRC | 19:01 | |
| *** fragatina has joined #openstack-nova | 19:06 | |
| *** gbarros has joined #openstack-nova | 19:07 | |
| *** hamzy has joined #openstack-nova | 19:10 | |
| *** mvenesio has quit IRC | 19:10 | |
| *** tssurya_ has joined #openstack-nova | 19:14 | |
| *** moshele has quit IRC | 19:15 | |
| *** jose-phillips has joined #openstack-nova | 19:20 | |
| *** moshele has joined #openstack-nova | 19:22 | |
| *** jose-phillips has quit IRC | 19:24 | |
| *** tssurya_ has quit IRC | 19:25 | |
| *** tssurya_ has joined #openstack-nova | 19:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a new check to volume attach https://review.openstack.org/525622 | 19:27 |
| *** yamamoto has quit IRC | 19:27 | |
| *** Apoorva_ has joined #openstack-nova | 19:28 | |
| *** jose-phillips has joined #openstack-nova | 19:28 | |
| *** gbarros has quit IRC | 19:28 | |
| *** nore_rabel has joined #openstack-nova | 19:30 | |
| itlinux | hello all I wonder if any one can suggest the best way to get sec group disabled.. Thanks | 19:31 |
| *** Apoorva has quit IRC | 19:31 | |
| mriedem | ildikov: i'm going to update https://review.openstack.org/#/c/330285/169 | 19:34 |
| ildikov | mriedem: ok, I hit a rebase issue with it | 19:34 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert ext filesystem resizes to privsep. https://review.openstack.org/517516 | 19:34 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move flushing block devices to privsep. https://review.openstack.org/519010 | 19:34 |
| openstackgerrit | Michael Still proposed openstack/nova master: Start moving users of parted to privsep. https://review.openstack.org/519011 | 19:34 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move remaining uses of parted to privsep. https://review.openstack.org/519483 | 19:34 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert users of tune2fs to privsep. https://review.openstack.org/519484 | 19:34 |
| mriedem | ildikov: yes, and tempest is failing now too, so i'll handle both issues | 19:35 |
| ildikov | mriedem: and not with my laptop for a little while now | 19:35 |
| ildikov | mriedem: I guess Tempest is just because of the revert | 19:35 |
| ildikov | It got landed in the meantime | 19:35 |
| ildikov | mriedem: thank you | 19:35 |
| ildikov | mriedem: and sorry for being a bit unpleasant... | 19:36 |
| sean-k-mooney2 | gus: o/ | 19:40 |
| *** esberglu_ has joined #openstack-nova | 19:40 | |
| *** esberglu has quit IRC | 19:43 | |
| sean-k-mooney2 | gus: QQ if i have two fuctions func1 and func2 and both are decorated as a privsep entrypoint and func1 calls func2 will that dispatch the call to func2 via the unix socket again even though the body of func1 is executing in the privsep deamon process? | 19:43 |
| *** Guest35678 has joined #openstack-nova | 19:45 | |
| sean-k-mooney2 | gus: if the privsep entrypoint decorator that was used for func1 and func2 were from a different privsep context im guessing the answer would have to be yes as they may have different capablitys which woudld lead me to belive if they were the same context i would still invoke func2 via the socket. | 19:49 |
| *** liangy has joined #openstack-nova | 19:51 | |
| *** Alex_Staf has quit IRC | 19:52 | |
| *** tssurya_ has quit IRC | 19:53 | |
| *** kuzko has quit IRC | 19:54 | |
| sean-k-mooney2 | mikal: ^^ any input on the above question regarding nested privsep calls? | 19:54 |
| *** kuzko has joined #openstack-nova | 19:56 | |
| mikal | sean-k-mooney2: huh, we haven't done anything like that. I'm really not sure. | 19:58 |
| mikal | sean-k-mooney2: I guess the decorators aren't magic, and would just apply the contexts in the order the decorators were executed | 19:58 |
| *** peter-hamilton has quit IRC | 19:58 | |
| *** smatzek has quit IRC | 19:58 | |
| mikal | sean-k-mooney2: and if you didn't get an error from privsep calling itself, then you'd get the context of the innermost call | 19:58 |
| sean-k-mooney2 | mikal: actully we do it in os-vif but i belive its unintentional. | 19:59 |
| sean-k-mooney2 | mikal: i think two decorators were acidentally swapped | 19:59 |
| sean-k-mooney2 | mikal: in the os-vif case both decorators are form the same privsep context so both have the same permissions | 20:00 |
| mikal | Oh, interesting. So its either crash, or work as expected? | 20:00 |
| sean-k-mooney2 | basically i think https://github.com/openstack/os-vif/blob/23c71e083aeb3536c4cf4c46b5c7712b0f7442ee/vif_plug_linux_bridge/linux_net.py#L58 and https://github.com/openstack/os-vif/blob/23c71e083aeb3536c4cf4c46b5c7712b0f7442ee/vif_plug_linux_bridge/linux_net.py#L70 are swapped | 20:01 |
| sean-k-mooney2 | mikal: i think it works as expected but just dispatches twice | 20:01 |
| sean-k-mooney2 | mikal: https://github.com/openstack/os-vif/blob/23c71e083aeb3536c4cf4c46b5c7712b0f7442ee/vif_plug_linux_bridge/linux_net.py#L65 the call to _ensure_bridge_privileged is in a privesep context but _ensure_bridge_privileged is also privaldged | 20:02 |
| *** kuzko has quit IRC | 20:04 | |
| sean-k-mooney2 | mikal: im going to try and un nest the calls tomorow but i realised while reviewing https://review.openstack.org/#/c/484386/26/os_vif/privsep.py that the functions that use this new privsep context are only ever invoked form privaldged function in the plugins which have the same capablites CAP_NET_ADMIN | 20:06 |
| sean-k-mooney2 | so 1 that would result in nested context with the same capablites and 2 it would intoduce another instance of the privsep deamon to hanel that context both of which i think are not needed. | 20:07 |
| sean-k-mooney2 | mikal: am im going to head home for the evening but if you have a chance could you take a look and see if it makes sense to intorduce this new privsep context or not? | 20:08 |
| *** lpetrut has quit IRC | 20:11 | |
| *** BryanS68 has quit IRC | 20:11 | |
| *** moshele has quit IRC | 20:11 | |
| *** kuzko has joined #openstack-nova | 20:14 | |
| *** BryanS68 has joined #openstack-nova | 20:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 20:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 20:19 |
| *** yangyapeng has joined #openstack-nova | 20:20 | |
| *** efried_cya_wed has quit IRC | 20:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 20:21 |
| mriedem | ildikov: i touched up some things in https://review.openstack.org/#/c/267587/ and left some FIXMEs | 20:21 |
| ildikov | Oh, I thought you'll fix up the new attach patch only | 20:22 |
| mriedem | i wanted to rebase the series | 20:23 |
| ildikov | Oh, ok, I left behind the API one on purpose, but will check what you did in a bit :) | 20:24 |
| ildikov | Thanks!!! | 20:24 |
| *** yangyapeng has quit IRC | 20:24 | |
| ildikov | I can look into the Cinder policies and client leftovers too a bit then... | 20:24 |
| *** READ10 has quit IRC | 20:26 | |
| *** liangy has quit IRC | 20:26 | |
| *** yamamoto has joined #openstack-nova | 20:28 | |
| *** efried_cya_wed has joined #openstack-nova | 20:30 | |
| *** edmondsw has quit IRC | 20:30 | |
| *** yamamoto has quit IRC | 20:35 | |
| mriedem | i'm also going to add unit tests for the new flow to nova.tests.unit.virt.test_block_device in https://review.openstack.org/#/c/330285/170 - we might want to consider splitting out the virt.block_device changes too | 20:41 |
| *** gszasz has quit IRC | 20:41 | |
| *** gbarros has joined #openstack-nova | 20:42 | |
| mikal | mriedem: you had a chance to read my comment on that privsep bug? | 20:42 |
| mriedem | mikal: nope | 20:42 |
| *** edand has quit IRC | 20:42 | |
| *** slaweq has joined #openstack-nova | 20:43 | |
| *** gyee has joined #openstack-nova | 20:44 | |
| mikal | mriedem: good man. In summary, I have no idea what you people are talking about. | 20:46 |
| mriedem | mikal: that's what you told me yesterday, so ok :) | 20:46 |
| mikal | mriedem: oh, I was expecting you to call me a liar on the bug is all | 20:46 |
| jaypipes | cdent: you have any idea what is causing this tempest.scenario.test_server_multinode.TestServerMultinode.test_schedule_to_all_nodes failure with the "Failed to get resource provider with UUID XXXX" issue that keeps occurring? I think you and efried_cya_wed may have talked aboiut it? | 20:47 |
| cdent | yeah, there’s a bug for it, I’m working on it: https://bugs.launchpad.net/nova/+bug/1736385 basically placement is getting restarted | 20:47 |
| openstack | Launchpad bug 1736385 in grenade "placement is not being properly restarted in grenade (pike to master)" [Undecided,In progress] - Assigned to Chris Dent (cdent) | 20:47 |
| cdent | it’s apparently been a latent problem only exposed because exception handing that efried_cya_wed added | 20:48 |
| jaypipes | cdent: k. is there anything I can do to assist? | 20:48 |
| cdent | I don’t reckon so, the delay has been in getting it to repeat locally, but I’m nearly there, and from there should be able to do some poking | 20:49 |
| *** tssurya_ has joined #openstack-nova | 20:49 | |
| cdent | but thanks for offering. If I stall out before the night is over, I’ll dump state on the bug and let you know | 20:49 |
| *** tbachman has quit IRC | 20:52 | |
| jaypipes | cdent: k | 20:53 |
| openstackgerrit | Brianna Poulos proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 20:53 |
| *** Apoorva_ has quit IRC | 20:57 | |
| *** Apoorva has joined #openstack-nova | 20:57 | |
| *** tssurya_ has quit IRC | 21:04 | |
| *** damien_r has joined #openstack-nova | 21:05 | |
| *** tssurya_ has joined #openstack-nova | 21:06 | |
| *** tssurya_ has quit IRC | 21:09 | |
| *** nicolasbock has quit IRC | 21:10 | |
| *** Apoorva_ has joined #openstack-nova | 21:10 | |
| ildikov | mriedem: let me know when you had enough and want me to take over and screw up the half thing again before doing anything sane :) | 21:12 |
| *** hamzy has quit IRC | 21:12 | |
| mriedem | ildikov: i need to fix another functional test, and i'm working on adding the unit test coverage for the new flow changes in test_block_device | 21:13 |
| ildikov | mriedem: and I owe you a lot, I'm sure we can negotiate, lemme know | 21:13 |
| mriedem | which makes me realize that in the new attach flow in block_device.py, if attachment_complete fails, we don't do any cleanup | 21:13 |
| mriedem | unlike the old flow | 21:13 |
| ildikov | yeah, we moved that around a bit | 21:14 |
| *** Apoorva has quit IRC | 21:14 | |
| ildikov | so I guess that's why it's uncovered | 21:14 |
| ildikov | the volume is connected though, however the volume state would still be attaching if that call doesn't get to Cinder or fails before the db update | 21:15 |
| *** damien_r has quit IRC | 21:17 | |
| *** damien_r has joined #openstack-nova | 21:17 | |
| mriedem | that's why we handle it in the legacy flow and rollback (terminate the connection and detach the volume so it's "available") | 21:20 |
| mriedem | anyway, i'm just going to leave a note in the code | 21:22 |
| ildikov | I know, was thinking out loud | 21:22 |
| *** penick has joined #openstack-nova | 21:23 | |
| *** armax has quit IRC | 21:25 | |
| *** Apoorva_ has quit IRC | 21:26 | |
| *** Apoorva has joined #openstack-nova | 21:26 | |
| *** damien_r has quit IRC | 21:30 | |
| *** edmondsw has joined #openstack-nova | 21:30 | |
| *** itlinux has quit IRC | 21:39 | |
| mriedem | we are going to want to break out these block_device.py changes with the unit tests - this gets pretty hairy in the tests | 21:43 |
| mriedem | i'm down to 10 failures | 21:43 |
| *** itlinux has joined #openstack-nova | 21:44 | |
| *** tbachman has joined #openstack-nova | 21:44 | |
| ildikov | we should find a superhero name for you | 21:45 |
| ildikov | can do it after my next meeting and breaking out those changes | 21:45 |
| *** tidwellr has quit IRC | 21:47 | |
| *** penick has quit IRC | 21:47 | |
| *** pchavva has quit IRC | 21:51 | |
| ildikov | and sorry, there were two self.save() calls in the new attach call in block_device.py | 21:52 |
| ildikov | I obviously deleted the wrong duplicate... | 21:52 |
| *** tojuvone has quit IRC | 21:55 | |
| *** tojuvone has joined #openstack-nova | 21:56 | |
| *** flwang has quit IRC | 21:56 | |
| openstackgerrit | Lance Bragstad proposed openstack/nova master: Add scope_types to server policies https://review.openstack.org/525772 | 21:57 |
| *** tbachman has quit IRC | 21:58 | |
| mriedem | ildikov: i'm actively working on the attach patch so don't make any changes there | 21:59 |
| lbragstad | cc johnthetubaguy ^ | 21:59 |
| *** smatzek has joined #openstack-nova | 21:59 | |
| ildikov | mriedem: I didn't intend to until you explicitly say so | 21:59 |
| ildikov | mriedem: otherwise things can get messy, practiced that with jgriffith not that long ago | 22:00 |
| *** Apoorva_ has joined #openstack-nova | 22:00 | |
| *** BryanS68 has quit IRC | 22:01 | |
| *** flwang has joined #openstack-nova | 22:01 | |
| *** gouthamr has quit IRC | 22:04 | |
| *** Apoorva has quit IRC | 22:04 | |
| *** smatzek has quit IRC | 22:04 | |
| *** abalutoiu has quit IRC | 22:04 | |
| *** threestrands has joined #openstack-nova | 22:05 | |
| *** threestrands has quit IRC | 22:05 | |
| *** threestrands has joined #openstack-nova | 22:05 | |
| *** rcernin has joined #openstack-nova | 22:05 | |
| *** priteau has quit IRC | 22:07 | |
| *** Tom-Tom has quit IRC | 22:07 | |
| *** Tom-Tom has joined #openstack-nova | 22:08 | |
| *** smatzek has joined #openstack-nova | 22:09 | |
| *** Tom-Tom has quit IRC | 22:12 | |
| *** fragatina has quit IRC | 22:13 | |
| *** dave-mcc_ is now known as dave-mccowan | 22:15 | |
| *** fragatina has joined #openstack-nova | 22:17 | |
| *** fragatin_ has joined #openstack-nova | 22:17 | |
| *** smatzek has quit IRC | 22:18 | |
| *** yamahata has joined #openstack-nova | 22:19 | |
| *** armax has joined #openstack-nova | 22:20 | |
| *** fragatina has quit IRC | 22:21 | |
| *** erlon has quit IRC | 22:22 | |
| *** awaugama has quit IRC | 22:23 | |
| *** faridda has joined #openstack-nova | 22:27 | |
| faridda | Hi guys, to Configure Hyper-V virtual switching, we have to specify an interface. Which one should be use (internal api, tenant network ...)? | 22:29 |
| *** dtruong has quit IRC | 22:31 | |
| *** tbachman has joined #openstack-nova | 22:38 | |
| *** gszasz has joined #openstack-nova | 22:41 | |
| *** gouthamr has joined #openstack-nova | 22:42 | |
| *** tbachman has quit IRC | 22:43 | |
| *** tbachman has joined #openstack-nova | 22:46 | |
| *** yamahata has quit IRC | 22:49 | |
| melwitt | mriedem: heads up, regression live-migrating with a volume that was backported to ocata. I'm gonna add stable/pike and stable/ocata to the bug https://bugs.launchpad.net/nova/+bug/1715569 | 22:55 |
| openstack | Launchpad bug 1715569 in OpenStack Compute (nova) "Live migration fails with an attached non-bootable Cinder volume (Pike)" [Low,In progress] - Assigned to Mike Lowe (jomlowe) | 22:55 |
| *** slaweq has quit IRC | 22:55 | |
| melwitt | "nominate to series pike and ocata | 22:55 |
| mriedem | faridda: ask claudiub or lpetrut when they are around | 22:56 |
| mriedem | melwitt: you mean something was changed which introduced the regression and that change was backported to stable? | 22:57 |
| melwitt | mriedem: yes, that | 22:57 |
| mriedem | and https://review.openstack.org/#/c/459741 was the chnage | 22:58 |
| melwitt | yes | 22:58 |
| mriedem | super | 22:58 |
| melwitt | yeah :( | 22:58 |
| melwitt | the good news? is the fix looks correct to me and fixes the problem without undoing what the other change [that introduced the regression] fixed | 22:59 |
| *** esberglu_ has quit IRC | 23:01 | |
| *** esberglu has joined #openstack-nova | 23:01 | |
| melwitt | so I think we can just roll forward and backport the fix that's up for review right now | 23:02 |
| *** yamahata has joined #openstack-nova | 23:03 | |
| *** esberglu has quit IRC | 23:06 | |
| *** Tom-Tom has joined #openstack-nova | 23:09 | |
| *** jmlowe has joined #openstack-nova | 23:09 | |
| *** burt has quit IRC | 23:10 | |
| *** smatzek has joined #openstack-nova | 23:12 | |
| *** slaweq has joined #openstack-nova | 23:13 | |
| *** Tom-Tom has quit IRC | 23:13 | |
| *** faridda has quit IRC | 23:13 | |
| *** yamahata has quit IRC | 23:13 | |
| *** lyan has quit IRC | 23:14 | |
| *** esberglu has joined #openstack-nova | 23:14 | |
| *** smatzek has quit IRC | 23:17 | |
| *** slaweq has quit IRC | 23:18 | |
| *** esberglu has quit IRC | 23:18 | |
| mriedem | gd finally got these unit tests passing | 23:20 |
| mriedem | 2.5 hours | 23:21 |
| melwitt | I know your pain | 23:22 |
| *** nore_rabel has quit IRC | 23:22 | |
| *** dave-mccowan has quit IRC | 23:23 | |
| *** amodi has quit IRC | 23:25 | |
| *** Apoorva_ has quit IRC | 23:27 | |
| *** Apoorva has joined #openstack-nova | 23:27 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Implement new attach Cinder flow https://review.openstack.org/330285 | 23:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 23:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 23:28 |
| ildikov | mriedem: that would've taken me waaaaay more than that | 23:29 |
| ildikov | I know it doesn't give you back the wasted time, but still | 23:29 |
| mriedem | i'll see if i can split out block_device.py quick | 23:30 |
| melwitt | mriedem: on this https://review.openstack.org/#/c/525622 how can we know we have cinder microversion 3.44 available? or does the check not hurt anything in the case that it's < 3.44? | 23:34 |
| ildikov | sounds like a famous last sentence, but hearing from you makes it believable :) | 23:34 |
| *** edmondsw has quit IRC | 23:34 | |
| *** edmondsw has joined #openstack-nova | 23:35 | |
| *** gszasz has quit IRC | 23:35 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: [placement] Fix foreign key constraint error https://review.openstack.org/525620 | 23:37 |
| mriedem | melwitt: at this point we won't check because bdm.attachment_id won't be set | 23:38 |
| mriedem | bdm.attachment_id only gets set once (1) computes are all upgraded to support new flow and (2) cinder 3.44 is available | 23:39 |
| melwitt | ah, cool. thanks | 23:39 |
| mriedem | existing bdms won't have that attachment_id field set, so we'll just do the old stuff | 23:39 |
| *** yamahata has joined #openstack-nova | 23:43 | |
| *** tbachman has quit IRC | 23:44 | |
| mriedem | here it comes | 23:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 23:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: Allow multiple volume attachments https://review.openstack.org/267587 | 23:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Allow multi-attach in compute api https://review.openstack.org/271047 | 23:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add new style volume attachment support to block_device.py https://review.openstack.org/525787 | 23:45 |
| mriedem | ildikov: jgriffith: i split this out https://review.openstack.org/#/c/525787/ - and left fixme/todo stuff in there from when i was adding the unit tests | 23:48 |
| mriedem | too tired to really go over any of that now | 23:48 |
| mriedem | that tempest test for attaching a volume to a shelved offloaded test is passing too, even after the revert | 23:50 |
| *** yangyapeng has joined #openstack-nova | 23:50 | |
| mriedem | so at this point i think the questions in https://review.openstack.org/#/c/525787/ are going to be the sticking point, and hopefully those aren't too bad | 23:51 |
| mriedem | melwitt: so in https://review.openstack.org/#/c/525622/3/nova/compute/api.py - you want a specific test for the case that we find a bdm and fail? | 23:55 |
| *** yangyapeng has quit IRC | 23:55 | |
| mriedem | via objects.BlockDeviceMapping.get_by_volume_and_instance | 23:55 |
| melwitt | mriedem: no, I'm thinking of just pushing a follow up that changes from stubbing out the entire "check if already attached" to mocking only the BDM get. so that the real code raises InvalidVolume instead of unit test code raising it | 23:56 |
| melwitt | since we're not unit testing "check if already attached" anywhere. I think it would be two birds with one stone by just making that small change | 23:57 |
| mriedem | ok | 23:57 |
| ildikov | mriedem: thank you | 23:57 |
| *** edmondsw has quit IRC | 23:57 | |
| ildikov | I will go through the changes once I slept a bit | 23:57 |
| ildikov | mriedem: is the fixme waiting for me now or there are things you still plan to change? | 23:59 |
| mriedem | i don't plan on making changes at this point | 23:59 |
| mriedem | i've pointed out the open questoins in the block_device change | 23:59 |
| mriedem | but i've got to run | 23:59 |
| *** mriedem is now known as mriedem_away | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!