| *** thorst has joined #openstack-nova | 00:00 | |
| *** mingyu has quit IRC | 00:02 | |
| *** thorst has quit IRC | 00:02 | |
| *** slaweq has quit IRC | 00:02 | |
| *** thorst has joined #openstack-nova | 00:05 | |
| *** yingjun has joined #openstack-nova | 00:05 | |
| *** jmlowe has joined #openstack-nova | 00:06 | |
| *** itlinux has joined #openstack-nova | 00:09 | |
| *** crushil has quit IRC | 00:17 | |
| *** gmann has quit IRC | 00:18 | |
| *** gmann has joined #openstack-nova | 00:18 | |
| *** slaweq has joined #openstack-nova | 00:19 | |
| *** thorst has quit IRC | 00:23 | |
| *** slaweq has quit IRC | 00:23 | |
| *** thorst has joined #openstack-nova | 00:23 | |
| *** crushil has joined #openstack-nova | 00:23 | |
| *** harlowja has quit IRC | 00:25 | |
| *** lucasxu has joined #openstack-nova | 00:27 | |
| *** thorst has quit IRC | 00:27 | |
| *** slaweq has joined #openstack-nova | 00:29 | |
| *** crushil has quit IRC | 00:34 | |
| *** claudiub has quit IRC | 00:34 | |
| *** slaweq has quit IRC | 00:36 | |
| *** armax has quit IRC | 00:37 | |
| *** thorst has joined #openstack-nova | 00:38 | |
| *** slaweq has joined #openstack-nova | 00:41 | |
| *** edmondsw has joined #openstack-nova | 00:42 | |
| *** Apoorva_ has joined #openstack-nova | 00:42 | |
| *** Apoorva has quit IRC | 00:45 | |
| *** slaweq has quit IRC | 00:46 | |
| *** Apoorva_ has quit IRC | 00:47 | |
| *** edmondsw has quit IRC | 00:47 | |
| *** armax has joined #openstack-nova | 00:48 | |
| *** kiennt has joined #openstack-nova | 00:49 | |
| *** mdnadeem has joined #openstack-nova | 00:49 | |
| *** slaweq has joined #openstack-nova | 00:51 | |
| *** lyan has joined #openstack-nova | 00:53 | |
| *** markvoelker has joined #openstack-nova | 00:55 | |
| *** slaweq has quit IRC | 00:56 | |
| *** mdnadeem has quit IRC | 00:57 | |
| *** lucasxu has quit IRC | 00:57 | |
| *** markvoelker_ has joined #openstack-nova | 00:57 | |
| *** jmlowe has quit IRC | 01:00 | |
| *** markvoelker has quit IRC | 01:01 | |
| *** slaweq has joined #openstack-nova | 01:01 | |
| *** gouthamr has quit IRC | 01:02 | |
| *** catintheroof has joined #openstack-nova | 01:02 | |
| *** Shunli has joined #openstack-nova | 01:02 | |
| *** phuongnh has joined #openstack-nova | 01:03 | |
| *** gjayavelu has quit IRC | 01:04 | |
| *** lucasxu has joined #openstack-nova | 01:06 | |
| *** armax has quit IRC | 01:07 | |
| *** slaweq has quit IRC | 01:07 | |
| *** tuanluong has joined #openstack-nova | 01:10 | |
| *** zhurong has joined #openstack-nova | 01:11 | |
| *** catintheroof has quit IRC | 01:11 | |
| *** litao__ has joined #openstack-nova | 01:15 | |
| *** yangyapeng has joined #openstack-nova | 01:18 | |
| *** hieulq has quit IRC | 01:23 | |
| *** slaweq has joined #openstack-nova | 01:23 | |
| *** jmlowe has joined #openstack-nova | 01:24 | |
| *** thorst has quit IRC | 01:24 | |
| *** jichen has joined #openstack-nova | 01:27 | |
| *** slaweq has quit IRC | 01:28 | |
| *** mingyu has joined #openstack-nova | 01:28 | |
| *** mingyu has quit IRC | 01:33 | |
| *** slaweq has joined #openstack-nova | 01:34 | |
| *** slaweq has quit IRC | 01:40 | |
| *** randomhack has joined #openstack-nova | 01:40 | |
| *** rajathagasthya has quit IRC | 01:42 | |
| *** randomhack has quit IRC | 01:45 | |
| *** lyan has quit IRC | 01:46 | |
| *** slaweq has joined #openstack-nova | 01:56 | |
| *** slaweq has quit IRC | 02:00 | |
| *** crushil has joined #openstack-nova | 02:03 | |
| *** slaweq has joined #openstack-nova | 02:06 | |
| *** yamahata has quit IRC | 02:07 | |
| *** bkopilov has quit IRC | 02:07 | |
| *** slaweq has quit IRC | 02:13 | |
| *** mtreinish has quit IRC | 02:17 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/490859 | 02:17 |
|---|---|---|
| *** jowisz has quit IRC | 02:18 | |
| *** Guest51738 has quit IRC | 02:18 | |
| *** lifeless has quit IRC | 02:18 | |
| *** jowisz has joined #openstack-nova | 02:19 | |
| *** rodrigods has quit IRC | 02:19 | |
| *** lifeless has joined #openstack-nova | 02:19 | |
| *** mtreinish has joined #openstack-nova | 02:22 | |
| *** rodrigods has joined #openstack-nova | 02:23 | |
| *** saphi has joined #openstack-nova | 02:24 | |
| *** egarbade has joined #openstack-nova | 02:25 | |
| *** egarbade is now known as Guest57787 | 02:25 | |
| *** gcb has joined #openstack-nova | 02:29 | |
| *** edmondsw has joined #openstack-nova | 02:30 | |
| *** sree has joined #openstack-nova | 02:34 | |
| *** edmondsw has quit IRC | 02:35 | |
| *** saphi has quit IRC | 02:38 | |
| *** sree has quit IRC | 02:39 | |
| *** slaweq has joined #openstack-nova | 02:40 | |
| *** armax has joined #openstack-nova | 02:41 | |
| *** armax has quit IRC | 02:44 | |
| *** slaweq has quit IRC | 02:45 | |
| *** yamamoto_ has joined #openstack-nova | 02:46 | |
| *** yamamoto has quit IRC | 02:46 | |
| *** hongbin_ has joined #openstack-nova | 02:49 | |
| *** hongbin has quit IRC | 02:49 | |
| *** hongbin_ has quit IRC | 02:49 | |
| *** hongbin has joined #openstack-nova | 02:49 | |
| *** slaweq has joined #openstack-nova | 02:51 | |
| *** saphi has joined #openstack-nova | 02:51 | |
| *** slaweq has quit IRC | 02:56 | |
| *** slaweq has joined #openstack-nova | 03:01 | |
| *** slaweq has quit IRC | 03:05 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** david-lyle has quit IRC | 03:16 | |
| *** slaweq has quit IRC | 03:18 | |
| *** mingyu has joined #openstack-nova | 03:18 | |
| *** mingyu has quit IRC | 03:22 | |
| *** david-lyle has joined #openstack-nova | 03:23 | |
| *** nicolasbock has joined #openstack-nova | 03:25 | |
| *** mdnadeem has joined #openstack-nova | 03:27 | |
| *** yangyapeng has quit IRC | 03:33 | |
| *** slaweq has joined #openstack-nova | 03:33 | |
| *** slaweq has quit IRC | 03:38 | |
| *** yangyapeng has joined #openstack-nova | 03:39 | |
| *** dixiaoli has joined #openstack-nova | 03:39 | |
| *** nicolasbock has quit IRC | 03:39 | |
| *** slaweq has joined #openstack-nova | 03:43 | |
| *** lucasxu has quit IRC | 03:43 | |
| *** baoli has quit IRC | 03:44 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:45 | |
| *** udesale has joined #openstack-nova | 03:45 | |
| *** bkopilov has joined #openstack-nova | 03:46 | |
| *** yangyapeng has quit IRC | 03:47 | |
| *** dave-mccowan has quit IRC | 03:47 | |
| *** yangyapeng has joined #openstack-nova | 03:47 | |
| *** slaweq has quit IRC | 03:49 | |
| *** nicolasbock has joined #openstack-nova | 03:50 | |
| *** yangyapeng has quit IRC | 03:52 | |
| *** yangyapeng has joined #openstack-nova | 03:52 | |
| *** links has joined #openstack-nova | 03:53 | |
| *** hongbin has quit IRC | 03:56 | |
| *** yangyapeng has quit IRC | 03:57 | |
| *** yangyapeng has joined #openstack-nova | 03:57 | |
| *** esberglu has quit IRC | 03:59 | |
| *** mamandle has joined #openstack-nova | 04:00 | |
| *** yangyapeng has quit IRC | 04:02 | |
| *** yangyapeng has joined #openstack-nova | 04:07 | |
| *** yangyapeng has quit IRC | 04:14 | |
| *** yangyapeng has joined #openstack-nova | 04:15 | |
| *** reedip_afk is now known as reedip | 04:17 | |
| *** mingyu has joined #openstack-nova | 04:19 | |
| *** adisky__ has joined #openstack-nova | 04:22 | |
| *** mingyu has quit IRC | 04:24 | |
| *** thorst has joined #openstack-nova | 04:25 | |
| *** thorst has quit IRC | 04:30 | |
| *** mamandle has quit IRC | 04:32 | |
| *** mamandle has joined #openstack-nova | 04:34 | |
| *** harlowja has joined #openstack-nova | 04:35 | |
| *** crushil has quit IRC | 04:43 | |
| *** esberglu has joined #openstack-nova | 04:49 | |
| *** ratailor has joined #openstack-nova | 04:52 | |
| *** esberglu has quit IRC | 04:53 | |
| *** crushil has joined #openstack-nova | 04:55 | |
| *** slaweq has joined #openstack-nova | 05:00 | |
| *** vks1 has joined #openstack-nova | 05:00 | |
| *** claudiub has joined #openstack-nova | 05:01 | |
| *** hareesh has joined #openstack-nova | 05:01 | |
| *** mlakat has quit IRC | 05:03 | |
| *** slaweq has quit IRC | 05:05 | |
| *** mlakat has joined #openstack-nova | 05:09 | |
| *** slaweq has joined #openstack-nova | 05:10 | |
| *** crushil has quit IRC | 05:10 | |
| *** nicolasbock has quit IRC | 05:11 | |
| ratailor | alex_xu, Hi | 05:11 |
| ratailor | alex_xu, you around ? | 05:11 |
| *** harlowja has quit IRC | 05:14 | |
| *** slaweq has quit IRC | 05:15 | |
| *** rajathagasthya has joined #openstack-nova | 05:16 | |
| *** diga has joined #openstack-nova | 05:16 | |
| *** slaweq has joined #openstack-nova | 05:20 | |
| *** mingyu has joined #openstack-nova | 05:21 | |
| *** sridharg has joined #openstack-nova | 05:24 | |
| *** saphi_ has joined #openstack-nova | 05:24 | |
| *** saphi has quit IRC | 05:25 | |
| *** mingyu has quit IRC | 05:25 | |
| *** slaweq has quit IRC | 05:27 | |
| ratailor | any sqlalchemy expert here ? | 05:30 |
| *** psachin has joined #openstack-nova | 05:34 | |
| *** shan has joined #openstack-nova | 05:34 | |
| *** mamandle has quit IRC | 05:38 | |
| *** suzhengwei_ has joined #openstack-nova | 05:39 | |
| *** yamahata has joined #openstack-nova | 05:40 | |
| *** trinaths has joined #openstack-nova | 05:41 | |
| suzhengwei_ | Live-migration one instance, if not give destination host, disable nova-compute node will not be scheduled. | 05:46 |
| suzhengwei_ | but if give a disable nova-compute node as the destination host, the migration will execute. | 05:46 |
| suzhengwei_ | What is the consideration of this inconsistent behavior? | 05:46 |
| *** tojuvone has quit IRC | 05:48 | |
| *** sree has joined #openstack-nova | 05:49 | |
| *** kiennt has quit IRC | 05:50 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Improve stable-api doc with current API state https://review.openstack.org/489926 | 05:52 |
| *** nicolasbock has joined #openstack-nova | 05:53 | |
| *** thorst has joined #openstack-nova | 05:58 | |
| *** markus_z has joined #openstack-nova | 05:58 | |
| *** moshele has joined #openstack-nova | 06:00 | |
| *** saphi__ has joined #openstack-nova | 06:01 | |
| *** saphi_ has quit IRC | 06:02 | |
| *** udesale__ has joined #openstack-nova | 06:02 | |
| *** thorst has quit IRC | 06:03 | |
| *** udesale has quit IRC | 06:03 | |
| *** edmondsw has joined #openstack-nova | 06:06 | |
| *** kiennt has joined #openstack-nova | 06:07 | |
| *** Oku_OS-away is now known as Oku_OS | 06:08 | |
| *** edmondsw has quit IRC | 06:11 | |
| *** diga has quit IRC | 06:12 | |
| *** kiennt has quit IRC | 06:21 | |
| *** rcernin has joined #openstack-nova | 06:21 | |
| *** kiennt_ has joined #openstack-nova | 06:22 | |
| *** kiennt has joined #openstack-nova | 06:22 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Improve stable-api doc with current API state https://review.openstack.org/489926 | 06:22 |
| *** mamandle has joined #openstack-nova | 06:22 | |
| *** kiennt_ has quit IRC | 06:23 | |
| openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550 | 06:35 |
| *** dixiaoli has quit IRC | 06:39 | |
| *** sshwarts has joined #openstack-nova | 06:43 | |
| *** gjayavelu has joined #openstack-nova | 06:44 | |
| alex_xu | ratailor: hi, I'm here | 06:53 |
| *** rajathagasthya has quit IRC | 06:56 | |
| *** gjayavelu has quit IRC | 06:56 | |
| *** slaweq has joined #openstack-nova | 06:58 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Deny volume swapping with non-bootable volume https://review.openstack.org/407346 | 06:58 |
| *** zhurong has quit IRC | 06:59 | |
| *** pcaruana has joined #openstack-nova | 07:00 | |
| *** markvoelker_ has quit IRC | 07:01 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/490722 | 07:01 |
| ratailor | alex_xu, shouldn't this provide case-sensitive result. https://github.com/openstack/nova/blob/master/nova/objects/host_mapping.py#L93 | 07:01 |
| *** sahid has joined #openstack-nova | 07:03 | |
| *** slaweq has quit IRC | 07:04 | |
| alex_xu | ratailor: mysql doesn't support case-sensitive | 07:05 |
| alex_xu | ratailor: what is your problem? the host name is case-insensitive also? | 07:06 |
| ratailor | alex_xu, so what could be done in that case. | 07:06 |
| ratailor | alex_xu, yes. | 07:06 |
| *** markvoelker has joined #openstack-nova | 07:07 | |
| ratailor | If I try to add a compute node "COMPUTE1.example.com" to host-aggregate, but in fact the actual hostname of node is "compute1.example.com". It should throw HostNotFound error. | 07:07 |
| ratailor | alex_xu, ^^ | 07:07 |
| ratailor | alex_xu, but in this case the host is added to host-aggregate. and while spawning instance scheduler don't filter that host, as it is not actually present. | 07:08 |
| *** markvoelker has quit IRC | 07:08 | |
| *** markvoelker has joined #openstack-nova | 07:08 | |
| *** mingyu has joined #openstack-nova | 07:08 | |
| *** aarefiev has joined #openstack-nova | 07:10 | |
| *** tesseract has joined #openstack-nova | 07:21 | |
| *** ralonsoh has joined #openstack-nova | 07:22 | |
| alex_xu | ratailor: emm... | 07:22 |
| *** udesale has joined #openstack-nova | 07:23 | |
| *** udesale__ has quit IRC | 07:24 | |
| *** zz9pzza has joined #openstack-nova | 07:25 | |
| *** udesale__ has joined #openstack-nova | 07:26 | |
| alex_xu | ratailor: I guess due to the scheduler keep host<->aggregate mapping in the memory, then the thing becomes case-sensitive | 07:26 |
| *** Swami has quit IRC | 07:27 | |
| alex_xu | ratailor: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L359 | 07:28 |
| alex_xu | ratailor: have you file a bug for it? | 07:28 |
| ratailor | alex_xu, might be. but even if scheduler fetches it from db, there won't be any host with hostname "COMPUTE1.example.com", so we won't be able to create instance on that. | 07:28 |
| ratailor | alex_xu, not yet. | 07:28 |
| ratailor | alex_xu, I will do that in some time. | 07:28 |
| *** udesale has quit IRC | 07:29 | |
| alex_xu | ratailor: yes, so there is no host_state for 'COMPUTE1.exmaple.com', but there will be a mapping for it in the host_aggregates_map | 07:29 |
| ratailor | alex_xu, yes, | 07:30 |
| *** slaweq has joined #openstack-nova | 07:30 | |
| *** slaweq has quit IRC | 07:36 | |
| *** mingyu has quit IRC | 07:39 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | 07:40 |
| *** randomhack has joined #openstack-nova | 07:41 | |
| *** yamamoto_ has quit IRC | 07:44 | |
| ratailor | alex_xu, I have reported in launchpad, FYI https://bugs.launchpad.net/nova/+bug/1709260 | 07:44 |
| openstack | Launchpad bug 1709260 in OpenStack Compute (nova) "Addition of host to host-aggregate should be case -sensitive" [Undecided,New] | 07:44 |
| alex_xu | ratailor: thanks | 07:44 |
| ratailor | alex_xu, welcome :) | 07:45 |
| *** ratailor is now known as ratailor|Lunch | 07:45 | |
| *** randomhack has quit IRC | 07:45 | |
| *** yamamoto has joined #openstack-nova | 07:50 | |
| *** edmondsw has joined #openstack-nova | 07:54 | |
| *** alexchadin has joined #openstack-nova | 07:55 | |
| *** ralonsoh_ has joined #openstack-nova | 07:57 | |
| *** ralonsoh has quit IRC | 07:57 | |
| *** rtjure has quit IRC | 07:58 | |
| *** edmondsw has quit IRC | 07:59 | |
| *** thorst has joined #openstack-nova | 07:59 | |
| *** chohoor has quit IRC | 08:01 | |
| *** ralonsoh_ is now known as ralonsoh | 08:02 | |
| *** chohoor has joined #openstack-nova | 08:02 | |
| *** mingyu has joined #openstack-nova | 08:03 | |
| *** thorst has quit IRC | 08:04 | |
| *** priteau has joined #openstack-nova | 08:09 | |
| *** itlinux has quit IRC | 08:11 | |
| *** ratailor|Lunch is now known as ratailor | 08:16 | |
| bauzas | gibi: FWIW, reviewing your change today | 08:17 |
| *** trinaths has quit IRC | 08:18 | |
| *** yingjun has quit IRC | 08:20 | |
| *** derekh has joined #openstack-nova | 08:20 | |
| *** lpetrut has joined #openstack-nova | 08:23 | |
| *** trinaths has joined #openstack-nova | 08:23 | |
| *** slaweq has joined #openstack-nova | 08:25 | |
| *** lucas-afk is now known as lucasagomes | 08:26 | |
| *** tiendc has joined #openstack-nova | 08:28 | |
| *** esberglu has joined #openstack-nova | 08:28 | |
| *** mamandle has quit IRC | 08:29 | |
| *** slaweq has quit IRC | 08:29 | |
| *** karthiks has joined #openstack-nova | 08:30 | |
| *** esberglu has quit IRC | 08:32 | |
| gibi | bauzas: thanks a lot | 08:34 |
| bauzas | tbc, the chance one | 08:34 |
| bauzas | did Gerrit was upgraded ? | 08:34 |
| bauzas | I just provided an URL in a comment and it broke weirdly | 08:35 |
| *** slaweq has joined #openstack-nova | 08:35 | |
| gibi | bauzas: that change still fail on the gate with the server_group tests but I cannot repoduce it locally and I even removed every server_group related change for them patch | 08:36 |
| bauzas | gibi: ok | 08:36 |
| gibi | bauzas: so any comment is really appreciated | 08:37 |
| *** mingyu has quit IRC | 08:37 | |
| *** mamandle has joined #openstack-nova | 08:39 | |
| gibi | bauzas: also I'm curious about your oppinion about https://review.openstack.org/#/c/491491/4/nova/tests/unit/scheduler/test_scheduler.py@152 | 08:40 |
| *** mingyu has joined #openstack-nova | 08:40 | |
| *** slaweq has quit IRC | 08:41 | |
| bauzas | gibi: you mean about legacy filters being still in use ? | 08:41 |
| * bauzas needs caffeine | 08:41 | |
| gibi | bauzas: about raising NoValidHost if Placement API is not available or not upgraded | 08:42 |
| gibi | bauzas: raising NoValidHost if Placemnet returns {} is clearly a good thing but I'm a bit uneasy about the two other cases | 08:43 |
| *** rtjure has joined #openstack-nova | 08:46 | |
| bauzas | gibi: sorry, was just refueling my stomach | 08:49 |
| *** yamamoto has quit IRC | 08:49 | |
| bauzas | by coffee (10:40am here, what people are thinking ?) | 08:49 |
| bauzas | gibi: about the NoValidHost exception ? Well, correct me if I'm wrong but we already do that :) | 08:50 |
| bauzas | gibi: we just return an empty list that will eventually raise that error :) | 08:50 |
| gibi | bauzas: if Placement is not available then Scheduler falls back to normal filtering and if CoreFilter is not enabled it can select a host with not enough vcpu | 08:53 |
| gibi | bauzas: now this can happen in three cases, Placement cannot be accessed, Placement is not upgraded, or Placement returned {}. | 08:54 |
| gibi | bauzas: in the third one I'm happy to raise NoValidHost | 08:54 |
| bauzas | gibi: wait, are you sure ? | 08:54 |
| bauzas | gibi: when I wrote the BP about scheduler calling placement in Ocata, I made it clear that if Placement wasn't there, we should return an empty list | 08:55 |
| gibi | bauzas: based on this https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L133 | 08:55 |
| bauzas | then it's a regression | 08:55 |
| bauzas | in Pike | 08:55 |
| gibi | so it is OK for you to raise NoValidHost in all the 3 cases. I can accept this. :) | 08:56 |
| bauzas | Placement isn't optional | 08:56 |
| bauzas | if the driver supports it | 08:56 |
| bauzas | at least that's what we had in Ocata | 08:56 |
| bauzas | gibi: lemme show you the ocata code | 08:56 |
| gibi | bauzas: but then this whole bunch of code is unnecessary https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L124-L144 | 08:57 |
| bauzas | gibi: https://github.com/openstack/nova/blob/stable/ocata/nova/scheduler/filter_scheduler.py#L184-L189 | 08:58 |
| gibi | bauzas: OK, that sounds convincing | 08:59 |
| bauzas | that's at least what we had in Ocata | 09:00 |
| bauzas | given it was in the filter scheduler code, it was only for that driver | 09:00 |
| gibi | bauzas: then I' don't know why we have so much code in the scheduler manager to distinguish between the different cases | 09:00 |
| bauzas | probably a consequence of reviews and whack-a-mole gaming | 09:00 |
| gibi | either we got a non empty result from placement or it is a NoValidHost | 09:00 |
| bauzas | or we could want to be more gentle | 09:00 |
| bauzas | and in that case, it's a feature | 09:01 |
| gibi | then my patch breaking that feature | 09:01 |
| bauzas | but the fact is, we came from a fact in Ocata where any problem communicating to Placement was leading to a NoValidHost | 09:01 |
| *** viswarya has joined #openstack-nova | 09:02 | |
| *** alexchadin has quit IRC | 09:03 | |
| gibi | and as in Ocata placement was not mandatory we needed to easy that up | 09:03 |
| gibi | but can we be strict in Pike? | 09:04 |
| *** mingyu has quit IRC | 09:05 | |
| *** mingyu has joined #openstack-nova | 09:08 | |
| bauzas | gibi: no, Placement was optional in Newton but mandatory in Pike | 09:09 |
| bauzas | graaah | 09:09 |
| bauzas | lemme rephrase it | 09:09 |
| bauzas | gibi: Placement = {"Newton": "optional", "Ocata": "mandatory"} | 09:10 |
| * bauzas has fat fingers | 09:10 | |
| gibi | so we can be strict in Pike | 09:10 |
| gibi | then I'm happy to raise NoValidHost in all three cases | 09:10 |
| bauzas | gibi: https://docs.openstack.org/releasenotes/nova/ocata.html#id7 | 09:11 |
| bauzas | "he Nova FilterScheduler driver is now able to make scheduling decisions based on the new Placement RESTful API endpoint that becomes mandatory in Ocata. " | 09:11 |
| bauzas | and | 09:12 |
| bauzas | " nova-scheduler process is now calling the placement API in order to get a list of valid destinations before calling the filters. That works only if all your compute nodes are fully upgraded to Ocata. If some nodes are not upgraded, the scheduler will still lookup from the DB instead which is less performant. " | 09:12 |
| bauzas | Since the Placement service is now mandatory in Ocata, you need to deploy it and amend your compute node configuration with correct placement instructions before restarting nova-"compute or the compute node will refuse to start. " | 09:12 |
| bauzas | anyway | 09:12 |
| bauzas | gibi: last point for your knowledge | 09:13 |
| bauzas | If by Newton (14.0.0), you don’t use any of the CoreFilter, RamFilter or DiskFilter, then please modify all your compute node’s configuration by amending either cpu_allocation_ratio (if you don’t use CoreFilter) or ram_allocation_ratio (if you don’t use RamFilter) or disk_allocation_ratio (if you don’t use DiskFilter) by putting a 9999.0 value for the ratio before upgrading the nova-scheduler to Ocata. | 09:13 |
| gibi | bauzas: thanks. I'm convinced | 09:13 |
| bauzas | the last one is error-prone | 09:13 |
| bauzas | it was because some operators were *not* placing based on those legacy resources | 09:14 |
| bauzas | so, in that case, in order to keep them untied with those resources, they have to fake an "infinite" allocation ratio | 09:15 |
| *** alexchadin has joined #openstack-nova | 09:15 | |
| *** nicolasbock has quit IRC | 09:15 | |
| *** yamamoto has joined #openstack-nova | 09:15 | |
| bauzas | mostly FYI | 09:15 |
| gibi | I see | 09:17 |
| gibi | meanwhile I think I found why the server_group func tests fails in the chance scheduler removal patch | 09:19 |
| gibi | scheduler.utils caches information about loaded filters | 09:19 |
| gibi | https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L397 | 09:19 |
| bauzas | gibi: that was one of my thoughts I didn't yet commented : why do you need to update test_server_group since it doesn't use chance ? | 09:19 |
| *** slaweq has joined #openstack-nova | 09:19 | |
| gibi | the problem is that now we load only the ComputeFilter in other tests and that cache makes the tests interdependent | 09:20 |
| gibi | so I have to invalidate the cache in the server_group tests | 09:20 |
| *** sambetts|afk is now known as sambetts | 09:20 | |
| gibi | I will push that soon | 09:21 |
| *** yamamoto has quit IRC | 09:22 | |
| bauzas | gibi: sounds like a fixture to me | 09:24 |
| *** slaweq has quit IRC | 09:25 | |
| gibi | bauzas: like a scheduler fixture that 1) invalidate the cache 2) configure the requested filters 3) starts the scheduler service ? | 09:25 |
| gibi | please note that the cache only affect the server group behavior | 09:26 |
| *** mingyu has quit IRC | 09:28 | |
| *** mingyu has joined #openstack-nova | 09:29 | |
| *** slaweq has joined #openstack-nova | 09:29 | |
| bauzas | gibi: it affected the server group behaviour because we don't define filters to run ? | 09:30 |
| gibi | bauzas: if the first test that hit https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L403 has only ComputeFilter configured then a later server_group test fails as _get_group_details raise an exception based on a stale cache | 09:33 |
| gibi | bauzas: previously every filter was configured by default, now it is on ComputeFilter | 09:34 |
| *** slaweq has quit IRC | 09:34 | |
| *** Shunli has quit IRC | 09:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | 09:34 |
| gibi | bauzas: ^^ now this should pass the func test on the gate as well | 09:35 |
| *** jichen has quit IRC | 09:36 | |
| *** slaweq has joined #openstack-nova | 09:39 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892 | 09:41 |
| *** mingyu has quit IRC | 09:41 | |
| *** edmondsw has joined #openstack-nova | 09:43 | |
| bauzas | gibi: I left some comments | 09:43 |
| *** nicolasbock has joined #openstack-nova | 09:43 | |
| bauzas | gibi: I'm unclear on some needed modifications | 09:43 |
| gibi | bauzas: looking | 09:43 |
| *** mingyu has joined #openstack-nova | 09:45 | |
| *** slaweq has quit IRC | 09:46 | |
| *** edmondsw has quit IRC | 09:47 | |
| *** kornicameister has quit IRC | 09:47 | |
| gibi | bauzas: responeded | 09:48 |
| *** yassine has quit IRC | 09:48 | |
| *** udesale__ has quit IRC | 09:49 | |
| bauzas | gibi: okay, looking | 09:51 |
| bauzas | gibi: about the doubled allocation, I thought we were just doing that against different hosts | 09:54 |
| bauzas | gibi: if we resize on same host, we also duplicate the allocation ? | 09:54 |
| bauzas | :/ | 09:54 |
| *** yamamoto has joined #openstack-nova | 09:54 | |
| gibi | bauzas: I think so https://review.openstack.org/#/c/490085/ | 09:54 |
| bauzas | gibi: could you just split your change in twice then ? | 09:55 |
| bauzas | gibi: and test | 09:55 |
| gibi | bauzas: do you mean one patch for the vcpu=2 and the other is the rest? | 09:56 |
| gibi | I'm going to eat something now but then I will be back | 09:56 |
| bauzas | gibi: well, the problem I see is that if you need to resize an instance, you absolutely now need 2 CPUs | 09:57 |
| bauzas | even for an AIO | 09:57 |
| bauzas | that's probably something I wasn't really concerned, but you can play with allocation ratios | 09:57 |
| bauzas | gibi: oh had a thought | 09:57 |
| bauzas | gibi: what if instead of modifying the fake driver resource, you would just amend the according resize test by providing a cpu allocation ? | 09:58 |
| bauzas | allocation ratio ? | 09:58 |
| bauzas | gibi: it should anyway default to 16.0 so I don't really see *why* we need that | 09:58 |
| *** alexchadin has quit IRC | 09:59 | |
| *** thorst has joined #openstack-nova | 10:00 | |
| *** kornicameister has joined #openstack-nova | 10:00 | |
| * bauzas disappearing for lunch | 10:01 | |
| *** saphi__ has quit IRC | 10:01 | |
| *** slaweq has joined #openstack-nova | 10:02 | |
| *** thorst has quit IRC | 10:05 | |
| *** yamamoto has quit IRC | 10:07 | |
| *** slaweq has quit IRC | 10:08 | |
| *** mingyu has quit IRC | 10:09 | |
| *** dtantsur|afk is now known as dtantsur | 10:09 | |
| *** dr_gogeta86 has quit IRC | 10:09 | |
| *** yamamoto has joined #openstack-nova | 10:12 | |
| *** yangyapeng has quit IRC | 10:12 | |
| *** slaweq has joined #openstack-nova | 10:12 | |
| *** dr_gogeta86 has joined #openstack-nova | 10:12 | |
| *** dr_gogeta86 has quit IRC | 10:12 | |
| *** dr_gogeta86 has joined #openstack-nova | 10:12 | |
| *** yangyapeng has joined #openstack-nova | 10:12 | |
| *** mdavidson has quit IRC | 10:16 | |
| *** mingyu has joined #openstack-nova | 10:16 | |
| *** mdavidson has joined #openstack-nova | 10:17 | |
| *** markvoelker has quit IRC | 10:17 | |
| *** yamamoto has quit IRC | 10:17 | |
| *** esberglu has joined #openstack-nova | 10:18 | |
| *** yamamoto has joined #openstack-nova | 10:18 | |
| *** yangyapeng has quit IRC | 10:18 | |
| *** hareesh has quit IRC | 10:18 | |
| *** gszasz has joined #openstack-nova | 10:18 | |
| *** slaweq has quit IRC | 10:19 | |
| *** hareesh has joined #openstack-nova | 10:19 | |
| *** yamamoto has quit IRC | 10:20 | |
| *** yamamoto has joined #openstack-nova | 10:20 | |
| *** esberglu has quit IRC | 10:21 | |
| *** zhurong has joined #openstack-nova | 10:23 | |
| *** zenoway has joined #openstack-nova | 10:29 | |
| *** tojuvone has joined #openstack-nova | 10:34 | |
| *** thorst has joined #openstack-nova | 10:42 | |
| *** zenoway has quit IRC | 10:45 | |
| *** zenoway has joined #openstack-nova | 10:46 | |
| *** cdent has joined #openstack-nova | 10:47 | |
| gibi | bauzas: OK, I will look into the resize test | 10:52 |
| *** udesale has joined #openstack-nova | 10:53 | |
| *** mdnadeem has quit IRC | 10:53 | |
| *** thorst has quit IRC | 10:54 | |
| *** thorst has joined #openstack-nova | 10:54 | |
| *** bkopilov has quit IRC | 10:55 | |
| *** yamamoto has quit IRC | 10:58 | |
| *** thorst has quit IRC | 10:59 | |
| *** slaweq has joined #openstack-nova | 10:59 | |
| *** yamamoto has joined #openstack-nova | 10:59 | |
| *** sdague has joined #openstack-nova | 10:59 | |
| *** phuongnh has quit IRC | 11:01 | |
| cdent | gibi: what new bugs have you found today | 11:04 |
| *** zenoway has quit IRC | 11:04 | |
| *** yamamoto has quit IRC | 11:05 | |
| cdent | gibi, bauzas : have you guys seen this https://review.openstack.org/#/c/489205/ is a fix for https://bugs.launchpad.net/nova/+bug/1708978 which is something we ought to make sure is in pike | 11:06 |
| openstack | Launchpad bug 1708978 in OpenStack Compute (nova) "The traits associations are deleted incorrectly" [High,In progress] - Assigned to Alex Xu (xuhj) | 11:06 |
| *** slaweq_ has joined #openstack-nova | 11:07 | |
| *** zenoway has joined #openstack-nova | 11:07 | |
| *** yamamoto has joined #openstack-nova | 11:07 | |
| *** yamamoto has quit IRC | 11:08 | |
| gibi | cdent: hi! no new bug today | 11:09 |
| cdent | <- disbelief | 11:09 |
| gibi | slow day | 11:09 |
| gibi | still working on the removal of the change scheduler in the func test and the resize to too big flavor patches | 11:10 |
| *** yamamoto has joined #openstack-nova | 11:10 | |
| *** sree has quit IRC | 11:10 | |
| gibi | so I had no time to play with some custom resource + resize tests | 11:10 |
| gibi | that will be my next fun | 11:10 |
| *** vks1 has quit IRC | 11:10 | |
| cdent | I’m not having the best success trying to keep track of everything: there are lots of indvidual patch sets spread around. I need to take some time to find them all. | 11:11 |
| *** slaweq_ has quit IRC | 11:12 | |
| *** yamamoto has quit IRC | 11:13 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 11:13 |
| gibi | most of them tight to a bug report | 11:13 |
| gibi | so if you look at the high prio bugs then your will find relevant patches | 11:14 |
| cdent | gibi: yeah, I know, it is more in terms of being able to have them all at once for a) an overview of what’s up, b) some local testing with the pending stuff | 11:14 |
| *** yamamoto has joined #openstack-nova | 11:15 | |
| *** huanxie has quit IRC | 11:15 | |
| cdent | since they are all spread around, there’s no easy way, to, for example, answer the question of “do these fixes play well together” or “what coverage is missing” | 11:15 |
| *** JoseMello has joined #openstack-nova | 11:16 | |
| *** yamamoto has quit IRC | 11:16 | |
| *** yamamoto has joined #openstack-nova | 11:16 | |
| gibi | cdent: ahh I see | 11:17 |
| gibi | cdent: I have no good answer for that | 11:17 |
| cdent | :) | 11:17 |
| *** slaweq_ has joined #openstack-nova | 11:17 | |
| cdent | I’m currently looking at coverage results when running just functional/test_servers.py to see if that raises any alarms. But because I’m looking at master I now it is missing several of the things that are in progress. | 11:17 |
| *** alexchadin has joined #openstack-nova | 11:19 | |
| cdent | gibi: a lot of what is missing is related to custom resource classes, so your plans for that will be useful | 11:20 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: ensure sharing RPs maps combinates with correct shared RP https://review.openstack.org/480379 | 11:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | 11:23 |
| alex_xu | cdent: ^ remove the 'root', instead to use 'sharing' and 'shared' | 11:23 |
| *** slaweq_ has quit IRC | 11:23 | |
| gibi | cdent: now I just have to find the time to write them :) | 11:24 |
| cdent | thank you alex_xu | 11:24 |
| gibi | bauzas: I removed the vcpu=2 from the SmallFakeDriver to see what fails | 11:24 |
| gibi | bauzas: I think we have a problem with the default 16.0 allocation ration. I don't see that it is applied at all | 11:24 |
| alex_xu | cdent: hope that works :) | 11:24 |
| gibi | bauzas: here is an example test failure http://paste.openstack.org/show/617764/ | 11:26 |
| cdent | gibi: do you get reasonable results from placement, but then the fake driver refuses then? If so, it’s probably a bug in the driver itself. If you’re not getting results from placement then is the inventory being set properly? | 11:26 |
| gibi | cdent: L66 worries me http://paste.openstack.org/show/617764/ | 11:27 |
| cdent | gibi: it’s max_unit, | 11:28 |
| cdent | that’s the problem | 11:28 |
| cdent | and is an actual problem: | 11:28 |
| cdent | we set max_unit to be the number of real cpus because we don’t think any single consumer should occupy more than the number of cpus, whatever allocation ratio says | 11:29 |
| cdent | which makes sense | 11:29 |
| cdent | but when we create a doubling allocation for the resize to same host, we’re breaking that | 11:29 |
| gibi | bauzas: ^^ | 11:30 |
| *** zenoway has quit IRC | 11:30 | |
| cdent | so as the code is currently designed, if using doubling, you can never resize to same host a guest with #vcpus == #pcpus | 11:30 |
| cdent | the quick fix for the tests is to use a bigger driverr | 11:30 |
| gibi | yes, that was what I proposed the bauzas suggested allocation ratio | 11:30 |
| *** zenoway has joined #openstack-nova | 11:30 | |
| gibi | but then I guess we cannot use the allocation ratio trick here | 11:30 |
| cdent | but we may need to consider that the doubling concept is problematic on small hosts… | 11:31 |
| cdent | yeah, allocation ratio doesn’t do anything for max_unit | 11:31 |
| gibi | OK I wait for bauzas to agree then I will push back the previos patch set of https://review.openstack.org/#/c/491529/ that has the SmallFakeDriver modification to 2 vcpus | 11:32 |
| cdent | alex_xu: it isn’t quite right. I’m trying to come up with a suitable alternative. I’ll push something up if that’s okay with you? | 11:33 |
| alex_xu | cdent: yea, appreciate the help, looks like I understand 'shared' and 'sharing' incorrectly | 11:33 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Fix all >= 2 hit 404s https://review.openstack.org/491761 | 11:33 |
| cdent | gibi: seems reasonable. I wonder who has an answer to the question about the legitimacy of resizing a large guest on a small host. I don’t really know. I wouldn’t want to do it, but I’m not paying for hardware... | 11:34 |
| *** zenoway has quit IRC | 11:34 | |
| gibi | resize on same host feels like a feature to support testing resize on single node devstack | 11:35 |
| *** zenoway has joined #openstack-nova | 11:36 | |
| *** mamandle has quit IRC | 11:39 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create reference subpage https://review.openstack.org/490994 | 11:39 |
| *** dave-mccowan has joined #openstack-nova | 11:40 | |
| *** lucasagomes is now known as lucas-hungry | 11:46 | |
| *** smatzek has joined #openstack-nova | 11:46 | |
| *** smatzek_ has joined #openstack-nova | 11:48 | |
| *** smatzek has quit IRC | 11:48 | |
| *** thorst has joined #openstack-nova | 11:51 | |
| *** slaweq_ has joined #openstack-nova | 11:51 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: placement: ensure RP maps to those RPs that share with it https://review.openstack.org/480379 | 11:51 |
| *** tiendc has quit IRC | 11:53 | |
| cdent | alex_xu: ^ that may be a bit better. I ended up finding it difficult to make clear. | 11:54 |
| *** yassine has joined #openstack-nova | 11:54 | |
| alex_xu | cdent: thanks | 11:55 |
| *** slaweq_ has quit IRC | 11:56 | |
| *** edmondsw has joined #openstack-nova | 11:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 11:58 |
| *** psachin has quit IRC | 11:58 | |
| *** lyan has joined #openstack-nova | 11:59 | |
| *** mdnadeem has joined #openstack-nova | 11:59 | |
| *** psachin has joined #openstack-nova | 12:00 | |
| *** pchavva has joined #openstack-nova | 12:01 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Raise NoValidHost if no allocation candidates https://review.openstack.org/491491 | 12:01 |
| *** slaweq_ has joined #openstack-nova | 12:01 | |
| gibi | bauzas: fixed your comment about the test ^^ | 12:02 |
| *** jpena|off is now known as jpena | 12:03 | |
| *** litao__ has quit IRC | 12:04 | |
| *** esberglu has joined #openstack-nova | 12:04 | |
| *** kiennt has quit IRC | 12:05 | |
| *** slaweq_ has quit IRC | 12:06 | |
| *** tuanluong has quit IRC | 12:07 | |
| *** hareesh has quit IRC | 12:08 | |
| *** esberglu has quit IRC | 12:09 | |
| *** slaweq_ has joined #openstack-nova | 12:11 | |
| bauzas | cdent: looking at alex_xu change, thanks for it | 12:12 |
| bauzas | gibi: cdent: looking at the above discussion, could you please summarize the problem with ratios ? | 12:13 |
| gibi | bauzas: we set max_unit of the vcpu resource based on the number of pcpus therefore we cannot ask for more than pcpu amount of vcpu in a single allocation | 12:14 |
| alex_xu | bauzas: thanks for the review | 12:14 |
| bauzas | gibi: mmm, sadly then | 12:14 |
| *** ratailor has quit IRC | 12:15 | |
| *** slaweq_ has quit IRC | 12:16 | |
| *** yamamoto has quit IRC | 12:18 | |
| *** yamamoto has joined #openstack-nova | 12:20 | |
| *** yamamoto has quit IRC | 12:20 | |
| gibi | bauzas: so are you OK with the SmallFakeDriver vcpu=2 change? | 12:21 |
| bauzas | gibi: looking | 12:21 |
| *** slaweq_ has joined #openstack-nova | 12:22 | |
| bauzas | gibi: just reviewing alex_xu and then it's your turn :p | 12:23 |
| gibi | bauzas: OK, thanks | 12:25 |
| *** slaweq_ has quit IRC | 12:28 | |
| openstackgerrit | Alexandra Settle proposed openstack/nova master: Create reference subpage https://review.openstack.org/490994 | 12:28 |
| bauzas | cdent: gibi: so, question about max_unit | 12:29 |
| * cdent listens | 12:29 | |
| bauzas | cdent: gibi: when we have a flavor asking for 10 CPUs, do you think it should be 10 pCPUs or 10 vCPUs ? | 12:29 |
| bauzas | cdent: gibi: MHO is that's for virtual ones | 12:30 |
| asettle | Ah shite, sdague and stephenfin - I got ahead of myself and updated the wrong nova patch (didn't tab to the right PR). I just updated this patch: https://review.openstack.org/#/c/490994/ with the change from Administrators to Adminstration Guide | 12:30 |
| asettle | I can revert if you'd like? | 12:30 |
| cdent | bauzas: it _is_ for vcpus | 12:30 |
| asettle | Otherwise, I was just going to make the same change on stephenfin 's patch: https://review.openstack.org/#/c/490952/ | 12:30 |
| bauzas | cdent: I know | 12:30 |
| cdent | and it should be | 12:30 |
| *** zhurong has quit IRC | 12:30 | |
| bauzas | cdent: gibi: but the point is then, why max_unit should be about *physical* resources ? | 12:30 |
| *** ralonsoh has quit IRC | 12:31 | |
| cdent | max_unit, in general, is abstract. where we make concrete assertions about its meaning is when we set inventory from the compute manager. In there we make the assertion that it is bad for a service to host a _single_ vm that has more vcpus than there are pcpus | 12:31 |
| *** ralonsoh has joined #openstack-nova | 12:32 | |
| cdent | when we discussed this before, several people mentioned that doing so would cause pathalogical context switching | 12:32 |
| bauzas | cdent: tbc, flavor * ratio should be <= max_unit | 12:32 |
| bauzas | not sure I understand the problem about max_unit being related to physical resources :( | 12:33 |
| cdent | ratio has _nothing_ to do with max unit. ratio is a measurement for all all guests, max_unit is for one | 12:33 |
| bauzas | cdent: sure, I know | 12:33 |
| cdent | bauzas: okay, so I dont understand what you’re asking or suggesting then? | 12:34 |
| sdague | asettle: don't work, I've got a patch sitting on top of it that I'm about to push and it should zero it back | 12:34 |
| asettle | sdague: dont work? | 12:34 |
| cdent | asettle: woot. you never need to work again! | 12:34 |
| asettle | cdent: I have seriously been waiting for this day for ages. | 12:34 |
| bauzas | cdent: the problem is that max_unit is blocking us for https://review.openstack.org/#/c/491529/4/nova/virt/fake.py@599 | 12:34 |
| sdague | asettle: don't worry | 12:34 |
| asettle | sdague: hahaha okay :) | 12:35 |
| cdent | bauzas: yes, in a way we want and expect it to. so either we change the fake driver or use a different one. | 12:35 |
| *** jaypipes has joined #openstack-nova | 12:35 | |
| asettle | I will go make my two second patch on stephenfin 's then | 12:35 |
| *** sbezverk has joined #openstack-nova | 12:35 | |
| bauzas | cdent: I'm unclear, why should we need to modify the resources if we have a ratio around 16.0 ? | 12:35 |
| bauzas | cdent: because of max_unit, because max_unit == pCPUs, right? | 12:36 |
| bauzas | that ^ looks weird to me, and changing the behaviour we had for 5 years | 12:36 |
| cdent | because we are creating an allocation, when we do the doubling, for a single consumer that is greater than max_unit | 12:36 |
| cdent | the change in behavior is the doubling | 12:36 |
| cdent | that’s what’s new | 12:36 |
| cdent | the max_unit behavior has been around for a while | 12:37 |
| bauzas | imagine a world where we would double the allocation, but have the previous behaviour | 12:37 |
| cdent | if we were able to do the doubling with two different consumer uuids, we wouldnt have this problem | 12:37 |
| bauzas | say I have a single pCPU with 16.0 ratio, I can still ask for 2 flavors of 1vCPU, right? | 12:37 |
| * gibi reads back | 12:37 | |
| cdent | bauzas: yes | 12:37 |
| bauzas | so, why can't we do that now ? | 12:38 |
| cdent | but that’s not what is being asked for here | 12:38 |
| cdent | we are literally asking for a single consumption with 2vcpu | 12:38 |
| jaypipes | morning folks | 12:38 |
| bauzas | cdent: if we have a ratio of 16.0, I don't think it's a problem | 12:38 |
| cdent | morning jaypipes: i hope your potty emergency is cleared up | 12:39 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 12:39 |
| bauzas | cdent: in a previous world, I could ask for one flavor of 2vCPUs with a single compute having 1pCPU | 12:39 |
| jaypipes | dansmith, cdent, bauzas: just FYI, I'm down to two test failures left on the confirm/resize patch series... | 12:39 |
| jaypipes | cdent: seems to be, yes. | 12:39 |
| sdague | asettle: ah, I guess it doesn't overwrite it, however it should be fine | 12:39 |
| asettle | sdague: okay :) that's not so bad. Just a wording nit anyway. | 12:39 |
| bauzas | jaypipes: dansmith: cdent: gibi: FWIW, I'll need to be on PTO tomorrow (only) btw. | 12:40 |
| jaypipes | bauzas: noted | 12:40 |
| cdent | bauzas: well clearly we do have a problem because stuff is broken: we cannot write the allocations we want to write. we can either not do the doubling or we can break the way max_unit works, or we can just use a bigger fake driver. neither of the two first options are worth doing at this time | 12:40 |
| asettle | Also stephenfin I have another file you need to move with the admin guide patch | 12:40 |
| bauzas | and then, I'll have my summer vacations starting next week for 2.5 weeks | 12:40 |
| asettle | Oh wait, nvm, you've already done it! | 12:40 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 12:40 |
| *** yamamoto has joined #openstack-nova | 12:40 | |
| bauzas | jaypipes: dansmith: cdent: gibi: Monday 14th Aug. to 30th Aug. incl. | 12:41 |
| bauzas | I'm telling you because it was a problem for June | 12:41 |
| bauzas | knowing when I was around | 12:41 |
| jaypipes | bauzas: k. thx for the heads up! | 12:42 |
| *** slaweq_ has joined #openstack-nova | 12:44 | |
| *** trinaths has left #openstack-nova | 12:45 | |
| *** lucas-hungry is now known as lucasagomes | 12:45 | |
| *** jpena is now known as jpena|mtg | 12:46 | |
| stephenfin | jaypipes: Any chance I could get eyes on this today (before I head off for another week)? https://review.openstack.org/#/c/453808 | 12:48 |
| stephenfin | Ignore the bp topic - that's just to link it. It's actually a prerequisite for that bp which I hope to work on next cycle | 12:48 |
| *** slaweq_ has quit IRC | 12:49 | |
| jaypipes | stephenfin: done | 12:52 |
| stephenfin | jaypipes: Shound | 12:52 |
| jaypipes | stephenfin: is that a type of dog that hangs out in libraries? | 12:53 |
| jaypipes | so has gibi come up with a bug of the day yet in placement? :) | 12:53 |
| stephenfin | jaypipes: :D No, it's the rural Irish equivalent of "thank you" | 12:54 |
| jaypipes | stephenfin: :) good to know! | 12:54 |
| *** slaweq_ has joined #openstack-nova | 12:54 | |
| jaypipes | stephenfin: how is that pronounced? | 12:54 |
| stephenfin | "Want to sound like a true Irishman? Use 'Sh' instead of 'S' for literally every word you encounter. Tashty shtuff" | 12:55 |
| *** felipemonteiro_ has joined #openstack-nova | 12:55 | |
| *** jpena|mtg is now known as jpena|off | 12:56 | |
| jaypipes | heh | 12:56 |
| *** felipemonteiro__ has joined #openstack-nova | 12:57 | |
| *** esberglu has joined #openstack-nova | 12:58 | |
| *** catintheroof has joined #openstack-nova | 13:00 | |
| gibi | jaypipes: not yet. I'm making myself busy with the removal of change scheduler from the func test and the fix for the resize to too big flavor bug | 13:00 |
| jaypipes | gibi: almost done with review on that | 13:00 |
| *** slaweq_ has quit IRC | 13:00 | |
| *** felipemonteiro_ has quit IRC | 13:01 | |
| *** lucasxu has joined #openstack-nova | 13:02 | |
| *** clayton has quit IRC | 13:03 | |
| bhagyashris | jaypipes, melwitt, dansmitt: Hi, | 13:04 |
| jaypipes | bhagyashris: we're still working on fixing bugs around shared resources. it doesn't look like Pike will include proper support for shared disk :( | 13:05 |
| alex_xu | jaypipes: a easy one https://review.openstack.org/#/c/489205/ for a bug of traits api | 13:05 |
| *** tbachman has quit IRC | 13:05 | |
| *** clayton has joined #openstack-nova | 13:05 | |
| bhagyashris | jaypipes: ok. I just wanted to ask related to the bfv | 13:05 |
| *** yangyapeng has joined #openstack-nova | 13:05 | |
| *** kazsh has left #openstack-nova | 13:06 | |
| bhagyashris | jaypipes, melwitt, dansmith: Why we are spending less attention to these patches[1][2]? [1]: https://review.openstack.org/#/c/428481/ [2]: https://review.openstack.org/#/c/428505 | 13:06 |
| bhagyashris | I believe bfv case is handle at the placement side properly so Is it necessity of [1][2] | 13:06 |
| stephenfin | asettle: To which file do you refer "As I said earlier, only major qualm is changing it to Administration Guide rather than Administrators." https://review.openstack.org/#/c/490952/ | 13:06 |
| stephenfin | ? | 13:06 |
| asettle | stephenfin: no file there. I was talking about the build. I was going to pull it down, and edit the index file. | 13:06 |
| stephenfin | I need to rework that to include some more changes, so I might as well change it here | 13:06 |
| stephenfin | Ahgg | 13:06 |
| asettle | But then I got confused, and edited sdague 's patch | 13:06 |
| stephenfin | *ahh | 13:06 |
| asettle | So, I fixed it, but in sdague 's patch, and not yours :) | 13:07 |
| asettle | So, do nothing there :P | 13:07 |
| * stephenfin isn't choking | 13:07 | |
| asettle | I hope not | 13:07 |
| stephenfin | ok then :) | 13:07 |
| * stephenfin loves it when a plan comes together | 13:07 | |
| *** sbezverk has quit IRC | 13:07 | |
| jaypipes | bhagyashris: we've been trying to increase functional test case coverage of resource accounting over the last couple weeks, focusing on move operations (resize, migrate, evacuate, etc). | 13:08 |
| jaypipes | bhagyashris: I'd be keen to look at those patches for Pike, but they need a rebase. | 13:08 |
| jaypipes | bhagyashris: are you interested in rebasing them? | 13:09 |
| *** yangyapeng has quit IRC | 13:10 | |
| *** links has quit IRC | 13:11 | |
| *** markvoelker has joined #openstack-nova | 13:12 | |
| jaypipes | alex_xu: done | 13:12 |
| *** shan has quit IRC | 13:15 | |
| *** slaweq_ has joined #openstack-nova | 13:16 | |
| *** bkopilov has joined #openstack-nova | 13:17 | |
| alex_xu | jaypipes: thx | 13:17 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add additional content to admin guide https://review.openstack.org/490952 | 13:19 |
| *** yangyapeng has joined #openstack-nova | 13:19 | |
| stephenfin | cdent, sdague: Remind me - what's changing wrt ports in OpenStack services? https://review.openstack.org/#/c/491796/ | 13:19 |
| * stephenfin recalls some talk of using :80 and :8080 for everything behind Apache/uWSGI? | 13:20 | |
| * cdent looks | 13:21 | |
| *** slaweq_ has quit IRC | 13:21 | |
| vdrok | good morning everyone! | 13:21 |
| *** mamandle has joined #openstack-nova | 13:21 | |
| cdent | stephenfin: the goals that has been expressed in devstack is that services will be on prefixes rather than ports, so that everything is either on port 80 or 443, depending the use of ssl, and you get service urls like http://exampe.com/compute http://example.com/image http://example.com/placeent | 13:22 |
| vdrok | have a small question, is it ok to have <address type="pci" ...> for ceph volume in the instance xml, not <address type="drive"...>? in the <disk> section of course | 13:22 |
| cdent | where example.com is likely a reverse proxy of some kind | 13:22 |
| *** vks1 has joined #openstack-nova | 13:23 | |
| cdent | in my experience, packagers aren’t bought into this idea | 13:23 |
| stephenfin | cdent: That sounds familiar alright. Do we need to include any references to that in that document? | 13:23 |
| *** baoli has joined #openstack-nova | 13:23 | |
| stephenfin | And, more importantly, I guess that document is still correct as it stands? | 13:23 |
| jaypipes | mdbooth: perhaps you might know the answer to vdrok's question above? | 13:23 |
| cdent | stephenfin: I don’t really feel like I’m in a position to answer that: every time I’ve tried to point out ports and such in the docs, it has ended up conflicting with what’s in debs and rpms and we’ve followed what’s in them | 13:24 |
| *** xyang1 has joined #openstack-nova | 13:24 | |
| vdrok | jaypipes: thx :) | 13:24 |
| jaypipes | np | 13:24 |
| sdague | asettle: I'm changing that index page a bit right now anyway based on the email I sent, so maybe hold a second | 13:25 |
| bhagyashris | jaypipes: yeah I will do this. but I have one query about the patches, As bfv case is handled properly at placement side so Is there a need of these two patches ? By looking at the patches it looks like they are only updating compute_node table records which are not required. | 13:25 |
| stephenfin | cdent: That's fair. Always worth asking | 13:25 |
| asettle | sdague: I am holding :) | 13:25 |
| sdague | once I get all these references building together | 13:26 |
| stephenfin | asettle, sdague: Pushed up the latest version of the "add stuff we missed from the admin guide" patch to address mriedem's comments. That probably affects your work, sdague? https://review.openstack.org/490952 | 13:26 |
| *** slaweq_ has joined #openstack-nova | 13:26 | |
| * stephenfin goes to find this email | 13:26 | |
| *** sree has joined #openstack-nova | 13:27 | |
| sdague | stephenfin: yeh, I think it will | 13:27 |
| *** jmlowe has quit IRC | 13:28 | |
| *** slaweq_ has quit IRC | 13:33 | |
| *** rmart04 has joined #openstack-nova | 13:33 | |
| jaypipes | bhagyashris: I'm not sure... I need to revisit those patches. | 13:35 |
| *** viswarya has quit IRC | 13:36 | |
| bhagyashris | jaypipes: ok. Thank you :) | 13:36 |
| *** cleong has joined #openstack-nova | 13:38 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances periodic task https://review.openstack.org/491808 | 13:38 |
| *** rmart04 has quit IRC | 13:38 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances periodic task https://review.openstack.org/491808 | 13:39 |
| *** alexchadin has quit IRC | 13:39 | |
| *** awaugama has joined #openstack-nova | 13:39 | |
| *** alexchadin has joined #openstack-nova | 13:40 | |
| *** awaugama has quit IRC | 13:40 | |
| *** alexchadin has quit IRC | 13:40 | |
| openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances() periodic task https://review.openstack.org/491808 | 13:40 |
| *** alexchadin has joined #openstack-nova | 13:40 | |
| *** alexchadin has quit IRC | 13:41 | |
| *** alexchadin has joined #openstack-nova | 13:41 | |
| *** alexchadin has quit IRC | 13:41 | |
| *** alexchadin has joined #openstack-nova | 13:42 | |
| *** smatzek_ has quit IRC | 13:43 | |
| *** awaugama has joined #openstack-nova | 13:44 | |
| sdague | stephenfin: while I'm chugging through toc references - https://review.openstack.org/#/c/491761 would be handy to get in to reduce 404s | 13:44 |
| *** rgerganov has joined #openstack-nova | 13:44 | |
| *** mdnadeem has quit IRC | 13:46 | |
| *** alexchadin has quit IRC | 13:46 | |
| *** hongbin has joined #openstack-nova | 13:47 | |
| *** felipemonteiro__ has quit IRC | 13:48 | |
| stephenfin | sdague: What happened to nova-cert? | 13:48 |
| stephenfin | (just out of curiosity) | 13:48 |
| *** slaweq_ has joined #openstack-nova | 13:48 | |
| dansmith | jaypipes: still crankin' on both patches yes? | 13:49 |
| *** ociuhandu has joined #openstack-nova | 13:50 | |
| sdague | stephenfin: we deleted it | 13:52 |
| *** slaweq_ has quit IRC | 13:53 | |
| sdague | https://review.openstack.org/#/c/461762/ | 13:53 |
| *** jsheeren has joined #openstack-nova | 13:54 | |
| jsheeren | hi all, how are the filenames generated for the image_cache under /var/lib/nova/instances/_base ? is it a sha1 sum or md5sum of the glance image id or something? | 13:55 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Add For Operators section to front page https://review.openstack.org/491815 | 13:55 |
| sdague | stephenfin: ok, see what you think of that bit | 13:56 |
| *** rgerganov has quit IRC | 13:56 | |
| * stephenfin looks | 13:56 | |
| *** ociuhandu has quit IRC | 13:56 | |
| stephenfin | also, I'd no idea nova-cert was gone. Good to know | 13:56 |
| stephenfin | asettle: https://review.openstack.org/491815 | 13:57 |
| stephenfin | another one for you too ;) | 13:57 |
| asettle | Hooray | 13:58 |
| *** rgerganov has joined #openstack-nova | 13:58 | |
| *** slaweq_ has joined #openstack-nova | 13:59 | |
| *** p01nt3r75 has joined #openstack-nova | 13:59 | |
| *** crushil has joined #openstack-nova | 14:00 | |
| *** gouthamr has joined #openstack-nova | 14:00 | |
| *** xinliang has quit IRC | 14:01 | |
| *** moshele has quit IRC | 14:01 | |
| *** smatzek has joined #openstack-nova | 14:01 | |
| cdent | jaypipes: if you’re in a cruising reviews kind of way, I’m pretty sure that we don’t want to do this so you might be able to quickly dismiss it: https://review.openstack.org/#/c/483506/ | 14:01 |
| cdent | jaypipes: but we might want to do this: https://review.openstack.org/#/c/483460/ (they used to be the same patches by the contributor I suggested they split them) | 14:02 |
| jaypipes | dansmith: yup. | 14:02 |
| jaypipes | cdent: k, will look at them during next test run. | 14:03 |
| dansmith | jaypipes: okay, is is the bottom patch that is giving you trouble or the top? If the top, then maybe you could push what you have for the bottom one so we can get it reviewed and maybe on the way? | 14:03 |
| jaypipes | dansmith: bottom one, unfortunately. I added a patch before the confirm/resize patch that cleans up the _remove_deleted_instance_allocations() method of the RT and adds a bunch of debug logging. | 14:04 |
| dansmith | okay | 14:04 |
| jaypipes | dansmith: only two failures left. should be pushing shortly. | 14:04 |
| dansmith | alright | 14:04 |
| *** marst has joined #openstack-nova | 14:05 | |
| *** smatzek has quit IRC | 14:05 | |
| *** slaweq_ has quit IRC | 14:06 | |
| *** cfriesen has joined #openstack-nova | 14:06 | |
| *** smatzek has joined #openstack-nova | 14:06 | |
| *** liverpooler has joined #openstack-nova | 14:06 | |
| jsheeren | nevemrind i found it | 14:08 |
| jsheeren | https://github.com/openstack/nova/blob/stable/newton/nova/virt/libvirt/imagecache.py#L53 | 14:09 |
| jsheeren | quit | 14:09 |
| *** jsheeren has quit IRC | 14:09 | |
| jaypipes | lol | 14:09 |
| *** mriedem has joined #openstack-nova | 14:09 | |
| *** slaweq has quit IRC | 14:10 | |
| gibi | jaypipes, bauzas, cdent: Why do we still have RamFilter and DiskFilter in the enabled_filters? https://github.com/openstack/nova/blob/master/nova/conf/scheduler.py#L251-L252 | 14:10 |
| *** tbachman has joined #openstack-nova | 14:10 | |
| *** sree has quit IRC | 14:10 | |
| jaypipes | gibi: I don't know. | 14:10 |
| *** sree has joined #openstack-nova | 14:11 | |
| gibi | jaypipes: interestingly CoreFilter is not there | 14:11 |
| *** jmlowe has joined #openstack-nova | 14:11 | |
| jaypipes | gibi: I presume for caching scheduler. | 14:11 |
| jaypipes | gibi: since it doesn't use placement | 14:11 |
| gibi | does CoreFilter needed also for the caching? | 14:11 |
| *** gaoyan has joined #openstack-nova | 14:12 | |
| bauzas | jaypipes: gibi: because CachingScheduler indeed | 14:12 |
| gibi | bauzas: then the missing CoreFilter is a bug I guess | 14:12 |
| jaypipes | gibi: I would assume so, yes. | 14:12 |
| bauzas | and also because when we used placement in Ocata, we agreed to not modify the nova.conf | 14:12 |
| bauzas | now we're in Pike, we could just cut that | 14:13 |
| robcresswell | Re: Horizons magic edit flavor action, its now disabled-by-default, and the documentation for the setting has a big fat warning sign all over it. https://review.openstack.org/#/c/491442/ | 14:13 |
| *** xinliang has joined #openstack-nova | 14:13 | |
| bauzas | gibi: I know, but devstack runs it | 14:13 |
| cdent | robcresswell++ | 14:13 |
| bauzas | gibi: crazy, I know | 14:13 |
| robcresswell | Hopefully that means less headaches from now on :) | 14:13 |
| stephenfin | sdague: Done. Because this is mostly new docs, I've started pulling on grammar stuff. Figure it's worth doing now rather than kicking the can | 14:13 |
| sdague | robcresswell: ++ | 14:14 |
| sdague | stephenfin: sure thing | 14:14 |
| gibi | bauzas, jaypipes: anyhow I'm filing a bug that the default is not consistent. Either we need all three Core,Ram,DiskFilter or non of them | 14:14 |
| mriedem | we should remove them | 14:14 |
| mriedem | caching scheduler isn't the default | 14:14 |
| mriedem | so that's not the reason | 14:14 |
| mriedem | we just didn't remove ram/disk yet because nobody did it | 14:14 |
| sdague | robcresswell: other question, when I was linking to horizon docs this morning, I was surprised that they didn't include screen shots | 14:14 |
| mriedem | we also didn't do https://review.openstack.org/#/c/427200/ yet because the logic is complicated | 14:15 |
| sdague | is that on your plan? | 14:15 |
| bauzas | mriedem: agreed, we could cut that in Pike | 14:15 |
| dansmith | mriedem: bauzas: agreed | 14:15 |
| bauzas | mriedem: we didn't done that for Ocata because of the upgrade | 14:15 |
| bauzas | want me to do so ? | 14:15 |
| *** gaoyan has quit IRC | 14:15 | |
| bauzas | with a devstack related patch | 14:16 |
| sdague | mriedem: more 404 cleanups - https://review.openstack.org/#/c/491761 | 14:17 |
| robcresswell | sdague: It's not something we've done before, since it was mostly dev / contributor docs. It's a sensible idea for the admin / user / operator content though. | 14:18 |
| sdague | robcresswell: hmm ok, this didn't seem like dev docs - https://docs.openstack.org/horizon/latest/user/launch-instances.html | 14:18 |
| gibi | mriedem, bauzas, dansmith: here is the bug for the cut https://bugs.launchpad.net/nova/+bug/1709328 | 14:19 |
| openstack | Launchpad bug 1709328 in OpenStack Compute (nova) "the default of the scheduler.enabled_filters config is inconsistent" [Undecided,New] | 14:19 |
| robcresswell | sdague: Yeah, that got ported over as part of the docs -> repos move in the past month. | 14:19 |
| sdague | robcresswell: gotcha | 14:19 |
| sdague | stephenfin: before I fix the gramar bits in the top patch, you want to go through - https://review.openstack.org/#/c/491785 as well? | 14:20 |
| sdague | so I can get them in one go | 14:20 |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Add format_dom for PCI device addresses https://review.openstack.org/491822 | 14:21 |
| bauzas | mriedem: dansmith: like I said to other folks there, I won't be there tomorrow only | 14:21 |
| bauzas | mriedem: dansmith: plus being on vacations for 2.5 weeks starting on Monday till Wed (incl.) two weeks after | 14:21 |
| *** Guest13936 is now known as med_ | 14:21 | |
| *** med_ has quit IRC | 14:21 | |
| *** med_ has joined #openstack-nova | 14:21 | |
| *** med_ is now known as medberry | 14:21 | |
| stephenfin | sdague: Yup, I'm on that atm | 14:22 |
| gibi | mriedem: FYI, I'm planning to skip the notification meeting today | 14:23 |
| sdague | stephenfin: thank you | 14:23 |
| dansmith | bauzas: like I said, probably easier if you just tell us when you _will_ be here | 14:24 |
| dansmith | thu/fri of this week sounds like? | 14:24 |
| bauzas | yup | 14:24 |
| * bauzas should provide his agenda honestly :( | 14:24 | |
| dansmith | okay, I'm out those days (first PTO all year) | 14:24 |
| mriedem | gibi: ok | 14:24 |
| *** jpena|off is now known as jpena | 14:25 | |
| bauzas | June was terrible to me, I don't want August to be the same | 14:25 |
| stephenfin | sdague: done | 14:27 |
| *** itlinux has joined #openstack-nova | 14:28 | |
| stephenfin | For reference, I'm off the rest of the week and most of next week. Not aware of anything hinging on me though, thankfully | 14:29 |
| stephenfin | dansmith, sdague, bauzas, mriedem, alex_xu, melwitt, jaypipes, (anyone I might have missed): ^ | 14:29 |
| jaypipes | stephenfin: cool. I'll assign a bunch of stuff to you on Friday. | 14:30 |
| mriedem | nope. i'm out next week as well. | 14:31 |
| stephenfin | jaypipes: Yay! It'll be just like being back in Intel | 14:31 |
| jaypipes | hehe | 14:32 |
| mriedem | jaypipes: where are we at with this? https://review.openstack.org/#/c/488510/ | 14:33 |
| jaypipes | mriedem: just wrapping up local testing. should be pushed in <30 mins | 14:33 |
| sdague | mriedem: cool, so am I also out the next 2 weeks as we do a family road trip into the eclipse zone | 14:33 |
| *** gbarros has joined #openstack-nova | 14:33 | |
| * gibi will be here next week but will be out the week after | 14:35 | |
| stephenfin | sdague: Looks like this one's good to go, if it doesn't interfere with your stuff too much https://review.openstack.org/#/c/490952/ | 14:35 |
| * cdent never leaves | 14:35 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:37 | |
| *** armax has joined #openstack-nova | 14:37 | |
| *** jpena is now known as jpena|off | 14:38 | |
| sdague | stephenfin: yeh, let me look | 14:41 |
| sdague | stephenfin: +A | 14:41 |
| *** alexchadin has joined #openstack-nova | 14:42 | |
| *** medberry is now known as med_ | 14:43 | |
| openstackgerrit | Merged openstack/nova master: placement: filtering the resource provider id when delete trait association https://review.openstack.org/489205 | 14:43 |
| mriedem | edleafe: re https://review.openstack.org/#/c/487925/ someone pointed out https://review.openstack.org/#/c/449587/ is basically the same change | 14:43 |
| mriedem | i was -1 on that at the time but looks like for the wrong reason | 14:43 |
| *** slaweq has joined #openstack-nova | 14:43 | |
| edleafe | mriedem: yeah, I mentioned that in one of my comments, and listed Lucas a co-author | 14:44 |
| *** dtantsur is now known as dtantsur|brb | 14:44 | |
| mriedem | ah ok | 14:45 |
| *** smatzek has quit IRC | 14:46 | |
| *** alexchadin has quit IRC | 14:47 | |
| stephenfin | asettle, sdague: I assume we can abandon this now as we've gone another direction? https://review.openstack.org/#/c/478485/ | 14:48 |
| stephenfin | *I can | 14:48 |
| *** gyee has joined #openstack-nova | 14:48 | |
| *** links has joined #openstack-nova | 14:48 | |
| cfriesen | if nobody else is working on gibi's bug above, I can do it. | 14:48 |
| asettle | stephenfin: by all means | 14:48 |
| *** slaweq has quit IRC | 14:48 | |
| *** links has quit IRC | 14:49 | |
| gibi | cfriesen: I have no intention to start fixing it now. | 14:51 |
| mriedem | stephenfin: did you see my question about migrating the hypervisor-specific config references, e.g. https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/config-reference/source/compute/hypervisor-hyper-v.rst ? | 14:53 |
| mriedem | stephenfin: that was tipped off to me by jungleboyj in cinder b/c apparently some cinder docs for windows volumes references that | 14:53 |
| mriedem | but i know the vmware config reference is quite detailed also | 14:53 |
| *** slaweq has joined #openstack-nova | 14:53 | |
| mriedem | maybe we just report a bug that it's a gap? | 14:53 |
| stephenfin | mriedem: Yeah, I haven't migrated any of the config-reference stuff at the moment | 14:54 |
| mriedem | ok, i'll open a bug to track it | 14:54 |
| stephenfin | Yeah, none of the info on the options themselves needs to be migrated because oslo.config does this for us automagically now | 14:55 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1709335 | 14:55 |
| openstack | Launchpad bug 1709335 in OpenStack Compute (nova) "docs migration is missing hypervisor-specific configuration references" [Undecided,New] | 14:55 |
| stephenfin | ...which is miles better than the openstack-doc-tools insanity that was required beforehand (as asettle can testify to) | 14:56 |
| mriedem | yeah that's fine - these are more about actually setting up the compute host for a given virt backend | 14:56 |
| asettle | stephenfin: yeah fuck mate don't bring up that shit | 14:56 |
| stephenfin | mriedem: Gotcha. I'll do that in the next few hours | 14:56 |
| *** annegentle has joined #openstack-nova | 14:56 | |
| mriedem | asettle: that sailor talk will have to be reserved for fleet week | 14:56 |
| * asettle shuffles awkwardly | 14:56 | |
| asettle | Soorrrryyy | 14:56 |
| smcginnis | :D | 14:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Extend nfv feature matrix with pinning/NUMA https://review.openstack.org/327126 | 14:59 |
| *** slaweq has quit IRC | 14:59 | |
| mriedem | melwitt: are you planning on putting any notes about the location of the console auth service in a multi-cell layout in the docs? | 14:59 |
| *** gyee_ has joined #openstack-nova | 15:01 | |
| *** gbarros has quit IRC | 15:01 | |
| *** psachin has quit IRC | 15:01 | |
| *** mamandle has quit IRC | 15:02 | |
| *** gbarros has joined #openstack-nova | 15:04 | |
| *** slaweq has joined #openstack-nova | 15:04 | |
| *** gyee_ has quit IRC | 15:04 | |
| *** gyee has quit IRC | 15:04 | |
| *** vks1 has quit IRC | 15:04 | |
| *** gyee has joined #openstack-nova | 15:05 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 15:05 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Add For Operators section to front page https://review.openstack.org/491815 | 15:05 |
| openstackgerrit | Sean Dague proposed openstack/nova master: rework index intro to describe nova https://review.openstack.org/491834 | 15:05 |
| sdague | stephenfin: I think I got them all sorted, plus a final change to actually make the index intro fit it's new role | 15:06 |
| stephenfin | sdague: Cool. I'll finish importing the config guide then take a gawk | 15:07 |
| sdague | great | 15:08 |
| *** slaweq has quit IRC | 15:10 | |
| openstackgerrit | Thomas Bechtold proposed openstack/nova master: Handle deleted instances when refreshing the info_cache https://review.openstack.org/398308 | 15:11 |
| *** lpetrut_ has joined #openstack-nova | 15:11 | |
| toabctl | mriedem, hey. could you have another look at https://review.openstack.org/#/c/398308/ ? you added your +2 already month ago. I rebased the patch and addressed 2 more comments... | 15:12 |
| *** tbachman has quit IRC | 15:12 | |
| mriedem | toabctl: didn't jichenjc have a conflicting change for this? | 15:13 |
| *** tbachman has joined #openstack-nova | 15:13 | |
| mriedem | yeah https://review.openstack.org/#/c/363585/ | 15:13 |
| *** lpetrut has quit IRC | 15:14 | |
| toabctl | mriedem, hm. need to check if theses are the the issues | 15:15 |
| toabctl | mriedem, https://review.openstack.org/#/c/398308/ catches the exception "globally" | 15:16 |
| toabctl | mriedem, see your own comment :) | 15:16 |
| *** Oku_OS is now known as Oku_OS-away | 15:16 | |
| *** lpetrut_ has quit IRC | 15:17 | |
| mriedem | i don't trust anything i said over 6 months ago | 15:18 |
| dansmith | s/months/days for me | 15:18 |
| toabctl | heh | 15:18 |
| dansmith | and if it's about placement, then .. hours | 15:18 |
| *** zenoway has quit IRC | 15:19 | |
| *** vks1 has joined #openstack-nova | 15:20 | |
| *** zenoway has joined #openstack-nova | 15:20 | |
| *** smatzek has joined #openstack-nova | 15:22 | |
| *** sbezverk has joined #openstack-nova | 15:23 | |
| *** sbezverk_ has joined #openstack-nova | 15:24 | |
| *** mmehan has joined #openstack-nova | 15:24 | |
| *** slaweq has joined #openstack-nova | 15:26 | |
| *** marst_ has joined #openstack-nova | 15:26 | |
| *** mingyu has quit IRC | 15:26 | |
| *** marst has quit IRC | 15:27 | |
| *** sbezverk has quit IRC | 15:28 | |
| *** zenoway has quit IRC | 15:29 | |
| *** zenoway has joined #openstack-nova | 15:30 | |
| *** dtantsur|brb is now known as dtantsur | 15:30 | |
| *** slaweq has quit IRC | 15:30 | |
| *** jmlowe has quit IRC | 15:32 | |
| *** jmlowe has joined #openstack-nova | 15:32 | |
| *** slaweq has joined #openstack-nova | 15:36 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: no instance info cache update if instance deleted https://review.openstack.org/363585 | 15:36 |
| *** coreywright has quit IRC | 15:37 | |
| cfriesen | anyone seen this error message (in the context of block live migration of boot-from-volume instance with a config drive): error : qemuMigrationPrecreateStorage:1714 : Operation not supported: pre-creation of storage targets for incremental storage migration is not supported | 15:41 |
| *** armax has quit IRC | 15:42 | |
| *** slaweq has quit IRC | 15:42 | |
| *** armax has joined #openstack-nova | 15:43 | |
| sdague | ok, it's about 3 hour wait time for check nodes right now, so I'm going to walk away for a bit. Any review of those doc bits would be nice | 15:45 |
| *** JoseMello has quit IRC | 15:45 | |
| *** markus_z has quit IRC | 15:46 | |
| *** jamesdenton has quit IRC | 15:49 | |
| *** coreywright has joined #openstack-nova | 15:50 | |
| mriedem | dansmith: melwitt: do we want to try and get this into ocata? https://review.openstack.org/#/c/428481/ | 15:50 |
| mriedem | *pike i mean | 15:50 |
| *** jamesdenton has joined #openstack-nova | 15:50 | |
| *** vks1 has quit IRC | 15:51 | |
| stephenfin | mriedem, asettle: Is it just me, or does this not belong in the install guide? https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/config-reference/source/compute/hypervisor-hyper-v.rst | 15:51 |
| dansmith | mriedem: didn't jaypipes' fix for the allocation thing I wrote effectively do this? | 15:51 |
| stephenfin | (and all hypervisor-xxx docs) | 15:51 |
| asettle | stephenfin: that belongs in config | 15:51 |
| asettle | Why is it in the install?! | 15:51 |
| mriedem | dansmith: no idea | 15:52 |
| *** tbachman has quit IRC | 15:52 | |
| *** slaweq_ has joined #openstack-nova | 15:52 | |
| stephenfin | asettle: It seems like an install step to me? (Configuring compute nodes) | 15:52 |
| stephenfin | It's currently in '/admin' | 15:52 |
| stephenfin | Or, rather, I have it moved into '/admin' at the moment | 15:53 |
| sdague | stephenfin: I think this is the issue of the docs which were feature oriented (the existing placement doc is the same thing) where concept, install, config were all in one doc | 15:53 |
| dansmith | mriedem: https://review.openstack.org/#/c/490514/7/nova/scheduler/utils.py | 15:53 |
| sdague | honestly, I would just say pick one for now, and all those are going to need to get broken up later to be more usage oriented | 15:53 |
| mriedem | stephenfin: leave in config (/admin) for now | 15:54 |
| dansmith | mriedem: the scheduler equivalent of that | 15:54 |
| *** krtaylor has quit IRC | 15:54 | |
| asettle | sdague does have a point. I would move to admin for now, and then we can figure it out | 15:54 |
| stephenfin | mriedem, sdague, asettle: "He stays" (in admin) | 15:54 |
| sdague | I also honestly think where things land on disk is not super important | 15:54 |
| mriedem | dansmith: so do we run melwitt's functional test in https://review.openstack.org/#/c/428505/11/nova/tests/functional/test_boot_from_volume.py and see if the problem is gone? | 15:54 |
| sdague | our consumers for the most part aren't browsing a local filesystem | 15:54 |
| *** yamamoto has quit IRC | 15:54 | |
| openstackgerrit | Merged openstack/nova master: Fix all >= 2 hit 404s https://review.openstack.org/491761 | 15:54 |
| sdague | they are coming in from the web, so it's just about how things end up on the glass with navigation patterns | 15:55 |
| stephenfin | sdague: It kind of does because the filesystem manifests itself in the URL structure | 15:55 |
| *** hamzy has quit IRC | 15:55 | |
| sdague | stephenfin: which is ignored by 99% of consumers | 15:55 |
| dansmith | mriedem: I dunno, I think that test looks at a lot of RT stuff doesn't it? | 15:55 |
| stephenfin | and I was pretty sure the plan was to still have central "Admin guide" and "Install guide" pages that deep link into each folder | 15:55 |
| stephenfin | sdague: True | 15:56 |
| bauzas | jaypipes: cdent: gibi: I clarified my opinion in https://review.openstack.org/#/c/491529/5/nova/tests/functional/integrated_helpers.py@75 about using all the filters | 15:56 |
| stephenfin | Documentation is hard work. | 15:56 |
| sdague | stephenfin: for sure | 15:56 |
| bauzas | jaypipes: cdent: gibi: I'm okay with using all of them by default, just not in the same change, that's it | 15:56 |
| sdague | stephenfin: it's possible we get there, there is so much near duplication of content from these different sources though, it's going to take a lot of massaging to figure it out | 15:57 |
| asettle | stephenfin sdague - I'm going to print screen that you two are both agreeing that docs are hard work and cherish that forever | 15:57 |
| asettle | Do you know how many times I've heard that docs aren't necessary and my job is worthless :D | 15:57 |
| * asettle screen caps | 15:57 | |
| sdague | asettle: zomg, that's terrible. | 15:58 |
| *** yamamoto has joined #openstack-nova | 15:58 | |
| *** felipemonteiro__ has joined #openstack-nova | 15:58 | |
| cfriesen | asettle: anyone making such a statement is obviously not worth listening to. | 15:58 |
| asettle | *shrug* it is what it is :) | 15:58 |
| asettle | cfriesen: in a nutshell ;0 | 15:59 |
| asettle | ;) * | 15:59 |
| asettle | My favourite argument is that their code is so pure no docs are required for it's beauty | 15:59 |
| asettle | Because 'you should just be able to read the code' ;) | 15:59 |
| cfriesen | having written pure and beautiful code and then gone back 5 years later..... | 15:59 |
| *** smatzek has quit IRC | 15:59 | |
| *** smatzek has joined #openstack-nova | 16:00 | |
| asettle | hahahhahaha | 16:00 |
| sean-k-mooney | asettle: cfriesen that argument may fly for perl. i here its considered a write only language so need to read it again 5 years later :P | 16:01 |
| * stephenfin learns that nova apparently supports "User mode Linux", whatever that is | 16:01 | |
| asettle | stephenfin: uhhhhh who wrote that? :P did we? | 16:02 |
| asettle | sean-k-mooney: pretty much goes for all code, no? | 16:02 |
| sean-k-mooney | stephenfin: that is when you use qemu without kvm/xen i think | 16:02 |
| *** felipemonteiro_ has quit IRC | 16:02 | |
| sfinucan | sean-k-mooney: Doesn't look like it http://user-mode-linux.sourceforge.net/ | 16:02 |
| sean-k-mooney | asettle: there is some code that is self documenting and it you coreccletly decompose your codded into small fuctions it can be but ingererall comment help alot | 16:03 |
| sdague | sfinucan: it's what came before xen | 16:03 |
| stephenfin | Oops - wrong nick | 16:03 |
| *** yamamoto has quit IRC | 16:03 | |
| stephenfin | sdague: Is it still relevant? | 16:03 |
| sdague | stephenfin: I wouldn't think so | 16:03 |
| cfriesen | sean-k-mooney: no, actually it's different and funky | 16:03 |
| * stephenfin kills that section | 16:03 | |
| edleafe | asettle: Docs aren't necessary - to the person writing the code. To everyone else, though... | 16:03 |
| sdague | user mode linux was run linux kernels as user processes | 16:03 |
| asettle | edleafe: I think that's the point at the end, right? :p | 16:04 |
| asettle | I wrote my first little python script so I feel ya | 16:04 |
| edleafe | asettle: :) | 16:04 |
| asettle | It is obviously perfect | 16:04 |
| asettle | And makes sense to *everyone* | 16:04 |
| asettle | :p | 16:04 |
| edleafe | but of course | 16:04 |
| sdague | circa late 90s | 16:04 |
| sean-k-mooney | stephenfin: huh that is weird but ok if nova supports it thne great if there is not a ci for it though its broken by default | 16:04 |
| sdague | honestly, uml is kind of docker before docker | 16:04 |
| cfriesen | sdague: wouldn't that be lxc? | 16:06 |
| sean-k-mooney | sdague: so its like lxc/openvz container. e.g a sandboxed system level container/chroot? | 16:06 |
| *** p01nt3r75 has quit IRC | 16:06 | |
| sdague | sean-k-mooney: yeh, except pre namespaces | 16:06 |
| *** Apoorva has joined #openstack-nova | 16:07 | |
| cfriesen | sean-k-mooney: sdague: I think it's actually linux implemented using POSIX as the architecture. | 16:07 |
| *** sridharg has quit IRC | 16:07 | |
| sdague | anyway, the crux of it, I'd remove all the references to it in the nova space. I expect someone got somethign working in cactus, but never bothered again after | 16:08 |
| sdague | and the reference lasted until now | 16:08 |
| cfriesen | sdague: yeah, agreed. don't see why anyone would actually use it with nova | 16:08 |
| stephenfin | Yup, they're gone | 16:08 |
| stephenfin | There was only one (that I've found so far) | 16:09 |
| sdague | oh, this is why - https://blueprints.launchpad.net/nova/+spec/austin-user-mode-linux | 16:09 |
| sdague | they were attempting to use it for testing instead of 2nd level qemu | 16:09 |
| sean-k-mooney | sdague: looking at https://wiki.openstack.org/wiki/Nova/UML it looks like its pluged in under livbivrt | 16:09 |
| stephenfin | sdague: Importing this config guide is proving slower than I thought (alll the cross-references). I may need to have you take over it if I don't get much further in the next hour or so | 16:09 |
| stephenfin | (I'm gone tomorrow on) | 16:10 |
| sdague | stephenfin: no prob | 16:10 |
| mriedem | melwitt: i've rebased and cleaned up the conflict in the stable branches for https://review.openstack.org/#/q/I8cd056fa17184a98c31547add0e9fb2d363d0908,n,z | 16:10 |
| mriedem | melwitt: now just need to get the series of changes below that one merged | 16:10 |
| *** dtp has joined #openstack-nova | 16:10 | |
| *** yassine has quit IRC | 16:10 | |
| *** armax has quit IRC | 16:10 | |
| sdague | stephenfin: before you leave, if you can send me an email with the patch url, and what the major reference fixing looks like | 16:10 |
| sdague | just to get me running on it quicker | 16:11 |
| sdague | as I'm about to go out for a bike ride while the getting is good | 16:11 |
| stephenfin | Will do | 16:11 |
| *** zenoway has quit IRC | 16:11 | |
| *** armax has joined #openstack-nova | 16:11 | |
| *** mingyu has joined #openstack-nova | 16:15 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | 16:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012 | 16:21 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: refactor healing of allocations in RT https://review.openstack.org/491850 | 16:21 |
| *** yangyapeng has quit IRC | 16:21 | |
| jaypipes | dansmith: ok, I did my best on the above but it's icky and may have made a mistake or two. | 16:21 |
| dansmith | okay | 16:21 |
| jaypipes | dansmith: really need your eyeballs on it. | 16:21 |
| *** yangyapeng has joined #openstack-nova | 16:21 | |
| dansmith | I guess I didn't think there was that much change needed... | 16:22 |
| *** krtaylor has joined #openstack-nova | 16:23 | |
| dansmith | jaypipes: this replaces the delete with "heal" which doesn't make sense to me | 16:24 |
| dansmith | since we're also still healing in the non-delete path | 16:24 |
| jaypipes | dansmith: the heal will need to recreate allocations for ocata-deleted allocations, which is why I renamed it heal. I know, it's bad | 16:24 |
| *** lucasagomes is now known as lucas-afk | 16:24 | |
| dansmith | and it doesn't heal right? it deletes. | 16:25 |
| *** lyan has quit IRC | 16:25 | |
| jaypipes | dansmith: well, this method will need to re-create allocations that an ocata compute node deleted incorrectly. | 16:25 |
| *** yangyapeng has quit IRC | 16:26 | |
| *** lyan has joined #openstack-nova | 16:26 | |
| jaypipes | dansmith: if an ocata compute node was the source for a migrate to a pike compute host. | 16:26 |
| dansmith | but that's already done in update_usage_for_instance right? | 16:26 |
| *** chyka has joined #openstack-nova | 16:26 | |
| dansmith | in the top patch, conditional on the presence of ocata computes | 16:26 |
| *** sshwarts has quit IRC | 16:27 | |
| *** pcaruana has quit IRC | 16:27 | |
| jaypipes | dansmith: ack, sorry, yes, you're right. | 16:28 |
| jaypipes | dansmith: I can rename it back to delete... | 16:28 |
| dansmith | jaypipes: I'm not sure what the point of this patch is though.. just some extra conditions for not calling delete? | 16:28 |
| jaypipes | dansmith: the point of this patch was two things: 1) to only delete allocations when the instance is DELETED or SHELEVED_OFFLOADED and 2) add a bunch of log statements so we can see what state instances are in during this _remove_deleted_instances_allocations() method | 16:29 |
| dansmith | jaypipes: okay I thought we were doing this filtering earlier such that by the time we got here we didn't have anything other than the ones we needed to delete.. | 16:30 |
| jaypipes | dansmith: I added the debug log statements when trying to fix the issue alex_xu brought up about evacuate code paths not being correct. | 16:30 |
| dansmith | we've been round and round about this particular conditional, so maybe I missed something | 16:31 |
| *** rcernin has quit IRC | 16:31 | |
| jaypipes | dansmith: the evacuate code paths were not being affected by the update_usage_for_instance() path for some reason. | 16:31 |
| *** slagle has quit IRC | 16:31 | |
| *** gjayavelu has joined #openstack-nova | 16:31 | |
| jaypipes | dansmith: on the source host at least. | 16:31 |
| *** tesseract has quit IRC | 16:31 | |
| *** saphi has joined #openstack-nova | 16:32 | |
| jaypipes | dansmith: so when trying to verify the evacuate code path for scenario when source host is restarted, I was trying to get log messages about the instances in this method. sorry, it got really confusing :( | 16:32 |
| *** sahid has quit IRC | 16:32 | |
| dansmith | jaypipes: so vm_states.ALLOW_RESOURCE_REMOVAL excludes things that aren't deleted or shelved_offloaded, so doesn't that cover us? | 16:32 |
| dansmith | oh, not for deleting allocations I guess | 16:33 |
| jaypipes | right, that actually results in InstanceNotFound. | 16:33 |
| dansmith | what does? | 16:33 |
| jaypipes | when an instance is deleted. | 16:33 |
| jaypipes | the Instance.get_by_uuid() returns InstanceNotFound | 16:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853 | 16:34 |
| mriedem | stephenfin: in case you haven't left yet, there are two duplicate upgrade notes for similar things in the libvirt driver about port filtering capability | 16:35 |
| mriedem | https://docs.openstack.org/releasenotes/nova/unreleased.html#id15 | 16:35 |
| jaypipes | dansmith: sorry about all of this :( in trying to address alex_xu's review comments about evacuate I ended up going down the rabbithole. | 16:35 |
| jaypipes | dansmith: and it's likely I've f'd it all up now :( | 16:35 |
| dansmith | jaypipes: okay, yeah, I'm confused I guess | 16:35 |
| stephenfin | mriedem: I assume we can just delete one/ | 16:35 |
| stephenfin | *? | 16:35 |
| dansmith | jaypipes: I'm throwing some comments in here though | 16:35 |
| jaypipes | k | 16:35 |
| mriedem | stephenfin: they are slightly different | 16:35 |
| *** lyan has quit IRC | 16:36 | |
| *** markvoelker has quit IRC | 16:36 | |
| mriedem | https://github.com/openstack/nova/blob/501a0fe65afabb7e6a8b1e2d1ca0fbcea941d2d1/releasenotes/notes/libvirt-ignore-allow_same_net_traffic-fd88bb2801b81561.yaml | 16:36 |
| mriedem | https://github.com/openstack/nova/blob/5c0cb33d75acb284a3b6299c851ab70f10f69dfc/releasenotes/notes/libvirt-firewall-ignore-use_ipv6-c555f95799f991fd.yaml | 16:36 |
| *** chyka has quit IRC | 16:37 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Remove ram/disk sched filters from default list https://review.openstack.org/491854 | 16:37 |
| *** gszasz has quit IRC | 16:38 | |
| mriedem | stephenfin: maybe i'll just make sure the boilerplate text is the same between the two | 16:40 |
| mriedem | and leave the rest | 16:40 |
| stephenfin | mriedem: As in keep both but make the shared part look similar? | 16:41 |
| cfriesen | mriedem: dansmith: how much validation of images should nova do? I'm getting a report that with RDB instance storage launching an instance from qcow2 format image doesn't boot but launching instance from raw format image works. Booting from volume with either image works. | 16:41 |
| stephenfin | or something else? | 16:41 |
| mriedem | stephenfin: yes | 16:41 |
| stephenfin | mriedem: Cool. You or me doing that? | 16:41 |
| mriedem | i'm doing it | 16:42 |
| *** lyan has joined #openstack-nova | 16:42 | |
| stephenfin | (y) | 16:42 |
| cfriesen | mriedem: dansmith: similarly, should we believe glance when it tells us the image type? In Newton at least glance doesn't appear to be validating the specified image type. | 16:43 |
| *** slaweq_ has quit IRC | 16:43 | |
| *** alexchadin has joined #openstack-nova | 16:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup release note about ignoring allow_same_net_traffic https://review.openstack.org/491855 | 16:44 |
| bauzas | folks, bailing out, see you Thursday \o | 16:44 |
| *** slaweq has joined #openstack-nova | 16:45 | |
| *** chyka has joined #openstack-nova | 16:49 | |
| *** chyka has quit IRC | 16:49 | |
| *** lyan has quit IRC | 16:49 | |
| *** annegentle has quit IRC | 16:49 | |
| *** alexchadin has quit IRC | 16:49 | |
| *** chyka has joined #openstack-nova | 16:49 | |
| *** Apoorva_ has joined #openstack-nova | 16:50 | |
| stephenfin | bauzas: o/ | 16:50 |
| stephenfin | mriedem: +2d | 16:52 |
| *** derekh has quit IRC | 16:52 | |
| stephenfin | sdague: email sent | 16:52 |
| *** yamahata has quit IRC | 16:52 | |
| stephenfin | (I hope - Evolution sux) | 16:52 |
| *** smatzek has quit IRC | 16:53 | |
| *** Apoorva has quit IRC | 16:53 | |
| *** ralonsoh has quit IRC | 16:53 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853 | 16:55 |
| *** saphi has quit IRC | 16:56 | |
| * stephenfin packs bags | 16:57 | |
| stephenfin | See you all next week o/ | 16:57 |
| *** chyka has quit IRC | 16:58 | |
| *** baoli has quit IRC | 17:00 | |
| *** artom_ is now known as artom | 17:01 | |
| *** slaweq has quit IRC | 17:02 | |
| *** abalutoiu has joined #openstack-nova | 17:02 | |
| *** aarefiev_ has joined #openstack-nova | 17:03 | |
| cdent | jaypipes, bauzas, dansmith, mriedem : I made a new patch to publish the placement-api-ref. https://review.openstack.org/#/c/491860/ it depends on the top patch in https://review.openstack.org/#/q/topic:cd/placement-api-ref+status:open so it would be nice if we could get those in and have happy little docs | 17:04 |
| jaypipes | cdent: kk | 17:04 |
| *** kylek3h has joined #openstack-nova | 17:04 | |
| *** udesale has quit IRC | 17:07 | |
| *** tbachman has joined #openstack-nova | 17:08 | |
| *** baoli has joined #openstack-nova | 17:09 | |
| *** annegentle has joined #openstack-nova | 17:13 | |
| *** mingyu has quit IRC | 17:16 | |
| *** smatzek has joined #openstack-nova | 17:17 | |
| *** dtantsur is now known as dtantsur|afk | 17:17 | |
| melwitt | dansmith, mriedem: my bfv functional test queries hypervisor stats to verify correct handling of bfv. it seems like that's independent of the RT, right? | 17:17 |
| dansmith | no, that's where hv stats come from | 17:18 |
| *** sree has quit IRC | 17:18 | |
| *** abalutoiu has quit IRC | 17:18 | |
| melwitt | so currently the scheduler, claims, and reporting will be different than hv stats? | 17:19 |
| *** sree has joined #openstack-nova | 17:19 | |
| melwitt | that is, they'll show different resource amounts? | 17:19 |
| openstackgerrit | Doug Hellmann proposed openstack/nova master: use intersphinx to link to horizon https://review.openstack.org/491866 | 17:19 |
| dansmith | melwitt: we do account for things a little differently in placement, which is what scheduler is using for the basis of choosing a host, and claiming against | 17:20 |
| dansmith | hv stats has never been particularly correct either, mind you | 17:21 |
| melwitt | okay | 17:21 |
| *** yangyapeng has joined #openstack-nova | 17:21 | |
| *** baoli has quit IRC | 17:22 | |
| melwitt | I think I could update the test to query placement for how much disk the compute node is reporting | 17:22 |
| melwitt | because that's all I was doing is verifying it's reporting 0 local_gb_used | 17:22 |
| *** baoli has joined #openstack-nova | 17:22 | |
| *** sree has quit IRC | 17:23 | |
| dansmith | so the compute node's allocation will account for it, but we don't heal if we're on pike only, | 17:23 |
| melwitt | it would be interested to see if the test passes with those lines commented out too, because if bfv isn't handled correctly yet, it won't even be able to boot instances | 17:23 |
| melwitt | *interesting | 17:23 |
| *** hamzy has joined #openstack-nova | 17:24 | |
| dansmith | looking earlier, the place I had added it to the scheduler request didn't seem particularly correct anymore | 17:24 |
| sean-k-mooney | hi everyone quick question is "nova-manage cell_v2 create_cell" updating the db directly or calling the api to create the cell entries? | 17:24 |
| dansmith | sean-k-mooney: directly | 17:24 |
| *** tbachman_ has joined #openstack-nova | 17:24 | |
| dansmith | sean-k-mooney: almost all of nova-manage is direct-to-databsae | 17:24 |
| sean-k-mooney | dansmith: cool thanks, that is what i taught. trying debug an issue in kolla and wnated to check where the logs would be | 17:24 |
| dansmith | on the bfv thing, I'm a little concerned about even getting jaypipes' set in before rc at this point, so... | 17:25 |
| *** tbachman__ has joined #openstack-nova | 17:25 | |
| *** shan has joined #openstack-nova | 17:26 | |
| *** yangyapeng has quit IRC | 17:26 | |
| *** tbachman has quit IRC | 17:26 | |
| *** tbachman__ is now known as tbachman | 17:26 | |
| *** vks1 has joined #openstack-nova | 17:28 | |
| *** tbachman_ has quit IRC | 17:28 | |
| melwitt | yeah. I've been trying to mention the bfv thing occasionally throughout this cycle because it's one of the top things people are looking for from resource providers and I haven't been able to tell how close we are to that working | 17:28 |
| *** sambetts is now known as sambetts|afk | 17:29 | |
| melwitt | I'll try stacking the test on top of jay's set locally to see if it passes without the hv stats stuff | 17:29 |
| dansmith | jaypipes' set doesn't affect any of this, AFAIK | 17:30 |
| dansmith | and we're not even accounting for moves properly right now (which is the subject of the set) which is arguably more important | 17:30 |
| dansmith | my zero request patch may actually still work, since we're still calling resources_from_request_spec or whatever it's calls | 17:32 |
| cdent | dansmith: have you got a summary of “what’s wrong today”? It’s hard to keep track. | 17:32 |
| dansmith | *called | 17:32 |
| dansmith | cdent: no | 17:32 |
| openstackgerrit | Doug Hellmann proposed openstack/nova master: use extlinks to build series-specific links https://review.openstack.org/491869 | 17:32 |
| cdent | roger that, I’ll travel with lights | 17:32 |
| melwitt | dansmith: okay. I thought earlier you said we're already accounting for it in the current stuff, I must have misunderstood | 17:33 |
| dansmith | melwitt: I said we are on the compute node, but that the scheduler probably isn't (which I since confirmed) | 17:34 |
| *** vks1 has quit IRC | 17:34 | |
| dansmith | and if we're on pike we'll depend on the scheduler having it right | 17:34 |
| melwitt | I see, thanks | 17:34 |
| *** yamahata has joined #openstack-nova | 17:34 | |
| dansmith | which is what my zero request patch is for.. asking the scheduler for zero root disk | 17:34 |
| openstackgerrit | Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | 17:34 |
| melwitt | yeah | 17:34 |
| dansmith | this is somewhat wrapped up in the shared storage thing which we're punting on again, so it really can't be right regardless | 17:35 |
| melwitt | okay. yeah, I was wondering about the shared storage thing too. good to know | 17:36 |
| *** sbezverk_ has quit IRC | 17:37 | |
| *** markvoelker has joined #openstack-nova | 17:37 | |
| jaypipes | melwitt: yeah, the bfv accounting issues will most likely remain in Pike unfortunately. | 17:38 |
| *** yangyapeng has joined #openstack-nova | 17:40 | |
| *** sbezverk has joined #openstack-nova | 17:42 | |
| dansmith | jaypipes: replied | 17:42 |
| *** hemna_ has joined #openstack-nova | 17:42 | |
| dansmith | jaypipes: I still don't see how we get to the offload thing, and just want that code to be less complicated, but if we're not sure or you've seen it in real life somehow, then we should just leave it in I guess | 17:43 |
| *** markvoelker has quit IRC | 17:44 | |
| jaypipes | dansmith: this patch is mostly in response to mriedem and alex_xu's comments on https://review.openstack.org/#/c/488510/ ps 27. | 17:44 |
| *** yangyapeng has quit IRC | 17:45 | |
| *** slagle has joined #openstack-nova | 17:45 | |
| jaypipes | dansmith: i.e. this from mriedem: | 17:45 |
| jaypipes | Related to #4, there is bug https://bugs.launchpad.net/nova/+bug/1679750 where we don't delete allocations from Placement in nova-api when doing a "local delete", i.e. when the compute host is down, or the instance does not have a host associated (e.g. shelved_offloaded state). | 17:45 |
| openstack | Launchpad bug 1679750 in OpenStack Compute (nova) "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,In progress] | 17:45 |
| *** alexchadin has joined #openstack-nova | 17:45 | |
| jaypipes | dansmith: but I admit I've probably f'd this series up :( | 17:45 |
| *** annegentle has quit IRC | 17:45 | |
| jaypipes | trying to fix these corner cases | 17:45 |
| dansmith | jaypipes: the shelved offloaded thing in that bug is conjecture right? | 17:46 |
| jaypipes | dansmith: yes, but listed by mriedem as something to handle | 17:46 |
| dansmith | jaypipes: yeah, but maybe he didn't dig to see how we'd actually get here :) | 17:46 |
| * dansmith wonders how many times we have to say mriedem before he shows up | 17:47 | |
| jaypipes | perhaps. this code is fugly, as you know. | 17:47 |
| mriedem | 3 more times | 17:47 |
| dansmith | jaypipes: that bug as written does't actually say anything about shelved, although I thought mriedem had said something about it | 17:47 |
| openstackgerrit | Merged openstack/nova master: Handle ironicclient failures in Ironic driver https://review.openstack.org/487925 | 17:47 |
| mriedem | i forgot my kid at camp and they called | 17:47 |
| mriedem | so i'll be paying for that in counseling sessions later | 17:47 |
| jaypipes | mriedem: Dad of the Year. | 17:48 |
| mriedem | tbc, i dropped that link in the change as an fyi | 17:48 |
| mriedem | and listed the move operations | 17:48 |
| mriedem | i was not meaning that the bug had to be fixed in that change | 17:48 |
| *** lyan has joined #openstack-nova | 17:48 | |
| dansmith | mriedem: well, we're not sure there is a bug | 17:48 |
| dansmith | or, I'm not | 17:49 |
| jaypipes | mriedem: sure. though the changes I put in there were also to highlight code paths that alex_xu had pointed out around evacuate and the local delete problem where the compute host was down. | 17:49 |
| dansmith | if there is, I'm skeptical that offloaded and host==self is a case we can have :) | 17:49 |
| jaypipes | in there == the new bottom patch on the series. | 17:49 |
| dansmith | jaypipes: the local delete path should be deleting the allocation itself right? | 17:49 |
| dansmith | so that there's nothing to clean up here, ideally | 17:49 |
| mriedem | if the instance is offloaded, host is None | 17:49 |
| *** alexchadin has quit IRC | 17:49 | |
| dansmith | like, we shouldn't actually delete the instance unless we were able to nuke the allocation | 17:50 |
| mriedem | the point of the bug was that yes we should delete allocations in the local delete case, if we care | 17:50 |
| dansmith | right | 17:50 |
| dansmith | so not in RT at all, IMHO | 17:50 |
| jaypipes | dansmith: the local delete path never gets to the compute host, thus the need for the allocation to be deleted when the compute host starts back up and sees allocations for instances that no longer exist. | 17:50 |
| mriedem | melwitt wrote a test that shows that even though we don't delete the allocations in the api in local delete cases, when the compute host comes back up and the instance is gone, the allocation is deleted by the compute | 17:50 |
| dansmith | jaypipes: no dude, delete it from the api :) | 17:50 |
| mriedem | now ^ might be impacted by whatever you guys are doing | 17:50 |
| dansmith | jaypipes: and don't mark the instance as deleted until you succeeded, or there isn't an allocation | 17:50 |
| mriedem | this https://review.openstack.org/#/c/470578/ | 17:51 |
| dansmith | jaypipes: then there's less complexity for the compute node to handle | 17:51 |
| jaypipes | dansmith: oh, you mean delete the allocation from placement during the nova-api's "local delete" operation? | 17:51 |
| jaypipes | dansmith: we'd still need to deal with ocata apis that didn't do that though ;) yay. | 17:52 |
| dansmith | jaypipes: yeah, we delete anything we can from there without the compute node, | 17:52 |
| dansmith | which is kinda the point of it | 17:52 |
| dansmith | since we can totes nuke the allocation we're good | 17:52 |
| dansmith | jaypipes: why? | 17:52 |
| *** Swami has joined #openstack-nova | 17:52 | |
| dansmith | jaypipes: if we nuke it from api, we have to be pike, an ocata compute isn't going to care, right? | 17:52 |
| jaypipes | dansmith: are you saying we *currently* delete the allocation from the API? | 17:52 |
| dansmith | no I'm saying we should do that, and that's what the bug is about | 17:52 |
| dansmith | mriedem: right? | 17:53 |
| jaypipes | dansmith: if an ocata api local-deleted an instance, then is upgraded to pike, the compute host is upgraded to pike as well, wouldn't there be an allocation left over for the compute host that would need deleting? | 17:54 |
| mriedem | melwitt: question in https://review.openstack.org/#/c/470578/ | 17:54 |
| dansmith | jaypipes: sure, but you're doing that right? | 17:54 |
| melwitt | mriedem: I'll add console proxy stuff to the cells docs. I was thinking to mention that "in the future" we're planning to change the location, so people have a heads up | 17:54 |
| mriedem | dansmith: correct | 17:55 |
| melwitt | mriedem: also thanks for rebasing those backport series. didn't even get a chance to ask you yet :) | 17:55 |
| mriedem | during local delete in the API, we delete shit from external services like cinder/neutron because the compute is down or the instance doesn't have a host (it's offloaded) | 17:55 |
| mriedem | placement would be included in "external shit" | 17:55 |
| jaypipes | dansmith: heh, yes, I am. sorry, I thought you were saying there'd be no need for that code. | 17:55 |
| dansmith | jaypipes: no, I don't think there's a need for the shelve offload part I commented on, but for local delete we should hope to never hit this code if we deleted from the api as expected | 17:56 |
| jaypipes | ahhh, sorry. | 17:56 |
| dansmith | jaypipes: if there is an allocation for us that refers to an instance that is marked as deleted, then we should delete the allocation | 17:57 |
| *** gjayavelu has quit IRC | 17:57 | |
| mriedem | when we shelve offload an instance, the allocations for that compute node should be cleaned up by the RT | 17:57 |
| dansmith | jaypipes: note my comment about notfound for later though | 17:57 |
| melwitt | mriedem: to your question, yeah it seems like it would be racy. not sure what else to do though. | 17:57 |
| dansmith | mriedem: we clean the allocations before we offload it, so I don't think we need to handle cleanup there | 17:57 |
| mriedem | dansmith: via RT yeah? | 17:57 |
| dansmith | mriedem: otherwise we couldn't have been offloaded | 17:58 |
| mriedem | melwitt: you could call the update_available_resource method directly | 17:58 |
| dansmith | mriedem: yeah we call direct to self._update or wahtever | 17:58 |
| mriedem | self.service.manager.update_available_resource or whatever | 17:58 |
| melwitt | oh, okay | 17:58 |
| dansmith | mriedem: yeah, I assumed you mean the periodic osrry | 17:58 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4345 | 17:58 |
| mriedem | right it calls rt.update_usages | 17:59 |
| mriedem | *usage | 17:59 |
| mriedem | and the offloaded state is in the ALLOW_REMOVAL_STATES or whatever | 17:59 |
| mriedem | so the only case for local delete of allocatoins in the api is when the instance isn't shelved offloaded but the compute service is down | 17:59 |
| *** itlinux has quit IRC | 18:04 | |
| *** annegentle has joined #openstack-nova | 18:09 | |
| mriedem | jaypipes: tbc, i dont know that we need to handle the local delete in the api thing right now | 18:10 |
| mriedem | unless the computes won't cleanup those allocations when they come back up | 18:10 |
| cdent | I’d like it if we could merge some of the pending code as we have several in flight bug fixes, all vaguely interrelated, and it is hard to find yet more bugs while those are still in the way (and not all in the same stack). We may just need to be willing to have some bugs in master (we already do) so we can find and fix more of them. | 18:11 |
| dansmith | mriedem: jaypipes: agreed | 18:13 |
| *** annegentle has quit IRC | 18:13 | |
| *** slaweq has joined #openstack-nova | 18:14 | |
| jaypipes | dansmith, mriedem: so, bottom line, the changes in https://review.openstack.org/#/c/491850/ are fundamentally OK aside from some of the typos dansmith noted? | 18:15 |
| mriedem | i'll have to go through it, | 18:18 |
| mriedem | i've been waiting for dansmith to be ok with things | 18:18 |
| mriedem | i need to push up something quick and then i'll take a look | 18:22 |
| dansmith | jaypipes: not just typos right? | 18:25 |
| dansmith | or are you going to leave the shelve_offloaded thing? | 18:25 |
| jaypipes | dansmith: I can remove that, sure. | 18:26 |
| dansmith | I think we should remove it if we can't explain it and deal with it later if we determine there's a gap there | 18:26 |
| dansmith | it'll be a shelve gap, of which there are many | 18:26 |
| *** gjayavelu has joined #openstack-nova | 18:26 | |
| dansmith | jaypipes: I say clean it up and let mriedem take a look fresh | 18:26 |
| dansmith | not like we're going to get check results any time soon anyway | 18:27 |
| jaypipes | kk | 18:27 |
| melwitt | this is interesting. I'm running the test_boot_from_volume func test after rebasing and it used to allow an in-place resize (1 vcpu to 1 vcpu on a host with only 1 vcpu) but now it's saying it needs 2 vcpus to do the resize | 18:27 |
| mriedem | melwitt: yup :) | 18:28 |
| mriedem | we double the allocations in the scheduler | 18:28 |
| mriedem | well, sum rather than take the max | 18:28 |
| mriedem | https://review.openstack.org/#/c/490085/ | 18:29 |
| melwitt | yeah, I remember seeing some mention of that in the channel chats. I guess I'm surprised at the behavior change? I didn't think we'd want to change how that works because users will hit this | 18:29 |
| melwitt | well, I guess maybe resize on same host isn't too common so maybe they won't hit it | 18:29 |
| mriedem | dansmith and i talked about why sum vs max() in https://review.openstack.org/#/c/490085/ but now i can't really remember the reasoning | 18:30 |
| *** lpetrut_ has joined #openstack-nova | 18:30 | |
| mriedem | i think to basically be consistent with multiple hosts | 18:31 |
| mriedem | so if you have an allocation for host A and host B, then the instance allocations are 1 VCPU on each | 18:31 |
| dansmith | it's hypervisor-dependent behavior | 18:31 |
| dansmith | so the only sane thing we can do is double-claim everything | 18:32 |
| melwitt | yeah, I mean I could see the logic in it. I think my concern is with the change in behavior. that's something to call out in the release notes/docs I think | 18:32 |
| *** nicolasbock has quit IRC | 18:32 | |
| melwitt | i.e. thing that used to work, no longer works | 18:32 |
| dansmith | it's not, | 18:32 |
| dansmith | because it's a scheduler thing users won't see | 18:33 |
| dansmith | i.e. they can't ask for resize to the same host | 18:33 |
| dansmith | I mean, maybe it's worth calling out for operators that things you think used to fit one way won't anymore, | 18:33 |
| dansmith | if that's what you mean | 18:33 |
| melwitt | it is in my test. I have a compute node with 1 vcpu and was doing a resize on it, 1 vcpu to 1 vcpu. that used to work, now it doesn't because it wants 2 vcpus and that violates the compute node resource constraints | 18:33 |
| dansmith | but it's not like fundamentally different externally visible behavior | 18:33 |
| mriedem | dansmith: can you explain the hypervisor-dependent behavior? not sure i'm following you there. | 18:35 |
| dansmith | mriedem: meaning libvirt very loosely defines a vcpu and thus if a thing isn't running it's not really using any resource, | 18:35 |
| *** lpetrut_ has quit IRC | 18:35 | |
| melwitt | yeah, since we don't default allow_resize_same_host=True then I think it's less likely users will see it externally. so maybe more realistically it'll come up as you said for operators that are setting allow_resize_to_same_host=True for testing etc | 18:35 |
| dansmith | but if you pin cpus to dedicated mode then it will | 18:35 |
| dansmith | melwitt: that flag is really just for tempest and the gate yeah | 18:36 |
| *** vishwanathj has quit IRC | 18:36 | |
| *** vishwanathj has joined #openstack-nova | 18:37 | |
| dansmith | a general prelude about placement and resource accounting differences is useful, which I think bauzas has up right? | 18:37 |
| dansmith | because there are differences between the old filters and placement's logic, some of which we rolled over with ocata | 18:38 |
| melwitt | yeah, that would be really good to have | 18:39 |
| mriedem | the prelude reno doesn't go into those details | 18:40 |
| mriedem | https://review.openstack.org/#/c/491424/ | 18:40 |
| melwitt | maybe a pointer to a doc if too much detail would be big | 18:40 |
| mriedem | it's not in a doc :) | 18:40 |
| melwitt | when it's in a doc | 18:40 |
| *** gjayavelu has quit IRC | 18:40 | |
| *** markvoelker has joined #openstack-nova | 18:40 | |
| mriedem | when it's in a doc would have to be before we release 16.0.0 | 18:40 |
| mriedem | we could put something here https://docs.openstack.org/nova/latest/user/placement.html#pike-16-0-0 | 18:41 |
| mriedem | and have the prelude point at that | 18:41 |
| *** yangyapeng has joined #openstack-nova | 18:41 | |
| dansmith | mriedem: it's totally in there | 18:41 |
| dansmith | mriedem: it says "this is not an exhaustive list" -> "and other stuff, kthx" | 18:41 |
| melwitt | yeah. I dunno, just imagining people noticing this stuff and wondering who the what now | 18:41 |
| mriedem | dansmith: you're joking right? | 18:42 |
| dansmith | mriedem: yes | 18:42 |
| melwitt | though it won't be for like a year since that's when people would start trying Pike | 18:42 |
| mriedem | jaypipes was talking about putting up a devref for how resize is going to be handled | 18:42 |
| mriedem | but maybe for now, | 18:42 |
| mriedem | we go cheap and easy and throw a bullet in https://docs.openstack.org/nova/latest/user/placement.html#pike-16-0-0 and then reference that from the prelude for 'more info' type stuff for now | 18:42 |
| mriedem | i.e. during scheduling, we get the allocation candidates from placement, and then use those to get the compute nodes from the cells, and iterate the results using the enabled filters | 18:43 |
| mriedem | then we iterate the hosts and make allocation requests for the instance against a given host, retrying as necessary until an allocation is made or all allocations are exhausted, which results in NoValidHost | 18:44 |
| mriedem | for a move operation, allocations are made on the source and dest hosts, | 18:44 |
| mriedem | for a resize to the same host, allocations are summed on the same host | 18:44 |
| mriedem | ^ is that sufficient for a note in https://docs.openstack.org/nova/latest/user/placement.html#pike-16-0-0 ? | 18:44 |
| melwitt | we can just copy-paste this into the doc :) | 18:44 |
| mriedem | i'll just throw something up using that and we can take a look | 18:45 |
| melwitt | ++ | 18:46 |
| *** alexchadin has joined #openstack-nova | 18:46 | |
| *** yangyapeng has quit IRC | 18:46 | |
| *** markvoelker has quit IRC | 18:48 | |
| jaypipes | dansmith: pls see latest coment on https://review.openstack.org/#/c/491850/1/nova/compute/resource_tracker.py | 18:49 |
| *** Apoorva_ has quit IRC | 18:49 | |
| jaypipes | dansmith: line 1060 | 18:50 |
| jaypipes | dansmith: ? for you there. | 18:50 |
| *** Apoorva has joined #openstack-nova | 18:50 | |
| *** alexchadin has quit IRC | 18:50 | |
| melwitt | guh, looks like it's a PITA to change the resources SmallFakeDriver has | 18:50 |
| mriedem | melwitt: i did something like this, sec | 18:52 |
| mriedem | melwitt: one thing is just using FakeDriver | 18:52 |
| mriedem | it has more resources | 18:52 |
| dansmith | jaypipes: well, you are putting a continue in there that wasn't there before, but also, I think it's actually dead code | 18:52 |
| mriedem | the ServerMovingTests use that | 18:52 |
| mriedem | for the same reason | 18:52 |
| dansmith | jaypipes: L1028 clears the tracked instances, then you roll through and exclude things that are in that set, but it's empty right? | 18:52 |
| melwitt | mriedem: I found some examples but they involve stubbing out the compute driver load | 18:53 |
| jaypipes | dansmith: but the call to _update_usage_from_instance() on line 1042 adds instances back into tracked_instances :) | 18:53 |
| jaypipes | dansmith: perfectly. clear. | 18:53 |
| dansmith | jaypipes: ah right, well then you are changing it | 18:54 |
| jaypipes | dansmith: I know, it's awfulness. | 18:54 |
| mriedem | melwitt: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L1074-L1077 | 18:55 |
| melwitt | mriedem: yesss thank you | 18:56 |
| dansmith | jaypipes: so we only have things in tracked_instances that are not offloaded or deleted, and your assertion is that if we processed them in that thing, added to tracked, and then found an allocation we can ignore entirely | 18:56 |
| jaypipes | dansmith: yup. those represent the "normals" | 18:57 |
| jaypipes | dansmith: and we don't need to remove any allocations for them. | 18:57 |
| jaypipes | dansmith: they're active, stopped, paused, etc | 18:57 |
| jaypipes | dansmith: still consuming resources on the node and that's acceptable. | 18:57 |
| dansmith | jaypipes: yeah okay re-reading my scenario, I see that update would have excluded anything we in those states _and_ things we don't have running on our host I guess, the latter being the critical point | 18:58 |
| jaypipes | right. I was just adding some log statements in there... | 18:58 |
| dansmith | I'm not sure it's less confusing the way you have it written, but don't change it now | 18:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add track_instance_changes note in disable_group_policy_check_upcall https://review.openstack.org/490627 | 18:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: considerations before deploying multiple cells https://review.openstack.org/491885 | 18:59 |
| *** slaweq has quit IRC | 19:00 | |
| cdent | melwitt: you might take a look at gibi’s tests where he’s messing with resize to same host. that’s where a lot of the fiddling and discussion about make tests happy has happened: around ps4 on https://review.openstack.org/#/c/491529/ | 19:00 |
| mriedem | dansmith: posed a question in my own patch ^ for https://review.openstack.org/#/c/491885/ to how we'd best like to communicate the online data migrations not being multi-cell aware | 19:00 |
| *** slaweq has joined #openstack-nova | 19:01 | |
| melwitt | thanks cdent | 19:01 |
| dansmith | mriedem: I was thinking about this after you brought it up, but people can't have multiple cells worth of things needing migration, so I'm not sure we need to even say anything, right? | 19:02 |
| mriedem | dansmith: because a new cell would be empty and we couldn't fallback to it anyway? | 19:02 |
| mriedem | and new things would be in the api db | 19:02 |
| dansmith | yeah | 19:02 |
| mriedem | not for pike i suppose | 19:03 |
| mriedem | the mention in the code review guide is probably legit though right? https://review.openstack.org/#/c/491885/1/doc/source/contributor/code-review.rst | 19:03 |
| dansmith | mriedem: well, any data migration at all needs to consider multiple cells.. I guess that means we should make the runner thing arrange to run it against all cells | 19:04 |
| dansmith | mriedem: but yeah | 19:04 |
| mriedem | like say you deploy multiple cells in pike, start populating them, and then in queens we have some data migration to move something to the api db | 19:04 |
| dansmith | mriedem: hopefully we're done with that pattern, but yeah | 19:04 |
| mriedem | but i still have to move the bandwidth_usage table to the api db! | 19:04 |
| dansmith | mriedem: redirect to trash can | 19:05 |
| mriedem | ok i'll drop the thing in the layout page | 19:05 |
| openstackgerrit | Merged openstack/nova master: Create reference subpage https://review.openstack.org/490994 | 19:05 |
| *** slaweq has quit IRC | 19:06 | |
| openstackgerrit | Merged openstack/nova master: doc: Add additional content to admin guide https://review.openstack.org/490952 | 19:06 |
| *** slaweq has joined #openstack-nova | 19:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: code review considerations for online data migrations https://review.openstack.org/491885 | 19:08 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: refactor healing of allocations in RT https://review.openstack.org/491850 | 19:09 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | 19:09 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012 | 19:09 |
| jaypipes | dansmith, mriedem: k. ^^ | 19:09 |
| toabctl | oomichi, hey. could you have a look at https://review.openstack.org/#/c/398308/ please? | 19:10 |
| *** aarefiev_ has quit IRC | 19:13 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 19:16 |
| *** shan has quit IRC | 19:18 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481 | 19:20 |
| openstackgerrit | melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505 | 19:20 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 19:22 |
| openstackgerrit | Sean Dague proposed openstack/nova master: rework index intro to describe nova https://review.openstack.org/491834 | 19:22 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 19:22 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Add For Operators section to front page https://review.openstack.org/491815 | 19:22 |
| *** baoli has quit IRC | 19:22 | |
| sdague | well that was an interesting gerrit edge case | 19:22 |
| *** itlinux has joined #openstack-nova | 19:24 | |
| melwitt | what happened | 19:26 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 19:27 |
| *** pchavva has quit IRC | 19:27 | |
| melwitt | mriedem: it looks like this is why we shouldn't need to call update_available_resource directly https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1138-L1144 | 19:32 |
| mriedem | melwitt: but you didn't stop the compute service, you just disabled it | 19:33 |
| mriedem | and then re-enabled it | 19:33 |
| mriedem | honestly i'm not even sure how that test is passing... | 19:33 |
| *** awaugama has quit IRC | 19:33 | |
| melwitt | oh, right | 19:34 |
| melwitt | it's magic! | 19:34 |
| mriedem | i probably led you down a dark path | 19:34 |
| melwitt | the path of dark magic | 19:35 |
| mriedem | i'm a 10th level drow elf on the weekends | 19:35 |
| melwitt | lol | 19:35 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057 | 19:37 |
| melwitt | I'm gonna check what happens with this test if I don't re-enable the service. if it doesn't fail then, something has changed | 19:37 |
| melwitt | huh. I think something is afoot here | 19:40 |
| melwitt | disabling the service must not be doing what I think it is | 19:41 |
| dansmith | it does very little.. what do you think it does | 19:41 |
| dansmith | ? | 19:41 |
| melwitt | well, mriedem suggesting doing it to force a local delete. to make the "service.is_up()" return False | 19:41 |
| melwitt | but it seems to be still considered up | 19:41 |
| dansmith | that won't do it | 19:42 |
| *** yangyapeng has joined #openstack-nova | 19:42 | |
| melwitt | *suggested. why do I keep using the wrong tense of every word | 19:42 |
| melwitt | well hells bells | 19:42 |
| dansmith | disabled is only checked by a scheduler filter to exclude hosts | 19:42 |
| melwitt | is there a better way other than setting the update interval really low and sleeping? that's what I was doing before and that kinda sucks | 19:42 |
| dansmith | yeah, that's not reasonable, IMHO | 19:43 |
| mriedem | melwitt: i said force-down | 19:43 |
| dansmith | stop the service and tweak the updated_at on it | 19:43 |
| mriedem | not disable | 19:43 |
| mriedem | force-down is what the api will check for is_up | 19:43 |
| dansmith | will force down trigger a local delete? | 19:43 |
| * dansmith looks | 19:43 | |
| melwitt | but the code you linked to was doing a disable | 19:43 |
| melwitt | gah | 19:43 |
| melwitt | okay, lemme look at force-down then | 19:44 |
| *** markvoelker has joined #openstack-nova | 19:44 | |
| dansmith | ah yeah it will work | 19:44 |
| dansmith | service_is_up() checks it and that's what api is using | 19:45 |
| dansmith | you should kill the service first though, | 19:45 |
| melwitt | sweet | 19:45 |
| dansmith | to make sure you're not running periodics I think | 19:45 |
| melwitt | thanks yall | 19:45 |
| mriedem | let me -1 quick | 19:45 |
| mriedem | for points | 19:45 |
| melwitt | and to mess up jaypipes stats | 19:46 |
| *** yangyapeng has quit IRC | 19:47 | |
| mriedem | melwitt: https://review.openstack.org/#/c/470578/3/nova/tests/functional/regressions/test_bug_1679750.py@31 was confusing | 19:48 |
| mriedem | i said force down and then linked to gibi's thing which was disable | 19:48 |
| mriedem | i guess i meant the same PUT /os-services API | 19:48 |
| mriedem | it was an exercise for the reader | 19:48 |
| melwitt | yeah, I got too excited about it and didn't put two and two together | 19:49 |
| mriedem | well this is exciting stuff | 19:49 |
| melwitt | yeah it is | 19:50 |
| mriedem | ok here comes the placement scheduler interaction thingy | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581 | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582 | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424 | 19:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: provide more details on scheduling with placement https://review.openstack.org/491900 | 19:50 |
| *** markvoelker has quit IRC | 19:51 | |
| *** jmlowe has quit IRC | 19:54 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578 | 20:00 |
| melwitt | gdi left a commented out line | 20:00 |
| *** baoli has joined #openstack-nova | 20:01 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578 | 20:01 |
| *** baoli_ has joined #openstack-nova | 20:02 | |
| *** liverpooler has quit IRC | 20:03 | |
| *** gjayavelu has joined #openstack-nova | 20:04 | |
| *** baoli has quit IRC | 20:05 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057 | 20:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581 | 20:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582 | 20:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424 | 20:06 |
| *** jamesdenton has quit IRC | 20:07 | |
| *** jamesdenton has joined #openstack-nova | 20:10 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 20:13 |
| *** lucasxu has quit IRC | 20:17 | |
| *** mingyu has joined #openstack-nova | 20:17 | |
| *** kfarr has joined #openstack-nova | 20:18 | |
| *** mingyu has quit IRC | 20:22 | |
| *** adisky__ has quit IRC | 20:23 | |
| *** jmlowe has joined #openstack-nova | 20:28 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Document service layout for consoles with cells https://review.openstack.org/491914 | 20:32 |
| melwitt | mriedem: consoles doc ^ | 20:34 |
| mriedem | cool | 20:35 |
| *** felipemonteiro__ has quit IRC | 20:40 | |
| *** marst_ has quit IRC | 20:44 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: doc: Import configuration reference https://review.openstack.org/491853 | 20:50 |
| *** baoli_ has quit IRC | 20:50 | |
| *** krtaylor has quit IRC | 20:51 | |
| sdague | mriedem / melwitt can we get some doc reviews on https://review.openstack.org/#/c/491834/ and stack, that gets our docs landing page in a pretty reasonable state | 20:51 |
| sdague | all those extra config reference imports are going to be a bear to get sorted | 20:52 |
| sdague | I'll keep plugging on 491853 but I expect that's at least all of my tomorrow if not more to get it sorted | 20:52 |
| *** sbezverk has quit IRC | 20:53 | |
| *** cleong has quit IRC | 20:54 | |
| *** marst has joined #openstack-nova | 20:55 | |
| cdent | jaypipes: I reviewed your stack, got stuck a bit on the last one. And I went through mriedem’s release note stack. Is there other major stuff pending? | 20:58 |
| jaypipes | cdent: already responded :) | 20:58 |
| jaypipes | cdent: upi | 20:58 |
| jaypipes | guh | 20:58 |
| jaypipes | cdent: have you reviewed the func tests for local delete? | 20:58 |
| jaypipes | https://review.openstack.org/#/c/470578/4//COMMIT_MSG | 20:58 |
| jaypipes | from melwitt | 20:58 |
| mriedem | https://review.openstack.org/#/c/470578/ | 20:58 |
| mriedem | yes he did | 20:59 |
| cdent | jaypipes: yes | 20:59 |
| jaypipes | k | 20:59 |
| mriedem | jaypipes: you should send that home | 20:59 |
| cdent | jaypipes: my point on the continue is that you’ve removed a continue | 20:59 |
| cdent | but that it doesn’t matter | 20:59 |
| jaypipes | cdent: oh, gotcha... | 20:59 |
| cdent | so neither continue should really be there | 20:59 |
| cdent | or something… not sure what? | 20:59 |
| jaypipes | cdent: yeah, it's just a placeholder, sorry... rebase merge conflict mistake really | 20:59 |
| cdent | I understood the coment was pretty much a *throws hands up* | 21:00 |
| jaypipes | cdent: indeed. | 21:00 |
| cdent | fun fun | 21:00 |
| cdent | i’ll pass through everything again in the morning, and do my morning recheck rituatls | 21:01 |
| *** _pewp_ has quit IRC | 21:01 | |
| cdent | otherwise: good night all, good luck | 21:01 |
| jaypipes | k, thx cdent | 21:01 |
| *** _pewp_ has joined #openstack-nova | 21:01 | |
| *** cdent has quit IRC | 21:01 | |
| mriedem | jaypipes: what's the -1 for specifically? https://review.openstack.org/#/c/491900/ | 21:02 |
| jaypipes | melwitt: glad you liked my old-man-joke about the HamburgerHelperFixture yesterday. :) | 21:02 |
| melwitt | heh | 21:03 |
| *** baoli has joined #openstack-nova | 21:03 | |
| jaypipes | mriedem: that cell comment... | 21:04 |
| mriedem | jaypipes: i replied | 21:04 |
| mriedem | i think you misunderstood | 21:04 |
| jaypipes | mriedem: as a user doc, I don't think that's helpful. | 21:04 |
| mriedem | it's for an operator | 21:04 |
| mriedem | the compute nodes live in the cells | 21:04 |
| mriedem | not sure how that's less appropriate than talking about host UUIDs | 21:05 |
| *** gyee has quit IRC | 21:05 | |
| sdague | jaypipes: pay no attention to the directory structures on the docs, a bunch landed in probably the wrong place | 21:05 |
| sdague | https://review.openstack.org/#/c/491815/ tries to reorganize and clarify without generating any new 404s | 21:05 |
| jaypipes | mriedem: k, will update shortly. sorry, on call with kevinbenton :( | 21:05 |
| mriedem | gd kevinbenton | 21:06 |
| jaypipes | kevinbenton: welcome to that bus. | 21:06 |
| *** abalutoiu has joined #openstack-nova | 21:07 | |
| *** kfarr has quit IRC | 21:07 | |
| *** crushil has quit IRC | 21:09 | |
| *** yamamoto has joined #openstack-nova | 21:09 | |
| *** slaweq has quit IRC | 21:18 | |
| *** vladikr has quit IRC | 21:19 | |
| *** yamamoto has quit IRC | 21:21 | |
| *** sbezverk has joined #openstack-nova | 21:22 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:22 |
| *** awaugama has joined #openstack-nova | 21:27 | |
| *** annegentle has joined #openstack-nova | 21:32 | |
| *** felipemonteiro_ has joined #openstack-nova | 21:33 | |
| *** felipemonteiro__ has joined #openstack-nova | 21:35 | |
| *** markvoelker has joined #openstack-nova | 21:37 | |
| *** thorst has quit IRC | 21:37 | |
| *** edmondsw has quit IRC | 21:38 | |
| kevinbenton | mriedem: sorry about that. jaypipes just wanted to have a sync-up call to tell me how terrible Nova is being managed by the PTL | 21:38 |
| *** felipemonteiro_ has quit IRC | 21:38 | |
| dansmith | ouch | 21:40 |
| clarkb | kevinbenton: did you tell him its not too late to run for ptl? | 21:43 |
| *** kfarr has joined #openstack-nova | 21:43 | |
| kevinbenton | clarkb: :) | 21:43 |
| *** yangyapeng has joined #openstack-nova | 21:43 | |
| mikal | All right you lot, stop talking and release pike so I can go and break libvirt in queens. | 21:43 |
| mikal | Less talky, more shippy. | 21:43 |
| kevinbenton | something about no point in changing the captain of the titanic now :) | 21:43 |
| clarkb | mikal: red hat already broke libvirt do we have to break it again? | 21:44 |
| mikal | clarkb: if we break it enought it might just loop around to working again | 21:44 |
| *** markvoelker has quit IRC | 21:44 | |
| clarkb | (if you haven't heard rhel 7.4 has libvirt 3.2 which is not compatible with our stable branch libvirt-python constraint) | 21:44 |
| mikal | In other news, whoever wrote code that said "sudo rm -rf <<path>>" needs to be kicked in the shins | 21:45 |
| *** gjayavelu has quit IRC | 21:47 | |
| *** yangyapeng has quit IRC | 21:48 | |
| cfriesen | mikal: only in the shins? | 21:56 |
| melwitt | I think he's just giving everyone a chance to get kicked | 21:58 |
| *** yamamoto has joined #openstack-nova | 21:59 | |
| *** priteau has quit IRC | 22:02 | |
| *** smatzek has quit IRC | 22:03 | |
| *** esberglu has quit IRC | 22:03 | |
| *** markvoelker has joined #openstack-nova | 22:04 | |
| *** esberglu has joined #openstack-nova | 22:04 | |
| *** markvoelker_ has joined #openstack-nova | 22:05 | |
| *** gjayavelu has joined #openstack-nova | 22:05 | |
| mikal | Heh | 22:06 |
| mikal | We have so much crap code around rootwrap. Its embarrassing. | 22:07 |
| *** esberglu has quit IRC | 22:08 | |
| *** markvoelker has quit IRC | 22:09 | |
| *** mtanino has joined #openstack-nova | 22:10 | |
| *** gjayavelu has quit IRC | 22:13 | |
| *** esberglu has joined #openstack-nova | 22:16 | |
| *** slaweq has joined #openstack-nova | 22:19 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578 | 22:21 |
| *** slaweq has quit IRC | 22:24 | |
| *** felipemonteiro__ has quit IRC | 22:31 | |
| *** xyang1 has quit IRC | 22:34 | |
| *** markvoelker has joined #openstack-nova | 22:36 | |
| *** markvoel_ has joined #openstack-nova | 22:37 | |
| *** thorst has joined #openstack-nova | 22:38 | |
| *** mtanino has quit IRC | 22:39 | |
| *** gyee has joined #openstack-nova | 22:40 | |
| *** markvoelker_ has quit IRC | 22:40 | |
| *** markvoelker has quit IRC | 22:41 | |
| *** jaypipes has quit IRC | 22:42 | |
| *** kfarr has quit IRC | 22:43 | |
| *** thorst has quit IRC | 22:43 | |
| *** yangyapeng has joined #openstack-nova | 22:44 | |
| *** yangyapeng has quit IRC | 22:48 | |
| *** krtaylor has joined #openstack-nova | 22:51 | |
| openstackgerrit | Merged openstack/nova master: Fix the log information argument mistake https://review.openstack.org/478792 | 22:54 |
| openstackgerrit | Merged openstack/nova master: Create For End Users index section https://review.openstack.org/491785 | 23:00 |
| *** markvoelker has joined #openstack-nova | 23:01 | |
| *** markvoel_ has quit IRC | 23:03 | |
| *** marst has quit IRC | 23:06 | |
| *** markvoelker has quit IRC | 23:18 | |
| *** markvoelker has joined #openstack-nova | 23:18 | |
| *** sdague has quit IRC | 23:22 | |
| *** markvoelker has quit IRC | 23:23 | |
| *** Swami has quit IRC | 23:25 | |
| *** catintheroof has quit IRC | 23:29 | |
| *** hongbin has quit IRC | 23:31 | |
| *** abalutoiu has quit IRC | 23:38 | |
| *** kazsh has joined #openstack-nova | 23:39 | |
| *** vladikr has joined #openstack-nova | 23:40 | |
| *** suzhengwei has joined #openstack-nova | 23:42 | |
| *** lyan has quit IRC | 23:43 | |
| *** yangyapeng has joined #openstack-nova | 23:45 | |
| *** suzhengwei_ has quit IRC | 23:45 | |
| *** jangutter has quit IRC | 23:47 | |
| *** abalutoiu has joined #openstack-nova | 23:48 | |
| *** yangyapeng has quit IRC | 23:50 | |
| *** dtp has quit IRC | 23:57 | |
| *** slagle has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!