| *** yamamoto has quit IRC | 00:01 | |
| *** smatzek has quit IRC | 00:04 | |
| jaypipes | dansmith: the reason it's failing is because you're forgetting to run that _run_perioidics() after calling delete on the server. | 00:04 |
|---|---|---|
| jaypipes | dansmith: on the revert one. | 00:05 |
| *** yamamoto has joined #openstack-nova | 00:05 | |
| dansmith | jaypipes: the reason what is failing? | 00:05 |
| dansmith | tests pass locally for me, and delete should clean up all the allocations without a periodic run, no? | 00:06 |
| jaypipes | nope. | 00:06 |
| dansmith | um why? | 00:06 |
| jaypipes | dansmith: delete doesn't clean up placement at all. | 00:06 |
| dansmith | delete doesn't call self.update() or whatever in compute manager? | 00:06 |
| jaypipes | update is only inventory. | 00:06 |
| dansmith | that would mean you can't boot instances on a compute node until after the periodic runs to clean up | 00:06 |
| jaypipes | dansmith: welcome to my hell. | 00:07 |
| dansmith | no, I'm serious | 00:08 |
| dansmith | that makes zero sense to me.. surely we'd have people beating down our door if deleting an instance didn't free up space for another one | 00:08 |
| dansmith | jaypipes: but again, the tests pass for me, so what are you saying is failing? | 00:08 |
| jaypipes | dansmith: nm, I'm wrong. | 00:09 |
| jaypipes | I think... | 00:09 |
| dansmith | self._update_resource_tracker() is in _complete_deletion() | 00:09 |
| dansmith | surely that updates things | 00:09 |
| dansmith | yeah, calls update_usage() | 00:09 |
| jaypipes | only if the uuid is in self.tracked_instances. | 00:09 |
| dansmith | which it will be if it was just running | 00:10 |
| *** xyang1 has quit IRC | 00:11 | |
| *** acormier has joined #openstack-nova | 00:11 | |
| *** chyka has quit IRC | 00:13 | |
| *** acormier has quit IRC | 00:15 | |
| *** dtp has quit IRC | 00:15 | |
| *** gmann has quit IRC | 00:16 | |
| *** gmann has joined #openstack-nova | 00:16 | |
| *** vishwana_ has joined #openstack-nova | 00:18 | |
| *** edmondsw has joined #openstack-nova | 00:21 | |
| *** vishwanathj has quit IRC | 00:22 | |
| *** edmondsw has quit IRC | 00:25 | |
| *** acormier has joined #openstack-nova | 00:26 | |
| *** mdnadeem has joined #openstack-nova | 00:28 | |
| *** rdo_ has joined #openstack-nova | 00:28 | |
| *** rdo has quit IRC | 00:28 | |
| *** mtanino_ has quit IRC | 00:30 | |
| *** mriedem has quit IRC | 00:30 | |
| *** kiennt has joined #openstack-nova | 00:32 | |
| *** armax has quit IRC | 00:34 | |
| *** slaweq has joined #openstack-nova | 00:36 | |
| *** mdnadeem has quit IRC | 00:37 | |
| *** mriedem has joined #openstack-nova | 00:38 | |
| *** harlowja has quit IRC | 00:38 | |
| mriedem | dansmith: jaypipes: did you guys sort out the delete allocations on delete thing? b/c i'm pretty sure melwitt has a functional test up for that. | 00:41 |
| jaypipes | mriedem: yeah, I was wrong. | 00:41 |
| mriedem | oh https://review.openstack.org/#/c/470578/ is for local delete | 00:42 |
| *** slaweq has quit IRC | 00:42 | |
| *** zhurong has joined #openstack-nova | 00:42 | |
| mriedem | alright well someone just ping me when the pep8 thing is fixed and i'll +2 | 00:43 |
| jaypipes | mriedem: I'm working on it. | 00:45 |
| *** thorst_afk has joined #openstack-nova | 00:46 | |
| *** kiennt has quit IRC | 00:47 | |
| *** mdnadeem has joined #openstack-nova | 00:47 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438 | 00:48 |
| *** haukebruno has joined #openstack-nova | 00:50 | |
| *** Shunli has joined #openstack-nova | 00:51 | |
| *** kiennt has joined #openstack-nova | 00:51 | |
| mikal | melwitt / sdague: the +W fell off https://review.openstack.org/#/c/486831 if you're feeling charitable | 00:53 |
| *** rajathagasthya has quit IRC | 00:53 | |
| mikal | It would make tonyb's day | 00:53 |
| tonyb | it would at that | 00:53 |
| *** thorst_afk has quit IRC | 00:54 | |
| mriedem | there was no +W on that | 00:54 |
| *** _pewp_ has quit IRC | 00:54 | |
| mriedem | nice try aussies | 00:55 |
| jaypipes | dansmith: why are we setting the availability zone on the build request in these tests? | 00:55 |
| mriedem | jaypipes: to force the host | 00:55 |
| mriedem | at boot time | 00:55 |
| jaypipes | ugh | 00:55 |
| mriedem | it uses the forced_host thing in the api | 00:55 |
| mriedem | yeah | 00:55 |
| mikal | mriedem: curse you meddling kids | 00:55 |
| mriedem | but it makes the order deterministic | 00:55 |
| mriedem | jaypipes: plus we lost all the docs on that forced_host thing with the docs migration i think | 00:56 |
| *** jichen has joined #openstack-nova | 00:56 | |
| *** _pewp_ has joined #openstack-nova | 00:57 | |
| tonyb | ZOMG I was lied to! | 00:58 |
| mriedem | https://github.com/openstack/openstack-manuals/commit/c21f7bb13ccec63ecf96f5d9d0a9d30f1057e4d5#diff-320133d1ccbd2ba417cd580760c18606 | 00:58 |
| mriedem | stephenfin: ^ do we have plans to import that into the nova docs? | 00:59 |
| mriedem | because this forced_host thing isn't in the compute API reference | 00:59 |
| jaypipes | really wish we used the names source and destination instead of "host" and "other" | 01:00 |
| mikal | jaypipes: that's defeatist | 01:01 |
| mikal | jaypipes: next you'll be complaining that we convey "hairpin enable failed" with a ProcessException | 01:01 |
| jaypipes | heh | 01:01 |
| mriedem | jaypipes: agree on the naming there, we could rename / refactor later too | 01:02 |
| mriedem | plus there is a lot of redundant code in there before we get to the confirm/revert action which could be put into a private common method | 01:02 |
| jaypipes | mriedem: honestly, I just don't understand why there's a need for the whole "do this test in the opposite order" thing. | 01:02 |
| dansmith | jaypipes: because you fail it differently in each case | 01:04 |
| dansmith | jaypipes: keep it on master and disable the skips and you'll see | 01:05 |
| jaypipes | dansmith: but if the whole "availability_zone": "nova:" + initial thing is so deterministic, why the need? | 01:05 |
| dansmith | because going from one compute node to the other, and running their periodics in that order end up with an updated allocation | 01:05 |
| dansmith | in the reverse order, one of them deletes it last | 01:05 |
| dansmith | i.e. one updates, then the other deletes | 01:06 |
| dansmith | vs one deletes then the other updates (creates) | 01:06 |
| jaypipes | with all the stuff we discussed today about ocata computes, there's going to need to be so many friggin conditionals in these code paths that we're introducing more risk than anything else :( | 01:06 |
| dansmith | you mean in order to pass the tests? | 01:07 |
| dansmith | that's exactly why we must have it tested both ways | 01:07 |
| dansmith | ocata to pike _has_ to work, and pike to pike _has_ to work, with no leaks | 01:07 |
| jaypipes | well these tests don't test ocata to pike, only pike to pike | 01:07 |
| dansmith | pike to ocata I can kind of get on board with allowing to be leaky, but it's still not awesome | 01:07 |
| dansmith | jaypipes: exactly, we must have _at least_ this much coverage, | 01:07 |
| dansmith | and we really need one that simulates the pike/ocata split | 01:07 |
| dansmith | we have the grenade multinode case, which helps, but it's not deterministic | 01:08 |
| dansmith | and I think we've shown thus far, that if we don't lay down a test-driven approach to what we expect, | 01:08 |
| *** sdague has quit IRC | 01:08 | |
| jaypipes | I'm in a fix one thing, break ten others place right now :( | 01:08 |
| dansmith | we're going to keep bouncing around between partial solutions | 01:08 |
| *** iceyao has joined #openstack-nova | 01:09 | |
| dansmith | jaypipes: I'm not sure what the alternative is.. if I can write a test that shows that the code is broken if we end up running things in a particular sequence, that's a problem right? | 01:10 |
| mriedem | we can possibly build on this to make one of the computes' service version be ocata | 01:11 |
| mriedem | to test that code path in the change that checks the min service version | 01:11 |
| jaypipes | dansmith: I'm not disagreeing with you that shit is broken. I just don't know how to fix this without breaking the happy path | 01:11 |
| dansmith | mriedem: we have to simulate the ocata way of managing allocations too | 01:11 |
| mriedem | plus we can do the single node resize to same host testing building on this | 01:11 |
| dansmith | mriedem: i.e. the "always blow away everything without looking first" way | 01:12 |
| mriedem | happy path is all computes are pike isn't it? | 01:12 |
| dansmith | yes | 01:12 |
| mriedem | which this tests | 01:12 |
| dansmith | right | 01:12 |
| jaypipes | no. happy path is non-move operations. | 01:12 |
| dansmith | hah | 01:12 |
| dansmith | that's the beer path | 01:12 |
| mriedem | so, | 01:13 |
| mriedem | what about bfv with shared storage resize to another az? | 01:13 |
| mriedem | will THAT work?! | 01:13 |
| jaypipes | not funny | 01:13 |
| mriedem | uh mixed compute too | 01:13 |
| mriedem | fine fine fine | 01:14 |
| mriedem | s/resize/evacuate/ | 01:14 |
| mriedem | happy? | 01:14 |
| mriedem | so i think the tests as written are a same-version compute good representation of what we expect for confirm and revert, and before dan moved them from the top of the series of fixes, they were passing | 01:15 |
| mriedem | so i think we get that baseline going, and then starting adding in test wrinkles | 01:15 |
| mriedem | i think this is all easier once we have the tests written | 01:16 |
| dansmith | mriedem: meaning they worked on top of the series, which means the series can work atop the tests, right? | 01:16 |
| mriedem | yeah | 01:16 |
| dansmith | that was my reason for doing that before rebasing, to make sure they could work with jay's set | 01:16 |
| mriedem | just like how we do the functional regression bug testaroos | 01:16 |
| dansmith | agreed, we *have* to get this baseline working, and then we can expand the base a bit | 01:17 |
| dansmith | for things like single compute at least | 01:17 |
| *** randomhack has joined #openstack-nova | 01:17 | |
| jaypipes | I don't disagree with you. | 01:17 |
| jaypipes | just raging that's all. | 01:17 |
| jaypipes | I'll figure it out eventually. | 01:17 |
| mriedem | i'll go back to commenting up dan's cells docs patch :) | 01:18 |
| * dansmith puts on his muck boots | 01:19 | |
| *** randomhack has quit IRC | 01:21 | |
| *** yamamoto has quit IRC | 01:25 | |
| jaypipes | dansmith: still here? | 01:27 |
| dansmith | jaypipes: yeah | 01:27 |
| jaypipes | dansmith: so this: | 01:27 |
| jaypipes | 1136 compute_version = objects.Service.get_minimum_version( | 01:27 |
| jaypipes | 1137 context, 'nova-compute') | 01:27 |
| jaypipes | 1138 heal_allocations = False | 01:27 |
| jaypipes | 1139 if compute_version < 22: | 01:27 |
| jaypipes | 1140 heal_allocations = True | 01:27 |
| jaypipes | is not working | 01:27 |
| jaypipes | or at least, it's returning heal_allocations = True in the functional tests | 01:28 |
| dansmith | jaypipes: are you using the allservicescurrent fixture? | 01:28 |
| jaypipes | which is triggering the healing of allocations improperly. | 01:28 |
| dansmith | otherwise you probably have a min ver of zero | 01:28 |
| jaypipes | dansmith: sigh | 01:28 |
| dansmith | jaypipes: mriedem pointed that out earlier | 01:28 |
| jaypipes | you even told me about that earlier. | 01:28 |
| jaypipes | yeah.. :( | 01:28 |
| dansmith | yeah, sorry | 01:28 |
| *** thorst_afk has joined #openstack-nova | 01:29 | |
| *** yamamoto has joined #openstack-nova | 01:29 | |
| *** gcb has joined #openstack-nova | 01:30 | |
| *** litao__ has joined #openstack-nova | 01:33 | |
| *** gcb has quit IRC | 01:37 | |
| *** thorst_afk has quit IRC | 01:38 | |
| *** thorst_afk has joined #openstack-nova | 01:38 | |
| *** gcb has joined #openstack-nova | 01:39 | |
| mriedem | dansmith: ok comments in https://review.openstack.org/#/c/487183/ for the cells docs - looks real purdy | 01:39 |
| mriedem | you can tell me you'll look in the morning and i won't be hurt | 01:40 |
| *** xinliang has joined #openstack-nova | 01:40 | |
| *** xinliang has quit IRC | 01:40 | |
| *** xinliang has joined #openstack-nova | 01:40 | |
| dansmith | mriedem: I'll look in the morning | 01:40 |
| * mriedem is broken hearted | 01:41 | |
| dansmith | but.. you said... | 01:41 |
| *** https_GK1wmSU has joined #openstack-nova | 01:42 | |
| *** thorst_afk has quit IRC | 01:43 | |
| *** https_GK1wmSU has left #openstack-nova | 01:44 | |
| jaypipes | dansmith: other_provider_uuid is the source host right? | 01:46 |
| dansmith | jaypipes: it depends on which direction you're going | 01:46 |
| dansmith | jaypipes: actually, it should always be target the way it's written I think | 01:47 |
| dansmith | provider_uuid is instance[host] and other is the target right/ | 01:47 |
| jaypipes | dansmith: ? if "host" is always the one you were originally scheduled to, then other is the one you're going *to*, right? | 01:47 |
| jaypipes | yeah, ok | 01:47 |
| jaypipes | dansmith: the only thing the "other direction" refers to isn't the direction but rather the order in which the hosts' update_available_resource() is called. | 01:48 |
| jaypipes | I think? | 01:48 |
| dansmith | no | 01:48 |
| dansmith | we always call host1 first and host2 second | 01:48 |
| *** Apoorva has quit IRC | 01:48 | |
| dansmith | for the periodic | 01:49 |
| mriedem | other_provider_uuid is the target | 01:50 |
| dansmith | right | 01:50 |
| dansmith | the destination host | 01:51 |
| mriedem | we could rename to target or dest or whatever | 01:51 |
| dansmith | yep | 01:51 |
| *** yamamoto has quit IRC | 01:51 | |
| *** tuanluong has joined #openstack-nova | 01:51 | |
| jaypipes | I gotta look at this in the morning. I'm fried right now :( | 01:51 |
| dansmith | jaypipes: you want me to convert it to source/dest so it's like that for you in the morning? | 01:52 |
| jaypipes | dansmith: no. | 01:52 |
| jaypipes | dansmith: I'll do it in the morning. will probably need to start from scratch with this last patch :( | 01:52 |
| *** armax has joined #openstack-nova | 01:52 | |
| dansmith | okay | 01:52 |
| jaypipes | too many friggin conditionals to keep in my head. | 01:52 |
| jaypipes | are we in the update loop? are we on an ocata? are we removing? are we migrating to same host? | 01:53 |
| jaypipes | all with the same fucking code paths. :( | 01:53 |
| dansmith | well, this is why in hindsight, I think bolting this onto the RT was a bad move | 01:53 |
| dansmith | too much baggage | 01:53 |
| dansmith | jaypipes: anyway, go get your pug cuddles | 01:54 |
| *** itlinux has joined #openstack-nova | 01:55 | |
| *** thorst_afk has joined #openstack-nova | 01:55 | |
| *** thorst_afk has quit IRC | 01:55 | |
| *** yamamoto has joined #openstack-nova | 01:56 | |
| *** tbachman has quit IRC | 01:58 | |
| *** slaweq has joined #openstack-nova | 01:59 | |
| jaypipes | dansmith: I would have been happy to write all of this outside of the resource tracker, but you know... upgrades. | 02:00 |
| openstackgerrit | Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | 02:00 |
| *** itlinux has quit IRC | 02:01 | |
| *** owalsh_ has joined #openstack-nova | 02:04 | |
| *** slaweq has quit IRC | 02:04 | |
| *** yamamoto has quit IRC | 02:07 | |
| *** owalsh has quit IRC | 02:08 | |
| *** yamahata has quit IRC | 02:08 | |
| *** slaweq has joined #openstack-nova | 02:09 | |
| *** mriedem has quit IRC | 02:10 | |
| *** thorst_afk has joined #openstack-nova | 02:11 | |
| *** bkopilov_ has quit IRC | 02:11 | |
| *** slaweq has quit IRC | 02:15 | |
| *** rajathagasthya has joined #openstack-nova | 02:17 | |
| *** acormier has quit IRC | 02:19 | |
| *** acormier has joined #openstack-nova | 02:19 | |
| *** yamamoto has joined #openstack-nova | 02:19 | |
| *** hongbin has joined #openstack-nova | 02:21 | |
| *** harlowja has joined #openstack-nova | 02:22 | |
| *** acormier has quit IRC | 02:24 | |
| *** thorst_afk has quit IRC | 02:25 | |
| *** itlinux has joined #openstack-nova | 02:27 | |
| *** rajathagasthya has quit IRC | 02:34 | |
| *** saphi has joined #openstack-nova | 02:37 | |
| *** esberglu has joined #openstack-nova | 02:39 | |
| *** kiennt has quit IRC | 02:41 | |
| *** kiennt has joined #openstack-nova | 02:42 | |
| *** harlowja has quit IRC | 02:44 | |
| *** esberglu has quit IRC | 02:44 | |
| *** esberglu has joined #openstack-nova | 02:49 | |
| *** baoli_ has quit IRC | 02:50 | |
| *** hongbin_ has joined #openstack-nova | 02:55 | |
| *** hongbin has quit IRC | 02:57 | |
| *** hongbin has joined #openstack-nova | 02:59 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Live migration failed in xapi pool https://review.openstack.org/489451 | 03:00 |
| *** hongbin_ has quit IRC | 03:00 | |
| *** itlinux has quit IRC | 03:01 | |
| *** yamamoto has quit IRC | 03:01 | |
| *** yamamoto has joined #openstack-nova | 03:06 | |
| *** lbragstad_ has joined #openstack-nova | 03:14 | |
| *** lbragstad has quit IRC | 03:14 | |
| *** yamamoto has quit IRC | 03:21 | |
| *** sree_ has joined #openstack-nova | 03:23 | |
| *** sree_ is now known as Guest35159 | 03:23 | |
| *** yamamoto has joined #openstack-nova | 03:24 | |
| *** gouthamr has quit IRC | 03:28 | |
| *** bkopilov_ has joined #openstack-nova | 03:29 | |
| *** yamamoto has quit IRC | 03:36 | |
| *** marst has joined #openstack-nova | 03:36 | |
| *** slaweq has joined #openstack-nova | 03:37 | |
| *** harlowja has joined #openstack-nova | 03:38 | |
| *** slaweq has quit IRC | 03:42 | |
| *** udesale has joined #openstack-nova | 03:43 | |
| *** yamamoto has joined #openstack-nova | 03:44 | |
| *** nicolasbock has joined #openstack-nova | 03:45 | |
| *** dave-mcc_ has quit IRC | 03:48 | |
| *** mamandle has joined #openstack-nova | 03:50 | |
| *** iceyao has quit IRC | 03:56 | |
| *** ijw has quit IRC | 03:57 | |
| *** mvensky has quit IRC | 03:58 | |
| *** kbaegis has quit IRC | 03:59 | |
| *** mvensky has joined #openstack-nova | 04:04 | |
| *** mtanino has quit IRC | 04:04 | |
| *** yamamoto has quit IRC | 04:04 | |
| *** hongbin has quit IRC | 04:05 | |
| *** links has joined #openstack-nova | 04:07 | |
| *** yamamoto has joined #openstack-nova | 04:09 | |
| *** hshiina has joined #openstack-nova | 04:09 | |
| *** takashin has joined #openstack-nova | 04:09 | |
| *** psachin has joined #openstack-nova | 04:10 | |
| *** iceyao has joined #openstack-nova | 04:21 | |
| *** takashin_ has joined #openstack-nova | 04:21 | |
| *** takashin has quit IRC | 04:23 | |
| *** iceyao has quit IRC | 04:26 | |
| *** thorst_afk has joined #openstack-nova | 04:26 | |
| *** ijw has joined #openstack-nova | 04:27 | |
| *** thorst_afk has quit IRC | 04:31 | |
| *** ijw has quit IRC | 04:31 | |
| *** udesale__ has joined #openstack-nova | 04:32 | |
| *** adisky__ has joined #openstack-nova | 04:33 | |
| *** udesale has quit IRC | 04:34 | |
| *** iceyao has joined #openstack-nova | 04:39 | |
| *** jhesketh__ has joined #openstack-nova | 04:44 | |
| *** iceyao has quit IRC | 04:44 | |
| *** jhesketh__ has quit IRC | 04:44 | |
| *** jhesketh_ has joined #openstack-nova | 04:44 | |
| *** jhesketh_ has quit IRC | 04:45 | |
| *** iceyao has joined #openstack-nova | 04:45 | |
| *** mamandle_ has joined #openstack-nova | 04:49 | |
| *** mamandle has quit IRC | 04:49 | |
| *** mamandle_ is now known as mamandle | 04:49 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix test_get_volume_config method https://review.openstack.org/489467 | 04:53 |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** chyka has joined #openstack-nova | 04:58 | |
| *** slaweq has joined #openstack-nova | 04:59 | |
| *** chyka has quit IRC | 05:02 | |
| *** slaweq has quit IRC | 05:04 | |
| *** itlinux has joined #openstack-nova | 05:05 | |
| *** prateek has joined #openstack-nova | 05:06 | |
| *** iceyao has quit IRC | 05:08 | |
| *** harlowja has quit IRC | 05:10 | |
| *** Alex_____ has quit IRC | 05:12 | |
| *** vvargaszte has quit IRC | 05:13 | |
| *** gabor_antal has quit IRC | 05:13 | |
| *** hferenc has quit IRC | 05:14 | |
| *** mamandle has quit IRC | 05:17 | |
| *** https___GK1wmSU has joined #openstack-nova | 05:17 | |
| *** https__GK1wmSU has joined #openstack-nova | 05:17 | |
| *** randomhack has joined #openstack-nova | 05:17 | |
| *** https___GK1wmSU has left #openstack-nova | 05:20 | |
| *** https__GK1wmSU has left #openstack-nova | 05:20 | |
| *** ekuris has joined #openstack-nova | 05:21 | |
| *** randomhack has quit IRC | 05:22 | |
| *** moshele has joined #openstack-nova | 05:26 | |
| *** hoonetorg has quit IRC | 05:27 | |
| *** tetsuro has joined #openstack-nova | 05:28 | |
| *** gcb has quit IRC | 05:29 | |
| *** gcb_ has joined #openstack-nova | 05:29 | |
| *** moshele has quit IRC | 05:29 | |
| *** chyka has joined #openstack-nova | 05:29 | |
| *** lpetrut has joined #openstack-nova | 05:32 | |
| *** chyka has quit IRC | 05:34 | |
| *** moshele has joined #openstack-nova | 05:34 | |
| *** sridharg has joined #openstack-nova | 05:35 | |
| *** itlinux has quit IRC | 05:35 | |
| *** iceyao has joined #openstack-nova | 05:35 | |
| *** hferenc has joined #openstack-nova | 05:36 | |
| *** iceyao has quit IRC | 05:40 | |
| *** hferenc has quit IRC | 05:41 | |
| *** hferenc has joined #openstack-nova | 05:42 | |
| *** hoonetorg has joined #openstack-nova | 05:44 | |
| *** vladikr has quit IRC | 05:48 | |
| *** harlowja has joined #openstack-nova | 05:51 | |
| *** kiennt has quit IRC | 05:57 | |
| *** moshele has quit IRC | 05:58 | |
| *** moshele has joined #openstack-nova | 06:01 | |
| *** yamahata has joined #openstack-nova | 06:01 | |
| *** kiennt has joined #openstack-nova | 06:01 | |
| *** iceyao has joined #openstack-nova | 06:03 | |
| openstackgerrit | Zhaokun Fu proposed openstack/nova master: Smaller disk flavor check https://review.openstack.org/489484 | 06:04 |
| *** jaosorior has quit IRC | 06:05 | |
| *** esberglu has quit IRC | 06:06 | |
| *** esberglu has joined #openstack-nova | 06:06 | |
| *** iceyao has quit IRC | 06:08 | |
| *** trinaths has joined #openstack-nova | 06:09 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move execs of touch to privsep. https://review.openstack.org/489190 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 06:10 |
| openstackgerrit | Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | 06:10 |
| *** iceyao has joined #openstack-nova | 06:12 | |
| *** slaweq has joined #openstack-nova | 06:13 | |
| *** amuresan has joined #openstack-nova | 06:13 | |
| openstackgerrit | Zhaokun Fu proposed openstack/nova master: Smaller disk flavor check https://review.openstack.org/489484 | 06:14 |
| *** esberglu has quit IRC | 06:15 | |
| *** mvensky has quit IRC | 06:15 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move common definition into common.py https://review.openstack.org/489491 | 06:17 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP:check query param for service's index function https://review.openstack.org/489492 | 06:17 |
| *** yushb has joined #openstack-nova | 06:18 | |
| *** jaosorior has joined #openstack-nova | 06:24 | |
| *** thorst_afk has joined #openstack-nova | 06:28 | |
| *** thorst_afk has quit IRC | 06:32 | |
| *** mamandle has joined #openstack-nova | 06:34 | |
| *** mvensky has joined #openstack-nova | 06:35 | |
| *** lpetrut has quit IRC | 06:42 | |
| *** karthiks has joined #openstack-nova | 06:42 | |
| *** gabor_antal has joined #openstack-nova | 06:45 | |
| *** harlowja has quit IRC | 06:51 | |
| *** ralonsoh has joined #openstack-nova | 06:52 | |
| *** vvargaszte has joined #openstack-nova | 06:53 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP:check query param for service's index function https://review.openstack.org/489492 | 06:53 |
| *** sshwarts has joined #openstack-nova | 06:54 | |
| *** lpetrut has joined #openstack-nova | 06:54 | |
| *** rcernin has joined #openstack-nova | 06:55 | |
| *** alexchadin has joined #openstack-nova | 06:56 | |
| *** dtantsur|afk is now known as dtantsur | 07:01 | |
| *** cfriesen_ has quit IRC | 07:02 | |
| *** Shunli has quit IRC | 07:03 | |
| *** Shunli has joined #openstack-nova | 07:03 | |
| *** pcaruana has joined #openstack-nova | 07:06 | |
| *** markus_z has joined #openstack-nova | 07:10 | |
| * gibi_ reads back | 07:10 | |
| *** gibi_ is now known as gibi | 07:11 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: allow null to be input for key_name https://review.openstack.org/489505 | 07:13 |
| *** ygl has joined #openstack-nova | 07:15 | |
| *** vladikr has joined #openstack-nova | 07:22 | |
| bhagyashris | jaypipes: Hi, Found one bug reported on launchpad https://bugs.launchpad.net/nova/+bug/1707256 so is this will solve the issue that we have discussed yesterday. | 07:22 |
| openstack | Launchpad bug 1707256 in OpenStack Compute (nova) "Scheduler report client does not account for shared resource providers" [High,Confirmed] - Assigned to Jay Pipes (jaypipes) | 07:22 |
| *** sshwarts has quit IRC | 07:26 | |
| *** aarefiev_afk is now known as aarefiev | 07:28 | |
| *** Oku_OS-away is now known as Oku_OS | 07:28 | |
| *** mdnadeem has quit IRC | 07:32 | |
| *** mdnadeem has joined #openstack-nova | 07:37 | |
| *** kukacz has joined #openstack-nova | 07:39 | |
| *** kukacz has quit IRC | 07:41 | |
| *** moshele has quit IRC | 07:41 | |
| *** kukacz has joined #openstack-nova | 07:41 | |
| *** slaweq_ has joined #openstack-nova | 07:41 | |
| *** lpetrut has quit IRC | 07:43 | |
| *** moshele has joined #openstack-nova | 07:43 | |
| *** tiendc has joined #openstack-nova | 07:43 | |
| *** elod has joined #openstack-nova | 07:45 | |
| *** igordcard has quit IRC | 07:47 | |
| *** slaweq_ has quit IRC | 07:47 | |
| *** dtantsur is now known as dtantsur|bbl | 07:47 | |
| *** igordcard has joined #openstack-nova | 07:48 | |
| *** rcernin has quit IRC | 07:48 | |
| *** rcernin has joined #openstack-nova | 07:50 | |
| openstackgerrit | jichenjc proposed openstack/nova master: enhance error message for input field https://review.openstack.org/489519 | 07:53 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP:enhance error message for input field https://review.openstack.org/489519 | 08:03 |
| *** vladikr has quit IRC | 08:04 | |
| *** clarkb has quit IRC | 08:04 | |
| * gibi tries to contribute some way to the resize testing, maybe renaming variables to make it more understandable | 08:09 | |
| *** vladikr has joined #openstack-nova | 08:14 | |
| *** aloga has quit IRC | 08:17 | |
| *** randomhack has joined #openstack-nova | 08:17 | |
| *** aloga has joined #openstack-nova | 08:17 | |
| *** efoley has joined #openstack-nova | 08:17 | |
| *** clarkb has joined #openstack-nova | 08:17 | |
| *** efoley has quit IRC | 08:18 | |
| *** efoley has joined #openstack-nova | 08:18 | |
| openstackgerrit | jichenjc proposed openstack/nova master: add description about key_name https://review.openstack.org/489525 | 08:18 |
| *** moshele has quit IRC | 08:19 | |
| *** rgerganov has quit IRC | 08:20 | |
| *** randomhack has quit IRC | 08:21 | |
| *** vladikr has quit IRC | 08:24 | |
| *** lucas-afk is now known as lucasagomes | 08:26 | |
| *** gmann_ has joined #openstack-nova | 08:26 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Move common definition into common.py https://review.openstack.org/489491 | 08:26 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP:check query param for service's index function https://review.openstack.org/489492 | 08:26 |
| *** thorst_afk has joined #openstack-nova | 08:27 | |
| *** zenoway has joined #openstack-nova | 08:30 | |
| *** markvoelker has quit IRC | 08:30 | |
| *** markvoelker has joined #openstack-nova | 08:31 | |
| *** ygl has quit IRC | 08:31 | |
| *** vladikr has joined #openstack-nova | 08:31 | |
| *** thorst_afk has quit IRC | 08:32 | |
| mamandle | bauzas: sfinucan: mriedem https://review.openstack.org/#/c/483911/ is awaiting another +2, can you please take a look, Thanks. | 08:32 |
| *** markvoelker has quit IRC | 08:35 | |
| bhagyashris | Hi all I am facing one issue to boot instance in multinode setup. Error ""Host 'host-name' is not mapped to any cell". because of this instance is going to error state Can any one have any idea about this to resolve. | 08:39 |
| bhagyashris | On controller + compute node the n-cond-cell1 is configure | 08:40 |
| *** moshele has joined #openstack-nova | 08:42 | |
| *** priteau has joined #openstack-nova | 08:48 | |
| *** sapcc-bot2 has joined #openstack-nova | 08:49 | |
| *** zenoway has quit IRC | 08:50 | |
| *** zenoway has joined #openstack-nova | 08:50 | |
| *** Guest35159 has quit IRC | 08:50 | |
| *** sree_ has joined #openstack-nova | 08:51 | |
| *** sree_ is now known as Guest35970 | 08:51 | |
| saphi | bhagyashris Did you discover new compute node? Run `nova-manage cell_v2 discover_hosts` on controller node | 08:53 |
| *** sapcc-bot has quit IRC | 08:53 | |
| *** alexchadin has quit IRC | 08:53 | |
| *** Guest35970 has quit IRC | 08:55 | |
| *** alexchadin has joined #openstack-nova | 08:56 | |
| *** zenoway has quit IRC | 08:58 | |
| *** zenoway has joined #openstack-nova | 08:58 | |
| *** yangyapeng has joined #openstack-nova | 09:00 | |
| *** cdent has joined #openstack-nova | 09:02 | |
| openstackgerrit | Jacek Tomasiak proposed openstack/nova master: ironic: Use internal API endpoint https://review.openstack.org/489537 | 09:03 |
| *** mdbooth[m] has left #openstack-nova | 09:09 | |
| trinaths | hi, when I installed compute node using devstack ocata, I see that nova-compute is running with nova-cpu.conf. but actually it must run with nova.conf and nova-compute.conf. is there any localrc changes I need to make for this? | 09:09 |
| *** ralonsoh has quit IRC | 09:10 | |
| *** ralonsoh has joined #openstack-nova | 09:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | 09:13 |
| *** yamahata has quit IRC | 09:17 | |
| *** moshele has quit IRC | 09:19 | |
| *** slaweq_ has joined #openstack-nova | 09:20 | |
| bhagyashris | saphi: Hi, I have done this too, but still getting same error. | 09:20 |
| *** sdague has joined #openstack-nova | 09:20 | |
| trinaths | I get this error when I run nova-compute, IncompatibleObjectVersion: Version 2.4 of InstanceList is not supported | 09:23 |
| *** slaweq_ has quit IRC | 09:24 | |
| saphi | Can you post your nova-compute.log? | 09:25 |
| saphi | bhagyashris | 09:25 |
| *** Oku_OS is now known as Oku_OS-away | 09:25 | |
| *** sambetts|afk is now known as sambetts | 09:27 | |
| openstackgerrit | Zhaokun Fu proposed openstack/nova master: Smaller disk flavor check https://review.openstack.org/489484 | 09:28 |
| openstackgerrit | Alexandru Muresan proposed openstack/nova master: Pass config object to oslo_reports https://review.openstack.org/485575 | 09:28 |
| *** moshele has joined #openstack-nova | 09:29 | |
| *** Shunli has quit IRC | 09:30 | |
| trinaths | Cannot update service status on host "compute" due to an unexpected exception | 09:30 |
| *** owalsh_ is now known as owalsh | 09:33 | |
| *** prateek has quit IRC | 09:33 | |
| *** mkucia has joined #openstack-nova | 09:34 | |
| bauzas | johnthetubaguy: not sure you're around, but I'm wondering if other drivers but libvirt and vmware can support shrinking root disks when resizing | 09:36 |
| bauzas | I tend to think so for ironic at least | 09:36 |
| bauzas | the context being https://bugs.launchpad.net/nova/+bug/1707830 | 09:37 |
| openstack | Launchpad bug 1707830 in OpenStack Compute (nova) "resize to smaller flavor failed, but has not error message on dashboard" [Medium,In progress] - Assigned to Zhaokun Fu (fuzhaokun) | 09:37 |
| *** yamamoto has quit IRC | 09:37 | |
| bauzas | I don't want to make it something verified by the API | 09:37 |
| *** Oku_OS-away is now known as Oku_OS | 09:37 | |
| *** marst_ has joined #openstack-nova | 09:38 | |
| *** marst has quit IRC | 09:38 | |
| trinaths | oslo_messaging.rpc.server IncompatibleObjectVersion: Version 2.4 of InstanceList is not supported | 09:42 |
| *** ygl has joined #openstack-nova | 09:47 | |
| *** takashin_ has left #openstack-nova | 09:48 | |
| *** esberglu has joined #openstack-nova | 09:48 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Accept any scheduler driver entrypoint https://review.openstack.org/484828 | 09:49 |
| *** lpetrut has joined #openstack-nova | 09:51 | |
| *** esberglu has quit IRC | 09:53 | |
| cdent | sdague++ on the mass abandonment | 09:54 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Destroy the ReqSpec object when deleting the instance https://review.openstack.org/391060 | 09:54 |
| sdague | cdent: yeh, the in progress list is a lot less accurate than we think | 09:55 |
| *** jichen has quit IRC | 09:55 | |
| sdague | I trimmed back the criteria, this is just stuff that's been in merge conflict for 4 weeks | 09:55 |
| *** moshele has quit IRC | 09:55 | |
| sdague | cdent: what comms channel did you notice this on? | 09:56 |
| cdent | i’m getting a lot of email for reviews that I’m watching | 09:56 |
| *** udesale__ has quit IRC | 09:56 | |
| cdent | or otherwise participating in | 09:56 |
| cdent | so: from gerrit | 09:56 |
| *** yamamoto has joined #openstack-nova | 09:57 | |
| sdague | gotcha | 09:57 |
| *** lpetrut_ has joined #openstack-nova | 09:59 | |
| *** lpetrut has quit IRC | 10:01 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | 10:02 |
| *** gmann_ has quit IRC | 10:06 | |
| *** yamamoto has quit IRC | 10:08 | |
| *** moshele has joined #openstack-nova | 10:11 | |
| *** dtantsur|bbl is now known as dtantsur | 10:11 | |
| *** kiennt has quit IRC | 10:12 | |
| *** zenoway has quit IRC | 10:13 | |
| *** zenoway has joined #openstack-nova | 10:14 | |
| *** yushb has quit IRC | 10:17 | |
| *** zenoway has quit IRC | 10:18 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 10:18 |
| *** prateek has joined #openstack-nova | 10:19 | |
| *** prateek has quit IRC | 10:20 | |
| *** prateek has joined #openstack-nova | 10:21 | |
| *** yangyapeng has quit IRC | 10:22 | |
| gibi | cdent: I will push an update to ^^ soon with some refactoring | 10:22 |
| gibi | cdent: removing duplicated code and better naming variables | 10:22 |
| cdent | gibi: are you up to date on the plan there? make it pass on current master, with expectations commented out, and then adjust it based on all the code jay’s been working. | 10:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 10:23 |
| gibi | cdent: yes, I read back | 10:23 |
| cdent | go you | 10:23 |
| gibi | cdent: what I did is that I update ps 14 on master with some refactoring | 10:24 |
| gibi | cdent: also locally I moved top of the bugfix to see that confirm works with the uncommented asserts as well | 10:24 |
| cdent | there was a hangout between dan and jay last night that went on for quite some time, I was only able to particpate for a short while. it was complicated. | 10:24 |
| bauzas | cdent: I still need to understand the consensus now | 10:24 |
| cdent | bauzas: as far as I can tell there isn’t yet a consensus on a fix | 10:24 |
| *** kristian__ has joined #openstack-nova | 10:25 | |
| bauzas | okay | 10:25 |
| bauzas | let's wait for the others | 10:25 |
| cdent | we are aware of the problem and want to make it as visible as possible, thus the functional test going in first | 10:25 |
| gibi | exactly this is why I only did refactoring that does not impact whatwhever will be the fix for the bug | 10:25 |
| *** chyka has joined #openstack-nova | 10:25 | |
| *** yamamoto has joined #openstack-nova | 10:25 | |
| cdent | bauzas: in the conversations last night, each time a potential solution was discussed another problem was revealed | 10:27 |
| bauzas | heh | 10:27 |
| *** slaweq_ has joined #openstack-nova | 10:27 | |
| cdent | one idea that was well liked was that a migration/resize would have a second allocation with a different consumer id, instead of the doubling | 10:28 |
| *** thorst_afk has joined #openstack-nova | 10:28 | |
| cdent | but that discussion exposed problems with migrations happening between ocata computes and pike computes | 10:28 |
| bauzas | shouldn't we buy https://www.amazon.com/Hasbro-40509-Whac-A-Mole-Game/dp/B0001GDP00 ? | 10:28 |
| cdent | probably yes | 10:28 |
| bauzas | I see | 10:29 |
| bauzas | about the 2nd consumer discussion | 10:29 |
| cdent | sdague: and now the launchpad emails are starting | 10:29 |
| bauzas | honestly, looks like a doubling allocation seems difficult | 10:29 |
| bauzas | when I provided my comment, I was just thinking of getting the original allocation and just passing it back in case of an exception | 10:29 |
| *** chyka has quit IRC | 10:30 | |
| bauzas | I didn't thought about all the other problems we could have :( | 10:30 |
| sdague | cdent: yeh, I'm flushing the in progress bugs, it moves at least 25 out of in progress | 10:31 |
| bauzas | sdague: I did that too | 10:31 |
| *** markvoelker has joined #openstack-nova | 10:31 | |
| cdent | bauzas: It’s good that we are talking this stuff out, because we don’t really have sufficient testing to find the bugs that we are creating (we need more gibi ) so applying brains is necessary. Each question, though annoying, is revealing something, and that’s better in the long run. | 10:32 |
| *** thorst_afk has quit IRC | 10:32 | |
| bauzas | sdague: do we have jobs for resizing to a 2nd host ? I know that for live-migration, but I do wonder if we only verify resizes for the same host | 10:33 |
| *** slaweq_ has quit IRC | 10:34 | |
| *** zenoway has joined #openstack-nova | 10:34 | |
| *** alexchadin has quit IRC | 10:35 | |
| *** sree has joined #openstack-nova | 10:35 | |
| *** alexchadin has joined #openstack-nova | 10:36 | |
| *** mdnadeem has quit IRC | 10:37 | |
| johnthetubaguy | bauzas: I think XenAPI already shrinks the disks when resizing down | 10:39 |
| bauzas | johnthetubaguy: ack | 10:40 |
| bauzas | johnthetubaguy: anyway, stopping to accept at the API level a resize down would probably need a microversion | 10:40 |
| johnthetubaguy | cdent: when we chatted about this before, I remember we kinda liked the doubling up, are folks finding thats bad? | 10:40 |
| johnthetubaguy | bauzas: I guess it should, although that's kinda removing a feature some folks use | 10:40 |
| cdent | johnthetubaguy: we need the doubling up, the problem is that it is hard to manage the cleaning up afterwards | 10:41 |
| bauzas | johnthetubaguy: exactly my point I wrote in the review | 10:41 |
| johnthetubaguy | cdent: oh, I see what you mean now | 10:41 |
| johnthetubaguy | cdent: would the migration uuid holding an allocation work, or mess things up totally for sync logic? | 10:41 |
| bauzas | johnthetubaguy: either we say nova will stop supporting that for all drivers and then it requires a microversion, or we say it's per-driver and then we don't want to have the API verifying it | 10:41 |
| johnthetubaguy | bauzas: I would rather the API new if the compute host could do it | 10:42 |
| johnthetubaguy | knew | 10:42 |
| bauzas | johnthetubaguy: yeah, agreed, a capability | 10:43 |
| cdent | johnthetubaguy: if there were a migration uuid, that would help, but there’s not, and getting access to it in the confirm_resize is weird (not sure I have all the details of this right, was very tired while listening to dan and jay last night) | 10:43 |
| *** zenoway has quit IRC | 10:43 | |
| bauzas | cdent: we have a migration object, couldn't that help ? (well, for all migrations except live-mig :D) | 10:43 |
| johnthetubaguy | cdent: oh, damm, did we never add that | 10:43 |
| *** zenoway has joined #openstack-nova | 10:43 | |
| cdent | johnthetubaguy: that’s what dan and jay said :) | 10:43 |
| cdent | (the “oh damn”) | 10:43 |
| johnthetubaguy | cdent: oh, thats correct, migration is completed before the confirm/revert phase I think | 10:43 |
| bauzas | cdent: and FWIW we expose those migration objects to the API | 10:44 |
| bauzas | s/FWIW/AFAIK | 10:44 |
| johnthetubaguy | bauzas: in my head that was getting added as part of the cancel resize/migrate work | 10:45 |
| *** trinaths has quit IRC | 10:45 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Show quota detail when inject file quota exceeds https://review.openstack.org/453040 | 10:45 |
| * johnthetubaguy shakes fist at pesky technical debt | 10:46 | |
| *** trinaths has joined #openstack-nova | 10:46 | |
| bauzas | johnthetubaguy: you mean os-migrations ? | 10:46 |
| johnthetubaguy | bauzas: I think so | 10:46 |
| * bauzas just opening the api-ref :) | 10:46 | |
| bauzas | but whatever, we haven't yet a migration object for live migrations :) | 10:46 |
| johnthetubaguy | bauzas: can't remember if the additions merged now, I thought it was shared for both now | 10:47 |
| bauzas | maybe we could just split nikola's patch in two and just at least add the migration object at first, before trying to claim | 10:47 |
| johnthetubaguy | anyways, not sure any of that helps | 10:47 |
| sdague | bauzas: we run the resize tests in multihost I think | 10:47 |
| bauzas | sdague: cool then | 10:48 |
| sdague | bauzas: but I haven't looked that hard to verify | 10:48 |
| bauzas | sdague: I can check | 10:48 |
| * johnthetubaguy runs off for some lunch | 10:48 | |
| *** ygl has quit IRC | 10:49 | |
| cdent | sdague, bauzas: we talked about that last night, and dan confirmed there are some, but the issue with them is that they don’t run in a constrained environment nor concurrent placements and don’t validate the allocations, so the fact that there isn’t yet doubling of allocations isn’t an issue because there’s spare capacity | 10:51 |
| sdague | cdent: yeh, that makes sense | 10:52 |
| *** iceyao has quit IRC | 10:52 | |
| sdague | honestly, that's one of those things where doing the in tree functional testing with a couple of fake computes is probably the best way to flush it out | 10:52 |
| cdent | sdague: that’s what gibi’s new test does | 10:52 |
| cdent | so is very good to have | 10:52 |
| sdague | cdent: does that still need review? | 10:52 |
| bauzas | cdent: dan confirmed there are some what ? | 10:53 |
| * bauzas is lost | 10:53 | |
| cdent | but I suspect that there are lots of edges that won’t get covered and in about 18 months we’ll see a lot of bugs from big deployments | 10:53 |
| cdent | bauzas: there are some resize tests | 10:53 |
| cdent | sdague: yes, it needs review, but I’m not sure how “done” it is: https://review.openstack.org/#/c/487958/ | 10:54 |
| bauzas | cdent: ah | 10:54 |
| bauzas | cdent: yeah, I know that but I do wonder if we test those multihost | 10:54 |
| cdent | yes, multihost | 10:54 |
| bauzas | ok | 10:54 |
| *** saphi has quit IRC | 10:54 | |
| *** iceyao has joined #openstack-nova | 10:55 | |
| bauzas | cdent: I see your comment now, you mean those test exist but aren't really stress-testing at limits so we can't really verify capacity issues | 10:55 |
| bauzas | tests* | 10:55 |
| bauzas | so, not a big deal for functional testing, but not for placement-specific concerns | 10:56 |
| bauzas | gotcha | 10:56 |
| gibi | cdent, sdague: I'm still intended to understand and remove the last time.sleep(1) left in the setUp() of that tests as that is ugly and might not be necessary | 10:58 |
| *** bkopilov_ has quit IRC | 10:58 | |
| *** iceyao has quit IRC | 11:00 | |
| *** prateek_ has joined #openstack-nova | 11:03 | |
| *** smatzek has joined #openstack-nova | 11:04 | |
| *** markvoelker has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/nova master: fix test_rebuild_server_exc instability https://review.openstack.org/487382 | 11:05 |
| *** prateek has quit IRC | 11:05 | |
| *** alexchadin has quit IRC | 11:08 | |
| *** slagle has quit IRC | 11:08 | |
| gibi | OK I think that sleep was only needed before the fake virt driver was updated to keep a local nodes copy and the periodic tasks was running every second | 11:08 |
| gibi | that two things together caused a race on setting the nodes of the fake virt driver | 11:09 |
| *** edmondsw has joined #openstack-nova | 11:09 | |
| sdague | gibi: yeh, I just went through with a fine toothed comb there and provided some import | 11:09 |
| sdague | input | 11:09 |
| gibi | sdague: thanks. checking... | 11:09 |
| sdague | gibi: mostly also bringing fresh eyes of not being familiar with some of this, so some code restructure for clarity that might help as well | 11:10 |
| gibi | sdague: sure, fresh eyes helps a lot | 11:11 |
| *** alexchadin has joined #openstack-nova | 11:12 | |
| openstackgerrit | Merged openstack/nova master: Fix example in _serialize_allocations_for_consumer https://review.openstack.org/487614 | 11:12 |
| *** edmondsw has quit IRC | 11:14 | |
| openstackgerrit | Merged openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | 11:16 |
| *** yamamoto has quit IRC | 11:17 | |
| *** mamandle has quit IRC | 11:17 | |
| *** acormier has joined #openstack-nova | 11:20 | |
| *** alexchadin has quit IRC | 11:22 | |
| *** yangyapeng has joined #openstack-nova | 11:23 | |
| *** acormier has quit IRC | 11:25 | |
| *** sree has quit IRC | 11:28 | |
| *** tpatzig_ has joined #openstack-nova | 11:29 | |
| *** seife_ has joined #openstack-nova | 11:29 | |
| *** carthaca_ has joined #openstack-nova | 11:29 | |
| *** mkoderer_ has joined #openstack-nova | 11:29 | |
| *** sree has joined #openstack-nova | 11:30 | |
| sdague | gibi / cdent - https://review.openstack.org/#/c/487327 | 11:30 |
| *** gszasz has joined #openstack-nova | 11:30 | |
| *** markvoelker has joined #openstack-nova | 11:30 | |
| sdague | can we fix wsgi_intercept instead? | 11:30 |
| sdague | because if we don't pass those vars, people can't build their venvs | 11:31 |
| *** seife_ has quit IRC | 11:31 | |
| *** tpatzig_ has quit IRC | 11:31 | |
| *** mkoderer_ has quit IRC | 11:31 | |
| *** carthaca_ has quit IRC | 11:31 | |
| *** yamamoto has joined #openstack-nova | 11:32 | |
| *** mamandle has joined #openstack-nova | 11:33 | |
| *** trinaths has quit IRC | 11:33 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | 11:34 |
| gibi | sdague: I have an env that is behind proxy and I can build the env there without passing the PROXY wars | 11:35 |
| gibi | sdague: But if this can be fixed in wsgi_intercept then I'm happy with that solution | 11:35 |
| openstackgerrit | Merged openstack/nova master: Instance remains in migrating state forever https://review.openstack.org/483911 | 11:36 |
| sdague | gibi: not everyone can - https://review.openstack.org/#/c/189569/ | 11:36 |
| sdague | it was added because without it people were blocked from running tests | 11:36 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | 11:37 |
| sdague | unless tox itself changed since then | 11:37 |
| jaypipes | cdent: morning. | 11:37 |
| cdent | sdague: I think tox has changed | 11:37 |
| *** esberglu has joined #openstack-nova | 11:37 | |
| cdent | it’s difficult to fix in the wsgi_intercept because of the way urllib3 manages proxy variables very early in its handling | 11:38 |
| cdent | (at least last time I checked) | 11:38 |
| cdent | jaypipes: morning | 11:38 |
| jaypipes | cdent: unfortunately, trying to fix bug #1707071 has been excruciating. Looks like I'm going to need to go back to the drawing board and rewrite my patch pretty much from scratch. | 11:38 |
| openstack | bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes) | 11:38 |
| cdent | jaypipes: oh noes! | 11:38 |
| sdague | ok, so we need to figure out when it changed, because our minimum is 2.0 | 11:38 |
| cdent | sdague: i’ll look in the changelogs | 11:38 |
| sdague | gibi: if you can confirm when tox changed, and bump the minimum at the same time, I'm +2 | 11:38 |
| gibi | cdent: thanks for taking that | 11:39 |
| gibi | sdague: good point | 11:39 |
| sdague | I just don't want to break folks | 11:39 |
| *** tetsuro has quit IRC | 11:39 | |
| cdent | jaypipes: is there a crucial bit, or is it many things combined? | 11:39 |
| *** thorst_afk has joined #openstack-nova | 11:40 | |
| *** efried has quit IRC | 11:40 | |
| cdent | sdague, gibi: 2.1.0: http://tox.readthedocs.io/en/latest/changelog.html#id12 | 11:41 |
| *** prateek_ has quit IRC | 11:41 | |
| gibi | cdent: thanks! I will update the patch with the mimimum bump soon | 11:42 |
| *** acormier has joined #openstack-nova | 11:42 | |
| *** esberglu has quit IRC | 11:42 | |
| *** pchavva has joined #openstack-nova | 11:42 | |
| jaypipes | cdent: the latter | 11:43 |
| jaypipes | cdent: and the fact that we need to deal with Ocata computes migrating to Pike computes. | 11:43 |
| cdent | jaypipes: do you have an idea/plan or still cogitating? anything I can do to help? | 11:43 |
| sdague | gibi: I can actually bump it if you like, you are working on more important patches | 11:43 |
| jaypipes | cdent: not on this bug, no. but in debugging, I did notice that the aggregate refresh rate in the resource tracker/report client was super high. I know you'd submitted a bug on that (or related) some time ago. might be nice to look at reducing the number of those calls. | 11:44 |
| openstackgerrit | Sean Dague proposed openstack/nova master: do not pass proxy env variables by tox https://review.openstack.org/487327 | 11:44 |
| sdague | gibi: fixed + approved | 11:45 |
| openstackgerrit | Merged openstack/python-novaclient master: Remove run_tests.sh https://review.openstack.org/488276 | 11:46 |
| cdent | jaypipes: it’s on the cycle of the periodic job isn’t it? Or is it happening even more than that? | 11:46 |
| jaypipes | cdent: it happens every time reportclient._ensure_resource_provider() runs | 11:47 |
| jaypipes | cdent: so.. a lot. | 11:47 |
| gibi | sdague: thanks a lot! | 11:47 |
| cdent | jaypipes: ah, okay, yeah. these days we do that even more. will poke. | 11:47 |
| *** yamamoto has quit IRC | 11:49 | |
| openstackgerrit | Merged openstack/python-novaclient master: Update URLs in docs, comments and setup.cfg https://review.openstack.org/488271 | 11:51 |
| *** litao__ has quit IRC | 11:51 | |
| *** lucasagomes is now known as lucas-hungry | 11:52 | |
| *** efried has joined #openstack-nova | 11:52 | |
| *** slagle has joined #openstack-nova | 11:53 | |
| *** hoonetorg has quit IRC | 11:54 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438 | 12:00 |
| openstackgerrit | Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | 12:00 |
| *** _pewp_ has quit IRC | 12:02 | |
| *** kukacz has quit IRC | 12:02 | |
| *** kukacz has joined #openstack-nova | 12:03 | |
| *** _pewp_ has joined #openstack-nova | 12:05 | |
| *** claudiub has joined #openstack-nova | 12:06 | |
| *** hoonetorg has joined #openstack-nova | 12:06 | |
| *** tuanluong has quit IRC | 12:08 | |
| *** chyka has joined #openstack-nova | 12:11 | |
| *** acormier has quit IRC | 12:13 | |
| *** acormier has joined #openstack-nova | 12:14 | |
| *** chyka has quit IRC | 12:15 | |
| *** slagle has quit IRC | 12:17 | |
| *** acormier has quit IRC | 12:18 | |
| *** catintheroof has joined #openstack-nova | 12:20 | |
| *** thorst_afk has quit IRC | 12:22 | |
| *** udesale has joined #openstack-nova | 12:23 | |
| *** esberglu has joined #openstack-nova | 12:24 | |
| *** slagle has joined #openstack-nova | 12:25 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 12:26 |
| gibi | sdague: I've fixed your comments in https://review.openstack.org/487958 | 12:27 |
| *** mriedem has joined #openstack-nova | 12:27 | |
| *** lyan has joined #openstack-nova | 12:27 | |
| *** moshele has quit IRC | 12:29 | |
| *** mamandle has quit IRC | 12:29 | |
| *** slaweq_ has joined #openstack-nova | 12:31 | |
| *** liuyulong has joined #openstack-nova | 12:31 | |
| *** lyan_ has joined #openstack-nova | 12:31 | |
| *** cdent has quit IRC | 12:32 | |
| mriedem | gibi: want to skip the notification meeting today? | 12:32 |
| gibi | mriedem: I can chair it but I don't see any pressing issue to discuss | 12:33 |
| gibi | mriedem: therefore I suggested to skip | 12:33 |
| mriedem | seconded | 12:34 |
| gibi | mriedem: Should I send a second mail to the ML about the skip? | 12:34 |
| *** lyan has quit IRC | 12:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 12:34 |
| mriedem | gibi: up to you | 12:35 |
| gibi | mriedem: then I won't. I don't think anybody besides you and me could be interested | 12:35 |
| *** rmart04 has joined #openstack-nova | 12:36 | |
| *** slaweq_ has quit IRC | 12:36 | |
| *** edmondsw has joined #openstack-nova | 12:38 | |
| *** baoli has joined #openstack-nova | 12:39 | |
| *** esberglu has quit IRC | 12:39 | |
| *** links has quit IRC | 12:40 | |
| jaypipes | gibi: gah. I was just in the process of reworking that resize tests... | 12:42 |
| *** moshele has joined #openstack-nova | 12:42 | |
| *** moshele has quit IRC | 12:44 | |
| sdague | mriedem: ... http://logs.openstack.org/81/488381/3/experimental/gate-tempest-dsvm-cells-ubuntu-xenial/b5f4fa1/logs/devstacklog.txt.gz#_2017-08-01_10_56_05_959 ... oh cells munging hostnames | 12:45 |
| sdague | cells v1 that is | 12:46 |
| *** rmart04 has quit IRC | 12:46 | |
| sdague | we should rename cells v1 to apoptosis | 12:47 |
| *** mamandle has joined #openstack-nova | 12:47 | |
| *** amuresan has quit IRC | 12:47 | |
| *** slagle has quit IRC | 12:47 | |
| mriedem | it's not deprecated yet | 12:47 |
| mriedem | cells v1 is alive and well | 12:47 |
| sdague | alive... sure | 12:48 |
| sdague | mriedem: we really haven't deprecated it yet? | 12:48 |
| sdague | because it's definitely in freeze for everything bug critical fixes, it seems like deprecation should be a thing | 12:48 |
| sdague | even if we don't have a remove date | 12:48 |
| *** lyan_ has quit IRC | 12:49 | |
| *** yamamoto has joined #openstack-nova | 12:49 | |
| *** ratailor has quit IRC | 12:50 | |
| *** lucas-hungry is now known as lucasagomes | 12:50 | |
| gibi | jaypipes: sorry for that. I read back and only see an opportunity to refactor but not that somebody already started that | 12:51 |
| mriedem | i'm +2 on gibi's test change | 12:52 |
| mriedem | sdague: yes i've been thinking about deprecating cells v1 before we release pike, in case we want to drop it in queens | 12:52 |
| mriedem | b/c we can't drop nova-network until we drop cells v1 and i don't want to lose another cycle on that | 12:53 |
| *** lyan has joined #openstack-nova | 12:53 | |
| *** dave-mccowan has joined #openstack-nova | 12:54 | |
| jaypipes | mriedem: hold up. I'm fixing up a couple more things. | 12:54 |
| *** esberglu has joined #openstack-nova | 12:55 | |
| *** mriedem has quit IRC | 12:57 | |
| openstackgerrit | Merged openstack/nova master: provide interface-scoped nameserver information https://review.openstack.org/467699 | 12:57 |
| *** thorst_afk has joined #openstack-nova | 12:57 | |
| *** yamamoto has quit IRC | 12:59 | |
| *** kylek3h has joined #openstack-nova | 13:01 | |
| *** kbaegis has joined #openstack-nova | 13:01 | |
| bauzas | jaypipes: gibi: I'm confused by the current situation for reviewing, how can I help by looking at first? | 13:02 |
| *** lyan has quit IRC | 13:02 | |
| jaypipes | bauzas: please give me 15 mins to push up another patch on top of gibi's latest test resize patch | 13:03 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Read datapath_type from VIF object https://review.openstack.org/474914 | 13:03 |
| *** gouthamr has joined #openstack-nova | 13:03 | |
| *** lyan has joined #openstack-nova | 13:04 | |
| bauzas | jaypipes: okay | 13:04 |
| bauzas | jaypipes: I missed your convo yesterday with dan, hoping to understand more the issues | 13:04 |
| *** mriedem has joined #openstack-nova | 13:06 | |
| *** kukacz has quit IRC | 13:06 | |
| mriedem | hooray for neighborhood construction taking out all the power | 13:06 |
| *** kukacz has joined #openstack-nova | 13:06 | |
| dims | mriedem : yikes | 13:07 |
| *** acormier has joined #openstack-nova | 13:07 | |
| *** eharney has joined #openstack-nova | 13:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on expected network-vif-unplugged events https://review.openstack.org/465794 | 13:09 |
| *** iceyao has joined #openstack-nova | 13:09 | |
| jaypipes | bauzas: you didn't miss much other than me getting super raging. | 13:10 |
| *** mamandle has quit IRC | 13:11 | |
| *** acormier has quit IRC | 13:11 | |
| sdague | mriedem: https://review.openstack.org/#/c/487860/ that nova manage change, most of the urls you suggested in the test aren't valid urls | 13:13 |
| *** yushb has joined #openstack-nova | 13:14 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 13:15 |
| mriedem | sdague: it's on the list | 13:15 |
| sdague | mriedem: I also put a procedural hold on the privsep series once it started changing real things - https://review.openstack.org/#/c/459166/ | 13:16 |
| sdague | I assume that's about right for this point in the release | 13:16 |
| mriedem | yes | 13:16 |
| *** sridharg has quit IRC | 13:17 | |
| *** sridharg has joined #openstack-nova | 13:18 | |
| *** sridharg has quit IRC | 13:18 | |
| *** yushb has quit IRC | 13:18 | |
| *** cjvolzka has joined #openstack-nova | 13:19 | |
| *** sridharg has joined #openstack-nova | 13:19 | |
| *** sridharg has quit IRC | 13:19 | |
| *** lucasxu has joined #openstack-nova | 13:20 | |
| *** sridharg has joined #openstack-nova | 13:20 | |
| *** bkopilov_ has joined #openstack-nova | 13:21 | |
| mriedem | sdague: want to push this through? https://review.openstack.org/#/c/487932/ - i think what i'm hearing in there is we have to test it in prod | 13:22 |
| mriedem | but if it works, we have other redirects to add, like for the api microversion history stuff | 13:22 |
| mriedem | and those are just 2 that i know are broken, i don't know what else i don't know about | 13:23 |
| openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for RP traits https://review.openstack.org/474550 | 13:23 |
| openstackgerrit | Merged openstack/nova master: doc: add FAQ entry for cells v1 config options https://review.openstack.org/487938 | 13:23 |
| sdague | mriedem: looking | 13:24 |
| openstackgerrit | Merged openstack/nova master: do not pass proxy env variables by tox https://review.openstack.org/487327 | 13:24 |
| sdague | mriedem: yeh, +A | 13:24 |
| sdague | we can test those redirects out in production and get them fixed there | 13:24 |
| mriedem | stephenfin: are you going to update this? https://review.openstack.org/#/c/477497/ | 13:25 |
| mriedem | stephenfin: i've identified some missing nova CLI guides from the admin guide that are missing in there | 13:25 |
| *** mamandle has joined #openstack-nova | 13:25 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 13:25 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 13:25 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | 13:25 |
| *** claudiub has quit IRC | 13:25 | |
| jaypipes | mriedem, bauzas, gibi: I think you'll want to take a look at the changes I made to the test above. The tests now fail -- with no code changes -- indicating that the faulty assertions that supposedly were verifying the existing bad behaviour were incorrect. | 13:27 |
| *** yangyapeng has quit IRC | 13:27 | |
| jaypipes | mriedem, bauzas, gibi: specifically, after the changes to the test I made, the following fails: | 13:28 |
| mriedem | if you didn't change any function then why would they start failing? | 13:28 |
| jaypipes | 1250 # NOTE(danms): This is bug 1707071 where we've lost the entire | 13:29 |
| openstack | bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes) | 13:29 |
| jaypipes | 1251 # allocation because one of the computes deleted it | 13:29 |
| jaypipes | 1252 self.assertEqual(0, dest_usages['VCPU']) | 13:29 |
| jaypipes | mriedem: because the test assertion was wrong. | 13:29 |
| mriedem | then why wasn't it failing before? | 13:29 |
| jaypipes | mriedem: I believe because the test was incorrectly passing the source rp UUID when it was supposed to pass the dest rp UUID | 13:30 |
| * gibi is looking | 13:31 | |
| mriedem | jaypipes: so you did change something functional | 13:32 |
| mriedem | on which line? | 13:32 |
| *** slaweq_ has joined #openstack-nova | 13:32 | |
| gibi | jaypipes: could you point out the faulty line in the test in the previous patchset, in 1252 seems worked the same way before than now | 13:32 |
| *** cdent has joined #openstack-nova | 13:32 | |
| *** sridharg has quit IRC | 13:32 | |
| *** sridharg has joined #openstack-nova | 13:33 | |
| openstackgerrit | Merged openstack/nova master: add a redirect for the old cells landing page https://review.openstack.org/487932 | 13:33 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/489604 | 13:33 |
| *** tiendc has quit IRC | 13:34 | |
| *** pchavva has quit IRC | 13:35 | |
| *** sridharg has quit IRC | 13:35 | |
| *** pchavva has joined #openstack-nova | 13:35 | |
| *** sridharg has joined #openstack-nova | 13:35 | |
| *** slaweq_ has quit IRC | 13:37 | |
| jaypipes | gibi: your guess is as good as mine. :( | 13:37 |
| jaypipes | mriedem: I did not make any functional changes... :( | 13:38 |
| *** hongbin has joined #openstack-nova | 13:38 | |
| * gibi is diggin | 13:38 | |
| cdent | jaypipes, gibi : you two didn’t collide on your rebasing/patching of the test did you? | 13:38 |
| jaypipes | gibi, mriedem: the only thing I changes was not using this: | 13:38 |
| jaypipes | server['OS-EXT-SRV-ATTR:host'] | 13:38 |
| mriedem | jaypipes: ok, i don't know what you're saying then. you didn't make any changes, but things are failing, but they weren't before | 13:38 |
| jaypipes | cdent: no, I rebased on a clean version from gibi | 13:39 |
| jaypipes | mriedem, gibi: I believe the problem is the original test was relying on server['OS-EXT-SRV-ATTR:host'] to get the server's host and determine what was the "source" or "target". That's incorrect though because that value changes over the course of the migration | 13:40 |
| jaypipes | so when I remove that and just use constants for the source and destination hostname (and rp UUIDs), the tests fails. | 13:40 |
| mriedem | sdague: did you see my comments in here about versioning https://review.openstack.org/#/c/467699/ ? | 13:41 |
| jaypipes | this is also why I think dansmith was seeing non-deterministic issues with ordering. | 13:41 |
| jaypipes | because the server['OS-EXT-SRV-ATTR:host'] would change at different times in the migration sequence. | 13:41 |
| *** jmlowe has joined #openstack-nova | 13:41 | |
| dansmith | jaypipes: we got the host once at the beginning though | 13:42 |
| *** kristian__ has quit IRC | 13:43 | |
| jaypipes | dansmith: no... it was grabbed again on previous line 1215 in gibi's new _resize_and_check_allocations() | 13:43 |
| *** kristian__ has joined #openstack-nova | 13:43 | |
| *** sridharg has quit IRC | 13:44 | |
| *** sridharg has joined #openstack-nova | 13:44 | |
| *** liuyulong has quit IRC | 13:45 | |
| jaypipes | dansmith: well, it wasn't "grabbed again"... just read again from the server dict. but the server dict is passed to the _wait_for_status() thing. perhaps that dict is modified? | 13:45 |
| dansmith | jaypipes: that function wasn't there when Ilast pushed | 13:45 |
| jaypipes | dansmith: I know, it was gibi's overnight refactor. | 13:45 |
| jaypipes | but the basic premise remains. | 13:45 |
| dansmith | jaypipes: I don't think it does, | 13:46 |
| dansmith | because we pulled host, even saved it in original_host, | 13:46 |
| dansmith | and used the provider uuids once | 13:46 |
| dansmith | that was mriedem's early comment | 13:46 |
| jaypipes | dansmith: no, I'm right. bingo. The server parameter to _wait_for_state_change() is modified **in-place** and replaced with the returned value from the GET call. | 13:46 |
| jaypipes | dansmith: and that is why server['OS-EXT-SRV-ATTR:host'] changes value. | 13:47 |
| jaypipes | while True: | 13:47 |
| jaypipes | 225 server = admin_api.get_server(server['id']) | 13:47 |
| dansmith | oh you're right, so I should just stop looking then eh? | 13:47 |
| gibi | jaypipes: can it be that your refactring changed what host order we skip and what host order we test now? | 13:47 |
| jaypipes | well, I need food and more caffeine. will tackle this further when returning. | 13:47 |
| mriedem | dan's point was with the way the test was written about 16 hours ago, | 13:48 |
| mriedem | everything was monolithic, | 13:48 |
| mriedem | and we stored the source host right up front | 13:48 |
| jaypipes | gibi: no, my refactoring removed the use of server['OS-EXT-SRV-ATTR:host'] to get the resource provider UUIDs. that server['OS-EXT-SRV-ATTR:host'] changes over the course of the migration resulting in the wrong compute host being returned | 13:48 |
| dansmith | jaypipes: right and that change is wrong | 13:49 |
| dansmith | assuming that the rp uuid of the host we asked for is where it actually is is assuming too much, IMHO | 13:49 |
| mriedem | https://review.openstack.org/#/c/487958/14/nova/tests/functional/test_servers.py | 13:49 |
| jaypipes | dansmith: huh? | 13:49 |
| gibi | interestingly if I set dest_hostname to host1 in the confirm test it passes | 13:49 |
| jaypipes | gibi: and that is incorrect. | 13:49 |
| mriedem | https://review.openstack.org/#/c/487958/14/nova/tests/functional/test_servers.py@1168 | 13:49 |
| openstackgerrit | Jacek Tomasiak proposed openstack/nova master: ironic: Use internal API endpoint https://review.openstack.org/489537 | 13:50 |
| mriedem | as of last night (me and dan time), we got the source host once at the beginning | 13:50 |
| dansmith | jaypipes: I left a comment. However, I'm wrong and you're right, so I'm getting coffee and a bagel | 13:50 |
| *** liverpooler has joined #openstack-nova | 13:50 | |
| jaypipes | dansmith: ditto. | 13:50 |
| mriedem | don't make me quote rodney king | 13:51 |
| *** cleong has joined #openstack-nova | 13:51 | |
| sdague | mriedem: apparently not, I didn't see any -1s on it. | 13:52 |
| cdent | I often, in cases like this, wish we had to write new commits each time we pushed to gerrit | 13:52 |
| *** sridharg has quit IRC | 13:53 | |
| *** sridharg has joined #openstack-nova | 13:53 | |
| *** gbarros has quit IRC | 13:53 | |
| *** ijw has joined #openstack-nova | 13:54 | |
| mriedem | bauzas: i'm not sure why this is pike-rc-potential https://bugs.launchpad.net/nova/+bug/1702454 | 13:54 |
| openstack | Launchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 13:54 |
| mriedem | it's not a regression in master, it's a latent issue in stable right? | 13:55 |
| bauzas | mriedem: yup, like I said "As a consequence, the feature to pass a destination for evacuation is not working in Newton and Ocata. " | 13:55 |
| bauzas | mriedem: I'd love to see it merged for Pike so we could backport it 'til Newton | 13:55 |
| bauzas | if not, it would be a bit difficult to backport it | 13:56 |
| mriedem | why? | 13:56 |
| mriedem | pike GA != newton phase 3 | 13:56 |
| mriedem | bauzas: so how about writing a functional regression test for https://review.openstack.org/#/c/481116/ then ? | 13:56 |
| mriedem | because anything involving the request spec getting passed around 3 different services should have a functional test | 13:57 |
| *** sridharg has quit IRC | 13:57 | |
| bauzas | mriedem: for evacuating ? | 13:57 |
| bauzas | mriedem: not sure it would work for a functional test | 13:57 |
| mriedem | i've been wanting to write a functional test for evacuate for a long time, | 13:58 |
| mriedem | i don't think it would be that hard | 13:58 |
| *** gszasz has quit IRC | 13:58 | |
| bauzas | mriedem: about why Pike, because https://docs.openstack.org/project-team-guide/stable-branches.html#support-phases | 13:58 |
| *** sridharg has joined #openstack-nova | 13:58 | |
| mriedem | you start 2 services, create server on one, force it down and evacuate | 13:58 |
| bauzas | mriedem: I can try | 13:58 |
| mriedem | https://releases.openstack.org/ | 13:59 |
| *** chyka has joined #openstack-nova | 13:59 | |
| mriedem | Phase III – Legacy release on 2017-10-09 | 13:59 |
| mriedem | you have 5 weeks to make it happen :) | 13:59 |
| bauzas | okay okay :) | 13:59 |
| *** yushb has joined #openstack-nova | 13:59 | |
| bauzas | mriedem: just remove the pike-potential tag and I'll try to provide a functional test | 14:00 |
| *** kukacz_ has joined #openstack-nova | 14:00 | |
| bauzas | mriedem: but then, I'll harass you :p | 14:00 |
| * bauzas jk :p | 14:00 | |
| mriedem | except !jk | 14:00 |
| gibi | bauzas: there is example evacuate test in the server_group functional test I think | 14:00 |
| *** gbarros has joined #openstack-nova | 14:00 | |
| bauzas | gibi: maybe, I'll look :) | 14:01 |
| *** kukacz__ has joined #openstack-nova | 14:01 | |
| mriedem | bauzas: keep in mind, the way we do the functional regression tests is a 2 patch process, | 14:01 |
| gibi | bauzas: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L412 | 14:01 |
| mriedem | the first writes the test recreating the bug, | 14:01 |
| mriedem | asserting the failure, | 14:01 |
| mriedem | the 2nd patch fixes the bug | 14:01 |
| mriedem | and adjusts the test | 14:01 |
| bauzas | the functional server groups tests just do a lot so I'm not remembering if it's also calling evacuate :p | 14:01 |
| *** kukacz has quit IRC | 14:01 | |
| bauzas | mriedem: yup, I know, no worries | 14:01 |
| bauzas | I did reviewed a few of you :p | 14:01 |
| gibi | bauzas: also a notification sample test with evacuate is up on review https://review.openstack.org/#/c/482148/3/nova/tests/functional/notification_sample_tests/test_instance.py | 14:02 |
| mriedem | i know, quotas things | 14:02 |
| gibi | bauzas: this one is better as it uses force_down | 14:02 |
| bauzas | thanks gibi :) | 14:03 |
| mriedem | bauzas: i also don't think https://bugs.launchpad.net/nova/+bug/1678056 is pike-rc-potential | 14:03 |
| openstack | Launchpad bug 1678056 in OpenStack Compute (nova) "RequestSpec records are never deleted when destroying an instance" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 14:03 |
| mriedem | request specs not getting deleted is a latent issue | 14:03 |
| bauzas | same problem | 14:03 |
| bauzas | same situation | 14:03 |
| *** chyka has quit IRC | 14:03 | |
| *** sridharg has quit IRC | 14:03 | |
| bauzas | we have that since we persisted the Requestspec records | 14:03 |
| mriedem | sure, but it's not a pike blocker | 14:04 |
| bauzas | so that's not really a regression | 14:04 |
| mriedem | it's latent | 14:04 |
| bauzas | but AFAIK I thought RC1 was not only for regressions :) | 14:04 |
| *** sridharg has joined #openstack-nova | 14:04 | |
| bauzas | RC2 and others yup so | 14:04 |
| *** lbragstad_ is now known as lbragstad | 14:04 | |
| *** crushil has joined #openstack-nova | 14:04 | |
| mriedem | pike-rc-potential is not your personal wishlist of bugs for review :) | 14:04 |
| *** kukacz_ has quit IRC | 14:05 | |
| bauzas | anyway, seems I agreed to remove pike-rc-potential for the former, I'm okay to remove that tag for the latter :) | 14:05 |
| mriedem | yup, done | 14:05 |
| *** kristia__ has joined #openstack-nova | 14:05 | |
| mriedem | i'm just working on my etherpad of stuff to do for rc1 | 14:05 |
| mriedem | so that's why i'm being harsh on these tagged bugs | 14:05 |
| bauzas | no worries | 14:05 |
| mriedem | and as a result i'm taking it out on you | 14:05 |
| *** slaweq has quit IRC | 14:05 | |
| bauzas | yup, I understand | 14:05 |
| bauzas | no worries again | 14:05 |
| bauzas | I just want to make sure we don't forget them | 14:06 |
| mriedem | i could never forget the wasteland that is request spec bugs :) | 14:06 |
| bauzas | and since we were working on features during last milestones, I'll ping a few of us during those weeks | 14:06 |
| mriedem | ^ not sure what you mean there | 14:06 |
| mriedem | you mean you held off on pinging people for bug reviews b/c of working on closing out features? | 14:07 |
| bauzas | exacrlt | 14:07 |
| mriedem | ok | 14:07 |
| bauzas | exactly | 14:07 |
| bauzas | now, it's time for asking to review bugs | 14:07 |
| bauzas | of course, regressions first, totally agreed | 14:07 |
| mriedem | gmann: alex_xu: do you know if patches were put up for modifying the api plugins and stable api docs pages for the new routes stuff? | 14:08 |
| *** kukacz__ has quit IRC | 14:08 | |
| *** kristian__ has quit IRC | 14:08 | |
| *** mamandle has quit IRC | 14:09 | |
| *** awaugama has joined #openstack-nova | 14:09 | |
| *** markus_z has quit IRC | 14:13 | |
| *** sridharg has quit IRC | 14:15 | |
| *** jamesden_ has joined #openstack-nova | 14:15 | |
| *** sridharg has joined #openstack-nova | 14:16 | |
| *** jamesdenton has quit IRC | 14:18 | |
| openstackgerrit | Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | 14:20 |
| *** sridharg has quit IRC | 14:20 | |
| *** dfisher has joined #openstack-nova | 14:20 | |
| *** sridharg has joined #openstack-nova | 14:22 | |
| *** sridharg has quit IRC | 14:23 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 14:23 |
| *** sridharg has joined #openstack-nova | 14:24 | |
| mriedem | melwitt: we should update this doc for counting quotas https://docs.openstack.org/nova/latest/user/quotas.html | 14:25 |
| *** udesale has quit IRC | 14:26 | |
| *** hshiina has quit IRC | 14:27 | |
| *** lucasxu has quit IRC | 14:27 | |
| *** marst_ has quit IRC | 14:28 | |
| *** sridharg has quit IRC | 14:30 | |
| *** sridharg has joined #openstack-nova | 14:31 | |
| *** eharney has quit IRC | 14:33 | |
| gibi | jaypipes, dansmith: sorry for being stubborn but I still not get it. The only difference I see in the logs between ps17 and ps18 is that in ps17 server booted on host2 and then moved to host1 while in ps18 it is booted on host1 and moved to host2 | 14:33 |
| *** slaweq has joined #openstack-nova | 14:33 | |
| *** trinaths has joined #openstack-nova | 14:33 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for PUT /os-services/* for non-compute services https://review.openstack.org/489621 | 14:33 |
| *** slaweq has quit IRC | 14:33 | |
| *** trinaths has left #openstack-nova | 14:33 | |
| gibi | jaypipes, dansmith: and as the periodic tasks runs in the same order in both patch sets the two patch sets test two different scenari | 14:34 |
| *** marst has joined #openstack-nova | 14:35 | |
| dansmith | gibi: tbh I haven't looked at the later ones in detail.. as I said on the review, I think we should revert back to PS14 and roll on, but I'm not sure if there was a reason for the refactor | 14:35 |
| *** slaweq has joined #openstack-nova | 14:35 | |
| *** slaweq_ has joined #openstack-nova | 14:36 | |
| gibi | dansmith: the refactor was only for reduce duplication and increase readability by better naming | 14:37 |
| *** sridharg has quit IRC | 14:37 | |
| gibi | dansmith: I think 14 and 17 executes the same scenario but 18 executes a different one (different move direction) | 14:37 |
| dansmith | gibi: well, like I said, the duplication in the test makes it _more_ readable IMHO, even if a bit wasteful | 14:38 |
| dansmith | gibi: agree we could have improved the naming a bit though | 14:38 |
| *** sridharg has joined #openstack-nova | 14:38 | |
| *** slagle has joined #openstack-nova | 14:39 | |
| *** tbachman has joined #openstack-nova | 14:39 | |
| *** trinaths has joined #openstack-nova | 14:39 | |
| jaypipes | gibi: yeah, as I walked to get breakfast I realized you are correct | 14:39 |
| *** slaweq_ has quit IRC | 14:40 | |
| * mriedem imagines jay walking down a cavernous hallways for his lucky charms | 14:40 | |
| * cdent never wants to see that image again | 14:41 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 14:42 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 14:42 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | 14:42 |
| jaypipes | dansmith, gibi, mriedem: ok, good to go now ^^ | 14:42 |
| jaypipes | for the test resize patch at least | 14:42 |
| *** psachin has quit IRC | 14:42 | |
| *** cfriesen_ has joined #openstack-nova | 14:42 | |
| jaypipes | dansmith, gibi, mriedem: now I go back to trying to actually fix the bug 1707071 | 14:43 |
| openstack | bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes) | 14:43 |
| gibi | dansmith, jaypipes: then I guess we are not bringing back the duplications by inlining util functions I introduced | 14:44 |
| jaypipes | gibi: I think what you did made the test easier to read and consume. | 14:46 |
| jaypipes | gibi: I know dansmith disagrees a bit, though | 14:46 |
| *** sridharg has quit IRC | 14:46 | |
| jaypipes | but dansmith is a disagreeable man. | 14:47 |
| *** ekuris has quit IRC | 14:47 | |
| jaypipes | who requires a constant IV drop of caffeine to agree with anything. | 14:47 |
| jaypipes | is it Friday yet? | 14:47 |
| *** sridharg has joined #openstack-nova | 14:48 | |
| cdent | soon, jaypipes. soon | 14:48 |
| jaypipes | hehe | 14:48 |
| mriedem | https://images-na.ssl-images-amazon.com/images/I/51S%2BpPtReeL._AC_UL320_SR228,320_.jpg | 14:48 |
| *** eharney has joined #openstack-nova | 14:48 | |
| mriedem | or https://s-media-cache-ak0.pinimg.com/originals/49/d7/a0/49d7a0676e7945b3fb7bcf4c4533fd99.jpg | 14:49 |
| sdague | gibi: honestly, on the test front, duplication is not a bad thing. You are trying to understand individual test functions in their own context, and if you have to chase a bunch of common code, it's a lot harder to put the state in your head | 14:49 |
| *** gszasz has joined #openstack-nova | 14:50 | |
| gibi | sdague: I have no firm oppinion I think for me the usefullness of deduplication depends on how well I can trust the utility function to do what it promise | 14:52 |
| *** chyka has joined #openstack-nova | 14:53 | |
| *** annegentle has joined #openstack-nova | 14:53 | |
| dansmith | sdague: exactly | 14:53 |
| gibi | sdague: to build that trust during review I guess I inline the utils in my head at the first usage but then later I just trust them | 14:53 |
| *** annegentle has quit IRC | 14:54 | |
| *** annegentle has joined #openstack-nova | 14:55 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 14:57 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 14:57 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | 14:57 |
| jaypipes | dansmith: made those changes you pointed out in the review ^^ | 14:57 |
| *** chyka has quit IRC | 14:57 | |
| *** vladikr has quit IRC | 14:58 | |
| openstackgerrit | khushbu parakh proposed openstack/nova master: Closes-Bug: #1454515 https://review.openstack.org/488941 | 14:58 |
| openstack | bug 1454515 in OpenStack Compute (nova) "Property "instance.disable_terminate" is always "False" and never actually used." [Low,In progress] https://launchpad.net/bugs/1454515 - Assigned to Khushbuparakh (khushbuparakh) | 14:58 |
| sdague | gibi: right, but that's because you are familiar with them. People reading tests will not be, so it takes longer to understand what is going on if they also need to digest utils | 14:59 |
| *** acormier has joined #openstack-nova | 15:01 | |
| *** sridharg has quit IRC | 15:02 | |
| *** jamesden_ has quit IRC | 15:02 | |
| *** felipemonteiro has joined #openstack-nova | 15:02 | |
| *** sridharg has joined #openstack-nova | 15:02 | |
| *** acormier_ has joined #openstack-nova | 15:03 | |
| *** Oku_OS is now known as Oku_OS-away | 15:04 | |
| *** sridharg has quit IRC | 15:04 | |
| *** acormier has quit IRC | 15:05 | |
| *** jamesdenton has joined #openstack-nova | 15:05 | |
| *** sridharg has joined #openstack-nova | 15:05 | |
| dfisher | ok, i'm still struggling trying to get a compute node talking to a devstack rig. What services need to be running on the compute node? Obviously nova-compute but what else? | 15:05 |
| dfisher | this is all with beta3 | 15:06 |
| dfisher | nova service-list sees my compute node, but cell_v2 discover_hosts can't find it | 15:06 |
| gibi | sdague: sure, there is an overhead due to the extra indirection until the reader gets familiar with the utils but after that it is a lot easier to read the deduplicated code (not to mention chaging it) | 15:07 |
| *** sridharg has quit IRC | 15:07 | |
| jaypipes | gibi, dansmith, mriedem, cdent: for the record, I was wrong, dansmith and gibi were right. sorry that I jumped the gun. | 15:07 |
| mriedem | dfisher: what does nova-manage cell_v2 list_cells show? | 15:07 |
| mriedem | do you have a cell0 and cell1? | 15:07 |
| *** josecastroleon has joined #openstack-nova | 15:07 | |
| *** mkucia has quit IRC | 15:07 | |
| * cdent bows to jaypipes | 15:07 | |
| jaypipes | gibi, dansmith, mriedem, cdent: and I did not mean to shut anyone down. I just thought I'd figured out the issue | 15:07 |
| dfisher | mriedem: yes. I have both cell0 and cell1 | 15:07 |
| *** sridharg has joined #openstack-nova | 15:08 | |
| cdent | jaypipes: I’ll have a aggregate map WIP up shortly | 15:08 |
| jaypipes | cdent: cool, thanks. | 15:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate cells v1 https://review.openstack.org/489632 | 15:08 |
| gibi | jaypipes: you made me think for a while, but I like these mental challenges so no worries | 15:08 |
| sdague | dfisher: what versions of devstack code do you have? | 15:08 |
| dansmith | dfisher: and cell1 points to the same transport and db url as the config for the conductor and the compute? | 15:08 |
| mriedem | dfisher: and does the transport_url for cell1 match the transport_url in nova.conf on the compute node? | 15:08 |
| dfisher | sdague: git pull'd as of yesterday | 15:08 |
| *** felipemonteiro has quit IRC | 15:08 | |
| mriedem | dfisher: you can see the transport_url for cell1 by using --verbose with the list_cells command | 15:08 |
| dfisher | dansmith/mriedem: hang on, checking... | 15:09 |
| *** vladikr has joined #openstack-nova | 15:09 | |
| mriedem | dansmith: sdague: here is the cellsv1 deprecation https://review.openstack.org/489632 | 15:09 |
| dansmith | dfisher: this is what I asked you yesterday fwiw :) | 15:09 |
| dfisher | I know. I'm thick :( | 15:09 |
| jaypipes | gibi: no, I feel bad because I didn't see dansmith's comment above "oh you're right, so I should just stop looking then eh?". I didn't mean to shut him down. | 15:09 |
| sdague | mriedem: ++ | 15:10 |
| dfisher | dansmith: i apologize but I didn't understand you meant the transport_url | 15:11 |
| dfisher | dansmith: you said, "dfisher: make sure your conductor's config is pointed at the cell1 db, matching the cell1 cell_mapping record" | 15:12 |
| dansmith | dfisher: yesterday or now? | 15:12 |
| dfisher | dansmith: and I thought you meant the database connection string :( | 15:12 |
| dfisher | yesterday | 15:12 |
| dfisher | ok, so with the transport_url set right, i'm in business | 15:12 |
| dansmith | dfisher: well, it's a little of both | 15:12 |
| dfisher | thank you all. | 15:12 |
| dansmith | dfisher: cool | 15:12 |
| mriedem | little bit country? little bit rock&roll? | 15:12 |
| mriedem | dfisher: we could put something in https://docs.openstack.org/nova/latest/user/cells.html#faqs for your ase | 15:13 |
| mriedem | *case | 15:13 |
| *** sridharg has quit IRC | 15:14 | |
| *** rcernin has quit IRC | 15:14 | |
| *** sridharg has joined #openstack-nova | 15:14 | |
| mriedem | by we i think i mean you | 15:14 |
| *** chyka has joined #openstack-nova | 15:16 | |
| *** sridharg has quit IRC | 15:16 | |
| *** sridharg has joined #openstack-nova | 15:17 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP Update RT aggregate map less frequently https://review.openstack.org/489633 | 15:18 |
| *** sridharg has quit IRC | 15:18 | |
| sdague | dfisher: ok, it would be good to figure out where that went wrong | 15:19 |
| sdague | because devstack should be setting it up correctly on both controller and compute | 15:19 |
| *** sridharg has joined #openstack-nova | 15:19 | |
| sdague | and if something is falling through, would be good to fix | 15:19 |
| mriedem | sdague: i assume dfisher is doign multinode | 15:19 |
| mriedem | w/o devstack-gate | 15:19 |
| sdague | mriedem: sure | 15:19 |
| sdague | but the only thing in d-g is the discover_hosts | 15:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 15:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 15:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | 15:20 |
| cdent | jaypipes: that patch above does what I think we’re after ^ but needs some reactions and tweaks. gonna get lunch and then will check back | 15:20 |
| jaypipes | cdent: cheers | 15:20 |
| mriedem | sdague: d-g also sets up the local.conf for the subnodes doesn't it? | 15:20 |
| mriedem | otherwise you'd have n-api in enabled_services | 15:20 |
| cdent | bbs | 15:20 |
| *** sridharg has quit IRC | 15:20 | |
| sdague | mriedem: yeh, but I didn't think we had cells specific logic there | 15:20 |
| *** vladikr_ has joined #openstack-nova | 15:20 | |
| sdague | I'd like devstack multinode without d-g to work for folks | 15:21 |
| *** vladikr has quit IRC | 15:21 | |
| *** cdent has quit IRC | 15:21 | |
| *** iceyao has quit IRC | 15:21 | |
| mriedem | sdague: there is conditional logic in devstack to know if it's a subnode or not based on n-api running | 15:21 |
| mriedem | is my point | 15:21 |
| *** sridharg has joined #openstack-nova | 15:21 | |
| *** pcaruana has quit IRC | 15:22 | |
| sdague | mriedem: yeh | 15:22 |
| *** sridharg has quit IRC | 15:22 | |
| sdague | dfisher: anyway, if you have suggestions on how to make this more clear and straightforward to setup on the devstack side, let me know | 15:23 |
| dfisher | sdague: just mention that the transport_url on the compute node needs to match the cell1 transport_url | 15:23 |
| dfisher | that's all you need. | 15:23 |
| *** sridharg has joined #openstack-nova | 15:23 | |
| dfisher | and, again, thank you sdague, mriedem, and dansmith for putting up with dumb questions from the peanut gallery | 15:24 |
| *** kbaegis has quit IRC | 15:24 | |
| *** kbaegis has joined #openstack-nova | 15:24 | |
| gibi | jaypipes, dansmith: I have one more question at https://review.openstack.org/#/c/487958/21/nova/tests/functional/test_servers.py@1370 | 15:24 |
| sdague | dfisher: any idea where that should be mentioned that it would be more obvious? | 15:25 |
| *** damien_r has left #openstack-nova | 15:25 | |
| *** sridharg has quit IRC | 15:25 | |
| dfisher | sdague: | 15:25 |
| dfisher | 1.Configure and start your compute hosts. Before step 7, make sure you have compute hosts in the database by running nova service-list --binary nova-compute. | 15:25 |
| dfisher | gah. that should be #6 | 15:25 |
| *** sridharg has joined #openstack-nova | 15:26 | |
| dfisher | maybe something like: 'Configure your compute node's transport_url to point to the cell1 transport_url (visible with nova-manage cell_v2 list_cells —verbose) and start the nova-compute service' | 15:27 |
| jaypipes | gibi: that's concerning to me. I can't explain why that would be. :( | 15:27 |
| *** kbaegis1 has joined #openstack-nova | 15:28 | |
| *** sridharg has quit IRC | 15:28 | |
| *** sridharg has joined #openstack-nova | 15:29 | |
| gibi | jaypipes: sorry I pointed to the wrong assert it fails the assert 'self.assertEqual(0, len(allocations))' | 15:29 |
| mriedem | dfisher: step 5 says, "The transport url is taken from the [DEFAULT]/transport_url setting in the Nova configuration file if not specified on the command line." - which would assume that if you created cell1 with a transport_url from the config file, you'd be using that same config file on the compute service if you have a single MQ | 15:29 |
| *** claudiub has joined #openstack-nova | 15:29 | |
| mriedem | dfisher: devstack is a bit different now in that by default there are 2 conductors | 15:30 |
| mriedem | what you suggest isn't a bad reminder though | 15:30 |
| * dfisher nods | 15:31 | |
| *** kbaegis has quit IRC | 15:31 | |
| *** sridharg has quit IRC | 15:31 | |
| mriedem | dfisher: did you want to push a change to adjust that part of the docs? | 15:32 |
| bauzas | oh man, my computer crashed | 15:32 |
| mriedem | bauzas: it didn't crash, it's on french government mandated PTO | 15:32 |
| *** sridharg has joined #openstack-nova | 15:32 | |
| bauzas | (says the one who uses AndChat) | 15:32 |
| mriedem | hence the smoke | 15:32 |
| jaypipes | gibi: I believe there should be a *separate* assertion above line 1370 that shows we have the correct allocation after CONFIRM_RESIZE but after the periodics run, that allocation is messed up. I think that's what dansmith was going for there. | 15:32 |
| dfisher | I can. Not sure how, however. That and me no word good. | 15:32 |
| bauzas | mriedem: it's a trap | 15:33 |
| mriedem | dfisher: have you ever pushed a change to review.openstack.org? | 15:33 |
| dfisher | yep. | 15:33 |
| dansmith | isn't dfisher from oracle? | 15:33 |
| *** kbaegis1 has quit IRC | 15:33 | |
| dfisher | that's me | 15:33 |
| * dfisher ducks | 15:33 | |
| dansmith | he might burst into flame if he pushes a patch | 15:33 |
| dansmith | so we should probably do it for him | 15:33 |
| dfisher | :( | 15:33 |
| *** kbaegis has joined #openstack-nova | 15:33 | |
| *** zz_dimtruck has quit IRC | 15:33 | |
| mriedem | dfisher: http://git.openstack.org/cgit/openstack/nova/tree/doc/source/user/cells.rst#n391 is the line you want | 15:33 |
| * dfisher nods | 15:34 | |
| dfisher | on it. | 15:34 |
| gibi | jaypipes: make sense | 15:34 |
| jaypipes | gibi: I'll add that assertion. | 15:34 |
| gibi | jaypipes: thanks | 15:34 |
| *** crushil has quit IRC | 15:35 | |
| dfisher | dansmith: i'll let you know if you if any parts of me (fleshy or ethereal) start to smoke as I work on this | 15:35 |
| *** sree has quit IRC | 15:35 | |
| *** lpetrut_ has quit IRC | 15:36 | |
| dansmith | dfisher: I'll stand by with a fire extinguisher | 15:36 |
| *** armax has quit IRC | 15:36 | |
| *** lpetrut has joined #openstack-nova | 15:36 | |
| *** sree has joined #openstack-nova | 15:36 | |
| dfisher | even though I'm an Oracle employee? :) | 15:36 |
| mriedem | sdague: redirect works https://docs.openstack.org/nova/latest/cells.html | 15:36 |
| dansmith | dfisher: you're still a human... | 15:36 |
| dansmith | dfisher: um, right? | 15:36 |
| * dfisher hisses | 15:36 | |
| gibi | jaypipes: would it make sense if I start building some more funcitonal tests top of the your bug fix to see further ahead? | 15:36 |
| dansmith | heh | 15:37 |
| mriedem | gibi: yes we want a single node functional set of tests for resize confirm/revert | 15:37 |
| mriedem | resize to same host | 15:37 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fake_notifier: allow waiting on either notification type https://review.openstack.org/489637 | 15:37 |
| dfisher | as a Denver resident I can suggest places to eat (and not to eat) for the PTG | 15:37 |
| mriedem | gibi: that's going to be needed for this bug https://bugs.launchpad.net/nova/+bug/1707252 | 15:37 |
| jaypipes | gibi: not at this time, I don't think so. | 15:37 |
| openstack | Launchpad bug 1707252 in OpenStack Compute (nova) "Claims in the scheduler does not account for doubling allocations on resize to same host" [Medium,Confirmed] | 15:37 |
| dfisher | i can trade that for fire-putting-outting, maybe | 15:37 |
| *** kbaegis has quit IRC | 15:38 | |
| mdbooth | mriedem: Incidentally, I now have a patch on top of gibi's patch, but because it also has another dependency I can't push it | 15:38 |
| mdbooth | Any chance we could keep the scope of gibi's patch small so it can merge soon? | 15:38 |
| mdbooth | And add more later. | 15:39 |
| gibi | mdbooth: If you are refering to https://review.openstack.org/#/c/487958/ then I think that patch is pretty close to land | 15:39 |
| mriedem | mdbooth: i was assuming any new tests would be built on top | 15:39 |
| mdbooth | gibi: Yep, that's the one. | 15:40 |
| *** sridharg has quit IRC | 15:40 | |
| *** pcaruana has joined #openstack-nova | 15:40 | |
| mdbooth | mriedem: Excellent, just checking. | 15:40 |
| mriedem | mdbooth: believe me, i'd like to see that test patch land asap | 15:40 |
| gibi | mdbooth: I think that patch will not grow further | 15:40 |
| *** kbaegis has joined #openstack-nova | 15:40 | |
| mdbooth | gibi: Now could you land it in the next 10 minutes? ;) | 15:40 |
| gibi | mdbooth: I have no power over it ;) | 15:40 |
| *** armax has joined #openstack-nova | 15:40 | |
| *** sree has quit IRC | 15:40 | |
| *** sridharg has joined #openstack-nova | 15:41 | |
| mdbooth | I have your patch stashed in the middle of my own series, so I need to be really careful not to submit it! | 15:41 |
| *** andreas_s has quit IRC | 15:41 | |
| *** sridharg has quit IRC | 15:42 | |
| gibi | mdbooth: to be clear it is not my patch, it is shared at least between jaypipes, dansmith, cdent and myself. Just to make it easy ;) | 15:43 |
| *** eharney_ has joined #openstack-nova | 15:43 | |
| gibi | mriedem: so I'm not committing myself to start the resize to same host today, but if nobody starts that until I wake up tomorrow then I will stat | 15:43 |
| gibi | mriedem: s/stat/start/ | 15:44 |
| mriedem | gibi: ok i might start that today | 15:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add redirect for api-microversion-history doc https://review.openstack.org/489641 | 15:44 |
| gibi | mriedem: ping me when you start to avoid double work | 15:45 |
| mriedem | aye aye | 15:45 |
| * gibi now sees the power of distributed development timezones | 15:46 | |
| *** annegentle has quit IRC | 15:46 | |
| mriedem | fyi, also sent to the ML https://etherpad.openstack.org/p/nova-pike-release-candidate-todo | 15:46 |
| *** eharney has quit IRC | 15:46 | |
| *** kbaegis has quit IRC | 15:47 | |
| *** eharney_ is now known as eharney | 15:48 | |
| openstackgerrit | Drew Fisher proposed openstack/nova master: Add language for compute node configuration https://review.openstack.org/489643 | 15:48 |
| * dfisher combusts | 15:48 | |
| *** annegentle has joined #openstack-nova | 15:49 | |
| *** rcernin has joined #openstack-nova | 15:49 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 15:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 15:49 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | 15:49 |
| *** hamzy has quit IRC | 15:49 | |
| jaypipes | gibi: done. | 15:50 |
| gibi | jaypipes: looking | 15:51 |
| *** zenoway has quit IRC | 15:51 | |
| *** yushb has quit IRC | 15:53 | |
| *** cdent has joined #openstack-nova | 15:53 | |
| *** iceyao has joined #openstack-nova | 15:54 | |
| dansmith | dfisher-cinder: sorry, I was distracted while you were exploding | 15:54 |
| sdague | mriedem: woot, now we just need to figure out what other redirects are needed | 15:55 |
| *** crushil has joined #openstack-nova | 15:55 | |
| mriedem | sdague: basically everything | 15:55 |
| mriedem | placement, vendordata, everything has changed | 15:55 |
| mriedem | api microversion history | 15:55 |
| mriedem | i'm in -doc | 15:55 |
| *** iceyao has quit IRC | 15:58 | |
| *** Apoorva has joined #openstack-nova | 16:00 | |
| gibi | jaypipes: looks good to me | 16:00 |
| *** lpetrut has quit IRC | 16:03 | |
| *** lucasxu has joined #openstack-nova | 16:04 | |
| * gibi is signing off for today | 16:06 | |
| bauzas | mriedem: have time for a quick question about https://bugs.launchpad.net/nova/+bug/1702454 ? | 16:06 |
| openstack | Launchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 16:06 |
| bauzas | mriedem: given it works for Pike but not Newton and Ocata, the regression test would be different between stable changes and the master change | 16:07 |
| bauzas | mriedem: doesn't that look a bit weird ? | 16:07 |
| bauzas | mriedem: tbc, I'll be testing that if you have 2 hosts (A, B) with A as a target for the instance, it would provide a NoValidHost if A is not accepting it | 16:08 |
| *** claudiub has quit IRC | 16:08 | |
| bauzas | mriedem: that would be for the fix | 16:09 |
| bauzas | mriedem: and without the fix (in Ocata and N) it would just provide B as instance.host | 16:09 |
| bauzas | or at least accepting to evacuate | 16:09 |
| bauzas | see my problem ? | 16:09 |
| bauzas | the cherry-pick change would be different | 16:10 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness https://review.openstack.org/487183 | 16:10 |
| mriedem | bauzas: do we have a fix to make in pike at all? | 16:10 |
| bauzas | mriedem: so, only a stable change ? | 16:10 |
| bauzas | I'm confused | 16:11 |
| bauzas | like I said in the bug report, the bug was fixed implicitly by https://review.openstack.org/#/c/469037/ but we can't just backport it | 16:11 |
| mriedem | bauzas: if it's fixed on master, then yes it's a stable only change | 16:12 |
| bauzas | okay, lemme upload then and we'll discuss | 16:12 |
| *** links has joined #openstack-nova | 16:12 | |
| mriedem | unless you just write the regression test for master but no fix | 16:12 |
| mriedem | as you said, the backport of the test would be weird | 16:13 |
| *** lyan has quit IRC | 16:14 | |
| bauzas | anyway, looks difficult to discuss unless I'm uploading it | 16:15 |
| bauzas | so I'll do | 16:15 |
| * bauzas just needs to bailout because $wife + $ikea | 16:15 | |
| *** mvensky has quit IRC | 16:16 | |
| mriedem | does that mean sylvain's wife is variable? | 16:18 |
| openstackgerrit | Sean Dague proposed openstack/nova master: add redirects for existing broken docs urls https://review.openstack.org/489650 | 16:18 |
| sdague | mriedem: ^^^ | 16:18 |
| sdague | mriedem: also, here are real 404s from today, which include stuff going way back - http://paste.openstack.org/show/617142/ | 16:18 |
| bauzas | mriedem: oh oops, WIFE + $idea | 16:18 |
| bauzas | $ikea even | 16:18 |
| mdbooth | mriedem: *potentially* variable. In practise it may not actually be modified after assignment. | 16:18 |
| *** vishwana_ has quit IRC | 16:18 | |
| *** vishwanathj has joined #openstack-nova | 16:19 | |
| mriedem | sdague: can those tabs be fixed? | 16:19 |
| sdague | mriedem: sure | 16:19 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness https://review.openstack.org/487183 | 16:20 |
| openstackgerrit | Sean Dague proposed openstack/nova master: add redirects for existing broken docs urls https://review.openstack.org/489650 | 16:20 |
| mdbooth | So I can rebase 7 patches on top of the revert function tests | 16:21 |
| sdague | mriedem: I'm going to walk away for a bit, but I can rebase sfinucan's patches later today probably, and add any more redirects if we need them | 16:22 |
| sdague | although I think most of the moves already happened | 16:22 |
| *** lucasagomes is now known as lucas-afk | 16:23 | |
| *** aarefiev is now known as aarefiev_afk | 16:23 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fake_notifier: allow waiting on either notification type https://review.openstack.org/489637 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize https://review.openstack.org/487515 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802 | 16:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Functional test for auto revert resize https://review.openstack.org/489654 | 16:24 |
| mdbooth | Meh, at least now I have something to point people at | 16:24 |
| *** itlinux has joined #openstack-nova | 16:25 | |
| *** rajathagasthya has joined #openstack-nova | 16:30 | |
| *** crushil has quit IRC | 16:30 | |
| *** stewie925_ has joined #openstack-nova | 16:31 | |
| *** yamahata has joined #openstack-nova | 16:31 | |
| *** stewie925_ is now known as stewie925 | 16:32 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove custom autodoc implementation https://review.openstack.org/480262 | 16:33 |
| *** ragasthya has joined #openstack-nova | 16:33 | |
| *** rajathagasthya has quit IRC | 16:35 | |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/489604 | 16:39 |
| mriedem | dansmith: jaypipes: i'm +2 on gibi's test now https://review.openstack.org/#/c/487958/ - should i just push that through? | 16:39 |
| *** penick has joined #openstack-nova | 16:39 | |
| mriedem | since you both worked on it and sean is afk | 16:39 |
| dansmith | mriedem: I'm not likely to +W it in its current form, so probably | 16:39 |
| mriedem | ok | 16:39 |
| jaypipes | mriedem: actually I'd like to add one more assertion in there. | 16:40 |
| mriedem | jaypipes: can it go on top? | 16:40 |
| jaypipes | mriedem: sure I suppose | 16:40 |
| mriedem | i just want to stop iterating on this one | 16:40 |
| jaypipes | ok with me | 16:40 |
| mriedem | but if you're ready like now then i can wait | 16:40 |
| jaypipes | mriedem: please proceed. | 16:41 |
| mriedem | done | 16:41 |
| *** lpetrut has joined #openstack-nova | 16:42 | |
| cdent | jaypipes: has a plan (for migrations) distilled out of today’s conversations yet, or is that still pending? | 16:43 |
| * cdent is trying hard to keep abreast | 16:43 | |
| jaypipes | cdent: 1707071 is the primary bug I'm tracking right now. | 16:43 |
| *** ijw has quit IRC | 16:44 | |
| cdent | jaypipes: yes, but I thought any potential solutions to that impinge on the wider migration picture? | 16:44 |
| jaypipes | cdent: not quite following you on that... | 16:45 |
| cdent | jaypipes: maybe I misunderstood your answer to my question. Are you saying “yes, that’s what 1707071 is about” or “no, I’m focused on the details of making sure that we create the right allocations”? Looks like the former? | 16:47 |
| *** abalutoiu has joined #openstack-nova | 16:47 | |
| jaypipes | cdent: I'm focused on trying to not have Pike compute node RTs fight each other writing and overwriting allocation records. | 16:48 |
| cdent | Earlier today you said that overnight you fought with the code enough to think that you had to rejigger everything again. | 16:48 |
| jaypipes | cdent: what I said earlier we mostly referring to needing to essentially put a bunch of conditionals in to keep being broken for Ocata compute hosts migrating to Pike compute hosts. | 16:48 |
| cdent | So sounds like you have some kind of plan. That’s great. As before, if there’s something I can do, let me know. | 16:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Accept any scheduler driver entrypoint https://review.openstack.org/484828 | 16:50 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Refactor get_endpoint_data to accept service_type https://review.openstack.org/489666 | 16:50 |
| *** randomhack has joined #openstack-nova | 16:50 | |
| jaypipes | cdent: will do. | 16:50 |
| *** bks has joined #openstack-nova | 16:56 | |
| bks | Hi all, i wanted to run a clou-init script in centos 6.6 os to change the root password, can someone please pass me the cloud-init to do it. Thanks | 16:56 |
| *** slaweq has quit IRC | 16:56 | |
| cfriesen_ | in Newton would we expect a deleted instance (which is in the "instances" table) to always have an entry in instance_extra? | 16:56 |
| bks | and is used_data option is used in the nova create server api to pass the cloud-init? | 16:56 |
| bks | can someone please help me here | 16:57 |
| cfriesen_ | bks: your question should probably be asked on #openstack | 16:58 |
| *** cfriesen_ is now known as cfriesen | 16:58 | |
| *** pcaruana has quit IRC | 16:58 | |
| *** randomhack has quit IRC | 16:58 | |
| *** lpetrut has quit IRC | 16:59 | |
| *** jistr is now known as jistr|afk | 17:00 | |
| bks | @cfriesen_ i asked there too, no response | 17:00 |
| *** baoli has quit IRC | 17:00 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add ``HostPortProfileInfo`` class https://review.openstack.org/441590 | 17:00 |
| *** lyan has joined #openstack-nova | 17:01 | |
| mriedem | yes user_data is passed through to cloud-init | 17:02 |
| cfriesen | bks: many of the nova folks are busy with release-critical stuff. have you looked at: http://blog.scottlowe.org/2015/11/09/changing-passwords-cloud-init/ | 17:02 |
| *** ralonsoh has quit IRC | 17:02 | |
| *** crushil has joined #openstack-nova | 17:03 | |
| *** hamzy has joined #openstack-nova | 17:03 | |
| bks | @cfriesen ohh sorry, iam trying the same script but couldnot get it worked | 17:05 |
| *** baoli has joined #openstack-nova | 17:05 | |
| bks | @cfriesen the userdata option in createserver is used to pass the cloud-init? | 17:05 |
| bks | as mentioned in the https://developer.openstack.org/api-ref/compute/#create-server | 17:06 |
| mriedem | https://github.com/openstack/openstack-manuals/blob/stable/ocata/doc/user-guide/source/cli-config-drive.rst | 17:06 |
| *** slaweq has joined #openstack-nova | 17:07 | |
| *** efoley has quit IRC | 17:07 | |
| * dansmith wonders if he should change the /topic in this channel | 17:08 | |
| cburgess | Because.....? | 17:08 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Adopt new pypowervm power_off APIs https://review.openstack.org/476945 | 17:10 |
| *** baoli has quit IRC | 17:11 | |
| *** lpetrut has joined #openstack-nova | 17:11 | |
| *** stewie925 has left #openstack-nova | 17:13 | |
| *** dtantsur is now known as dtantsur|afk | 17:13 | |
| *** baoli has joined #openstack-nova | 17:15 | |
| *** kbaegis has joined #openstack-nova | 17:17 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 17:20 |
| *** randomhack has joined #openstack-nova | 17:21 | |
| *** bks has left #openstack-nova | 17:22 | |
| *** sambetts is now known as sambetts|afk | 17:24 | |
| *** randomhack has quit IRC | 17:26 | |
| *** ragasthya has quit IRC | 17:34 | |
| *** kristia__ has quit IRC | 17:38 | |
| *** kristian__ has joined #openstack-nova | 17:39 | |
| *** lucasxu has quit IRC | 17:41 | |
| *** gyee has joined #openstack-nova | 17:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: See if we can squash ComputeHostNotFound_Remote on startup https://review.openstack.org/489683 | 17:42 |
| mriedem | dansmith: ^ destroys unit tests for the objects b/c of the fake indirection api, but is that something that's even possible? ^ | 17:42 |
| mriedem | i want to get rid of these http://logs.openstack.org/54/487954/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4412f5d/logs/screen-n-cpu.txt.gz?level=TRACE#_Jul_28_19_41_38_466972 | 17:43 |
| *** yamahata has quit IRC | 17:43 | |
| *** liverpooler has quit IRC | 17:43 | |
| dansmith | mriedem: no because those aren't actually the rpc calls | 17:43 |
| *** kristian__ has quit IRC | 17:43 | |
| cdent | Is stephenfin around this week, I sense his absence | 17:43 |
| dansmith | well, I'm guessing that won't work because ^ | 17:43 |
| mriedem | cdent: i'm told he's back tomorrow | 17:43 |
| cdent | thanks mriedem | 17:44 |
| dansmith | mriedem: that line you quote is intentional log.warning in the libvirt driver | 17:45 |
| dansmith | mriedem: and it looks like we're getting a stack trace automagically from the logging layer (?) | 17:46 |
| mriedem | i know, but the trace is coming from oslo.messaging isn't it? | 17:46 |
| dansmith | no I don't think so | 17:46 |
| dansmith | mriedem: see the line below.. you need exc_info=False maybe ? | 17:47 |
| dansmith | maybe a default changed somehow? | 17:47 |
| dansmith | oh | 17:47 |
| dansmith | ooooh | 17:47 |
| dansmith | you're hitting the lower one | 17:47 |
| dansmith | with exc_info=True | 17:47 |
| dansmith | because it is _Remote | 17:47 |
| mriedem | dansmith: yeah there is that, | 17:47 |
| dansmith | so maybe in that handler, check the exception name and if it looks remoteish then you can not pass the exc_info flag? | 17:47 |
| mriedem | but that doesn't explain this one http://logs.openstack.org/54/487954/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/4412f5d/logs/screen-n-cpu.txt.gz?level=TRACE#_Jul_28_19_41_40_927881 | 17:47 |
| dansmith | it's a little icky | 17:47 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6624 | 17:48 |
| mriedem | oh well, | 17:48 |
| mriedem | maybe we don't hit that code b/c of the same thing? | 17:48 |
| *** rajathagasthya has joined #openstack-nova | 17:48 | |
| dansmith | well, you log that message, so it seems like you are | 17:49 |
| dansmith | not sure why you get a trace there then | 17:49 |
| mriedem | but where does the traceback come from? | 17:49 |
| mriedem | right | 17:49 |
| dansmith | unless a default has changed and oslo now logs a trace if you're in exception context | 17:50 |
| dansmith | boy that sure is ugly | 17:51 |
| mriedem | been this way since ocata | 17:51 |
| trinaths | hi, I'm hitting this error, when i start nova-compute, http://paste.openstack.org/show/617156/ | 17:52 |
| openstackgerrit | Sumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors https://review.openstack.org/459794 | 17:52 |
| trinaths | please help me resolve the same. | 17:52 |
| *** slaweq has quit IRC | 17:56 | |
| *** slaweq has joined #openstack-nova | 17:57 | |
| *** gszasz has quit IRC | 17:57 | |
| *** crushil has quit IRC | 17:57 | |
| *** links has quit IRC | 17:57 | |
| *** crushil has joined #openstack-nova | 17:58 | |
| sdague | mriedem: actually, looking at sfinucan's split up of docs, I'm really not convinced that https://review.openstack.org/#/c/478485/ is a good move | 17:58 |
| *** baoli has quit IRC | 17:59 | |
| *** Apoorva_ has joined #openstack-nova | 17:59 | |
| *** penick has quit IRC | 17:59 | |
| *** baoli has joined #openstack-nova | 18:00 | |
| mriedem | sdague: ... i said it was a massive change | 18:00 |
| mriedem | http://docs-draft.openstack.org/85/478485/16/check/gate-nova-docs-ubuntu-xenial/481415d//doc/build/html/ | 18:00 |
| *** baoli has quit IRC | 18:00 | |
| mriedem | compared to how things used to be https://docs.openstack.org/nova/ocata/ | 18:00 |
| sdague | mriedem: yeh | 18:00 |
| mriedem | i can't even really review it | 18:00 |
| *** Apoorva_ has quit IRC | 18:00 | |
| mriedem | asettle is also working on that patch | 18:00 |
| sdague | honestly, I mostly want to light docs like that on fire | 18:00 |
| *** baoli has joined #openstack-nova | 18:01 | |
| *** Apoorva has quit IRC | 18:01 | |
| *** Apoorva_ has joined #openstack-nova | 18:01 | |
| sdague | because you have to know what you are looking for before you can find what you are looking for | 18:01 |
| *** slaweq has quit IRC | 18:01 | |
| *** slaweq has joined #openstack-nova | 18:01 | |
| mriedem | wait which thing do you want to light on fire? | 18:01 |
| *** markvoelker has quit IRC | 18:02 | |
| *** penick has joined #openstack-nova | 18:02 | |
| sdague | spliting up the process doc into 6 process docs | 18:02 |
| *** markvoelker has joined #openstack-nova | 18:02 | |
| sdague | http://docs-draft.openstack.org/85/478485/16/check/gate-nova-docs-ubuntu-xenial/481415d//doc/build/html/contributor/process.html | 18:02 |
| *** lucasxu has joined #openstack-nova | 18:02 | |
| *** lucasxu has quit IRC | 18:02 | |
| mriedem | compared to https://docs.openstack.org/nova/ocata/process.html ? | 18:03 |
| sdague | yes | 18:03 |
| mriedem | idk if this is meant to be consistent with other projects, but it's not consistent with cinder's home page now | 18:06 |
| mriedem | https://docs.openstack.org/cinder/latest/ | 18:06 |
| mriedem | or glance https://docs.openstack.org/glance/latest/ | 18:06 |
| *** itlinux has quit IRC | 18:06 | |
| *** ijw has joined #openstack-nova | 18:07 | |
| *** ijw has quit IRC | 18:07 | |
| *** ijw has joined #openstack-nova | 18:07 | |
| *** kristian__ has joined #openstack-nova | 18:09 | |
| *** slagle has quit IRC | 18:09 | |
| *** kristian__ has quit IRC | 18:09 | |
| *** kristian__ has joined #openstack-nova | 18:09 | |
| *** slagle has joined #openstack-nova | 18:11 | |
| sdague | it would be nice to figure out how we get in page toc into the sidebar instead of top of page | 18:13 |
| mriedem | yes that's also been annoying me | 18:13 |
| *** EmilienM is now known as emacchi | 18:14 | |
| sdague | dhellman might know | 18:14 |
| *** emacchi is now known as EmilienM | 18:14 | |
| sdague | looks like glance does it | 18:14 |
| *** trinaths has left #openstack-nova | 18:16 | |
| mriedem | sdague: any idea how we figure out which log formatter/handler we're using in a devstack run? | 18:16 |
| mriedem | like, are those configurable somewhere? | 18:17 |
| sdague | mriedem: ?? | 18:18 |
| mriedem | well there is a json formatter, and a context formatter | 18:18 |
| sdague | yes, we're using the context formatter | 18:18 |
| mriedem | and a color handler, and journal and syslog handler | 18:18 |
| mriedem | but how would someone know? | 18:18 |
| mriedem | config? | 18:18 |
| sdague | it's config, but I think those are the defaults | 18:19 |
| *** yamahata has joined #openstack-nova | 18:20 | |
| sdague | oh, you know what it is, it's actually python logging config | 18:20 |
| sdague | outside of our config | 18:20 |
| sdague | so use_syslog / use_journal will tweak those things | 18:21 |
| sdague | https://docs.openstack.org/oslo.log/latest/configuration/index.html | 18:21 |
| sdague | but on the formatter side it's all done as python logger setup | 18:21 |
| *** dtp has joined #openstack-nova | 18:22 | |
| mriedem | ok, because what i think we're seeing with a bunch of these random stacktraces related to ComputeHostNotFound_Remote is that we're logging with an exception context, | 18:23 |
| mriedem | and oslo.log is logging the traceback | 18:23 |
| mriedem | automagically | 18:23 |
| mriedem | https://www.youtube.com/watch?v=iExgnVXSAuE | 18:24 |
| mriedem | thanks oslo.log | 18:24 |
| *** slaweq has quit IRC | 18:25 | |
| mriedem | gonna push a patch to test that theory | 18:26 |
| *** slaweq has joined #openstack-nova | 18:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: See if we can squash ComputeHostNotFound_Remote on startup https://review.openstack.org/489683 | 18:27 |
| mriedem | sdague: dansmith: ^ is the canary | 18:27 |
| mriedem | i think it's something to do with this: https://github.com/openstack/oslo.log/blob/3.30.0/oslo_log/formatters.py#L144 | 18:29 |
| *** slaweq has quit IRC | 18:29 | |
| *** slaweq has joined #openstack-nova | 18:30 | |
| *** egonzalez has joined #openstack-nova | 18:30 | |
| *** slaweq has quit IRC | 18:31 | |
| *** annegentle has quit IRC | 18:33 | |
| *** itlinux has joined #openstack-nova | 18:34 | |
| *** jistr|afk is now known as jistr | 18:34 | |
| *** slaweq has joined #openstack-nova | 18:35 | |
| *** itlinux has quit IRC | 18:36 | |
| openstackgerrit | Merged openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | 18:36 |
| mriedem | yay ^ | 18:36 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 18:37 |
| *** ijw has quit IRC | 18:39 | |
| *** slaweq has quit IRC | 18:40 | |
| *** ijw has joined #openstack-nova | 18:46 | |
| *** dtp is now known as dtp-afk | 18:49 | |
| *** yushb has joined #openstack-nova | 18:50 | |
| jaypipes | gibi: where do I change the notification sample test JSON files? | 18:54 |
| *** yushb has quit IRC | 18:54 | |
| jaypipes | gibi: nm, found it. | 18:54 |
| *** pchavva has quit IRC | 18:55 | |
| *** kristian__ has quit IRC | 18:57 | |
| *** adisky__ has quit IRC | 18:58 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | 19:02 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | 19:02 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Additional assertions to resize tests https://review.openstack.org/489714 | 19:02 |
| *** randomhack has joined #openstack-nova | 19:02 | |
| *** penick has quit IRC | 19:02 | |
| melwitt | this is a bug fix (data corruption possible) I think we'll need for rc1, if anyone can review please https://review.openstack.org/#/c/488545/ | 19:05 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 19:07 |
| *** kbaegis has quit IRC | 19:08 | |
| *** _pewp_ has quit IRC | 19:09 | |
| *** _pewp_ has joined #openstack-nova | 19:12 | |
| *** ijw has quit IRC | 19:12 | |
| *** penick has joined #openstack-nova | 19:13 | |
| *** annegentle has joined #openstack-nova | 19:17 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: nova.utils.get_endpoint_data() https://review.openstack.org/488137 | 19:22 |
| mriedem | melwitt: question in there | 19:23 |
| mriedem | the persistent vs live stuff always confuses me | 19:23 |
| * melwitt looks | 19:23 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup unnecessary logic in os-volume_attachments controller code https://review.openstack.org/485823 | 19:25 |
| cfriesen | mriedem: isn't "persisten" whether there is a persistent domain (unrelated to the device)? | 19:25 |
| melwitt | mriedem: I'm not sure I understand the question. in my comment I tried to say "if DeviceNotFound was raised when we passed persistent=True, that means it wasn't found, so we should continue on to try a live detach". though I do notice I should have used "if persistent and live" | 19:26 |
| melwitt | because if live isn't True then there's no need to continue | 19:26 |
| mriedem | well there you go | 19:26 |
| melwitt | is that what you were pointing out? sorry :) | 19:27 |
| mriedem | no | 19:27 |
| mriedem | i just wanted to ask a question to sound like i know 2 sh*ts about this code before +2ing it | 19:27 |
| mriedem | <- professional | 19:27 |
| melwitt | cfriesen: yeah, from what I understand there's effectively two copies of the VM config. one is "persistent" to affect upon next boot and the other is "live" which affects only the live VM | 19:28 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 19:28 |
| cdent | jmlowe: I’m going to break the bourbon pattern to give you some early for the good advice of the day award | 19:28 |
| mriedem | melwitt: the comment makes more sense now | 19:28 |
| melwitt | so if the VM even has a persistent config, you have to detach the device from both configs to make sure the device is detached live and also won't show up again after a reboot | 19:29 |
| melwitt | it's confusing | 19:29 |
| mriedem | melwitt: that would be good doc to put in that code | 19:29 |
| melwitt | will do | 19:29 |
| cfriesen | melwitt: so we try first calling detach_device() with both persistant and live but libvirt raises an exception since it doesn't find it in the persistent config? | 19:31 |
| *** baoli has quit IRC | 19:31 | |
| *** acormier_ has quit IRC | 19:31 | |
| mriedem | so the bug is we tried to detach from persistent config and it wasn't there, so we gave up, but it was in the live config, and then the user reboots the guest and now the volume is attached to both? | 19:31 |
| cfriesen | melwitt: so we have to retry just the live detach without the persistant | 19:32 |
| jmlowe | cdent: what advise was that? "never shit in your hat" "money talks and bullshit walks" "shit in one hand wish in the other and see which one fills up first" | 19:32 |
| *** acormier has joined #openstack-nova | 19:32 | |
| melwitt | cfriesen: right. this can happen in the scenario where the guest is busy (e.g. file open) and the guest ignores the ACPI request to detach from live. so what happens there is the detach from the persistent config succeeds but the live fails and so the overall detach fails | 19:32 |
| mriedem | can qemu / libvirt just add a "seriously_please_detach_this_thing_at_some_point" API? | 19:32 |
| jmlowe | cdent: it appears that most of my advise is scatological in nature | 19:33 |
| cdent | jmlowe: ceph your glance and your disk | 19:33 |
| cfriesen | melwitt: I take it libvirt chokes if you specify both VIR_DOMAIN_AFFECT_CONFIG and VIR_DOMAIN_AFFECT_LIVE and it's not in the persistant? | 19:33 |
| melwitt | cfriesen: later on, if the guest is all done and the file is closed, the user wants to detach the volume again, they will issue the detach command and we'll need to detach it from only the live config bc it's already gone from the persistent config | 19:33 |
| cdent | which may be scat | 19:33 |
| melwitt | cfriesen: tes | 19:33 |
| *** peter-hamilton has joined #openstack-nova | 19:33 | |
| melwitt | *yes | 19:33 |
| *** peter-hamilton has quit IRC | 19:33 | |
| melwitt | libvirt will raise a "no device found" type error due to the AFFECT_CONFIG flag | 19:33 |
| *** acormier has quit IRC | 19:33 | |
| *** acormier has joined #openstack-nova | 19:34 | |
| *** acormier has quit IRC | 19:34 | |
| *** kbaegis has joined #openstack-nova | 19:34 | |
| *** peter-hamilton has joined #openstack-nova | 19:34 | |
| cfriesen | melwitt: almost seems safer to just handle persistent and live separately rather than trying to do them both and have to clean up if it fails | 19:34 |
| *** acormier has joined #openstack-nova | 19:34 | |
| *** acormier has quit IRC | 19:34 | |
| cfriesen | but I suppose it's probably more efficient to do them both at the same time | 19:34 |
| jmlowe | cdent: I do what I can, I was practically frothing at the mouth to go from Liberty to Mitaka just for the ceph glance nova stuff | 19:34 |
| *** itlinux has joined #openstack-nova | 19:35 | |
| *** acormier has joined #openstack-nova | 19:35 | |
| melwitt | cfriesen: yeah, I have wondered similar. in a normal scenario you'd only need one call to do the whole thing | 19:35 |
| *** rcernin has quit IRC | 19:36 | |
| *** slaweq has joined #openstack-nova | 19:36 | |
| cfriesen | melwitt: looks okay to me with the caveat of adding that check for "live" | 19:37 |
| melwitt | cfriesen: cool, thanks. I'm working on adding that and beefing up the test to match | 19:37 |
| melwitt | and adding more code comments | 19:37 |
| *** baoli has joined #openstack-nova | 19:38 | |
| cfriesen | seems like we could have run into problems with the second call currently if live was false | 19:38 |
| melwitt | yeah, possibly. I'm not sure what it does if you pass no flags, maybe a no-op one would hope | 19:39 |
| *** acormier has quit IRC | 19:39 | |
| * melwitt looks | 19:39 | |
| *** slaweq has quit IRC | 19:41 | |
| melwitt | okay, 0 is VIR_DOMAIN_AFFECT_CURRENT=0 | 19:42 |
| melwitt | Affect current domain state. so it would do something, hopefully raising one of the "not found" we handle and then it would bubble up to compute which would ignore it | 19:42 |
| mriedem | jaypipes: want to -2 this so someone doesn't get confused it's not for pike? https://review.openstack.org/#/c/488595/ | 19:43 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: update policy UT fixtures https://review.openstack.org/398610 | 19:44 |
| *** nicolasbock has quit IRC | 19:45 | |
| *** dtp-afk is now known as dtp | 19:46 | |
| *** randomhack has quit IRC | 19:47 | |
| cfriesen | melwitt: looks like libvirt virDomainDetachDeviceFlags() will error if "flags" is not set. | 19:47 |
| cfriesen | based on a quick check of the code | 19:47 |
| mriedem | dims: i'm beating my head against some weird traceback logging we're seeing but don't know where the traceback is actually coming from https://review.openstack.org/#/c/489683/2 | 19:47 |
| mriedem | dims: i assume it's something in oslo | 19:48 |
| melwitt | cfriesen: okay. well, we'd pass 0 for flags if neither persistent nor live, and I thought 0 was a valid flag | 19:48 |
| *** penick has quit IRC | 19:49 | |
| cfriesen | melwitt: wait, I think I misread. | 19:49 |
| cfriesen | oops | 19:50 |
| cfriesen | was looking at the function pointer, not the variable | 19:50 |
| *** penick has joined #openstack-nova | 19:50 | |
| *** acormier has joined #openstack-nova | 19:51 | |
| *** acormier has quit IRC | 19:52 | |
| *** acormier has joined #openstack-nova | 19:53 | |
| cfriesen | melwitt: the common code does not check for empty flags, but passes it on down to the specific sub-driver (ie the qemu one). | 19:54 |
| *** itlinux has quit IRC | 19:54 | |
| *** eharney has quit IRC | 19:56 | |
| *** acormier has quit IRC | 19:57 | |
| *** priteau has quit IRC | 20:01 | |
| *** penick has quit IRC | 20:01 | |
| cfriesen | melwitt: based on virDomainObjUpdateModificationImpact() it looks like if flags is empty it will set either VIR_DOMAIN_AFFECT_LIVE or VIR_DOMAIN_AFFECT_CONFIG based on whether or not the domain is currently active | 20:01 |
| melwitt | cfriesen: ah, cool. so that's what they mean by VIR_DOMAIN_AFFECT_CURRENT (which is 0) | 20:02 |
| cfriesen | yes | 20:02 |
| *** eharney has joined #openstack-nova | 20:11 | |
| *** awaugama has quit IRC | 20:12 | |
| *** kbaegis has quit IRC | 20:14 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Detach device from live domain even if not found on persistent https://review.openstack.org/488545 | 20:18 |
| cdent | mriedem: if you’re in a docs way here’s a bit of placement docs: https://review.openstack.org/#/c/469048/ | 20:20 |
| *** mtanino has joined #openstack-nova | 20:22 | |
| *** karthiks has quit IRC | 20:23 | |
| *** karthiks has joined #openstack-nova | 20:23 | |
| mriedem | ack | 20:23 |
| mriedem | dansmith: whilst reviewing your cells v2 topology docaroo, i realized we could/should disable CONF.filter_scheduler.track_instance_changes in the superconductor mode for devstack, | 20:24 |
| mriedem | since the computes are basically rpc casting into the ether | 20:24 |
| dansmith | ah yeah | 20:24 |
| sdague | speaking of docs, if anyone wants to fix a whole lot of our 404s... https://review.openstack.org/#/c/489650/ one more +2 | 20:25 |
| mriedem | so i'm +2 on the doc https://review.openstack.org/#/c/487183/ but what did you have in mind for documenting the upcall limitations? | 20:25 |
| *** jackie-truong has joined #openstack-nova | 20:25 | |
| dansmith | mriedem: I can throw those into the bottom set of things if you want | 20:26 |
| mriedem | ok, i mentioned them in ps5 to go in there, but you didn't add them so i didn't know what you had planned | 20:27 |
| *** slaweq has joined #openstack-nova | 20:27 | |
| dansmith | unintentional | 20:29 |
| *** baoli has quit IRC | 20:29 | |
| *** crushil has quit IRC | 20:29 | |
| jackie-truong | dansmith: Do you have a few minutes? I have another question related to https://review.openstack.org/#/c/457711 | 20:30 |
| dansmith | jackie-truong: okay, since that's not release-related it's not very high priority, but.. go ahead and ask | 20:31 |
| jackie-truong | dansmith: Got it. We want the trusted_certs column to store lists of UUIDs | 20:32 |
| jackie-truong | dansmith: On L31 of 363_add_trusted_certs.py, we're trying to store an sqlalchemy ARRAY of Strings | 20:32 |
| jackie-truong | dansmith: I don't think that that's the best way to go about that, but unsure if you all of seen a similar need? | 20:33 |
| dansmith | jackie-truong: yeah I have no idea what that would look like in the sql | 20:33 |
| dansmith | huh arrays in sql | 20:34 |
| *** lpetrut has quit IRC | 20:35 | |
| dansmith | that's new to me, but I'm fairly certain that that's not the way to do this | 20:35 |
| *** itlinux has joined #openstack-nova | 20:35 | |
| *** gbarros has quit IRC | 20:35 | |
| dansmith | jackie-truong: everywhere else that we store multiples of things, they're either as rows, related to the instance table, if we need to be able to query them (and if there will be lots) | 20:35 |
| dansmith | the instance_extra table is specifically 1:1 to instances, and is just TEXT columns, where we store json blobs | 20:36 |
| dansmith | can't query on the contents (easily), but if you just need to store a list of a few strings, then that's the place, | 20:36 |
| dansmith | but ideally you'd store an object in there so it's versioned instead of just some complex unversioned wild-west structure of stuff | 20:36 |
| *** sree_ has joined #openstack-nova | 20:37 | |
| *** sree_ is now known as Guest16991 | 20:37 | |
| *** crushil has joined #openstack-nova | 20:37 | |
| *** baoli has joined #openstack-nova | 20:38 | |
| *** cleong has quit IRC | 20:39 | |
| jackie-truong | dansmith: Hmm we just need to be able to store and access the list of strings. If the trusted_certs column is a TEXT column, then the Instance object should be able to retrieve the list with something like L412 in https://review.openstack.org/#/c/489408/1/nova/objects/instance.py ? | 20:39 |
| dansmith | jackie-truong: no, because the field is a list and the column (if TEXT) is a string | 20:41 |
| *** Guest16991 has quit IRC | 20:41 | |
| dansmith | you have to serialize and deserialize the contents there somehow | 20:41 |
| jackie-truong | Okay, that's where I was having the disconnect | 20:41 |
| mriedem | more like https://review.openstack.org/#/c/489408/1/nova/objects/instance.py@982 | 20:41 |
| *** jmlowe has quit IRC | 20:42 | |
| mriedem | dansmith: ok here is the track_instance_changes thing for devstack https://review.openstack.org/489742 | 20:42 |
| mriedem | i need to dig a bit into how the scheduler keeps up to date with what's in the compute node for the affinity filters if that's disabled | 20:42 |
| jackie-truong | Thanks, @mriedem | 20:43 |
| *** ijw has joined #openstack-nova | 20:43 | |
| jackie-truong | It would probably make most sense to go ahead and create a TrustedCerts object and corresponding TrustedCertsList | 20:44 |
| jackie-truong | s/TrustedCerts object and corresponding TrustedCertsList/TrustedCert object and corresponding TrustedCertList | 20:44 |
| dansmith | no need for the list object | 20:44 |
| dansmith | the list objects we have are mostly syntactic sugar for remotable query methods | 20:45 |
| jackie-truong | So a single TrustedCerts object that stores the list of strings | 20:45 |
| jackie-truong | got it | 20:45 |
| jackie-truong | Cool, that gives me some better direction. Thanks! | 20:45 |
| *** jackie-truong has quit IRC | 20:48 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 20:52 |
| mriedem | hilarious | 20:52 |
| mriedem | policies body array A list of exactly one policy name to associate with the server group. The current valid policy names are: | 20:52 |
| mriedem | a list of exactly one | 20:52 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711 | 20:53 |
| dfisher | ok, so, to continue the adventure of the flammable Oracle engineer … http://paste.openstack.org/show/617175/ … Something is clearly not implemented but I don't know what it is :( | 20:53 |
| mriedem | get_inventory() method in your compute driver? | 20:54 |
| dfisher | E486: Pattern not found: get_inventory | 20:54 |
| dfisher | well! | 20:54 |
| dfisher | thank you | 20:54 |
| mriedem | where that shows up is very wonky | 20:55 |
| mriedem | in the logs in that paste i mean | 20:55 |
| mriedem | get_inventory is optional | 20:55 |
| dfisher | ok. | 20:56 |
| dfisher | hmm. | 20:56 |
| dfisher | let me see if I can implement it real quick and see what happens. | 20:57 |
| *** abalutoiu has quit IRC | 21:02 | |
| *** imacdonn has quit IRC | 21:08 | |
| *** imacdonn has joined #openstack-nova | 21:08 | |
| *** marst has quit IRC | 21:09 | |
| *** penick has joined #openstack-nova | 21:10 | |
| *** baoli has quit IRC | 21:13 | |
| *** baoli has joined #openstack-nova | 21:13 | |
| *** vladikr_ has quit IRC | 21:15 | |
| *** awaugama has joined #openstack-nova | 21:16 | |
| *** yamamoto has joined #openstack-nova | 21:17 | |
| *** baoli has quit IRC | 21:19 | |
| *** yamamoto has quit IRC | 21:21 | |
| *** yamamoto has joined #openstack-nova | 21:21 | |
| mriedem | dansmith: jaypipes: looks like tempest wasn't testing anti-affinity before https://review.openstack.org/489754 | 21:22 |
| mriedem | it was testing the different_hosts stuff | 21:23 |
| dansmith | so that'll fail in our current multinode setup right? | 21:24 |
| mriedem | that's what i'm trying to test | 21:24 |
| dansmith | well, it'll be flaky I think | 21:24 |
| mriedem | b/c we don't have the upcall? | 21:25 |
| dansmith | yeah | 21:25 |
| dansmith | well, | 21:25 |
| dansmith | hmm | 21:25 |
| mriedem | does that scenario rely on rebuilds? | 21:25 |
| dansmith | no | 21:25 |
| dansmith | it requires scheduler races | 21:26 |
| *** yamamoto has quit IRC | 21:26 | |
| mriedem | i think it should just say server 1 is going on host A and when the filter scheduler processes server 2, it should put it on host B because we're tracking server1 on A in the HostState | 21:26 |
| mriedem | i'm really just trying to make sure the HostState stuff doesn't explode w/o the upcalls | 21:26 |
| *** eharney has quit IRC | 21:27 | |
| dansmith | right, but your test may validate that without enough parallelism the right thing happens early on | 21:27 |
| dansmith | which I guess is what you're going for, | 21:27 |
| *** dave-mccowan has quit IRC | 21:27 | |
| dansmith | but it doesn't prove that the upcall is working (especially since it won't even be done currently) | 21:28 |
| mriedem | yeah not trying to prove the upcall | 21:28 |
| mriedem | just trying to make sure the basic scenario through the filter works properly | 21:28 |
| mriedem | i think people have tried to add a test for this in tempest in the past and it's been shot down because it could be done in nova functional tests, but i worry about how much we actually stub out in the functional stuff | 21:29 |
| dansmith | I guess I'm not sure how the filter really works so I can't say if it'll be likely to fail | 21:29 |
| dansmith | yeah | 21:29 |
| mikal | Morning | 21:29 |
| *** cjvolzka has quit IRC | 21:29 | |
| cfriesen | was there an official notification email that the Sydney presentation voting was open? I don't remember seeing one. | 21:29 |
| *** acormier has joined #openstack-nova | 21:30 | |
| mriedem | i don't remember seeing one, but i don't vote either | 21:30 |
| mriedem | i'm only one person, | 21:30 |
| mriedem | my vote doesn't count | 21:30 |
| *** cjvolzka has joined #openstack-nova | 21:30 | |
| *** cjvolzka has quit IRC | 21:31 | |
| cdent | cfriesen: I’ve seen a few different announcements, but I’m not sure on which lists | 21:32 |
| cdent | and there were some “we’ve extended voiting” announcements too | 21:33 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Handle addition of new nodes/instances in ironic flavor migration https://review.openstack.org/487954 | 21:33 |
| melwitt | I can't find a link to the voting other than the one that cisco person sent out | 21:36 |
| melwitt | (can't find in email I mean) | 21:36 |
| *** egonzalez has quit IRC | 21:37 | |
| mriedem | edleafe: i think i'm going to make us run E128 just for you https://review.openstack.org/#/c/487925/2/nova/virt/ironic/driver.py | 21:38 |
| *** smatzek has quit IRC | 21:42 | |
| cdent | melwitt, cfriesen: I’m on a _lot_ of lists, so may not have been os-dev | 21:43 |
| melwitt | I found one email to os-dev but it had no link to voting :P | 21:44 |
| melwitt | vote ... somewhere ... that you should find by googling | 21:44 |
| edleafe | mriedem: I'm consistent :) | 21:45 |
| *** crushil has quit IRC | 21:48 | |
| *** crushil has joined #openstack-nova | 21:49 | |
| *** ijw has quit IRC | 21:52 | |
| *** kbaegis has joined #openstack-nova | 21:53 | |
| cfriesen | mriedem: for https://review.openstack.org/#/c/339715 would you be okay with me updating the "stale" migration to a "failed" or "error" state when we detect it? Or just check for them at nova-compute startup and assume they can't happen during "normal" running? | 21:54 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 21:57 |
| jaypipes | mriedem: marked that one patch -2. | 21:58 |
| *** esberglu has quit IRC | 21:58 | |
| cdent | mriedem: does https://bugs.launchpad.net/nova/+bug/1708031 need an owner? If so, I can take it. Do we need the report client to be happy with both the old and new messages? Or just new? I’m guessing both. | 22:00 |
| openstack | Launchpad bug 1708031 in OpenStack Compute (nova) ""Failed to delete inventory for resource provider" error messages for predictable 409 cases" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem) | 22:00 |
| *** burt has quit IRC | 22:00 | |
| cdent | mriedem: nm, you assigned it to yourself while I was reading it | 22:01 |
| *** burt has joined #openstack-nova | 22:01 | |
| *** smatzek has joined #openstack-nova | 22:01 | |
| *** burt has quit IRC | 22:01 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix 409 handling in report client when deleting inventory https://review.openstack.org/489763 | 22:01 |
| mriedem | cdent: ^ | 22:01 |
| *** kbaegis has quit IRC | 22:01 | |
| * cdent looks | 22:01 | |
| *** smatzek_ has joined #openstack-nova | 22:02 | |
| *** slaweq has quit IRC | 22:03 | |
| *** slaweq has joined #openstack-nova | 22:03 | |
| *** penick has quit IRC | 22:03 | |
| *** mikal has quit IRC | 22:04 | |
| *** thorst_afk has quit IRC | 22:05 | |
| *** mikal has joined #openstack-nova | 22:06 | |
| *** annegentle has quit IRC | 22:06 | |
| *** smatzek has quit IRC | 22:06 | |
| *** penick has joined #openstack-nova | 22:07 | |
| cdent | mriedem: has ironic been spewing these errors since early june? | 22:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438 | 22:08 |
| openstackgerrit | Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | 22:08 |
| *** slaweq has quit IRC | 22:08 | |
| zzzeek | jaypipes: there? | 22:08 |
| mriedem | cdent: probably | 22:08 |
| mriedem | cdent: i only check the ironic ci job logs for ironic related chagnes | 22:08 |
| cdent | mriedem: my real question: how come this didn’t break stuff ? | 22:08 |
| mriedem | *changes | 22:08 |
| * cdent makes a related reminder bug | 22:09 | |
| zzzeek | mriedem: does nova get DB connection URLs from anywhere other than /etc/nova/nova.conf ? | 22:09 |
| mriedem | zzzeek: yes | 22:10 |
| mriedem | from the db for the cell mappings | 22:10 |
| zzzeek | mriedem: in the DB ! | 22:10 |
| mriedem | nova_api.cell_mappings table | 22:10 |
| zzzeek | mriedem: omg. | 22:10 |
| zzzeek | mriedem: so. once you deploy nova, you can never change the ip number of the database ?? | 22:10 |
| zzzeek | ip number gets written into the DB itself ? | 22:10 |
| mriedem | it's whatever is put in when creating the cell mapping | 22:11 |
| melwitt | you can update the cell mapping | 22:11 |
| melwitt | via nova-manage | 22:11 |
| melwitt | if you need to change it | 22:11 |
| zzzeek | melwitt: you can! did anyone consider maybe looking in the nova.conf file and seeing, oh hey they moved their DB server | 22:11 |
| zzzeek | wow. | 22:12 |
| zzzeek | nova. heh. | 22:12 |
| zzzeek | OK | 22:12 |
| *** kylek3h has quit IRC | 22:12 | |
| *** esberglu has joined #openstack-nova | 22:12 | |
| mriedem | your volume connection info to a ceph server is also stored in a json blob in the db, so if your ceph server ip changes you have similar problems | 22:12 |
| mriedem | per instance | 22:12 |
| mriedem | so you have to migrate or reboot the instance | 22:12 |
| *** colby_ has joined #openstack-nova | 22:13 | |
| zzzeek | WOW. OK wait, this actually destroys waht I want to do. wow | 22:13 |
| *** kylek3h has joined #openstack-nova | 22:13 | |
| *** kylek3h has quit IRC | 22:13 | |
| *** acormier has quit IRC | 22:13 | |
| mriedem | http://lists.openstack.org/pipermail/openstack-operators/2017-June/013700.html | 22:13 |
| *** acormier has joined #openstack-nova | 22:14 | |
| zzzeek | mriedem: im just looking at mysql urls | 22:14 |
| colby_ | Hey Everyone I asked in the support channel but no one seemed to have an answer. We upgraded to newton and the flavor and aggregate migration scripts fail to cpoy the data to the nova_api tables. It appears that sqlalchecmy is adding the timezone offset to the DATETIME field and its complaining about incorrect format. Here is an example of the error: | 22:15 |
| colby_ | Incorrect datetime value: '2015-02-17 22:37:06+00:00' for column 'created_at' | 22:15 |
| zzzeek | mriedem: so confirm, it is completely impossible to have a scenario where a nova server on a particular controller had its own MySQL URL distinct from that of other contrlers, because they are pulled from the database and do not distinguish between the source | 22:15 |
| colby_ | we use Mariadb 10.0.21 | 22:16 |
| dansmith | zzzeek: I don't know what you mean by "between the source" but yes, all the control services find the cell databases by looking in the api database | 22:17 |
| zzzeek | dansmith: OK | 22:17 |
| *** esberglu has quit IRC | 22:17 | |
| melwitt | each controller has to know how to connect to each of N cell databases, that's why they're in the database, there are multiple DB URLs we need to be able to connect to | 22:18 |
| *** acormier has quit IRC | 22:18 | |
| *** thorst_afk has joined #openstack-nova | 22:19 | |
| *** smatzek_ has quit IRC | 22:20 | |
| mriedem | melwitt: +2 on your detach shenanigans | 22:22 |
| *** yamamoto has joined #openstack-nova | 22:23 | |
| *** esberglu has joined #openstack-nova | 22:23 | |
| melwitt | \o/ | 22:23 |
| *** ijw has joined #openstack-nova | 22:23 | |
| *** catintheroof has quit IRC | 22:23 | |
| *** thorst_afk has quit IRC | 22:24 | |
| *** yamamoto has quit IRC | 22:25 | |
| *** yamamoto has joined #openstack-nova | 22:25 | |
| melwitt | mriedem: do you want me to move the comment inside the conditional? I can do that quick if you want to re +2 | 22:25 |
| mriedem | meh | 22:25 |
| melwitt | haha, okay | 22:25 |
| mriedem | my ability to make any sort of decision right now is very low | 22:26 |
| * melwitt nods | 22:26 | |
| efried | morgan mordred sdague https://review.openstack.org/#/c/488137/ is passing tests with temporary patches to twiddle glance & ironic confs. | 22:27 |
| mordred | efried: woot! | 22:27 |
| efried | morgan mordred sdague And FYI, PS5 has the swizzle where you pass the service_type (rather than the conf_group/project_name) to the util. | 22:27 |
| efried | (which both sdague and morgan asked for) | 22:27 |
| morgan | nice | 22:27 |
| efried | Next stop: cinder! | 22:28 |
| mriedem | huh, we're actually failing grenade at a decent clip http://logs.openstack.org/54/489754/3/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/7e19ce3/logs/old/screen-n-cond.txt.gz#_2017-08-01_21_57_19_559 | 22:29 |
| mriedem | on the ocata side | 22:29 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 22:33 |
| cdent | mriedem: in muiltinode does one node stay ocata? is this before or after that? | 22:35 |
| *** sdague has quit IRC | 22:35 | |
| mordred | efried: a few suggestions inline | 22:36 |
| *** edmondsw has quit IRC | 22:36 | |
| *** smatzek_ has joined #openstack-nova | 22:36 | |
| mriedem | cdent: depends on the job config | 22:37 |
| mriedem | some keep n-cpu behind | 22:37 |
| mriedem | but yeah i think multinode grenade always keeps n-cpu behind as n-1 | 22:38 |
| mriedem | and upgrades everything else | 22:38 |
| mriedem | there used to be a single node grenade partial which upgraded everything except n-cpu | 22:38 |
| mriedem | multinode grenade has 1 upgraded n-cpu and one n-1 n-cpu | 22:38 |
| *** penick has quit IRC | 22:39 | |
| mriedem | so we can do things like live migrate between versions | 22:39 |
| zzzeek | mriedem: crisis averted thanks for the help | 22:39 |
| *** kbaegis has joined #openstack-nova | 22:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP Always use application/json accept header in report client https://review.openstack.org/489772 | 22:41 |
| mriedem | zzzeek: can you shed some light on what the crisis was? | 22:41 |
| zzzeek | mriedem: customer wants each controller accessing from its own source IP which is tied to a distinct password on the mysql server. because we use haproxy, that means each contorller must connect to a local haproxy, which means each controller has distinct database url | 22:43 |
| *** dave-mccowan has joined #openstack-nova | 22:43 | |
| *** annegentle has joined #openstack-nova | 22:45 | |
| *** itlinux has quit IRC | 22:49 | |
| *** smatzek_ has quit IRC | 22:49 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408 | 22:51 |
| *** lyan has quit IRC | 22:51 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 22:51 |
| *** https_GK1wmSU has joined #openstack-nova | 22:54 | |
| *** https_GK1wmSU has left #openstack-nova | 22:56 | |
| *** ijw has quit IRC | 22:58 | |
| dansmith | mriedem: people like that can just put the url in the database using an alias hostname, that they map per node in /etc/hosts | 22:58 |
| dansmith | mriedem: easy stuff | 22:58 |
| dansmith | mriedem: and it appears that they can also configure the creds in a mysql client config file that gets honored, so they can have separate creds too | 22:59 |
| dansmith | which is way better than us trying to pattern-format the url we get out of the db or something silly like that | 22:59 |
| *** dfisher has quit IRC | 23:00 | |
| mriedem | but can postgresql do that?! | 23:01 |
| * cdent slaps mriedem | 23:01 | |
| *** jmlowe has joined #openstack-nova | 23:02 | |
| *** jmlowe has quit IRC | 23:03 | |
| *** annegentle has quit IRC | 23:04 | |
| *** esberglu has quit IRC | 23:06 | |
| *** slaweq has joined #openstack-nova | 23:07 | |
| *** slaweq has quit IRC | 23:11 | |
| *** kbaegis has quit IRC | 23:12 | |
| *** esberglu has joined #openstack-nova | 23:12 | |
| *** kbaegis has joined #openstack-nova | 23:13 | |
| *** jmlowe has joined #openstack-nova | 23:16 | |
| *** chyka has quit IRC | 23:19 | |
| *** mtanino has quit IRC | 23:26 | |
| gmann | mriedem, re: API doc patches. not yet. i will push those today | 23:29 |
| *** hongbin has quit IRC | 23:30 | |
| *** jaypipes has quit IRC | 23:31 | |
| *** jamesden_ has joined #openstack-nova | 23:35 | |
| *** jamesdenton has quit IRC | 23:35 | |
| *** cjvolzka has joined #openstack-nova | 23:38 | |
| *** jamesden_ has quit IRC | 23:39 | |
| gmann | mriedem, can you restore this - https://review.openstack.org/#/c/489641/1 | 23:40 |
| gmann | api-microversion-history redirect is not done in https://review.openstack.org/#/c/489650/ | 23:40 |
| *** jamesdenton has joined #openstack-nova | 23:41 | |
| mriedem | gmann: that's weird | 23:42 |
| mriedem | done | 23:42 |
| *** chyka has joined #openstack-nova | 23:42 | |
| *** gouthamr has quit IRC | 23:43 | |
| gmann | mriedem, thanks, it might need rebase once 489650 is in. i will do after main patch is merged | 23:44 |
| *** kbaegis has quit IRC | 23:45 | |
| -openstackstatus- NOTICE: osic nodes have been removed from nodepool due to a problem with the mirror host beginning around 22:20 UTC. please recheck any jobs with failures installing packages. | 23:47 | |
| *** chyka has quit IRC | 23:49 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add redirect for api-microversion-history doc https://review.openstack.org/489641 | 23:49 |
| *** ijw has joined #openstack-nova | 23:52 | |
| *** markvoelker has quit IRC | 23:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add redirect for api-microversion-history doc https://review.openstack.org/489641 | 23:54 |
| *** acormier has joined #openstack-nova | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
