*** rajathagasthya has joined #openstack-nova | 00:00 | |
*** fragatina has quit IRC | 00:02 | |
*** Swami has quit IRC | 00:02 | |
*** yingjun has joined #openstack-nova | 00:03 | |
*** trinaths has left #openstack-nova | 00:03 | |
*** rajathagasthya has quit IRC | 00:04 | |
*** suresh12 has quit IRC | 00:04 | |
*** liverpooler has quit IRC | 00:05 | |
*** boris-42_ has joined #openstack-nova | 00:05 | |
*** suresh12 has joined #openstack-nova | 00:05 | |
*** gomarivera has quit IRC | 00:17 | |
*** gomarivera has joined #openstack-nova | 00:18 | |
*** gomarivera has quit IRC | 00:19 | |
*** gomarivera has joined #openstack-nova | 00:19 | |
*** gomarivera has quit IRC | 00:29 | |
*** trungnv has quit IRC | 00:34 | |
*** thorst_afk has joined #openstack-nova | 00:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814 | 00:35 |
---|---|---|
*** slaweq has joined #openstack-nova | 00:35 | |
*** trungnv has joined #openstack-nova | 00:36 | |
*** nic has quit IRC | 00:37 | |
*** thorst_afk has quit IRC | 00:38 | |
*** slaweq has quit IRC | 00:39 | |
*** gomarivera has joined #openstack-nova | 00:39 | |
*** Apoorva_ has joined #openstack-nova | 00:43 | |
*** zhurong has joined #openstack-nova | 00:45 | |
*** Apoorva has quit IRC | 00:47 | |
*** thorst_afk has joined #openstack-nova | 00:50 | |
*** litao__ has joined #openstack-nova | 00:52 | |
*** litao__ has quit IRC | 00:53 | |
*** litao__ has joined #openstack-nova | 00:53 | |
*** hongbin has quit IRC | 00:54 | |
*** tbachman has quit IRC | 00:57 | |
*** fragatina has joined #openstack-nova | 00:59 | |
*** tovin07_ has joined #openstack-nova | 00:59 | |
*** gomarivera has quit IRC | 01:00 | |
*** lucasxu has joined #openstack-nova | 01:00 | |
*** lucasxu has quit IRC | 01:01 | |
*** thorst_afk has quit IRC | 01:01 | |
*** Apoorva_ has quit IRC | 01:02 | |
*** mdnadeem has joined #openstack-nova | 01:03 | |
*** suresh12 has quit IRC | 01:03 | |
*** gomarivera has joined #openstack-nova | 01:04 | |
*** phuongnh has joined #openstack-nova | 01:04 | |
*** fragatina has quit IRC | 01:05 | |
*** gomarivera has quit IRC | 01:06 | |
*** salv-orlando has joined #openstack-nova | 01:06 | |
*** suresh12 has joined #openstack-nova | 01:07 | |
*** gomarivera has joined #openstack-nova | 01:07 | |
*** gomarivera has quit IRC | 01:07 | |
*** gomarivera has joined #openstack-nova | 01:08 | |
*** esberglu has joined #openstack-nova | 01:08 | |
*** suresh12 has quit IRC | 01:12 | |
*** cNilesh has joined #openstack-nova | 01:12 | |
*** esberglu has quit IRC | 01:12 | |
*** gjayavelu has joined #openstack-nova | 01:13 | |
*** gjayavelu has quit IRC | 01:15 | |
*** acormier has joined #openstack-nova | 01:15 | |
*** salv-orlando has quit IRC | 01:16 | |
*** acormier_ has joined #openstack-nova | 01:17 | |
*** acormier has quit IRC | 01:19 | |
*** liujiong has joined #openstack-nova | 01:20 | |
*** takashin has quit IRC | 01:22 | |
*** jaypipes has quit IRC | 01:22 | |
*** ijw has joined #openstack-nova | 01:23 | |
*** ijw has quit IRC | 01:28 | |
mriedem | oh yay https://bugs.launchpad.net/nova/+bug/1697580 | 01:31 |
openstack | Launchpad bug 1697580 in OpenStack Compute (nova) "Cinder volumes not always attached to instance in order presented" [Undecided,New] | 01:31 |
Kevin_Zheng | mriedem: do you have time to checkout my reply on https://review.openstack.org/#/c/459593/ , especially about [TagList] | 01:31 |
mriedem | Kevin_Zheng: block device mappings also have an instance_uuid field but we don't send those to conductor as a list | 01:32 |
mriedem | so something must be wrong in the api code that is requiring this to be different from how BDMs are handled | 01:33 |
*** zhurong has quit IRC | 01:33 | |
Kevin_Zheng | hmm I will check | 01:34 |
*** zhurong has joined #openstack-nova | 01:35 | |
*** slaweq has joined #openstack-nova | 01:35 | |
*** slaweq has quit IRC | 01:40 | |
*** gomarivera has quit IRC | 01:44 | |
*** gomarivera has joined #openstack-nova | 01:44 | |
*** xinliang has quit IRC | 01:46 | |
*** mingyu has joined #openstack-nova | 01:46 | |
*** jdurgin has joined #openstack-nova | 01:46 | |
*** gomarivera has quit IRC | 01:48 | |
Kevin_Zheng | mriedem: hmm, instance uuid for bdm was added in conductor to bdm obj, I will try if I can do it for TagObj | 01:50 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: XenAPI: device tagging https://review.openstack.org/333781 | 01:53 |
mriedem | Kevin_Zheng: good lukc | 01:54 |
mriedem | *luck | 01:54 |
mriedem | i'm going to call it a day | 01:54 |
Kevin_Zheng | mriedem: have a nice sleep | 01:54 |
openstackgerrit | jimmygc proposed openstack/nova master: Remove Xen networking plugin https://review.openstack.org/474024 | 01:55 |
*** mriedem has quit IRC | 01:56 | |
*** xinliang has joined #openstack-nova | 01:59 | |
*** fragatina has joined #openstack-nova | 02:01 | |
*** rdo_ has quit IRC | 02:01 | |
*** ghs39ghsggf has joined #openstack-nova | 02:02 | |
*** thorst_afk has joined #openstack-nova | 02:02 | |
*** ghs39ghsggf has left #openstack-nova | 02:03 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | 02:04 |
*** rdo_ has joined #openstack-nova | 02:05 | |
*** fragatina has quit IRC | 02:06 | |
*** thorst_afk has quit IRC | 02:06 | |
openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | 02:09 |
*** sapcc-bot1 has joined #openstack-nova | 02:10 | |
*** toabctl has quit IRC | 02:11 | |
*** toabctl has joined #openstack-nova | 02:12 | |
*** gbarros has joined #openstack-nova | 02:12 | |
*** sapcc-bot has quit IRC | 02:14 | |
*** acormier_ has quit IRC | 02:15 | |
*** acormier has joined #openstack-nova | 02:15 | |
*** salv-orlando has joined #openstack-nova | 02:16 | |
*** gomarivera has joined #openstack-nova | 02:17 | |
*** yamahata has quit IRC | 02:18 | |
*** acormier has quit IRC | 02:19 | |
*** Apoorva has joined #openstack-nova | 02:20 | |
*** esberglu has joined #openstack-nova | 02:24 | |
*** salv-orlando has quit IRC | 02:25 | |
*** acormier has joined #openstack-nova | 02:26 | |
*** gomarivera has quit IRC | 02:32 | |
*** yamamoto_ has joined #openstack-nova | 02:32 | |
*** gomarivera has joined #openstack-nova | 02:33 | |
*** mingyu has quit IRC | 02:39 | |
*** baoli has joined #openstack-nova | 02:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201 | 02:43 |
*** Apoorva has quit IRC | 02:44 | |
*** jichen has joined #openstack-nova | 02:44 | |
*** gomarivera has quit IRC | 02:45 | |
*** gomarivera has joined #openstack-nova | 02:45 | |
openstackgerrit | Hieu LE proposed openstack/nova master: remove mox from unit/virt/vmwareapi/test_driver_api.py https://review.openstack.org/452128 | 02:48 |
*** Apoorva has joined #openstack-nova | 02:48 | |
*** acormier has quit IRC | 02:49 | |
*** gomarivera has quit IRC | 02:50 | |
*** ayogi has joined #openstack-nova | 02:51 | |
*** nicolasbock has joined #openstack-nova | 02:56 | |
*** thorst_afk has joined #openstack-nova | 02:56 | |
*** tuanluong has joined #openstack-nova | 02:56 | |
*** fragatina has joined #openstack-nova | 03:02 | |
*** acormier has joined #openstack-nova | 03:02 | |
*** fragatina has quit IRC | 03:06 | |
*** tbachman has joined #openstack-nova | 03:07 | |
*** links has joined #openstack-nova | 03:14 | |
*** thorst_afk has quit IRC | 03:16 | |
*** acormier has quit IRC | 03:17 | |
*** acormier has joined #openstack-nova | 03:18 | |
*** baoli has quit IRC | 03:18 | |
*** mingyu has joined #openstack-nova | 03:18 | |
*** Shunli has joined #openstack-nova | 03:24 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 03:28 |
*** dave-mccowan has quit IRC | 03:31 | |
*** vks1 has joined #openstack-nova | 03:35 | |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/472814 | 03:35 |
*** slaweq has joined #openstack-nova | 03:37 | |
*** acormier_ has joined #openstack-nova | 03:39 | |
*** trinaths has joined #openstack-nova | 03:39 | |
*** slaweq has quit IRC | 03:41 | |
*** itlinux_ has joined #openstack-nova | 03:42 | |
*** acormier has quit IRC | 03:42 | |
*** dimtruck is now known as zz_dimtruck | 03:47 | |
*** Apoorva has quit IRC | 03:48 | |
*** hongbin has joined #openstack-nova | 03:51 | |
*** salv-orlando has joined #openstack-nova | 03:52 | |
*** amotoki_away is now known as amotoki | 03:55 | |
*** suresh12 has joined #openstack-nova | 04:00 | |
*** salv-orlando has quit IRC | 04:02 | |
*** fragatina has joined #openstack-nova | 04:03 | |
*** suresh12_ has joined #openstack-nova | 04:06 | |
*** fragatina has quit IRC | 04:07 | |
*** suresh12 has quit IRC | 04:07 | |
*** gouthamr_ has joined #openstack-nova | 04:07 | |
*** gouthamr has quit IRC | 04:09 | |
*** suresh12 has joined #openstack-nova | 04:10 | |
*** hoonetorg has quit IRC | 04:11 | |
*** suresh12_ has quit IRC | 04:11 | |
*** thorst_afk has joined #openstack-nova | 04:13 | |
*** psachin has joined #openstack-nova | 04:14 | |
*** suresh12 has quit IRC | 04:14 | |
*** suresh12 has joined #openstack-nova | 04:15 | |
*** gbarros has quit IRC | 04:17 | |
*** hoonetorg has joined #openstack-nova | 04:21 | |
*** esberglu has quit IRC | 04:23 | |
*** gcb has quit IRC | 04:24 | |
*** gcb has joined #openstack-nova | 04:24 | |
*** acormier_ has quit IRC | 04:26 | |
*** zhurong has quit IRC | 04:28 | |
*** EmilienM has quit IRC | 04:30 | |
*** EmilienM has joined #openstack-nova | 04:35 | |
*** slaweq has joined #openstack-nova | 04:38 | |
*** zhurong has joined #openstack-nova | 04:38 | |
*** slaweq has quit IRC | 04:42 | |
*** mingyu has quit IRC | 04:46 | |
openstackgerrit | Merged openstack/python-novaclient master: Fix setting 'global_request_id' in SessionClient https://review.openstack.org/473224 | 04:48 |
*** thorst_afk has quit IRC | 04:48 | |
*** mikal has quit IRC | 04:48 | |
*** mikal has joined #openstack-nova | 04:50 | |
*** adisky__ has joined #openstack-nova | 04:50 | |
*** salv-orlando has joined #openstack-nova | 04:51 | |
*** prateek has joined #openstack-nova | 04:54 | |
*** qwertyco has joined #openstack-nova | 04:58 | |
*** bkopilov has quit IRC | 04:59 | |
*** salv-orl_ has joined #openstack-nova | 05:03 | |
*** hongbin has quit IRC | 05:03 | |
*** salv-orlando has quit IRC | 05:06 | |
*** hongbin has joined #openstack-nova | 05:07 | |
*** slaweq has joined #openstack-nova | 05:12 | |
*** itlinux_ has quit IRC | 05:12 | |
*** suresh12 has quit IRC | 05:12 | |
*** yamahata has joined #openstack-nova | 05:14 | |
*** mvpnitesh has joined #openstack-nova | 05:15 | |
*** bnemec has quit IRC | 05:16 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (2) https://review.openstack.org/420619 | 05:17 |
*** zhurong has quit IRC | 05:17 | |
*** slaweq has quit IRC | 05:17 | |
*** tbachman has quit IRC | 05:19 | |
*** hongbin_ has joined #openstack-nova | 05:19 | |
*** udesale has joined #openstack-nova | 05:19 | |
*** hongbin has quit IRC | 05:20 | |
*** suresh12 has joined #openstack-nova | 05:21 | |
*** zhurong has joined #openstack-nova | 05:21 | |
*** hongbin has joined #openstack-nova | 05:23 | |
*** hongbin_ has quit IRC | 05:24 | |
*** hongbin_ has joined #openstack-nova | 05:26 | |
*** hongbin has quit IRC | 05:27 | |
*** hongbin has joined #openstack-nova | 05:28 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform keypair.create notification https://review.openstack.org/408689 | 05:28 |
*** gouthamr_ has quit IRC | 05:29 | |
*** hongbin_ has quit IRC | 05:30 | |
*** hongbin_ has joined #openstack-nova | 05:30 | |
*** hongbin__ has joined #openstack-nova | 05:33 | |
*** hongbin has quit IRC | 05:33 | |
*** edmondsw has joined #openstack-nova | 05:34 | |
*** hongbin_ has quit IRC | 05:34 | |
*** boris-42_ has quit IRC | 05:34 | |
*** hongbin has joined #openstack-nova | 05:35 | |
*** ratailor has joined #openstack-nova | 05:37 | |
*** hongbin__ has quit IRC | 05:37 | |
*** edmondsw has quit IRC | 05:38 | |
*** hongbin_ has joined #openstack-nova | 05:38 | |
*** hongbin has quit IRC | 05:40 | |
*** mamandle has joined #openstack-nova | 05:40 | |
*** hongbin has joined #openstack-nova | 05:42 | |
*** hongbin_ has quit IRC | 05:43 | |
*** adreznec has quit IRC | 05:43 | |
*** adreznec has joined #openstack-nova | 05:43 | |
*** sridharg has joined #openstack-nova | 05:44 | |
*** mingyu has joined #openstack-nova | 05:48 | |
*** sree has joined #openstack-nova | 05:54 | |
*** ltomasbo|away is now known as ltomasbo | 06:01 | |
*** suresh12 has quit IRC | 06:03 | |
*** jwcroppe_ has joined #openstack-nova | 06:07 | |
*** salv-orl_ has quit IRC | 06:08 | |
*** rcernin has joined #openstack-nova | 06:08 | |
*** salv-orlando has joined #openstack-nova | 06:09 | |
*** jwcroppe has quit IRC | 06:09 | |
*** krtaylor has quit IRC | 06:10 | |
*** ekuris has joined #openstack-nova | 06:10 | |
*** bkopilov has joined #openstack-nova | 06:10 | |
*** markus_z has joined #openstack-nova | 06:11 | |
*** salv-orlando has quit IRC | 06:13 | |
*** Oku_OS-away is now known as Oku_OS | 06:14 | |
*** slaweq has joined #openstack-nova | 06:19 | |
*** markus_z has quit IRC | 06:22 | |
*** krtaylor has joined #openstack-nova | 06:23 | |
*** slaweq has quit IRC | 06:23 | |
*** markus_z has joined #openstack-nova | 06:23 | |
*** cfriesen has quit IRC | 06:25 | |
*** ijw has joined #openstack-nova | 06:26 | |
*** ijw has quit IRC | 06:31 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 06:32 |
*** Guest77651 has quit IRC | 06:32 | |
*** sudipto has joined #openstack-nova | 06:33 | |
*** sudipto has quit IRC | 06:33 | |
*** jichen has quit IRC | 06:33 | |
*** sudipto has joined #openstack-nova | 06:33 | |
*** sudipto_ has joined #openstack-nova | 06:33 | |
*** jichen has joined #openstack-nova | 06:33 | |
*** andreas_s has joined #openstack-nova | 06:37 | |
*** cNilesh has quit IRC | 06:44 | |
*** yamahata has quit IRC | 06:45 | |
*** cNilesh has joined #openstack-nova | 06:45 | |
*** sridharg has quit IRC | 06:45 | |
*** sridharg has joined #openstack-nova | 06:45 | |
*** thorst_afk has joined #openstack-nova | 06:46 | |
*** david-lyle has quit IRC | 06:48 | |
*** dklyle has joined #openstack-nova | 06:48 | |
*** dklyle has quit IRC | 06:49 | |
*** david-lyle_ has joined #openstack-nova | 06:49 | |
*** jaosorior has joined #openstack-nova | 06:49 | |
*** thorst_afk has quit IRC | 06:50 | |
*** sridharg has quit IRC | 06:51 | |
*** sridharg has joined #openstack-nova | 06:52 | |
openstackgerrit | Merged openstack/nova master: Use plain routes list for user_data instead of stevedore https://review.openstack.org/462183 | 06:55 |
*** hongbin_ has joined #openstack-nova | 06:59 | |
*** jwcroppe_ has quit IRC | 06:59 | |
*** hongbin has quit IRC | 07:01 | |
*** shaohe_feng has quit IRC | 07:08 | |
*** hongbin has joined #openstack-nova | 07:08 | |
*** hongbin_ has quit IRC | 07:11 | |
*** hongbin has quit IRC | 07:13 | |
*** shaohe_feng has joined #openstack-nova | 07:15 | |
*** sudipto_ has quit IRC | 07:16 | |
*** sudipto has quit IRC | 07:16 | |
*** tesseract has joined #openstack-nova | 07:16 | |
*** sudipto has joined #openstack-nova | 07:17 | |
*** sudipto has quit IRC | 07:17 | |
*** sudipto has joined #openstack-nova | 07:17 | |
*** sudipto_ has joined #openstack-nova | 07:17 | |
*** hongbin has joined #openstack-nova | 07:18 | |
*** salv-orlando has joined #openstack-nova | 07:19 | |
*** slaweq has joined #openstack-nova | 07:19 | |
*** trinaths has quit IRC | 07:21 | |
*** hongbin_ has joined #openstack-nova | 07:21 | |
*** hongbin has quit IRC | 07:22 | |
*** gyee has quit IRC | 07:22 | |
*** hongbin has joined #openstack-nova | 07:23 | |
openstackgerrit | Ngo Quoc Cuong proposed openstack/nova master: Remove translation of log messages https://review.openstack.org/466957 | 07:24 |
*** hongbin_ has quit IRC | 07:25 | |
*** slaweq has quit IRC | 07:26 | |
*** jpena|off is now known as jpena | 07:26 | |
*** mingyu has quit IRC | 07:30 | |
*** diga has joined #openstack-nova | 07:30 | |
*** mingyu has joined #openstack-nova | 07:30 | |
*** gcb has quit IRC | 07:34 | |
*** gcb has joined #openstack-nova | 07:37 | |
*** mingyu has quit IRC | 07:39 | |
*** mingyu has joined #openstack-nova | 07:41 | |
*** damien_r has joined #openstack-nova | 07:43 | |
*** gomarivera has joined #openstack-nova | 07:46 | |
*** thorst_afk has joined #openstack-nova | 07:46 | |
*** hongbin_ has joined #openstack-nova | 07:47 | |
*** hongbin has quit IRC | 07:48 | |
*** gomarivera has quit IRC | 07:50 | |
*** karimb has joined #openstack-nova | 07:50 | |
*** thorst_afk has quit IRC | 07:51 | |
*** ralonsoh has joined #openstack-nova | 07:52 | |
*** mingyu has quit IRC | 07:55 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:00 | |
*** roeyc has joined #openstack-nova | 08:03 | |
*** ltomasbo is now known as ltomasbo|away | 08:10 | |
*** fragatina has joined #openstack-nova | 08:11 | |
*** fragatina has quit IRC | 08:12 | |
*** fragatina has joined #openstack-nova | 08:13 | |
*** suresh12 has joined #openstack-nova | 08:13 | |
*** tovin07_ has quit IRC | 08:14 | |
*** suresh12 has quit IRC | 08:17 | |
*** efoley has joined #openstack-nova | 08:19 | |
*** ayogi has quit IRC | 08:19 | |
*** hongbin has joined #openstack-nova | 08:21 | |
*** mvpnitesh has quit IRC | 08:23 | |
*** hongbin__ has joined #openstack-nova | 08:23 | |
*** hongbin_ has quit IRC | 08:24 | |
*** tovin07_ has joined #openstack-nova | 08:24 | |
*** lucas-afk is now known as lucasagomes | 08:25 | |
*** hongbin has quit IRC | 08:26 | |
*** hongbin has joined #openstack-nova | 08:26 | |
*** hongbin__ has quit IRC | 08:28 | |
*** zz9pzza_ has joined #openstack-nova | 08:28 | |
*** zz9pzza has quit IRC | 08:28 | |
*** trinaths has joined #openstack-nova | 08:28 | |
*** hongbin_ has joined #openstack-nova | 08:30 | |
*** hongbin has quit IRC | 08:31 | |
frickler | so this is a novaclient issue rather than OSC it seems: https://bugs.launchpad.net/python-novaclient/+bug/1697452 | 08:32 |
openstack | Launchpad bug 1697452 in python-openstackclient "openstack client dumps debug info on console even without specifying --debug option" [Undecided,New] | 08:32 |
*** fragatina has quit IRC | 08:37 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773 | 08:42 |
*** hongbin has joined #openstack-nova | 08:44 | |
*** yamamoto_ has quit IRC | 08:44 | |
*** hongbin_ has quit IRC | 08:45 | |
*** sridharg has quit IRC | 08:45 | |
*** sridharg has joined #openstack-nova | 08:45 | |
*** moshele has joined #openstack-nova | 08:46 | |
*** hongbin_ has joined #openstack-nova | 08:46 | |
*** thorst_afk has joined #openstack-nova | 08:47 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 08:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add key_name field to InstancePayload https://review.openstack.org/463002 | 08:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstanceCreatePayload https://review.openstack.org/419730 | 08:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add separate instance.create payload type https://review.openstack.org/463001 | 08:47 |
moshele | sean-k-mooney, sfinucan: hi, some of the ovs hw-offload patches are pushed in to ovs https://github.com/openvswitch/ovs/commit/53611f7b05460ee60cc94d67e14ac8945de4b4f9 can you unblock my os-vif patch? | 08:48 |
*** hongbin has quit IRC | 08:48 | |
*** hongbin has joined #openstack-nova | 08:49 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 08:50 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add key_name field to InstancePayload https://review.openstack.org/463002 | 08:50 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstanceCreatePayload https://review.openstack.org/419730 | 08:50 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add separate instance.create payload type https://review.openstack.org/463001 | 08:50 |
*** lpetrut has joined #openstack-nova | 08:50 | |
*** hongbin_ has quit IRC | 08:51 | |
openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-cloudpipe endpoint instead of stevedore https://review.openstack.org/474116 | 08:51 |
*** mvpnitesh has joined #openstack-nova | 08:52 | |
*** thorst_afk has quit IRC | 08:52 | |
*** awaugama has joined #openstack-nova | 08:52 | |
*** hongbin_ has joined #openstack-nova | 08:53 | |
*** hongbin has quit IRC | 08:53 | |
*** ayogi has joined #openstack-nova | 08:55 | |
openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-quota-classes endpoint instead of stevedore https://review.openstack.org/461641 | 08:55 |
openstackgerrit | jichenjc proposed openstack/nova master: add zvm migration object https://review.openstack.org/414090 | 08:56 |
*** markvoelker has quit IRC | 09:01 | |
*** derekh has joined #openstack-nova | 09:06 | |
*** josecastroleon has joined #openstack-nova | 09:06 | |
*** edmondsw has joined #openstack-nova | 09:10 | |
*** yamamoto has joined #openstack-nova | 09:12 | |
*** dtantsur|afk is now known as dtantsur | 09:13 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 09:14 |
*** edmondsw has quit IRC | 09:15 | |
*** alex_xu has quit IRC | 09:16 | |
*** yamamoto has quit IRC | 09:17 | |
*** yamamoto has joined #openstack-nova | 09:20 | |
*** cdent has joined #openstack-nova | 09:22 | |
*** slaweq has joined #openstack-nova | 09:23 | |
*** gszasz has joined #openstack-nova | 09:23 | |
*** diga has quit IRC | 09:24 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 09:26 |
*** trinaths has quit IRC | 09:26 | |
*** slaweq has quit IRC | 09:28 | |
*** Shunli has quit IRC | 09:32 | |
*** alex_xu has joined #openstack-nova | 09:36 | |
*** tojuvone has quit IRC | 09:37 | |
*** tojuvone has joined #openstack-nova | 09:38 | |
hferenc | hi all | 09:38 |
hferenc | if somebody has time on his/her hands i'd appreciate any reviews on this: https://review.openstack.org/#/c/464002/ | 09:39 |
*** yingjun has quit IRC | 09:39 | |
*** zhurong has quit IRC | 09:40 | |
*** liusheng has quit IRC | 09:42 | |
*** liusheng has joined #openstack-nova | 09:42 | |
*** yamamoto has quit IRC | 09:43 | |
*** mdnadeem has quit IRC | 09:46 | |
*** abalutoiu has quit IRC | 09:48 | |
*** thorst_afk has joined #openstack-nova | 09:48 | |
*** prateek has quit IRC | 09:49 | |
*** prateek has joined #openstack-nova | 09:50 | |
*** jichen has quit IRC | 09:52 | |
*** abalutoiu has joined #openstack-nova | 09:53 | |
*** fragatina has joined #openstack-nova | 09:55 | |
*** sambetts|afk is now known as sambetts | 09:55 | |
*** mvpnitesh has quit IRC | 09:56 | |
*** mvpnitesh has joined #openstack-nova | 09:57 | |
*** yamamoto has joined #openstack-nova | 09:58 | |
*** liujiong has quit IRC | 09:58 | |
*** awaugama has quit IRC | 09:58 | |
*** tovin07_ has quit IRC | 10:02 | |
*** sdague has joined #openstack-nova | 10:03 | |
*** yamamoto has quit IRC | 10:05 | |
*** yamamoto has joined #openstack-nova | 10:05 | |
*** yamamoto has quit IRC | 10:05 | |
*** thorst_afk has quit IRC | 10:07 | |
*** mvk has quit IRC | 10:15 | |
*** moshele has quit IRC | 10:19 | |
*** moshele has joined #openstack-nova | 10:20 | |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform aggregate.update_prop notification https://review.openstack.org/462576 | 10:21 |
*** slaweq has joined #openstack-nova | 10:24 | |
openstackgerrit | Merged openstack/nova master: remove get_nw_info_for_instance from compute.utils https://review.openstack.org/451387 | 10:26 |
*** mvk has joined #openstack-nova | 10:26 | |
*** hongbin_ has quit IRC | 10:27 | |
*** slaweq has quit IRC | 10:28 | |
*** moshele has quit IRC | 10:30 | |
*** moshele has joined #openstack-nova | 10:30 | |
*** trinaths has joined #openstack-nova | 10:33 | |
*** cNilesh has quit IRC | 10:37 | |
*** cNilesh has joined #openstack-nova | 10:37 | |
*** cNilesh has quit IRC | 10:40 | |
*** cNilesh has joined #openstack-nova | 10:40 | |
*** CristinaPauna has quit IRC | 10:40 | |
cdent | bauzas, alex_xu : some relatively small placement-related fixes: https://review.openstack.org/#/c/468928/ https://review.openstack.org/#/c/469047/ https://review.openstack.org/#/c/469048/ https://review.openstack.org/#/c/471067/ please and thank you | 10:40 |
*** lucasagomes has quit IRC | 10:41 | |
*** hferenc has quit IRC | 10:46 | |
*** cNilesh has quit IRC | 10:47 | |
openstackgerrit | Merged openstack/nova master: Use plain routes list for os-server-groups endpoint instead of stevedore https://review.openstack.org/462169 | 10:48 |
*** p01nt3r75 has joined #openstack-nova | 10:49 | |
*** applec4rt has quit IRC | 10:49 | |
*** yamamoto has joined #openstack-nova | 10:51 | |
alex_xu | cdent: added to my list, will try to reach them | 10:52 |
openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/472919 | 10:52 |
*** lucasagomes has joined #openstack-nova | 10:52 | |
cdent | thanks alex_xu | 10:52 |
alex_xu | cdent: np | 10:52 |
*** moshele has quit IRC | 10:53 | |
*** yamamoto has quit IRC | 10:55 | |
*** salv-orlando has quit IRC | 10:55 | |
*** trinaths has quit IRC | 10:56 | |
*** moshele has joined #openstack-nova | 10:57 | |
*** markvoelker has joined #openstack-nova | 11:01 | |
*** yamamoto has joined #openstack-nova | 11:01 | |
*** moshele has quit IRC | 11:04 | |
*** ltomasbo|away is now known as ltomasbo | 11:04 | |
*** thorst_afk has joined #openstack-nova | 11:04 | |
*** moshele has joined #openstack-nova | 11:05 | |
*** udesale has quit IRC | 11:05 | |
*** yamamoto has quit IRC | 11:06 | |
*** _danpawlik is now known as danpawlik | 11:08 | |
*** claudiub has joined #openstack-nova | 11:08 | |
*** thorst_afk has quit IRC | 11:09 | |
*** phuongnh has quit IRC | 11:12 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova master: live-migration test hook for serial console https://review.openstack.org/347471 | 11:14 |
*** tuanluong has quit IRC | 11:16 | |
*** slaweq has joined #openstack-nova | 11:24 | |
*** qwertyco has quit IRC | 11:25 | |
*** jaosorior has quit IRC | 11:29 | |
*** slaweq has quit IRC | 11:29 | |
*** lucasagomes is now known as lucas-hungry | 11:31 | |
*** rfolco has joined #openstack-nova | 11:31 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make all timestamps formats equal https://review.openstack.org/421981 | 11:32 |
*** dtantsur is now known as dtantsur|brb | 11:33 | |
*** markvoelker has quit IRC | 11:36 | |
*** yamamoto has joined #openstack-nova | 11:36 | |
*** yamamoto has quit IRC | 11:36 | |
*** hferenc has joined #openstack-nova | 11:38 | |
*** yamamoto has joined #openstack-nova | 11:38 | |
*** acormier has joined #openstack-nova | 11:41 | |
*** thorst_afk has joined #openstack-nova | 11:42 | |
*** sudipto has quit IRC | 11:43 | |
*** sudipto_ has quit IRC | 11:43 | |
*** vladiskuz has joined #openstack-nova | 11:46 | |
*** acormier has quit IRC | 11:47 | |
vladiskuz | Hey, guys! When I tried use pagination in nova I've faced with problem. When I use '--marker' nova doesn't return instances in error state. Is it a bug or not? | 11:49 |
vladiskuz | http://paste.openstack.org/show/612533/ | 11:49 |
*** CristinaPauna has joined #openstack-nova | 11:51 | |
*** trinaths has joined #openstack-nova | 11:52 | |
*** cdent has quit IRC | 11:53 | |
*** thorst_afk has quit IRC | 11:53 | |
*** markvoelker has joined #openstack-nova | 11:53 | |
*** gszasz has quit IRC | 11:56 | |
*** CristinaPauna has quit IRC | 11:57 | |
sdague | lyarwood: is this still in progress - https://bugs.launchpad.net/nova/+bug/1639293 ? | 11:59 |
openstack | Launchpad bug 1639293 in OpenStack Compute (nova) "Cinder encrypted vol connection info include full nova internal class name " [High,In progress] - Assigned to Lee Yarwood (lyarwood) | 11:59 |
*** markvoelker has quit IRC | 11:59 | |
openstackgerrit | Monty Taylor proposed openstack/python-novaclient master: Stop posting to os-volumes_boot https://review.openstack.org/473833 | 12:00 |
*** jpena is now known as jpena|lunch | 12:01 | |
*** ratailor has quit IRC | 12:01 | |
*** awaugama has joined #openstack-nova | 12:01 | |
*** qwertyco has joined #openstack-nova | 12:01 | |
*** markvoelker has joined #openstack-nova | 12:02 | |
*** gszasz has joined #openstack-nova | 12:02 | |
lyarwood | sdague: yeah still in progress, we can't remove the full class path method until Queens thanks to Tempest | 12:02 |
lyarwood | https://review.openstack.org/#/q/status:open+branch:master+topic:deprecate_legacy_encryptor_provider_names | 12:03 |
*** litao__ has quit IRC | 12:03 | |
sdague | lyarwood: is there going to still be another nova patch there? | 12:03 |
lyarwood | sdague: nope, we can remove it from the bug now. | 12:04 |
* lyarwood adds os-brick and tempest | 12:04 | |
*** ralonsoh has quit IRC | 12:06 | |
*** jdurgin has quit IRC | 12:08 | |
*** baoli has joined #openstack-nova | 12:11 | |
*** mvpnitesh has quit IRC | 12:13 | |
*** mvpnitesh has joined #openstack-nova | 12:14 | |
*** ralonsoh has joined #openstack-nova | 12:15 | |
*** vks1 has quit IRC | 12:16 | |
*** acormier has joined #openstack-nova | 12:17 | |
*** kornicameister has quit IRC | 12:22 | |
*** suresh12 has joined #openstack-nova | 12:23 | |
*** slaweq has joined #openstack-nova | 12:25 | |
*** ltomasbo is now known as ltomasbo|away | 12:26 | |
*** lyan has joined #openstack-nova | 12:27 | |
*** suresh12 has quit IRC | 12:27 | |
*** mamandle has quit IRC | 12:28 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for traits https://review.openstack.org/474186 | 12:29 |
*** mdrabe has joined #openstack-nova | 12:29 | |
*** acormier has quit IRC | 12:29 | |
*** alexchadin has joined #openstack-nova | 12:29 | |
*** prateek has quit IRC | 12:30 | |
*** slaweq has quit IRC | 12:30 | |
*** coreywright has quit IRC | 12:33 | |
*** lucas-hungry is now known as lucasagomes | 12:33 | |
*** edmondsw has joined #openstack-nova | 12:37 | |
*** jdurgin has joined #openstack-nova | 12:39 | |
*** acormier has joined #openstack-nova | 12:41 | |
*** jamesden_ has joined #openstack-nova | 12:41 | |
*** acormier has joined #openstack-nova | 12:42 | |
*** jamesdenton has quit IRC | 12:44 | |
*** gouthamr has joined #openstack-nova | 12:44 | |
*** abalutoiu has quit IRC | 12:44 | |
*** coreywright has joined #openstack-nova | 12:45 | |
*** links has quit IRC | 12:46 | |
*** acormier has quit IRC | 12:46 | |
alex_xu | nova api meeting is in 13 mins at #openstack-meeting-4 | 12:47 |
openstackgerrit | Merged openstack/nova master: api-ref: fix misleading description in PUT /os-services/disable https://review.openstack.org/473997 | 12:49 |
*** sudipto_ has joined #openstack-nova | 12:50 | |
*** sudipto has joined #openstack-nova | 12:50 | |
*** catintheroof has joined #openstack-nova | 12:52 | |
*** sbezverk has quit IRC | 12:53 | |
*** sbezverk has joined #openstack-nova | 12:54 | |
sfinucan | moshele: I could, but surely we should wait until it's in the wild? | 12:54 |
sfinucan | ...and in a release | 12:54 |
moshele | sfinucan: ok | 12:57 |
*** mvpnitesh has quit IRC | 12:57 | |
*** pchavva has joined #openstack-nova | 12:57 | |
*** liverpooler has joined #openstack-nova | 12:58 | |
*** baoli has quit IRC | 12:59 | |
*** baoli has joined #openstack-nova | 12:59 | |
*** jpena|lunch is now known as jpena | 13:03 | |
*** ayogi has quit IRC | 13:04 | |
Kevin_Zheng | ping gibi | 13:05 |
Kevin_Zheng | ping | 13:05 |
*** mingyu has joined #openstack-nova | 13:06 | |
*** baoli has quit IRC | 13:08 | |
*** yassine has joined #openstack-nova | 13:08 | |
*** mriedem has joined #openstack-nova | 13:10 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Clean up ShellTest unit tests https://review.openstack.org/473910 | 13:11 |
Kevin_Zheng | ping mriedem | 13:13 |
*** gcb has quit IRC | 13:14 | |
*** gomarivera has joined #openstack-nova | 13:14 | |
*** xyang1 has joined #openstack-nova | 13:14 | |
*** gomarivera_ has joined #openstack-nova | 13:15 | |
*** lucasxu has joined #openstack-nova | 13:15 | |
mriedem | Kevin_Zheng: pong | 13:15 |
*** gomarivera has quit IRC | 13:15 | |
mriedem | sdague: want to put https://review.openstack.org/#/c/474029/ in and then i'll cut a stable/ocata release this afternoon | 13:15 |
*** kylek3h has joined #openstack-nova | 13:17 | |
Kevin_Zheng | mriedem: saw you guys mentioned me in notification meeting last night, I will have a patch up tomorrow, and I have a question came up today from our product team | 13:18 |
*** openstackgerrit has quit IRC | 13:18 | |
Kevin_Zheng | Should instance notification payload including STATUS? | 13:18 |
*** dave-mccowan has joined #openstack-nova | 13:18 | |
mriedem | it has vm_state doesn't it? | 13:19 |
Kevin_Zheng | As it appears in instance details response and we have filter for this field | 13:19 |
Kevin_Zheng | Yeah, but we currently allow filter by status | 13:19 |
mriedem | looking at https://docs.openstack.org/developer/nova/notifications.html | 13:20 |
Kevin_Zheng | In client | 13:20 |
mriedem | i see | 13:20 |
mriedem | "state":"active", "task_state":"pausing", "power_state":"running", | 13:20 |
*** alexchadin has quit IRC | 13:20 | |
mriedem | for instance.pause.start | 13:20 |
Kevin_Zheng | O we have state | 13:21 |
mriedem | Kevin_Zheng: yes i think that's the vm_state | 13:21 |
mriedem | i assume you're asking for something like the status in the rest api response for GET /servers/{server_id} which uses https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L113 | 13:21 |
Kevin_Zheng | Yeah | 13:22 |
mriedem | i.e. https://developer.openstack.org/api-guide/compute/server_concepts.html | 13:22 |
*** esberglu has joined #openstack-nova | 13:22 | |
mriedem | honestly i don't really know why there was ever a distinction in the rest api | 13:23 |
mriedem | i think the status field in the response predated the vm/task states being in the rest api response | 13:23 |
mriedem | which came in the OS-EXT-STS extension | 13:23 |
mriedem | it seems redundant t ome | 13:23 |
Kevin_Zheng | Hmm | 13:24 |
Kevin_Zheng | So you prefer not adding it | 13:24 |
*** eharney has joined #openstack-nova | 13:24 | |
*** roeyc has quit IRC | 13:24 | |
*** roeyc has joined #openstack-nova | 13:25 | |
Kevin_Zheng | And perhaps apps should rely on vm state instead of status | 13:25 |
sdague | mriedem: done | 13:25 |
Kevin_Zheng | ? | 13:25 |
*** roeyc has quit IRC | 13:25 | |
*** slaweq has joined #openstack-nova | 13:26 | |
*** dtantsur|brb is now known as dtantsur | 13:26 | |
mriedem | Kevin_Zheng: i don't have a strong feeling either way, we could add status to the InstancePayload if we wanted, i'd ask gibi too | 13:27 |
mriedem | but this is why we have versioned notifications now | 13:27 |
mriedem | so we can change them | 13:27 |
mriedem | Kevin_Zheng: i would like some more details on the use case, but that could come in a change or ML thread or something else | 13:27 |
mriedem | sdague: thanks | 13:28 |
Kevin_Zheng | yeah, I just find it might be useful as we already support filter by it | 13:28 |
*** pabardina has joined #openstack-nova | 13:28 | |
sdague | mriedem: is there a current bug leader? | 13:28 |
stvnoyes | good morning mriedem. I have the cinder v3 migrate rv ready to go. I've been testing it with jgriffith 's POC changes and can migrate back and forth OK with a bfv instance and instances with attached volumes . I would appreciate your feedback on the changes. thanks. https://review.openstack.org/#/c/463987/ | 13:29 |
sdague | mriedem: I was staring at the bugs again today and thinking about the way tags get "abused" in github for workflow | 13:29 |
sdague | and think we could use some of that | 13:29 |
mriedem | sdague: there is no bug master | 13:29 |
mriedem | stvnoyes: ok | 13:29 |
mriedem | sdague: abused? | 13:29 |
sdague | mriedem: github has no real workflow states | 13:30 |
sdague | it's either open or clossed | 13:30 |
sdague | which means the entire incomplete / confirmed / triaged isn't used | 13:30 |
sdague | as it doesn't exist | 13:30 |
*** slaweq has quit IRC | 13:31 | |
mriedem | oh right, i remember | 13:31 |
sdague | and instead projects use tags and bug bots to do workflow with tags | 13:31 |
mriedem | with GHE | 13:31 |
mriedem | inprogress, blocked, etc | 13:31 |
sdague | which, is actually a lot more flexible in a lot of ways | 13:31 |
sdague | because you can customize workflow to your project | 13:31 |
pabardina | Hello, I would like to use the "nova trigger-crash-dump", but how can I validate if it works correctly ? The cli doesn't do anything (on mitaka) thanks | 13:31 |
sdague | I was thinking about things like "needs.sub-team-triage" "needs.os-info" "needs.version-info" | 13:32 |
*** jianghuaw__ has joined #openstack-nova | 13:32 | |
mriedem | pabardina: here are the functional tests for trigger crash dump in mitaka if those help https://github.com/openstack/python-novaclient/blob/stable/mitaka/novaclient/tests/functional/v2/test_trigger_crash_dump.py | 13:32 |
sdague | launchpad doesn't let you have : in tags, but it does let you have "." | 13:33 |
sdague | a bunch of that could be automatically applied with some text processing | 13:34 |
mriedem | Kevin_Zheng: when you say filter by status, you mean this right? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L188-L208 | 13:34 |
mriedem | we really filter by vm/task state | 13:34 |
mriedem | the status thing is just an alias for the API user | 13:34 |
sdague | because a lot bugs just end up with no logical next step | 13:34 |
Kevin_Zheng | hmm yes | 13:35 |
mriedem | sdague: automatically applied how? cron job that pulls the bug down and scans the text and applies a tag? | 13:35 |
mriedem | i'm not even sure if we're supposed to be actively moving to storyboard or not | 13:35 |
mriedem | i've avoided that conversation | 13:35 |
*** alexchadin has joined #openstack-nova | 13:36 | |
sdague | mriedem: yeh, there are mqtt events on bug changes, we don't have to cron it | 13:36 |
Kevin_Zheng | but for SL for example, if we want to support filter by status, we have to maintain the mapping like in Nova | 13:36 |
*** sapcc-bot1 has quit IRC | 13:36 | |
*** carthaca_ has quit IRC | 13:36 | |
Kevin_Zheng | vm_state + task_state -> status | 13:36 |
*** carthaca_ has joined #openstack-nova | 13:36 | |
*** sapcc-bot has joined #openstack-nova | 13:36 | |
mriedem | Kevin_Zheng: true; when you say support filter by status in searchlight (SL reminds me of softlayer), are you talking about something added to the searchlight REST API? | 13:36 |
*** cleong has joined #openstack-nova | 13:37 | |
mriedem | sdague: yeah good point | 13:37 |
efried | johnthetubaguy yt? | 13:38 |
Kevin_Zheng | no, they are just transforming user input query params to ElasticSearch Query, so if it has this field, it can search | 13:38 |
sdague | mriedem: anyway, I'm playing with some things to see what might be useful to make the bug backlog not too crazy | 13:40 |
*** jwcroppe has joined #openstack-nova | 13:40 | |
Kevin_Zheng | it can also transforming status query to vm_state + task_state, but means maintain the mapping :) | 13:41 |
mriedem | edleafe: dansmith: semi interesting placement related bug https://bugs.launchpad.net/nova/+bug/1697825 | 13:41 |
openstack | Launchpad bug 1697825 in OpenStack Compute (nova) "nova-compute can not regist resource_provider when nova-compute start before placement endpoint created" [Undecided,New] - Assigned to zhang zhenzhong (zzzhang0118) | 13:41 |
mriedem | sdague: ok - honestly i'm happy with anyone that's just looking at bugs | 13:42 |
mriedem | so go nuts | 13:42 |
*** zhurong has joined #openstack-nova | 13:42 | |
mriedem | Kevin_Zheng: why search SL by the status field then? why not just search by the vm_state field? | 13:43 |
mriedem | if that's all SL has? | 13:43 |
sdague | ok, so I'm going to poke around at a few things and try to write up some ideas to the mailing list when I have something more concrete | 13:43 |
efried | Can anyone tell me if (and if so, why) it's illegal for a member of a notification payload to be None? | 13:44 |
mriedem | gibi: ^ | 13:45 |
mriedem | efried: which member? | 13:45 |
efried | Hehe. gibi is the reason I'm asking. | 13:45 |
*** jamesden_ has quit IRC | 13:45 | |
efried | Trying to get to the bottom of https://review.openstack.org/#/c/455778/3/nova/notifications/base.py@394 | 13:45 |
*** openstackgerrit has joined #openstack-nova | 13:45 | |
openstackgerrit | Alex Xu proposed openstack/nova master: [placement] Update placement devref to modern features https://review.openstack.org/469047 | 13:45 |
dansmith | mriedem: we know about that one right? | 13:46 |
Kevin_Zheng | mriedem: just saying, nova currently support it :) | 13:46 |
dansmith | mriedem: tripleo was doing that, and we said starting compute before your catalog was setup was not a thing | 13:46 |
mriedem | Kevin_Zheng: sure, but i don't see that as a need for SL to need the same information | 13:47 |
mriedem | when it has the vm_state | 13:47 |
mriedem | which is essentially the same | 13:47 |
mriedem | dansmith: forgot about the tripleo case | 13:47 |
Kevin_Zheng | got it | 13:47 |
*** alineb has quit IRC | 13:47 | |
mriedem | Kevin_Zheng: again i'm not blocking it, i would just like a better idea of the end use case and flow, and requirements - which seem pretty thin if it's just "nova rest api has this field so SL should too" | 13:48 |
mriedem | but, we're doing that for other things | 13:48 |
Kevin_Zheng | yeah, I understand | 13:48 |
mriedem | https://blueprints.launchpad.net/nova/+spec/additional-notification-fields-for-searchlight i mean | 13:48 |
*** smatzek has joined #openstack-nova | 13:49 | |
mriedem | efried: so setting https://github.com/openstack/nova/blob/9dde4fe0eacc01c135401da3313c493caa99a30c/nova/notifications/base.py#L478 to None makes legacy notifications blow up? | 13:49 |
efried | mriedem I think that's what we don't know. | 13:50 |
mriedem | because for a versioned payload that should be fine https://github.com/openstack/nova/blob/9dde4fe0eacc01c135401da3313c493caa99a30c/nova/notifications/objects/instance.py#L86 | 13:50 |
*** jamesdenton has joined #openstack-nova | 13:50 | |
mriedem | since it's nullable=True | 13:50 |
*** crushil has joined #openstack-nova | 13:50 | |
efried | mriedem Right, although the only other place I can see that field being used, it's being defaulted to 0 | 13:51 |
efried | https://github.com/openstack/nova/blob/9dde4fe0eacc01c135401da3313c493caa99a30c/nova/api/openstack/compute/views/servers.py#L153 | 13:51 |
*** jaypipes has joined #openstack-nova | 13:53 | |
efried | What's a "legacy notification"? Or any notification, for that matter? Is it a way for an API consumer to register a kind of callback to return instance info periodically or when something happens? | 13:53 |
efried | (jaypipes FYI, trying to get to the bottom of https://review.openstack.org/#/c/455778/3/nova/notifications/base.py@394) | 13:54 |
jaypipes | efried: a legacy notification is any notification that doesn't use versioning | 13:55 |
*** yamahata has joined #openstack-nova | 13:56 | |
efried | jaypipes Is there some reason a piece of the notification payload can't be None? | 13:56 |
jaypipes | efried: notification messages are sent out on the notifications topic queue and subscribers to that queue can take whatever action they want depending on the event type and payload | 13:56 |
*** baoli has joined #openstack-nova | 13:56 | |
jaypipes | efried: I don't believe so, which is the reason for my comment there :) | 13:56 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Extract custom resource classes from flavors https://review.openstack.org/473627 | 13:58 |
*** amotoki is now known as amotoki_away | 13:59 | |
edleafe | Is it the responsibility of an operator to create a flavor's extra_specs with only valid data? | 14:00 |
jaypipes | edleafe: good question :) | 14:00 |
jaypipes | edleafe: not sure, frankly. | 14:00 |
edleafe | IOW, if they enter a string where an integer is required, how should that be handled | 14:00 |
jaypipes | edleafe: I would say yes? | 14:00 |
edleafe | jaypipes: that was my instinct | 14:00 |
openstackgerrit | Merged openstack/python-novaclient master: strip the remote prefixes from the release note branch specifiers https://review.openstack.org/471082 | 14:00 |
edleafe | but cdent disagrees | 14:00 |
edleafe | or at least wonders about that | 14:01 |
jaypipes | edleafe: not user-friendly, but then again, it's extra_specs, so wild west. | 14:01 |
*** sdatko has joined #openstack-nova | 14:01 | |
edleafe | jaypipes: so if they specify a custom resource class that doesn't start with CUSTOM_, raise an error and be done with it? | 14:02 |
* gibi is reading back | 14:02 | |
*** gbarros has joined #openstack-nova | 14:02 | |
*** prateek has joined #openstack-nova | 14:03 | |
*** bnemec has joined #openstack-nova | 14:05 | |
*** tidwellr has joined #openstack-nova | 14:06 | |
*** masber has quit IRC | 14:06 | |
gibi | jaypipes, efried, mriedem: technically legacy notification payload could contain null values. But in this particular case progress was never null in the legacy notification | 14:07 |
gibi | jaypipes, efried, mriedem: so makit it null now might break the consumer | 14:07 |
efried | gibi Is this code path *only* used for legacy notifications? | 14:07 |
*** masber has joined #openstack-nova | 14:07 | |
gibi | efried: let me doublecheck | 14:07 |
efried | So the only reason we need to preserve this particular behavior is for backward compatibility. In which case we should keep it defaulting to ''. | 14:09 |
gibi | efried: the null_safe_int is only used for legacy. the versioned part directly copy the progress field from the Instance and the versioned notification defines progress as nullble too | 14:10 |
*** zz_dimtruck is now known as dimtruck | 14:11 | |
gibi | so yes, the only reason I wouldn't like to send null in the legacy notification as it was never null before | 14:11 |
gibi | and I have no way to signal (except a release note) that now progress can be null in the legacy notification | 14:12 |
*** prateek has quit IRC | 14:12 | |
*** ckopper has joined #openstack-nova | 14:12 | |
*** qwertyco has quit IRC | 14:13 | |
gibi | jaypipes: you vote for sending null in https://review.openstack.org/#/c/455778/3/nova/notifications/base.py@394 , don't you think it will cause trouble for the consumer? | 14:13 |
*** qwertyco has joined #openstack-nova | 14:13 | |
gibi | jaypipes: or it is enough to add a release note to signal such a change | 14:13 |
efried | I have another suggestion. Commenting in the change set... | 14:13 |
*** eharney has quit IRC | 14:13 | |
jaypipes | gibi: I'm kinda of the opinion "just see if anything breaks" :) | 14:14 |
gibi | jaypipes: so you mean if consumer is broken then they will file a bug and we will revert the change? :) | 14:14 |
gibi | efried: I appreciate your review! | 14:15 |
jaypipes | gibi: possibly :) or rather a better scenario would be to have a functional test that attempts to load the legacy notification when null_safe_int() is removed and see if something blows up | 14:15 |
openstackgerrit | Merged openstack/python-novaclient master: Error out if nic auto or none are not alone https://review.openstack.org/470000 | 14:16 |
gibi | jaypipes: that something that loads the notification in the functional test is not exists today so if I create it now then I definitely make it so that it won't blow up because of progress can be null | 14:16 |
*** eharney has joined #openstack-nova | 14:16 | |
gibi | jaypipes: however I don't know if that is a meaningfull test :) | 14:16 |
jaypipes | gibi: I'm not sure either :) | 14:17 |
mriedem | if the end consumer expects it to not be null, then us testing whatever we change it to internally doesn't help much | 14:18 |
*** jdurgin has quit IRC | 14:18 | |
*** kfarr has joined #openstack-nova | 14:18 | |
*** tbachman has joined #openstack-nova | 14:18 | |
gibi | mriedem: exactly | 14:18 |
gibi | mriedem: would you be OK with making progress null and signal that with a reno? | 14:19 |
*** links has joined #openstack-nova | 14:19 | |
efried | gibi jaypipes added a comment. | 14:20 |
mriedem | what is this holding up? | 14:20 |
mriedem | why do we care? | 14:20 |
gibi | it is come up as part of the bugfix https://review.openstack.org/#/c/421981/ but it doesn't hold it up any more | 14:21 |
*** ekuris has quit IRC | 14:21 | |
*** qwertyco has quit IRC | 14:22 | |
*** gomarivera_ has quit IRC | 14:22 | |
gibi | mriedem: so we can ignore the problem if we want | 14:22 |
*** qwertyco has joined #openstack-nova | 14:22 | |
*** jdurgin has joined #openstack-nova | 14:23 | |
mriedem | gibi: jaypipes: efried: commented with my 2 cents, | 14:24 |
mriedem | ultimately i say abandon | 14:24 |
mriedem | this isn't worth the time spent discussing it | 14:24 |
mriedem | especially not when we could be bikeshedding over flavor extra spec validation! | 14:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup the plethora of libvirt live migration options https://review.openstack.org/471834 | 14:25 |
gibi | mriedem: I got your point. This is a side track really | 14:25 |
gibi | mriedem: so I'm not against droping it | 14:26 |
*** armax has joined #openstack-nova | 14:27 | |
*** slaweq has joined #openstack-nova | 14:27 | |
sdatko | hey mriedem | 14:27 |
*** jaosorior has joined #openstack-nova | 14:28 | |
openstackgerrit | Maciej Kucia proposed openstack/nova-specs master: WIP Extended PCI alias https://review.openstack.org/474218 | 14:28 |
sdatko | do you remember, by change, i had issues with testing db_api in current Nova/Master? | 14:28 |
mriedem | sdatko: i don't | 14:28 |
sdatko | you recommened me to use nova.objects instead of db.flavor_create /etc. | 14:29 |
mriedem | efried: more on notifications if you're interested https://docs.openstack.org/developer/nova/notifications.html | 14:30 |
*** felipemonteiro has joined #openstack-nova | 14:30 | |
mriedem | sdatko: ok, i vaguely remember you messing around with things in the database | 14:30 |
mriedem | and me trying to discourage that | 14:30 |
*** ckopper has quit IRC | 14:30 | |
gibi | Kevin_Zheng, mriedem: about state vs status we can a status based on https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L113 I'm not against it especially if you have a use case needing it | 14:30 |
sdatko | yep :) | 14:30 |
mriedem | gibi: i'm not against it really either, as long as i understand the use case first | 14:31 |
gibi | mriedem: then I guess Kevin_Zheng can put up a patch with the use case in the commit message :) | 14:32 |
sdatko | mriedem: so i am trying to get all flavorIDs on specific host | 14:32 |
*** mamandle has joined #openstack-nova | 14:33 | |
mriedem | gibi: you know how you're creating the new instance create payload? didn't we do that once already with some other action payload? i was thinking related to snapshots | 14:33 |
mriedem | but i might be misremembering | 14:33 |
*** sree has quit IRC | 14:33 | |
mriedem | like, | 14:33 |
edleafe | alex_xu: around? | 14:33 |
mriedem | we needed to add the snapshot image id to the payload but didn't want to add it to every action payload | 14:34 |
*** sree has joined #openstack-nova | 14:34 | |
mriedem | sdatko: flavors are not tied to a compute host, the instance is | 14:34 |
mriedem | and the instance has a flavor | 14:34 |
mriedem | associated with it | 14:34 |
mriedem | embedded really | 14:34 |
mriedem | nova.objects.Instance.flavor field | 14:34 |
sdatko | mriedem: in nova.db.sqlalchemy.api i have function that returns model_query(context, models.Instance.instancE_typE_id).filter(models.Instance.host == host).filter(models.Instance.deleted == 0).distinct(models.Instance.instance_type_id).all() | 14:35 |
mriedem | gibi: ah this https://review.openstack.org/#/c/453077/ | 14:35 |
gibi | mriedem: there are actions with specific payload like https://github.com/openstack/nova/blob/master/nova/notifications/objects/instance.py#L121 | 14:36 |
mriedem | gibi: this is what i was thinking of https://review.openstack.org/#/c/453077/2/doc/notification_samples/instance-snapshot-end.json@71 | 14:36 |
*** sridharg has quit IRC | 14:36 | |
sdatko | and it seems to work; however, i am trying to write unit test for that, but i receive "oslo_db.exception.DBNonExistentTable: (sqlite3.OperationalError) no such table: instances" | 14:36 |
mriedem | we added a more specific payload, | 14:36 |
*** links has quit IRC | 14:36 | |
mriedem | and i was checking to see what we did with the version | 14:36 |
mriedem | so that we are being consistent with InstanceCreatePayload | 14:37 |
gibi | mriedem: ahh I see. You are askin about the version number | 14:37 |
mriedem | yes | 14:37 |
mriedem | i want to be consistent when we rename payloads | 14:37 |
mriedem | consistent in what we do about the version i mean | 14:37 |
mriedem | does it stay the same or increment | 14:37 |
openstackgerrit | Maciej Kucia proposed openstack/nova-specs master: WIP Extended PCI alias https://review.openstack.org/474218 | 14:37 |
*** hongbin has joined #openstack-nova | 14:37 | |
mriedem | gibi: looks like it's being consistent and not incrementing the version https://review.openstack.org/#/c/453077/9/doc/notification_samples/instance-snapshot-end.json | 14:38 |
*** sree has quit IRC | 14:38 | |
gibi | mriedem: in case of snapshot_id we did increase as not just renamed the class but added the new field | 14:38 |
Kevin_Zheng | mriedem gibi I will ask for detailed usecase and see if it is persuasive enough | 14:38 |
gibi | mriedem: but in the create case we had a separate patch to rename | 14:38 |
gibi | mriedem: so there we kept the version | 14:39 |
mriedem | gibi: then isn't this wrong? https://review.openstack.org/#/c/453077/9/doc/notification_samples/instance-snapshot-start.json@72 | 14:39 |
openstackgerrit | Maciej Kucia proposed openstack/nova-specs master: WIP Extended PCI alias https://review.openstack.org/474218 | 14:39 |
mriedem | shouldn't that be 1.3? | 14:39 |
gibi | mriedem: yes, that is wrong | 14:39 |
mriedem | cool :) | 14:39 |
mriedem | -1! | 14:39 |
mriedem | Kevin_Zheng: thanks | 14:39 |
gibi | mriedem: thanks for founding it :) | 14:39 |
*** slaweq has quit IRC | 14:40 | |
mriedem | sdatko: is this for something you're planning on contributing to nova in the community? or just working on separately downstream? because if it's the latter, i don't really have time to help with forking nova. | 14:41 |
gibi | mriedem: I will be more explicit in the https://review.openstack.org/#/c/453667/ as well about keeping the same version in case of pure rename and bumping it if also content is changed in the same step | 14:41 |
mriedem | gibi: ok i was going to ask that we document this in the devref | 14:42 |
sdatko | mriedem: nothing very important, i am just trying to get into Nova | 14:42 |
sdatko | playing on DevStack :-) Ok, maybe some other time | 14:44 |
sdatko | thanks! | 14:44 |
mriedem | sdatko: ok, i figured with the types of questions you're asking you are trying to implement some out of tree feature | 14:44 |
mriedem | sdatko: ultimately it depends on your use case, but i think if you're just trying to figure out which flavors are being used on which hosts, that can all be done via the REST API / client side tools | 14:45 |
mriedem | if you're working on a scheduler filter or something like that, then it's a different story | 14:45 |
*** psachin has quit IRC | 14:45 | |
*** mhenkel has quit IRC | 14:48 | |
*** zhurong has quit IRC | 14:49 | |
*** mhenkel has joined #openstack-nova | 14:49 | |
kashyap | mriedem: Forgot to respond here, as I was asleep - about your persistent domain question | 14:49 |
kashyap | mriedem: But you answered yourself, and you were right | 14:50 |
*** ckopper has joined #openstack-nova | 14:50 | |
mriedem | kashyap: yeah now just need to know why it takes 5 minutes to remove an ethernet interface device from a guest | 14:50 |
mriedem | was hoping danpb could help with some of that | 14:51 |
kashyap | mriedem: That sounds like an awful lot of time | 14:51 |
* kashyap on a call, be back in a few to pay full attention here | 14:51 | |
*** mingyu has quit IRC | 14:52 | |
*** cfriesen has joined #openstack-nova | 14:52 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | 14:54 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077 | 14:54 |
gibi | mriedem: Fixed the versioning problem in the snapshot_id patch ^^ | 14:54 |
mriedem | kashyap: cool, comments 14 and on are the details https://bugs.launchpad.net/nova/+bug/1696125 | 14:54 |
openstack | Launchpad bug 1696125 in OpenStack Compute (nova) "Detach interface failed - timeout waiting to detach tap device in linuxbridge job (pike)" [High,Confirmed] - Assigned to Matt Riedemann (mriedem) | 14:54 |
*** trinaths has quit IRC | 14:54 | |
mriedem | gibi: cool | 14:54 |
*** mingyu has joined #openstack-nova | 14:57 | |
mriedem | gibi: ok +2 on the instance create payload change https://review.openstack.org/#/c/463001/ now | 14:58 |
gibi | mriedem: thanks for the review! | 14:58 |
gibi | mriedem: and thanks for the feedback on the doc. I will fix it soon | 14:59 |
*** mdrabe_ has joined #openstack-nova | 15:01 | |
*** tidwellr has quit IRC | 15:01 | |
*** ujjain has joined #openstack-nova | 15:02 | |
*** ujjain has quit IRC | 15:02 | |
*** ujjain has joined #openstack-nova | 15:02 | |
*** alexchadin has quit IRC | 15:02 | |
*** danpawlik has quit IRC | 15:03 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800 | 15:03 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | 15:03 |
mriedem | gibi: ok also some issues in https://review.openstack.org/#/c/453077/ | 15:03 |
*** qwertyco has quit IRC | 15:03 | |
*** mamandle has quit IRC | 15:03 | |
mriedem | d'oh | 15:03 |
dansmith | dtantsur: is there an easy way to detect that I'm on the primary node or not? | 15:04 |
dansmith | actually | 15:04 |
*** qwertyco has joined #openstack-nova | 15:04 | |
dansmith | we should probably only run this if we're on a node where there is something like nova-api configured, so I'll do that | 15:04 |
mriedem | dansmith: that's what devstack/stack.sh checks for | 15:05 |
mriedem | so yeah | 15:05 |
*** mdrabe has quit IRC | 15:05 | |
dansmith | yeah | 15:05 |
gibi | mriedem: I have to run now, but will get back to the snapshot patch tomorrow morning. thanks again for the review! | 15:05 |
mriedem | yw | 15:06 |
*** gjayavelu has joined #openstack-nova | 15:06 | |
*** mingyu has quit IRC | 15:07 | |
*** alex_xu has quit IRC | 15:07 | |
*** alex_xu has joined #openstack-nova | 15:07 | |
mriedem | man we don't even go over conductor for compute_node_statistics | 15:07 |
dansmith | mriedem: well, it's api only, so we wouldn't | 15:08 |
dansmith | but no objects yeah | 15:08 |
dtantsur | dansmith: seems so: https://github.com/openstack/ironic/blob/870d909cc7e0c6118a174d412ae814953bb805e1/devstack/lib/ironic#L377-L384 | 15:08 |
*** moshele has quit IRC | 15:09 | |
dansmith | dtantsur: I think checking for n-api is the devstacky way | 15:09 |
dansmith | dtantsur: just pushed a rev for that | 15:09 |
dtantsur | thanks, I'll check after a meeting (and probably after Jenkins agrees with it) | 15:09 |
dansmith | cool, thanks | 15:09 |
dansmith | I'll be keeping an eye on it too of course :) | 15:09 |
dansmith | glad we (mriedem) caught this before we landed it and broke ironic this time :) | 15:10 |
mriedem | \o/ | 15:10 |
dansmith | heh | 15:10 |
*** Sukhdev has joined #openstack-nova | 15:10 | |
*** qwertyco has quit IRC | 15:12 | |
*** mingyu has joined #openstack-nova | 15:13 | |
*** salv-orlando has joined #openstack-nova | 15:16 | |
kashyap | mriedem: Nice sleuthing on comment#16 | 15:17 |
kashyap | How did you guess it could be related to AppArmour? | 15:18 |
*** mingyu has quit IRC | 15:18 | |
mriedem | kashyap: i'm not sure that it is, | 15:18 |
* kashyap clicks on the URLs from comment#19 | 15:18 | |
mriedem | kashyap: but we've had those previous bugs where based on the version of libvirt, the script path in the interface xml has to be None or '' | 15:18 |
mriedem | to tell qemu use the default, which is /etc/qemu-ifup | 15:18 |
mriedem | and apparmor could be blocking that script | 15:18 |
kashyap | mriedem: Yeah, just checking with Laine Stump on OFTC network, who mediatates on libvirt networking | 15:19 |
kashyap | mriedem: Yeah, I recall the script path thing, that's fixed, no | 15:20 |
kashyap | ? | 15:20 |
mriedem | it is | 15:21 |
mriedem | kashyap: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/designer.py#L62 | 15:21 |
*** cdent has joined #openstack-nova | 15:21 | |
*** mingyu has joined #openstack-nova | 15:22 | |
mriedem | jaypipes: are you able to pull out of your bag of lore what the simple difference between disk_available_least and free_disk_gb is? | 15:24 |
mriedem | because the descriptions on those response parameters in https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-statistics-detail#show-hypervisor-statistics is not clear | 15:24 |
*** mingyu has quit IRC | 15:25 | |
kashyap | mriedem: Laine & DanPB said: Without looking at data from the guest, it's hard to say *where* precisely is the delay lurking | 15:25 |
jaypipes | mriedem: it's not clear because the implementation/design of it all is unclear... | 15:25 |
mriedem | jaypipes: plus it depends on backend storage doesn't it? | 15:25 |
mriedem | e.g. ceph vs others | 15:25 |
jaypipes | mriedem: disk_available_least is essentially the worst-case scenario whereas free_disk_gb considers sparse disks as not consuming their entire mapping file | 15:26 |
kashyap | mriedem: Are you able to reproduce this issue? You note a hit in the bug | 15:26 |
jaypipes | s/mapping/backing | 15:26 |
mriedem | kashyap: reproduce locally? i haven't tried. | 15:26 |
kashyap | mriedem: Okay, here's what the folks from #virt say: | 15:26 |
mriedem | kashyap: we had a recreate in upstream ci which is where i pulled and dug through those libvirtd logs | 15:26 |
*** ArchiFleKs has quit IRC | 15:26 | |
kashyap | 17:19 < danpb> kashyap: suggests the guest OS is not honouring the unplug event promtly | 15:26 |
kashyap | 17:20 < danpb> kashyap: or perhaps it is honouring it, but something in the guest is waiting 5 minutes for something to happen before offlineing the nic | 15:27 |
kashyap | 17:20 < danpb> its hard to say for sure without getting data from the guest os really | 15:27 |
kashyap | 17:24 <@laine> kashyap: I was going to suggest what danpb suggested - the delay could be on the guest. | 15:27 |
kashyap | 17:25 < danpb> i'm not even sure how to get any data from the guest | 15:27 |
kashyap | 17:26 < danpb> might need udev event logs for example | 15:27 |
kashyap | mriedem: Does DevStack log 'udev' events? /me thinks no | 15:27 |
mriedem | kashyap: hmm, ok - is there some way to get information out of the guest, like the qemu guest agent? or should we dump the console when this times out? | 15:28 |
mriedem | kashyap: don't know | 15:28 |
* cdent deeply appreciates efried's use of language, such as "dig" | 15:28 | |
* efried likes to keep it real, yo. | 15:28 | |
kashyap | mriedem: Guest Agent is a good idea, but I'm not sure if it gives us what we need here. /me taps on the table and thinks | 15:28 |
kashyap | And looks at the man pages | 15:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: cleanup PUT /os-hypervisors/statistics docs https://review.openstack.org/474250 | 15:30 |
*** gszasz has quit IRC | 15:30 | |
*** gyee has joined #openstack-nova | 15:32 | |
*** pabardina has quit IRC | 15:33 | |
*** nic1 has joined #openstack-nova | 15:34 | |
*** tidwellr has joined #openstack-nova | 15:35 | |
*** ArchiFleKs has joined #openstack-nova | 15:36 | |
*** andreas_s has quit IRC | 15:36 | |
*** yamahata has quit IRC | 15:39 | |
*** armax has quit IRC | 15:40 | |
*** armax has joined #openstack-nova | 15:40 | |
*** armax has quit IRC | 15:42 | |
*** mvk has quit IRC | 15:45 | |
*** ArchiFleKs has quit IRC | 15:46 | |
openstackgerrit | Merged openstack/nova master: Indicate Hyper-v supports fibre channel in support matrix https://review.openstack.org/473986 | 15:47 |
*** burt has joined #openstack-nova | 15:48 | |
openstackgerrit | Merged openstack/nova master: Remove service control from feature support matrix https://review.openstack.org/473989 | 15:48 |
*** damien_r has quit IRC | 15:51 | |
*** Apoorva has joined #openstack-nova | 15:52 | |
jaypipes | melwitt: I'm going to rebase 469635 and fix bauzas' comments from the dependent patch. ok with you? | 15:54 |
melwitt | jaypipes: I'm in the middle of doing it right now | 15:54 |
jaypipes | melwitt: ah, no probs! | 15:55 |
* jaypipes redirecs | 15:55 | |
melwitt | thanks though | 15:55 |
jaypipes | :) | 15:55 |
*** f10d4 has left #openstack-nova | 15:55 | |
*** fragatina has quit IRC | 15:56 | |
*** trinaths has joined #openstack-nova | 15:56 | |
*** fragatina has joined #openstack-nova | 15:56 | |
*** trinaths has left #openstack-nova | 15:56 | |
*** ArchiFleKs has joined #openstack-nova | 15:57 | |
*** mingyu has joined #openstack-nova | 15:57 | |
melwitt | jaypipes: should I add the api-refs? that's the only thing I wasn't clear on | 15:58 |
jaypipes | melwitt: no, since the allocations api-ref is a dependency and we're still working on that | 15:58 |
* melwitt nods | 15:58 | |
jaypipes | melwitt: kinda pointless adding an api-ref about usages that discusses allocations and not have an api-ref on allocations :) | 15:59 |
*** yamamoto has quit IRC | 15:59 | |
jaypipes | which I mentioned to bauzas on 469635 | 15:59 |
melwitt | agreed | 15:59 |
jaypipes | avolkov and jichenc are working on allocations api-ref | 15:59 |
melwitt | sweet | 16:00 |
*** itlinux_ has joined #openstack-nova | 16:01 | |
*** yamamoto has joined #openstack-nova | 16:01 | |
*** gszasz has joined #openstack-nova | 16:04 | |
*** sree has joined #openstack-nova | 16:06 | |
*** yamamoto has quit IRC | 16:07 | |
*** Oku_OS is now known as Oku_OS-away | 16:08 | |
*** p01nt3r75 has quit IRC | 16:11 | |
*** sree has quit IRC | 16:11 | |
*** Sukhdev_ has joined #openstack-nova | 16:12 | |
*** yamahata has joined #openstack-nova | 16:13 | |
*** nic1 is now known as nic | 16:14 | |
*** gbarros has quit IRC | 16:16 | |
openstackgerrit | Merged openstack/python-novaclient master: Clean up ShellTest unit tests https://review.openstack.org/473910 | 16:17 |
*** gbarros has joined #openstack-nova | 16:18 | |
*** gszasz has quit IRC | 16:20 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514 | 16:21 |
*** suresh12 has joined #openstack-nova | 16:22 | |
*** jmlowe has quit IRC | 16:23 | |
*** masber has quit IRC | 16:27 | |
melwitt | jaypipes: quick question, did you want to do something about the fetchall() bauzas mentioned? I addressed everything except that and the api-refs | 16:28 |
*** masber has joined #openstack-nova | 16:28 | |
melwitt | in my local changes | 16:28 |
melwitt | jaypipes: I can just push what I have and if you want to do anything about the fetchall(), I'll leave it to you :) | 16:30 |
openstackgerrit | melanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | 16:31 |
openstackgerrit | melanie witt proposed openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | 16:31 |
jaypipes | melwitt: meh? :) | 16:31 |
*** ralonsoh has quit IRC | 16:31 | |
*** dtantsur is now known as dtantsur|afk | 16:32 | |
*** gszasz has joined #openstack-nova | 16:33 | |
*** mdrabe_ is now known as mdrabe | 16:33 | |
*** rajathagasthya has joined #openstack-nova | 16:33 | |
*** suresh12 has quit IRC | 16:34 | |
*** david-lyle_ is now known as david-lyle | 16:35 | |
*** gjayavelu has quit IRC | 16:35 | |
*** gomarivera has joined #openstack-nova | 16:36 | |
*** suresh12 has joined #openstack-nova | 16:38 | |
openstackgerrit | melanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | 16:42 |
openstackgerrit | melanie witt proposed openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | 16:42 |
*** annegentle has joined #openstack-nova | 16:42 | |
*** lucasxu has quit IRC | 16:43 | |
*** roeyc has joined #openstack-nova | 16:43 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Only auto-disable new nova-compute services https://review.openstack.org/474285 | 16:43 |
*** gbarros has quit IRC | 16:44 | |
*** sambetts is now known as sambetts|Afk | 16:44 | |
*** sambetts|Afk is now known as sambetts|afk | 16:44 | |
*** gbarros has joined #openstack-nova | 16:46 | |
*** jmlowe has joined #openstack-nova | 16:46 | |
*** armax has joined #openstack-nova | 16:46 | |
*** rcernin has quit IRC | 16:49 | |
*** roeyc1 has joined #openstack-nova | 16:50 | |
*** ijw has joined #openstack-nova | 16:51 | |
*** ijw has quit IRC | 16:51 | |
*** sudipto has quit IRC | 16:51 | |
*** sudipto_ has quit IRC | 16:51 | |
*** ijw has joined #openstack-nova | 16:51 | |
*** ijw has quit IRC | 16:52 | |
*** roeyc has quit IRC | 16:52 | |
*** ijw has joined #openstack-nova | 16:52 | |
*** tesseract has quit IRC | 16:56 | |
*** suresh12 has quit IRC | 16:56 | |
*** mvk has joined #openstack-nova | 16:59 | |
*** roeyc has joined #openstack-nova | 16:59 | |
*** roeyc1 has quit IRC | 17:01 | |
*** catintheroof has quit IRC | 17:02 | |
*** salv-orl_ has joined #openstack-nova | 17:03 | |
*** catintheroof has joined #openstack-nova | 17:03 | |
*** roeyc has quit IRC | 17:03 | |
*** yamamoto has joined #openstack-nova | 17:03 | |
*** derekh has quit IRC | 17:04 | |
*** markus_z has quit IRC | 17:05 | |
*** salv-orlando has quit IRC | 17:05 | |
cfriesen | bauzas: you on? | 17:07 |
*** moshele has joined #openstack-nova | 17:09 | |
*** lpetrut has quit IRC | 17:10 | |
cfriesen | bauzas: (and any other cores) I'm running into an issue that prevents cold migrating an instance created originally on Liberty or earlier from a Mitaka compute node to a Newton compute node. It appears that until you run "nova db online_data_migrations" to create the missing RequestSpec you can't migrate. Traceback at http://paste.openstack.org/show/612574/ | 17:11 |
cfriesen | Is this design intent? If so, it would seem to preclude an upgrade involving an underlying OS upgrade at the same time as an openstack upgrade. | 17:12 |
cfriesen | (note: some of the line numbers might not quite match up with upstream newton since we've patched some things) | 17:13 |
cfriesen | I'm confirming vanilla stable/newton now | 17:13 |
*** lucasagomes is now known as lucas-afk | 17:16 | |
*** cdent has quit IRC | 17:17 | |
*** yamamoto has quit IRC | 17:18 | |
*** yassine has quit IRC | 17:20 | |
*** kfarr has quit IRC | 17:20 | |
*** moshele has quit IRC | 17:22 | |
mriedem | melwitt: ah i see now, objects.Quotas._remove_members_in_db - yeah that won't work :) | 17:23 |
*** jpena is now known as jpena|off | 17:24 | |
melwitt | mriedem: yup. thanks for pointing out the lack of tests. I added similar tests to all the "Count <resource> to check quota" patches except instances, that one is in progress | 17:24 |
*** rajathagasthya has quit IRC | 17:25 | |
cfriesen | mriedem: do you know whether the above issue ^ is design intent? It seems like an oversight. Basically we call objects.RequestSpec.save() on a brand new object, which calls _save_in_db(), which calls RequestSpec._get_by_instance_uuid_from_db(), which raises exception.RequestSpecNotFound() | 17:27 |
mriedem | cfriesen: would have to dig, but bauzas is the best answer for that, but he's on PTO today | 17:27 |
mriedem | back tomorrow | 17:27 |
mriedem | and i can't dig right now | 17:28 |
*** efoley has quit IRC | 17:28 | |
cfriesen | generally speaking it seems like the newton code is assuming that we've already run "nova db online_data_migrations", but we can't run that until all the nodes are running newton | 17:28 |
*** yassine has joined #openstack-nova | 17:28 | |
dansmith | cfriesen: why do you think it's an oversight? the newer nodes expect request specs to be in place, the online data migration corrects them for older instances | 17:28 |
dansmith | cfriesen: that's not true, | 17:29 |
*** gszasz has quit IRC | 17:29 | |
*** pcaruana has quit IRC | 17:29 | |
cfriesen | dansmith: what's not true? | 17:29 |
dansmith | you can run it right after you've upgraded your schema, after control services are upgraded | 17:29 |
dansmith | can/should | 17:29 |
dansmith | and anything that can't run because computes aren't upgraded won't, like that pci one | 17:29 |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Canary https://review.openstack.org/473565 | 17:30 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make compute_node_statistics() work across cells https://review.openstack.org/473931 | 17:30 |
cfriesen | dansmith: https://docs.openstack.org/developer/nova/upgrade.html says to run it "once all services are running the new code" | 17:31 |
cfriesen | dansmith: or at least in the "after maintenance window" section along with other stuff that runs after all services are upgraded | 17:32 |
*** annegentle has quit IRC | 17:32 | |
cfriesen | dansmith: so you're saying to run it once after control services are upgraded and then again after everything is upgraded? | 17:32 |
dansmith | yeah, I see the confusion, | 17:32 |
dansmith | what that's describing is the maintenance window for your control services, which requires total downtime, | 17:32 |
dansmith | after which you can roll your computes later | 17:33 |
*** gbarros has quit IRC | 17:33 | |
*** annegentle has joined #openstack-nova | 17:33 | |
dansmith | although it's also confusing the situation with the config bits being before that | 17:33 |
cfriesen | dansmith: it can't be the maintenance window for just control services, it talks about bumping the RPC version | 17:33 |
cfriesen | "Once all the services are running the latest version of the code, and all the services are aware they all have been upgraded, it is safe to transform the data in the database into its new format." | 17:34 |
dansmith | yeah, its' confusing | 17:34 |
dansmith | normally you wouldn't really have to run it twice, and either after control or after everything is done would be enough, | 17:34 |
dansmith | but if you've got a release where there are critical things on both sides... | 17:35 |
cfriesen | dansmith: do we guarantee that the online data migrations won't change things in such a way that they break old compute nodes? | 17:35 |
dansmith | that's the whole point of conductor | 17:35 |
dansmith | to insulate computes from those changes | 17:35 |
*** lucasxu has joined #openstack-nova | 17:39 | |
cfriesen | dansmith: okay. that answers my question, but I think we need to update the docs at https://docs.openstack.org/developer/nova/upgrade.html to make it clear that the online data migrations should be run earlier *during* the maintenance window. | 17:40 |
cfriesen | dansmith: and remove the comments that talk about it only needing to be run before the upgrade to the *next* version | 17:41 |
*** gjayavelu has joined #openstack-nova | 17:41 | |
*** itlinux_ has quit IRC | 17:41 | |
dansmith | cfriesen: perhaps mentioning that if you fail to reduce the remaining updates past a certain threshold, those may be things that need to run again later | 17:41 |
openstackgerrit | melanie witt proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634 | 17:42 |
openstackgerrit | melanie witt proposed openstack/nova master: placement: Add GET /usages to placement API https://review.openstack.org/469635 | 17:42 |
cfriesen | dansmith: doesn't anything greater than zero mean you need to re-run it later? | 17:42 |
dansmith | I probably wrote that text and was writing it attempting to hit a generic scenario without mentioning every possibility, where I just put it in the process somewhere | 17:42 |
dansmith | cfriesen: if you run with --until-done or whatever, yeah | 17:43 |
cfriesen | dansmith: originally I think the idea was that you'd only need to run the online_data_migrations sometime before the next upgrade...that's the way it's written at https://docs.openstack.org/releasenotes/nova/newton.html | 17:43 |
cfriesen | "... budget time to run these online migrations before you plan to upgrade to ocata" | 17:43 |
dansmith | cfriesen: that has never been the "design intent" | 17:44 |
*** eandersson has joined #openstack-nova | 17:44 | |
dansmith | because as those docs say, you're expecting more conductor load during the period where you're not fully migrated, so budget resources for that | 17:44 |
cfriesen | dansmith: there's been a disconnect then, because that sort of wording is all over the upstream documentation around upgrades | 17:45 |
*** sudipto has joined #openstack-nova | 17:45 | |
*** sudipto_ has joined #openstack-nova | 17:46 | |
dansmith | cfriesen: patches welcome | 17:46 |
*** Apoorva_ has joined #openstack-nova | 17:46 | |
*** Sukhdev_ has quit IRC | 17:47 | |
*** burt has quit IRC | 17:48 | |
*** tbachman has quit IRC | 17:49 | |
*** Apoorva has quit IRC | 17:50 | |
cfriesen | dansmith: maybe next week. I'm now going to be busy modifying our automated upgrade tools and retesting everything. | 17:50 |
*** Apoorva_ has quit IRC | 17:51 | |
*** Apoorva has joined #openstack-nova | 17:52 | |
cfriesen | this won't impact people that upgrade nova-compute with all the guests still running....it's only a factor if you want to migrate all the instances off the "old" compute node to upgrade the OS as well. | 17:56 |
*** yamamoto has joined #openstack-nova | 17:57 | |
*** itlinux_ has joined #openstack-nova | 17:57 | |
*** fragatina has quit IRC | 17:58 | |
*** suresh12 has joined #openstack-nova | 17:58 | |
*** roeyc has joined #openstack-nova | 17:59 | |
*** tbachman has joined #openstack-nova | 17:59 | |
*** dtp has joined #openstack-nova | 17:59 | |
cfriesen | dansmith: question for you....if some online migrations can't complete until all the services are upgraded (like pcidevice_online_data_migration()) and others *must* complete in order to allow things to function, how does the person running the command know if it's safe to proceed? | 17:59 |
*** gbarros has joined #openstack-nova | 18:00 | |
cfriesen | dansmith: it makes it really hard to reliably automate the call to "nova-manage db online_data_migrations" | 18:01 |
*** sudipto_ has quit IRC | 18:01 | |
*** sudipto has quit IRC | 18:01 | |
cfriesen | seems to me we need to break it up into two calls, one right after the control services are upgraded, and one after all the compute nodes are also upgraded | 18:02 |
dansmith | we've only ever had that one thing that needed to run after computes are up, and it's gone now | 18:03 |
dansmith | it's a very exceptional case and once you did it on any release it was present on, it was done | 18:03 |
dansmith | so not in favor of complicating things further based on one exceptional example | 18:03 |
dansmith | it could have printed a warning explanation and been fine I think | 18:04 |
dansmith | "sorry homey, I can't finish until after, so blah blah" | 18:04 |
cfriesen | dansmith: okay, didn't realize that was the only thing ever | 18:04 |
dansmith | yep, the only one ever, which is why in my head, you do this when control is upgraded | 18:04 |
*** nicolasbock has quit IRC | 18:04 | |
*** cheran has joined #openstack-nova | 18:05 | |
*** roeyc has quit IRC | 18:05 | |
*** nicolasbock has joined #openstack-nova | 18:05 | |
*** gbarros has quit IRC | 18:12 | |
*** itlinux_ has quit IRC | 18:14 | |
*** qwertyco has joined #openstack-nova | 18:16 | |
*** gbarros has joined #openstack-nova | 18:16 | |
*** itlinux has joined #openstack-nova | 18:16 | |
*** annegentle has quit IRC | 18:16 | |
*** tidwellr has quit IRC | 18:18 | |
*** annegentle has joined #openstack-nova | 18:20 | |
*** ijw has quit IRC | 18:20 | |
mnaser | i'm trying to do some perf tweaking and i'm just curious on why a relatively idle 60-ish node cloud conductor rabbitmq message rates is at ~20/s | 18:21 |
*** tidwellr has joined #openstack-nova | 18:21 | |
mnaser | i increased the service report interval from 10 seconds up to 60s | 18:21 |
mnaser | and why i say relatively idle, there is no new servers being added/deleted etc | 18:22 |
*** gbarros has quit IRC | 18:25 | |
mriedem | melwitt: one small thing in here https://review.openstack.org/#/c/446241/ | 18:27 |
mriedem | melwitt: in a normal network delete, we call network_api.disassociate and then delete, | 18:27 |
mriedem | so we should do the same for that rollback | 18:27 |
mriedem | melwitt: i also found a fun latent networks quota bug in there | 18:27 |
mriedem | mnaser: could be a few things, periodic tasks in the computes come to mine | 18:28 |
mriedem | *mind | 18:28 |
*** gbarros has joined #openstack-nova | 18:29 | |
melwitt | mriedem: cool, thanks. looking | 18:29 |
mriedem | might also depend on if you have instance_usage_audit enabled to send notifications | 18:29 |
edleafe | mnaser: You should probably ask on the #openstack channel. See #topic | 18:29 |
mriedem | edleafe: i actually want to know what mnaser is doing and finding out, given he runs vexxhost :) | 18:30 |
mnaser | edleafe im aware, i was just looking more on the internals of nova, i wasn't looking for a "how to fix" but more of a "what components would be good to look at" | 18:30 |
mriedem | mnaser: the computes are going to be running periodic tasks and pulling instances from the database over conductor | 18:30 |
mnaser | mriedem we toned down the service check ins (which is used by the services / scheduler) to 1 minute + 4 minute service_down_time and that helped | 18:30 |
mriedem | which is going to be rpc traffic | 18:30 |
mriedem | mnaser: this isn't the service check in | 18:31 |
*** salv-orl_ has quit IRC | 18:31 | |
mnaser | but yeah, periodic tasks is not something i've touched on yet | 18:31 |
mriedem | with the service group api | 18:31 |
mriedem | this would be things like the update_available_resources periodic task in the compute | 18:31 |
mriedem | that runs every minute by default to update resource usage information in the compute_nodes table and in the placement api | 18:31 |
*** egonzalez has joined #openstack-nova | 18:31 | |
mriedem | mnaser: which release? | 18:31 |
mriedem | there is also the instance_usage_audit task but that's disabled by default | 18:31 |
mnaser | i'll throw up debugging on a compute node | 18:31 |
mnaser | newton atm, no placement service in place yet | 18:32 |
mriedem | ok | 18:32 |
mnaser | yeah instance_usage_audit is off (well, i havent verified but notifications queue is empty and no consumers for it) | 18:32 |
mriedem | even w/o placement there is probably a lot of steady state traffic | 18:32 |
mriedem | the computes are also sending instance info to the filter scheduler every minute | 18:32 |
mriedem | *all* computes | 18:32 |
mriedem | even if you're not using the filter scheduler | 18:32 |
mriedem | you're welcome | 18:32 |
mnaser | lol! | 18:32 |
mriedem | are you using the filter scheduler or caching scheduler? | 18:33 |
mnaser | we are so i guess that helps, but 60 nodes every minute means 60 updates only so that averages to just one per second (and i think fuzzing in place in nova can help alleviate the big burst) | 18:33 |
mnaser | caching scheduler...? til. | 18:33 |
mnaser | the filter does the job for us though we had to reorder things because it took too long sometimes | 18:33 |
mnaser | aka computefilter is the last one but by the time it runs, "service is down" | 18:34 |
mnaser | (i dont know why it isn't earlier in by default, considering it's one of the more fundamental ones that might drop a whole bunch) | 18:34 |
mriedem | these are the current defaults | 18:35 |
mriedem | default=[ | 18:35 |
mriedem | "RetryFilter", | 18:35 |
mriedem | "AvailabilityZoneFilter", | 18:35 |
mriedem | "RamFilter", | 18:35 |
mriedem | "DiskFilter", | 18:35 |
mriedem | "ComputeFilter", | 18:35 |
mriedem | "ComputeCapabilitiesFilter", | 18:35 |
mriedem | "ImagePropertiesFilter", | 18:35 |
mriedem | "ServerGroupAntiAffinityFilter", | 18:35 |
mriedem | "ServerGroupAffinityFilter", | 18:35 |
mriedem | ], | 18:35 |
mriedem | i think we can drop ramfilter and diskfilter from defaults now that we have placement required in ocata, but would have to check that out again | 18:35 |
mnaser | computefilter pretty much checks if service is alive | 18:35 |
mnaser | so... id imagine that's more important than figuring out if you have enough ram | 18:36 |
mnaser | but i guess the logic was ram will eliminate a bigger subset of possiblities rather than disabled nodes | 18:36 |
mnaser | but yeah, placement mix address a whole bunch of that | 18:36 |
mriedem | assuming there was logic | 18:36 |
mriedem | mnaser: anyway, let us know if you find anything | 18:36 |
mriedem | i always like to hear about performance issues | 18:37 |
mnaser | we've had some neutron ones but so far with nova, it's just trying to see how we can minimize rpc traffic so to handle big loads | 18:37 |
mnaser | we had the pleasure of an api request with num_instances => 200 | 18:37 |
*** ujjain has quit IRC | 18:38 | |
mnaser | nova seemed to cope well, but neutron couldn't catch up (more specifically neutron-dhcp-agent), so at some point instance port plugging started timing out (vif_plugging_timeout was getting hit) | 18:38 |
*** efried has quit IRC | 18:38 | |
mnaser | which did raise the issue of.. there is no way of limiting num_instances in api requests (based on my research of the code base), so if the quota is 100 vms.. with one api request you can cause a lot of trouble (rate limiting wouldn't be a solution here considering its a single request) | 18:40 |
mriedem | eesh that's a good point | 18:41 |
mriedem | i thought there was a port quota in neutron of 50 by default? | 18:41 |
mnaser | right, but we naturally raise the port quota when we increase the VM quota anyways | 18:42 |
mriedem | the compute api checks with neutron how many ports can be created in a single multi-instance create run | 18:42 |
mriedem | ok | 18:42 |
mnaser | so say you have 200 vms quota, 200 ports quota in neutron, you can send a request with num_instances = 200 and things can get a bit messy | 18:42 |
mriedem | i'd have to look but i think if you ask for 200 but you can only get 100, we drop the count down to 100 based on how many ports neutron will let you create | 18:42 |
mriedem | but then it's a race to the computes which actually create the ports | 18:43 |
mnaser | thing is: i'm okay with a customer having 200 vms, it's just the "create them all at once" thing that ends up hurting a bit | 18:43 |
mnaser | because then not only do their vms end up in error states but all new vms timeout in spawning until neutron-dhcp-agent catches up (because reload_allocations does 1 network at a time, one port update at a time) | 18:44 |
mriedem | yeah we don't have any cap on how many instances you can ask for in the REST API schema itself | 18:44 |
mriedem | melwitt: speaking of api quota things, and your networks quota patch, do you remember if you can even POST /os-tenant-networks in cells v1? | 18:45 |
mnaser | so the dhcp agent queue grows (and the problem gets even worse when these vms fail, all the ports that failed to get activated receive a delete request, and you just doubled the size of that queue as the dhcp agent is updated about "deleting" them) | 18:45 |
mnaser | but that's more of a neutron side of things i'm hoping to bring up | 18:45 |
mriedem | that will also cause api traffice between nova and neutron when the ports are deleted | 18:45 |
melwitt | mriedem: I think you can, it just won't propagate to child cells at all, so would not result in any instance being able to use the new network if you added one | 18:46 |
mriedem | nova deletes the port, neutron sends an api request back to nova saying something change via the os-server-external-events api, which rpc casts to the compute to do some cleanup | 18:46 |
*** Sukhdev_ has joined #openstack-nova | 18:47 | |
mriedem | melwitt: so you can, but it doesn't work | 18:47 |
mnaser | yeah, it just causes a lot of bad times overall | 18:47 |
mriedem | so you can't :) | 18:47 |
*** qwertyco has quit IRC | 18:47 | |
mnaser | workaround would be to bring vif_plugging_timeout up but .. 300 seconds is already long enough :x | 18:47 |
mriedem | melwitt: i see we exclude tempest test test_list_show_tenant_networks from the cells v1 job | 18:48 |
*** mingyu has quit IRC | 18:49 | |
mriedem | melwitt: i just got thinking about that because of my rubiks cube questions in that change about assuming single cell for getting all networks | 18:49 |
mriedem | took me to a dark place about cells v1 and cells v2 and nova-network and what won't work | 18:49 |
melwitt | mriedem: that stuff is nova-network only too, I think. the create/delete network stuff | 18:50 |
mriedem | melwitt: yes for os-tenant-networks it is | 18:51 |
*** efried has joined #openstack-nova | 18:52 | |
melwitt | yeah | 18:52 |
*** suresh12 has quit IRC | 18:52 | |
*** suresh12_ has joined #openstack-nova | 18:53 | |
*** suresh12_ has quit IRC | 18:55 | |
mriedem | dansmith: whenever we declare support for multiple v2 cells in the release notes, we should remember to mention that excludes nova-network https://review.openstack.org/#/c/446241/20/nova/api/openstack/compute/tenant_networks.py@200 | 18:56 |
*** ijw has joined #openstack-nova | 19:03 | |
*** jwcroppe has quit IRC | 19:05 | |
*** burt has joined #openstack-nova | 19:06 | |
*** jwcroppe has joined #openstack-nova | 19:06 | |
*** rcernin has joined #openstack-nova | 19:10 | |
*** jwcroppe has quit IRC | 19:11 | |
*** moshele has joined #openstack-nova | 19:15 | |
*** tidwellr has quit IRC | 19:16 | |
*** liuqing has quit IRC | 19:18 | |
*** nicolasbock has quit IRC | 19:22 | |
*** jose-phillips has quit IRC | 19:22 | |
*** moshele has quit IRC | 19:24 | |
*** annegentle has quit IRC | 19:27 | |
dansmith | mriedem: totes | 19:34 |
*** sree has joined #openstack-nova | 19:34 | |
*** crushil has quit IRC | 19:37 | |
*** sree has quit IRC | 19:39 | |
*** awaugama has quit IRC | 19:43 | |
*** tbachman has quit IRC | 19:44 | |
*** awaugama has joined #openstack-nova | 19:46 | |
*** crushil has joined #openstack-nova | 19:47 | |
*** tidwellr has joined #openstack-nova | 19:48 | |
*** pchavva has quit IRC | 19:50 | |
cfriesen | dansmith: this may be an issue for bauzas, but I had an entry in the DB for the "pci_requests" column in the "instance_extra" table. I then ran the online DB migrations which generated a new RequestSpec for the instance, but the generated RequestSpec for this instance has an emtpy list of pci requests and the "pci_requests" column in "instance_extra" is now empty | 19:59 |
*** annegentle has joined #openstack-nova | 20:00 | |
*** Apoorva has quit IRC | 20:00 | |
melwitt | mriedem: replied on the networks quota patch. it seems to me that disassociate is only needed if associate could ever have happened and in the recheck_quota case, it couldn't have. do you think we should still do disassociate anyway? | 20:03 |
mriedem | melwitt: is that the POST /os-networks/{network_id}/action "associate_host" action? | 20:07 |
*** suresh12 has joined #openstack-nova | 20:08 | |
melwitt | lemme see ... whatever calls the nova-network manager's associate method | 20:09 |
mriedem | os-networks-associate | 20:09 |
melwitt | this is so confusing | 20:10 |
melwitt | anyway, I'm not opposed to adding the disassociate call, I just noticed I don't think it would ever do anything | 20:10 |
mriedem | no i think you're right | 20:11 |
melwitt | I'm going to have to respin anyway for the errant CellDatabases fixture change | 20:11 |
*** awaugama has quit IRC | 20:11 | |
melwitt | and the cleanup() function that never gets called probably. it's just weird how all of the fixtures have it wrong | 20:12 |
melwitt | I don't know why we haven't seen any problems around that | 20:12 |
*** itlinux has quit IRC | 20:13 | |
*** rajathagasthya has joined #openstack-nova | 20:14 | |
mriedem | melwitt: i replied about that too | 20:14 |
mriedem | and the other | 20:14 |
mriedem | so i guess just fix that cells db fixture thing and i'm +2 | 20:14 |
mriedem | speaking of confusing, | 20:15 |
mriedem | https://developer.openstack.org/api-ref/compute/#hypervisors-os-hypervisors | 20:15 |
melwitt | mriedem: thanks. yeah changing it to cleanUp broke stuff. gah | 20:15 |
mriedem | i'm trying to jam GET /os-hypervisors/{hypervisor_hostname_pattern}/servers and GET /os-hypervisors/{hypervisor_hostname_pattern}/search into GET /os-hypervisors now | 20:15 |
mriedem | plus paging | 20:15 |
mriedem | this is going to be bug city, and the code is nearly unreadable | 20:16 |
melwitt | good times | 20:16 |
*** Apoorva has joined #openstack-nova | 20:17 | |
*** awaugama has joined #openstack-nova | 20:18 | |
*** xyang1 has quit IRC | 20:18 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 20:21 |
openstackgerrit | melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862 | 20:21 |
*** ijw has quit IRC | 20:22 | |
*** smatzek has quit IRC | 20:22 | |
*** gjayavelu has quit IRC | 20:22 | |
mriedem | oomichi: do you remember why we need to apply the validation.query_schema on all api versioned methods even if some microversions don't have query parameters? | 20:24 |
mriedem | oomichi: for example, GET /os-keypairs/{id} on 2.1 has https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/keypairs.py#L205 | 20:25 |
mriedem | which is an empty schema | 20:25 |
mriedem | but then 2.10 has query parameter schema for passing a user_id https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/keypairs.py#L191 | 20:25 |
mriedem | so i understand why we have that for the 2.10 method, but not for 2.1 or 2.2 | 20:25 |
*** Sukhdev has quit IRC | 20:30 | |
*** liverpooler has quit IRC | 20:34 | |
*** jdurgin has quit IRC | 20:34 | |
mriedem | oy, i suppose a compute_nodes.hypervisor_hostname field can be an IP? | 20:39 |
mriedem | or a uuid in the case of ironic | 20:40 |
mriedem | that makes GET /os-hypervisors/{hypervisor_hostname_pattern}/search fun if you're using ironic | 20:40 |
mriedem | and this looks wrong https://developer.openstack.org/api-ref/compute/?expanded=search-hypervisor-detail#search-hypervisor | 20:41 |
mriedem | "The hypervisor host name provided by the Nova virt driver. For the Ironic driver, it is the Ironic node name." | 20:41 |
mriedem | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L332 | 20:42 |
*** gouthamr has quit IRC | 20:45 | |
*** itlinux has joined #openstack-nova | 20:45 | |
*** itlinux has quit IRC | 20:46 | |
*** dimtruck is now known as zz_dimtruck | 20:49 | |
*** jwcroppe has joined #openstack-nova | 20:52 | |
*** jwcroppe has quit IRC | 20:52 | |
*** jwcroppe has joined #openstack-nova | 20:52 | |
*** tbachman has joined #openstack-nova | 20:52 | |
*** awaugama has quit IRC | 20:55 | |
*** Swami has joined #openstack-nova | 20:56 | |
cfriesen | does nova-conductor need to be running in order to run "nova db online_data_migrations"? | 20:56 |
melwitt | cells meeting in 4 minutes | 20:56 |
*** Apoorva_ has joined #openstack-nova | 21:01 | |
*** jdurgin has joined #openstack-nova | 21:01 | |
*** itlinux_ has joined #openstack-nova | 21:04 | |
*** Apoorva has quit IRC | 21:04 | |
*** jmlowe has quit IRC | 21:05 | |
*** jdurgin has quit IRC | 21:05 | |
*** lucasxu has quit IRC | 21:06 | |
*** cleong has quit IRC | 21:09 | |
*** egonzalez has quit IRC | 21:11 | |
*** edmondsw has quit IRC | 21:11 | |
*** gouthamr has joined #openstack-nova | 21:12 | |
*** zz_dimtruck is now known as dimtruck | 21:15 | |
*** eharney has quit IRC | 21:16 | |
*** kylek3h has quit IRC | 21:16 | |
*** ericyoung has quit IRC | 21:17 | |
eandersson | Anyone that got some time to help me look into this :D | 21:18 |
eandersson | https://review.openstack.org/#/c/390984 | 21:18 |
eandersson | I am trying to figure out why the Server Group Tests are failing because the resource usage isn't always updated. | 21:19 |
*** baoli has quit IRC | 21:19 | |
eandersson | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L168 | 21:19 |
eandersson | Need to figure out if it is the test that is broken, or if there is a race condition happening here. | 21:20 |
eandersson | jaypipes maybe? | 21:20 |
*** felipemonteiro has quit IRC | 21:21 | |
*** Sukhdev has joined #openstack-nova | 21:25 | |
*** dave-mccowan has quit IRC | 21:26 | |
*** fragatina has joined #openstack-nova | 21:27 | |
*** jaypipes has quit IRC | 21:30 | |
mriedem | sdague: any idea why we'd cache compute nodes in the request here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L110 ? | 21:30 |
mriedem | nothing is looking up a cached compute node record from what i can tell | 21:30 |
mriedem | anywhere else in the api | 21:30 |
mriedem | do we just do it for fun and games? | 21:31 |
*** jdurgin has joined #openstack-nova | 21:31 | |
*** esberglu has quit IRC | 21:31 | |
*** dave-mcc_ has joined #openstack-nova | 21:31 | |
*** mingyu has joined #openstack-nova | 21:31 | |
*** hoonetorg has quit IRC | 21:34 | |
*** gomarivera has quit IRC | 21:34 | |
*** rajathagasthya has quit IRC | 21:34 | |
oomichi | mriedem: I guessed that was a reason why unknown queries should be blocked, but now additionalProperties is True on https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/keypairs.py#L94 | 21:38 |
mriedem | yeah i looked up the original change that added that and it wasn't clear to me | 21:38 |
oomichi | mriedem: so I can not find the reason now. alex_xu can answer anyways | 21:38 |
*** gjayavelu has joined #openstack-nova | 21:38 | |
mriedem | yeah i have a lot of questions for alex_xu | 21:38 |
mriedem | 5:40am for him, i'm not sure why he's not up and working yet :) | 21:39 |
oomichi | oh, "a lot".. | 21:39 |
mriedem | see john asked about the same sort of thing here https://review.openstack.org/#/c/398755/18/nova/api/openstack/compute/schemas/keypairs.py | 21:39 |
mriedem | btw, i removed those decorators from the methods that didn't need them and no tests failed | 21:40 |
mriedem | so i'm not really sure why we need them | 21:40 |
mriedem | but that's a question for alex | 21:40 |
mriedem | one of many | 21:40 |
*** jmlowe has joined #openstack-nova | 21:40 | |
*** jdurgin has quit IRC | 21:40 | |
oomichi | hehe, I saw the patch on the history. and I found I +2d on that before without this question | 21:40 |
mriedem | oomichi: did you see my question to sean above about https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L110 ? | 21:41 |
mriedem | as far as i can tell, nothing uses those cached compute nodes in the request | 21:41 |
mriedem | i think the cache is more or less for extensions isn't it? | 21:41 |
* oomichi is checking irc history.. | 21:41 | |
*** gbarros has quit IRC | 21:43 | |
melwitt | that's my understanding, that those request caches are just to avoid doing DB lookup every time for each extension that receives the request | 21:43 |
*** jaypipes has joined #openstack-nova | 21:44 | |
*** rajathagasthya has joined #openstack-nova | 21:44 | |
melwitt | since multiple extensions can operate on the same request | 21:44 |
mriedem | i don't see anything extending the "hypervisors" resource extension | 21:44 |
mriedem | therefore i don't think anything would be using the cache | 21:45 |
mriedem | maybe something used to and we collapsed it? | 21:45 |
mriedem | unless the view does somehow | 21:45 |
melwitt | they don't have to extend it to be run, I don't think | 21:45 |
mriedem | https://review.openstack.org/#/c/53785/ | 21:45 |
mriedem | aha | 21:46 |
mriedem | os-pci | 21:46 |
mriedem | mfer | 21:46 |
melwitt | can't remember for sure though. I just know a lot of it is like onion layers, running each extension on the request object | 21:46 |
mriedem | time to get out my delete knife | 21:46 |
*** tidwellr has quit IRC | 21:48 | |
*** rfolco has quit IRC | 21:48 | |
*** fragatina has quit IRC | 21:53 | |
*** fragatina has joined #openstack-nova | 21:56 | |
*** mingyu has quit IRC | 21:57 | |
*** cdent has joined #openstack-nova | 21:57 | |
*** salv-orlando has joined #openstack-nova | 22:01 | |
*** fragatina has quit IRC | 22:04 | |
melwitt | eandersson: it looks like there might be something wrong with the test. in the log trace there's "Compute_service record created for compute:fake-mini" but then later on there's "Received an update from an unknown host 'compute'. Re-created its InstanceList." which looks like it's not matching it to the earlier created compute | 22:04 |
*** lyan has quit IRC | 22:05 | |
melwitt | like I wonder if the first compute service in the test needs to be started more similarly as the second compute service with the host and nodes set for it | 22:06 |
eandersson | Yea - found that as well | 22:08 |
jaypipes | eandersson: agree with melwitt. I don't really see anything in that patch that should be producing that error. and it seems the failure doesn't always occur, thus the rechecks. | 22:08 |
jaypipes | eandersson: the whole disabled check should definitely not be coming into play here. | 22:09 |
eandersson | Testing it locally it occurs maybe 80% of the time though | 22:09 |
jaypipes | hmm | 22:09 |
jaypipes | and only those affinity tests? | 22:09 |
jaypipes | eandersson: ^ | 22:09 |
*** takashin has joined #openstack-nova | 22:09 | |
*** armax has quit IRC | 22:09 | |
eandersson | I am just doing a single test at the moment (test_boot_servers_with_affinity_no_valid_host) | 22:10 |
eandersson | Adding a sleep at the right place and it succeeds 100% | 22:10 |
melwitt | eandersson: you might try patching like this and see if it improves anything locally http://paste.openstack.org/show/612599/ | 22:11 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532 | 22:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | 22:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280 | 22:12 |
mriedem | melwitt: dansmith: oomichi: check out https://review.openstack.org/471899 if you want to see some terrible things | 22:12 |
*** takashin has quit IRC | 22:13 | |
*** takashin has joined #openstack-nova | 22:13 | |
*** armax has joined #openstack-nova | 22:15 | |
cfriesen | mriedem: does nova-conductor need to be running in order to run "nova db online_data_migrations"? | 22:17 |
oomichi | mriedem: I am not sure why we want to add empty schema again for this api v2.0, is that WIP reason? | 22:17 |
oomichi | oh, these schemas are not used on https://review.openstack.org/#/c/471899/8/nova/api/openstack/compute/hypervisors.py .. | 22:18 |
eandersson | melwitt, was looking into something similar, still something holding it up | 22:18 |
eandersson | *but | 22:18 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.48: Standardization of VM diagnostics https://review.openstack.org/473228 | 22:18 |
eandersson | got 100% on that one test now, lets see if the others are going to be as happy :D | 22:19 |
mriedem | oomichi: it's one of my questions to alex_xu | 22:19 |
mriedem | i don't want to use empty schema if it can be avoided | 22:19 |
mriedem | but yeah it's all WIP right now | 22:19 |
mriedem | cfriesen: that's a dansmith question | 22:19 |
mriedem | i know some of them go through the objects, | 22:20 |
mriedem | but i figure they should be local to the db | 22:20 |
*** gbarros has joined #openstack-nova | 22:21 | |
*** ckopper has quit IRC | 22:22 | |
*** jamesdenton has quit IRC | 22:24 | |
*** takashin has quit IRC | 22:24 | |
*** takashin has joined #openstack-nova | 22:24 | |
*** annegentle has quit IRC | 22:27 | |
*** Apoorva_ has quit IRC | 22:30 | |
eandersson | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1671648.py#L97 | 22:30 |
*** Apoorva has joined #openstack-nova | 22:30 | |
eandersson | Looks like a very similar issue | 22:32 |
melwitt | huh, I added that. barely remember it | 22:35 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532 | 22:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | 22:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280 | 22:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Centralize compute_node_search_by_hypervisor in os-hypervisors https://review.openstack.org/474381 | 22:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop caching compute nodes in the request https://review.openstack.org/474382 | 22:37 |
mriedem | easy pickins on those bottom two changes | 22:37 |
*** adisky__ has quit IRC | 22:37 | |
eandersson | mriedem, so your suggestion fixed most issues, but it's still hitting this in 4 tests > not self.driver.node_is_available(nodename) | 22:40 |
openstackgerrit | Merged openstack/nova master: Count server group members to check quota https://review.openstack.org/457859 | 22:40 |
eandersson | I see - FAKE_NODES need to have both hosts | 22:42 |
*** suresh12 has quit IRC | 22:43 | |
*** esberglu has joined #openstack-nova | 22:43 | |
*** cdent has quit IRC | 22:44 | |
*** salv-orlando has quit IRC | 22:45 | |
*** ckopper has joined #openstack-nova | 22:47 | |
*** esberglu has quit IRC | 22:48 | |
melwitt | mriedem: just curious, how was the compute node request cache messing up what you're working on? | 22:48 |
*** suresh12 has joined #openstack-nova | 22:48 | |
openstackgerrit | Merged openstack/nova master: Make compute_node_statistics() work across cells https://review.openstack.org/473931 | 22:49 |
openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984 | 22:53 |
eandersson | That was effort, but I think I got it figured out | 22:53 |
eandersson | I could probably have left fake_network where it was though | 22:54 |
*** lyan has joined #openstack-nova | 22:59 | |
*** itlinux_ has quit IRC | 22:59 | |
eandersson | thanks melwitt | 22:59 |
*** bnemec has quit IRC | 22:59 | |
*** ckopper has quit IRC | 23:02 | |
melwitt | eandersson: np. you might probably be asked to split the test fix into its own patch ahead of your scheduler patch. the issue in the server group tests is probably affecting other things too and is its own separate bug | 23:02 |
eandersson | Yea - was thinking the same. | 23:03 |
eandersson | Gonna go and get luncch and Zuul is hopefully all green :D delayed lunch by like... 4 hours trying to figure this out :D | 23:04 |
eandersson | *by the time I get back | 23:04 |
*** mvk has quit IRC | 23:07 | |
*** mvk has joined #openstack-nova | 23:07 | |
*** catintheroof has quit IRC | 23:09 | |
*** Sukhdev_ has quit IRC | 23:10 | |
*** claudiub has quit IRC | 23:15 | |
*** pewp has quit IRC | 23:23 | |
*** pewp has joined #openstack-nova | 23:26 | |
*** sdague has quit IRC | 23:30 | |
*** Sukhdev has quit IRC | 23:34 | |
*** sree has joined #openstack-nova | 23:35 | |
*** sree has quit IRC | 23:39 | |
*** Swami has quit IRC | 23:41 | |
*** dtp has quit IRC | 23:43 | |
*** hongbin has quit IRC | 23:46 | |
*** suresh12 has quit IRC | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!