| *** r-daneel has quit IRC | 00:02 | |
| *** markvoelker has joined #openstack-nova | 00:04 | |
| *** thorst has joined #openstack-nova | 00:06 | |
| *** itlinux has joined #openstack-nova | 00:09 | |
| *** gomarivera has joined #openstack-nova | 00:13 | |
| *** markvoelker has quit IRC | 00:16 | |
| *** Shunli has joined #openstack-nova | 00:18 | |
| *** markvoelker has joined #openstack-nova | 00:21 | |
| *** thorst has quit IRC | 00:22 | |
| *** thorst has joined #openstack-nova | 00:22 | |
| *** gomarivera has quit IRC | 00:22 | |
| *** gomarivera has joined #openstack-nova | 00:23 | |
| *** winston-d_ has joined #openstack-nova | 00:24 | |
| *** gomarivera has quit IRC | 00:26 | |
| *** gomarivera has joined #openstack-nova | 00:26 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add FixedIP.get_count_by_project() https://review.openstack.org/446246 | 00:26 |
|---|---|---|
| openstackgerrit | melanie witt proposed openstack/nova master: Add FloatingIP.get_count_by_project() https://review.openstack.org/446247 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to Instance object https://review.openstack.org/446244 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add SecurityGroup.get_counts() https://review.openstack.org/446245 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | 00:26 |
| mriedem | breath | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add InstanceGroup.get_counts() https://review.openstack.org/457857 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add check_deltas() and limit_check_project_and_user() to Quotas https://review.openstack.org/446239 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add InstanceGroup._remove_members_in_db https://review.openstack.org/457858 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860 | 00:26 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 00:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861 | 00:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 00:27 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862 | 00:27 |
| *** markvoelker has quit IRC | 00:27 | |
| mriedem | it's a series! | 00:27 |
| *** thorst has quit IRC | 00:27 | |
| mriedem | 10lb 6oz | 00:27 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 00:27 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 00:27 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - List/Show all server migration types https://review.openstack.org/430839 | 00:28 |
| *** xyang1 has quit IRC | 00:28 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436 | 00:29 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unused exceptions https://review.openstack.org/464525 | 00:29 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 00:29 |
| *** ayogi has quit IRC | 00:30 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201 | 00:30 |
| *** markvoelker has joined #openstack-nova | 00:30 | |
| *** markvoelker has quit IRC | 00:31 | |
| *** dimtruck is now known as zz_dimtruck | 00:32 | |
| *** gomarivera has quit IRC | 00:33 | |
| *** gomarivera has joined #openstack-nova | 00:34 | |
| prometheanfire | mriedem: :D | 00:35 |
| *** dtp has quit IRC | 00:41 | |
| mriedem | gyee: we're going to have a problem backporting that evacuate rebuild_claim fix to newton | 00:42 |
| mriedem | getting the resource tracker in newton requires scheduled_node to be not None | 00:42 |
| mriedem | which we don't have in the forced evacuate case | 00:42 |
| *** itlinux has quit IRC | 00:42 | |
| *** Apoorva_ has joined #openstack-nova | 00:47 | |
| mriedem | gyee: i think i have a workaround | 00:48 |
| gyee | mriedem: yes, I think we can set the host prior to the resource_tracker | 00:49 |
| mriedem | yeah i've got the patch local | 00:49 |
| mriedem | running tests | 00:49 |
| *** zz_dimtruck is now known as dimtruck | 00:49 | |
| mriedem | this will likely need an additional test | 00:49 |
| *** karthiks has quit IRC | 00:53 | |
| *** crushil has joined #openstack-nova | 00:53 | |
| mriedem | eh maybe not that bad | 00:53 |
| gyee | I think there are two checks there | 00:54 |
| *** markvoelker has joined #openstack-nova | 00:54 | |
| gyee | first check if recreate and scheduled_node is not none prior to resource_tracker | 00:54 |
| gyee | then if not recreate and not scheduled_node after that | 00:55 |
| *** tovin07_ has joined #openstack-nova | 00:56 | |
| gyee | the second check covers the scenario where instance is being rebuilt on the same host | 00:56 |
| *** dixiaoli has joined #openstack-nova | 00:56 | |
| mriedem | yup i'm just fixing tests | 00:56 |
| *** Apoorva_ has quit IRC | 00:57 | |
| *** karthiks has joined #openstack-nova | 00:57 | |
| *** markvoelker has quit IRC | 00:58 | |
| *** markvoelker has joined #openstack-nova | 00:58 | |
| *** nic has quit IRC | 00:59 | |
| *** john5223_ has quit IRC | 00:59 | |
| *** crushil has quit IRC | 01:00 | |
| *** tbachman has quit IRC | 01:00 | |
| *** crushil has joined #openstack-nova | 01:01 | |
| *** phuongnh has joined #openstack-nova | 01:03 | |
| *** gomarivera has quit IRC | 01:04 | |
| *** gomarivera has joined #openstack-nova | 01:05 | |
| *** baoli has joined #openstack-nova | 01:05 | |
| *** acormier has joined #openstack-nova | 01:05 | |
| *** tuanluong has joined #openstack-nova | 01:06 | |
| *** acormier has quit IRC | 01:07 | |
| *** acormier has joined #openstack-nova | 01:07 | |
| mriedem | this is going to take some fancy word-smithing in the commit message | 01:08 |
| *** dikonoor has joined #openstack-nova | 01:08 | |
| *** gomarivera has quit IRC | 01:08 | |
| *** gomarivera has joined #openstack-nova | 01:09 | |
| *** tbachman has joined #openstack-nova | 01:09 | |
| *** dixiaoli has quit IRC | 01:14 | |
| *** mingyu has joined #openstack-nova | 01:15 | |
| mriedem | gyee: https://review.openstack.org/#/c/468227/ | 01:15 |
| *** dikonoor has quit IRC | 01:15 | |
| gyee | mriedem: we are letting ComputeHostNotFound bubble up? | 01:16 |
| mriedem | w/o the compute node we can't get the resource tracker and make the claim | 01:16 |
| mriedem | so we need to fail | 01:16 |
| mriedem | as noted in the commit message | 01:17 |
| gyee | make sense | 01:17 |
| mriedem | that 3rd scenario for forced evacuation was basically totally busted in newton | 01:17 |
| *** amotoki_away is now known as amotoki | 01:17 | |
| mriedem | when that microversion was introduced for forced evacuate | 01:18 |
| mriedem | since it doesn't make the rebuild claim on the target host | 01:18 |
| *** gouthamr has quit IRC | 01:20 | |
| *** dave-mccowan has joined #openstack-nova | 01:21 | |
| *** edmondsw has joined #openstack-nova | 01:23 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: nova-compute cannot restart after manually delete VM https://review.openstack.org/467926 | 01:24 |
| *** yolkfull_ has joined #openstack-nova | 01:24 | |
| *** gouthamr has joined #openstack-nova | 01:24 | |
| *** edmondsw has quit IRC | 01:27 | |
| *** thorst has joined #openstack-nova | 01:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 01:31 |
| *** thorst has quit IRC | 01:32 | |
| *** itlinux has joined #openstack-nova | 01:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid lazy-loading instance.id when cross_az_attach=False https://review.openstack.org/468232 | 01:36 |
| *** dave-mccowan has quit IRC | 01:36 | |
| *** itlinux has quit IRC | 01:38 | |
| *** mriedem has quit IRC | 01:38 | |
| *** mtanino_ has quit IRC | 01:39 | |
| *** markvoelker has quit IRC | 01:41 | |
| *** acormier has quit IRC | 01:47 | |
| *** acormier has joined #openstack-nova | 01:47 | |
| *** thorst has joined #openstack-nova | 01:48 | |
| *** thorst has quit IRC | 01:48 | |
| *** huanxie has joined #openstack-nova | 01:50 | |
| *** zhurong has joined #openstack-nova | 01:51 | |
| *** acormier has quit IRC | 01:51 | |
| *** abalutoiu_ has quit IRC | 01:51 | |
| *** abalutoiu_ has joined #openstack-nova | 01:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 01:53 |
| *** gomarivera has quit IRC | 01:53 | |
| *** gomarivera has joined #openstack-nova | 01:54 | |
| *** rfolco has joined #openstack-nova | 01:58 | |
| *** gomarivera has quit IRC | 01:58 | |
| *** jichen has joined #openstack-nova | 01:59 | |
| *** mingyu has quit IRC | 02:01 | |
| *** baoli has quit IRC | 02:02 | |
| *** mingyu has joined #openstack-nova | 02:03 | |
| *** gomarivera has joined #openstack-nova | 02:06 | |
| *** coreywright has quit IRC | 02:09 | |
| *** mingyu has quit IRC | 02:12 | |
| *** tbachman has quit IRC | 02:13 | |
| *** ijw has quit IRC | 02:15 | |
| *** abalutoiu_ has quit IRC | 02:16 | |
| *** ijw_ has joined #openstack-nova | 02:19 | |
| *** ijw_ has quit IRC | 02:22 | |
| *** ijw has joined #openstack-nova | 02:22 | |
| *** hongbin has joined #openstack-nova | 02:25 | |
| *** coreywright has joined #openstack-nova | 02:26 | |
| *** ijw has quit IRC | 02:27 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 02:30 |
| *** larainema has quit IRC | 02:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 02:39 |
| *** xinliang has quit IRC | 02:46 | |
| *** gouthamr has quit IRC | 02:46 | |
| *** gouthamr has joined #openstack-nova | 02:47 | |
| *** thorst has joined #openstack-nova | 02:49 | |
| *** mingyu has joined #openstack-nova | 02:50 | |
| *** rfolco has quit IRC | 02:51 | |
| *** mingyu has quit IRC | 02:53 | |
| *** thorst has quit IRC | 02:54 | |
| *** mingyu has joined #openstack-nova | 02:55 | |
| *** yamamoto_ has joined #openstack-nova | 02:55 | |
| *** penick has joined #openstack-nova | 02:56 | |
| *** larainema has joined #openstack-nova | 02:59 | |
| *** penick has quit IRC | 03:00 | |
| *** edmondsw has joined #openstack-nova | 03:11 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 03:13 |
| *** mingyu has quit IRC | 03:13 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 03:15 |
| *** edmondsw has quit IRC | 03:15 | |
| *** mingyu has joined #openstack-nova | 03:15 | |
| *** mingyu has quit IRC | 03:28 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 03:29 |
| *** sofie_ has joined #openstack-nova | 03:33 | |
| openstackgerrit | suzhengwei proposed openstack/nova-specs master: availability zone return all services in api https://review.openstack.org/468261 | 03:34 |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** mtanino_ has joined #openstack-nova | 03:41 | |
| openstackgerrit | suzhengwei proposed openstack/nova master: availability zone return all services in api https://review.openstack.org/462897 | 03:45 |
| *** vks1 has joined #openstack-nova | 03:46 | |
| *** coreywright has quit IRC | 03:49 | |
| *** mtanino_ has quit IRC | 03:49 | |
| *** thorst has joined #openstack-nova | 03:50 | |
| *** gomarivera has quit IRC | 03:51 | |
| openstackgerrit | suzhengwei proposed openstack/nova-specs master: availability zone return all services in api https://review.openstack.org/468261 | 03:52 |
| *** thorst has quit IRC | 03:54 | |
| *** coreywright has joined #openstack-nova | 04:01 | |
| *** hongbin has quit IRC | 04:04 | |
| *** zhurong has quit IRC | 04:07 | |
| *** yamamoto_ has quit IRC | 04:08 | |
| *** dimtruck is now known as zz_dimtruck | 04:12 | |
| *** gouthamr has quit IRC | 04:14 | |
| *** markvoelker has joined #openstack-nova | 04:19 | |
| *** mdnadeem has joined #openstack-nova | 04:27 | |
| *** coreywright has quit IRC | 04:27 | |
| *** adreznec has quit IRC | 04:41 | |
| *** adreznec has joined #openstack-nova | 04:45 | |
| *** coreywright has joined #openstack-nova | 04:45 | |
| *** zhurong has joined #openstack-nova | 04:45 | |
| *** trinaths has joined #openstack-nova | 04:50 | |
| *** ayogi has joined #openstack-nova | 04:51 | |
| *** thorst has joined #openstack-nova | 04:51 | |
| *** ijw has joined #openstack-nova | 04:55 | |
| *** thorst has quit IRC | 04:55 | |
| *** ijw has quit IRC | 04:58 | |
| *** edmondsw has joined #openstack-nova | 04:59 | |
| *** psachin has quit IRC | 05:01 | |
| *** armax has quit IRC | 05:02 | |
| *** crushil has quit IRC | 05:03 | |
| *** edmondsw has quit IRC | 05:03 | |
| *** psachin has joined #openstack-nova | 05:06 | |
| *** salv-orlando has joined #openstack-nova | 05:06 | |
| *** prateek has joined #openstack-nova | 05:07 | |
| *** psachin has quit IRC | 05:07 | |
| *** prateek has joined #openstack-nova | 05:08 | |
| *** yamamoto_ has joined #openstack-nova | 05:08 | |
| openstackgerrit | Rikimaru Honjo proposed openstack/nova master: Calculate stopped instance's disk sizes for disk_available_least https://review.openstack.org/468269 | 05:08 |
| *** psachin has joined #openstack-nova | 05:09 | |
| *** kaisers_ has joined #openstack-nova | 05:09 | |
| *** kaisers_ has quit IRC | 05:11 | |
| *** vks1 has quit IRC | 05:15 | |
| *** claudiub has joined #openstack-nova | 05:16 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 05:18 |
| *** prateek has quit IRC | 05:18 | |
| openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 05:19 |
| gmann | alex_xu: can you check this now - https://review.openstack.org/#/c/461728/4 | 05:19 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 05:24 |
| *** gyee has quit IRC | 05:26 | |
| *** gszasz has joined #openstack-nova | 05:28 | |
| *** ratailor has joined #openstack-nova | 05:28 | |
| *** vks1 has joined #openstack-nova | 05:29 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 05:33 |
| *** crushil has joined #openstack-nova | 05:36 | |
| *** salv-orlando has quit IRC | 05:38 | |
| *** pcaruana has joined #openstack-nova | 05:43 | |
| *** avolkov has joined #openstack-nova | 05:45 | |
| *** armax has joined #openstack-nova | 05:48 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Remove bittorrent.py which is not used or referred https://review.openstack.org/468273 | 05:50 |
| *** thorst has joined #openstack-nova | 05:52 | |
| *** arunman has joined #openstack-nova | 05:54 | |
| *** amotoki is now known as amotoki_away | 06:03 | |
| *** amotoki_away is now known as amotoki | 06:03 | |
| *** prateek has joined #openstack-nova | 06:08 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 06:09 |
| *** thorst has quit IRC | 06:10 | |
| *** belmoreira has joined #openstack-nova | 06:10 | |
| *** rcernin has joined #openstack-nova | 06:10 | |
| *** markvoelker has quit IRC | 06:12 | |
| *** udesale has joined #openstack-nova | 06:12 | |
| *** amotoki is now known as amotoki_away | 06:13 | |
| *** mingyu has joined #openstack-nova | 06:15 | |
| *** crushil has quit IRC | 06:17 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 06:19 |
| *** amotoki_away is now known as amotoki | 06:19 | |
| *** moshele has joined #openstack-nova | 06:20 | |
| *** vladikr has quit IRC | 06:22 | |
| *** moshele has quit IRC | 06:23 | |
| *** Oku_OS-away is now known as Oku_OS | 06:23 | |
| *** armax has quit IRC | 06:25 | |
| *** kaisers_ has joined #openstack-nova | 06:27 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | 06:27 |
| *** karthiks has quit IRC | 06:28 | |
| *** phuongnh has quit IRC | 06:31 | |
| *** kaisers_ has quit IRC | 06:31 | |
| *** phuongnh has joined #openstack-nova | 06:31 | |
| *** salv-orlando has joined #openstack-nova | 06:32 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 06:34 |
| alex_xu | gmann: yea, will try to reach that soon | 06:34 |
| gmann | alex_xu: thanks | 06:35 |
| alex_xu | gmann: np | 06:35 |
| *** sree has joined #openstack-nova | 06:37 | |
| *** markus_z has joined #openstack-nova | 06:42 | |
| *** markvoelker has joined #openstack-nova | 06:44 | |
| *** ltomasbo|away is now known as ltomasbo | 06:47 | |
| *** jamielennox is now known as jamielennox|away | 06:48 | |
| *** markvoelker has quit IRC | 06:49 | |
| *** sridharg has joined #openstack-nova | 06:50 | |
| *** zhurong has quit IRC | 06:54 | |
| *** markvoelker has joined #openstack-nova | 06:56 | |
| *** zhurong has joined #openstack-nova | 06:59 | |
| *** mingyu has quit IRC | 07:00 | |
| *** markvoelker has quit IRC | 07:02 | |
| *** salv-orl_ has joined #openstack-nova | 07:04 | |
| *** jaosorior has joined #openstack-nova | 07:06 | |
| *** salv-orlando has quit IRC | 07:06 | |
| *** thorst has joined #openstack-nova | 07:07 | |
| *** Dinesh_Bhor has quit IRC | 07:07 | |
| openstackgerrit | Shunli Zhou proposed openstack/nova master: Remove mox from unit/cells/test_cells_messaging.py https://review.openstack.org/448021 | 07:08 |
| *** karthiks has joined #openstack-nova | 07:10 | |
| *** markvoelker has joined #openstack-nova | 07:11 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 07:11 |
| *** thorst has quit IRC | 07:11 | |
| *** ratailor has quit IRC | 07:12 | |
| *** ralonsoh has joined #openstack-nova | 07:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:13 | |
| *** ratailor has joined #openstack-nova | 07:14 | |
| *** cfriesen has quit IRC | 07:14 | |
| *** markvoelker has quit IRC | 07:15 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Enhancement comments on CountableResource https://review.openstack.org/402051 | 07:16 |
| openstackgerrit | jichenjc proposed openstack/nova master: add zvm migration object https://review.openstack.org/414090 | 07:16 |
| openstackgerrit | jichenjc proposed openstack/nova master: Check instance existing before check in mapping https://review.openstack.org/433470 | 07:16 |
| *** shaohe_feng has quit IRC | 07:17 | |
| alex_xu | gmann: done | 07:20 |
| gmann | alex_xu: thanks again | 07:21 |
| alex_xu | gmann: np | 07:21 |
| *** ratailor has quit IRC | 07:22 | |
| *** phuongnh has quit IRC | 07:24 | |
| *** sree has quit IRC | 07:24 | |
| *** ratailor has joined #openstack-nova | 07:24 | |
| *** markvoelker has joined #openstack-nova | 07:25 | |
| *** salv-orl_ has quit IRC | 07:27 | |
| *** markvoelker has quit IRC | 07:30 | |
| *** jpena|off is now known as jpena | 07:33 | |
| *** shaohe_feng has joined #openstack-nova | 07:40 | |
| *** vks1 has quit IRC | 07:41 | |
| *** vks1 has joined #openstack-nova | 07:42 | |
| *** hferenc has quit IRC | 07:44 | |
| *** Drankis has joined #openstack-nova | 07:44 | |
| *** gabor_antal has quit IRC | 07:44 | |
| *** vks11 has joined #openstack-nova | 07:44 | |
| *** hferenc has joined #openstack-nova | 07:46 | |
| *** gabor_antal has joined #openstack-nova | 07:46 | |
| *** vks1 has quit IRC | 07:46 | |
| *** bkopilov has quit IRC | 07:47 | |
| *** liuqing has quit IRC | 07:47 | |
| *** liuqing has joined #openstack-nova | 07:47 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** _danpawlik is now known as danpawlik | 07:49 | |
| *** vks11 has quit IRC | 07:59 | |
| *** karthiks has quit IRC | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** karimb has joined #openstack-nova | 08:01 | |
| *** sofie_ has quit IRC | 08:02 | |
| *** openstackgerrit has joined #openstack-nova | 08:07 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Remove bittorrent.py which is not used or referred https://review.openstack.org/468273 | 08:07 |
| *** thorst has joined #openstack-nova | 08:07 | |
| *** aarefiev_afk is now known as aarefiev | 08:10 | |
| *** Shunli has quit IRC | 08:10 | |
| *** Shunli has joined #openstack-nova | 08:11 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Remove bittorrent.py which is not used or referred https://review.openstack.org/468273 | 08:12 |
| *** thorst has quit IRC | 08:13 | |
| *** abalutoiu has joined #openstack-nova | 08:13 | |
| *** karthiks has joined #openstack-nova | 08:13 | |
| *** ayogi has quit IRC | 08:16 | |
| *** vks1 has joined #openstack-nova | 08:16 | |
| *** lucas-afk is now known as lucasagomes | 08:18 | |
| *** markvoelker has joined #openstack-nova | 08:19 | |
| *** efoley has joined #openstack-nova | 08:22 | |
| *** shaohe_feng has quit IRC | 08:23 | |
| *** abalutoiu has quit IRC | 08:24 | |
| *** abalutoiu has joined #openstack-nova | 08:28 | |
| *** markvoelker has quit IRC | 08:28 | |
| *** salv-orlando has joined #openstack-nova | 08:31 | |
| *** shaohe_feng has joined #openstack-nova | 08:32 | |
| *** edmondsw has joined #openstack-nova | 08:35 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** edmondsw has quit IRC | 08:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-virtual-interfaces endpoint https://review.openstack.org/468317 | 08:41 |
| alex_xu | gmann: one comment https://review.openstack.org/#/c/467938/2 | 08:41 |
| gmann | alex_xu: nice catch, ll update | 08:42 |
| alex_xu | gmann: thanks :) | 08:44 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | 08:50 |
| *** gomarivera has joined #openstack-nova | 08:55 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Remove bittorrent.py which is not used or referred https://review.openstack.org/468273 | 08:57 |
| openstackgerrit | Andrea Visnyei proposed openstack/nova master: Parameter verification of os-security-groups https://review.openstack.org/383598 | 08:59 |
| *** gomarivera has quit IRC | 09:00 | |
| openstackgerrit | Tao Li proposed openstack/nova master: Fix the display of updated_at time when using memcache driver. https://review.openstack.org/414463 | 09:03 |
| *** roeyc1 has joined #openstack-nova | 09:07 | |
| *** thorst has joined #openstack-nova | 09:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix a context argument in _set_vm_state_and_notify https://review.openstack.org/468322 | 09:09 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-server-external-events endpoint https://review.openstack.org/468324 | 09:10 |
| *** dillaman has quit IRC | 09:12 | |
| *** jdillaman has quit IRC | 09:12 | |
| *** thorst has quit IRC | 09:13 | |
| *** markvoelker has joined #openstack-nova | 09:13 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-server-external-events endpoint https://review.openstack.org/468324 | 09:15 |
| *** markvoelker has quit IRC | 09:18 | |
| *** zhurong has quit IRC | 09:19 | |
| *** sambetts|afk is now known as sambetts | 09:20 | |
| *** rmart04 has joined #openstack-nova | 09:21 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for server diagnostics endpoint https://review.openstack.org/468331 | 09:25 |
| *** jdillaman has joined #openstack-nova | 09:25 | |
| *** dillaman has joined #openstack-nova | 09:26 | |
| *** hshiina has joined #openstack-nova | 09:27 | |
| *** Shunli has quit IRC | 09:27 | |
| *** roeyc1 has quit IRC | 09:28 | |
| *** haplo37 has quit IRC | 09:29 | |
| *** yingjun has quit IRC | 09:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for server ips endpoint https://review.openstack.org/468334 | 09:34 |
| *** lpetrut has joined #openstack-nova | 09:34 | |
| openstackgerrit | zhangyanxian proposed openstack/nova-specs master: Sriov-bond https://review.openstack.org/463526 | 09:36 |
| *** haplo37 has joined #openstack-nova | 09:39 | |
| *** takashin has left #openstack-nova | 09:40 | |
| *** roeyc has joined #openstack-nova | 09:41 | |
| *** markvoelker has joined #openstack-nova | 09:47 | |
| *** tovin07_ has quit IRC | 09:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for instance actions endpoint https://review.openstack.org/468338 | 09:50 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 09:51 |
| *** markvoelker has quit IRC | 09:52 | |
| *** mpaolino has joined #openstack-nova | 09:53 | |
| *** tbachman has joined #openstack-nova | 09:54 | |
| *** sofie_ has joined #openstack-nova | 09:57 | |
| *** jichen has quit IRC | 09:58 | |
| *** amotoki is now known as amotoki_away | 10:05 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | 10:05 |
| *** trinaths has left #openstack-nova | 10:05 | |
| *** sdague has joined #openstack-nova | 10:07 | |
| *** lucasxu has joined #openstack-nova | 10:09 | |
| *** thorst has joined #openstack-nova | 10:09 | |
| andymccr | Morning Nova - I'm seeing gate failures on OSA since https://review.openstack.org/458635 and https://review.openstack.org/458634 merged - essentially the compute host isnt seen as being in the cell yet so it fails to boot an instance - before those patches it works fine. The scheduler is saying the host isnt mapped to a cell. The boot works fine if you try a short while after though, so im guessing its a timi | 10:13 |
| andymccr | ng issue. | 10:13 |
| andymccr | is there anything we can change/do to ensure the host is in the cell and we avoid the race? (we're already performing a discover host) | 10:13 |
| *** thorst has quit IRC | 10:13 | |
| *** markvoelker has joined #openstack-nova | 10:15 | |
| *** tbachman has quit IRC | 10:15 | |
| *** markvoelker has quit IRC | 10:19 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-fping endpoint https://review.openstack.org/468349 | 10:23 |
| openstackgerrit | Deepak Mourya proposed openstack/nova master: Remove Babel from requirements.txt https://review.openstack.org/468350 | 10:24 |
| *** yamamoto_ has quit IRC | 10:24 | |
| *** cdent has joined #openstack-nova | 10:26 | |
| *** lucasagomes has quit IRC | 10:27 | |
| *** lucasagomes has joined #openstack-nova | 10:29 | |
| *** salv-orlando has quit IRC | 10:30 | |
| *** salv-orlando has joined #openstack-nova | 10:30 | |
| *** markvoelker has joined #openstack-nova | 10:34 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 10:36 |
| *** markvoelker has quit IRC | 10:39 | |
| *** lucasxu has quit IRC | 10:40 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventory https://review.openstack.org/455215 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET resource provider https://review.openstack.org/467541 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventory https://review.openstack.org/455214 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT resource provider https://review.openstack.org/467542 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventory https://review.openstack.org/455213 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE resource provider https://review.openstack.org/467543 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for resource classes https://review.openstack.org/467596 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventories https://review.openstack.org/449765 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventories https://review.openstack.org/452708 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for POST resource provider https://review.openstack.org/456176 | 10:41 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventories https://review.openstack.org/452707 | 10:41 |
| *** lucasagomes has quit IRC | 10:41 | |
| *** markvoelker has joined #openstack-nova | 10:43 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 10:47 |
| *** markvoelker has quit IRC | 10:48 | |
| *** Drankis has quit IRC | 10:49 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Send request_id on glance calls https://review.openstack.org/467242 | 10:53 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Send request_id on cinder calls https://review.openstack.org/468355 | 10:53 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Send request_id on neutron calls https://review.openstack.org/468356 | 10:53 |
| *** mriedem has joined #openstack-nova | 10:53 | |
| *** lucasagomes has joined #openstack-nova | 10:54 | |
| mriedem | sfinucan: you want to put this veritas volume driver bp patch through? https://review.openstack.org/#/c/443951/ mdbooth and lyarwood have been through it several times. | 10:56 |
| *** Drankis has joined #openstack-nova | 10:57 | |
| sfinucan | mriedem: sure | 10:57 |
| *** amotoki_away is now known as amotoki | 10:59 | |
| cdent | mriedem: did you see that I de-conflicted your https://review.openstack.org/#/c/454426/ ? | 11:00 |
| mriedem | ooo i did not | 11:00 |
| *** Qiming has quit IRC | 11:01 | |
| mriedem | thanks, i've got a few older changes i need to address | 11:01 |
| mriedem | waking up at 5:30 and not being able to get back to sleep might allow me time to do that | 11:01 |
| *** amotoki is now known as amotoki_away | 11:01 | |
| mdbooth | mriedem: Get it done before you crash later :) | 11:01 |
| mriedem | cdent: as for your question, "Out of curiosity do scheduler.client.query.sync_instance_info and scheduler.client.query.update_instance_info eventually result in the same end state?" they are sent in different cases i believe | 11:02 |
| mriedem | sync_instance_info is called in a periodic in all computes, every minute by default | 11:03 |
| mriedem | update_instance_info is called on init_host for the compute service and when an instance is changed (when we do claims type stuff i think) | 11:04 |
| mriedem | it's all very chatty | 11:04 |
| mriedem | to keep the scheduler aware of what's on the computes for the affinity filters | 11:04 |
| cdent | right, but the end state (scheduler being aware of what's on the computes) is effectively the same? | 11:05 |
| mriedem | i've got https://review.openstack.org/#/c/453916/ to be smarter about that if you're not using the affinity filters | 11:05 |
| mriedem | cdent: yes i believe that's the idea | 11:06 |
| *** Qiming has joined #openstack-nova | 11:06 | |
| mriedem | i also want to kill the TypeAffinityFilter https://review.openstack.org/#/c/457812/ | 11:06 |
| * cdent adds another thing to his list of stuff to refactor (that won't ever actually happy) | 11:06 | |
| *** yamamoto has joined #openstack-nova | 11:06 | |
| mriedem | because then i can change this stuff to not send full objects but just the ids | 11:06 |
| *** gomarivera has joined #openstack-nova | 11:06 | |
| mriedem | for https://blueprints.launchpad.net/nova/+spec/put-host-manager-instance-info-on-a-diet | 11:06 |
| mriedem | if we get the right stuff in placement for affinity filtering before then, great | 11:07 |
| sdague | mriedem: thanks for getting that spec landed yesterday | 11:07 |
| *** yamamoto_ has joined #openstack-nova | 11:07 | |
| mriedem | but right now we send a full InstanceList from all computes every minute to the single poor scheduler | 11:07 |
| mriedem | sdague: np | 11:07 |
| cdent | 453916 is saying "people not using the filter scheduler". if we kill the caching scheduler is there much left besides filter? (in terms of active users) | 11:07 |
| *** yamamoto_ has quit IRC | 11:08 | |
| mriedem | cdent: nope | 11:08 |
| sdague | also, my new favorite git feature discovered this month | 11:08 |
| mriedem | cdent: that could be further trimmed to the affinity filters, but it gets murky | 11:08 |
| cdent | instances by reference (rather than object) sounds like a very good thing | 11:08 |
| sdague | git commit -c/-C | 11:08 |
| mriedem | cdent: but that gets messy with people that have customer filters | 11:08 |
| sdague | which is steal the commit message from another commit | 11:08 |
| mriedem | stealing is bad mkay | 11:08 |
| mriedem | sdague: maybe you'd like to deprecate this filter https://review.openstack.org/#/c/457812/ | 11:09 |
| *** thorst has joined #openstack-nova | 11:10 | |
| *** yamamoto has quit IRC | 11:10 | |
| *** gomarivera has quit IRC | 11:11 | |
| sdague | I always like deprecating things | 11:11 |
| mriedem | sdague: you're going to have functional api samples failures on this https://review.openstack.org/#/c/467998/ | 11:11 |
| mriedem | because of the GET / tests | 11:11 |
| sdague | mriedem: good call, I'll fix that as soon as I'm done with your review | 11:12 |
| sdague | zomg, we can blame jogo for that one :) | 11:13 |
| sdague | I was assuming it was code to support rax | 11:13 |
| *** thorst has quit IRC | 11:14 | |
| mriedem | yup i saw that too when i dug through writing that change | 11:14 |
| sdague | https://review.openstack.org/#/c/7571 | 11:15 |
| sdague | it honestly confuses me to see review ids that short | 11:15 |
| *** smatzek has joined #openstack-nova | 11:16 | |
| mriedem | at least it's in gerrit | 11:16 |
| sdague | yeh, well there is that :) | 11:16 |
| sdague | then you get to see who signed off on things | 11:16 |
| *** gomarivera has joined #openstack-nova | 11:17 | |
| sdague | all those bzr changes that were imported usually have no rhyme or reason why they were merged | 11:17 |
| *** lucasagomes is now known as lucas-hungry | 11:17 | |
| mriedem | seemed like a good idea at the time... | 11:17 |
| mriedem | this is why the ptl talk had the part about 'we're not historians' | 11:18 |
| *** salv-orlando has quit IRC | 11:18 | |
| sdague | Chesterton's Fence | 11:19 |
| sdague | early morning is a good time to look through old commits and figure out why would folks ever have done a thing :) | 11:20 |
| *** Qiming has quit IRC | 11:22 | |
| *** tuanluong has quit IRC | 11:23 | |
| *** roeyc has quit IRC | 11:24 | |
| *** udesale has quit IRC | 11:25 | |
| *** Qiming has joined #openstack-nova | 11:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused migrate_data kwarg from virt driver destroy() method https://review.openstack.org/452958 | 11:27 |
| *** yolkfull_ has quit IRC | 11:29 | |
| *** markvoelker has joined #openstack-nova | 11:29 | |
| *** Qiming has quit IRC | 11:30 | |
| *** sapcc-bot4 has quit IRC | 11:31 | |
| *** databus23_1 has quit IRC | 11:31 | |
| *** carthaca_4 has quit IRC | 11:31 | |
| *** david_7 has quit IRC | 11:31 | |
| *** carthaca_ has joined #openstack-nova | 11:31 | |
| *** databus23_ has joined #openstack-nova | 11:31 | |
| *** sapcc-bot has joined #openstack-nova | 11:31 | |
| *** david_8 has joined #openstack-nova | 11:31 | |
| *** markvoelker has quit IRC | 11:34 | |
| *** Qiming has joined #openstack-nova | 11:34 | |
| *** rfolco has joined #openstack-nova | 11:35 | |
| *** acormier has joined #openstack-nova | 11:38 | |
| *** Qiming has quit IRC | 11:41 | |
| *** thorst has joined #openstack-nova | 11:42 | |
| *** mingyu has joined #openstack-nova | 11:43 | |
| *** acormier has quit IRC | 11:46 | |
| *** Qiming has joined #openstack-nova | 11:47 | |
| *** winston-d_ has quit IRC | 11:49 | |
| *** eharney has joined #openstack-nova | 11:50 | |
| sdague | that feeling when you pdb trace a failing unit test, and figure out the issue is tox env doesn't include the required version of oslo.middleware | 11:50 |
| *** Qiming has quit IRC | 11:52 | |
| *** Qiming has joined #openstack-nova | 11:53 | |
| *** Qiming_ has joined #openstack-nova | 11:54 | |
| mriedem | -r | 11:54 |
| *** acormier has joined #openstack-nova | 11:55 | |
| *** litao__ has quit IRC | 11:55 | |
| *** arunman has quit IRC | 11:56 | |
| *** edmondsw has joined #openstack-nova | 11:56 | |
| *** acormier has quit IRC | 11:56 | |
| *** ericyoung has joined #openstack-nova | 11:56 | |
| *** acormier has joined #openstack-nova | 11:56 | |
| *** Qiming has quit IRC | 11:58 | |
| *** masber has quit IRC | 12:00 | |
| *** markvoelker has joined #openstack-nova | 12:00 | |
| *** amotoki_away is now known as amotoki | 12:00 | |
| *** mingyu has quit IRC | 12:04 | |
| *** amotoki is now known as amotoki_away | 12:05 | |
| *** markvoelker has quit IRC | 12:05 | |
| *** yamamoto has joined #openstack-nova | 12:05 | |
| *** acormier has quit IRC | 12:07 | |
| *** mingyu has joined #openstack-nova | 12:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for server ips endpoint https://review.openstack.org/468334 | 12:07 |
| *** acormier has joined #openstack-nova | 12:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for instance actions endpoint https://review.openstack.org/468338 | 12:08 |
| *** yamamoto has quit IRC | 12:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-fping endpoint https://review.openstack.org/468349 | 12:08 |
| *** markvoelker has joined #openstack-nova | 12:08 | |
| *** ctrath has joined #openstack-nova | 12:09 | |
| *** eharney has quit IRC | 12:11 | |
| sdague | mriedem: amirth pointed out some interesting trove fail about a failing to schedule instance which is stuck in scheduling and not put into ERROR | 12:11 |
| sdague | http://logs.openstack.org/47/467447/14/check/gate-trove-scenario-dsvm-mariadb-multi-ubuntu-xenial-nv/6efec50/logs/screen-n-cond.txt.gz#_May_26_03_24_31_161873 | 12:11 |
| *** acormier has quit IRC | 12:11 | |
| *** amrith has joined #openstack-nova | 12:11 | |
| amrith | sdague ... | 12:12 |
| amrith | http://paste.openstack.org/show/610724/ | 12:12 |
| sdague | it looks like when conductor swings around to error it it can't find the instance | 12:12 |
| amrith | and trove hangs on the scheduling | 12:12 |
| *** kaisers_ has joined #openstack-nova | 12:12 | |
| *** markvoelker has quit IRC | 12:13 | |
| mriedem | so it's trying to bury the instance in cell0, and send a notification but while it's doing that it's trying to save the instance (probably updating vm/task state) and that's loading the instance up again for some reason which is making it blow up... | 12:14 |
| mriedem | this is all changes on master for trove? | 12:14 |
| mriedem | or random? | 12:15 |
| *** yamamoto has joined #openstack-nova | 12:15 | |
| sdague | amrith: ^^?? | 12:15 |
| *** gomarivera has quit IRC | 12:15 | |
| amrith | sdague i dont understand the question | 12:15 |
| mriedem | amrith: is this random or 100% CI fail? | 12:16 |
| amrith | this is 100% repeatable in https://review.openstack.org/#/c/467447/ | 12:16 |
| *** gomarivera has joined #openstack-nova | 12:16 | |
| amrith | look at the multi jobs | 12:16 |
| mriedem | so just that change? | 12:16 |
| amrith | I repro it on my laptop | 12:16 |
| amrith | just that one change | 12:16 |
| amrith | this is the change to get around the nova pass through API's | 12:16 |
| *** kaisers_ has quit IRC | 12:16 | |
| amrith | it is the first time we're seeing 8.0.0 | 12:16 |
| amrith | and whatever else nova backend brings to the party | 12:17 |
| amrith | to repro it just recheck that change https://review.openstack.org/#/c/467447/ | 12:17 |
| amrith | and watch the multi job | 12:17 |
| amrith | it'll get to the wait_for_non_affinity_repl_to_fail thing | 12:17 |
| amrith | and hang | 12:17 |
| amrith | because nova lists the instance (in nova list) as scheduling | 12:18 |
| amrith | while it has actually failed | 12:18 |
| sdague | mriedem: it's not just that change | 12:18 |
| sdague | the entire trove gate looks like this is busted | 12:18 |
| sdague | it's the multinode for mariadb | 12:18 |
| amrith | in my laptop now ... http://paste.openstack.org/show/610724/ | 12:18 |
| amrith | you can see that scheduler gave up, conductor errored but nova list says scheduling | 12:18 |
| amrith | and yes to what sdague said | 12:18 |
| *** mingyu has quit IRC | 12:18 | |
| amrith | currnetly the trove gate is borked | 12:18 |
| mriedem | so, how does the trove CI setup cells v2? is it using devstack? | 12:18 |
| sdague | https://review.openstack.org/#/c/468102/ is a change to CONTRIBUTING.rst that has the same pattern | 12:18 |
| *** acormier has joined #openstack-nova | 12:18 | |
| mriedem | did this just start? | 12:19 |
| amrith | yes | 12:19 |
| amrith | I thought it was related to the 8.0.0 stuff | 12:19 |
| amrith | but not true | 12:19 |
| amrith | this may have been the last successful run https://review.openstack.org/#/c/457223/ | 12:19 |
| amrith | certainly didnt happen > 4 days ago | 12:20 |
| mriedem | http://logs.openstack.org/47/467447/14/check/gate-trove-scenario-dsvm-mariadb-multi-ubuntu-xenial-nv/6efec50/logs/screen-n-sch.txt.gz#_May_26_03_24_31_029544 | 12:20 |
| mriedem | the anti-affinity filter kicked it out, which is why you're getting NoValidHost, | 12:20 |
| *** gomarivera has quit IRC | 12:20 | |
| mriedem | also, the scheduler is only seeing 1 host | 12:20 |
| sdague | mriedem: right, that's expected | 12:21 |
| mriedem | are you using devstack? | 12:21 |
| sdague | that's actually the point of the test | 12:21 |
| amrith | mriedem it is devstack driven through trovestack (formerly redstack) | 12:21 |
| amrith | i can send you my local confs if that will help | 12:21 |
| amrith | but you can see the confs in the CI as well | 12:22 |
| sdague | the real question is actually why nova-conductor fails to actually error the the node | 12:22 |
| sdague | not that it fails to schedule | 12:22 |
| mriedem | yes i realize | 12:22 |
| sdague | ok, cool | 12:22 |
| mriedem | odd that i can't get hits on this in logstash | 12:24 |
| sdague | is conductor indexed? | 12:24 |
| sdague | or these jobs? | 12:24 |
| mriedem | conductor is certainly indexed, | 12:25 |
| mriedem | but i didn't think it was per job | 12:25 |
| mriedem | it's per file | 12:25 |
| mriedem | i think i see the problem, maybe | 12:26 |
| mriedem | patch incoming | 12:26 |
| sdague | cool | 12:28 |
| sdague | thanks | 12:28 |
| *** baoli has joined #openstack-nova | 12:28 | |
| mriedem | amrith: got a bug? | 12:28 |
| sdague | mriedem: I don't think he does, and he just had to head off for holiday weekend | 12:30 |
| *** baoli_ has joined #openstack-nova | 12:30 | |
| mriedem | ok, i'll put up a trove patch with depends-on to test this out | 12:31 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use targeted context when burying instances in cell0 https://review.openstack.org/468401 | 12:31 |
| *** vks1 has quit IRC | 12:31 | |
| *** ctrath has quit IRC | 12:31 | |
| *** lucas-hungry is now known as lucasagomes | 12:31 | |
| mriedem | dansmith: ^ | 12:31 |
| *** acormier has quit IRC | 12:32 | |
| openstackgerrit | Sean Dague proposed openstack/python-novaclient master: Have python-novaclient support global_request_id https://review.openstack.org/468126 | 12:32 |
| *** jpena is now known as jpena|lunch | 12:33 | |
| mriedem | aha https://bugs.launchpad.net/nova/+bug/1693438 | 12:33 |
| openstack | Launchpad bug 1693438 in OpenStack Compute (nova) "error instances remain in "Build" status and can't delete it" [Undecided,New] - Assigned to Tetsuro Nakamura (tetsuro0907) | 12:33 |
| mriedem | already reported yesterday by someone doing a good job at CD | 12:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use targeted context when burying instances in cell0 https://review.openstack.org/468401 | 12:34 |
| *** baoli has quit IRC | 12:34 | |
| sdague | mriedem: nice | 12:35 |
| *** sofie_ has quit IRC | 12:37 | |
| mriedem | amrith: fyi https://review.openstack.org/#/c/468402/ | 12:39 |
| *** yamamoto has quit IRC | 12:40 | |
| mriedem | and now i'm afraid i must get cleaned up | 12:40 |
| *** priteau has joined #openstack-nova | 12:41 | |
| *** artom has quit IRC | 12:41 | |
| sdague | mriedem: what was the dogpile cache issue with nova? | 12:42 |
| *** yamamoto has joined #openstack-nova | 12:42 | |
| amrith | mriedem your trove change will fail because of the nova client 8.0.0. if you'd like please dep my change (which aims to fix that) on your proposed fix | 12:44 |
| amrith | sdague ^^ | 12:44 |
| sdague | amrith: yeh, I can update that | 12:44 |
| *** thorst has quit IRC | 12:45 | |
| *** yamamoto has quit IRC | 12:46 | |
| *** gomarivera has joined #openstack-nova | 12:50 | |
| *** markvoelker has joined #openstack-nova | 12:51 | |
| *** lyan has joined #openstack-nova | 12:54 | |
| *** gouthamr has joined #openstack-nova | 12:54 | |
| *** markvoelker has quit IRC | 12:58 | |
| *** jaypipes is now known as leakypipes | 13:00 | |
| leakypipes | morning folks | 13:00 |
| *** kylek3h has joined #openstack-nova | 13:01 | |
| *** karthiks has quit IRC | 13:01 | |
| sdague | leakypipes: in reading through test logs of my failing patches, I saw a lot of sqla warnings are being emitted around the traits tests | 13:02 |
| sdague | because of unicode mismatch | 13:03 |
| cdent | sfinucan: leakypipes put his +2 on https://review.openstack.org/#/c/461494/ so it is safe for you to raise your +1 to +2 if you like. or anyone else if they are feeling like a quick win | 13:03 |
| sfinucan | cdent: Yup, done | 13:03 |
| leakypipes | sdague: ya. I've been meaning to ask alex_xu to submit fixups for those... | 13:03 |
| *** edleafe is now known as figleaf | 13:03 | |
| cdent | sfinucan: yay! | 13:03 |
| * sfinucan waits for leakypipes on all things SQL'y now | 13:03 | |
| sdague | leakypipes: ok, cool | 13:04 |
| leakypipes | sdague: but since it's now the weekend for alex_xu I'll put the word out to get that cleaned up. | 13:04 |
| leakypipes | efried: feel like an easy one? :) | 13:04 |
| *** thorst has joined #openstack-nova | 13:04 | |
| sdague | yeh, that's fine, I just wanted to make sure it was known | 13:04 |
| leakypipes | sdague: yup, thank you sir :) | 13:05 |
| *** Dinesh_Bhor has quit IRC | 13:05 | |
| sdague | cross service request id tracking to cinder is Jenkins +1 - https://review.openstack.org/#/c/468355/ if anyone wants to push that in | 13:06 |
| *** dims has quit IRC | 13:07 | |
| *** hshiina has quit IRC | 13:07 | |
| *** psachin has quit IRC | 13:08 | |
| *** eharney has joined #openstack-nova | 13:08 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 13:11 |
| *** markvoelker has joined #openstack-nova | 13:12 | |
| *** karthiks has joined #openstack-nova | 13:13 | |
| *** pchavva has joined #openstack-nova | 13:14 | |
| *** mdrabe has joined #openstack-nova | 13:14 | |
| *** esberglu has joined #openstack-nova | 13:14 | |
| *** lucasxu has joined #openstack-nova | 13:14 | |
| *** gouthamr has quit IRC | 13:15 | |
| *** eharney has quit IRC | 13:16 | |
| *** gouthamr has joined #openstack-nova | 13:18 | |
| *** yamamoto has joined #openstack-nova | 13:21 | |
| *** prateek has quit IRC | 13:22 | |
| mriedem | sdague: i don't think a bug was reported for the dogpile.cache test failure | 13:22 |
| *** karthiks has quit IRC | 13:26 | |
| mriedem | sdague: tsk tsk https://review.openstack.org/#/c/468355/1 | 13:27 |
| *** gszasz has quit IRC | 13:27 | |
| sdague | mriedem: yeh, I was going to swing around with minimums at the end | 13:28 |
| sdague | because otherwise it's another couple of days per patch | 13:28 |
| mriedem | we're using a new thing on a minimum version, | 13:28 |
| mriedem | we should require the minimum version | 13:28 |
| sdague | and if you are CDing and not using upper constraints | 13:29 |
| mriedem | regardless of u-c | 13:29 |
| sdague | you are crazy | 13:29 |
| mriedem | if i'm packaging and picking up when minimums bump... | 13:29 |
| mriedem | at the least | 13:29 |
| mriedem | anyway, can we just do that? it's trivial | 13:29 |
| mriedem | and it's the right thing | 13:29 |
| sdague | mriedem: we have to do g-r change to and Depends-On, that's fine, but I need to swing around on it | 13:29 |
| mriedem | sure | 13:30 |
| *** sridharg has quit IRC | 13:30 | |
| mriedem | or i can quick | 13:30 |
| sdague | mriedem: I'll at least state for my defense, even trivial individual patches aren't so much when you have 12 of them outstanding in 7 repos, with depends-on :) | 13:30 |
| sdague | I'll do it | 13:31 |
| mriedem | just pushed the reqs change | 13:31 |
| sdague | ok | 13:31 |
| mriedem | https://review.openstack.org/468417 | 13:31 |
| sdague | oh, you want to bump cinderclient as well | 13:32 |
| mriedem | sure | 13:32 |
| sdague | if you want to be strict about it | 13:32 |
| mriedem | i do | 13:32 |
| *** cdent has quit IRC | 13:32 | |
| mriedem | done | 13:33 |
| mriedem | https://review.openstack.org/468419 | 13:33 |
| *** mpaolino has quit IRC | 13:34 | |
| *** smcginnis is now known as ZenMaster | 13:34 | |
| *** ZenMaster is now known as smcginnis | 13:34 | |
| stvnoyes | mriedem: johnthetubaguy: when you get a minute, please take a look at https://review.openstack.org/#/c/463987/ - cinder v3 migrate update. thanks. | 13:36 |
| dansmith | who is responsible for the bindep stuff? is that fungi? | 13:36 |
| *** smatzek has quit IRC | 13:36 | |
| *** cristicalin has joined #openstack-nova | 13:37 | |
| leakypipes | figleaf: you pushing up a new patch for the send instance UUIDs in param changeset? | 13:37 |
| sdague | dansmith: mostly, what's up though? | 13:38 |
| dansmith | sdague: was just trying it on a fresh centos7 and it just does nothing, "file not found" or something.. I can repro here in a sec | 13:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Send request_id on neutron calls https://review.openstack.org/468356 | 13:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Send request_id on cinder calls https://review.openstack.org/468355 | 13:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Send request_id on glance calls https://review.openstack.org/467242 | 13:38 |
| mriedem | sdague: ^ updated with depends-on | 13:38 |
| leakypipes | dansmith: don't you need to find a phone booth to change your outfit in? | 13:38 |
| mriedem | marked neutron and glance ones as wips until the related clients are in g-r | 13:38 |
| dansmith | leakypipes: no, I'm more of a public exposure kinda guy | 13:39 |
| *** udesale has joined #openstack-nova | 13:39 | |
| *** dansmith is now known as superdan | 13:39 | |
| sdague | mriedem: ok, thanks | 13:39 |
| leakypipes | lmao | 13:39 |
| sdague | mriedem: can you squash those 2 g-r changes? | 13:39 |
| sdague | because otherwise we're running about 20 jobs for each and they don't actually even test anything | 13:40 |
| sdague | or, I'll do it | 13:40 |
| mriedem | the cinderclient one could cause someting to fail | 13:40 |
| mriedem | that's why i separated them | 13:40 |
| superdan | sdague: https://pastebin.com/pUjH5vf4 | 13:42 |
| sdague | mriedem: it actually can't | 13:42 |
| sdague | mriedem: it's a test hole, we're always testing with u-c | 13:42 |
| sdague | the g-r non uc changes are just burning nodes | 13:43 |
| mriedem | done | 13:43 |
| *** arunman has joined #openstack-nova | 13:43 | |
| fungi | superdan: i'm not really around most of today, but odds are the error you're seeing is because bindep wants the lsb_release utility so it can identify your operating system | 13:44 |
| fungi | it could probably benefit from a patch to produce a more useful error message under that scenario | 13:44 |
| superdan | fungi: okay, lemme see if that's it | 13:44 |
| *** jerrygb has joined #openstack-nova | 13:45 | |
| *** jerrygb has quit IRC | 13:45 | |
| *** jerrygb has joined #openstack-nova | 13:45 | |
| fungi | it used to be that pretty much all distros preinstalled that by default, but now that the lsb itself has fallen by the wayside distros are starting to omit the tool | 13:45 |
| *** jpena|lunch is now known as jpena | 13:45 | |
| sdague | mriedem: thanks | 13:45 |
| fungi | well, s/omit/made optional/ | 13:46 |
| superdan | fungi: and I'm running on a super stripped "cloud-ready" install of centos | 13:46 |
| fungi | aha | 13:46 |
| superdan | missing all kinds of stuff I would normally expect | 13:46 |
| superdan | the desire to omit wget these days is super annoying | 13:47 |
| fungi | more than anything i hate when they leave out manpages | 13:47 |
| superdan | fungi: yeah that was it | 13:47 |
| superdan | fungi: is bindep in each project or a library? | 13:47 |
| mriedem | each project | 13:47 |
| *** gouthamr has quit IRC | 13:47 | |
| superdan | so it really needs fixing everywhere? | 13:47 |
| fungi | superdan: it's a python utility on pypi | 13:48 |
| mriedem | i think so | 13:48 |
| mriedem | the txt file is in each project | 13:48 |
| *** arunman has quit IRC | 13:48 | |
| *** gouthamr_ has joined #openstack-nova | 13:48 | |
| superdan | mriedem: this sounds like it's a core problem though | 13:48 |
| fungi | if you look at nova's tox.ini, the bindep target just installs bindep from pypi into a tox venv and then runs it (and it checks the packages installed on your system against the list of package names in the bindep.txt file in the nova repo) | 13:49 |
| superdan | yep, i see | 13:49 |
| superdan | fungi: recede behind the curtain, I'm unblocked and we can discuss more later if needed :) | 13:50 |
| fungi | glad i could help! | 13:50 |
| superdan | yep thanks :) | 13:51 |
| *** awaugama has joined #openstack-nova | 13:51 | |
| mriedem | if there is one thing i hate, it's needing to mock a context manager | 13:52 |
| leakypipes | mriedem: just one thing, eh? | 13:52 |
| mriedem | that's the only thing i hate | 13:52 |
| mriedem | right this minute | 13:52 |
| *** owalsh_ has joined #openstack-nova | 13:53 | |
| *** arunman has joined #openstack-nova | 13:55 | |
| *** owalsh has quit IRC | 13:55 | |
| *** jwcroppe has quit IRC | 13:56 | |
| *** jwcroppe has joined #openstack-nova | 13:57 | |
| *** tidwellr has joined #openstack-nova | 13:59 | |
| alex_xu | sdague: leakypipes yea, I can take a look at the trait log tomorrow, do you have any example? | 14:00 |
| *** karimb has quit IRC | 14:00 | |
| sdague | alex_xu: I was just running tox -e functional locally | 14:00 |
| alex_xu | sdague: ok, got it, i will try | 14:00 |
| *** jwcroppe has quit IRC | 14:01 | |
| sdague | it's warnings in the stream | 14:01 |
| *** smatzek has joined #openstack-nova | 14:01 | |
| leakypipes | alex_xu: oh, it's all the same warning... just need to use six.text_type() for a few things. | 14:01 |
| alex_xu | leakypipes: ah, got it, I will check that tomorrow | 14:01 |
| leakypipes | coolio. | 14:01 |
| *** udesale has quit IRC | 14:02 | |
| *** dims has joined #openstack-nova | 14:04 | |
| *** mtanino__ has joined #openstack-nova | 14:04 | |
| *** haplo37 has quit IRC | 14:05 | |
| *** owalsh_ is now known as owalsh | 14:07 | |
| danpawlik | mriedem: Hi. If you have some time can you reply me in my comment: https://review.openstack.org/#/c/459753/ ? Please | 14:10 |
| *** karimb has joined #openstack-nova | 14:11 | |
| *** gouthamr_ has quit IRC | 14:11 | |
| *** gouthamr has joined #openstack-nova | 14:13 | |
| *** felipemonteiro has joined #openstack-nova | 14:13 | |
| *** markvoelker has quit IRC | 14:15 | |
| mriedem | danpawlik: reply how? | 14:16 |
| *** jwcroppe has joined #openstack-nova | 14:17 | |
| *** artom has joined #openstack-nova | 14:18 | |
| *** zz_dimtruck is now known as dimtruck | 14:19 | |
| danpawlik | mriedem: maybe question is not directed to you, but it will be nice to know if we still wait for reply from Claudio or we can focus on merging it ;) | 14:19 |
| *** salv-orlando has joined #openstack-nova | 14:19 | |
| mriedem | danpawlik: i understand that you're eager to get this change merged, | 14:19 |
| mriedem | but we have ~72 proposed blueprints for this release, | 14:19 |
| mriedem | and other things going on at the same time, | 14:19 |
| mriedem | so it's on my list | 14:19 |
| mriedem | but not top priority atm | 14:19 |
| *** priteau has quit IRC | 14:19 | |
| melwitt | mriedem: fyi it looks like this patch is working on the same thing you are about cell0 context https://review.openstack.org/#/c/468322 | 14:20 |
| mriedem | melwitt: ah, it's also incomplete | 14:20 |
| melwitt | here's the bug he opened too https://bugs.launchpad.net/nova/+bug/1693721 | 14:21 |
| openstack | Launchpad bug 1693721 in OpenStack Compute (nova) "Error handling for HostMappingNotFound in conductor manager does not work properly" [Undecided,In progress] - Assigned to Takashi NATSUME (natsume-takashi) | 14:21 |
| melwitt | if you want to pick which one to dupe | 14:21 |
| mriedem | i'll dupe his | 14:21 |
| melwitt | k | 14:21 |
| danpawlik | mriedem: Ok, sorry for pushing you. I just want to move forward.I'll be patient | 14:22 |
| mriedem | so given takashin is probably done for the weekend | 14:22 |
| mriedem | and his patch is incomplete | 14:22 |
| mriedem | i'm not sure if i'll just continue working on mine or clean his up | 14:22 |
| mriedem | plus the trove patches are dependent on mine | 14:22 |
| *** aarefiev is now known as aarefiev_afk | 14:23 | |
| *** hongbin has joined #openstack-nova | 14:24 | |
| *** acormier has joined #openstack-nova | 14:25 | |
| *** READ10 has joined #openstack-nova | 14:27 | |
| mriedem | sdague: melwitt: superdan: looks like the trove job failed but it's not failing on the bury in cell0 InstanceNotFound thing with my patch http://logs.openstack.org/47/467447/15/check/gate-trove-scenario-dsvm-mariadb-multi-ubuntu-xenial-nv/30d878e/logs/screen-n-cond.txt.gz?level=TRACE | 14:29 |
| mriedem | now i just need to get unit tests fixed up | 14:29 |
| *** salv-orl_ has joined #openstack-nova | 14:30 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: integrate trait cache with TraitList and Trait https://review.openstack.org/462770 | 14:30 |
| sdague | mriedem: nice | 14:31 |
| efried | leakypipes Just saw a pop from an hour and a half ago - something about unicode mismatches? | 14:32 |
| *** pchavva has quit IRC | 14:32 | |
| *** salv-orlando has quit IRC | 14:32 | |
| leakypipes | efried: ya, it's cool though. alex_xu is gonna do it tomorrow morning. | 14:33 |
| efried | ight | 14:33 |
| *** pchavva has joined #openstack-nova | 14:33 | |
| *** tbachman has joined #openstack-nova | 14:38 | |
| *** ratailor has quit IRC | 14:40 | |
| *** jwcroppe has quit IRC | 14:44 | |
| *** jwcroppe has joined #openstack-nova | 14:44 | |
| *** markvoelker has joined #openstack-nova | 14:45 | |
| *** gomarivera has quit IRC | 14:48 | |
| efried | sdague Not sure if you saw, but glanceclient plans to cut a release next Wed. (This is regarding global req id work items) | 14:48 |
| *** coreywright has quit IRC | 14:48 | |
| sdague | efried: I did not see that | 14:48 |
| *** crushil has joined #openstack-nova | 14:48 | |
| *** gomarivera has joined #openstack-nova | 14:48 | |
| *** jwcroppe_ has joined #openstack-nova | 14:48 | |
| sdague | efried: do glance unit tests run for you? | 14:48 |
| efried | You're wanting https://review.openstack.org/#/c/467592/ to get in there? | 14:48 |
| sdague | because they seem to be hanging for me | 14:48 |
| sdague | efried: yes please | 14:48 |
| efried | sdague They did last week. Which env? | 14:48 |
| *** jwcroppe has quit IRC | 14:49 | |
| sdague | py27 | 14:49 |
| efried | sdague oh, glance, not glanceclient. Haven't done that, possibly ever. | 14:50 |
| *** mdrabe has quit IRC | 14:51 | |
| sdague | I'm trying to run locally and http://paste.openstack.org/show/610745/ | 14:51 |
| sdague | I guess it's all just timing out now | 14:51 |
| efried | sdague It wouldn't surprise me if there are latent bugs; there were in glanceclient. And the last couple weeks have been pretty chaotic around there. | 14:52 |
| *** gomarivera has quit IRC | 14:52 | |
| efried | I'm pulling & running locally, will let you know what I find. | 14:53 |
| mriedem | \o/ context manager is successfully mocked | 14:54 |
| *** tbachman has quit IRC | 14:54 | |
| *** vladikr has joined #openstack-nova | 14:56 | |
| sdague | mriedem: sweet | 14:57 |
| efried | sdague Okay, I hadn't gotten all the way through my emails - rosmaita called out your patch on the dev ML. | 14:57 |
| openstackgerrit | Jeremy Liu proposed openstack/python-novaclient master: Fix reservation_id not supported by Nova API https://review.openstack.org/468444 | 14:57 |
| *** lpetrut has quit IRC | 14:57 | |
| sdague | efried: https://review.openstack.org/#/c/468443/ is the thing I'd like to also get in on the glance side, because today the pass just overwrites the real request_id | 14:57 |
| *** masuberu has joined #openstack-nova | 14:58 | |
| *** mdrabe has joined #openstack-nova | 14:58 | |
| *** arunman has quit IRC | 14:58 | |
| efried | sdague Okay. (In case there's been some confusion, I'm not a glance guy - just jumped in there for the first time last week to get service-tokens work moving ;) | 14:59 |
| *** salv-orl_ has quit IRC | 14:59 | |
| mriedem | efried: you are now a glance guy | 15:00 |
| mriedem | deal with it | 15:00 |
| *** cfriesen has joined #openstack-nova | 15:00 | |
| sdague | mriedem: ++ | 15:00 |
| efried | dangit | 15:00 |
| *** coreywright has joined #openstack-nova | 15:01 | |
| *** ijw has joined #openstack-nova | 15:03 | |
| *** jerrygb has quit IRC | 15:03 | |
| *** rcernin has quit IRC | 15:04 | |
| *** jerrygb has joined #openstack-nova | 15:04 | |
| *** amotoki_away is now known as amotoki | 15:05 | |
| *** mdnadeem has quit IRC | 15:06 | |
| *** gyee has joined #openstack-nova | 15:06 | |
| *** kaisers_ has joined #openstack-nova | 15:07 | |
| *** salv-orlando has joined #openstack-nova | 15:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use targeted context when burying instances in cell0 https://review.openstack.org/468401 | 15:07 |
| mriedem | sdague: melwitt: superdan: ^ now with tests | 15:07 |
| mriedem | https://review.openstack.org/#/c/467447/ passed with that | 15:08 |
| *** READ10 has quit IRC | 15:09 | |
| *** kaisers_ has quit IRC | 15:11 | |
| melwitt | mriedem: none of those tests repro the original problem, where the instance can't be deleted, do they? | 15:12 |
| *** karthiks has joined #openstack-nova | 15:12 | |
| superdan | because they're not actually using the full cell fixture right? | 15:13 |
| mriedem | they aren't using the cells fixtures no | 15:14 |
| mriedem | well, | 15:14 |
| mriedem | they would be via the base test case | 15:14 |
| *** Oku_OS is now known as Oku_OS-away | 15:14 | |
| *** amotoki is now known as amotoki_away | 15:15 | |
| mriedem | if you want a full regression suite, that's probably a functional test, and probably the rest of my day | 15:15 |
| *** armax has joined #openstack-nova | 15:15 | |
| mriedem | i'm not actually sure why the TestDeleteFromCell0CheckQuota functional test never caught this | 15:16 |
| mriedem | since it's simulating a case where the instance fails to schedule and goes into ERROR state, and goes into cell0 | 15:16 |
| mriedem | could have to do with not actually doing notifications in tests | 15:17 |
| mriedem | checking | 15:17 |
| *** READ10 has joined #openstack-nova | 15:17 | |
| melwitt | okay, just thinking about how this got past tests in the first place | 15:17 |
| *** kaisers_ has joined #openstack-nova | 15:17 | |
| sdague | mriedem: any chance that it wasn't magicing the db enough? | 15:18 |
| melwitt | because the problem is the InstanceMapping is pointing at a NULL cell_id | 15:18 |
| melwitt | this is where the issue is right? https://review.openstack.org/#/c/468401/3/nova/conductor/manager.py@893 maybe we could at least assert the right context in that call in unit tests | 15:19 |
| *** efoley has quit IRC | 15:19 | |
| mriedem | melwitt: that's why the unit test changes do | 15:19 |
| melwitt | I thought those were only changes about notifications | 15:19 |
| efried | sdague FYI glance py35: Ran 625 tests in 1216.144s \ OK. py27 cranking up now. | 15:20 |
| mriedem | it doesn't blow up there, it's before that, | 15:20 |
| *** crushil has quit IRC | 15:20 | |
| mriedem | maybe you're asking that the tests also assert InstanceMapping.get_by_instance_uuid | 15:20 |
| mriedem | which is probably raising NotFound and we pass | 15:20 |
| *** crushil has joined #openstack-nova | 15:21 | |
| melwitt | maybe. I trust the fix, just saying none of the test changes are covering it. we can add coverage as a follow up if this is urgent | 15:21 |
| *** kaisers_ has quit IRC | 15:21 | |
| mriedem | superdan: so i'm guessing the reason this didn't fail functional tests like TestDeleteFromCell0CheckQuota is because the CellDatabases fixture is patching target_cell? | 15:21 |
| superdan | melwitt: no, the set_vm_state thing does actual changes to the instance right? | 15:22 |
| sdague | melwitt: on the up side we have real tests in trove that at least expose it | 15:22 |
| sdague | which is how we got here | 15:22 |
| superdan | mriedem: I dunno, I need to look at that test.. are you using CellDatabases or SingleCellSimple there? | 15:22 |
| mriedem | CellDatabases since USES_DB=True | 15:23 |
| superdan | yeah okay | 15:23 |
| *** karthiks has quit IRC | 15:23 | |
| mriedem | superdan: so for your question, | 15:24 |
| mriedem | i asked the same thing in your series https://review.openstack.org/#/c/458634/13/nova/objects/host_mapping.py@227 | 15:24 |
| melwitt | superdan: oh, yeah. set_vm_state makes the changes to the instance, so that explains the wonky states from the bug | 15:24 |
| melwitt | but the failed deletion part is that the InstanceMapping isn't pointing at the cell where the instance is | 15:24 |
| superdan | mriedem: that's different because it also talks to the celldb | 15:25 |
| *** cristicalin has quit IRC | 15:25 | |
| mriedem | i'll modify one of these tests to make sure the targeted context is passed to InstanceMapping.get_by_instance_uuid | 15:25 |
| *** tbachman has joined #openstack-nova | 15:25 | |
| mriedem | superdan: it being _check_and_create_host_mappings ? | 15:25 |
| superdan | mriedem: yeah | 15:26 |
| mriedem | the context passed in there is only used for the api db | 15:26 |
| melwitt | is the trove failure because of an inability to delete the instance? so we at least know the instance can be deleted with this fix | 15:26 |
| mriedem | since i thought compute.save() would already be targeted to the cell | 15:26 |
| mriedem | melwitt: yes | 15:26 |
| melwitt | okay, cool | 15:26 |
| mriedem | it hangs in scheduling state for ever and the test times out | 15:26 |
| superdan | mriedem: well, before the target yield it had to remain targeted because it was the shared context | 15:27 |
| mriedem | alright i'll just undo that part | 15:27 |
| mriedem | woe to new contributors | 15:27 |
| superdan | mriedem: I didn't -1 for it I was just gonna think on it | 15:27 |
| mriedem | ok | 15:27 |
| mriedem | i'll update tests in the meantime | 15:28 |
| superdan | mriedem: do you understand why your test didn't catch this? | 15:29 |
| mriedem | the functional one? no | 15:29 |
| mriedem | i didn't dig into the fixture magic | 15:29 |
| superdan | okay I'm still thinking on that | 15:29 |
| *** Drankis has quit IRC | 15:29 | |
| superdan | in devstack land, cell0 is the default connection so it would make sense to have gotten a free pass because of that | 15:29 |
| superdan | but with CellDatabases, it chooses cell1 to make the transition easier | 15:30 |
| melwitt | I still don't get why the fix works. how does it make the instance findable via InstanceMapping? | 15:30 |
| superdan | melwitt: it was failing to ever do the assignment because it failed the vm state update right? | 15:31 |
| superdan | explote on L888 means it never ran L892? | 15:31 |
| superdan | *explode | 15:31 |
| melwitt | ohhh | 15:31 |
| melwitt | right, thanks | 15:32 |
| melwitt | so the tests are covering it because it's not only notifications, it's an instance.save() with the right context and verifying that | 15:32 |
| mriedem | so i'm not changing anything right now then? | 15:33 |
| superdan | I don't think we need to hold up on the context thing.. since it's very specifically not needed, I would probably have not used the targeted one, but not sure it's worth changing | 15:35 |
| superdan | do you want to drill down on the functional test not catching it or no? | 15:35 |
| superdan | if this is holding up people, | 15:35 |
| superdan | an the trove test passes, I'd say we go | 15:35 |
| melwitt | I'm cool with doing this now and looking into the functional test as a follow up | 15:35 |
| mriedem | i changed the InstanceMapping.get_by_instance_uuid to use context instead of cctxt and no unit tests failed, so we're not asserting that | 15:35 |
| mriedem | so i can change that back, or add an assertion, or do nothing in this change | 15:36 |
| *** karthiks has joined #openstack-nova | 15:36 | |
| mriedem | it's an easy switch back to just using context for that call | 15:36 |
| superdan | well, not validating it because it's not a big deal | 15:36 |
| superdan | I'm cool with either, up to you | 15:36 |
| melwitt | ditto | 15:36 |
| mriedem | i'll change it and add comments | 15:37 |
| mriedem | b/c otherwise it's confusing | 15:37 |
| *** eharney has joined #openstack-nova | 15:38 | |
| mriedem | i'll recheck the trove change on this one too | 15:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use targeted context when burying instances in cell0 https://review.openstack.org/468401 | 15:38 |
| efried | sdague py27 finished with one failure for me: http://paste.openstack.org/show/610750/ | 15:39 |
| *** marst has joined #openstack-nova | 15:39 | |
| *** belmoreira has quit IRC | 15:39 | |
| *** viks has joined #openstack-nova | 15:40 | |
| mriedem | leakypipes: i added MOS to this https://bugs.launchpad.net/mos/+bug/1693829 | 15:40 |
| openstack | Launchpad bug 1693829 in OpenStack Compute (nova) "name too long" [Undecided,New] | 15:40 |
| mriedem | in case you guys have triage people | 15:40 |
| leakypipes | k | 15:40 |
| viks | Hi seeking attention on https://review.openstack.org/#/c/468089/ . Need one more verification :) | 15:42 |
| viks | thanks mriedem | 15:44 |
| *** dillaman has quit IRC | 15:47 | |
| *** jdillaman has quit IRC | 15:47 | |
| *** armax has quit IRC | 15:47 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | 15:51 |
| *** armax has joined #openstack-nova | 15:53 | |
| mriedem | mtreinish: uh oh! https://bugs.launchpad.net/nova/+bug/1693257 | 15:54 |
| openstack | Launchpad bug 1693257 in OpenStack Compute (nova) "Policy doesn't allow os_compute_api:os-cloudpipe to be performed" [Undecided,New] | 15:54 |
| mriedem | there might have been 1 cloudpipe user in the wild | 15:54 |
| *** gomarivera has joined #openstack-nova | 15:54 | |
| mtreinish | mriedem: haha, well they're in for a surprise in pike | 15:55 |
| *** dillaman has joined #openstack-nova | 15:55 | |
| *** sridharg has joined #openstack-nova | 15:56 | |
| *** READ10 has quit IRC | 15:56 | |
| *** sridharg has quit IRC | 15:56 | |
| sean-k-mooney | hi o/ | 15:56 |
| sean-k-mooney | mriedem: leakypipes sfinucan can i ye take a look at https://bugs.launchpad.net/nova/+bug/1691178 and https://review.openstack.org/#/c/465160/ | 15:58 |
| openstack | Launchpad bug 1691178 in OpenStack Compute (nova) "virt_type=qemu does not support cpu affinity." [Undecided,New] - Assigned to sean mooney (sean-k-mooney) | 15:58 |
| *** jdillaman has joined #openstack-nova | 15:58 | |
| mriedem | mtreinish: i don't think they understand policy anyway, | 15:58 |
| mriedem | it's admin-only by default and they are probably using non-admin | 15:59 |
| mriedem | sean-k-mooney: you realize that's going to require tests | 15:59 |
| sean-k-mooney | mriedem: leakypipes superdan just wondering if this is a bug you want to fix/ should i also adress this when selecting the host? | 15:59 |
| sean-k-mooney | mriedem: yes | 15:59 |
| mriedem | i don't know anything about this code | 15:59 |
| sean-k-mooney | mriedem: qemu without kvm/zen does not support cpu affinity | 16:00 |
| sean-k-mooney | we generate vcpu-pin ellement anyway and the vm fails to boot with a livbirt error | 16:00 |
| cfriesen | sdague: does the api-ref changes in https://review.openstack.org/#/c/434514 match what you were looking for? (incidentally, it's lame that the min/max version is in parameters.yaml instead of the *.inc files, it leads to duplicated entries differing only in min/max version) | 16:00 |
| leakypipes | sean-k-mooney: on the bug report, you put expected result that the VM starts with a virt topology. however, TCG doesn't support NUMA so how is that right? | 16:00 |
| *** dillaman has quit IRC | 16:00 | |
| mriedem | sean-k-mooney: do you need to have that refactor in there? | 16:01 |
| *** dillaman has joined #openstack-nova | 16:01 | |
| sean-k-mooney | leakypipes: numa is supprot cpu affinity is not | 16:01 |
| leakypipes | sean-k-mooney: what precisely is the point of NUMA without CPU affinity? | 16:02 |
| mriedem | untriaged bugs < 100 \o/ | 16:02 |
| sean-k-mooney | mriedem: the if puts me over the 80 charter limit and pep8 complains | 16:02 |
| mriedem | time for lunch | 16:02 |
| *** ralonsoh has quit IRC | 16:02 | |
| cfriesen | leakypipes: TCG still lets you call the "virsh vcpupin" APIs, it just doesn't always give the expected results when you have multiple vCPUs. | 16:02 |
| mriedem | sean-k-mooney: refactor in a separate change | 16:02 |
| *** mriedem is now known as mriedem_bbq | 16:02 | |
| cfriesen | leakypipes: TCG still supports hugepages | 16:02 |
| sean-k-mooney | mriedem_bbq: cool no problem ill do that and ill also add tests | 16:02 |
| leakypipes | cfriesen: guh. | 16:03 |
| sean-k-mooney | mriedem_bbq: just wanted to know if people were ok with me "fixing" the bug or if i should spend time on something else | 16:03 |
| leakypipes | cfriesen, sean-k-mooney: honestly, why are we going out of our way to support this kind of thing for an emulator nobody will use in production? | 16:03 |
| sean-k-mooney | leakypipes: numa and hugepages are unrelated to cpu affintiy execpt in nova... am it would help with testing with ovs-dpdk in the upstream ci in the future | 16:04 |
| cfriesen | leakypipes: I don't really care about jumping through hoops to make TCG work better. | 16:04 |
| cfriesen | leakypipes: sean-k-mooney: we use TCG for designer testing, but not for production | 16:05 |
| sdague | cfriesen: well, a lot of those lame things were to make it a lot more clear when changing things where they ended up, and that no editor is going to help you edit yaml correctly nested inside an rst block :P | 16:05 |
| sean-k-mooney | cfriesen: leakypipes basically the only thing that stops testing ovs-dpdk in the upstream ci is the fact that rackspcae uses zen so i cant rely on kvm being avaiable | 16:06 |
| *** nic has joined #openstack-nova | 16:06 | |
| sean-k-mooney | cfriesen: leakypipes i have been trying to make it work with just qemu but sinc we generate cpu affinity info when we request numa/hugepages i cant use that either | 16:06 |
| *** nic1 has joined #openstack-nova | 16:07 | |
| sean-k-mooney | cfriesen: leakypipes that said the TCG backend has a segfault bug in upstream qemu that they need to fix also so even then i would need that to be fixed to support my usecase | 16:07 |
| cfriesen | sean-k-mooney: the newer qemu/libvirt must be more strict, under the same circumstances it works for us (but as I recall we're running somewhat older versions than you) | 16:07 |
| sean-k-mooney | cfriesen: yes it only an issue with newer libvirt | 16:08 |
| sean-k-mooney | i am using 3.3.0 and qemu 2.8 | 16:08 |
| leakypipes | sean-k-mooney: well, I'll review the patch in a bit. not too thrilled obviously by it, but I'll review just because I like you. :) | 16:09 |
| cfriesen | sean-k-mooney: honestly that seems like a libvirt bug, since it should still be able to affine the qemu process even if it can't affine the individual vCPU threads separately | 16:09 |
| cfriesen | sean-k-mooney: it seems to me that libvirt should accept it as long as all vCPUs are affined the same | 16:10 |
| sean-k-mooney | leakypipes: aw, offers of beer at next ptg hehe. | 16:10 |
| *** nic has quit IRC | 16:10 | |
| sean-k-mooney | leakypipes: it not a high proity i just wanted to know if i should rebase and continue working on it or we dont care about the TCG backend | 16:11 |
| sean-k-mooney | cfriesen: yes that was discused on libvirt mailing list tangentaly. | 16:12 |
| sean-k-mooney | cfriesen: we are specificaly generating per core configurat which is invalad | 16:12 |
| sean-k-mooney | cfriesen: affinties all the cores to the same set should work | 16:12 |
| cfriesen | sean-k-mooney: I don't care about the backend except to the extent it enables ovs-dpdk in upstream CI. :) | 16:12 |
| leakypipes | sean-k-mooney: I'm willing to review the patch if it's something you need to work on ovs-dpdk. | 16:12 |
| sean-k-mooney | cfriesen: leakypipes ill ask infra if we can create a job that will only run on ci provides that use kvm | 16:13 |
| *** marst has quit IRC | 16:13 | |
| sean-k-mooney | if they can provide that i dont need the change and i can test it upstream with a configuration that is closer to production | 16:13 |
| *** lucasagomes is now known as lucas-afk | 16:14 | |
| sean-k-mooney | that is my preferend solution honestly but they were not to open to that the last time i asked | 16:14 |
| sean-k-mooney | the whole motivation for this was i was asked to try and figure out how to also test ovs-dpdk upstream with odl and ovn but if i can do it with neutron i also blockes with an sdn controler | 16:15 |
| leakypipes | k | 16:16 |
| *** gomarivera has quit IRC | 16:23 | |
| *** gomarivera has joined #openstack-nova | 16:23 | |
| *** ltomasbo is now known as ltomasbo|away | 16:27 | |
| *** gomarivera has quit IRC | 16:27 | |
| *** gomarivera has joined #openstack-nova | 16:28 | |
| *** kaisers has quit IRC | 16:30 | |
| *** david-lyle has joined #openstack-nova | 16:30 | |
| *** markvoelker has quit IRC | 16:30 | |
| *** crushil has quit IRC | 16:34 | |
| *** tidwellr has quit IRC | 16:35 | |
| *** viks has quit IRC | 16:37 | |
| efried | sdague I pulled down your change and py27 passed all the way for me. | 16:38 |
| efried | Did you maybe have an old venv? tox -r? | 16:38 |
| sdague | efried: I did a -r | 16:40 |
| efried | sdague hmph, can't explain it. | 16:41 |
| *** sridharg has joined #openstack-nova | 16:41 | |
| sdague | yeh, neither can I, oh well | 16:41 |
| *** cdent has joined #openstack-nova | 16:41 | |
| efried | sdague Jenkins seems to agree with me, so yeah, oh well. | 16:42 |
| *** gomarivera has quit IRC | 16:43 | |
| *** kaisers has joined #openstack-nova | 16:45 | |
| *** sambetts is now known as sambetts|afk | 16:46 | |
| sdague | efried: yeh, I'll completely blow away the directory at some point and reset | 16:48 |
| *** gomarivera has joined #openstack-nova | 16:49 | |
| *** jaosorior has quit IRC | 16:49 | |
| *** dtp has joined #openstack-nova | 16:51 | |
| sdague | ok, the oslo.middleware request_id change + mv 2.46 is green - https://review.openstack.org/#/c/467998 | 16:53 |
| *** kaisers has quit IRC | 16:54 | |
| *** crushil has joined #openstack-nova | 16:54 | |
| *** sridharg has quit IRC | 16:56 | |
| *** ctrath has joined #openstack-nova | 16:57 | |
| *** esberglu has quit IRC | 16:57 | |
| *** david-lyle has quit IRC | 16:58 | |
| *** derekh has quit IRC | 16:58 | |
| *** itlinux has joined #openstack-nova | 16:58 | |
| *** jpena is now known as jpena|off | 17:05 | |
| *** kaisers has joined #openstack-nova | 17:12 | |
| *** kaisers1 has joined #openstack-nova | 17:13 | |
| *** ctrath has quit IRC | 17:14 | |
| *** kaisers has quit IRC | 17:17 | |
| *** rmart04 has quit IRC | 17:17 | |
| *** Swami has joined #openstack-nova | 17:20 | |
| *** tidwellr has joined #openstack-nova | 17:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 17:25 |
| *** jmlowe has quit IRC | 17:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/468494 | 17:29 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 17:30 |
| sdague | melwitt: I'm sticking that behind the other one which is mv sensitive so that it doesn't cause a merge issue late | 17:30 |
| *** salv-orlando has quit IRC | 17:30 | |
| sdague | melwitt: if you want to poke at https://review.openstack.org/#/c/467998 - it would be much appreciated | 17:31 |
| *** salv-orlando has joined #openstack-nova | 17:31 | |
| melwitt | sdague: ack | 17:32 |
| *** salv-orlando has quit IRC | 17:35 | |
| leakypipes | cdent: fabulous: "Your reward is a brief moment of respite from the despair of existence." | 17:35 |
| *** gomarivera has quit IRC | 17:36 | |
| *** gomarivera has joined #openstack-nova | 17:36 | |
| cdent | leakypipes: you made it to the end! bask in this brief moment! | 17:37 |
| *** itlinux_ has joined #openstack-nova | 17:38 | |
| *** slaweq has joined #openstack-nova | 17:41 | |
| *** mriedem_bbq is now known as mriedem | 17:42 | |
| *** itlinux has quit IRC | 17:42 | |
| leakypipes | cdent: :) | 17:43 |
| cdent | too late, the moment is over | 17:43 |
| *** salv-orlando has joined #openstack-nova | 17:44 | |
| *** slaweq has quit IRC | 17:45 | |
| *** markus_z has quit IRC | 17:45 | |
| mriedem | sdague: https://bugs.launchpad.net/nova/+bug/1693228 | 17:47 |
| openstack | Launchpad bug 1693228 in OpenStack Compute (nova) "Nova quota show/set give errors in verify_project_id" [Undecided,New] | 17:47 |
| mriedem | looks like some url munging problems http://<domain:port>/v3/v3/projects/<project_id> | 17:47 |
| melwitt | sdague, mriedem: do we need a reno on the mv 2.46 change? | 17:48 |
| melwitt | for the new microversion | 17:48 |
| mriedem | melwitt: umm, probably | 17:48 |
| melwitt | other than that, it looks reasonable to me | 17:49 |
| mriedem | sdague: does the global request id just get generated or does the user pass it in on the request? | 17:49 |
| mriedem | either way, the point of the microversion is to signal to users that they can get that thing back from this cloud and use it to trace through other services | 17:49 |
| mriedem | so it's probably good to call it out in release notes as a feature | 17:49 |
| melwitt | yeah, was thinking the same | 17:49 |
| *** yamahata has joined #openstack-nova | 17:50 | |
| *** jwcroppe_ has quit IRC | 17:50 | |
| *** annegentle has joined #openstack-nova | 17:51 | |
| *** slaweq has joined #openstack-nova | 17:52 | |
| sdague | mriedem: ok, so there are 2 things going on here, that are related, but slightly different | 17:53 |
| sdague | global_request_id is an inbound value, with a request header of X-OpenStack-Request-ID | 17:53 |
| *** itlinux_ has quit IRC | 17:53 | |
| sdague | you set that | 17:53 |
| sdague | there is also an outbound response header | 17:53 |
| sdague | X-OpenStack-Request-ID - which is locally generated | 17:54 |
| sdague | that's been true for every service except Nova for years | 17:54 |
| sdague | Nova was doing the same thing with X-Compute-Request-ID | 17:54 |
| sdague | in order to get the inbound behavior without copy/paste we needed to adopt the oslo lib | 17:55 |
| sdague | which meant getting the oslo behavior | 17:55 |
| sdague | mriedem: I can add a reno | 17:55 |
| mriedem | ok | 17:55 |
| sdague | you want it in this patch, or a follow on? | 17:56 |
| mriedem | same one | 17:56 |
| sdague | ok, through the jenkins gauntlet again :) | 17:56 |
| *** bnemec is now known as beekneemech | 17:57 | |
| *** karimb has quit IRC | 17:57 | |
| mriedem | lbragstad: jamielennox|away: can you take a look at this? https://bugs.launchpad.net/nova/+bug/1693228 | 17:59 |
| openstack | Launchpad bug 1693228 in OpenStack Compute (nova) "Nova quota show/set give errors in verify_project_id" [Undecided,Triaged] | 17:59 |
| lbragstad | mriedem: sure | 18:00 |
| mriedem | since ocata nova tries to validate a project id in our quotas API by calling /v3/projects/{project_id} | 18:00 |
| *** pcaruana has quit IRC | 18:00 | |
| mriedem | this assumes you have keystone v3 since v2 has been deprecated since i think mitaka | 18:00 |
| mriedem | the person in the bug report said that nova hard-coding /v3/ in the url prefix is wrong | 18:00 |
| lbragstad | mriedem: i'm digging into some stable maintenance things for keystone at the moment, but i'll look into that next | 18:00 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 18:00 |
| sdague | right, this is the versioned vs. unversioned keystone endpoint issue | 18:01 |
| mriedem | ok - only thing that gives me pause is the v3 api-ref uses /v3/ too https://developer.openstack.org/api-ref/identity/v3/#show-project-details | 18:01 |
| sdague | https://review.openstack.org/#/c/438049/ | 18:01 |
| sdague | mriedem: so that's the result they will get if they made their identity url use the versioned one | 18:01 |
| sdague | it's the same thing tripleo hit | 18:02 |
| sdague | there is other keystoneauth magic we could lean on here | 18:03 |
| sdague | the half baked patch I had died on the vine | 18:03 |
| sdague | actually, I think https://review.openstack.org/#/c/438049/6/nova/api/openstack/identity.py might be the fix for them as well | 18:04 |
| sdague | I didn't like it at the time because of how much magic hiding of issues it does | 18:04 |
| mriedem | hit kolla too https://review.openstack.org/#/c/463500/ | 18:04 |
| sdague | yeh. | 18:06 |
| mriedem | so with that patch of yours, | 18:06 |
| mriedem | they go from a 400 (because of endpoint not found) to a 404 (Because endpoint not found) | 18:06 |
| mriedem | but with a helpful message | 18:06 |
| sdague | actually, they wouldn't get a 404 | 18:07 |
| mriedem | or does ksa actually do magic to find the right v3 endpoint? | 18:07 |
| sdague | yep, it does | 18:07 |
| mriedem | oh well that's neat | 18:07 |
| sdague | that's the magic I wasn't all that comfortable with | 18:07 |
| mriedem | oh | 18:07 |
| mriedem | well | 18:07 |
| sdague | but, honestly, it's probably the right UX for operators | 18:07 |
| mriedem | yeah, plus upgrade impact isn't fun | 18:07 |
| sdague | yep | 18:08 |
| sdague | ok, so how about the following deal. You look at mv 2.46 again, and I'll fix this patch | 18:08 |
| *** rmart04 has joined #openstack-nova | 18:08 | |
| sdague | which we'll probably want to backport | 18:08 |
| openstackgerrit | John Griffith proposed openstack/nova master: cinder: add attachment_create method https://review.openstack.org/459111 | 18:08 |
| openstackgerrit | John Griffith proposed openstack/nova master: cinder: add attachment_update method https://review.openstack.org/459113 | 18:08 |
| openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 18:08 |
| *** eharney has quit IRC | 18:08 | |
| mriedem | sdague: ok | 18:09 |
| *** eharney has joined #openstack-nova | 18:12 | |
| *** ericyoung has quit IRC | 18:16 | |
| *** mriedem1 has joined #openstack-nova | 18:16 | |
| *** mriedem1 has quit IRC | 18:16 | |
| *** mriedem1 has joined #openstack-nova | 18:17 | |
| *** slaweq has quit IRC | 18:17 | |
| *** mriedem has quit IRC | 18:18 | |
| mriedem1 | superdan: want to update the link in the channel topic to https://wiki.openstack.org/wiki/Nova/Pike_Release_Schedule ? | 18:18 |
| superdan | oh alright | 18:18 |
| *** ChanServ sets mode: +o superdan | 18:19 | |
| *** superdan changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Pike_Release_Schedule" | 18:19 | |
| *** ChanServ sets mode: -o superdan | 18:19 | |
| *** awaugama has quit IRC | 18:23 | |
| *** awaugama has joined #openstack-nova | 18:23 | |
| mriedem1 | 2.46 reviewed | 18:24 |
| *** mriedem1 is now known as mriedem | 18:24 | |
| openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 18:25 |
| *** pchavva has quit IRC | 18:27 | |
| lbragstad | mriedem: so you don't need anything from a ksa perspective, just double checking | 18:28 |
| mriedem | lbragstad: sean is on it | 18:31 |
| mriedem | thanks | 18:31 |
| mriedem | leakypipes: figleaf: cdent: is there anything that merged recently which might be causing this? http://logs.openstack.org/32/468232/1/gate/gate-tempest-dsvm-cells-ubuntu-xenial/ad969ba/logs/screen-n-cpu.txt.gz?level=TRACE#_May_26_17_29_52_292260 | 18:32 |
| mriedem | looks like a race to cleanup allocations in the resource tracker when an instance is deleted | 18:32 |
| * cdent reads | 18:32 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1693899 | 18:33 |
| openstack | Launchpad bug 1693899 in OpenStack Compute (nova) "Cleaning up stale resource allocations can fail with InstanceNotFound" [Undecided,New] | 18:33 |
| mriedem | just started in the last 24 hours or so | 18:33 |
| mriedem | https://github.com/openstack/nova/commit/439f67e7bc795f171af8248400c3f3e17a0bbe7e ? | 18:33 |
| mriedem | yup | 18:33 |
| * cdent quacks | 18:35 | |
| artom | mriedem, the InstanceNotFound test thing - better to squash the two patches into one in the backport, or leave separate? | 18:36 |
| mriedem | artom: gonna be hard to separate them since it's writing a test for something already fixed on master | 18:36 |
| artom | mriedem, it could be fix first then test in the top patch. But yeah, squash makes more sense | 18:37 |
| mriedem | unless you mean the test backport comes after the fix backport on stable too | 18:37 |
| mriedem | ok | 18:37 |
| mriedem | either way | 18:37 |
| mriedem | cdent: figleaf: anyone want to pick that up? seems like just needs to handle that InstanceNotFound in RT, but i didn't review that original patch | 18:38 |
| cdent | mriedem: i can give it a try, that's what I was thinking too | 18:38 |
| artom | I noticed lyarwood proposed the fix for ocata too - if you're still around lyarwood, mind if I jump in in your patch and add the test? | 18:39 |
| * cdent tries it right now | 18:39 | |
| mriedem | why is this a warning? https://review.openstack.org/#/c/460177/12/nova/compute/resource_tracker.py@1013 | 18:39 |
| mriedem | because the RT shouldn't be cleaning up allocations when the scheduler/conductor is? | 18:40 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/468514 | 18:41 |
| cdent | warning seems wrong to me. | 18:41 |
| mriedem | "WARNING I AM DOING THAT THING YOU ASKED ME TO DO" | 18:42 |
| cdent | i'll change that too? | 18:42 |
| mriedem | separate | 18:43 |
| mriedem | but wow http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Deleting%20stale%20allocation%20for%20instance%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d | 18:43 |
| mriedem | cdent: it was latent https://review.openstack.org/#/c/460177/12/nova/scheduler/client/report.py@a929 | 18:44 |
| figleaf | cdent: sorry, was heads down and just saw the above. You got it? | 18:44 |
| mriedem | and if that's in ocata we'll want to backport that | 18:44 |
| cdent | figleaf: yeah, you carry on on your stuff, should be fine | 18:44 |
| mriedem | crap it's all the way back to newton https://github.com/openstack/nova/commit/9374566d194be1e861e7d08dd0e3b2a615ff408c | 18:45 |
| mriedem | cdent: i'll open a separate bug for the warning | 18:45 |
| *** felipemonteiro has quit IRC | 18:45 | |
| cdent | ✔ | 18:45 |
| *** felipemonteiro has joined #openstack-nova | 18:45 | |
| *** felipemonteiro has quit IRC | 18:47 | |
| *** felipemonteiro has joined #openstack-nova | 18:47 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1693903 | 18:47 |
| openstack | Launchpad bug 1693903 in OpenStack Compute (nova) "Excessive "Deleting stale allocation for instance" warnings in nova-compute logs" [Undecided,New] | 18:47 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Be more tolerant of keystone catalog configuration https://review.openstack.org/438049 | 18:47 |
| sdague | lbragstad / mriedem ^^^ | 18:47 |
| *** artom_ has joined #openstack-nova | 18:52 | |
| *** annegentle has quit IRC | 18:52 | |
| *** jmlowe has joined #openstack-nova | 18:54 | |
| *** artom has quit IRC | 18:54 | |
| *** felipemonteiro has quit IRC | 18:58 | |
| mriedem | sdague: commented. some issues in the release note | 18:58 |
| *** lucasxu has quit IRC | 18:58 | |
| mriedem | i thought the validation in the quota sets api happened in ocata so i was wrong there, we probably do want the new note under the upgrade section | 18:58 |
| mriedem | but let's do it in a separate new release note please | 18:58 |
| *** annegentle has joined #openstack-nova | 18:58 | |
| *** sdague has quit IRC | 18:59 | |
| *** sdague has joined #openstack-nova | 18:59 | |
| sdague | mriedem: ok, I'm trying to understand what you wanted as release notes | 19:00 |
| sdague | because in the last patch you said make it a dedicated one | 19:00 |
| sdague | oh, that it shows up so much later that we just need a whole other file? | 19:01 |
| sdague | walk me through your ideal world here, I'll make it :) | 19:01 |
| sdague | also, irc client crash, so my back buffer is gone | 19:01 |
| mtreinish | sdague: I want world peace | 19:02 |
| *** xyang1 has joined #openstack-nova | 19:03 | |
| *** salv-orl_ has joined #openstack-nova | 19:04 | |
| mriedem | sdague: the release note you're updating is already in a tagged release, | 19:04 |
| mriedem | so it should be a separate file | 19:04 |
| mriedem | tox -e venv -- reno new <something> | 19:04 |
| openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | 19:05 |
| mriedem | sdague: i was also confused because i thought we had this validation in the quotas api in ocata, | 19:05 |
| mriedem | but we don't, | 19:05 |
| sdague | ok, separate file is fine | 19:05 |
| mriedem | so i think you just need to add a new release note with an upgrade impact that notes the thing about not being able to find keystone v3 will result in a 400 for these apis now | 19:05 |
| sdague | I don't think this is an upgrade impact | 19:06 |
| sdague | I actually think it mitigates one | 19:06 |
| mriedem | if ksa does the magic to find v3 and the only issue is if v3 isn't there, then maybe the upgrade impact is just, 'nova requires keystone v3 now' | 19:06 |
| sdague | the previous patch actually required unversioned keystone endpoint | 19:06 |
| mriedem | it's an upgrade impact if you don't have keystone v3 right? | 19:06 |
| sdague | sure | 19:06 |
| *** salv-orlando has quit IRC | 19:06 | |
| lbragstad | yeah - i was going to say something like that in the comment here - https://review.openstack.org/#/c/438049/7/nova/api/openstack/identity.py,unified | 19:07 |
| mriedem | which i dont think we required before this | 19:07 |
| sdague | mriedem: it's actually kind of unclear if we did or not | 19:07 |
| sdague | it turns out if we'd had this patch, tripleo would have worked | 19:07 |
| mriedem | alternative we don't release note it | 19:07 |
| sdague | without any changes | 19:07 |
| lbragstad | reading the error on lines 45 - 48 make it seem like nova requires v3 | 19:07 |
| sdague | lbragstad: it does for this call | 19:07 |
| mriedem | i think i'm just trying to say, if we were unsure before, we're sure now | 19:08 |
| mriedem | so seems we should note that | 19:08 |
| sdague | mriedem: yes, that's fair | 19:08 |
| mriedem | but...the existing reno has GET /v3/projects/project_id in it | 19:08 |
| mriedem | which implies v3 is required | 19:08 |
| mriedem | so maybe we just don't need a release note for this fix | 19:08 |
| *** awaugama has quit IRC | 19:08 | |
| sdague | yeh | 19:09 |
| sdague | I was just looking, that is what I'd sort of go with | 19:09 |
| mriedem | i'm good either way | 19:09 |
| sdague | the only other item is the fact that we fixed a bug we introduced in p1 | 19:09 |
| mriedem | right that tripped me up | 19:09 |
| *** rmart04 has quit IRC | 19:09 | |
| sdague | but, for people that don't consume this until pike final, saying that might be really confusing | 19:09 |
| mriedem | i very much doubt many people are in product on p1 right now | 19:09 |
| mriedem | right | 19:10 |
| mriedem | so i'd either say nothing, no new reno, or new reno that just has an upgrade impact saying keystone v3 is for sure required now | 19:10 |
| sdague | ok, lets go nothing | 19:10 |
| mriedem | read my lips, no, new, reno | 19:10 |
| openstackgerrit | Sean Dague proposed openstack/nova master: Be more tolerant of keystone catalog configuration https://review.openstack.org/438049 | 19:11 |
| mriedem | +2 | 19:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 19:14 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | 19:14 |
| mriedem | sdague: also +2 on your 2.46 | 19:15 |
| *** lucasxu has joined #openstack-nova | 19:15 | |
| mriedem | melwitt: ^ | 19:15 |
| mriedem | artom_: so about this bug https://bugs.launchpad.net/nova/+bug/1692893 - what you reported is really a duplicate of the other bug, so shouldn't we duplicate it? | 19:15 |
| openstack | Launchpad bug 1692893 in OpenStack Compute (nova) "'nova usage' returns 500 when deleted row in instance_extra is archived" [Undecided,New] | 19:15 |
| melwitt | mriedem: +W | 19:16 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Catch InstanceNotFound when deleting allocations https://review.openstack.org/468517 | 19:16 |
| artom_ | mriedem, I specifically didn't because duplicating it would hide it from search results, and I feel like my report is more relevant to actual users, as opposed to the other Tempest stacktrace | 19:17 |
| *** artom_ is now known as arotm | 19:17 | |
| *** arotm is now known as artom | 19:17 | |
| mriedem | ok, well, i just duplicated it :) | 19:17 |
| artom | mriedem, *shrug* | 19:17 |
| mriedem | i didn't think about search results | 19:17 |
| artom | I don't feel that strongly about it | 19:18 |
| melwitt | hm, I didn't think dupes got hidden from search results | 19:18 |
| artom | It warns you before you do it | 19:18 |
| mriedem | mtreinish: so i just read https://bugs.launchpad.net/nova/+bug/1692376 | 19:18 |
| openstack | Launchpad bug 1692376 in OpenStack Compute (nova) "Binary dependencies aren't easily discoverable" [Undecided,New] | 19:18 |
| artom | So I went to duplicate it, and then thought otherwise | 19:19 |
| mriedem | mtreinish: and....idk | 19:19 |
| melwitt | artom: interesting, never knew that | 19:19 |
| mriedem | mtreinish: the binary dependencies you need are going to depend on service and configuration | 19:19 |
| mriedem | mtreinish: plus anything in the devref is going to get out of date | 19:19 |
| artom | melwitt, I just discovered a couple of days ago ;) | 19:19 |
| melwitt | launchpad, you are full of mysteries | 19:19 |
| mtreinish | mriedem: well if we don't actually write it down anywhere how are people supposed to know what's needed? | 19:20 |
| mriedem | just like http://cosmosmysteryarea.com/index.html | 19:20 |
| artom | For all we know LP is where The Matrix will come from | 19:20 |
| mriedem | mtreinish: requirements.txt + bindep? | 19:20 |
| *** salv-orl_ has quit IRC | 19:21 | |
| mriedem | we used to have a fairly full package list in https://docs.openstack.org/developer/nova/development.environment.html#explicit-install-clone | 19:21 |
| mriedem | but then we got bindep and that was cleaned up | 19:21 |
| *** salv-orlando has joined #openstack-nova | 19:21 | |
| melwitt | lol, we have the same thing in santa cruz https://www.mysteryspot.com/ | 19:21 |
| mtreinish | mriedem: and bindep are just the deps for running the tests (like what you need to build libxml, etc) | 19:22 |
| *** dimtruck is now known as zz_dimtruck | 19:22 | |
| mtreinish | like where does it say I need qemu-img installed? | 19:23 |
| mriedem | mtreinish: where does it say you need hyper-v or vcenter installed? | 19:23 |
| mriedem | or a power 8 rack for powervm? :) | 19:23 |
| *** mingyu has joined #openstack-nova | 19:24 | |
| mriedem | https://docs.openstack.org/ocata/config-reference/compute/hypervisors.html | 19:24 |
| mriedem | is anything hypervisor specific | 19:24 |
| *** salv-orlando has quit IRC | 19:25 | |
| mtreinish | mriedem: well powervm isn't in tree :) | 19:26 |
| sdague | mtreinish: surprise! it mostly is | 19:26 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Changing deleting stale allocations warning to debug https://review.openstack.org/468519 | 19:27 |
| mtreinish | oh, it started merging | 19:27 |
| mriedem | yeha | 19:27 |
| mriedem | *yeah | 19:27 |
| mtreinish | mriedem: so I agree there are some bits that are config dependent, but clearly outlining the requirements for using nova seems like something we should do | 19:28 |
| mriedem | i actually got on efried the other night about docs | 19:28 |
| mriedem | mtreinish: i have triaged it as opinion | 19:28 |
| mriedem | which means it is now in purgatory | 19:28 |
| mtreinish | mriedem: especially since there are things which you need like qemu-img which are always needed (at least from what I could tell) | 19:28 |
| mtreinish | mriedem: what does opinion even mean? | 19:28 |
| mriedem | it means, meh | 19:28 |
| cdent | mriedem: I've pushed fixes for both of those bugs, but only ran the nearby tests before I did. It is time for my weekend to start so feel free to fix everything I've forgotten. | 19:28 |
| mriedem | cdent: thanks | 19:29 |
| *** adisky_ has quit IRC | 19:29 | |
| *** artom has quit IRC | 19:30 | |
| sdague | mtreinish: I think writing the arch install guide in nova tree is out of scope. That is kind of part of what the install guide and packaging is about | 19:31 |
| *** slaweq has joined #openstack-nova | 19:31 | |
| mtreinish | I'm not saying the arch install guide. (I haven't even tried that) I'm saying we're shipping code with external requirements that aren't documented anywhere | 19:32 |
| mtreinish | sure packaging solves this, but how do packagers know what's needed | 19:32 |
| mtreinish | it doesn't seem unreasonable to say if installing from source make sure you have X, Y, Z installed since nova calls out to those | 19:33 |
| sdague | by being part of our community | 19:33 |
| efried | mtreinish Since you're clearly interested in furthering the cause of powervm in-tree, here ya go: https://review.openstack.org/#/c/443189/ | 19:33 |
| sdague | I do get in a perfect world there would be a crisp "here is everything you need" interface, but in the list of priorities that's not really in the top 100 | 19:33 |
| efried | (and mriedem, updating refs is on our to-do list, near the top) | 19:33 |
| sdague | as the only people it's impacting is building from source without using any of the deployment projects | 19:34 |
| mtreinish | sdague: I'm not saying it's a priority. I filed a bug to just recognize it's a gap | 19:34 |
| mriedem | mtreinish: i didn't invalidate the bug, i just marked it low priority | 19:34 |
| mriedem | if someone wants to take that on they can | 19:34 |
| mriedem | with my reservations about it noted in there | 19:35 |
| mriedem | i.e. complicated and getting out of date easily | 19:35 |
| mtreinish | efried: I guess that I can take a look... | 19:35 |
| efried | mtreinish It's a biggie. Perhaps you can figure out a way to parallel-process the review using that cloud in your closet... | 19:36 |
| sdague | mtreinish: right, so my feeling is that bugs not in the top 100 priorities are just hay hiding needles in the stack. | 19:36 |
| sdague | efried: https://review.openstack.org/#/c/443189/24/nova/virt/powervm/tasks/storage.py ... I'm confused about the LOG.exception that have "ignoring" in their message | 19:37 |
| sdague | because, that's going to be a giant stack trace which will scare people | 19:38 |
| *** djohnsto has quit IRC | 19:38 | |
| sdague | but then being "meh" | 19:38 |
| mtreinish | efried: I asked ibm to give me funding for that cloud and I was told no. They didn't even offer to give me any power boxes | 19:38 |
| efried | sdague Taskflow esoterica | 19:38 |
| sdague | seems contradictory | 19:38 |
| mtreinish | not that my circuit breaker could handle them | 19:38 |
| mriedem | leakypipes: did https://review.openstack.org/#/c/409706/ resolve that mitaka issue you were chasing the other night? | 19:39 |
| sdague | efried: ok, intentional, then I'm fine with it | 19:39 |
| *** jwcroppe_ has joined #openstack-nova | 19:39 | |
| efried | sdague This code only gets hit if the forward part of a Task Flow failed, and it's reverting. If one of the revert methods raises an exception, that's the exception that winds up getting raised overall, obscuring the original and bailing out of the remainder of the revert sequence. | 19:39 |
| sdague | efried: sure | 19:39 |
| sdague | I get catching the exception | 19:39 |
| efried | sdague I had a talk with harlowja about this "feature" a few weeks ago, and we brainstormed some ideas to make it a bit more friendly; but for the time being... | 19:40 |
| *** cristicalin has joined #openstack-nova | 19:40 | |
| sdague | but you still want to dump the stack trace, even though you are saying "we're ignoring this fail" | 19:40 |
| efried | sdague But yeah, I want to see the stack trace regardless, in case it points to something I want to fix. | 19:40 |
| sdague | ? | 19:40 |
| sdague | ok | 19:40 |
| sdague | +2 | 19:40 |
| efried | sdague Thanks! | 19:41 |
| *** nic1 has quit IRC | 19:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Changing deleting stale allocations warning to debug https://review.openstack.org/468519 | 19:42 |
| superdan | mriedem: heh, | 19:44 |
| superdan | mriedem: I just found and fixed a bug in the hypervisor-stats db query | 19:44 |
| superdan | rebased to submit, merge conflict | 19:45 |
| superdan | "that's impossible, this code hasn't changed in forever" | 19:45 |
| superdan | wah wah wah, fixed three days ago by Kevin_Zheng | 19:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Catch InstanceNotFound when deleting allocations https://review.openstack.org/468517 | 19:45 |
| mriedem | superdan: heh yup | 19:46 |
| mriedem | did that merge/ | 19:46 |
| mriedem | ? | 19:46 |
| superdan | apparently it did ;) | 19:46 |
| mriedem | oh it did | 19:46 |
| mriedem | https://review.openstack.org/#/c/467220/ | 19:46 |
| mriedem | nice | 19:46 |
| superdan | found it in kilo | 19:46 |
| mriedem | you can thank yours truly for the gratuitous commit message | 19:46 |
| superdan | was like "wow, still broken in master" | 19:46 |
| superdan | heh | 19:46 |
| mriedem | he taught me something on that one too, | 19:46 |
| mriedem | remember how we though deleting a service doesn't actually delete the compute node? | 19:47 |
| mriedem | turns out that's half true, | 19:47 |
| mriedem | it actually does if it's a super f'ing old compute node record | 19:47 |
| mriedem | i'm working on backports now | 19:47 |
| superdan | sweet | 19:48 |
| *** mnestratov has quit IRC | 19:48 | |
| cdent | mriedem: i tested the log thing because that was the only change in the commit, and not having a test seemed lame | 19:48 |
| mriedem | so you aren't weekending! | 19:49 |
| mriedem | cdent: yeah i'm not saying i haven't done it myself | 19:49 |
| mriedem | it's just, meh | 19:49 |
| cdent | I blame figleaf. He distracted me with interesting conversation | 19:49 |
| cdent | but soon I will eat carrots and drink wine and watch bad tv | 19:50 |
| mriedem | ooo carrots | 19:50 |
| mriedem | how english | 19:50 |
| figleaf | I blame it on having to return alternate hosts | 19:50 |
| *** mingyu has quit IRC | 19:50 | |
| figleaf | hey, we're growing carrots here! | 19:50 |
| cdent | we've planted some | 19:51 |
| cdent | but not ready yet | 19:51 |
| mriedem | i was into alternate hosts before it was cool to be into alternate hosts | 19:51 |
| sdague | oh, you know, we could add merged patches to the IRC bot here | 19:51 |
| * figleaf remembers that his ancestry is English | 19:51 | |
| mriedem | sdague: yeah we should do that | 19:51 |
| sdague | https://review.openstack.org/468527 | 19:51 |
| mriedem | i've liked patchbot in other channels | 19:51 |
| sdague | mriedem: gerritbot does it | 19:51 |
| cdent | alternate hosts is going to cause problems, I reckon | 19:51 |
| cdent | we'll see | 19:51 |
| sdague | just the nova channel doesn't have it turned on | 19:51 |
| sdague | we do in others | 19:51 |
| mriedem | yeah qa | 19:52 |
| mriedem | qa is bot city | 19:52 |
| *** crushil has quit IRC | 19:52 | |
| cdent | have a good weekend all | 19:52 |
| mriedem | +1 | 19:52 |
| *** cdent has quit IRC | 19:52 | |
| mriedem | o/ | 19:52 |
| sdague | enjoy | 19:52 |
| sdague | merged patches are nice to see things going in and feel like there is progress :) | 19:52 |
| *** salv-orlando has joined #openstack-nova | 19:53 | |
| efried | leakypipes Been digging into get_inventory; can I confirm a couple things with you real quick? | 19:55 |
| efried | leakypipes First thing, I'm noticing the old get_available_resource included not just "how much is there" but "how much has been used". The latter doesn't appear to have a place in get_inventory(). I _think_ I've gleaned that this is because the layers outside of the driver (resource tracker? scheduler?) calculate that for me by summing up allocations for existing instances, said allocations having been created when the | 19:58 |
| efried | instance was claimified. Have I got that right? | 19:58 |
| mriedem | sdague: progress is nice | 19:58 |
| mriedem | fun is fun | 19:58 |
| efried | leakypipes Second, on a similar note, I have a bunch of fields in get_available_resource that don't have standard ResourceClass affordance. I could create custom resource classes for those, but there doesn't seem much point if nothing is going to consume them. So do those just... disappear? | 20:02 |
| efried | leakypipes E.g. https://github.com/openstack/nova/blob/master/nova/virt/powervm/host.py#L55-L64 | 20:03 |
| *** lyan has quit IRC | 20:04 | |
| *** gouthamr has quit IRC | 20:05 | |
| mriedem | sdague: isn't this kind of a known thing? https://bugs.launchpad.net/nova/+bug/1691667 | 20:07 |
| openstack | Launchpad bug 1691667 in OpenStack Compute (nova) "The metadata 8775 port has no authentication" [Undecided,New] | 20:07 |
| mriedem | i don't really see it documented though | 20:07 |
| sdague | yeh | 20:08 |
| sdague | I thought there was host based authentication in there | 20:09 |
| sdague | like it actually cares about request ip address | 20:09 |
| sdague | but, that code is so old and wonky, idk | 20:09 |
| mriedem | i might be thinking of it coming up during the summit | 20:12 |
| mriedem | someone saying you can't use https | 20:12 |
| harlowja | leakypipes so u going to finally make https://github.com/jaypipes/enamel a thing -P | 20:14 |
| sdague | https://github.com/openstack/nova/blob/315ae692256939e6925db56c6ac833a237d46571/nova/api/metadata/handler.py#L130 | 20:14 |
| sdague | mriedem: we definitely validate against remote addr, or a proxy header equiv if you tell us to trust a proxy | 20:15 |
| sdague | if you tell us to trust the proxy then you better not let your instances go straight to the server as well, all requests should only come from the proxy | 20:15 |
| sdague | https://github.com/openstack/nova/blob/315ae692256939e6925db56c6ac833a237d46571/nova/api/metadata/handler.py#L131-L132 | 20:15 |
| mriedem | anyway ca'nt find that now | 20:16 |
| sdague | mriedem: it's not over https | 20:16 |
| sdague | but that's all limitations of the amazon implementation I thought | 20:16 |
| sdague | also no ipv6 for same reason | 20:16 |
| sdague | mriedem: I'll respond to the bug | 20:18 |
| sdague | ok, headed out. I'm mostly out next week. Including some camping | 20:28 |
| sdague | enjoy all | 20:28 |
| *** smatzek has quit IRC | 20:32 | |
| *** Swami has quit IRC | 20:34 | |
| openstackgerrit | Matt Wisch proposed openstack/nova master: Corrected compute_monitors setting help https://review.openstack.org/468538 | 20:35 |
| *** lyan has joined #openstack-nova | 20:38 | |
| *** thorst has quit IRC | 20:40 | |
| *** cristicalin has quit IRC | 20:43 | |
| mriedem | has it always been the case that if you specify a limit>what's left to page on after the marker we 404? https://bugs.launchpad.net/nova/+bug/1689692 | 20:45 |
| openstack | Launchpad bug 1689692 in OpenStack Compute (nova) "marker not found" [Undecided,New] | 20:45 |
| mriedem | that seems wrong | 20:45 |
| superdan | limit or marker? | 20:46 |
| superdan | marker makes sense to 404 | 20:46 |
| *** jmlowe has quit IRC | 20:49 | |
| *** lyan has quit IRC | 20:49 | |
| mriedem | the marker in this case exists | 20:51 |
| mriedem | looks like all instances are ERROR state which means they should be in cell0 | 20:51 |
| mriedem | they are sending a limit which is 1 more than how many they have left in the page | 20:52 |
| mriedem | superdan: i think i know | 20:55 |
| mriedem | yup | 20:55 |
| *** zz_dimtruck is now known as dimtruck | 20:55 | |
| mriedem | so they are all in cell0 | 20:55 |
| mriedem | we get the instances from cell0 here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2554 | 20:56 |
| mriedem | with limit=3, we got 2 back b/c that was the end of the page | 20:56 |
| mriedem | so we are left with limit 1 | 20:56 |
| mriedem | so we continue to page into the cells https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2569 | 20:56 |
| mriedem | and we're going to fail here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2676 | 20:57 |
| *** dimtruck is now known as zz_dimtruck | 20:57 | |
| mriedem | because the marker was in cell0 | 20:57 |
| *** vladikr has quit IRC | 20:57 | |
| mriedem | so the marker is never found in the other cells, but the limit said to keep checking | 20:57 |
| superdan | we don't clear the marker once we find it? | 20:57 |
| superdan | or maybe we do but not if we start on cell0? | 20:57 |
| mriedem | i don't think we do if we start on cell0 yeah | 20:58 |
| superdan | gotcha | 20:58 |
| *** thorst has joined #openstack-nova | 21:00 | |
| *** tbachman has quit IRC | 21:00 | |
| *** tbachman has joined #openstack-nova | 21:02 | |
| mriedem | writing a recreate functional test, should be simple | 21:02 |
| *** gouthamr has joined #openstack-nova | 21:03 | |
| *** thorst has quit IRC | 21:04 | |
| *** artom has joined #openstack-nova | 21:04 | |
| *** crushil has joined #openstack-nova | 21:06 | |
| *** masuberu has quit IRC | 21:07 | |
| *** tidwellr has quit IRC | 21:10 | |
| *** slaweq has quit IRC | 21:11 | |
| *** slaweq has joined #openstack-nova | 21:11 | |
| *** slaweq has quit IRC | 21:13 | |
| *** slaweq has joined #openstack-nova | 21:14 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | 21:15 |
| *** avolkov has quit IRC | 21:16 | |
| sdague | grrr, requirements conflict | 21:18 |
| sdague | rebased and reapproved | 21:19 |
| *** gyee has quit IRC | 21:19 | |
| mriedem | damn this goes back to newton | 21:21 |
| mriedem | functional regression test has got it recreated though | 21:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add recreate functional test for regression bug 1689692 https://review.openstack.org/468549 | 21:24 |
| openstack | bug 1689692 in OpenStack Compute (nova) "MarkerNotFound when limit>num(instances) and marker starts in cell0" [High,Triaged] https://launchpad.net/bugs/1689692 - Assigned to Matt Riedemann (mriedem) | 21:24 |
| mriedem | superdan: thar she blar ^ before you leave for 4 days | 21:24 |
| *** sdague has quit IRC | 21:25 | |
| *** lucasxu has quit IRC | 21:26 | |
| superdan | mriedem: you're going to work on a fix too presumably? | 21:27 |
| superdan | glad that was easy to repro, | 21:27 |
| mriedem | sgordon: heh look familiar? https://bugs.launchpad.net/openstack-manuals/+bug/1693633 | 21:27 |
| openstack | Launchpad bug 1693633 in openstack-manuals "Compute schedulers in Configuration Reference - AggregateImagePropertiesIsolation filter example" [Undecided,Incomplete] | 21:27 |
| superdan | but kinda uncool at the same ime | 21:27 |
| mriedem | superdan: yeah | 21:27 |
| mriedem | should be trivial | 21:27 |
| mriedem | marker = None | 21:27 |
| superdan | aye | 21:28 |
| *** kylek3h has quit IRC | 21:28 | |
| *** catintheroof has joined #openstack-nova | 21:33 | |
| *** catintheroof has quit IRC | 21:39 | |
| *** imacdonn has quit IRC | 21:40 | |
| mriedem | superdan: those hypervisor stats backports are up btw | 21:40 |
| *** imacdonn has joined #openstack-nova | 21:40 | |
| superdan | okay but as soon as the ups man shows up with my weekend toys, I'm outta here | 21:40 |
| mriedem | his truck broke down i heard | 21:41 |
| mriedem | i have to leave soon too | 21:41 |
| * superdan will hunt him down | 21:43 | |
| mriedem | crap of course there are failing compute api unit tests | 21:44 |
| *** slaweq has quit IRC | 21:44 | |
| *** annegentle has quit IRC | 21:44 | |
| *** slaweq has joined #openstack-nova | 21:45 | |
| *** mdrabe has quit IRC | 21:45 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | 21:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | 21:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174 | 21:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | 21:48 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | 21:48 |
| cburgess | superdan Toys? | 21:49 |
| mriedem | superdan: here it comes | 21:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix MarkerNotFound when paging and marker was found in cell0 https://review.openstack.org/468559 | 21:49 |
| *** slaweq has quit IRC | 21:49 | |
| figleaf | ...and with that, I'm off. Happy weekend, all! | 21:50 |
| openstackgerrit | Eric Fried proposed openstack/nova master: [WIP] PowerVM: get_inventory() https://review.openstack.org/468560 | 21:50 |
| *** figleaf is now known as edleafe | 21:50 | |
| efried | leakypipes ^^ Hopefully I'm on the right track here. | 21:51 |
| *** salv-orlando has quit IRC | 21:51 | |
| *** salv-orlando has joined #openstack-nova | 21:51 | |
| *** mriedem is now known as mriedem_afk | 21:54 | |
| *** salv-orlando has quit IRC | 21:55 | |
| *** rfolco has quit IRC | 22:02 | |
| *** rfolco has joined #openstack-nova | 22:03 | |
| *** rfolco has quit IRC | 22:03 | |
| *** clarkb has joined #openstack-nova | 22:05 | |
| clarkb | as a heads up the nova cells job seems to be failing a lot today | 22:05 |
| *** xyang1 has quit IRC | 22:12 | |
| sgordon | mriedem_afk, yupppp | 22:19 |
| *** vladikr has joined #openstack-nova | 22:28 | |
| *** acormier has quit IRC | 22:28 | |
| *** acormier has joined #openstack-nova | 22:29 | |
| *** acormier has quit IRC | 22:33 | |
| *** acormier has joined #openstack-nova | 22:34 | |
| *** acormier has quit IRC | 22:40 | |
| *** acormier has joined #openstack-nova | 22:41 | |
| *** acormier has quit IRC | 22:45 | |
| *** mingyu has joined #openstack-nova | 22:51 | |
| *** jmlowe has joined #openstack-nova | 22:52 | |
| *** mingyu has quit IRC | 22:56 | |
| *** crushil has quit IRC | 23:07 | |
| *** crushil has joined #openstack-nova | 23:08 | |
| *** yamahata has quit IRC | 23:18 | |
| *** hongbin has quit IRC | 23:21 | |
| *** salv-orlando has joined #openstack-nova | 23:22 | |
| *** salv-orlando has quit IRC | 23:27 | |
| *** david-lyle has joined #openstack-nova | 23:31 | |
| *** yamahata has joined #openstack-nova | 23:32 | |
| *** edleafe- has joined #openstack-nova | 23:33 | |
| *** edleafe has quit IRC | 23:35 | |
| *** arunman has joined #openstack-nova | 23:35 | |
| *** david-lyle has quit IRC | 23:36 | |
| *** vladikr has quit IRC | 23:40 | |
| *** arunman has quit IRC | 23:40 | |
| *** crushil has quit IRC | 23:49 | |
| *** sree has joined #openstack-nova | 23:50 | |
| *** mtanino__ has quit IRC | 23:52 | |
| *** sree has quit IRC | 23:55 | |
| *** leakypipes has quit IRC | 23:57 | |
| *** rfolco has joined #openstack-nova | 23:57 | |
| *** rfolco has quit IRC | 23:57 | |
| *** dtp has quit IRC | 23:58 | |
| *** yingjun has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!