Monday, 2017-05-22

*** jamielennox|away is now known as jamielennox00:02
*** markvoelker has quit IRC00:11
*** yingjun has joined #openstack-nova00:13
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc  https://review.openstack.org/45456500:19
*** thorst_afk has joined #openstack-nova00:19
openstackgerritTakashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases  https://review.openstack.org/39543600:20
*** winston-d_ has joined #openstack-nova00:20
*** mriedem has joined #openstack-nova00:22
*** mriedem has quit IRC00:22
*** thorst_afk has quit IRC00:24
*** liverpooler has joined #openstack-nova00:26
*** hongbin_ has joined #openstack-nova00:28
*** hongbin has quit IRC00:28
*** liverpooler has quit IRC00:31
*** Shunli has joined #openstack-nova00:33
*** trungnv has quit IRC00:43
*** fragatina has joined #openstack-nova00:44
*** fragatina has quit IRC00:44
*** fragatina has joined #openstack-nova00:45
*** ssurana has quit IRC00:45
openstackgerritShunli Zhou proposed openstack/nova master: Remove mox from unit/cells/test_cells_messaging.py  https://review.openstack.org/44802100:49
*** links has joined #openstack-nova00:54
*** adreznec has quit IRC00:59
*** adreznec has joined #openstack-nova01:01
*** phuongnh has joined #openstack-nova01:02
*** thorst_afk has joined #openstack-nova01:02
*** hongbin_ has quit IRC01:03
*** thorst_afk has quit IRC01:04
*** tovin07_ has joined #openstack-nova01:04
*** kaisers has joined #openstack-nova01:06
*** kaisers_ has quit IRC01:08
openstackgerritTakashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects  https://review.openstack.org/46620101:24
*** trungnv has joined #openstack-nova01:25
*** baoli has joined #openstack-nova01:30
*** cNilesh has joined #openstack-nova01:30
openstackgerritZhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed  https://review.openstack.org/45992301:41
openstackgerritShunli Zhou proposed openstack/nova master: Remove mox from cells/test_cells_rpc_driver.py  https://review.openstack.org/44741201:43
*** baoli has quit IRC01:46
*** armax has joined #openstack-nova01:47
*** Sukhdev has joined #openstack-nova01:47
*** fragatina has quit IRC01:48
*** yolkfull has joined #openstack-nova01:52
*** armax has quit IRC01:54
*** thorst_afk has joined #openstack-nova01:58
*** thorst_afk has quit IRC01:58
*** trungnv has quit IRC01:59
*** jamielennox is now known as jamielennox|away02:00
*** sofie_ has joined #openstack-nova02:01
*** gcb has joined #openstack-nova02:04
*** Kevin_Zheng has joined #openstack-nova02:07
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - List/Show all server migration types  https://review.openstack.org/43083902:09
*** johnhaan has joined #openstack-nova02:10
openstackgerritHuan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi v2 in nova  https://review.openstack.org/45349302:13
openstackgerritHuan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi v2 in nova  https://review.openstack.org/45349302:22
*** trungnv has joined #openstack-nova02:51
*** salv-orlando has joined #openstack-nova02:54
*** thorst_afk has joined #openstack-nova02:57
*** thorst_afk has quit IRC02:57
*** trungnv has quit IRC02:58
*** baoli has joined #openstack-nova03:00
*** jhesketh_ is now known as jhesketh03:08
*** trungnv has joined #openstack-nova03:08
*** hongbin has joined #openstack-nova03:23
*** psachin has joined #openstack-nova03:23
*** thorst_afk has joined #openstack-nova03:28
*** thorst_afk has quit IRC03:46
*** baoli has quit IRC03:48
*** jamielennox|away is now known as jamielennox03:53
*** xinliang has quit IRC03:54
*** xinliang has joined #openstack-nova03:55
*** xinliang has quit IRC03:55
*** xinliang has joined #openstack-nova03:55
*** salv-orlando has quit IRC03:58
*** guchihiro has joined #openstack-nova04:07
*** yamamoto has quit IRC04:12
*** adisky_ has joined #openstack-nova04:21
*** trinaths has joined #openstack-nova04:28
*** johnhaan has quit IRC04:28
*** gianpietro has joined #openstack-nova04:37
*** vks1 has joined #openstack-nova04:42
*** udesale has joined #openstack-nova04:47
*** jaosorior has joined #openstack-nova04:52
*** yamamoto has joined #openstack-nova04:56
*** sree has joined #openstack-nova04:56
*** mdnadeem has joined #openstack-nova04:59
*** hongbin_ has joined #openstack-nova05:13
*** hongbin has quit IRC05:14
*** hongbin_ has quit IRC05:17
*** salv-orlando has joined #openstack-nova05:17
*** sridharg has joined #openstack-nova05:20
*** prateek has joined #openstack-nova05:27
*** nmathew has joined #openstack-nova05:28
*** ratailor has joined #openstack-nova05:34
openstackgerritJohn Haan proposed openstack/nova-specs master: Support volume_type with BDM paramter  https://review.openstack.org/46659505:38
*** thorst_afk has joined #openstack-nova05:43
openstackgerritjichenjc proposed openstack/nova master: Deprecate unused policy from policy doc  https://review.openstack.org/46659605:47
*** thorst_afk has quit IRC05:48
*** mamandle has joined #openstack-nova05:50
*** yingjun has quit IRC05:54
*** mamandle has quit IRC05:55
*** sofie_ has quit IRC05:55
openstackgerritjichenjc proposed openstack/nova master: Deprecate unused policy from policy doc  https://review.openstack.org/46550505:55
*** salv-orlando has quit IRC06:04
*** ltomasbo|away is now known as ltomasbo06:06
*** belmoreira has joined #openstack-nova06:07
*** salv-orlando has joined #openstack-nova06:07
*** gyee has joined #openstack-nova06:08
*** Oku_OS-away is now known as Oku_OS06:11
openstackgerritJohn Haan proposed openstack/nova-specs master: Support volume_type with BDM paramter  https://review.openstack.org/46659506:17
*** bhagyashris has quit IRC06:18
*** rcernin has joined #openstack-nova06:19
*** markus_z has joined #openstack-nova06:21
*** litao__ has joined #openstack-nova06:23
*** guchihiro has quit IRC06:25
*** takashin has left #openstack-nova06:30
*** gyee has quit IRC06:31
*** abhishek_k has joined #openstack-nova06:36
*** abhishek_k has quit IRC06:40
*** andreas_s has joined #openstack-nova06:41
*** thorst_afk has joined #openstack-nova06:44
*** thorst_afk has quit IRC06:49
*** fragatina has joined #openstack-nova06:55
*** wxy has joined #openstack-nova06:55
*** salv-orlando has quit IRC07:01
*** salv-orlando has joined #openstack-nova07:03
openstackgerritBéla Vancsics proposed openstack/nova master: Use more specific asserts in tests  https://review.openstack.org/46660907:03
*** salv-orlando has quit IRC07:08
*** pcaruana has joined #openstack-nova07:11
*** zsli_ has joined #openstack-nova07:12
*** pcaruana has quit IRC07:12
*** ayogi has joined #openstack-nova07:12
*** pcaruana has joined #openstack-nova07:13
*** rcernin has quit IRC07:14
*** rcernin has joined #openstack-nova07:14
*** Shunli has quit IRC07:15
*** mlakat has joined #openstack-nova07:23
*** bnemec has quit IRC07:29
*** gianpietro has quit IRC07:34
*** bnemec has joined #openstack-nova07:35
*** david-lyle has quit IRC07:36
*** hoonetorg has quit IRC07:39
*** david-lyle has joined #openstack-nova07:42
*** thorst_afk has joined #openstack-nova07:45
*** jpena|off is now known as jpena07:46
*** david-lyle has quit IRC07:46
*** fragatina has quit IRC07:47
*** thorst_afk has quit IRC07:50
*** Sukhdev has quit IRC07:50
openstackgerritBéla Vancsics proposed openstack/nova master: Transform instance.live_migration_rollback notification  https://review.openstack.org/40212407:50
*** fragatina has joined #openstack-nova07:50
*** _dpawlik is now known as danpawlik07:50
*** gouthamr has joined #openstack-nova07:51
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46662107:52
*** hoonetorg has joined #openstack-nova07:53
*** ralonsoh has joined #openstack-nova07:55
*** trungnv has quit IRC07:56
*** zzzeek has quit IRC08:00
*** hferenc has quit IRC08:00
*** zzzeek has joined #openstack-nova08:01
*** trungnv has joined #openstack-nova08:02
*** david-lyle has joined #openstack-nova08:03
*** fragatina has quit IRC08:06
*** hferenc has joined #openstack-nova08:06
openstackgerritShunli Zhou proposed openstack/nova master: Transform servergroup.create notification  https://review.openstack.org/45402308:14
*** lucas-afk is now known as lucasagomes08:15
*** ralonsoh has quit IRC08:15
openstackgerritDaniel Pawlik proposed openstack/nova master: Add hide hypervisor id on guest host  https://review.openstack.org/45975308:17
*** gouthamr has quit IRC08:19
*** ralonsoh has joined #openstack-nova08:19
*** cdent has joined #openstack-nova08:19
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045508:23
*** avolkov has joined #openstack-nova08:25
*** lpetrut has joined #openstack-nova08:31
*** derekh has joined #openstack-nova08:34
*** karimb has joined #openstack-nova08:44
*** gszasz has joined #openstack-nova08:44
*** thorst_afk has joined #openstack-nova08:46
*** zsli__ has joined #openstack-nova08:46
*** zsli_ has quit IRC08:49
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46663709:01
*** thorst_afk has quit IRC09:05
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for server-tags instead of stevedore  https://review.openstack.org/46164509:23
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore  https://review.openstack.org/45997909:23
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore  https://review.openstack.org/46164609:23
*** sree_ has joined #openstack-nova09:27
*** sree_ is now known as Guest209009:27
*** fragatina has joined #openstack-nova09:29
*** sree has quit IRC09:30
*** sree has joined #openstack-nova09:30
*** mnestratov has joined #openstack-nova09:30
*** Guest2090 has quit IRC09:31
*** bhagyashris has joined #openstack-nova09:33
*** mvk has quit IRC09:36
*** zsli__ has quit IRC09:38
openstackgerritHuan Xie proposed openstack/nova master: XenAPI use os-xenapi v2 in nova  https://review.openstack.org/45349309:45
openstackgerritBéla Vancsics proposed openstack/nova master: Remove reimported  https://review.openstack.org/46665809:48
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for server-tags instead of stevedore  https://review.openstack.org/46164509:49
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore  https://review.openstack.org/45997909:49
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore  https://review.openstack.org/46081309:49
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore  https://review.openstack.org/46164609:49
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for os-quota-sets endpoint instead of stevedore  https://review.openstack.org/46163009:49
openstackgerritAlex Xu proposed openstack/nova master: Use plain routes list for os-migrations endpoint instead of stevedore  https://review.openstack.org/46162809:49
*** sambetts_ is now known as sambetts09:51
*** cNilesh has quit IRC09:53
*** tovin07_ has quit IRC09:55
*** tbachman has joined #openstack-nova09:57
*** fragatina has quit IRC10:00
*** thorst_afk has joined #openstack-nova10:02
*** mvk has joined #openstack-nova10:06
*** thorst_afk has quit IRC10:07
*** tuanluong has joined #openstack-nova10:15
openstackgerritLee Yarwood proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended  https://review.openstack.org/38979810:16
*** mpaolino has joined #openstack-nova10:21
openstackgerritjichenjc proposed openstack/nova master: Use plain routes list for os-quota-classes endpoint instead of stevedore  https://review.openstack.org/46164110:21
openstackgerritjichenjc proposed openstack/nova master: Deprecate unused policy from policy doc  https://review.openstack.org/46550510:23
*** sdague has joined #openstack-nova10:31
*** fragatina has joined #openstack-nova10:39
*** Shunli has joined #openstack-nova10:48
*** Shunli has quit IRC10:49
*** lucasagomes is now known as lucas-hungry10:57
*** yolkfull has quit IRC10:58
*** Guest87461 has quit IRC10:58
*** smatzek has joined #openstack-nova11:01
*** sree has quit IRC11:01
*** sree has joined #openstack-nova11:02
*** tuanluong has quit IRC11:04
*** sree has quit IRC11:06
*** sree has joined #openstack-nova11:08
*** ayogi has quit IRC11:09
*** sree has quit IRC11:13
*** yassine has joined #openstack-nova11:16
*** yassine is now known as Guest498811:16
*** phuongnh has quit IRC11:16
openstackgerritZhenyu Zheng proposed openstack/nova master: Should not allow security group from other project pass API layer check when booting  https://review.openstack.org/46616011:17
*** thorst_afk has joined #openstack-nova11:18
*** gcb has quit IRC11:19
danpawlikMorning. Does someone know, how to recheck only one CI like: Citrix XenServer CI (https://review.openstack.org/#/c/459753/) ? I don't want to make recheck. Thanks11:21
*** fragatina has quit IRC11:22
*** lennyb_ has quit IRC11:24
*** lennyb has quit IRC11:24
*** lennyb has joined #openstack-nova11:25
openstackgerritBéla Vancsics proposed openstack/nova master: Use more specific asserts in tests  https://review.openstack.org/46660911:26
*** lennyb has quit IRC11:27
*** lennyb has joined #openstack-nova11:28
*** lennyb_ has joined #openstack-nova11:29
*** lennyb has quit IRC11:29
*** lennyb_ has quit IRC11:29
*** lennyb has joined #openstack-nova11:30
*** dave-mccowan has joined #openstack-nova11:30
*** RuiChen has joined #openstack-nova11:31
*** RuiChen has left #openstack-nova11:31
*** karimb has quit IRC11:32
*** nmathew has quit IRC11:34
*** udesale has quit IRC11:36
danpawlikkashyap, mriedem: Hi. Can you review https://review.openstack.org/#/c/459753/ in free time ? Please :)11:37
kashyapdanpawlik: Will look in a bit; in the middle of something11:38
*** ratailor has quit IRC11:44
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot  https://review.openstack.org/44925711:44
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request  https://review.openstack.org/45177711:44
*** vks1 has quit IRC11:47
*** litao__ has quit IRC11:58
openstackgerritsahid proposed openstack/nova master: libvirt: configure trust mode for vfs  https://review.openstack.org/45851411:59
openstackgerritsahid proposed openstack/nova master: network: update pci request spec to handle trusted tags  https://review.openstack.org/45882011:59
openstackgerritsahid proposed openstack/nova master: network: add command to configure trusted mode for VFs  https://review.openstack.org/45851311:59
openstackgerritsahid proposed openstack/nova master: libvirt: update the active migrations DS to support migration result  https://review.openstack.org/40926012:02
openstackgerritsahid proposed openstack/nova master: libvirt: ensure live-migration success  https://review.openstack.org/40926112:02
*** vladikr has joined #openstack-nova12:04
*** mvk has quit IRC12:07
*** lucas-hungry is now known as lucasagomes12:07
*** edmondsw has joined #openstack-nova12:15
*** edmondsw has quit IRC12:16
*** rfolco has joined #openstack-nova12:16
*** gianpietro has joined #openstack-nova12:16
*** jaypipes has joined #openstack-nova12:18
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Update noVNC URL  https://review.openstack.org/46671012:18
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Update noVNC URL  https://review.openstack.org/46671012:19
*** vladikr has quit IRC12:20
jaypipessdague, mdbooth, sfinucan: anyone remember a bug that was fixed in Nova (or elsewhere?) about predictable network interface names in guests?12:21
cdentjaypipes: I very vaguely remember reading something about that, but not enough to do any real searching :(12:22
mdboothjaypipes: Not specifically. Did it involve assuming network interface names started with 'eth'?12:23
jaypipesmdbooth: ya.12:23
jaypipesmdbooth: googling for "persistent (or predictable) interface names nova openstack" yields nothing useful..12:23
mdboothjaypipes: Any idea what code it would have touched?12:24
jaypipesmdbooth: not sure... maybe the libvirt XML configurator code?12:25
jaypipesmdbooth: or alternately maybe something around the network metadata stuff?12:26
mdboothjaypipes: commit 577174b025af9513aaba572d6965f9b0e0d1b3c1 maybe ?12:27
*** vladikr has joined #openstack-nova12:28
mdboothThat looks like it might result in binding by mac address rather than name12:30
* mdbooth hasn't looked closely, though12:30
mdboothThat looks very debian-specific. I wonder what that is...12:30
*** mvk has joined #openstack-nova12:32
jaypipesmdbooth: yeah, doesn't look like it..12:32
*** jwcroppe has quit IRC12:33
*** jwcroppe has joined #openstack-nova12:33
*** jpena is now known as jpena|lunch12:34
mdboothjaypipes: Got a bug you're trying to fix, btw?12:34
sdaguejaypipes: I thought that was the whole vif device tags push12:35
jaypipesmdbooth: nah, someone internally at Mirantis is complaining about it and I vaguely remembered it coming up about a year ago and was looking for more info.12:35
*** mdrabe has joined #openstack-nova12:35
jaypipessdague: nah, that was more to identify physical networks that a vif was associated with, IIRC>12:36
jaypipesartom: ^^ is my memory correct on that?12:36
*** dikonoor has joined #openstack-nova12:36
*** jwcroppe has quit IRC12:37
sfinucanjaypipes: Nothing off the top of my head, I'm afraid12:39
*** vks1 has joined #openstack-nova12:39
*** yamahata has quit IRC12:40
*** catintheroof has joined #openstack-nova12:41
sdaguejaypipes: it's not really a solvable problem, device naming inside a guest is determined by the guest os, and different linux distros do it differently with hotplug rules12:41
sdagueyou definitely need guest assist there12:42
efriedsdague https://review.openstack.org/#/c/419662/ you said, "The tests that are running on top of this are failing on these jobs, because the tempest timeout is too low (300s), so the sleep 600 is triggering a fail. We need that to be handled."12:47
efriedsdague Is that still an issue?  I'm not seeing where that's happening.12:47
sdagueefried: I don't know, it's a pretty old comment on an old set of test failures12:49
efriedsdague Okay, wasn't sure if the failure was posted in the CI results on this change set, or... somewhere else.12:50
*** trinaths has quit IRC12:55
*** karimb has joined #openstack-nova12:56
*** jwcroppe has joined #openstack-nova12:58
*** esberglu has joined #openstack-nova13:01
*** jheroux has joined #openstack-nova13:01
*** salv-orlando has joined #openstack-nova13:01
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045513:02
openstackgerritSylvain Bauza proposed openstack/nova master: Fix ChanceScheduler returning a wrong node  https://review.openstack.org/46672513:02
*** READ10 has joined #openstack-nova13:03
*** esberglu has quit IRC13:03
*** udesale has joined #openstack-nova13:05
*** esberglu has joined #openstack-nova13:05
*** esberglu_ has joined #openstack-nova13:06
*** salv-orlando has quit IRC13:07
*** salv-orlando has joined #openstack-nova13:07
*** esberglu has quit IRC13:09
*** zul has joined #openstack-nova13:11
*** lyan has joined #openstack-nova13:12
*** mriedem has joined #openstack-nova13:14
jaypipesalex_xu, avolkov: answered your queries on https://review.openstack.org/#/c/461574/913:17
*** liverpooler has joined #openstack-nova13:19
*** salv-orlando has quit IRC13:21
*** gianpietro has quit IRC13:21
*** markvoelker has joined #openstack-nova13:22
openstackgerritJay Pipes proposed openstack/nova master: placement: shared resources when finding providers  https://review.openstack.org/46157413:23
jaypipesdansmith: addressed your comments ^13:23
*** trinaths has joined #openstack-nova13:24
*** trinaths has left #openstack-nova13:24
openstackgerritJay Pipes proposed openstack/nova master: placement: tests for non-shared with shared  https://review.openstack.org/46189913:25
openstackgerritJay Pipes proposed openstack/nova master: placement: test for agg association not sharing  https://review.openstack.org/46190113:25
openstackgerritJay Pipes proposed openstack/nova master: placement: test non-shared out of inventory  https://review.openstack.org/46190013:25
openstackgerritJay Pipes proposed openstack/nova master: placement: shared resources when finding providers  https://review.openstack.org/46157413:25
openstackgerritJay Pipes proposed openstack/nova master: placement: tests for non-shared with shared  https://review.openstack.org/46189913:27
openstackgerritJay Pipes proposed openstack/nova master: placement: test for agg association not sharing  https://review.openstack.org/46190113:27
openstackgerritJay Pipes proposed openstack/nova master: placement: test non-shared out of inventory  https://review.openstack.org/46190013:27
openstackgerritJay Pipes proposed openstack/nova master: placement: shared resources when finding providers  https://review.openstack.org/46157413:27
*** xyang1 has joined #openstack-nova13:27
*** gcb has joined #openstack-nova13:28
bauzascdent: question, how can we know if allocating an instance was wrong ?13:29
cdentbauzas: what do you mean by wrong?13:29
bauzascdent: I need to know whether the allocation was accepted, ie. 20413:29
bauzascdent: calling _put_allocations() returns a bool about that13:30
*** kylek3h has quit IRC13:30
bauzascdent: so that means that if some allocation is not accepted by the scheduler, then _put_allocations would return False, right?13:30
cdentyes13:31
*** jpena|lunch is now known as jpena13:31
bauzasokay13:32
openstackgerritJay Pipes proposed openstack/nova master: add cache which keeps DB and os_traits in sync  https://review.openstack.org/46276913:32
efrieddansmith (or whoever) - is there a concept of `nova-manage cell_v2 discover_hosts` failing?  In a way that it would exit nonzero to the shell?13:33
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045513:34
dansmithefried: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L144313:34
dansmithefried: only if an exception gets raised13:34
*** prateek has quit IRC13:34
*** gianpietro has joined #openstack-nova13:34
efrieddansmith - esberglu_ is seeing failures in our CI (host not mapped to any cell) that one would normally see if above was not run, but console log shows it running (and not failing)13:34
avolkovjaypipes: thanks for explanation13:34
*** smatzek has quit IRC13:34
efrieddansmith Thanks, I'll look through that.13:34
*** baoli has joined #openstack-nova13:34
dansmithefried: running with --verbose and seeing it actually discover the host you expect?13:34
efrieddansmith Okay, will try.  esberglu_ ^^ can you stuff that into the script?13:35
*** markvoelker has quit IRC13:35
esberglu_efried: I'm running through it manually on a test instance right now13:35
esberglu_I will add verbose13:35
*** markvoelker has joined #openstack-nova13:35
efriedesberglu_ Cool beans.  Thought you said you couldn't reproduce when running manually, though.  (dansmith FYI, esberglu_ suspected timing - running discover_hosts too soon after services were started)13:36
dansmithefried: yep, definitely possible13:36
efrieddansmith Okay.  Possible to patch such that it will fail if it doesn't discover anything?  Possibly at the behest of a --strict flag?  (Sorry if that's a naïf question; I don't have the background to understand whether that can really be considered a "failure" per se.)13:38
*** gianpietro has quit IRC13:38
efried(and other borrowed words from Latin languages)13:38
dansmithefried: I would think that you should exit nonzero if it _did_ discover something, and then scripts can "run-until-success"13:38
*** MVenesio has joined #openstack-nova13:38
efrieddansmith Sorry, making sure we're talking about the same thing: shell command exits zero on *success*, nonzero on *failure*, yes?  So ^^ implies that discovering something is failure??13:40
*** dimtruck is now known as zz_dimtruck13:40
*** zz_dimtruck is now known as dimtruck13:40
dansmithwell, it's also often used to mean "I did something out of the ordinary" or "I took action"13:40
dansmithall you hosts should be discovered all the time, so if it found one that isn't, it's out of the ordinary13:40
dansmithI mean you could argue that discovering a host is what you intended to do when you ran it, and so not discovering anything is the error,13:41
efrieddansmith Right, that's how it feels to me.13:41
dansmithbut I think the way people will use it will be "run until it reports success"13:41
efrieddansmith I can buy it, but if that's the case, I feel like it should be called out as such in the doc.13:42
efriedesberglu_ ^^ So as currently coded, sounds like you want to do something like:13:42
dansmithit needs to be called out in either case, like the update_cell docstring13:42
efriedesberglu_ while ! nova-manage cell_v2 discover_hosts; do sleep 1; done13:42
dansmithefried: no, not as currently coded.. it always returns zero unless something actually explodes13:43
efrieddansmith Oh, okay.13:43
dansmithefried: but you can do that, document it, and backport it to ocata if you want :)13:43
efrieddansmith Roger that.  esberglu_ ^^ may be a good way to get you into nova contribution ;-)13:44
*** udesale has quit IRC13:46
efrieddansmith On first read of the update_cell doc, it sounds like the paradigm is "exit zero if it works, nonzero if something goes wrong" - so I would expect discover_hosts to be similar.  Did I read it right?13:47
esberglu_dansmith: efried: Sure. I will take a look after I get this CI issue sorted out13:47
dansmithefried: they're entirely different commands though13:47
dansmithefried: it's not a failure to run discover_hosts and not find anything13:48
dansmithit _is_ a failure to update_cell and not ... update the cell13:48
efrieddansmith A new user may have a hard time understanding that.  I say "discover" and nothing is discovered - seems like a failure.13:48
efried(Speaking as a new user myself ;-)13:48
dansmithefried: right now people are running discover_hosts and always seeing zero exit, so which do you think will be less disruptive to those people13:48
dansmithefried: but discover_hosts is something you can (and some people do) run in cron13:49
*** felipemonteiro has joined #openstack-nova13:49
dansmithit's idempotent13:49
dansmithso, would you like an email from cron every time it runs and doesn't find anything, or every time it does? :)13:49
bauzasdansmith: mriedem: jaypipes: cdent: edleafe: I'll need to take some PTOs by this week, so I won't be around for Wed-Frid13:49
efrieddansmith Or a --strict flag13:49
*** dimtruck is now known as zz_dimtruck13:49
jaypipesbauzas: k, thanks for the heads up.13:50
dansmithefried: sure, or that13:50
bauzasdansmith: mriedem: jaypipes: cdent: edleafe: the series is in a good pace, you can review it13:50
jaypipesbauzas: can you give edleafe permission to take over any patches you have in progress please?13:50
dansmithjaypipes: +113:50
jaypipesbauzas: I want to keep progress going.13:50
bauzasas I said earlier, I'm fine with anyone working on my changes if we're not duplicating work13:50
jaypipesbauzas: cool, thank you sir.13:50
*** felipemonteiro_ has joined #openstack-nova13:51
bauzasanyway, I'm still around for 24h13:51
dansmithefried: --strict means we keep existing behavior without that being passed to avoid breaking anyone current right?13:51
dansmiththat's probably the best, in which case I'm good with not finding anything is an "error"13:51
*** sridharg has quit IRC13:52
efrieddansmith Right.  Adding --strict would mean, "any result that isn't 'I discovered a host' is a failure."13:52
dansmithyep13:52
*** catinthe_ has joined #openstack-nova13:53
efrieddansmith For current impl, is there a command I can use to ask whether this host has been discovered (registered with a cell)?13:53
*** catinth__ has joined #openstack-nova13:53
dansmithefried: no, such a command would be welcome too I think13:54
*** catintheroof has quit IRC13:54
dansmithefried: also I think you can backport the --strict patch13:54
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508113:54
efrieddansmith To ocata?13:54
dansmithefried: aye13:54
efriedCause none of this was implemented in newton?13:54
efried(or at least not required)13:54
dansmithnot required yeah13:54
efrieddig13:54
*** felipemonteiro has quit IRC13:54
dansmithefried: just MHO but we did similar things before to make the transition easier before people got there, so I think it's legit13:55
dansmiththat way esberglu_ gets the full gamut of nova dev interaction :)13:55
efriedTrial by fire13:56
*** kylek3h has joined #openstack-nova13:56
efrieddansmith So `nova-manage cell_v2 list_cells [--verbose]` doesn't show which hosts are in which cells?13:57
*** links has quit IRC13:57
*** catinthe_ has quit IRC13:57
efriednope13:57
dansmithefried: I think it does, but it won't return pass/fail for a single host.. but you can use grep and get that I think13:57
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request  https://review.openstack.org/45177713:58
dansmithoh wait,13:58
dansmithnot after my faster-er patch13:58
openstackgerritGábor Antal proposed openstack/nova master: Transform instance.resize_prep notification  https://review.openstack.org/46508113:58
dansmithbut in ocata you can I think13:58
*** crushil has joined #openstack-nova13:58
*** mmedvede has quit IRC13:58
dansmithin master now, it is able to efficiently determine which hosts are unmapped13:58
dansmithin ocata it couldn't, which means it had to get them all13:58
*** smatzek has joined #openstack-nova13:58
*** awaugama has joined #openstack-nova13:59
efrieddansmith Would list_cells be an appropriate place to put the "include mapped hosts" behavior?  Potentially via a new flag?13:59
mriedemis it odd that migration.status goes from accepted -> pre-migrating -> done | failed; with no 'evacuating' or middle state?14:00
mriedemfor evacuate i mean14:00
efrieddansmith Versus a whole new command, like `nova-manage cell_v2 host_mapping`14:00
*** diga has joined #openstack-nova14:00
*** mmedvede has joined #openstack-nova14:01
dansmithefried: I think a command of "is host $hostname mapped" that returns a boolean is likely to be useful for scripting deployments14:02
dansmithlist_cells shouldn't return hosts, IMHO14:02
*** smatzek_ has joined #openstack-nova14:02
efrieddansmith okay.14:02
dansmithbut a list-hosts-in-cell command is probably also useful14:02
*** sree has joined #openstack-nova14:02
*** salv-orlando has joined #openstack-nova14:03
esberglu_efried: dansmith: Just getting caught back up. Sounds like the two takeaways are that we want to add14:04
esberglu_- A --strict flag to the discover_hosts command (and backport to ocata)14:04
esberglu_- A new command to check if a host is mapped14:04
esberglu_- A new command to list hosts in a cell14:05
esberglu_(3 takeaways)14:05
efriedesberglu_ Probably not #314:05
*** smatzek has quit IRC14:06
openstackgerritJay Pipes proposed openstack/nova master: placement: test for agg association not sharing  https://review.openstack.org/46190114:06
openstackgerritJay Pipes proposed openstack/nova master: placement: test non-shared out of inventory  https://review.openstack.org/46190014:06
dansmith#3 seems useful to me too, but that's the order of importance, yeah14:06
*** sree has quit IRC14:06
esberglu_K I'm on the hook for that. I'll be back with questions I'm sure14:07
*** salv-orlando has quit IRC14:08
*** zz_dimtruck is now known as dimtruck14:09
*** adisky_ has quit IRC14:11
*** eharney has joined #openstack-nova14:14
*** gianpietro has joined #openstack-nova14:18
*** dikonoor has quit IRC14:25
*** hongbin has joined #openstack-nova14:28
*** edmondsw has joined #openstack-nova14:29
*** markvoelker_ has joined #openstack-nova14:29
openstackgerritsahid proposed openstack/nova master: libvirt: update the logic to configure volume with scsi controller  https://review.openstack.org/45974114:32
openstackgerritsahid proposed openstack/nova master: libvirt: update logic to configure device for scsi controller  https://review.openstack.org/45974014:32
openstackgerritsahid proposed openstack/nova master: libvirt: update LibvirtConfigGuestDeviceAddress to provide XML  https://review.openstack.org/45973714:32
openstackgerritsahid proposed openstack/nova master: libvirt: rearange how scsi controller is defined  https://review.openstack.org/45973914:32
openstackgerritsahid proposed openstack/nova master: libvirt: set full description of the controller used by disk  https://review.openstack.org/45973814:32
*** markvoelker has quit IRC14:33
*** david-lyle has quit IRC14:34
*** david-lyle has joined #openstack-nova14:35
mriedemhttps://review.openstack.org/#/c/430608/ worries me a bit - it's defining what "in progress" means for various types of migrations which is going to impact how the API works14:37
mriedemi.e. post-copy is not considered in-progress,14:37
mriedemand there is no 'evacuating' status while we're actually performing the evacuate14:37
mriedemseems like this could be a mess to manage in the future, since we're exposing an internal state machine out of the api14:38
*** psachin has quit IRC14:38
*** gjayavelu has joined #openstack-nova14:39
openstackgerritDan Smith proposed openstack/nova master: De-complicate some of the instance delete path  https://review.openstack.org/45863614:39
openstackgerritDan Smith proposed openstack/nova master: Move to proper target_cell calling convention  https://review.openstack.org/45863414:39
openstackgerritDan Smith proposed openstack/nova master: Make target_cell() yield a new context  https://review.openstack.org/45863514:39
openstackgerritDan Smith proposed openstack/nova master: Fix live migration devstack hook for multicell environment  https://review.openstack.org/45853714:39
openstackgerritDan Smith proposed openstack/nova master: Target cell on local delete  https://review.openstack.org/46405914:40
*** armax has joined #openstack-nova14:41
*** crushil has quit IRC14:42
*** smatzek_ is now known as smatzek14:42
*** mtanino has joined #openstack-nova14:46
*** yamahata has joined #openstack-nova14:51
*** david-lyle has quit IRC14:52
danpawlikmriedem: : Hi. Can you review https://review.openstack.org/#/c/459753/ when you have some free time? Thanks14:52
*** salv-orlando has joined #openstack-nova14:52
*** dillaman has quit IRC14:52
mriedemcdent: alex_xu: wondering about your opinions on 400 vs 409 here https://review.openstack.org/#/c/459483/5/nova/api/openstack/compute/server_migrations.py@8914:55
*** gjayavelu has quit IRC14:55
mriedemit might not matter since we're never very consistent on those14:55
*** crushil has joined #openstack-nova14:55
*** lucasxu has joined #openstack-nova14:56
*** salv-orlando has quit IRC14:57
*** mvk_ has joined #openstack-nova14:57
*** andreas_s has quit IRC14:59
*** fragatina has joined #openstack-nova15:00
*** dillaman has joined #openstack-nova15:05
*** andreas_s has joined #openstack-nova15:08
*** armax has quit IRC15:10
*** Oku_OS is now known as Oku_OS-away15:18
mriedemsfinucan: replied in https://review.openstack.org/#/c/464088/15:18
mriedemsfinucan: i think we can assume the db name doesn't have / in it15:18
* sfinucan looking15:18
mriedemsfinucan: and / is the url separator15:18
*** vks1 has quit IRC15:18
sfinucanmriedem: Then we're good15:18
mriedemi'd rather not over-complicate this until someone shows up with a case that breaks this15:18
sfinucanI was just making sure - I've been caught rotten with rstrip before15:19
mriedemok15:19
melwittdansmith, jaypipes, johnthetubaguy, mriedem: just a heads up that the quotas set is ready to look at again15:19
jaypipesmelwitt: awesome. will review after bauzas/edleafe claims series.15:19
mriedemmelwitt: then i shall review now15:20
melwittcool, thanks :)15:20
*** yamahata has quit IRC15:22
*** mlavalle has joined #openstack-nova15:25
*** trungnv has quit IRC15:30
*** sree has joined #openstack-nova15:33
*** burt has joined #openstack-nova15:34
*** markvoelker_ has quit IRC15:35
*** lpetrut has quit IRC15:35
*** nicolasbock has joined #openstack-nova15:36
*** salv-orlando has joined #openstack-nova15:36
*** nicolasbock has quit IRC15:36
*** nicolasbock has joined #openstack-nova15:37
*** mdnadeem has quit IRC15:38
*** sree has quit IRC15:38
*** sree has joined #openstack-nova15:39
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove dead code  https://review.openstack.org/46066215:39
*** gyee has joined #openstack-nova15:42
*** sree has quit IRC15:43
*** belmoreira has quit IRC15:45
*** READ10 has quit IRC15:46
openstackgerritmelanie witt proposed openstack/nova master: convert unicode to string before we connect to rados  https://review.openstack.org/46540415:46
*** andreas_s has quit IRC15:50
*** nic has joined #openstack-nova15:51
bauzasjaypipes: thanks for commenting my series, good points there15:54
bauzasjaypipes: just rev'ing15:54
bauzasjaypipes: I think we agreed on having the conductor doing the allocations, right?15:57
jaypipesbauzas: I don't remember such an agreement, no.15:57
bauzasjaypipes: and scheduler passing a list of alternatives to the conductor for that, as per dan's session15:57
bauzasbecause of the rescheduling issue15:57
mriedemmelwitt: random questions https://review.openstack.org/#/c/446239/7/nova/compute/api.py@516715:57
dansmithjaypipes: wat. really?15:57
jaypipesbauzas: there are no rescheduling issues if we do the claims in the scheduler.15:57
jaypipesdansmith: yes.15:58
dansmithjaypipes: we totally said we were doing them in the conductor in boston :)15:58
bauzasjaypipes: I explained why the scheduler sould be a wrong possibilty in some email15:58
bauzaslemme find it15:58
jaypipesdansmith, bauzas: reschedule issues go away if we do the claims in the scheduler.15:58
*** lbragstad has joined #openstack-nova15:58
dansmithjaypipes: eh?15:59
bauzasjaypipes: http://lists.openstack.org/pipermail/openstack-dev/2017-May/117039.html15:59
*** pcaruana has quit IRC15:59
dansmithjaypipes: if we do it in the scheduler, then we end up with scheduler claiming first, then conductor claiming on reschedules15:59
dansmithjaypipes: which I don't like15:59
bauzas"There are multiple reasons why we chose to use conductor for that :"15:59
jaypipesdansmith: you remember when I told operators that "95% or more of the reasons for retries go away when the scheduler does claims"?15:59
jaypipesdansmith: there is no reason to do reschedules at all if we do claims in the scheduler.15:59
dansmithjaypipes: sure, but we're talking about claiming during the scheduling phase15:59
dansmithI can't believe we're having this conversation again :)16:00
mriedemthe problem is no one is defining what 'reschedule' means here16:00
jaypipesdansmith: I thought you were cool with getting rid of retries entirely?16:00
dansmithlol16:00
mriedemi think what jaypipes is talking about is calling select_destinations again16:00
bauzasthat's at least a bit unfortunate I spent my week on something I thought we had a consensus :)16:00
bauzaswithout doing any reviews (sorry folks!)16:00
mriedemi think dansmith is talking about deleting failed allocations and looping to the next host in our list, which is not the same16:01
mriedemwhich we could do in conductor,16:01
mriedemif the scheduler gives a list from select_destinations16:01
bauzasmriedem: I implemented that in https://review.openstack.org/#/c/460455/15/nova/conductor/manager.py16:01
jaypipesmriedem: no, I'm talking about the scheduler doing the "retry" of a claim/allocation.16:01
mriedem"reschedule" is a broad ass term16:01
bauzasjaypipes: please see at http://lists.openstack.org/pipermail/openstack-dev/2017-May/117039.html16:01
*** slaweq has joined #openstack-nova16:01
dansmithhow about a hangout at the bottom of the hour?16:01
bauzasjaypipes: there are 4 reasons why I disagree with doing the allocation within the scheduler worker process16:02
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove dead code  https://review.openstack.org/46066216:02
openstackgerritStephen Finucane proposed openstack/nova master: utils: Replace 'utf8' with oslo.utils equivalent  https://review.openstack.org/46679916:02
mriedemdansmith: yeah need a hangout, so 1PM ET?16:02
jaypipesdansmith, bauzas: I strongly think we should be calling placement's POST /allocations from the scheduler, not the conductor. Sorry if this surprises people.16:02
dansmithmriedem: mriedem sure16:03
dansmithjaypipes: yes that's very surprising.. we all had this conversation in boston and I was sure we had consensus16:03
*** david-lyle has joined #openstack-nova16:03
jaypipesI specifically remember saying "doing claims in the scheduler gets rid of the retry issues (and all associated "upcall shenanigans")16:03
*** mvk_ has quit IRC16:03
bauzasjaypipes: well, I do remember exatly operators nodding at dansmith's proposal of passing down a list of possible acceptable hosts16:03
dansmithjaypipes: so, we also agreed we can't fully get rid of retries right away, which means conductor _will_ have to do allocation calls as well16:03
dansmithright16:03
mriedemnote we've also been saying "claims in the scheduler*"16:03
dansmithjaypipes: I'm opposed to doing it in scheduler first and conductor second.. I think that's a mess16:04
melwittmriedem: thanks. short answer is, you're right. replying on the review now16:04
*** lucasxu has quit IRC16:04
*** slaweq has quit IRC16:04
jaypipesdansmith: I see no reason to "do it in the conductor second".16:04
mriedemmelwitt: ok - so basically wtf for how this behaves, but it's not backward incompatible so ok16:04
jaypipesdansmith: if the scheduler does the claim, there is no reason for anything else to do the claim.16:04
dansmithjaypipes: reschedule16:05
mriedemjaypipes: retries from the computes go up to the cell conductor16:05
jaypipesdansmith: we should *not* support reschedule. period.16:05
dansmithjaypipes: there was almost zero support in the room for eliminating reschedules16:05
bauzasI thought we had that discussion in Boston :/16:05
*** gouthamr has joined #openstack-nova16:05
dansmithjaypipes: which was the whole point of the "send extra hosts down to the cell" discussion, which you were definitely there for16:05
*** udesale has joined #openstack-nova16:05
jaypipesdansmith: yes there was when I said "95% of the causes of reschedules currently will be eliminated"16:05
dansmithbauzas: we did16:05
dansmith*facepalm*16:05
melwittmriedem: yeah ... I'm trying to make all of the formats of count as dict consistent. before, I had some dict and some int so that only things that could have project and user would be dict, but people found that more confusing16:06
bauzasanyway, I'm litterally 24 hours away of taking a long break16:06
jaypipesdansmith: perhaps this is the session I had to leave early (I was standing in the back and right before I left I said "recschedules should not occur and the reason for them will be gone when claining in the scheduler"?16:06
bauzasI'm trying hard to make sure we're all on the same page before I leave16:06
dansmithjaypipes: bauzas: mriedem: I'm good for a hangout any time starting now, whenever you want, until 11:30 PDT16:06
*** mvk has quit IRC16:07
bauzasI can16:07
jaypipesI can do a hangout whenever.16:07
mriedemi can also do now16:07
jaypipes++16:07
dansmithjaypipes: yeah, you left, but I thought you were still around for the consensus on reschedules.. however you _were_ there for the scheduling claims session where we talked about the extra hosts thing16:07
melwitteliminating reschedules would make things really suck for Ironic users in the absence of a porcelain API that does retries16:07
jaypipesmelwitt: you mean "standalone Ironic".16:07
melwittno, Ironic + Nova16:07
mriedemplus i think numa came up16:08
dansmithI'll get a link, just a sec16:08
mriedemin the claims in the scheduler session16:08
jaypipesmriedem: NUMA is handled in the existing NUMAtopologyFilter.16:08
*** hongbin has quit IRC16:08
dansmithhttps://hangouts.google.com/call/e6jtzndusjf6rezqvwdatascvuu16:08
bauzasjoining16:09
jaypipesmriedem: claims would occur after the NUMATopologyFilter selected a host. We could have the NUMAtopology that was selected (and currently thrown away by the filter) written to the compute_nodes table.16:09
*** gouthamr has quit IRC16:09
*** sajeesh has joined #openstack-nova16:10
bauzasdansmith: you're not there in the hangout16:10
jaypipesmelwitt: honestly, I don't really care about use cases where an IPMI boot failure results in an ERROR state for an instance16:11
sajeeshping sdague16:12
sdaguesajeesh: what's up?16:14
*** mikal has quit IRC16:14
*** rcernin has quit IRC16:14
sajeeshHi sdague ..you have written in the mail Get someone from the CERN team to write down what their ideal16:14
sajeesh   ruleset looks like, so it can be turned into a worked example16:14
sdaguesajeesh: yes16:15
sajeeshby ruleset do you mean all use cases ?16:15
sdaguenot use cases, how they think they would want hierarchical quotas to work16:15
*** mikal has joined #openstack-nova16:16
sajeeshok16:16
melwittjaypipes: :\ I don't know the particulars on what is different about scheduling onto baremetal directly, but when you have enough nodes, enough of them could be flaky and if we fail and go to error, we're not absorbing any of that for the end user16:16
sdaguesajeesh: because the use cases here don't build the hierarchical model all that well, most people set a bunch of use cases together that actually are conflicting16:17
sdagueso, I want the model algorithm to be proposed by groups that are interested, then we'll work it through16:17
sajeeshsdague:+116:18
*** lucasxu has joined #openstack-nova16:18
*** Apoorva has joined #openstack-nova16:19
*** ayoung has joined #openstack-nova16:21
ayoungSince we are rewriting how you guys do policy enforcement, maybe y'all should take a look:  https://review.openstack.org/#/c/384148/16:21
*** udesale has quit IRC16:22
*** kaisers has quit IRC16:22
ayoungalaski, it has changed a bit since you last looked at it...in October16:22
*** kaisers has joined #openstack-nova16:23
cdentjaypipes are you guys still on the hangout?16:25
jaypipescdent: yes16:25
*** mpaolino has quit IRC16:25
sdagueayoung: so, my concern with is_admin on project is that now if you give a user authority to add other users to a project, they also get to see the physical topology of your cloud, and perform live migrations. Because while is_admin is no longer fully global, it isn't service scoped, right?16:25
alaskiayoung: I'm no longer actively involved in openstack and likely won't get a chance to look too closely at that change.16:26
ayoungalaski, understood16:26
ayoungsdague, let me parse what you are asking.16:27
ayoungsdague, "my concern with" == "the reason I don't like this approach."    " if you give a user authority to add other users to a project"  should read " if you give a user authority to add other users to the admin project"16:28
ayoungsdague, is that what you mean?16:28
sdagueayoung: well, I'm trying to understand based on what's there16:28
ayoungsdague, ok...so let me try to explain what we are doing here.16:29
sdagueso, what does the flow look like from openstack cli calls16:29
ayoungWe added a config option in Keystone that indicates one project is an admin project.16:29
sdaguefor what an operator would be doing, and why16:29
*** tjones has joined #openstack-nova16:30
ayoungIf that value is set, if a token is scoped to the admin project, the oslo-context will contain the value is_admin_project=True16:30
ayoungthe assumption is that, for operations that should be scoped to a proejct, we still need to honor the admin role, but that should be distinct from global operations that need the admin role16:30
ayoungfor global operations, such as adding a hypervisor, you limit access to tokens with is_admin_project=True16:31
*** rcernin has joined #openstack-nova16:31
ayoungit is not scoped per service16:31
ayoungyou could do per-service via RBAC, but you would still want to make use of this mechanism16:31
ayoungif you wanted a computeadmin role separate from admin, you could do that, but it would require custom policy16:32
ayoungbut you would still want to enforce that the user has computeadmin on the admin_project, and not accept tokens scoped to other projects16:32
*** ltomasbo is now known as ltomasbo|away16:32
ayoungsdague, does that make sense?16:32
sdagueok, I guess I don't understand how it moves things forward. I think I need an example of openstack cli commands about "now this is in place, this is what a keystone admin would do to give bob the following permissions, and this is what he could do after"16:33
sdagueI need an outside in view of this to make it make sense to me16:33
ayoungsdague, fair enough16:33
ayoungsdague, once this change is merged, assuming no changes on the Keystone side, nothing would actively change in Nova16:34
sdagueayoung: then I don't understand why we'd make the change16:34
ayoungthe reason for that is, as alaski and I discussed in his comments, we built a hack into oslo-context16:34
ayoungsdague, it only takes effect once the config option is actively set in Keystone16:34
*** slaweq has joined #openstack-nova16:34
*** gouthamr has joined #openstack-nova16:34
ayoungat that point, only users with roles on the project that Keystone has configured as the admin_project would be able to execute these APIs16:35
*** lucasagomes is now known as lucas-afk16:35
ayoungWe need the change in Nova, Glance, Cinder, Neutron, and Keystone before the fix enforces policy across the board16:35
sdagueayoung: sure, I guess I don't understand why Nova should ever know that big16:35
sdaguethat bit16:35
sdaguelike, that's the thing I don't get16:35
sdaguethere are multiple ways now for a keystone setup to say "you are admin"16:35
sdagueso, that's fine16:36
ayoungsdague Nova is the policy enforcement point, not Keystone16:36
sdaguewhy doesn't keystonemiddleware / oslo.context process that16:36
sdagueand just set the is_admin flag based on that logic16:36
ayoungso....16:36
ayoungDid you go to my RBAC in middleware talk?16:36
sdagueit doesn't seem useful to have to teach every service what the current keystone configuration is to do that16:36
sdaguenope16:36
ayoungsdague, ok, so the conccet there is that RBAC could be enforced on just the URL, as it does not need to know the scope of the object out of the database.  Unlike, say, neutron netwokrs, or glance images, which are project scoped.  The role check is only on the URL16:37
ayoungis_admin_project is a scope check.16:37
ayoungand, for all the listed resources, we need to fetch an object our of the database first16:38
ayoungOK...you say...but these APIs are not scoped, so we don't need an object from the database, right?16:38
ayoungand...I agree with you16:38
ayoungbut we do not have enough information to determine what policy rule we need to enforce16:38
ayoungonly the policy.json file knows that, as of now16:39
sdagueayoung: honestly, I think I need worked examples showing the set of cli flows for it to make sense. The policy bits get really abstract really quickly. And while I realize you have most of it your head, I can't really do that without pictures and flows16:39
ayoungIn the "RBAC in middleware" proposal, we specify an inventory of routes, with a  role assigned to each.  The routes look a lot like the Compute API doc16:39
*** gouthamr has quit IRC16:40
dansmithjaypipes: feel free to cc me directly on that mail if you want to further implicate me in the act of bring it back up16:40
ayoungsdague, the short answer to your question is, without additional policy enforcement, we need to know, at policy time, whether a specific token is supposed to be global scoped or not16:40
*** salv-orlando has quit IRC16:40
ayoungforget my RBAC proposal, cus that is not approved yet.  JUst to get a fix for bug 968696, we need a way for Nova to say "yes, this token is good for global operations" or "no it is not"16:41
openstackbug 968696 in OpenStack Identity (keystone) ""admin"-ness not properly scoped" [High,In progress] https://launchpad.net/bugs/968696 - Assigned to Adam Young (ayoung)16:41
ayoungsdague, determining which operations are global vs scoped is a decision for the Nova engineering team to make16:41
ayoungas is figuring out how to enforce the scoping16:42
ayoungwhat Keystione is providing is the answer to "is this token valid for global operations"16:42
ayoungthis patch is using that answer to start differentiating between scoped and global operationws16:42
ayoungcould it be done in middleware?  Not today16:42
ayoungNot without a lot more tooling.16:43
sdagueayoung: so, I'll repeat, this isn't going to make any sense to me without those other diagrams and flows. So I'll stay opted out of the conversation if those don't exist.16:43
ayoungsdague, huh?16:43
ayoungI...I don't think I can make it any more simple than that.16:44
ayoungIn order to perform global admin operations, you need a token scoped to the admin project.16:44
*** markus_z has quit IRC16:45
*** jaosorior is now known as jaosorior_away16:45
*** diga has quit IRC16:46
*** armax has joined #openstack-nova16:46
openstackgerritSylvain Bauza proposed openstack/nova master: Scheduler returning alternatives per destination  https://review.openstack.org/46517516:46
*** purplerbot has quit IRC16:46
openstackgerritSylvain Bauza proposed openstack/nova master: Delete existing allocations when retrying  https://review.openstack.org/46043316:46
openstackgerritSylvain Bauza proposed openstack/nova master: Don't delete allocation if instance being scheduled  https://review.openstack.org/46017716:46
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor  https://review.openstack.org/46045516:46
openstackgerritSylvain Bauza proposed openstack/nova master: Fix ChanceScheduler returning a wrong node  https://review.openstack.org/46672516:46
*** jpena is now known as jpena|off16:47
*** purplerbot has joined #openstack-nova16:47
ayoungsdague, what exactly would you require in order to move this forward?  Considering that a comparable change needs to go into every openstack project, I'm guessing that whatever we provided for the Nova team would help move it forward across the board.  The current implementations are really broken, due to Keystone not having provided a way to distinguish between global and scoped tokens.  But that mistake goes back to pre-Ke16:54
ayoungystone Nova's token system as well.16:54
ayoungJust because it has been broken since Cactus does not mean it is not broken.16:54
*** gszasz has quit IRC16:55
*** ralonsoh has quit IRC16:57
*** derekh has quit IRC16:59
*** salv-orlando has joined #openstack-nova17:01
bauzasjaypipes: mriedem: dansmith: cdent: melwitt: edleafe: FWIW, given the outcome of our hangout, I'm going to stop working on my series, in particular given I'll need to disappear starting tomorrow17:04
bauzasedleafe: feel free to takeover any change you want17:04
*** hongbin has joined #openstack-nova17:04
*** gouthamr has joined #openstack-nova17:04
bauzasedleafe: I just removed my -2s that I gave you previously17:04
bauzastl;dr: all is clear for iterating fast17:05
*** slaweq has quit IRC17:05
*** mvk has joined #openstack-nova17:05
bauzasI'll spend my day tomorrow for bug triaging and reviews17:05
*** salv-orlando has quit IRC17:05
*** trinaths has joined #openstack-nova17:06
*** gouthamr has quit IRC17:09
ayoungsdague, here is my RBAC talk. https://www.openstack.org/videos/boston-2017/per-api-role-based-access-control  please watch it when you have the time.  In the meanwhile, I will try to put together the explanation of why we are approach the fix to 968696 the way we are.17:09
*** hongbin has quit IRC17:13
*** marst_ has joined #openstack-nova17:13
*** trinaths has quit IRC17:14
*** lucasxu has quit IRC17:14
bauzasmriedem: melwitt: do you want me to publish a new rev for the ReqSpec delete where I would call the deletion in https://review.openstack.org/#/c/391060/9/nova/compute/api.py@2046 for example ?17:15
bauzasI can do that quickly so you both could review17:15
*** mvk_ has joined #openstack-nova17:15
cdentbauzas: ack on the all clear for iterating17:16
mriedembauzas: i don't think that's the place to do it17:16
mriedem_local_delete is the place to do it in the api17:17
bauzasmriedem: I saw you wanted to restrict for local deletes17:17
mriedembauzas: but i won't be reviewing anything else for awhile, i'm on patch 1 of the quota series17:17
mriedembauzas: the _local_delete method is where local delete happens17:17
bauzasmriedem: like I said in the comment, I think it's pretty harmless17:17
bauzasmriedem: well, I think we would loose a huge number of deletions if we only do that for local instance deletes17:18
bauzasright?17:18
melwittbauzas: I didn't know about the on-the-fly reqspec it can come up with if it doesn't find one, so it's not catastrophic in the case we described17:18
melwittit would still be something like "user can see and do actions on instance but instance may not honor original scheduling spec"17:19
*** tjones has left #openstack-nova17:19
mriedemwe are still going to need something to cleanup api db orphans, like instance_mappings17:19
bauzasmelwitt: eg. https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L29417:20
mriedemidk, i can't context switch on this right now17:20
bauzasokay, let's postpone that for later17:20
bauzasit's a bugfix, we can land it later17:20
bauzasI'll review jaypipes's series for shared-rps17:21
*** jmlowe has quit IRC17:25
edmondswjohnthetubaguy can you point me to the patch you mentioned at the summit to swap network routing before pause/resume on live migrate?17:36
*** fragatina has quit IRC17:37
*** Sukhdev has joined #openstack-nova17:44
*** gianpietro has quit IRC17:44
mriedemmelwitt: just so you're aware, i posted comments in the base patch but i'm still working through the rest17:44
gyeemriedem: can you please take a look whenever you have a chance? https://review.openstack.org/#/c/466143/17:45
melwittmriedem: cool, thanks17:45
openstackgerritSteve Noyes proposed openstack/nova master: WIP: update live migration to use v3 cinder api  https://review.openstack.org/46398717:46
*** sajeesh has quit IRC17:48
*** yamahata has joined #openstack-nova17:49
*** jmlowe has joined #openstack-nova17:53
jaypipesmriedem, dansmith, melwitt, cdent, bauzas: ok, ML post sent about getting rid of automated reschedule behaviour.17:54
* cdent prepares himself17:54
*** mvk_ has quit IRC17:54
dansmithack17:55
jaypipesmriedem, dansmith, melwitt, cdent, bauzas: pls let me know if I accurately explained the issue and the request.17:56
melwittout of curiosity I checked how kubernetes scheduling works and whether it retries, to be aware of what others are doing,17:56
melwittand it sounds like it does retry forever "remains in pending state until suitable machine becomes available" according to this post. I didn't find a doc about it on k8s site yet https://stackoverflow.com/questions/28857993/how-does-kubernetes-scheduler-work/28874577#2887457717:57
jaypipesmelwitt: well, yeah, because k8s is an orchestrator :)17:57
dansmithyeah, totally different17:57
jaypipesmelwitt: which fits nicely into my "nova shouldn't be an orchestrator" point ;)17:58
melwittbut openstack doesn't have an orchestrator at all, does it?17:58
melwittso our thing just performs worse17:58
jaypipesmelwitt: heat?17:59
dansmithheat17:59
dansmithheh17:59
jaypipesmelwitt: or tacker for NFV.17:59
*** sambetts is now known as sambetts|afk17:59
melwittI think heat is a manual orchestrator, you (the end user) have to tell it everything to do, I thought18:00
jaypipesmelwitt: well, k8s is the same. you declare a pod definition and k8s tries constantly to make your pod definition a reality.18:01
*** Sukhdev has quit IRC18:01
jaypipesmelwitt: or you just meant heat doesn't constantly try to do things?18:01
melwittjaypipes: more the latter. I'm not a heat expert, maybe there's a way to tell it to keep retrying a definition18:03
jaypipesmelwitt: yeah, I'm not a Heat expert either.18:03
*** r-daneel has joined #openstack-nova18:09
*** ijw has quit IRC18:09
*** crushil has quit IRC18:10
*** lucasxu has joined #openstack-nova18:12
*** kaisers has quit IRC18:14
*** kaisers has joined #openstack-nova18:14
cdentjaypipes, melwitt: if want to play the odds, it is more likely that a "keep retrying orchestrator" (that actually does the job well) will come into existence if we do not include bad orchestration in nova.18:17
*** kaisers has quit IRC18:17
*** kaisers has joined #openstack-nova18:17
jaypipescdent: ++18:17
cdentit is also the case that the odds of "good orchestration" merging sooner (in nova) than something else trying to do it (outside of nova's constraints) are low18:17
melwittcdent: maybe. I'm not sure how many people would want to use an orchestrator-less system, but that works as long as no other viable options are available18:20
*** itlinux has joined #openstack-nova18:21
cdentmelwitt: Is what we have today orchestrator-less or bad-orchestrator?18:21
melwittcdent: bad-orchestrator18:22
cdentas in makes a half hearted effort at retrying and then bails..., yeah?18:22
melwittyes18:23
*** gouthamr has joined #openstack-nova18:24
jaypipesdansmith: you were +2 previously. I'm good on https://review.openstack.org/#/c/460177/ now with bauzas' latest revision.18:25
melwittcdent: with the half hearted effort, an operators can detect a bad baremetal node and take it out of rotation without exposing end users to the fail. without it, the end user would have to suffer the failure at least once before the operator can take it out of rotation. unless the operator builds a porcelain API that maybe uses heat behind it and has end users point at that. is what I'm thinking18:26
* cdent nods18:27
*** catinth__ has quit IRC18:28
melwittI can also see the point of, you can't serve everybody perfectly, and if it's really only 5% of people that would be affected, then I get that. we'll see what they say on the ML18:29
*** READ10 has joined #openstack-nova18:29
*** catintheroof has joined #openstack-nova18:30
*** trinaths has joined #openstack-nova18:30
*** trinaths has left #openstack-nova18:31
mriedemmelwitt: ok https://review.openstack.org/#/c/446239/18:35
mriedemmelwitt: i didn't go through tests18:35
melwittmriedem: thanks. reading through18:36
*** harlowja has joined #openstack-nova18:37
mriedemi have successfully finished a 60+ ounce bag of tootsie rolls from halloween18:38
mriedemit was a grind, but it's done18:39
*** masuberu has quit IRC18:39
cdentmy jaw hurts now18:40
*** dave-mccowan has quit IRC18:41
*** lucasxu has quit IRC18:41
*** itlinux has quit IRC18:41
*** esberglu_ has quit IRC18:42
*** itlinux has joined #openstack-nova18:42
*** lucasxu has joined #openstack-nova18:43
*** harlowja has quit IRC18:43
*** crushil has joined #openstack-nova18:43
*** esberglu has joined #openstack-nova18:44
*** yamahata has quit IRC18:45
*** itlinux has quit IRC18:48
jaypipesmelwitt: hmm, I wonder if some combination of beer and cat toys will be enough to bribe your James into my worldview...18:54
*** gouthamr has quit IRC18:54
mriedemjaypipes: not until you can chug a beer faster than him18:55
mriedemwhich from fenway we know isn't going to happen without proper training with a montage18:56
melwittheh18:56
*** lucasxu has quit IRC18:58
*** smatzek has quit IRC19:02
melwittmriedem: replied on quotas19:02
*** smatzek has joined #openstack-nova19:02
*** lucasxu has joined #openstack-nova19:03
*** gianpietro has joined #openstack-nova19:08
*** gianpietro has quit IRC19:13
*** nicolasbock has quit IRC19:13
*** avolkov has quit IRC19:16
cdentmriedem, jaypipes, melwitt, dansmith: Does the idea that was bounced around on the call of claim in the scheduler, re-claim (when things are bad) in the conductor address the issues james is pointing out? Trying to clarify my confused brain.19:18
mriedemcdent: yes and is what we discussed in boston19:18
*** salv-orlando has joined #openstack-nova19:18
mriedemsuper conductor passes alternate hosts to the cell; if something fails, we reschedule via conductor within the cell using those alternate hosts19:19
cdenti knew that the boston plan did, but wasn't clear on if the claim from two different places idea did19:19
cdentgotchya, thanks19:19
mriedemclaiming in two places has the same long-term functionality if we have to retry within a cell19:19
mriedemi think the idea of doing claims in the scheduler AND conductor is if we do it in the scheduler, we have (a) tighter retry loop and (b) if we eventually drop reschedules in the cell, then we've already got the work done in the scheduler - as dan pointed out on the call19:20
cdentI think I'm leaning that way because of the "claim as early as possible" stuff I mentioned in one of my comments19:20
mriedemthe short-term downside is you have duplication19:20
* cdent is not too bothered by that19:20
mriedemi do'nt really see how that's not hidden in the scheduler report client though19:21
cdentDRY is what breeds and deeply nested object hierarchies and that makes me cry19:21
mriedemor some utility method shared between conductor and scheduler19:21
cdentyes19:21
cdentwoot! I managed a whole 4 things off my to do list today. That's less than 4%. ossum.19:22
* cdent surrenders19:22
cdentgoodnight19:22
*** cdent has quit IRC19:22
*** jmlowe has quit IRC19:23
mriedemmelwitt: did you give up halfway?19:23
melwittmriedem: did I miss some comments? I didn't mean to19:23
melwittargh, sorry19:23
*** jmlowe has joined #openstack-nova19:24
*** slaweq has joined #openstack-nova19:24
*** larsks has joined #openstack-nova19:25
larsksHowdy.  I have an instance that is attached both ipv4 and ipv6 networks.  The ipv4 networks show up in network_data.json on the config drive, but there is no trace of the ipv6 network.  I see the same thing with a single network that has both ipv4 and ipv6 subnets...only the ipv4 information shows up.  What could be causing this?19:27
*** salv-orlando has quit IRC19:28
dansmithmriedem: I may be remembering wrong, but wasn't there a thing in the last six months or something about us not including ipv6 stuff in network.json in certain circumstances? re ^19:33
fungilarsks: that's a known issue. i gather there's an open bug, mailing list thread and proposed change(s) addressing it, though i don't have references handy at the moment19:33
mriedemdansmith: i vaguely remember sdague and jaypipes reviewing something in there recently, but don't know if it was for this19:34
larsksfungi: thanks. do you happen to know in which release it should work right now?  E.g. was this a regression in ocata or master or something?19:35
larsksAnd would I expect it to work in release N-1?19:35
*** tbachman has quit IRC19:35
mriedemhttps://github.com/openstack/nova/commit/ccebded0cbb654be18db5b4e0e7f8b8a3a7cacdb ?19:35
mriedem^ is what i was thinking of19:35
mriedembut does'nt look like the right thing19:36
larsksHmmm, I found https://bugs.launchpad.net/nova/+bug/1514082 which suggests this is just a configuration issue.19:36
openstackLaunchpad bug 1514082 in OpenStack Compute (nova) "network_data.json does not provide information about ipv6 addresses." [Undecided,Invalid]19:36
fungilarsks: on another channel, clarkb pointed me to bug 167636319:38
openstackbug 1676363 in OpenStack Compute (nova) "The network metadata should be more useful" [Medium,In progress] https://launchpad.net/bugs/1676363 - Assigned to Dan Peschman (dpeschman)19:38
mriedemdansmith: why do we need with instance.obj_alternate_context on https://review.openstack.org/#/c/458634/12/nova/compute/api.py@1802 ?19:39
fungilarsks: related ml thread starts at http://lists.openstack.org/pipermail/openstack-dev/2017-March/114563.html19:39
larsksfungi: thanks for both pointers.  I like the bug title.  I'm going to see if it was just a config issue.19:39
dansmithmriedem: because the instance has the ctxt inside not the cctxt19:40
dansmithmriedem: well, actually, maybe not there I guess19:40
dansmithmriedem: might be able to remove that one I guess19:40
mriedemhold up19:41
mriedemstill going through this19:41
dansmithI need food anyway19:41
mriedemthis is probably tied to get_instance stashing the targeted context on the instance object19:43
mriedemthat's probably something that deserves a comment in the code then19:43
jaypipesmriedem: and it's that "get me alternate hosts" thing that I am really against.19:49
jaypipesmriedem: in the conductor that is..19:49
*** slaweq has quit IRC19:49
*** gianpietro has joined #openstack-nova19:49
*** slaweq has joined #openstack-nova19:49
*** tbachman has joined #openstack-nova19:50
bauzassorry folks, was afk for dinner purposes19:52
jaypipesdansmith: the diaper exception. nice.19:52
dansmithjaypipes: that19:53
melwittmriedem: replied to the rest of the comments19:53
dansmithis definitely not my term, but someone used it around me recently and I made note to use it again19:53
bauzasjaypipes: dansmith: unfortunatly, I think it's related to the thread mriedem created about the pendulum switching19:54
bauzasie. should nova be tolerant to misconfig?19:54
bauzasif we assume the answer be no, then I agree, case c) is probably not worth it for rescheduling19:55
*** smatzek has quit IRC19:55
*** slaweq has quit IRC19:55
*** slaweq__ has joined #openstack-nova19:55
mriedembauzas: that's not really why i started that thread19:55
bauzasmriedem: that I know19:56
bauzasmriedem: but I think the outcome is related19:56
*** salv-orlando has joined #openstack-nova19:56
mriedemi think eventually disabling reschedules by default will make things that cause (c) to get exposed more clearly so that we can determine if they are things we should reschedule on, or handle as just bug fixes, i.e. some race we can handle19:57
mriedembut it's a wild west of who knows19:57
bauzasyup19:57
mriedemb/c it's python and anything raised up from below goes in there19:57
mriedemdansmith: left some comments/questions in https://review.openstack.org/#/c/458634/19:58
dansmithmriedem: thanks19:58
mriedemdansmith: am i correct in stating that's all prep work for the next change in the series?19:58
*** smatzek has joined #openstack-nova19:58
mriedemmelwitt: ok looking20:00
bauzasmriedem: dansmith: mmm, that https://review.openstack.org/#/c/458634/ is something I wondered when I was looking at my branch20:01
bauzasmriedem: dansmith: correct me if I'm misunderstanding, but the problem is that we mutate the context so that when we exit the contextmanager, it's still having the new MQ ?20:02
bauzasbecause if so, that explains what I discovered, ie. the fact that I was able to ComputeNodeList.get_all() without needing to scope my target20:02
*** gianpietro has quit IRC20:05
mriedemmelwitt: replied to your replies, i don't get the point about old compute code calling count()20:05
mriedembecause it's not a separate service,20:05
mriedemthe old compute code will call the old count() code20:06
*** nicolasbock has joined #openstack-nova20:06
melwittmriedem: the count() function is accessible through the Quotas.count() remotable method20:06
mriedembecause it's all bundled together i think, unless maybe you have like a nova-common package and that gets updated before this or something?20:06
*** gianpietro has joined #openstack-nova20:06
melwittI don't think compute actually calls count. but if something old did, then the new code would have to work20:06
*** gianpietro has quit IRC20:07
mriedemi don't see anything calling it20:07
*** gianpietro has joined #openstack-nova20:07
mriedembesides the api,20:08
mriedemwhich you've changed here20:08
melwittI don't think anything is, dansmith was saying because the remotable method is there, we can't just change the format of what it returns20:08
mriedemi think that's fine, and you're not20:08
mriedemyou added count_as_dict and the api calls that now20:09
melwittyeah, but underneath there has to be something in nova/quota.py that returns the old format20:09
melwittright?20:09
*** READ10 has quit IRC20:09
mriedembut i'm asking about https://review.openstack.org/#/c/446239/7/nova/quota.py@191420:09
melwittif count() is to still be supported20:09
melwittQuotas.count() passes through to nova/quota.py20:09
mriedemalso this https://review.openstack.org/#/c/446239/7/nova/quota.py@145020:10
melwittand what I have there is "if count() use old counting function, else use the new one that returns a dict"20:10
mriedemwhere does ^ happen?20:10
melwittat L1450 I'm defining the old count function if one is provided20:11
melwittbecause a Quotas.count() would call self.count()20:11
*** awaugama has quit IRC20:12
mriedemwhich otherwise would fail if you didn't have https://review.openstack.org/#/c/446239/7/nova/quota.py@1608 ?20:13
mriedemQuotas.count() calls count on the resource objec20:13
mriedemthe engine doesn't have a count() method20:13
dansmithmriedem: yeah, prep for the next20:13
*** armax has quit IRC20:13
mriedemwhether or not you're talking to the engine, the driver or the resource object is always a gamble when yo'ure talking quotas20:14
dansmithbauzas: I'm not sure what you're asking.. currently we mutate global context for the temporary target context handler, which isn't what we want20:14
mriedemmelwitt: oh no you're right20:14
mriedemengine does have a count() method which calls count() on the resource object20:14
mriedemCountableResource in this case20:14
*** dimtruck is now known as zz_dimtruck20:14
bauzasdansmith: I'm trying to explain that I saw a weird behaviour where I stupidly forgot to target a cell for calling the compute list, and it worked20:14
bauzaswhile it should have be given me no computes, right?20:15
dansmithbauzas: well, that's probably because you weren't in a multicell environment20:15
mriedemstill, couldn't nova.objects.Quotas.count() call count_as_dict and return the int?20:15
melwittmriedem: yeah, those methods I added on the NoopQuotaDriver were a mistake, they would do nothing20:15
bauzasdansmith: that's what I thought, since it was for functional tests20:15
dansmithbauzas: without my (yet to be merged) patch to devstack, you're always single-cell20:15
dansmithand in functional tests unless you specifically arrange for multicell20:15
mriedemmaybe the problem is if count called count_as_dict we wouldn't know which key to use in the dict20:15
bauzasdansmith: ah right20:16
mriedembut we could try keys until we found one that hits20:16
* bauzas back to reviewing20:16
melwittmriedem: yeah, that might be possible.20:16
melwittI was thinking I should change security_group_rules to use the 'user' key since its limit can be scoped to a user20:17
melwittthat could be the logic that determines which key it should be. whereas fixed_ips, floating_ips, and networks limit can only be scoped to a project20:18
mriedemif figured just key = 'user' if 'user' in count else 'project'20:18
mriedemyou already have something like that in here20:18
melwittyeah. I was just saying as a tangent that I'm gonna change the key for security_group_rules20:19
mriedemanywho, it's been raining here for about a week but we have sun today, so i'm going to go out and mow the lawn.20:19
melwittk. thanks for all of the good comments on the review20:19
mriedem\o/ i'm hoping the rest of the series is easier than this one20:19
melwittit is, until the "count instances" patch, that one will be hard as all of the "reserve" change to "check_deltas"20:20
*** liverpooler has quit IRC20:21
*** ijw has joined #openstack-nova20:21
mriedemplus it's multi-cell right?20:25
mriedemuntil we get that info from placement?20:25
*** lbragstad has quit IRC20:26
melwittmriedem: yeah, the count function isn't hard to understand. it's all of the changes in nova/compute/api and nova/compute/manager that might be tough20:26
melwittlots of deleted lines and changing the old reservation stuff to counting20:26
melwittand by that I mean, replacing the reserve/commit/rollback with the stuff defined in the first patch20:27
mriedemdansmith: re your reply in the reschedule ML thread - you can configure the cell conductor to hit the api db to get the cell mappings, yes? we don't want you to, but you can.20:28
dansmithmriedem: yes, but you can't configure it to talk to the compute and the scheduler at the same time, which is why I said MQ and not DB :)20:28
mriedemyeah that was more clear20:28
mriedemneed diagrams in the devref at some point20:29
mriedembut,20:29
mriedemyou probably wouldn't want to put a line between the cell conductor and the api db in a diagram anyway since you don't want people doing that20:29
mriedemand we do'nt want code relying on that20:29
dansmithand it wouldn't help without also building that line for the mq20:30
mriedemi also get tripped up when talking about this because you don't need a super conductor today20:30
mriedemi think it would be good to have something in the devref like a topology diagram for multi-cell cells v2, with some information about which config is needed for each service in which location, i.e. where do i need api_db or database set in nova.conf, which is pointing at cell0, et20:31
mriedemi have a feeling people will just set api_db in nova.conf everywhere because they don't know, like we used to have in devstack20:32
cburgessdansmith mriedem Wait what did I do?20:32
mriedemhuh?20:33
cburgessdansmith mriedem Something about live migrations and extra specs (no regular users can't see the extra specs).20:33
mriedemanyway, time for cutoffs and sleeveless t for the neighbors20:33
dansmithmriedem: you don't if you only have one cell20:33
cburgessOh looks like an old message from a few days ago. Weird. Sorry20:33
*** karimb has quit IRC20:33
mriedemcburgess: regular users can see extra specs,20:33
mriedembecause we do'nt scope the check to the flavor20:33
*** smatzek has quit IRC20:34
cburgessmriedem Oh ok.. well I meant, I don't change anything with regard to extra spec visibility20:34
cburgessSo whatever upstream does we do20:34
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/flavors_extraspecs.py#L5320:34
mriedemcburgess: we all assumed that extra specs are hidden by default b/c they are admin or user in policy and the owner of a flavor/extra spec is the admin,20:34
mriedemhowever,20:34
mriedemwe don't scope the policy check to the flavor, we scope it to the context, and the user context is the admin or owner - they are the owner of the request20:35
mriedemso unless you change the policy to admin only, non-admins can see extra specs20:35
cburgessOh thats acute...20:35
cburgessCute even...20:35
mriedemright, and johnthetubaguy has a spec to fix that20:35
cburgessLike I said, I don't think we change that one.20:35
cburgessHmmm I wonder if that would be an issue..20:35
cburgessThats a pretty big change at this point.20:35
mriedemhttps://review.openstack.org/#/c/433037/20:36
*** dillaman has quit IRC20:36
mriedemit would break a bunch of shit i'm sure20:36
mriedemb/c you'd start getting 401 or 403 or whatever20:36
*** mriedem is now known as mriedem_afk20:36
cburgessYeah we have it default policy.20:36
cburgessmriedem_afk What else is this spec going to break I wonder.20:37
*** salv-orlando has quit IRC20:39
*** salv-orlando has joined #openstack-nova20:40
*** salv-orlando has quit IRC20:44
*** amrith has joined #openstack-nova20:50
amrithmriedem_afk, when you get a chance would you please take a look at the email I sent you.20:51
amrithwondering how best to make sure I get all of the gotcha's in one go.20:51
*** ijw_ has joined #openstack-nova20:51
*** dillaman has joined #openstack-nova20:53
*** ijw has quit IRC20:55
*** gouthamr has joined #openstack-nova20:55
*** thorst_afk has quit IRC20:58
*** thorst_afk has joined #openstack-nova20:59
*** felipemonteiro_ has quit IRC20:59
*** dillaman has quit IRC21:03
*** thorst_afk has quit IRC21:03
*** dave-mccowan has joined #openstack-nova21:05
*** armax has joined #openstack-nova21:07
*** kaisers has quit IRC21:10
*** gianpietro has quit IRC21:10
*** gouthamr has quit IRC21:13
*** dillaman has joined #openstack-nova21:15
*** gouthamr has joined #openstack-nova21:16
openstackgerritDan Smith proposed openstack/nova master: De-complicate some of the instance delete path  https://review.openstack.org/45863621:18
openstackgerritDan Smith proposed openstack/nova master: Move to proper target_cell calling convention  https://review.openstack.org/45863421:18
openstackgerritDan Smith proposed openstack/nova master: Make target_cell() yield a new context  https://review.openstack.org/45863521:19
openstackgerritDan Smith proposed openstack/nova master: Fix live migration devstack hook for multicell environment  https://review.openstack.org/45853721:19
openstackgerritDan Smith proposed openstack/nova master: Target cell on local delete  https://review.openstack.org/46405921:19
dansmithmriedem_afk: this is only the object context change to see if it breaks anything ^21:19
dansmiththen I'll do the other things21:19
*** gianpietro has joined #openstack-nova21:22
*** catintheroof has quit IRC21:22
*** MVenesio has quit IRC21:23
*** ijw_ has quit IRC21:23
*** esberglu has quit IRC21:24
*** kaisers1 has quit IRC21:25
*** MVenesio has joined #openstack-nova21:28
*** catintheroof has joined #openstack-nova21:29
*** jheroux has quit IRC21:30
*** fragatina has joined #openstack-nova21:35
*** thorst_afk has joined #openstack-nova21:36
*** esberglu has joined #openstack-nova21:39
*** eharney has quit IRC21:40
*** kaisers has joined #openstack-nova21:40
*** thorst_afk has quit IRC21:40
*** gouthamr has quit IRC21:41
*** jwcroppe has quit IRC21:42
*** jmlowe has quit IRC21:42
*** jwcroppe has joined #openstack-nova21:43
*** ijw has joined #openstack-nova21:46
*** jwcroppe has quit IRC21:47
*** fragatina has quit IRC21:47
*** fragatina has joined #openstack-nova21:48
efriedmriedem_afk Can you please push https://review.openstack.org/#/c/391288/ ?  Wanna get this pile moving again.  Got some more stuff I want to add on top, features from previous review comments.21:49
*** lyan has quit IRC21:52
*** fragatina has quit IRC21:58
*** lucasxu has quit IRC21:58
*** MVenesio has quit IRC21:59
*** takashin has joined #openstack-nova22:02
*** mtanino has quit IRC22:03
*** zz_dimtruck is now known as dimtruck22:09
*** ijw has quit IRC22:10
*** lyan has joined #openstack-nova22:10
*** mlavalle has quit IRC22:10
*** burt has quit IRC22:10
*** kylek3h has quit IRC22:12
*** rfolco has quit IRC22:13
*** baoli has quit IRC22:13
*** xyang1 has quit IRC22:13
*** itlinux has joined #openstack-nova22:13
*** claudiub has quit IRC22:14
*** ijw has joined #openstack-nova22:20
*** ijw has quit IRC22:23
*** crushil has quit IRC22:27
*** jwcroppe has joined #openstack-nova22:28
*** ijw has joined #openstack-nova22:28
*** hongbin has joined #openstack-nova22:33
*** ijw has quit IRC22:34
*** ijw has joined #openstack-nova22:35
*** Apoorva_ has joined #openstack-nova22:36
*** slaweq__ has quit IRC22:36
*** Apoorva has quit IRC22:40
*** itlinux has quit IRC22:42
*** ijw has quit IRC22:42
*** gianpietro has quit IRC22:43
*** gianpiet_ has joined #openstack-nova22:44
*** lyan has quit IRC22:46
*** ijw has joined #openstack-nova22:46
*** Apoorva_ has quit IRC22:47
*** r-daneel has quit IRC22:47
*** dimtruck is now known as zz_dimtruck22:47
*** Apoorva has joined #openstack-nova22:47
*** zz_dimtruck is now known as dimtruck22:48
*** kuzko has quit IRC22:49
*** kuzko has joined #openstack-nova22:49
*** ijw has quit IRC22:51
*** jmlowe has joined #openstack-nova22:56
*** gianpiet_ has quit IRC22:57
*** lyan has joined #openstack-nova22:59
*** thorst_afk has joined #openstack-nova23:00
*** itlinux has joined #openstack-nova23:01
*** ijw has joined #openstack-nova23:02
*** hongbin has quit IRC23:03
*** sdague has quit IRC23:03
*** hongbin has joined #openstack-nova23:04
*** thorst_afk has quit IRC23:04
*** thorst_afk has joined #openstack-nova23:05
*** itlinux has quit IRC23:05
*** thorst_afk has quit IRC23:09
*** gianpietro has joined #openstack-nova23:10
*** kaisers_ has joined #openstack-nova23:10
*** jmlowe has quit IRC23:11
*** jmlowe has joined #openstack-nova23:12
*** kaisers_ has quit IRC23:14
*** ijw has quit IRC23:14
*** jamesdenton has joined #openstack-nova23:16
*** jwcroppe has quit IRC23:18
*** jamesden_ has joined #openstack-nova23:20
*** jamesdenton has quit IRC23:21
*** lyan has quit IRC23:25
*** jamesden_ has quit IRC23:30
*** ijw has joined #openstack-nova23:33
*** ijw has quit IRC23:34
*** ijw has joined #openstack-nova23:34
*** felipemonteiro has joined #openstack-nova23:39
*** catintheroof has quit IRC23:40
*** nicolasbock has quit IRC23:40
*** salv-orlando has joined #openstack-nova23:41
*** jwcroppe has joined #openstack-nova23:43
*** catintheroof has joined #openstack-nova23:48
*** gianpietro has quit IRC23:49
*** Apoorva_ has joined #openstack-nova23:54
*** Apoorva has quit IRC23:57
*** Apoorva_ has quit IRC23:58
*** catintheroof has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!