| *** winston-d_ has joined #openstack-nova | 00:00 | |
| *** ijw has quit IRC | 00:01 | |
| *** gouthamr has quit IRC | 00:03 | |
| *** jdurgin has quit IRC | 00:04 | |
| openstackgerrit | Sean Dague proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | 00:09 |
|---|---|---|
| *** artom has quit IRC | 00:10 | |
| *** artom has joined #openstack-nova | 00:11 | |
| *** artom has quit IRC | 00:12 | |
| *** artom has joined #openstack-nova | 00:12 | |
| *** Apoorva_ has joined #openstack-nova | 00:12 | |
| *** thorst has quit IRC | 00:12 | |
| *** kaisers has joined #openstack-nova | 00:15 | |
| *** Apoorva has quit IRC | 00:16 | |
| *** Apoorva_ has quit IRC | 00:16 | |
| *** dtp has quit IRC | 00:17 | |
| *** jdurgin has joined #openstack-nova | 00:17 | |
| *** jaypipes has quit IRC | 00:19 | |
| *** slaweq has joined #openstack-nova | 00:21 | |
| *** salv-orlando has quit IRC | 00:22 | |
| *** markvoelker has joined #openstack-nova | 00:25 | |
| *** slaweq has quit IRC | 00:29 | |
| *** MasterOfBugs has quit IRC | 00:37 | |
| *** mriedem has quit IRC | 00:43 | |
| *** jerrygb has joined #openstack-nova | 00:45 | |
| *** zhurong has joined #openstack-nova | 00:50 | |
| *** jerrygb has quit IRC | 00:52 | |
| *** lyan has joined #openstack-nova | 00:53 | |
| *** dimtruck is now known as zz_dimtruck | 00:56 | |
| *** ijw has joined #openstack-nova | 00:58 | |
| *** Sukhdev has joined #openstack-nova | 00:59 | |
| *** dillaman has quit IRC | 01:03 | |
| *** jerrygb has joined #openstack-nova | 01:04 | |
| *** ijw has quit IRC | 01:07 | |
| *** fragatina has quit IRC | 01:08 | |
| *** cNilesh has joined #openstack-nova | 01:11 | |
| *** zz_dimtruck is now known as dimtruck | 01:14 | |
| *** phuongnh has joined #openstack-nova | 01:16 | |
| *** dillaman has joined #openstack-nova | 01:17 | |
| *** salv-orlando has joined #openstack-nova | 01:19 | |
| *** dimtruck is now known as zz_dimtruck | 01:22 | |
| *** Sukhdev has quit IRC | 01:25 | |
| *** thorst has joined #openstack-nova | 01:25 | |
| *** slaweq has joined #openstack-nova | 01:26 | |
| *** Sukhdev has joined #openstack-nova | 01:29 | |
| *** Sukhdev has quit IRC | 01:30 | |
| *** slaweq has quit IRC | 01:31 | |
| *** gcb has joined #openstack-nova | 01:31 | |
| *** gjayavelu has quit IRC | 01:31 | |
| *** thorst has quit IRC | 01:32 | |
| *** sree has joined #openstack-nova | 01:35 | |
| *** kevinz has joined #openstack-nova | 01:38 | |
| *** sree has quit IRC | 01:39 | |
| *** kaisers has quit IRC | 01:40 | |
| *** yingwei has joined #openstack-nova | 01:40 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi v2 in nova https://review.openstack.org/453493 | 01:43 |
| *** j_king has joined #openstack-nova | 01:46 | |
| *** tbachman has quit IRC | 01:46 | |
| *** baoli has joined #openstack-nova | 01:46 | |
| *** Sukhdev has joined #openstack-nova | 01:47 | |
| *** Sukhdev has quit IRC | 01:47 | |
| *** salv-orlando has quit IRC | 01:48 | |
| *** smatzek has joined #openstack-nova | 01:49 | |
| *** zz_dimtruck is now known as dimtruck | 01:50 | |
| *** baoli has quit IRC | 01:50 | |
| *** baoli has joined #openstack-nova | 01:50 | |
| *** kaisers has joined #openstack-nova | 01:53 | |
| *** kaisers has quit IRC | 01:57 | |
| *** awaugama has joined #openstack-nova | 01:58 | |
| *** ssurana has quit IRC | 02:01 | |
| *** ssurana has joined #openstack-nova | 02:01 | |
| *** ssurana has quit IRC | 02:01 | |
| *** smatzek has quit IRC | 02:02 | |
| *** yamahata has quit IRC | 02:03 | |
| *** chatter29 has joined #openstack-nova | 02:04 | |
| chatter29 | hey guys | 02:04 |
| chatter29 | allah is doing | 02:04 |
| *** ijw has joined #openstack-nova | 02:04 | |
| chatter29 | sun is not doing allah is doing | 02:04 |
| chatter29 | to accept Islam say that i bear witness that there is no deity worthy of worship except Allah and Muhammad peace be upon him is his slave and messenger | 02:04 |
| *** thorst has joined #openstack-nova | 02:05 | |
| *** thorst has quit IRC | 02:05 | |
| *** thorst has joined #openstack-nova | 02:05 | |
| *** chatter29 has quit IRC | 02:06 | |
| *** ijw has quit IRC | 02:09 | |
| *** thorst has quit IRC | 02:10 | |
| *** gouthamr has joined #openstack-nova | 02:14 | |
| *** sdague has quit IRC | 02:16 | |
| *** gongysh has joined #openstack-nova | 02:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in servers-action-console-output https://review.openstack.org/458713 | 02:23 |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Add sync traits command for placement https://review.openstack.org/450125 | 02:24 |
| *** hongbin_ has joined #openstack-nova | 02:26 | |
| *** slaweq has joined #openstack-nova | 02:28 | |
| *** gcb has quit IRC | 02:31 | |
| *** slaweq has quit IRC | 02:35 | |
| *** thorst has joined #openstack-nova | 02:36 | |
| *** gcb has joined #openstack-nova | 02:44 | |
| *** gcb has quit IRC | 02:44 | |
| *** salv-orlando has joined #openstack-nova | 02:45 | |
| *** thorst has quit IRC | 02:50 | |
| *** thorst has joined #openstack-nova | 02:50 | |
| *** thorst has quit IRC | 02:50 | |
| *** ijw has joined #openstack-nova | 02:52 | |
| *** kaisers has joined #openstack-nova | 02:54 | |
| *** Shashi has joined #openstack-nova | 02:54 | |
| *** psachin has joined #openstack-nova | 02:57 | |
| *** dikonoor has joined #openstack-nova | 02:57 | |
| *** ijw has quit IRC | 02:58 | |
| *** amotoki has joined #openstack-nova | 02:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Use 'note' directive https://review.openstack.org/458717 | 03:00 |
| *** dillaman has quit IRC | 03:01 | |
| *** salv-orl_ has joined #openstack-nova | 03:03 | |
| *** salv-orlando has quit IRC | 03:03 | |
| *** amotoki has quit IRC | 03:03 | |
| *** takashin has quit IRC | 03:04 | |
| *** winston-d_ has quit IRC | 03:04 | |
| *** winston-d_ has joined #openstack-nova | 03:04 | |
| *** takashin has joined #openstack-nova | 03:04 | |
| *** david-lyle has joined #openstack-nova | 03:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Explicitly define enum type as string in schema https://review.openstack.org/456430 | 03:15 |
| *** salv-orl_ has quit IRC | 03:16 | |
| *** fragatina has joined #openstack-nova | 03:19 | |
| *** david-lyle has quit IRC | 03:19 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321 | 03:21 |
| *** vladikr has quit IRC | 03:24 | |
| *** hongbin_ has quit IRC | 03:25 | |
| *** nicolasbock has quit IRC | 03:28 | |
| *** imacdonn has quit IRC | 03:28 | |
| *** coreywright has quit IRC | 03:28 | |
| *** imacdonn has joined #openstack-nova | 03:29 | |
| *** Sukhdev has joined #openstack-nova | 03:30 | |
| *** slaweq has joined #openstack-nova | 03:32 | |
| *** slaweq has quit IRC | 03:39 | |
| *** kaisers has quit IRC | 03:41 | |
| *** kaisers has joined #openstack-nova | 03:41 | |
| *** zhurong has quit IRC | 03:43 | |
| *** lyan has quit IRC | 03:44 | |
| *** coreywright has joined #openstack-nova | 03:45 | |
| *** ijw has joined #openstack-nova | 03:46 | |
| *** ijw has quit IRC | 03:46 | |
| *** thorst has joined #openstack-nova | 03:51 | |
| *** guchihiro has joined #openstack-nova | 03:54 | |
| *** haplo37 has quit IRC | 03:54 | |
| *** thorst has quit IRC | 03:56 | |
| *** dave-mcc_ has quit IRC | 04:02 | |
| *** haplo37 has joined #openstack-nova | 04:04 | |
| *** kaisers has quit IRC | 04:05 | |
| *** vks1 has joined #openstack-nova | 04:07 | |
| *** amotoki has joined #openstack-nova | 04:09 | |
| *** baoli has quit IRC | 04:09 | |
| *** salv-orlando has joined #openstack-nova | 04:13 | |
| *** gongysh has quit IRC | 04:14 | |
| *** awaugama has quit IRC | 04:15 | |
| *** trinaths has joined #openstack-nova | 04:16 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (2/4) https://review.openstack.org/455568 | 04:19 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (3/4) https://review.openstack.org/455570 | 04:19 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (4/4) https://review.openstack.org/455573 | 04:19 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc https://review.openstack.org/454565 | 04:20 |
| *** yamahata has joined #openstack-nova | 04:24 | |
| *** xyang1_ has joined #openstack-nova | 04:29 | |
| *** xyang1 has quit IRC | 04:32 | |
| *** xyang1_ is now known as xyang1 | 04:32 | |
| *** MasterOfBugs has joined #openstack-nova | 04:33 | |
| *** kristian__ has joined #openstack-nova | 04:34 | |
| *** neilsun has quit IRC | 04:34 | |
| *** slaweq has joined #openstack-nova | 04:35 | |
| *** kristian__ has quit IRC | 04:38 | |
| *** ayogi has joined #openstack-nova | 04:38 | |
| *** salv-orlando has quit IRC | 04:41 | |
| *** udesale has joined #openstack-nova | 04:42 | |
| *** gongysh has joined #openstack-nova | 04:42 | |
| *** adisky_ has joined #openstack-nova | 04:45 | |
| *** salv-orlando has joined #openstack-nova | 04:46 | |
| *** neilsun has joined #openstack-nova | 04:48 | |
| *** armax has quit IRC | 04:50 | |
| *** thorst has joined #openstack-nova | 04:52 | |
| *** thorst has quit IRC | 04:57 | |
| *** kristian__ has joined #openstack-nova | 05:00 | |
| *** kristian__ has quit IRC | 05:00 | |
| *** kristian__ has joined #openstack-nova | 05:00 | |
| *** slaweq has quit IRC | 05:02 | |
| *** ratailor has joined #openstack-nova | 05:05 | |
| *** kristian__ has quit IRC | 05:05 | |
| *** kaisers has joined #openstack-nova | 05:05 | |
| *** dimtruck is now known as zz_dimtruck | 05:09 | |
| *** gongysh has quit IRC | 05:09 | |
| *** baoli has joined #openstack-nova | 05:10 | |
| *** kaisers has quit IRC | 05:10 | |
| *** nkorabli has joined #openstack-nova | 05:15 | |
| *** baoli has quit IRC | 05:15 | |
| *** kristian__ has joined #openstack-nova | 05:17 | |
| *** gcb has joined #openstack-nova | 05:18 | |
| *** kristian__ has quit IRC | 05:22 | |
| *** nkorabli has quit IRC | 05:25 | |
| *** nkorabli has joined #openstack-nova | 05:26 | |
| *** diga has joined #openstack-nova | 05:30 | |
| *** nkorabli has quit IRC | 05:30 | |
| *** prateek has joined #openstack-nova | 05:35 | |
| *** kevinz has quit IRC | 05:38 | |
| *** neilsun has quit IRC | 05:39 | |
| *** lpetrut has joined #openstack-nova | 05:47 | |
| *** hferenc has joined #openstack-nova | 05:48 | |
| *** Sukhdev has quit IRC | 05:48 | |
| *** kylek3h has quit IRC | 05:52 | |
| *** kristian__ has joined #openstack-nova | 05:52 | |
| *** ralonsoh has joined #openstack-nova | 05:52 | |
| *** kylek3h has joined #openstack-nova | 05:52 | |
| *** thorst has joined #openstack-nova | 05:52 | |
| openstackgerrit | Alex Xu proposed openstack/python-novaclient master: Add `instance-uuid` flag to the migration-list https://review.openstack.org/458728 | 05:53 |
| *** kristian__ has quit IRC | 05:57 | |
| *** kylek3h has quit IRC | 05:57 | |
| *** neilsun has joined #openstack-nova | 05:57 | |
| *** thorst has quit IRC | 05:57 | |
| *** slaweq has joined #openstack-nova | 05:59 | |
| *** gongysh has joined #openstack-nova | 05:59 | |
| *** brault has quit IRC | 06:01 | |
| *** brault has joined #openstack-nova | 06:01 | |
| *** sridharg has joined #openstack-nova | 06:02 | |
| Dinesh_Bhor | alex_xu: Hi, if you have time then may I have your attention on this? https://review.openstack.org/#/c/457890/ | 06:02 |
| *** slaweq has quit IRC | 06:04 | |
| *** brault has quit IRC | 06:05 | |
| *** jaosorior has joined #openstack-nova | 06:06 | |
| *** kaisers has joined #openstack-nova | 06:06 | |
| *** Oku_OS-away is now known as Oku_OS | 06:08 | |
| *** sree has joined #openstack-nova | 06:10 | |
| *** salv-orlando has quit IRC | 06:11 | |
| *** salv-orlando has joined #openstack-nova | 06:11 | |
| *** kristian__ has joined #openstack-nova | 06:13 | |
| *** kevinz has joined #openstack-nova | 06:13 | |
| *** rcernin has joined #openstack-nova | 06:15 | |
| *** salv-orlando has quit IRC | 06:16 | |
| *** kristian__ has quit IRC | 06:17 | |
| *** pcaruana has joined #openstack-nova | 06:18 | |
| *** hoonetorg has quit IRC | 06:19 | |
| *** zhurong has joined #openstack-nova | 06:21 | |
| *** tbachman has joined #openstack-nova | 06:25 | |
| *** tbachman has quit IRC | 06:27 | |
| *** kaisers1 has quit IRC | 06:30 | |
| *** phuongnh has quit IRC | 06:30 | |
| *** phuongnh has joined #openstack-nova | 06:31 | |
| *** hoonetorg has joined #openstack-nova | 06:32 | |
| *** voelzmo has joined #openstack-nova | 06:34 | |
| *** lpetrut has quit IRC | 06:37 | |
| *** udesale__ has joined #openstack-nova | 06:37 | |
| *** gouthamr has quit IRC | 06:39 | |
| *** zhurong has quit IRC | 06:39 | |
| *** satyar has joined #openstack-nova | 06:39 | |
| *** sridharg has quit IRC | 06:40 | |
| *** udesale has quit IRC | 06:40 | |
| *** kaisers1 has joined #openstack-nova | 06:41 | |
| *** ltomasbo|away is now known as ltomasbo | 06:42 | |
| *** zhurong has joined #openstack-nova | 06:42 | |
| *** gcb has quit IRC | 06:42 | |
| *** kristian__ has joined #openstack-nova | 06:43 | |
| *** kristian__ has quit IRC | 06:47 | |
| *** andreas_s has joined #openstack-nova | 06:47 | |
| *** ralonsoh_ has joined #openstack-nova | 06:49 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321 | 06:49 |
| *** ralonsoh_ has quit IRC | 06:51 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Deprecate Multinic, floatingip action and os-virtual-interface API https://review.openstack.org/457181 | 06:51 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Move all the deprecated server actions together into the bottom of doc https://review.openstack.org/458738 | 06:51 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Adjust the order of server actions in api-ref https://review.openstack.org/458739 | 06:51 |
| *** ralonsoh has quit IRC | 06:51 | |
| *** kylek3h has joined #openstack-nova | 06:53 | |
| *** thorst has joined #openstack-nova | 06:53 | |
| *** zhurong has quit IRC | 06:54 | |
| *** gcb has joined #openstack-nova | 06:56 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add description to policies in hypervisors.py https://review.openstack.org/451294 | 06:58 |
| *** kylek3h has quit IRC | 06:58 | |
| *** thorst has quit IRC | 06:58 | |
| *** ralonsoh has joined #openstack-nova | 06:59 | |
| *** slaweq has joined #openstack-nova | 07:00 | |
| *** salv-orlando has joined #openstack-nova | 07:01 | |
| *** markus_z has joined #openstack-nova | 07:01 | |
| *** MasterOfBugs has quit IRC | 07:09 | |
| *** tesseract has joined #openstack-nova | 07:11 | |
| *** baoli has joined #openstack-nova | 07:11 | |
| alex_xu | johnthetubaguy: how about rename all of those titles in api-ref as URL, for example https://developer.openstack.org/api-ref/compute/#servers-run-an-action-servers-action rename to '/servers/{server_uuid}/action' | 07:12 |
| *** guchihiro has quit IRC | 07:12 | |
| *** baoli has quit IRC | 07:16 | |
| *** rmart04 has joined #openstack-nova | 07:18 | |
| *** gongysh has quit IRC | 07:18 | |
| *** trinaths has left #openstack-nova | 07:19 | |
| *** kaisers has quit IRC | 07:20 | |
| *** mlakat has joined #openstack-nova | 07:23 | |
| *** udesale has joined #openstack-nova | 07:24 | |
| *** udesale__ has quit IRC | 07:26 | |
| *** kristian__ has joined #openstack-nova | 07:27 | |
| *** mkrai_ has joined #openstack-nova | 07:29 | |
| *** zhurong has joined #openstack-nova | 07:31 | |
| *** kristian__ has quit IRC | 07:32 | |
| *** sridharg has joined #openstack-nova | 07:32 | |
| *** damien_r has joined #openstack-nova | 07:32 | |
| *** sree has quit IRC | 07:33 | |
| *** sree has joined #openstack-nova | 07:34 | |
| *** sree has quit IRC | 07:36 | |
| *** jpena|off is now known as jpena | 07:39 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: WIP: Specify keymap on server boot (1/2) https://review.openstack.org/458752 | 07:48 |
| *** kristian__ has joined #openstack-nova | 07:48 | |
| *** Shunli has joined #openstack-nova | 07:51 | |
| *** kristian__ has quit IRC | 07:52 | |
| *** kylek3h has joined #openstack-nova | 07:54 | |
| *** thorst has joined #openstack-nova | 07:54 | |
| johnthetubaguy | alex_xu: I was thinking about those when I was going through your patches yesterday... | 07:55 |
| johnthetubaguy | alex_xu: I think we probably should reorganise based around the URL patterns, maybe we should etherpad out some possible ways to arrange those | 07:55 |
| *** phuongnh has quit IRC | 07:56 | |
| johnthetubaguy | alex_xu: https://etherpad.openstack.org/p/nova-api-ref-organisation | 07:56 |
| *** slaweq has quit IRC | 07:58 | |
| *** kylek3h has quit IRC | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** slaweq has joined #openstack-nova | 08:01 | |
| *** takashin has left #openstack-nova | 08:02 | |
| johnthetubaguy | alex_xu: I take that back, its basically there | 08:03 |
| *** lucas-afk is now known as lucasagomes | 08:07 | |
| *** gongysh has joined #openstack-nova | 08:09 | |
| *** jerrygb_ has joined #openstack-nova | 08:11 | |
| *** jerrygb has quit IRC | 08:11 | |
| *** derekh has joined #openstack-nova | 08:12 | |
| *** gouthamr has joined #openstack-nova | 08:13 | |
| *** rcernin has quit IRC | 08:13 | |
| *** thorst has quit IRC | 08:14 | |
| *** zhurong has quit IRC | 08:15 | |
| *** kaisers has joined #openstack-nova | 08:16 | |
| *** efoley_ has joined #openstack-nova | 08:16 | |
| *** slaweq has quit IRC | 08:17 | |
| *** slaweq has joined #openstack-nova | 08:17 | |
| *** efoley__ has joined #openstack-nova | 08:18 | |
| *** slaweq has quit IRC | 08:19 | |
| *** slaweq_ has joined #openstack-nova | 08:19 | |
| *** jerrygb_ has quit IRC | 08:21 | |
| *** efoley_ has quit IRC | 08:21 | |
| *** zhurong has joined #openstack-nova | 08:22 | |
| *** gouthamr has quit IRC | 08:22 | |
| *** jerrygb has joined #openstack-nova | 08:22 | |
| sfinucan | cfriesen: I am now | 08:23 |
| *** karimb has joined #openstack-nova | 08:23 | |
| *** kristian__ has joined #openstack-nova | 08:24 | |
| *** brault has joined #openstack-nova | 08:27 | |
| *** rcernin has joined #openstack-nova | 08:27 | |
| *** ralonsoh has quit IRC | 08:30 | |
| *** ralonsoh has joined #openstack-nova | 08:32 | |
| mdbooth | imacdonn lyarwood: https://bugs.launchpad.net/os-brick/+bug/1664032 | 08:36 |
| openstack | Launchpad bug 1664032 in os-brick "iSCSI Multipath may leave residual paths due to race condition" [Undecided,Fix released] - Assigned to Gorka Eguileor (gorka) | 08:36 |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Don't create instance backup image if rotation is 0 https://review.openstack.org/409644 | 08:37 |
| lyarwood | mdbooth: nice, so limiting the rescans would help for iSCSI but I wonder how many other backends could still race? | 08:39 |
| mdbooth | lyarwood: Well the issue is peculiar to a global rescan | 08:40 |
| mdbooth | lyarwood johnthetubaguy: While I was thinking about this, though, a couple of things occurred to me | 08:40 |
| mdbooth | Namely that os-brick probably should explicitly know about terminate connection | 08:41 |
| mdbooth | And that the required scope of locks is always going be be driver-specific | 08:41 |
| johnthetubaguy | it does feel like we need to have a more well understood relationship with os-brick | 08:41 |
| johnthetubaguy | I like the idea of negotiation about locking | 08:42 |
| lyarwood | well, terminate connection no longer exists in v3 | 08:42 |
| mdbooth | lyarwood: The function exists, though | 08:42 |
| mdbooth | Delete attachment, presumably? | 08:42 |
| *** kristian__ has quit IRC | 08:42 | |
| lyarwood | right, but that's terminate connection and detach | 08:43 |
| lyarwood | in v2 | 08:43 |
| *** kristian__ has joined #openstack-nova | 08:43 | |
| *** cdent has joined #openstack-nova | 08:44 | |
| mdbooth | johnthetubaguy: The problem with having differing scope of locks is that it's hard to represent that across an api boundary | 08:44 |
| mdbooth | I mean, if backend A requires X to be serialised only with itself, backend B requires X and Y to be serialised, and backend C has no such restrictions | 08:45 |
| mdbooth | How do you abstract that for the caller? | 08:45 |
| *** kristia__ has joined #openstack-nova | 08:45 | |
| *** kristia__ has quit IRC | 08:45 | |
| mdbooth | I think the locking would need to live in the backend | 08:46 |
| *** kristia__ has joined #openstack-nova | 08:46 | |
| *** kristia__ has quit IRC | 08:46 | |
| *** kristian__ has quit IRC | 08:46 | |
| asettle | cdent: you around? :) | 08:46 |
| *** kristian__ has joined #openstack-nova | 08:46 | |
| *** kristian__ has quit IRC | 08:46 | |
| cdent | asettle: I just showed up, what's up? | 08:46 |
| *** kristian__ has joined #openstack-nova | 08:46 | |
| asettle | Magic@ | 08:46 |
| asettle | Placement API :( | 08:47 |
| *** kristian__ has quit IRC | 08:47 | |
| asettle | Any chance you could take a look at this bug to help out Brian and myself? https://bugs.launchpad.net/openstack-manuals/+bug/1683585 | 08:47 |
| openstack | Launchpad bug 1683585 in openstack-manuals "Placement endpoint configuration incorrect as written" [Undecided,New] - Assigned to Brian Moss (bmoss) | 08:47 |
| * cdent looks | 08:47 | |
| lyarwood | mdbooth: so just serialise all volume operations (both local n-cpu and remote via c-api) for all backends? | 08:48 |
| mdbooth | lyarwood: You could do that, but that's a big hammer | 08:48 |
| mdbooth | Akin to a GIL ;) | 08:48 |
| lyarwood | GBDML | 08:49 |
| cdent | asettle: ah, that. Yeah, so the issue is that there hasn't been consensus between nova, devstack, deb packagers, rpm packages on "where" placement is supposed to live | 08:49 |
| mdbooth | hehe | 08:49 |
| lyarwood | but yeah, massive hammer, slows everything down | 08:49 |
| asettle | cdent: yep. Which is causing issues, it's our second bug of the same nature. We're going to have to chat about reversing it, I think. IT's just not working. | 08:49 |
| cdent | asettle: I would guess that what needs to happen is find out from the packages where they are putting it (it can go wherever they like), and make the docs reflect that | 08:49 |
| cdent | s/packages/packagers/ | 08:49 |
| mdbooth | Suspect the problem would mostly be that 1 slow/malfunctioning thing would kill everything | 08:50 |
| cdent | asettle: I can reflect this on the bug report too | 08:50 |
| asettle | cdent: who can we get to sort out the packaging then? | 08:50 |
| *** afazekas has quit IRC | 08:50 | |
| *** gongysh has quit IRC | 08:51 | |
| cdent | asettle: I don't have the names at the top of my head. johnthetubaguy and mdbooth you know who the contacts are for ubuntu and rdo packages? | 08:51 |
| mdbooth | lyarwood: ^^^ ? | 08:51 |
| *** gszasz has joined #openstack-nova | 08:52 | |
| * mdbooth reads the bug | 08:52 | |
| mdbooth | cdent: You looking for a default port number? | 08:53 |
| cdent | mdbooth: no | 08:54 |
| cdent | looking for agreement between the various parties on where it will be placed, or at least authoritative statements on how things are current configured | 08:54 |
| asettle | cdent: thanks for looking into it. Contextually, could you please explain to me why this was implemented without consensus? Am I msising something? :/ | 08:55 |
| *** kylek3h has joined #openstack-nova | 08:55 | |
| cdent | hmmm | 08:55 |
| mdbooth | cdent: Being dim, just trying to understand what 'where' means in this context. | 08:55 |
| cdent | I'm pretty sure that the rpm and debs use the same port. | 08:55 |
| mdbooth | where == port number? | 08:55 |
| asettle | Okay, well, that's good? | 08:55 |
| alex_xu | johnthetubaguy: yea, agree with that. begin to do some cleanup https://review.openstack.org/458738 https://review.openstack.org/458739 | 08:56 |
| bauzas | asettle: mmm I do remember a problem with RDO packaging for the above bug, sec | 08:56 |
| cdent | The issue entered into the discussion because there is a movement to stop using ports for hosting each of the individual services and instead put them on default http (80) or https (443) ports on the same controller host, distinguishing between services by a path prefix | 08:57 |
| asettle | bauzas: The same issue we were fiddling with a few weeks back? | 08:57 |
| bauzas | not using ports means you have to have your virtualhost able to accept on this location | 08:57 |
| openstackgerrit | jichenjc proposed openstack/nova master: [placement] Add doc for resource provider usages https://review.openstack.org/450105 | 08:57 |
| *** amotoki has quit IRC | 08:57 | |
| cdent | asettle, bauzas: there have been a few different bugs related to the configuration, for example, needing <Directory> | 08:57 |
| bauzas | cdent: yup, AFAIR, it was related to that | 08:58 |
| asettle | Okay. | 08:58 |
| bauzas | I just have a shit ton of BZs to look at | 08:58 |
| cdent | asettle: I commented about those prefixes on the reviews, but it wasn't meant as a way of saying "do this", but rather as a way of saying "we should be moving in this direction, eventually" | 08:58 |
| bauzas | a-ha! think I found it | 08:58 |
| cdent | (like a warning of future change) | 08:59 |
| bauzas | cdent: asettle: Red Hat Bugzilla – Bug 1434944 | 08:59 |
| bauzas | oops | 08:59 |
| bauzas | https://bugzilla.redhat.com/show_bug.cgi?id=1434944 | 08:59 |
| openstack | bugzilla.redhat.com bug 1434944 in openstack-nova "[Ocata] openstack-nova-placement-api-15.0.0-1.el7.noarch missing <Directory> parameter" [Medium,Assigned] - Assigned to sferdjao | 08:59 |
| *** kylek3h has quit IRC | 08:59 | |
| asettle | I always liked the name 'bugzilla' | 08:59 |
| asettle | cdent: okay, thanks, that's a start :) | 08:59 |
| asettle | Ah, this was after I pushed sgordon with a stick | 09:00 |
| bauzas | asettle: indeed :) | 09:00 |
| * asettle waves her stick saround | 09:00 | |
| bauzas | that came back to my ears a week or so ago | 09:00 |
| asettle | Thanks for finding this, bauzas | 09:00 |
| asettle | Okay, looks like Petr is on this. | 09:01 |
| bauzas | so I'd say the problem is on track for RDO, fix needs to go on its way | 09:01 |
| cdent | bauzas: this issue is different: it is making sure that the docs are aligned with the rdo config | 09:01 |
| bauzas | asettle: FWIW, Red Hat product-based OpenStack Platform is not impacted because we use TripleO | 09:01 |
| *** aarefiev_afk is now known as aarefiev | 09:02 | |
| cdent | the directory thing causes a different issue | 09:02 |
| bauzas | asettle: where Puppet nukes that file and replaces by a correct config | 09:02 |
| * asettle nods a lot | 09:02 | |
| asettle | Okay | 09:02 |
| bauzas | cdent: probably, have very few context | 09:02 |
| bauzas | cdent: just saying that RDO .rpms aren't working anyway | 09:02 |
| cdent | here's another semi-related thing the other day that I made: https://bugzilla.redhat.com/show_bug.cgi?id=1441200 | 09:02 |
| openstack | bugzilla.redhat.com bug 1441200 in openstack-nova "openstack-placement-api.conf not configured properly by the openstack-nova-placement-api rpm" [Unspecified,Post] - Assigned to nlevinki | 09:02 |
| cdent | sorry, I mean this one: https://bugzilla.redhat.com/show_bug.cgi?id=1441208 | 09:03 |
| openstack | bugzilla.redhat.com bug 1441208 in openstack-nova "placement api apache configuration does not align with documentation, ensure system does not work" [High,Closed: duplicate] - Assigned to nlevinki | 09:03 |
| bauzas | cdent: BZ1441200 points to the same fix for RDO than 1434944 for resolution | 09:03 |
| cdent | the first one is a duplicate of the one I created, mine has more context | 09:03 |
| cdent | bauzas: I'm providing these so asettle has context, which is what was asked for, not to find the right bug | 09:04 |
| asettle | Yep, context me ahoy. | 09:04 |
| asettle | Thanks cdent | 09:04 |
| bauzas | cdent: np, just trying to understand the missing bits and the resolution path | 09:04 |
| cdent | asettle: in my bug report there are a lot of lurking "warnings" | 09:05 |
| bauzas | anyway, seems like the RDO fix needs to be aligned with docs, or the other way | 09:06 |
| bauzas | since both are pulling on two different directions | 09:06 |
| asettle | I completely agree. | 09:07 |
| *** abalutoiu_ is now known as abalutoiu | 09:07 | |
| bauzas | but FWIW, whatever lands in RDO needs to properly amend the upstream docs, I do agree | 09:07 |
| bauzas | if those docs become wrong of course | 09:07 |
| asettle | Provided we're not going to have substantially broken docs for another month, I'm happy to do what we need to do. | 09:07 |
| *** amotoki has joined #openstack-nova | 09:08 | |
| *** sambetts|afk is now known as sambetts | 09:08 | |
| *** djohnsto has joined #openstack-nova | 09:08 | |
| bauzas | asettle: cdent: we have an internal bug triaging meeting today, will raise it up | 09:10 |
| cdent | bauzas++ | 09:11 |
| asettle | Thank you bauzas :) | 09:11 |
| asettle | Could you keep us up to date on the launchpad bug if I'm not around? | 09:11 |
| bauzas | we = Nova team in Red Hat, not RDO team | 09:11 |
| asettle | I mean, I'm sure I will be :( | 09:11 |
| bauzas | asettle: that's at 1400UTC | 09:12 |
| asettle | Lovely. Just in time for tea. | 09:12 |
| cdent | asettle: I think it is pretty clear that the communication for "how to do placement" went awry to many parties over the past... six months? So we can probably do some kind of retrospective or something to figure out what to do better in the future. From my standpoint I didn't have enough insight into the process and made too many assumptions about it being under control | 09:12 |
| bauzas | cdent: well, mostly because that's deployment choices | 09:13 |
| *** brault has quit IRC | 09:14 | |
| bauzas | cdent: so that's hard to find a common denominator for all | 09:14 |
| *** baoli has joined #openstack-nova | 09:14 | |
| bauzas | and we all say that Service Catalog serves the purpose to enable services the way you want | 09:14 |
| *** brault has joined #openstack-nova | 09:14 | |
| cdent | bauzas: sure, but I think there's been a lot of confusion that we could have made less of a problem. The <Directory> thing, for example, seems like something that never should have happened because when that's wrong things simply don't work. | 09:14 |
| bauzas | so, you, as a deployer, just needs to make consistent what you have in your service catalog entry and what you configure server-side | 09:15 |
| asettle | cdent: thanks for your honesty. What can I do to help? | 09:15 |
| bauzas | cdent: the port discussion clearly showed up that a lot people were having wrong expectations | 09:16 |
| bauzas | the fact that the service catalog exists is for the exact reason that you can provide any endpoint you want | 09:16 |
| bauzas | this is not aimed to be consistent across all openstack deployments | 09:16 |
| cdent | bauzas: yes, I know, I'm not suggesting we change any of that. but the docs process has been more fraught with error than it should have been. we should figure out why and try to make it better | 09:17 |
| cdent | asettle: will you be in boston? | 09:17 |
| bauzas | and application developers wanting to integrate with APIs need to use the Service Catalog as the discovery system | 09:17 |
| asettle | cdent: sure will be. You? | 09:17 |
| cdent | yup, we should gather and chat | 09:18 |
| bauzas | cdent: sure, I guess that's the crux of providing upstream documentation that sets kind of de-facto standard | 09:18 |
| *** baoli has quit IRC | 09:18 | |
| *** huanxie has quit IRC | 09:18 | |
| *** huanxie has joined #openstack-nova | 09:18 | |
| asettle | Okay, let's aim for that. I've got a shitty tight schedule Mon - Wed with updates and all that jazz. | 09:19 |
| *** brault has quit IRC | 09:19 | |
| asettle | But I'm there until Friday :) | 09:19 |
| *** claudiub|2 has joined #openstack-nova | 09:19 | |
| asettle | bauzas: you gonna be there? | 09:19 |
| bauzas | yup | 09:20 |
| bauzas | we have a couple of sessions around placement | 09:20 |
| asettle | Lucky meeee | 09:20 |
| bauzas | both in the Forum and the conference itself | 09:20 |
| bauzas | like, jay (pipes) has 2 sessions for talking $placement, one targeted for users and architects, the other more for devs | 09:21 |
| asettle | Well, it should be interesting. | 09:21 |
| bauzas | 2 talks | 09:21 |
| asettle | Okay. Well. I'll try and make sure I get along to some of them. I'm a bit of a lone wolf this summit. | 09:21 |
| *** litao has joined #openstack-nova | 09:24 | |
| *** kaisers has quit IRC | 09:27 | |
| *** amotoki has quit IRC | 09:30 | |
| *** kiwi_rot has joined #openstack-nova | 09:31 | |
| *** zhurong has quit IRC | 09:33 | |
| openstackgerrit | fengzhr proposed openstack/nova master: Modify the description of flat_injected in nova.conf https://review.openstack.org/458789 | 09:33 |
| *** amotoki has joined #openstack-nova | 09:33 | |
| frickler | it seems that the scheduler docs are outdated, can anyone confirm that it should mention e.g. filter_scheduler.enabled_filters instead of scheduler_default_filters here? https://docs.openstack.org/ocata/config-reference/compute/schedulers.html | 09:35 |
| frickler | I'm also struggling to get scheduling to a specific az to work with Ocata, are there known issues? | 09:35 |
| *** gouthamr has joined #openstack-nova | 09:35 | |
| *** zhurong has joined #openstack-nova | 09:36 | |
| *** ralonsoh has quit IRC | 09:36 | |
| *** brault has joined #openstack-nova | 09:37 | |
| *** zhurong has quit IRC | 09:38 | |
| *** ralonsoh has joined #openstack-nova | 09:38 | |
| frickler | bauzas: cdent: regarding deployment of placement-api, are end users supposed to talk to it or would it rather be for admins/operators only? i.e. do I really need to deploy a public endpoint for it or would I rather only do an internal one? | 09:39 |
| cdent | frickler: it is admin _for now_ but the expectation is that might change in the future, as having dashboard views over one's own usage is expected | 09:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure https://review.openstack.org/442105 | 09:42 |
| frickler | cdent: ah, that is a good point, so a public endpoint will make sense in the long run. | 09:42 |
| cdent | frickler: another one of the things that might happen in the future warnings (like described above with asettle) is that the preference is for interface type to notmatter | 09:42 |
| cdent | but that's a long way off | 09:42 |
| *** Shunli has quit IRC | 09:44 | |
| *** gouthamr has quit IRC | 09:44 | |
| asettle | Hey cdent since you're loving doc nova bugs, want another one? :D | 09:46 |
| cdent | asettle: I can certainly look, but I'm making no promises | 09:46 |
| * asettle claps | 09:46 | |
| asettle | Hooray! | 09:46 |
| asettle | :p thanks | 09:46 |
| asettle | https://bugs.launchpad.net/openstack-manuals/+bug/1683104 | 09:46 |
| openstack | Launchpad bug 1683104 in openstack-manuals "instance is not created rightly" [Undecided,New] | 09:46 |
| asettle | I'm not convinced of this one, let's put it that way | 09:47 |
| asettle | But, my nova deep dive konwledge is bad :( | 09:47 |
| cdent | mine too! | 09:48 |
| * cdent looks | 09:48 | |
| *** salv-orl_ has joined #openstack-nova | 09:48 | |
| cdent | asettle: heh, interesting. their solution works but is undesirable :) | 09:49 |
| * cdent leaves some note | 09:49 | |
| cdent | s | 09:49 |
| asettle | cdent: I guess my real concern is whether or not what we have is going to work or not. | 09:50 |
| *** dixiaoli has joined #openstack-nova | 09:50 | |
| *** afazekas has joined #openstack-nova | 09:50 | |
| cdent | asettle: while the apache configuration is incorrect things will not work and the bugs that cascade from that will be various | 09:51 |
| asettle | -.- | 09:51 |
| cdent | the original cause of this person's problem is that their apache config is wrong and they have worked around it by not using apache at all for the placement service | 09:51 |
| *** salv-orlando has quit IRC | 09:51 | |
| asettle | Well, that's info I can work with. | 09:52 |
| asettle | Okay. | 09:52 |
| asettle | Thanks cdent. I can reply to the reporter with that :) | 09:52 |
| asettle | Unless you've already said something? | 09:52 |
| cdent | I've started something, yeah, but haven't finished it yet | 09:52 |
| asettle | Okay :) tahnks cdent I appreciate this | 09:52 |
| *** psachin has quit IRC | 09:54 | |
| *** kylek3h has joined #openstack-nova | 09:56 | |
| cdent | asettle: I left a comment but more might be needed | 09:56 |
| asettle | cdent: lgtm. | 09:59 |
| * asettle clicks *invalid* | 09:59 | |
| *** dixiaoli has quit IRC | 09:59 | |
| asettle | Thanks again :) | 09:59 |
| *** kylek3h has quit IRC | 10:00 | |
| cdent | asettle: you're very welcome | 10:00 |
| asettle | I owe you and bauzas a drink | 10:00 |
| *** cNilesh has quit IRC | 10:01 | |
| *** Guest86170 has quit IRC | 10:02 | |
| *** satyar has quit IRC | 10:03 | |
| *** cNilesh has joined #openstack-nova | 10:04 | |
| *** cNilesh has quit IRC | 10:05 | |
| *** cNilesh has joined #openstack-nova | 10:05 | |
| *** amotoki has quit IRC | 10:05 | |
| *** damien_r has quit IRC | 10:06 | |
| *** kevinz has quit IRC | 10:07 | |
| *** brault has quit IRC | 10:10 | |
| *** thorst has joined #openstack-nova | 10:11 | |
| *** Guest86170 has joined #openstack-nova | 10:14 | |
| *** baoli has joined #openstack-nova | 10:15 | |
| *** nicolasbock has joined #openstack-nova | 10:15 | |
| *** bhagyashris has quit IRC | 10:16 | |
| *** thorst has quit IRC | 10:16 | |
| *** baoli has quit IRC | 10:19 | |
| *** psachin has joined #openstack-nova | 10:21 | |
| *** ralonsoh has quit IRC | 10:23 | |
| *** kaisers has joined #openstack-nova | 10:23 | |
| *** yamamoto has quit IRC | 10:25 | |
| *** Shashi has quit IRC | 10:26 | |
| *** slaweq_ has quit IRC | 10:34 | |
| *** brault has joined #openstack-nova | 10:34 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805 | 10:34 |
| *** slaweq has joined #openstack-nova | 10:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 10:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | 10:37 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | 10:37 |
| *** slaweq has quit IRC | 10:39 | |
| *** brault has quit IRC | 10:39 | |
| *** ralonsoh has joined #openstack-nova | 10:42 | |
| *** cNilesh has quit IRC | 10:43 | |
| *** smatzek has joined #openstack-nova | 10:44 | |
| *** cdent has quit IRC | 10:45 | |
| *** shaner has quit IRC | 10:52 | |
| *** shaner has joined #openstack-nova | 10:53 | |
| *** udesale has quit IRC | 10:53 | |
| *** phuongnh has joined #openstack-nova | 10:56 | |
| *** kylek3h has joined #openstack-nova | 10:56 | |
| *** djohnsto has quit IRC | 10:58 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 10:59 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | 10:59 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: add tags field to instance.update notification https://review.openstack.org/407228 | 10:59 |
| *** trinaths has joined #openstack-nova | 11:00 | |
| *** yamahata has quit IRC | 11:00 | |
| *** kylek3h has quit IRC | 11:01 | |
| *** phuongnh has quit IRC | 11:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807 | 11:11 |
| *** vks1 has quit IRC | 11:12 | |
| *** markvoelker has quit IRC | 11:14 | |
| *** baoli has joined #openstack-nova | 11:15 | |
| *** cdent has joined #openstack-nova | 11:16 | |
| *** zenoway has joined #openstack-nova | 11:17 | |
| *** Shunli has joined #openstack-nova | 11:18 | |
| *** Shunli has quit IRC | 11:18 | |
| *** phuongnh has joined #openstack-nova | 11:19 | |
| *** baoli has quit IRC | 11:20 | |
| *** phuongnh has quit IRC | 11:21 | |
| *** thorst has joined #openstack-nova | 11:25 | |
| *** lucasagomes is now known as lucas-afk | 11:25 | |
| ralonsoh | sfinucan: hi | 11:26 |
| *** slaweq has joined #openstack-nova | 11:26 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807 | 11:29 |
| *** vladikr has joined #openstack-nova | 11:31 | |
| *** yamamoto has joined #openstack-nova | 11:33 | |
| lyarwood | kashyap, mdbooth ; ^ hopefully a straight forward bugfix for review if you have anytime this afternoon | 11:33 |
| kashyap | lyarwood: Yeah, will look after lunch | 11:35 |
| *** yamamoto has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-nova | 11:39 | |
| *** dillaman has joined #openstack-nova | 11:40 | |
| *** salv-orl_ has quit IRC | 11:40 | |
| *** ratailor has quit IRC | 11:45 | |
| *** sree has joined #openstack-nova | 11:45 | |
| *** slaweq has quit IRC | 11:45 | |
| *** slaweq has joined #openstack-nova | 11:46 | |
| *** slaweq has quit IRC | 11:51 | |
| *** lyan has joined #openstack-nova | 11:51 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** prateek has quit IRC | 11:52 | |
| *** satyar has joined #openstack-nova | 11:54 | |
| *** sdague has joined #openstack-nova | 11:54 | |
| *** rmart04 has quit IRC | 11:54 | |
| *** lpetrut has joined #openstack-nova | 11:55 | |
| *** jpena is now known as jpena|lunch | 11:55 | |
| *** lyan has quit IRC | 11:56 | |
| *** ebbex has joined #openstack-nova | 11:57 | |
| *** kaisers has quit IRC | 11:57 | |
| *** kylek3h has joined #openstack-nova | 11:57 | |
| openstackgerrit | Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710 | 11:57 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | 11:59 |
| *** baoli has joined #openstack-nova | 11:59 | |
| *** brault has joined #openstack-nova | 12:01 | |
| *** kylek3h has quit IRC | 12:02 | |
| *** neilsun has quit IRC | 12:02 | |
| *** baoli has quit IRC | 12:03 | |
| *** jaypipes has joined #openstack-nova | 12:04 | |
| *** jaypipes is now known as leakypipes | 12:04 | |
| *** litao has quit IRC | 12:09 | |
| sfinucan | ralonsoh: Hey | 12:10 |
| sfinucan | Sorry - just back from lunch | 12:10 |
| *** baoli has joined #openstack-nova | 12:11 | |
| *** baoli has quit IRC | 12:12 | |
| *** jaosorior is now known as jaosorior_away | 12:12 | |
| *** markvoelker has joined #openstack-nova | 12:15 | |
| ralonsoh | sfinucan, me too | 12:17 |
| ralonsoh | sfinucan, it's about https://review.openstack.org/#/c/427145/ | 12:17 |
| *** salv-orlando has joined #openstack-nova | 12:17 | |
| ralonsoh | sfinucan: don't you think optimizing this function (and adding a tool for future optimizations) worth the effort? | 12:18 |
| *** markvoelker has quit IRC | 12:20 | |
| *** damien_r has joined #openstack-nova | 12:20 | |
| *** ayogi has quit IRC | 12:21 | |
| sfinucan | ralonsoh: not really, no | 12:23 |
| sfinucan | I mean, we're saving a fraction of a fraction of a second per instance boot | 12:23 |
| *** markmc` has joined #openstack-nova | 12:23 | |
| sfinucan | and that's a not insignificant chunk of code to do so | 12:24 |
| ralonsoh | sfinucan: I know, but the point is this function should have been done like this | 12:24 |
| sfinucan | ralonsoh: Would there be any real world improvements by doing that? | 12:24 |
| ralonsoh | sfinucan: and the biggest part of this code is a function useful for other possible optimizations | 12:25 |
| *** markmc has quit IRC | 12:25 | |
| *** ltomasbo has quit IRC | 12:25 | |
| *** jpena|lunch has quit IRC | 12:25 | |
| *** dmellado has quit IRC | 12:26 | |
| *** lucas-afk is now known as lucasagomes | 12:26 | |
| sfinucan | and if they yield more significant results, I'd be happy to reassess that :) | 12:27 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | 12:27 |
| *** zenoway has quit IRC | 12:27 | |
| *** zenoway has joined #openstack-nova | 12:27 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Fix races with nfs volume mount/umount https://review.openstack.org/383859 | 12:28 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Pass instance to connect_volume and disconnect_volume https://review.openstack.org/450383 | 12:28 |
| mdbooth | sfinucan johnthetubaguy: ^^^ also rebases those 2 commits, btw, but the only change is an additional comment in test_mount.py. | 12:28 |
| sfinucan | ralonsoh: That whole section of the code could do with being examined closer for larger optimizations, particularly wrt integration with resource providers | 12:30 |
| *** diga has quit IRC | 12:30 | |
| *** lyan has joined #openstack-nova | 12:31 | |
| sfinucan | jaypipes would be able to provide more info, but iirc the PCI tracker model doesn't integrate into the resource providers model very well. Lots of opportunities for larger optimizations there | 12:31 |
| sfinucan | mdbooth: Cool. Looking now | 12:32 |
| ralonsoh | sfinucan: I'll talk to jaypipes | 12:33 |
| ralonsoh | sfinucan: I'll see if we can optimize the code related to resource providers | 12:34 |
| ralonsoh | sfinucan, thank you! | 12:34 |
| sfinucan | ralonsoh: Definitely. I'm sure Jay would be ecstatic to have someone working on that :) | 12:35 |
| *** sree has quit IRC | 12:35 | |
| *** zenoway has quit IRC | 12:36 | |
| *** zenoway has joined #openstack-nova | 12:37 | |
| *** david_1 has joined #openstack-nova | 12:37 | |
| efried | sdague Thanks for watching the PowerVM changes :) | 12:37 |
| *** brault has quit IRC | 12:38 | |
| *** jpena has joined #openstack-nova | 12:38 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 12:38 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 12:39 |
| sfinucan | mdbooth: done and done. Thanks for addressing that small comment | 12:39 |
| *** markvoelker has joined #openstack-nova | 12:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 12:40 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 12:41 |
| *** markmc` has quit IRC | 12:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: WIP: Specify keymap on server boot (1/2) https://review.openstack.org/458752 | 12:41 |
| efried | sdague ^^ Rebased up through "SSP ephemeral disk support". | 12:41 |
| leakypipes | ralonsoh: hey, I'm here :) | 12:41 |
| *** zenoway has quit IRC | 12:42 | |
| sfinucan | oops | 12:42 |
| * sfinucan wishes IRC did nick aliasing | 12:42 | |
| ralonsoh | leakypipes: I was talking to Stephen about a patch I submitted https://review.openstack.org/#/c/427145/ | 12:42 |
| ralonsoh | leakypipes: it's an small optimization. The point is if the memoize function could be useful to store in cache and optimize some parts of resourde providers | 12:43 |
| sdague | efried: ok, cool, I'll back through them in a minute | 12:43 |
| efried | sdague Awesome. | 12:43 |
| ralonsoh | leakypipes: let me know if you know any interesting place to use it | 12:43 |
| *** edleafe is now known as figleaf | 12:44 | |
| johnthetubaguy | sfinucan: +1 | 12:44 |
| *** rmart04 has joined #openstack-nova | 12:44 | |
| leakypipes | ralonsoh: will do. :) | 12:45 |
| *** gcb has quit IRC | 12:45 | |
| zioproto | dansmith: I have been in meetings the all day... later I hope to find time to clean that broken database we have seen yesterday, I will keep you updated | 12:45 |
| ralonsoh | leakypipes: thanks! | 12:45 |
| *** markmc has joined #openstack-nova | 12:46 | |
| *** kylek3h has joined #openstack-nova | 12:46 | |
| *** zenoway has joined #openstack-nova | 12:47 | |
| *** slaweq has joined #openstack-nova | 12:47 | |
| *** yingwei has quit IRC | 12:47 | |
| *** dmellado has joined #openstack-nova | 12:47 | |
| *** ltomasbo has joined #openstack-nova | 12:49 | |
| *** adisky_ has quit IRC | 12:49 | |
| *** zenoway has quit IRC | 12:50 | |
| *** zenoway has joined #openstack-nova | 12:50 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514 | 12:52 |
| openstackgerrit | sahid proposed openstack/nova master: network: add command to configure trusted mode for VFs https://review.openstack.org/458513 | 12:52 |
| openstackgerrit | sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820 | 12:52 |
| *** kaisers has joined #openstack-nova | 12:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807 | 12:53 |
| lyarwood | mdbooth: posted some comments in the change, basically I was going to follow up with another change for resize failures as we can't just disconnect the new volume at that point. | 12:54 |
| sdague | efried: there is an oslo_utils method for something in patch #4 | 12:56 |
| *** efried has quit IRC | 12:57 | |
| *** yamamoto has joined #openstack-nova | 12:57 | |
| *** yamamoto has quit IRC | 12:58 | |
| *** slaweq has quit IRC | 12:58 | |
| mdbooth | lyarwood: That's an excellent point. | 12:58 |
| *** yamamoto has joined #openstack-nova | 12:58 | |
| *** yongjiexu has joined #openstack-nova | 12:59 | |
| openstackgerrit | Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710 | 13:00 |
| *** awaugama has joined #openstack-nova | 13:00 | |
| *** mdrabe has joined #openstack-nova | 13:04 | |
| *** iceyao has joined #openstack-nova | 13:04 | |
| *** sridharg has quit IRC | 13:05 | |
| *** psachin has quit IRC | 13:07 | |
| *** efried has joined #openstack-nova | 13:09 | |
| *** iceyao has quit IRC | 13:09 | |
| *** slaweq has joined #openstack-nova | 13:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/458834 | 13:12 |
| efried | andymccr For the love of all that is holy, at some point you gotta tell us to bugger off and merge your patch already. | 13:13 |
| *** pchavva has joined #openstack-nova | 13:14 | |
| *** edmondsw has joined #openstack-nova | 13:15 | |
| *** yamamoto has quit IRC | 13:15 | |
| *** baoli has joined #openstack-nova | 13:16 | |
| *** baoli has quit IRC | 13:16 | |
| *** yamamoto has joined #openstack-nova | 13:16 | |
| *** mriedem has joined #openstack-nova | 13:16 | |
| *** yamamoto has quit IRC | 13:16 | |
| mriedem | o/ | 13:16 |
| *** yamamoto has joined #openstack-nova | 13:16 | |
| *** jamesdenton has joined #openstack-nova | 13:17 | |
| *** cleong has joined #openstack-nova | 13:17 | |
| rpodolyaka | mriedem: hey! could you please take a look at https://review.openstack.org/#/c/458837/? Am I missing something or "?h=stable/newton" part was just missed in the original change? | 13:18 |
| *** esberglu has joined #openstack-nova | 13:19 | |
| mriedem | was probably just missed, and i bet newton was master when that was added to novaclient | 13:19 |
| rpodolyaka | ack, thanks! | 13:20 |
| mriedem | cdent: johnthetubaguy: congrats on your TC glory | 13:23 |
| mriedem | as PTL i will promise to fight your TC decisions at every turn | 13:23 |
| johnthetubaguy | mriedem: I wouldn't want anything less | 13:23 |
| *** yamamoto has quit IRC | 13:25 | |
| cdent | mriedem: from the fires of conflict truth will rise | 13:25 |
| *** yamamoto has joined #openstack-nova | 13:26 | |
| mriedem | it'll be like those looney toons characters that clock in each day to fight each other | 13:26 |
| mriedem | but are buddies before and after | 13:26 |
| dansmith | zioproto: cool | 13:26 |
| *** baoli has joined #openstack-nova | 13:26 | |
| mriedem | clarkb: i don't suppose we ever backported your nova fix for the live migration job setup to stable/ocata | 13:27 |
| cdent | mriedem: perfect | 13:27 |
| *** dave-mccowan has joined #openstack-nova | 13:28 | |
| mriedem | clarkb: here we go https://review.openstack.org/#/c/458843/ | 13:28 |
| cdent | https://www.youtube.com/watch?v=kerUbfOQTW0 | 13:28 |
| mriedem | one of you can be the weird hairy english sheep dog, | 13:29 |
| mriedem | and i can be the american coyote | 13:29 |
| mriedem | who gets his ass handed to him daily | 13:29 |
| *** gszasz has quit IRC | 13:30 | |
| *** yamamoto has quit IRC | 13:30 | |
| *** baoli has quit IRC | 13:31 | |
| mriedem | johnthetubaguy: dansmith: leakypipes: has anyone proposed the concept of dedicated hosts in nova before? i have to assume it's come up, but i don't remember | 13:31 |
| *** liverpooler has joined #openstack-nova | 13:31 | |
| johnthetubaguy | yeah, HP folks did | 13:31 |
| mriedem | do you remember a spec for it? | 13:32 |
| johnthetubaguy | it was all aggregate wrangling if I remember, it might be pre-specs? | 13:32 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/multi-tenancy-isolation-only-aggregates | 13:32 |
| mriedem | ^ was cern | 13:32 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/whole-host-allocation | 13:32 |
| mriedem | ^ was HP | 13:32 |
| johnthetubaguy | ah, the second one is what I thought you meant | 13:33 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/multi-tenant-exclusion-filter | 13:33 |
| johnthetubaguy | yeah, I think it was phil talking about that | 13:33 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/hide-exclusive-availability-zone | 13:33 |
| mriedem | ha | 13:33 |
| mriedem | the list goes on | 13:33 |
| johnthetubaguy | we did something like the cern and last one downstream | 13:34 |
| mriedem | https://blueprints.launchpad.net/nova/+spec/support-dedicate-hosts-when-boot | 13:34 |
| *** baoli has joined #openstack-nova | 13:34 | |
| johnthetubaguy | yeah, thats the whole-host-allocation one | 13:34 |
| johnthetubaguy | there are two separate issues mixed in there | 13:34 |
| mriedem | i figured this could be done with dedicated aggregates/AZs and filters | 13:34 |
| johnthetubaguy | "I want only my VMs on each hypervisor", "assign some hosts to a sub-set of tenants" | 13:35 |
| *** tuan_luong has joined #openstack-nova | 13:35 | |
| *** rmart04_ has joined #openstack-nova | 13:35 | |
| johnthetubaguy | depends how dynamic you want it | 13:35 |
| cdent | andymccr, efried: that code is going to be the shiniest thing ever | 13:35 |
| johnthetubaguy | the HP plan (memory is fuzzy) was that you pick the host by the first instance that lands there "owns" that box | 13:35 |
| *** rmart04 has quit IRC | 13:36 | |
| *** rmart04_ is now known as rmart04 | 13:36 | |
| mriedem | johnthetubaguy: interesting, but what if the box isn't big enough for all of the instances the tenant wants to take over on that box? delete and find a new one? or create server groups to do this? | 13:36 |
| cdent | johnthetubaguy, mriedem : ironic wants a similar kind of thing for baremetal | 13:37 |
| cdent | i linked the spec in the latest rp update | 13:37 |
| *** Dinesh_Bhor has quit IRC | 13:37 | |
| johnthetubaguy | mriedem: it was simpler than that | 13:37 |
| johnthetubaguy | cdent: but when you get an ironic host, you get all the resources regardless, or do you mean reserving some for a particular tenant? | 13:37 |
| mriedem | cdent: not seeing it | 13:38 |
| johnthetubaguy | mriedem: well, by simpler, I mean, you cheat, if it doesn't fit on the host, you then get another host to pay for | 13:38 |
| mriedem | johnthetubaguy: oh i see | 13:38 |
| cdent | mriedem: I'll find the real link | 13:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: WIP: Specify keymap on server boot (1/2) https://review.openstack.org/458752 | 13:38 |
| johnthetubaguy | mriedem: there was talk of per project flavors being allowed, so the divide the hosts they pay for up however they want... got super messy really fast | 13:39 |
| mriedem | so apparently phil's proposal was accepted at one point | 13:39 |
| mriedem | HP public cloud wanted it, rax public cloud had it, and huawei public cloud has something too downstream, which is why i'm asking about it | 13:39 |
| cdent | mriedem, johnthetubaguy https://review.openstack.org/#/c/415512/ | 13:39 |
| cdent | figleaf and I had some fairly meandering comments and then leakypipes came along and set everyone straight | 13:40 |
| leakypipes | saw ah? | 13:40 |
| *** eglynn has joined #openstack-nova | 13:40 | |
| leakypipes | say wha? | 13:40 |
| johnthetubaguy | cdent: ah... right | 13:40 |
| johnthetubaguy | cdent: thats similar to the host assignment case | 13:41 |
| *** brault has joined #openstack-nova | 13:41 | |
| johnthetubaguy | mriedem: I am missing the business context on some of this, it sounds like better quotas would fix the ironic case | 13:41 |
| mriedem | i think it could be solved with tenant isolation filters and image meta, | 13:42 |
| mriedem | i.e. your tenant has access to these images which are configured to only work on certain host aggregates | 13:42 |
| mriedem | thereby you can only boot servers in those hosts | 13:43 |
| mriedem | phil says similar in https://review.openstack.org/#/c/38156/ | 13:43 |
| mriedem | it puts a burden on the operator | 13:43 |
| *** slaweq has quit IRC | 13:43 | |
| *** burt has joined #openstack-nova | 13:43 | |
| johnthetubaguy | mriedem: the problem is to automate that, you need to filer all create server requests, to make sure you just in time provision the extra hosts they might need, but maybe thats not really how it works, people probably have to buy the hosts via some other system. | 13:44 |
| *** vks1 has joined #openstack-nova | 13:44 | |
| *** eharney has joined #openstack-nova | 13:49 | |
| * johnthetubaguy way too many internet company vans outside my house, I hope thats for next door... | 13:51 | |
| stvnoyes | mriedem: johnthetubaguy: re: https://review.openstack.org/#/c/438750 - did you guys come to an agreement on whether something needs to done about the concern on begin_detaching? I looked thru the flows and i *think* it's ok for both the new flow and old flow. | 13:51 |
| johnthetubaguy | stvnoyes: I thought the previous consensus was its not allowed in the new flow, as it doesn't work for multi-attach, etc | 13:52 |
| mriedem | johnthetubaguy: ildikov was supposed to talk to jgriffith about that | 13:53 |
| johnthetubaguy | ah, right, that was the action | 13:53 |
| mriedem | but we did seem to get two answers on whether or not it would work in the new API model during the meeting yesterday | 13:53 |
| stvnoyes | would that mean that detaching would no longer ever be a valid status? | 13:54 |
| mriedem | i'd think it could be at least for a single attachment | 13:54 |
| mriedem | i.e. not multiattach | 13:54 |
| stvnoyes | ok got it | 13:54 |
| johnthetubaguy | mriedem: maybe that... not sure | 13:54 |
| mriedem | maybe the concern is that with multiattach you could go from in-use > detaching > in-use again | 13:54 |
| johnthetubaguy | but we need a solution that works for multi-attach | 13:54 |
| mriedem | if yo'ure going from 2 to 1 attachments | 13:54 |
| mriedem | if you have one attachment, you go in-use > detaching > available | 13:54 |
| johnthetubaguy | well the detaching status would have to be per attachment, I believe | 13:55 |
| mriedem | i'm looking up their data model | 13:55 |
| johnthetubaguy | well, its on the volume today, which I guess is the problem | 13:55 |
| johnthetubaguy | but well worth a check | 13:55 |
| ildikov | johnthetubaguy: I think begin_detaching is on another layer than the attachment calls TBH, therefore keeping it for that state change should be fine | 13:55 |
| mriedem | having said this, when ildikov did multiattach before, begin_detaching worked, but it did in-use > detaching > in-use | 13:55 |
| ildikov | johnthetubaguy: couldn't catch jgriffith yesterday, but I will try next week, he's out today | 13:55 |
| openstackgerrit | sahid proposed openstack/nova master: numa: fix an uninitialized local variable https://review.openstack.org/458848 | 13:55 |
| *** ratailor has joined #openstack-nova | 13:56 | |
| ildikov | mriedem: yep, we can say we don't want two detach happen at the same time, by which that state machine makes sense | 13:56 |
| johnthetubaguy | mriedem: that works if we only allow people to detach one attachment at once, thats not terrible | 13:56 |
| mriedem | does hemna know? | 13:57 |
| *** andreas_s has quit IRC | 13:57 | |
| *** prateek has joined #openstack-nova | 13:57 | |
| stvnoyes | the new VolumeAttachmentNotFound exception in that change will be needed in other work. I may just put add that exception as a new review to remove the dependency so I can move forward | 13:58 |
| mriedem | there is an attach_status on the volume_attachment table in cinder | 13:58 |
| mriedem | stvnoyes: hold up for now | 13:58 |
| *** prateek has quit IRC | 13:58 | |
| johnthetubaguy | oh... | 13:58 |
| stvnoyes | mriedem: ok | 13:58 |
| mriedem | johnthetubaguy: given this is an open question and begin_detaching is in the api, and what this patch is doing is in the compute side, i don't think we need to hold it up | 13:59 |
| *** catintheroof has joined #openstack-nova | 13:59 | |
| mriedem | johnthetubaguy: this patch is at the bottom of the call chain and has to assume the api has done whatever it needed to do, right? | 13:59 |
| johnthetubaguy | mriedem: yeah, I am not against leaving this as an open question, we do need to keep moving here | 13:59 |
| mriedem | we also get the attach status back when showing details about a volume attachment | 14:00 |
| ildikov | mriedem: I agree, I don't think we decided how to deprecate exactly what, begin_detaching can still fit as it does today | 14:00 |
| johnthetubaguy | but we don't pass the attachment_id in begin_detaching? | 14:00 |
| johnthetubaguy | its just the volume_id? | 14:00 |
| mriedem | i think regardless of what happens, cinder api deals with the multiattach case if begin_detaching is called | 14:01 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 14:01 |
| stvnoyes | just the volume is passed in | 14:01 |
| mriedem | johnthetubaguy: volume id | 14:01 |
| *** kaisers has quit IRC | 14:01 | |
| johnthetubaguy | mriedem: you are right though, this is the API, its not our problem | 14:01 |
| johnthetubaguy | mriedem: so didn't see your comment in the patch till now | 14:02 |
| ildikov | volume_id should be fine for begin_detaching IMHO | 14:02 |
| ildikov | at least from overall behavior perspective | 14:02 |
| *** claudiub|3 has joined #openstack-nova | 14:03 | |
| *** mlavalle has joined #openstack-nova | 14:03 | |
| johnthetubaguy | well, it does disallow multiple detatch of the same volume, because we can't no which one it is | 14:03 |
| johnthetubaguy | I mean, I am OK with that | 14:03 |
| johnthetubaguy | its just a thing | 14:03 |
| mriedem | we'd know which attachment to drop based on volume_id + instance_uuid | 14:04 |
| *** claudiub|4 has joined #openstack-nova | 14:04 | |
| johnthetubaguy | do we pass instance_uuid? | 14:04 |
| mriedem | no | 14:04 |
| mriedem | i'm talking future speak | 14:05 |
| johnthetubaguy | oh right | 14:05 |
| mriedem | hi, it's matt, from the future | 14:05 |
| ildikov | johnthetubaguy: until we have multi-attach it's a valid behavior and while working towards multi-attach we can figure it out whether it's the level of lock we want or not | 14:05 |
| johnthetubaguy | mriedem: you in australia? | 14:05 |
| johnthetubaguy | ildikov: yep, agreed with that | 14:05 |
| mriedem | johnthetubaguy: antarctica, it's warm and tropical now | 14:05 |
| mriedem | in the future | 14:05 |
| *** jaosorior_away is now known as jaosorior_mtg | 14:05 | |
| ildikov | mriedem: there are multiple ways to sort that out if that's what we want, like the one you mentioned | 14:05 |
| ildikov | mriedem: how's the future? :) | 14:06 |
| johnthetubaguy | mriedem: true, true. | 14:06 |
| mriedem | bleak | 14:06 |
| mriedem | very bleak | 14:06 |
| johnthetubaguy | something tells me mriedem likes the snow | 14:06 |
| *** claudiub has quit IRC | 14:06 | |
| mriedem | if we needed later on, we could hit a begin_detaching api on the attachments api in cinder, to change the status on a single attachment, which rolls up a status change in the volume itself, idk | 14:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807 | 14:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove is_job_complete polling after pivot https://review.openstack.org/458854 | 14:06 |
| mriedem | but that seems to be the same as what we have now essentially | 14:06 |
| *** felipemonteiro has joined #openstack-nova | 14:07 | |
| mriedem | i guess you wouldn't aggregate the status | 14:07 |
| johnthetubaguy | mriedem: its just the multi detach in parallel thing | 14:07 |
| mriedem | the volume would be in-use, one attachment would be 'attached' and the other would be 'detaching' | 14:07 |
| mriedem | so you could detach the other attachment, | 14:07 |
| *** claudiub|2 has quit IRC | 14:07 | |
| mriedem | but not the one that's 'detaching' | 14:07 |
| mriedem | i think that's probably the answer | 14:07 |
| johnthetubaguy | mriedem: I think that was in one proposal, the begin_detaching on the attachment, I don't remember why we dropped that now | 14:07 |
| *** claudiub has joined #openstack-nova | 14:07 | |
| ildikov | I think we only have volume state right now | 14:07 |
| mriedem | once both attachments are deleted, the volume status is 'available' | 14:07 |
| *** claudiub|2 has joined #openstack-nova | 14:07 | |
| johnthetubaguy | mriedem: yeah, overall its "in-use" until the last one is detaching, I gues... | 14:07 |
| mriedem | ildikov: there is an attach_status column on the volume_attachment table in cinder | 14:08 |
| mriedem | johnthetubaguy: yeah that sounds right, in-use until ==1 attachment is 'detaching', then the volume itself is 'detaching' | 14:08 |
| mriedem | once all attachments are deleted, the volume is 'available' | 14:08 |
| johnthetubaguy | anyways, I am +W on the detach patch, lets punt this, seems like its safe for now, appreciate stvnoyes for checking all that. | 14:08 |
| mriedem | so yeah, probably long-term we need a begin_detaching action on the attachments API | 14:08 |
| *** yongjiexu has quit IRC | 14:08 | |
| ildikov | mriedem: right, I remember that one, I just don't think we played that much with that state machine yet | 14:08 |
| johnthetubaguy | mriedem: yeah, same for attaching I guess | 14:08 |
| mriedem | until then you can only detach one attachment at a time | 14:09 |
| ildikov | johnthetubaguy: sounds good, thanks | 14:09 |
| johnthetubaguy | mriedem: +1 | 14:09 |
| *** djohnsto has joined #openstack-nova | 14:09 | |
| mriedem | which today is all you can do anyway b/c we don't support multiattac | 14:09 |
| ildikov | mriedem: +1 | 14:09 |
| *** cdent has quit IRC | 14:09 | |
| mriedem | maybe we should write this down somewhere :) | 14:09 |
| mriedem | b/c you know in 3 weeks we'll have forgotten | 14:09 |
| johnthetubaguy | mriedem: you read my mind | 14:09 |
| stvnoyes | thanks! moving on to the next one... | 14:10 |
| *** catintheroof has quit IRC | 14:10 | |
| ildikov | mriedem: johnthetubaguy: wiki page, devref, etherpad, love letter? | 14:10 |
| *** claudiub|3 has quit IRC | 14:10 | |
| *** catintheroof has joined #openstack-nova | 14:10 | |
| mriedem | i haven't written a love letter since high school | 14:10 |
| *** claudiub|4 has quit IRC | 14:10 | |
| mriedem | when we didn't have cell phones | 14:10 |
| gibi | mriedem: hi! thanks for the reviews and fixes on the https://review.openstack.org/#/q/topic:bp/additional-notification-fields-for-searchlight+status:open series. | 14:11 |
| mriedem | gibi: np | 14:11 |
| johnthetubaguy | I wrote a poem for my wedding, I am not doing that again | 14:11 |
| gibi | mriedem: I rebased the keypair patch as well and I'm working on the BDM patch | 14:11 |
| mriedem | i believe we picked poems and had others read them | 14:11 |
| ildikov | :) | 14:11 |
| * ildikov feels nostalgic now :) | 14:12 | |
| johnthetubaguy | mriedem: yeah, I couldn't think of how to finish my speach... and didn't think to use google because I was too nervous, lol | 14:12 |
| mriedem | johnthetubaguy: was it pre-dinner or post-dinner? | 14:12 |
| mriedem | or mid-dinner? | 14:12 |
| johnthetubaguy | sort of mid I really | 14:12 |
| sballe_ | morning | 14:12 |
| mriedem | same for my forced impromptu speech | 14:13 |
| johnthetubaguy | heh | 14:13 |
| mriedem | i should have done jimmy from south park | 14:13 |
| mriedem | "wow what a great audience!" | 14:13 |
| sballe_ | I am looking for some documentation on how nova can schedule VMs with FPGAs as well as how FPGAs are represented in nove | 14:13 |
| sballe_ | s/nova | 14:13 |
| sballe_ | Any help is appreciated | 14:14 |
| johnthetubaguy | mriedem: ildikov: maybe update the existing spec with a note about all that? | 14:14 |
| *** dixiaoli has joined #openstack-nova | 14:15 | |
| ildikov | johnthetubaguy: that can work too | 14:15 |
| *** rmart04_ has joined #openstack-nova | 14:15 | |
| johnthetubaguy | sballe_: we don't really support FPGA passthrough for VMs as such, although I think you could use ironic to give you the whole box including the FPGA | 14:15 |
| mriedem | sballe_: they aren't | 14:16 |
| sballe_ | couls I use nova to schedule flavors with accelerators? | 14:16 |
| *** tbachman has joined #openstack-nova | 14:16 | |
| *** rmart04 has quit IRC | 14:16 | |
| *** rmart04_ is now known as rmart04 | 14:16 | |
| sballe_ | I see a lot of post with gpus | 14:16 |
| *** pjm6 has joined #openstack-nova | 14:16 | |
| johnthetubaguy | sballe_: so you can pass through a generic PCI device, maybe that would work? | 14:17 |
| mriedem | sballe_: there is a project called 'cyborg' which you should probably start with | 14:17 |
| mriedem | which is all about acceleration | 14:17 |
| sballe_ | ok cool! thx for the help | 14:17 |
| mriedem | sballe_: https://wiki.openstack.org/wiki/Cyborg | 14:17 |
| mriedem | look for email threads in the openstack-dev mailing list tagged with [acceleration] | 14:18 |
| johnthetubaguy | so I forgot about that thing, my email filters are a bit strong these days | 14:18 |
| mriedem | sballe_: also https://review.openstack.org/#/c/318047/ | 14:18 |
| mriedem | leakypipes: dansmith: johnthetubaguy: https://review.openstack.org/#/c/419185/ on down for bp/additional-notification-fields-for-searchlight is ready to go, has my +2 | 14:19 |
| *** dixiaoli has quit IRC | 14:19 | |
| mriedem | johnthetubaguy: yeah we could amend the spec, | 14:20 |
| mriedem | johnthetubaguy: you going to do that or want me to? | 14:20 |
| mriedem | i'm happy to update it | 14:20 |
| johnthetubaguy | mriedem: if you could, that would be great | 14:20 |
| mriedem | will do | 14:20 |
| sballe_ | mriedem: thx | 14:20 |
| *** bnemec is now known as beekneemech | 14:20 | |
| bauzas | mriedem: hola, quick q, when are you planning a stable/newton release ? :) | 14:20 |
| bauzas | and oh snap, TGIF | 14:21 |
| mriedem | bauzas: when you merge the regression fixes proposed to newton | 14:21 |
| * bauzas bauwser | 14:21 | |
| *** yamahata has joined #openstack-nova | 14:21 | |
| * bauzas facepalms | 14:21 | |
| bauzas | mriedem: heh, roger. | 14:21 |
| *** bauzas is now known as bauwser | 14:21 | |
| * bauwser is just refueling with coffee | 14:21 | |
| smcginnis | mriedem: Missed your question yesterday while travelling. | 14:21 |
| smcginnis | mriedem: That session is to discuss the track chair process and issues. | 14:22 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: configure trust mode for vfs https://review.openstack.org/458514 | 14:22 |
| openstackgerrit | sahid proposed openstack/nova master: network: update pci request spec to handle trusted tags https://review.openstack.org/458820 | 14:22 |
| openstackgerrit | sahid proposed openstack/nova master: network: add command to configure trusted mode for VFs https://review.openstack.org/458513 | 14:22 |
| mriedem | smcginnis: what's a track chair? | 14:24 |
| mriedem | those setting up the summit? | 14:24 |
| mriedem | or those running a session? | 14:24 |
| openstackgerrit | Alex Xu proposed openstack/python-novaclient master: Add `instance-uuid` flag to the migration-list https://review.openstack.org/458728 | 14:24 |
| *** rcernin has quit IRC | 14:24 | |
| johnthetubaguy | pick the sessions | 14:24 |
| mriedem | alex_xu: you beat me to it | 14:25 |
| smcginnis | mriedem: Decising which sessions to accept for the official schedule. | 14:25 |
| *** brault has quit IRC | 14:25 | |
| johnthetubaguy | mriedem: done it twice, its a pain | 14:25 |
| mriedem | oh, i don't care about that session then :) | 14:25 |
| smcginnis | johnthetubaguy: Yep. :) | 14:25 |
| alex_xu | mriedem: hope you didn't start that | 14:25 |
| mriedem | alex_xu: no i didn't, thanks for doing it | 14:25 |
| alex_xu | mriedem: np | 14:25 |
| *** rfolco has joined #openstack-nova | 14:26 | |
| *** yamamoto has joined #openstack-nova | 14:27 | |
| *** baoli has quit IRC | 14:28 | |
| *** brault has joined #openstack-nova | 14:28 | |
| *** salv-orlando has quit IRC | 14:28 | |
| *** baoli has joined #openstack-nova | 14:29 | |
| mriedem | alex_xu: comments inline :) | 14:29 |
| mriedem | otherwise looks good | 14:29 |
| *** zz_dimtruck is now known as dimtruck | 14:29 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect_volume after rebase failures https://review.openstack.org/458807 | 14:30 |
| *** rfolco has quit IRC | 14:30 | |
| mriedem | bauwser: these https://review.openstack.org/#/c/457353/ https://review.openstack.org/#/c/448235/ https://review.openstack.org/#/c/458668/ https://review.openstack.org/#/c/456770/ https://review.openstack.org/#/c/448253/ | 14:31 |
| bauwser | mriedem: reviewy reviewy | 14:31 |
| mriedem | ask and ye shall receieve | 14:32 |
| mriedem | *receive | 14:32 |
| bauwser | mriedem: FWIW, I haven't touched the scheduler claims spec since I need time to think about | 14:32 |
| mriedem | i haven't either | 14:32 |
| bauwser | about the super extra cool problem you showed to the world with overhead values | 14:32 |
| mriedem | don't thank me, thank some performance tester internal to huawei | 14:33 |
| *** dikonoor has quit IRC | 14:33 | |
| *** amotoki has joined #openstack-nova | 14:33 | |
| bauwser | mriedem: FWIW, my honest first opinion is that problem it's something that we should leave out of placement | 14:33 |
| mriedem | i didn't know the overhead stuff existed before that | 14:33 |
| bauwser | mriedem: that looks something not really useful for placement and very related to the hypervisor | 14:33 |
| *** baoli has quit IRC | 14:34 | |
| mriedem | you have to solve it with placement one way or the other, either by tracking overhead in allocations, or forcing extra reserved inventory to make up for the overhead | 14:34 |
| bauwser | so, say we leave in a world where we're not trying to eat all the resources but still have reserved room for that, then it's not a problem for placement | 14:34 |
| mriedem | right? | 14:34 |
| mriedem | i don't think we can punt on this | 14:34 |
| *** baoli has joined #openstack-nova | 14:34 | |
| *** baoli has quit IRC | 14:35 | |
| *** mriedem has left #openstack-nova | 14:35 | |
| *** mriedem has joined #openstack-nova | 14:35 | |
| bauwser | mriedem: if we have rescheduling, would it be a problem ? | 14:35 |
| *** amotoki has quit IRC | 14:36 | |
| bauwser | we already don't place instances by reviewing that value | 14:36 |
| mriedem | we reschedule based on it though | 14:36 |
| bauwser | of course | 14:36 |
| mriedem | but we don't have reschedules with super conductor | 14:36 |
| bauwser | but how much ? | 14:36 |
| mriedem | idk how much | 14:36 |
| bauwser | so, it's rather a problem about how to reschedule | 14:36 |
| mriedem | well, | 14:36 |
| mriedem | the point of claims in the scheduler is you don't need to reschedule | 14:36 |
| bauwser | honestly, I think claiming in the scheduler couldn't remove the compute node verifying the resources too | 14:37 |
| bauwser | because sometimes, things can be wrong | 14:37 |
| bauwser | so, having claims in the scheduler is cool but like Pareto (or more) fixing 95% of the number of problems we have | 14:37 |
| bauwser | should we fix 5% of the current problems by adding more ? | 14:38 |
| bauwser | if we still reschedule | 14:38 |
| mriedem | if you can't reschedule from the compute, then what? NoValidHost and put the instance into ERROR state? | 14:38 |
| mriedem | ^ was one of the options i proposed in the spec | 14:38 |
| bauwser | anyway, since not all the resources are yet set in the placement API (like NUMA), we would still need to reschedule, right ? | 14:38 |
| mriedem | i said account for the overhead by updating the allocations once on the compute, but people didn't like that b/c of quotas | 14:38 |
| bauwser | because we use allocations for quotas, and I agree with the majority | 14:39 |
| bauwser | so, either we say we add that for inventories *and not allocations*, or we say it's not a problem | 14:39 |
| *** amotoki has joined #openstack-nova | 14:39 | |
| bauwser | and we leave reschedules fix that self-healing | 14:39 |
| mriedem | we don't have reschedules | 14:40 |
| mriedem | i thought the consensus the other day was pad the RP inventory reserved amount | 14:40 |
| bauwser | that's what I'm not sure we can just say it won't exist in a cellsv2 world | 14:40 |
| mriedem | via the get_inventory() method on drivers that calculate overhead | 14:40 |
| bauwser | mriedem: I think the consensus looks good by me | 14:40 |
| mriedem | reschedules are possible in a single-cell deployment | 14:40 |
| bauwser | that's my "either" possibiltyu | 14:40 |
| mriedem | but i don't think we should rely on them | 14:41 |
| bauwser | okay | 14:41 |
| mriedem | when designing things | 14:41 |
| *** gongysh has joined #openstack-nova | 14:41 | |
| mriedem | dan proposed adding a config option to disable reschedules so you never have upcalls, regardless of deployment | 14:41 |
| *** yongjiexu has joined #openstack-nova | 14:41 | |
| bauwser | so it leaves the idea to modify inventories to add more "something" for decrementing the "left" value | 14:41 |
| bauwser | amending 'reserved' could be that "something" which wouldn't need to add a new DB fiedl | 14:42 |
| mriedem | correct, that's what most people wanted the other day | 14:42 |
| *** slagle has quit IRC | 14:42 | |
| bauwser | mriedem: yup, and I +2d that change for the instance scheduler RPC call | 14:42 |
| mriedem | it sucks for the operator because they have to configure reserved amounts, | 14:43 |
| mriedem | unless we can come up with a scheme to automate it | 14:43 |
| bauwser | mriedem: okay, if so, I think I can amend that spec | 14:43 |
| *** pjm6 has quit IRC | 14:43 | |
| bauwser | mriedem: I was rather thinking to have the inventory be modified by the RT to augment it by the sum of overhead for each instance | 14:43 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: Remove fstype param from ploop init https://review.openstack.org/444970 | 14:43 |
| bauwser | snap | 14:43 |
| bauwser | to have the inventory.reserved value | 14:44 |
| cfriesen | question...has nova ever considered setting the virtual disk logical/physical block size based on the host disk block size? currently the guest sees 512 even for disks with 4K block size, which potentially leads to extra read-modify-write overhead | 14:44 |
| *** rnoriega has quit IRC | 14:44 | |
| leakypipes | mriedem: k, on it. | 14:44 |
| bauwser | leakypipes: mriedem: okay, I think then I have enough to amend the spec | 14:46 |
| *** armax has joined #openstack-nova | 14:46 | |
| bauwser | I'll try to provide a new rev' by today EOB or Monday | 14:46 |
| leakypipes | bauwser: coolio. | 14:46 |
| mriedem | bauwser: so rather than add overheads to allocations, you want to add overhead to inventory.reserved during each build? | 14:46 |
| mriedem | that could still get you in a 409 situation where we have to fail the build | 14:47 |
| bauwser | leakypipes: do you agree with my idea to augment in the RT the reserved value given by the driver.get_inventory() method by the number of instance.overhead we have ? | 14:47 |
| *** jschlueter has joined #openstack-nova | 14:47 | |
| *** marst has joined #openstack-nova | 14:47 | |
| mriedem | we had talked about just a configurable value that get_inventory() would provide and isn't per-instance | 14:48 |
| *** slaweq has joined #openstack-nova | 14:48 | |
| *** nkorabli has joined #openstack-nova | 14:48 | |
| figleaf | I don't like treating reserved like an allocation - it should be set when the RP is created, and that's it | 14:48 |
| leakypipes | bauwser: hmm, I must have missed that. lemme have another look at the spec | 14:48 |
| bauwser | leakypipes: that's not yet in the spec | 14:48 |
| mriedem | leakypipes: it's new as of bauwser today | 14:48 |
| leakypipes | oh | 14:49 |
| mriedem | last 5 minutes | 14:49 |
| figleaf | it's sort of in my last comment on the spec | 14:49 |
| leakypipes | no wonder I missed it then :) | 14:49 |
| bauwser | I'm trying to explain that we find nodes based on what we ask vs. what we have as free | 14:49 |
| bauwser | so, what we ask is the flavor | 14:49 |
| bauwser | what we have is the inventory minus the allocations | 14:49 |
| leakypipes | bauwser: sorry, lemme read back up. I just got back from breakfast :) | 14:49 |
| bauwser | I'm trying to explain it another way | 14:50 |
| bauwser | given we ask for the flavor size | 14:50 |
| mriedem | reserved to me means static reserved, via config from the operator, something that nova doesn't mess with automatically | 14:50 |
| bauwser | and we compare it to each node by doing (total - reserved - sum(allocations)) | 14:50 |
| figleaf | mriedem: exactly | 14:51 |
| bauwser | I'm seeing some way to say (total - reserved - sum(allocations) - sum(overhead)) | 14:51 |
| figleaf | for a hypervisor, it's the "cost of doing business" | 14:51 |
| mriedem | worst case scenario is you don't modify reserved at all and run the risk of over-consuming your resources on the host | 14:51 |
| bauwser | my proposal being "reserved" and sum(overhead) is purely related to the hypervisor | 14:51 |
| mriedem | for ram and disk it could be a small overhead | 14:51 |
| mriedem | that you didn't account for in capacity planning | 14:51 |
| figleaf | the amount of resource that a provider cannot offer | 14:52 |
| *** kiwi_rot has quit IRC | 14:52 | |
| bauwser | I think we all know why we have that "reserved "field | 14:52 |
| bauwser | I'm just trying to see how we can consider overheads to be part of something sent to placement | 14:52 |
| bauwser | because the more I think, the more I'm -1 to amending allocations if we consider allocations as the basement for quotas | 14:53 |
| figleaf | if we do, then we should use it accordingly. "Overhead" is nothing except resources that the HV needs to do its job | 14:53 |
| *** yamamoto has quit IRC | 14:53 | |
| mriedem | alex_xu: since we print "Instance UUID" in the nova migration-list output, i guess --instance-uuid is ok | 14:53 |
| bauwser | the other way would require a new 'overhead' table that would be per consumer id | 14:53 |
| mriedem | bauwser: i think we already shot own the idea of updating allocations to account for overhead | 14:54 |
| bauwser | exactly like allocations is | 14:54 |
| bauwser | mriedem: \o/ glad to hear | 14:54 |
| bauwser | mriedem: so, if we say it's not allocations | 14:54 |
| mriedem | it's rp.inventory.reserved | 14:54 |
| bauwser | and if we don't want to touch 'reserved', then how could we send that amount to placement ? | 14:54 |
| mriedem | it is via reserved | 14:54 |
| bauwser | mriedem: right | 14:54 |
| mriedem | the question is, is it static via config, or do you adjust it dynamically | 14:55 |
| figleaf | Configure when creating the RP, and be done with it | 14:55 |
| mriedem | which is what i thought you were talking about doing, the latter | 14:55 |
| bauwser | so, why are people arguing with my idea to automatically augment that rp.inventory.reserved by the sum(overhead) ? | 14:55 |
| mriedem | the simplest solution is config like figleaf says | 14:55 |
| bauwser | mriedem: remember the libvirt overheads | 14:55 |
| bauwser | and see how it is linear per instances | 14:55 |
| mriedem | i realize that the overhead is per instance | 14:56 |
| *** ratailor has quit IRC | 14:56 | |
| bauwser | FWIW, my Red Hat infrastructure gladly crashed so I'm really 100% committed to upstream :p | 14:56 |
| figleaf | bauwser: so figure out what the max number of instances that will cover 90% of the hosts, and use that | 14:56 |
| *** markus_z has quit IRC | 14:56 | |
| leakypipes | mriedem, bauwser, figleaf (and anyone else who wants to settle the overheads discussion): https://hangouts.google.com/hangouts/_/ejhj37l6u5fkhonhnn23in2vome | 14:56 |
| lyarwood | bauwser: who needs DNS anyway? | 14:56 |
| bauwser | figleaf: how could you be ? it's depending on the number of flavors the users ask ? | 14:56 |
| mriedem | and yes we could technically adjust the inventory.reserved based on the sum of all instance overheads, but i think that would be a surprise to operators that nova is automatically adjusting and increasing the reserved amount of inventory even though they set a static config value for it | 14:56 |
| alex_xu | mriedem: ok, got it | 14:56 |
| bauwser | lyarwood: you're right, it's totally useless | 14:56 |
| * bauwser lives in a cave with no signals | 14:57 | |
| *** kaisers has joined #openstack-nova | 14:57 | |
| bauwser | mriedem: if we allow them to see the values thru the REST API, I agree | 14:57 |
| figleaf | leakypipes: gimme a minute | 14:57 |
| mriedem | bauwser: which we do | 14:57 |
| bauwser | mriedem: but for the moment, we never intended to do so | 14:57 |
| mriedem | huh/ | 14:58 |
| mriedem | ? | 14:58 |
| *** markmc has quit IRC | 14:58 | |
| bauwser | mriedem: I thought we said the REST API is not yet consumable by end-users ? | 14:58 |
| *** jaosorior_mtg is now known as jaosorior | 14:58 | |
| mriedem | bauwser: jump on the hangout if you can | 14:58 |
| openstackgerrit | Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710 | 14:59 |
| *** jaosorior has quit IRC | 14:59 | |
| bauwser | mriedem: "I live for obeying orders" (again, French comics named 'Leonard') | 14:59 |
| *** markmc has joined #openstack-nova | 15:01 | |
| *** mdrabe has quit IRC | 15:02 | |
| *** slaweq has quit IRC | 15:02 | |
| openstackgerrit | Monty Taylor proposed openstack/python-novaclient master: Remove direct dependency on requests https://review.openstack.org/458868 | 15:02 |
| *** yamahata has quit IRC | 15:03 | |
| *** yamahata_ has joined #openstack-nova | 15:03 | |
| *** cdent has joined #openstack-nova | 15:03 | |
| lyarwood | ildikov / stvnoyes ; just getting around to the cinderv3 patches now, am I okay to work on the swap_volume change? https://review.openstack.org/#/c/456971/ | 15:04 |
| *** nkorabli has quit IRC | 15:05 | |
| *** voelzmo has quit IRC | 15:05 | |
| ildikov | lyarwood: it should be ok, stvnoyes took https://review.openstack.org/#/c/456877/ yesterday | 15:05 |
| *** brault has quit IRC | 15:05 | |
| *** voelzmo has joined #openstack-nova | 15:05 | |
| lyarwood | ildikov: kk thanks | 15:06 |
| ildikov | lyarwood: this one is on its way to get merged: https://review.openstack.org/438750 , so I should rebase the chain though | 15:06 |
| *** ijw has joined #openstack-nova | 15:07 | |
| *** annegentle has joined #openstack-nova | 15:07 | |
| *** brault has joined #openstack-nova | 15:07 | |
| *** slagle has joined #openstack-nova | 15:07 | |
| ildikov | lyarwood: also this one is not in the chain and needs some love too if you don't want to deal with the patch in the middle of the chain: https://review.openstack.org/#/c/456851/ | 15:08 |
| *** MasterOfBugs has joined #openstack-nova | 15:09 | |
| *** amotoki has quit IRC | 15:09 | |
| *** mdrabe has joined #openstack-nova | 15:10 | |
| *** voelzmo has quit IRC | 15:10 | |
| *** MasterOfBugs has quit IRC | 15:10 | |
| *** BlackDex has joined #openstack-nova | 15:11 | |
| *** MasterOfBugs has joined #openstack-nova | 15:11 | |
| *** Oku_OS is now known as Oku_OS-away | 15:11 | |
| *** aarefiev is now known as aarefiev_afk | 15:11 | |
| *** brault has quit IRC | 15:12 | |
| *** markmc has quit IRC | 15:12 | |
| *** nkorabli has joined #openstack-nova | 15:12 | |
| *** MasterOfBugs has quit IRC | 15:12 | |
| *** migi has quit IRC | 15:13 | |
| *** nkorabli has quit IRC | 15:14 | |
| *** migi has joined #openstack-nova | 15:14 | |
| bauwser | leakypipes: mriedem: figleaf: thanks for helping me, always appreciated. :) | 15:16 |
| bauwser | you just missed my new co-worker's face | 15:16 |
| mriedem | dogs psh | 15:16 |
| *** markmc has joined #openstack-nova | 15:17 | |
| mriedem | now what did i say i was going to do an hour ago... | 15:17 |
| bauwser | mriedem: dansmith: soooo we can assume to modify a DB migration script like this https://review.openstack.org/#/c/458668/1 ? | 15:18 |
| *** MasterOfBugs has joined #openstack-nova | 15:18 | |
| bauwser | mriedem: are you then planning to do a .y release for ^ ? | 15:18 |
| mriedem | bauwser: x | 15:18 |
| mriedem | major version bump | 15:18 |
| bauwser | mriedem: or would it still be a .z given it's a mitaka>newton migration script | 15:18 |
| mriedem | to f over red hat | 15:18 |
| mriedem | if there was a w, i'd use that | 15:19 |
| mriedem | epoch | 15:19 |
| mriedem | it's a bug fix | 15:19 |
| mriedem | not a new migration | 15:19 |
| mriedem | so it's a patch release | 15:19 |
| mriedem | .z | 15:19 |
| dansmith | bauwser: can we assume what now? | 15:19 |
| dansmith | bauwser: you're asking if it's okay to make that change? | 15:20 |
| mriedem | we don't have to worry about people with the bug getting past that migration, | 15:20 |
| mriedem | because they'd be blocked on it | 15:20 |
| mriedem | hence the fix | 15:20 |
| dansmith | ....right | 15:20 |
| mriedem | i.e. swebster_'s migration to newton was blocked on that migration | 15:21 |
| *** kashyap has quit IRC | 15:21 | |
| dansmith | yeah it's totally fine to make that change, I'm not sure what the concern is | 15:21 |
| openstackgerrit | Andy McCrae proposed openstack/nova master: Allow CONTENT_LENGTH to be present but empty https://review.openstack.org/455710 | 15:21 |
| mriedem | i released a stable version as a patch release that had a db migration in it awhile back and red hat freaked out, so bauwser is touchy to backports on db migrations ever since | 15:22 |
| bauwser | yeah that | 15:22 |
| dansmith | okay but this is a blocker | 15:22 |
| bauwser | (sorry otp) | 15:22 |
| mriedem | i wasn't aware of red hat's internal stable release processes | 15:22 |
| mriedem | for which i'll always be regretful | 15:22 |
| dansmith | yeah, I remember that, but.. this is... again, a blocker migration | 15:23 |
| lyarwood | bauwser: which db migration was that? | 15:23 |
| mriedem | lyarwood: i think https://github.com/openstack/nova/commit/ee086460db947ea0dcd2cb27fd2aecf738b47c20 | 15:24 |
| *** efoley__ has quit IRC | 15:24 | |
| *** zenoway has quit IRC | 15:24 | |
| *** vladikr has quit IRC | 15:25 | |
| mriedem | or https://github.com/openstack/nova/commit/608105a7c508ed48055dca6e2d327c944ecb18ea | 15:25 |
| *** manjaro has quit IRC | 15:25 | |
| *** zenoway has joined #openstack-nova | 15:25 | |
| *** kashyap has joined #openstack-nova | 15:26 | |
| *** amotoki has joined #openstack-nova | 15:26 | |
| mriedem | lyarwood: this is what you want for the brick encryptors change https://review.openstack.org/#/c/458834/ | 15:26 |
| lyarwood | mriedem: yup thanks I'll update the depends on with that now | 15:26 |
| cdent | andymccr, efried : you done yet, I've been holding off until you both bless that shiny code | 15:27 |
| *** rmart04 has quit IRC | 15:27 | |
| efried | Fer heaven's sake, bless it. We could keep tweaking it for years. | 15:28 |
| *** vks1 has quit IRC | 15:28 | |
| efried | Unless pep8 complains about those redundant parens, I say ship it! | 15:28 |
| efried | oh, andymccr fixed... | 15:28 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 15:28 |
| cdent | efried: unfortunatley I can't +2 it, so... | 15:28 |
| efried | cdent It looks JUST PERFECT now. Please, please approve it! ( sfinucan ) | 15:29 |
| andymccr | hahahahahaha | 15:29 |
| *** amotoki has quit IRC | 15:30 | |
| bauwser | dansmith: mriedem: so this https://review.openstack.org/#/c/458668/1 is just for a mitaka>newton migration right? | 15:31 |
| bauwser | dansmith: mriedem: I mean, since we say to use the latest .z version, we're fine | 15:31 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 15:31 |
| mriedem | bauwser: who is we? | 15:32 |
| mriedem | red hat? | 15:32 |
| bauwser | just wanted to make sure it wasn't needing a new db sync if you already applied a newton install | 15:32 |
| mriedem | bauwser: it's for an upgrade | 15:32 |
| mriedem | not a new install | 15:32 |
| *** amotoki has joined #openstack-nova | 15:32 | |
| mriedem | select([func.count()]).select_from(pci_devices) | 15:32 |
| bauwser | ok, so no db sync for updating to that new package if already newton ? | 15:32 |
| mriedem | if you don't have pci devices (new install), then it's not a bug | 15:32 |
| bauwser | no db sync *required* | 15:33 |
| *** gongysh has quit IRC | 15:33 | |
| bauwser | if the answer is yes, then +W | 15:33 |
| mriedem | if you already got to newton you don't have this issue | 15:33 |
| *** migi has quit IRC | 15:33 | |
| *** migi has joined #openstack-nova | 15:33 | |
| bauwser | okay, that's what I thought, just double-checked | 15:33 |
| mriedem | because 330 was in newton | 15:34 |
| mriedem | https://github.com/openstack/nova/blob/stable/newton/nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py | 15:34 |
| *** amotoki has quit IRC | 15:35 | |
| *** ssurana has joined #openstack-nova | 15:35 | |
| *** MasterOfBugs has quit IRC | 15:36 | |
| *** baoli has joined #openstack-nova | 15:37 | |
| *** MasterOfBugs has joined #openstack-nova | 15:37 | |
| lyarwood | mriedem: ah sorry didn't see your check experimental | 15:38 |
| *** zenoway has quit IRC | 15:38 | |
| lyarwood | mriedem: any idea why the encrypted volume tests were moved there? | 15:38 |
| mriedem | lyarwood: a bunch of scenario tests were marked slow to take them out of the main gate runs, | 15:41 |
| mriedem | because the scenario tests were taking up a ton of time, and randomly failing and causing resets, which takes more time | 15:41 |
| *** baoli has quit IRC | 15:41 | |
| mriedem | it was a big QA effort around the time of the PTG | 15:41 |
| lyarwood | mriedem: understood, me-- for not checking that the tests were still present in the gate in the recent CI runs. | 15:43 |
| *** chyka has joined #openstack-nova | 15:43 | |
| *** lpetrut has quit IRC | 15:44 | |
| *** ildikov is now known as coffee_cat | 15:45 | |
| *** MasterOfBugs has quit IRC | 15:45 | |
| mriedem | me-- :) | 15:46 |
| mriedem | never seen that before | 15:46 |
| *** jpena has quit IRC | 15:46 | |
| mriedem | this isn't c lee | 15:46 |
| mriedem | if you're going to decrement yourself, me -= me, please | 15:47 |
| *** zenoway has joined #openstack-nova | 15:47 | |
| *** dikonoor has joined #openstack-nova | 15:48 | |
| *** amotoki has joined #openstack-nova | 15:48 | |
| lyarwood | mriedem: always reviewing ;) | 15:49 |
| *** MasterOfBugs has joined #openstack-nova | 15:50 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 15:50 |
| *** yamamoto has joined #openstack-nova | 15:51 | |
| *** jpena has joined #openstack-nova | 15:52 | |
| dansmith | mriedem: me -= me = 0, not me-1 right? | 15:53 |
| mriedem | dansmith: you've got me there | 15:55 |
| mriedem | superdan | 15:55 |
| *** dansmith is now known as superdan | 15:55 | |
| *** Guest86170 has quit IRC | 15:56 | |
| bauwser | if me = -1, is me a square root of myself ? | 15:56 |
| *** lyarwood is now known as me | 15:56 | |
| me | always wanted a friday nick | 15:56 |
| *** me is now known as Guest41383 | 15:57 | |
| Guest41383 | dude | 15:57 |
| bauwser | heh, registered | 15:57 |
| mdbooth | Haha | 15:57 |
| Guest41383 | aaaaaaaaaand that's not going to be it | 15:57 |
| *** MasterOfBugs has quit IRC | 15:57 | |
| bauwser | I did registered both my casual nick *and* my friday one :) | 15:57 |
| *** Guest41383 is now known as lyarwood | 15:57 | |
| *** Guest86170 has joined #openstack-nova | 15:58 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 15:58 |
| *** david-lyle has joined #openstack-nova | 15:58 | |
| bauwser | anyway, let's call it a week-end | 15:59 |
| *** slaweq has joined #openstack-nova | 15:59 | |
| *** salv-orlando has joined #openstack-nova | 16:00 | |
| *** dikonoo has joined #openstack-nova | 16:02 | |
| *** yongjiexu has quit IRC | 16:03 | |
| *** salv-orlando has quit IRC | 16:04 | |
| *** slaweq has quit IRC | 16:04 | |
| *** salv-orlando has joined #openstack-nova | 16:05 | |
| *** dikonoor has quit IRC | 16:05 | |
| *** damien_r has quit IRC | 16:05 | |
| *** kaisers has quit IRC | 16:06 | |
| *** kaisers has joined #openstack-nova | 16:06 | |
| * cdent agrees with bauwser | 16:09 | |
| * cdent waves | 16:09 | |
| *** cdent has quit IRC | 16:09 | |
| *** mlavalle has quit IRC | 16:11 | |
| *** zenoway has quit IRC | 16:14 | |
| *** slaweq has joined #openstack-nova | 16:17 | |
| *** yongjiexu has joined #openstack-nova | 16:17 | |
| *** slaweq has quit IRC | 16:18 | |
| *** zenoway has joined #openstack-nova | 16:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: move createBackup to server-actions https://review.openstack.org/452971 | 16:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: 2.43: Remove Location header from createImage and createBackup responses https://review.openstack.org/455443 | 16:19 |
| *** nic has joined #openstack-nova | 16:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/458834 | 16:21 |
| *** rmart04 has joined #openstack-nova | 16:21 | |
| *** rmart04 has quit IRC | 16:22 | |
| *** zenoway has quit IRC | 16:23 | |
| *** annegentle has quit IRC | 16:26 | |
| *** voelzmo has joined #openstack-nova | 16:27 | |
| *** annegentle has joined #openstack-nova | 16:27 | |
| *** john51 has quit IRC | 16:27 | |
| *** john51_ has joined #openstack-nova | 16:27 | |
| *** dikonoo has quit IRC | 16:28 | |
| *** beekneemech has quit IRC | 16:30 | |
| *** esberglu has quit IRC | 16:30 | |
| *** nic1 has joined #openstack-nova | 16:31 | |
| *** dtp has joined #openstack-nova | 16:31 | |
| *** yongjiexu has quit IRC | 16:33 | |
| *** voelzmo has quit IRC | 16:33 | |
| *** nic has quit IRC | 16:34 | |
| *** gyee has joined #openstack-nova | 16:36 | |
| *** lucasagomes is now known as lucas-afk | 16:36 | |
| *** nic1 has quit IRC | 16:36 | |
| *** dikonoo has joined #openstack-nova | 16:38 | |
| *** baoli has joined #openstack-nova | 16:38 | |
| *** amotoki has quit IRC | 16:39 | |
| *** ltomasbo is now known as ltomasbo|away | 16:40 | |
| *** pchavva has quit IRC | 16:40 | |
| *** baoli has quit IRC | 16:43 | |
| *** bnemec has joined #openstack-nova | 16:44 | |
| *** bnemec is now known as beekneemech | 16:45 | |
| *** wasmum has joined #openstack-nova | 16:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Tell people that the nova-cells man page is for cells v1 https://review.openstack.org/456925 | 16:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add release note and update cell install guide for multi-cell limitations https://review.openstack.org/456923 | 16:46 |
| *** mlavalle has joined #openstack-nova | 16:47 | |
| *** dmellado has quit IRC | 16:52 | |
| *** kashyap has quit IRC | 16:52 | |
| *** ltomasbo|away has quit IRC | 16:52 | |
| *** markmc has quit IRC | 16:53 | |
| *** nkorabli has joined #openstack-nova | 16:53 | |
| *** jpena has quit IRC | 16:54 | |
| *** weshay has quit IRC | 16:54 | |
| *** migi has quit IRC | 16:54 | |
| *** ijw has quit IRC | 16:54 | |
| *** ijw has joined #openstack-nova | 16:55 | |
| *** yamamoto has quit IRC | 16:55 | |
| *** Apoorva has joined #openstack-nova | 16:55 | |
| *** ijw has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:00 | |
| *** salv-orlando has quit IRC | 17:00 | |
| *** kashyap has joined #openstack-nova | 17:00 | |
| *** jpena|off has joined #openstack-nova | 17:00 | |
| *** migi has joined #openstack-nova | 17:00 | |
| *** markmc has joined #openstack-nova | 17:01 | |
| *** weshay has joined #openstack-nova | 17:01 | |
| coffee_cat | lyarwood: I had that thought rushing through my head as well re swap volume and reserve the new one | 17:01 |
| *** ltomasbo|away has joined #openstack-nova | 17:02 | |
| coffee_cat | coffee_cat: it was my laziness at this point that I didn't think it through, I just wanted to get something up what we can argue over :) | 17:02 |
| *** jpena|off is now known as jpena | 17:04 | |
| *** dmellado has joined #openstack-nova | 17:06 | |
| *** jpena is now known as jpena|off | 17:07 | |
| *** eglynn has quit IRC | 17:07 | |
| *** arunman has joined #openstack-nova | 17:08 | |
| *** arunman has quit IRC | 17:08 | |
| *** marst has quit IRC | 17:09 | |
| *** marst_ has joined #openstack-nova | 17:09 | |
| *** brault has joined #openstack-nova | 17:10 | |
| *** nic has joined #openstack-nova | 17:15 | |
| cfriesen | does it make sense to allow a rebuild of a boot-from-volume to a different image, given that we don't write the new image to the volume? | 17:16 |
| *** brault has quit IRC | 17:18 | |
| *** tesseract has quit IRC | 17:19 | |
| *** slaweq has joined #openstack-nova | 17:21 | |
| *** ig0r_ has quit IRC | 17:24 | |
| *** ralonsoh has quit IRC | 17:25 | |
| *** gjayavelu has joined #openstack-nova | 17:28 | |
| *** ig0r_ has joined #openstack-nova | 17:28 | |
| *** annegentle has quit IRC | 17:30 | |
| *** tuan_luong has quit IRC | 17:34 | |
| *** salv-orlando has joined #openstack-nova | 17:34 | |
| *** baoli has joined #openstack-nova | 17:39 | |
| *** esberglu has joined #openstack-nova | 17:40 | |
| *** esberglu_ has joined #openstack-nova | 17:41 | |
| *** esberglu has quit IRC | 17:41 | |
| *** baoli has quit IRC | 17:43 | |
| *** imacdonn has quit IRC | 17:46 | |
| *** zenoway has joined #openstack-nova | 17:47 | |
| *** zenoway has quit IRC | 17:51 | |
| *** mnestratov has joined #openstack-nova | 18:00 | |
| mnestratov | sdague: hi, around? | 18:02 |
| sdague | mnestratov: yeh, what's up? | 18:02 |
| mnestratov | can you take a look at https://review.openstack.org/#/c/458912/ | 18:02 |
| *** jdurgin has quit IRC | 18:04 | |
| *** yamahata_ has quit IRC | 18:04 | |
| *** owalsh_ has joined #openstack-nova | 18:06 | |
| sdague | mnestratov: my only concern with that is that we're going to need to add it back in as soon as we roll to packages | 18:08 |
| sdague | and we're going to fail some upgrades in the process | 18:09 |
| *** owalsh has quit IRC | 18:10 | |
| mnestratov | sdague: hmm, and when do we plan this? as soon as packages are ready? | 18:10 |
| *** zenoway has joined #openstack-nova | 18:11 | |
| sdague | mnestratov: yeh, centos already has new enough packages in epel, it might switch back over if epel comes back on | 18:14 |
| sdague | ubuntu has packages, but the socket interface isn't stable yet in them | 18:14 |
| *** sambetts is now known as sambetts|afk | 18:15 | |
| *** jdurgin has joined #openstack-nova | 18:15 | |
| mnestratov | I see, well, looks we shouldn't merge this at all then | 18:15 |
| *** zenoway has quit IRC | 18:15 | |
| *** yamahata_ has joined #openstack-nova | 18:22 | |
| *** rnoriega has joined #openstack-nova | 18:25 | |
| *** slagle_ has joined #openstack-nova | 18:29 | |
| *** salv-orlando has quit IRC | 18:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 18:31 |
| *** winston-d_ has quit IRC | 18:33 | |
| mriedem | i don't know how to debug this https://bugs.launchpad.net/nova/+bug/1685333 | 18:33 |
| openstack | Launchpad bug 1685333 in OpenStack Compute (nova) "Fatal Python error: Cannot recover from stack overflow. - in py35 unit test job" [High,Confirmed] | 18:33 |
| *** baoli has joined #openstack-nova | 18:39 | |
| *** amotoki has joined #openstack-nova | 18:39 | |
| *** jerrygb has quit IRC | 18:40 | |
| *** mnestratov has quit IRC | 18:41 | |
| mriedem | interesting | 18:43 |
| mriedem | live migration job failed because the destination said the guest wasn't found | 18:43 |
| mriedem | but on the source side, the logs say "You may see the error "libvirt: QEMU error: Domain not found: no domain with matching name." This error can be safely ignored." | 18:43 |
| *** amotoki has quit IRC | 18:44 | |
| *** Sukhdev has joined #openstack-nova | 18:46 | |
| mriedem | oh fun that info message is in the compute manager | 18:47 |
| mriedem | where i might not be using libvirt at all | 18:47 |
| *** ijw has joined #openstack-nova | 18:48 | |
| *** jerrygb has joined #openstack-nova | 18:49 | |
| *** imacdonn has joined #openstack-nova | 18:50 | |
| *** ijw has quit IRC | 18:52 | |
| *** mfisch has quit IRC | 18:54 | |
| *** med_ has quit IRC | 18:54 | |
| *** med_ has joined #openstack-nova | 18:54 | |
| *** mfisch has joined #openstack-nova | 18:54 | |
| mriedem | oh no wonder this goes back to diablo in a commit with no explanation | 18:54 |
| *** mfisch has quit IRC | 18:55 | |
| *** mfisch has joined #openstack-nova | 18:55 | |
| *** med_ is now known as Guest76746 | 18:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove archaic reference to QEMU errors during post live migration https://review.openstack.org/458935 | 18:56 |
| mriedem | also | 18:57 |
| mriedem | Post live migration at destination ubuntu-xenial-2-node-osic-cloud1-s3500-8527282 failed | 18:57 |
| mriedem | Migrating instance to ubuntu-xenial-2-node-osic-cloud1-s3500-8527282 finished successfully. | 18:57 |
| mriedem | wtf | 18:58 |
| kashyap | mriedem: Oops - that error message, specific to driver | 18:58 |
| mriedem | kashyap: well, it's probably from when libvirt was the only driver | 18:59 |
| kashyap | Hmm. Are other drivers, besides Xen, are well-maintained? | 18:59 |
| * kashyap should probably duck... | 18:59 | |
| mriedem | hypev | 19:00 |
| mriedem | *hyperv | 19:01 |
| *** voelzmo has joined #openstack-nova | 19:01 | |
| kashyap | Yeah. | 19:01 |
| *** fragatina has quit IRC | 19:01 | |
| kashyap | So, will Nova support Moby Containers? :P | 19:01 |
| * kashyap stops trolling now | 19:02 | |
| *** pcaruana has quit IRC | 19:02 | |
| kashyap | Was debugging a "fun" issue where exposing a CPU "L3" cache (via QEMU's "-cpu host,l3-cache=on") to a guest will improve performance by 10% or so for some SAP workloads! | 19:03 |
| *** fragatina has joined #openstack-nova | 19:03 | |
| mriedem | kashyap: you should talk to cfriesen then | 19:04 |
| mriedem | he's been looking for someone that loves qemu and libvirt for the last 3 days | 19:04 |
| kashyap | mriedem: Found out the root cause, actually | 19:04 |
| kashyap | But luckily, no action item needed for upstream Nova, Because: | 19:04 |
| kashyap | We "get it for free", with QEMU 2.8 and above. | 19:04 |
| kashyap | As it is part of the _default_ machine type | 19:04 |
| *** tbachman has quit IRC | 19:05 | |
| kashyap | So, if anyone is hitting it with Nova, using an older QEMU, still "no problem", we could use the always-handy (but voids support warranty) workaround: | 19:05 |
| kashyap | Libvirt's XML namespace <qemu:commandline> [...] </qemu:commandline> | 19:05 |
| kashyap | While upstream libvirt is trying to wire it into its QEMU command-line generator. So all good. And I can wind up for the night | 19:06 |
| mriedem | is that like injecting stuff into rabbit at runtime using erlang? | 19:06 |
| kashyap | Hehe | 19:07 |
| kashyap | cfriesen: You might be interested in this -- https://www.redhat.com/archives/libvir-list/2017-April/msg00815.html | 19:07 |
| kashyap | Unfortunately, the link won't work :-( | 19:07 |
| kashyap | As there's a major outage in one of the critical datacenters | 19:07 |
| kashyap | But rest assured, somewhere some tired admin is sweating to hell and back trying to fix the outage ... | 19:08 |
| kashyap | mriedem: But more seriously, that namespace is very handy -- we (Nova) could test interesting features and can decide: "Okay, this and that combination of QEMU command-line gives Nova users some advantage -- so let's file an RFE to get that wired up into official libvirt APIs" | 19:09 |
| mriedem | kashyap: maybe it's down b/c he was injecting stuff via qemu command line to the infra running the server | 19:09 |
| kashyap | mriedem: Yeah, that workaround should be a one-off hack only. | 19:09 |
| kashyap | Because, when using that workaroud, in logs, you'd see the instances to be marked as "tainted" (rightfully) | 19:10 |
| kashyap | Warning the opertors that: "Look, your libvirt / QEMU upgrade might break your existing guests" | 19:10 |
| kashyap | And of course, to help support people identify if someone is using unofficial command-line | 19:10 |
| mriedem | i'm much more interested in making sure the features we've already landed actually work | 19:10 |
| kashyap | mriedem: I'm all with you | 19:10 |
| mriedem | like when live migration fails and we tell you it was ok | 19:10 |
| kashyap | "Stability" over "yeah, let's bake that half-assed feature in, and let it rot after initial enthusiasm wanes" | 19:11 |
| superdan | mriedem: lol, I was trying to help with your doc patches, sorry if that was not that helpful | 19:11 |
| mriedem | superdan: you ruined EVERYTHING! | 19:12 |
| mriedem | superdan: you just have to realize the sfinucan-isms | 19:12 |
| mriedem | with .rst files | 19:12 |
| *** tbachman has joined #openstack-nova | 19:12 | |
| * superdan hangs his head in shame | 19:12 | |
| superdan | mriedem: the one thing I know about sfinucanisms is that he gives a shit about the formatting and I do not | 19:12 |
| superdan | I read it in text format | 19:12 |
| mriedem | i also care about format | 19:12 |
| mriedem | it's why sfinucan and i butt heads | 19:12 |
| superdan | well, sorry, you gonna change it? | 19:12 |
| mriedem | no, i don't really care | 19:13 |
| superdan | ack | 19:13 |
| mriedem | i'm fixing this live migration logging turd | 19:13 |
| superdan | never again shall I do that | 19:13 |
| mriedem | whilst live migration job is broken in ocata and blocking all changes | 19:13 |
| mriedem | and kashyap wants nova injecting qemu command line stuff in production, it's insane :P | 19:13 |
| kashyap | mriedem: No, no! | 19:13 |
| kashyap | You're too eager to misunderstand, aren't you? | 19:13 |
| mriedem | kashyap: i know all too well my friend | 19:14 |
| kashyap | :P | 19:14 |
| kashyap | mriedem: What is the failure? Actually Dave Gilbert from QEMU is also up and awake at this our | 19:14 |
| kashyap | I see the failure you link above is due to a bogus error message | 19:14 |
| kashyap | Is there anything more other than that? | 19:14 |
| *** mlavalle has quit IRC | 19:14 | |
| *** brault has joined #openstack-nova | 19:14 | |
| kashyap | (s/our/hour/) | 19:15 |
| kashyap | Jeez - "logging turd" | 19:15 |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: Make flavor-rxtx policy more granular flavor-rxtx currently only has one policy it checks against, which is not restrictive enough when used in conjunction with other policies (e.g., flavor-manage). This allows users a greater degree of customization. https://review.openstack.org/444036 | 19:16 |
| kashyap | mriedem: It can be fast-approved, I think? | 19:16 |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: Make flavor-rxtx policy more granular flavor-rxtx currently only has one policy it checks against, which is not restrictive enough when used in conjunction with other policies (e.g., flavor-manage). This allows users a greater degree of customization. https://review.openstack.org/444036 | 19:17 |
| *** brault has quit IRC | 19:18 | |
| mriedem | kashyap: i don't actually need someone from qemu | 19:21 |
| mriedem | i mean, i don't know why the guest wasn't found that caused this actual failure | 19:21 |
| mriedem | but that's not what i'm fixing atm | 19:21 |
| kashyap | mriedem: Thought, you were also looking at another bug which involves QEMU itself | 19:22 |
| *** fragatina has quit IRC | 19:22 | |
| *** mlavalle has joined #openstack-nova | 19:22 | |
| mriedem | well, this live migration job failed | 19:22 |
| mriedem | because during post live migration, when source calls dest to complete the migration on that side, the guest domain wasn't found | 19:23 |
| kashyap | mriedem: Got a link to a log, if you don't mind? | 19:23 |
| mriedem | even though we were in post live migration | 19:23 |
| kashyap | I think I should find one from here: logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/ | 19:23 |
| mriedem | yes | 19:23 |
| * kashyap now remembers by memory: "subnode2" == source logs | 19:24 | |
| kashyap | The root dir (gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/) has destination logs | 19:25 |
| mriedem | http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/screen-n-cpu.txt.gz#_2017-04-21_13_54_10_150 | 19:25 |
| mriedem | yes ^ is the dest logs | 19:25 |
| * kashyap nods | 19:27 | |
| mriedem | http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/libvirt/qemu/instance-00000001.txt.gz | 19:28 |
| mriedem | /build/qemu-5OJ39u/qemu-2.8+dfsg/nbd/server.c:nbd_receive_request():L710: read failed 2017-04-21 13:54:08.792+0000: shutting down, reason=failed | 19:28 |
| *** dikonoo has quit IRC | 19:28 | |
| *** cleong has quit IRC | 19:28 | |
| kashyap | For future note: Incidentally, we're going to get finer-grained details about shutdown reasons | 19:29 |
| kashyap | Whether it is guest-triggered, or host-triggerred | 19:29 |
| kashyap | And what precisely caused it, etc | 19:29 |
| kashyap | (There's a long thread on qemu-devel upstream, to iron out the details.) | 19:30 |
| mriedem | well, /build/qemu-5OJ39u/qemu-2.8+dfsg/nbd/server.c:nbd_receive_request():L710: read failed | 19:31 |
| mriedem | caused it | 19:31 |
| mriedem | i guess | 19:31 |
| *** haplo37 has quit IRC | 19:31 | |
| *** nkorabli_ has joined #openstack-nova | 19:31 | |
| kashyap | Yes, I recall seeing that | 19:31 |
| * kashyap looks for detaiils | 19:31 | |
| mriedem | /build/qemu-5OJ39u/qemu-2.8+dfsg/nbd/server.c:nbd_receive_request():L710: read failed | 19:32 |
| mriedem | oops | 19:32 |
| kashyap | mriedem: Yep, I recall it | 19:33 |
| mriedem | http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/libvirt/libvirtd.txt.gz#_2017-04-21_13_54_08_792 | 19:33 |
| kashyap | I even reported it recently here: http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg01086.html | 19:33 |
| kashyap | Quoting myself: | 19:33 |
| kashyap | Just writing for completeness' sake, if you try to stop the NBD server | 19:33 |
| kashyap | on the destination, _without_ gracefully completing or cancelling the | 19:33 |
| kashyap | `drive-mirror` job on the source, you see the below: | 19:33 |
| kashyap | [...] | 19:33 |
| kashyap | {"execute":"nbd-server-stop"} | 19:33 |
| kashyap | {"return": {}} | 19:33 |
| kashyap | /home/stack/src/qemu/nbd/server.c:nbd_receive_request():L706: read failed | 19:33 |
| kashyap | [...] | 19:33 |
| *** nkorabli has quit IRC | 19:34 | |
| mriedem | kashyap: so this is a known bug in qemu? | 19:35 |
| kashyap | mriedem: It's actually benign | 19:35 |
| kashyap | Because: | 19:35 |
| kashyap | It means the source has gone away unexpectedly or that you stopped the NBD server before the source was disconnected | 19:35 |
| kashyap | I know Nova shouldn't care this level of detail. | 19:36 |
| *** haplo37 has joined #openstack-nova | 19:36 | |
| kashyap | I'm checking if my discussion resulted in another patch | 19:36 |
| *** cdent has joined #openstack-nova | 19:36 | |
| mriedem | around that same time in syslog http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/syslog.txt.gz#_Apr_21_13_54_08 | 19:37 |
| kashyap | mriedem: What were you trying to quote in the previous libvirtd log? Your link seems broken here | 19:37 |
| *** voelzmo has quit IRC | 19:38 | |
| mriedem | that's where it failed | 19:38 |
| mriedem | 2017-04-21 13:54:08.792+0000: 12165: debug : qemuProcessStop:5941 : Shutting down vm=0x7f918c009d40 name=instance-00000001 id=2 pid=5792, reason=failed, asyncJob=migration in, flags=1 | 19:38 |
| mriedem | then around that time in syslog | 19:39 |
| mriedem | Apr 21 13:54:08ubuntu-xenial-2-node-osic-cloud1-s3500-8527282 virtlogd[12188]: End of file while reading data: Input/output error | 19:39 |
| kashyap | But _what_ caused the guest shutdown... | 19:40 |
| mriedem | no idea | 19:40 |
| kashyap | mriedem: Checking with Eric Blake & Max, both should know this code in libvirt / QEMU respectively | 19:42 |
| -openstackstatus- NOTICE: Gerrit will be offline briefly starting at 20:00 for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 19:42 | |
| *** rdo has quit IRC | 19:48 | |
| *** rnoriega has quit IRC | 19:49 | |
| *** Apoorva has quit IRC | 19:49 | |
| *** rdo has joined #openstack-nova | 19:49 | |
| *** fragatina has joined #openstack-nova | 19:50 | |
| cdent | thank you mriedem, someone had to respond to leakypipes | 19:52 |
| kashyap | mriedem: Is this mig. failure blocking Gate? | 19:53 |
| *** baoli has quit IRC | 19:54 | |
| *** ig0r_ has quit IRC | 19:55 | |
| kashyap | At least, I found out (w/ help from Max) the commit that introduced it. | 19:55 |
| mriedem | cdent: ha | 19:56 |
| mriedem | kashyap: i think this is probably random failure | 19:56 |
| kashyap | mriedem: Ah, okay, good. | 19:57 |
| kashyap | The actual culprit failure is on the source host: | 19:57 |
| kashyap | http://logs.openstack.org/43/458843/1/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/697a501/logs/subnode-2/libvirt/qemu/instance-00000001.txt.gz | 19:57 |
| mriedem | stable/ocata is blocked b/c of the live migration job, and to fix that i need to get this other change in, but i think this is just an intermittent failure | 19:57 |
| mriedem | oh fun | 19:57 |
| mriedem | qemu-system-x86_64: /build/qemu-5OJ39u/qemu-2.8+dfsg/block/io.c:1514: bdrv_co_pwritev: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed. | 19:57 |
| kashyap | Yep | 19:57 |
| mriedem | i have no idea what that means | 19:57 |
| *** felipemonteiro has quit IRC | 19:58 | |
| *** ericyoung has joined #openstack-nova | 19:59 | |
| *** awaugama has quit IRC | 19:59 | |
| *** smatzek has quit IRC | 20:02 | |
| kashyap | mriedem: It means (according to the QEMU commit that introduced it): | 20:02 |
| kashyap | Something tried to write to the image file on the source, _while_ it is being migrated | 20:03 |
| -openstackstatus- NOTICE: Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 20:03 | |
| kashyap | Anyway, it's unreasonably late here, I'll get to this on Monday | 20:03 |
| *** ChanServ changes topic to "Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html" | 20:03 | |
| kashyap | Cool; Gerrit is also offline on time. Everything is in harmony, and the earth keeps spinning | 20:04 |
| mriedem | kashyap: ack, thanks for taking a look | 20:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not log live migration success when it actually failed https://review.openstack.org/458958 | 20:06 |
| mriedem | superdan: dig this ^ | 20:06 |
| mriedem | sdague: ^ you too | 20:06 |
| mriedem | classic terrible | 20:06 |
| *** Sukhdev has quit IRC | 20:07 | |
| superdan | mriedem: does that cleanup flags thing tell us not to destroy disks, etc in the case of failure? | 20:08 |
| superdan | like, I'm surprised that falling through is the right thing to do | 20:08 |
| openstackgerrit | Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877 | 20:09 |
| superdan | mriedem: doesn't look like it does to me | 20:09 |
| *** xyang1 has quit IRC | 20:10 | |
| superdan | mriedem: so if we fail, have not shared path, we'll do_cleanup=True and tell the driver to run cleanup right? | 20:10 |
| *** jerrygb has quit IRC | 20:10 | |
| mriedem | looks that way | 20:11 |
| superdan | and libvirt goes right into deleting stuff | 20:11 |
| mriedem | even though you should be rolling back | 20:11 |
| mriedem | but this isn't where rollback is called from | 20:11 |
| *** nic has quit IRC | 20:12 | |
| superdan | right, this is if post-at-destination fails, which presumably could fail for some mundane reason and then we eff things up by doing the cleanup | 20:12 |
| *** Apoorva has joined #openstack-nova | 20:12 | |
| *** slagle_ has quit IRC | 20:12 | |
| mriedem | is live_migration started from the source or dest host? | 20:12 |
| superdan | source | 20:13 |
| mriedem | oh right it has the dest parameter | 20:13 |
| mriedem | i lose track of the musical chairs game that is live migration | 20:13 |
| superdan | yeah it's confusing | 20:13 |
| mriedem | so the source side though it was done, and calls _post_live_migration (source compute stiffl) | 20:14 |
| mriedem | *still | 20:14 |
| mriedem | which does an rpc call to post_live_migration_at_destination on the dest host | 20:15 |
| superdan | oh, we don't get here unless it actually migrated | 20:15 |
| mriedem | that fails becuase the guest isn't found on the dest host | 20:15 |
| superdan | and then we just failed in the post call, but whatever, we don't own it anymore | 20:15 |
| mriedem | yeah post_live_migration_at_destination fails and returns the failure back through rpc | 20:16 |
| mriedem | we get the failure, log the trace "Post live migration at destination %s failed" | 20:17 |
| superdan | right, so I guess it's okay | 20:17 |
| mriedem | then drop through and start cleaning up the source | 20:17 |
| superdan | we don't get to this post method unless libvirt said it worked | 20:17 |
| superdan | so we can clean up regardless | 20:17 |
| mriedem | meanwhile, the guest is not on the dest either | 20:17 |
| mriedem | yeah | 20:17 |
| superdan | yeah, but nothing we can do about it | 20:17 |
| mriedem | so basically, | 20:17 |
| mriedem | your sh is f'ed | 20:17 |
| mriedem | and you instance is gone | 20:17 |
| mriedem | *your | 20:17 |
| superdan | yeah, I just wanted to make sure we didn't delete the thing if migration failed | 20:17 |
| superdan | that's a double kick in the pands | 20:17 |
| mriedem | meanwhile we've deleted your disks | 20:18 |
| mriedem | this is really like, well, it's all busted, oh and btw we deleted your instance | 20:18 |
| mriedem | you're welcome | 20:18 |
| superdan | whatever, libvirt told us to :) | 20:18 |
| mriedem | wow | 20:18 |
| mriedem | remind me to never run live migration if i'm in ops | 20:18 |
| superdan | if libvirt told us it was done, then there should be disks on the other side too | 20:18 |
| mriedem | yeah hopefully | 20:19 |
| superdan | it's scary how many people depend on live migration | 20:19 |
| coffee_cat | lyarwood: are you around? | 20:24 |
| *** jerrygb has joined #openstack-nova | 20:25 | |
| *** felipemonteiro has joined #openstack-nova | 20:26 | |
| *** felipemonteiro has quit IRC | 20:26 | |
| coffee_cat | or anyone who could/would answer stupid BDM questions | 20:27 |
| mriedem | i can answer stupid questions | 20:27 |
| mriedem | coffee_cat: are you in budapest right now? | 20:27 |
| mriedem | or the US? | 20:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 20:27 |
| coffee_cat | mriedem: in the US until tomorrow evening | 20:28 |
| mriedem | oh, lee is in the UK | 20:28 |
| mriedem | so he's in a pub somewhere | 20:28 |
| coffee_cat | mriedem: will fly back next Sunday though... | 20:28 |
| *** felipemonteiro has joined #openstack-nova | 20:28 | |
| coffee_cat | mriedem: ah, I forgot | 20:28 |
| coffee_cat | mriedem: anyhow, I'm sure you can help me out here to understand what's going on :) | 20:29 |
| coffee_cat | mriedem: so his comments are here: https://review.openstack.org/#/c/456971/2/nova/compute/manager.py | 20:29 |
| coffee_cat | mriedem: and I started to wonder whether the BDM is host or instance specific? if this question even makes sense... | 20:30 |
| mriedem | the bdm is instance + volume specific | 20:31 |
| mriedem | so we get the bdm for the instance and existing (old) volume on L5011 | 20:31 |
| mriedem | the connector is specific to the host | 20:33 |
| mriedem | well, host + instance | 20:33 |
| mriedem | so in the old way, after we swap the volume, we terminate the connection for the old volume, | 20:35 |
| *** satyar has quit IRC | 20:35 | |
| mriedem | and then update the bdm with the new connection_info for the new volume | 20:36 |
| *** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. Please see: https://wiki.openstack.org/wiki/Nova/Ocata_Release_Schedule" | 20:36 | |
| -openstackstatus- NOTICE: Gerrit is back in service and generally usable, though remote Git replicas (git.openstack.org and github.com) will be stale for the next few hours until online reindexing completes | 20:36 | |
| *** amotoki has joined #openstack-nova | 20:40 | |
| mriedem | coffee_cat: left comments inline | 20:41 |
| mriedem | coffee_cat: this was also called out in john's spec i believe | 20:41 |
| mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/cinder-new-attach-apis.html#swap-volume | 20:41 |
| coffee_cat | mriedem: ok, cool, makes sense, so basically need to create a new attachment for the new volume | 20:42 |
| coffee_cat | and we might not be able to consolidate the workflow that much, but oh well | 20:42 |
| mriedem | yes | 20:42 |
| mriedem | where we used to call initialize_connection for the new volume, now we'll need to create a new attachment | 20:43 |
| mriedem | for the new volume | 20:43 |
| coffee_cat | ok, that sounds easily doable | 20:43 |
| mriedem | if everything is ok, we delete the old attachment for the old volume and update the bdm with the new attachment_id | 20:43 |
| mriedem | john's spec is talking about doing things in the api too, which i'm not really following | 20:44 |
| mriedem | (api) create new attachment for the volume uuid-new, fail API call if we can’t create that attachment | 20:44 |
| mriedem | ^ is what i was saying we could do on the compute where initialize_connection is called for the new volume | 20:44 |
| mriedem | we could create the attachment for the new volume in the api, but we don't have a bdm for that | 20:45 |
| mriedem | so not sure how we get that in the compute, unless we lookup the new volume details and get it's attachment list | 20:45 |
| coffee_cat | yeah, BDM is problematic :/ | 20:45 |
| *** slaweq has quit IRC | 20:45 | |
| *** slaweq has joined #openstack-nova | 20:45 | |
| *** amotoki has quit IRC | 20:46 | |
| mriedem | maybe he just meant create the new attachment in the api so we can fail fast | 20:46 |
| mriedem | but, | 20:46 |
| coffee_cat | probably as that was a topic many times | 20:46 |
| mriedem | we'd only do that if we knew the old attached volume was created with the new flow i htink | 20:46 |
| mriedem | *think | 20:47 |
| *** ociuhandu has joined #openstack-nova | 20:47 | |
| mriedem | i'm not sure if that matters or not | 20:47 |
| mriedem | but it probably does | 20:47 |
| coffee_cat | so the volume is always created the same way | 20:47 |
| mriedem | this is all new flow stuff | 20:47 |
| mriedem | "In this section, we talk about what happens should the volume being swapped have the attachment_id present in the BDM, and as such we follow the new flow." | 20:47 |
| mriedem | yeah, so if the bdm.attachment_id is set, we key off that for all of the swap volume goodies outlined in the spec | 20:48 |
| *** openstackgerrit has quit IRC | 20:48 | |
| mriedem | like creating a new attachment for the new volume, etc | 20:48 |
| coffee_cat | and for the new volume we can create that with the new flow | 20:48 |
| coffee_cat | if the API is available | 20:49 |
| mriedem | well i think the point is, you can't swap from a volume attachd the old way, to a volume attached the new way | 20:49 |
| mriedem | you have to swap from attached new way to attached new way | 20:49 |
| mriedem | if that makes sense | 20:49 |
| mriedem | i don't know if technically it makes a difference on the cinder side | 20:49 |
| coffee_cat | I don't really see why not, but as we go by attachment_id in the BDM anyhow it pretty much doesn't matter | 20:49 |
| sdague | mriedem: it would be less terrible if you used the fixture that actually captures the log stream | 20:49 |
| *** baoli has joined #openstack-nova | 20:49 | |
| mriedem | coffee_cat: the reason john and i said to do it this way in the spec is so nothing else in the code does anything using the new apis until we've plumbed in support for attaching volumes the new way | 20:50 |
| smcginnis | mriedem: Should be OK on the Cinder side as long as each volume has its attachment info. | 20:50 |
| mriedem | since everything keys off that | 20:50 |
| coffee_cat | in the sense that we only detach --> attach with the new flow if the BDM.attachment_id is set | 20:50 |
| smcginnis | mriedem: ie, we don't do some silly DB swap of some data to "make it easier" | 20:50 |
| mriedem | coffee_cat: i think i'm agreeing with you | 20:51 |
| mriedem | the thing i don't like about https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/cinder-new-attach-apis.html#swap-volume and creating the new attachment for the new volume in the API is, we'd have to do a service version check on that b/c we wouldn't know if the compute we're going to cast to is new enough to understand what we're doing | 20:51 |
| coffee_cat | mriedem: ok, if we want to do this in the API, where we don't have the BDM that's another thing | 20:51 |
| mriedem | i don't think we want to do it in the api | 20:52 |
| mriedem | since that logic relies on if the compute is new enough i think | 20:52 |
| mriedem | if we're casting to an ocata compute, it's not going to have any of this new bdm.attachment_id code | 20:52 |
| coffee_cat | although there we need to check whether the new Cinder API is available, etc. | 20:52 |
| mriedem | well, that's why we key off bdm.attachment_id, | 20:52 |
| mriedem | if that is set, we're using new api | 20:52 |
| *** kiwi_rot has joined #openstack-nova | 20:52 | |
| mriedem | that's why new style attach comes at the very end | 20:53 |
| mriedem | since everything else keys off that | 20:53 |
| coffee_cat | mriedem: yeah, on the compute it's all fine and I think we're on the same page if we keep things there | 20:53 |
| mriedem | coffee_cat: ok i can amend the spec for that | 20:53 |
| mriedem | when i add in the stuff we talked about this morning | 20:53 |
| mriedem | about begin_detaching | 20:53 |
| coffee_cat | mriedem: sounds good, thank you | 20:53 |
| *** yamamoto has joined #openstack-nova | 20:54 | |
| *** baoli has quit IRC | 20:57 | |
| *** kiwi_rot has quit IRC | 20:57 | |
| *** tbachman has quit IRC | 20:57 | |
| *** felipemonteiro has quit IRC | 20:58 | |
| *** yamamoto has quit IRC | 20:58 | |
| *** thorst has quit IRC | 21:03 | |
| *** xyang1 has joined #openstack-nova | 21:10 | |
| mriedem | maybe john had us creating the new attachment in the api in place of calling reserve on the new volume | 21:12 |
| mriedem | but i thought with the new flow, we still called reserve when doing an attach? | 21:13 |
| mriedem | coffee_cat: do you remember? ^ | 21:13 |
| mriedem | the spec doesn't talk about reserve | 21:14 |
| mriedem | hmm, the cinder spec talks about it http://specs.openstack.org/openstack/cinder-specs/specs/ocata/add-new-attach-apis.html#proposed-change | 21:15 |
| mriedem | "If the connector is not specified this call will only complete the volume reservation step and create an empty volume attachment. This can be used by Nova to call it from the API and start the volume attaching process by checking that the volume is available and creates the empty attachment." | 21:15 |
| *** brault has joined #openstack-nova | 21:15 | |
| mriedem | and in the nova spec | 21:16 |
| mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/cinder-new-attach-apis.html#proposed-change | 21:16 |
| mriedem | "In addition we should only use the new API when all of the nova-compute nodes have been upgraded." | 21:16 |
| mriedem | so if we only create a new attachment when cinder 3.27 is available and all computes are upgraded, then during swap_volume we can create the new attachment for the new volume based on bdm.attachment_id being set for the old volume | 21:17 |
| mriedem | we could pass the new attachment_id over rpc to swap_volume on the compute | 21:17 |
| coffee_cat | mriedem: we don't call reserve with the new flow | 21:18 |
| mriedem | coffee_cat: yeah ok so then we need to create the new attachment in the api | 21:18 |
| coffee_cat | mriedem: attachment_create without connector acts as reserve in the sense of putting the volume in 'reserved' state | 21:18 |
| mriedem | and pass the attachment id down to the compute over rpc, or the compute can look it up | 21:19 |
| coffee_cat | I guess passing it to the compute should be fine if we don't want to call out to Cinder that much | 21:19 |
| *** brault has quit IRC | 21:20 | |
| mriedem | the compute could lookup the attachments for the new volume... | 21:20 |
| mriedem | since the cinder api isn't documented, i don't know what it looks like | 21:21 |
| *** karimb has quit IRC | 21:21 | |
| coffee_cat | mriedem: also we need to figure out on the compute too how to finalize the attachment process | 21:21 |
| coffee_cat | we might do that by using receiving an attachment_id from the API as a trigger | 21:21 |
| coffee_cat | or list the attachments with the call from the new flow too I guess | 21:22 |
| *** tbachman has joined #openstack-nova | 21:23 | |
| mriedem | we update the attachment with the connector | 21:23 |
| coffee_cat | I meant that we need to know on the compute that the API reserved the volume with the new flow | 21:24 |
| coffee_cat | and we need to call attachment_update at some point | 21:24 |
| coffee_cat | with the connector | 21:25 |
| *** nic has joined #openstack-nova | 21:25 | |
| mriedem | if bdm.attachment_id is set, we know the api reserved the new volume with the new flow | 21:25 |
| mriedem | so i think https://review.openstack.org/#/c/456971/ gets more complicated than just updating the compute code | 21:25 |
| mriedem | it should also be the api code | 21:25 |
| mriedem | and the rpc api changes | 21:25 |
| mriedem | unless we just want to lookup the new attachment via rest api | 21:26 |
| mriedem | i just don't know if we have that support yet in cinderclient | 21:26 |
| mriedem | i could help work on this if you want | 21:26 |
| mriedem | i just can't do it today | 21:27 |
| *** tjones has joined #openstack-nova | 21:27 | |
| *** thorst has joined #openstack-nova | 21:27 | |
| mriedem | it would be great if you guys could get the v3.27 APIs documented in https://developer.openstack.org/api-ref/block-storage/v3/ | 21:28 |
| mriedem | you == all of cinder | 21:28 |
| mriedem | and by "guys" i mean guys and gals and those that don't identify as guys or gals, of course | 21:28 |
| *** Sukhdev has joined #openstack-nova | 21:30 | |
| coffee_cat | mriedem: got it :) | 21:31 |
| *** smatzek has joined #openstack-nova | 21:31 | |
| mriedem | it looks like from the compute we could list attachments and filter on instance_uuid | 21:31 |
| coffee_cat | and yeah, if the bdm.attachment_id is set then all computes should be on the high enough version, etc. | 21:31 |
| coffee_cat | we should definitely be able to do that if we want to skip the rpc changes, which I'm totally fine with | 21:32 |
| mriedem | we could get attachments via cinderclient for a given volume and instance | 21:32 |
| *** thorst has quit IRC | 21:32 | |
| mriedem | using filters it looks like | 21:32 |
| jgriffith | mriedem correct | 21:32 |
| *** smatzek has quit IRC | 21:32 | |
| mriedem | if we got more than one attachment back...idk | 21:33 |
| *** smatzek has joined #openstack-nova | 21:33 | |
| mriedem | we shouldn't today since we don't support multiattach | 21:33 |
| mriedem | but it gets weird | 21:33 |
| mriedem | that's probably why it's just better to pass the new attachment id over rpc | 21:33 |
| jgriffith | mriedem right, for today that’s our safety net | 21:33 |
| mriedem | to the compute | 21:33 |
| mriedem | rather than hae the compute guess | 21:33 |
| *** ijw has joined #openstack-nova | 21:33 | |
| jgriffith | BUT, there’s a get-attachment | 21:33 |
| coffee_cat | mriedem: although for live migrate etc we should be able to have multiple attachments for the same volume | 21:33 |
| coffee_cat | which should not make a mess for swap volume, but still | 21:33 |
| mriedem | i think passing over rpc is safest | 21:33 |
| mriedem | then compute doesn't need to decide | 21:34 |
| mriedem | again, i can help with this later, but i'm getting in trouble for hiding in the office when it's a nice day out | 21:34 |
| coffee_cat | agreed | 21:34 |
| mriedem | so i'm forcefully detaching from this computer, ttyl | 21:34 |
| *** jamesdenton has quit IRC | 21:34 | |
| *** bauwser is now known as bauzas | 21:34 | |
| coffee_cat | mriedem: have a good weekend :) | 21:34 |
| *** salv-orlando has joined #openstack-nova | 21:38 | |
| *** fragatin_ has joined #openstack-nova | 21:42 | |
| *** amotoki has joined #openstack-nova | 21:42 | |
| *** fragatina has quit IRC | 21:45 | |
| *** amotoki has quit IRC | 21:47 | |
| *** dimtruck is now known as zz_dimtruck | 21:47 | |
| *** salv-orl_ has joined #openstack-nova | 21:49 | |
| *** salv-orlando has quit IRC | 21:52 | |
| *** nic has quit IRC | 21:55 | |
| *** smatzek has quit IRC | 21:55 | |
| *** marst_ has quit IRC | 21:56 | |
| *** burt has quit IRC | 21:56 | |
| *** baoli has joined #openstack-nova | 21:57 | |
| *** mdrabe has quit IRC | 22:00 | |
| *** baoli has quit IRC | 22:02 | |
| *** Apoorva_ has joined #openstack-nova | 22:03 | |
| *** Apoorva has quit IRC | 22:06 | |
| *** fragatin_ has quit IRC | 22:08 | |
| *** fragatina has joined #openstack-nova | 22:09 | |
| *** openstackgerrit has joined #openstack-nova | 22:14 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: nova.utils.get_service_url(group) https://review.openstack.org/458257 | 22:14 |
| efried | mriedem johnthetubaguy mordred If possible I'd like y'all to start looking at ^^ - let me know if the approach is remotely sane, and maybe answer some of the open questions in the comments. | 22:15 |
| efried | Wait, was it johnthetubaguy or jaypipes? Well, jaypipes isn't here, so... | 22:15 |
| mordred | it was jay - I have it open in my browser - I'm heads down on a different patch at the moment, but I'll come back and give you some feedback RSN | 22:17 |
| mordred | leakypipes: ^^ | 22:18 |
| efried | mordred Thanks. No hurry, think I'm gonna bounce for the night. | 22:22 |
| *** thorst has joined #openstack-nova | 22:22 | |
| *** jdurgin has quit IRC | 22:29 | |
| *** slaweq has quit IRC | 22:33 | |
| *** slaweq has joined #openstack-nova | 22:34 | |
| *** thorst has quit IRC | 22:37 | |
| *** slaweq has quit IRC | 22:38 | |
| *** slaweq has joined #openstack-nova | 22:44 | |
| *** Sukhdev has quit IRC | 22:45 | |
| *** lyan has quit IRC | 22:45 | |
| *** catintheroof has quit IRC | 22:46 | |
| *** zz_dimtruck is now known as dimtruck | 22:47 | |
| *** cdent has quit IRC | 22:47 | |
| *** baoli has joined #openstack-nova | 22:47 | |
| *** salv-orl_ has quit IRC | 22:48 | |
| *** dtp has quit IRC | 22:51 | |
| *** gjayavelu has quit IRC | 23:01 | |
| *** masber has quit IRC | 23:02 | |
| *** masber has joined #openstack-nova | 23:04 | |
| *** gjayavelu has joined #openstack-nova | 23:05 | |
| *** Apoorva_ has quit IRC | 23:07 | |
| *** Apoorva has joined #openstack-nova | 23:07 | |
| *** thorst has joined #openstack-nova | 23:08 | |
| *** edmondsw has quit IRC | 23:09 | |
| *** edmondsw has joined #openstack-nova | 23:09 | |
| *** abalutoiu_ has joined #openstack-nova | 23:10 | |
| *** erhudy has quit IRC | 23:10 | |
| *** thorst has quit IRC | 23:12 | |
| *** abalutoiu__ has joined #openstack-nova | 23:13 | |
| *** owalsh_ is now known as owalsh | 23:13 | |
| *** abalutoiu has quit IRC | 23:14 | |
| *** edmondsw has quit IRC | 23:14 | |
| *** nkorabli_ has quit IRC | 23:16 | |
| *** chyka has quit IRC | 23:16 | |
| *** brault has joined #openstack-nova | 23:16 | |
| leakypipes | mriedem: oh, you didn't appreciate my playground rock-paper-scissors humour? boo. | 23:16 |
| *** abalutoiu_ has quit IRC | 23:16 | |
| *** nkorabli has joined #openstack-nova | 23:17 | |
| *** abalutoiu has joined #openstack-nova | 23:17 | |
| *** esberglu_ has quit IRC | 23:17 | |
| *** abalutoiu__ has quit IRC | 23:18 | |
| *** owalsh_ has joined #openstack-nova | 23:19 | |
| *** Eugene has joined #openstack-nova | 23:19 | |
| *** Eugene has left #openstack-nova | 23:19 | |
| *** baoli has quit IRC | 23:20 | |
| *** brault has quit IRC | 23:20 | |
| *** nkorabli has quit IRC | 23:21 | |
| *** owalsh has quit IRC | 23:22 | |
| *** sdague has quit IRC | 23:24 | |
| *** baoli has joined #openstack-nova | 23:25 | |
| *** baoli has quit IRC | 23:26 | |
| *** dixiaoli has joined #openstack-nova | 23:30 | |
| *** gjayavelu has quit IRC | 23:31 | |
| *** dixiaoli has quit IRC | 23:35 | |
| *** thorst has joined #openstack-nova | 23:38 | |
| *** gouthamr has joined #openstack-nova | 23:39 | |
| *** yamahata_ has quit IRC | 23:40 | |
| *** gouthamr has quit IRC | 23:44 | |
| *** owalsh has joined #openstack-nova | 23:44 | |
| *** owalsh_ has quit IRC | 23:44 | |
| *** tuan_luong has joined #openstack-nova | 23:49 | |
| *** tuan_luong has quit IRC | 23:54 | |
| *** yamamoto has joined #openstack-nova | 23:56 | |
| *** gouthamr has joined #openstack-nova | 23:57 | |
| *** thorst has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!