| *** Apoorva_ has quit IRC | 00:01 | |
| *** jamesdenton has quit IRC | 00:01 | |
| *** Apoorva has joined #openstack-nova | 00:01 | |
| *** jamesdenton has joined #openstack-nova | 00:03 | |
| *** dharinic has quit IRC | 00:04 | |
| *** diga has joined #openstack-nova | 00:05 | |
| *** ngupta has quit IRC | 00:11 | |
| *** jamesdenton has quit IRC | 00:13 | |
| *** faizy_ has quit IRC | 00:15 | |
| *** jamesdenton has joined #openstack-nova | 00:15 | |
| *** hongbin has quit IRC | 00:15 | |
| *** jamesdenton has quit IRC | 00:19 | |
| *** jamesdenton has joined #openstack-nova | 00:23 | |
| openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.unrescue notifications https://review.openstack.org/388275 | 00:24 |
|---|---|---|
| *** thorst has quit IRC | 00:27 | |
| *** dtp has quit IRC | 00:27 | |
| *** tjones has joined #openstack-nova | 00:28 | |
| *** jamesdenton has quit IRC | 00:34 | |
| *** zhurong has joined #openstack-nova | 00:42 | |
| *** winston-d_ has joined #openstack-nova | 00:43 | |
| *** gjayavelu has quit IRC | 00:45 | |
| *** jamesdenton has joined #openstack-nova | 00:49 | |
| *** crushil has joined #openstack-nova | 00:51 | |
| *** huanxie has joined #openstack-nova | 00:52 | |
| *** mriedem has quit IRC | 00:53 | |
| *** Swami has quit IRC | 01:00 | |
| *** Apoorva_ has joined #openstack-nova | 01:00 | |
| *** tovin07_ has joined #openstack-nova | 01:02 | |
| *** Apoorva has quit IRC | 01:04 | |
| *** Apoorva_ has quit IRC | 01:04 | |
| *** cNilesh has joined #openstack-nova | 01:05 | |
| *** ijw has joined #openstack-nova | 01:09 | |
| *** tjones has quit IRC | 01:09 | |
| *** ubuntu-mate_ has joined #openstack-nova | 01:11 | |
| *** ubuntu-mate_ has quit IRC | 01:11 | |
| *** ngupta has joined #openstack-nova | 01:12 | |
| *** thorst has joined #openstack-nova | 01:12 | |
| *** thorst has quit IRC | 01:12 | |
| *** kevinz has joined #openstack-nova | 01:13 | |
| *** ijw has quit IRC | 01:14 | |
| *** MasterOfBugs has quit IRC | 01:16 | |
| *** NikhilS has joined #openstack-nova | 01:20 | |
| *** jamesdenton has quit IRC | 01:22 | |
| openstackgerrit | shaofeng cheng proposed openstack/nova master: Update etherpad url https://review.openstack.org/457198 | 01:23 |
| *** tbachman has quit IRC | 01:26 | |
| *** ijw has joined #openstack-nova | 01:27 | |
| *** esberglu has joined #openstack-nova | 01:29 | |
| *** esberglu has quit IRC | 01:29 | |
| *** esberglu has joined #openstack-nova | 01:29 | |
| *** esberglu has quit IRC | 01:29 | |
| *** esberglu has joined #openstack-nova | 01:30 | |
| *** fragatin_ has joined #openstack-nova | 01:30 | |
| *** fragatin_ has quit IRC | 01:30 | |
| *** fragatin_ has joined #openstack-nova | 01:31 | |
| *** fragatin_ has quit IRC | 01:31 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230 | 01:31 |
| *** ngupta has quit IRC | 01:33 | |
| *** ngupta has joined #openstack-nova | 01:33 | |
| *** fragatina has quit IRC | 01:33 | |
| *** esberglu has quit IRC | 01:34 | |
| *** fragatina has joined #openstack-nova | 01:36 | |
| *** gcb has joined #openstack-nova | 01:39 | |
| *** MasterOfBugs has joined #openstack-nova | 01:40 | |
| *** fragatin_ has joined #openstack-nova | 01:40 | |
| *** fragatina has quit IRC | 01:41 | |
| *** fragatin_ has quit IRC | 01:41 | |
| *** jamesdenton has joined #openstack-nova | 01:41 | |
| *** ijw has quit IRC | 01:44 | |
| *** scottda has quit IRC | 01:45 | |
| *** hongbin has joined #openstack-nova | 01:45 | |
| *** ijw has joined #openstack-nova | 01:48 | |
| *** iceyao has joined #openstack-nova | 01:51 | |
| *** ijw has quit IRC | 01:52 | |
| *** ssurana has joined #openstack-nova | 01:54 | |
| *** jamesdenton has quit IRC | 01:54 | |
| *** vishwanathj has joined #openstack-nova | 01:56 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix response code and parameters in evacuate https://review.openstack.org/457167 | 01:57 |
| *** vishwanathj has quit IRC | 01:58 | |
| *** vishwanathj has joined #openstack-nova | 01:58 | |
| *** vishwanathj has quit IRC | 02:03 | |
| *** iceyao has quit IRC | 02:03 | |
| *** vishwanathj has joined #openstack-nova | 02:04 | |
| *** iceyao has joined #openstack-nova | 02:04 | |
| *** nic has quit IRC | 02:08 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove json-schema extension variable for resize https://review.openstack.org/457430 | 02:10 |
| oomichi | gmann: alex_xu: ^^^ is easy one | 02:11 |
| *** thorst has joined #openstack-nova | 02:13 | |
| *** yamahata has quit IRC | 02:14 | |
| alex_xu | oomichi: got it | 02:14 |
| *** jamesdenton has joined #openstack-nova | 02:14 | |
| *** jamesdenton has quit IRC | 02:16 | |
| *** thorst has quit IRC | 02:18 | |
| gmann | oomichi: +1, i did search final schema for resize due to that name, thanks | 02:19 |
| alex_xu | oomichi: done | 02:20 |
| oomichi | gmann: alex_xu: thanks :) | 02:20 |
| alex_xu | oomichi: np | 02:21 |
| *** jamesdenton has joined #openstack-nova | 02:21 | |
| oomichi | gmann: yeah, I found this on the review of https://review.openstack.org/455570 | 02:21 |
| oomichi | gmann: I guessed the resize jsonschema was extended from the name, but actually not. so it would be better to rename | 02:22 |
| gmann | oomichi: yea | 02:22 |
| *** hshiina has joined #openstack-nova | 02:26 | |
| *** TheJulia has quit IRC | 02:26 | |
| *** gouthamr has quit IRC | 02:27 | |
| *** khappone_ has quit IRC | 02:27 | |
| *** khappone has joined #openstack-nova | 02:27 | |
| *** rajinir has quit IRC | 02:28 | |
| oomichi | takashin: can you take a look at https://review.openstack.org/#/c/457167 ? I am not sure the error status code 503 also is necessary for evacuate API | 02:28 |
| takashin | oomichi: Thank you for your review. | 02:29 |
| *** TheJulia has joined #openstack-nova | 02:29 | |
| takashin | oomichi: I don't know 503 is necessary or not, too. | 02:30 |
| *** rajinir has joined #openstack-nova | 02:30 | |
| oomichi | takashin: I did some investigation now and actually APIs which could return 503 are fping and tenant-network only | 02:33 |
| oomichi | takashin: the corresponding api-ref contains it on these APIs. | 02:33 |
| oomichi | takashin: the other api-ref which includes this case should be invalid I think now | 02:34 |
| takashin | oomihi: Thanks. I will remove 503 in evacuate API reference. | 02:34 |
| oomichi | takashin: cool, thanks | 02:34 |
| *** hongbin_ has joined #openstack-nova | 02:34 | |
| *** hongbin_ has quit IRC | 02:36 | |
| *** hongbin has quit IRC | 02:36 | |
| *** hongbin has joined #openstack-nova | 02:37 | |
| *** jamesdenton has quit IRC | 02:46 | |
| *** eliqiao has joined #openstack-nova | 02:48 | |
| oomichi | gmann: about https://review.openstack.org/#/c/456430 I did think about it before, but I don't have strong opinion about that | 02:48 |
| oomichi | gmann: the enum list clearly says the type is string even if not having 'type' | 02:48 |
| *** iceyao has quit IRC | 02:49 | |
| oomichi | gmann: it is also an option to remove 'type' from such definitions instead | 02:49 |
| oomichi | for consistency | 02:49 |
| gmann | oomichi: actually, enum values can be accessed with index so it was confusing to me. but yes json schema defien enum always a string i think | 02:50 |
| oomichi | gmann: it also would be fine to add type to all schema, but current patch seems necessary to be updated anyways | 02:53 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix response code and parameters in evacuate https://review.openstack.org/457167 | 02:55 |
| gmann | oomichi: did not get, you mean to updated with takashin comments ? | 02:55 |
| *** diga has quit IRC | 02:55 | |
| oomichi | gmann: yep | 02:55 |
| *** diga has joined #openstack-nova | 02:55 | |
| gmann | oomichi: yea i can incorporate those separately if takashin is ok :) | 02:56 |
| gmann | takashin: ^^ what you say? | 02:56 |
| *** coreywright has quit IRC | 03:00 | |
| *** gjayavelu has joined #openstack-nova | 03:01 | |
| takashin | gmann: You can do it separately. But it is small changes. So it is good for reviewers to do it together. | 03:02 |
| *** zhurong has quit IRC | 03:03 | |
| *** tonyb has quit IRC | 03:04 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| *** nicolasbock has quit IRC | 03:05 | |
| *** iceyao has joined #openstack-nova | 03:06 | |
| *** tjones has joined #openstack-nova | 03:07 | |
| *** sudipto has joined #openstack-nova | 03:08 | |
| *** sudipto_ has joined #openstack-nova | 03:08 | |
| *** tonyb has joined #openstack-nova | 03:09 | |
| gmann | takashin: sure, ll do | 03:09 |
| *** gjayavelu has quit IRC | 03:09 | |
| *** ngupta has quit IRC | 03:10 | |
| *** tonyb has quit IRC | 03:12 | |
| *** zhurong has joined #openstack-nova | 03:12 | |
| *** tonyb has joined #openstack-nova | 03:13 | |
| *** thorst has joined #openstack-nova | 03:14 | |
| *** coreywright has joined #openstack-nova | 03:18 | |
| *** thorst has quit IRC | 03:18 | |
| *** iceyao has quit IRC | 03:20 | |
| *** iceyao has joined #openstack-nova | 03:21 | |
| *** amotoki has joined #openstack-nova | 03:22 | |
| *** imacdonn has quit IRC | 03:28 | |
| *** tonyb has quit IRC | 03:28 | |
| *** imacdonn has joined #openstack-nova | 03:28 | |
| *** tonyb has joined #openstack-nova | 03:28 | |
| oomichi | takashin: one question about https://review.openstack.org/#/c/414926/39/nova/tests/functional/test_servers.py | 03:30 |
| oomichi | takashin: why do we need to specify a certain image_uuid for these test cases? | 03:30 |
| takashin | oomichi: Just a moment, please. | 03:31 |
| oomichi | takashin: New tests seem to require the same host only, so I could not understand why we need to specify image_uuid | 03:31 |
| *** iceyao has quit IRC | 03:35 | |
| *** iceyao has joined #openstack-nova | 03:36 | |
| *** links has joined #openstack-nova | 03:40 | |
| *** iceyao has quit IRC | 03:42 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:44 | |
| *** hshiina has quit IRC | 03:47 | |
| *** kaisers has joined #openstack-nova | 03:49 | |
| *** eliqiao has quit IRC | 03:50 | |
| *** sridharg has joined #openstack-nova | 03:51 | |
| *** trinaths has joined #openstack-nova | 03:53 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 03:54 |
| takashin | oomichi: Image API was deprecated in API version 2.36. | 03:55 |
| takashin | oomichi: So an error is raised in https://github.com/openstack/nova/blob/5a556a720f5a7394cab4c84fa6202976c6190b23/nova/tests/functional/integrated_helpers.py#L141 . | 03:55 |
| oomichi | takashin: does that mean 2.36+ functional tests should specify image_uuid, right? | 03:56 |
| takashin | oomichi; And I modified _build_minimal_create_server_request method in _IntegratedTestBase, | 03:57 |
| *** fragatina has joined #openstack-nova | 03:57 | |
| takashin | oomichi: Yes. (in my modification.) | 03:57 |
| oomichi | takashin: I see, thanks. Then it would be better to have NOTE on https://review.openstack.org/#/c/414926/39/nova/tests/functional/integrated_helpers.py | 03:58 |
| oomichi | to explain the above your comment | 03:58 |
| takashin | oomichi: Thank you for your review. I will add a note. | 03:59 |
| oomichi | takashin: thanks again :) | 03:59 |
| *** zhurong has quit IRC | 04:00 | |
| *** tjones has quit IRC | 04:00 | |
| *** hshiina has joined #openstack-nova | 04:01 | |
| *** kaisers has quit IRC | 04:02 | |
| *** iceyao has joined #openstack-nova | 04:03 | |
| *** hongbin has quit IRC | 04:06 | |
| *** iceyao has quit IRC | 04:08 | |
| *** ngupta has joined #openstack-nova | 04:10 | |
| *** esberglu has joined #openstack-nova | 04:11 | |
| *** thorst has joined #openstack-nova | 04:15 | |
| *** esberglu has quit IRC | 04:15 | |
| *** gyee has quit IRC | 04:17 | |
| *** zhurong has joined #openstack-nova | 04:17 | |
| *** thorst has quit IRC | 04:19 | |
| *** zhurong has quit IRC | 04:25 | |
| *** yongjiexu has joined #openstack-nova | 04:28 | |
| *** ijw has joined #openstack-nova | 04:29 | |
| *** takashin has left #openstack-nova | 04:31 | |
| *** udesale has joined #openstack-nova | 04:32 | |
| *** huanxie has quit IRC | 04:32 | |
| *** psachin has joined #openstack-nova | 04:33 | |
| *** fragatina has quit IRC | 04:35 | |
| *** fragatina has joined #openstack-nova | 04:36 | |
| *** yogesh_ has joined #openstack-nova | 04:36 | |
| *** yogesh_ has quit IRC | 04:37 | |
| *** ayogi has joined #openstack-nova | 04:38 | |
| *** diga has quit IRC | 04:40 | |
| *** huanxie has joined #openstack-nova | 04:42 | |
| *** phuongnh has joined #openstack-nova | 04:43 | |
| *** ratailor has joined #openstack-nova | 04:44 | |
| *** Jack_Iv has joined #openstack-nova | 04:45 | |
| *** Jack_Iv has quit IRC | 04:50 | |
| *** yongjiexu has quit IRC | 04:57 | |
| *** yongjiexu has joined #openstack-nova | 04:57 | |
| *** zhurong has joined #openstack-nova | 05:00 | |
| *** kaisers has joined #openstack-nova | 05:03 | |
| *** yongjiexu has quit IRC | 05:03 | |
| *** yongjiexu has joined #openstack-nova | 05:04 | |
| *** esberglu has joined #openstack-nova | 05:08 | |
| *** yongjiexu has quit IRC | 05:08 | |
| *** esberglu has quit IRC | 05:08 | |
| *** esberglu has joined #openstack-nova | 05:08 | |
| *** bmace has quit IRC | 05:12 | |
| *** jamielennox is now known as jamielennox|away | 05:12 | |
| *** esberglu has quit IRC | 05:13 | |
| *** bmace has joined #openstack-nova | 05:13 | |
| *** ijw has quit IRC | 05:14 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: XenAPI: Create linux bridge in dest host during live migration https://review.openstack.org/451657 | 05:14 |
| *** thorst has joined #openstack-nova | 05:15 | |
| *** jamielennox|away is now known as jamielennox | 05:17 | |
| *** sudipto_ has quit IRC | 05:18 | |
| *** sudipto has quit IRC | 05:18 | |
| *** sudipto_ has joined #openstack-nova | 05:19 | |
| *** sudipto has joined #openstack-nova | 05:19 | |
| *** sudipto_ has quit IRC | 05:19 | |
| *** sudipto has quit IRC | 05:19 | |
| *** thorst has quit IRC | 05:20 | |
| *** prateek has joined #openstack-nova | 05:23 | |
| *** fragatina has quit IRC | 05:31 | |
| *** Jack_Iv has joined #openstack-nova | 05:33 | |
| *** gcb has quit IRC | 05:33 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 05:37 |
| *** yasemin has left #openstack-nova | 05:38 | |
| *** ekuris has joined #openstack-nova | 05:38 | |
| *** gcb has joined #openstack-nova | 05:46 | |
| *** iceyao has joined #openstack-nova | 05:47 | |
| *** crushil has quit IRC | 05:48 | |
| *** mdnadeem has joined #openstack-nova | 05:50 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 05:56 |
| *** karthiks has joined #openstack-nova | 06:04 | |
| *** Oku_OS-away is now known as Oku_OS | 06:04 | |
| *** rcernin has joined #openstack-nova | 06:06 | |
| *** sridharg has quit IRC | 06:07 | |
| *** ijw has joined #openstack-nova | 06:14 | |
| *** thorst has joined #openstack-nova | 06:16 | |
| *** sandanar has joined #openstack-nova | 06:18 | |
| *** sandanar__ has joined #openstack-nova | 06:18 | |
| *** sandanar__ has quit IRC | 06:20 | |
| *** adisky_ has joined #openstack-nova | 06:20 | |
| *** ijw has quit IRC | 06:21 | |
| *** iceyao has quit IRC | 06:22 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 06:24 |
| *** sudipto_ has joined #openstack-nova | 06:26 | |
| *** sudipto has joined #openstack-nova | 06:26 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 06:26 |
| *** bkopilov has joined #openstack-nova | 06:30 | |
| *** ngupta_ has joined #openstack-nova | 06:32 | |
| *** wxy has joined #openstack-nova | 06:33 | |
| *** ngupta has quit IRC | 06:34 | |
| *** vishwanathj has quit IRC | 06:34 | |
| *** vishwana_ has joined #openstack-nova | 06:34 | |
| *** Shunli has joined #openstack-nova | 06:34 | |
| *** iceyao has joined #openstack-nova | 06:35 | |
| *** Shunli has quit IRC | 06:35 | |
| *** thorst has quit IRC | 06:36 | |
| *** Shunli has joined #openstack-nova | 06:36 | |
| *** Shunli has quit IRC | 06:37 | |
| *** Shunli has joined #openstack-nova | 06:38 | |
| *** tesseract has joined #openstack-nova | 06:40 | |
| *** ltomasbo has joined #openstack-nova | 06:42 | |
| *** udesale__ has joined #openstack-nova | 06:51 | |
| *** udesale has quit IRC | 06:52 | |
| *** gabor_antal_ has joined #openstack-nova | 06:55 | |
| *** voelzmo has joined #openstack-nova | 06:59 | |
| *** pcaruana has joined #openstack-nova | 06:59 | |
| *** brault has joined #openstack-nova | 07:00 | |
| *** sridharg has joined #openstack-nova | 07:06 | |
| *** damien_r has joined #openstack-nova | 07:07 | |
| *** voelzmo has quit IRC | 07:08 | |
| *** Jack_Iv has quit IRC | 07:09 | |
| *** CristinaPauna has quit IRC | 07:09 | |
| *** coreywright has quit IRC | 07:16 | |
| *** ijw has joined #openstack-nova | 07:18 | |
| *** yushb has joined #openstack-nova | 07:19 | |
| *** Jack_Iv has joined #openstack-nova | 07:20 | |
| *** CristinaPauna has joined #openstack-nova | 07:21 | |
| *** ijw has quit IRC | 07:23 | |
| *** mlakat has joined #openstack-nova | 07:27 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Deprecate Multinic, floatingip action and os-virtual-interface API https://review.openstack.org/457181 | 07:28 |
| *** markus_z has joined #openstack-nova | 07:31 | |
| *** thorst has joined #openstack-nova | 07:32 | |
| *** jamielennox is now known as jamielennox|away | 07:34 | |
| *** coreywright has joined #openstack-nova | 07:34 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321 | 07:35 |
| *** thorst has quit IRC | 07:37 | |
| *** haplo37- has quit IRC | 07:39 | |
| openstackgerrit | shaofeng cheng proposed openstack/nova master: Update nova version newton to ocata in upgrade.rst https://review.openstack.org/457197 | 07:39 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.volume_attach.error notification https://review.openstack.org/455801 | 07:39 |
| *** jpenag is now known as jpena | 07:40 | |
| *** faizy has joined #openstack-nova | 07:41 | |
| *** yushb has quit IRC | 07:41 | |
| *** haplo37_ has joined #openstack-nova | 07:41 | |
| gcb | alex_xu: please help review https://review.openstack.org/457188 , that fixes http://logs.openstack.org/periodic/periodic-nova-py35-with-oslo-master/74800d1/testr_results.html.gz | 07:43 |
| gcb | alex_xu: this blocks we release oslo.config 4.0, hope we can fix it in Nova side before we release new version of oslo.config | 07:45 |
| *** ralonsoh has joined #openstack-nova | 07:46 | |
| *** priteau has joined #openstack-nova | 07:55 | |
| *** karthiks has quit IRC | 07:58 | |
| *** lucas-afk is now known as lucasagomes | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** jaosorior has joined #openstack-nova | 08:03 | |
| *** karimb has joined #openstack-nova | 08:05 | |
| *** ssurana has quit IRC | 08:05 | |
| *** ssurana has joined #openstack-nova | 08:08 | |
| *** zhurong has quit IRC | 08:09 | |
| *** ssurana has quit IRC | 08:10 | |
| *** karthiks has joined #openstack-nova | 08:10 | |
| *** bauwser is now known as bauzas | 08:12 | |
| *** iceyao has quit IRC | 08:13 | |
| *** abalutoiu has joined #openstack-nova | 08:13 | |
| *** zenoway has joined #openstack-nova | 08:14 | |
| *** iceyao has joined #openstack-nova | 08:15 | |
| *** iceyao has quit IRC | 08:17 | |
| *** litao has joined #openstack-nova | 08:17 | |
| *** iceyao has joined #openstack-nova | 08:18 | |
| *** MasterOfBugs has quit IRC | 08:19 | |
| *** karimb has quit IRC | 08:20 | |
| *** ijw has joined #openstack-nova | 08:20 | |
| *** karthiks has quit IRC | 08:21 | |
| *** dmk0202 has joined #openstack-nova | 08:22 | |
| *** ijw has quit IRC | 08:25 | |
| *** iceyao has quit IRC | 08:26 | |
| *** zhurong has joined #openstack-nova | 08:26 | |
| openstackgerrit | Lei Zhang proposed openstack/nova master: Add sync traits command for placement https://review.openstack.org/450125 | 08:27 |
| *** derekh has joined #openstack-nova | 08:27 | |
| openstackgerrit | LiChaoLei proposed openstack/nova master: Fix bug of delete image_base_image_ref after rebuild instance https://review.openstack.org/457514 | 08:27 |
| *** jamielennox|away is now known as jamielennox | 08:28 | |
| *** efoley has joined #openstack-nova | 08:29 | |
| *** sandanar_ has joined #openstack-nova | 08:30 | |
| *** openstackgerrit has quit IRC | 08:33 | |
| *** efoley_ has joined #openstack-nova | 08:34 | |
| *** sandanar has quit IRC | 08:34 | |
| *** baoli has joined #openstack-nova | 08:35 | |
| *** efoley has quit IRC | 08:37 | |
| *** baoli has quit IRC | 08:39 | |
| *** litao has quit IRC | 08:40 | |
| *** litao has joined #openstack-nova | 08:41 | |
| *** esberglu has joined #openstack-nova | 08:46 | |
| *** esberglu has quit IRC | 08:46 | |
| *** esberglu has joined #openstack-nova | 08:46 | |
| *** openstackgerrit has joined #openstack-nova | 08:50 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 08:50 |
| *** esberglu has quit IRC | 08:51 | |
| *** winston-d_ has quit IRC | 08:53 | |
| *** karimb has joined #openstack-nova | 08:54 | |
| *** sapcc-bot has joined #openstack-nova | 08:57 | |
| *** tpatzig_ has joined #openstack-nova | 08:57 | |
| *** dgonzalez_ has joined #openstack-nova | 08:57 | |
| *** carthaca_ has joined #openstack-nova | 08:57 | |
| *** mkoderer_ has joined #openstack-nova | 08:57 | |
| *** seife_ has joined #openstack-nova | 08:57 | |
| *** databus23_ has joined #openstack-nova | 08:57 | |
| *** david_1 has joined #openstack-nova | 08:57 | |
| *** databus23_ has quit IRC | 08:59 | |
| *** seife_ has quit IRC | 08:59 | |
| *** mkoderer_ has quit IRC | 08:59 | |
| *** carthaca_ has quit IRC | 08:59 | |
| *** dgonzalez_ has quit IRC | 08:59 | |
| *** tpatzig_ has quit IRC | 08:59 | |
| *** david_1 has quit IRC | 08:59 | |
| openstackgerrit | Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi V2 in nova https://review.openstack.org/453493 | 09:02 |
| *** sapcc-bot2 has quit IRC | 09:02 | |
| *** kaisers has quit IRC | 09:07 | |
| *** cdent has joined #openstack-nova | 09:09 | |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: tests: add a hook for functional testing in the gate https://review.openstack.org/452122 | 09:09 |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: CLI for resource providers https://review.openstack.org/457532 | 09:09 |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: CLI for inventories https://review.openstack.org/457533 | 09:09 |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: CLI for allocations https://review.openstack.org/457534 | 09:09 |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: CLI for usages https://review.openstack.org/457535 | 09:09 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321 | 09:13 |
| *** gszasz has joined #openstack-nova | 09:16 | |
| *** sambetts|afk is now known as sambetts | 09:19 | |
| *** ijw has joined #openstack-nova | 09:21 | |
| *** Robby__ has joined #openstack-nova | 09:22 | |
| alex_xu | gcb: done | 09:23 |
| *** ijw has quit IRC | 09:26 | |
| *** xinliang_ has quit IRC | 09:27 | |
| *** xinliang has joined #openstack-nova | 09:27 | |
| *** sandanar__ has joined #openstack-nova | 09:32 | |
| *** thorst has joined #openstack-nova | 09:34 | |
| *** sandanar_ has quit IRC | 09:36 | |
| *** gongysh has joined #openstack-nova | 09:37 | |
| *** thorst has quit IRC | 09:38 | |
| *** moshele has joined #openstack-nova | 09:39 | |
| *** zhurong has quit IRC | 09:42 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Deprecate Multinic, floatingip action and os-virtual-interface API https://review.openstack.org/457181 | 09:43 |
| *** fragatina has joined #openstack-nova | 10:01 | |
| *** NikhilS has quit IRC | 10:01 | |
| *** trinaths has left #openstack-nova | 10:03 | |
| *** kaisers has joined #openstack-nova | 10:03 | |
| *** nicolasbock has joined #openstack-nova | 10:04 | |
| openstackgerrit | falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050 | 10:05 |
| *** tovin07_ has quit IRC | 10:13 | |
| *** Guest27975 is now known as BobBall | 10:13 | |
| johnthetubaguy | cdent: am I right to worry about this one? https://review.openstack.org/#/c/448791/7 | 10:15 |
| *** phuongnh has quit IRC | 10:15 | |
| cdent | johnthetubaguy: reading | 10:15 |
| *** hshiina has quit IRC | 10:16 | |
| gcb | alex_xu: thanks | 10:17 |
| cdent | johnthetubaguy: your comments are mostly reasonable (and you did find a bug), but I'm not sure you should "worry"? | 10:18 |
| johnthetubaguy | cdent: heh, I am just a worrier | 10:18 |
| johnthetubaguy | cdent: s/1.5/1.6/ I guess? | 10:19 |
| cdent | the pattern for how to deal with microversions in the gabbi tests has yet to emerge, in that particular file it is "put diferences near to one another so we can compare" | 10:19 |
| johnthetubaguy | cdent: I was curious about the gabby stuff, do we really want to modify those old tests to request a different version? | 10:19 |
| cdent | but it might be better to do what you suggest "group the new version" | 10:19 |
| cdent | the 1.5, 1.6 thing is the bug | 10:19 |
| johnthetubaguy | yeah, but those tests, we should probably best both request no version, and request 1.6 I guess? | 10:20 |
| cdent | the use of a version is to be explicit in the test so that it is clear that we are instentionally saying "I want a version that has a version I know" rather than "I want the default version" | 10:20 |
| cdent | the intention isn't to test that microversions work | 10:20 |
| cdent | that's tested elsewhere | 10:20 |
| cdent | the intention is to test that the behavior at known microversions is what we expect, and to be explicit about it | 10:21 |
| cdent | however | 10:21 |
| cdent | given that you found a bug in reading the code that the tests did not catch, there's probably an adjustment that needs to be made | 10:21 |
| *** cNilesh has quit IRC | 10:22 | |
| johnthetubaguy | I know before in nova-api we said, test bottom, test top, test change points | 10:22 |
| *** ijw has joined #openstack-nova | 10:23 | |
| cdent | that might be a good idea, but we haven't established that yet | 10:23 |
| johnthetubaguy | we missed some of the test change points in the past though, and end up with a discontinuity in bits of the API being supported, i.e. we missed the "change" point that needed testing | 10:23 |
| * cdent nods | 10:23 | |
| johnthetubaguy | not in placement, I think that was assumed in nova-api | 10:23 |
| cdent | I'll look at making it more betterer | 10:23 |
| johnthetubaguy | cdent: I guess I just like seeing tests not changed when I don't want the behaviour to change, if that makes sense | 10:24 |
| cdent | yeah, that makes sense | 10:24 |
| johnthetubaguy | I just don't trust my eyes to review that stuff properly | 10:24 |
| *** kevinz has quit IRC | 10:25 | |
| cdent | I think adding instead of changing is probably a good idea. It is a bit harder to do cleanly in the gabbi stuff because we're in a single session there and I really want to avoid this situation where we create giant gabbi files. Might need to do some of it in separate files. | 10:25 |
| johnthetubaguy | testing all those negative tests for top a middle makes no sense to me either, so clearly a middle ground there | 10:25 |
| johnthetubaguy | yeah, thats true | 10:25 |
| *** zenoway has quit IRC | 10:26 | |
| *** zenoway has joined #openstack-nova | 10:26 | |
| *** sdague has joined #openstack-nova | 10:26 | |
| johnthetubaguy | I was thinking you just repeat one negative test with version 1.6, to confirm it works, a test to confirm the API is removed in 1.7, just leave the old tests as they are, and test the new 1.7 in isolation, was what I was thinking? | 10:27 |
| johnthetubaguy | not sure if that fits with what you were thinking? | 10:27 |
| *** ijw has quit IRC | 10:27 | |
| * cdent has not had enough coffee yet to be fully thinking | 10:28 | |
| *** egonzalez has joined #openstack-nova | 10:28 | |
| cdent | it sounds reasonable, I'll have to see what comes out when I start playing with it properly. | 10:28 |
| johnthetubaguy | yeah | 10:29 |
| cdent | but yeah, thank you, is very good input | 10:31 |
| johnthetubaguy | no worries, happy to help | 10:31 |
| *** gongysh has quit IRC | 10:31 | |
| *** esberglu has joined #openstack-nova | 10:34 | |
| *** thorst has joined #openstack-nova | 10:34 | |
| *** rmart04 has joined #openstack-nova | 10:35 | |
| cdent | johnthetubaguy: on the RT, the fallback was something that matt said ought to happen, to be extra nice. I'm not sure about adding the warning. Is that the usual behavior? Seems noisy to me. | 10:37 |
| johnthetubaguy | cdent: we sometimes only warn the first time, but that does overcomplicate things | 10:38 |
| *** esberglu has quit IRC | 10:38 | |
| johnthetubaguy | cdent: maybe debug is best, I am just thinking about scratching my head debugging things in the future really | 10:38 |
| *** thorst has quit IRC | 10:39 | |
| *** zenoway has quit IRC | 10:40 | |
| *** zenoway has joined #openstack-nova | 10:44 | |
| *** Jack_Iv has quit IRC | 10:46 | |
| *** jaosorior has quit IRC | 10:55 | |
| *** geekinutah has quit IRC | 10:58 | |
| *** geekinutah has joined #openstack-nova | 10:58 | |
| *** kaisers has quit IRC | 11:00 | |
| *** jaosorior has joined #openstack-nova | 11:01 | |
| *** zenoway has quit IRC | 11:02 | |
| *** zenoway has joined #openstack-nova | 11:02 | |
| *** zenoway has quit IRC | 11:07 | |
| *** zenoway has joined #openstack-nova | 11:07 | |
| *** zhurong has joined #openstack-nova | 11:12 | |
| *** lucasagomes is now known as lucas-hungry | 11:14 | |
| *** ratailor has quit IRC | 11:15 | |
| cdent | johnthetubaguy: ah, part of the reason for those explicit microversions is because the tests in tha file are using a default of 'latest' | 11:15 |
| *** ratailor has joined #openstack-nova | 11:15 | |
| johnthetubaguy | cdent: ah... I missed that | 11:15 |
| cdent | I still think there are some good cleanups that can be made based on your idea though. | 11:16 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova master: libvirt: Virtuozzo containers config drive support https://review.openstack.org/449818 | 11:17 |
| *** smatzek has joined #openstack-nova | 11:19 | |
| *** moshele has quit IRC | 11:20 | |
| *** ijw has joined #openstack-nova | 11:24 | |
| *** med_ has quit IRC | 11:28 | |
| *** baoli has joined #openstack-nova | 11:28 | |
| *** peter-hamilton has quit IRC | 11:28 | |
| *** ijw has quit IRC | 11:29 | |
| *** med_ has joined #openstack-nova | 11:30 | |
| *** med_ is now known as Guest45512 | 11:30 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Fix the evacuate API without json-schema validation in 2.13 https://review.openstack.org/457577 | 11:31 |
| alex_xu | sdague: ^ a easy fix, but do you have any suggestion about how to test it? | 11:32 |
| *** bkopilov has quit IRC | 11:33 | |
| *** baoli has quit IRC | 11:34 | |
| *** vladikr has joined #openstack-nova | 11:35 | |
| *** voelzmo has joined #openstack-nova | 11:37 | |
| *** baoli has joined #openstack-nova | 11:37 | |
| *** moshele has joined #openstack-nova | 11:38 | |
| cdent | johnthetubaguy: you're having a banner day: you've caused me to find what might be a bug in gabbi | 11:39 |
| *** karimb has quit IRC | 11:40 | |
| *** thorst has joined #openstack-nova | 11:43 | |
| *** Jack_Iv has joined #openstack-nova | 11:44 | |
| sdague | alex_xu: the way that stack is written, not really | 11:46 |
| sdague | alex_xu: it would be a little interesting if instead of the function stack the decorator was registering alias entries for every microversion, so you could see if they were missing | 11:48 |
| *** edmondsw has joined #openstack-nova | 11:52 | |
| *** yassine has joined #openstack-nova | 11:53 | |
| *** yassine is now known as Guest86170 | 11:53 | |
| *** Guest15696 has quit IRC | 11:54 | |
| *** fragatina has quit IRC | 11:55 | |
| *** kaisers has joined #openstack-nova | 11:55 | |
| *** hshiina has joined #openstack-nova | 11:57 | |
| *** dillaman has quit IRC | 12:08 | |
| *** dave-mccowan has joined #openstack-nova | 12:08 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Update resource tracker to PUT custom resource classes https://review.openstack.org/456915 | 12:17 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Idempotent PUT /resource_classes/{name} https://review.openstack.org/448791 | 12:17 |
| openstackgerrit | Monty Taylor proposed openstack/python-novaclient master: Add novaclient client_name and client_version to user-agent https://review.openstack.org/456638 | 12:17 |
| cdent | mordred: did you see the comment I've just left on ^? | 12:17 |
| mordred | cdent: nope! missed it - looking | 12:17 |
| mordred | cdent: ah- so, for that case, "app_name" is the thing the person should be setting | 12:18 |
| mordred | and it gets set on the Session | 12:18 |
| cdent | meh, ETOOMANYKNOBS | 12:18 |
| mordred | cdent: (or, if they're doing something like shade and making a client that other apps use, there is another nob - but this should work in all those cases) | 12:19 |
| *** salv-orlando has joined #openstack-nova | 12:19 | |
| mordred | one could argue in favor of exposing app_name in novaclient constructor to allow a user to set it for the cases where novaclient creates the session for the user -but honestly - I think that falls into "just create the session yourself and pass it in" :) | 12:20 |
| cdent | so often in these things it seems like we are creating abstractions for stuff that has normal real world names and interaction mode (such as "user-agent") | 12:20 |
| *** dillaman has joined #openstack-nova | 12:20 | |
| *** udesale__ has quit IRC | 12:22 | |
| *** esberglu has joined #openstack-nova | 12:24 | |
| *** esberglu has quit IRC | 12:24 | |
| *** lucas-hungry is now known as lucasagomes | 12:24 | |
| *** ijw has joined #openstack-nova | 12:26 | |
| *** ngupta_ has quit IRC | 12:27 | |
| *** ngupta has joined #openstack-nova | 12:27 | |
| *** gouthamr has joined #openstack-nova | 12:30 | |
| *** ijw has quit IRC | 12:31 | |
| mordred | yah | 12:32 |
| *** karimb has joined #openstack-nova | 12:32 | |
| mordred | cdent: well, that's because abstractions make everytihng better | 12:32 |
| cdent | I heard that somewhere | 12:32 |
| sdague | mordred: https://review.openstack.org/#/c/456344/ ... no special ports on keystone, also it was interesting what fell out of that in the process | 12:35 |
| mordred | sdague: zomg I'm so excited about that | 12:35 |
| *** jpena is now known as jpena|lunch | 12:36 | |
| *** gongysh has joined #openstack-nova | 12:37 | |
| *** gongysh has quit IRC | 12:38 | |
| *** rfolco has joined #openstack-nova | 12:38 | |
| *** gongysh has joined #openstack-nova | 12:39 | |
| *** gongysh has quit IRC | 12:40 | |
| *** ayogi has quit IRC | 12:41 | |
| *** pchavva has joined #openstack-nova | 12:43 | |
| *** ngupta has quit IRC | 12:43 | |
| *** zhurong has quit IRC | 12:45 | |
| *** dimtruck is now known as zz_dimtruck | 12:49 | |
| *** lyan has joined #openstack-nova | 12:50 | |
| *** kylek3h has joined #openstack-nova | 12:50 | |
| alex_xu | sdague: ah, thanks, let me thinking how to make it happen | 12:52 |
| *** Matias has joined #openstack-nova | 12:53 | |
| sdague | alex_xu: I think it would require a more substantial rewrite here | 12:53 |
| sdague | honestly, we should fix this issue | 12:53 |
| *** baoli has quit IRC | 12:54 | |
| sdague | but I think in general there are some changes to the way these decorators work that might make it harder to make mistakes like this | 12:54 |
| *** moshele has quit IRC | 12:56 | |
| *** timello has joined #openstack-nova | 12:56 | |
| mordred | sdague: on the novaclient patch above - you think docstring is a good place to document? | 12:57 |
| sdague | mordred: wherever makes it so it ends up here - https://docs.openstack.org/developer/python-novaclient/api.html | 12:58 |
| mordred | kk | 12:58 |
| *** gcb has quit IRC | 13:00 | |
| bauzas | mordred: sdague: I think a reno patch is good enough for documenting that https://review.openstack.org/#/c/456638/3 | 13:00 |
| bauzas | of course amending the doc is the better approach, but a note would help people knowing the new possibility | 13:01 |
| *** esberglu has joined #openstack-nova | 13:01 | |
| bauzas | (and the alternative) | 13:01 |
| *** Shunli has quit IRC | 13:03 | |
| sdague | bauzas: it's a client api, I'd rather just make it clear how to set the agent string up front | 13:03 |
| openstackgerrit | Monty Taylor proposed openstack/python-novaclient master: Add novaclient client_name and client_version to user-agent https://review.openstack.org/456638 | 13:03 |
| mordred | how's that? | 13:03 |
| alex_xu | sdague: all the versioned method are stored in the a class method, I think I can check that list | 13:03 |
| sdague | I always think about how clear it is in these docs - http://search.cpan.org/dist/libwww-perl/lib/LWP.pm#An_Example | 13:03 |
| *** Jack_Iv has quit IRC | 13:04 | |
| sdague | mordred: works for me | 13:04 |
| sdague | mordred: thanks | 13:04 |
| *** sudipto has quit IRC | 13:04 | |
| *** sudipto_ has quit IRC | 13:04 | |
| *** xyang1 has joined #openstack-nova | 13:04 | |
| bauzas | sdague: I totally agree with you, I'm just advocating on a rather operator/end-user perspective | 13:05 |
| mordred | sdague: woot! | 13:05 |
| bauzas | meaning that I should see my UA logs be changed once I start using the new release of novaclient | 13:06 |
| bauzas | mordred: +W'aboom | 13:06 |
| *** jaosorior has quit IRC | 13:06 | |
| mordred | \o/ | 13:07 |
| mordred | I have made a success today! | 13:07 |
| *** mdrabe has joined #openstack-nova | 13:08 | |
| *** ngupta has joined #openstack-nova | 13:09 | |
| bauzas | always a pleasure to come back from an holiday period by helping others :) | 13:09 |
| *** jamesdenton has joined #openstack-nova | 13:10 | |
| *** mriedem has joined #openstack-nova | 13:10 | |
| mriedem | o/ | 13:10 |
| bauzas | 'supp | 13:11 |
| *** baoli has joined #openstack-nova | 13:13 | |
| *** ngupta has quit IRC | 13:14 | |
| *** jaosorior has joined #openstack-nova | 13:14 | |
| *** Jack_Iv has joined #openstack-nova | 13:15 | |
| *** smatzek has quit IRC | 13:21 | |
| *** prateek has quit IRC | 13:22 | |
| mriedem | bauzas: have you gone through the latest comments in the claims in scheduler spec? https://review.openstack.org/#/c/437424/ | 13:26 |
| bauzas | mriedem: yup, I was waiting for all the folks to be around before pinging all of you | 13:26 |
| bauzas | mriedem: looks like the consensus changed ? | 13:27 |
| bauzas | mriedem: now, the compute node should HTTP get the list of allocations instead of having those passed thru RPC, correct? | 13:27 |
| *** pcaruana has quit IRC | 13:27 | |
| *** ijw has joined #openstack-nova | 13:27 | |
| bauzas | mriedem: also, seems like there was kind of a confusion where the POST allocations should be called, ie. in the conductor vs. scheduler | 13:28 |
| openstackgerrit | Roman Podoliaka proposed openstack/osc-placement master: tests: add a hook for functional testing in the gate https://review.openstack.org/452122 | 13:28 |
| bauzas | FWIW, I thought we all agreed to have the conductor doing that | 13:28 |
| bauzas | (during the hangout) | 13:28 |
| mriedem | bauzas: i thought that when i thought, incorrectly, that the conductor got the list of filtered and weighed hosts | 13:29 |
| bauzas | yup | 13:29 |
| mriedem | we could do it in either, but it seems to me it would be better to retry by just hitting the next host in the list of already filtered hosts, in the scheduler, | 13:29 |
| mriedem | rather than having conductor ask the scheduler to pull a fresh new set all over again | 13:30 |
| andreykurilin | hi folks! Could someone look at small (+9, -5) patch to novaclient https://review.openstack.org/#/c/450763/ ? | 13:30 |
| *** eharney has quit IRC | 13:30 | |
| bauzas | tbc, the conductor only get a subset of hosts returned by the scheduler, not all the accepted nodes | 13:30 |
| bauzas | where the default subset is 1 | 13:30 |
| bauzas | mriedem: the problem wasn't really with the POST logic, rather the DELETE allocation logic when rescheduling or moving the instance | 13:31 |
| mriedem | right, i didn't realize that until yesterday | 13:31 |
| mriedem | bauzas: i think it's fine to do the delete in conductor on reschedules | 13:31 |
| bauzas | mriedem: given the scheduler doesn't know whether it's a boot request, or a move | 13:31 |
| mriedem | like we do for cleaning up bdms and ports | 13:31 |
| bauzas | okay | 13:32 |
| bauzas | fine by me then | 13:32 |
| bauzas | that's 2 distinct situations | 13:32 |
| mriedem | ok, think you can have the spec updated today? | 13:32 |
| *** ijw has quit IRC | 13:32 | |
| bauzas | we could POST the allocation in the current synchronous method we have | 13:32 |
| mriedem | andreykurilin: why does that really need to change? does it just bug you? or is something building on that later? | 13:32 |
| bauzas | and then DELETE allocations for reschedules/moves in the conductor | 13:33 |
| *** bkopilov has joined #openstack-nova | 13:33 | |
| bauzas | mriedem: yup, was planning to | 13:33 |
| mriedem | bauzas: post somewhere in here? https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L124 | 13:33 |
| bauzas | nope | 13:33 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L80 ? | 13:34 |
| bauzas | mriedem: within consume_from_request https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L131 | 13:34 |
| bauzas | because it's a synchronous method | 13:34 |
| bauzas | I mean there is a semaphore | 13:34 |
| bauzas | synchronous section of code | 13:35 |
| *** links has quit IRC | 13:35 | |
| bauzas | dammit, 3.5 days out of OpenStack and my English is still on holiday :/ | 13:35 |
| mriedem | so https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L271 | 13:35 |
| bauzas | probablement oui | 13:35 |
| bauzas | but that's an implementation detail IMHO | 13:36 |
| andreykurilin | mriedem: I just saw an usage of that method in some script and it was not clear what does it accept without searching at docs.o.o/nova (usually, looking at novaclient's docstring is enough) | 13:36 |
| *** jpena|lunch is now known as jpena | 13:38 | |
| *** Oku_OS is now known as Oku_OS-away | 13:40 | |
| mriedem | do we have some sort of memory overhead estimate code in the virt drivers that impacts scheduling via the resource tracker? | 13:41 |
| mriedem | ah estimate_instance_overhead | 13:42 |
| *** burt has joined #openstack-nova | 13:42 | |
| *** Robby__ has quit IRC | 13:42 | |
| mriedem | wow that's a fun method, it can get 1 of 3 different input parameter types | 13:43 |
| mriedem | bauzas: hmm, so that's going to be something interesting that will have to be taken into account to do claims in the scheduler | 13:45 |
| mriedem | totally coincidental but someone internal was asking about this for kvm | 13:45 |
| efried | mriedem I know the PowerVM code for estimate_instance_overhead is... interesting. | 13:45 |
| mriedem | but i see RT.instance_claim calls estimate_instance_overhead on the virt driver | 13:45 |
| mriedem | so how are we going to get this information from the virt driver when we're doing it in the scheduler | 13:46 |
| *** cleong has joined #openstack-nova | 13:46 | |
| *** iceyao has joined #openstack-nova | 13:47 | |
| mriedem | oh it looks like sahid just implemented this for the libvirt driver | 13:47 |
| *** mlavalle has joined #openstack-nova | 13:47 | |
| efried | mriedem Link? | 13:47 |
| efried | Is this something all drivers (including OOT) will need to make changes for? | 13:48 |
| mriedem | https://review.openstack.org/#/c/385364/ | 13:48 |
| mriedem | wait link to what? | 13:48 |
| mriedem | efried: claims in the scheduler spec https://review.openstack.org/#/c/437424/ | 13:48 |
| efried | Yeah, that. Thanks. | 13:48 |
| efried | mriedem FYI: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L249 | 13:49 |
| *** hongbin has joined #openstack-nova | 13:50 | |
| mriedem | btw, the fact we can pass in 3 different things to this... | 13:51 |
| efried | Yeah... awkward | 13:51 |
| mriedem | terrible | 13:51 |
| mriedem | if it should just always be a flavor, we should just do that | 13:52 |
| mriedem | i like how the powervm driver is turning it into a flavor at the start | 13:52 |
| efried | mriedem If the caller(s) just changed to always use a flavor, it remains compatible, and consumers can clean out dead code at their leisure. | 13:53 |
| *** zenoway has quit IRC | 13:53 | |
| *** zenoway has joined #openstack-nova | 13:54 | |
| efried | worthy of a (possibly specless) blueprint? | 13:55 |
| *** Oku_OS-away is now known as Oku_OS | 13:55 | |
| *** hshiina has quit IRC | 13:57 | |
| mriedem | probably don't need a blueprint. we could also use a new method and deprecate the old one. or just as you say always pass a flavor and update the docstrings and let virt drivers get updated | 13:57 |
| *** zenoway has quit IRC | 13:58 | |
| *** crushil has joined #openstack-nova | 13:58 | |
| *** zenoway has joined #openstack-nova | 13:59 | |
| bauzas | mriedem: sorry, my IRC client crashed silently | 14:00 |
| bauzas | mriedem: what do you mean ? | 14:00 |
| mriedem | jaypipes: does memory_mb_used on the compute node find it's way into placement anywhere? | 14:00 |
| bauzas | yup, some virt drivers reserve some overhead, like Xen AFAIK | 14:01 |
| *** sandanar__ has quit IRC | 14:01 | |
| mriedem | i only see cn.memory_mb used for inventory on the MEMORY_MB resource class for the compute RT | 14:01 |
| mriedem | *RP | 14:01 |
| mriedem | bauzas: xen, hyperv and now libvirt | 14:01 |
| mriedem | which impacts how cn.memory_mb_used is reported in the RT | 14:01 |
| mriedem | and cn.free_ram_mb | 14:01 |
| *** kevinz has joined #openstack-nova | 14:01 | |
| bauzas | mriedem: memory_mb_used is just summing the flavor.memory for all the running instances AFAIK | 14:01 |
| bauzas | mriedem: compared to the total size which is returned by the hypervisor | 14:02 |
| mriedem | via get_available_resource right? | 14:02 |
| mriedem | or get_inventory | 14:02 |
| bauzas | yup | 14:02 |
| bauzas | formerly get_avail_resource IIRC | 14:03 |
| mriedem | right so when we make a claim for a new instance, https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L144 | 14:03 |
| bauzas | with ironic, get_inventory | 14:03 |
| mriedem | we calculate the overhead for the vm | 14:03 |
| mriedem | and the claim.memory_mb is based on the instance.flavor.memory_mb + that overhead value from the compute driver | 14:04 |
| bauzas | right | 14:04 |
| *** ngupta has joined #openstack-nova | 14:04 | |
| *** ngupta has quit IRC | 14:04 | |
| *** priteau has quit IRC | 14:04 | |
| *** eharney has joined #openstack-nova | 14:05 | |
| mriedem | what i'm trying to figure out, | 14:05 |
| *** ngupta has joined #openstack-nova | 14:05 | |
| mriedem | is if this overhead estimate from the virt driver factors into scheduling decisions in the scheduler anywhere | 14:05 |
| *** Guest45512 is now known as med_ | 14:05 | |
| *** med_ has quit IRC | 14:05 | |
| *** med_ has joined #openstack-nova | 14:05 | |
| mriedem | or is it something we can only determine once we're on a host, find out that with the overhead we are over the limit, and fail the claim test | 14:05 |
| mriedem | and trigger a retry | 14:05 |
| *** efoley_ is now known as efoley | 14:06 | |
| bauzas | mriedem: the RamFilter doesn't get that for a specific virt driver, so I'd assume no | 14:06 |
| *** ekuris has quit IRC | 14:06 | |
| mriedem | right. but do we record it in the allocation record? | 14:06 |
| mriedem | in placement | 14:06 |
| bauzas | the overhead ? | 14:07 |
| mriedem | e.g. if the full allocation for MEMORY_MB for a given instance is instance.flavor.memory_mb + overhead from virt driver, do we put that into the allocation? | 14:07 |
| mriedem | or just instance.flavor.memory_mb? | 14:07 |
| mriedem | the overhead value that comes out of virt.estimate_instance_overhead | 14:07 |
| bauzas | well, all happens in _update_usage_from_instance so looking | 14:07 |
| *** sudipto_ has joined #openstack-nova | 14:08 | |
| *** sudipto has joined #openstack-nova | 14:08 | |
| bauzas | mriedem: looks like it's not | 14:08 |
| jaypipes | mriedem: yes, it's the inventory for MEMORY_MB :) | 14:08 |
| bauzas | mriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L156 | 14:09 |
| mriedem | aha | 14:09 |
| mriedem | then yeah that seems like a bug | 14:09 |
| jaypipes | mriedem: what? the overhead? | 14:09 |
| mriedem | yes | 14:10 |
| mriedem | because https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L106 | 14:10 |
| *** pcaruana has joined #openstack-nova | 14:10 | |
| mriedem | which is tested in the claim here https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L168 | 14:10 |
| mriedem | right? | 14:10 |
| bauzas | jaypipes: the overhead is only calculated when calling the claim AFAICS | 14:10 |
| *** peter-hamilton has joined #openstack-nova | 14:10 | |
| *** peter-hamilton has quit IRC | 14:10 | |
| mriedem | requested = self.memory_mb == instance.flavor.memory_mb + overhead['memory_mb'] | 14:11 |
| *** peter-hamilton has joined #openstack-nova | 14:11 | |
| jaypipes | mriedem: meh, maybe. it's true there's a little bit of possible inconsistency. I was hoping to resolve that with claims in scheduler. but we need to know the virt driver of the target host *before* we actually allocate :( which is tarded. | 14:11 |
| bauzas | mriedem: well, seems like it's self-healed actually | 14:11 |
| *** zz_dimtruck is now known as dimtruck | 14:11 | |
| mriedem | jaypipes: right, so we have this whole chicken and egg | 14:12 |
| bauzas | mriedem: because RT._update_usage() does calculate the overhead past the allocation | 14:12 |
| bauzas | mriedem: and given we call _update() after _update_usage() with the resources that are taking in account that overhead, it auto-heals | 14:13 |
| jaypipes | mriedem: instead of doing the chicken egg thing, I think it's better to instead use the inventory record's reserved value. that may be a coarser-grained solution, but it's certainly cleaner. | 14:13 |
| johnthetubaguy | mriedem: probably not a shock, but alot of that memory crazy is Xen related, or at least very related to when you have "hard" memory limits | 14:13 |
| *** kevinz has quit IRC | 14:13 | |
| cdent | shouldn't overhead (as a sum of potentials) be recorded within reserved and _not_ be in the consumer's allocations? | 14:13 |
| * cdent jinxes with jaypipes | 14:13 | |
| mriedem | bauzas: i'm not following the full call chain yet | 14:13 |
| jaypipes | cdent: it's overhead *per instance*, whereas reserved is per provider/resource cllass. | 14:13 |
| bauzas | what jaypipes said | 14:13 |
| mriedem | bauzas: but you agree we can hit ComputeResourcesUnavailable due to the overhead pushing us over right? | 14:13 |
| cdent | jaypipes: I know, thus the "sum of potentials" | 14:13 |
| jaypipes | cdent: thus reserved is "more coarse-grained" | 14:13 |
| cdent | and thus the "jinx" | 14:13 |
| jaypipes | cdent: right. | 14:13 |
| jaypipes | :) | 14:14 |
| *** kevinz has joined #openstack-nova | 14:14 | |
| bauzas | mriedem: sec, explaining | 14:14 |
| johnthetubaguy | jaypipes: cdent: so the memory overhead is VM specific in some cases (ducks) but I would argue we might want to ignore that | 14:14 |
| mriedem | johnthetubaguy: exactly | 14:14 |
| jaypipes | johnthetubaguy: ++ | 14:14 |
| mriedem | the overhead calculation is totally based on the flavor used | 14:14 |
| bauzas | mriedem: so, the RamFilter is calculating against the free ram based on what the RT reports, right? | 14:14 |
| bauzas | mriedem: what I'm saying is that I just saw that we do calculate the overhead when updating the usage in the RT | 14:15 |
| mriedem | so do you then make a generic reserved value for the RT on that provider for what you expect to land on that host flavor-wise? | 14:15 |
| mriedem | bauzas: i thought we wanted to deprecate/remove the RamFilter? | 14:15 |
| mriedem | because we use placement now | 14:15 |
| johnthetubaguy | mriedem: yeah, I got the impression that its party host CPU model specific, but I never got a straight answer about that | 14:15 |
| * cdent thinks we should just take what ever anyone provides as reserved and put a 1<random multiplier<2 on it and let it sort itself out in the wash | 14:15 | |
| * cdent is only half kidding | 14:15 | |
| bauzas | mriedem: well, I'm trying to figure out the situation in a pre-placement world | 14:16 |
| mriedem | ok, so the reason i'm even looking at this, is because someone internal is looking at this for the libvirt driver and with an example vm they calculated ~226MB of overhead | 14:16 |
| jaypipes | frankly, mriedem and johnthetubaguy, we're going to end up with a similar issue with the emulator threads. | 14:16 |
| mriedem | which isn't being taken into account for scheduling | 14:16 |
| johnthetubaguy | jaypipes: oh, true | 14:17 |
| jaypipes | mriedem, johnthetubaguy: because the reserved amount of those is specific to a virt driver./ | 14:17 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.openstack.org/452006 | 14:17 |
| jaypipes | course, we need nested providers first, but still, thinking ahead... | 14:17 |
| mriedem | can we agree that https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L156 should be taking into account the overhead? | 14:17 |
| dansmith | I haven't been paying attention, | 14:18 |
| bauzas | I'm still looking at the 100+ calls involved in the decision-making :) | 14:18 |
| dansmith | but the overhead should be included in the inventory reserved amount no? | 14:18 |
| jaypipes | mriedem: perhaps, though that may lead to a failure to allocate. | 14:18 |
| bauzas | dansmith: it's per instance | 14:18 |
| jaypipes | dansmith: yeah, per instance... | 14:18 |
| *** awaugama has joined #openstack-nova | 14:18 | |
| johnthetubaguy | so there are a few overheads going around here | 14:18 |
| dansmith | hmm, I must be missing that part | 14:19 |
| bauzas | the reserved bit is for a global hypervisor overhead | 14:19 |
| bauzas | like a memory heap size you wanna not touch | 14:19 |
| mriedem | jaypipes: hmm, but what we claim would actually be more than what we report for the actual allocation, agreed? | 14:19 |
| dansmith | having allocations include per-instance overhead seems confusing to me, unless it's called out specifically | 14:19 |
| mriedem | or could be | 14:19 |
| dansmith | otherwise it will not be super helpful for use by other tools | 14:19 |
| jaypipes | mriedem: right, which is partly why we didn't include it in that code. | 14:19 |
| mriedem | jaypipes: but shouldn't be as accurate as possible in the allocation since that's going to be used by the scheduler? | 14:20 |
| jaypipes | mriedem: I guess, but the scheduler doesn't ask for that amount :) | 14:20 |
| dansmith | ah, estimate_instance_overhead | 14:21 |
| mriedem | i'm going to need a refresher on what the scheduler asks for in placement, is it just based on inventory? | 14:21 |
| bauzas | yep, that's what I was trying to explain | 14:21 |
| dansmith | jaypipes: nor can it, right? it comes from the virt driver | 14:21 |
| jaypipes | mriedem: in other words, the scheduler doesn't say "I want X MEMORY_MB plus some overhead if the instance is on a Xen hypervisor" | 14:21 |
| bauzas | there are two things to consider | 14:21 |
| mriedem | dansmith: right claims in the scheduler can't use this | 14:21 |
| jaypipes | dansmith: right. | 14:21 |
| bauzas | 1/ what you request and 2/ what you have as free | 14:21 |
| mriedem | jaypipes: i realize, that's not what i'm saying though | 14:21 |
| bauzas | in the claim, we add more to request with the overhead but we don't touch 2/ | 14:21 |
| mriedem | do we or don't we look at allocations when figuring out which providers can serve a request in the scheduler? | 14:22 |
| bauzas | while we do later in the self-heal process, do decrease 2/ | 14:22 |
| jaypipes | mriedem: I think the long-term solution to this is the following: | 14:22 |
| *** smatzek has joined #openstack-nova | 14:22 | |
| bauzas | so, when it comes to placement, the free space is already decremented by the sum of overheads | 14:22 |
| jaypipes | mriedem: add an overheads table to placement API, containing resource_provider_id, resource_class_id, and amount. | 14:22 |
| bauzas | (or when it comes to RAMfilter) | 14:22 |
| jaypipes | mriedem: each record in that table would contain the overhead for that resource class on that provider for each consumer of that resource class. | 14:22 |
| *** burgerk has joined #openstack-nova | 14:23 | |
| dansmith | jaypipes: ooh, yeah I like that | 14:23 |
| jaypipes | mriedem: that way, we can properly model both the inventory and allocation request in the placement API. | 14:23 |
| dansmith | jaypipes: make the virt driver delcare it ahead of time | 14:23 |
| jaypipes | dansmith: right, in the RT's init_compute_node(), etc | 14:23 |
| mriedem | but, | 14:23 |
| dansmith | jaypipes: which kinda pushes us more to a model where we speak about everything in terms of resourceclasses | 14:23 |
| mriedem | the overhead is a factor of the flavor | 14:23 |
| BobBall | jaypipes: My understanding is the overhead on Xen for RAM is smallish. Yes, there will be some instances where we are running very tight against total RAM that need rescheduling, but I'm not sure it's worth the code changes to fix it? | 14:23 |
| dansmith | mriedem: right, but make it declare how it calculates it in terms of resource classes | 14:24 |
| jaypipes | mriedem: no, it's a factor of the resource class. | 14:24 |
| *** dave-mccowan has quit IRC | 14:24 | |
| jaypipes | mriedem: each virt driver has a separate overhead for cpu, disk and memory. | 14:24 |
| dansmith | mriedem: because eventually we get rid of weirdo extra specs and it's all resource classes | 14:24 |
| jaypipes | mriedem: and soon, emulator_threads :) | 14:24 |
| *** moshele has joined #openstack-nova | 14:24 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/hyperv/vmops.py#L124 is a simple case | 14:25 |
| jaypipes | BobBall: I think having an overheads table in the placement API containing this information is the best long-term solution. it would make the system data-driven instead of hard-coded in the virt driver. | 14:25 |
| *** felipemonteiro has joined #openstack-nova | 14:25 | |
| mriedem | so the overheads table contains the multiplier? | 14:25 |
| jaypipes | mriedem: right, that's not per-flavor. it's per reesource class.. | 14:25 |
| mriedem | for a given resource class on that provider? | 14:25 |
| jaypipes | yep | 14:25 |
| dansmith | jaypipes: well, that's crossing the line.. because it's disk = memory + N | 14:25 |
| BobBall | jaypipes: OK - but it's going to be a best guess at any rate. AIUI the actual overhead will depend on the guest type as well as various other factors which we really won't want to encode in any table... | 14:25 |
| dansmith | jaypipes: that one is ... hard | 14:26 |
| mriedem | dansmith: store a lambda in the table?! :P | 14:26 |
| dansmith | mriedem: genius! | 14:26 |
| * johnthetubaguy bingo | 14:26 | |
| cdent | Is there some way we can do this algorithmically based on the inventory of the node when it starts up, do a calculation, and simply add that to the reserved? Because this all sounds fragile and constantly in need of adding yet more stuff. | 14:27 |
| cdent | If we know that an average use scenaior of an inventory that looks like X needs a multiplier on some scale... | 14:27 |
| bauzas | tbh, looks very dynamic to me, since it's provided by the virt driver | 14:27 |
| mriedem | right, i don't know how we encode this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L713 | 14:27 |
| bauzas | I mean, are we sure the overhead can mathematically be given ? | 14:27 |
| *** vks1 has joined #openstack-nova | 14:27 | |
| *** ijw has joined #openstack-nova | 14:29 | |
| dansmith | mriedem: the libvirt one is not that bad I think, but the hyperv one is | 14:29 |
| *** ratailor has quit IRC | 14:29 | |
| jaypipes | mriedem: I think for that hyperv one, it may just be that the DISK_GB inventory record on hyperv compute nodes needs a pre-set reserved value :( | 14:29 |
| dansmith | although the libvirt one would need to be able to specify a trait that increases the cpu overhead by one, I guess | 14:29 |
| cdent | /o\ | 14:30 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Update resource tracker to PUT custom resource classes https://review.openstack.org/456915 | 14:30 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Idempotent PUT /resource_classes/{name} https://review.openstack.org/448791 | 14:30 |
| mriedem | bauzas: going back to your auto-heal, are you referring to https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L616 which eventually calls _update_usage? | 14:30 |
| mriedem | and then later we call https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L648 | 14:31 |
| jaypipes | mriedem: for the emulator threads, I think we can handle that differently... | 14:31 |
| bauzas | mriedem: I'm saying we call https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L774 | 14:31 |
| bauzas | because indeed we call https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L616 | 14:32 |
| *** baoli has quit IRC | 14:32 | |
| jaypipes | mriedem: for libvirt compute nodes, we'd have a fixed number of EMULATOR_THREADS inventory, with no overcommit. For other drivers, we'd have a huge overcommit of EMULATOR_THREADS inventory. | 14:32 |
| mriedem | bauzas: right _update_usage_from_instance calls _update_usage | 14:32 |
| mriedem | bauzas: but _update just changes the inventory record in placement | 14:33 |
| bauzas | mriedem: so, _update_usage_from_instance calls placement by not adding the overhead | 14:33 |
| mriedem | and the total doesn't change does it? | 14:33 |
| *** baoli has joined #openstack-nova | 14:33 | |
| bauzas | mriedem: but _update updates the inventory with the values it was updated by _update_usage() | 14:33 |
| * bauzas is having hard time because he's also listening at https://www.youtube.com/watch?v=hkZir1L7fSY | 14:33 | |
| mriedem | yes, but, https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L779-L795 | 14:34 |
| mriedem | only sets the used/free values on the cn | 14:34 |
| mriedem | which aren't used when setting the inventory in placement for that provider | 14:34 |
| *** ijw has quit IRC | 14:34 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L117 | 14:34 |
| mriedem | the inventory value comes from driver.get_available_resource/get_inventory, right? | 14:34 |
| *** udesale has joined #openstack-nova | 14:34 | |
| bauzas | mriedem: oh fuck, you're right | 14:35 |
| jaypipes | yes | 14:35 |
| mriedem | YES | 14:35 |
| mriedem | ha, ok | 14:35 |
| mriedem | SO... | 14:35 |
| bauzas | it's just updating memory_used | 14:35 |
| mriedem | going back to https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L156 | 14:35 |
| bauzas | so, not called to placement | 14:35 |
| mriedem | ^ is wrong | 14:35 |
| bauzas | mriedem: yup | 14:35 |
| bauzas | mriedem: in a perfect world, we should add that to placement | 14:35 |
| mriedem | let me look up the voodoo that placement does when scheduler asks for providers for a given reqspec | 14:35 |
| bauzas | mriedem: because RamFilter does that | 14:35 |
| bauzas | and we want placement to behave like the filter | 14:36 |
| *** kaisers has quit IRC | 14:36 | |
| *** moshele has quit IRC | 14:37 | |
| *** baoli has quit IRC | 14:38 | |
| jaypipes | bauzas: I don't care if placement doesn't behave exactly like the RamFilter. I just want placement to be clear, clean, and accurate without leaking implementation details (of the virt driver) out of the API. | 14:38 |
| *** sudipto_ has quit IRC | 14:38 | |
| *** sudipto has quit IRC | 14:38 | |
| *** eharney has quit IRC | 14:38 | |
| bauzas | jaypipes: I couldn't agree more, but at the moment, something could trigger a rescheduler while it could be avoided if we would ask for more | 14:39 |
| mriedem | so when the filter scheduler does the GET /resource_providers?resources=VCPUS:2,MEMORY_MB=4096,DISK_GB=60, it looks like it eventually joins and takes into account allocations on each provider, right? | 14:39 |
| mriedem | i'm lost in the sql | 14:39 |
| cdent | mriedem: that is correct | 14:39 |
| bauzas | mriedem: you're correct | 14:39 |
| mriedem | ok | 14:39 |
| mriedem | thanks, | 14:39 |
| jaypipes | mriedem: yes, of course. | 14:39 |
| mriedem | so, it seems https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L156 should then be reporting the full allocation that we actually claimed on the compute node, right? | 14:40 |
| bauzas | so we underestimate the already taken memory | 14:40 |
| mriedem | correct | 14:40 |
| *** baoli has joined #openstack-nova | 14:40 | |
| *** tbachman has joined #openstack-nova | 14:40 | |
| mriedem | and we could pike a RP in the scheduler that fails the claim test on the host | 14:40 |
| mriedem | because maybe we shaved off enough overheads in our allocations reporting that we screwed ourselves | 14:40 |
| mriedem | worst case that just triggers a retry | 14:40 |
| mriedem | UNTIL | 14:40 |
| mriedem | we don't have retries anymore | 14:40 |
| bauzas | yup, retry | 14:40 |
| mriedem | see where i'm going :) | 14:40 |
| bauzas | I know | 14:41 |
| mriedem | jaypipes: bauzas: cdent: can we at least agree this is a bug? | 14:41 |
| jaypipes | mriedem: sure :) | 14:41 |
| bauzas | I think we can reasonably assume it is a nice one | 14:41 |
| mriedem | ok | 14:41 |
| mriedem | good | 14:41 |
| cdent | mriedem: yes, there is a mismatch between reality and what's recorded | 14:41 |
| mriedem | because i started this morning reading this email from a perf guy in china, not knowing anything about this overhead stuff, to realizing there is a bug, | 14:41 |
| jaypipes | cdent: that is the plotline of my entire life. | 14:41 |
| bauzas | meiwelcome in the club | 14:42 |
| mriedem | so i'd like to take that back to him instead of just saying, 'i have no f'ing clue what you're talking about' | 14:42 |
| bauzas | mriedem: welcome in the club | 14:42 |
| openstackgerrit | Gergely Csatari proposed openstack/nova master: Checking the parameters of servers-actions.inc https://review.openstack.org/327112 | 14:42 |
| cdent | jaypipes: I think there's a good song in there somewhere | 14:42 |
| sfinucan | jaypipes: I see https://review.openstack.org/#/c/361140/ didn't get in before the spec freeze. Think it's a fair candidate for the exception process? | 14:42 |
| mriedem | cdent: every country western song ever | 14:42 |
| mriedem | sfinucan: not imo | 14:42 |
| cdent | mriedem: need to add some tears in my ears from crying on my pillow over you | 14:43 |
| jaypipes | sfinucan: not up to me. but I will review today regardless. | 14:43 |
| sfinucan | mriedem: no? | 14:43 |
| bauzas | oh, sfinucan reminded me one | 14:43 |
| sfinucan | any particular reason? | 14:43 |
| mriedem | sfinucan: because at this point we're overcommitted and the only exceptions i'm interested in are for priorities or things that impact all of nova, not narrow use cases | 14:43 |
| bauzas | mriedem: https://review.openstack.org/#/c/450122/18 is getting 2 +2s from jaypipes and me but I refrained my +W, so I leave you use your axe | 14:44 |
| *** dave-mccowan has joined #openstack-nova | 14:44 | |
| *** nkorabli has joined #openstack-nova | 14:44 | |
| *** jianghuaw_ has joined #openstack-nova | 14:46 | |
| *** iceyao has quit IRC | 14:47 | |
| mriedem | i'm -2 on the vgpus one also | 14:47 |
| mriedem | same reason | 14:47 |
| sfinucan | mriedem: Those use cases are the primary use cases for a lot of our customers | 14:47 |
| sfinucan | the VGPU less so. That needs more exploration, IMO | 14:48 |
| mriedem | sfinucan: then tell me which of the other red hat priority blueprints you'd like to defer in it's place | 14:48 |
| mriedem | emulator threads? | 14:48 |
| mriedem | secure console proxy? | 14:48 |
| mriedem | your other pci scheduler one? | 14:48 |
| sfinucan | emulator threads is done | 14:48 |
| sfinucan | the other PCI scheduler is a two patch change, ~100 line change | 14:49 |
| sfinucan | and, if Gerrit's logs are anything to go by, I'm going to be very fortunate to get the secure console proxy stuff in. No one wants to review it :( | 14:49 |
| sfinucan | the PCI use cases are my primary focus this cycle. There's no lack of reviewer bandwidth on my end | 14:50 |
| *** kfarr has joined #openstack-nova | 14:51 | |
| *** eharney has joined #openstack-nova | 14:53 | |
| *** marst has joined #openstack-nova | 14:54 | |
| openstackgerrit | Peter Hamilton proposed openstack/nova master: Add configuration options for certificate validation https://review.openstack.org/457678 | 14:56 |
| mriedem | sfinucan: you can work with artom on the tagged attach/detach stuff then | 14:56 |
| mriedem | sfinucan: honestly look at what we've already approved https://blueprints.launchpad.net/nova/pike | 14:57 |
| voelzmo | @johnthetubaguy I've updated https://review.openstack.org/#/c/416997 with some comments, not sure how we should continue the discussion | 14:57 |
| johnthetubaguy | voelzmo: here is fine, for me it was a case of consistency | 14:59 |
| sfinucan | mriedem: Yeah, I've been horse trading with him for reviews on the secure console proxy stuff, heh :) | 14:59 |
| *** dharinic has joined #openstack-nova | 14:59 | |
| johnthetubaguy | voelzmo: its a strange API to only support this for half of the nic types, thats really hard API docs and validation, etc | 14:59 |
| johnthetubaguy | voelzmo: but maybe I am seeing it all wrong | 15:00 |
| *** kevinz has quit IRC | 15:00 | |
| *** tjones has joined #openstack-nova | 15:00 | |
| mriedem | speaking of deleting ports, | 15:00 |
| mriedem | let's fix latent bugs https://review.openstack.org/#/c/452577/ | 15:00 |
| *** baoli has quit IRC | 15:00 | |
| voelzmo | @johnthetubaguy I understand the consistency argument, I just fear that it adds scope that I didn't mean to include. Not sure how special the documentation and code really will get. From what I've seen it is already pretty special in the sense that it sets the 'remove port' flag based on whether nova creates it or the user passed it in | 15:01 |
| sfinucan | mriedem: Also get your point about being oversubscribed, but these are the things I'm paid to care about. If push came to shove, could we drop the secure console proxy work in favour of that | 15:01 |
| *** baoli has joined #openstack-nova | 15:01 | |
| johnthetubaguy | voelzmo: but saying you can customise only one of those cases seems strange. | 15:02 |
| sfinucan | *that 'share-pci-between-numa-nodes' spec? | 15:02 |
| voelzmo | @johnthetubaguy I agree that for the sake of symmetry that would make sense. Have you heard of someone wanting to keep ports created by nova? | 15:03 |
| *** timello has quit IRC | 15:04 | |
| *** dharinic has quit IRC | 15:04 | |
| mriedem | sfinucan: well, melwitt was also saying in here yesterday that accurately reporting boot from volume disk usage was important for red hat customers, and the answer to fixing that has been claims in the scheduler and shared storage pool resource aggregates | 15:04 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Fix the FakeDriver using same hypervisor names https://review.openstack.org/456237 | 15:05 |
| openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | 15:05 |
| mriedem | sfinucan: and that's a thing melwitt has been trying to get resolved since at least newton, and we keep saying, "once this is done, and once this is done..." | 15:05 |
| mriedem | and it keeps getting pushed out | 15:05 |
| *** kfarr has quit IRC | 15:07 | |
| sdague | oomichi: I'm confused by your -1 here - https://review.openstack.org/#/c/454854/2 | 15:07 |
| sfinucan | mriedem: I can't speak as to the relative importance of the two so I guess I better go ask :) | 15:08 |
| sfinucan | Crucially though, if either of those took precedence would you be OK with us dropping secure console proxy in favour of one of them? | 15:08 |
| *** rcernin has quit IRC | 15:09 | |
| *** vks1 has quit IRC | 15:10 | |
| johnthetubaguy | voelzmo: I know I wanted that to re-use an IP a few times | 15:10 |
| voelzmo | @johnthetubaguy and you knew that during VM creation already? Because that's where the user will be able to specify this flag | 15:11 |
| voelzmo | Changing it after the fact is not a thing, currently | 15:11 |
| *** ngupta has quit IRC | 15:11 | |
| mriedem | sfinucan: maybe, but it sounds like that's something you need to discuss with your entire team first, | 15:11 |
| mriedem | because there are several blueprints your team is involved in | 15:12 |
| mriedem | and you guys are going to need to agree before you start proposing something to drop i think | 15:12 |
| *** udesale has quit IRC | 15:13 | |
| sfinucan | mriedem: Yup, we've a team meeting tomorrow. I'll bring that up then and see what the story is | 15:13 |
| *** ngupta has joined #openstack-nova | 15:13 | |
| *** iceyao has joined #openstack-nova | 15:14 | |
| *** crushil has quit IRC | 15:15 | |
| *** kevinz has joined #openstack-nova | 15:16 | |
| *** markus_z has quit IRC | 15:17 | |
| *** eharney has quit IRC | 15:19 | |
| *** iceyao has quit IRC | 15:19 | |
| *** mdrabe has quit IRC | 15:20 | |
| *** kfarr has joined #openstack-nova | 15:21 | |
| *** kevinz has quit IRC | 15:21 | |
| *** mdnadeem has quit IRC | 15:21 | |
| *** Guest86170 has quit IRC | 15:21 | |
| *** crushil has joined #openstack-nova | 15:21 | |
| *** catintheroof has joined #openstack-nova | 15:22 | |
| *** rmart04 has quit IRC | 15:22 | |
| *** Guest86170 has joined #openstack-nova | 15:25 | |
| *** mdrabe has joined #openstack-nova | 15:27 | |
| *** Jack_Iv has quit IRC | 15:27 | |
| *** Jack_Iv has joined #openstack-nova | 15:27 | |
| *** mvk has quit IRC | 15:28 | |
| *** scottda has joined #openstack-nova | 15:30 | |
| *** ijw has joined #openstack-nova | 15:30 | |
| *** tjones has quit IRC | 15:30 | |
| *** tjones has joined #openstack-nova | 15:31 | |
| *** felipemonteiro has quit IRC | 15:31 | |
| *** kaisers has joined #openstack-nova | 15:32 | |
| *** abalutoiu has quit IRC | 15:32 | |
| *** kaisers has quit IRC | 15:34 | |
| *** kaisers has joined #openstack-nova | 15:34 | |
| *** ijw has quit IRC | 15:35 | |
| *** eharney has joined #openstack-nova | 15:38 | |
| johnthetubaguy | voelzmo: the other part is making this like the delete_on_termination we have for volumes, but I don't 100% remember the details | 15:38 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Destroy the ReqSpec object when deleting the instance https://review.openstack.org/391060 | 15:39 |
| *** pcaruana has quit IRC | 15:41 | |
| *** zenoway has quit IRC | 15:42 | |
| *** ngupta has quit IRC | 15:46 | |
| *** ngupta has joined #openstack-nova | 15:46 | |
| *** salv-orl_ has joined #openstack-nova | 15:49 | |
| *** rfolco has quit IRC | 15:50 | |
| *** jianghuaw_ has quit IRC | 15:50 | |
| *** fragatina has joined #openstack-nova | 15:51 | |
| *** salv-orlando has quit IRC | 15:51 | |
| edleafe | Trying to create a functional test that simulates 1000 computes. Would I do this by creating a single n-cpu service and 1000 ComputeNode objects? If so, how do I add those ComputeNode objects to the service's ResourceTracker? | 15:52 |
| edleafe | Or am I completely lost? | 15:52 |
| mriedem | edleafe: did you see my reply about this to cdent's placement update in the ML? | 15:53 |
| mriedem | edleafe: i'm not sure a functional test makes sense for this, since it's just a report, it wouldn't actually fail | 15:53 |
| mriedem | edleafe: i dug out yingxin's tool from the austin summit when he was testing the filter scheduler vs the caching scheduler, | 15:53 |
| mriedem | it might need some tweaking, but the readme says you can run it against a single-node devstack | 15:53 |
| mriedem | so i'd probably start there | 15:53 |
| edleafe | mriedem: no, didn't see your reply yet | 15:54 |
| *** rfolco has joined #openstack-nova | 15:54 | |
| *** iceyao has joined #openstack-nova | 15:54 | |
| bauzas | edleafe: I agree with mriedem, I'm pretty sure our infra wouldn't like to have a job faking 1000 nodes for each patch | 15:54 |
| *** chyka has joined #openstack-nova | 15:54 | |
| mriedem | bauzas: ed was working on an in-tree functional test i think | 15:54 |
| mriedem | which just simulates things in the db | 15:54 |
| mriedem | and runs the scheduler | 15:54 |
| edleafe | why wouldn't it fail? If you have inventory/allocations that don't meet the request, shouldn't it fail? | 15:54 |
| mriedem | edleafe: i mean the test doesn't really fail | 15:55 |
| mriedem | it's a perf test which is used to compare results | 15:55 |
| mriedem | so with an actual TestCase, what do you compare it to for the benchmark? | 15:55 |
| mriedem | that's all i mean | 15:55 |
| edleafe | And this wasn't going in-tree - it was more of a tool to test our assumptions | 15:55 |
| mriedem | edleafe: ok, that tool already exists | 15:55 |
| bauzas | mriedem: not sure I understand the reasoning behind running 1000 nodes | 15:55 |
| mriedem | we should re-use it | 15:55 |
| edleafe | it does? | 15:55 |
| bauzas | and we already have all the infra for running functional tests | 15:55 |
| *** vishwana_ has quit IRC | 15:56 | |
| bauzas | you can just castascall and run all your services with the fake driver | 15:56 |
| bauzas | plus all the fixtures | 15:56 |
| edleafe | bauzas: the question was whether claiming in scheduler or conductor was better when hitting the race situation | 15:56 |
| *** gfhellma has joined #openstack-nova | 15:57 | |
| bauzas | edleafe: so, that's not needing a functional test - it's different | 15:57 |
| bauzas | what you need is to run a testbed for verifying some things | 15:57 |
| *** Kevin_Zheng has quit IRC | 15:57 | |
| edleafe | bauzas: ok, functional "tool" | 15:57 |
| bauzas | you can write that using the existing fixtures | 15:57 |
| *** damien_r has quit IRC | 15:57 | |
| edleafe | mriedem: which tool are you referring to? | 15:58 |
| bauzas | but I think it should rather be something for the implementation :) | 15:58 |
| mriedem | edleafe: | 15:58 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2017-April/115553.html | 15:58 |
| bauzas | FWIW, I think discussing about whether the claim post should be in the conductor or the scheduler is an implementation detail that needs verification during the implementation phase | 15:58 |
| bauzas | I was actually planning to do so | 15:58 |
| *** Jack_Iv has quit IRC | 15:59 | |
| mriedem | edleafe: https://github.com/cyx1231st/nova-scheduler-bench | 15:59 |
| *** iceyao has quit IRC | 15:59 | |
| mriedem | bauzas: that's why this came up | 15:59 |
| bauzas | honestly, I don't want to defer the spec acceptance by that | 15:59 |
| edleafe | mriedem: thanks - I'll dig into this | 16:00 |
| mriedem | i.e. is it better to retry in the scheduler where we already have the hosts, or conductor which requires the full retry | 16:00 |
| mriedem | bauzas: i don't either | 16:00 |
| bauzas | having the scheduler or the conductor calling the placement seems an implementation detail | 16:00 |
| edleafe | bauzas: you could simply add "to be determined" | 16:00 |
| bauzas | edleafe: I was *on* the spec given I made a promise to mriedem :p | 16:00 |
| mriedem | bauzas: i'd like to say we're going to start with retry in scheduler, but mention an alternative | 16:00 |
| bauzas | mriedem: jinxed | 16:00 |
| mriedem | and say both can be tested | 16:00 |
| *** Jack_Iv has joined #openstack-nova | 16:01 | |
| dansmith | mriedem: that pushes the claim to placement into the scheduler too | 16:01 |
| mriedem | dansmith: i know | 16:01 |
| dansmith | hmm. | 16:01 |
| mriedem | that's where we have the list of filtered and weighed hosts | 16:01 |
| dansmith | I know | 16:01 |
| mriedem | so if we have to retry, it's faster | 16:01 |
| mriedem | well, theoretically it's faster | 16:02 |
| dansmith | or it might be much worse, depending on how you race | 16:02 |
| dansmith | we could also, you know, return more information from that scheduler interface | 16:02 |
| mriedem | sure, if host[1] and host[2] in the list are now used up too | 16:02 |
| dansmith | like "here are the top 5, weighed in order" | 16:02 |
| mriedem | dansmith: i thought about that yesterday too | 16:02 |
| mriedem | select_destinations could just return the hosts | 16:02 |
| *** ngupta has quit IRC | 16:02 | |
| dansmith | ...yeah | 16:02 |
| mriedem | i'd return whatever CONF.max_attempts is | 16:03 |
| bauzas | there are 2 implementation possibilites | 16:03 |
| dansmith | it already returns multiples now if num_instances is >1, so just return N plus some.. yeah | 16:03 |
| bauzas | either we put POST in consume_from_request() | 16:03 |
| mriedem | jaypipes: cdent: bauzas: https://bugs.launchpad.net/nova/+bug/1683858 | 16:03 |
| openstack | Launchpad bug 1683858 in OpenStack Compute (nova) "Allocation records do not contain overhead information" [High,Triaged] | 16:03 |
| bauzas | or, we do POST right after scheduler returns a destination to conductor | 16:03 |
| *** ngupta has joined #openstack-nova | 16:04 | |
| mriedem | bauzas: the post isn't the problem, it's where to retry | 16:04 |
| jaypipes | mriedem: thx | 16:04 |
| bauzas | either way, like I discussed with mriedem, we need to DELETE allocations in the conductor on a reschedule/move operation | 16:04 |
| bauzas | mriedem: like I said to you, the scheduler doesn't know whether it's a move or a single boot | 16:04 |
| bauzas | for it, it just answers a specific question which is "which host(s) matches my request" | 16:05 |
| bauzas | *why* we ask the scheduler this question is totally unrelated to it | 16:05 |
| *** voelzmo has quit IRC | 16:05 | |
| *** egonzalez has quit IRC | 16:05 | |
| edleafe | bauzas: either way, the resources on the selected host will have to be claimed | 16:05 |
| bauzas | edleafe: in the PS I'm writing, I'm decoupling the DELETE and the POST | 16:06 |
| *** ngupta has quit IRC | 16:06 | |
| *** voelzmo has joined #openstack-nova | 16:06 | |
| *** sridharg has quit IRC | 16:06 | |
| *** ngupta has joined #openstack-nova | 16:06 | |
| bauzas | edleafe: in the conductor, I'm planning to GET allocations for that instance and DELETE those if existing, before calling scheduler which would POST the new allocations for that instance | 16:06 |
| openstackgerrit | Jon Bernard proposed openstack/nova master: Add tempest-dsvm-ceph-rc https://review.openstack.org/456292 | 16:07 |
| *** Apoorva has joined #openstack-nova | 16:07 | |
| *** Apoorva has quit IRC | 16:07 | |
| *** Apoorva has joined #openstack-nova | 16:08 | |
| efried | sfinucan Got a sec to talk through https://review.openstack.org/#/c/455710/8/nova/api/openstack/placement/handler.py@184 ? (andymccr cdent) | 16:08 |
| *** gyee has joined #openstack-nova | 16:09 | |
| *** nic has joined #openstack-nova | 16:09 | |
| sfinucan | efried: Sure | 16:09 |
| * cdent listens | 16:09 | |
| efried | sfinucan First, assertion that we don't need .get(..., '') | 16:09 |
| efried | Whyzat? Is something upstack guaranteeing that var will be present (even if empty) in the env? | 16:09 |
| *** voelzmo has quit IRC | 16:10 | |
| sfinucan | efried: '.get' will return 'None' even if the key isn't a dictionary | 16:10 |
| sfinucan | which is different from the dict[key] notation | 16:11 |
| sfinucan | *isn't in a given dictionary | 16:11 |
| efried | mm, fair | 16:11 |
| cdent | this has been through enough iterations I'm not sure if we haven't lost the original point | 16:12 |
| cdent | or maybe points | 16:12 |
| andymccr | sfinucan: so if i understand your point correctly, the subsequent .get()'s after line 183 are not required in that format since we are certain by now that the var does exist. | 16:13 |
| andymccr | although the last one is probably required still since that's for CONTENT_TYPE rather than CONTENT_LENGTH? | 16:13 |
| efried | I wasn't a fan of leaving the int() to raise TypeError/ValueError, but that was the original behavior that supposedly wasn't wanting to be changed. | 16:13 |
| efried | andymccr Right, but leave out the , '' | 16:13 |
| cdent | efried: no we don't want that. we don't want a lose exception to raise | 16:13 |
| cdent | loose | 16:13 |
| andymccr | efried: because it would return None anyway- ok cool i understand | 16:14 |
| efried | cdent Yeah, just thought we might want it to be a better exception | 16:14 |
| *** salv-orl_ has quit IRC | 16:14 | |
| efried | cdent Like HTTPBadRequest | 16:14 |
| andymccr | i can add in a try/raise if needed | 16:14 |
| cdent | andymccr: my advice would be to start from a test that demonstrates the bug you're experiencing | 16:15 |
| cdent | make that, make it fail, then fix it | 16:15 |
| cdent | you can do that by faking an environ that you pass to the PlacementHandler class | 16:15 |
| cdent | (as a callable) | 16:15 |
| *** lucasagomes is now known as lucas-afk | 16:15 | |
| efried | Yeah, mahbad for suggesting all the , '' / , 0 stuff. There's some other builtin that raises if you don't use that second var (can't remember which, now) that I was confusing with dict.get(). | 16:16 |
| andymccr | cdent: yeah my plan is to cover a few test cases there. i think it should be doable i just need to carve out some time. but to confirm when i propose the next patch set it would be better to have a try block around the int() | 16:17 |
| cdent | I can't remember :) | 16:17 |
| efried | andymccr IMO, yes; cdent may not agree. | 16:18 |
| *** sudipto_ has joined #openstack-nova | 16:18 | |
| *** sudipto has joined #openstack-nova | 16:18 | |
| cdent | go for it | 16:18 |
| andymccr | efried: it makes sense to me so i'll do it and can always revise :) | 16:18 |
| efried | Basically, we don't want a CONTENT_LENGTH that's not an int. | 16:18 |
| cdent | i think once you get tests in place, the solutions will be pretty clear | 16:18 |
| andymccr | yeah agreed | 16:18 |
| *** marst_ has joined #openstack-nova | 16:19 | |
| efried | Thanks guys. Felt like we were going around in circles a bit trying to have this conversation via gerrit. | 16:19 |
| andymccr | haha yeah probably - and thanks for the pointers/help on that one. | 16:20 |
| *** marst has quit IRC | 16:20 | |
| openstackgerrit | dane-fichter proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | 16:21 |
| efried | andymccr cdent sfinucan Aha - it was getattr() I was confusing with. If you don't provide the default there, it raises. <facepalm> | 16:21 |
| sfinucan | efried: Yup, I only realized last week that you could even use a default. Had been using a 1-2 hasattr/getattr combo up to that point | 16:22 |
| *** swebster_ has joined #openstack-nova | 16:23 | |
| *** swebster has quit IRC | 16:23 | |
| cdent | efried: thanks for that linking | 16:27 |
| efried | yahyoubetcha | 16:27 |
| *** ijw has joined #openstack-nova | 16:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.openstack.org/456571 | 16:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Gather 'live_migration_scheme', 'live_migration_inbound_addr' https://review.openstack.org/456572 | 16:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Convert 'live_migration_inbound_addr' to HostAddressOpt https://review.openstack.org/456573 | 16:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Set default for live_migration_scheme https://review.openstack.org/457716 | 16:33 |
| johnthetubaguy | mriedem: I have some questions on https://review.openstack.org/#/c/452577 I just took a look | 16:34 |
| johnthetubaguy | mriedem: I am trying to workout why the existing logic doesn't work correctly | 16:34 |
| *** moshele has joined #openstack-nova | 16:36 | |
| *** ijw has quit IRC | 16:37 | |
| *** moshele has quit IRC | 16:40 | |
| *** dave-mccowan has quit IRC | 16:41 | |
| *** gjayavelu has joined #openstack-nova | 16:42 | |
| *** jaosorior has quit IRC | 16:43 | |
| *** dave-mccowan has joined #openstack-nova | 16:45 | |
| *** baoli has quit IRC | 16:45 | |
| efried | mriedem jaypipes Clarification on https://review.openstack.org/#/c/454983/ (Service catalog for endpoints): Do we *want* to include config options like [cinder]catalog_info for all the services, or just use a hardcoded service_type? | 16:46 |
| *** karimb has quit IRC | 16:47 | |
| jaypipes | efried: I'd prefer to use a hard-coded service type, from the service-types-authority: https://github.com/openstack/service-types-authority/ | 16:48 |
| jaypipes | efried: unfortunately cinder isn't in there :( | 16:48 |
| efried | jaypipes Okay, I dig the idea of having fewer conf settings. But edmondsw also had concerns about hardcoding the endpoint_type. | 16:48 |
| jaypipes | efried: but cinder is proposed for "block-storage": https://review.openstack.org/#/c/436178/ | 16:49 |
| *** litao has quit IRC | 16:49 | |
| jaypipes | efried: for Cinder, specifically, we'll need to have a list of hard-coded service types and try them in order. | 16:49 |
| jaypipes | efried: for instance, try "block-storage", then "volumev2", then "volume", etc | 16:50 |
| jaypipes | efried: because Cinder is the odd man out of all this. | 16:50 |
| *** harlowja_ has joined #openstack-nova | 16:50 | |
| *** harlowja has quit IRC | 16:52 | |
| mriedem | efried: the whole point is we don't want catalog_info | 16:52 |
| mriedem | so we're going to deprecate that once we start using ksa | 16:52 |
| jaypipes | right | 16:52 |
| mriedem | and we just have a service_type and interface option | 16:52 |
| jaypipes | bingo | 16:52 |
| mriedem | so service_type=cinderv3, interface=public | 16:52 |
| *** dmk0202 has quit IRC | 16:52 | |
| mriedem | or whatever | 16:52 |
| jaypipes | and frankly, even the interface is questionable... but meh. :) | 16:52 |
| mriedem | interface defaults to None in nova.conf, which defaults to public in ksa | 16:52 |
| mriedem | sure | 16:52 |
| *** ssurana has joined #openstack-nova | 16:52 | |
| mriedem | i only mention interface b/c of the one we added for placement for andymccr | 16:52 |
| jaypipes | ya | 16:53 |
| mriedem | johnthetubaguy: ok will look after the notifications meeting | 16:53 |
| mriedem | where i'm sure we'll talk about loading instance.tags by default | 16:53 |
| mriedem | so dansmith might want to be there | 16:53 |
| dansmith | "want" | 16:53 |
| mriedem | "so i want dansmith to be there" | 16:54 |
| mriedem | better? | 16:54 |
| dansmith | yes | 16:54 |
| mriedem | sorry i'm midwestern | 16:54 |
| mriedem | and therefore passive aggressive | 16:54 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Claims in the scheduler https://review.openstack.org/437424 | 16:54 |
| bauzas | mriedem: dansmith: edleafe: cdent: jaypipes: BOOOM ^ | 16:55 |
| bauzas | that said, \o | 16:55 |
| jaypipes | bauzas: k, thx. will re-review shortly. | 16:55 |
| mordred | TIL novaclient validates payloads more in python3 than in python2 | 16:55 |
| *** felipemonteiro has joined #openstack-nova | 16:56 | |
| *** derekh has quit IRC | 16:56 | |
| sdague | mordred: interesting... | 16:56 |
| sdague | mordred: define more? | 16:56 |
| *** amotoki has quit IRC | 16:57 | |
| mordred | sdague: http://logs.openstack.org/48/457548/2/check/gate-shade-python35/0b68957/testr_results.html.gz - the test failure there only fails on python3 - in python3 it passed. the error is that I was returning the wrong top-level key in my response | 16:57 |
| mordred | (was returning security_groups and not security_group) | 16:58 |
| sdague | weird | 16:59 |
| *** baoli has joined #openstack-nova | 17:00 | |
| *** ralonsoh has quit IRC | 17:01 | |
| *** baoli has quit IRC | 17:01 | |
| *** baoli has joined #openstack-nova | 17:02 | |
| mordred | yah | 17:03 |
| mordred | I mean, it's neat that novaclient in python3 double-checked that for me - it caught a bug :) | 17:03 |
| sdague | yeh, I wonder what actually is different there | 17:03 |
| edmondsw | mriedem, are you saying we would still have service_type and interface options in conf? | 17:05 |
| mriedem | edmondsw: yes | 17:05 |
| mriedem | because we need to know if you're going to use cinderv2 or cinderv3 | 17:05 |
| mriedem | or cinderv4 | 17:05 |
| edmondsw | mriedem, ok, good... I would even be fine with (at least eventually) hardcoding service_type... but not interface | 17:06 |
| mriedem | details are in the spec | 17:06 |
| edmondsw | mriedem well that's the thing... I read the spec and this was far from clear | 17:06 |
| edmondsw | unfortunately I read it after it was merged | 17:06 |
| mordred | sdague: I can't see anything different in the code | 17:06 |
| *** cdent has quit IRC | 17:07 | |
| *** efoley has quit IRC | 17:07 | |
| edmondsw | efried, so see mriedem's reply above... service_type and interface would still be in conf | 17:07 |
| efried | edmondsw Hm, see jaypipes from 20min ago | 17:08 |
| *** yamahata has joined #openstack-nova | 17:09 | |
| edmondsw | efried he seemed to agree at 12:52 | 17:10 |
| jaypipes | edmondsw: gimme 10 minutes and I'll disagree with myself. | 17:10 |
| edmondsw | :) | 17:10 |
| *** Jack_Iv has quit IRC | 17:10 | |
| efried | edmondsw Oh, I misunderstood, thought that was params to the function, not conf options. | 17:10 |
| edmondsw | jaypipes I like a man who can change his mind when it makes sense | 17:11 |
| jaypipes | edmondsw: I totally disagree. | 17:11 |
| edmondsw | lol | 17:11 |
| jaypipes | :P | 17:11 |
| *** Jack_Iv has joined #openstack-nova | 17:11 | |
| edmondsw | "interface" is what I was calling "endpoint_type" in our conversation because that's what the spec had called it | 17:13 |
| edmondsw | efried ^ | 17:13 |
| *** ociuhandu has joined #openstack-nova | 17:13 | |
| efried | edmondsw Yeah, I've picked up on that dual naming. | 17:13 |
| *** fragatina has quit IRC | 17:14 | |
| efried | edmondsw It's either-or all over the place. | 17:14 |
| *** ltomasbo is now known as ltomasbo|away | 17:15 | |
| edmondsw | efried keystone calls it "interface"... at least in v3, I don't remember in v2 | 17:16 |
| *** ociuhandu has quit IRC | 17:16 | |
| *** mdrabe has quit IRC | 17:17 | |
| *** mdrabe has joined #openstack-nova | 17:18 | |
| mordred | yah. interface is the 'correct' term, endpoint_type is the legacy type | 17:18 |
| mordred | fwiw, I would vote for not having service_type in the conf myself, but that's just me perhaps | 17:18 |
| *** kaisers has quit IRC | 17:19 | |
| efried | mordred The concern was that we would then have to try some number of service types (in some possibly-arbitrary order) before we find the right one. | 17:19 |
| mordred | mriedem: I do not think you need to have service_type so that you know cinderv2/cinderv3 - since that's in the cinder discovery doc | 17:19 |
| mordred | efried: yes. you may have to do that - but that is fairly cheap. whereas continuing to allow configuration of service_type perpetuates the idea that it's ok for people to set them to something other than the one thing they should be set to | 17:20 |
| mordred | but, as I said, i'm the extremist view on all of this | 17:20 |
| mriedem | mordred: but i thought the service type in the catalog was cinder/cinderv2/cinderv3? | 17:20 |
| mriedem | and cinder == v1 | 17:21 |
| mordred | mriedem: yes. well, this is a tragedy of history that is hopefully soon rectified | 17:21 |
| mordred | since it causes baby bunnies to weep regularly | 17:21 |
| *** Jack_Iv has quit IRC | 17:21 | |
| mordred | (and it's volume, volumev2 and volumev3) | 17:21 |
| mriedem | oh right | 17:21 |
| mriedem | we have that hard-coded in the nova request context code too \o/ | 17:22 |
| mordred | but you can _easily_ try all three of those from the catalog, since it's a local dict lookup | 17:22 |
| mordred | and, in fact, I even already have the logic for that written up :) | 17:22 |
| *** Jack_Iv has joined #openstack-nova | 17:22 | |
| *** Jack_Iv has quit IRC | 17:22 | |
| *** jpena is now known as jpena|off | 17:24 | |
| efried | mordred mriedem Where can I get the exhaustive list of service_type values? | 17:25 |
| *** nkorabli has quit IRC | 17:25 | |
| *** nkorabli has joined #openstack-nova | 17:25 | |
| mordred | efried: https://review.openstack.org/#/q/project:openstack/service-types-authority is the beginning of collecting them | 17:26 |
| *** gfhellma_ has joined #openstack-nova | 17:26 | |
| mordred | efried: there is also an unofficial list here: http://git.openstack.org/cgit/openstack/os-client-config/tree/os_client_config/constructors.json | 17:26 |
| mordred | although hopefully we can make that go away and rely on s-t-a once it coalesces | 17:27 |
| *** gszasz has quit IRC | 17:27 | |
| *** baoli has quit IRC | 17:27 | |
| * mordred is so looking forward to adding block-storage to the list of things we try for volume things | 17:27 | |
| *** baoli has joined #openstack-nova | 17:28 | |
| efried | mordred Will service-types-authority be complete and definitive in pike (in time to be used for this impl)? | 17:28 |
| mordred | doubful - can you point me to the spec you're talking about? | 17:28 |
| efried | mordred https://review.openstack.org/#/c/454983/7/specs/pike/approved/use-service-catalog-for-endpoints.rst | 17:29 |
| mordred | thanks! | 17:29 |
| *** gfhellma has quit IRC | 17:29 | |
| efried | Thank _you_. I'm very much struggling just to understand the context here. Any guidance is much appreciated. | 17:29 |
| *** ijw has joined #openstack-nova | 17:33 | |
| *** burgerk has quit IRC | 17:38 | |
| *** ijw has quit IRC | 17:38 | |
| efried | jaypipes mriedem Suggestions for where the new get_service_url() method should live? | 17:39 |
| *** mlavalle has quit IRC | 17:39 | |
| jaypipes | efried: nova/utils.py? | 17:39 |
| efried | ight | 17:39 |
| efried | jaypipes Not service.py, service_auth.py, or context.py, then. | 17:40 |
| jaypipes | efried: I think nova/utils.py is a fine home. we can always move it in the future if need be. | 17:41 |
| efried | rgr | 17:41 |
| mriedem | yeah nova.utils is fine | 17:43 |
| *** ociuhandu has joined #openstack-nova | 17:46 | |
| *** fragatina has joined #openstack-nova | 17:47 | |
| *** fragatina has quit IRC | 17:47 | |
| *** fragatina has joined #openstack-nova | 17:48 | |
| efried | concern: circular imports... | 17:49 |
| *** ociuhandu has quit IRC | 17:50 | |
| openstackgerrit | Monty Taylor proposed openstack/nova-specs master: Fix old terminology https://review.openstack.org/457746 | 17:51 |
| openstackgerrit | Monty Taylor proposed openstack/nova-specs master: Implement use-service-catalog-for-endpoints differently https://review.openstack.org/457747 | 17:51 |
| mordred | jaypipes, efried, mriedem: ^^ there is me arguing | 17:51 |
| *** fragatina has quit IRC | 17:53 | |
| *** ociuhandu has joined #openstack-nova | 17:53 | |
| mriedem | mordred: publicURL is in the config defaults right now https://github.com/openstack/nova/blob/master/nova/conf/cinder.py#L26 | 17:53 |
| mriedem | that's why it was in the spec | 17:53 |
| mordred | mriedem: I totally understand. but publicURL is a keystonev2 holdover | 17:54 |
| mriedem | yeah that's fine, we could change the default config option | 17:54 |
| mriedem | we already changed cinderv2 to cinderv3 in that option in pike | 17:54 |
| mriedem | mordred: you could propose the change and get your ATC badge | 17:54 |
| mordred | ah - so I totally misunderstood taht the config option already existed | 17:55 |
| mriedem | right | 17:55 |
| *** ociuhandu has quit IRC | 17:55 | |
| mordred | so - my sugestion of 2 new options still stands - but if this is already a thing I guess there is no point in doing a double migration | 17:55 |
| mriedem | jaypipes: efried: so i guess we lost something in one of the patch sets on that spec where it listed the options we'd provide as overrides, like service_type and interface | 17:56 |
| mriedem | which is maybe why edmondsw was confused | 17:56 |
| *** fragatina has joined #openstack-nova | 17:57 | |
| *** ociuhandu has joined #openstack-nova | 17:57 | |
| mriedem | edmondsw: mordred: see https://review.openstack.org/#/c/454983/4..7/specs/pike/approved/use-service-catalog-for-endpoints.rst@a76 | 17:58 |
| mriedem | ps4 on the original spec called some of this out | 17:58 |
| *** ekhugen has quit IRC | 17:58 | |
| *** patriciadomin has quit IRC | 17:58 | |
| efried | So if service_type is provided, use it. If interface is provided, use it. If not provided, cycle through them (if neither provided, does it matter which is inner and which is outer loop?) | 17:59 |
| macsz | bug team meeting in 2 minutes @ openstack-meeting-4 | 17:59 |
| efried | Is the service catalog guarateed to present at most one hit for a given service? | 17:59 |
| *** baoli has quit IRC | 17:59 | |
| mriedem | efried: i've been in other meetings so didn't follow any of the discussion about iterating things | 18:00 |
| efried | Sorry, I mean I guess e.g. glance can provide multiple endpoints - but only for one service_type/interface combo? | 18:00 |
| efried | mriedem Yeah, so jaypipes (I think) suggested having a hardcoded list of service_type values and trying them in (what?) order. | 18:00 |
| *** nicolasbock has quit IRC | 18:01 | |
| efried | ...or is service_type required (defaulting to something "sensible" for each service)? | 18:01 |
| mordred | starting with "nicest" default - that is, whatever is in service-type-authority - and then falling back to other items in preferred order | 18:02 |
| *** baoli has joined #openstack-nova | 18:02 | |
| jaypipes | mordred: right, xactly what I think is appropriate.y | 18:02 |
| efried | And for further fun, continue supporting existing conf options, with deprecation warnings, through pike. | 18:03 |
| mordred | btw - I'm writing a quick spec for "just use os-client-config" - which I started hacking on but it's entirely possible that none of you know that, since I didn't write a spec | 18:03 |
| efried | mordred Is there an example somewhere of os-client-config being used for something like this? | 18:04 |
| mriedem | efried: novaclient functional tests | 18:04 |
| mriedem | https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/base.py#L157 | 18:04 |
| *** Jack_Iv has joined #openstack-nova | 18:07 | |
| *** sudipto has quit IRC | 18:07 | |
| *** sudipto_ has quit IRC | 18:07 | |
| mriedem | so what is the list of service types for cinder? | 18:07 |
| mriedem | and this is a ListOpt or what? | 18:07 |
| *** gfhellma_ has quit IRC | 18:07 | |
| mriedem | [cinder]service_types=volumev3,volumev2,cinderv3,cinderv2? | 18:07 |
| *** sambetts is now known as sambetts|afk | 18:08 | |
| *** patriciadomin has joined #openstack-nova | 18:09 | |
| mriedem | mordred: "ditch the concept of a single value that is a colon separated tuple, since that form is not used to indicate an OpenStack service pretty much anywhere else" is adorable | 18:10 |
| mriedem | mordred: cinder copied that from nova, and manila copied that from cinder | 18:10 |
| jaypipes | mriedem: in case you were wondering, I'm working on patches that add get_inventory() implementation for all the non-Ironic virt drivers. | 18:10 |
| *** faizy has quit IRC | 18:11 | |
| mriedem | jaypipes: ok | 18:12 |
| mriedem | i'm working on reviewing already approved specs | 18:12 |
| mriedem | so we can rewrite them | 18:12 |
| jaypipes | lol | 18:13 |
| *** bkopilov has quit IRC | 18:22 | |
| *** tesseract has quit IRC | 18:22 | |
| *** felipemonteiro has quit IRC | 18:23 | |
| *** felipemonteiro has joined #openstack-nova | 18:25 | |
| *** nicolasbock has joined #openstack-nova | 18:27 | |
| mordred | mriedem: heh. I meant in the world of people consuming openstack services | 18:28 |
| openstackgerrit | Monty Taylor proposed openstack/nova-specs master: Add spec for using os-client-config for service clients https://review.openstack.org/457760 | 18:29 |
| *** nkorabli has quit IRC | 18:29 | |
| *** ngupta_ has joined #openstack-nova | 18:31 | |
| openstackgerrit | Monty Taylor proposed openstack/nova-specs master: Fix old terminology https://review.openstack.org/457746 | 18:32 |
| *** felipemonteiro has quit IRC | 18:34 | |
| *** ngupta has quit IRC | 18:35 | |
| *** ijw has joined #openstack-nova | 18:35 | |
| *** nkorabli has joined #openstack-nova | 18:37 | |
| *** ijw has quit IRC | 18:41 | |
| *** abalutoiu_ has joined #openstack-nova | 18:42 | |
| *** mnestratov has quit IRC | 18:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix docstring in _validate_requested_port_ids https://review.openstack.org/457767 | 18:44 |
| *** Sukhdev has joined #openstack-nova | 18:46 | |
| *** nkorabli has quit IRC | 18:46 | |
| *** ngupta has joined #openstack-nova | 18:47 | |
| *** adisky_ has quit IRC | 18:49 | |
| *** ngupta_ has quit IRC | 18:51 | |
| *** mlavalle has joined #openstack-nova | 18:52 | |
| *** ekhugen has joined #openstack-nova | 18:55 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make server groups api aware of multiple cells for membership https://review.openstack.org/457338 | 18:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 18:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | 18:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 18:57 |
| *** cdent has joined #openstack-nova | 18:58 | |
| *** gfhellma has joined #openstack-nova | 19:00 | |
| *** JayF has left #openstack-nova | 19:04 | |
| *** dave-mccowan has quit IRC | 19:06 | |
| mriedem | johnthetubaguy: i went through https://review.openstack.org/#/c/452577/ and short answer is i don't know why the existing code isn't working :( | 19:06 |
| mriedem | unless the info cache is getting concurrent updates and some stale data overwrites our update with the newly attached port | 19:07 |
| *** dtp has joined #openstack-nova | 19:08 | |
| *** dtp has quit IRC | 19:14 | |
| *** jamesdenton has quit IRC | 19:25 | |
| *** jamesdenton has joined #openstack-nova | 19:29 | |
| *** dave-mccowan has joined #openstack-nova | 19:32 | |
| *** mdrabe has quit IRC | 19:33 | |
| *** mdrabe has joined #openstack-nova | 19:34 | |
| *** jamesdenton has quit IRC | 19:35 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: implement get_inventory() for libvirt https://review.openstack.org/457782 | 19:36 |
| *** mdrabe has quit IRC | 19:36 | |
| *** mdrabe has joined #openstack-nova | 19:37 | |
| *** mdrabe has quit IRC | 19:38 | |
| *** mdrabe has joined #openstack-nova | 19:40 | |
| *** awaugama has quit IRC | 19:40 | |
| openstackgerrit | Monty Taylor proposed openstack/nova-specs master: Add spec for using os-client-config for service clients https://review.openstack.org/457760 | 19:41 |
| *** mdrabe has quit IRC | 19:46 | |
| *** felipemonteiro has joined #openstack-nova | 19:47 | |
| *** slaweq_ has joined #openstack-nova | 19:47 | |
| *** jdurgin has quit IRC | 19:47 | |
| *** Jack_Iv has quit IRC | 19:47 | |
| *** mdrabe has joined #openstack-nova | 19:48 | |
| *** slaweq_ has quit IRC | 19:48 | |
| *** Jack_Iv has joined #openstack-nova | 19:49 | |
| openstackgerrit | Jon Bernard proposed openstack/nova master: Add tempest-dsvm-ceph-rc https://review.openstack.org/456292 | 19:49 |
| *** iceyao has joined #openstack-nova | 19:50 | |
| *** Jack_Iv has quit IRC | 19:51 | |
| openstackgerrit | Jon Bernard proposed openstack/nova master: Add tempest-dsvm-ceph-rc https://review.openstack.org/456292 | 19:53 |
| *** david-lyle has joined #openstack-nova | 19:53 | |
| *** iceyao has quit IRC | 19:54 | |
| *** Laszlo_ has joined #openstack-nova | 19:55 | |
| *** Jack_Iv has joined #openstack-nova | 19:55 | |
| Laszlo_ | hello | 19:55 |
| Laszlo_ | I've run into an interesting situation with Newton: | 19:56 |
| Laszlo_ | I have a user user1 in project1 | 19:56 |
| Laszlo_ | the user is creating a VM | 19:56 |
| Laszlo_ | then the admin user in the admin project is creating a volume | 19:56 |
| Laszlo_ | next the admin user is attaching the volume using the ID of the VM (server) created by the user and the ID of the voulme created by admin | 19:57 |
| Laszlo_ | all fine, the volume is visible inside the server. | 19:58 |
| mriedem | user tries to detach the volume or delete the instance and it blows up because the user doesn't have access to GET the volume | 19:59 |
| mriedem | by design | 19:59 |
| Laszlo_ | next the user is deleting the server (actually is deleting the entire stack that has created the server) | 19:59 |
| Laszlo_ | openstack stack delete lab2 | 19:59 |
| Laszlo_ | no errors so far | 20:00 |
| *** Jack_Iv has quit IRC | 20:00 | |
| *** jdurgin has joined #openstack-nova | 20:00 | |
| Laszlo_ | but when I'm looking at the volume created by the admin user I can still see it as being attached .... | 20:00 |
| mriedem | because nova failed to detach it | 20:00 |
| mriedem | because the instance user doesn't have access to the volume | 20:00 |
| Laszlo_ | I see ... | 20:01 |
| mriedem | fails here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2267 | 20:01 |
| Laszlo_ | can I run the detach as admin? (now the VM is already gone .... ) | 20:01 |
| mriedem | you should see one of those warnings in the logs | 20:01 |
| mriedem | you'd have to detach the volume as admin before deleting the server | 20:01 |
| mriedem | you can't detach it after the server is gone | 20:02 |
| mriedem | otherwise you need to force a reset of the volume state on the cinder side | 20:02 |
| Laszlo_ | is there a way out from this situation? | 20:02 |
| mriedem | Laszlo_: i think you have to use the os-reset_status API on the cinder side in that case | 20:03 |
| *** Apoorva_ has joined #openstack-nova | 20:03 | |
| *** Jack_Iv has joined #openstack-nova | 20:03 | |
| mriedem | https://developer.openstack.org/api-ref/block-storage/v2/index.html#reset-volume-statuses | 20:04 |
| Laszlo_ | mriedem: OK. I will chack it. I have not used this before | 20:04 |
| mriedem | it's really a backdoor hack | 20:04 |
| mriedem | when something goes wrong | 20:04 |
| mriedem | your root problem is that you have the admin creating and attaching a volume to a server it does not own | 20:04 |
| mriedem | so when the server is deleted, the owner of the server does not have access to detach the volume | 20:05 |
| mriedem | b/c it can't get access to the volume | 20:05 |
| mriedem | since the admin owns it | 20:05 |
| mriedem | so either, use a single tenant, or make sure your tooling has the admin detach the volume before the server is deleted | 20:05 |
| *** eharney has quit IRC | 20:06 | |
| *** Apoorva has quit IRC | 20:06 | |
| Laszlo_ | mriedem: I understood the problem. currently the issue is not big because I was just playing with a newton lab install | 20:07 |
| *** mnestratov has joined #openstack-nova | 20:07 | |
| mriedem | whew | 20:08 |
| Laszlo_ | so it's a good chance to learn about how to solve the issue if I will have it in real life situation ... :) | 20:08 |
| *** dtp has joined #openstack-nova | 20:13 | |
| *** Jack_Iv has quit IRC | 20:14 | |
| *** Jack_Iv has joined #openstack-nova | 20:14 | |
| *** mvk has joined #openstack-nova | 20:15 | |
| *** smatzek has quit IRC | 20:17 | |
| *** eharney has joined #openstack-nova | 20:21 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova master: Add spice-native type https://review.openstack.org/454940 | 20:21 |
| *** ildikov is now known as hypothermic_cat | 20:22 | |
| *** ijw has joined #openstack-nova | 20:24 | |
| *** dimtruck is now known as zz_dimtruck | 20:27 | |
| smcginnis | Laszlo_: In case you don't want to make API calls directly, here's the client info: https://docs.openstack.org/cli-reference/cinder.html | 20:29 |
| *** ijw has quit IRC | 20:29 | |
| *** xyang1 has quit IRC | 20:30 | |
| *** xyang1 has joined #openstack-nova | 20:31 | |
| *** iceyao has joined #openstack-nova | 20:31 | |
| Laszlo_ | smcginnis: thank you! that makes our life much easyer ... :) | 20:32 |
| *** Apoorva_ has quit IRC | 20:32 | |
| smcginnis | ;) | 20:32 |
| *** openstackgerrit has quit IRC | 20:33 | |
| Laszlo_ | so the right command would be: cinder reset-state --state available --attach-status detached right? | 20:33 |
| *** Apoorva has joined #openstack-nova | 20:33 | |
| smcginnis | Laszlo_: Not having done it lately and not having access to tests right now... yes, I believe so. :) | 20:33 |
| Laszlo_ | one sec .. I'll tell you ... :) | 20:34 |
| *** gfhellma_ has joined #openstack-nova | 20:35 | |
| Laszlo_ | it worked! of course I had to specify the vol_id also ... | 20:35 |
| Laszlo_ | thank you! | 20:35 |
| *** pchavva has quit IRC | 20:35 | |
| *** iceyao has quit IRC | 20:36 | |
| *** ngupta has quit IRC | 20:36 | |
| *** gfhellma has quit IRC | 20:36 | |
| *** slaweq_ has joined #openstack-nova | 20:37 | |
| *** Jack_Iv has quit IRC | 20:38 | |
| *** slaweq_ has quit IRC | 20:39 | |
| *** slaweq_ has joined #openstack-nova | 20:39 | |
| *** gjayavelu has quit IRC | 20:42 | |
| *** cleong has quit IRC | 20:43 | |
| mriedem | gmann: did you ever start this? https://blueprints.launchpad.net/nova/+spec/nova-microversion-functional-tests | 20:44 |
| *** slaweq_ has quit IRC | 20:44 | |
| *** slaweq_ has joined #openstack-nova | 20:44 | |
| *** jdurgin has quit IRC | 20:45 | |
| *** marst_ has quit IRC | 20:45 | |
| *** salv-orlando has joined #openstack-nova | 20:45 | |
| *** sean-k-mooney has quit IRC | 20:46 | |
| *** gfhellma__ has joined #openstack-nova | 20:46 | |
| *** gfhellma_ has quit IRC | 20:47 | |
| *** vladikr has quit IRC | 20:48 | |
| *** zz_dimtruck is now known as dimtruck | 20:48 | |
| *** david-lyle has quit IRC | 20:49 | |
| *** slaweq_ has quit IRC | 20:50 | |
| *** slaweq_ has joined #openstack-nova | 20:51 | |
| mriedem | dansmith: jaypipes: so i think i'm going to push a change to deprecate the TypeAffinityFilter, there wasn't much reply in the mailing list on it, but as noted there it's broken by design if you ever change your flavors | 20:58 |
| mriedem | http://lists.openstack.org/pipermail/openstack-operators/2017-April/013131.html | 20:58 |
| *** jdurgin has joined #openstack-nova | 21:00 | |
| jaypipes | mriedem: cool with me, but then again, I'm pro-removal-of-most-things. ;) | 21:01 |
| *** sdague has quit IRC | 21:04 | |
| dansmith | mriedem: yes, me as well | 21:05 |
| *** slaweq has quit IRC | 21:05 | |
| *** slaweq_ is now known as slaweq | 21:07 | |
| *** cdent has quit IRC | 21:07 | |
| *** david-lyle has joined #openstack-nova | 21:10 | |
| *** slaweq has quit IRC | 21:10 | |
| *** slaweq has joined #openstack-nova | 21:10 | |
| *** edmondsw has quit IRC | 21:11 | |
| *** dmk0202 has joined #openstack-nova | 21:11 | |
| *** thorst has quit IRC | 21:11 | |
| *** edmondsw has joined #openstack-nova | 21:11 | |
| *** Laszlo_ has left #openstack-nova | 21:12 | |
| *** rfolco has quit IRC | 21:12 | |
| *** rfolco has joined #openstack-nova | 21:13 | |
| *** rfolco has quit IRC | 21:13 | |
| *** iceyao has joined #openstack-nova | 21:14 | |
| *** Sukhdev has quit IRC | 21:15 | |
| *** xinliang has quit IRC | 21:16 | |
| *** edmondsw has quit IRC | 21:16 | |
| *** Sukhdev has joined #openstack-nova | 21:17 | |
| *** marst_ has joined #openstack-nova | 21:18 | |
| *** gjayavelu has joined #openstack-nova | 21:18 | |
| *** jamesdenton has joined #openstack-nova | 21:19 | |
| *** iceyao has quit IRC | 21:19 | |
| *** lyan has quit IRC | 21:19 | |
| melwitt | anyone else seen random failures of nova.tests.unit.virt.ironic.test_driver.IronicDriverConsoleTestCase.test__get_node_console_with_reset_wait_timeout locally? | 21:22 |
| dansmith | not locally, but have seen it twice in the last few hours in infra | 21:23 |
| *** jamesdenton has quit IRC | 21:23 | |
| melwitt | something is afoot, it's not just me | 21:24 |
| * dansmith scowls | 21:24 | |
| melwitt | :) | 21:24 |
| mriedem | jaypipes: dansmith: btw, why do we still have ram/disk filters in enabled_filters? | 21:28 |
| mriedem | placement replaces those now | 21:28 |
| mriedem | yeah? | 21:28 |
| dansmith | yeah, might should remove them | 21:28 |
| dansmith | I hear jaypipes loves ramfilter though, so maybe he wants to keep it | 21:28 |
| * dansmith runs | 21:28 | |
| mriedem | EXCEPT | 21:29 |
| mriedem | ramfilter checks host_state.free_ram_mb | 21:29 |
| mriedem | which has that overhead thing in it from the virt drivers | 21:29 |
| mriedem | and placement doesn't | 21:29 |
| *** xinliang has joined #openstack-nova | 21:29 | |
| *** eharney has quit IRC | 21:30 | |
| mriedem | so maybe we can't remove it until that bug is fixed | 21:30 |
| dansmith | weren't we going to stop writing the RT data in pike though? | 21:30 |
| mriedem | well, remove it from default | 21:30 |
| mriedem | writing what rt data? | 21:31 |
| dansmith | all the existing stuff we're duplicating in placement now | 21:32 |
| mriedem | melwitt: https://github.com/openstack/nova/commit/213f7120c483a37317091b7478dfb99495619ce4 ? | 21:32 |
| mriedem | for that ironic thing | 21:32 |
| *** thorst has joined #openstack-nova | 21:32 | |
| mriedem | dansmith: oh writing to the compute nodes table? | 21:32 |
| dansmith | yeah, all the stats we compile in the RT from the instances, available resources, etc | 21:33 |
| mriedem | i don't remember that specifically | 21:33 |
| mriedem | for pike | 21:33 |
| mriedem | i remember deprecating the ram/disk/cpu filters | 21:33 |
| mriedem | and sylvain had the nova-status thing for it kind of | 21:33 |
| dansmith | because right now we're keeping track of the data twice, which we needed for the upgrade, but at pike we don't, | 21:33 |
| dansmith | unless we're going to keep it for the ramfilter, but that would suck | 21:33 |
| mriedem | https://review.openstack.org/#/c/427200/ | 21:34 |
| mriedem | yeah this was the thing where the filters are enabled (which ram and disk are by default), and they had allocation ratios set | 21:34 |
| mriedem | because you didn't set reserved=9999 on your provider | 21:35 |
| mriedem | anyway, seems we should take those out of the default enabled filters | 21:36 |
| mriedem | but probably need to fix that overhead bug first | 21:36 |
| *** thorst has quit IRC | 21:37 | |
| *** Apoorva_ has joined #openstack-nova | 21:38 | |
| *** esberglu has quit IRC | 21:38 | |
| *** stvnoyes has quit IRC | 21:40 | |
| *** ijw has joined #openstack-nova | 21:40 | |
| *** ngupta has joined #openstack-nova | 21:40 | |
| *** crushil has quit IRC | 21:41 | |
| *** Apoorva has quit IRC | 21:42 | |
| *** baoli has quit IRC | 21:43 | |
| *** tbachman has quit IRC | 21:45 | |
| *** Sukhdev has quit IRC | 21:47 | |
| *** Sukhdev has joined #openstack-nova | 21:48 | |
| *** salv-orl_ has joined #openstack-nova | 21:48 | |
| *** tbachman has joined #openstack-nova | 21:49 | |
| *** gouthamr has quit IRC | 21:50 | |
| *** lyan has joined #openstack-nova | 21:50 | |
| *** salv-orlando has quit IRC | 21:50 | |
| *** gfhellma__ has quit IRC | 21:51 | |
| *** mnestratov has quit IRC | 21:53 | |
| *** thorst has joined #openstack-nova | 21:53 | |
| *** MasterOfBugs has joined #openstack-nova | 21:55 | |
| *** david-lyle has quit IRC | 21:55 | |
| *** iceyao has joined #openstack-nova | 21:56 | |
| *** gfhellma has joined #openstack-nova | 21:57 | |
| *** thorst has quit IRC | 21:58 | |
| *** openstackgerrit has joined #openstack-nova | 21:58 | |
| openstackgerrit | Steven Webster proposed openstack/nova master: Fix mitaka online migration for PCI devices https://review.openstack.org/456397 | 21:58 |
| openstackgerrit | Steven Webster proposed openstack/nova master: Fix port update exception when unshelving an instance with PCI devices https://review.openstack.org/453938 | 21:58 |
| *** dmk0202 has quit IRC | 21:59 | |
| *** iceyao has quit IRC | 22:00 | |
| *** marst_ has quit IRC | 22:00 | |
| *** gfhellma has quit IRC | 22:01 | |
| *** marst_ has joined #openstack-nova | 22:01 | |
| *** catintheroof has quit IRC | 22:01 | |
| *** mdrabe has quit IRC | 22:03 | |
| *** abalutoiu_ has quit IRC | 22:04 | |
| *** abalutoiu_ has joined #openstack-nova | 22:04 | |
| *** fragatin_ has joined #openstack-nova | 22:05 | |
| *** marst_ has quit IRC | 22:05 | |
| *** fragatina has quit IRC | 22:08 | |
| *** ianw_pto is now known as ianw | 22:12 | |
| *** amotoki has joined #openstack-nova | 22:13 | |
| *** xyang1 has quit IRC | 22:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate TypeAffinityFilter https://review.openstack.org/457812 | 22:17 |
| *** Sukhdev has quit IRC | 22:17 | |
| *** ijw has quit IRC | 22:21 | |
| mriedem | nova.tests.unit.virt.ironic.test_driver.IronicDriverConsoleTestCase.test__get_node_console_with_reset_wait_timeout is definitely failing due to something changing with the enforce_type stuff in https://review.openstack.org/#/c/457188/ <- gcb | 22:23 |
| mriedem | oh because it changed from a 0.1 to a 1 | 22:23 |
| *** Apoorva_ has quit IRC | 22:24 | |
| mriedem | and _CONSOLE_STATE_CHECKING_INTERVAL is set to 0.05 | 22:24 |
| *** Apoorva has joined #openstack-nova | 22:24 | |
| mriedem | jitter=0.5 in the driver | 22:25 |
| *** felipemonteiro has quit IRC | 22:30 | |
| mriedem | https://bugs.launchpad.net/nova/+bug/1683953 | 22:33 |
| openstack | Launchpad bug 1683953 in OpenStack Compute (nova) "IronicDriverConsoleTestCase.test__get_node_console_with_reset_wait_timeout intermittently fails since 4/18" [Medium,Confirmed] | 22:33 |
| *** Jack_Iv has joined #openstack-nova | 22:38 | |
| *** thorst has joined #openstack-nova | 22:41 | |
| *** Jack_Iv has quit IRC | 22:42 | |
| *** thorst has quit IRC | 22:43 | |
| *** thorst has joined #openstack-nova | 22:43 | |
| *** jianghuaw_ has joined #openstack-nova | 22:43 | |
| *** tjones has quit IRC | 22:43 | |
| *** jaypipes has quit IRC | 22:46 | |
| *** thorst has quit IRC | 22:47 | |
| *** jianghuaw_ has quit IRC | 22:48 | |
| *** salv-orl_ has quit IRC | 22:48 | |
| *** tjones has joined #openstack-nova | 22:50 | |
| *** tjones has quit IRC | 22:52 | |
| *** artom has quit IRC | 22:53 | |
| *** artom has joined #openstack-nova | 22:53 | |
| *** david-lyle has joined #openstack-nova | 22:53 | |
| *** david-lyle has quit IRC | 22:56 | |
| *** aloga has quit IRC | 22:57 | |
| *** ijw has joined #openstack-nova | 22:59 | |
| *** aloga has joined #openstack-nova | 23:03 | |
| *** ijw has quit IRC | 23:03 | |
| *** fragatin_ has quit IRC | 23:05 | |
| *** fragatina has joined #openstack-nova | 23:06 | |
| *** vladikr has joined #openstack-nova | 23:08 | |
| *** gjayavelu has quit IRC | 23:11 | |
| *** thorst has joined #openstack-nova | 23:15 | |
| *** slaweq has quit IRC | 23:16 | |
| *** ngupta has quit IRC | 23:23 | |
| *** ngupta has joined #openstack-nova | 23:24 | |
| *** ngupta has quit IRC | 23:28 | |
| *** mlavalle has quit IRC | 23:30 | |
| *** chyka has quit IRC | 23:33 | |
| *** gouthamr has joined #openstack-nova | 23:33 | |
| gmann | mriedem: not yet, i am planning after summit and once we have extensions removal in good progress and more people can join hands there | 23:34 |
| *** Sukhdev has joined #openstack-nova | 23:35 | |
| *** amotoki has quit IRC | 23:37 | |
| *** aloga has quit IRC | 23:37 | |
| *** tjones has joined #openstack-nova | 23:38 | |
| *** baoli has joined #openstack-nova | 23:38 | |
| *** tjones has quit IRC | 23:39 | |
| *** aloga has joined #openstack-nova | 23:41 | |
| *** Nakato has quit IRC | 23:45 | |
| *** Nakato has joined #openstack-nova | 23:46 | |
| mriedem | ok | 23:47 |
| *** vladikr has quit IRC | 23:49 | |
| *** artom has quit IRC | 23:49 | |
| *** artom has joined #openstack-nova | 23:50 | |
| *** amotoki has joined #openstack-nova | 23:50 | |
| *** artom has quit IRC | 23:52 | |
| *** artom has joined #openstack-nova | 23:52 | |
| *** hongbin has quit IRC | 23:55 | |
| *** rfolco has joined #openstack-nova | 23:56 | |
| *** rfolco has quit IRC | 23:56 | |
| *** ijw has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!