| *** yamahata has joined #openstack-nova | 00:02 | |
| *** masber has joined #openstack-nova | 00:05 | |
| *** kaisers has joined #openstack-nova | 00:36 | |
| *** dillaman has quit IRC | 00:38 | |
| mriedem | Kevin_Zheng: i think i have a much easier way to fix this https://review.openstack.org/#/c/403568/ | 00:39 |
|---|---|---|
| Kevin_Zheng | mriedem: thanks，Im looking at it | 00:40 |
| *** artom has quit IRC | 00:42 | |
| *** tobasco has quit IRC | 00:42 | |
| *** artom has joined #openstack-nova | 00:42 | |
| mriedem | let me work something up quick | 00:44 |
| *** erlon has quit IRC | 00:45 | |
| *** suresh12 has joined #openstack-nova | 00:45 | |
| *** READ10 is now known as READ10|away | 00:46 | |
| *** tobasco has joined #openstack-nova | 00:46 | |
| *** ssurana has joined #openstack-nova | 00:51 | |
| *** ssurana has quit IRC | 00:52 | |
| *** baoli has quit IRC | 00:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577 | 00:53 |
| mriedem | Kevin_Zheng: ^ see if that works, i still need to update tests | 00:53 |
| *** suresh12 has quit IRC | 00:53 | |
| *** ssurana has joined #openstack-nova | 00:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577 | 00:55 |
| *** baoli has joined #openstack-nova | 00:58 | |
| mriedem | i'll be back in an hour or so | 00:58 |
| *** nic has joined #openstack-nova | 01:00 | |
| *** nic has quit IRC | 01:00 | |
| *** yamahata has quit IRC | 01:03 | |
| *** jamielennox|away is now known as jamielennox | 01:06 | |
| *** NikhilS has joined #openstack-nova | 01:09 | |
| *** gcb has joined #openstack-nova | 01:14 | |
| *** baoli has quit IRC | 01:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | 01:19 |
| *** takashin_ has joined #openstack-nova | 01:24 | |
| *** takashin has quit IRC | 01:24 | |
| *** kaisers has quit IRC | 01:27 | |
| *** baoli has joined #openstack-nova | 01:29 | |
| *** tuanluong has joined #openstack-nova | 01:35 | |
| *** thorst has joined #openstack-nova | 01:37 | |
| *** thorst has quit IRC | 01:42 | |
| *** baoli has quit IRC | 01:43 | |
| *** kaisers has joined #openstack-nova | 01:44 | |
| *** tovin07 has joined #openstack-nova | 01:50 | |
| *** nkorabli has joined #openstack-nova | 01:55 | |
| *** fandi has joined #openstack-nova | 01:57 | |
| *** rcernin has joined #openstack-nova | 01:58 | |
| *** nkorabli has quit IRC | 01:59 | |
| *** lucas-afk has quit IRC | 02:23 | |
| *** lucasagomes has joined #openstack-nova | 02:25 | |
| *** baoli has joined #openstack-nova | 02:28 | |
| *** yamamoto has joined #openstack-nova | 02:29 | |
| *** baoli_ has joined #openstack-nova | 02:30 | |
| mordred | mriedem: I was | 02:30 |
| mordred | mriedem: basically, the idea that I could put metadata on my glance image and it somehow at boot time might cause other volumes to be needed/mounted is both surprising and also might solve one of clarkb's complaints with booting servers with volumes | 02:31 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 02:33 |
| *** baoli has quit IRC | 02:33 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 02:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 02:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 02:35 |
| mriedem | mordred: all sorts of undocumented goodies lurk beneath | 02:36 |
| mriedem | and apparently is why we can never change anything | 02:36 |
| *** tbachman has quit IRC | 02:38 | |
| *** thorst has joined #openstack-nova | 02:38 | |
| *** suresh12 has joined #openstack-nova | 02:39 | |
| *** amotoki has joined #openstack-nova | 02:39 | |
| *** gouthamr has quit IRC | 02:41 | |
| *** suresh12 has quit IRC | 02:43 | |
| *** rcernin has quit IRC | 02:45 | |
| *** brault|away has joined #openstack-nova | 02:46 | |
| *** baoli_ has quit IRC | 02:50 | |
| *** brault|away has quit IRC | 02:51 | |
| *** baoli has joined #openstack-nova | 02:51 | |
| *** catintheroof has joined #openstack-nova | 02:55 | |
| *** dave-mccowan has joined #openstack-nova | 02:55 | |
| *** sridharg has joined #openstack-nova | 02:56 | |
| *** sridharg has quit IRC | 02:57 | |
| *** thorst has quit IRC | 02:57 | |
| *** ducttape_ has joined #openstack-nova | 02:57 | |
| *** dave-mcc_ has quit IRC | 02:57 | |
| *** ducttape_ has quit IRC | 02:58 | |
| *** ducttape_ has joined #openstack-nova | 02:58 | |
| *** pjm6 has quit IRC | 02:59 | |
| *** mlavalle has joined #openstack-nova | 02:59 | |
| *** amotoki has quit IRC | 03:00 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| mordred | mriedem: fantastic | 03:06 |
| mordred | mriedem: I may, when it's not 10pm on a Sunday night, ping you more to try to learn more things | 03:07 |
| *** mlavalle has quit IRC | 03:07 | |
| mriedem | wfm | 03:07 |
| mriedem | i'm learning too :) | 03:07 |
| *** tjones has joined #openstack-nova | 03:08 | |
| *** tjones has quit IRC | 03:08 | |
| *** artom has quit IRC | 03:09 | |
| *** artom has joined #openstack-nova | 03:09 | |
| *** fragatina has quit IRC | 03:10 | |
| *** artom has quit IRC | 03:10 | |
| *** artom has joined #openstack-nova | 03:10 | |
| *** baoli has quit IRC | 03:16 | |
| *** ducttape_ has quit IRC | 03:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577 | 03:18 |
| *** sree has joined #openstack-nova | 03:20 | |
| *** amotoki has joined #openstack-nova | 03:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Preserve pre-existing port when attach interface fails https://review.openstack.org/452577 | 03:21 |
| *** mriedem has quit IRC | 03:21 | |
| *** ducttape_ has joined #openstack-nova | 03:22 | |
| *** ducttape_ has quit IRC | 03:24 | |
| *** ducttape_ has joined #openstack-nova | 03:24 | |
| *** mlavalle has joined #openstack-nova | 03:26 | |
| *** mlavalle has quit IRC | 03:26 | |
| *** sree has quit IRC | 03:28 | |
| *** sree has joined #openstack-nova | 03:28 | |
| *** amotoki has quit IRC | 03:29 | |
| *** jwcroppe has quit IRC | 03:31 | |
| *** jwcroppe has joined #openstack-nova | 03:32 | |
| *** sree has quit IRC | 03:33 | |
| *** kaisers has quit IRC | 03:36 | |
| *** kaisers has joined #openstack-nova | 03:36 | |
| *** yamamoto has quit IRC | 03:37 | |
| *** amotoki has joined #openstack-nova | 03:38 | |
| *** kaisers has quit IRC | 03:40 | |
| *** kaisers has joined #openstack-nova | 03:41 | |
| *** ducttape_ has quit IRC | 03:41 | |
| *** kaisers has quit IRC | 03:45 | |
| *** ducttape_ has joined #openstack-nova | 03:48 | |
| *** thorst has joined #openstack-nova | 03:54 | |
| *** dharinic has joined #openstack-nova | 03:54 | |
| *** ducttape_ has quit IRC | 03:55 | |
| *** thorst has quit IRC | 03:58 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:01 | |
| *** amotoki has quit IRC | 04:01 | |
| *** fragatina has joined #openstack-nova | 04:01 | |
| *** fragatina has quit IRC | 04:04 | |
| *** kaisers has joined #openstack-nova | 04:04 | |
| *** fragatina has joined #openstack-nova | 04:04 | |
| *** vks1 has joined #openstack-nova | 04:06 | |
| *** amotoki has joined #openstack-nova | 04:08 | |
| *** trinaths has joined #openstack-nova | 04:09 | |
| *** iceyao has joined #openstack-nova | 04:09 | |
| *** catintheroof has quit IRC | 04:10 | |
| *** iceyao has quit IRC | 04:10 | |
| *** kaisers_ has joined #openstack-nova | 04:11 | |
| *** kaisers_ has quit IRC | 04:15 | |
| *** yamamoto has joined #openstack-nova | 04:16 | |
| *** iceyao has joined #openstack-nova | 04:19 | |
| *** suresh12 has joined #openstack-nova | 04:23 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936 | 04:24 |
| *** psachin has joined #openstack-nova | 04:26 | |
| *** haplo37 has quit IRC | 04:32 | |
| *** haplo37 has joined #openstack-nova | 04:35 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova-specs master: Add use-local-scheduler spec https://review.openstack.org/438936 | 04:36 |
| *** fandi__ has joined #openstack-nova | 04:41 | |
| *** Jack_Iv has joined #openstack-nova | 04:44 | |
| *** bmace has quit IRC | 04:45 | |
| *** fandi has quit IRC | 04:45 | |
| *** bmace has joined #openstack-nova | 04:45 | |
| *** ducttape_ has joined #openstack-nova | 04:48 | |
| *** kaisers has quit IRC | 04:49 | |
| *** ducttape_ has quit IRC | 04:53 | |
| *** thorst has joined #openstack-nova | 04:54 | |
| *** rcernin has joined #openstack-nova | 04:56 | |
| *** thorst has quit IRC | 04:59 | |
| *** kaisers has joined #openstack-nova | 05:00 | |
| *** iceyao has quit IRC | 05:03 | |
| *** Jack_Iv has quit IRC | 05:03 | |
| *** kaisers1 has joined #openstack-nova | 05:04 | |
| *** kaisers has quit IRC | 05:10 | |
| *** udesale has joined #openstack-nova | 05:11 | |
| *** ratailor has joined #openstack-nova | 05:12 | |
| *** dharinic has quit IRC | 05:12 | |
| *** iceyao has joined #openstack-nova | 05:12 | |
| *** ratailor has quit IRC | 05:13 | |
| *** udesale has quit IRC | 05:14 | |
| *** udesale has joined #openstack-nova | 05:15 | |
| *** kaisers1 has quit IRC | 05:15 | |
| *** iceyao has quit IRC | 05:17 | |
| *** claudiub has joined #openstack-nova | 05:17 | |
| *** rcernin has quit IRC | 05:18 | |
| *** Jack_Iv has joined #openstack-nova | 05:18 | |
| *** ratailor has joined #openstack-nova | 05:18 | |
| *** dimtruck is now known as zz_dimtruck | 05:24 | |
| *** zz_dimtruck is now known as dimtruck | 05:24 | |
| *** udesale has quit IRC | 05:27 | |
| *** udesale has joined #openstack-nova | 05:27 | |
| *** prateek has joined #openstack-nova | 05:29 | |
| *** lpetrut has joined #openstack-nova | 05:30 | |
| *** rcernin has joined #openstack-nova | 05:31 | |
| *** kaisers has joined #openstack-nova | 05:32 | |
| *** lpetrut has quit IRC | 05:33 | |
| *** dimtruck is now known as zz_dimtruck | 05:33 | |
| *** iceyao has joined #openstack-nova | 05:39 | |
| *** Fdaisuke has joined #openstack-nova | 05:40 | |
| *** kaisers has quit IRC | 05:41 | |
| *** IRCFrEAK has joined #openstack-nova | 05:45 | |
| *** IRCFrEAK has left #openstack-nova | 05:47 | |
| *** ecelik has joined #openstack-nova | 05:51 | |
| *** ecelik has left #openstack-nova | 05:51 | |
| *** mdnadeem has joined #openstack-nova | 05:51 | |
| *** iceyao_ has joined #openstack-nova | 05:54 | |
| *** thorst has joined #openstack-nova | 05:55 | |
| *** yamahata has joined #openstack-nova | 05:55 | |
| *** kaisers has joined #openstack-nova | 05:56 | |
| *** iceyao has quit IRC | 05:57 | |
| *** thorst has quit IRC | 05:59 | |
| *** kaisers has quit IRC | 06:03 | |
| *** oomichi has quit IRC | 06:03 | |
| *** oomichi has joined #openstack-nova | 06:04 | |
| *** ratailor has quit IRC | 06:04 | |
| *** sree has joined #openstack-nova | 06:07 | |
| *** gcb has quit IRC | 06:07 | |
| *** ratailor has joined #openstack-nova | 06:07 | |
| *** ltomasbo|away is now known as ltomasbo | 06:08 | |
| *** Oku_OS-away is now known as Oku_OS | 06:10 | |
| *** kaisers has joined #openstack-nova | 06:11 | |
| *** mkoderer has joined #openstack-nova | 06:15 | |
| *** ducttape_ has joined #openstack-nova | 06:18 | |
| *** kaisers1 has joined #openstack-nova | 06:19 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502 | 06:19 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861 | 06:19 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - manager.py https://review.openstack.org/359868 | 06:19 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py https://review.openstack.org/359871 | 06:19 |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code complexity - libvirt/config.py https://review.openstack.org/359879 | 06:19 |
| *** Jack_Iv has quit IRC | 06:20 | |
| *** nkrinner_afk is now known as nkrinner | 06:20 | |
| *** ducttape_ has quit IRC | 06:23 | |
| *** mnestratov has joined #openstack-nova | 06:29 | |
| *** oomichi has quit IRC | 06:29 | |
| *** oomichi has joined #openstack-nova | 06:30 | |
| *** voelzmo has joined #openstack-nova | 06:31 | |
| openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882 | 06:32 |
| *** jwcroppe has quit IRC | 06:32 | |
| *** jwcroppe has joined #openstack-nova | 06:32 | |
| *** kaisers1 has quit IRC | 06:33 | |
| *** tesseract has joined #openstack-nova | 06:34 | |
| *** hoonetorg has quit IRC | 06:37 | |
| *** voelzmo has quit IRC | 06:38 | |
| *** voelzmo has joined #openstack-nova | 06:42 | |
| *** brault|away has joined #openstack-nova | 06:42 | |
| *** ralonsoh has joined #openstack-nova | 06:43 | |
| *** andreas_s has joined #openstack-nova | 06:50 | |
| *** kaisers1 has joined #openstack-nova | 06:50 | |
| *** belmoreira has joined #openstack-nova | 06:50 | |
| *** sridharg has joined #openstack-nova | 06:52 | |
| *** suresh12 has quit IRC | 06:54 | |
| *** thorst has joined #openstack-nova | 06:56 | |
| *** pcaruana has joined #openstack-nova | 06:57 | |
| *** udesale has quit IRC | 06:57 | |
| *** jaosorior has joined #openstack-nova | 06:57 | |
| *** udesale has joined #openstack-nova | 06:58 | |
| *** moshele has joined #openstack-nova | 06:58 | |
| *** markus_z has joined #openstack-nova | 06:58 | |
| *** udesale has quit IRC | 06:58 | |
| *** udesale has joined #openstack-nova | 06:59 | |
| *** Jack_Iv has joined #openstack-nova | 07:00 | |
| *** thorst has quit IRC | 07:00 | |
| *** zz_dimtruck is now known as dimtruck | 07:01 | |
| *** kaisers1 has quit IRC | 07:02 | |
| *** satyar has joined #openstack-nova | 07:04 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 07:08 |
| *** dimtruck is now known as zz_dimtruck | 07:11 | |
| *** kaisers1 has joined #openstack-nova | 07:17 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782 | 07:19 |
| *** amoralej|off is now known as amoralej | 07:20 | |
| *** Jack_Iv has joined #openstack-nova | 07:23 | |
| *** d9k has quit IRC | 07:31 | |
| *** d9k has joined #openstack-nova | 07:31 | |
| *** kaisers1 has quit IRC | 07:33 | |
| *** avolkov has joined #openstack-nova | 07:36 | |
| *** amotoki_ has joined #openstack-nova | 07:41 | |
| *** Jack_Iv has quit IRC | 07:43 | |
| *** amotoki has quit IRC | 07:44 | |
| *** ducttape_ has joined #openstack-nova | 07:49 | |
| *** kaisers1 has joined #openstack-nova | 07:49 | |
| *** kaisers has quit IRC | 07:51 | |
| *** ducttape_ has quit IRC | 07:54 | |
| *** thorst has joined #openstack-nova | 07:56 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** nkorabli has joined #openstack-nova | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** zz_dimtruck is now known as dimtruck | 08:02 | |
| *** mlakat has joined #openstack-nova | 08:02 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** kaisers has joined #openstack-nova | 08:04 | |
| *** dimtruck is now known as zz_dimtruck | 08:12 | |
| *** thorst has quit IRC | 08:16 | |
| *** iceyao_ has quit IRC | 08:18 | |
| *** iceyao has joined #openstack-nova | 08:18 | |
| *** nmathew has joined #openstack-nova | 08:24 | |
| *** fragatina has quit IRC | 08:28 | |
| *** kaisers has quit IRC | 08:38 | |
| *** lpetrut has joined #openstack-nova | 08:41 | |
| *** derekh has joined #openstack-nova | 08:42 | |
| *** jpena|off is now known as jpena | 08:42 | |
| *** yamahata has quit IRC | 08:48 | |
| *** owalsh is now known as owalsh_afk | 08:49 | |
| *** iceyao has quit IRC | 08:50 | |
| *** mtreinish has quit IRC | 08:53 | |
| *** abhishek_k has joined #openstack-nova | 08:54 | |
| *** suresh12 has joined #openstack-nova | 08:55 | |
| *** abhishekk has quit IRC | 08:55 | |
| *** trinaths has quit IRC | 08:55 | |
| *** mtreinish has joined #openstack-nova | 08:57 | |
| *** suresh12 has quit IRC | 08:59 | |
| *** openstackgerrit has joined #openstack-nova | 09:02 | |
| openstackgerrit | Tadas Ustinavičius proposed openstack/nova master: Implements: blueprint custom-emulator-path https://review.openstack.org/452646 | 09:02 |
| *** zz_dimtruck is now known as dimtruck | 09:02 | |
| *** trinaths has joined #openstack-nova | 09:07 | |
| *** dimtruck is now known as zz_dimtruck | 09:12 | |
| *** thorst has joined #openstack-nova | 09:13 | |
| *** cdent has joined #openstack-nova | 09:14 | |
| *** yassine has joined #openstack-nova | 09:17 | |
| *** yassine is now known as Guest63262 | 09:17 | |
| *** thorst has quit IRC | 09:17 | |
| *** bhagyashris has joined #openstack-nova | 09:17 | |
| *** ducttape_ has joined #openstack-nova | 09:20 | |
| *** ducttape_ has quit IRC | 09:24 | |
| *** szaher has quit IRC | 09:25 | |
| *** amotoki_ has quit IRC | 09:25 | |
| *** sambetts|afk is now known as sambetts | 09:25 | |
| *** lpetrut has quit IRC | 09:26 | |
| *** karimb has joined #openstack-nova | 09:27 | |
| *** abalutoiu has joined #openstack-nova | 09:28 | |
| *** szaher has joined #openstack-nova | 09:30 | |
| *** szaher has quit IRC | 09:33 | |
| *** prateek has quit IRC | 09:33 | |
| *** kaisers has joined #openstack-nova | 09:33 | |
| *** takashin_ has left #openstack-nova | 09:34 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add policy-remove-scope-checks spec https://review.openstack.org/433037 | 09:35 |
| *** kaisers has quit IRC | 09:38 | |
| *** szaher has joined #openstack-nova | 09:39 | |
| *** trinaths1 has joined #openstack-nova | 09:40 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872 | 09:42 |
| *** trinaths has quit IRC | 09:42 | |
| *** karimb has quit IRC | 09:43 | |
| *** NikhilS has quit IRC | 09:46 | |
| *** prateek has joined #openstack-nova | 09:47 | |
| *** trinaths1 has left #openstack-nova | 09:47 | |
| *** prateek has quit IRC | 09:47 | |
| *** prateek has joined #openstack-nova | 09:47 | |
| *** lpetrut has joined #openstack-nova | 09:48 | |
| *** trinaths has joined #openstack-nova | 09:49 | |
| *** pjm6 has joined #openstack-nova | 09:50 | |
| *** lpetrut has quit IRC | 09:51 | |
| *** karimb has joined #openstack-nova | 09:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: doc: Rewrap 'vif_types' document https://review.openstack.org/452665 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: doc: Add glossary https://review.openstack.org/452666 | 09:53 |
| *** tovin07_ has joined #openstack-nova | 09:53 | |
| *** lpetrut has joined #openstack-nova | 09:53 | |
| *** lpetrut has quit IRC | 09:53 | |
| *** prateek has quit IRC | 09:56 | |
| *** prateek_ has joined #openstack-nova | 09:56 | |
| *** tovin07__ has joined #openstack-nova | 09:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Flatten functions https://review.openstack.org/367470 | 09:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraints' functions https://review.openstack.org/385071 | 09:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072 | 09:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074 | 09:57 |
| *** tovin07__ has quit IRC | 09:59 | |
| *** prateek has joined #openstack-nova | 10:00 | |
| *** pjm6 has quit IRC | 10:00 | |
| *** tovin07_ has quit IRC | 10:00 | |
| *** tovin07 has quit IRC | 10:01 | |
| *** szaher has quit IRC | 10:01 | |
| *** owalsh_afk is now known as owalsh | 10:02 | |
| *** prateek_ has quit IRC | 10:03 | |
| *** tbachman has joined #openstack-nova | 10:03 | |
| *** zz_dimtruck is now known as dimtruck | 10:03 | |
| *** szaher has joined #openstack-nova | 10:04 | |
| *** rcernin has quit IRC | 10:05 | |
| *** fandi__ has quit IRC | 10:05 | |
| *** pjm6 has joined #openstack-nova | 10:05 | |
| *** hoonetorg has joined #openstack-nova | 10:07 | |
| *** prateek has quit IRC | 10:09 | |
| *** lpetrut has joined #openstack-nova | 10:10 | |
| *** szaher has quit IRC | 10:10 | |
| *** szaher has joined #openstack-nova | 10:11 | |
| *** dimtruck is now known as zz_dimtruck | 10:13 | |
| *** ssurana has quit IRC | 10:14 | |
| *** prateek has joined #openstack-nova | 10:15 | |
| *** satyar has quit IRC | 10:20 | |
| *** tbachman has quit IRC | 10:20 | |
| *** lpetrut has quit IRC | 10:21 | |
| *** tbachman has joined #openstack-nova | 10:23 | |
| *** sdague has joined #openstack-nova | 10:23 | |
| *** nicolasbock has joined #openstack-nova | 10:23 | |
| *** rcernin has joined #openstack-nova | 10:24 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | 10:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 10:26 |
| *** lpetrut has joined #openstack-nova | 10:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Optimize creating security_group https://review.openstack.org/315311 | 10:30 |
| *** f10d4 has joined #openstack-nova | 10:34 | |
| f10d4 | hi | 10:34 |
| *** lpetrut has quit IRC | 10:34 | |
| *** kaisers has joined #openstack-nova | 10:34 | |
| *** lpetrut has joined #openstack-nova | 10:34 | |
| *** psachin has quit IRC | 10:34 | |
| *** lpetrut has quit IRC | 10:39 | |
| *** sree has quit IRC | 10:41 | |
| *** sree has joined #openstack-nova | 10:42 | |
| *** ducttape_ has joined #openstack-nova | 10:50 | |
| *** psachin has joined #openstack-nova | 10:51 | |
| *** ducttape_ has quit IRC | 10:55 | |
| *** sree has quit IRC | 10:57 | |
| *** sree has joined #openstack-nova | 10:58 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventories https://review.openstack.org/449765 | 11:02 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for POST RP inventories https://review.openstack.org/451855 | 11:02 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventories https://review.openstack.org/452707 | 11:02 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventories https://review.openstack.org/452708 | 11:02 |
| *** sree has quit IRC | 11:02 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872 | 11:02 |
| *** zz_dimtruck is now known as dimtruck | 11:04 | |
| *** moshele has quit IRC | 11:10 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782 | 11:10 |
| johnthetubaguy | ildikov: had a deeper look at this check_detach patch, actually I think we loose some super important checks, but I could be missing something big: https://review.openstack.org/#/c/446671 | 11:13 |
| *** dimtruck is now known as zz_dimtruck | 11:14 | |
| *** gszasz has joined #openstack-nova | 11:15 | |
| *** lucasagomes is now known as lucas-hungry | 11:20 | |
| *** Jack_Iv has joined #openstack-nova | 11:22 | |
| ildikov | johnthetubaguy: I added that check as a prep for multi-attach, which Nova still does not support | 11:27 |
| johnthetubaguy | ildikov: right, but I am saying it breaks all our existing users, how do we stop that | 11:28 |
| johnthetubaguy | ildikov: it seems like it would work fine with multi-attach to me, it would be good to describe what checks are bad for multi-attach there, I guess its one of the status checkes | 11:29 |
| ildikov | johnthetubaguy: it's just that it's unnecessary just like the check_attach was | 11:29 |
| johnthetubaguy | ildikov: I described in my comments, I believe its critical | 11:29 |
| ildikov | johnthetubaguy: it's Cinder who should do the status checks | 11:30 |
| johnthetubaguy | ildikov: sure, but we don't have an API in the new flow to do that | 11:30 |
| ildikov | ildikov: the status checks you mean? | 11:30 |
| johnthetubaguy | ildikov: and the old flow doesn't seem to check the instance uuid | 11:30 |
| *** READ10|away has quit IRC | 11:31 | |
| ildikov | johnthetubaguy: because it didn't need to | 11:31 |
| johnthetubaguy | ildikov: ... so your patch says stop check_detach, because we can just call begin_detaching? | 11:31 |
| johnthetubaguy | ildikov: it really, really does | 11:31 |
| ildikov | johnthetubaguy: I think we went through the detach cases when we removed check_attach and I think we got a good coverage, but I need to look into the code | 11:32 |
| johnthetubaguy | ildikov: so lets think about the new flow quickly | 11:32 |
| johnthetubaguy | ildikov: what call does the checks? | 11:32 |
| ildikov | johnthetubaguy: you need to find the attachment_id in the bdm to detach | 11:33 |
| johnthetubaguy | ildikov: that doesn't tell us what the state of that attachment is, we could be out of sync | 11:33 |
| *** huyang_ has joined #openstack-nova | 11:33 | |
| ildikov | johnthetubaguy: the attachment state is Cinder's responsibility | 11:34 |
| johnthetubaguy | ildikov: we still need to check that the user has asked us to detach a volume that is currently attached to the instance | 11:34 |
| *** thorst has joined #openstack-nova | 11:34 | |
| johnthetubaguy | ildikov: I agree in principal, but we don't have the APIs for it in the new flow | 11:34 |
| ildikov | johnthetubaguy: Cinder should do that either as part of attachment_delete or we can look into other options | 11:34 |
| ildikov | johnthetubaguy: for attach we can create an empty attachment to lock the volume and not for the status checks either | 11:35 |
| johnthetubaguy | ildikov: so attachment_delete is after the API has returned, and after we have attempted to remove the volume | 11:35 |
| *** pjm6 has quit IRC | 11:35 | |
| johnthetubaguy | ildikov: so we need a spec in Nova to describe all the multi_attach loose ends | 11:36 |
| *** thorst has quit IRC | 11:36 | |
| ildikov | johnthetubaguy: we need that for other reasons too | 11:37 |
| johnthetubaguy | ildikov: this might be one of those, be we need to be clear what checks are replacing our existing guard rails, and describe how you don't break the current API behaviour for Nova | 11:37 |
| ildikov | johnthetubaguy: I would like to just clean up the code and solve the problems that we really have at the right place | 11:37 |
| *** ttx has quit IRC | 11:38 | |
| johnthetubaguy | ildikov: we have the same goal, the problem is your patch breaks our API | 11:38 |
| *** ttx has joined #openstack-nova | 11:38 | |
| ildikov | johnthetubaguy: even for the non-dteach cases? | 11:38 |
| *** pjm6 has joined #openstack-nova | 11:38 | |
| *** kaisers has quit IRC | 11:38 | |
| ildikov | *non-detach | 11:38 |
| johnthetubaguy | ildikov: its breaks the detach flow only, AFAIK | 11:38 |
| johnthetubaguy | when you call detach with a volume attach on a different instance, we end up doing some very strange things to the volume the user passed into our API | 11:39 |
| ildikov | johnthetubaguy: bah, sorry I meant non-multi-attach | 11:39 |
| johnthetubaguy | yes, it breaks all regular detaches | 11:39 |
| johnthetubaguy | we now report errors in different places, for some cases, other cases I think just break horribly and cause possible data corrupution | 11:40 |
| ildikov | I wonder whether that check will be the first place to recognize that | 11:40 |
| johnthetubaguy | I attempted to describe that in the review comments | 11:40 |
| johnthetubaguy | ildikov: don't know | 11:40 |
| ildikov | I saw that, but if I don't mess with the code purely because of multi-attach that check wouldn't be there | 11:40 |
| *** trinaths has quit IRC | 11:40 | |
| ildikov | it's not part of the regular detach flow by design | 11:41 |
| *** lpetrut has joined #openstack-nova | 11:41 | |
| johnthetubaguy | ildikov: so I think it would be much easier for me to review this if we can write up your thinking around the change, and how all these checks should be done | 11:41 |
| johnthetubaguy | ildikov: a few notes in the git commit message might be the best way to start it, but honestly, it feels like it needs a spec, because its API sensitive | 11:42 |
| *** tuanluong has quit IRC | 11:42 | |
| ildikov | and even for multi-attach case as we have the attachment_id stored in the bdm that approach should help | 11:43 |
| johnthetubaguy | ildikov: I am not sure how that helps the old code flow | 11:43 |
| johnthetubaguy | that would still be broken | 11:43 |
| ildikov | johnthetubaguy: I will look into that later, on a conference this week | 11:43 |
| *** lpetrut has quit IRC | 11:44 | |
| ildikov | johnthetubaguy: I will test the old flow case and if I hit that error message I will look into how to fix that | 11:44 |
| ildikov | johnthetubaguy: but the status checks should go regardless | 11:44 |
| ildikov | johnthetubaguy: that shouldn't be in Nova | 11:44 |
| johnthetubaguy | ildikov: its the error handling where we hit problems, bad volume-uuids, volume-uuids that are not attached, volume-uuids attached to other instances, volume-uuids for volumes that are already part way through the detach process, we want to give the user an API error, rather than a 200 | 11:45 |
| johnthetubaguy | ildikov: as I said, agreed with the goal, just the new flow doesn't have an API for that right now, as I see it, and it seems the old flow still needs these checks | 11:45 |
| ildikov | johnthetubaguy: I will look into that, I cannot tell you more now from te top of my head about this | 11:47 |
| johnthetubaguy | ildikov: that no problem, I just think we need to get this all written down / agreed first | 11:48 |
| ildikov | johnthetubaguy: I just really hope we can clean up the code more, if we can't I'm not going make anything more complicated just to delete 10-20 lines | 11:49 |
| *** jgr is now known as jgrassler | 11:49 | |
| johnthetubaguy | ildikov: me too, I am just trying to understand how this doesn't break the existing flow | 11:50 |
| johnthetubaguy | the error handling in it | 11:50 |
| ildikov | sure, let me look into that later | 11:50 |
| ildikov | thanks for raising your concerns, the goal isn't to break the API | 11:50 |
| johnthetubaguy | ildikov: I think this might actually just be when the Cinder and Nova state drift appart, but thats possible with force-detach | 11:51 |
| johnthetubaguy | ildikov: we do check with the BDM further up (that logic really shouldn't be in there, but it is): https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/volumes.py#L431 | 11:51 |
| *** voelzmo has quit IRC | 11:52 | |
| ildikov | johnthetubaguy: so you check the volume_id in the BDM | 11:53 |
| *** voelzmo has joined #openstack-nova | 11:53 | |
| ildikov | johnthetubaguy: if it does not match you don't do anything | 11:54 |
| *** vks1 has quit IRC | 11:55 | |
| *** suresh12 has joined #openstack-nova | 11:55 | |
| *** karimb has quit IRC | 11:55 | |
| johnthetubaguy | ildikov: yeah, I missed all that logic, it certainly protects against the worse bits of what I was worried about | 11:56 |
| johnthetubaguy | ildikov: hence the fresh link above | 11:57 |
| ildikov | johnthetubaguy: it would've been weird to be honest if that checks points that out first as it wasn't part of a bugfix or anything like that | 11:57 |
| ildikov | s/checks/check/ | 11:58 |
| *** psachin has quit IRC | 11:58 | |
| *** suresh12 has quit IRC | 11:59 | |
| *** ratailor has quit IRC | 12:00 | |
| *** thorst has joined #openstack-nova | 12:00 | |
| *** jangutter has joined #openstack-nova | 12:03 | |
| *** zz_dimtruck is now known as dimtruck | 12:05 | |
| *** jaypipes has joined #openstack-nova | 12:05 | |
| *** lucas-hungry is now known as lucasagomes | 12:07 | |
| *** prateek has quit IRC | 12:10 | |
| *** psachin has joined #openstack-nova | 12:11 | |
| *** dimtruck is now known as zz_dimtruck | 12:15 | |
| *** danpawlik has joined #openstack-nova | 12:18 | |
| markus_z | Is anyone aware of issues with centos nodes and oslo.serialization? Our s390x CI is centos based and goes mad since a few day, other upstream test jobs fail too: http://logstash.openstack.org/#dashboard/file/logstash.json?from=7d&query=message%3A%5C%22Malformed%20request%20body%5C%22 | 12:19 |
| markus_z | oslo.serialization 2.18 merged to u-c a a few days ago: https://github.com/openstack/requirements/commit/f0952e715c247ac570ed86341580bbe82fd85760 | 12:20 |
| markus_z | And the requirements project doesn't have a centos job: https://review.openstack.org/#/c/450508/ | 12:20 |
| *** ducttape_ has joined #openstack-nova | 12:20 | |
| *** gouthamr has joined #openstack-nova | 12:21 | |
| markus_z | I checked all test jobs of that logstash query, all with the same issue, at the same "server tagging" tests. | 12:22 |
| markus_z | Might be the PUT with an empty body. | 12:22 |
| *** _ducttape_ has joined #openstack-nova | 12:24 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova-specs master: Stop using Neutron admin token https://review.openstack.org/439890 | 12:25 |
| markus_z | And, IIUC, json decode issue won't get logged because that message https://github.com/openstack/nova/blob/94671e279fddc0d8eba29375750dd85410a0b9b9/nova/api/openstack/wsgi.py#L266-L271 gets overwritten by https://github.com/openstack/nova/blob/94671e279fddc0d8eba29375750dd85410a0b9b9/nova/api/openstack/wsgi.py#L635-L637 | 12:26 |
| *** dane-fichter has joined #openstack-nova | 12:27 | |
| *** ducttape_ has quit IRC | 12:28 | |
| *** edmondsw has joined #openstack-nova | 12:32 | |
| *** lpetrut has joined #openstack-nova | 12:34 | |
| *** kaisers has joined #openstack-nova | 12:34 | |
| *** jaosorior is now known as jaosorior_brb | 12:36 | |
| *** aysyd has joined #openstack-nova | 12:37 | |
| *** efried has quit IRC | 12:38 | |
| *** mdrabe has joined #openstack-nova | 12:39 | |
| *** blaisebool has quit IRC | 12:40 | |
| *** blaisebool has joined #openstack-nova | 12:41 | |
| *** jpena is now known as jpena|lunch | 12:43 | |
| *** jdillaman has quit IRC | 12:45 | |
| *** READ10 has joined #openstack-nova | 12:46 | |
| *** efried has joined #openstack-nova | 12:48 | |
| *** artom has quit IRC | 12:50 | |
| *** artom has joined #openstack-nova | 12:50 | |
| *** liverpooler has joined #openstack-nova | 12:51 | |
| *** edleafe- is now known as edleafe | 12:51 | |
| *** jwcroppe has quit IRC | 12:53 | |
| *** jwcroppe has joined #openstack-nova | 12:54 | |
| *** amoralej is now known as amoralej|lunch | 12:54 | |
| *** READ10 has quit IRC | 12:57 | |
| *** artom has quit IRC | 12:58 | |
| *** artom has joined #openstack-nova | 12:58 | |
| *** jwcroppe has quit IRC | 12:58 | |
| *** baoli has joined #openstack-nova | 13:00 | |
| *** lyan has joined #openstack-nova | 13:01 | |
| cdent | Is tomorrow the planned spec sprint day? | 13:01 |
| *** _ducttape_ has quit IRC | 13:02 | |
| *** voelzmo has quit IRC | 13:03 | |
| dane-fichter | cdent: yes | 13:03 |
| *** karimb has joined #openstack-nova | 13:03 | |
| cdent | thanks dane-fichter | 13:03 |
| dane-fichter | no problemo | 13:03 |
| *** zz_dimtruck is now known as dimtruck | 13:06 | |
| *** jwcroppe has joined #openstack-nova | 13:07 | |
| *** cristicalin has joined #openstack-nova | 13:08 | |
| *** rfolco has joined #openstack-nova | 13:09 | |
| jaypipes | dane-fichter: you see my review on the trusted flavors spec? | 13:11 |
| dane-fichter | jaypipes: yes. | 13:11 |
| jaypipes | dane-fichter: k. any questions for me? | 13:11 |
| dane-fichter | jaypipes: working on another draft currently | 13:11 |
| jaypipes | dane-fichter: gotcha | 13:11 |
| *** cleong has joined #openstack-nova | 13:11 | |
| dane-fichter | jaypipes: we considered doing this in the way you suggested a couple cycles ago | 13:12 |
| dane-fichter | jaypipes: but I think another core shot it down. | 13:12 |
| jaypipes | dane-fichter: oh? who blocked that idea? | 13:12 |
| *** jdillaman has joined #openstack-nova | 13:12 | |
| dane-fichter | jaypipes: I don't recall, I'll try to find a comment or something on it | 13:12 |
| *** READ10 has joined #openstack-nova | 13:12 | |
| jaypipes | dane-fichter: I wasn't a specs core until a few weeks ago, so def wasn't me ;) | 13:13 |
| dane-fichter | jaypipes: lol | 13:13 |
| jaypipes | dane-fichter: now whenever I do a specs review I shout "By the power of Grayskull" in my home office. | 13:13 |
| dane-fichter | jaypipes: w great spec power comes great spec responsibility | 13:14 |
| jaypipes | dane-fichter: indeed. | 13:14 |
| *** esberglu has joined #openstack-nova | 13:15 | |
| *** dimtruck is now known as zz_dimtruck | 13:15 | |
| *** crushil has quit IRC | 13:16 | |
| *** kaisers has quit IRC | 13:18 | |
| mordred | jaypipes: I imagine the pugs REALLY enjoy the shouting | 13:19 |
| jaypipes | mordred: my Pug secretary is deaf and mostly blind, so no, it's cool. | 13:19 |
| *** lpetrut has quit IRC | 13:20 | |
| jaypipes | mordred: the black one is my secretary: https://pbs.twimg.com/media/C2ylYN-WgAES_p8.jpg:large | 13:20 |
| jaypipes | mordred: the white one, as you can probably tell, is retarded. | 13:21 |
| cdent | I think your secretary may be ready for a relaxed retirement | 13:21 |
| jaypipes | mordred: sorry, I meant "learning challenged". | 13:21 |
| mordred | jaypipes: :) | 13:21 |
| mordred | jaypipes: they both look _very_ excited | 13:22 |
| jaypipes | mordred: oh, that's "active mode". trust me. | 13:22 |
| mordred | it feels active. like they're about to spring forth and maybe change their head position slightly | 13:23 |
| mordred | stillness, after all, does not equal stasis. in every instant of stillness exists the potential for movement, so proper stillness is extremely active | 13:25 |
| *** jdillaman has quit IRC | 13:26 | |
| *** baoli has quit IRC | 13:29 | |
| *** baoli has joined #openstack-nova | 13:30 | |
| *** eharney has joined #openstack-nova | 13:31 | |
| *** catintheroof has joined #openstack-nova | 13:31 | |
| *** crushil has joined #openstack-nova | 13:31 | |
| *** beekneemech is now known as bnemec | 13:31 | |
| *** belmorei_ has joined #openstack-nova | 13:32 | |
| *** jaosorior_brb is now known as jaosorior | 13:33 | |
| *** belmoreira has quit IRC | 13:33 | |
| *** voelzmo has joined #openstack-nova | 13:33 | |
| jaypipes | how very metaphysical of you, mordred | 13:36 |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: Make flavor-rxtx policy more granular https://review.openstack.org/444036 | 13:38 |
| *** ducttape_ has joined #openstack-nova | 13:38 | |
| *** gcb has joined #openstack-nova | 13:41 | |
| openstackgerrit | Scott Moser proposed openstack/nova master: Limit exposure of network device types to the guest. https://review.openstack.org/400883 | 13:42 |
| *** suresh12 has joined #openstack-nova | 13:42 | |
| sdague | alex_xu: you able to revise https://review.openstack.org/#/c/450834 ? | 13:43 |
| johnthetubaguy | sdague: do you remember when we said nova-cert would die? | 13:44 |
| johnthetubaguy | sdague: did we say wait until we arise the API min_version? or kill it sooner? | 13:44 |
| sdague | I thought it was going to die sooner | 13:44 |
| sdague | when did it deprecate? | 13:45 |
| johnthetubaguy | sdague: https://github.com/openstack/nova/commit/789edad0e811d866551bec18dc7729541105f59d | 13:49 |
| *** ratailor has joined #openstack-nova | 13:49 | |
| johnthetubaguy | sdague: it might be time already, macsz was putting a spec together to delete it, not strictly required, but there is API impact | 13:49 |
| *** jpena|lunch is now known as jpena | 13:50 | |
| *** ducttape_ has quit IRC | 13:51 | |
| macsz | sdague: as a reference https://review.openstack.org/#/c/448882/ | 13:51 |
| sdague | yeh, honestly, it's probably fair to delete, it's been deprecated for newton and ocata | 13:53 |
| sdague | and it's arguably a security risk given the entropy problem | 13:53 |
| *** hongbin has joined #openstack-nova | 13:53 | |
| *** cristicalin has quit IRC | 13:53 | |
| johnthetubaguy | sdague: yeah, I am certainly leaning that way | 13:54 |
| johnthetubaguy | macsz: I think you just need to cover more details on what the API does, now the implementation is deleted | 13:55 |
| edleafe | Scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | 13:55 |
| *** jdillaman has joined #openstack-nova | 13:57 | |
| *** chyka has joined #openstack-nova | 13:57 | |
| *** sree has joined #openstack-nova | 13:58 | |
| macsz | thanks for insights, johnthetubaguy | 13:58 |
| *** belmorei_ has quit IRC | 13:58 | |
| *** voelzmo has quit IRC | 14:00 | |
| *** fragatina has joined #openstack-nova | 14:00 | |
| *** sree_ has joined #openstack-nova | 14:00 | |
| *** sree_ is now known as Guest64432 | 14:01 | |
| *** lpetrut has joined #openstack-nova | 14:01 | |
| *** fragatina has quit IRC | 14:02 | |
| *** vks1 has joined #openstack-nova | 14:02 | |
| *** nmathew has quit IRC | 14:02 | |
| *** lpetrut has quit IRC | 14:04 | |
| *** sree has quit IRC | 14:04 | |
| *** chyka has quit IRC | 14:05 | |
| *** amotoki has joined #openstack-nova | 14:05 | |
| *** artom has quit IRC | 14:06 | |
| *** Guest64432 has quit IRC | 14:06 | |
| *** artom has joined #openstack-nova | 14:06 | |
| *** zz_dimtruck is now known as dimtruck | 14:06 | |
| *** lucasxu has joined #openstack-nova | 14:06 | |
| *** tuan_luong has joined #openstack-nova | 14:07 | |
| *** ratailor has quit IRC | 14:08 | |
| *** artom has quit IRC | 14:08 | |
| *** artom has joined #openstack-nova | 14:08 | |
| *** tuanla_ has joined #openstack-nova | 14:08 | |
| *** voelzmo has joined #openstack-nova | 14:08 | |
| *** voelzmo has quit IRC | 14:08 | |
| *** sree has joined #openstack-nova | 14:10 | |
| *** artom has quit IRC | 14:10 | |
| *** artom has joined #openstack-nova | 14:10 | |
| *** peter-hamilton has joined #openstack-nova | 14:10 | |
| *** mdrabe has quit IRC | 14:11 | |
| *** huyang_ has quit IRC | 14:12 | |
| *** voelzmo has joined #openstack-nova | 14:14 | |
| *** artom has quit IRC | 14:14 | |
| *** kaisers has joined #openstack-nova | 14:14 | |
| *** sree has quit IRC | 14:14 | |
| *** artom has joined #openstack-nova | 14:14 | |
| *** mdrabe has joined #openstack-nova | 14:17 | |
| *** udesale has quit IRC | 14:17 | |
| *** ducttape_ has joined #openstack-nova | 14:18 | |
| *** burt has joined #openstack-nova | 14:18 | |
| *** dimtruck is now known as zz_dimtruck | 14:19 | |
| *** amoralej|lunch is now known as amoralej | 14:20 | |
| *** vks1 has quit IRC | 14:20 | |
| *** Drankis has joined #openstack-nova | 14:21 | |
| *** smatzek has joined #openstack-nova | 14:25 | |
| *** amotoki has quit IRC | 14:25 | |
| *** suresh12 has quit IRC | 14:28 | |
| *** lyan has quit IRC | 14:29 | |
| *** suresh12 has joined #openstack-nova | 14:29 | |
| *** lyan has joined #openstack-nova | 14:29 | |
| *** satyar has joined #openstack-nova | 14:29 | |
| *** ducttape_ has quit IRC | 14:30 | |
| *** pumarani_ has joined #openstack-nova | 14:30 | |
| *** zz_dimtruck is now known as dimtruck | 14:33 | |
| *** ducttape_ has joined #openstack-nova | 14:36 | |
| *** vks1 has joined #openstack-nova | 14:37 | |
| *** nicolasbock has quit IRC | 14:41 | |
| *** ZZelle_ has quit IRC | 14:46 | |
| *** nicolasbock has joined #openstack-nova | 14:48 | |
| *** baoli has quit IRC | 14:49 | |
| *** marst has quit IRC | 14:49 | |
| *** suresh12 has quit IRC | 14:55 | |
| *** lpetrut has joined #openstack-nova | 14:55 | |
| *** lyan has quit IRC | 14:56 | |
| *** marst has joined #openstack-nova | 14:56 | |
| *** lpetrut has quit IRC | 14:56 | |
| *** mriedem has joined #openstack-nova | 14:57 | |
| *** chyka has joined #openstack-nova | 14:57 | |
| *** pumarani_ has quit IRC | 14:57 | |
| *** lyan has joined #openstack-nova | 14:58 | |
| *** sneti_ has joined #openstack-nova | 14:58 | |
| *** amotoki has joined #openstack-nova | 14:59 | |
| *** _ducttape_ has joined #openstack-nova | 15:00 | |
| *** suresh12 has joined #openstack-nova | 15:01 | |
| *** voelzmo has quit IRC | 15:01 | |
| *** voelzmo has joined #openstack-nova | 15:02 | |
| *** voelzmo has quit IRC | 15:02 | |
| *** jwcroppe has quit IRC | 15:02 | |
| *** ducttape_ has quit IRC | 15:03 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova master: Reduced the complexity of the _init_instance method (3) https://review.openstack.org/420619 | 15:04 |
| *** corey__ has joined #openstack-nova | 15:05 | |
| *** cleong has quit IRC | 15:05 | |
| *** garyk1 has joined #openstack-nova | 15:07 | |
| *** Oku_OS is now known as Oku_OS-away | 15:08 | |
| *** jwcroppe has joined #openstack-nova | 15:09 | |
| *** crushil has quit IRC | 15:09 | |
| sneti_ | johnthetubaguy, can you please review https://review.openstack.org/#/q/topic:bp/additional-notification-fields-for-searchlight+status:open when you have time.. getting merge conflicts every time a versioned notification patch gets merged. | 15:09 |
| *** jwcroppe has quit IRC | 15:09 | |
| *** sree has joined #openstack-nova | 15:10 | |
| *** jwcroppe has joined #openstack-nova | 15:10 | |
| *** haplo37 has quit IRC | 15:12 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: encryptors: Switch to os-brick encryptor classes https://review.openstack.org/391597 | 15:12 |
| *** suresh12 has quit IRC | 15:13 | |
| *** sree has quit IRC | 15:14 | |
| openstackgerrit | Scott Moser proposed openstack/nova master: Limit exposure of network device types to the guest. https://review.openstack.org/400883 | 15:14 |
| *** jwcroppe has quit IRC | 15:15 | |
| *** suresh12 has joined #openstack-nova | 15:15 | |
| *** felipemonteiro has joined #openstack-nova | 15:16 | |
| *** pumarani_ has joined #openstack-nova | 15:18 | |
| *** jamesdenton has joined #openstack-nova | 15:20 | |
| *** dave-mccowan has joined #openstack-nova | 15:20 | |
| *** haplo37 has joined #openstack-nova | 15:21 | |
| *** baoli has joined #openstack-nova | 15:21 | |
| *** _ducttape_ has quit IRC | 15:21 | |
| *** ducttape_ has joined #openstack-nova | 15:22 | |
| *** baoli has quit IRC | 15:24 | |
| *** crushil has joined #openstack-nova | 15:24 | |
| *** adrian_otto has joined #openstack-nova | 15:26 | |
| openstackgerrit | Roman Podoliaka proposed openstack/nova-specs master: Ironic: add support for instance RAID configuration https://review.openstack.org/408151 | 15:26 |
| *** annegentle has joined #openstack-nova | 15:28 | |
| andreas_s | thorst, Hey Drew, is this already on your radar? https://bugs.launchpad.net/cloud-init/+bug/1663315 | 15:29 |
| openstack | Launchpad bug 1663315 in cloud-init " identify openstack kvm platform on ppc64" [Medium,Confirmed] | 15:29 |
| thorst | andreas_s: looking... | 15:29 |
| thorst | andreas_s: actually, it hasn't been (as I'm more PowerVM). Though PowerVM does have the same issue and we've been scratching our head how to solve. | 15:30 |
| thorst | but let me see if I can get someone to take a peak at this. | 15:30 |
| mriedem | artom: i looked at your tempest test for the tagged vif / volume attach test https://review.openstack.org/#/c/391947/ | 15:31 |
| mriedem | artom: looks like you're not waiting for the interface to be used before checking the device tags on the guest | 15:31 |
| *** sridharg has quit IRC | 15:31 | |
| andreas_s | thorst, ok - cause we have the same issue on s390... | 15:31 |
| artom | mriedem, that's possible... | 15:31 |
| *** tesseract has quit IRC | 15:31 | |
| mriedem | artom: what's odd is that the test fails because it doesn't find any tagged devices on the guest, but the attach_volume method will wait for the volume to be in-use, so that should be on the guest | 15:31 |
| thorst | andreas_s: yeah...I know burgerk has been working that issue from a cloud-init perspective rather than a pure OpenStack perspective | 15:31 |
| mriedem | unless things just aren't working yet in that series | 15:31 |
| thorst | may want to sync up with him | 15:31 |
| *** baoli has joined #openstack-nova | 15:31 | |
| artom | mriedem, in local test I think it has something to do with metadata cache | 15:32 |
| artom | Which may or may not mask the ACTIVE interface issue | 15:32 |
| *** suresh12 has quit IRC | 15:32 | |
| artom | mriedem, because it's not deterministic - sometimes I see 1 tags, sometimes 0, but never both | 15:32 |
| thorst | andreas_s: I'll see if I can get him on IRC. | 15:32 |
| artom | mriedem, thanks for taking a look, at any case :) I'm kind on other things now, but I'll circle back in two or 3 days | 15:33 |
| *** joanna__ has joined #openstack-nova | 15:33 | |
| mriedem | artom: hmm, isn't this using config drive though which shouldn't be racy or care about a cache? | 15:33 |
| *** nkorabli has quit IRC | 15:33 | |
| *** thorst is now known as thorst_afk | 15:33 | |
| artom | mriedem, https://github.com/openstack/nova/blob/master/nova/api/metadata/handler.py#L78 | 15:33 |
| mriedem | artom: how offended will you be if i -2 the bottom change in the series until the tempest test is passing? | 15:34 |
| *** suresh12 has joined #openstack-nova | 15:34 | |
| artom | mriedem, I shall write angry letters | 15:34 |
| markus_z | felipemonteiro: are you around? | 15:34 |
| mriedem | it's a good thing i can't read | 15:34 |
| artom | I probably should have done that myself, in all seriousness | 15:34 |
| artom | I shall have a towne cryer at your doorstep | 15:35 |
| mriedem | ye olde towne cryer? | 15:35 |
| artom | aye, ye oldeste | 15:35 |
| mriedem | ok so the config drive is also dependent on this md cache? | 15:37 |
| *** crushil has quit IRC | 15:37 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Destroy the ReqSpec object when deleting the instance https://review.openstack.org/391060 | 15:38 |
| *** suresh12 has quit IRC | 15:38 | |
| artom | mriedem, I'd have to look at the code | 15:38 |
| artom | IIRC it grabs the https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L109 object directly | 15:39 |
| mriedem | lyarwood: red hat probably cares about these fixes on stable https://review.openstack.org/#/q/a41d265a19b7bcb1af8fc179bf864e00023c6cc6,n,z | 15:39 |
| artom | So no cache involved | 15:39 |
| mriedem | artom: i can look too | 15:39 |
| mriedem | i'm just high on cold medicine | 15:39 |
| *** amotoki has quit IRC | 15:39 | |
| *** READ10 has quit IRC | 15:39 | |
| bauzas | mriedem: dansmith: blushing about https://review.openstack.org/391060 | 15:39 |
| bauzas | in case you wanna bite it ^ | 15:40 |
| mriedem | did you fix your pep8 issue? | 15:40 |
| artom | mriedem, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3245 | 15:41 |
| artom | That seems to say I'm right | 15:41 |
| artom | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L62 | 15:41 |
| artom | It's importing base, not handler | 15:41 |
| openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in servers.py https://review.openstack.org/451966 | 15:41 |
| bauzas | mriedem: yup, hence me blushing | 15:41 |
| bauzas | I should write 100 times "I shall not provide a i18n message for a debug log" | 15:42 |
| mriedem | right which calls instance_md.metadata_for_config_drive() | 15:42 |
| *** Jack_Iv has quit IRC | 15:42 | |
| *** pumarani_ has quit IRC | 15:43 | |
| *** pumarani_ has joined #openstack-nova | 15:43 | |
| bauzas | the right-side of Gerrit makes me chilling when I see 9 concurrent patches conflicting with mine :) | 15:43 |
| mriedem | god i always have a hard time chasing down what the md code does | 15:43 |
| artom | Md is due for some refactoring | 15:44 |
| artom | Proper versionning, to begin with | 15:44 |
| artom | And if we can improve on the reason why folks don't like to deploy it, that'd be cool as well | 15:45 |
| artom | IPv6, not so easy to spoof your way into another instance's md... | 15:45 |
| mriedem | do we dump the guest console when your test fails? that would be interesting to see since i think it dumps the config drive | 15:45 |
| *** jwcroppe has joined #openstack-nova | 15:46 | |
| *** mdnadeem has quit IRC | 15:47 | |
| *** mvk has quit IRC | 15:47 | |
| *** jwcroppe has quit IRC | 15:47 | |
| *** mlavalle has joined #openstack-nova | 15:49 | |
| mriedem | oh you're not calling verify_metadata_on_config_drive from the tempest test | 15:49 |
| artom | mriedem, not for attach | 15:51 |
| *** nkrinner is now known as nkrinner_afk | 15:51 | |
| artom | There was agreement that we're not updating the config drive with the new tags | 15:51 |
| *** vks1 has quit IRC | 15:51 | |
| mriedem | oh right, | 15:51 |
| mriedem | yeah because we don't update config drive | 15:51 |
| *** ijw has joined #openstack-nova | 15:51 | |
| artom | Continuing with the improved metadata service thought, do we have a virt-agnostic way of shoving something into an instance? | 15:52 |
| artom | Really, the only way to make sure it really is the instance it's claiming to be that is asking for metadata is with some sort of shared secret | 15:53 |
| *** pcaruana has quit IRC | 15:53 | |
| artom | But how do we let the guest know of that secret? | 15:53 |
| *** jwcroppe has joined #openstack-nova | 15:54 | |
| artom | Anyways, maybe I'll propose that for next cycle | 15:54 |
| mriedem | i thought passing secrets was part of the vendordata v2 stuff | 15:54 |
| artom | But that still goes through the metadata API, right? | 15:54 |
| mriedem | i thought that's what rob crittenden's vendordata service did | 15:55 |
| mriedem | the initial request is made when creating the config drive, so not through the md api | 15:55 |
| artom | Hrm... But the config drive is libvirt-only, no? | 15:55 |
| mriedem | which is why there was also an ask at BCN for a way to make the server create fail if the vendordata stuff failed during config drive creation | 15:56 |
| mriedem | no | 15:56 |
| artom | As in, we can't rely on it to supply the guest with a secret that it can then use to query the metadata API | 15:56 |
| *** andreas_s has quit IRC | 15:56 | |
| artom | For real? So xenapi and hyperv support it? | 15:56 |
| mriedem | yes | 15:56 |
| mriedem | all virt drivers support config drive | 15:56 |
| artom | Yey :) | 15:57 |
| mriedem | https://docs.openstack.org/developer/nova/support-matrix.html#guest_setup_configdrive | 15:57 |
| artom | Hrmm, maybe I really will propose metadata API improvement next cycle | 15:57 |
| *** suresh12 has joined #openstack-nova | 15:57 | |
| artom | Or this cycle? What's the likelyhood of a spec making its way in? | 15:58 |
| artom | This late in the spec-review process | 15:58 |
| *** kaisers has quit IRC | 15:58 | |
| mriedem | with ~100 open specs already? chances aren't great, unless it's a big win and a simple spec probably. | 15:58 |
| mriedem | have you read through https://docs.openstack.org/developer/nova/vendordata.html btw? | 15:58 |
| mriedem | i thought removing bdm device from the API would be easy, turns out i was way wrong on that | 15:59 |
| *** efried has quit IRC | 15:59 | |
| artom | Wait, remove bdm device? | 16:00 |
| mriedem | specifying the device on create and attach | 16:00 |
| bauzas | jaypipes: humpf, reading thru your comments on the claims spec, do you accept now given our IRC meeting that we could POST allocations not at the same time with GET /rps, ie. after filters running ? | 16:00 |
| mriedem | https://review.openstack.org/#/c/452546/ | 16:00 |
| jaypipes | bauzas: yes | 16:00 |
| mriedem | artom: turns out there is an ec2 use case that we've been supporting for years, | 16:00 |
| mriedem | that no one really knew existed | 16:00 |
| bauzas | jaypipes: I know it's not what you want, but I think it's a trade-off so that sooner or later, we could merge both calls | 16:00 |
| mriedem | and now i can't break it | 16:00 |
| bauzas | jaypipes: okay, thanks for the clarification | 16:01 |
| jaypipes | bauzas: yes. | 16:01 |
| artom | mriedem, and actually I think it would break device tagging as well | 16:01 |
| *** Guest52040 has joined #openstack-nova | 16:01 | |
| mriedem | artom: why? | 16:01 |
| artom | mriedem, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7696 | 16:01 |
| artom | We use device name to match the XML to the bdm | 16:01 |
| oomichi | alex_xu: can you take a look at https://review.openstack.org/#/c/452284 ? | 16:01 |
| bauzas | jaypipes: and sorry, I thought you were in favor of a "ticket" (let's call it UUID), at least that's what I remember from some very old midcycle | 16:02 |
| artom | (I'm right in saying that it's the device name the user passed in, right?) | 16:02 |
| mriedem | artom: the libvirt driver completely ignores any user-supplied device name, and calculates it's own | 16:02 |
| jaypipes | bauzas: no, I think the APIs we have will work fine as-is for the moment. | 16:02 |
| bauzas | jaypipes: good with me | 16:03 |
| mriedem | artom: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7833 | 16:03 |
| artom | mriedem, fair enough, I need to refresh myself on how the above link works then :/ | 16:03 |
| mriedem | ^ been there since liberty | 16:03 |
| *** gcb has quit IRC | 16:03 | |
| mriedem | artom: i think this code is what sets the device names on the bdm objects https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7840 | 16:03 |
| artom | Ah, so there's still a matching name between the bdm and XML | 16:04 |
| artom | But it's libvirt that sets it, not the user | 16:04 |
| mriedem | correct | 16:04 |
| *** iceyao has joined #openstack-nova | 16:04 | |
| mriedem | it's all very confusing where libvirt sets it, because the libvirt driver doesn't actually set it | 16:04 |
| mriedem | block_device.default_device_names does | 16:04 |
| mriedem | like most of the bdm code, it's a lot of smoke and mirrors | 16:04 |
| *** yamahata has joined #openstack-nova | 16:04 | |
| artom | Any sentence that matches /.*block.*device.*confusing.*/ is a tautology | 16:05 |
| *** adrian_otto has quit IRC | 16:05 | |
| mriedem | nvm i guess it is specific to the libvirt driver https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L466 | 16:05 |
| mriedem | it has those driver bdm wrapper objects | 16:05 |
| mriedem | so it can mutate the underlying bdm object, and then update it in the db | 16:06 |
| mriedem | using driver_bdm.save() | 16:06 |
| mriedem | and get_disk_info(virt_type, instance, image_meta, block_device_info) is not read-only :) | 16:06 |
| artom | Well, get_guest_xml() isn't read-only either IIRC, so it's at least internally consistent | 16:07 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L488 | 16:07 |
| mriedem | yeah anyway, point is, the libvirt driver sets the device name for the bdm, the user doesn't | 16:07 |
| *** suresh12 has quit IRC | 16:08 | |
| mriedem | sdague: johnthetubaguy: dansmith: did you read that thread in the ML on removing user-supplied bdm devices from requests in the API? i had no idea people were using our crappy data model for overriding image bdms | 16:08 |
| *** iceyao has quit IRC | 16:08 | |
| markus_z | felipemonteiro: Would be cool if you could take a look at: https://bugs.launchpad.net/nova/+bug/1679223 | 16:09 |
| openstack | Launchpad bug 1679223 in OpenStack Compute (nova) "tempest.api.compute.servers.test_server_tags.ServerTagsTestJSON fail on centos7 nodes" [Undecided,New] | 16:09 |
| dansmith | mriedem: I saw it, didn't read it | 16:10 |
| *** psachin has quit IRC | 16:10 | |
| dansmith | mriedem: but yeah, I knew | 16:11 |
| sdague | mriedem: it didn't fully sink in, I'll have to revisit | 16:11 |
| *** nic has joined #openstack-nova | 16:11 | |
| *** cdent has quit IRC | 16:11 | |
| *** markus_z has quit IRC | 16:14 | |
| bauzas | mriedem: jaypipes: I have a thought, and I'd love your feedback about claims | 16:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | 16:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | 16:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (3) https://review.openstack.org/452820 | 16:14 |
| bauzas | mriedem: jaypipes: I have a long standing BP targeting to pass the Spec object down to the compute, mostly for rescheduling needs | 16:14 |
| jaypipes | bauzas: I'll trade ya for a review of https://review.openstack.org/#/c/448282/? :) | 16:14 |
| bauzas | mriedem: jaypipes: if we would pass the allocations as part of the Spec object down to the compute, it would prevent us to have a very specific RPC modification for something abstract enough | 16:15 |
| jaypipes | bauzas: yup, makes sense to me. | 16:16 |
| bauzas | mriedem: jaypipes: ie. the conductor gets the Spec object, pass it to the scheduler, and gives back a list of allocations (because the scheduler would claim) | 16:16 |
| mriedem | i'm out of the loop on the claims stuff. | 16:16 |
| bauzas | then, it would pass it down to the compute by setting those claims | 16:16 |
| mriedem | what is the compute going to do with them? | 16:16 |
| bauzas | jaypipes: it would allow us to change the RPC interface to just accept a spec_obj attribute and read the allocations UUIDs | 16:16 |
| mriedem | isn't the whole point that the compute no longer needs to care about setting allocations in the RT? | 16:16 |
| bauzas | mriedem: in case something goes wrong | 16:16 |
| mriedem | what does that mean? | 16:17 |
| jaypipes | mriedem: if the compute sees the allocations in the request spec, it wouldn't need to do the claims.Claim() build. | 16:17 |
| bauzas | mriedem: the compute would DELETE those allocations | 16:17 |
| bauzas | and it would trigger the reschedule by passing back the Spec | 16:17 |
| mriedem | i thought the scheduler was going to delete the allocations if something failed on a given compute host? | 16:17 |
| bauzas | jaypipes: yeah, the Spec object would signal if we support new-style of claiming | 16:18 |
| bauzas | mriedem: the scheduler would POST allocations | 16:18 |
| bauzas | mriedem: and get the UUIDs | 16:18 |
| jaypipes | bauzas: yeah, the presence of allocation objects in the RequestSpec would be that signal. | 16:18 |
| mriedem | jaypipes: so we bump the service version when computes start checking for claims in the scheduler (via the allocations in the request spec?) and then use that service version to determine when the scheduler can start doing this? once all computes are upgraded or what? | 16:18 |
| bauzas | mriedem: I was considering that approach | 16:19 |
| bauzas | mriedem: because we suppose a fully-upgraded cloud | 16:19 |
| jaypipes | mriedem: ya | 16:19 |
| mriedem | i'm not sure i like the compute deleting the allocations | 16:19 |
| mriedem | on a retry | 16:19 |
| *** namnh has joined #openstack-nova | 16:19 | |
| dansmith | definitely not | 16:19 |
| mriedem | wouldn't it be better to have the allocation create and cleanup in the same service? | 16:19 |
| bauzas | I dunno | 16:20 |
| mriedem | if we want to just pass a flag down to the compute, sure | 16:20 |
| bauzas | I'm not opiniated | 16:20 |
| bauzas | so | 16:20 |
| dansmith | compute shouldn't be doing that once we're claiming in the scheduler, methinks | 16:20 |
| mriedem | dansmith: agree | 16:20 |
| bauzas | if we say no to that idea | 16:20 |
| bauzas | then, we would just send a signal | 16:20 |
| mriedem | at a high level, we want the compute out of the business of doing this stuff | 16:20 |
| mriedem | yeah send a flag in the reqspec object i guess? | 16:20 |
| bauzas | but the compute would pass down the Spec by signaling against the signal :) | 16:20 |
| bauzas | I mean | 16:21 |
| mriedem | do we pass the reqspec today to the compute | 16:21 |
| mriedem | ? | 16:21 |
| bauzas | mriedem: not yet, but I was planning to | 16:21 |
| mriedem | oy | 16:21 |
| bauzas | it's a specless bp | 16:21 |
| mriedem | why not just pass a simple boolean on the rpc method? | 16:21 |
| dansmith | mriedem: it's leftovers from that whole process still :/ | 16:21 |
| mriedem | do_claims=False | 16:21 |
| dansmith | mriedem: +1.. I think encoding the state in the reqspec is kinda bad | 16:21 |
| bauzas | mriedem: I'd rather prefer to pass a Spec object because we could need it for rescheduling needs | 16:22 |
| dansmith | it's not guaranteed to be right | 16:22 |
| mriedem | bauzas: what rescheduling needs? | 16:22 |
| mriedem | conductor / scheduler handles that | 16:22 |
| bauzas | mriedem: the Retry nested object at least | 16:22 |
| mriedem | in filter_properties? | 16:22 |
| dansmith | bauzas: a call from compute to scheduler will be an upcall, you know | 16:22 |
| bauzas | mriedem: at the moment, we have ugly object-to-dict and dict-to-objects handlers | 16:22 |
| mriedem | let's step back, are you talking about build_and_run_instance? | 16:23 |
| bauzas | dansmith: compute does upcall conductor when rescheduling | 16:23 |
| bauzas | and conductor calls scheduler | 16:23 |
| mriedem | because build_and_run_instance already gets the reqspec | 16:23 |
| *** suresh12 has joined #openstack-nova | 16:23 | |
| bauzas | so when talking compute > scheduler, I'm just summarizing rather compute > conductor > scheduler | 16:23 |
| mriedem | the reqspec is already passed to the compute, but not used at all | 16:24 |
| mriedem | it's a dead parameter in _do_build_and_run_instance in the compute manager | 16:24 |
| dansmith | bauzas: if we're claiming in the scheduler, do we ever reschedule once it's made it to the compute? | 16:24 |
| bauzas | it's passed as a dict | 16:24 |
| bauzas | dansmith: we could | 16:24 |
| bauzas | dansmith: we still need some way to assume something went bad | 16:24 |
| mriedem | yeah we can fail for non-resource related reasons | 16:25 |
| bauzas | libvirt could fail for some foolish BDM things | 16:25 |
| bauzas | or some perms issue | 16:25 |
| *** lucasxu has quit IRC | 16:25 | |
| mriedem | vif plug can fail, etc | 16:25 |
| bauzas | zactly | 16:25 |
| dansmith | bauzas: so, there's literally no mechanism for an upcall from that layer | 16:25 |
| mriedem | compute does an rpc cast to build_instances in conductor for the reschedule right? | 16:26 |
| bauzas | dansmith: remind me at the moment, the super-conductor calls what ? local conductor or compute ? | 16:26 |
| dansmith | mriedem: yeah, but it's cell conductor | 16:26 |
| bauzas | dansmith: I think we agreed long time ago that a reschedule would not be multi-cell | 16:26 |
| bauzas | at least for initial versions | 16:26 |
| dansmith | bauzas: sure, but cell conductor can't talk to scheduler | 16:26 |
| bauzas | oh snap indeed | 16:26 |
| dansmith | because they're on different MQs | 16:27 |
| bauzas | yeah | 16:27 |
| bauzas | f*** | 16:27 |
| bauzas | I forgot that | 16:27 |
| bauzas | so, we're stuck | 16:27 |
| bauzas | because we *need* to schedule again if we failed | 16:27 |
| bauzas | dansmith: have you tested reschedules after all your cells-aware series ? | 16:27 |
| *** suresh12 has quit IRC | 16:28 | |
| dansmith | bauzas: not sure how we'd do that reliably from tempest | 16:28 |
| bauzas | fair point | 16:28 |
| bauzas | but anyway, even if not covered, the issue still remains | 16:28 |
| dansmith | I guess I thought part of the point of the claiming in the scheduler was to get rid of the need to retry | 16:28 |
| *** dtp has joined #openstack-nova | 16:29 | |
| bauzas | dansmith: it would reduce races, and gives us better decisions | 16:29 |
| mriedem | i had assumed we could still retry for other failures | 16:29 |
| mriedem | specific to the ocmpute | 16:29 |
| dansmith | if we fail to setup BDMs or ports, I would kinda expect that to affect all computes in a similar way, except maybe for misconfiguration | 16:29 |
| mriedem | *compute | 16:29 |
| bauzas | dansmith: but like mriedem said, compute-related failures can still exist | 16:29 |
| bauzas | dansmith: I know | 16:29 |
| dansmith | sure, but what kinds of things would not affect all computes? | 16:29 |
| dansmith | talking to glance or neutron or cinder would likely affect them all | 16:29 |
| bauzas | dansmith: but atm, we allow misconfigurations | 16:29 |
| dansmith | we allow misconfigurations? :) | 16:30 |
| bauzas | it just triggers reschedules | 16:30 |
| dansmith | you mean we retry in those cases, yes | 16:30 |
| mriedem | "tolerate" | 16:30 |
| bauzas | we /tolerate/ if you prefer | 16:30 |
| bauzas | but I'm pretty sure it would be drama if we stop providing reschedules for compute failures | 16:30 |
| mriedem | if cinder/glance/neutron are goofed up, then yeah those are probably global failures | 16:30 |
| bauzas | mriedem: well, I wouldn't be that strong | 16:31 |
| mriedem | i'm trying to think of things that we fail on a compute and don't know about before hand | 16:31 |
| mriedem | i think file injection was one of them | 16:31 |
| bauzas | a vif plug event is the most known failure | 16:31 |
| dansmith | bauzas: for what actual reason? | 16:31 |
| bauzas | honestly ? I can google search vif_binding failed and find a ton of different stacktraces | 16:32 |
| mriedem | do we reschedule on all of those? | 16:32 |
| bauzas | yup | 16:32 |
| mriedem | we don't reschedule on boot from volume failure, for example | 16:32 |
| dansmith | I'm seriously asking.. what kind of those failures aren't global? | 16:32 |
| jaypipes | mriedem: no, we ERROR the instance, IIRC. | 16:32 |
| bauzas | *all* is maybe presumptuous | 16:32 |
| bauzas | we *reschedule* on exceptions that are raised by the driver | 16:32 |
| mriedem | i'm thinking of the vif plug timeout case | 16:33 |
| dansmith | I don't really understand why it's not okay for us to ERROR a build if we're far into the process and fail | 16:33 |
| mriedem | bauzas: not for all | 16:33 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: doc: Separate the releasenotes guide from the code-review section https://review.openstack.org/451870 | 16:33 |
| bauzas | mriedem: well, I'm mostly sure it's a catch-all exception handling | 16:33 |
| jaypipes | bauzas: only in the instance_claim() context manager. once the claim is completed (and the "allocations" written to the compute_nodes table), we don't reschedule. | 16:33 |
| dansmith | because if it is global, we bounce to three compute nodes, generate a bunch of glance download traffic, and then ultimately fail, having wasted a bunch of time and resources | 16:33 |
| dansmith | jaypipes: orly, well, that helps | 16:33 |
| mriedem | bauzas: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1971 | 16:33 |
| bauzas | sec, the code will tell us the truth | 16:33 |
| mriedem | raise exception.BuildAbortException | 16:34 |
| dansmith | because if we claim in the scheduler, then after that we're committed to ACTIVE or ERROR | 16:34 |
| jaypipes | right. | 16:34 |
| bauzas | mriedem: jaypipes: nope, nope, general exception https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2003-L2010 | 16:34 |
| mriedem | bauzas: but you go through the specific errors before that, | 16:34 |
| mriedem | like VirtualInterfaceCreateException | 16:34 |
| dansmith | bauzas: that's only for we-haveno-idea | 16:35 |
| mriedem | which is translated to an abort | 16:35 |
| mriedem | VirtualInterfaceCreateException is raised for vif plug timeout | 16:35 |
| mriedem | or error | 16:35 |
| *** derekh has quit IRC | 16:35 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5090-L5106 | 16:35 |
| bauzas | dansmith: correct me if I'm wrong, but for other cases, we raise exceptions and enter that section ? | 16:35 |
| mriedem | anyway, that's one class of error | 16:35 |
| mriedem | i know we don't reschedule on boot from volume failures | 16:35 |
| dansmith | bauzas: I dunno | 16:36 |
| mriedem | bauzas: we get into that general block for shit we aren't expecting | 16:36 |
| mriedem | like i bet ProcessExecutionError gets into the generic retry block | 16:36 |
| dansmith | which might be misconfiguration things, but more likely it's crazy shit failing that will affect the reschedule too I bet | 16:36 |
| jaypipes | well, bauzas was correct that I was wrong about the instance_claim() not wrapping the entire spawn() operation. | 16:36 |
| *** jwcroppe_ has joined #openstack-nova | 16:37 | |
| *** crushil has joined #openstack-nova | 16:37 | |
| mriedem | yeah i would think most of these are localized misconfiguration, or global | 16:37 |
| mriedem | like the one about not reserving enough resources on a given compute for ovs to run | 16:38 |
| mriedem | remember that one? | 16:38 |
| dansmith | jaypipes: it wraps all of driver.spawn() or did you mean the compute manager level? | 16:38 |
| mriedem | if you need to reserve space for a compute to run ovs, then i'm not sure why you wouldn't make the reservation on the inventory record for the compute resource provider | 16:38 |
| jaypipes | dansmith: yeah for some reason I didn't think instance_claim() wrapped all of spawn(). | 16:38 |
| mriedem | that's the point | 16:38 |
| jaypipes | dansmith: I was wrong. | 16:38 |
| bauzas | so, the flag is clear, we only reschedule if we raise RescheduledException | 16:39 |
| bauzas | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1779 | 16:39 |
| dansmith | jaypipes: I'm confused, what doesn't get wrapped? | 16:39 |
| dansmith | jaypipes: we've started the instance in the driver before we return | 16:39 |
| jaypipes | dansmith: right, I understand that now. I implied with my comment above that that was not the case, and I'm saying I was wrong. | 16:40 |
| bauzas | dansmith: mriedem: so you could be right, some exceptions couldn't be transformed into that specific exception and we could just error out the instance | 16:40 |
| *** jwcroppe has quit IRC | 16:40 | |
| * dansmith is so confused | 16:40 | |
| bauzas | but that leaves the whole world of unexpected exceptions that *are* rescheduled | 16:40 |
| bauzas | unexpected exceptions being the ones raised by the driver | 16:41 |
| mriedem | so if we wanted to reschedule within the cell, we'd need two schedulers right? one top level scheduler across all cells, and one for the cell itself, which is basically redoing cells v1 | 16:42 |
| alaski | It's been a while since I looked at the code, but I remember that generally we try to reschedule if there's a chance that the instance could start on another host. Typically this is for the case where there are not enough resources on the host for the instance, either due to a scheduler race or due to bad resource accounting on the compute | 16:42 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872 | 16:42 |
| dansmith | alaski: right | 16:42 |
| *** thorst_afk is now known as thorst | 16:42 | |
| mriedem | alaski: but we also just have the generic 'we have no idea' | 16:42 |
| dansmith | alaski: I was thinking that's really the case we most care about today | 16:42 |
| mriedem | this https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2003 | 16:43 |
| alaski | mriedem: I don't think you need two schedulers. I think the scheduler shouldn't live at the API level. Think of it more like cinder, outside of cells fully | 16:43 |
| alaski | dansmith: yep, agreed | 16:43 |
| dansmith | alaski: um, scheduler shouldn't live at the api level? what does that mean? | 16:44 |
| mriedem | if you have one scheduler, and you want to retry, then we'd have to upcall to that top level scheduler | 16:44 |
| *** Guest63262 has quit IRC | 16:44 | |
| dansmith | mriedem: I definitely don't want to have multiple schedulers to handle the reschedule case | 16:44 |
| alaski | dansmith: I mean start to think of the scheduler as outside of Nova. Just as cinder doesn't live at the API level I wouldn't lump the scheduler there either | 16:44 |
| mriedem | API level == global to me | 16:45 |
| alaski | otherwise you do have to have an upcall to reschedule, or have two levels | 16:45 |
| dansmith | alaski: well, there's the architecture diagram and then there's the plumbing of how to talk to it :) | 16:45 |
| mriedem | neutron, cinder, placement, keystone, etc | 16:45 |
| dansmith | scheduler isn't a REST service which means we're a little constrained from just talking to it from wherever | 16:45 |
| *** Guest63262 has joined #openstack-nova | 16:46 | |
| alaski | dansmith: yep. And this is where my knowledge has gaps, but I thought a scheduler API was being stood up, which would allow talking to it from anywhere | 16:46 |
| dansmith | although, I will re-point out the scheduler-is-just-a-library helps with this :) | 16:46 |
| dansmith | alaski: that's placement | 16:46 |
| dansmith | alaski: and it's only part of the act of scheduling a thing | 16:46 |
| alaski | gotcha | 16:46 |
| bauzas | dansmith: I'm basically +1 on the idea of merging filtering/weighting in the conductor | 16:47 |
| bauzas | so I think it's reasonable | 16:47 |
| bauzas | but here, I'm more concerned by having the claims being implemented *before* that | 16:47 |
| dansmith | it'd be super interesting to use scheduler as a library for reschedules | 16:47 |
| bauzas | we sorta do that already | 16:47 |
| dansmith | bauzas: well, then I think you have to nuke the reschedules if you're going to do it first | 16:47 |
| bauzas | we have a scheduler.utils module that computes use for that purpose | 16:47 |
| dansmith | bauzas: temporarily, if you want, to be reopened later | 16:48 |
| bauzas | I dunno, and my wife is yelling at me because of dinner time :(' | 16:48 |
| dansmith | hey I have a crazy idea | 16:48 |
| dansmith | how about we ask an operator? | 16:48 |
| mriedem | i was going to say, | 16:48 |
| bauzas | can someone could just press the "pause" button for real life things? | 16:48 |
| mriedem | we can agree we need to pass a flag down to the compute to tell it to not claim because we already did it at the top | 16:48 |
| mriedem | for the reschedule thing, we have a session proposed for claims in the scheduler already, | 16:49 |
| bauzas | that, I'm all good with | 16:49 |
| mriedem | i think we could hash out the reschedule thing at that session since operators are supposed to be there | 16:49 |
| bauzas | good lord | 16:49 |
| dansmith | mriedem: sounds good to me | 16:49 |
| bauzas | okay, let me just write some stuff and put that in the spec as a big PITA | 16:49 |
| mriedem | that's assuming (1) that session is picked and (2) anyone shows up | 16:49 |
| bauzas | yeah | 16:50 |
| dansmith | mriedem: well, if it's not picked we can do something else | 16:50 |
| *** sambetts is now known as sambetts|afk | 16:50 | |
| dansmith | mriedem: if it is and they don't show up, then, I dunno, I guess they approve of whatever outcome :P | 16:50 |
| bauzas | open a thread and leave people arguing forever \o/ | 16:50 |
| bauzas | either way, I really need to drop off for family business :( | 16:50 |
| mriedem | dansmith: and yell at us 18 months later :) | 16:50 |
| mriedem | that's all par for the course really | 16:51 |
| dansmith | mriedem: I'll be flippin burgers by then | 16:51 |
| mriedem | beet farming for me | 16:51 |
| bauzas | I got a new project | 16:51 |
| bauzas | Burgers-As-a-Service | 16:51 |
| dansmith | bauzas: you really like us better than your wife? | 16:51 |
| bauzas | I do *love* my wife | 16:51 |
| bauzas | even my kids | 16:51 |
| * dansmith emails bauzas' wife instructions for disconnecting the internet | 16:51 | |
| bauzas | but sometimes, work/life balance is hard :) | 16:52 |
| mriedem | dude, just go | 16:52 |
| *** annegentle has quit IRC | 16:53 | |
| *** kaisers has joined #openstack-nova | 16:53 | |
| *** aarefiev_afk is now known as aarefiev | 16:56 | |
| mriedem | ok, i think he's gone. now let's undo all of the claims stuff behind his back! | 16:56 |
| *** lucasagomes is now known as lucas-afk | 16:56 | |
| dansmith | heh | 16:56 |
| *** sivak has quit IRC | 16:58 | |
| *** sivak has joined #openstack-nova | 16:58 | |
| *** kfarr has joined #openstack-nova | 17:02 | |
| namnh | dansmith: Hi Mr.Smith, may I confirm with you a point? | 17:03 |
| dansmith | namnh: you can try :) | 17:06 |
| namnh | dansmith: thanks for your reply | 17:06 |
| namnh | dansmith: Currenlty, Nova supported rolling-upgrade feature, it means old services in Nova can interact with new services. For example nova-api(Mitaka) can interact with nova-conductor(Nova). Is that right? | 17:06 |
| dansmith | namnh: no. That statement is true for control services vs. computes, but that's all currently | 17:07 |
| dansmith | namnh: i.e. api and conductor must be the same level, but compute may be old | 17:07 |
| *** adrian_otto has joined #openstack-nova | 17:10 | |
| namnh | dansmith: during upgrade, I can use the "pinning version" option in nova.conf. I.e, during I upgrade M -> Newton, I can pin version in nova.conf at mitaka release | 17:10 |
| *** Apoorva has joined #openstack-nova | 17:11 | |
| namnh | dansmith: so in my understading, conductor can still interact with api at old release. am i right? | 17:11 |
| *** ltomasbo is now known as ltomasbo|away | 17:12 | |
| dansmith | namnh: no | 17:15 |
| *** gszasz has quit IRC | 17:15 | |
| dansmith | namnh: at no point can you have different versions of conductor and api | 17:15 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Remove deprecated network APIs https://review.openstack.org/447728 | 17:17 |
| namnh | dansmith: so it means that I have turn off all conductors and apis at the same time and then upgrade and start these services at the same time. | 17:19 |
| namnh | dansmith: so it means that I have to turn off all conductors and apis at the same time and then upgrade and start these services at the same time. | 17:19 |
| mriedem | sdague: i addressed the stuff you and alex_xu wanted to see in the os-services/os-hypervisors spec https://review.openstack.org/#/c/447149/, it's got a +2 from dansmith | 17:20 |
| mriedem | dtp: have you started on the change to add uuid to the services table? | 17:20 |
| dansmith | namnh: yes | 17:20 |
| *** esberglu_ has joined #openstack-nova | 17:23 | |
| *** cdent has joined #openstack-nova | 17:23 | |
| *** esberglu has quit IRC | 17:24 | |
| namnh | dansmith: thanks for your answer, I think I need to research more deeply Nova's document for this case | 17:25 |
| *** armax has joined #openstack-nova | 17:25 | |
| mriedem | namnh: https://docs.openstack.org/developer/nova/upgrade.html in case you haven't seen that yet | 17:25 |
| sdague | mriedem: looking | 17:27 |
| *** ducttape_ has quit IRC | 17:27 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova master: libvirt: Virtuozzo containers config drive support https://review.openstack.org/449818 | 17:28 |
| namnh | mriedem: thanks. Surely, I will research more deeply the link. | 17:29 |
| *** liverpooler has quit IRC | 17:29 | |
| *** jaosorior is now known as jaosorior_away | 17:29 | |
| mriedem | looks like we need to clarify between cells v1 and v2 in there | 17:29 |
| *** karimb has quit IRC | 17:30 | |
| mriedem | sdague: thanks. i'm going to update the searchlight spec after lunch. | 17:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Distinguish between cells v1 and v2 in upgrades doc https://review.openstack.org/452872 | 17:32 |
| *** yamahata has quit IRC | 17:32 | |
| *** namnh has quit IRC | 17:33 | |
| *** nicolasbock has quit IRC | 17:35 | |
| dtp | mriedem about to now, why? | 17:36 |
| mriedem | dtp: was just wondering | 17:36 |
| *** pumarani_ has quit IRC | 17:36 | |
| *** jpena is now known as jpena|away | 17:37 | |
| sdague | mriedem: great | 17:39 |
| *** jwcroppe_ has quit IRC | 17:41 | |
| *** kaisers has quit IRC | 17:42 | |
| *** tuanla_ has quit IRC | 17:46 | |
| *** tuan_luong has quit IRC | 17:46 | |
| *** lucasxu has joined #openstack-nova | 17:47 | |
| *** satyar has quit IRC | 17:47 | |
| *** suresh12 has joined #openstack-nova | 17:48 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | 17:48 |
| *** dane-fichter has quit IRC | 17:49 | |
| *** jamielennox is now known as jamielennox|away | 17:50 | |
| *** ijw has quit IRC | 17:51 | |
| *** nicolasbock has joined #openstack-nova | 17:51 | |
| *** armax has quit IRC | 17:53 | |
| *** suresh12 has quit IRC | 17:56 | |
| *** amoralej is now known as amoralej|off | 17:57 | |
| *** kaisers has joined #openstack-nova | 17:57 | |
| *** baoli has quit IRC | 17:57 | |
| *** Sukhdev has joined #openstack-nova | 17:57 | |
| *** xyang1 has joined #openstack-nova | 17:59 | |
| *** aarefiev is now known as aarefiev_afk | 18:00 | |
| *** ZZelle has joined #openstack-nova | 18:01 | |
| *** peter-hamilton has quit IRC | 18:01 | |
| *** jdillaman has quit IRC | 18:01 | |
| *** baoli has joined #openstack-nova | 18:01 | |
| *** suresh12 has joined #openstack-nova | 18:01 | |
| *** markmcclain has quit IRC | 18:05 | |
| *** markmcclain has joined #openstack-nova | 18:07 | |
| *** armax has joined #openstack-nova | 18:07 | |
| *** Guest52040 has quit IRC | 18:08 | |
| *** jwcroppe has joined #openstack-nova | 18:11 | |
| *** Swami has joined #openstack-nova | 18:12 | |
| *** harlowja has joined #openstack-nova | 18:12 | |
| *** jdillaman has joined #openstack-nova | 18:14 | |
| *** crushil has quit IRC | 18:16 | |
| *** tjones has joined #openstack-nova | 18:20 | |
| *** sihan has joined #openstack-nova | 18:20 | |
| tjones | mriedem: one of my guys want to work on https://review.openstack.org/#/c/402256 but we cannot restore it. does the owner have to restore? I thought we could take it over | 18:21 |
| *** joanna__ has quit IRC | 18:22 | |
| *** cdent has quit IRC | 18:22 | |
| *** ralonsoh has quit IRC | 18:23 | |
| ildikov | mriedem: would the Cinder Nova meeting work for an hour earlier (1600 UTC) on Thursdays? | 18:24 |
| *** annegentle has joined #openstack-nova | 18:24 | |
| mriedem | tjones: i've restored it | 18:25 |
| mriedem | ildikov: for me yes | 18:25 |
| ildikov | mriedem: cool, tnx | 18:25 |
| *** avolkov has quit IRC | 18:25 | |
| clarkb | tjones: any core or the owner can restore | 18:30 |
| *** tbachman has quit IRC | 18:30 | |
| *** liverpooler has joined #openstack-nova | 18:32 | |
| *** sihan has quit IRC | 18:34 | |
| *** tbachman has joined #openstack-nova | 18:35 | |
| *** suresh12 has quit IRC | 18:36 | |
| *** Jack_Iv has joined #openstack-nova | 18:37 | |
| *** sapcc-bot1 has joined #openstack-nova | 18:40 | |
| *** crushil has joined #openstack-nova | 18:40 | |
| *** suresh12 has joined #openstack-nova | 18:40 | |
| *** sapcc-bot has quit IRC | 18:40 | |
| *** artom has quit IRC | 18:40 | |
| *** felipemonteiro has quit IRC | 18:41 | |
| *** john51_ has joined #openstack-nova | 18:41 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 18:41 |
| *** artom has joined #openstack-nova | 18:41 | |
| *** john51 has quit IRC | 18:41 | |
| *** felipemonteiro has joined #openstack-nova | 18:42 | |
| *** Jack_Iv_ has joined #openstack-nova | 18:43 | |
| openstackgerrit | Simon Dodsley proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 18:44 |
| *** suresh12 has quit IRC | 18:45 | |
| openstackgerrit | Simon Dodsley proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 18:46 |
| *** dimtruck is now known as zz_dimtruck | 18:46 | |
| *** Jack_Iv has quit IRC | 18:47 | |
| *** suresh12 has joined #openstack-nova | 18:47 | |
| *** sneti_ has quit IRC | 18:49 | |
| *** efried has joined #openstack-nova | 18:52 | |
| *** zz_dimtruck is now known as dimtruck | 18:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: List instances using Searchlight (spec) https://review.openstack.org/441692 | 18:56 |
| mriedem | sdague: there you go ^ | 18:56 |
| openstackgerrit | Simon Dodsley proposed openstack/nova-specs master: Enhanced KVM Storage QoS https://review.openstack.org/340168 | 18:58 |
| *** armax has quit IRC | 19:00 | |
| *** burt has quit IRC | 19:01 | |
| *** sneti_ has joined #openstack-nova | 19:04 | |
| *** adrian_otto has quit IRC | 19:04 | |
| *** sree has joined #openstack-nova | 19:11 | |
| mordred | mriedem, sdague: SO - over the weekend I was working on replacing the create server snapshot image call in shade with pure-rest - and I discovered that the value that nova returns in the header is wrong on at least 1 public cloud - but nobody has likely noticed because novaclient doesn't directly use the url returned, instead it pops the id off the end and uses that | 19:14 |
| mordred | I'm fairly certain there is at least one bug somewhere | 19:14 |
| mordred | but I'm not 100% sure in what, or where to file it | 19:15 |
| sdague | mordred: can you be more specific about which cloud, and in what way it is wrong? | 19:15 |
| mordred | yes! | 19:15 |
| sdague | so we could at least narrow down where the disconnect is | 19:15 |
| *** sree has quit IRC | 19:15 | |
| mriedem | talking about https://developer.openstack.org/api-ref/compute/?expanded=create-image-createimage-action-detail#create-image-createimage-action right? | 19:17 |
| mordred | I was testing against vexxhost, which is running newton I believe ... | 19:17 |
| mordred | (and yes) | 19:17 |
| *** joanna__ has joined #openstack-nova | 19:17 | |
| mordred | one sec - getting the actual value from my logs so I can paste the right things | 19:17 |
| mriedem | might have been related to some glance v1 stuff that we intentionally broke in newton | 19:18 |
| mriedem | for glance v2 | 19:18 |
| mriedem | i seem to remember some issues there with returning locations to glance api servers | 19:18 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1112 | 19:19 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/image/glance.py#L58 | 19:20 |
| mordred | RESP: [202] Content-Type: text/html; charset=UTF-8 Content-Length: 0 Location: http://172.21.1.10:9292/images/f5d5b63b-e710-4d59-aa12-a9bd42f6652a Openstack-Api-Version: compute 2.1 X-Openstack-Nova-Api-Version: 2.1 Vary: OpenStack-API-Version, X-OpenStack-Nova-API-Version X-Compute-Request-Id: req-4b6fb5ed-3055-4d84-a16f-4057685ce737 Date: Sun, 02 Apr 2017 13:26:20 GMT | 19:20 |
| mordred | that's the response I got | 19:20 |
| mordred | but the Location _should_ have been https://image-ca-ymq-1.vexxhost.net/v2/images/f5d5b63b-e710-4d59-aa12-a9bd42f6652a | 19:20 |
| mriedem | yeah i was going to say, it's wrong b/c it's missing v1 or v2 right? | 19:21 |
| mordred | well - and also the host is wrong | 19:21 |
| mriedem | the host comes from the config in nova | 19:21 |
| mriedem | for glance api servers | 19:21 |
| mordred | 172.21.1.10:9292 is unreachable by me as a user | 19:21 |
| *** lpetrut has joined #openstack-nova | 19:21 | |
| sdague | so, the host is going to because they have private glance servers | 19:21 |
| mordred | so it seems it's returning the thing that is the internal url | 19:21 |
| mordred | yah | 19:21 |
| mriedem | yeah comes from config https://github.com/openstack/nova/blob/master/nova/image/glance.py#L107 | 19:21 |
| mriedem | we'd have to get the host from the service catalog right? | 19:22 |
| sdague | yeh, for historical reasons that's just a randomly picked one of their api_services | 19:22 |
| mriedem | for publicUrl | 19:22 |
| sdague | mriedem: yeh, it's more complicated than that, but yes | 19:22 |
| mordred | kk. so this is still just part of the whole "use the catalog for glance stuff" effort | 19:22 |
| sdague | because the glance stuff doesn't use the catalog anywhere | 19:22 |
| mordred | yah | 19:22 |
| sdague | mordred: yes | 19:22 |
| mordred | cool - ok - so no new issue to file | 19:22 |
| mriedem | is that an effort? | 19:22 |
| mriedem | no one is working on this | 19:22 |
| mordred | maybe effort is the wrong word "aspirational future state that people would love to be in but nobody is currently driving" | 19:23 |
| mriedem | mordred: you should report a bug regardless | 19:23 |
| mordred | kk | 19:23 |
| mordred | will do | 19:23 |
| mordred | also - I'm just stealing novaclient's workaround for now | 19:23 |
| mriedem | i'm surprised we actually returned a location header | 19:24 |
| mordred | which is to just pop the uuid off the end of the url and return _that_ | 19:24 |
| sdague | mriedem: that's been there for a long time | 19:24 |
| mriedem | sdague: there's lots of things that have been around for lots of years that surprise me :) | 19:24 |
| sdague | :) | 19:24 |
| sdague | returning location is actually a pretty good pattern, it's just that it depends on too much config being correct | 19:25 |
| *** sneti_ has quit IRC | 19:25 | |
| sdague | I'm trying to figure out if vexxhost's config is going to hurt something else in terms of migration | 19:26 |
| mriedem | sdague: so is the basic idea, long-term we want to drop CONF.glance.api_servers and just have nova lookup the image service url in the catalog? | 19:26 |
| sdague | mriedem: yes | 19:26 |
| mriedem | same for neutron and cinder | 19:26 |
| mriedem | since those are config driven | 19:26 |
| mordred | yah | 19:26 |
| mriedem | oh right and raj_singh had a patch to use ksa with glance in nova... | 19:26 |
| sdague | right, so we probably are going to have to have a slightly more complicated case for glance where we consider an internal and a public path | 19:27 |
| mriedem | https://review.openstack.org/#/c/412634/ | 19:27 |
| sdague | because glance is one of those services where your would tend to build a really high bw internal path to the api service | 19:27 |
| mordred | mriedem: I've also got this one: https://review.openstack.org/#/c/438512/ | 19:27 |
| mriedem | we make that configurable for placement | 19:27 |
| mriedem | which url to use i mean | 19:27 |
| mordred | mriedem: which needs a little more cleanip before I bother you fine people with it much more | 19:27 |
| *** lpetrut has quit IRC | 19:28 | |
| sdague | mriedem: well... except we reflect urls straight to the user | 19:28 |
| sdague | so we're going to need 2 config options | 19:28 |
| mriedem | sdague: right i know | 19:28 |
| mriedem | internal defaults to internalUrl or adminUrl or whatever, and public defaults to publicUrl | 19:28 |
| mriedem | i was thinking about this https://github.com/openstack/nova/blob/master/nova/conf/placement.py#L31 | 19:28 |
| sdague | mriedem: yeh | 19:29 |
| mordred | yah - I'd argue to not have that | 19:29 |
| mordred | internal and public are known interfaces. nova should reflect urls based on public to API consumers and should use internal to talk to other services - we shouldn't make operators tell nova to do that- if they don't want an internal url, they should just register the same url twice with keystone | 19:30 |
| sdague | mordred: well, we tried to get away with be prescriptive with placement | 19:30 |
| mordred | but I'm unreasonable | 19:30 |
| sdague | and people got mad | 19:30 |
| mordred | of course they did | 19:30 |
| sdague | mordred: so, lots of deployments only use public | 19:31 |
| sdague | or at least some do | 19:31 |
| sdague | and just route correctly | 19:31 |
| mordred | yah. that would be more smarter | 19:31 |
| *** sneti_ has joined #openstack-nova | 19:31 | |
| sdague | is there anyone else with a newton cloud? | 19:31 |
| *** liusheng has quit IRC | 19:32 | |
| mordred | dunno - I only know vexxhost is because I was chatting with mnaser about a config-drive issue over the weekend | 19:32 |
| *** marst_ has joined #openstack-nova | 19:32 | |
| mordred | but given the way novaclient works here, it's highly unlikely many real-world folks are broken by this issue, fwiw | 19:32 |
| *** liusheng has joined #openstack-nova | 19:32 | |
| *** tbachman has quit IRC | 19:33 | |
| mordred | I mean - honestly rather than fixing it - just returning a json dict in the body with the image_id in it would be a win - those urls aren't really used much in the rest of the overall api flow | 19:34 |
| mordred | and the first thing you're going to do with this as a user is make a call to glance to get the image dict by id | 19:34 |
| mordred | (since you have to poll that for status to know when it's done) | 19:34 |
| mriedem | mordred: yeah that's why i said i was surprised, | 19:35 |
| mriedem | because we just return ids for things like this in response bodies | 19:35 |
| mordred | so it likely _could_ be fixed with a microversion easier than actually fixing the internal/public glance url thing | 19:35 |
| mriedem | but, changing the response will be a microversion | 19:35 |
| mordred | mriedem: yah. I was very surprised myself | 19:35 |
| mordred | mriedem: as you might can tell from my comment: https://review.openstack.org/#/c/452566/2/shade/openstackcloud.py | 19:35 |
| *** marst has quit IRC | 19:35 | |
| mriedem | ha | 19:36 |
| mriedem | so dramatic | 19:36 |
| mordred | well - it was a sunday and I managed to break a server by making the api call against nova | 19:36 |
| mordred | because it _ALSO_ apparently turns the server off to do the snapshot | 19:37 |
| mordred | so I might have been in a bad mood at the time | 19:37 |
| mriedem | live snapshot is a thing if libvirt is new enough and you've configured nova-compute to attempt it | 19:37 |
| mriedem | we disabled live snapshot way back when b/c it resulted in 25% failure rate in the gate | 19:37 |
| *** harlowja has quit IRC | 19:37 | |
| mriedem | you as the api user have no idea if it's live or cold though | 19:37 |
| mriedem | since it's config drive on the compute | 19:38 |
| mriedem | *driven | 19:38 |
| mordred | \o/ | 19:38 |
| mriedem | were you surprised that it was a cold snapshot? i see we don't mention that in the api ref | 19:38 |
| mordred | well - I shouldn't have been - I know we don't use snapshots for any purpose in infra because it used to make the servers unresponsive for potentially hours - but I think I had just assumed that was some Xen/Rackspace thing | 19:39 |
| *** xyang1 has quit IRC | 19:39 | |
| mordred | but yes - I was totally unprepared for it to be a COMPLETELY unsafe thing to run | 19:39 |
| *** yamahata has joined #openstack-nova | 19:40 | |
| mordred | that left me with a VM in a down state for an unknowable period of time | 19:40 |
| *** xyang1 has joined #openstack-nova | 19:40 | |
| mordred | and with no way that I could find for me to say "oh, crap, dude, nevermind - I need the VM back please" | 19:40 |
| mriedem | build a confirm prompt into shade :) | 19:40 |
| mriedem | we could note this in the docs though, that by default it's a cold snapshot so you should expect the guest to be offline during the snapshot operation | 19:41 |
| mriedem | i'm not really sure if that's true for the other virt drivers, but it is for libvirt | 19:41 |
| mriedem | sdague: didn't you have a patch to undo disable_libvirt_livesnapshot? | 19:42 |
| mriedem | or change it to False | 19:42 |
| mriedem | maybe it was sfinucan | 19:42 |
| mordred | mriedem: yah - I think a docs patch with a warning would be a good idea | 19:42 |
| openstackgerrit | Sihan Wang proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.openstack.org/402256 | 19:42 |
| mriedem | mordred: we can also doc the image location header response as probably being bogus for most users, at least users of public clouds | 19:42 |
| *** tbachman has joined #openstack-nova | 19:42 | |
| mordred | ++ | 19:42 |
| sdague | I did change it to false, I thought we reverted it though | 19:43 |
| sdague | oh, I guess it's still off by default | 19:44 |
| sdague | we should probably change that | 19:44 |
| *** dimtruck is now known as zz_dimtruck | 19:45 | |
| mordred | mriedem: https://bugs.launchpad.net/nova/+bug/1679285 | 19:46 |
| openstack | Launchpad bug 1679285 in OpenStack Compute (nova) "Create Server Snapshot returns incorrect Image Location" [Undecided,New] | 19:46 |
| *** armax has joined #openstack-nova | 19:47 | |
| mriedem | thanks | 19:47 |
| mriedem | so how to fix this, i'm not sure if we just do the service catalog thing for this right now, or change the response in a microversion (which we can't backport) | 19:51 |
| mriedem | it's super latent so i'm not sure we need to backport a fix, | 19:51 |
| mriedem | we could just doc it as always sucking | 19:51 |
| *** karimb has joined #openstack-nova | 19:52 | |
| mriedem | sdague: ^ thoughts on which way you'd lean? | 19:53 |
| mriedem | i'm not as clear on the service catalog stuff but could probably figure it out by looking at similar things with placement | 19:54 |
| *** smatzek has quit IRC | 19:54 | |
| sdague | well, it makes it clear that once we get to newton, we probably break people by accident if they used that field | 19:54 |
| mriedem | because it doesn't have v2 in the url? | 19:54 |
| mordred | mriedem: for my money, I'd document it, and then add the microversion for a new response type ... I think the catalog thing is a _much_ longer fix, even though it's the right one long term | 19:55 |
| mriedem | it doesn't have v1 in it either | 19:55 |
| sdague | the Location: field really is supposed to have the url | 19:55 |
| mriedem | unless images is an alias for v1/images | 19:55 |
| mordred | yah - I think there are too many variables for Location to be correct consistently | 19:55 |
| mordred | because you might be an admin who _does_ want to use the internal url | 19:55 |
| mordred | and you might have requested internal urls from keystone as a user | 19:55 |
| sdague | Location is HTTP spec, if we are going to use it, it has to be a real url | 19:55 |
| mordred | yah. I'm saying ignore the location header and just return the image id in a json doc | 19:56 |
| mordred | that's consistent and can be consumed well | 19:56 |
| mriedem | right it's a question of change the response, or fix the location header and use the catalog | 19:56 |
| mordred | oh - I was suggesting neither ... | 19:56 |
| mriedem | i can do the former easily | 19:56 |
| mordred | just _Add_ a json return dict and document that the location header is likely broken | 19:56 |
| mriedem | mordred: you're saying leave the busted location header? | 19:56 |
| mriedem | oh | 19:56 |
| mriedem | well it's still a microversion to return a body now | 19:57 |
| mordred | yah | 19:57 |
| mordred | but microversions are there for a reason, right? | 19:57 |
| mriedem | yeah, i just don't know if it's better to do the quick fix with a microversion now, or invest in doing the catalog lookup, which is more obscure for me personally | 19:57 |
| mriedem | ksa is just a big black box and i always ask sean what to do :) | 19:58 |
| mriedem | or copy his code | 19:58 |
| mordred | well - I have a patch coming to maybe make it friendlier | 19:58 |
| sdague | mriedem: yeh, honestly, I would say a better response body is probably the right answer | 19:59 |
| sdague | and drop the Location header when we do it | 19:59 |
| mriedem | sdague: i can totally do that, today | 19:59 |
| mordred | ++ - I still think fixing glance interactoins to use catalog long term is the correct and healthy thing to do - but it's not going to be quick | 19:59 |
| sdague | the Location header is clever, and when it was an internal location for nova, maybe really sensible | 19:59 |
| sdague | mordred: yeh | 19:59 |
| mordred | agree | 19:59 |
| mordred | but the world it has changed since then | 19:59 |
| sdague | I think the only sucky part is that the fix isn't really backportable | 20:00 |
| sdague | this is basically an edge case of the v1 -> v2 bit that we missed | 20:00 |
| mordred | yah - but it's also luckily not TERRIBLE to workaround as an API consumer | 20:00 |
| mriedem | does /images alias to /v1/images though? | 20:00 |
| mordred | I mean id = "/".rsplit(location, 1) | 20:00 |
| sdague | mriedem: honestly, I don't know | 20:00 |
| mordred | isn't bad | 20:00 |
| mordred | mriedem: I do not believe so, no | 20:00 |
| sdague | mordred: yeh, sure. We should probably mention there are weirdnesses in the API call | 20:01 |
| mriedem | ok, i wasn't sure looking at https://developer.openstack.org/api-ref/image/versions/index.html?expanded=list-api-versions-detail,id1-detail | 20:01 |
| mriedem | and the api refs for glance | 20:01 |
| mriedem | or https://developer.openstack.org/api-ref/image/v1/index.html#images | 20:01 |
| mriedem | which has an explicit /v1/ in it | 20:01 |
| mordred | mriedem: no, it doens't | 20:02 |
| mriedem | maybe this has just been broken since glance became a thing birthed from nova? :P | 20:02 |
| mordred | GET https://image-ca-ymq-1.vexxhost.net/images/05a02839-5eb2-4335-8869-fabe88601f18 | 20:02 |
| mordred | gets you the image version discovery document | 20:02 |
| mordred | mriedem: yes - I believe it likely has been broken always | 20:02 |
| mordred | mriedem: because of how novaclient consumes the value | 20:02 |
| mriedem | mordred: to be clear, "no it doesn't" meaning /images doesn't alias /v1/images? | 20:03 |
| mriedem | because yeah i see https://image-ca-ymq-1.vexxhost.net/v1/ | 20:03 |
| mriedem | ok, well i'll draft up a spec | 20:04 |
| sdague | mordred: so... on other clouds is it returning a glance url or a nova one? | 20:04 |
| mordred | sdague: I can check - but it'll be a little bit - I need to create some vms first | 20:05 |
| *** jamielennox|away is now known as jamielennox | 20:05 | |
| sdague | mordred: yeh, no worries. Just curious, because it's been so long | 20:05 |
| sdague | because, I think that might be part of what happened | 20:05 |
| sdague | as we used to push through nova urls | 20:05 |
| mordred | image = cls.compute_images_client.create_image(server_id, name=name) | 20:06 |
| mordred | image_id = data_utils.parse_image_id(image.response['location']) | 20:06 |
| mordred | cls.images.append(image_id) | 20:06 |
| mordred | tempest ALSO employs the novaclient workaround | 20:06 |
| sdague | heh | 20:06 |
| sdague | yeh, ok, we've just been terrible forever | 20:06 |
| *** crushil has quit IRC | 20:06 | |
| mordred | yup | 20:06 |
| *** adrian_otto has joined #openstack-nova | 20:08 | |
| mriedem | ok so we're a go for removing location header and return image_id in a response body dict in a microversion, yes? | 20:08 |
| mriedem | if so, i'll start writing up a spec | 20:08 |
| raj_singh | mriedem: sdague We are working up a spec to use catalog lookup for Glance. This spec will have details on making consistent use of keystone_auth in Neutron and Cinder client as well. | 20:08 |
| mordred | mriedem: ++ I think that's a GREAT microversion | 20:09 |
| raj_singh | and we will have it up by today | 20:09 |
| mordred | raj_singh: hey - will you point me to it as well? | 20:09 |
| raj_singh | pumaranikar: is working on it | 20:09 |
| mordred | pumaranikar, raj_singh: I have some thoughts and a half-done patch for improving that area as well :) | 20:09 |
| raj_singh | mriedem: Sure I will ping you once ready | 20:09 |
| *** Jack_Iv_ has quit IRC | 20:10 | |
| mordred | sweet | 20:10 |
| sdague | mriedem: sounds great | 20:10 |
| *** crushil has joined #openstack-nova | 20:10 | |
| *** Jack_Iv has joined #openstack-nova | 20:10 | |
| *** pumarani_ has joined #openstack-nova | 20:13 | |
| *** pumarani_ has quit IRC | 20:13 | |
| *** Sukhdev_ has joined #openstack-nova | 20:13 | |
| *** pumarani_ has joined #openstack-nova | 20:13 | |
| *** pumarani_ has quit IRC | 20:14 | |
| *** pumarani_ has joined #openstack-nova | 20:14 | |
| *** Jack_Iv has quit IRC | 20:15 | |
| *** liverpooler has quit IRC | 20:16 | |
| *** rmart04 has joined #openstack-nova | 20:16 | |
| *** crushil has quit IRC | 20:18 | |
| *** sivak has quit IRC | 20:19 | |
| *** sivak has joined #openstack-nova | 20:19 | |
| *** sivak has quit IRC | 20:19 | |
| *** sivak has joined #openstack-nova | 20:20 | |
| *** jamesdenton has quit IRC | 20:20 | |
| *** lucasxu has quit IRC | 20:22 | |
| *** Drankis has quit IRC | 20:24 | |
| *** zz_dimtruck is now known as dimtruck | 20:25 | |
| *** baoli has quit IRC | 20:25 | |
| *** kaisers has quit IRC | 20:26 | |
| *** Sukhdev has quit IRC | 20:30 | |
| *** Sukhdev_ is now known as Sukhdev | 20:30 | |
| melwitt | mriedem: I thought you might want to look at this docs change, makes a new page for release notes how-to and links from the main page and the code review page https://review.openstack.org/#/c/451870 | 20:31 |
| *** baoli has joined #openstack-nova | 20:32 | |
| mriedem | sdague: mordred: funny, but we emit notifications for snapshot start/end, but don't actually include the snapshot image id in those | 20:33 |
| mriedem | kind of useless | 20:33 |
| mriedem | gibi: ^ | 20:33 |
| sdague | so, question, in log messages, sometimes we use instance= and sometimes we use instance_uuid= | 20:33 |
| mriedem | sdague: no different | 20:33 |
| mriedem | *difference | 20:33 |
| *** rmart04 has quit IRC | 20:33 | |
| sdague | is there a reason we couldn't abolish instance= and do the uuid dereference thre? | 20:33 |
| mriedem | oslo.log checks to see if it's 'instance' and pulls the uuid from it | 20:33 |
| *** armax has quit IRC | 20:34 | |
| sdague | mriedem: yes, I realize it, but it actually adds a reasonable amount of gorp in oslo.log | 20:34 |
| mriedem | it would be a bunch of churn | 20:34 |
| *** armax has joined #openstack-nova | 20:34 | |
| *** armax has quit IRC | 20:35 | |
| sdague | yeh, though the dual fields do make doing some additional stuff with exposing variables to systemd journal a big gorpier | 20:35 |
| *** abalutoiu_ has joined #openstack-nova | 20:36 | |
| mriedem | melwitt: can i have no opinion? | 20:36 |
| melwitt | mriedem: of course | 20:37 |
| *** abalutoiu has quit IRC | 20:39 | |
| *** sivak has quit IRC | 20:45 | |
| *** sneti_ has quit IRC | 20:45 | |
| *** sivak has joined #openstack-nova | 20:46 | |
| *** dimtruck is now known as zz_dimtruck | 20:48 | |
| *** zz_dimtruck is now known as dimtruck | 20:48 | |
| *** armax has joined #openstack-nova | 20:48 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP encryptors: Do not overwrite file volumes on attach https://review.openstack.org/452938 | 20:49 |
| lyarwood | melwitt: ^ hackaround for the encrypted nfs volume corruption bug if you get time today | 20:49 |
| *** sivak has quit IRC | 20:49 | |
| *** sivak has joined #openstack-nova | 20:50 | |
| melwitt | lyarwood: cool, thanks for the heads up | 20:50 |
| lyarwood | mriedem: thanks for the heads up re the stable bugfixes btw, I'll queue them up for the morning | 20:50 |
| mriedem | mordred: createBackup API has the same issue :) | 20:51 |
| *** david-lyle has quit IRC | 20:51 | |
| *** esberglu_ is now known as esberglu | 20:51 | |
| *** david-lyle has joined #openstack-nova | 20:51 | |
| *** mvk has joined #openstack-nova | 20:52 | |
| *** annegentle has quit IRC | 20:52 | |
| *** sneti_ has joined #openstack-nova | 20:52 | |
| *** harlowja has joined #openstack-nova | 20:53 | |
| dansmith | sdague: instance_uuid would suck measurably more, IMHO | 20:54 |
| *** hoangcx has joined #openstack-nova | 20:55 | |
| *** Guest63262 has quit IRC | 20:56 | |
| *** esberglu has quit IRC | 20:56 | |
| *** corey__ has quit IRC | 20:56 | |
| *** esberglu has joined #openstack-nova | 20:56 | |
| *** tbachman has quit IRC | 20:56 | |
| *** tbachman_ has joined #openstack-nova | 20:56 | |
| *** thorst has quit IRC | 20:59 | |
| *** thorst has joined #openstack-nova | 21:00 | |
| *** esberglu has quit IRC | 21:01 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in servers.py https://review.openstack.org/451966 | 21:02 |
| *** Guest63262 has joined #openstack-nova | 21:02 | |
| mriedem | wow, nova backup does not print out the actual image id for the created snapshot image | 21:04 |
| mriedem | so i guess that's just an exercise for the user | 21:04 |
| mriedem | melwitt: ^ have you ever seen anyone propose a change for that in novaclient? | 21:04 |
| *** thorst has quit IRC | 21:04 | |
| melwitt | mriedem: I haven't but to be honest I haven't been paying attention to novaclient changes in awhile | 21:05 |
| dansmith | mriedem: backup is broken for certain things, right? like bfv instances? | 21:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Remove Location header from createImage and createBackup response (spec) https://review.openstack.org/452951 | 21:07 |
| dansmith | tbh I kinda relegated it into an old usage scenario | 21:07 |
| *** sivak has quit IRC | 21:08 | |
| mriedem | flwang tried fixing bfv with backup years ago, but we blocked it | 21:08 |
| dansmith | yeah | 21:08 |
| *** sivak has joined #openstack-nova | 21:08 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: WIP: Replace live migration steps and delays with memory iteration logic https://review.openstack.org/443339 | 21:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Remove Location header from createImage and createBackup response (spec) https://review.openstack.org/452951 | 21:10 |
| mriedem | mordred: sdague: ^ the spec | 21:11 |
| mriedem | dansmith: i bet we don't mention that limitation in the api ref for createBackup either | 21:11 |
| dansmith | I kinda wish we didn't mention it at all :) | 21:12 |
| mriedem | like the os-pci API? | 21:12 |
| mriedem | which reminds me... | 21:12 |
| *** edmondsw has quit IRC | 21:12 | |
| mriedem | nice, this is the message you get back with the 400 in that case, "The request is invalid." | 21:13 |
| mriedem | it should also kick you in the balls while it's being helpful | 21:14 |
| *** edmondsw has joined #openstack-nova | 21:14 | |
| dansmith | it logs something relevant, but yeah, no help for the user | 21:14 |
| * dansmith slinks away | 21:14 | |
| *** sivak has quit IRC | 21:15 | |
| *** annegentle has joined #openstack-nova | 21:15 | |
| mriedem | logs something for the admin to check when he gets the support ticket | 21:15 |
| *** sivak has joined #openstack-nova | 21:15 | |
| *** rfolco has quit IRC | 21:18 | |
| *** edmondsw has quit IRC | 21:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused migrate_data kwarg from virt driver destroy() method https://review.openstack.org/452958 | 21:19 |
| *** eharney has quit IRC | 21:20 | |
| *** kaisers has joined #openstack-nova | 21:21 | |
| *** sivak has quit IRC | 21:24 | |
| *** darrenc has quit IRC | 21:24 | |
| *** darrenc has joined #openstack-nova | 21:24 | |
| *** gouthamr has quit IRC | 21:24 | |
| *** ijw has joined #openstack-nova | 21:25 | |
| *** thorst has joined #openstack-nova | 21:26 | |
| *** artom has quit IRC | 21:28 | |
| *** artom has joined #openstack-nova | 21:29 | |
| *** thorst has quit IRC | 21:30 | |
| *** artom_ has joined #openstack-nova | 21:30 | |
| *** suresh12 has quit IRC | 21:30 | |
| *** suresh12 has joined #openstack-nova | 21:33 | |
| *** jwcroppe has quit IRC | 21:34 | |
| *** artom has quit IRC | 21:34 | |
| *** jwcroppe has joined #openstack-nova | 21:34 | |
| *** esberglu has joined #openstack-nova | 21:35 | |
| *** kfarr has quit IRC | 21:38 | |
| *** jwcroppe has quit IRC | 21:38 | |
| *** aysyd has quit IRC | 21:40 | |
| *** kaisers has quit IRC | 21:43 | |
| *** felipemonteiro has quit IRC | 21:47 | |
| *** thorst has joined #openstack-nova | 21:47 | |
| *** Sukhdev_ has joined #openstack-nova | 21:47 | |
| *** armax has quit IRC | 21:51 | |
| *** Guest63262 has quit IRC | 21:52 | |
| *** armax has joined #openstack-nova | 21:57 | |
| *** chyka has quit IRC | 21:57 | |
| *** chyka has joined #openstack-nova | 21:57 | |
| mordred | mriedem: awesome | 22:02 |
| *** armax has quit IRC | 22:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: Separate the releasenotes guide from the code-review section https://review.openstack.org/451870 | 22:03 |
| *** Swami has quit IRC | 22:04 | |
| *** Guest63262 has joined #openstack-nova | 22:04 | |
| mordred | mriedem: the impacts are awesome | 22:04 |
| mriedem | None? | 22:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Document and provide useful error message for volume-backed backup https://review.openstack.org/452970 | 22:06 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: move createBackup to server-actions https://review.openstack.org/452971 | 22:08 |
| *** rcernin has quit IRC | 22:12 | |
| *** marst_ has quit IRC | 22:13 | |
| *** mdrabe has quit IRC | 22:13 | |
| *** rebase has joined #openstack-nova | 22:15 | |
| *** ZZelle has quit IRC | 22:15 | |
| *** rfolco has joined #openstack-nova | 22:16 | |
| *** rfolco has quit IRC | 22:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: List instances using Searchlight (spec) https://review.openstack.org/441692 | 22:16 |
| *** rebase has left #openstack-nova | 22:16 | |
| *** lyan has quit IRC | 22:17 | |
| dtp | nova/objects/service.py/Service.obj_make_compatible_from_manifest doesn't seem to be called from anywhere within nova; is it still used? | 22:18 |
| mriedem | dtp: i believe that's used in the oslo.versionedobjects library | 22:19 |
| mriedem | so it's probably an override in nova | 22:19 |
| *** pumarani_ has quit IRC | 22:19 | |
| dansmith | mriedem: aye | 22:19 |
| mriedem | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L527 | 22:19 |
| dtp | roger; thanks | 22:19 |
| *** marst_ has joined #openstack-nova | 22:21 | |
| *** baoli has quit IRC | 22:24 | |
| *** mlavalle has quit IRC | 22:26 | |
| *** Sukhdev has quit IRC | 22:26 | |
| *** aunnam has quit IRC | 22:30 | |
| *** pumaranikar has quit IRC | 22:30 | |
| *** sneti has quit IRC | 22:30 | |
| *** sapcc-bot has joined #openstack-nova | 22:31 | |
| *** sapcc-bot1 has quit IRC | 22:31 | |
| *** efried has quit IRC | 22:32 | |
| *** sneti has joined #openstack-nova | 22:37 | |
| *** kaisers has joined #openstack-nova | 22:38 | |
| *** pumaranikar has joined #openstack-nova | 22:38 | |
| *** aunnam has joined #openstack-nova | 22:39 | |
| *** armax has joined #openstack-nova | 22:39 | |
| *** catintheroof has quit IRC | 22:44 | |
| *** ijw has quit IRC | 22:45 | |
| *** edmondsw has joined #openstack-nova | 22:45 | |
| *** ijw has joined #openstack-nova | 22:45 | |
| *** ijw has quit IRC | 22:47 | |
| *** crushil has joined #openstack-nova | 22:47 | |
| *** ijw has joined #openstack-nova | 22:47 | |
| *** edmondsw has quit IRC | 22:49 | |
| *** xyang1 has quit IRC | 22:50 | |
| *** ijw has quit IRC | 22:52 | |
| *** sdague has quit IRC | 22:57 | |
| *** sree has joined #openstack-nova | 22:58 | |
| *** marst_ has quit IRC | 23:00 | |
| *** jwcroppe has joined #openstack-nova | 23:01 | |
| *** sree has quit IRC | 23:03 | |
| *** annegentle has quit IRC | 23:03 | |
| *** ijw has joined #openstack-nova | 23:03 | |
| *** ijw has quit IRC | 23:03 | |
| *** ijw has joined #openstack-nova | 23:04 | |
| *** suresh12 has quit IRC | 23:08 | |
| *** ijw has quit IRC | 23:09 | |
| *** marst has joined #openstack-nova | 23:13 | |
| *** suresh12 has joined #openstack-nova | 23:14 | |
| *** siva_krishnan has quit IRC | 23:16 | |
| *** pumaranikar has quit IRC | 23:17 | |
| *** sneti has quit IRC | 23:17 | |
| *** aunnam has quit IRC | 23:17 | |
| *** aunnam has joined #openstack-nova | 23:19 | |
| *** pumaranikar has joined #openstack-nova | 23:19 | |
| *** yamahata has quit IRC | 23:21 | |
| *** siva_krishnan has joined #openstack-nova | 23:21 | |
| *** sneti has joined #openstack-nova | 23:22 | |
| *** chyka has quit IRC | 23:28 | |
| *** hoangcx has quit IRC | 23:35 | |
| *** suresh12 has quit IRC | 23:35 | |
| *** adrian_otto has quit IRC | 23:38 | |
| *** armax has quit IRC | 23:38 | |
| *** sneti__ has joined #openstack-nova | 23:41 | |
| *** suresh12 has joined #openstack-nova | 23:41 | |
| *** kaisers has quit IRC | 23:42 | |
| *** diga has joined #openstack-nova | 23:43 | |
| *** sneti_ has quit IRC | 23:44 | |
| *** sneti__ has quit IRC | 23:44 | |
| *** sneti_ has joined #openstack-nova | 23:44 | |
| *** sneti_ has quit IRC | 23:45 | |
| *** sneti_ has joined #openstack-nova | 23:46 | |
| *** kaisers has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
