| *** zz_dimtruck is now known as dimtruck | 00:01 | |
| alex_xu | mriedem: will check that patch in the morning | 00:03 |
|---|---|---|
| alex_xu | jaypipes: something looking for your feedback https://review.openstack.org/441829, cdent didn't want the cache :) | 00:03 |
| jaypipes | alex_xu: yeah, it's next on my list. currently reviewing https://review.openstack.org/#/c/435954/6/specs/pike/approved/enable-sriov-nic-features.rst | 00:04 |
| alex_xu | jaypipes: thanks :) | 00:05 |
| *** salv-orlando has quit IRC | 00:05 | |
| *** tbachman has joined #openstack-nova | 00:07 | |
| *** david-lyle has joined #openstack-nova | 00:08 | |
| *** yingjun has joined #openstack-nova | 00:09 | |
| dansmith | what kind of monster doesn't want a cache? | 00:09 |
| *** claudiub has quit IRC | 00:11 | |
| *** gfhellma has joined #openstack-nova | 00:12 | |
| *** hongbin has quit IRC | 00:14 | |
| *** david-lyle has quit IRC | 00:15 | |
| *** kylek3h has joined #openstack-nova | 00:18 | |
| *** browne has quit IRC | 00:18 | |
| *** gfhellma has quit IRC | 00:20 | |
| *** haplo37 has quit IRC | 00:20 | |
| dansmith | alex_xu: can you drop your -1 from this now? https://review.openstack.org/#/c/441388/9 | 00:21 |
| *** thorst has joined #openstack-nova | 00:25 | |
| mriedem | dansmith: just setup amazon household for prime, finally | 00:25 |
| mriedem | oh so sweet | 00:25 |
| mriedem | now i don't have to secretly log into laura's account to order things | 00:25 |
| dansmith | you mean you just got prime, or just got setup so laura can order stuff without you? | 00:25 |
| dansmith | oh heh | 00:25 |
| mriedem | she's had prime for years | 00:25 |
| dansmith | welcome to 2009! | 00:26 |
| mriedem | but has always been my proxy | 00:26 |
| *** dave-mccowan has joined #openstack-nova | 00:26 | |
| mriedem | \o/ | 00:26 |
| jaypipes | mriedem: can you record the Grand Tour and let me stream from your house? :) | 00:26 |
| dansmith | jaypipes: I know you're old, but... amazon prime video is streaming and generally "recording" it is hard to do | 00:27 |
| jaypipes | dansmith: I was expecting mriedem to set up a camcorder, tape it, upload the tape to his personal server and let me stream it from there. | 00:27 |
| * dansmith headdesks | 00:28 | |
| jaypipes | rofl | 00:28 |
| jaypipes | alex_xu: ok, sorry, I goofed. you were actually third in the queue, right behind my current review on https://review.openstack.org/#/c/364468/11/specs/pike/approved/reserve-numa-with-pci.rst | 00:29 |
| *** haplo37 has joined #openstack-nova | 00:29 | |
| *** jamesdenton has joined #openstack-nova | 00:29 | |
| *** thorst has quit IRC | 00:29 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 00:43 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 00:43 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 00:43 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 00:43 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 00:43 |
| mriedem | who wants to volunteer to run the meeting in the morning? | 00:44 |
| *** dtp has quit IRC | 00:45 | |
| *** catintheroof has quit IRC | 00:46 | |
| *** zhurong has joined #openstack-nova | 00:47 | |
| *** rfolco has quit IRC | 00:48 | |
| *** iceyao has joined #openstack-nova | 00:50 | |
| *** Shunli has joined #openstack-nova | 00:50 | |
| *** david-lyle has joined #openstack-nova | 00:54 | |
| *** ducttape_ has quit IRC | 00:54 | |
| *** david-lyle has quit IRC | 00:54 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 00:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 00:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 00:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 00:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 00:57 |
| * dansmith shakes his fist at pep8 | 00:59 | |
| *** yuntongjin has joined #openstack-nova | 01:00 | |
| *** jamesdenton has quit IRC | 01:00 | |
| *** Jeffrey4l_ has quit IRC | 01:00 | |
| *** dave-mccowan has quit IRC | 01:02 | |
| *** thorst has joined #openstack-nova | 01:02 | |
| *** thorst has quit IRC | 01:02 | |
| *** ssurana has joined #openstack-nova | 01:03 | |
| *** mlavalle has quit IRC | 01:10 | |
| *** iceyao has quit IRC | 01:10 | |
| *** esberglu has joined #openstack-nova | 01:10 | |
| *** iceyao has joined #openstack-nova | 01:10 | |
| *** esberglu has quit IRC | 01:11 | |
| *** ducttape_ has joined #openstack-nova | 01:13 | |
| dansmith | gfdi | 01:14 |
| dansmith | jaypipes: your requests have thrown off the whole cosmic balance of my patches | 01:14 |
| jaypipes | dansmith: :( | 01:14 |
| jaypipes | sorry duder. | 01:14 |
| melwitt | jaypipes: I've got the transactional safety change in my working dir. just finishing up some changes to the quota count patch | 01:15 |
| jaypipes | melwitt: coolio. | 01:16 |
| *** iceyao_ has joined #openstack-nova | 01:20 | |
| *** namnh has joined #openstack-nova | 01:21 | |
| *** iceyao has quit IRC | 01:24 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 01:25 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 01:25 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 01:25 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 01:25 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 01:25 |
| *** Lambert has joined #openstack-nova | 01:26 | |
| *** unicell has quit IRC | 01:34 | |
| *** ducttape_ has quit IRC | 01:35 | |
| *** mtanino has quit IRC | 01:35 | |
| *** salv-orlando has joined #openstack-nova | 01:37 | |
| *** gjayavelu has quit IRC | 01:38 | |
| *** ducttape_ has joined #openstack-nova | 01:38 | |
| *** youzp_ has joined #openstack-nova | 01:39 | |
| *** tuanluong has joined #openstack-nova | 01:40 | |
| *** salv-orlando has quit IRC | 01:41 | |
| *** adrian_otto has quit IRC | 01:46 | |
| *** ducttape_ has quit IRC | 01:49 | |
| *** dave-mcc_ has joined #openstack-nova | 01:50 | |
| *** yuntongjin has quit IRC | 01:52 | |
| *** yuntongjin has joined #openstack-nova | 01:52 | |
| *** david-lyle has joined #openstack-nova | 01:52 | |
| *** kevinz has joined #openstack-nova | 01:57 | |
| *** tommylikehu has joined #openstack-nova | 02:01 | |
| *** thorst has joined #openstack-nova | 02:03 | |
| *** ijw has quit IRC | 02:06 | |
| *** tovin07_ has joined #openstack-nova | 02:06 | |
| *** ijw has joined #openstack-nova | 02:07 | |
| *** thorst has quit IRC | 02:08 | |
| *** ijw has quit IRC | 02:09 | |
| *** tommylikehu has quit IRC | 02:12 | |
| *** haplo37 has quit IRC | 02:12 | |
| *** trinaths1 has left #openstack-nova | 02:17 | |
| *** Kevin_Zheng has joined #openstack-nova | 02:17 | |
| Kevin_Zheng | Hi, is this a known issue about quotas and cells? https://bugs.launchpad.net/nova/+bug/1670627 | 02:18 |
| openstack | Launchpad bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Undecided,In progress] - Assigned to huangtianhua (huangtianhua) | 02:18 |
| Kevin_Zheng | Looks critical | 02:19 |
| *** gjayavelu has joined #openstack-nova | 02:19 | |
| *** haplo37 has joined #openstack-nova | 02:21 | |
| melwitt | Kevin_Zheng: we have seen some quota bugs on the multicell patches that are currently in progress, but I hadn't heard about the specific issue with ERROR instances until now | 02:23 |
| *** markvoelker has quit IRC | 02:23 | |
| *** gjayavelu has quit IRC | 02:23 | |
| Kevin_Zheng | melwitt: Thanks for the reply | 02:23 |
| *** tbachman has quit IRC | 02:24 | |
| melwitt | Kevin_Zheng: and I think your analysis is right. we've been working on quotas in regard to cells right now, which will address the issues you're seeing. just didn't realize there were already problems in the wild with the single cell case | 02:24 |
| Kevin_Zheng | melwitt: shouldn't all quota calculated from nova_api db? | 02:24 |
| melwitt | Kevin_Zheng: yes, see this series https://review.openstack.org/#/c/410945/ | 02:24 |
| *** erlon has quit IRC | 02:25 | |
| Kevin_Zheng | melwiit: yeah, I know you are working on quota related issues so I ask here to see if it is already known :) | 02:25 |
| melwitt | it isn't in nova_api db yet, that series moves it there and gets rid of "usages" and "reservations" | 02:25 |
| Kevin_Zheng | Ok, thanks, I will have a look | 02:26 |
| Kevin_Zheng | will it fix the problem we meet? | 02:27 |
| melwitt | ah, cool. yeah, we didn't know about that one yet and I agree it sounds critical. our intention was that things should be okay in the single cell deployment | 02:27 |
| mriedem | Kevin_Zheng: we'll have to fix the bug separately | 02:28 |
| *** gongysh has joined #openstack-nova | 02:28 | |
| melwitt | yes, it will fix that problem. but I think we'll have to do a small different fix for now, that we can backport | 02:28 |
| mriedem | because we have to backport the fix | 02:28 |
| mriedem | jinx | 02:28 |
| Kevin_Zheng | yeah sounds reasonable | 02:28 |
| mriedem | so when we bury the instance in cell0, | 02:28 |
| melwitt | hah, yeah | 02:28 |
| mriedem | we have to remove the reservation from cell0 | 02:28 |
| mriedem | i think? | 02:28 |
| mriedem | we must be making a claim in cell0 or how does that work? | 02:29 |
| mriedem | s/claim/reservation/ | 02:29 |
| *** yuntongjin has quit IRC | 02:29 | |
| *** yuntongjin has joined #openstack-nova | 02:30 | |
| melwitt | thinking ... we're not doing anything to target the reservation/usage/etc | 02:30 |
| melwitt | so it should be in cell0 I think. and that's not getting removed ... so I think you're right | 02:30 |
| mriedem | the quota reservation happens in nova-api here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L312 | 02:33 |
| mriedem | but since that's not targeted to cell0, wouldn't that be in the main cell, i.e. nova database? | 02:33 |
| *** Apoorva has quit IRC | 02:34 | |
| mriedem | the commit is here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1059 | 02:34 |
| mriedem | there is no rollback of the quota in _bury_in_cell0 | 02:35 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L836 | 02:35 |
| mriedem | which probably makes sense because don't we want to keep the reservation until the instance is actually deleted? | 02:35 |
| melwitt | there shouldn't be because ERROR instances occupy quota | 02:35 |
| melwitt | but when the user deletes it, we need to do a reverse reserve and commit and somehow that's going to the wrong db | 02:36 |
| mriedem | we put the instance in cell0 here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L881 | 02:37 |
| melwitt | it's probably something like, we target cell0 to delete the instance and the quota reserve/commit for the freeing of quota goes to cell0 in the same target and we didn't mean to | 02:37 |
| melwitt | or something | 02:37 |
| *** salv-orlando has joined #openstack-nova | 02:38 | |
| mriedem | yeah, so we made the reservation in the nova db, but put the instance in the nova_cell0 db, and right when we delete i bet we find it in cell0 via the instance mapping | 02:38 |
| *** Jeffrey4l_ has joined #openstack-nova | 02:39 | |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1708 | 02:40 |
| melwitt | yeah, I'm looking in compute/api.py and I'm not seeing any freeing of quota for local deletes | 02:40 |
| mriedem | i think deleted would be False there | 02:40 |
| mriedem | because conductor deleted the build request | 02:40 |
| mriedem | we delete the build request in _bury_in_cell0 here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L888 | 02:40 |
| melwitt | yeah. so far it's looking to me like we're missing a quotas.commit() for the local delete cases | 02:41 |
| *** jamesdenton has joined #openstack-nova | 02:41 | |
| melwitt | like if we're deleting from here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1799 | 02:41 |
| melwitt | this would be if it never landed on a host | 02:42 |
| *** salv-orlando has quit IRC | 02:42 | |
| melwitt | we're not doing anything with quotas until L1842 but you have to have reserve and commit for a delete too | 02:43 |
| mriedem | yeah i was looking at _lookup_instance https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1660 | 02:43 |
| *** zerda4 has quit IRC | 02:43 | |
| mriedem | and we pull it from cell0 here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1690 | 02:43 |
| mriedem | looks like we need something like this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1729-L1756 | 02:44 |
| melwitt | I see that _delete_while_booting takes care of quotas correctly, it's just we're missing any quota handling at all at L1799 | 02:44 |
| melwitt | yes, agree | 02:45 |
| *** phuongnh has joined #openstack-nova | 02:45 | |
| *** jamesdenton has quit IRC | 02:45 | |
| *** rmk has joined #openstack-nova | 02:45 | |
| *** rmk has quit IRC | 02:45 | |
| *** rmk has joined #openstack-nova | 02:45 | |
| mriedem | should be relatively straightforward | 02:47 |
| melwitt | yeah, I think so too | 02:48 |
| *** rfolco has joined #openstack-nova | 02:49 | |
| *** rfolco has quit IRC | 02:50 | |
| *** ducttape_ has joined #openstack-nova | 02:50 | |
| melwitt | thanks Kevin_Zheng for alerting about that | 02:50 |
| Kevin_Zheng | melwitt: your are welcome, still try to catch all you guys discussed :) | 02:51 |
| *** raunak has quit IRC | 02:51 | |
| melwitt | Kevin_Zheng: mriedem added a comment to the lp bug to explain what was concluded | 02:52 |
| melwitt | it turned out to be something pretty simple | 02:52 |
| melwitt | that particular local delete case is missing quota cleanup | 02:53 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395 | 02:53 |
| mriedem | melwitt: Kevin_Zheng: ^ w/o any tests run or anything | 02:53 |
| *** dave-mcc_ has quit IRC | 02:54 | |
| *** thorst has joined #openstack-nova | 02:54 | |
| *** amrith has quit IRC | 02:54 | |
| *** yuntongjin has quit IRC | 02:54 | |
| *** armax has joined #openstack-nova | 02:54 | |
| *** thorst has quit IRC | 02:54 | |
| *** namnh_ has joined #openstack-nova | 02:54 | |
| *** ducttape_ has quit IRC | 02:55 | |
| *** amrith has joined #openstack-nova | 02:55 | |
| *** namnh has quit IRC | 02:56 | |
| Kevin_Zheng | https://review.openstack.org/#/c/443003 | 02:56 |
| Kevin_Zheng | ^ seems we have already tried this but didnt work? | 02:56 |
| *** amotoki has joined #openstack-nova | 02:57 | |
| melwitt | gah, I didn't look at the patch first | 02:58 |
| *** yuntongjin has joined #openstack-nova | 02:58 | |
| Kevin_Zheng | we tested manually | 02:59 |
| *** huangtianhua has joined #openstack-nova | 02:59 | |
| Kevin_Zheng | fix like this actually decrease usage in cell0 | 02:59 |
| melwitt | I'm trying to understand why that code is going to cell0 | 02:59 |
| *** hongbin has joined #openstack-nova | 03:00 | |
| melwitt | mriedem: ^ | 03:01 |
| mriedem | yeah idk | 03:01 |
| mriedem | are we mutating the context somewhere? | 03:01 |
| melwitt | I thought probably not. I'm not sure if we yet merged the thing method that targets a context and lets it continue on targeted | 03:03 |
| melwitt | and also I didn't think it would be used in this case | 03:03 |
| mriedem | that definitely came later | 03:08 |
| mriedem | set_target_cell | 03:08 |
| melwitt | grr this doesn't make sense | 03:09 |
| *** amotoki has quit IRC | 03:09 | |
| *** nic has quit IRC | 03:10 | |
| *** nicolasbock has joined #openstack-nova | 03:10 | |
| mriedem | i would have to recreate locally and tinker with this, | 03:12 |
| mriedem | which i don't have time tonight | 03:12 |
| mriedem | Kevin_Zheng: the instance is in cell0 though correct? | 03:12 |
| mriedem | and the build_request is deleted? | 03:12 |
| *** sudipto has joined #openstack-nova | 03:13 | |
| *** sudipto_ has joined #openstack-nova | 03:14 | |
| Kevin_Zheng | yes, we are have meeting now, but I will try to dig more if you guys didn't have tien | 03:15 |
| Kevin_Zheng | Time | 03:15 |
| mriedem | melwitt: i think i found the problem | 03:15 |
| melwitt | do tell | 03:16 |
| mriedem | gather round children | 03:16 |
| melwitt | heh | 03:16 |
| mriedem | so when the REST API looks up the instance via id | 03:16 |
| mriedem | it goes down to compute.API.get() | 03:16 |
| *** thorst has joined #openstack-nova | 03:16 | |
| mriedem | eventually to _get_instance | 03:16 |
| mriedem | we get the cell0 instance mapping here https://github.com/openstack/nova/blob/fa2b4a82648101826566da68dd56d204e269853f/nova/compute/api.py#L2292 | 03:17 |
| Kevin_Zheng | Ah | 03:17 |
| *** thorst has quit IRC | 03:17 | |
| mriedem | and then we mutate the context here https://github.com/openstack/nova/blob/fa2b4a82648101826566da68dd56d204e269853f/nova/compute/api.py#L2294 | 03:17 |
| mriedem | and forever after, that context object is targeted to cell0 | 03:17 |
| *** bkopilov_ has quit IRC | 03:17 | |
| melwitt | argh, so we are already using set_target_cell | 03:17 |
| Kevin_Zheng | Seems right | 03:18 |
| *** ducttape_ has joined #openstack-nova | 03:18 | |
| *** nicolasbock has quit IRC | 03:19 | |
| *** ducttape_ has quit IRC | 03:19 | |
| mriedem | dansmith: ^ set_target_cell might be screwing us here | 03:20 |
| mriedem | melwitt: on master yes | 03:20 |
| mriedem | but not ocata | 03:20 |
| *** ducttape_ has joined #openstack-nova | 03:20 | |
| *** ducttape_ has joined #openstack-nova | 03:20 | |
| melwitt | I wonder if we should avoid using it until everything that needs to move to api db moves, or try to just patch around it for now? | 03:20 |
| mriedem | we still have the bug in ocata | 03:21 |
| mriedem | but i think that's the reason why the guys patch didn't work | 03:21 |
| mriedem | and decremented from cell0 | 03:21 |
| dansmith | the only time I've experienced this is if the main db for the control services is set to cell0 | 03:21 |
| dansmith | it shouldn't happen with a single cell and database set to that db right? | 03:21 |
| mriedem | i believe this is single node devstack | 03:22 |
| Kevin_Zheng | We meet this in devstack env, didn't test in other cases yet | 03:22 |
| melwitt | dansmith: this is the quota_usages and reservations tables, so it's updating usages in cell0 | 03:22 |
| mriedem | dansmith: yeah see https://review.openstack.org/443395 | 03:23 |
| melwitt | after set_target_cell targets the context to cell0 | 03:23 |
| mriedem | which doesn't work because it tries to decrement from cell0 because the context is mutated to use cell0 when we lookup the instance here https://github.com/openstack/nova/blob/fa2b4a82648101826566da68dd56d204e269853f/nova/compute/api.py#L2294 | 03:23 |
| *** markvoelker has joined #openstack-nova | 03:24 | |
| dansmith | I'm confused, nothing ever moves between cell0 and another cell.. | 03:24 |
| mriedem | we make the reservation on quota in the nova db in the api | 03:24 |
| mriedem | then conductor fails to schedule and creates the instance in cell0 | 03:25 |
| mriedem | and deletes the build request | 03:25 |
| dansmith | ah | 03:25 |
| mriedem | when you go to delete the instance, we dont find the build request, | 03:25 |
| mriedem | but we find the instance mapping to cell0 | 03:25 |
| melwitt | dansmith: this is a delete of an ERROR instance in cell0. the REST API does a get of the instance, which set_target_cell to cell0 on the context, then that same context is passed along to quotas.commit() and it decrements usage in the wrong db | 03:25 |
| mriedem | and we delete the instance from the cell0 db | 03:25 |
| mriedem | but we don't decrement the quota | 03:25 |
| mriedem | melwitt: well, w/o https://review.openstack.org/#/c/443395/ we don't even attempt to decrement quota | 03:25 |
| melwitt | dansmith: (after the person tried to add the missing quota cleanup) | 03:25 |
| dansmith | and this is because we don't have the reservations in the api I guess? | 03:25 |
| mriedem | dansmith: yup | 03:25 |
| *** raunak has joined #openstack-nova | 03:25 | |
| dansmith | awesome | 03:26 |
| *** ssurana has quit IRC | 03:26 | |
| melwitt | mriedem, dansmith: right. so 1) we're missing quota cleanup 2) when we add quota cleanup, it cleans the wrong db because the context was targeted to cell0 early on | 03:27 |
| dansmith | has melwitt pointed out that counting fixes all this nonsense? | 03:27 |
| mriedem | yes | 03:27 |
| dansmith | okay good | 03:27 |
| melwitt | dansmith: yeah. but we need a backportable fix | 03:27 |
| mriedem | but we can't backprot that to ocata | 03:27 |
| openstackgerrit | Tony Breeds proposed openstack/os-vif master: Add Constraints support https://review.openstack.org/413325 | 03:27 |
| mriedem | so we need 2 fixes | 03:27 |
| dansmith | yeah, so we probably need a hacky thing to just go find the cell a thing is in (which will only ever be two places to check) right? | 03:27 |
| mriedem | the set_target_cell one for master only, | 03:27 |
| dansmith | for ocata | 03:27 |
| mriedem | and then https://review.openstack.org/#/c/443395/ or the other patch for ocata | 03:27 |
| mriedem | we know what cell it's in already | 03:27 |
| mriedem | and we delete the instance, that's all fine | 03:27 |
| mriedem | we just never decrement quota in that path, which https://review.openstack.org/#/c/443395/ does | 03:27 |
| mriedem | it just doesn't work on master b/c of set_target_cell | 03:28 |
| dansmith | okay | 03:28 |
| dansmith | yeah | 03:28 |
| mriedem | was there a reason we needed https://github.com/openstack/nova/blob/fa2b4a82648101826566da68dd56d204e269853f/nova/compute/api.py#L2294 ? | 03:28 |
| melwitt | mriedem: yeah, I was thinking consider taking the first patch for ocata https://review.openstack.org/#/c/443003 | 03:28 |
| mriedem | like, can't we just do the context manager there? | 03:28 |
| dansmith | mriedem: correct, | 03:28 |
| dansmith | mriedem: because the caller will need to do things, like later it might need to lazy-load fault for example | 03:29 |
| dansmith | which happens deep in the view | 03:29 |
| *** markvoelker has quit IRC | 03:29 | |
| dansmith | long after we've returned from here and have lost all cell scope | 03:29 |
| dansmith | or instance_info_cache sometimes | 03:29 |
| mriedem | ok, so i guess we have to hacky the quota decrement in the delete path | 03:30 |
| mriedem | such that it's untargeted | 03:30 |
| dansmith | and get is used to look up a thing which is later passed to something else that will make an rpc call, etc | 03:30 |
| dansmith | anyway | 03:30 |
| dansmith | yeah, | 03:30 |
| dansmith | I have a hard stop now, but happy to work on that thing tomorrow | 03:30 |
| mriedem | i'll roll something on top of the original fix and he can see if it works | 03:31 |
| mriedem | because i want to stop too | 03:31 |
| dansmith | melwitt: this is a reason to unblock your bottom two patches right? | 03:31 |
| melwitt | dansmith: yes, I think so | 03:32 |
| melwitt | well, no | 03:32 |
| *** amotoki has joined #openstack-nova | 03:32 | |
| melwitt | dansmith: my patches don't move the usages and reservations tables. just leaves them out | 03:32 |
| dansmith | oh right | 03:32 |
| melwitt | dansmith: sorry, doesn't move the data | 03:32 |
| dansmith | okay, anyway .. tomorrow | 03:33 |
| melwitt | it might still work because we have the tables and the usage might be addressed by the quota resyncing stuff | 03:33 |
| *** yamahata has quit IRC | 03:34 | |
| *** vladikr has quit IRC | 03:35 | |
| melwitt | like, data migration was not supposed to be needed for the usages. have to read over the original spec again | 03:35 |
| *** karthiks has quit IRC | 03:36 | |
| *** sudipto has quit IRC | 03:37 | |
| *** sudipto_ has quit IRC | 03:37 | |
| *** salv-orlando has joined #openstack-nova | 03:39 | |
| *** jamesdenton has joined #openstack-nova | 03:41 | |
| *** salv-orlando has quit IRC | 03:43 | |
| *** gjayavelu has joined #openstack-nova | 03:44 | |
| *** jamesden_ has joined #openstack-nova | 03:44 | |
| *** jamesdenton has quit IRC | 03:45 | |
| melwitt | yeah, nevermind. that wouldn't work at all bc no methods added to read/write usages and reservations in api db | 03:45 |
| *** iceyao_ has quit IRC | 03:46 | |
| *** amotoki has quit IRC | 03:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395 | 03:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 03:48 |
| mriedem | Kevin_Zheng: melwitt: ^ this is pretty ugly, but it's what i'm thinking before going to bed | 03:48 |
| *** fragatina has quit IRC | 03:48 | |
| *** gjayavelu has quit IRC | 03:48 | |
| *** karthiks has joined #openstack-nova | 03:49 | |
| Kevin_Zheng | mriedem: Thanks I will test it :) | 03:50 |
| Kevin_Zheng | mriedem: have a nice sleep | 03:50 |
| mriedem | o/ | 03:50 |
| *** mriedem is now known as mriedem_away | 03:51 | |
| melwitt | mriedem_away: okay, looking | 03:52 |
| *** diga has joined #openstack-nova | 03:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Start removing _lookup_instance https://review.openstack.org/443405 | 03:57 |
| mriedem_away | melwitt: one last thing that i thought of while looking through all of this ^ | 03:57 |
| mriedem_away | we can start unwinding the super complicated spaghetti code that was there for the transition | 03:57 |
| melwitt | okay, cool | 03:57 |
| mriedem_away | now i'm really leaving | 03:58 |
| mriedem_away | o/ | 03:58 |
| melwitt | gnight o/ | 03:58 |
| *** namnh_ has quit IRC | 03:59 | |
| *** hongbin has quit IRC | 03:59 | |
| *** udesale has joined #openstack-nova | 03:59 | |
| *** amotoki has joined #openstack-nova | 04:02 | |
| *** jamesden_ has quit IRC | 04:04 | |
| *** ijw has joined #openstack-nova | 04:07 | |
| *** iceyao has joined #openstack-nova | 04:07 | |
| *** amotoki has quit IRC | 04:10 | |
| *** ratailor has joined #openstack-nova | 04:10 | |
| *** iceyao has quit IRC | 04:11 | |
| *** jamielennox is now known as jamielennox|away | 04:13 | |
| *** KeithMnemonic has quit IRC | 04:14 | |
| *** bkopilov has joined #openstack-nova | 04:17 | |
| *** links has joined #openstack-nova | 04:17 | |
| *** thorst has joined #openstack-nova | 04:17 | |
| *** crushil has joined #openstack-nova | 04:20 | |
| *** bkopilov has quit IRC | 04:22 | |
| *** thorst has quit IRC | 04:22 | |
| *** amotoki has joined #openstack-nova | 04:24 | |
| *** sree has joined #openstack-nova | 04:24 | |
| *** markvoelker has joined #openstack-nova | 04:25 | |
| *** mdnadeem has joined #openstack-nova | 04:28 | |
| *** ducttape_ has quit IRC | 04:28 | |
| *** markvoelker has quit IRC | 04:29 | |
| *** moshele has joined #openstack-nova | 04:32 | |
| *** bkopilov has joined #openstack-nova | 04:33 | |
| *** salv-orlando has joined #openstack-nova | 04:39 | |
| *** moshele has quit IRC | 04:42 | |
| *** salv-orlando has quit IRC | 04:44 | |
| *** gouthamr has quit IRC | 04:46 | |
| *** denaitre has quit IRC | 04:47 | |
| *** iceyao has joined #openstack-nova | 04:47 | |
| *** jamielennox|away is now known as jamielennox | 04:47 | |
| *** iceyao_ has joined #openstack-nova | 04:51 | |
| *** iceyao has quit IRC | 04:51 | |
| *** yuntongjin has quit IRC | 04:52 | |
| *** psachin has joined #openstack-nova | 04:54 | |
| *** iceyao has joined #openstack-nova | 04:54 | |
| *** sam_nowitzki has joined #openstack-nova | 04:55 | |
| *** iceyao has quit IRC | 04:55 | |
| *** iceyao_ has quit IRC | 04:56 | |
| *** iceyao has joined #openstack-nova | 04:56 | |
| *** iceyao_ has joined #openstack-nova | 04:57 | |
| *** iceyao has quit IRC | 04:57 | |
| *** iceyao_ has quit IRC | 05:00 | |
| *** iceyao has joined #openstack-nova | 05:00 | |
| *** gjayavelu has joined #openstack-nova | 05:00 | |
| *** iceyao_ has joined #openstack-nova | 05:03 | |
| *** iceyao has quit IRC | 05:05 | |
| *** iceyao_ has quit IRC | 05:06 | |
| *** iceyao has joined #openstack-nova | 05:06 | |
| *** iceyao_ has joined #openstack-nova | 05:07 | |
| *** iceyao has quit IRC | 05:07 | |
| *** ijw has quit IRC | 05:08 | |
| *** gjayavelu has quit IRC | 05:09 | |
| *** iceyao_ has quit IRC | 05:09 | |
| *** iceyao has joined #openstack-nova | 05:10 | |
| *** diga has quit IRC | 05:10 | |
| *** iceyao_ has joined #openstack-nova | 05:13 | |
| *** iceyao has quit IRC | 05:14 | |
| *** iceyao_ has quit IRC | 05:14 | |
| *** sridharg has joined #openstack-nova | 05:14 | |
| *** iceyao has joined #openstack-nova | 05:14 | |
| *** unicell has joined #openstack-nova | 05:14 | |
| *** ssurana has joined #openstack-nova | 05:16 | |
| *** gongysh has quit IRC | 05:16 | |
| *** iceyao_ has joined #openstack-nova | 05:17 | |
| *** unicell1 has joined #openstack-nova | 05:18 | |
| *** fragatina has joined #openstack-nova | 05:18 | |
| *** thorst has joined #openstack-nova | 05:18 | |
| *** iceyao__ has joined #openstack-nova | 05:18 | |
| *** unicell has quit IRC | 05:19 | |
| *** iceyao has quit IRC | 05:19 | |
| *** ayogi has joined #openstack-nova | 05:20 | |
| *** fragatin_ has joined #openstack-nova | 05:20 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421 | 05:21 |
| *** iceyao__ has quit IRC | 05:22 | |
| *** iceyao has joined #openstack-nova | 05:22 | |
| *** iceyao_ has quit IRC | 05:22 | |
| *** fragatina has quit IRC | 05:22 | |
| *** thorst has quit IRC | 05:23 | |
| *** fragatin_ has quit IRC | 05:25 | |
| *** fragatina has joined #openstack-nova | 05:25 | |
| *** sudipto has joined #openstack-nova | 05:25 | |
| *** iceyao_ has joined #openstack-nova | 05:25 | |
| *** markvoelker has joined #openstack-nova | 05:25 | |
| *** iceyao has quit IRC | 05:26 | |
| *** iceyao has joined #openstack-nova | 05:27 | |
| *** ducttape_ has joined #openstack-nova | 05:28 | |
| *** fragatina has quit IRC | 05:29 | |
| *** iceyao_ has quit IRC | 05:29 | |
| *** jose-phillips has quit IRC | 05:30 | |
| *** gjayavelu has joined #openstack-nova | 05:30 | |
| *** iceyao has quit IRC | 05:30 | |
| *** markvoelker has quit IRC | 05:30 | |
| *** iceyao has joined #openstack-nova | 05:31 | |
| *** fragatina has joined #openstack-nova | 05:32 | |
| *** iceyao has quit IRC | 05:32 | |
| *** iceyao has joined #openstack-nova | 05:32 | |
| *** ducttape_ has quit IRC | 05:32 | |
| *** fragatina has quit IRC | 05:33 | |
| *** eliqiao has quit IRC | 05:33 | |
| *** iceyao_ has joined #openstack-nova | 05:34 | |
| *** gjayavelu has quit IRC | 05:35 | |
| *** yamahata has joined #openstack-nova | 05:36 | |
| *** fragatina has joined #openstack-nova | 05:36 | |
| *** eliqiao has joined #openstack-nova | 05:36 | |
| *** iceyao has quit IRC | 05:37 | |
| *** iceyao__ has joined #openstack-nova | 05:37 | |
| *** prateek has joined #openstack-nova | 05:38 | |
| *** iceyao__ has quit IRC | 05:38 | |
| *** iceyao has joined #openstack-nova | 05:38 | |
| *** iceyao_ has quit IRC | 05:38 | |
| *** iceyao has quit IRC | 05:40 | |
| *** iceyao has joined #openstack-nova | 05:40 | |
| *** salv-orlando has joined #openstack-nova | 05:40 | |
| *** fragatina has quit IRC | 05:41 | |
| *** fragatina has joined #openstack-nova | 05:42 | |
| *** iceyao_ has joined #openstack-nova | 05:43 | |
| *** iceyao has quit IRC | 05:45 | |
| *** salv-orlando has quit IRC | 05:45 | |
| openstackgerrit | Edu Alcaniz proposed openstack/nova master: follow-up https://review.openstack.org/443424 | 05:45 |
| openstackgerrit | jichenjc proposed openstack/nova master: Trivial Fix https://review.openstack.org/442310 | 05:46 |
| *** iceyao_ has quit IRC | 05:48 | |
| *** armax has quit IRC | 05:50 | |
| *** iceyao has joined #openstack-nova | 05:51 | |
| *** iceyao_ has joined #openstack-nova | 05:53 | |
| *** iceyao__ has joined #openstack-nova | 05:55 | |
| *** iceyao has quit IRC | 05:55 | |
| *** iceyao has joined #openstack-nova | 05:57 | |
| *** iceyao_ has quit IRC | 05:57 | |
| *** iceyao__ has quit IRC | 05:57 | |
| *** trinaths has joined #openstack-nova | 05:58 | |
| *** nkrinner_afk is now known as nkrinner | 05:59 | |
| *** gongysh has joined #openstack-nova | 06:01 | |
| *** avolkov has joined #openstack-nova | 06:02 | |
| *** links has quit IRC | 06:04 | |
| *** gjayavelu has joined #openstack-nova | 06:04 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add description for Image location in snapshot https://review.openstack.org/440379 | 06:06 |
| *** gjayavelu has quit IRC | 06:09 | |
| *** crushil has quit IRC | 06:10 | |
| *** edmondsw has joined #openstack-nova | 06:13 | |
| openstackgerrit | jichenjc proposed openstack/nova master: check hw:mem_page_size when change extra_spec https://review.openstack.org/408610 | 06:14 |
| *** karthiks has quit IRC | 06:14 | |
| openstackgerrit | jichenjc proposed openstack/nova master: no instance info cache update if instance deleted https://review.openstack.org/363585 | 06:14 |
| *** links has joined #openstack-nova | 06:16 | |
| *** edmondsw has quit IRC | 06:17 | |
| *** yuntongjin has joined #openstack-nova | 06:18 | |
| *** thorst has joined #openstack-nova | 06:19 | |
| *** satyar has joined #openstack-nova | 06:22 | |
| *** thorst has quit IRC | 06:24 | |
| *** moshele has joined #openstack-nova | 06:27 | |
| *** ducttape_ has joined #openstack-nova | 06:29 | |
| *** trinaths1 has joined #openstack-nova | 06:29 | |
| *** trinaths has quit IRC | 06:29 | |
| *** raunak has quit IRC | 06:30 | |
| *** diga has joined #openstack-nova | 06:31 | |
| *** ducttape_ has quit IRC | 06:33 | |
| *** salv-orlando has joined #openstack-nova | 06:33 | |
| *** yuntongjin1 has joined #openstack-nova | 06:36 | |
| *** yuntongjin has quit IRC | 06:36 | |
| *** gjayavelu has joined #openstack-nova | 06:39 | |
| *** jose-phillips has joined #openstack-nova | 06:39 | |
| *** armax has joined #openstack-nova | 06:39 | |
| *** ssurana has quit IRC | 06:42 | |
| *** rcernin has joined #openstack-nova | 06:44 | |
| *** ssurana has joined #openstack-nova | 06:45 | |
| *** gjayavelu has quit IRC | 06:48 | |
| *** Guest34860 has quit IRC | 06:51 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Add volume status check when deleting instances https://review.openstack.org/260339 | 06:53 |
| *** links has quit IRC | 06:58 | |
| *** amotoki_ has joined #openstack-nova | 07:01 | |
| *** lpetrut has joined #openstack-nova | 07:02 | |
| *** amotoki has quit IRC | 07:03 | |
| *** ssurana has quit IRC | 07:06 | |
| *** armax has quit IRC | 07:06 | |
| *** guchihiro has joined #openstack-nova | 07:07 | |
| *** jamielennox is now known as jamielennox|away | 07:09 | |
| *** ducnc has joined #openstack-nova | 07:10 | |
| *** sandanar has joined #openstack-nova | 07:12 | |
| *** jose-phillips has quit IRC | 07:12 | |
| *** diga has quit IRC | 07:13 | |
| *** yamamoto has quit IRC | 07:14 | |
| *** links has joined #openstack-nova | 07:15 | |
| *** jose-phillips has joined #openstack-nova | 07:20 | |
| *** thorst has joined #openstack-nova | 07:20 | |
| *** arne_r has joined #openstack-nova | 07:21 | |
| *** andreas_s has joined #openstack-nova | 07:22 | |
| *** salv-orl_ has joined #openstack-nova | 07:22 | |
| *** tesseract has joined #openstack-nova | 07:22 | |
| *** yuntongjin1 has quit IRC | 07:22 | |
| *** CristinaPauna has quit IRC | 07:23 | |
| *** thorst has quit IRC | 07:24 | |
| *** yuntongjin has joined #openstack-nova | 07:24 | |
| *** salv-orlando has quit IRC | 07:25 | |
| *** karthiks has joined #openstack-nova | 07:27 | |
| *** jamielennox|away is now known as jamielennox | 07:27 | |
| *** CristinaPauna has joined #openstack-nova | 07:29 | |
| *** ducttape_ has joined #openstack-nova | 07:30 | |
| *** databus23_ has joined #openstack-nova | 07:34 | |
| *** mkoderer_ has joined #openstack-nova | 07:34 | |
| *** david_1 has joined #openstack-nova | 07:34 | |
| *** ducttape_ has quit IRC | 07:35 | |
| *** databus23_ has quit IRC | 07:36 | |
| *** mkoderer_ has quit IRC | 07:36 | |
| *** david_1 has quit IRC | 07:36 | |
| *** dimtruck is now known as zz_dimtruck | 07:37 | |
| *** tbachman has joined #openstack-nova | 07:39 | |
| *** tbachman has quit IRC | 07:44 | |
| *** markus_z has joined #openstack-nova | 07:44 | |
| *** yuntongjin1 has joined #openstack-nova | 07:48 | |
| *** yuntongjin has quit IRC | 07:48 | |
| arne_r | markus_z: Hi, care to give this https://review.openstack.org/#/c/436868/ your blessing? | 07:49 |
| markus_z | arne_r: I'm going to check it within the next hours | 07:50 |
| arne_r | thanks =) | 07:52 |
| *** kaisers_ has joined #openstack-nova | 07:54 | |
| *** ralonsoh has joined #openstack-nova | 07:54 | |
| *** Jack_I has joined #openstack-nova | 07:58 | |
| *** lpetrut has quit IRC | 08:02 | |
| *** guchihiro has quit IRC | 08:05 | |
| *** jpena|off is now known as jpena | 08:05 | |
| *** ltomasbo|away is now known as ltomasbo | 08:11 | |
| *** mlakat has joined #openstack-nova | 08:13 | |
| *** mlakat has quit IRC | 08:13 | |
| *** mlakat has joined #openstack-nova | 08:13 | |
| *** diga has joined #openstack-nova | 08:14 | |
| *** mlakat_ has joined #openstack-nova | 08:14 | |
| *** lpetrut has joined #openstack-nova | 08:17 | |
| *** mlakat has quit IRC | 08:18 | |
| *** iceyao has quit IRC | 08:18 | |
| *** sofie_ has joined #openstack-nova | 08:18 | |
| *** jpena is now known as jpena|off | 08:19 | |
| *** thorst has joined #openstack-nova | 08:21 | |
| *** fragatina has quit IRC | 08:22 | |
| *** thorst has quit IRC | 08:25 | |
| *** jpena|off is now known as jpena | 08:26 | |
| Kevin_Zheng | melwitt, mriedem maybe it is good to add tempest test for this: create instance -> error -> delete -> check quota after this fixed, to avoid same thing happen again | 08:26 |
| Kevin_Zheng | ? | 08:26 |
| *** yassine has joined #openstack-nova | 08:27 | |
| *** jaosorior has joined #openstack-nova | 08:28 | |
| *** abalutoiu_ has quit IRC | 08:28 | |
| *** mnestratov has joined #openstack-nova | 08:30 | |
| *** ducttape_ has joined #openstack-nova | 08:30 | |
| *** mlakat_ has quit IRC | 08:30 | |
| *** mlakat has joined #openstack-nova | 08:31 | |
| markus_z | arne_r: It needs a small change, IMO | 08:33 |
| *** irenab has quit IRC | 08:33 | |
| *** mlakat has quit IRC | 08:34 | |
| *** abalutoiu has joined #openstack-nova | 08:34 | |
| *** mlakat has joined #openstack-nova | 08:34 | |
| *** psachin has quit IRC | 08:35 | |
| *** mlakat has quit IRC | 08:35 | |
| *** ducttape_ has quit IRC | 08:35 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | 08:41 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 08:41 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 08:41 |
| *** irenab_ has joined #openstack-nova | 08:42 | |
| *** markvoelker has joined #openstack-nova | 08:46 | |
| *** lpetrut has quit IRC | 08:47 | |
| *** psachin has joined #openstack-nova | 08:49 | |
| *** jahsis has joined #openstack-nova | 08:50 | |
| openstackgerrit | Qiming Teng proposed openstack/nova master: Fix API doc about server attributes (2.3 API) https://review.openstack.org/443000 | 08:52 |
| *** gjayavelu has joined #openstack-nova | 08:58 | |
| *** iceyao has joined #openstack-nova | 08:58 | |
| *** sree_ has joined #openstack-nova | 08:59 | |
| openstackgerrit | Dave Chen proposed openstack/nova master: WIP - Recover instance's task state after exception https://review.openstack.org/443509 | 08:59 |
| *** zzzeek has quit IRC | 09:00 | |
| *** sree_ is now known as Guest99484 | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:02 | |
| *** gjayavelu has quit IRC | 09:02 | |
| *** sree has quit IRC | 09:03 | |
| *** amoralej|off is now known as amoralej | 09:07 | |
| *** mlakat has joined #openstack-nova | 09:07 | |
| *** lucas-afk is now known as lucasagomes | 09:09 | |
| *** yuntongjin1 has quit IRC | 09:10 | |
| *** yuntongjin has joined #openstack-nova | 09:10 | |
| *** karimb has joined #openstack-nova | 09:14 | |
| *** hshiina has joined #openstack-nova | 09:18 | |
| *** alexpilotti has quit IRC | 09:19 | |
| *** jogo has quit IRC | 09:19 | |
| *** alexpilotti has joined #openstack-nova | 09:20 | |
| *** thorst has joined #openstack-nova | 09:22 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 09:22 |
| *** abalutoiu has quit IRC | 09:22 | |
| *** jogo has joined #openstack-nova | 09:24 | |
| *** Dave____ has joined #openstack-nova | 09:24 | |
| *** namnh has joined #openstack-nova | 09:26 | |
| *** haplo37 has quit IRC | 09:28 | |
| *** Dave has quit IRC | 09:29 | |
| *** Dave____ is now known as Dave | 09:29 | |
| *** thorst has quit IRC | 09:31 | |
| *** ducttape_ has joined #openstack-nova | 09:31 | |
| *** Shunli has quit IRC | 09:31 | |
| *** ducttape_ has quit IRC | 09:36 | |
| *** yingjun has quit IRC | 09:37 | |
| *** haplo37 has joined #openstack-nova | 09:38 | |
| *** kevinz has quit IRC | 09:39 | |
| *** abalutoiu has joined #openstack-nova | 09:41 | |
| *** yamahata has quit IRC | 09:48 | |
| *** edmondsw has joined #openstack-nova | 09:50 | |
| *** youzp_ is now known as youzp | 09:52 | |
| *** gszasz has joined #openstack-nova | 09:53 | |
| *** psachin has quit IRC | 09:54 | |
| *** edmondsw has quit IRC | 09:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Reserve NUMA nodes with PCI devices attached https://review.openstack.org/364468 | 09:57 |
| *** efoley has joined #openstack-nova | 10:00 | |
| asettle | johnthetubaguy: morning! You around yet? :) | 10:04 |
| *** psachin has joined #openstack-nova | 10:06 | |
| *** namnh has quit IRC | 10:06 | |
| johnthetubaguy | asettle: yup | 10:07 |
| johnthetubaguy | asettle: hows things? | 10:07 |
| asettle | johnthetubaguy: less than awesome rn. I've just had to move up one of our nova-related bugs to critical. I will be sending out to the ML the details but I was just going to see if you could help me get all hands on deck. | 10:07 |
| johnthetubaguy | asettle: you got a link? | 10:08 |
| asettle | https://bugs.launchpad.net/openstack-manuals/+bug/1663485 | 10:08 |
| openstack | Launchpad bug 1663485 in openstack-manuals "Document Nova v2 Cells and Placement API" [Critical,In progress] - Assigned to Brian Moss (bmoss) | 10:08 |
| asettle | Relevant patch: https://review.openstack.org/#/c/438328/ | 10:08 |
| asettle | It still doesn't work. | 10:08 |
| asettle | We need to branch, but we can't because the guide is broken at the moment as a result of this. | 10:08 |
| johnthetubaguy | asettle: doesn't work after you try with https://review.openstack.org/#/c/438328/ added? | 10:10 |
| asettle | johnthetubaguy: My understanding is that it does not. | 10:10 |
| *** hshiina has quit IRC | 10:10 | |
| johnthetubaguy | ah, I see the comment from bmoss now | 10:11 |
| bauzas | asettle: see the comment from Dimitry | 10:11 |
| bauzas | oops | 10:11 |
| johnthetubaguy | asettle: the people you want for this are melwitt and dansmith really, both west coast | 10:11 |
| *** tovin07 has quit IRC | 10:11 | |
| bauzas | s/Dimitry/Georgios | 10:11 |
| bauzas | I can try to help | 10:12 |
| johnthetubaguy | bauzas: cool | 10:12 |
| johnthetubaguy | it is RDO related | 10:12 |
| *** tovin07_ has quit IRC | 10:12 | |
| asettle | bauzas: would really appreciate that. You understand it doesn't really matter right now who did what, the fact is it doesn't work and we need all the assistance we can get - so, TL;DR - would super appreciate that. | 10:12 |
| asettle | bauzas: where is the commetn from GEorgios? | 10:13 |
| bauzas | asettle: https://bugs.launchpad.net/openstack-manuals/+bug/1663485/comments/20 | 10:13 |
| openstack | Launchpad bug 1663485 in openstack-manuals "Document Nova v2 Cells and Placement API" [Critical,In progress] - Assigned to Brian Moss (bmoss) | 10:13 |
| asettle | Oh in the bug ;) | 10:13 |
| *** kiseok7 has joined #openstack-nova | 10:13 | |
| bauzas | yeah | 10:13 |
| asettle | bauzas: yep I had seen that. Fortunately, Georgios error turned out well. | 10:14 |
| bauzas | asettle: the RDO issue is tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1405098 | 10:14 |
| openstack | bugzilla.redhat.com bug 1405098 in openstack-tripleo-heat-templates "Ocata requires additional cellvs2 setup" [High,On_qa] - Assigned to owalsh | 10:14 |
| asettle | However, Thiago's comments bring up another set of issues in the docs and Brian's one too. | 10:14 |
| bauzas | owalsh: around ? | 10:14 |
| asettle | bauzas: yep I'd been made aware of that :) | 10:14 |
| bauzas | owalsh is one of our top-notch engineers responsible for integrating Nova features into TripleO | 10:14 |
| johnthetubaguy | I don't see any logs about what is going wrong, I guess | 10:15 |
| bauzas | the problem I have is that I'm blind of the left problems | 10:15 |
| johnthetubaguy | yeah, same | 10:15 |
| asettle | bauzas: awesome :) | 10:15 |
| bauzas | I would love to see what's missing or still having problems so we could discuss on what's wrong | 10:15 |
| johnthetubaguy | there is no info to help debug the issues, apart from go reproduce it I guess | 10:15 |
| johnthetubaguy | and hope you see the same problem | 10:16 |
| asettle | johnthetubaguy: pretty much. I'm still going to reach out to the ML to get some reviews and help outside of the nova team. | 10:16 |
| asettle | What else can I do? | 10:16 |
| johnthetubaguy | if we could get logs from bmoss, that would really help us | 10:16 |
| asettle | Brian has gone to bed, and Amy (spotz) who is the other person experiencing the issue won't be up for a bit (Austin) | 10:16 |
| bauzas | upstream documentation is one thing, deployment procedures for a specific tool is another | 10:16 |
| asettle | johnthetubaguy: let me try and contact him. I know in theory he's awake. | 10:16 |
| johnthetubaguy | OK, I don't want to get him out of bed, just saying we don't really have anything to work on here | 10:17 |
| asettle | bauzas: very much so. andymccr offered to help too as he got it working in OSA. But I'm not too sure how mcuh it would help or not (I mean, I ain't knocking hte offer back) | 10:17 |
| bauzas | so, here, we could try to see what are the discrepancies between upstream docs and how TripleO gates nova | 10:17 |
| asettle | Nah, it's only 8pm there | 10:17 |
| asettle | Uno momenot | 10:17 |
| bauzas | asettle: you're EU based ? | 10:17 |
| asettle | bauzas: yes, London :) | 10:17 |
| bauzas | okay | 10:17 |
| bauzas | owalsh is Irish and I'm French | 10:17 |
| asettle | Excellent :D | 10:17 |
| bauzas | so we can somehow sort that out | 10:17 |
| andymccr | yeah if we compare it to OSA or TripleO we should be able to get it going | 10:17 |
| bauzas | not sure it's excellent to be French, but meh :p | 10:18 |
| johnthetubaguy | well, can compare it to the in tree docs too | 10:18 |
| asettle | I am happy to spin up an instance and start replicating if I can't get bmoss to give me his error logs rn | 10:18 |
| *** tuanluong has quit IRC | 10:18 | |
| asettle | bauzas: it's pretty great right now :P | 10:18 |
| bauzas | so, the question I have is | 10:19 |
| johnthetubaguy | andymccr: did we get that ordering issue sorted? | 10:19 |
| bauzas | without using a deployment tool, are we able to spin up an instance by following the upstream documentation ? | 10:19 |
| bauzas | and if not, what is the error ? | 10:19 |
| asettle | bauzas: that's basically the problem. No, we cannot. | 10:19 |
| asettle | spotz experienced this, and so did bmoss | 10:19 |
| johnthetubaguy | using the install guide, it doesn't work right now, right? | 10:20 |
| bauzas | asettle: do you have ways to reproduce that so you could throw me the exception ? | 10:20 |
| asettle | I've just text Brian now to see if he can shoot me his logs (I'm sure his wife will be hatin') | 10:20 |
| andymccr | johnthetubaguy: yes sir - we now do a "api_db version" before attempting the sync - if it's 0 --> sync, if it's not --> don't sync just create cell. | 10:20 |
| andymccr | (and sync later) | 10:20 |
| asettle | bauzas: not at the moment, no. Will work on getting you more information. I don't have the instance up, Brian does. Let me get back to you :) | 10:20 |
| asettle | (I hope?) | 10:20 |
| bauzas | Brian is ET-based ? | 10:20 |
| asettle | bauzas: Australia | 10:20 |
| bauzas | meh okay | 10:21 |
| asettle | So, complete opposite timezone. | 10:21 |
| bauzas | not sure we could get him | 10:21 |
| johnthetubaguy | andymccr: I wonder if the docs have that issue, they seem to not do api_db sync | 10:21 |
| asettle | It's after 8pm - not too late. | 10:21 |
| andymccr | johnthetubaguy: hmm maybe | 10:21 |
| andymccr | johnthetubaguy: on a new build you need it first | 10:21 |
| *** iceyao has quit IRC | 10:21 | |
| *** edmondsw has joined #openstack-nova | 10:22 | |
| asettle | bauzas: he's awake ;) he's just turning on his computer to send me the logs for you | 10:23 |
| *** satyar has quit IRC | 10:23 | |
| *** karimb has quit IRC | 10:23 | |
| asettle | "I updated the patch (with the comments from mriedem_away) but haven't tested the revision yet. I'll send you my nova logs." | 10:23 |
| asettle | So, hopefully we can see what the original problem was, and move from there. | 10:24 |
| bauzas | \o/ | 10:24 |
| bauzas | I'll have to bail out for a couple of hours | 10:24 |
| bauzas | but I'll be back around 1pm UTC | 10:24 |
| asettle | bauzas: no problem :) thank you for offering ot help. I've sent out to the ML too. Hopefully we can get some people looking at it too. | 10:24 |
| asettle | Sorry andymccr and johnthetubaguy - not ignoring you both :P | 10:26 |
| asettle | Getting the error logs from bmoss rn | 10:26 |
| *** edmondsw has quit IRC | 10:26 | |
| * johnthetubaguy nods | 10:28 | |
| *** Jack_I has quit IRC | 10:28 | |
| asettle | Ugh *head desk* | 10:28 |
| * asettle waves hand outside | 10:28 | |
| asettle | And it was such a nice day too | 10:28 |
| *** Jack_I has joined #openstack-nova | 10:29 | |
| bauzas | alex_xu: around ? | 10:29 |
| bauzas | alex_xu: not understood your point in https://review.openstack.org/#/c/440580/3/specs/pike/approved/scheduler-hints-in-server-details.rst@34 | 10:30 |
| johnthetubaguy | asettle: do we tell people to always install the controller first, and then the compute node? | 10:30 |
| *** yuntongjin has quit IRC | 10:30 | |
| bauzas | "controller" is a pure non-nova thing :) | 10:31 |
| asettle | johnthetubaguy: good question, lemme just check historically. | 10:31 |
| asettle | Yes, we do. | 10:31 |
| johnthetubaguy | OK, thats good | 10:32 |
| bauzas | but yeah I remember the old docs, and it's the case | 10:32 |
| * asettle is going back | 10:32 | |
| asettle | Yep | 10:32 |
| asettle | Controller -> Compute | 10:32 |
| bauzas | asettle: is the problem due to an upgrade or a greenfields install ? | 10:32 |
| asettle | bauzas: greenfields, I believe. | 10:32 |
| bauzas | because instructions are fairly different | 10:32 |
| asettle | We just test the install instructions, we don't test upgrades. | 10:32 |
| bauzas | for cells | 10:32 |
| *** efoley has quit IRC | 10:33 | |
| asettle | bauzas: that documentation for upgrades should belong in the upgrade docs, no? | 10:33 |
| bauzas | asettle: yup | 10:33 |
| asettle | Yes, okay, I'm not going crazy then. | 10:33 |
| *** udesale has quit IRC | 10:33 | |
| bauzas | just wanted to verify that bmoss is following the fresh install procedure, that's it | 10:33 |
| bauzas | because he's pointing to some internal BZ that mentions upgrades and TripleO hence my confusion | 10:33 |
| bauzas | both are totally separate things | 10:34 |
| *** lpetrut has joined #openstack-nova | 10:34 | |
| asettle | bauzas: yes he should be. The whole idea behind doing the install guide testing ist hat you have to do a full manual install (which is also why we don't have people racing to do it) | 10:34 |
| *** sambetts|afk is now known as sambetts | 10:35 | |
| bauzas | yeah, I followed it in 2012 :p | 10:36 |
| bauzas | using .deb packages :blushes: | 10:36 |
| bauzas | glad to see it continuing even if not a lot of people are crazy pants enough to install OpenStack by hand :) | 10:37 |
| bauzas | oh | 10:37 |
| lyarwood | https://review.openstack.org/#/c/391597/ - pretty simple ~1k LOC removal change in favor of os-brick code if anyone has time this morning | 10:37 |
| bauzas | asettle: my reply to your email was bounced | 10:37 |
| bauzas | asettle: because openstack-docs@ is moderated | 10:37 |
| asettle | bauzas: by me! | 10:37 |
| asettle | Let me add you in | 10:38 |
| bauzas | strange, why are you moderating it ? | 10:38 |
| johnthetubaguy | oh, did not know there was a docs ML | 10:38 |
| asettle | bauzas: cause i'm the PTL :p | 10:38 |
| bauzas | well, in general, our lists are open | 10:38 |
| asettle | johnthetubaguy: yeah we're weird like that. I dunno why we have it. | 10:38 |
| asettle | Hence why I added the dev list into it, and the docs for others. I don't know the historical reason we have a separate ML | 10:38 |
| asettle | I think it was because we were not a part of the dev cycle for a while there | 10:38 |
| asettle | now we are | 10:38 |
| asettle | Soooo ya know | 10:38 |
| bauzas | having a separate ML is fine by me | 10:39 |
| johnthetubaguy | that does explain why I don't see any docs chatter on the ML | 10:39 |
| asettle | johnthetubaguy: yep :) feel free to sign up. | 10:39 |
| bauzas | having it moderated is what I'm worried about | 10:39 |
| johnthetubaguy | well, not much anyways | 10:39 |
| asettle | I occasionally post to it | 10:39 |
| asettle | bauzas: we get a *Lot* of spam, unforunatley | 10:39 |
| bauzas | anyway, /me needs to drop off, school pick-up | 10:39 |
| asettle | Everything is let through from people unless it's a clear spam email or bot (which, is unbelievably common) | 10:39 |
| bauzas | soooo \o see ya in a couple of hours | 10:39 |
| owalsh | asettle: hi | 10:40 |
| johnthetubaguy | asettle: not sure, that kind of thing can make you accidentally make you a docs CPL | 10:40 |
| asettle | owalsh: hi! | 10:40 |
| asettle | bauzas: have fun! | 10:40 |
| asettle | johnthetubaguy: *screams* | 10:40 |
| * owalsh looks at https://review.openstack.org/438328 | 10:40 | |
| asettle | thank you owalsh !! | 10:41 |
| *** Lambert has quit IRC | 10:42 | |
| * bauzas waves to owalsh and throws the baby to him :p | 10:42 | |
| *** Lambert has joined #openstack-nova | 10:42 | |
| bauzas | kid's time, so \o | 10:42 |
| asettle | bauzas: hey woah it's hardly a baby :P | 10:42 |
| *** gongysh has quit IRC | 10:44 | |
| owalsh | asettle: AFAIK need to run api_db sync before map_cell0 or create_cell | 10:45 |
| asettle | owalsh: the person to best answer that is bmoss as he has been testing. I'm just waiting for him to send me his error logs so can I appropriately address questions. | 10:46 |
| asettle | I am currently just escalating to ensure we have eyes on it :) | 10:46 |
| *** ratailor has quit IRC | 10:46 | |
| *** mvk has quit IRC | 10:48 | |
| *** Lambert has quit IRC | 10:49 | |
| *** cdent has joined #openstack-nova | 10:49 | |
| *** Lambert has joined #openstack-nova | 10:49 | |
| *** sudipto has quit IRC | 10:51 | |
| *** derekh has joined #openstack-nova | 10:52 | |
| *** sam_nowitzki has quit IRC | 10:54 | |
| *** yuntongjin has joined #openstack-nova | 10:55 | |
| asettle | owalsh and johnthetubaguy - Brian confirmed that he initially used the dev docs in-tree to install, and those didn't work either *head desk* | 10:57 |
| gibi | hi nova! there is a high severity bug fix that needs core attention https://review.openstack.org/#/c/437222/ . Could you check it please? | 10:57 |
| johnthetubaguy | OK, that has worked for some people, at least apparently | 10:57 |
| johnthetubaguy | gibi: its open in my browser, just chasing down this docs issue right now | 10:58 |
| gibi | johnthetubaguy: thanks! | 10:58 |
| jaosorior | gibi: thanks for the fix; that actually breaks us. | 10:58 |
| *** yuntongjin has quit IRC | 10:59 | |
| *** yuntongjin has joined #openstack-nova | 10:59 | |
| gibi | jaosorior: hi! breaks me too :) | 11:00 |
| johnthetubaguy | gibi: there are related quota issues to that fix, I believe | 11:00 |
| *** salv-orl_ has quit IRC | 11:00 | |
| johnthetubaguy | not that your fix breaks quotas, just that you are pointing at a wider bug / lack of code sharing | 11:01 |
| *** salv-orlando has joined #openstack-nova | 11:01 | |
| *** salv-orlando has quit IRC | 11:01 | |
| *** salv-orlando has joined #openstack-nova | 11:02 | |
| gibi | johnthetubaguy: you mean this fix needs to be extended with some quota fix as well? | 11:02 |
| johnthetubaguy | gibi: no, just there are other problems in that area I think | 11:02 |
| johnthetubaguy | there is a quota bug about that, someone was working on it | 11:02 |
| johnthetubaguy | gibi: I would love dansmith or melwitt to take a look at that bug fix, they have better context around that code | 11:03 |
| *** sree has joined #openstack-nova | 11:03 | |
| gibi | johnthetubaguy: OK, I will ping them today | 11:03 |
| johnthetubaguy | gibi: when I last checked it I was a bit worried about the cut and paste -ness of it, but not sure how to restructure it | 11:03 |
| gibi | johnthetubaguy: yeah, that code path is ugly. I was affraid to touch it as I felt I will break something if I try to factor out the duplication | 11:04 |
| gibi | johnthetubaguy: do you have the bug number for the quota bug? I would review that patch to learn something new | 11:05 |
| *** Guest99484 has quit IRC | 11:05 | |
| johnthetubaguy | gibi: I don't was in chat previously, something about hitting over quota errors, and the quota never being removed | 11:06 |
| asettle | johnthetubaguy: I see you pushed a patch! What's up? | 11:06 |
| asettle | Just replied to the ML with brian's logs | 11:06 |
| asettle | bauzas: ^^ | 11:06 |
| cdent | asettle, johnthetubaguy: do we have a more clear picture of the context that leads to "wrong" and whatever "wrong" is with that docs stuff? It feels a bit like we're all guessing | 11:06 |
| cdent | oh good | 11:06 |
| * gibi diggin launchpad | 11:06 | |
| cdent | that'll probably answer my questions, thank you asettle | 11:06 |
| asettle | cdent: yep take a look. | 11:06 |
| johnthetubaguy | gibi: maybe just a function that does destroy and does the notification | 11:06 |
| *** yuntongjin has quit IRC | 11:07 | |
| johnthetubaguy | asettle: I was worried about the order not being very clear, but also very, very important, so I refactored the docs patch while we were waiting for the logs | 11:07 |
| asettle | cdent: the in-tree docs you guys have were also tested and although I don't have the error logs to give you, my understanding is that those instructions immediately error with "placement API is not available, you must configure the placement API." | 11:07 |
| asettle | johnthetubaguy: you're a gem ;) | 11:07 |
| gibi | johnthetubaguy: this could be the quota bug https://bugs.launchpad.net/nova/+bug/1670627 | 11:07 |
| openstack | Launchpad bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] - Assigned to Matt Riedemann (mriedem) | 11:07 |
| sean-k-mooney | tonyb: hi you about? sorry my rely to your comment on https://review.openstack.org/#/c/413325/2/tools/tox_install.sh is a bit ranty | 11:08 |
| johnthetubaguy | asettle: did you include the dev list? | 11:08 |
| asettle | johnthetubaguy: sure did | 11:08 |
| johnthetubaguy | hmm, not getting the email, will try the archive | 11:08 |
| cdent | asettle: I suspect that is because of this of the <Directory> thing (I added a link to an os-dev posting on the review) | 11:08 |
| gibi | johnthetubaguy: yeah that could be done. If that helps then I'm happy to do that | 11:09 |
| sean-k-mooney | tonyb: that said the fact my cygwin workflow for running tox is now broken really annoyed me when i disscovered it | 11:09 |
| johnthetubaguy | gibi: makes it easier not to forget next time I think | 11:09 |
| cdent | the reason things happen to work in devstack but not elsewhere is because keystone stuff is taking care of adding a <Directory> entry that covers placement too | 11:09 |
| gibi | johnthetubaguy: OK | 11:09 |
| asettle | johnthetubaguy: http://lists.openstack.org/pipermail/openstack-dev/2017-March/113608.html | 11:09 |
| asettle | cdent: in the in-tree docs or the docs.o.o ones? | 11:10 |
| cdent | asettle: I added a link on the docs.o.o review, just as a reference point | 11:10 |
| johnthetubaguy | oh... maybe the docs don't talk about creating any flavors any more | 11:10 |
| johnthetubaguy | thats quite a recent change, we no longer install any flavors by default, you have to create your own | 11:11 |
| gibi | johnthetubaguy: I have to rewoke that it would be easy to do see the block change in https://review.openstack.org/#/c/437222/5/nova/compute/api.py | 11:11 |
| *** yuntongjin has joined #openstack-nova | 11:11 | |
| cdent | asettle, johnthetubaguy: I need to coffee-up and read the logs, but I'll be around to try and help more soon | 11:11 |
| johnthetubaguy | cdent: sweet | 11:11 |
| asettle | cdent: thanks dude :) | 11:11 |
| johnthetubaguy | cdent: it sounds very familiar | 11:11 |
| gibi | johnthetubaguy: also it seems there are different error handling around instance.destroy | 11:12 |
| *** kevinz has joined #openstack-nova | 11:12 | |
| gibi | johnthetubaguy: sometimes we retry after a refresh, sometimes we don'tt | 11:12 |
| gibi | johnthetubaguy: here https://review.openstack.org/#/c/437222/5/nova/conductor/manager.py | 11:12 |
| johnthetubaguy | asettle: I am not seeing that placement related error anywhere in the logs | 11:13 |
| johnthetubaguy | asettle: do you know where you saw it? | 11:13 |
| johnthetubaguy | I see "libvirtError: Failed to connect socket to '/var/run/libvirt/libvirt-sock': Connection refused" | 11:14 |
| asettle | johnthetubaguy: that placement error was specifically for the in-tree docs, unreferenced | 11:14 |
| gibi | johnthetubaguy: anyhow I will ping dansmith and melwitt later with this patch | 11:14 |
| asettle | The error logs I sent you were from the instructions that bmoss tried in the patch | 11:14 |
| * gibi runs for lunch | 11:14 | |
| asettle | johnthetubaguy: meant to be different things, sorry for confusing you | 11:14 |
| *** karimb has joined #openstack-nova | 11:14 | |
| johnthetubaguy | asettle: so the bug he is hitting seems to be listed here: https://github.com/mseknibilel/OpenStack-Grizzly-Install-Guide/issues/71 | 11:15 |
| johnthetubaguy | asettle: seems unrelated to placement or cells | 11:15 |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: Avoid using fdatasync() when fetching images https://review.openstack.org/443583 | 11:16 |
| owalsh | asettle: I think the current instructions should work, I've added some nits but nothing significant | 11:16 |
| asettle | Okay, this is good. I'd like to get a few more eyes on it. | 11:17 |
| asettle | One of my other concerns is that nobody seemed to agree in that patch set. | 11:17 |
| asettle | There was a lot of differing opinions. | 11:17 |
| asettle | I might have to spin something up and test it, Brian has just gone to bed. | 11:17 |
| asettle | I'm sorry I can't answer all the questions - I'm speaking on behalf of someone. | 11:18 |
| *** karimb has quit IRC | 11:18 | |
| cdent | asettle: you're encountering that sad reality that seems to be coming up alot lately: Half of us making this stuff haven't got enough time to actually use it and test it :( | 11:18 |
| *** kevinz has quit IRC | 11:19 | |
| *** sree has quit IRC | 11:19 | |
| johnthetubaguy | asettle: afraid the logs don't help here, so someone is going to have to walk through the guide I guess? | 11:19 |
| *** kevinz has joined #openstack-nova | 11:20 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova master: Avoid using fdatasync() when fetching images https://review.openstack.org/443583 | 11:20 |
| *** hshiina has joined #openstack-nova | 11:21 | |
| *** JoseMello has joined #openstack-nova | 11:21 | |
| *** sofie_ has quit IRC | 11:21 | |
| asettle | johnthetubaguy: volunteering? :D | 11:22 |
| asettle | You can do it and I can do it and i'll meet you in the middle | 11:22 |
| johnthetubaguy | asettle: I am curious what your take is on the doc change after this: https://review.openstack.org/#/c/438328/7/doc/install-guide/source/nova-controller-install.rst | 11:22 |
| asettle | cdent: unfortunately, yep. I've been chatting to mriedem_away about getting a dedicated CPL for this stuff. Nova is one of the only projects that don't have one. | 11:22 |
| asettle | johnthetubaguy: where specifically? | 11:23 |
| johnthetubaguy | asettle: I don't think I can, I am blocking way too many people to do none of my other work I had planned, bauzas sounded like he might | 11:23 |
| johnthetubaguy | asettle: I basically moved all the new instructions into the existing flow | 11:23 |
| asettle | johnthetubaguy: okay that's a good start. My day is relatively clear :) | 11:24 |
| johnthetubaguy | asettle: this is the bulk of the change https://review.openstack.org/#/c/438328/4..7/doc/install-guide/source/nova-controller-install.rst | 11:24 |
| asettle | johnthetubaguy: okay, lemme do the thing. | 11:25 |
| asettle | Let's see if I can get lucky. | 11:26 |
| *** aloga_ has joined #openstack-nova | 11:27 | |
| *** mvk has joined #openstack-nova | 11:27 | |
| * johnthetubaguy crosses fingers | 11:28 | |
| *** thorst has joined #openstack-nova | 11:28 | |
| *** yamamoto has joined #openstack-nova | 11:29 | |
| *** vishwanathj has quit IRC | 11:29 | |
| *** vishwanathj has joined #openstack-nova | 11:29 | |
| *** kornicameister has quit IRC | 11:30 | |
| *** kornicameister has joined #openstack-nova | 11:31 | |
| *** nicolasbock has joined #openstack-nova | 11:32 | |
| *** sean-k-mooney has quit IRC | 11:32 | |
| *** aarefiev_afk has quit IRC | 11:32 | |
| *** markvoelker has quit IRC | 11:33 | |
| *** thorst has quit IRC | 11:33 | |
| *** vsaienk0 has quit IRC | 11:35 | |
| *** rmart04 has joined #openstack-nova | 11:39 | |
| *** yuntongjin has quit IRC | 11:43 | |
| *** yuntongjin has joined #openstack-nova | 11:44 | |
| *** purplerbot has quit IRC | 11:44 | |
| *** purplerbot has joined #openstack-nova | 11:44 | |
| alex_xu | bauzas: so currently our API is free dict for hints field? | 11:45 |
| *** purplerbot has quit IRC | 11:46 | |
| alex_xu | bauzas: oops, I saw you said i have valid comment | 11:46 |
| *** rfolco has joined #openstack-nova | 11:47 | |
| *** purplerbot has joined #openstack-nova | 11:49 | |
| *** purplerbot has quit IRC | 11:49 | |
| *** rfolco_ has joined #openstack-nova | 11:50 | |
| *** rmart04 has quit IRC | 11:51 | |
| *** rmart04 has joined #openstack-nova | 11:52 | |
| *** rfolco has quit IRC | 11:53 | |
| *** sdague has joined #openstack-nova | 11:53 | |
| *** purplerbot has joined #openstack-nova | 11:55 | |
| *** Matias_ has quit IRC | 11:56 | |
| *** Matias_ has joined #openstack-nova | 11:57 | |
| *** rmart04 has quit IRC | 11:57 | |
| *** kaisers_ has quit IRC | 11:57 | |
| *** rfolco_ has quit IRC | 11:58 | |
| *** rfolco has joined #openstack-nova | 11:59 | |
| *** kaisers_ has joined #openstack-nova | 11:59 | |
| *** kaisers_ has quit IRC | 11:59 | |
| *** kaisers_ has joined #openstack-nova | 12:00 | |
| *** moshele has quit IRC | 12:01 | |
| *** moshele has joined #openstack-nova | 12:01 | |
| *** purplerbot has quit IRC | 12:02 | |
| *** purplerbot has joined #openstack-nova | 12:02 | |
| *** aysyd has joined #openstack-nova | 12:03 | |
| *** jpena is now known as jpena|lunch | 12:05 | |
| *** tuanluong has joined #openstack-nova | 12:06 | |
| *** mkoderer_ has joined #openstack-nova | 12:06 | |
| *** databus23_ has joined #openstack-nova | 12:06 | |
| *** seife_ has joined #openstack-nova | 12:06 | |
| *** david_1 has joined #openstack-nova | 12:06 | |
| *** amotoki_ has quit IRC | 12:07 | |
| *** zhurong has quit IRC | 12:08 | |
| *** amotoki has joined #openstack-nova | 12:08 | |
| *** seife_ has quit IRC | 12:08 | |
| *** databus23_ has quit IRC | 12:08 | |
| *** mkoderer_ has quit IRC | 12:08 | |
| *** david_1 has quit IRC | 12:08 | |
| *** crusio has quit IRC | 12:08 | |
| *** crusio has joined #openstack-nova | 12:09 | |
| *** claudiub has joined #openstack-nova | 12:10 | |
| *** aarefiev_afk has joined #openstack-nova | 12:12 | |
| *** lucasagomes is now known as lucas-hungry | 12:12 | |
| *** amotoki has quit IRC | 12:13 | |
| *** cdent has quit IRC | 12:16 | |
| *** rdo has joined #openstack-nova | 12:20 | |
| *** yuntongjin1 has joined #openstack-nova | 12:20 | |
| *** yuntongjin has quit IRC | 12:21 | |
| *** tuanluong has quit IRC | 12:21 | |
| *** yamamoto has quit IRC | 12:21 | |
| *** yamamoto has joined #openstack-nova | 12:21 | |
| *** rdo_ has quit IRC | 12:22 | |
| arne_r | markus_z: I addressed the issues in https://review.openstack.org/#/c/436868/ and Jenkins verified | 12:22 |
| *** cdent has joined #openstack-nova | 12:23 | |
| markus_z | arne_r: The zkvm CI should also pass | 12:24 |
| *** aloga__ has joined #openstack-nova | 12:24 | |
| *** aloga___ has joined #openstack-nova | 12:24 | |
| *** 21WAAQZ9J has joined #openstack-nova | 12:24 | |
| *** aloga____ has joined #openstack-nova | 12:24 | |
| *** aloga___1 has joined #openstack-nova | 12:24 | |
| *** aloga___2 has joined #openstack-nova | 12:24 | |
| *** aloga___3 has joined #openstack-nova | 12:24 | |
| *** aloga___4 has joined #openstack-nova | 12:24 | |
| *** aloga___5 has joined #openstack-nova | 12:24 | |
| *** aloga___6 has joined #openstack-nova | 12:24 | |
| *** aloga___7 has joined #openstack-nova | 12:24 | |
| *** yuntongjin1 has quit IRC | 12:25 | |
| arne_r | mriedem_away lyearwood: Is this good enough for a workflow now? https://review.openstack.org/#/c/436868/ | 12:25 |
| *** amotoki has joined #openstack-nova | 12:26 | |
| *** sudipto has joined #openstack-nova | 12:29 | |
| *** bkopilov has quit IRC | 12:30 | |
| *** smatzek has joined #openstack-nova | 12:31 | |
| *** smatzek_ has joined #openstack-nova | 12:32 | |
| *** Lambert has quit IRC | 12:33 | |
| *** jvarlamova__ has quit IRC | 12:33 | |
| *** smatzek has quit IRC | 12:36 | |
| *** hferenc has joined #openstack-nova | 12:36 | |
| *** sdague has quit IRC | 12:36 | |
| *** thorst has joined #openstack-nova | 12:37 | |
| *** aloga___1 has quit IRC | 12:38 | |
| *** aloga___6 has quit IRC | 12:38 | |
| *** aloga_ has quit IRC | 12:38 | |
| *** aloga___5 has quit IRC | 12:38 | |
| *** 21WAAQZ9J has quit IRC | 12:38 | |
| *** aloga__ has quit IRC | 12:38 | |
| *** aloga___7 has quit IRC | 12:38 | |
| *** aloga___ has quit IRC | 12:38 | |
| *** aloga___4 has quit IRC | 12:38 | |
| *** aloga___2 has quit IRC | 12:38 | |
| *** aloga___3 has quit IRC | 12:38 | |
| *** aloga____ has quit IRC | 12:38 | |
| *** salv-orlando has quit IRC | 12:38 | |
| *** moshele has quit IRC | 12:38 | |
| *** moshele has joined #openstack-nova | 12:38 | |
| *** phuongnh has quit IRC | 12:40 | |
| *** eglynn has joined #openstack-nova | 12:42 | |
| *** phuongnh has joined #openstack-nova | 12:43 | |
| *** gongysh has joined #openstack-nova | 12:43 | |
| *** sree has joined #openstack-nova | 12:44 | |
| *** sridharg has quit IRC | 12:44 | |
| *** sree_ has joined #openstack-nova | 12:47 | |
| *** sree_ is now known as Guest41531 | 12:48 | |
| *** lucas-hungry is now known as lucasagomes | 12:48 | |
| *** kaisers_ has quit IRC | 12:48 | |
| *** sree has quit IRC | 12:49 | |
| alex_xu | bauzas: johnthetubaguy, looks like we have no quota for scheduler_hints....so is that something user can input any number of hints? | 12:50 |
| *** ayogi has quit IRC | 12:50 | |
| alex_xu | but I guess that limited by the max length of request body | 12:53 |
| *** phuongnh has quit IRC | 12:54 | |
| *** priteau has joined #openstack-nova | 12:55 | |
| *** mriedem_away is now known as mriedem | 12:55 | |
| *** dave-mccowan has joined #openstack-nova | 12:56 | |
| mriedem | asettle: we had docs CPL volunteers in the mailing list | 12:56 |
| asettle | mriedem: yes I was waiting to hear back from you regarding confirmation of that. | 12:56 |
| asettle | I saw there were two volunteers - let me know who is available to provide the time | 12:57 |
| mriedem | asettle: Kevin_Zheng and nicolas bock | 12:57 |
| asettle | mriedem: terrific: https://wiki.openstack.org/wiki/CrossProjectLiaisons#Documentation | 12:57 |
| asettle | It would be very much appreciated if you could update that table :) | 12:57 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200 | 12:57 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Move the common code out of ResourceClassCache https://review.openstack.org/416007 | 12:57 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | 12:57 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add simple cache object for traits https://review.openstack.org/441829 | 12:57 |
| *** trinaths1 has left #openstack-nova | 12:58 | |
| mriedem | will do | 12:58 |
| mriedem | nicolasbock: fyi ^ | 12:59 |
| asettle | Muchos appreciated :) and now, back to the manual install that'll kill my will to live | 12:59 |
| nicolasbock | mriedem, thanks | 12:59 |
| *** tblakes has joined #openstack-nova | 12:59 | |
| mriedem | asettle: updated | 13:00 |
| asettle | nicolasbock: while you're here ;) if you haven't seen my email to the dev ML, I've had to update a nova-related bug to critical. https://bugs.launchpad.net/openstack-manuals/+bug/1663485 | 13:01 |
| openstack | Launchpad bug 1663485 in openstack-manuals "Document Nova v2 Cells and Placement API" [Critical,In progress] - Assigned to John Garbutt (johngarbutt) | 13:01 |
| asettle | We've gotta hit the ground running | 13:01 |
| mriedem | johnthetubaguy: bauzas: cdent: sfinucan: i'm not going to be able to run the full meeting this morning, got single parenting before school duties - can one of you pick up running the meeting? | 13:01 |
| asettle | I need as many people as possible to help test: https://review.openstack.org/#/c/438328/ | 13:01 |
| cdent | asettle: i've started a run through of the current doc | 13:01 |
| cdent | mriedem: yeah, I'm sure one of us can get it | 13:01 |
| * asettle sends cdent flowers | 13:01 | |
| nicolasbock | asettle, I'll have a look | 13:02 |
| johnthetubaguy | mriedem: +1 for cdent to take the helm | 13:02 |
| mriedem | heh, i see what you did there | 13:02 |
| asettle | Ugh thank you! I'm on it as well. Starting completely fresh. | 13:02 |
| asettle | Really appreciate it cdent and nicolasbock :) | 13:02 |
| *** jpena|lunch is now known as jpena | 13:02 | |
| * cdent shakes tiny fist at johnthetubaguy | 13:02 | |
| mriedem | the nova meeting agenda is up to date as of last night, so should be good to go there | 13:03 |
| cdent | but yeah, sure | 13:03 |
| asettle | In theory, the instructions should be right now. But I need to make sure :) | 13:03 |
| * johnthetubaguy smiles at cdent | 13:03 | |
| *** jaosorior is now known as jaosorior_brb | 13:03 | |
| johnthetubaguy | cdent: I am going to try join a TC vision thing thats happening in boston today, somehow | 13:03 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | 13:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | 13:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Only destroy BDMs after successful detach call https://review.openstack.org/440693 | 13:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | 13:05 |
| cdent | johnthetubaguy: good luck with that, remote vision is hard | 13:05 |
| johnthetubaguy | cdent: yeah | 13:06 |
| *** esberglu has joined #openstack-nova | 13:06 | |
| *** youzp has quit IRC | 13:06 | |
| *** yamamoto has quit IRC | 13:07 | |
| bauzas | johnthetubaguy: asettle: saw the ML replies, looks like the problem is related to libvirt so | 13:08 |
| *** sean-k-mooney has joined #openstack-nova | 13:08 | |
| johnthetubaguy | asettle: stupid question, but do we know how the packaging folks tested the packages? | 13:08 |
| *** markus_z has quit IRC | 13:09 | |
| bauzas | mriedem: okay, I can run it | 13:09 |
| johnthetubaguy | asettle: I think I always assumed they would update the install docs based on the release notes and upstream notes, maybe that was never a thing | 13:09 |
| mriedem | bauzas: i think cdent is on the hook | 13:11 |
| cdent | like a fish | 13:11 |
| asettle | johnthetubaguy: 'how' - as in, physically how they test it, or how do we know if they did it? | 13:11 |
| asettle | bauzas: yes, I hope that's all that is. But we still need to test to ensure that. | 13:11 |
| johnthetubaguy | asettle: physically really | 13:11 |
| bauzas | mriedem: cdent: okay, no worries, good with me | 13:12 |
| *** edmondsw has joined #openstack-nova | 13:12 | |
| *** yamamoto has joined #openstack-nova | 13:13 | |
| asettle | johnthetubaguy: that I can't answer. We have people who test it for us. We track the work here: https://wiki.openstack.org/wiki/Documentation/OcataDocTesting | 13:14 |
| asettle | As you can see, we're a bit blocked. | 13:14 |
| johnthetubaguy | asettle: no worries, just missing bits of the loop here | 13:14 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364 | 13:15 |
| openstackgerrit | sahid proposed openstack/nova master: numa: fit instance NUMA node with cpus reserved onto host NUMA node https://review.openstack.org/400875 | 13:15 |
| openstackgerrit | sahid proposed openstack/nova master: virt: update overhead to take into account vCPUs https://review.openstack.org/385024 | 13:15 |
| asettle | Well, we get access to the packages, we then test. Let me poke around and get some holes fixed up for you. I admit entirely I haven't been a part of the install guide process for quite some time. | 13:16 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878 | 13:16 |
| openstackgerrit | sahid proposed openstack/nova master: numa: take into account cpus reserved https://review.openstack.org/400876 | 13:16 |
| openstackgerrit | sahid proposed openstack/nova master: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877 | 13:16 |
| *** yamamoto has quit IRC | 13:16 | |
| johnthetubaguy | asettle: no worries, same here | 13:17 |
| *** yamamoto has joined #openstack-nova | 13:17 | |
| *** yamamoto has quit IRC | 13:21 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | 13:21 |
| openstackgerrit | Dao Cong Tien proposed openstack/nova master: Stop using mox in unit/virt/disk/test_api.py https://review.openstack.org/342061 | 13:24 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200 | 13:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: WIP: Replace target_cell and set_target_cell with context.for_cell() https://review.openstack.org/443627 | 13:24 |
| cdent | asettle: as a mildly irrelevant aside: a) I'm able to follow these docs in general quite well so: awesome!, b) the nova endpoints are being created with tenant_id in them, has the "naw, that's icky" been communicated (to you and others) in any fashion? | 13:24 |
| *** prateek has quit IRC | 13:24 | |
| *** yamamoto has joined #openstack-nova | 13:25 | |
| *** markus_z has joined #openstack-nova | 13:25 | |
| mdbooth | dansmith: If you're alive yet, I starting writing this: https://review.openstack.org/#/c/443627/ | 13:25 |
| asettle | cdent: a) SWISH! Terrific. How are you testing? Greenfields? b) the nova docs have not been updated in a *long* time I'm assuming. Hence, need for liaison blah blah you get it. Tl;DR - no. | 13:25 |
| cdent | :) | 13:26 |
| mdbooth | It's in response to my review comment on https://review.openstack.org/#/c/442685/ | 13:26 |
| cdent | asettle: I'm using some bare vms, ubuntu | 13:26 |
| mdbooth | dansmith: If it's architecturally sound it removes a ton of edge cases and boilerplate | 13:26 |
| mdbooth | melwitt: ^^^ https://review.openstack.org/#/c/443627/ | 13:27 |
| asettle | cdent: okay ubuntu is good. That was one of the ones with an issue. I'm trying to do CentOS (key word: trying - screw netowrking rn) | 13:27 |
| *** salv-orlando has joined #openstack-nova | 13:28 | |
| mdbooth | dansmith melwitt: It's a bunch of donkey work, so I'm going to leave it like that until we validate/invalidate the approach | 13:29 |
| *** kaisers_ has joined #openstack-nova | 13:29 | |
| *** diga has quit IRC | 13:30 | |
| *** cleong has joined #openstack-nova | 13:31 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119 | 13:31 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | 13:33 |
| owalsh | asettle: is there another doc for upgrades, or do we just care about greenfield installs? | 13:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | 13:34 |
| *** kaisers_ has quit IRC | 13:34 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | 13:35 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | 13:36 |
| asettle | owalsh: we only care about greenfields with regards to this doc | 13:36 |
| asettle | (wow, freud, originally wrote 'shit doc' o.o) | 13:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | 13:36 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | 13:38 |
| sean-k-mooney | this is proably a dumb question but if i resize an image it wont loose data will it? assuming it succedded etc | 13:39 |
| sean-k-mooney | sorry not image instance | 13:39 |
| sean-k-mooney | just want to double check before i do it to the dev env i use for dpdk | 13:40 |
| *** ducttape_ has joined #openstack-nova | 13:41 | |
| efried | sean-k-mooney IIRC, resize will detach disks, destroy the instance, create a new instance with the same name and UUID and the new flavor specs, then reattach the same disks. | 13:41 |
| *** karimb has joined #openstack-nova | 13:41 | |
| efried | sean-k-mooney So no, you shouldn't lose data that's on the disks. | 13:41 |
| sean-k-mooney | efried: ok that was what i was hoping you would say. its what i assumed it would do but wanted to double check | 13:42 |
| efried | sean-k-mooney But I could be wrong about all of that ;-) | 13:42 |
| *** Guest41531 has quit IRC | 13:42 | |
| sean-k-mooney | well worst case i recerate my dev enviornment. i dont currently have anything on it that is not pushed to gerrit bar my local.conf | 13:42 |
| efried | I assume resize on a live instance will do a graceful shutdown. | 13:42 |
| *** vladikr has joined #openstack-nova | 13:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 13:43 |
| mriedem | melwitt: Kevin_Zheng: ^ updated that patch | 13:44 |
| sean-k-mooney | well the cloud its on is at max capasity and i have the instance shut down and some spawned another instance and now i cant start it so trying to see if i can startit with less ram instead of deleting other insances which is my next option | 13:44 |
| mriedem | i'll work on a functional test for the recreate today | 13:44 |
| efried | thorst adreznec esberglu Please re-+1 https://review.openstack.org/438598 - had merge conflict all the way up the chain, but this was the only one I had to rebase by hand. (gerrit carries +1s through auto rebases, it seems.) | 13:45 |
| *** liverpooler has quit IRC | 13:45 | |
| efried | sean-k-mooney If only you were running PowerVM ;-) | 13:45 |
| thorst | efried: will do | 13:45 |
| frickler | cdent: regarding "tenant_id in endpoint", is there a document somewhere how it should be upgraded/changed properly? | 13:45 |
| *** liverpooler has joined #openstack-nova | 13:45 | |
| efried | sean-k-mooney Isn't there a memory overcommit in the conf? | 13:46 |
| *** kfarr has joined #openstack-nova | 13:46 | |
| cdent | frickler: yes, probably, but I'm not sure where at the moment, and buried in reviewing these docs. sdague will know (when returns from tc things) | 13:46 |
| sean-k-mooney | efried: im not sure intel it would be trilled with me runing power lol :) | 13:47 |
| efried | sean-k-mooney So you would at worst have to shut down other instances if you're truly out of memory on the host. | 13:47 |
| mriedem | mdbooth: given your comment on the os-migrations patch and the target cell stuff, and corruption, see https://review.openstack.org/443403 | 13:47 |
| sean-k-mooney | libvirt was failing to alloc the memory so ya it was shutdown because i really was out of memory on the host | 13:47 |
| efried | sean-k-mooney I can never keep straight which is which, but one of shelve, pause, or suspend will save an instance in such a way that it's recoverable, but its resources are freed up. | 13:49 |
| bauzas | sfinucan: heh, fun you took it :p | 13:50 |
| bauzas | sfinucan: https://review.openstack.org/#/c/235930/ | 13:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 13:50 |
| sfinucan | bauzas: After 18 months I figured you wouldn't mind :P | 13:50 |
| sfinucan | also, I was trying to get DevStack in Vagrant going (again) | 13:51 |
| *** sridharg has joined #openstack-nova | 13:51 | |
| bauzas | sfinucan: heh, you hit my 18-month acceptance deadline | 13:51 |
| sean-k-mooney | sfinucan: qq. you were doing some struff with adding tags to alias correct? e.g. for pci passthrough? | 13:51 |
| sfinucan | sean-k-mooney: Not me personally, but someone was iirc | 13:52 |
| *** READ10 has joined #openstack-nova | 13:52 | |
| sean-k-mooney | sfinucan: do you know if that ever merged? | 13:53 |
| sfinucan | sean-k-mooney: I don't, I'm afraid. moshele might be a better person to ask | 13:53 |
| sean-k-mooney | im asking for the nic feature spec, jay was suggesting moveing the feautre request for the alias to the flavor extra spec | 13:54 |
| sean-k-mooney | we could move it to the flavor or image mentadata but i was wondering if the device tags would be better but that assumes that work was completed | 13:55 |
| sean-k-mooney | sfinucan: but cool thanks ill take a look and see | 13:55 |
| *** iceyao has joined #openstack-nova | 13:56 | |
| cdent | coreycb (or anyone else): where's the right place to report an apparent bug in the the packaging (specifically the apache config) for placement api? | 13:58 |
| mriedem | cdent: probably ubuntu/nova | 13:58 |
| *** takashin has joined #openstack-nova | 13:58 | |
| cdent | thanks mriedem | 13:58 |
| mriedem | https://bugs.launchpad.net/ubuntu/+source/nova/+bugs ? | 13:59 |
| coreycb | cdent, mriedem, yes that's correct | 13:59 |
| mriedem | i'm not entirely sure, jamespage can probably help too | 13:59 |
| mriedem | \o/ | 13:59 |
| cdent | gold star for mriedem | 13:59 |
| coreycb | :) | 13:59 |
| coreycb | cdent, mind forwarding that along once it's open? | 13:59 |
| cdent | yeah, will do, | 14:00 |
| coreycb | cdent, thanks | 14:00 |
| *** iceyao has quit IRC | 14:00 | |
| *** eharney has joined #openstack-nova | 14:03 | |
| *** yingjun has joined #openstack-nova | 14:05 | |
| *** edleafe_ has joined #openstack-nova | 14:05 | |
| *** udesale has joined #openstack-nova | 14:06 | |
| *** gongysh has quit IRC | 14:08 | |
| *** amotoki has quit IRC | 14:08 | |
| *** gouthamr has joined #openstack-nova | 14:08 | |
| *** efoley has joined #openstack-nova | 14:12 | |
| *** NikhilS has joined #openstack-nova | 14:13 | |
| jaypipes | sean-k-mooney, sfinucan: fancy a hangout to discuss this? | 14:14 |
| sfinucan | jaypipes: The NIC feature spec, you mean? | 14:15 |
| *** zz_dimtruck is now known as dimtruck | 14:15 | |
| *** yingjun has quit IRC | 14:16 | |
| *** nshetty has joined #openstack-nova | 14:16 | |
| *** NikhilS has quit IRC | 14:16 | |
| jaypipes | sfinucan: ya | 14:18 |
| sfinucan | jaypipes: Sure, once the meeting is over | 14:18 |
| jaypipes | sfinucan: because, frankly, it's more than just the NIC features. | 14:18 |
| *** gszasz has quit IRC | 14:19 | |
| *** romainh has joined #openstack-nova | 14:19 | |
| *** ducttape_ has quit IRC | 14:19 | |
| *** yamamoto has quit IRC | 14:23 | |
| *** Kevin_Zheng_Hex has joined #openstack-nova | 14:25 | |
| *** jamesdenton has joined #openstack-nova | 14:27 | |
| *** mriedem has quit IRC | 14:28 | |
| *** bkopilov has joined #openstack-nova | 14:28 | |
| *** nshetty has quit IRC | 14:29 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | 14:31 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | 14:31 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Only destroy BDMs after successful detach call https://review.openstack.org/440693 | 14:31 |
| *** mlavalle has joined #openstack-nova | 14:32 | |
| *** satyar has joined #openstack-nova | 14:34 | |
| sean-k-mooney | jaypipes: sfinucan rodolfo will be tied up for an hour he is presenting in a meeting. but after that sure | 14:34 |
| jaypipes | sean-k-mooney: coolio. | 14:34 |
| sfinucan | sean-k-mooney: (y) | 14:35 |
| *** yuntongjin has joined #openstack-nova | 14:35 | |
| *** links has quit IRC | 14:35 | |
| *** smatzek_ has quit IRC | 14:36 | |
| *** markus_z has quit IRC | 14:37 | |
| *** baoli has joined #openstack-nova | 14:39 | |
| *** Jeffrey4l_ has quit IRC | 14:39 | |
| *** takashin has left #openstack-nova | 14:41 | |
| *** iceyao has joined #openstack-nova | 14:41 | |
| *** jaosorior_brb is now known as jaosorior | 14:43 | |
| *** dimtruck is now known as zz_dimtruck | 14:43 | |
| mdbooth | cdent: Pinging you only because you raised it in the meeting, but fwiw I'm -1 on the patch which implements https://blueprints.launchpad.net/nova/+spec/lvm-thin-pool for 'spec type reasons' | 14:44 |
| mdbooth | There's no spec for me to -1, though | 14:45 |
| gibi | jaypipes: hi! Here is a fix to for the orphaning of the instance.flavor we talked about at the PTG. https://review.openstack.org/#/c/440347/ Could you check it please if you have time? | 14:45 |
| cdent | mdbooth: yeah, I'm not up to date on any of that, was just parroting the agenda | 14:45 |
| *** adrian_otto has joined #openstack-nova | 14:45 | |
| mdbooth | cdent: Figured | 14:45 |
| *** kaisers_ has joined #openstack-nova | 14:45 | |
| mdbooth | mri | 14:46 |
| mdbooth | Bleargh | 14:46 |
| mdbooth | He's not here | 14:46 |
| cdent | he has to parent | 14:46 |
| asettle | johnthetubaguy: in relate to your question earlier about testing packages, there's a bit of info here: https://docs.openstack.org/contributor-guide/release/taskdetail.html | 14:46 |
| asettle | Under "installation tutorial testing" | 14:46 |
| mdbooth | I hate it when that happens | 14:46 |
| asettle | TL;DR - locate pre-release packages for each distribution, and disseminate information about obtaining the packages for testing purposes. | 14:46 |
| * mdbooth would appreciate a second opinion on whether I'm being an arsehole objecting to https://review.openstack.org/#/c/442126/ | 14:47 | |
| *** kevinz has quit IRC | 14:49 | |
| mdbooth | TL;DR thin pools are very similar to sparse volumes. I don't want to support both. Happy to support thin pools, but only if we deprecate sparse volumes, we have a plan to convert sparse volumes to thin pools automatically (so we don't need to support both), and it's painless for the operator. | 14:49 |
| lyarwood | mdbooth: I'll go over it again, did you see my comment a few days ago about the current lvm.conf in F25 defaulting to using thinp with the current lvcreate commands for sparse volumes in Nova | 14:49 |
| mdbooth | lyarwood: I did, yes. | 14:49 |
| *** crushil has joined #openstack-nova | 14:49 | |
| mdbooth | I wonder if there are any implications of mixing them in the same VG. | 14:50 |
| mdbooth | i.e. I created these sparse LVs before that change, and these other LVs after that change, so I have a mix in the same VG. | 14:50 |
| lyarwood | mdbooth: I assume that's fine as they wouldn't change the default otherwise right? | 14:51 |
| mdbooth | lyarwood: Anyway, I don't object to thin pools, only supporting 2 very similar ways to do the same thing. | 14:51 |
| *** Jeffrey4l_ has joined #openstack-nova | 14:51 | |
| mdbooth | lyarwood: Hard data would be nice. | 14:52 |
| lyarwood | yup agreed | 14:52 |
| *** hongbin has joined #openstack-nova | 14:52 | |
| *** markus_z has joined #openstack-nova | 14:53 | |
| cdent | coreycb: that bug https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1671509 | 14:53 |
| openstack | Launchpad bug 1671509 in nova (Ubuntu) "placement api configuration in apache configure CustomLog incorrectly" [Undecided,New] | 14:53 |
| jaypipes | edleafe, cdent: your reviews on https://review.openstack.org/#/c/441544/ would be great. thx in advance! | 14:54 |
| *** nkrinner is now known as nkrinner_afk | 14:54 | |
| cdent | jaypipes: noted! | 14:55 |
| coreycb | cdent, thanks we'll get that fixed up asap | 14:55 |
| edleafe | jaypipes: queued | 14:55 |
| jaypipes | danke | 14:55 |
| *** mriedem has joined #openstack-nova | 14:56 | |
| *** prateek has joined #openstack-nova | 14:56 | |
| *** prateek has quit IRC | 14:57 | |
| *** smatzek_ has joined #openstack-nova | 14:57 | |
| jaypipes | mdbooth: you previously reviewed https://review.openstack.org/#/c/399679/. would be great to have a once over from you on that. | 14:57 |
| *** smatzek_ has quit IRC | 14:57 | |
| mdbooth | jaypipes: Sure. | 14:57 |
| jaypipes | cheers | 14:58 |
| *** smatzek_ has joined #openstack-nova | 14:58 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:58 | |
| asettle | johnthetubaguy: further explanation, package managers test often with automatic setup and that might include updating config files | 14:58 |
| mdbooth | jaypipes: Incidentally, I was looking for validation of this approach for handling RequestContexts for cells: https://review.openstack.org/#/c/443627/ | 14:58 |
| *** eharney has quit IRC | 14:59 | |
| mdbooth | Or invalidation, obviously, which is why I haven't tried to do the whole job yet. | 14:59 |
| jaypipes | mdbooth: k, queued. | 14:59 |
| *** yingjun has joined #openstack-nova | 14:59 | |
| mdbooth | jaypipes: Thanks | 14:59 |
| *** ujjain has joined #openstack-nova | 15:00 | |
| *** ujjain has quit IRC | 15:00 | |
| *** ujjain has joined #openstack-nova | 15:00 | |
| openstackgerrit | Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677 | 15:01 |
| dansmith | mdbooth: I skimmed it briefly | 15:03 |
| dansmith | mdbooth: I think we can go with that approach for things for object contexts, where we iterate over multiple cells | 15:03 |
| dansmith | mdbooth: I don't like it for clearly single-cell-targeted operations on an instance or a host | 15:03 |
| dansmith | mdbooth: because after getting all of this to work, I feel confident we'll have some leaks where we don't realize that we've now got two copies of the context | 15:04 |
| mdbooth | dansmith: Ok. So it's worth adding context.for_cell() and fixing up say get_all() and its users? | 15:04 |
| dansmith | mdbooth: the context _is_ gobal and by reference everywhere | 15:04 |
| dansmith | mdbooth: we get it by reference from the request | 15:04 |
| *** armax has joined #openstack-nova | 15:04 | |
| dansmith | mdbooth: maybe, I also would want to see that change on top of a fully working tempest run of the current stack to prove it doesn't break anything else | 15:05 |
| *** ducttape_ has joined #openstack-nova | 15:05 | |
| jaypipes | sfinucan: so https://review.openstack.org/#/c/399653/is going to require the gate to have libvirt 1.2.9 | 15:05 |
| mdbooth | dansmith: That was another reason I didn't want to go all the way down this rabbit hole. I expect there are a bunch of tricky cases. | 15:06 |
| dansmith | mdbooth: there are a ton | 15:06 |
| mdbooth | dansmith: However, I was hoping that by removing the whole side-effect of changing the global context there might be significantly less | 15:06 |
| dansmith | mdbooth: I think you might be surprised | 15:06 |
| *** thorst is now known as thorst_afk | 15:06 | |
| sfinucan | jaypipes: I thought the point of those tests was to fake out libvirt? | 15:07 |
| mdbooth | dansmith: Ok, I'll limit to get_all() initially and see how it looks. | 15:07 |
| mdbooth | Thanks for looking. | 15:07 |
| jaypipes | sfinucan: see the functional test failure :) | 15:07 |
| cdent | coreycb: I think I've got another one. Is it considered a bug for the service.conf files to have uncommented config settings? | 15:07 |
| *** ekuris has quit IRC | 15:07 | |
| coreycb | cdent, not necessarily. some of the packages set defaults. | 15:08 |
| sfinucan | jaypipes: Well that doesn't look right :D | 15:08 |
| cdent | coreycb: in this case it is that os_region_name in the [placement] section is being set | 15:08 |
| sfinucan | Guess we can mock out that version check too | 15:08 |
| dansmith | mdbooth: fwiw, we already had a discussion about whether or not to fork the context in the objects that are tied to cells and decided on this approach to start | 15:08 |
| dansmith | mdbooth: one thing to remember is that if you send an object over rpc, it resets the context on all the objects in the stack | 15:09 |
| dansmith | mdbooth: so if you make a call over to conductor, for anything like boot or resize, contexts get reset anyway | 15:09 |
| coreycb | cdent, that may not need to be set. we set defaults so that the service will can start after the package is installed. | 15:09 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 15:10 |
| cdent | coreycb: the reason I noticed was because the docs I was testing changed it, i made all those changs at the top of the section, and then realized it was going to conflict with something that's set further below | 15:10 |
| cdent | coreycb: ah, okay, yeah, that makes sense then | 15:10 |
| cdent | it won't start without that | 15:10 |
| cdent | (there's no default) | 15:10 |
| mriedem | dansmith: ftr, i did give you the business, yes | 15:11 |
| mriedem | :) | 15:11 |
| dansmith | mriedem: yeah, I just totally wasn't paying attention when I wrote that :) | 15:11 |
| dansmith | mriedem: see my rev | 15:11 |
| dansmith | ? | 15:12 |
| *** yuntongjin has quit IRC | 15:12 | |
| mriedem | yes | 15:13 |
| mriedem | wait, what? | 15:13 |
| mriedem | oh i see | 15:13 |
| *** hshiina has quit IRC | 15:13 | |
| dansmith | actually, I have to fix target_cell too | 15:13 |
| mriedem | dansmith: you missed on | 15:13 |
| mriedem | *one | 15:13 |
| dansmith | oh no | 15:14 |
| dansmith | it works | 15:14 |
| *** eharney has joined #openstack-nova | 15:14 | |
| mriedem | you missed one in the exception block | 15:14 |
| dansmith | ah yeah | 15:14 |
| dansmith | just a sec | 15:14 |
| *** zz_dimtruck is now known as dimtruck | 15:14 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 15:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Using max api version in notificationt sample test https://review.openstack.org/443686 | 15:14 |
| *** salv-orlando has quit IRC | 15:14 | |
| *** salv-orlando has joined #openstack-nova | 15:15 | |
| *** awaugama has joined #openstack-nova | 15:15 | |
| coreycb | cdent, ok. we're considering loosening the restriction of having to start services by default because it can cause issues particularly with deployment tools. | 15:15 |
| dansmith | mriedem: so we should be able to write a functional test for this that checks the quota in each after delete right? | 15:15 |
| coreycb | cdent, but we haven't done that yet. if we did i think we'd just use the default config files. | 15:15 |
| cdent | coreycb: it's a reasonable thing to do for machines being directly used by humans but not so much in this case :) | 15:16 |
| mriedem | dansmith: yes | 15:16 |
| *** unicell has joined #openstack-nova | 15:16 | |
| mriedem | that's the plan | 15:16 |
| coreycb | cdent, yeah :) | 15:17 |
| mriedem | the tricky thing is going to be, | 15:17 |
| mriedem | we only need one of these fixes for the backport to ocata | 15:17 |
| mriedem | so the functional test won't pass until the top patch in pike | 15:17 |
| mriedem | but it will work for the bottom patch in ocata | 15:17 |
| mriedem | but re-ordering the changes in master doesn't make sense to me | 15:17 |
| dansmith | okay | 15:17 |
| *** unicell1 has quit IRC | 15:17 | |
| mriedem | so i'm thinking maybe the functional test is in a separate patch | 15:18 |
| mriedem | not sure | 15:18 |
| dansmith | yeah | 15:18 |
| *** tbachman has joined #openstack-nova | 15:19 | |
| *** iceyao has quit IRC | 15:19 | |
| *** iceyao has joined #openstack-nova | 15:19 | |
| *** yamahata has joined #openstack-nova | 15:21 | |
| mriedem | so i think the easy thing i can do first is create a functional regression patch that goes at the bottom of the series and recreates the failure, and asserts the error, | 15:22 |
| mriedem | then the fix patches on top of that, | 15:22 |
| mriedem | and the top fix patch changes the functional test to show it working | 15:22 |
| mriedem | that was my plan anyway | 15:22 |
| dansmith | I was just looking at the tests | 15:22 |
| dansmith | give me a few minutes | 15:22 |
| *** sridharg has quit IRC | 15:22 | |
| *** awaugama has quit IRC | 15:22 | |
| dansmith | we don't really have a way to query into the reservation stuff to look, AFAICT, but I think I can hack something in at least to check | 15:23 |
| mriedem | well, | 15:23 |
| mriedem | for a functional test i think this is pretty straightforward, | 15:23 |
| mriedem | we have cell1 and cell0, | 15:23 |
| mdbooth | dansmith: Incidentally, https://review.openstack.org/#/c/443403/ is pretty much what I was talking about with the side-effect thing. | 15:23 |
| mriedem | we disable nova-compute or do something to make scheduling fail, | 15:23 |
| *** yamamoto has joined #openstack-nova | 15:23 | |
| mriedem | create the server and show it goes into ERROR state, | 15:23 |
| dansmith | mdbooth: it's not at all, since this is a problem across multiple requests | 15:23 |
| mriedem | assert we have quota of instances=9 (default-1) | 15:23 |
| mriedem | then delete the instance, | 15:23 |
| mriedem | and assert that quota of instances=10 (but it won't be until the fix) | 15:24 |
| mriedem | it's basically the same recreate steps as in the bug report | 15:24 |
| dansmith | mriedem: I guess I'm lost in the db api on terminology, knowing which things are returning limits and which are calculated by limit and usage | 15:24 |
| *** iceyao has quit IRC | 15:24 | |
| dansmith | mriedem: but yeah, that's what I'm doing | 15:24 |
| mriedem | the functional test just hits the rest api | 15:24 |
| mriedem | like novaclient would | 15:24 |
| *** Kevin_Zheng_Hex has quit IRC | 15:25 | |
| mriedem | i really don't want to be going into the actual databases | 15:25 |
| mriedem | i was going to do this in nova/tests/functional/regressions | 15:25 |
| dansmith | mriedem: well, you're not really validating that exactly what you think is happening really is, but okay | 15:25 |
| dansmith | I'll leave it to you then | 15:26 |
| mriedem | as long as the regression test asserts the failure (the recreate), and the fix has to change the test to show it now passing, i think that's what we care about | 15:26 |
| dansmith | I just want to see them in the wrong database, but okay | 15:27 |
| dansmith | the quota stuff is so opaque to me that I'd want to see that we're out of sync for the reason we think and not one of the other reasons quotas gets out of sync | 15:27 |
| dansmith | but that's fine, you're far more familiar, so go for it | 15:27 |
| *** iceyao has joined #openstack-nova | 15:27 | |
| mriedem | why did you change set_target_cell? | 15:28 |
| mriedem | we're calling target_cell and passing None | 15:28 |
| dansmith | target_cell calls set_target_cell | 15:28 |
| mriedem | gotcha | 15:29 |
| *** iceyao has quit IRC | 15:29 | |
| *** yamamoto has quit IRC | 15:29 | |
| *** iceyao has joined #openstack-nova | 15:30 | |
| *** karimb has quit IRC | 15:31 | |
| johnthetubaguy | mdbooth: I am looking at your comments on migrate_volume_completion | 15:32 |
| mdbooth | johnthetubaguy: I spent half a day or so reading the cinder side code for that, btw | 15:32 |
| johnthetubaguy | mdbooth: I don't feel like I am understanding what that is trying to do, and if it should die/get replaced in this new model | 15:32 |
| mdbooth | I'll never get that back | 15:32 |
| johnthetubaguy | yeah, I did that about 6-8 months ago, and its wondered out my head again | 15:32 |
| *** adrian_otto has quit IRC | 15:32 | |
| mdbooth | johnthetubaguy: I think it needs to continue to exist, because cinder needs to know that the copy is complete so it can cleanup the old volume. | 15:33 |
| johnthetubaguy | mdbooth: yeah, we totally need that bit | 15:34 |
| mdbooth | However, I suspect it could similarly exist in a new form | 15:34 |
| johnthetubaguy | yeah, that | 15:34 |
| mdbooth | johnthetubaguy: It would be great if the new form included a flag for 'we didn't do the copy' | 15:34 |
| *** iceyao has quit IRC | 15:34 | |
| mdbooth | So that in cases where the driver can't do it, eg because the instance is stopped, cinder knows it needs to do it | 15:35 |
| mdbooth | And we don't need to fail the operation | 15:35 |
| *** awaugama has joined #openstack-nova | 15:35 | |
| johnthetubaguy | mdbooth: my problem is how do we know what to do with the attachments, does it alway delete the correct attachment for us? | 15:36 |
| mdbooth | Well cinder will have its own migration record which it hasn't exposed to Nova, which iirc is how it decides which 'mode' it's in | 15:37 |
| mdbooth | Can cinder just work it out? | 15:37 |
| johnthetubaguy | mdbooth: I think it knows, I just wonder if it always does the same thing from our view of the world | 15:37 |
| johnthetubaguy | like it always deletes the correct attachment | 15:37 |
| johnthetubaguy | so we don't need to delete any attachments | 15:38 |
| mdbooth | johnthetubaguy: We say: we're done with the swap volume of att_A to att_b for instance X, and we did the copy | 15:38 |
| mdbooth | That's enough info for cinder in all cases, right? | 15:38 |
| mdbooth | And I don't think we need a return value any more | 15:39 |
| johnthetubaguy | what I mean is, what do we have to do? | 15:39 |
| mdbooth | Because we don't need to do connection_info munging | 15:39 |
| johnthetubaguy | cinder gives us the volume-uuid of the finally attached volume to update in the BDM | 15:39 |
| mdbooth | I think the only thing Nova has to do is callback cinder with ^^^ | 15:39 |
| johnthetubaguy | maybe we just don't delete any attachments | 15:39 |
| *** karimb has joined #openstack-nova | 15:39 | |
| mdbooth | It actually occurred to me that all we really needed to do was delete the attachment | 15:40 |
| mdbooth | the source attachment, that is | 15:40 |
| mdbooth | And that's actually enough info for cinder | 15:40 |
| mdbooth | However, I vastly prefer to be explicit | 15:40 |
| mdbooth | I think we delete the attachment, then make the callback | 15:40 |
| gibi | dansmith, melwitt: Hi! could you please look at the bugfix of the instance.delete regression? https://review.openstack.org/#/c/437222/ | 15:40 |
| johnthetubaguy | Oh, true, cinder could delete the volume if it knows it has to | 15:40 |
| johnthetubaguy | but something nice about migrate being explicit, in case that gets messed up | 15:41 |
| mdbooth | Yeah | 15:41 |
| asettle | jaypipes: thanks for reviewing the doc :) were you able to test or just take a look? | 15:41 |
| johnthetubaguy | mdbooth: I have no idea how this could work with multi-attached volumes?? who does the delete? | 15:41 |
| jaypipes | asettle: lol, just on a hangout with cdent talking about that right now :) | 15:41 |
| jaypipes | asettle: apparently there *is* an openstack-nova-api-placement package... | 15:41 |
| asettle | jaypipes: wow you guys have all the fun don't you :p | 15:41 |
| mdbooth | johnthetubaguy: Whoa, I hadn't even considered that | 15:42 |
| mdbooth | johnthetubaguy: Who does the copy? | 15:42 |
| *** mdnadeem has quit IRC | 15:42 | |
| asettle | jaypipes: oh. so. what's next? | 15:42 |
| *** marst has quit IRC | 15:42 | |
| jaypipes | asettle: well, other than that one comment from me, I think all my other comments were correct ;) | 15:42 |
| *** moshele has quit IRC | 15:42 | |
| *** sree has joined #openstack-nova | 15:42 | |
| johnthetubaguy | mdbooth: everyone? oh dear... yeah. | 15:43 |
| mdbooth | johnthetubaguy: Ok, I think that problem can be solved if we add a 'please do the copy' flag to nova's swap_volume call | 15:43 |
| mdbooth | I think cinder then has enough tools in the box to do this | 15:43 |
| asettle | jaypipes: yeah just reading htem all now | 15:43 |
| mdbooth | Hmm, no, you'd need a quiesce operation too | 15:44 |
| johnthetubaguy | mdbooth: well we would also have to call back with the attachment_ids and not the volume ids right? | 15:44 |
| mdbooth | johnthetubaguy: That case requires a lot of thought | 15:44 |
| mdbooth | All attached instances would have to participate | 15:44 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 15:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | 15:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 15:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | 15:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | 15:45 |
| mdbooth | johnthetubaguy: So attachment_ids are going to make that case simpler, but it's also going to involve coordinating a simultaneous volume switch amongst all attached instances. | 15:45 |
| johnthetubaguy | mdbooth: its assume the user ensures only one is writing, but doesn't tell cinder right now, this is messed up, I think we should just fail this for multi-attach, for the moment at least | 15:45 |
| mdbooth | The latter problem is going to be funky | 15:45 |
| johnthetubaguy | mdbooth: +1 its hard | 15:46 |
| *** mriedem1 has joined #openstack-nova | 15:46 | |
| dansmith | gibi: was that a regression in ocata? | 15:46 |
| gibi | dansmith: yes it was | 15:46 |
| *** mriedem has quit IRC | 15:46 | |
| gibi | dansmith: I will backport it | 15:46 |
| dansmith | mriedem1: so we should rebase the quota fix on this one probably | 15:46 |
| dansmith | because they will conflict | 15:46 |
| mdbooth | johnthetubaguy: Yeah, I think it would be cinder's job to refuse to retype multi-attach volumes until support for that is added. | 15:47 |
| *** kaisers_ has quit IRC | 15:47 | |
| *** sree has quit IRC | 15:47 | |
| mdbooth | Nova shouldn't concern itself, just do the swap, and copy if requested | 15:47 |
| johnthetubaguy | mdbooth: well, Nova can't do the copy either right, when its Nova initiated | 15:48 |
| *** tbachman has quit IRC | 15:49 | |
| mdbooth | I mean, Nova gets an api call with (att_A, att_b, do_copy=True) | 15:49 |
| mdbooth | That call may come direct from a user, or from cinder which has a migration record | 15:49 |
| *** tbachman has joined #openstack-nova | 15:49 | |
| *** marst has joined #openstack-nova | 15:49 | |
| mdbooth | Either way, Nova's behaviour is the same: | 15:49 |
| mdbooth | Attach to att_b | 15:49 |
| mdbooth | Copy if requested | 15:50 |
| mdbooth | Detach from att_a | 15:50 |
| mdbooth | call cinder with finished(att_a, att_b, instance_x, did_copy=True) | 15:50 |
| dansmith | gibi: question inthere | 15:50 |
| mdbooth | And we update the connection_info to be that for att_b, in all cases | 15:51 |
| *** ducttape_ has quit IRC | 15:51 | |
| dansmith | gibi: unfortunately there's more cleanup in that patch than just is necessary for the backport, AFAICT | 15:51 |
| mdbooth | johnthetubaguy: And we trust the caller not to do anything which is going to cause data corruption | 15:51 |
| dansmith | gibi: I'm kinda conflicted on whether to just do that whole thing vs. two patches, one that is a smaller backport, followed by the cleanup | 15:51 |
| mdbooth | johnthetubaguy: I think instance is redundant in that callback, btw, because it's a property of both attachments | 15:53 |
| *** mriedem1 is now known as mriedem | 15:53 | |
| mriedem | dansmith: which one? | 15:53 |
| mdbooth | It shouldn't be there | 15:53 |
| dansmith | mriedem: https://review.openstack.org/#/c/437222/5 | 15:53 |
| *** sdague has joined #openstack-nova | 15:53 | |
| mriedem | oh yeah i knew about that, just hadn't gone through it yet | 15:53 |
| gibi | dansmith: you mean do the minimal thing first, backport that then do some cleanup in a followup on master? | 15:54 |
| dansmith | gibi: yeah | 15:54 |
| mriedem | smaller backports are much easier and nicer | 15:54 |
| cdent | jaypipes: I had to -1 get_invetory, but it is a very soft -1 | 15:55 |
| mriedem | dansmith: gibi: what's the cleanup? the context manager? | 15:55 |
| dansmith | mriedem: yeah, and the use of it in a few places that aren't affected, AFAICT | 15:56 |
| mriedem | jaypipes: https://review.openstack.org/#/c/442200/ - that's the bottom of the series and you were +2 yesterday | 15:57 |
| gibi | mriedem: I think this is the only place where it wasn't needed to restore original behavior https://review.openstack.org/#/c/437222/1/nova/compute/api.py@1868 | 15:57 |
| gibi | mriedem, dansmith: I can put this ^^ to a separate patch | 15:58 |
| dansmith | gibi: that's PS1 | 15:58 |
| gibi | ups sorry | 15:58 |
| *** rcernin has quit IRC | 15:58 | |
| dansmith | gibi: there are only two places we're missing the notification, | 15:58 |
| dansmith | and two places you convert to the new one, right? | 15:58 |
| *** KeithMnemonic has joined #openstack-nova | 15:58 | |
| jaypipes | mriedem: k, on it. just +2'd https://review.openstack.org/#/c/345138 BTW | 15:59 |
| *** jaosorior has quit IRC | 15:59 | |
| mriedem | ok, haven't reviewed that yet at all | 15:59 |
| dansmith | I have I'll circle back | 15:59 |
| gibi | dansmith: true. I looked at the wrong ps | 15:59 |
| *** raj_singh_ has joined #openstack-nova | 16:00 | |
| gibi | dansmith: I can split the patch | 16:00 |
| dansmith | gibi: I think splitting those up would be good for backport cleanliness if you're cool with it | 16:00 |
| dansmith | gibi: sweet, thanks for finding, fixing :) | 16:00 |
| gibi | dansmith: cool, I will do it | 16:00 |
| *** markus_z has quit IRC | 16:02 | |
| *** dtp has joined #openstack-nova | 16:04 | |
| *** links has joined #openstack-nova | 16:07 | |
| *** jahsis has quit IRC | 16:12 | |
| *** edleafe_ has quit IRC | 16:13 | |
| *** ducttape_ has joined #openstack-nova | 16:15 | |
| *** jaosorior has joined #openstack-nova | 16:19 | |
| *** tbachman has quit IRC | 16:24 | |
| *** yamamoto has joined #openstack-nova | 16:26 | |
| *** nikeshm has joined #openstack-nova | 16:27 | |
| nikeshm | hi | 16:27 |
| nikeshm | i am frequently facing the quota issue in openstack master | 16:28 |
| nikeshm | https://ask.openstack.org/en/question/494/how-to-reset-incorrect-quota-count/ | 16:28 |
| nikeshm | is there any bug reported | 16:28 |
| nikeshm | for this | 16:28 |
| *** yamamoto has quit IRC | 16:30 | |
| *** adrian_otto has joined #openstack-nova | 16:31 | |
| *** andreas_s has quit IRC | 16:32 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | 16:33 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | 16:34 |
| jaypipes | sfinucan, sean-k-mooney: time for a hangout? is rodolfo available? (btw, what's rodolfo's IRC nick?) | 16:35 |
| sfinucan | jaypipes: (y) | 16:35 |
| sfinucan | As for IRC nick - not a clue | 16:36 |
| sean-k-mooney | jaypipes: ralonsoh | 16:37 |
| *** ducttape_ has quit IRC | 16:37 | |
| sean-k-mooney | and ya im free ill ask him | 16:37 |
| jaypipes | cool. | 16:37 |
| ralonsoh | jaypipes, sean-k-mooney: hi, now I'm free | 16:38 |
| *** thorst_afk is now known as thorst | 16:38 | |
| jaypipes | sean-k-mooney, sfinucan, ralonsoh: https://hangouts.google.com/call/qqze37pjs5f4lnatg7owxiaklqe | 16:39 |
| *** efoley_ has joined #openstack-nova | 16:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for bug 1670627 https://review.openstack.org/443745 | 16:41 |
| openstack | bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] https://launchpad.net/bugs/1670627 - Assigned to Dan Smith (danms) | 16:41 |
| mriedem | dansmith: melwitt: Kevin_Zheng: ^ this is the regression test i was thinking of | 16:41 |
| *** yassine has quit IRC | 16:42 | |
| dansmith | mriedem: ack, and it works? | 16:42 |
| *** abalutoiu_ has joined #openstack-nova | 16:42 | |
| mriedem | it passes | 16:42 |
| mriedem | i'm going to rebase the fixes on top of it | 16:43 |
| dansmith | it passes on master? | 16:43 |
| *** sudipto has quit IRC | 16:44 | |
| dansmith | oh, I see it validates the broken behavior currently | 16:44 |
| *** efoley has quit IRC | 16:44 | |
| *** karimb has quit IRC | 16:45 | |
| *** abalutoiu has quit IRC | 16:45 | |
| mriedem | right, that's generally how these types of tests work, | 16:47 |
| mriedem | we write the recreate scenario, | 16:47 |
| *** sandanar has quit IRC | 16:47 | |
| mriedem | then roll the fix on top and change the assertion in the test when it's fixed | 16:47 |
| *** psachin has quit IRC | 16:48 | |
| mriedem | ok, first victim is context.db_connection == None blows up the CellDatabases fixture | 16:49 |
| *** udesale has quit IRC | 16:49 | |
| dansmith | mriedem: yeah you'll have to make the change there since that fixture replaces target_cell | 16:50 |
| *** kaisers_ has joined #openstack-nova | 16:50 | |
| nikeshm | smcginnis: https://bugs.launchpad.net/nova/+bug/1670627 :) | 16:51 |
| openstack | Launchpad bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] - Assigned to Dan Smith (danms) | 16:51 |
| dansmith | mriedem: if it's None, just yield without calling real_target_cell | 16:51 |
| dansmith | mriedem: but inside the lock | 16:51 |
| mriedem | i was just going to use self._default_ctxt_mgr | 16:52 |
| dansmith | not sure what you mean | 16:52 |
| *** abalutoiu_ has quit IRC | 16:53 | |
| dansmith | mriedem: before this, you need to yield if cell_mapping is None and then return https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L402-L402 | 16:53 |
| mriedem | sec | 16:53 |
| mriedem | here it comes | 16:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395 | 16:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for bug 1670627 https://review.openstack.org/443745 | 16:55 |
| openstack | bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] https://launchpad.net/bugs/1670627 - Assigned to Dan Smith (danms) | 16:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 16:55 |
| *** browne has joined #openstack-nova | 16:55 | |
| *** kaisers_ has quit IRC | 16:55 | |
| *** efoley__ has joined #openstack-nova | 16:56 | |
| dansmith | mriedem: I'd prefer you didn't do that, | 16:56 |
| *** jamesden_ has joined #openstack-nova | 16:56 | |
| *** annegentle has joined #openstack-nova | 16:56 | |
| mriedem | i'm fine changing it | 16:56 |
| dansmith | mriedem: not only because it ends up mutating the context unlike the real live scenario, but it also is database-specific, so when my mq one rolls around, it will target the mq but not the db | 16:56 |
| *** lucasxu has joined #openstack-nova | 16:57 | |
| *** jamesdenton has quit IRC | 16:58 | |
| mriedem | hmm, so that makes the test fail | 16:58 |
| *** jamesden_ has quit IRC | 16:58 | |
| *** raunak has joined #openstack-nova | 16:58 | |
| *** efoley_ has quit IRC | 16:59 | |
| *** lpetrut has quit IRC | 17:01 | |
| mriedem | dansmith: wouldn't the default context be pointing at the main cell db? | 17:01 |
| mriedem | which is what we want when we create the reservation | 17:02 |
| dansmith | mriedem: it points at the one that was default=true, but in real life you'll end up taking the global one instead of having your cell targeted at the other one | 17:02 |
| dansmith | mriedem: which means it depends on their config, and won't look like it does in real life | 17:02 |
| dansmith | mriedem: so someone will come along and want to assert that db_connection=None there because that is how target_cell works, but it will be different when using the fixture | 17:02 |
| *** gfhellma has joined #openstack-nova | 17:03 | |
| arne_r | Calling attention to https://review.openstack.org/#/c/436868/ which, if passed, would make our CI folks really happy | 17:04 |
| mriedem | dansmith: ok, in the nova/cinder meeting now, you want to tinker with that locally to change it? | 17:04 |
| mriedem | because i'm a bit lost in that fixture | 17:04 |
| dansmith | mriedem: sure | 17:04 |
| dansmith | it's complicated | 17:05 |
| dansmith | mriedem: you said the test failed.. which one did you mean? your regression test should fail yes? | 17:05 |
| mriedem | https://review.openstack.org/443403 is passing | 17:06 |
| mriedem | when i changed to what you wanted in the fixture, it failed | 17:06 |
| mriedem | so to do what you want in the fixture, i need you to take a look at why it's failing | 17:06 |
| dansmith | mriedem: but which test failed, the regression test? | 17:06 |
| mriedem | yes | 17:06 |
| mriedem | i'm just running that one | 17:06 |
| dansmith | oh I see you changed it there, gotcha | 17:07 |
| dansmith | waiting for a py27 run to finish and then I'll pull it down | 17:07 |
| *** lucasxu has quit IRC | 17:08 | |
| *** markvoelker has joined #openstack-nova | 17:08 | |
| mriedem | py27 for something else right? | 17:08 |
| dansmith | yes | 17:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: fix missing instance.delete notification https://review.openstack.org/437222 | 17:11 |
| *** mvk has quit IRC | 17:12 | |
| *** hieulq has quit IRC | 17:12 | |
| mriedem | ok, once i'm done with this meeting i'll fix up the unit tests on the middle patch | 17:12 |
| *** Madasi has joined #openstack-nova | 17:14 | |
| *** raj_singh_ has quit IRC | 17:14 | |
| *** tbachman has joined #openstack-nova | 17:15 | |
| *** hieulq has joined #openstack-nova | 17:15 | |
| *** arne_r has quit IRC | 17:16 | |
| *** yingjun has quit IRC | 17:16 | |
| *** lucasxu has joined #openstack-nova | 17:17 | |
| *** lucasxu has quit IRC | 17:17 | |
| *** nic has joined #openstack-nova | 17:17 | |
| dansmith | mriedem: actually, I changed my mind, this is okay | 17:18 |
| dansmith | I'm not sure it's as obvious, but it's less fiddling, and the context still looks like it should because we call real_target_cell anyway | 17:19 |
| dansmith | mriedem: for completeness let me show you what I was thinking: | 17:19 |
| dansmith | mriedem: http://pastebin.com/raw/isCJMvhG | 17:19 |
| dansmith | mriedem: that works, but it may be more confusing for other people | 17:20 |
| dansmith | if you agree, then just stick with what you've got | 17:20 |
| mriedem | "controllering"? | 17:20 |
| dansmith | http://pastebin.com/raw/pNv5smz8 | 17:20 |
| mriedem | i disagree with that | 17:20 |
| dansmith | is what it looks like applied | 17:20 |
| dansmith | hah I just saw that | 17:21 |
| *** annegentle has quit IRC | 17:21 | |
| dansmith | unintentional, but sounds like me | 17:21 |
| *** romainh has quit IRC | 17:21 | |
| *** lpetrut has joined #openstack-nova | 17:21 | |
| mriedem | so, your change, it's basically just a pass through to the real unwrapped thing, right? | 17:22 |
| dansmith | skipping the global db state switch, yeah | 17:22 |
| mriedem | ok i think it makes sense to me, enough ayway | 17:22 |
| mriedem | *anyway | 17:22 |
| dansmith | yours does the switch, but .. to the main one | 17:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | 17:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764 | 17:23 |
| mriedem | ok i'll just take your change and update my local copy | 17:24 |
| gibi | mriedem, dansmith: I splitted the instance.delete bugfix patch as we discussed https://review.openstack.org/#/c/437222 | 17:24 |
| *** moshele has joined #openstack-nova | 17:24 | |
| dansmith | mriedem: totally your call | 17:24 |
| gibi | mriedem, dansmith: but I have to run now. thanks for the reviews! | 17:25 |
| dansmith | gibi: I was going to suggest that first patch not adding/using the contextmanager | 17:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396 | 17:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 17:25 |
| dansmith | gibi: but if it's not going to cause conflicts, it's not as much of a problem I guess | 17:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 17:25 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | 17:25 |
| *** sapcc-bot2 has joined #openstack-nova | 17:25 | |
| *** lpetrut has quit IRC | 17:25 | |
| *** sapcc-bot has quit IRC | 17:25 | |
| gibi | dansmith: it didn't caused conflict a couple of days ago when I cherry-picked the patch to stable/ocata | 17:26 |
| *** yamamoto has joined #openstack-nova | 17:26 | |
| dansmith | gibi: not now for sure, I just mean in terms of backporting less code. the context manager add is more code, but it's contained | 17:26 |
| dansmith | gibi: if mriedem is cool with it then it's fine | 17:26 |
| gibi | dansmith: here is the cherry-pick https://review.openstack.org/#/c/441171/ I will update that as well | 17:26 |
| gibi | dansmith: ahh I see | 17:27 |
| gibi | dansmith: I agree that the ctx manager is quite self contained solution | 17:27 |
| dansmith | gibi: anyway, I'll look at this in a few, thanks! | 17:27 |
| gibi | dansmith: thanks a lot! | 17:27 |
| * gibi runs away | 17:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix formatting of network options https://review.openstack.org/443086 | 17:28 |
| mriedem | catch him! | 17:28 |
| *** jaosorior has quit IRC | 17:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network https://review.openstack.org/431023 | 17:29 |
| *** unicell has quit IRC | 17:29 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add spec to use cinder's new attachment API https://review.openstack.org/373203 | 17:30 |
| *** yamamoto has quit IRC | 17:32 | |
| *** mtanino has joined #openstack-nova | 17:32 | |
| *** nikeshm has quit IRC | 17:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 17:34 |
| *** ducttape_ has joined #openstack-nova | 17:37 | |
| *** ducttape_ has quit IRC | 17:38 | |
| *** ducttape_ has joined #openstack-nova | 17:38 | |
| *** kfarr has quit IRC | 17:40 | |
| *** ssurana has joined #openstack-nova | 17:41 | |
| *** snecklifter has joined #openstack-nova | 17:41 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | 17:41 |
| *** tesseract has quit IRC | 17:42 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Spec to add per instance timeout for LM https://review.openstack.org/442809 | 17:43 |
| openstackgerrit | Feodor Tersin proposed openstack/nova master: Give names to volumes during block device mapping https://review.openstack.org/213433 | 17:44 |
| *** lucasagomes is now known as lucas-afk | 17:45 | |
| *** mvk has joined #openstack-nova | 17:47 | |
| *** derekh has quit IRC | 17:47 | |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 17:47 |
| *** KeithMnemonic has quit IRC | 17:47 | |
| *** ducttape_ has quit IRC | 17:49 | |
| *** browne has quit IRC | 17:50 | |
| dansmith | mriedem: I'm going to pull down gibi's patch and fix a test comment of mine | 17:50 |
| dansmith | mriedem: are you cool with the heavier context manager approach for the backport or do you want to do the simplest thing, which is just call the normal methods in the places where we're not? | 17:51 |
| dansmith | I think his approach here ends up getting us a begin/end notification that we wouldn't get otherwise | 17:51 |
| dansmith | which is probably good, it's just .. more code | 17:52 |
| *** moshele has quit IRC | 17:54 | |
| *** slaweq_ has quit IRC | 17:54 | |
| *** moshele has joined #openstack-nova | 17:55 | |
| *** kaisers_ has joined #openstack-nova | 17:56 | |
| *** lpetrut has joined #openstack-nova | 17:56 | |
| *** lucasxu has joined #openstack-nova | 17:58 | |
| *** cdent has quit IRC | 17:58 | |
| mriedem | if it's not making the backport a mess i'm fine with it | 17:59 |
| *** kaisers_ has quit IRC | 17:59 | |
| mriedem | i haven't dug in in detail | 17:59 |
| *** kaisers_ has joined #openstack-nova | 17:59 | |
| *** moshele has quit IRC | 18:00 | |
| *** ralonsoh has quit IRC | 18:01 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Fix missing instance.delete notification https://review.openstack.org/437222 | 18:03 |
| *** kaisers_ has quit IRC | 18:03 | |
| dansmith | I also sneakily capitalized the first letter of the commit message because .. I hate that. | 18:03 |
| *** cdent has joined #openstack-nova | 18:04 | |
| *** links has quit IRC | 18:04 | |
| edleafe | rfolco: A could of nits on https://review.openstack.org/416669, but one serious issue | 18:05 |
| *** adrian_otto has quit IRC | 18:05 | |
| *** jpena is now known as jpena|off | 18:06 | |
| rfolco | edleafe, ack | 18:07 |
| mriedem | dansmith: but not period at the end? | 18:10 |
| mriedem | *no | 18:10 |
| dansmith | no I hate theperiod | 18:10 |
| mriedem | I like pizza. I also like cookies. | 18:10 |
| dansmith | heh | 18:10 |
| *** ltomasbo is now known as ltomasbo|away | 18:11 | |
| * dansmith reminds himself to never say something to mriedem he doesn't want recalled years later | 18:11 | |
| *** efoley__ has quit IRC | 18:12 | |
| *** abalutoiu_ has joined #openstack-nova | 18:12 | |
| *** jamesdenton has joined #openstack-nova | 18:13 | |
| openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | 18:14 |
| *** unicell has joined #openstack-nova | 18:15 | |
| *** zioproto has quit IRC | 18:21 | |
| *** Apoorva has joined #openstack-nova | 18:25 | |
| *** yamamoto has joined #openstack-nova | 18:28 | |
| *** amoralej is now known as amoralej|off | 18:31 | |
| *** yamamoto has quit IRC | 18:33 | |
| *** browne has joined #openstack-nova | 18:36 | |
| mdbooth | ... when you realise you created dicts called host_cell_mapping_mapping and cell_mapping_host_mapping | 18:36 |
| *** armax has quit IRC | 18:38 | |
| cburgess | OMG | 18:40 |
| cburgess | You should be taken out back and flogged for that. | 18:40 |
| mdbooth | cburgess: Done ;) | 18:40 |
| efried | mdbooth Clearly the former is mapping the mappings of hosts to cells, and the latter is mapping the .... sh!t, I got nothing. | 18:40 |
| mdbooth | hosts to cell mappings, and cell mappings to hosts | 18:41 |
| mdbooth | It made sense when I wrote it | 18:41 |
| cburgess | Where you are a ballmer peak when you wrote that? | 18:41 |
| *** yamahata has quit IRC | 18:42 | |
| *** karimb has joined #openstack-nova | 18:42 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Only destroy BDMs after successful detach call https://review.openstack.org/440693 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 18:43 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Use detach_volume during default rebuild https://review.openstack.org/443932 | 18:43 |
| *** dharinic is now known as dharinic|lunch | 18:43 | |
| *** ducttape_ has joined #openstack-nova | 18:50 | |
| *** fragatina has joined #openstack-nova | 18:50 | |
| *** fragatina has quit IRC | 18:50 | |
| *** fragatina has joined #openstack-nova | 18:51 | |
| *** sambetts is now known as sambetts|afk | 18:52 | |
| *** adrian_otto has joined #openstack-nova | 18:55 | |
| *** ducttape_ has quit IRC | 18:55 | |
| *** slaweq_ has joined #openstack-nova | 18:56 | |
| *** dtp has quit IRC | 18:57 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903 | 18:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902 | 18:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901 | 18:57 |
| oomichi | mriedem: sdague: is nova-network deprecated already? I guess so, but I cannot find clear doc on nova repo | 19:01 |
| *** giri has joined #openstack-nova | 19:02 | |
| mriedem | oomichi: since newton | 19:02 |
| mriedem | oomichi: the config options, release notes, starting the service, etc etc | 19:03 |
| *** kfarr has joined #openstack-nova | 19:03 | |
| mriedem | the official manuals probably don't say anything about it | 19:03 |
| oomichi | mriedem: thanks, I got it. reno is good for me | 19:03 |
| mriedem | asettle: so https://docs.openstack.org/admin-guide/compute-networking-nova.html | 19:05 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544 | 19:05 |
| jaypipes | cdent: fixed up per your review ^^ dansmith, you were already +2 on it :) | 19:05 |
| mriedem | asettle: nova-network has been deprecated since newton, and in ocata we made it such that you can only run nova-network in a cells v1 configuration (which is not recommended for new deployments either) | 19:05 |
| mriedem | asettle: i guess we need a big fat warning in that page now right? | 19:05 |
| cdent | thank you jaypipes, I felt meh about dissing dansmith's +2, but seemed better to get it now instead of later | 19:06 |
| jaypipes | no worries, those were good comments, cdent. | 19:06 |
| cdent | i'm in review mode at the moment, so should get back round to the new version shortly | 19:06 |
| * mdbooth has been trying to fix a unit test for about an hour, only to realise it's a bug in the code | 19:09 | |
| cdent | that means you win mdbooth | 19:09 |
| mdbooth | It's a mechanical change. I just added an additional assert and I couldn't see why the hell it didn't still work. | 19:10 |
| mdbooth | dansmith: Is it possible to migrate an instance between cells? Excepting, of course that the answer's no because there's only 1 cell. | 19:12 |
| dansmith | mdbooth: eventually, but not currently | 19:12 |
| *** david-lyle has quit IRC | 19:14 | |
| *** giri has quit IRC | 19:15 | |
| mdbooth | external_instance_event() associates a migrating instance with both its hosts. It then assumes that all instances it associated with a particular host have the same cell_mapping. However, if an instance were migrating to a new cell, it would be listed against the destination host, but have a different cell mapping to all other instances in that list. | 19:16 |
| *** armax has joined #openstack-nova | 19:16 | |
| dansmith | mdbooth: https://review.openstack.org/#/c/438025/7 | 19:18 |
| *** annegentle has joined #openstack-nova | 19:18 | |
| mdbooth | dansmith: Sure. The assumption in this code is kinda obtuse though (I stared at it for an hour without noticing it). It'll break when you eventually allow that, and it won't be at all obvious that it needs to be fixed. | 19:19 |
| mdbooth | dansmith: I wonder if it's worth addressing while it's in mind. | 19:20 |
| dansmith | mdbooth: the context in the instance doesn't have anything to do with where the rpc call will go | 19:20 |
| dansmith | and on the other side of the call, the context is reset to what was used for the rpc call | 19:21 |
| *** jackie-truong has joined #openstack-nova | 19:21 | |
| *** Prophidys has quit IRC | 19:21 | |
| *** Prophidys has joined #openstack-nova | 19:22 | |
| mdbooth | dansmith: In this case the cell_mapping comes from a weird mappings dict passed in | 19:22 |
| *** salv-orl_ has joined #openstack-nova | 19:22 | |
| mdbooth | The bug is that if the first instance in the host list is actually from the wrong cell, it'll use the wrong cell context | 19:23 |
| *** satyar has quit IRC | 19:23 | |
| cdent | jaypipes: are we decided that step_size of 1 is okay on the ironic inventory because the modulo math comes out right in that (special) case? | 19:23 |
| jaypipes | cdent: I think so | 19:23 |
| cdent | cool, just checking | 19:23 |
| openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | 19:24 |
| mdbooth | dansmith: NM. I have to shoot, but I'm going to leave this open and look at it again first thing in the morning. | 19:25 |
| dansmith | mdbooth: okay I see what you mean, but I don't think that's right.. the instancemapping will point to the hostmapping where its record currently resides | 19:25 |
| dansmith | mdbooth: then we add in the other destination, | 19:25 |
| *** salv-orlando has quit IRC | 19:25 | |
| dansmith | but the instance gets added to a host list based on instance.host, which matches hostmapping, and thus the cell | 19:25 |
| mdbooth | dansmith: That's the bug, btw | 19:25 |
| mdbooth | instance is added to host list based on _get_relevant_hosts | 19:26 |
| mdbooth | So a migrating instance will be in *2* host lists, one of which it's not actually on | 19:26 |
| mdbooth | If the first entry in the list just happened to be a migrating instance which wasn't actually on this host | 19:26 |
| *** sdague has quit IRC | 19:26 | |
| mdbooth | We'd use its cell_mapping anyway | 19:26 |
| dansmith | ah, this is actually what you mean: | 19:27 |
| mdbooth | That's ok as long as we're not migrating between cells | 19:27 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4082 | 19:27 |
| mdbooth | But it's seriously obtuse | 19:27 |
| dansmith | yeah, I see now | 19:27 |
| dansmith | I was looking at the api side | 19:27 |
| mdbooth | dansmith: Yeah, that. | 19:27 |
| * mdbooth should have linked the ode | 19:27 | |
| dansmith | we should just pass the mapping in from the api side instead of inferring it late there | 19:28 |
| dansmith | my NOTE was probably really "be lazy and don't add a new parameter" | 19:28 |
| *** sdague has joined #openstack-nova | 19:28 | |
| mdbooth | dansmith: As I say, I'll leave it open and poke at it in the morning | 19:29 |
| dansmith | alright | 19:29 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903 | 19:30 |
| *** yamamoto has joined #openstack-nova | 19:30 | |
| *** sneti_ has joined #openstack-nova | 19:33 | |
| mriedem | gah, mocking out a context manager and asserting calls on the mock is not fun | 19:33 |
| *** yamamoto has quit IRC | 19:35 | |
| mriedem | docs bug if someone wants it https://bugs.launchpad.net/openstack-manuals/+bug/1671615 | 19:36 |
| openstack | Launchpad bug 1671615 in openstack-manuals "Networking with nova-network in Administrator Guide" [Undecided,New] | 19:36 |
| *** dharinic|lunch is now known as dharinic | 19:36 | |
| *** salv-orl_ has quit IRC | 19:37 | |
| dansmith | mriedem: so this is my patch series to make the discovery faster: https://review.openstack.org/#/c/427903/ | 19:37 |
| dansmith | maybe should have a specless blueprint? | 19:37 |
| mriedem | yeah probably | 19:37 |
| *** gfhellma has quit IRC | 19:38 | |
| mriedem | mdbooth: dansmith: got any tricks for asserting calls on a context manager method? | 19:38 |
| *** salv-orlando has joined #openstack-nova | 19:38 | |
| mriedem | like, i want to use mock.assert_has_calls, | 19:38 |
| mriedem | on just the args to the method, | 19:38 |
| mriedem | but the context manager enter/exit stuff messes that up | 19:38 |
| dansmith | mriedem: mock it with a side effect that is a context manager | 19:38 |
| dansmith | there's some other way to mock just __enter__ but it's always obscure so I don't do it | 19:39 |
| dansmith | mriedem: I have been meaning to switch the way that fixture works a bit so we can more easily mock the non-context-manager set_target_cell in the tests | 19:39 |
| efried | __enter__ can be mock.patched like anything else, neh? | 19:39 |
| mriedem | yes, the problem is i don't need to mock __enter__ and __exit__ | 19:40 |
| mriedem | the problem is, | 19:40 |
| mriedem | assert_has_calls things i have 3 more calls than i actually care about | 19:40 |
| dansmith | yeah | 19:40 |
| dansmith | it's ugly | 19:40 |
| dansmith | I made it work one time, | 19:40 |
| dansmith | and then undid it | 19:40 |
| mriedem | maybe i can just use mock.method_calls | 19:41 |
| *** crusio has quit IRC | 19:41 | |
| mriedem | which doesn't include magic methods | 19:41 |
| *** crusio has joined #openstack-nova | 19:41 | |
| asettle | Sorry mriedem was off for the evening (I'm UK based), but basically, yes :) big fat warning. | 19:42 |
| asettle | "This is deprecated as of Ocata" type thing | 19:42 |
| asettle | Thanks for noticing that! | 19:42 |
| efried | mriedem https://github.com/powervm/pypowervm/blob/develop/pypowervm/tests/tasks/test_storage.py#L93-L99 | 19:43 |
| asettle | cdent and jaypipes - how did you both get on? | 19:43 |
| efried | mriedem Or perhaps https://github.com/powervm/pypowervm/blob/develop/pypowervm/tests/tasks/test_storage.py#L355-L363 is closer to what you want. | 19:43 |
| jaypipes | asettle: was there an updated revision pushed? I didn't see one? | 19:44 |
| asettle | jaypipes: nope. sorry, that's not what I meant. Just checking in to see if you or cdent had other thoughts/concerns since we last spoke | 19:44 |
| mriedem | efried: that's a bit ugly imo | 19:44 |
| asettle | I see your comments on patch 8 | 19:44 |
| asettle | Thank you :) | 19:44 |
| mriedem | the .__enter__.return_value | 19:44 |
| cdent | asettle: i put more comments on the review, but basically I was able to confirmation that the placement parts are okay | 19:44 |
| *** karimb has quit IRC | 19:45 | |
| efried | mriedem Would it be less ugly if __enter__ wasn't a double-underscore method? | 19:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903 | 19:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902 | 19:45 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901 | 19:45 |
| asettle | Terrific! Ugh thank you so much cdent :D | 19:45 |
| jaypipes | asettle: nope, besides those suggestions I put on the initial review, I'm good! :) | 19:45 |
| *** READ10 has quit IRC | 19:47 | |
| asettle | Ugh you guys are excellent :D thank you both and to mriedem for looking at this all week :) Crossing my fingers that some of these edits should set us on the right path for both RDO and Ubuntu | 19:47 |
| asettle | I'll check back in with Brian in the morning. | 19:47 |
| *** karimb has joined #openstack-nova | 19:48 | |
| openstackgerrit | christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951 | 19:50 |
| *** ducttape_ has joined #openstack-nova | 19:51 | |
| *** adrian_otto1 has joined #openstack-nova | 19:52 | |
| *** david-lyle has joined #openstack-nova | 19:53 | |
| *** ducttape_ has quit IRC | 19:56 | |
| *** adrian_otto has quit IRC | 19:56 | |
| mriedem | guh | 20:00 |
| mriedem | annoying when you have the fix for a thing all day, but spend 2 hours trying to get tests to work | 20:00 |
| mriedem | *unit* tests | 20:00 |
| cdent | mriedem: after all this time you haven't been able to accept that as the new normal? | 20:01 |
| mriedem | sometimes i don't mind, | 20:01 |
| mriedem | i only mind when i have other stuff to be doing | 20:02 |
| *** kaisers_ has joined #openstack-nova | 20:02 | |
| *** mtanino has quit IRC | 20:02 | |
| efried | mriedem Then you have to rebase the thing... | 20:04 |
| mriedem | i do actually have to rebase this | 20:06 |
| mriedem | but want it working first | 20:06 |
| mriedem | i want the *mocks* working first | 20:06 |
| * dansmith hands mriedem pizza and cookies | 20:07 | |
| * melwitt plays "you're the best" montage for mriedem | 20:08 | |
| *** salv-orlando has quit IRC | 20:08 | |
| mriedem | gee thanks everyone | 20:08 |
| mriedem | what i really need is coffee | 20:09 |
| dansmith | mriedem: basically, we all acknowledge your mundane plight, now get back to work | 20:09 |
| mriedem | and metal | 20:09 |
| *** kfarr has quit IRC | 20:09 | |
| mriedem | ha | 20:09 |
| dansmith | :) | 20:09 |
| *** yamahata has joined #openstack-nova | 20:09 | |
| mriedem | i need comstud here to kick me in my ass | 20:10 |
| *** gfhellma has joined #openstack-nova | 20:11 | |
| * dansmith puts on his red foreman costume to kick eric "riedeman" foreman in his ass | 20:11 | |
| efried | I could put you in an armbar, but that would be counterproductive to your typing abilities. | 20:11 |
| melwitt | what's special about comstud kicking you? what about us?? | 20:12 |
| * dansmith points at the boots and makes scardy eyes | 20:12 | |
| dansmith | er, "scaredy" | 20:12 |
| *** kfarr has joined #openstack-nova | 20:15 | |
| *** Anticimex has quit IRC | 20:21 | |
| mriedem | melwitt: because you'd probably apologize afterward | 20:22 |
| mriedem | comstud on the other hand... | 20:22 |
| melwitt | heh | 20:22 |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | 20:26 |
| *** slaweq_ has quit IRC | 20:27 | |
| mriedem | f yes | 20:28 |
| *** dtp has joined #openstack-nova | 20:29 | |
| *** slaweq_ has joined #openstack-nova | 20:29 | |
| *** dtp has quit IRC | 20:30 | |
| *** dave-mccowan has quit IRC | 20:30 | |
| *** dtp has joined #openstack-nova | 20:31 | |
| *** Anticimex has joined #openstack-nova | 20:31 | |
| *** yamamoto has joined #openstack-nova | 20:31 | |
| *** jackie-truong has quit IRC | 20:33 | |
| *** yamamoto has quit IRC | 20:35 | |
| *** raunak has quit IRC | 20:36 | |
| openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/443957 | 20:36 |
| *** tasker has joined #openstack-nova | 20:36 | |
| *** fragatina has quit IRC | 20:36 | |
| tasker | is there a way to "build" a new instance in an un-powered state? | 20:37 |
| *** Anticimex has quit IRC | 20:40 | |
| *** Anticimex has joined #openstack-nova | 20:40 | |
| *** sdague has quit IRC | 20:41 | |
| tasker | b'ah. probably the wrong channel, but I'm trying to do the above programatticaly. | 20:42 |
| dansmith | you're revising that quota set and un-WIPing them all I assume right? | 20:42 |
| *** raunak has joined #openstack-nova | 20:43 | |
| *** xyang1 has joined #openstack-nova | 20:43 | |
| *** sree has joined #openstack-nova | 20:44 | |
| mriedem | dansmith: yeah | 20:44 |
| mriedem | plumber called, more distractoins | 20:44 |
| *** awaugama has quit IRC | 20:46 | |
| efried | tasker That doesn't sound... easy. I can think of some ways to hack it. But I don't think the APIs provide anything. | 20:46 |
| tasker | efried: i was afraid of that. | 20:46 |
| *** dave-mcc_ has joined #openstack-nova | 20:47 | |
| efried | tasker Example: create it with no boot disk, and it (maybe) boots into grub/OF. The nova side will see this as "active", so the spawn will succeed, but the VM didn't _really_ boot. | 20:47 |
| *** sree has quit IRC | 20:48 | |
| tasker | i have an instance with two volumes, one boot, one mounted at /usr. not ideal, but not my instance. i need to be able to, at will, make a backup of the volumes, restore them, and spin up a new copy of the instance. but if the instance boots from 'vda' alone, it'll have problems with no 'vdb' and I can't attach a volume until it's active. | 20:48 |
| tasker | efried: that's not too bad. | 20:49 |
| mriedem | dansmith: like the water in my basement, here comes the flood | 20:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Decrement quota when deleting an instance in cell0 https://review.openstack.org/443395 | 20:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Temporarily untarget context when deleting from cell0 https://review.openstack.org/443403 | 20:49 |
| efried | ...can't attach volume until active, why? | 20:49 |
| tasker | Conflict: Cannot 'attach_volume' while it is in vm_state building | 20:49 |
| mriedem | tasker: i think cburgess is trying to solve a similar issue | 20:50 |
| mriedem | at least with that conflict | 20:50 |
| mriedem | you should join forces | 20:50 |
| tasker | oh? do you have a commit review i can check out? | 20:50 |
| *** ducttape_ has joined #openstack-nova | 20:52 | |
| tasker | I'll checkout gerrit and get send a message their way. | 20:52 |
| mriedem | sec | 20:52 |
| mriedem | i thought this https://review.openstack.org/#/c/417541 | 20:54 |
| mriedem | tasker: see L33 here for PTG discoussion https://etherpad.openstack.org/p/nova-ptg-pike-cinder | 20:54 |
| mriedem | *discussion | 20:54 |
| *** priteau has quit IRC | 20:54 | |
| *** JoseMello has quit IRC | 20:55 | |
| tasker | thanks! I'll check it out. | 20:55 |
| mriedem | dansmith: are you checking those changes out? if they look ok at first glance, i'll start working on rebasing on top of gibi's changes | 20:55 |
| dansmith | I will yeah | 20:55 |
| *** ducttape_ has quit IRC | 20:56 | |
| *** dimtruck is now known as zz_dimtruck | 20:56 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Count resources to check quota for cells https://review.openstack.org/416521 | 20:57 |
| dansmith | gross | 20:58 |
| dansmith | well, I don't like the context mocking | 20:58 |
| dansmith | but I shan't hold up on that | 20:58 |
| *** gjayavelu has joined #openstack-nova | 21:00 | |
| cburgess | mriedem tasker What did I do? | 21:00 |
| *** rfolco has quit IRC | 21:00 | |
| cburgess | mriedem Oh that thing yeah... so thats now part of johnthetubaguy spec on moving to the new cinder attach api | 21:00 |
| *** smatzek_ has quit IRC | 21:01 | |
| *** gfhellma has quit IRC | 21:03 | |
| mriedem | dansmith: for the assertions? | 21:03 |
| dansmith | mriedem: yeah | 21:03 |
| mriedem | or just the 20 context calls? | 21:03 |
| dansmith | the context calls | 21:03 |
| mriedem | oh | 21:03 |
| mriedem | yeah, well, | 21:03 |
| mriedem | see ^ for the last 3 hours :) | 21:03 |
| *** fragatina has joined #openstack-nova | 21:03 | |
| dansmith | heh yeah I know | 21:03 |
| *** eharney has quit IRC | 21:05 | |
| mriedem | dansmith: comments in https://review.openstack.org/#/c/437222/ | 21:05 |
| mriedem | the notification one | 21:05 |
| cburgess | mriedem So https://review.openstack.org/#/c/417541 should be abandoned. I'll have yuming do that shortly. Our work is now covered by johnthetubaguy work in https://review.openstack.org/#/c/373203/ | 21:06 |
| *** gfhellma has joined #openstack-nova | 21:07 | |
| mriedem | cburgess: i can abandon it if you want | 21:07 |
| cburgess | Go ahead | 21:07 |
| cburgess | mriedem Abandon with great abandon. | 21:07 |
| dansmith | mriedem: so in the delete_while_booting, we can't soft delete, so it's always going to be a hard instance-is-gone | 21:07 |
| *** tbachman has quit IRC | 21:08 | |
| dansmith | because we're just deleting the mapping | 21:08 |
| dansmith | well, wait | 21:08 |
| dansmith | yeah, right, | 21:08 |
| dansmith | because if we deleted that, then we're going to end up with no instance record when the conductor realizes that we won | 21:09 |
| *** salv-orlando has joined #openstack-nova | 21:09 | |
| dansmith | L1712 | 21:09 |
| *** zioproto has joined #openstack-nova | 21:09 | |
| *** Jack_I has quit IRC | 21:10 | |
| dansmith | well, wait, | 21:10 |
| mriedem | it seems like we just don't support soft_delete for the case that the instance isn't in a cell yet | 21:11 |
| dansmith | yeah | 21:11 |
| dansmith | right | 21:11 |
| *** gyee has joined #openstack-nova | 21:11 | |
| mriedem | soft_delete is also totally dependent on the compute deleting the instance | 21:11 |
| mriedem | and if it never landed in a cell, there is no compute to clean it up | 21:11 |
| mriedem | seems like a good comment to add in the code as a reminder of that | 21:12 |
| mriedem | we could do that in a follow up, like my ask for a comment about why we avoid the lazy-load in the context manager for sys meta | 21:12 |
| mriedem | cburgess: done, and the bp in lp too | 21:12 |
| *** ujjain has quit IRC | 21:13 | |
| cburgess | cool | 21:13 |
| mriedem | this patch still doesn't have a test to make sure that the soft_delete case is handled when the instance is in cell0 | 21:13 |
| dansmith | mriedem: yeah | 21:13 |
| dansmith | mriedem: I can do that, or you can throw it in while you're stacking your others on top here | 21:13 |
| mriedem | let me think about what i just said, | 21:14 |
| dansmith | yeah, that... | 21:14 |
| dansmith | would be a problem | 21:14 |
| mriedem | if it's in cell0, again, it's we can't soft delete it | 21:14 |
| dansmith | but there's also no resources to clean up | 21:14 |
| mriedem | https://review.openstack.org/#/c/437222/7/nova/compute/api.py@2126 | 21:15 |
| dansmith | that cast is just going to go into the ether | 21:16 |
| dansmith | if you delete it again, it hard deletes right? | 21:16 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: WIP: Replace live migration steps and delays with memory iteration logic https://review.openstack.org/443339 | 21:18 |
| dansmith | mriedem: from the api perspective, what we have _might_ make the most sense | 21:20 |
| dansmith | you soft delete, it stays around half deleted, | 21:20 |
| dansmith | but never gets culled because there is no compute for it | 21:20 |
| dansmith | then you hard delete it to make it go away | 21:20 |
| dansmith | on the other hand, | 21:20 |
| mriedem | you mean force-delete? | 21:21 |
| dansmith | just making it kill the instance immediately if it's in cell0 also makes sense, since there's no reason to keep a dead instance around | 21:21 |
| dansmith | soft-delete being for "oops, I deleted a thing that I wanted to keep" | 21:21 |
| mriedem | i don't think force-delete would fix anytihng here | 21:21 |
| mriedem | but i'm not following the half-deleted case | 21:22 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Spec to add per instance timeout for LM https://review.openstack.org/442809 | 21:22 |
| mriedem | i put some comments in there if you want to read those and reply | 21:22 |
| dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L782-L785 | 21:22 |
| mriedem | basically i think the only issue now is the notification is lying if it says we do a soft-delete but we actually hard-delete in cell0 | 21:22 |
| mriedem | what triggers that InstanceInvalidState though? | 21:23 |
| dansmith | mriedem: lies how? because it doesn't call it a soft delete? | 21:23 |
| openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Add live-migration-force-after-timeout spec https://review.openstack.org/438467 | 21:23 |
| *** liverpooler has quit IRC | 21:23 | |
| mriedem | must_have_launched=True | 21:23 |
| *** tasker has quit IRC | 21:23 | |
| dansmith | mriedem: must_have_launched | 21:23 |
| dansmith | yeah | 21:23 |
| *** aysyd has quit IRC | 21:24 | |
| mriedem | what sets launched_at? compute? | 21:24 |
| mriedem | yup _update_instance_after_spawn | 21:24 |
| dansmith | yeah | 21:24 |
| mriedem | see https://review.openstack.org/#/c/437222/7/nova/compute/api.py@1794 | 21:25 |
| mriedem | for the lie | 21:25 |
| *** jaosorior has joined #openstack-nova | 21:25 | |
| dansmith | oh, calls it a soft delete when it's not | 21:26 |
| mriedem | yeah | 21:26 |
| mriedem | i mean that's very minor | 21:26 |
| mriedem | but i think it's technically wrong | 21:26 |
| dansmith | if we do that, | 21:26 |
| dansmith | hmm | 21:26 |
| *** ujjain has joined #openstack-nova | 21:27 | |
| *** ujjain has quit IRC | 21:27 | |
| *** ujjain has joined #openstack-nova | 21:27 | |
| dansmith | you can get there if you have a non-cell0 cell too right? | 21:27 |
| mriedem | but no host? | 21:27 |
| dansmith | if you race with compute owning the instance | 21:27 |
| dansmith | the instance_mapping has a cell, | 21:27 |
| dansmith | because scheduler decided, | 21:27 |
| dansmith | but compute hasn't instance.host=$me yet | 21:27 |
| mriedem | what sets instance.host in the compute? | 21:29 |
| mriedem | for spawn i mean, i'm not seeing that | 21:29 |
| dansmith | yeah, hang on | 21:29 |
| dansmith | I always have to dig for this I dunno why | 21:30 |
| *** zz_dimtruck is now known as dimtruck | 21:30 | |
| *** tbachman has joined #openstack-nova | 21:30 | |
| melwitt | it's in instance_claim in the RT | 21:31 |
| dansmith | oh, that's probably why | 21:31 |
| mriedem | i figured that gd low down RT was involved | 21:31 |
| dansmith | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L336-L344 | 21:31 |
| melwitt | haha, yeah. it's hidden there, for fun! | 21:32 |
| *** yamamoto has joined #openstack-nova | 21:32 | |
| mriedem | RT is like a leprachaun | 21:32 |
| mriedem | full of tricks | 21:32 |
| *** jaosorior has quit IRC | 21:33 | |
| mriedem | dansmith: ok so back to https://review.openstack.org/#/c/437222/7/nova/compute/api.py@1794 if it's not in cell0 and it doesn't have a host yet, but let's say it's in cell1, | 21:33 |
| mriedem | we still delete the instance | 21:34 |
| mriedem | so i think that just means, when the reclaim task (or whatever it's called) in the compute runs, it just won't see that instance | 21:34 |
| mriedem | and that's fine, it's already gone | 21:34 |
| mriedem | so it was an immediate soft delete :) | 21:34 |
| mriedem | right? | 21:34 |
| *** Jeffrey4l_ has quit IRC | 21:35 | |
| dansmith | unless we got here because instance wasn't created in the database | 21:35 |
| dansmith | but I _think_ that means it's gone-gone too | 21:35 |
| mriedem | which database? | 21:35 |
| mriedem | cell db? | 21:35 |
| *** Jeffrey4l_ has joined #openstack-nova | 21:35 | |
| dansmith | yeah the only place instances get created | 21:36 |
| dansmith | I think we can also fail to delete there if host changes, right? | 21:36 |
| dansmith | we're in a try..except there | 21:36 |
| *** dave-mcc_ has quit IRC | 21:36 | |
| dansmith | and I think that's for the "if host changed" case, | 21:36 |
| dansmith | where we can either fall through or bail | 21:36 |
| dansmith | I think we might be over-obsessing here | 21:37 |
| mriedem | yeah if the host changes we're here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1816 | 21:37 |
| mriedem | and then it falls through to the normal delete path | 21:37 |
| dansmith | I'm not sure whether notifications consumers will do something useful with the soft/hard indication | 21:37 |
| mriedem | i agree this is probably not the end of the world | 21:37 |
| *** yamamoto has quit IRC | 21:38 | |
| dansmith | the missing notifications, and the quota bug behind this are definitely more important | 21:38 |
| dansmith | gibi might have a better handle on how much this does or does not matter | 21:38 |
| melwitt | I was thinking my main concern would be whether the start/end notifications match, and also that they match the request that was issued from the user | 21:39 |
| melwitt | for the first, I saw the context manager makes sure the start/end match | 21:39 |
| dansmith | the context manager makes sure they match I think | 21:39 |
| melwitt | for the last, I guess that's where the delete_type comes in. I was just trying to think, how someone might use this and if they're listening to notifications, they may also be looking at what requests were issued and correlating notifications with those | 21:40 |
| melwitt | to get like a bundle of "what happened" which would be 1) user issued delete_type X 2) nova emitted delete_type X start 3) nova emitted delete_type X end | 21:41 |
| *** krtaylor has quit IRC | 21:42 | |
| *** tbachman has quit IRC | 21:42 | |
| dansmith | I'm not sure what the point of correlating the requests and the notifications really is, but we don't really know what (all) people use these for | 21:42 |
| melwitt | if they're doing log collecting and correlating. anyway, that's the thing I could think of it mattering | 21:42 |
| dansmith | mriedem: I guess my point is, this is demonstrably better than what we have now, I think, especially considering the quota thing behind it | 21:43 |
| *** tbachman has joined #openstack-nova | 21:43 | |
| dansmith | in some very teensy windows of a less-mainstream feature, you might get a delete type you didn't expect | 21:43 |
| melwitt | at my last company, use used the old notification driver that emits notifications to the logs. and we had those in splunk and correlated things like that, to look at when people opened bugs etc | 21:43 |
| melwitt | I think what I'm saying is what the patch is doing, so it makes sense to me to keep everything saying "soft delete" if the user issued "soft delete" | 21:45 |
| *** dave-mccowan has joined #openstack-nova | 21:45 | |
| dansmith | well, it's not in the first case he brought up | 21:45 |
| mriedem | the user doesn't technically request "soft" delete | 21:46 |
| mriedem | it's all driven by config | 21:46 |
| *** kaisers_ has quit IRC | 21:46 | |
| mriedem | it's totally not interoperable | 21:46 |
| melwitt | erg, right. notifications probably have the request-id too right? so that's what anyone would use to correlate anyway | 21:46 |
| dansmith | yeah | 21:47 |
| melwitt | okay, that addresses what I was thinking | 21:47 |
| *** hamzy has quit IRC | 21:48 | |
| mriedem | so i think i might still pull this down, add some comments, and add a test for the soft-delete case where there isn't a host but it's in a cell (any cell) and the build request was already gone | 21:48 |
| mriedem | because i'm pretty sure i'm right here https://review.openstack.org/#/c/437222/7/nova/tests/unit/utils.py | 21:49 |
| mriedem | then i'll rebase my stuff on top of it | 21:49 |
| *** markmcclain has joined #openstack-nova | 21:49 | |
| mriedem | and then it's pants off dance off | 21:49 |
| *** aojea has quit IRC | 21:49 | |
| *** jose-phi_ has joined #openstack-nova | 21:51 | |
| *** gyee has quit IRC | 21:51 | |
| *** ducttape_ has joined #openstack-nova | 21:52 | |
| *** jose-phillips has quit IRC | 21:52 | |
| dansmith | so, wait, | 21:53 |
| dansmith | we notify delete.started..delete.ended in the api, or soft_delete.started..ended, | 21:53 |
| dansmith | and then again in compute in both cases? | 21:53 |
| dansmith | so if you normal delete, you get two delete.started notifications/ | 21:53 |
| dansmith | and if soft delete then you get the soft one first and the regular one later? | 21:53 |
| *** ducttape_ has quit IRC | 21:57 | |
| *** sneti_ has quit IRC | 21:57 | |
| melwitt | the notifys should be limited to the local delete cases, right? | 21:59 |
| melwitt | the new ones, I mean | 21:59 |
| *** crushil has quit IRC | 21:59 | |
| mriedem | melwitt: i think so https://review.openstack.org/#/c/437222/7/nova/compute/api.py@1866 | 21:59 |
| melwitt | so they wouldn't be going on to compute to get a second notify | 21:59 |
| mriedem | right | 22:00 |
| mriedem | and where gibi has made this change, it's a local delete | 22:00 |
| dansmith | not if we fail the last race check, but yeah | 22:00 |
| dansmith | so do we ever emit a soft-delete notification normally? | 22:01 |
| dansmith | meaning before all of this changed.. | 22:02 |
| dansmith | only in the local delete, which is totally not a soft delete, is that the only time we emit soft-deleted.start? | 22:02 |
| *** edmondsw has quit IRC | 22:03 | |
| mriedem | it looks like it... | 22:03 |
| dansmith | how stupid is that? | 22:04 |
| dansmith | the only time we emit soft-deleted is when .. we didn't | 22:04 |
| mriedem | down in _delete_instance in the compute manager, even if it was a soft_delete, we issue instance.delete.start | 22:04 |
| melwitt | I wonder how soft-deleted notify ever came about then. because like you said, there isn't really a soft-delete from the user perspective | 22:06 |
| mriedem | dansmith: that's a good point | 22:06 |
| dansmith | melwitt: right, I can't think of any reason it makes sense to emit soft-deleted | 22:06 |
| dansmith | except maybe in the case where we're deferring it, which we _don't_ notify about | 22:06 |
| *** rfolco has joined #openstack-nova | 22:08 | |
| mriedem | we'll also issue soft_delete.start/end in the case that the instance is shelved_offloaded, because that's another local delete case | 22:08 |
| *** rfolco has quit IRC | 22:08 | |
| dansmith | yeah | 22:08 |
| mriedem | so yeah, seems totally pointless to even distinguish | 22:08 |
| mriedem | since you can't restore it anyway | 22:08 |
| dansmith | we totally cover all the cases where we're not actually soft deleting | 22:08 |
| mriedem | it's mfing gone | 22:08 |
| mriedem | so going to back to https://review.openstack.org/#/c/437222/7/nova/compute/api.py@1792 i don't think we should even pass delete_type there, it's not a soft_delete | 22:09 |
| mriedem | i know we're talking in circles, but you could argue that we should never send soft_delete.start/end | 22:09 |
| dansmith | I think I would be in favor of just never emit soft_delete | 22:09 |
| mriedem | yeah | 22:09 |
| mriedem | for the existing parts that do this, i'd leave that for a separate change | 22:10 |
| dansmith | so for this patch, I say remove that one case where we do, | 22:10 |
| mriedem | yeah | 22:10 |
| dansmith | and then yeah clean up the others | 22:10 |
| mriedem | cool | 22:10 |
| mriedem | hey, high five | 22:10 |
| dansmith | fuck you you -1d my +2, no high five for you | 22:10 |
| dansmith | hmm, that sounded darker and more non-sensical ranty than I meant it to :P | 22:11 |
| * dansmith digs up the rainbows and lollipops link | 22:11 | |
| mriedem | i stand by my -1 | 22:12 |
| *** cleong has quit IRC | 22:13 | |
| *** jose-phi_ has quit IRC | 22:14 | |
| *** jose-phillips has joined #openstack-nova | 22:19 | |
| mriedem | crap | 22:22 |
| mriedem | all 3 speaking sessions at the summit were accepted | 22:22 |
| mriedem | armax: from boot to woot | 22:23 |
| *** gyee has joined #openstack-nova | 22:24 | |
| *** adrian_otto1 has quit IRC | 22:28 | |
| *** ducttape_ has joined #openstack-nova | 22:28 | |
| armax | mriedem: I just saw the emaik | 22:30 |
| armax | 22:30 | |
| *** adrian_otto has joined #openstack-nova | 22:30 | |
| armax | we should probably sit down and talk about it at some point | 22:30 |
| *** slaweq_ has quit IRC | 22:30 | |
| *** lucasxu has quit IRC | 22:31 | |
| *** edmondsw has joined #openstack-nova | 22:33 | |
| mriedem | yeah | 22:34 |
| tonyb | sean-k-mooney: It's all good. As you can see I'm trying to work with you but for the most part I'm learning on my feet. It'd be cool if we had a clear direction on what level of support we have for Windows platforms. Are they for development? or just runtime? I'm treatign win32 vs cygwin much like Ubuntu vs Fedora. Anyway we don't overlap much but we can keep going back and forth on the review | 22:37 |
| *** edmondsw has quit IRC | 22:38 | |
| *** lpetrut has quit IRC | 22:39 | |
| *** thorst has quit IRC | 22:39 | |
| *** karimb has quit IRC | 22:39 | |
| *** catintheroof has joined #openstack-nova | 22:39 | |
| *** gfhellma has quit IRC | 22:40 | |
| *** gfhellma_ has joined #openstack-nova | 22:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix missing instance.delete notification https://review.openstack.org/437222 | 22:40 |
| *** jamielennox is now known as jamielennox|away | 22:42 | |
| *** annegentle has quit IRC | 22:43 | |
| *** sree has joined #openstack-nova | 22:44 | |
| *** jamielennox|away is now known as jamielennox | 22:45 | |
| *** gouthamr has quit IRC | 22:48 | |
| *** gyee has quit IRC | 22:48 | |
| *** sree has quit IRC | 22:48 | |
| *** adrian_otto has quit IRC | 22:49 | |
| *** jamesdenton has quit IRC | 22:51 | |
| *** priteau has joined #openstack-nova | 22:55 | |
| mriedem | great, now the functional test isn't passing after i rebased on top of the notification fix | 22:57 |
| *** simondodsley has quit IRC | 22:57 | |
| *** felipemonteiro_ has quit IRC | 22:58 | |
| *** ducttape_ has quit IRC | 22:59 | |
| *** gyee has joined #openstack-nova | 23:00 | |
| *** iceyao has joined #openstack-nova | 23:00 | |
| *** priteau has quit IRC | 23:00 | |
| *** thorst has joined #openstack-nova | 23:03 | |
| *** yassine has joined #openstack-nova | 23:04 | |
| *** gyee has quit IRC | 23:04 | |
| *** armax has quit IRC | 23:04 | |
| *** ducttape_ has joined #openstack-nova | 23:04 | |
| *** iceyao has quit IRC | 23:05 | |
| *** gyee has joined #openstack-nova | 23:07 | |
| *** thorst has quit IRC | 23:07 | |
| *** gouthamr has joined #openstack-nova | 23:11 | |
| openstackgerrit | Samantha Blanco proposed openstack/nova master: [WIP] Make flavor-rxtx policy more granular https://review.openstack.org/444036 | 23:12 |
| *** diga has joined #openstack-nova | 23:19 | |
| *** baoli has quit IRC | 23:20 | |
| *** baoli has joined #openstack-nova | 23:21 | |
| *** zioproto has quit IRC | 23:21 | |
| *** esberglu has quit IRC | 23:21 | |
| *** baoli has quit IRC | 23:26 | |
| *** dimtruck is now known as zz_dimtruck | 23:28 | |
| mriedem | dansmith: ha | 23:31 |
| mriedem | so, | 23:31 |
| mriedem | the notification patch doesn't have a test that hits notify_about_instance_delete | 23:31 |
| mriedem | but mine on top of it do | 23:31 |
| mriedem | UnboundLocalError: local variable 'system_metadata' referenced before assignment | 23:31 |
| mriedem | fixing | 23:32 |
| *** esberglu has joined #openstack-nova | 23:33 | |
| *** gyee has quit IRC | 23:33 | |
| *** xyang1 has quit IRC | 23:33 | |
| *** yamamoto_ has joined #openstack-nova | 23:35 | |
| efried | mriedem That whole initializing-a-variable-within-a-try-and-then-using-it-in-the-except-or-finally thing... | 23:35 |
| mriedem | efried: i even thought about it when i was looking at it before | 23:35 |
| mriedem | efried: er i mean, it was a test to see if you would have caught and you didn't! | 23:35 |
| efried | mriedem Rat farts! I _did_ review that change set! | 23:36 |
| mriedem | rat farts indeed | 23:37 |
| *** esberglu has quit IRC | 23:37 | |
| *** marst has quit IRC | 23:37 | |
| *** marst has joined #openstack-nova | 23:37 | |
| *** yamamoto_ has quit IRC | 23:40 | |
| *** cdent has quit IRC | 23:41 | |
| *** dave-mccowan has quit IRC | 23:43 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | 23:46 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add identity helper property to CellMapping https://review.openstack.org/444038 | 23:46 |
| *** tblakes has quit IRC | 23:46 | |
| *** kaisers_ has joined #openstack-nova | 23:46 | |
| *** ducttape_ has quit IRC | 23:48 | |
| mriedem | dansmith: i hope you ran pep8 | 23:50 |
| *** kaisers_ has quit IRC | 23:51 | |
| * melwitt is going to have to start saying "rat farts" more | 23:52 | |
| melwitt | pep8 takes forever to run now, like before it even runs flake8. dunno what it's doing | 23:53 |
| *** zz_dimtruck is now known as dimtruck | 23:54 | |
| mriedem | melwitt: you know about: tox -e pep8 -- -HEAD? | 23:55 |
| mriedem | cinder has fast8 | 23:55 |
| mriedem | same thing | 23:55 |
| melwitt | no, what does that do? | 23:55 |
| mriedem | runs only on the changes in the commit | 23:55 |
| mriedem | -HEAD | 23:55 |
| mriedem | danpb wrote that quite a while ago | 23:55 |
| mriedem | https://github.com/openstack/nova/blob/master/tools/flake8wrap.sh#L12 | 23:56 |
| melwitt | oh, hm | 23:56 |
| mriedem | i never run full pep8 on nova anymore | 23:56 |
| melwitt | wow. thanks | 23:56 |
| efried | Second that. | 23:57 |
| *** eglynn has quit IRC | 23:57 | |
| *** ducttape_ has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!