| *** Swami has joined #openstack-nova | 00:00 | |
| *** gouthamr has joined #openstack-nova | 00:02 | |
| *** catintheroof has quit IRC | 00:03 | |
| *** karimb has quit IRC | 00:03 | |
| *** browne has quit IRC | 00:07 | |
| *** ducttape_ has quit IRC | 00:08 | |
| *** baoli has quit IRC | 00:08 | |
| *** yuntongjin has joined #openstack-nova | 00:11 | |
| *** nic has quit IRC | 00:17 | |
| *** yuntongjin has quit IRC | 00:17 | |
| *** annegentle has joined #openstack-nova | 00:18 | |
| *** burgerk_ has quit IRC | 00:18 | |
| *** browne has joined #openstack-nova | 00:19 | |
| *** dimtruck is now known as zz_dimtruck | 00:21 | |
| *** annegentle has quit IRC | 00:23 | |
| *** zz_dimtruck is now known as dimtruck | 00:23 | |
| *** annegentle has joined #openstack-nova | 00:23 | |
| *** ducttape_ has joined #openstack-nova | 00:24 | |
| *** esberglu has joined #openstack-nova | 00:24 | |
| *** dtp has quit IRC | 00:27 | |
| *** tbachman has quit IRC | 00:28 | |
| *** raunak has quit IRC | 00:28 | |
| *** esberglu has quit IRC | 00:29 | |
| *** Sukhdev has quit IRC | 00:31 | |
| *** chyka has quit IRC | 00:31 | |
| *** chyka has joined #openstack-nova | 00:31 | |
| *** hongbin has quit IRC | 00:33 | |
| *** Sukhdev has joined #openstack-nova | 00:35 | |
| *** chyka has quit IRC | 00:36 | |
| *** raunak has joined #openstack-nova | 00:42 | |
| *** raunak has quit IRC | 00:42 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 00:44 |
|---|---|---|
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 00:44 |
| *** rfolco has quit IRC | 00:45 | |
| *** rfolco has joined #openstack-nova | 00:45 | |
| *** raunak has joined #openstack-nova | 00:45 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 00:45 |
| *** rfolco has quit IRC | 00:46 | |
| *** vsaienko has quit IRC | 00:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 00:46 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707 | 00:47 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 00:47 |
| *** annegentle has quit IRC | 00:48 | |
| *** tovin07 has joined #openstack-nova | 00:49 | |
| *** tovin07_ has joined #openstack-nova | 00:49 | |
| *** armax has quit IRC | 00:50 | |
| *** dimtruck is now known as zz_dimtruck | 00:50 | |
| *** hoangcx has joined #openstack-nova | 00:50 | |
| *** zz_dimtruck is now known as dimtruck | 00:50 | |
| *** krtaylor has joined #openstack-nova | 00:51 | |
| *** dave-mcc_ has joined #openstack-nova | 00:51 | |
| *** browne has quit IRC | 00:51 | |
| *** rfolco has joined #openstack-nova | 00:52 | |
| *** rfolco has quit IRC | 00:52 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** phuongnh has joined #openstack-nova | 00:54 | |
| *** hoangcx has quit IRC | 00:54 | |
| *** armax has joined #openstack-nova | 00:56 | |
| alex_xu | gmann: johnthetubaguy if we think 403 is behaviour change. Then this is a behaviour change https://review.openstack.org/#/c/415142/33/nova/api/openstack/compute/servers.py@1230 ? | 00:58 |
| alex_xu | Kevin_Zheng: ^ | 00:58 |
| alex_xu | gmann: johnthetubaguy but expose host and node to the user is kind of bug fix. it isn't same case with all_tenants which is filter we support it public | 00:59 |
| alex_xu | s/bug fix/bug/ | 01:00 |
| *** dimtruck is now known as zz_dimtruck | 01:03 | |
| dansmith | melwitt: this is good again: https://review.openstack.org/#/c/319379/ | 01:05 |
| dansmith | melwitt: I broke it in a very subtle way when fixing johnthetubaguy's comment, but it's good now | 01:05 |
| *** ducttape_ has quit IRC | 01:06 | |
| *** bjolo_ has joined #openstack-nova | 01:06 | |
| *** Apoorva has quit IRC | 01:07 | |
| *** sacharya has joined #openstack-nova | 01:08 | |
| *** edmondsw has joined #openstack-nova | 01:12 | |
| mriedem | did bauzas get the grenade thing figured out? | 01:13 |
| mriedem | dansmith: simple change needed in https://review.openstack.org/#/c/424243/ and then i'm +2 | 01:13 |
| dansmith | mriedem: we're waiting for a run I think | 01:14 |
| *** zz_dimtruck is now known as dimtruck | 01:15 | |
| gmann | alex_xu: | 01:16 |
| gmann | alex_xu: humm, | 01:16 |
| *** shaner has quit IRC | 01:16 | |
| *** edmondsw has quit IRC | 01:17 | |
| *** annegentle has joined #openstack-nova | 01:17 | |
| dansmith | mriedem: | 01:17 |
| dansmith | gah | 01:17 |
| mriedem | _LW _MFER | 01:17 |
| openstackgerrit | Dan Smith proposed openstack/nova: Only warn about hostmappings during ocata upgrade https://review.openstack.org/424243 | 01:18 |
| dansmith | there | 01:18 |
| *** dave-mccowan has joined #openstack-nova | 01:20 | |
| gmann | alex_xu: IMO, that as bug fix makes it valid | 01:21 |
| *** dave-mcc_ has quit IRC | 01:22 | |
| oomichi | alex_xu: Does it mean the patch changes 403 to 400 ? | 01:24 |
| oomichi | alex_xu: we are discussing error status code changes on https://review.openstack.org/#/c/421846 . I am ok to allow error status code changes anyways | 01:26 |
| openstackgerrit | Dan Smith proposed openstack/nova: Only warn about hostmappings during ocata upgrade https://review.openstack.org/424243 | 01:26 |
| *** baoli has joined #openstack-nova | 01:28 | |
| gmann | oomichi: policy change for all_tenant will change 403->200 | 01:29 |
| gmann | oomichi: so its kinnda behavior change | 01:29 |
| gmann | oomichi: and on sort key change it is bug fix (not expose host and node to non admin user) and 200->400 | 01:30 |
| gmann | alex_xu: correct me if am wrong on sort key which used to me 200 now? | 01:31 |
| *** baoli has quit IRC | 01:32 | |
| oomichi | gmann: humm, 200->400 seems against on changing policy: "The following types of changes are generally **not** considered acceptable:" | 01:32 |
| oomichi | "A change such that a request which was successful before now results in an error response" | 01:33 |
| oomichi | if that is not security bug | 01:33 |
| oomichi | gmann: "not expose host and node to non admin user" seems a little bit security thing, which means abstraction doesn't work correctly for non-admin users | 01:34 |
| mriedem | melwitt: this is an easy one https://review.openstack.org/#/c/424243/ | 01:35 |
| oomichi | but I am not sure at this time | 01:35 |
| gmann | oomichi: yea that seems security bug for me too. but johnthetubaguy alex_xu mriedem can give better feedback on this - last paragraph in https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/add-whitelist-for-server-list-filter-sort-parameters.html#proposed-change | 01:37 |
| oomichi | gmann: yeah I see "For the non-admin user, the sort key ‘host’ and ‘node’ will be excluded. Those two columns are about the cloud internal. It can’t be leaked to the end user." | 01:39 |
| *** mingyu has joined #openstack-nova | 01:40 | |
| *** hfu has joined #openstack-nova | 01:40 | |
| oomichi | gmann: if we consider it as security issue, the bug should be fixed on stable branches. But we need different patch for fixing it because it is difficult to backport the whole patches related to the bp | 01:41 |
| gmann | oomichi: hummm | 01:43 |
| *** catintheroof has joined #openstack-nova | 01:44 | |
| *** mingyu has quit IRC | 01:44 | |
| gmann | alex_xu: johnthetubaguy oomichi on policy all_tenant changes, should we first change the spec ? - https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/add-whitelist-for-server-list-filter-sort-parameters.html#rest-api-impact | 01:46 |
| *** Jeffrey4l_ has quit IRC | 01:49 | |
| *** gongysh has joined #openstack-nova | 01:49 | |
| *** catintheroof has quit IRC | 01:49 | |
| *** Jeffrey4l has joined #openstack-nova | 01:49 | |
| *** erlon has quit IRC | 01:50 | |
| *** ejat has quit IRC | 01:51 | |
| *** ejat has joined #openstack-nova | 01:51 | |
| *** ejat has joined #openstack-nova | 01:51 | |
| *** raunak has quit IRC | 01:57 | |
| *** dave-mcc_ has joined #openstack-nova | 01:57 | |
| *** dave-mccowan has quit IRC | 01:59 | |
| *** jamesdenton has joined #openstack-nova | 02:01 | |
| *** thorst_ has joined #openstack-nova | 02:01 | |
| *** raunak has joined #openstack-nova | 02:02 | |
| *** kaisers_ has joined #openstack-nova | 02:03 | |
| melwitt | dansmith: I left a comment on https://review.openstack.org/#/c/319379/ it looks like the IBM CI failure might be legit, OrphanedObjectError raised from L1790 | 02:04 |
| melwitt | I don't yet understand how the instance could be orphaned at that point | 02:05 |
| *** thorst_ has quit IRC | 02:06 | |
| *** jamesdenton has quit IRC | 02:06 | |
| *** jamesdenton has joined #openstack-nova | 02:06 | |
| *** kaisers has quit IRC | 02:07 | |
| *** sacharya_ has joined #openstack-nova | 02:07 | |
| *** duonghq has joined #openstack-nova | 02:07 | |
| *** sacharya has quit IRC | 02:08 | |
| *** unicell has quit IRC | 02:10 | |
| *** cdelatte has quit IRC | 02:11 | |
| *** armax has quit IRC | 02:12 | |
| *** Sukhdev has quit IRC | 02:14 | |
| *** yamahata has quit IRC | 02:16 | |
| alex_xu | oomichi: yea, just as gmann said, this probably is a fix for key we didn't want to expose. I feel that is different with all_tenants | 02:19 |
| *** ducttape_ has joined #openstack-nova | 02:19 | |
| alex_xu | gmann: i'm not sure about the spec. but give th time i'm not sure we can get all thing done. maybe worth a email also to get widely suggestion | 02:20 |
| mriedem | dansmith: bauzas: jaypipes: well it looks like the scheduler + placement stuff is failing grenade multinode because of this test: | 02:20 |
| mriedem | https://github.com/openstack/tempest/blob/8bdd42766a7f02180d07e6ab75f0914e5d876a91/tempest/scenario/test_server_multinode.py#L49 | 02:20 |
| gmann | alex_xu: i did not fully understood your comment about capability discovery on this https://review.openstack.org/#/c/415330/24 | 02:20 |
| mriedem | i believe because we have 2 computes, but one is newton and one is ocata, and the newton one doesn't have placement configured, | 02:20 |
| *** eandersson__ has joined #openstack-nova | 02:20 | |
| mriedem | so when the scheduler tries to place an instance on the newton compute, the scheduler pukes because there isn't a resource provider for that node | 02:20 |
| *** dansmith has quit IRC | 02:20 | |
| *** eandersson_ has quit IRC | 02:20 | |
| *** dansmith has joined #openstack-nova | 02:21 | |
| gmann | alex_xu: you mean 403->200 is ok to change and discover with capabilities of all_tenant ? | 02:21 |
| gmann | alex_xu: correct me if other way around | 02:21 |
| alex_xu | gmann: whether the user is allowed to execute on a API, that should be discovered by capabilities discovery https://review.openstack.org/386555 | 02:21 |
| owalsh | dansmith, mriedem, melwitt: big thanks for https://review.openstack.org/424243 | 02:21 |
| dansmith | mriedem: with my backported change the newton one should keep trying | 02:22 |
| dansmith | mriedem: this: https://review.openstack.org/#/c/419217/ | 02:22 |
| dansmith | owalsh: np | 02:22 |
| alex_xu | gmann: no, I agree with johnthetubaguy. We change a enforce from hard to soft, that is a change on the API contract. so yes, we need microversion | 02:23 |
| mriedem | dansmith: but do we ever configure the newton subnode in grenade with placement creds? | 02:23 |
| mriedem | dansmith: nope http://logs.openstack.org/61/417961/26/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/15545e4/logs/subnode-2/etc/nova/nova.conf.txt.gz | 02:23 |
| *** mtanino has quit IRC | 02:23 | |
| dansmith | mriedem: oh right, damn | 02:23 |
| dansmith | mriedem: so it fails because we don't have resources for multiple computes, right? | 02:24 |
| * owalsh needs some sleep, have a good night/evening/etc... | 02:24 | |
| dansmith | mriedem: that's farther than it was getting before, right? so that | 02:24 |
| gmann | alex_xu: yea, so we all are on same page. thanks | 02:24 |
| dansmith | mriedem: is progress | 02:24 |
| alex_xu | gmann: yea | 02:24 |
| *** ducttape_ has quit IRC | 02:24 | |
| gmann | alex_xu: i ll push spec + patch updates and both can be reviewed in parallel | 02:25 |
| alex_xu | gmann: thanks! | 02:25 |
| mriedem | dansmith: correct, this test uses AZs to specifically place an instance on each compute node | 02:25 |
| mriedem | so the forced_host thing or whatever | 02:25 |
| mriedem | we could change the test to not be a smoke test and it wouldn't be run with grenade, but i could see people freaking out about that | 02:26 |
| dansmith | mriedem: well, it's either that or backport cred setup to newton devstack right? | 02:27 |
| mriedem | cred setup is in newton devstack, | 02:27 |
| mriedem | it's just grenade isn't configuring placement creds into nova.conf on the subnode | 02:27 |
| dansmith | oh | 02:27 |
| mriedem | the other alternative, which you're not going to probably like, is for ocata we fallback to the compute node get_all and drop that in pike | 02:28 |
| mriedem | because ocata computes will have placement setup for grenade from ocata->pike | 02:28 |
| dansmith | mriedem: I guess it's an important thing to check that the subnode is still live after the upgrade, assuming proper config | 02:28 |
| dansmith | mriedem: seems strange to push this hard and then not try to fix grenade at the last minute | 02:29 |
| *** jamesdenton has quit IRC | 02:30 | |
| *** annegentle has quit IRC | 02:33 | |
| mriedem | yeah i know, i'm not sure how hard this is to make grenade config the newton subnode for placement right now | 02:33 |
| dansmith | melwitt: can you see my response to you on my patch just now? | 02:34 |
| mriedem | i have an emergency toenail situation to deal with that's much easier to fix, will check grenade after that | 02:34 |
| melwitt | dansmith: yeah just opened it. replying | 02:34 |
| *** shaner has joined #openstack-nova | 02:38 | |
| dansmith | melwitt: might be easier to chat here | 02:41 |
| melwitt | dansmith: okay. that's setting the _context on the BuildRequest object though, not the BuildRequest.instance object | 02:41 |
| melwitt | I don't see anywhere in _load_instance that it sets instance._context | 02:42 |
| melwitt | self.instance._context | 02:42 |
| *** owalsh is now known as owalsh-afk | 02:43 | |
| dansmith | melwitt: you're right, I remember arguing with alaski about this specifically | 02:43 |
| dansmith | melwitt: so what do you want me to change it to? | 02:43 |
| melwitt | yeah, I was not sure if it's intentional not to do it | 02:43 |
| dansmith | I wanted him to, and he wanted it to be orphaned | 02:43 |
| melwitt | hrm. | 02:44 |
| melwitt | assuming he had good reason for that (we should ask him next time we catch him in the channel), I would think to go back to what you had, sans the refresh() call | 02:44 |
| *** jose-phillips has quit IRC | 02:44 | |
| dansmith | but your comment above the refresh explains why that's important | 02:45 |
| *** Jeffrey4l has quit IRC | 02:45 | |
| melwitt | why what's important? | 02:46 |
| dansmith | we also have to handle the case where we didn't actually look it up right? | 02:47 |
| dansmith | why the refresh is important | 02:47 |
| dansmith | or you want to keep the instance we got from _lookup? | 02:47 |
| *** raunak has quit IRC | 02:47 | |
| melwitt | oh, I was saying that's another more complicated option if doing a proper refresh() is important | 02:47 |
| dansmith | okay, I'm totally confused | 02:48 |
| melwitt | sorry. I was trying to say I think what we had with the _lookups makes sense considering that the Instance could have been a half-baked object generated from a BuildRequest | 02:49 |
| dansmith | to get the newer instance with .host set, right? | 02:49 |
| melwitt | and only to do something more (like check whether it's orphaned or not to determine whether to _lookup vs refresh()) but I'm not sure that matters | 02:49 |
| melwitt | yeah | 02:49 |
| dansmith | okay but PS79 wouldn't bail if we fail to do that lookup, so I also have to include the bit from PS81 that bails if we fail to lookup because we raced with another delete | 02:50 |
| *** sacharya_ has quit IRC | 02:50 | |
| *** sacharya has joined #openstack-nova | 02:50 | |
| *** thorst_ has joined #openstack-nova | 02:50 | |
| *** thorst_ has quit IRC | 02:50 | |
| melwitt | if it's important to do a refresh if real Instance, then we'd have to check for that and do either or depending. and I was going to defer to you on whether we should do that here | 02:51 |
| dansmith | we have to refresh if your comment above the refresh is correct | 02:52 |
| dansmith | otherwise we'll fail to send the delete request to the compute | 02:52 |
| melwitt | I thought the _lookup would serve as the refresh to send it. and then like you said also need the bail out part if it was a race with another delete | 02:53 |
| *** markmcclain has quit IRC | 02:53 | |
| dansmith | that's what I'm saying | 02:54 |
| dansmith | however, it seemed like I was getting an orphaned instance from that lookup in the previous patchset because I was getting orphaned errors in jenkins, which I no longer am here | 02:55 |
| *** baoli has joined #openstack-nova | 02:56 | |
| dansmith | melwitt: you happy with this? http://pastebin.com/QgsXKH1f | 02:57 |
| melwitt | that's unexpected | 02:57 |
| dansmith | melwitt: what is unexpected? the orphaned warnings before? I can link you to the logs :) | 02:57 |
| *** markmcclain has joined #openstack-nova | 02:58 | |
| melwitt | yeah. I believe you, it's just unexpected since I just looked through _lookup_instance and didn't think I saw a way it could get an orphaned instance loaded there | 02:58 |
| dansmith | actually, let me go back one more rev hang on | 02:59 |
| dansmith | but, is the above what you're thinking? | 02:59 |
| melwitt | dansmith: and yes that code is what I was thinking. but I'm concerned about the orphaned errors (although in the IBM CI it shows we still have them, maybe less of a window). I'm going to look through the logs now | 02:59 |
| dansmith | melwitt: okay I got it | 03:00 |
| dansmith | melwitt: PS79 we were getting failure trying to do instance.uuid from the return of _lookup, which can be None | 03:00 |
| dansmith | since I wasn't bailing there, I was using that instance (which had _context) if it was good, and hitting None.uuid if not | 03:00 |
| *** bkopilov has quit IRC | 03:00 | |
| dansmith | then in the next one, | 03:00 |
| melwitt | dansmith: oh, because you lacked the bailout code | 03:00 |
| dansmith | I used _instance and was getting the orphaned errors | 03:00 |
| dansmith | but maybe got lucky on the race | 03:01 |
| dansmith | so I think the above code, using the _lookup for the refresh and bailing if we get None is probably right | 03:01 |
| melwitt | okay, so the code in the paste should catch all of those cases. I think | 03:01 |
| dansmith | yeah | 03:01 |
| dansmith | the dep chain for this is like five deep so I just can't keep the sequencing of the errors in my head I guess | 03:01 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 03:02 |
| dansmith | and looks like the lowest dep is going to get kicked out of the gate.. yay | 03:03 |
| dansmith | #fml | 03:03 |
| melwitt | guh | 03:03 |
| *** markvoelker has joined #openstack-nova | 03:07 | |
| *** baoli has quit IRC | 03:10 | |
| *** yamahata has joined #openstack-nova | 03:10 | |
| dansmith | I'm still kinda unsure.. this must be a fantastic race that we only hit occasionally | 03:11 |
| dansmith | because I think it ran a bunch of times in a row without hitting it when I was dicking with the listing patch | 03:12 |
| dansmith | but whatever | 03:12 |
| melwitt | back when I was working on the patch to pass the cells v1 job, it failed often enough with the ObjectActionError in that block that I knew to add something. guess I was "lucky" | 03:15 |
| dansmith | right but that was a race, | 03:16 |
| dansmith | this is a race in the race handler :) | 03:16 |
| *** takashin has joined #openstack-nova | 03:16 | |
| melwitt | yes. fwiw it got really stable after adding the catch block, it's just the instance.refresh() wasn't really doing anything | 03:16 |
| dansmith | I mean, I'm not saying this doesn't make sense, I'm just wondering why murphy hates me | 03:16 |
| melwitt | yeah, I get you | 03:17 |
| *** thorst_ has joined #openstack-nova | 03:17 | |
| *** thorst_ has quit IRC | 03:17 | |
| dansmith | I think it was, but only in the cases where we get there from a buildrequest and when we didn't race with another delete right? | 03:17 |
| melwitt | hm, yeah. I guess it would have had an orphaned error itself when it tried to reload itself if it came from a build request | 03:19 |
| dansmith | at least those deps got reset so I get another go at the gate without a recheck | 03:19 |
| dansmith | even though it estimates 43h until completion :/ | 03:19 |
| melwitt | it's showing 1 hour estimate on my view for what's running right now | 03:20 |
| dansmith | it's now 15h for those | 03:20 |
| dansmith | 19: (421228,2) Add --verbose option to discover_hosts command (4h26m/++~~~~~~~/rem:15h43m) | 03:20 |
| * dansmith for the gate | 03:21 | |
| dansmith | 1h for this conductor patch | 03:21 |
| *** tbachman has joined #openstack-nova | 03:21 | |
| melwitt | oh, I see | 03:21 |
| melwitt | the gate was nuts today | 03:22 |
| melwitt | (busy) | 03:22 |
| dansmith | the queues aren't very long right now, but it's still estimating long runtimes, | 03:22 |
| dansmith | so something might be failing a lot | 03:22 |
| *** markvoelker has quit IRC | 03:23 | |
| dansmith | it's dropping. maybe just a big recalculation and pessimism | 03:25 |
| * dansmith likes pessimistic software | 03:26 | |
| melwitt | haha | 03:26 |
| melwitt | yeah, I was thinking, most of what's in the gate has only a 1 hr wait left, but I assume that doesn't account for resets | 03:26 |
| melwitt | bbiab | 03:29 |
| *** xiongjh1 has joined #openstack-nova | 03:30 | |
| *** pbandark has joined #openstack-nova | 03:31 | |
| *** bjolo_ has quit IRC | 03:31 | |
| *** markvoelker has joined #openstack-nova | 03:33 | |
| *** ijw has quit IRC | 03:35 | |
| *** ijw has joined #openstack-nova | 03:35 | |
| *** ijw has quit IRC | 03:35 | |
| *** Swami has quit IRC | 03:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 03:36 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512 | 03:38 |
| *** baoli has joined #openstack-nova | 03:39 | |
| *** nicolasbock has quit IRC | 03:39 | |
| *** jaypipes_ has quit IRC | 03:40 | |
| *** ducttape_ has joined #openstack-nova | 03:40 | |
| *** mingyu has joined #openstack-nova | 03:41 | |
| *** xinliang has quit IRC | 03:42 | |
| *** mingyu has quit IRC | 03:46 | |
| *** Sukhdev has joined #openstack-nova | 03:48 | |
| *** gcb has joined #openstack-nova | 03:50 | |
| *** guchihiro has joined #openstack-nova | 03:50 | |
| *** esberglu has joined #openstack-nova | 03:51 | |
| *** esberglu has quit IRC | 03:55 | |
| *** jaypipes_ has joined #openstack-nova | 03:57 | |
| *** ducttape_ has quit IRC | 04:00 | |
| *** psachin has joined #openstack-nova | 04:03 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421 | 04:05 |
| *** tbachman has quit IRC | 04:06 | |
| *** hongbin has joined #openstack-nova | 04:10 | |
| *** armax has joined #openstack-nova | 04:10 | |
| *** iceyao has joined #openstack-nova | 04:13 | |
| dansmith | melwitt: powerkvm passed | 04:16 |
| dansmith | but jenkins is going to fail | 04:16 |
| melwitt | ah, I see that. checking what it is | 04:16 |
| melwitt | it's that identity error again from keystone. I've seen that before but I dunno if anyone's documented it in a bug yet | 04:17 |
| dansmith | see the sql failure? | 04:18 |
| dansmith | http://logs.openstack.org/79/319379/82/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/72d1a95/logs/screen-n-api.txt.gz?level=TRACE#_2017-01-26_04_09_09_706 | 04:18 |
| dansmith | so fingers crossed it's not related | 04:18 |
| dansmith | but it means I have to recheck uh-gain | 04:18 |
| melwitt | yeah, looking at those now. weird | 04:18 |
| melwitt | I've seen sql errors on other failed runs before lately | 04:20 |
| *** baoli has quit IRC | 04:20 | |
| dansmith | well, | 04:21 |
| dansmith | I'm not going to be able to stay up for the end of the next run of this | 04:21 |
| dansmith | so I hope that we can get this happy tomorrow | 04:21 |
| *** ducttape_ has joined #openstack-nova | 04:22 | |
| melwitt | I'll keep an eye on it | 04:23 |
| dansmith | the powervm fail is a secgroup thing, FYI | 04:24 |
| dansmith | melwitt: okay thanks | 04:25 |
| melwitt | oh, why did it run it two on the same PS | 04:25 |
| melwitt | s/two/twice/ | 04:25 |
| melwitt | oh, powervm vs powerkvm | 04:25 |
| dansmith | yeah | 04:25 |
| melwitt | haha, they look too similar to me | 04:25 |
| dansmith | and powervm is the out of tree driver | 04:25 |
| dansmith | and non-voting | 04:26 |
| melwitt | okay, yeah | 04:26 |
| *** bkopilov has joined #openstack-nova | 04:28 | |
| *** smatzek has quit IRC | 04:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 04:31 |
| *** dave-mcc_ has quit IRC | 04:32 | |
| *** armax has quit IRC | 04:34 | |
| *** ducttape_ has quit IRC | 04:34 | |
| *** ianw is now known as ianw_pto | 04:34 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova: ironic: Add trigger crash dump support to ironic driver https://review.openstack.org/376548 | 04:35 |
| takashin | alex_xu: Are you aroud? | 04:38 |
| takashin | oomichi: Are you aroud? | 04:41 |
| *** cristicalin has joined #openstack-nova | 04:42 | |
| cristicalin | hello, I have an issue with a nova which I upgraded from juno to mitaka | 04:42 |
| cristicalin | after the upgrade it started flooding the neutron server with requests | 04:42 |
| cristicalin | is there any way to make it less aggressive ? | 04:43 |
| *** mingyu has joined #openstack-nova | 04:43 | |
| cristicalin | neutron is still running juno version at the moment | 04:43 |
| cristicalin | I see a lot of security group updates being sent to the neutron server which look redundant as they trigger no actual changes | 04:44 |
| cristicalin | and nova logs messaages like "Creating event network-changed:None" | 04:45 |
| *** yamahata has quit IRC | 04:46 | |
| *** mingyu has quit IRC | 04:47 | |
| *** d-bark has joined #openstack-nova | 04:49 | |
| *** mdnadeem has joined #openstack-nova | 04:50 | |
| mriedem | mnestratov: fyi http://lists.openstack.org/pipermail/openstack-dev/2017-January/111007.html re https://review.openstack.org/#/c/312488/ | 04:50 |
| mriedem | bauzas: for your morning pleasure http://lists.openstack.org/pipermail/openstack-dev/2017-January/111006.html | 04:51 |
| *** raunak has joined #openstack-nova | 04:51 | |
| mikal | I must say I find this PTG thing very depressing | 04:54 |
| *** hongbin has quit IRC | 04:56 | |
| *** hongbin has joined #openstack-nova | 04:56 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Few updates on server filter/sort spec https://review.openstack.org/425533 | 04:57 |
| *** Sukhdev has quit IRC | 04:58 | |
| *** cburgess has quit IRC | 05:01 | |
| *** Guest58531 has quit IRC | 05:04 | |
| *** McNinja has quit IRC | 05:05 | |
| *** d-bark has quit IRC | 05:06 | |
| *** McNinja has joined #openstack-nova | 05:07 | |
| *** comstud has quit IRC | 05:07 | |
| *** cburgess has joined #openstack-nova | 05:07 | |
| *** mgagne has joined #openstack-nova | 05:07 | |
| *** mgagne is now known as Guest33539 | 05:07 | |
| *** comstud has joined #openstack-nova | 05:08 | |
| *** cristicalin has quit IRC | 05:08 | |
| *** hongbin_ has joined #openstack-nova | 05:09 | |
| *** Sukhdev has joined #openstack-nova | 05:09 | |
| *** hongbin has quit IRC | 05:11 | |
| *** raunak has quit IRC | 05:13 | |
| *** sacharya has quit IRC | 05:14 | |
| *** moshele has joined #openstack-nova | 05:14 | |
| *** sacharya has joined #openstack-nova | 05:14 | |
| *** sacharya has quit IRC | 05:15 | |
| *** sacharya has joined #openstack-nova | 05:15 | |
| *** raunak has joined #openstack-nova | 05:17 | |
| *** thorst_ has joined #openstack-nova | 05:18 | |
| *** sacharya has quit IRC | 05:20 | |
| *** hongbin_ has quit IRC | 05:21 | |
| *** thorst_ has quit IRC | 05:23 | |
| *** browne has joined #openstack-nova | 05:23 | |
| *** claudiub has joined #openstack-nova | 05:25 | |
| *** unicell has joined #openstack-nova | 05:28 | |
| *** cristicalin has joined #openstack-nova | 05:30 | |
| *** browne has quit IRC | 05:34 | |
| *** nkrinner_afk is now known as nkrinner | 05:35 | |
| *** mdnadeem has quit IRC | 05:36 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Few updates on server filter/sort spec https://review.openstack.org/425533 | 05:37 |
| *** esberglu has joined #openstack-nova | 05:40 | |
| *** xiongjh1 has quit IRC | 05:40 | |
| *** cristicalin has quit IRC | 05:40 | |
| *** esberglu has quit IRC | 05:44 | |
| *** mdnadeem has joined #openstack-nova | 05:48 | |
| *** Sukhdev has quit IRC | 05:49 | |
| *** ducttape_ has joined #openstack-nova | 05:50 | |
| *** ekuris_ has joined #openstack-nova | 05:51 | |
| *** unicell has quit IRC | 05:53 | |
| *** unicell has joined #openstack-nova | 05:54 | |
| *** ducttape_ has quit IRC | 05:55 | |
| *** gouthamr has quit IRC | 06:00 | |
| *** sree has joined #openstack-nova | 06:02 | |
| *** kaisers_ has quit IRC | 06:02 | |
| *** mdnadeem has quit IRC | 06:02 | |
| *** mdnadeem has joined #openstack-nova | 06:02 | |
| *** baoli has joined #openstack-nova | 06:10 | |
| *** raunak has quit IRC | 06:14 | |
| *** baoli has quit IRC | 06:15 | |
| *** sacharya has joined #openstack-nova | 06:16 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix doc generation warnings https://review.openstack.org/425549 | 06:16 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix doc generation warnings https://review.openstack.org/425549 | 06:17 |
| *** vsaienko has joined #openstack-nova | 06:19 | |
| *** raunak has joined #openstack-nova | 06:19 | |
| *** sacharya has quit IRC | 06:22 | |
| *** adisky_ has joined #openstack-nova | 06:34 | |
| *** mjura has joined #openstack-nova | 06:34 | |
| *** mingyu has joined #openstack-nova | 06:44 | |
| *** zerda2 has quit IRC | 06:49 | |
| *** mingyu has quit IRC | 06:49 | |
| openstackgerrit | melanie witt proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 06:52 |
| *** carthaca_ has joined #openstack-nova | 07:02 | |
| *** kaisers has joined #openstack-nova | 07:03 | |
| *** aojea has quit IRC | 07:07 | |
| *** tesseract has joined #openstack-nova | 07:11 | |
| *** edmondsw has joined #openstack-nova | 07:12 | |
| *** andreas_s has joined #openstack-nova | 07:15 | |
| *** edmondsw has quit IRC | 07:16 | |
| *** rha has quit IRC | 07:17 | |
| *** frickler has quit IRC | 07:18 | |
| *** thorst_ has joined #openstack-nova | 07:19 | |
| *** aojea has joined #openstack-nova | 07:19 | |
| *** ducttape_ has joined #openstack-nova | 07:21 | |
| *** moshele has quit IRC | 07:23 | |
| *** thorst_ has quit IRC | 07:23 | |
| *** mfeoktistov has joined #openstack-nova | 07:24 | |
| *** vsaienko has quit IRC | 07:26 | |
| *** ducttape_ has quit IRC | 07:26 | |
| *** zerda2 has joined #openstack-nova | 07:27 | |
| *** lennyb has quit IRC | 07:27 | |
| *** lennyb has joined #openstack-nova | 07:28 | |
| *** esberglu has joined #openstack-nova | 07:29 | |
| *** vsaienko has joined #openstack-nova | 07:29 | |
| *** esberglu has quit IRC | 07:33 | |
| *** kaisers has quit IRC | 07:33 | |
| *** thorst_ has joined #openstack-nova | 07:34 | |
| *** avolkov has joined #openstack-nova | 07:36 | |
| *** kaisers has joined #openstack-nova | 07:36 | |
| *** rha has joined #openstack-nova | 07:36 | |
| *** rha has quit IRC | 07:37 | |
| *** rha has joined #openstack-nova | 07:37 | |
| *** frickler has joined #openstack-nova | 07:37 | |
| *** vsaienko has quit IRC | 07:38 | |
| *** thorst_ has quit IRC | 07:39 | |
| *** kaisers has quit IRC | 07:40 | |
| *** raunak has quit IRC | 07:44 | |
| *** kaisers has joined #openstack-nova | 07:45 | |
| *** vsaienko has joined #openstack-nova | 07:46 | |
| *** tojuvone has joined #openstack-nova | 07:47 | |
| *** sahid has joined #openstack-nova | 07:48 | |
| *** kaisers has quit IRC | 07:49 | |
| *** duonghq has quit IRC | 07:51 | |
| *** kaisers has joined #openstack-nova | 07:52 | |
| *** vsaienko has quit IRC | 07:54 | |
| *** hfu has quit IRC | 07:55 | |
| *** hfu has joined #openstack-nova | 07:55 | |
| *** markus_z has joined #openstack-nova | 07:55 | |
| *** hfu has quit IRC | 07:55 | |
| *** hfu has joined #openstack-nova | 07:56 | |
| *** hfu has quit IRC | 07:56 | |
| *** hfu has joined #openstack-nova | 07:57 | |
| *** hfu has quit IRC | 07:57 | |
| *** hfu has joined #openstack-nova | 07:57 | |
| *** hfu has quit IRC | 07:58 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Few updates on server filter/sort spec https://review.openstack.org/425533 | 07:58 |
| *** hfu has joined #openstack-nova | 07:58 | |
| *** hfu has quit IRC | 07:59 | |
| *** slaweq has quit IRC | 08:00 | |
| *** tovin07 has quit IRC | 08:02 | |
| *** eglynn has quit IRC | 08:03 | |
| *** tovin07_ has quit IRC | 08:05 | |
| *** slaweq has joined #openstack-nova | 08:06 | |
| *** hieulq has quit IRC | 08:09 | |
| *** markvoelker has quit IRC | 08:12 | |
| *** markvoelker has joined #openstack-nova | 08:15 | |
| *** guchihiro has quit IRC | 08:16 | |
| *** ralonsoh has joined #openstack-nova | 08:16 | |
| *** vladikr has quit IRC | 08:21 | |
| *** frickler has quit IRC | 08:23 | |
| *** abalutoiu_ has joined #openstack-nova | 08:23 | |
| *** rha has quit IRC | 08:23 | |
| *** frickler has joined #openstack-nova | 08:24 | |
| *** rha has joined #openstack-nova | 08:25 | |
| *** rha has joined #openstack-nova | 08:25 | |
| *** abalutoiu__ has quit IRC | 08:27 | |
| *** phuongnh has quit IRC | 08:27 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 08:35 |
| *** mingyu has joined #openstack-nova | 08:45 | |
| *** ducttape_ has joined #openstack-nova | 08:48 | |
| *** mingyu has quit IRC | 08:50 | |
| *** unicell has quit IRC | 08:54 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** gongysh has quit IRC | 09:10 | |
| mnestratov | mnes | 09:19 |
| mnestratov | mriedem: thanks | 09:19 |
| *** lucas-afk is now known as lucasagomes | 09:25 | |
| *** sambetts|afk is now known as sambetts | 09:26 | |
| *** amotoki has quit IRC | 09:27 | |
| *** amotoki has joined #openstack-nova | 09:28 | |
| *** amotoki has quit IRC | 09:32 | |
| *** CristinaPauna has quit IRC | 09:32 | |
| *** efoley_ has joined #openstack-nova | 09:34 | |
| *** thorst_ has joined #openstack-nova | 09:35 | |
| *** efoley__ has joined #openstack-nova | 09:36 | |
| *** derekh has joined #openstack-nova | 09:37 | |
| *** gcb has quit IRC | 09:37 | |
| *** amotoki has joined #openstack-nova | 09:39 | |
| *** jpena|off is now known as jpena | 09:40 | |
| *** efoley_ has quit IRC | 09:40 | |
| *** thorst_ has quit IRC | 09:40 | |
| *** BobBall_AWOL is now known as BobBall | 09:42 | |
| *** karimb has joined #openstack-nova | 09:43 | |
| *** karimb has quit IRC | 09:43 | |
| *** CristinaPauna has joined #openstack-nova | 09:45 | |
| *** rmart04 has joined #openstack-nova | 09:46 | |
| johnthetubaguy | mikal: whats depressing? | 09:46 |
| *** mvk has quit IRC | 09:47 | |
| johnthetubaguy | bauzas: let me know if I can lend a hand with some of the grenade stuff, I was helping with the zero downtime job where we added nova-api on the subnode | 09:48 |
| *** gcb has joined #openstack-nova | 09:50 | |
| *** jose-phillips has joined #openstack-nova | 09:50 | |
| *** moshele has joined #openstack-nova | 09:50 | |
| *** thorst_ has joined #openstack-nova | 09:51 | |
| *** karimb has joined #openstack-nova | 09:52 | |
| *** abalutoiu_ has quit IRC | 09:53 | |
| *** jpena is now known as jpena|off | 09:53 | |
| *** jose-phillips has quit IRC | 09:54 | |
| *** markus_z has quit IRC | 09:55 | |
| *** aarefiev_afk is now known as aarefiev | 09:55 | |
| *** thorst_ has quit IRC | 09:56 | |
| BlackDex | hello | 09:58 |
| BlackDex | i have some trouble with nova-consoleauth | 09:58 |
| BlackDex | i have an HA setup | 09:59 |
| BlackDex | and i added memcached for the console tokens | 09:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Use a service account to make vendordata requests. https://review.openstack.org/415597 | 09:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Cache boot time roles for vendordata. https://review.openstack.org/417780 | 09:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Optionally make dynamic vendordata failures fatal. https://review.openstack.org/416391 | 09:59 |
| BlackDex | the servers are added to the config | 09:59 |
| BlackDex | but they don't appear to be used | 09:59 |
| *** jpena|off is now known as jpena | 10:00 | |
| *** efoley_ has joined #openstack-nova | 10:03 | |
| gmann | johnthetubaguy: alex_xu can you check spec updates for policy things - https://review.openstack.org/#/c/425533/ | 10:04 |
| gmann | updating patch with alex_xu comment | 10:04 |
| *** hshiina has joined #openstack-nova | 10:05 | |
| *** efoley__ has quit IRC | 10:06 | |
| openstackgerrit | Michael Still proposed openstack/nova: Use a service account to make vendordata requests. https://review.openstack.org/415597 | 10:07 |
| openstackgerrit | Michael Still proposed openstack/nova: Cache boot time roles for vendordata. https://review.openstack.org/417780 | 10:07 |
| openstackgerrit | Michael Still proposed openstack/nova: Optionally make dynamic vendordata failures fatal. https://review.openstack.org/416391 | 10:07 |
| gmann | johnthetubaguy: alex_xu we need to do warning inside if condition - https://review.openstack.org/#/c/415330/25/nova/policy.py | 10:08 |
| gmann | johnthetubaguy: alex_xu i we want to warn even people did not updated file right ? | 10:08 |
| gmann | * i think we | 10:09 |
| johnthetubaguy | maybe... | 10:09 |
| gmann | i mean if there is old rule overridden then warn them irrespective of updates in policy file or not | 10:09 |
| johnthetubaguy | Oh, good point, it needs removing either way | 10:10 |
| gmann | yea | 10:10 |
| johnthetubaguy | I was thinking we should probably have a more general warning about folks who override a rule to it existing default value | 10:10 |
| johnthetubaguy | but thats something for pike, as part of the policy clean up | 10:11 |
| *** esberglu has joined #openstack-nova | 10:12 | |
| gmann | johnthetubaguy: but warn about what context ? 'be careful you are overriding default one' something like | 10:13 |
| sfinucan | mikal: Didn't know you were back - was addressing johnthetubaguy's comments on https://review.openstack.org/#/q/topic:bp/vendordata-reboot-ocata | 10:13 |
| sfinucan | As you were :) | 10:13 |
| johnthetubaguy | sfinucan: oh you did, sweet, let me jump on that | 10:14 |
| sfinucan | johnthetubaguy: Well, I haven't pushed them yet | 10:14 |
| sfinucan | mikal pushed a rebase just now and I don't want to walk all over any changes he has planned | 10:15 |
| * johnthetubaguy nods | 10:15 | |
| johnthetubaguy | sfinucan: let me know | 10:16 |
| *** owalsh-afk is now known as owalsh | 10:17 | |
| sfinucan | BlackDex: You might be better asking that on the general #openstack channel | 10:17 |
| *** esberglu has quit IRC | 10:17 | |
| johnthetubaguy | sfinucan: raj_singh has some changes up on service tokens that are very similar | 10:17 |
| sfinucan | BlackDex: ...or waiting until tomorrow, when the feature freeze deadline has passed :) | 10:17 |
| johnthetubaguy | had a chat to keystone folks about how the caching works, hence me spotting it | 10:17 |
| *** amotoki has quit IRC | 10:18 | |
| BlackDex | sfinucan: to busy with final stuff i guese | 10:18 |
| sfinucan | johnthetubaguy: Have a link? | 10:19 |
| mikal | sfinucan: I've only fixed the merge conflict so far | 10:19 |
| mikal | sfinucan: if you've got fixes for the caching and reno stuff, I encourage you to push them up | 10:19 |
| johnthetubaguy | sfinucan: https://review.openstack.org/#/c/412634/ | 10:19 |
| sfinucan | mikal: Yeah, I've that done. Just this one I'm stuck on https://review.openstack.org/#/c/415597/4/nova/conf/vendordata.py | 10:19 |
| sfinucan | I'll push shortly | 10:19 |
| *** carthaca_1 has joined #openstack-nova | 10:20 | |
| mikal | Ok | 10:20 |
| mikal | I'm actually not at work today, on prescription painkillers, and in a terrible mood | 10:20 |
| mikal | So you're much more likely to get it up in time than me | 10:20 |
| mikal | ;) | 10:20 |
| *** carthaca_ has quit IRC | 10:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 10:23 |
| bauzas | johnthetubaguy: sorry, I was afk this morning | 10:25 |
| *** wim_declercq has joined #openstack-nova | 10:25 | |
| bauzas | johnthetubaguy: you probably saw the problem with the scheduler upcall patch ? | 10:26 |
| bauzas | mriedem helped us by adding a new Depends-On | 10:26 |
| bauzas | but I'm a bit afraid to see the patch not being merged by Ocata given all the problems we still have when upgrading | 10:26 |
| bauzas | :' | 10:26 |
| bauzas | :( | 10:26 |
| *** sapcc-bot1 has joined #openstack-nova | 10:30 | |
| *** Cristina_ has joined #openstack-nova | 10:30 | |
| *** sapcc-bot has quit IRC | 10:31 | |
| *** karimb has quit IRC | 10:31 | |
| sahid | johnthetubaguy: did you notice my comments here ? https://review.openstack.org/#/c/385023/ | 10:32 |
| sahid | does it make sense for you to +W it ? | 10:32 |
| *** CristinaPauna has quit IRC | 10:33 | |
| johnthetubaguy | sahid: I haven't had chance to get back to that, stuck in priority features right now | 10:34 |
| *** wim_declercq has left #openstack-nova | 10:34 | |
| openstackgerrit | Sam Betts proposed openstack/nova: Change order of _cleanup_deploy and _unprovision in Ironic virt https://review.openstack.org/422678 | 10:38 |
| *** mingyu has joined #openstack-nova | 10:47 | |
| *** edmondsw has joined #openstack-nova | 10:48 | |
| andreykurilin | johnthetubaguy: hi! can you put final mark to the last blocker for novaclient's release https://review.openstack.org/#/c/424256/ ?) | 10:49 |
| *** karimb has joined #openstack-nova | 10:50 | |
| *** lpetrut has joined #openstack-nova | 10:51 | |
| *** mingyu has quit IRC | 10:51 | |
| *** edmondsw has quit IRC | 10:52 | |
| *** lpetrut has quit IRC | 10:55 | |
| *** Jack_V has joined #openstack-nova | 10:59 | |
| Jack_V | Hi folks! | 10:59 |
| Jack_V | I'm upgrading from mitaka to newton | 10:59 |
| *** dimtruck is now known as zz_dimtruck | 10:59 | |
| Jack_V | and got this error during creation an instance from a volume | 10:59 |
| Jack_V | InvalidInput: Invalid input received: Invalid image identifier or unable to access requested image. (HTTP 400) | 10:59 |
| *** kaisers has quit IRC | 11:04 | |
| *** kaisers has joined #openstack-nova | 11:05 | |
| *** tbachman has joined #openstack-nova | 11:05 | |
| *** kaisers_ has joined #openstack-nova | 11:08 | |
| openstackgerrit | melanie witt proposed openstack/nova: Count resources to check quota for cells https://review.openstack.org/416521 | 11:08 |
| *** kaisers has quit IRC | 11:09 | |
| mdbooth | mfeoktistov: Did you read the ML traffic on the privsep thing? | 11:10 |
| mdbooth | Sounds like the concensus is that you should just go ahead and use rootwrap. Oh, and do it quickly ;) | 11:10 |
| *** kaisers_ has quit IRC | 11:12 | |
| *** karimb has quit IRC | 11:12 | |
| *** mfeoktistov has quit IRC | 11:14 | |
| *** mfeoktistov has joined #openstack-nova | 11:15 | |
| mfeoktistov | mdbooth: Yes, thank you. I'll send patch in a minute | 11:16 |
| *** openstackgerrit has quit IRC | 11:17 | |
| *** vsaienko has joined #openstack-nova | 11:19 | |
| *** adisky_ has quit IRC | 11:19 | |
| *** sree has quit IRC | 11:20 | |
| *** openstackgerrit has joined #openstack-nova | 11:25 | |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488 | 11:25 |
| *** karimb has joined #openstack-nova | 11:27 | |
| *** karimb has quit IRC | 11:28 | |
| *** tbachman has quit IRC | 11:29 | |
| *** karimb has joined #openstack-nova | 11:30 | |
| johnthetubaguy | andreykurilin: don't we support --os-auth-token and --os-token? | 11:34 |
| andreykurilin | johnthetubaguy: I found note about --os-auth-token in the code, but there is no place if registration for that cli argument. PS: we use keystoneclient1 method for registrating identity cli arguments and it registrate just --os-token arg | 11:36 |
| andreykurilin | *no place of | 11:36 |
| johnthetubaguy | I guess we broke that at some point, oops | 11:36 |
| johnthetubaguy | or we deprecated it, and only partially removed it | 11:37 |
| *** tbachman has joined #openstack-nova | 11:40 | |
| johnthetubaguy | andreykurilin: are we missing OS_TOKEN environment variable reading, or does keystoneauth already do that for us? | 11:41 |
| *** gcb has quit IRC | 11:43 | |
| *** nicolasbock has joined #openstack-nova | 11:43 | |
| andreykurilin | johnthetubaguy: ok, I found commits for you:) | 11:45 |
| andreykurilin | johnthetubaguy: os-token argument was introduced with deprecation of os-auth-token: https://github.com/openstack/python-novaclient/commit/1f11840dd84f3570330d1fcd53d1e8eea5ff7922 . Actually that commit broke env variable and the whole token auth method via cli. https://github.com/openstack/python-novaclient/commit/08c4b746b2b894a5cb178c762850a1730e1c636e made a proper deprecation for os-auth-token with warning message. And it was finnaly removed h | 11:46 |
| andreykurilin | johnthetubaguy: So it looks like we can avoid usage of --os-auth-token, since we have a release note that it was deprecated and removed | 11:47 |
| johnthetubaguy | yeah, that looks good, I vaguely remember deprecating those alias things, thank you! | 11:47 |
| andreykurilin | but it sounds like you are right about env variable. keystoneauth doesn't do it for us | 11:48 |
| andreykurilin | johnthetubaguy: should I update my patch (and lose bauzas vote) or send another one?:) | 11:48 |
| *** ociuhandu has quit IRC | 11:48 | |
| johnthetubaguy | andreykurilin: feels like a follow on patch | 11:49 |
| andreykurilin | ok. give me a minute | 11:49 |
| johnthetubaguy | andreykurilin: bit worried about kevin's comment as well, feels like we should always access os_user_domain_id in a consistent way | 11:49 |
| johnthetubaguy | but happy for that to be a follow on | 11:49 |
| *** efoley__ has joined #openstack-nova | 11:50 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Use a service account to make vendordata requests. https://review.openstack.org/415597 | 11:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Cache boot time roles for vendordata. https://review.openstack.org/417780 | 11:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Optionally make dynamic vendordata failures fatal. https://review.openstack.org/416391 | 11:50 |
| johnthetubaguy | sfinucan: I see you | 11:51 |
| sfinucan | johnthetubaguy: Cached the tokens and added renos for all patches | 11:51 |
| sfinucan | jinx :) | 11:51 |
| andreykurilin | johnthetubaguy: if you look at previous patch-sets(for example this one - https://review.openstack.org/#/c/424256/8/novaclient/shell.py ), I tried several ways to make that lines a bit clear, but for some reasons I did not succed in making keystone v3 work | 11:51 |
| johnthetubaguy | andreykurilin: lets do a separate patch that adds a test for that maybe? | 11:51 |
| andreykurilin | ok, I'll try to do it again in folowwing patch | 11:52 |
| *** thorst_ has joined #openstack-nova | 11:52 | |
| *** efoley_ has quit IRC | 11:53 | |
| *** tbachman has quit IRC | 11:54 | |
| *** thorst_ has quit IRC | 11:57 | |
| *** lpetrut has joined #openstack-nova | 11:59 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [cli] Use environment variable for token https://review.openstack.org/425647 | 12:00 |
| *** jpena is now known as jpena|lunch | 12:01 | |
| johnthetubaguy | andreykurilin: I added some questions, got confused about the SecretHelper stuff | 12:01 |
| *** liverpooler has quit IRC | 12:03 | |
| *** bkopilov has quit IRC | 12:05 | |
| andreykurilin | johnthetubaguy: answered:) | 12:13 |
| *** karimb has quit IRC | 12:16 | |
| *** mvk has joined #openstack-nova | 12:16 | |
| *** sofie has quit IRC | 12:18 | |
| *** karimb has joined #openstack-nova | 12:19 | |
| *** smatzek has joined #openstack-nova | 12:20 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [cli] Use environment variable for token https://review.openstack.org/425647 | 12:23 |
| *** vsaienko has quit IRC | 12:25 | |
| *** erlon has joined #openstack-nova | 12:27 | |
| *** catintheroof has joined #openstack-nova | 12:27 | |
| *** ociuhandu has joined #openstack-nova | 12:28 | |
| *** DineshBhor has joined #openstack-nova | 12:32 | |
| *** kaisers has joined #openstack-nova | 12:32 | |
| *** kaisers has quit IRC | 12:37 | |
| *** bvanhav has joined #openstack-nova | 12:37 | |
| *** mjura has quit IRC | 12:38 | |
| *** catintheroof has quit IRC | 12:38 | |
| *** catintheroof has joined #openstack-nova | 12:38 | |
| *** karimb has quit IRC | 12:39 | |
| *** mjura has joined #openstack-nova | 12:40 | |
| *** esberglu has joined #openstack-nova | 12:41 | |
| *** kaisers has joined #openstack-nova | 12:42 | |
| claudiub | hi folks. any idea why nova list currently shows / returns an empty list (including with --all), even if I have spawned instances? | 12:43 |
| *** DineshBhor has quit IRC | 12:43 | |
| *** vsaienko has joined #openstack-nova | 12:45 | |
| *** esberglu has quit IRC | 12:46 | |
| *** vsaienko has quit IRC | 12:47 | |
| *** thorst_ has joined #openstack-nova | 12:47 | |
| *** mingyu has joined #openstack-nova | 12:48 | |
| *** lucasagomes is now known as lucas-hungry | 12:52 | |
| *** mingyu has quit IRC | 12:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 12:55 |
| sfinucan | alex_xu: Regarding https://review.openstack.org/#/c/394480 - does that require any changes on the RPC version? | 12:56 |
| *** pradk has joined #openstack-nova | 12:56 | |
| sfinucan | That's object gets sent over the wire, as far as I understand, and changes to what we send there necessitate RPC bumps | 12:57 |
| sfinucan | ...or so I thought | 12:57 |
| *** catinthe_ has joined #openstack-nova | 12:57 | |
| *** catintheroof has quit IRC | 12:59 | |
| *** jpena|lunch is now known as jpena | 13:00 | |
| *** d-bark has joined #openstack-nova | 13:01 | |
| *** cdent has joined #openstack-nova | 13:06 | |
| mdbooth | Extreme code smell is when reviewing a 6 line change requires a code audit of 2 other modules complete with notes: https://review.openstack.org/#/c/389593/2/nova/virt/libvirt/driver.py | 13:09 |
| *** tbachman has joined #openstack-nova | 13:09 | |
| *** kfarr has joined #openstack-nova | 13:10 | |
| *** edmondsw has joined #openstack-nova | 13:14 | |
| sfinucan | snikitin: https://review.openstack.org/#/c/399613 | 13:14 |
| *** markvoelker has quit IRC | 13:14 | |
| *** vsaienko has joined #openstack-nova | 13:14 | |
| *** lucas-hungry is now known as lucasagomes | 13:16 | |
| cdent | mdbooth: On some days I feel like that describes...everything | 13:17 |
| mdbooth | cdent: Feeling all existential. I'm literally sitting here contemplating 'what does destroy_disks really *mean*' | 13:17 |
| cdent | bauzas, mriedem, dansmith: is there somewhere for me to leap in? | 13:18 |
| * mdbooth has concluded that it is not an intent to destroy disks | 13:18 | |
| cdent | mdbooth: I think that all depends on your position on social construction of meaning | 13:18 |
| mdbooth | lol | 13:18 |
| bauzas | cdent: honestly, I still need to correctly understand the problem | 13:19 |
| cdent | bauzas: Is there only one at this point? | 13:19 |
| bauzas | cdent: yup, I fixed the functional issue | 13:20 |
| bauzas | cdent: now, we still have the grenade problem | 13:20 |
| bauzas | that's the blocking issue | 13:20 |
| cdent | did mriedem option #4 not work (I haven't had a chance to check yet)? | 13:20 |
| *** karimb has joined #openstack-nova | 13:20 | |
| bauzas | which option, sorry? | 13:20 |
| *** owalsh is now known as owalsh-brb | 13:21 | |
| bauzas | oh, you mean the email ? | 13:21 |
| cdent | yeah | 13:22 |
| bauzas | well, #4 is not working yet | 13:23 |
| bauzas | but I agree with mriedem about trying to have #4 and then if not working, doing #3 | 13:24 |
| *** amotoki has joined #openstack-nova | 13:24 | |
| bauzas | but we need to have a consensus before | 13:24 |
| cdent | I think 4 is the best choice | 13:25 |
| cdent | (assuming we can make it work) | 13:25 |
| *** owalsh-brb has quit IRC | 13:26 | |
| *** esberglu has joined #openstack-nova | 13:26 | |
| bauzas | well, tbh, I hate the forced_host field | 13:26 |
| bauzas | cdent: ^ | 13:26 |
| bauzas | because it's silly | 13:26 |
| *** baoli has joined #openstack-nova | 13:27 | |
| bauzas | rather I prefer to use the requested_destination like we did for live-migrating and evacuate, ie. calling all the filters | 13:27 |
| bauzas | but... | 13:27 |
| johnthetubaguy | bauzas: so that option #3, I have a slightly different version that could help? | 13:27 |
| *** baoli has quit IRC | 13:27 | |
| cdent | Yeah, I understand there's quite a lot of history on force_host | 13:27 |
| cdent | (social history) | 13:27 |
| bauzas | if we don't find a solution for #4 today, then the scheduler calling the placement couldn't be merged by Ocata | 13:27 |
| johnthetubaguy | bauzas: if we check for the min_compute service version, and fallback to [] if everything has been upgraded, and the full list of old computenodes if everything hasn't yet been upgraded? | 13:28 |
| bauzas | johnthetubaguy: the fact is that we verify the forced field *after* getting the list of nodes | 13:28 |
| bauzas | which is weirdo | 13:28 |
| bauzas | because if you want to force to a destination, you don't care about others | 13:28 |
| johnthetubaguy | oh, so the problem is different to what I am thinking it is, I thought it was just placement not being present | 13:29 |
| bauzas | johnthetubaguy: nope, we fixed that by my grenade job | 13:29 |
| johnthetubaguy | OK, so this is a different error now? | 13:29 |
| johnthetubaguy | I missed that | 13:29 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [cli] Use environment variable for token https://review.openstack.org/425647 | 13:29 |
| bauzas | johnthetubaguy: yup, see mriedem's email from this early morning | 13:29 |
| *** owalsh-brb has joined #openstack-nova | 13:29 | |
| *** owalsh-brb is now known as owalsh | 13:29 | |
| bauzas | johnthetubaguy: we have a tempest test that's blocking us for a very specific behaviour | 13:29 |
| bauzas | I'll actually respond to mriedem | 13:30 |
| johnthetubaguy | yeah, I was reading that and it seemed to say different | 13:30 |
| bauzas | because I think the current forced_hosts thing is already weirdo | 13:30 |
| cdent | could/should we reorder when force_host happens? | 13:30 |
| johnthetubaguy | so its a test thats confirm we can build on "both" nodes I guess? | 13:31 |
| bauzas | cdent: or just accepting [] for forced_hosts that's it :) | 13:31 |
| johnthetubaguy | is thats whats failing here? | 13:31 |
| bauzas | johnthetubaguy: it's failing because it forces to a destination using the --az hack that I *HATE* | 13:31 |
| *** baoli has joined #openstack-nova | 13:31 | |
| *** baoli has quit IRC | 13:31 | |
| bauzas | johnthetubaguy: given the subnode is not yet providing its resources to placement, the placement call returns [] which fails later when looking at forced_hosts | 13:32 |
| sfinucan | johnthetubaguy, raj_singh: could you enlighten me as to the purpose of these three lines https://github.com/openstack/nova/blob/master/nova/conf/neutron.py#L116-L118 | 13:32 |
| johnthetubaguy | right, so thats a bigger issue though, we would want to the subnode to be providing its resources already, I assume? | 13:32 |
| bauzas | johnthetubaguy: that's what we ask | 13:32 |
| sfinucan | I'm guessing they refer to the various version of the neutron API and we only need one, but that's a guess | 13:32 |
| sfinucan | https://github.com/openstack/watcher/blob/695ddf8ae7a2dccff4c62a28821888b7d49e2338/watcher/conf/_opts.py#L58 | 13:33 |
| bauzas | johnthetubaguy: in theory, you have to configure your computes to talk to the placement service even if they're Newton | 13:33 |
| bauzas | or you'd not get them when calling the placement | 13:33 |
| *** claudiub|2 has joined #openstack-nova | 13:33 | |
| johnthetubaguy | sfinucan: its what is done for neutron, it describes all the setting you can have for the password keystoneauth settings (i.e register_auth_conf_options), AFAIK | 13:33 |
| *** moshele has quit IRC | 13:34 | |
| *** Jeffrey4l has joined #openstack-nova | 13:35 | |
| cdent | bauzas: I thought the point of option 4 was that was causing the subnode to have placement in newton | 13:36 |
| bauzas | cdent: yup | 13:36 |
| *** claudiub has quit IRC | 13:36 | |
| cdent | so will that fix the force_host test? | 13:37 |
| *** tbachman has quit IRC | 13:38 | |
| johnthetubaguy | cdent: thats what I was assuming too, feel like I am missing a bit | 13:38 |
| *** baoli has joined #openstack-nova | 13:38 | |
| cdent | johnthetubaguy: yeah, exactly, I've not a clear hi-res picture of the situation | 13:38 |
| johnthetubaguy | unless the newton compute nodes are not providing placement with enough information, because of the new APIs we added this cycle? | 13:38 |
| *** baoli has quit IRC | 13:39 | |
| johnthetubaguy | certainly feel like the is a big piece I am missing here | 13:39 |
| johnthetubaguy | there | 13:39 |
| *** baoli has joined #openstack-nova | 13:39 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Use a service account to make vendordata requests. https://review.openstack.org/415597 | 13:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Cache boot time roles for vendordata. https://review.openstack.org/417780 | 13:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Optionally make dynamic vendordata failures fatal. https://review.openstack.org/416391 | 13:40 |
| *** tbachman has joined #openstack-nova | 13:40 | |
| sfinucan | johnthetubaguy: Appears those v2password, v3password lines refer to (keystone?) plugins https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/conf.py#L46 | 13:41 |
| johnthetubaguy | sfinucan: yeah, the auth config is pluggable | 13:42 |
| sfinucan | Blindly copied and pasted and ran genconfig without issue | 13:42 |
| sfinucan | ...so I think we're good | 13:42 |
| *** lpetrut has quit IRC | 13:42 | |
| johnthetubaguy | sfinucan: its consistent now, which I guess is good | 13:42 |
| sfinucan | So long as it's consistently correct :) | 13:42 |
| *** vsaienko has quit IRC | 13:43 | |
| johnthetubaguy | I am OK with consistently wrong, over in-consistently wrong, but maybe I am in a funny mood | 13:43 |
| *** gabor_antal has quit IRC | 13:45 | |
| cdent | bauzas, johnthetubaguy so looking at that grenade run, it appears that placement was not configured on the old side. Was the change in option 4 supposed to cause that? | 13:45 |
| *** bkopilov has joined #openstack-nova | 13:45 | |
| bauzas | cdent: I'm writing an email | 13:46 |
| bauzas | cdent: you'll see my thoughts | 13:46 |
| cdent | k | 13:47 |
| bauzas | after thinking more of that, I think we hit the bigger problem that johnthetubaguy said | 13:47 |
| johnthetubaguy | I think its time for option 3 | 13:47 |
| bauzas | which is that we need to ask operators to modify their compute configuration before upgrading | 13:47 |
| johnthetubaguy | but if we limit it only for during an upgrade, that feels better than raw option 3, like option 3.11 or something | 13:47 |
| bauzas | johnthetubaguy: could you please reply to my email I'm sending in 2 mins ? | 13:48 |
| * johnthetubaguy hangs head in shame at DOS joke | 13:48 | |
| johnthetubaguy | bauzas: sure | 13:48 |
| cdent | I wish I understood why it is hard to set the config on the subnode | 13:49 |
| bauzas | johnthetubaguy: cdent: so I just sent my email | 13:50 |
| bauzas | tl;dr: I think we have 2 problems, one being larger than other | 13:50 |
| *** jheroux has joined #openstack-nova | 13:51 | |
| bauzas | the fact that if you force a destination it fails is to me a corner case that can easily be tackled if we make the scheduler more defensive | 13:51 |
| bauzas | but | 13:51 |
| *** efried has joined #openstack-nova | 13:52 | |
| bauzas | it raises the main issue that it requires nova.conf to be updated for all your computes before you upgrade to Ocata, and that's a larger action item than the one we stated in the upgrade process http://docs.openstack.org/developer/nova/upgrade.html#rolling-upgrade-process | 13:52 |
| bauzas | where we only ask for modifying the upgrade_levels flag | 13:52 |
| bauzas | and even that | 13:52 |
| *** ducttape_ has quit IRC | 13:53 | |
| bauzas | cdent: johnthetubaguywe all supposed that a rolling upgrade means that you can only focus on upgrading your controller without touching the computes (unless just upgrading them to the latest stable release) | 13:53 |
| bauzas | johnthetubaguy: $ | 13:53 |
| bauzas | snap, I'm wearing gloves | 13:53 |
| bauzas | that's cold here, but not a reason | 13:53 |
| cdent | We've known for a few months that there will be config change on the compute nodes, it's part of why we made the upgrade ready script, isn't it? | 13:54 |
| * cdent reads the email | 13:55 | |
| *** eharney has quit IRC | 13:55 | |
| bauzas | cdent: tbh, I never identified that it would require a nova.conf change on old computes | 13:56 |
| edleafe | bauzas: what change is required? | 13:57 |
| cdent | we've said for a long time that newton computes will need to run placement before the ocata upgrade | 13:57 |
| cdent | in order ot set inventory | 13:57 |
| cdent | and in order to set inventory you have to have the [placement] section in nova.conf | 13:57 |
| cdent | edleafe: it contains the auth bits to do placement service discovery | 13:57 |
| bauzas | edleafe: what cdent just said | 13:57 |
| bauzas | cdent: are we sure we are going to ask operators to modify all their computes nova.conf before upgrading ? | 13:58 |
| edleafe | cdent: but isn't that what "have to run the placement service" would entail? | 13:58 |
| cdent | edleafe: yes, exactly and thus bauzas: yes! | 13:59 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [cli] Use environment variable for token https://review.openstack.org/425647 | 13:59 |
| cdent | bauzas: we act like this is a big deal because we pretend like someone, the day after feature freeze is going to upgrade to ocata, but that's rarely the case | 14:00 |
| cdent | people will be upgrading to newton while we are nearly finished fixing bugs in ocata | 14:00 |
| edleafe | cdent: ok, that's what I thought. I felt I was missing bauzas concern | 14:00 |
| *** bvanhav has quit IRC | 14:00 | |
| edleafe | So... nova meeting? | 14:01 |
| bauzas | I dunno | 14:01 |
| bauzas | in theory yes | 14:01 |
| bauzas | lemme see if there is an agenda | 14:01 |
| johnthetubaguy | I vote we skip the meeting, seems like we are having it here | 14:02 |
| cdent | johnthetubaguy: makes good sense given the day it is | 14:02 |
| *** kfarr has quit IRC | 14:02 | |
| edleafe | no argument from me | 14:02 |
| bauzas | so the agenda is not up to date | 14:03 |
| bauzas | I could just open the meeting, do a vote for skipping it and leave us coming back here ? | 14:03 |
| edleafe | bauzas: go for it | 14:04 |
| sfinucan | aye, I vote skip | 14:04 |
| *** ekuris__ has joined #openstack-nova | 14:04 | |
| *** bvanhav has joined #openstack-nova | 14:05 | |
| *** esberglu has quit IRC | 14:05 | |
| *** esberglu has joined #openstack-nova | 14:06 | |
| *** ekuris_ has quit IRC | 14:06 | |
| *** esberglu has quit IRC | 14:07 | |
| *** mdrabe has joined #openstack-nova | 14:07 | |
| *** esberglu has joined #openstack-nova | 14:07 | |
| openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(6): Introduce base PowerVM driver (ssp drv) https://review.openstack.org/422594 | 14:10 |
| *** vsaienko has joined #openstack-nova | 14:10 | |
| johnthetubaguy | bauzas: I replied to your email | 14:11 |
| bauzas | johnthetubaguy: ack | 14:11 |
| *** cleong has joined #openstack-nova | 14:12 | |
| *** ducttape_ has joined #openstack-nova | 14:13 | |
| *** esberglu has quit IRC | 14:14 | |
| *** haplo37_ has quit IRC | 14:15 | |
| *** esberglu has joined #openstack-nova | 14:16 | |
| *** hfu has joined #openstack-nova | 14:17 | |
| *** haplo37_ has joined #openstack-nova | 14:18 | |
| *** vsaienko has quit IRC | 14:20 | |
| claudiub|2 | sfinucan: ehm, it seems moshele isn't online atm, so can you take a look at the hyper-v pci passthrough patch and see if my answers seem reasonable to you? Thanks! https://review.openstack.org/#/c/420614/7 | 14:21 |
| *** tblakes has joined #openstack-nova | 14:22 | |
| *** vsaienko has joined #openstack-nova | 14:26 | |
| *** eharney has joined #openstack-nova | 14:27 | |
| *** gouthamr has joined #openstack-nova | 14:29 | |
| *** vsaienko has quit IRC | 14:29 | |
| dansmith | johnthetubaguy: only /you/ can send this to its happy place: https://review.openstack.org/#/c/319379/ | 14:29 |
| johnthetubaguy | dansmith: looking | 14:30 |
| *** vsaienko has joined #openstack-nova | 14:30 | |
| *** liverpooler has joined #openstack-nova | 14:30 | |
| sfinucan | claudiub|2: Sure thing | 14:30 |
| *** _ducttape_ has joined #openstack-nova | 14:31 | |
| *** ducttape_ has quit IRC | 14:32 | |
| bauzas | the gate is 3 hours late, not a big deal | 14:32 |
| bauzas | for a FF day :p | 14:32 |
| *** vladikr has joined #openstack-nova | 14:33 | |
| *** smatzek has quit IRC | 14:33 | |
| bauzas | dansmith: I'm maybe particularly exhausted and short-sighted but have we agreed to ask operators to modify their nova.conf to amend placement section in newton before upgrading ? | 14:33 |
| dansmith | bauzas: didn't we agree to that like weeks ago? | 14:34 |
| *** hshiina has quit IRC | 14:34 | |
| bauzas | I think I'm nervous | 14:34 |
| dansmith | if not, I'm not sure why we're doing all of this :) | 14:34 |
| bauzas | and I think my brain is litterally getting me mad | 14:34 |
| dansmith | I'm nervous that we might have to wait until pike to deliver any measurable scheduler improvement | 14:35 |
| dansmith | by the way, | 14:35 |
| dansmith | cdent: I know jaypipes did some scheduler benchmarking early on to test the sql-based approach, but do you know if anyone has measured the performance of the potentially large http queries the scheduler will be making? Like, under load with a large cloud... | 14:36 |
| dansmith | I was thinking about that last night | 14:36 |
| cdent | dansmith: have you seen the mail I sent last night on a similar topic | 14:37 |
| claudiub|2 | dansmith: does this help? 2017-01-26 03:04:14.169 2780 WARNING nova.scheduler.client.report [req-b2db1cb5-b647-4e48-b939-b0dfd7509e17 - - - - -] No authentication information found for placement API. Placement is optional in Newton, but required in Ocata. Please enable the placement service before upgrading. | 14:37 |
| dansmith | claudiub|2: help what? | 14:37 |
| bauzas | dansmith: nothing really yet AFAIU | 14:37 |
| bauzas | we haven't tested yet the performance, only what yingxin and jay did | 14:37 |
| claudiub|2 | a, sorry, bauzas asked about the placement section in nova.conf. my bad. :) | 14:38 |
| cdent | dansmith: my calculations are ~250 requests per second on a 1000 compute node cluster with 10 instances per node | 14:38 |
| cdent | that vast majority of those GETs | 14:38 |
| dansmith | claudiub|2: ah, yeah, that.. we added that warning to help exactly that, yeah :) | 14:38 |
| johnthetubaguy | dansmith: are you very against doing scheduling the old way, but only until all compute nodes are upgraded? (a modified option 3) | 14:38 |
| bauzas | okay, we need to move on | 14:38 |
| cdent | and many of them redudant, with a few minor fixes to the resource_tracker (all in the email dansmith) | 14:38 |
| dansmith | cdent: ah, okay, that's a pretty high rate right? | 14:38 |
| dansmith | cdent: yeah, looking now | 14:38 |
| cdent | dansmith: yes | 14:38 |
| bauzas | I'll at least work on trying to have the force_hosts thing to accept an empty list | 14:39 |
| johnthetubaguy | is that without any builds happening? | 14:39 |
| dansmith | johnthetubaguy: I have been yeah | 14:39 |
| cdent | johnthetubaguy: yes, that's after the builds are done and change has frozen | 14:39 |
| johnthetubaguy | dansmith: don't get me wrong, I would love to do a clean switch, but I would rather that than not land it | 14:39 |
| cdent | but it can be cut _way_ back with a few changes. halfed with a bug fix that's already in progress | 14:39 |
| johnthetubaguy | cdent: that sounds like a worthy aim | 14:40 |
| cdent | in order to make one fix, I/someone needs to understand why tracked_instances in the resource tracker is being cleared on every periodic job | 14:40 |
| dansmith | cdent: okay, but also, we can scale that horizontally | 14:40 |
| cdent | if that clear() doesn't happen, the number of requests can drop, alot | 14:41 |
| cdent | dansmith: yeah, which is nicely easy | 14:41 |
| dansmith | johnthetubaguy: the problem with that is that I think people will rely on that crutch | 14:41 |
| cdent | yeah, that crutch is something we've been wanting to avoid | 14:41 |
| *** esberglu has quit IRC | 14:41 | |
| dansmith | johnthetubaguy: but, if we check service_version and only do the fallback if there are old nodes, maybe that's a thing | 14:41 |
| johnthetubaguy | dansmith: thats the one I was meaning | 14:41 |
| dansmith | johnthetubaguy: that way once they've updated everything then they're stuck | 14:41 |
| johnthetubaguy | dansmith: only during upgrade, allow the fallback | 14:41 |
| johnthetubaguy | we should totally not fallback once we are upgraded | 14:42 |
| dansmith | cdent: I know, I really want to avoid the crutch | 14:42 |
| bauzas | we all want to avoid the crutch | 14:42 |
| bauzas | (whatever the word means for a non-English speaking person) | 14:42 |
| dansmith | but, if we give them a crutch that is half cut through so that it breaks once they walk out the door | 14:42 |
| * johnthetubaguy is now thinking about tiny tim from muppet christmas carol | 14:42 | |
| johnthetubaguy | dansmith: thats the one | 14:43 |
| johnthetubaguy | dansmith: like trolley wheels that lock on if you steal the trolley | 14:43 |
| bauzas | johnthetubaguy: dansmith: I can propose something about a conditional branch verifying the service version | 14:43 |
| bauzas | and if you upgrade all your computes, then good luck | 14:43 |
| johnthetubaguy | bauzas: thats what I suggested on the ML anyways (at least thats what I tried to suggest) | 14:43 |
| *** Jeffrey4l has quit IRC | 14:44 | |
| dansmith | johnthetubaguy: by trolley you mean "shopping cart" right? | 14:44 |
| bauzas | johnthetubaguy: well, I mentioned that also in my email as a conclusion, but I said we turned down the idea | 14:44 |
| *** Jeffrey4l has joined #openstack-nova | 14:44 | |
| bauzas | johnthetubaguy: if we revise that to something acceptable, then I can surely implement it | 14:44 |
| bauzas | but I'd love to see some quorum here | 14:44 |
| dansmith | cdent: what do you think about that? | 14:44 |
| * cdent catches up | 14:45 | |
| dansmith | cdent: I'll summarize | 14:45 |
| dansmith | cdent: we can detect if all the computes have been upgraded or not, | 14:45 |
| dansmith | cdent: and so we could fall back on the crutch until that point, and then go scorched-earth after that and refuse to look at anything other than placement | 14:45 |
| *** mlavalle has joined #openstack-nova | 14:46 | |
| dansmith | cdent: which would solve our current problem and not let anyone (reasonably) keep from using placement in ocata | 14:46 |
| dansmith | most people that don't do full-on live upgrades would have to deploy placement immediately (i.e. the tripleo types) | 14:46 |
| cdent | so each resource tracker would say "are all my peers up to date with me?" and if not, they'd use the old method of handling inventory? | 14:46 |
| dansmith | no, | 14:46 |
| dansmith | computes would all do placement and RT all the time like they do now, | 14:46 |
| dansmith | but scheduler would refuse to look at the RT data once all the computes are upgraded | 14:47 |
| dansmith | so it would just be a change in bauzas' patch | 14:47 |
| cdent | but the problem we're having right now is computes that _may_ be upgraded, but haven't changed their configuration? | 14:47 |
| bauzas | lemme fire a patch ip | 14:47 |
| bauzas | so cdent can see | 14:47 |
| bauzas | I mean a diff pastebin | 14:47 |
| cdent | I understand the change, I'm just not clear if it covers all the issues | 14:47 |
| *** _ducttape_ has quit IRC | 14:47 | |
| dansmith | I'm pretty sure it does | 14:48 |
| *** pbandark has quit IRC | 14:48 | |
| johnthetubaguy | so we might need one step worse... | 14:48 |
| johnthetubaguy | the placement data will be incomplete | 14:48 |
| johnthetubaguy | so we could use the crutch all the time, until the upgrade has completed | 14:48 |
| dansmith | johnthetubaguy: right you'd have to favor the RT data until the time when you switch | 14:48 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | 14:48 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 14:48 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 14:48 |
| dansmith | johnthetubaguy: the downside is that it makes the switch to different data non-obvious, so people may not know why things are suddenly being different, | 14:49 |
| dansmith | just because a lab monkey upgraded the last one | 14:49 |
| johnthetubaguy | yeah | 14:49 |
| * cdent aligns things in his brain | 14:49 | |
| bauzas | easy peasy question, can someone tell me the minimum service version for Ocata computes ? | 14:49 |
| bauzas | we don't comment that in the SERVICE_VERSION_HISTORY dict | 14:49 |
| dansmith | johnthetubaguy: we could log all-caps WARNING messages whilst using the crutch :) | 14:50 |
| johnthetubaguy | bauzas: technically, you might want to bump that, so you know everyone has your patch | 14:50 |
| dansmith | bauzas: yes, it's easy | 14:50 |
| bauzas | johnthetubaguy: we don't need that | 14:50 |
| cdent | okay, I think I'm caught up with you dansmith: the scheduler is the one that checks if all the compute nodes are up to date, and then makes a choice on what type of scheduling it does, yeah? | 14:50 |
| bauzas | johnthetubaguy: all computes are already able to talk to placement since newton | 14:50 |
| dansmith | bauzas: https://github.com/openstack/nova/blob/stable/newton/nova/objects/service.py#L92 | 14:50 |
| bauzas | johnthetubaguy: I just want to detect a fresh code | 14:50 |
| *** d-bark has quit IRC | 14:50 | |
| cdent | bauzas: but only if they have the config... | 14:50 |
| dansmith | cdent: yes | 14:50 |
| *** mtanino has joined #openstack-nova | 14:51 | |
| bauzas | cdent: but we say they need to upgrade to ocata, right? | 14:51 |
| johnthetubaguy | so does a compute node die if it doesn't have placement configured? | 14:51 |
| bauzas | dansmith: okay, so I need to set a new version | 14:51 |
| *** vsaienko has quit IRC | 14:51 | |
| bauzas | johnthetubaguy: nope | 14:51 |
| dansmith | will ocata computes fail to start if the placement config is not done? | 14:51 |
| cdent | bauzas: yes, but earlier you were complaining that making people change their configs to upgrade to ocata was in violation? | 14:51 |
| *** hfu has quit IRC | 14:51 | |
| dansmith | bauzas: I dunno what a new version would signal, TBH | 14:51 |
| *** mtanino has quit IRC | 14:52 | |
| snikitin | sfinucan: Hi! thank you for comments! I updated https://review.openstack.org/#/c/399613 | 14:52 |
| dansmith | bauzas: if they don't die, then maybe we should make them die and make that a new service version, and then check for that version in the scheduler | 14:52 |
| bauzas | dansmith: good question about nova computes refusing to start | 14:52 |
| bauzas | dansmith: I agree with that plan | 14:52 |
| johnthetubaguy | cdent: its not as bad, because the old compute could have had that same config, but its sure borderline | 14:52 |
| dansmith | I think it's what johnthetubaguy was saying too | 14:52 |
| bauzas | dansmith: that's the move defensive one | 14:52 |
| johnthetubaguy | yeah, make it obvious things are bad | 14:53 |
| snikitin | alex_xu: Hi Alex! I got two +2 on this patch https://review.openstack.org/#/c/394480/ can I get a +W, please? | 14:53 |
| dansmith | johnthetubaguy: do you think it's too borderline? | 14:53 |
| bauzas | but we said placement is mandatory for ocata, right? | 14:53 |
| dansmith | johnthetubaguy: I feel like we've already agreed we're going to make this decision | 14:54 |
| bauzas | so that means you have to access it when restarting your services | 14:54 |
| dansmith | right | 14:54 |
| dansmith | what bauzas said | 14:54 |
| dansmith | and we're logging on newton | 14:54 |
| johnthetubaguy | dansmith: I think I am OK because we get a massive gain, so we stick with it | 14:54 |
| bauzas | here, we're just trying to allow newton computes that are untouched to still be able to get instances on them | 14:54 |
| dansmith | johnthetubaguy: but really, it was optional in newton, required in ocata, and this is just enforcing that no? | 14:54 |
| bauzas | dansmith: to summarize, if I'm bumping the service version now, that would mean I'm sure the service is upgraded to ocata | 14:55 |
| johnthetubaguy | dansmith: I think the key bit that makes me OK, is they just need to update the config on the old system before they do the upgrade, if they haven't done that | 14:55 |
| mriedem | o/ | 14:55 |
| dansmith | bauzas: you don't need to bump it now, but if you're going to make the computes refuse to start, I'd call that a service version.. otherwise you're adding a number that doesn't have any real meaning | 14:56 |
| bauzas | now, the only question would be : should we silently soft-fail and do nothing with the risk for operators that they could loose capacity if they misconfigure ? | 14:56 |
| johnthetubaguy | big fire, always the big fire | 14:56 |
| dansmith | johnthetubaguy: right, and they could have done that in newton months ago if they wanted to be proactive | 14:56 |
| bauzas | dansmith: the thing is that we haven't bumped the version in Ocata | 14:56 |
| johnthetubaguy | dansmith: yeah, I think thats what makes me OK with it | 14:56 |
| dansmith | bauzas: not at all? | 14:56 |
| bauzas | dansmith: I'm still seeing version 15 in my local master branch | 14:56 |
| dansmith | mriedem: read back to my "let me summarize" comment to cdent | 14:56 |
| mriedem | what are we doing with a min service version check? | 14:57 |
| dansmith | bauzas: then yes you need to add one | 14:57 |
| johnthetubaguy | yeah, just add one | 14:57 |
| dansmith | mriedem: thinking we will add a fallback to RT data _if_ the computes are not all upgraded | 14:57 |
| bauzas | on it | 14:57 |
| dansmith | mriedem: in the scheduler | 14:57 |
| bauzas | and we hard-fail, as johnthetubaguy said | 14:57 |
| dansmith | mriedem: which will let us get past grenade, and give the deployers a little longer grace period | 14:57 |
| *** BobBall is now known as BobBall_AWOL | 14:57 | |
| *** markvoelker has joined #openstack-nova | 14:57 | |
| dansmith | mriedem: once they upgrade all their computes, scheduler will stop looking at RT data | 14:58 |
| *** owalsh is now known as owalsh-afk | 14:58 | |
| dansmith | mriedem: which means if they only change config during the upgrade they will still be fine | 14:58 |
| dansmith | mriedem: whereas before, we had to make them configure their newton computes before starting the controller upgrade | 14:58 |
| mriedem | we only fallback if we don't get any RPs *and* minimum compute isn't new enough right? | 14:59 |
| sfinucan | claudiub|2: I looked at that and it seems fine, but I think one of Moshe's questions still stands | 14:59 |
| dansmith | mriedem: no we have to always fallback if computes are old | 14:59 |
| mriedem | so don't even check placement until then? | 14:59 |
| johnthetubaguy | otherwise you get incomplete data, and the test we want to pass will still fail | 14:59 |
| sfinucan | ...and I don't think I can approve until one of ye proves it's not a problem :) | 14:59 |
| dansmith | mriedem: because otherwise after one compute reports RPs you'd hard switch and have a 1-compute cloud | 15:00 |
| mriedem | johnthetubaguy: the test would pass if we would fallback to computenodelist.get_all if there were 0 RPs, but yes i understand we'd have a 1 compute cloud for awhile | 15:00 |
| mriedem | fwiw we talked about that weeks ago and people thought that was ok and a small window | 15:00 |
| johnthetubaguy | mriedem: I was thinking the force host thing, but yeah | 15:01 |
| dansmith | mriedem: I think that was about waiting for the 60-second timer, | 15:01 |
| dansmith | mriedem: but it could be weeks if you upgrade one compute as a test | 15:01 |
| dansmith | mriedem: in this scenario | 15:01 |
| mriedem | dansmith: was refering to this http://lists.openstack.org/pipermail/openstack-dev/2016-December/109060.html | 15:03 |
| sfinucan | snikitin: Done and done | 15:04 |
| mriedem | but whatever, that was before we had a blocking issue with grenade | 15:04 |
| dansmith | mriedem: right but that was a thing that is triggered by doing the controller upgrade, right? this would be a thing triggered by the first compute upgrade | 15:04 |
| sfinucan | claudiub|2: Call me a fool, but wasn't this kind of request what we were implementing qualitative resources for? https://review.openstack.org/#/c/420960 | 15:05 |
| snikitin | sfinucan, thanks! | 15:06 |
| dansmith | mriedem: meaning, I think before we were assuming 1. Configure computes for placement, 2. upgrade controllers, 3. wait 60s for data to filter before scheduling works properly | 15:06 |
| sfinucan | johnthetubaguy: would it be too cheeky of me to +2 this, given that I addressed comments on it? https://review.openstack.org/#/c/415597 | 15:06 |
| claudiub|2 | sfinucan: sure, but that is being used for the ImageMetaProps object. that still has to exist | 15:06 |
| dansmith | mriedem: now, it would be 1. upgrade controllers, 2. upgrade one compute, 3. stuck until you upgrade more computes | 15:06 |
| sfinucan | claudiub|2: Ah, that's how the instance would request those properties while resource providers is for hosts publishing that information | 15:07 |
| claudiub|2 | yep | 15:08 |
| sfinucan | gotcha | 15:08 |
| *** jaypipes_ has quit IRC | 15:08 | |
| mriedem | dansmith: maybe, i know there have been several threads on this, and basically at this point those don't really matter :) | 15:08 |
| dansmith | aye | 15:08 |
| mriedem | i'm just reading back through the responses from the ML from earlier today | 15:08 |
| sfinucan | snikitin: If you could take a look at https://review.openstack.org/#/c/405954/ (and the follow up) today, I'd appreciate it. Think you should know enough about that code to comment | 15:09 |
| *** smatzek has joined #openstack-nova | 15:09 | |
| *** esberglu has joined #openstack-nova | 15:09 | |
| johnthetubaguy | sfinucan: usually I would say no, depends how you feel I guess. | 15:09 |
| sfinucan | johnthetubaguy: Sweet - I'll go for it so. It looks good and would be good to get it in | 15:10 |
| snikitin | sfinucan, sure | 15:10 |
| *** lpetrut has joined #openstack-nova | 15:10 | |
| * sfinucan hopes mikal gives out prizes | 15:10 | |
| bauzas | dansmith: question, what should I hard-fail ? | 15:11 |
| bauzas | dansmith: just that the placement section is empty, or that we aren't able to call the placement API by doing a query? | 15:11 |
| *** moshele has joined #openstack-nova | 15:11 | |
| bauzas | dansmith: I'd favor a real test call | 15:11 |
| dansmith | bauzas: just that the config isn't there I think | 15:12 |
| dansmith | bauzas: doing a real call in the middle of init_host to check that and failing would be terrible | 15:12 |
| dansmith | bauzas: because if it fails for some legit reason, computes wouldn't start | 15:12 |
| bauzas | dansmith: okay | 15:12 |
| mriedem | what do we need to touch init_host in the compute for? | 15:13 |
| bauzas | mriedem: for preventing ocata computes to start if they haven't filled in their placement section | 15:13 |
| dansmith | mriedem: to drive home that placement config is required | 15:14 |
| dansmith | mriedem: i.e. like anything else, there's not much point in starting if we don't have sufficient config to do anything | 15:14 |
| claudiub|2 | sfinucan: so, VFs / PFs won't show up as assignable PCI devices, rather those are requested from Hyper-V, and Hyper-V will then assign them to the VMs. | 15:14 |
| *** mtanino has joined #openstack-nova | 15:14 | |
| sfinucan | claudiub|2: as what? VIFs? | 15:14 |
| johnthetubaguy | bauzas: +1 what dansmith said, that sounds right | 15:14 |
| bauzas | johnthetubaguy: dansmith: and it would raise an exception if not CONF.placement? | 15:15 |
| mriedem | ok so the grenade case should be ok b/c newton subnode will be running and ocata compute will have config so will start | 15:15 |
| *** moshele has quit IRC | 15:15 | |
| dansmith | mriedem: right | 15:15 |
| mriedem | but scheduler will use the old RT data because of the newton compute | 15:15 |
| dansmith | yes | 15:15 |
| claudiub|2 | sfinucan: yeah. The vif has a property - if it SR-IOV is enabled for it or not. by default it is false. | 15:16 |
| dansmith | bauzas: yes, or whatever will arrest init_host cleanly | 15:16 |
| bauzas | dansmith: that's my question | 15:16 |
| bauzas | dansmith: should we log and stop ? | 15:16 |
| bauzas | or should we more like "sorry dude" | 15:16 |
| dansmith | I dunno what that means | 15:16 |
| bauzas | heh | 15:16 |
| bauzas | I mean | 15:16 |
| bauzas | two choices | 15:16 |
| *** hfu has joined #openstack-nova | 15:16 | |
| bauzas | #1 log an ERROR and return | 15:16 |
| bauzas | #2 raise an exception | 15:17 |
| bauzas | I'd favor #1 | 15:17 |
| dansmith | bauzas: that won't stop compute from starting | 15:17 |
| dansmith | that will just leave it further hamstrung | 15:17 |
| bauzas | okay, lemme see how init_host is working | 15:17 |
| mriedem | an unhandled exception from init_host will kill the nova-compute process | 15:18 |
| mriedem | which i think is the goal | 15:18 |
| mriedem | meaning you upgraded the code to ocata but didn't configure it properly, | 15:18 |
| mriedem | so you need to get paged | 15:18 |
| dansmith | right, only an exception will stop it from what I see | 15:18 |
| bauzas | okay, that's my question | 15:19 |
| bauzas | because it's threaded ? | 15:19 |
| *** sahid has quit IRC | 15:19 | |
| dansmith | bauzas: so just raise an exception, which will be ugly, and we could maybe clean that up in service.py after the fact to make it a little less ugly on the eyes | 15:19 |
| bauzas | I mean gt | 15:19 |
| dansmith | nothing related to threading | 15:19 |
| bauzas | anyway | 15:19 |
| bauzas | let's do the exception | 15:19 |
| *** stvnoyes1 has quit IRC | 15:19 | |
| bauzas | no time for introspecting the caller :) | 15:19 |
| *** takashin has left #openstack-nova | 15:20 | |
| *** pkoniszewski_ has joined #openstack-nova | 15:20 | |
| mriedem | i guess https://review.openstack.org/#/c/425524/ didn't work huh | 15:20 |
| *** stvnoyes has joined #openstack-nova | 15:20 | |
| *** sahid has joined #openstack-nova | 15:20 | |
| dansmith | I didn't look, this conversation was going on when I showed up | 15:21 |
| dansmith | however, | 15:21 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Fixed indentation in virt/libvirt/driver.py https://review.openstack.org/425748 | 15:21 |
| pkoniszewski_ | hey, can i have -W/+W there https://review.openstack.org/#/c/407518/ ? jenkins does not want to start gate job for some reason | 15:21 |
| dansmith | the moreI explain it the more I think it's probably the better option anyway | 15:21 |
| *** hongbin has joined #openstack-nova | 15:21 | |
| mriedem | bauzas: you can remove the dependency on https://review.openstack.org/#/c/425524/ when you respin your nova scheduler change, | 15:21 |
| mriedem | it didn't work anyway | 15:21 |
| cdent | mriedem: I checked into the grenade job and as far as I could tell, the subnode wasn't getting config'd, still | 15:22 |
| mriedem | cdent: yeah it wasn't | 15:22 |
| mriedem | that features yaml is all magic to me | 15:22 |
| * cdent nods | 15:22 | |
| bauzas | mriedem: ack | 15:22 |
| pkoniszewski_ | sfinucan: hi, are you around? | 15:23 |
| sfinucan | pkoniszewski_: aye | 15:23 |
| pkoniszewski_ | sfinucan: can i have -W/+W there https://review.openstack.org/#/c/407518/ ? jenkins does not want to start gate job for some reason | 15:23 |
| *** claudiub has joined #openstack-nova | 15:24 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Change exponential function to linear https://review.openstack.org/407518 | 15:24 |
| *** claudiub|2 has quit IRC | 15:24 | |
| sfinucan | pkoniszewski_: done | 15:24 |
| pkoniszewski_ | sfinucan: thanks! | 15:24 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | 15:25 |
| *** claudiub has quit IRC | 15:26 | |
| *** claudiub|2 has joined #openstack-nova | 15:26 | |
| dansmith | I think we probably need to touch the oslo service stuff to make a really graceful exit from service startup | 15:27 |
| *** ociuhandu has quit IRC | 15:27 | |
| dansmith | actually, no | 15:27 |
| mriedem | i don't think so, | 15:28 |
| mriedem | we had a bug where the pci whitelist parser was blowing up, | 15:28 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V PCI Passthrough https://review.openstack.org/420614 | 15:28 |
| mriedem | and that just killed the process | 15:28 |
| mriedem | ^ came from the RT on init_host | 15:28 |
| dansmith | mriedem: no I mean to avoid a traceback | 15:28 |
| mriedem | oh | 15:28 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Allow graceful service exits from compute https://review.openstack.org/425751 | 15:29 |
| *** psachin has quit IRC | 15:29 | |
| dansmith | mriedem: something like this ^ to clean up what bauzas is adding now .. but later | 15:29 |
| bauzas | dansmith: I'm just writing UTs and then boooom | 15:30 |
| sfinucan | claudiub|2: OK, I'd still like Moshe to jump in but I'm personally happy with that as is | 15:30 |
| *** owalsh-afk is now known as owalsh | 15:30 | |
| claudiub|2 | sfinucan: cool, thanks! :D | 15:30 |
| bauzas | dansmith: you okay if I'm just shamely copying your exception ? | 15:30 |
| claudiub|2 | sfinucan: will try to reach out to him as well, as soon as possible. | 15:30 |
| bauzas | dansmith: mine is too much explicit (PlacementNotConfigured) | 15:31 |
| sfinucan | Side note: we *really* need to find a way to standardized flavor extra specs like we do ImageMetaData | 15:31 |
| bauzas | dansmith: but I was basically doing the same, including the try/except clause in the cmd | 15:31 |
| *** jaosorior has joined #openstack-nova | 15:31 | |
| *** sacharya has joined #openstack-nova | 15:31 | |
| *** iceyao has quit IRC | 15:32 | |
| mriedem | i don't think create() is the correct method to handle, | 15:33 |
| mriedem | that just creates the service object, | 15:33 |
| dansmith | bauzas: just use something else and we can merge my graceful bit later and I will clean it up | 15:33 |
| mriedem | start() is the thing that blows up | 15:33 |
| *** mdrabe has quit IRC | 15:33 | |
| bauzas | dansmith: okay | 15:34 |
| dansmith | mriedem: yep, you're right | 15:34 |
| dansmith | mriedem: but I think I want to catch around both | 15:34 |
| dansmith | mriedem: in case we had to abort in low-level init or something | 15:34 |
| mriedem | i just don't know if serve() or wait() calls start() | 15:34 |
| andreykurilin | johnthetubaguy: I answered all your comments and all both patches are vaiting for your review:) | 15:34 |
| dansmith | serve calls launch | 15:34 |
| dansmith | which calls start I think | 15:34 |
| dansmith | this is why I made it fail so we can see :) | 15:35 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Allow graceful service exits from compute https://review.openstack.org/425751 | 15:35 |
| *** burgerk has joined #openstack-nova | 15:35 | |
| *** READ10 has joined #openstack-nova | 15:35 | |
| *** stevemar has quit IRC | 15:36 | |
| *** armax has joined #openstack-nova | 15:37 | |
| *** stevemar has joined #openstack-nova | 15:37 | |
| *** catintheroof has joined #openstack-nova | 15:39 | |
| *** claudiub has joined #openstack-nova | 15:40 | |
| *** vsaienko has joined #openstack-nova | 15:41 | |
| cdent | mriedem: if we stick to one full circle, I think we should consider that a win | 15:41 |
| mriedem | heh | 15:42 |
| openstackgerrit | melanie witt proposed openstack/nova: Count resources to check quota for cells https://review.openstack.org/416521 | 15:42 |
| mriedem | sfinucan: if you're looking for things, https://review.openstack.org/#/c/404990/ and the one after it have +2s | 15:42 |
| mriedem | pretty simple | 15:42 |
| *** claudiub|2 has quit IRC | 15:42 | |
| *** catinthe_ has quit IRC | 15:42 | |
| *** mdrabe has joined #openstack-nova | 15:43 | |
| *** vsaienko has quit IRC | 15:43 | |
| *** yamahata has joined #openstack-nova | 15:44 | |
| *** lpetrut has quit IRC | 15:44 | |
| sfinucan | mriedem: I'll give it a shot | 15:44 |
| *** karimb has quit IRC | 15:44 | |
| *** kfarr has joined #openstack-nova | 15:45 | |
| * sfinucan has veered away from anything that might involve SQL and Alchemy in the same sentence | 15:45 | |
| mriedem | none of that is sqla stuff | 15:45 |
| raj_singh | mriedem: If you have time, I got +2's on last two patches of service token bp. | 15:46 |
| mriedem | even though it's a jaypipes patch | 15:46 |
| mfeoktistov | sfinucan: mriedem: mdbooth: sorry for disturbing you, I updated https://review.openstack.org/#/c/312488/ (rootwrap instead of privsep and small cleanup). Virtuozzo Storage CI fails because we have problem with cinder now, it's not releated to this review. | 15:47 |
| melwitt | johnthetubaguy, mriedem: I took the WIP off the counting quota patch last night after adding more test coverage | 15:47 |
| *** raj_singh_ has joined #openstack-nova | 15:47 | |
| bauzas | interesting, how can I test that I don't have a conf section yet ? | 15:48 |
| *** openstackgerrit has quit IRC | 15:48 | |
| andreykurilin | mriedem bauzas johnthetubaguy: hi all! Do we want to put latest 7.1.0 (which is not released) to u-c ? If yes, there is only ~ 4 hours away now to make a release and propose c change to g-r repo | 15:48 |
| bauzas | I could mock the CONF object tho but I'd prefer to mimic | 15:48 |
| dansmith | bauzas: don't test for the section, test for the keys | 15:48 |
| bauzas | dansmith: same question, how could I unset that ? | 15:48 |
| mriedem | mfeoktistov: +2 | 15:48 |
| mriedem | melwitt: how comfortable are you with the counting quotas stuff? is it too risky at this point? and if counting quotas doesn't get in, should we still block the patches below it to move those other quotas tables to the api db (except reservations and usages)? | 15:49 |
| mriedem | andreykurilin: are the patches all in for novaclient 7.1.0 yet? | 15:50 |
| mriedem | bauzas: by default the tests won't have anything set in the CONF.placement values | 15:50 |
| mdbooth | mfeoktistov: Did you change anything else? | 15:50 |
| mriedem | unless we have defaults | 15:50 |
| *** openstackgerrit has joined #openstack-nova | 15:50 | |
| openstackgerrit | Chris Dent proposed openstack/nova: Add more debug logging on RP inventory update failures https://review.openstack.org/414230 | 15:50 |
| mriedem | mfeoktistov: he moved some small things around it looks like | 15:50 |
| mriedem | mdbooth: ^ | 15:51 |
| mdbooth | IIRC I was +1 on this before, so if they only thing you've change is privsep I'm still +1. | 15:51 |
| cdent | mriedem: that's ^ the long promised test additions to that logging thing you did a while back. with some adjustments | 15:51 |
| * mdbooth will look | 15:51 | |
| andreykurilin | mriedem: only one(+one not critical in the chain) left - https://review.openstack.org/#/c/424256/ . It has one +2 and answered all comments | 15:51 |
| *** lpetrut has joined #openstack-nova | 15:51 | |
| bauzas | mriedem: dansmith: the only problem I see is that we expect keystone config options | 15:51 |
| mriedem | andreykurilin: ok, looks like johnthetubaguy has been reviewing https://review.openstack.org/#/c/424256/ so i'll leave the +W to him | 15:52 |
| bauzas | so I need to verify them | 15:52 |
| melwitt | mriedem: I'm pretty confident in the counting stuff. I think it's no worse than what's already there. we would trade known issues and out-of-sync problems for something with a lot smaller footprint, but obviously has some element of the unknown compared to something we've had for years | 15:52 |
| *** karimb has joined #openstack-nova | 15:52 | |
| mfeoktistov | mdbooth: no, just rootwrap instead of privsep, move two lines of code from libvirt_driver to libvirt_utils and fix tests for it | 15:53 |
| mriedem | bauzas: i think you just need to check for CONF.placement.password | 15:53 |
| mriedem | that *has* to be set | 15:53 |
| bauzas | mriedem: okay, I can just do that | 15:53 |
| melwitt | mriedem: as for the bottom patches, if we assume a single cell, I think it still works, it's just reservations and usages would be in the main db whereas the limits and classes would be in the api db. | 15:53 |
| mriedem | http://logs.openstack.org/72/404472/20/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8aafdf2/logs/etc/nova/nova.conf.txt.gz | 15:53 |
| mriedem | bauzas: ^ for what we set in devstack | 15:54 |
| mriedem | but there are some deprecated things in ksa so i'd just stick with checking for the password option | 15:54 |
| bauzas | mriedem: yup, I know | 15:54 |
| mriedem | like user_id vs username, etc | 15:54 |
| bauzas | mriedem: I'm just hesitating about checking things related to keystone diretly | 15:54 |
| mriedem | and the 10 different ways you can specify a project in ksa | 15:54 |
| mfeoktistov | mdbooth: code which gets default filesystem type from nova conf or ext4 as default value | 15:54 |
| bauzas | mriedem: given we don't verify that by us but instead straight passing it to keystoneauth | 15:54 |
| mdbooth | mfeoktistov: Yep, spotted | 15:55 |
| mriedem | bauzas: i don't know what that means, or why we care | 15:55 |
| bauzas | anyway, let's not overcomplicate things | 15:55 |
| cdent | sfinucan: on https://review.openstack.org/#/c/404990/ there's this to fix that regex (next cycle): https://review.openstack.org/#/c/418393/ | 15:55 |
| mriedem | bauzas: init_host just checks, if CONF.placement.password is None: raise Exception | 15:55 |
| bauzas | my patch is almost ready and I have to leave in 5 | 15:55 |
| dansmith | mriedem: on the quotas thing, I think it's risky, but I also think it's more likely that anyone else will be able to fix bugs in the counting stuff, so if you want to push, I'll dig into that last one | 15:55 |
| *** mvk has quit IRC | 15:55 | |
| sfinucan | cdent: Aha - thank you. That did seem like a peculiar oversight | 15:56 |
| dansmith | mriedem: and I think there's probably truth to the argument that it's no worse than what we have now, but it is more obvious than what we have now | 15:56 |
| mdbooth | pkoniszewski pkoniszewski_ (irc is the worst): Are you able to determine what I'm talking about through gerrit's formatting? | 15:56 |
| dansmith | mriedem: but also, we're merging other stuff with high risk, so... | 15:56 |
| cdent | sfinucan: it's because 409 is overloaded for at least two different types of conflict | 15:56 |
| mriedem | dansmith: heh, so while we're playing with house money... | 15:56 |
| mriedem | dansmith: feel free to push, i just won't be able to get to it | 15:56 |
| pkoniszewski_ | mdbooth: but the point is that there is no such race | 15:56 |
| dansmith | mriedem: I meant "maybe we shouldn't take out another loan" but okay | 15:57 |
| mdbooth | pkoniszewski_: Explain | 15:57 |
| cdent | it's called leverage | 15:57 |
| mriedem | dansmith: oh i thought you wanted to go balls out | 15:57 |
| mdbooth | pkoniszewski_: I described the race. Can you point out the step I got wrong? | 15:57 |
| *** annegentle has joined #openstack-nova | 15:57 | |
| dansmith | mriedem: I meant the last statement was a hedge, not a "we've already got a second mortgage, why not go for a third" | 15:58 |
| dansmith | mriedem: let me look through it and see how I feel after that | 15:58 |
| mdbooth | pkoniszewski_: I think cfriesen(?) said they'd hit it in practise, too. | 15:58 |
| mriedem | hey, the dow was over 20K so i think that's a safe bet right now | 15:58 |
| mriedem | what could possibly go wrong | 15:58 |
| dansmith | heh | 15:58 |
| mfeoktistov | mriedem: thanks for discussion in mailing list | 15:58 |
| pkoniszewski_ | mdbooth: live migration will always be set to 'completed', there is no chance we will end up with 'failed' or 'finished' state | 15:59 |
| *** yamahata has quit IRC | 15:59 | |
| dansmith | johnthetubaguy: are you still around? | 15:59 |
| pkoniszewski_ | mdbooth: the RPC has been changed to call | 15:59 |
| pkoniszewski_ | mdbooth: https://review.openstack.org/#/c/389687/ | 15:59 |
| johnthetubaguy | dansmith: I am | 15:59 |
| bauzas | there it is | 15:59 |
| dansmith | johnthetubaguy: how are you feeling about the counting quotas stuff? | 16:00 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 16:00 |
| *** nkrinner is now known as nkrinner_afk | 16:00 | |
| mdbooth | pkoniszewski_: So it has, I must have been looking at an old version when looking at the old commit. | 16:00 |
| mdbooth | Well... for the reasons stated I also think that's a bad idea :) | 16:00 |
| mdbooth | But yeah, that means there's no race. | 16:01 |
| pkoniszewski_ | mdbooth: but there is still an issue with rollback, thats a very good point | 16:01 |
| melwitt | mriedem, dansmith, johnthetubaguy: one thing I realized about the counting quotas approach is that once we go multicell, if we lose contact with a cell db for whatever reason, we lose the ability to count resources in it, which would basically free up a person's resource usage for the time period the cell db is inaccessible | 16:02 |
| sfinucan | mfeoktistov: +W'd | 16:02 |
| sfinucan | also, worst IRC nick ever :) | 16:02 |
| sfinucan | ...and mine is bad | 16:02 |
| dansmith | melwitt: yeah, that would be bad.. | 16:03 |
| *** yamahata has joined #openstack-nova | 16:05 | |
| dansmith | melwitt: that would be for what kind of resources? | 16:05 |
| *** zz_dimtruck is now known as dimtruck | 16:05 | |
| dansmith | melwitt: we can count instances and server groups and keypairs all in the api db | 16:05 |
| mdbooth | pkoniszewski_: Incidentally, you could add a comment to the 'completed' code that it can be safely deleted in Queens, because we can guarantee the destination will have already updated migration status. | 16:05 |
| melwitt | dansmith: it seems like we'd need to have some sort of caching table for the usage that gets updated anytime we actually count | 16:05 |
| melwitt | dansmith: currently, I think instances, cores, ram. but that's because I rolled the instance tally into the cores and ram count | 16:06 |
| dansmith | melwitt: that kinda defeats the purpose,in that it becomes a thing that can get out of sync and that we can't refresh without being able to contact the other cell | 16:06 |
| dansmith | melwitt: okay well we could count instances in the api db to mitigate that | 16:06 |
| johnthetubaguy | melwitt: maybe we hard fail on that | 16:07 |
| dansmith | melwitt: so maybe we should get a read from operator(s) about how bad it would be be to not be if ram/cores leaks while a whole cell is offline | 16:07 |
| johnthetubaguy | melwitt: if we know something is there | 16:07 |
| dansmith | johnthetubaguy: hard fail to create instances anywhere if one cell is offline? that'd be bad :) | 16:07 |
| pkoniszewski_ | mdbooth: AFAIR nova does not assume that there will only be live migration from N-1 to N (N-2 to N must also be possible and safe) | 16:07 |
| melwitt | dansmith: yeah. I haven't thought about it much but it seemed like it makes sense for it to be stale if the cell is gone. but if it went away permanently, then yeah that would be the refresh/sync case. so nevermind that idea | 16:07 |
| mdbooth | pkoniszewski_: I understood the contract was that N and N-2 never exist in the same deployment, right? | 16:08 |
| melwitt | dansmith, johnthetubaguy: yeah, we could fall back to InstanceMappings for the instance count but cores/ram would be unknown | 16:08 |
| dansmith | melwitt: well, no I meant even if it's offline temporarily, you wouldn't be able to refresh that value from N-1 cells because you don't know how much of it is in the offline cell, unless you keep more data | 16:08 |
| mdbooth | So no migration between them is implicit. | 16:08 |
| mdbooth | dansmith: ^^^ ? | 16:08 |
| dansmith | mdbooth: correct | 16:08 |
| bauzas | mriedem: dansmith: cdent: rev'd https://review.openstack.org/417961 | 16:09 |
| melwitt | dansmith: oh, right | 16:09 |
| dansmith | mdbooth: pkoniszewski you shouldn't break your RPC api between N-2 and N, but we also don't support that kind of deployment, so higher level assumptions might not be possible between those two | 16:09 |
| cdent | bauzas: cool, will look asap, currently double booked in two meetings ... | 16:09 |
| *** krtaylor has quit IRC | 16:09 | |
| mriedem | bauzas: ok. i think we should move the compute/service version checking stuff into a separate patch for sanity | 16:10 |
| mriedem | bauzas: but sounds like you're going to be afk for awhile | 16:10 |
| dansmith | bauzas: that service version and fail should be a separate patch | 16:10 |
| dansmith | what mriedem said | 16:10 |
| bauzas | mriedem: yup, I could potentially lightweight the change | 16:10 |
| pkoniszewski_ | dansmith: got it | 16:10 |
| melwitt | dansmith: actually I guess the long term answer was we're going to ask for cores/ram count from placement when that's doable | 16:11 |
| bauzas | mriedem: dansmith: gimme just 20 mins for my daughter's homework and I'm back | 16:11 |
| dansmith | melwitt: ah, that's true | 16:11 |
| dansmith | melwitt: I forgot about that part | 16:11 |
| mdbooth | pkoniszewski_: Either way, it can be deleted as soon as we can assume the other end is doing the update. Worth adding a comment that we added the remote end in N. | 16:12 |
| pkoniszewski_ | mdbooth: yes, i'll add comment there | 16:12 |
| mfeoktistov | sfinucan: i never thought that "ploop" sounds bad, until i heard the pronunciation of other developers not from virtuozzo. Yes, i agree it sounds strange, to say the least . | 16:14 |
| mdbooth | pkoniszewski_: This code is hairy as hell, btw. Thanks for taking it on. | 16:14 |
| *** karimb has quit IRC | 16:15 | |
| mfeoktistov | sfinucan: we pronounce like pe + loop. "Parallels loop" . Parallels is previous name of our company | 16:15 |
| mdbooth | mfeoktistov: diana_clarke particularly enjoys it, btw. IIRC it's her favourite disk format. | 16:16 |
| sfinucan | mfeoktistov: Aha - that nuance escaped me :) | 16:16 |
| * sfinucan nearly choked the first time he heard his Donegal lecturer talk about "funny GUI things" | 16:17 | |
| mdbooth | sfinucan: Had you previous used gee-you-eye? | 16:17 |
| diana_clarke | Ploop! There it is! https://www.youtube.com/watch?v=Z-FPimCmbX8 | 16:17 |
| mdbooth | diana_clarke: lol | 16:18 |
| *** mdnadeem has quit IRC | 16:19 | |
| sfinucan | mdbooth: In my blessed ignorance, yes | 16:19 |
| alaski | dansmith: melwitt just caught part of scrollback from last night. I wanted BuildRequest.instance to be orphaned because I didn't want it treated like an instance, it's a holding place for what an instance should look like when it's created but isn't an instance itself. It's a subtle distinction made complicated by using an actual instance object there. I thought thinking of it that way would lead to | 16:19 |
| alaski | fewer bugs. | 16:19 |
| dansmith | alaski: right, I remember | 16:20 |
| sfinucan | We got odd looks for wanting to play Call of Duty (COD) in past years too | 16:20 |
| dansmith | alaski: I even went looking for where we had that convo, but it must have been in IRC | 16:20 |
| alaski | dansmith: cool. I also said I would defer to those who were doing the work :) | 16:20 |
| mfeoktistov | diana_clarke: ahaha! good track for presentation | 16:20 |
| dansmith | alaski: s'all good now | 16:20 |
| *** krtaylor has joined #openstack-nova | 16:21 | |
| cfriesen | mdbooth: thanks for taking a look at the live-migration claims patch. It'd be good to finally get that stuff in. | 16:22 |
| melwitt | alaski: yeah, once we realized what was happening, it was clear what to do | 16:22 |
| alaski | dansmith: melwitt excellent | 16:24 |
| melwitt | and I could see allowing it to masquerade as a normal Instance object could lead to a lot of subtle problems, if anything were missing from its fields | 16:25 |
| *** dtp has joined #openstack-nova | 16:25 | |
| dansmith | on the other hand, in reality, | 16:25 |
| dansmith | we used that to smooth over where we got the instance, | 16:25 |
| dansmith | so down the stack we've lost context (heh) about why it might not be a real one | 16:26 |
| melwitt | yeah. I suspect if it had a real context, the problem would travel further down the stack and be really puzzling | 16:26 |
| melwitt | *even further | 16:27 |
| johnthetubaguy | melwitt: sorry, got distracted, which bits where you counting when you needed the cells again? | 16:27 |
| dansmith | I dunno, the refresh should work if we have uuid and context | 16:27 |
| *** karimb has joined #openstack-nova | 16:27 | |
| *** tbachman has quit IRC | 16:27 | |
| dansmith | johnthetubaguy: the counting patches counts instances, ram and cores from the cell db | 16:28 |
| *** liangy has joined #openstack-nova | 16:28 | |
| melwitt | johnthetubaguy: the ram and cores, and I tally the instances while counting ram/cores. ram and cores are being counted currently by pulling the instances and going through their flavor extra specs | 16:28 |
| dansmith | johnthetubaguy: if we lose connectivity with a cell for ten minutes, a user suddenly gets their quota back until we reconnect and could burn it in other cells | 16:28 |
| * johnthetubaguy face palm | 16:28 | |
| johnthetubaguy | yeah, that makes sense | 16:29 |
| melwitt | johnthetubaguy: the real plan is to call the placement api to get cores/ram count and use InstanceMappings for instances, but we can't get that from placement quite yet | 16:29 |
| *** slaweq has quit IRC | 16:29 | |
| johnthetubaguy | melwitt: ah, true, well that to make placement do quota too ;) | 16:30 |
| johnthetubaguy | s/to/or | 16:30 |
| *** jaypipes_ has joined #openstack-nova | 16:30 | |
| johnthetubaguy | melwitt: FWIW, its tempting to fail hard if a cell is down, and we know there is something in there we should be counting | 16:30 |
| dansmith | johnthetubaguy: how does that work? | 16:30 |
| *** slaweq has joined #openstack-nova | 16:31 | |
| dansmith | johnthetubaguy: if one cell is down, we can't do anything? that kinda defeats the purpose no? | 16:31 |
| dansmith | well, s/do/create/ but .. | 16:31 |
| melwitt | yeah, that seems like it would draw much ire | 16:31 |
| dansmith | yeah | 16:31 |
| *** pkoniszewski_ has quit IRC | 16:31 | |
| dansmith | johnthetubaguy: so, we can count instances in the api database, | 16:31 |
| *** tbachman has joined #openstack-nova | 16:31 | |
| dansmith | johnthetubaguy: which would leave just cores and ram as leaky if a whole cell went down | 16:32 |
| dansmith | johnthetubaguy: which should be rare, and maybe some quota leakage isn't the worst thing in that case, given we will someday have placement do better | 16:32 |
| johnthetubaguy | yeah, thats fair, if we did it that way, it feels less of a big deal | 16:32 |
| dansmith | but I dunno | 16:32 |
| dansmith | I feel like maybe that needs to be a question to the ops, but we have no time for that | 16:32 |
| johnthetubaguy | yeah | 16:32 |
| *** lpetrut has quit IRC | 16:33 | |
| johnthetubaguy | honestly, feels like fail hard and don't care will be both be requested, depending on how much RAM and CPU quota matters to you | 16:33 |
| johnthetubaguy | I like that the instance count one works just fine though | 16:33 |
| *** raj_singh_ has quit IRC | 16:35 | |
| melwitt | usually maybe the cores/ram leak stays bounded by the instances quota, but if someone has set unlimited instances and limited cores/ram, that would be a lot bigger problem | 16:35 |
| *** hfu has quit IRC | 16:36 | |
| dansmith | yeah | 16:36 |
| dansmith | that's why asking the operators would be good | 16:36 |
| *** baoli has quit IRC | 16:36 | |
| *** hfu has joined #openstack-nova | 16:37 | |
| sfinucan | mriedem: If /you're/ looking for something to do, could you take a look at https://review.openstack.org/#/c/405954 at some point? | 16:37 |
| mriedem | currently reviewing https://review.openstack.org/#/c/404472 | 16:37 |
| *** hfu has quit IRC | 16:37 | |
| mriedem | but i already had https://review.openstack.org/#/c/405954 in a tab | 16:37 |
| dansmith | sfinucan: you know mriedem is on vacation right? I know, it's hard to tell | 16:38 |
| *** hfu has joined #openstack-nova | 16:38 | |
| sfinucan | a tab will do nicely | 16:38 |
| jaypipes_ | edleafe: are you handling the change to https://review.openstack.org/#/c/404472/17/nova/compute/resource_tracker.py that you said you were looking at yesterday? | 16:38 |
| *** jamesdenton has joined #openstack-nova | 16:38 | |
| jaypipes_ | edleafe: if not, I will do so. | 16:38 |
| jaypipes_ | and good morning fellas. | 16:38 |
| *** hfu has quit IRC | 16:38 | |
| sfinucan | dansmith: I do. I've already given out to him for being around but he won't listen | 16:38 |
| *** vsaienko has joined #openstack-nova | 16:38 | |
| dansmith | sfinucan: he's not very good at vacation | 16:38 |
| * dansmith goes to unendorse mriedem on linkedin for "vacation" | 16:39 | |
| *** chyka has joined #openstack-nova | 16:39 | |
| *** hfu has joined #openstack-nova | 16:39 | |
| sfinucan | You Americans and your pesky work ethic | 16:39 |
| *** chyka has quit IRC | 16:39 | |
| *** hfu has quit IRC | 16:39 | |
| sfinucan | We clearly need a Greek PTL | 16:39 |
| jaypipes_ | lol | 16:39 |
| *** hfu has joined #openstack-nova | 16:39 | |
| * sfinucan apologies to any hard working Greek folks he may have offended :) | 16:40 | |
| jaypipes_ | my idea of vacation is doing code reviews by a pool. | 16:40 |
| *** hfu has quit IRC | 16:40 | |
| dansmith | mriedem: bauzas: that change is failing because it can't find placement.password | 16:40 |
| kashyap | sfinucan: Quit giving those non-apologies | 16:41 |
| bauzas | dansmith: yup, I'm working on a new PS | 16:41 |
| dansmith | bauzas: you have a fix? | 16:41 |
| kashyap | sfinucan: Reminds me about an article on the word 'humbled' in NY Times lately. ;-) | 16:41 |
| mriedem | jaypipes: edleafe: just left some comments in https://review.openstack.org/#/c/404472/ | 16:41 |
| bauzas | dansmith: by also excepting the NoConfOpt + modifying the ServiceFixture | 16:41 |
| sfinucan | :D | 16:41 |
| mriedem | jaypipes: i'm not all of the way through it yet | 16:41 |
| mriedem | jaypipes: but the 'latest' microversion in the scheduler report client is what the -1 is for | 16:41 |
| dansmith | bauzas: is that going to work? | 16:42 |
| dansmith | bauzas: because it's failing to find it on a run that should have it | 16:42 |
| bauzas | dansmith: if we ConfPatcher the ServiceFixture | 16:42 |
| dansmith | bauzas: you might have to check the region name, since that's our conf opt | 16:42 |
| dansmith | bauzas: it's failing in real devstack runs! | 16:42 |
| dansmith | http://logs.openstack.org/61/417961/28/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ed475f7/logs/screen-n-cpu.txt.gz?level=TRACE | 16:42 |
| dansmith | bauzas: ^ | 16:42 |
| *** yamahata has quit IRC | 16:42 | |
| bauzas | interesting | 16:42 |
| cfriesen | jaypipes_: get a toughbook and you can do code reviews *in* the pool | 16:43 |
| bauzas | anyway, I'm just splitting the big change | 16:43 |
| dansmith | bauzas: I think it's because of lazy conf evaluation | 16:43 |
| *** marst has joined #openstack-nova | 16:43 | |
| mriedem | NoSuchOptError: no such option password in group [placement] | 16:44 |
| mriedem | that seems wonky | 16:44 |
| edleafe | jaypipes_: yes, I fixed that already | 16:44 |
| *** chyka has joined #openstack-nova | 16:44 | |
| jaypipes_ | cfriesen: :) | 16:44 |
| jaypipes_ | edleafe: ty sir | 16:44 |
| jaypipes_ | edleafe: sorry was looking at an old rev comment | 16:45 |
| *** lpetrut has joined #openstack-nova | 16:48 | |
| jaypipes_ | edleafe: I don't want to step on toes if you are already working on it, so let me know if you are addressing mriedem's comments? | 16:48 |
| johnthetubaguy | bauzas: I would try auth_url anyways, as password bit is pluggable | 16:48 |
| edleafe | yeah, looking at them now | 16:48 |
| johnthetubaguy | funky though, looks like it is there: http://logs.openstack.org/61/417961/28/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/ed475f7/logs/etc/nova/nova.conf.txt.gz | 16:49 |
| edleafe | jaypipes_: aren't you suposed to be drinking pina coladas or something? | 16:49 |
| jaypipes_ | edleafe: meh, coffee and email this morning :) | 16:49 |
| cdent | jaypipes_: what about getting caught in the rain? | 16:51 |
| *** sahid has quit IRC | 16:51 | |
| dansmith | it's not even morning in florida anymore | 16:52 |
| edleafe | jaypipes_: any idea about mriedem's comment here: https://review.openstack.org/#/c/404472/20/nova/scheduler/client/report.py@174 | 16:52 |
| edleafe | That got changed in PS 8 | 16:53 |
| *** vsaienko has quit IRC | 16:53 | |
| *** tesseract has quit IRC | 16:55 | |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Allow graceful service exits from compute https://review.openstack.org/425751 | 16:55 |
| jaypipes_ | edleafe: I don't see that changed in PS8. but anyway, it's likely just an oversight. There were so many patches that changed that line that I've lost track at this point which introduced latest and which introduced 1.X specified explicitly. | 16:57 |
| jaypipes_ | edleafe: in this particular case, it should be the microversion that added resource classes, so 1.2, yes? | 16:57 |
| edleafe | jaypipes_: not sure, but that sounds about right | 16:58 |
| bauzas | johnthetubaguy: dansmith: so I made the spit | 16:58 |
| bauzas | split even | 16:58 |
| bauzas | johnthetubaguy: dansmith: are you suggesting me other way to verify if the placement section is correct? | 16:59 |
| bauzas | I'm all ears | 16:59 |
| edleafe | jaypipes_: https://review.openstack.org/#/c/404472/8..20/nova/scheduler/client/report.py@174 | 16:59 |
| edleafe | jaypipes_: that's where it got added | 16:59 |
| dansmith | bauzas: I said check os_region right? | 16:59 |
| johnthetubaguy | bauzas: I was thinking of using auth_url CONF instead | 16:59 |
| dansmith | bauzas: that's our config value, should be there by the time you need it | 16:59 |
| dansmith | johnthetubaguy: is that going to be different than password from an order of loading perspective? because his patch fails on password not even being a thing by the time we're loading | 17:00 |
| dansmith | s/loading/running/ | 17:00 |
| *** bvanhav has quit IRC | 17:00 | |
| bauzas | dansmith: you mean os_region_name? | 17:00 |
| *** andreas_s has quit IRC | 17:00 | |
| bauzas | that's something coming from us ? | 17:00 |
| johnthetubaguy | dansmith: unsure, but I like your os_region suggestion better | 17:01 |
| johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/conf/placement.py#L22 | 17:01 |
| *** bvanhav has joined #openstack-nova | 17:01 | |
| johnthetubaguy | dansmith: bauzas: password is part of the pluggable auth and not not actually required, so it shouldn't be that one | 17:01 |
| bauzas | okay, let's try os_region_name then | 17:02 |
| bauzas | dansmith is right, given it's the only one we have in tree | 17:02 |
| *** raunak has joined #openstack-nova | 17:02 | |
| johnthetubaguy | (assuming we don't later decide os_region_name should be defaulted to RegionOne, but lets just be sure not to do that this cycle!) | 17:02 |
| bauzas | and password means a password auth, which could be changing in the future | 17:02 |
| bauzas | johnthetubaguy: I could write an unittest for preventing that | 17:03 |
| *** liverpooler has quit IRC | 17:03 | |
| johnthetubaguy | bauzas: cool | 17:03 |
| bauzas | johnthetubaguy: meaning that I'm expecting a None value | 17:03 |
| johnthetubaguy | ack | 17:03 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | 17:03 |
| bauzas | so someone defaulting the opt would have to cut that | 17:03 |
| bauzas | okay, let's try again | 17:03 |
| *** liverpooler has joined #openstack-nova | 17:04 | |
| *** pbandark has joined #openstack-nova | 17:04 | |
| bauzas | shit, I need a fixturre | 17:07 |
| jaypipes_ | edleafe: I must be seeing something different than you... I don't see placement latest being added in that patch? | 17:07 |
| bauzas | dansmith: johnthetubaguy ^ | 17:07 |
| jaypipes_ | edleafe: i.e. that line isn't green in gerrit. | 17:07 |
| jaypipes_ | edleafe: in any case, not sure it matter, right? solution is straight-forward. just s/latest/1.2/, yesh? | 17:08 |
| sfinucan | erm, vladikr - you're looking at this, right? https://review.openstack.org/#/c/424786/ :) | 17:09 |
| mriedem | jaypipes: i'd prefer the calling code is explicit about the microversion it needs, so GET and POST for resource classes, | 17:09 |
| mriedem | not globally in the init | 17:09 |
| * sfinucan imagines it's the test that's broken, but would like confirmation | 17:09 | |
| *** pbandark has quit IRC | 17:09 | |
| mriedem | edleafe: ^ | 17:09 |
| vladikr | sfinucan, yeah, but it's not really possible to test this with tempest | 17:09 |
| sfinucan | vladikr: Oh, wait - that was the thing that required hardware, right? | 17:10 |
| edleafe | jaypipes_: this is what I see: http://imgur.com/a/ocO8X | 17:10 |
| vladikr | sfinucan, yeah, I should abandon that | 17:10 |
| edleafe | jaypipes_: just so you don't think I crazy (well, crazier) | 17:10 |
| sfinucan | vladikr: Do please | 17:10 |
| sfinucan | though I'd also suggest submitting a patch for https://github.com/wznoinsk/hw-tests | 17:10 |
| dansmith | bauzas: I'm confused -- is os_region_name what you're going to use instead of password? | 17:11 |
| vladikr | yeah | 17:11 |
| bauzas | dansmith: yup | 17:11 |
| sfinucan | vladikr: wznoinsk should be able to provide more information on that project, if you ask nicely | 17:11 |
| dansmith | okay I thought you were saying you weren't | 17:11 |
| dansmith | so.. good | 17:11 |
| bauzas | dansmith: sorry then | 17:11 |
| dansmith | :) | 17:11 |
| edleafe | mriedem: ok, I'll look for where those are needed. | 17:11 |
| bauzas | dansmith: so, it works with devstack (like the t-shirt) | 17:11 |
| bauzas | dansmith: but for UTs and functional tests, I need to make a fixture and add it to nova.test | 17:11 |
| bauzas | dansmith: in order to set the config opt | 17:12 |
| mriedem | bauzas: just throw it in the global conf patcher | 17:12 |
| bauzas | unless I'm just setting the opt straight | 17:12 |
| mriedem | that is run on all tests by default | 17:12 |
| mriedem | it's a 1 line change | 17:12 |
| bauzas | mriedem: oh right | 17:12 |
| bauzas | I forgot it, but yeah, much better | 17:12 |
| *** ducttape_ has joined #openstack-nova | 17:12 | |
| jaypipes_ | edleafe: yes, that's what I see too. Notice that the line he is referring to is white, meaning the patch has not changed that line. | 17:13 |
| jaypipes_ | mriedem: you mean passing in a specific microversion header for each GET/POST call? | 17:14 |
| mriedem | jaypipes_: yes, like we're already doing for 1.1 with aggregates | 17:14 |
| jaypipes_ | mriedem: got it. edleafe, got it? :) | 17:15 |
| edleafe | jaypipes_: yeah, but if you compare to PS7, it's green | 17:15 |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404 | 17:15 |
| edleafe | meaning it's been in the code since PS8 | 17:16 |
| edleafe | IAC, I'm working on the changes | 17:16 |
| *** mjura has quit IRC | 17:16 | |
| mriedem | bauzas: yeah in here somewhere https://github.com/openstack/nova/blob/master/nova/tests/unit/conf_fixture.py#L30 | 17:17 |
| bauzas | mriedem: already did | 17:17 |
| mriedem | dansmith: oh nice https://review.openstack.org/319379 is approved | 17:17 |
| bauzas | running tests and uploading in a sec | 17:17 |
| mriedem | was just going to check on that | 17:17 |
| dansmith | mriedem: #10 in the gate MOFO | 17:17 |
| dansmith | mriedem: I'm watching it like my life depends on t | 17:18 |
| johnthetubaguy | melwitt: I sent a note on that quota patch, its not a blocker I am just curious what you think though. | 17:18 |
| johnthetubaguy | melwitt: looking at the latest one now. | 17:18 |
| mriedem | dansmith: was melwitt good with it? | 17:19 |
| dansmith | mriedem: she pushed the last change | 17:19 |
| dansmith | so I'm guessing | 17:19 |
| mriedem | oh excellent | 17:19 |
| *** lucasagomes is now known as lucas-afk | 17:19 | |
| melwitt | mriedem, dansmith: yes, all good | 17:19 |
| melwitt | johnthetubaguy: I just saw, thanks. I do like the idea of making the limit check atomic but I'm not familiar with the generation id and how passing a deltas dict helps? | 17:20 |
| johnthetubaguy | melwitt: I was really thinking, we do the generation thing much later, but the new interface would allow us to do that without changing all the callers | 17:21 |
| *** nic has joined #openstack-nova | 17:21 | |
| melwitt | johnthetubaguy: ah, gotcha | 17:21 |
| jaypipes_ | edleafe: danke | 17:21 |
| *** ekuris__ has quit IRC | 17:22 | |
| *** derekh has quit IRC | 17:24 | |
| melwitt | johnthetubaguy: okay, so you mean moving the counting call inside of Quotas.check_deltas for now. that makes sense | 17:24 |
| johnthetubaguy | melwitt: yeah, squash the two calls into a single call | 17:25 |
| mriedem | vladikr: question in https://review.openstack.org/#/c/405954/ | 17:25 |
| vladikr | mriedem, looking | 17:26 |
| *** unicell has joined #openstack-nova | 17:26 | |
| melwitt | johnthetubaguy: it would clean things up a lot too | 17:26 |
| johnthetubaguy | melwitt: its a nit, I was wondering if get counts should be on the list object? | 17:26 |
| *** _ducttape_ has joined #openstack-nova | 17:26 | |
| melwitt | johnthetubaguy: it could. I wasn't opinionated about it. I feel like there might be an example of a count on an existing list object already | 17:28 |
| *** purplerbot has quit IRC | 17:28 | |
| *** tbachman has quit IRC | 17:28 | |
| *** purplerbot has joined #openstack-nova | 17:28 | |
| johnthetubaguy | melwitt: I could see arguments both ways I guess | 17:28 |
| mriedem | vladikr: similar in https://review.openstack.org/#/c/405951/ | 17:29 |
| mriedem | vladikr: basically, we're doing the same stuff in both the metadata api code as in the libvirt driver, | 17:29 |
| mriedem | vladikr: i'm not sure why we don't just store the vlan on the NetworkInterfaceMetadata object in the libvirt driver, like the tag, | 17:30 |
| mriedem | and then use that in the metadata api | 17:30 |
| *** ducttape_ has quit IRC | 17:30 | |
| melwitt | johnthetubaguy: yeah. I just did a quick grep and didn't find an existing example of a count. so I think I just guessed :P | 17:30 |
| melwitt | there's the InstanceGroup.count_members_by_user but it counts members for a single group so that makes sense | 17:31 |
| vladikr | mriedem, yes, in the first patch we need to determine which vifs to include in the list of device that the metadata will receive and then in the second patch we will create the metadata only for those device that has a vlan or a tag | 17:31 |
| vladikr | mriedem, https://review.openstack.org/#/c/405951/13/nova/api/metadata/base.py@428 | 17:31 |
| *** mfeoktistov has quit IRC | 17:32 | |
| *** karimb has quit IRC | 17:33 | |
| *** karimb has joined #openstack-nova | 17:36 | |
| mriedem | vladikr: yeah but we build that list twice | 17:36 |
| mriedem | when we already know it in the libvirt driver, | 17:36 |
| mriedem | and could store the vlan on the same object that has the tag | 17:37 |
| *** cdent has quit IRC | 17:37 | |
| mriedem | dansmith: bauzas: johnthetubaguy: i'm heading out for a few hours, | 17:37 |
| mriedem | just a reminder on https://review.openstack.org/#/c/424256/ so we can release novaclient 7.1.0 | 17:37 |
| *** kencjohnston has joined #openstack-nova | 17:38 | |
| bauzas | mriedem: want me to tag the release btw. ? | 17:38 |
| vladikr | mriedem, yes, that's what the previous iteration of the code was doing | 17:38 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 17:39 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | 17:39 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806 | 17:39 |
| vladikr | mriedem, I'll look at it again | 17:39 |
| mriedem | bauzas: i'll be back around this afternoon to do that assuming we get the other things merged | 17:39 |
| bauzas | dansmith: mriedem: the branch is now up ^ | 17:39 |
| bauzas | mriedem: okay, I'll have to bail out by around 11pm UTC because I have to wake up early tomorrow | 17:40 |
| *** tbachman has joined #openstack-nova | 17:40 | |
| bauzas | mriedem: ie. midnight my time | 17:40 |
| bauzas | not sure which TZ you're in | 17:40 |
| mriedem | bauzas: GMT | 17:40 |
| bauzas | mriedem: I need to go back and forth tomorrow to Patis | 17:40 |
| bauzas | Paris even | 17:40 |
| mriedem | bauzas: i'm asking about the o-3 timeline + FF in the release channel too | 17:40 |
| bauzas | so mostly on train during the day | 17:41 |
| *** hfu has joined #openstack-nova | 17:41 | |
| *** baoli has joined #openstack-nova | 17:41 | |
| *** mriedem has quit IRC | 17:41 | |
| bauzas | mriedem: oh f*** I tought I was following | 17:41 |
| dansmith | bauzas: is the change to _enabled_filters still needed there? | 17:42 |
| johnthetubaguy | melwitt: that destroy_and_raise_if_over_quota, is that worth the extra maintenance cost? | 17:43 |
| bauzas | you mean the bottom change? | 17:43 |
| *** jogo has quit IRC | 17:43 | |
| bauzas | dansmith: ^ | 17:43 |
| *** liverpooler has quit IRC | 17:43 | |
| *** liverpoo1er has joined #openstack-nova | 17:43 | |
| melwitt | johnthetubaguy: replying to that right now on the review | 17:43 |
| dansmith | bauzas: L48 of the bottom change | 17:43 |
| bauzas | dansmith: yeah it should still, because we have a different behaviour in case we don't have all the filters | 17:43 |
| *** hfu has quit IRC | 17:43 | |
| bauzas | dansmith:oh sec | 17:44 |
| *** jogo has joined #openstack-nova | 17:44 | |
| bauzas | dansmith: I misunderstood your question | 17:44 |
| dansmith | I don't think it should be different if we're ignoring those filters | 17:44 |
| bauzas | dansmith: in theory, the affinity filters are part of the default | 17:44 |
| dansmith | bauzas: also, the other tests didn't have a list for that parameter? | 17:44 |
| bauzas | dansmith: so we should not need L48 theorically | 17:44 |
| bauzas | dansmith: but | 17:44 |
| dansmith | bauzas: what about the service_down_time thing? | 17:45 |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288 | 17:45 |
| bauzas | dansmith: I forgot to make a note here | 17:45 |
| bauzas | dansmith: I answered edleafe's on a previous PS | 17:45 |
| bauzas | and sorry pidgin crashed when I was replying to you about the _enabled_filters | 17:46 |
| bauzas | I preferred to explicitly ask for them in L48 given we could remove them from the default list later on | 17:46 |
| dansmith | you use pidgin for irc like a n00b? :) | 17:46 |
| dansmith | alright | 17:46 |
| *** karimb has quit IRC | 17:46 | |
| bauzas | dansmith: indeed, I love GUIs | 17:47 |
| melwitt | that was a burn | 17:47 |
| bauzas | and you know what ? I loooove Atom | 17:48 |
| artom | dansmith, let me guess, you jiggle magnets around some wires to send your messages? | 17:48 |
| bauzas | we're almost Friday | 17:48 |
| bauzas | so I think I have the wildcard for telling that | 17:48 |
| dansmith | bauzas: -1 on the middle patch | 17:48 |
| dansmith | I think the test is broken | 17:48 |
| bauzas | dansmith: ack, lookind | 17:49 |
| dansmith | bauzas: I love guis too | 17:49 |
| bauzas | oh "this" ans "that" | 17:49 |
| bauzas | my English teacher should hit me | 17:49 |
| *** jose-phillips has joined #openstack-nova | 17:49 | |
| dansmith | bauzas: that's the bottom, see the middle one | 17:49 |
| bauzas | dansmith: I know :) | 17:50 |
| dansmith | okay | 17:50 |
| bauzas | dansmith: I just saw your comment :) | 17:50 |
| bauzas | dansmith: for the middle patch | 17:50 |
| bauzas | good points | 17:50 |
| bauzas | I can respin quickly | 17:50 |
| bauzas | for the 2nd test I'm adding | 17:50 |
| dansmith | I would recommend waiting until we get a run so we know if the top one is going to work, but if you have to go before it will finish, then just push | 17:51 |
| bauzas | that is not running init_host, that's rather a defensive patch for making sure anyone can't just change nova.conf.placement opt and add a default without being kicked in the ass | 17:51 |
| bauzas | dansmith: well, I'll get an IndentationError anyway, right? | 17:51 |
| bauzas | dansmith: so I'm pretty sure it would fail anyway | 17:51 |
| *** sambetts is now known as sambetts|afk | 17:51 | |
| bauzas | don't know how I left that FWIW | 17:51 |
| bauzas | probably because I said I love Atom in public | 17:52 |
| dansmith | oh I see, well, might be good to assert the positive case in another test anyway | 17:52 |
| bauzas | dansmith: I can put that elsewhere | 17:53 |
| bauzas | dansmith: if you have ideas | 17:54 |
| bauzas | dansmith: I'm just about uploading a new Ps | 17:54 |
| bauzas | dansmith: unless you disagree | 17:54 |
| dansmith | don't disagree | 17:54 |
| *** _ducttape_ has quit IRC | 17:55 | |
| *** ducttape_ has joined #openstack-nova | 17:55 | |
| *** _ducttape_ has joined #openstack-nova | 17:56 | |
| bauzas | k | 17:57 |
| bauzas | shooting, then | 17:57 |
| *** _ducttape_ has quit IRC | 17:58 | |
| *** kfarr has quit IRC | 17:59 | |
| *** david-lyle has quit IRC | 17:59 | |
| *** Apoorva has joined #openstack-nova | 17:59 | |
| *** ducttape_ has quit IRC | 18:00 | |
| johnthetubaguy | melwitt: oh, resize is a bit of a bummer in that quota logic. | 18:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 18:02 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806 | 18:02 |
| *** ralonsoh has quit IRC | 18:03 | |
| *** annegentle has quit IRC | 18:03 | |
| *** annegentle has joined #openstack-nova | 18:03 | |
| *** unicell has quit IRC | 18:04 | |
| melwitt | johnthetubaguy: yeah, it's ugly. it would look a lot better with the check_deltas idea | 18:05 |
| *** rmart04 has quit IRC | 18:05 | |
| johnthetubaguy | melwitt: I was thinking, its not until resize confim that we update the DB with the new larger flavor so its counted correctly, thats quite a big window | 18:05 |
| dansmith | bauzas: did you not see my comment on the last patch about enabling service version caching? | 18:06 |
| bauzas | dansmith: it seems not | 18:06 |
| dansmith | bauzas: okay, I'll fix | 18:06 |
| bauzas | my bad | 18:06 |
| dansmith | oh, | 18:06 |
| dansmith | I thought you were leaving soon, it's only 1900 your time right? | 18:06 |
| bauzas | dansmith: I'm still here for a couple of hours :) | 18:07 |
| dansmith | either way, let us wait for a run of the top one anyway | 18:07 |
| dansmith | and if it's after you leave I'll fix it | 18:07 |
| melwitt | johnthetubaguy: ah, yeah. it's kind of like that now though, since it does a reserve right away, and quota is checked against reserved + in_use. the quota commit is in the confirm_resize but all that does it delete the reservation and increase the in_use | 18:07 |
| bauzas | dansmith: I just need to bail out for 60 mins | 18:07 |
| dansmith | okay | 18:07 |
| bauzas | dansmith: but yeah, it's 7:07pm | 18:07 |
| bauzas | dansmith: so I should be back around 9pm to midnight | 18:07 |
| melwitt | johnthetubaguy: oh, you mean with the new way, the in_use doesn't increase until the confirm. yeah | 18:08 |
| dansmith | okay | 18:08 |
| bauzas | ie. 2000UTC to 2300UTC | 18:08 |
| *** owalsh is now known as owalsh-afk | 18:08 | |
| johnthetubaguy | melwitt: but the reservations count towards quota, so its a bit different | 18:08 |
| bauzas | dansmith: I can do the fix related to your -1 | 18:08 |
| *** annegentle has quit IRC | 18:08 | |
| johnthetubaguy | melwitt: yeah, I think the count instances just needs to use the new flavor if its a pending resize (I kinda hope there is a cleaner way though) | 18:08 |
| bauzas | dansmith: but if you have time for it, go | 18:08 |
| dansmith | bauzas: okay but let the top patch finish a run first | 18:08 |
| bauzas | dansmith: okay, so I leave you implement that | 18:09 |
| melwitt | johnthetubaguy: yeah, I get what you mean now. the old way reflects the increased resource usage immediately whereas the new way defers it until the confirm | 18:09 |
| bauzas | dansmith: because I'll be off for 1.5h-ish | 18:09 |
| *** efoley__ has quit IRC | 18:09 | |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288 | 18:09 |
| bauzas | now the patches are in the gate, I'm bailing out but I'll be back | 18:09 |
| johnthetubaguy | melwitt: yeah, sorry, thats what I mean | 18:09 |
| bauzas | andreykurilin: where are we with the client side ? | 18:09 |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (disk drv) https://review.openstack.org/409401 | 18:09 |
| bauzas | andreykurilin: oh, it's missing another +2/+W | 18:10 |
| melwitt | johnthetubaguy: I had been thinking it's good to not reflect the usage until it's really actually used. but, that opens the window for things to get past and go over quota when confirm happens later | 18:10 |
| bauzas | andreykurilin: when are you planning to deliver a new revision ? | 18:10 |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (console) https://review.openstack.org/409402 | 18:11 |
| *** unicell has joined #openstack-nova | 18:11 | |
| openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404 | 18:11 |
| bauzas | andreykurilin: oh, you're saying all johnthetubaguy's comments can be addressed in a follow-up | 18:11 |
| andreykurilin | mriedem bauzas : let's release novaclient without merging fix for token+cli. It was broken for a year, so it looks like this feature is not in demand, but we need to release new version of novaclient now to release all warning messages which were introduced in 7.0.0 + we need full keystone v3 support | 18:11 |
| bauzas | andreykurilin: the token thing is fixed, that's just the CLI which is not yet fixed, right? | 18:12 |
| bauzas | andreykurilin: unless I'm wrong | 18:12 |
| andreykurilin | bauzas: yes. Token with via python novaclient's API is fixed | 18:13 |
| andreykurilin | *Token auth | 18:13 |
| bauzas | andreykurilin: could you then split your CLI change and just leave the reno file in a separate change ? | 18:13 |
| melwitt | johnthetubaguy: yeah, that would not be great to have to consider pending resize. I wonder if it could be as simple as checking count and quota in the confirm too. and if you are late with your confirm, you may not get to confirm it and have to revert | 18:13 |
| bauzas | andreykurilin: I'd like to include that note for the 7.1.0 release notes | 18:13 |
| bauzas | andreykurilin: and I feel brave enough for a single +2/+W | 18:14 |
| melwitt | but I guess that's not a good experience | 18:14 |
| andreykurilin | bauzas: sorry, I'm not near PC now:( | 18:14 |
| bauzas | andreykurilin: okay, lemme do that then | 18:14 |
| *** owalsh-afk has quit IRC | 18:14 | |
| andreykurilin | bauzas Ok, it looks like I'll able to do it in 10-15 mini | 18:15 |
| andreykurilin | *minutes | 18:15 |
| openstackgerrit | Dirk Mueller proposed openstack/nova: [WIP] Handle boot_index in block_device_info also for volumes https://review.openstack.org/425813 | 18:15 |
| johnthetubaguy | melwitt: I did wonder about that, it just feels like you could do loads of resizes to use too much quota, and just not bother doing and confirms so you get to keep the extra big instances | 18:15 |
| bauzas | andreykurilin: I'll need to bail out for 1.5 hours | 18:15 |
| bauzas | andreykurilin: so it's up to you, your call | 18:15 |
| melwitt | johnthetubaguy: oh, heh. yeah | 18:15 |
| johnthetubaguy | melwitt: we do have auto resize confirm to protect against that, but I duno, seems funky | 18:15 |
| andreykurilin | bauzas: oh.. we need to propose a release as soon as possible | 18:15 |
| bauzas | andreykurilin: if you can split that, I can +2 and ask another core to quickly +W the reno change only | 18:15 |
| openstackgerrit | Ed Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 18:16 |
| bauzas | andreykurilin: I know, but I don't want to ship a release without the proper release note | 18:16 |
| johnthetubaguy | melwitt: I should probably worry that that attack is the first thing that pops into my head! | 18:16 |
| bauzas | and we can still tag the release in the next hours | 18:16 |
| edleafe | jaypipes_: ^^ should fix mriedem's concerns | 18:16 |
| *** ociuhandu has joined #openstack-nova | 18:16 | |
| bauzas | there is no rush, the deadline can be very late PST | 18:16 |
| andreykurilin | bauzas maybe johnthetubaguy can find a bit of time to review my answers to his comments? | 18:17 |
| melwitt | johnthetubaguy: haha :) well, it's good you're thinking of those cases | 18:17 |
| bauzas | ask him :) | 18:17 |
| andreykurilin | bauzas g-r will be closed in an hour I think | 18:17 |
| bauzas | what I want is at least the reno file | 18:17 |
| johnthetubaguy | andreykurilin: I just don't understand that keychain stuff, and haven't had chance to read into it :( | 18:17 |
| bauzas | okay, too risky then | 18:17 |
| bauzas | let's just merge the reno file | 18:17 |
| johnthetubaguy | andreykurilin: once you delete that code, I can't see that class being used anywhere | 18:18 |
| johnthetubaguy | so we can always do a stable branch backport for this one | 18:18 |
| johnthetubaguy | for the CLI users | 18:18 |
| *** owalsh-afk has joined #openstack-nova | 18:18 | |
| *** owalsh-afk is now known as owalsh | 18:18 | |
| melwitt | johnthetubaguy: so on the race prevention thing, you were just thinking of checking the limit twice? once before object create and once after? | 18:18 |
| johnthetubaguy | melwitt: yeah, I mean thats racey, but in a quota goes low sense | 18:19 |
| melwitt | I guess you'd have to redo the count too | 18:19 |
| melwitt | yeah | 18:19 |
| *** cdent has joined #openstack-nova | 18:19 | |
| *** lpetrut has quit IRC | 18:20 | |
| johnthetubaguy | melwitt: yeah | 18:20 |
| *** dulek has quit IRC | 18:20 | |
| johnthetubaguy | melwitt: its just easier to reason about the correctness | 18:20 |
| melwitt | yeah | 18:21 |
| *** xek_ has joined #openstack-nova | 18:22 | |
| *** pkoniszewski has quit IRC | 18:22 | |
| melwitt | that's actually a painfully easy fix for a bug we have open where someone was able to create 100+ more keypairs than the quota | 18:22 |
| *** xek has quit IRC | 18:22 | |
| melwitt | well, I guess there's still a window there so I dunno how much it would lessen it | 18:23 |
| *** dulek has joined #openstack-nova | 18:23 | |
| *** pkoniszewski has joined #openstack-nova | 18:24 | |
| andreykurilin | ok, I'm near PC | 18:24 |
| *** moshele has joined #openstack-nova | 18:24 | |
| johnthetubaguy | melwitt: I think it would mean we would delete too many though, I could be wrong | 18:24 |
| * johnthetubaguy has to run to rehersal | 18:25 | |
| melwitt | cool, thanks for all the comments on the review | 18:25 |
| *** unicell has quit IRC | 18:25 | |
| andreykurilin | johnthetubaguy SecretHelper is used at L851 - https://review.openstack.org/#/c/424256/10/novaclient/shell.py . It check args and if password is not there it create "prompt" | 18:26 |
| *** yamahata has joined #openstack-nova | 18:26 | |
| andreykurilin | let's do it in Pike... | 18:26 |
| bauzas | andreykurilin: I need to bail out, but I leave you do the change and ping one of us for single-approving the reno change | 18:27 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | 18:27 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 18:27 |
| andreykurilin | bauzas: I need a minute | 18:27 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 18:27 |
| bauzas | andreykurilin: just tell the other core that I'm +2 | 18:27 |
| bauzas | andreykurilin: we need the patch to be merged because we can tag the release | 18:27 |
| bauzas | before* | 18:27 |
| bauzas | andreykurilin: as I need the SHA1 of the merge commit | 18:27 |
| snikitin | sfinucan, johnthetubaguy: Hi guys! I fixed your nits in diagnoistics. Could you please look? https://review.openstack.org/#/c/394480/ | 18:27 |
| cdent | bauzas: i'm around for the next three hours, anything in partivular i should watching? | 18:28 |
| bauzas | cdent: I think we addressed most of the concerns | 18:28 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add release not for fixing token auth method https://review.openstack.org/425822 | 18:28 |
| bauzas | cdent: the scheduler series is in good path, we're waiting for CI results | 18:28 |
| andreykurilin | bauzas: you can add Depends-On | 18:28 |
| cdent | awesome | 18:28 |
| andreykurilin | bauzas: https://review.openstack.org/#/c/425822/1 | 18:29 |
| bauzas | cdent: dansmith had a good valid point about how we should cache the min version | 18:29 |
| *** tblakes has quit IRC | 18:30 | |
| * cdent will catch up | 18:30 | |
| *** unicell has joined #openstack-nova | 18:30 | |
| bauzas | andreykurilin: fast-approved | 18:31 |
| andreykurilin | bauzas: thanks | 18:31 |
| bauzas | andreykurilin: I can't add a Depends-On as I wouldn't know the SHA1 | 18:32 |
| *** rcernin has joined #openstack-nova | 18:32 | |
| bauzas | that's not a change-id that I need to provide | 18:32 |
| andreykurilin | bauzas: why? you can use SHA1 from my commit and do not wait for merge-commit. I think it worked before | 18:32 |
| bauzas | andreykurilin: because I'm not sure we won't get a merge commit | 18:33 |
| andreykurilin | heh | 18:33 |
| andreykurilin | ok, np. It looks like requirements team is ok to wait a bit:) | 18:33 |
| *** amotoki has quit IRC | 18:33 | |
| bauzas | if I'm tagging based on your patch SHA1, then it would cut the release based on your local branch, not gerrit's | 18:34 |
| *** dharinic is now known as dharinic|lunch | 18:35 | |
| bauzas | andreykurilin: we now support 2.41 ? | 18:38 |
| bauzas | just writing release highlights | 18:38 |
| andreykurilin | bauzas: Human beings have dreams. Even dogs have dreams, but not gerrit, gerrit is just a program. An imitation of life. Can a program write a symphony? Can a program turn a... canvas into a beautiful masterpiece?... My local branch is better that gerrit's one. lol | 18:39 |
| andreykurilin | bauzas: yes, 2.41 is latest supported api version | 18:40 |
| bauzas | andreykurilin: okay, so it's confirmed, I can't use your SHA1 | 18:40 |
| bauzas | andreykurilin: http://git.openstack.org/cgit/openstack/python-novaclient/log/ | 18:40 |
| *** unicell has quit IRC | 18:40 | |
| bauzas | andreykurilin: compared to https://review.openstack.org/#/c/425822/1//COMMIT_MSG@1 | 18:41 |
| bauzas | andreykurilin: your parent patch is not HEAD | 18:41 |
| andreykurilin | bauzas: It can be fixed easily by pushing "Rebase" button via gerrit | 18:41 |
| bauzas | don't | 18:42 |
| bauzas | leave the patch be merged and I'll pick the merge commit sha1 | 18:42 |
| andreykurilin | np :) | 18:42 |
| *** mvk has joined #openstack-nova | 18:42 | |
| bauzas | andreykurilin: FYI https://review.openstack.org/#/c/425827/ | 18:44 |
| bauzas | andreykurilin: it's pointing on the current HEAD | 18:44 |
| *** jpena is now known as jpena|off | 18:44 | |
| bauzas | andreykurilin: in case I'm not there, just ping matt with that one and he'll update inline the change | 18:45 |
| snikitin | alex_xu, mriedem: If you are around could you too look at diagnostics patches, please? Today at one moment I had five +2 on my three patches, but had lost all of them because of rebases :( https://review.openstack.org/#/c/394480/ | 18:45 |
| bauzas | or if we are too late, just remove the mention of DNM and leave that be cut | 18:45 |
| andreykurilin | bauzas: got it, thanks | 18:46 |
| * bauzas afk for a bit | 18:46 | |
| bauzas | back in 1 hour-ish | 18:46 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 18:48 |
| *** moshele has quit IRC | 18:49 | |
| *** ijw has joined #openstack-nova | 18:51 | |
| *** bvanhav_ has joined #openstack-nova | 18:52 | |
| *** unicell has joined #openstack-nova | 18:52 | |
| *** tblakes has joined #openstack-nova | 18:52 | |
| dansmith | bauzas: several things failing on both patches | 18:53 |
| *** bvanhav has quit IRC | 18:53 | |
| *** mingyu has joined #openstack-nova | 18:53 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | 18:56 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 18:56 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 18:56 |
| *** mingyu has quit IRC | 18:58 | |
| *** lpetrut has joined #openstack-nova | 19:01 | |
| *** harlowja has quit IRC | 19:02 | |
| *** jdurgin1 has quit IRC | 19:03 | |
| *** derekh has joined #openstack-nova | 19:05 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | 19:07 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 19:07 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | 19:07 |
| *** alexpilotti has joined #openstack-nova | 19:07 | |
| cburgess | Is there an API call to get the contents of the block_device_mapping table for server or volume ID? | 19:08 |
| cburgess | Or is that purely internal? | 19:08 |
| *** alexpilotti has quit IRC | 19:08 | |
| *** alexpilotti has joined #openstack-nova | 19:09 | |
| *** tblakes has quit IRC | 19:10 | |
| artom | cburgess, the deprecated /os-volumes endpoint is probably the closest thing to what you want | 19:10 |
| artom | http://developer.openstack.org/api-ref/compute/?expanded=list-volumes-detail | 19:10 |
| *** avolkov has quit IRC | 19:10 | |
| *** avolkov has joined #openstack-nova | 19:11 | |
| cburgess | Tried that.. tragically it doesn't seem to work. | 19:11 |
| cburgess | I'll take another look at it. | 19:11 |
| artom | cburgess, define not working... | 19:12 |
| artom | Since it's deprecated, you need to cap your client's compute api version to 2.36 | 19:12 |
| *** andymccr has joined #openstack-nova | 19:12 | |
| cburgess | This AZ happens to be liberty so its capped at 2.12 | 19:12 |
| *** mlavalle has quit IRC | 19:13 | |
| *** alexpilotti has quit IRC | 19:13 | |
| cburgess | As for not working... let me rerun the command. | 19:14 |
| cburgess | Ahhh ok it works. | 19:16 |
| *** tblakes has joined #openstack-nova | 19:16 | |
| cburgess | But it does't expose the connection_info field from the block_device_mapping table. | 19:16 |
| cburgess | At least not that I can see | 19:17 |
| cburgess | I was previously passing a volume rather then an attachment id that was what was not working. | 19:17 |
| dansmith | bauzas: os_region_name is apparently unset on the grenade job so your computes are all not starting | 19:17 |
| dansmith | which makes sense I guess without the other grenade change because we're running with the default config from newton | 19:18 |
| dansmith | so your middle patch needs the dep from the last one | 19:18 |
| *** unicell has quit IRC | 19:20 | |
| *** unicell has joined #openstack-nova | 19:20 | |
| *** dharinic|lunch is now known as dharinic | 19:21 | |
| *** browne has joined #openstack-nova | 19:24 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 19:25 |
| openstackgerrit | Dan Smith proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806 | 19:25 |
| dansmith | bauzas: made the caching change, changed the dep to the middle patch, and addressed cdent's comments ^ | 19:25 |
| artom | cburgess, well, if you have a use case for it, you can always propose a spec for a new API microversion that does what you want :) | 19:25 |
| cdent | thanks dansmith | 19:25 |
| * cdent re-reviews | 19:25 | |
| *** karimb has joined #openstack-nova | 19:26 | |
| cburgess | artom I might later. RIght now just trying to fix some corruption that got into the DB (probably from some long ago fixed bug). Might make sense in the future but for now I'll just load up MySQLdb to find what I need. | 19:26 |
| *** derekh has quit IRC | 19:27 | |
| artom | cburgess, aha! Well, good luck in your quest ;) | 19:28 |
| artom | Actually for that use case, straight up DB access is easier, no? You can pipe it to grep and sed and awk and stuff to find what you're looking for easier | 19:29 |
| cburgess | artom Well I'm writting a python script to do what I need but yeah I suppose it is. I just prefer to avoid having to muck about in the DB if I can avoid it. | 19:31 |
| *** amotoki has joined #openstack-nova | 19:34 | |
| *** slaweq__ has joined #openstack-nova | 19:35 | |
| *** jheroux has quit IRC | 19:35 | |
| andymccr | evenin' nova - on the placement api - is there a way to specify which interface (internal/public/admin) will be used to connect to the placement api? i can't see a conf option for that, and it seems to default to public. | 19:38 |
| dansmith | andymccr: it defaults to however you route to that host | 19:39 |
| dansmith | I mean, | 19:40 |
| dansmith | we don't bind to an interface, we just connect to that host, so normal routing applies :) | 19:40 |
| andymccr | dansmith: i mean the "keystone endpoint interface" thats picked - so it looks like its using the publicURL I'm wondering if I can get it to use the internalURL- | 19:41 |
| dansmith | andymccr: I don't know enough about the keystoneclient bits, but .. if you don't set a publicurl maybe? | 19:43 |
| *** Swami has joined #openstack-nova | 19:43 | |
| *** Sukhdev_ has joined #openstack-nova | 19:44 | |
| dansmith | we load the standard keystone client options from [placement] so if you can do something with that, I'd think it works | 19:44 |
| dansmith | andymccr: i.e. https://github.com/openstack/nova/blob/master/nova/conf/placement.py#L45-L46 | 19:44 |
| *** david-lyle has joined #openstack-nova | 19:45 | |
| andymccr | dansmith: ahh good tip - so if i set a keystone option within placement that will set the endpoint type that should work | 19:45 |
| andymccr | thanks a bunch :) | 19:45 |
| andymccr | will look into that | 19:45 |
| *** karimb has quit IRC | 19:45 | |
| dansmith | andymccr: *should* | 19:45 |
| andymccr | haha yeah - most things are like that :) | 19:45 |
| artom | Does Nova officially support Python 3 now? | 19:46 |
| *** jheroux has joined #openstack-nova | 19:53 | |
| *** mtanino has quit IRC | 19:55 | |
| *** weshay is now known as weshay_brb | 19:55 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 19:56 |
| *** enki_anunnaki has quit IRC | 19:56 | |
| *** markvoelker has quit IRC | 20:00 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | 20:00 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Pass APIVersionRequest to extentions https://review.openstack.org/425876 | 20:00 |
| *** READ10 has quit IRC | 20:01 | |
| *** Guest33539 is now known as mgagne | 20:01 | |
| *** mgagne has quit IRC | 20:01 | |
| *** mgagne has joined #openstack-nova | 20:01 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.33 and 2.37 https://review.openstack.org/424759 | 20:05 |
| *** bvanhav_ is now known as bvanhav | 20:06 | |
| *** eharney has quit IRC | 20:08 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Pass APIVersionRequest to extentions https://review.openstack.org/425876 | 20:09 |
| *** harlowja has joined #openstack-nova | 20:09 | |
| bauzas | dansmith: cdent: back there | 20:10 |
| bauzas | scrolling back | 20:10 |
| dansmith | bauzas: back where? | 20:10 |
| bauzas | dansmith: back here | 20:10 |
| bauzas | je suis là | 20:10 |
| dansmith | bauzas: okay, well, just waiting for the latest run with my changes | 20:11 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 20:12 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: vlan field to NetworkInterfaceMetadata object https://review.openstack.org/405950 | 20:12 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954 | 20:12 |
| bauzas | dansmith: oh good point, I missed the grenade Depends-On | 20:13 |
| openstackgerrit | Chris Dent proposed openstack/nova: DNM: Don't clear the tracked instances in resource tracker https://review.openstack.org/425885 | 20:13 |
| bauzas | dansmith: FWIW, I think matt asked for updating as well the devref | 20:15 |
| bauzas | dansmith: I just provided a reno note, but maybe we should do that in a follow-up ? | 20:15 |
| dansmith | yeah | 20:15 |
| bauzas | not needing to be merged for o-3 but still be good for RC1 | 20:15 |
| cdent | dansmith: that review ^^ is checking one of investigations into the redundancies in the resourece_tracker | 20:16 |
| bauzas | dansmith: FWIW, release mgmt people accept for us a few FFE | 20:16 |
| bauzas | the only problem is that we have RC1 next week | 20:16 |
| bauzas | so in case the gate is bad, we could possibly cut o-3 and then merge the needed changes right after | 20:17 |
| bauzas | oooooh | 20:19 |
| bauzas | the requirements are frozen now :( | 20:20 |
| bauzas | andreykurilin: ^ | 20:20 |
| *** weshay_brb is now known as weshay | 20:20 | |
| bauzas | WTF... http://logs.openstack.org/61/417961/31/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/cd57fce/console.html#_2017-01-26_20_10_22_249335 | 20:22 |
| bauzas | dansmith: ^ | 20:22 |
| dansmith | bauzas: that would be an expected error if you're not getting resources from the other node right? | 20:22 |
| bauzas | hhhhmpppfff http://logs.openstack.org/61/417961/31/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/cd57fce/logs/new/screen-n-sch.txt.gz?level=INFO#_2017-01-26_20_06_58_563 | 20:23 |
| bauzas | lemme see | 20:23 |
| bauzas | how it can be possible now we accept older computes | 20:24 |
| *** eharney has joined #openstack-nova | 20:24 | |
| *** mriedem has joined #openstack-nova | 20:28 | |
| mriedem | how's it going? | 20:28 |
| dansmith | mriedem: fungi bumped the devstack fix in the gate, when my change was #1 and almost done, then mine failed on a known bug at #2, currently re-running | 20:30 |
| dansmith | mriedem: while I wait, I'm making a fungi-shaped voodoo doll | 20:30 |
| dansmith | mriedem: sounds like something is still up with bauzas' junk | 20:30 |
| dansmith | mriedem: and I'm eating a chicken pot pie as comfort food | 20:30 |
| dansmith | end of status | 20:30 |
| dansmith | oh great, that devstack fix is failing and going to reset the gate | 20:31 |
| mriedem | i thought bauzas saw the doctor about his junk issue | 20:31 |
| dansmith | the cream isn't working apparently | 20:31 |
| *** avolkov has quit IRC | 20:31 | |
| fungi | dansmith: https://www.seedsnow.com/blogs/news/7186766-how-to-make-a-mushroom-out-of-radish | 20:31 |
| mriedem | le creme | 20:31 |
| dansmith | fungi: hah | 20:31 |
| * fungi starts humming super mario bros. theme music | 20:32 | |
| bauzas | mriedem: unrelated, requirements is now frozen so https://review.openstack.org/#/c/425827/ is in the weeds for capping u-c | 20:32 |
| bauzas | mriedem: *la* crème | 20:32 |
| fungi | dansmith: i think clarkb actually promoted it, but i'll see if i can dig it back up | 20:33 |
| dansmith | fungi: oh, well it's not too late for me to change this into a clarkb doll | 20:33 |
| dansmith | fungi: it needed doing, I'm just annoyed | 20:33 |
| mriedem | bauzas: but we can still release novaclient 7.1.0 can't we? | 20:35 |
| bauzas | of course | 20:35 |
| bauzas | just saying that for u-c | 20:35 |
| bauzas | mriedem: there is a patch in the gate for adding a reno note | 20:35 |
| mriedem | the wifi in our room sucks so maybe sometime this afternoon i'll be able to load some of these links | 20:35 |
| bauzas | mriedem: that's why I'm putting WIP | 20:36 |
| mriedem | reno for what? | 20:36 |
| *** lpetrut has quit IRC | 20:36 | |
| bauzas | mriedem: for the token fix | 20:36 |
| *** lpetrut has joined #openstack-nova | 20:36 | |
| bauzas | in the client | 20:36 |
| bauzas | we agreed to not wait for the CLI | 20:36 |
| bauzas | but given the CLI included the reno note mentioning the regression bugfix of 7.0.0, I preferred asking andreykurilin to provide a separate change for the reno file and I fast-approved it | 20:37 |
| bauzas | mriedem: https://review.openstack.org/#/c/425822/1 is the patch in question | 20:38 |
| *** slaweq__ has quit IRC | 20:38 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 20:38 |
| *** enki_anunnaki has joined #openstack-nova | 20:38 | |
| *** bvanhav has quit IRC | 20:39 | |
| *** mlavalle has joined #openstack-nova | 20:42 | |
| *** pbandark has joined #openstack-nova | 20:45 | |
| mriedem | bauzas: so the fix mentioned in https://review.openstack.org/#/c/425822/ is already fixed and merged? | 20:49 |
| bauzas | mriedem: yup, the python binding | 20:49 |
| bauzas | mriedem: not the CLI | 20:49 |
| mriedem | https://github.com/openstack/python-novaclient/commit/9940e3fe0e47ff5f2f6d05c9564d17fc19ca0f5c | 20:50 |
| mriedem | ok | 20:50 |
| bauzas | mriedem: yup https://review.openstack.org/#/c/419441/ | 20:51 |
| fungi | dansmith: mriedem: i've reenqueued and promoted 425620,7 now | 20:53 |
| dansmith | fungi: and my change too, right? :D | 20:53 |
| dansmith | no, I know. | 20:53 |
| * fungi can only get away with so much | 20:54 | |
| dansmith | I know | 20:54 |
| *** mingyu has joined #openstack-nova | 20:54 | |
| dansmith | bauzas: looks like your bottom two might be merge-able soon | 20:55 |
| bauzas | dansmith: I'm still puzzled by why grenade-multi is unhappy after our changes | 20:56 |
| bauzas | http://logs.openstack.org/61/417961/31/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/cd57fce/logs/new/screen-n-sch.txt.gz?#_2017-01-26_20_06_58_560 tells me that node-[...]154 is not present | 20:57 |
| *** mingyu has quit IRC | 20:59 | |
| *** ijw has quit IRC | 20:59 | |
| *** esmiurium has quit IRC | 20:59 | |
| *** ijw has joined #openstack-nova | 20:59 | |
| cdent | bauzas, dansmith: I need to checkout, anything I should chase tomorrow morning? | 21:00 |
| dansmith | cdent: as of now, I think we're just hoping to land the time-sensitive stuff before tomorrow | 21:00 |
| dansmith | cdent: but someone can send a mail to the list if there's anything | 21:01 |
| cdent | dansmith: I can move stuff around stick around now if there's something specific that I could help with? | 21:01 |
| mriedem | i'm looking through vladikr's vlan metadata stuff again | 21:01 |
| mriedem | after that it's jaypipes' resource class ironic stuff | 21:01 |
| mriedem | cdent: i think we're mostly just watching the gate | 21:02 |
| mriedem | and rechecking | 21:02 |
| dansmith | cdent: unless you staring at the gate will make it go faster than me staring at the gate. otherwise, I'd go | 21:02 |
| dansmith | heh | 21:02 |
| cdent | my experience is that when I look at the gate it fails, so I'm going to go. but yeah, if there's utc morning stuff to do, leave another of those public handoff emails | 21:02 |
| cdent | good luck, break a leg or whatever it takes | 21:03 |
| * cdent waves | 21:03 | |
| * dansmith eyes bauzas' leg | 21:03 | |
| * mriedem cues 1983 metallica | 21:03 | |
| bauzas | meh | 21:03 |
| *** cdent has quit IRC | 21:04 | |
| bauzas | the old compute looks good | 21:04 |
| _gryf | do we need a saw | 21:04 |
| bauzas | but I still don't understand why we're not updating its hostState on the sheduler side | 21:04 |
| _gryf | ? | 21:04 |
| _gryf | oh man. wrong channel | 21:04 |
| bauzas | dansmith: the only possibilty I see with the grenade-multi issue is that we don't have the right service version | 21:09 |
| bauzas | checking whether we are calling placement | 21:10 |
| mriedem | +W on that bottom server groups test patch | 21:13 |
| *** moshele has joined #openstack-nova | 21:14 | |
| bauzas | erf, we don't follow-up passing the req-id to the placement API | 21:14 |
| bauzas | we regenerate a new one | 21:14 |
| bauzas | so good luck for guessing | 21:14 |
| mriedem | bauzas: we want a reno on this right? https://review.openstack.org/#/c/425806/ | 21:15 |
| mriedem | heads up - your computes won't start if you upgrade to ocata but don't have placement configured | 21:15 |
| mriedem | bauzas: yeah cdent is working on that | 21:15 |
| bauzas | mriedem: I did that in the top patch | 21:15 |
| mriedem | bauzas: ok | 21:15 |
| bauzas | mriedem: but I should have splitted the note | 21:15 |
| mriedem | for shame | 21:16 |
| bauzas | mriedem: that said, if we are unable to merge the top one in time, we can just add the note in a follow-up before RC1 | 21:16 |
| bauzas | unless you strongly disagree | 21:16 |
| mriedem | i think we're ok | 21:16 |
| mriedem | we'll have a reno either way before rc1 | 21:16 |
| bauzas | ok | 21:17 |
| claudiub | mriedem: hi. just an fyi, both moshele and sfinucan gave their blessings on the Hyper-V PCI passthrough patch. :D https://review.openstack.org/#/c/420614/ | 21:18 |
| *** annegentle has joined #openstack-nova | 21:18 | |
| mriedem | yeah i saw | 21:18 |
| mriedem | it's in yon tab now | 21:18 |
| *** edmondsw_ has joined #openstack-nova | 21:18 | |
| *** edmondsw_ has quit IRC | 21:18 | |
| mriedem | bauzas: fyi v | 21:18 |
| mriedem | https://review.openstack.org/#/c/414230/ | 21:18 |
| bauzas | dansmith: mriedem: okay, I think we're still calling the placement API even if we have an old node | 21:19 |
| bauzas | proof here http://logs.openstack.org/61/417961/31/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/cd57fce/logs/apache/placement-api.txt.gz#_2017-01-26_20_06_58_531 | 21:19 |
| *** moshele has quit IRC | 21:19 | |
| bauzas | the timings are quite the same, vs. http://logs.openstack.org/61/417961/31/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/cd57fce/logs/new/screen-n-sch.txt.gz?#_2017-01-26_20_06_58_556 | 21:19 |
| bauzas | dansmith: I think we need to instrument that and add more logs | 21:20 |
| bauzas | dansmith: you okay with me testing that? | 21:20 |
| dansmith | bauzas: do we have any other choice? so... sure :) | 21:20 |
| *** liverpoo1er has quit IRC | 21:21 | |
| mriedem | vladikr: are you sure we're getting an int back in the port details for vlan? | 21:21 |
| mriedem | or could it be a string? | 21:21 |
| bauzas | when I think I'm missing the semi-finals of the handball WC because of that... | 21:22 |
| mriedem | WC = bathroom? | 21:24 |
| mriedem | handball in the men's room? | 21:24 |
| mriedem | kinky | 21:24 |
| *** Jack_V has quit IRC | 21:24 | |
| mriedem | bauzas: https://review.openstack.org/#/c/425822/ is merged, i'll update the novaclient 7.1.0 patch while you instrument things | 21:24 |
| *** unicell has quit IRC | 21:24 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 21:27 |
| *** tjones has joined #openstack-nova | 21:28 | |
| bauzas | mriedem: cool | 21:28 |
| bauzas | mriedem: the logging is done, I'm just now waiting the results... | 21:28 |
| *** Swami has quit IRC | 21:29 | |
| mriedem | si capitan | 21:29 |
| *** slaweq has quit IRC | 21:29 | |
| bauzas | France won and goes to final, one good thing at least | 21:30 |
| *** slaweq has joined #openstack-nova | 21:30 | |
| *** smatzek has quit IRC | 21:31 | |
| dansmith | mriedem: I made dash show starred changes in blue, which makes it handy for following stuff through the gate | 21:32 |
| mriedem | cool | 21:33 |
| *** sacharya has quit IRC | 21:34 | |
| *** Jeffrey4l_ has joined #openstack-nova | 21:34 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** dimtruck is now known as zz_dimtruck | 21:37 | |
| dansmith | I have been sitting in the same place since this morning, so I'm going to get up for a bit now that my change is in the gate again, and will be back in a bit | 21:38 |
| dansmith | looks like bauzas' change is failing pep8 | 21:39 |
| bauzas | fk | 21:39 |
| bauzas | I edited inline | 21:39 |
| *** cleong has quit IRC | 21:39 | |
| bauzas | http://logs.openstack.org/61/417961/32/check/gate-nova-pep8-ubuntu-xenial/b7bc39a/console.html#_2017-01-26_21_33_30_781456 | 21:40 |
| bauzas | o_O | 21:40 |
| *** vsaienko has joined #openstack-nova | 21:40 | |
| mriedem | bauzas: the wifi is so terrible here i can't even git review -d your novaclient release change | 21:40 |
| mriedem | so i guess it's on you to update that | 21:40 |
| bauzas | mriedem: roger | 21:41 |
| bauzas | mriedem: FWIW, will use inline gerrit | 21:42 |
| *** rmart04 has joined #openstack-nova | 21:43 | |
| *** eandersson__ has quit IRC | 21:44 | |
| *** hfu has joined #openstack-nova | 21:44 | |
| bauzas | mriedem: dansmith: do you guys think the pep8 issue would prevent us to see the logs correctly? | 21:45 |
| dansmith | eh? | 21:45 |
| bauzas | I don't give a shit to pep8 since I don't want to merge that like this, but I do care about whether the logs are good | 21:45 |
| bauzas | dansmith: http://logs.openstack.org/61/417961/32/check/gate-nova-pep8-ubuntu-xenial/b7bc39a/console.html#_2017-01-26_21_33_30_781456 | 21:45 |
| dansmith | so you want to let it run? that's fine | 21:45 |
| bauzas | yeah | 21:45 |
| dansmith | biab | 21:45 |
| * dansmith & | 21:45 | |
| bauzas | I'll have to bail out in 1h15 so I prefer leave it running | 21:46 |
| *** slaweq has quit IRC | 21:46 | |
| *** catintheroof has quit IRC | 21:47 | |
| *** hfu has quit IRC | 21:47 | |
| *** slaweq has joined #openstack-nova | 21:48 | |
| *** tblakes has quit IRC | 21:51 | |
| *** ijw has quit IRC | 21:52 | |
| *** moshele has joined #openstack-nova | 21:52 | |
| *** tbachman has quit IRC | 21:54 | |
| *** Swami has joined #openstack-nova | 21:54 | |
| *** pbandark has quit IRC | 21:54 | |
| *** tblakes has joined #openstack-nova | 21:56 | |
| *** moshele has quit IRC | 21:57 | |
| *** gouthamr has quit IRC | 22:00 | |
| *** breitz has quit IRC | 22:01 | |
| *** breitz has joined #openstack-nova | 22:01 | |
| *** jheroux has quit IRC | 22:03 | |
| *** smatzek has joined #openstack-nova | 22:04 | |
| *** smatzek has quit IRC | 22:06 | |
| *** smatzek has joined #openstack-nova | 22:06 | |
| *** zz_dimtruck is now known as dimtruck | 22:07 | |
| *** Jack_V has joined #openstack-nova | 22:07 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 22:07 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954 | 22:07 |
| mriedem | vladikr: -1 on https://review.openstack.org/#/c/405954 because that's not handling that we are getting strings back from neutron for the vlan id in the port detials | 22:07 |
| mriedem | *details | 22:07 |
| vladikr | mriedem, just fixed it | 22:08 |
| vladikr | ^^ | 22:08 |
| mriedem | ah good timing :) | 22:08 |
| vladikr | :) | 22:09 |
| *** mtanino has joined #openstack-nova | 22:09 | |
| mriedem | jroll: do we have anything in CI that sets the node.resource_class field? | 22:10 |
| edleafe | recheck finally worked on https://review.openstack.org/#/c/404472/ \o/ | 22:11 |
| *** Jack_V has quit IRC | 22:11 | |
| *** ijw has joined #openstack-nova | 22:12 | |
| *** unicell has joined #openstack-nova | 22:13 | |
| mriedem | edleafe: just wrapping up some comments in there | 22:13 |
| mriedem | edleafe: what sucks is we have nothing in CI to test this new flow http://logs.openstack.org/72/404472/21/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/d12f128/logs/screen-n-cpu.txt.gz#_2017-01-26_18_59_36_215 | 22:13 |
| edleafe | mriedem: okie dokie | 22:13 |
| mriedem | we're still just doing the old thing | 22:14 |
| edleafe | mriedem: yeah, the extra specs stuff for ironic flavors hasn't been done yet | 22:14 |
| jroll | mriedem: I have some stuff in progress to do that thing | 22:15 |
| *** thorst_ has quit IRC | 22:15 | |
| bauzas | dansmith: around ? | 22:15 |
| * vladikr heads out for an hour | 22:16 | |
| *** ijw has quit IRC | 22:17 | |
| bauzas | dansmith: confirmed that the min service version is 16 http://logs.openstack.org/61/417961/32/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/f07f0e1/logs/new/screen-n-sch.txt.gz#_2017-01-26_22_02_47_735 | 22:18 |
| bauzas | while it should 15 | 22:18 |
| bauzas | ;( | 22:18 |
| bauzas | mriedem: ^ | 22:18 |
| *** ijw has joined #openstack-nova | 22:18 | |
| *** ijw has quit IRC | 22:18 | |
| *** ijw has joined #openstack-nova | 22:19 | |
| bauzas | potentially the cache isn't working well | 22:19 |
| *** tbachman has joined #openstack-nova | 22:21 | |
| *** gouthamr has joined #openstack-nova | 22:23 | |
| *** unicell1 has joined #openstack-nova | 22:23 | |
| *** sacharya has joined #openstack-nova | 22:23 | |
| mriedem | edleafe: comments posted | 22:24 |
| mriedem | mostly simple things | 22:25 |
| mriedem | and some missing tests | 22:25 |
| *** unicell has quit IRC | 22:26 | |
| mriedem | dansmith: you should be able to set a str to an IntegerField right? | 22:26 |
| mriedem | or does coerce() just make that work | 22:27 |
| *** baoli has quit IRC | 22:28 | |
| *** edmondsw has quit IRC | 22:29 | |
| *** lpetrut has quit IRC | 22:30 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Add RPC version aliases for Ocata https://review.openstack.org/425958 | 22:32 |
| dansmith | bauzas: no, it shouldn't be the cache, unless we're down long enough to consider the other node down | 22:34 |
| dansmith | and then start before it checks in | 22:34 |
| dansmith | mriedem: I think it will coerce a string to an int yeah | 22:34 |
| mriedem | blarg | 22:34 |
| mriedem | ok lesson learned | 22:34 |
| bauzas | dansmith: any thoughts on why then we have 16? | 22:35 |
| mriedem | vladikr: +2 on your middle change too, even though a couple of the unit tests need tweaks | 22:35 |
| dansmith | bauzas: how long is conductor stopped for? | 22:36 |
| *** burgerk has quit IRC | 22:36 | |
| *** marst has quit IRC | 22:36 | |
| bauzas | dansmith: verifying the tempest test | 22:37 |
| dansmith | service_down_time defaults to 60s so if it is >60s between conductor going down and scheduler coming back up, then it could be excluding the "down" service | 22:37 |
| *** vsaienko has quit IRC | 22:37 | |
| edleafe | mriedem: working on adding the missing tests | 22:39 |
| bauzas | dansmith: the test doesn't assume stopping anything | 22:39 |
| dansmith | bauzas: what test? | 22:39 |
| bauzas | the tempest test | 22:39 |
| bauzas | oh, you mean, upgrade? | 22:39 |
| dansmith | during the upgrade yeah | 22:40 |
| bauzas | so we try to boot on the old node | 22:40 |
| bauzas | I'm asking the service version for computes | 22:40 |
| dansmith | I'm not getting what you're saying | 22:43 |
| bauzas | dansmith: I'm trying to understand the inner logic | 22:43 |
| *** esmiurium has joined #openstack-nova | 22:43 | |
| *** jamesdenton has quit IRC | 22:43 | |
| bauzas | I'm not getting why the scheduler could be excluding the old node if we never upgraded the latter | 22:44 |
| bauzas | wrt the service down time you mentioned | 22:44 |
| *** slaweq has quit IRC | 22:45 | |
| *** slaweq has joined #openstack-nova | 22:46 | |
| *** sacharya has quit IRC | 22:46 | |
| *** owalsh_ has joined #openstack-nova | 22:46 | |
| *** owalsh has quit IRC | 22:46 | |
| dansmith | because conductor was down, so the subnode couldn't refresh its record | 22:46 |
| *** thorst_ has joined #openstack-nova | 22:47 | |
| dansmith | bauzas: see my change to your grenade patch just now | 22:49 |
| *** slaweq has quit IRC | 22:50 | |
| *** pradk has quit IRC | 22:50 | |
| bauzas | dansmith: ah, I see | 22:50 |
| bauzas | dansmith: we're restarting the scheduler too soon | 22:51 |
| dansmith | right, that's what I'm thinking | 22:51 |
| bauzas | without the compute having properly registered back | 22:51 |
| dansmith | right | 22:51 |
| bauzas | gotcha | 22:51 |
| *** thorst_ has quit IRC | 22:51 | |
| bauzas | okay, let's see | 22:51 |
| dansmith | if it's more than 60s then the scheduler's min version calculus will exclude it | 22:51 |
| bauzas | you gonna recheck ? | 22:51 |
| bauzas | I mean the main change | 22:51 |
| *** rmart04 has quit IRC | 22:52 | |
| dansmith | jesus I have to do everything around here! | 22:52 |
| bauzas | :p | 22:52 |
| bauzas | well, I can write a gerrit comment :p | 22:52 |
| *** annegentle has quit IRC | 22:52 | |
| *** slaweq has joined #openstack-nova | 22:54 | |
| *** slaweq has quit IRC | 22:54 | |
| bauzas | dansmith: it's pretty late now, and I have to pass my whole tomorrow on train | 22:54 |
| dansmith | ...oh | 22:55 |
| bauzas | dansmith: I'll have to handover :( | 22:55 |
| dansmith | hmm, okay | 22:55 |
| bauzas | mriedem: thoughts on me officially asking for a FFE? | 22:55 |
| *** Swami_ has joined #openstack-nova | 22:55 | |
| *** slaweq has joined #openstack-nova | 22:55 | |
| mriedem | granted | 22:56 |
| *** mingyu has joined #openstack-nova | 22:56 | |
| *** Swami has quit IRC | 22:56 | |
| *** mdrabe has quit IRC | 22:57 | |
| bauzas | dansmith: FWIW, do you think I should make a note in the reno file that operators have to make sure they leave a large enough window for having all the computes registered back or nope? | 22:57 |
| dansmith | bauzas: well, this is already the case for auto rpc mode, but sure | 22:57 |
| bauzas | right, my point | 22:58 |
| bauzas | it's not specific to the scheduler | 22:58 |
| bauzas | but I just want to make sure it's written somewhere | 22:58 |
| bauzas | either way, I'll have to bail out, but since I'm gonna pledge for a FFE, I will follow-up tomorrow in the train (with limited internet access, but mriedem proved it works) | 22:59 |
| *** Swami_ has quit IRC | 23:00 | |
| mriedem | heh it is possible | 23:00 |
| mriedem | despite wanting to gouge your eyes out | 23:00 |
| *** mingyu has quit IRC | 23:01 | |
| mriedem | crap do we have a meeting right now or was that htis morning? | 23:02 |
| bauzas | I did this morning | 23:02 |
| bauzas | and it should have been 1 hour before if odd week | 23:02 |
| bauzas | a very short one | 23:02 |
| mriedem | ok you ran it, cool, thanks | 23:03 |
| mriedem | my calendar is in my work email which i don't have up | 23:03 |
| mriedem | i'll work on vacation, just not for my employer | 23:03 |
| bauzas | :) | 23:03 |
| bauzas | hope the weather is good at least | 23:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Adding vlans field to Device tagging metadata https://review.openstack.org/405951 | 23:05 |
| mriedem | cloudy today | 23:05 |
| mriedem | vladikr: ^ updated the reno | 23:05 |
| mriedem | to mention it's libvirt-only right now | 23:05 |
| mriedem | these are ready to go https://review.openstack.org/#/q/topic:bp/sriov-pf-passthrough-neutron-port-vlan+status:open | 23:06 |
| mriedem | +2s on all | 23:06 |
| *** dtp has quit IRC | 23:07 | |
| bauzas | mriedem: you have enough bandwidth for git rev'ing ocata-3 ? | 23:07 |
| mriedem | bauzas: yeah | 23:07 |
| mriedem | there is always the 'business center' | 23:07 |
| bauzas | or do you want me to do a WIP and you just update it with the gerrit UI? | 23:08 |
| mriedem | i've got it | 23:08 |
| bauzas | okay | 23:08 |
| bauzas | mriedem: dansmith: thanks for helping me on that busy day | 23:08 |
| mriedem | no problema | 23:09 |
| mriedem | er, de nada | 23:09 |
| * bauzas disappears | 23:11 | |
| mriedem | 319379 is 38 in the gate? | 23:11 |
| mriedem | crap | 23:11 |
| mriedem | dansmith: so i guess i'm going to just be tagging o-3 without the cells v2 change, but don't think that's a major issue | 23:12 |
| *** slaweq has quit IRC | 23:12 | |
| dansmith | mriedem: are you serious? | 23:12 |
| *** slaweq has joined #openstack-nova | 23:12 | |
| mriedem | umm i guess not? | 23:12 |
| mriedem | what breaks | 23:12 |
| dansmith | my heart | 23:13 |
| mriedem | ha | 23:13 |
| *** tlian has quit IRC | 23:13 | |
| dansmith | and the plan is for FFE? | 23:13 |
| dansmith | I really really wanted it in o3 | 23:13 |
| dansmith | it's in the gate, you know | 23:13 |
| mriedem | i dont think FFE == o3 | 23:13 |
| mriedem | at least that's not how i was thinking about it | 23:13 |
| mriedem | they just land on the same day | 23:14 |
| *** annegentle has joined #openstack-nova | 23:14 | |
| mriedem | let me ask | 23:14 |
| dansmith | o3 is FF yes? I'm confused | 23:14 |
| mriedem | meet me in -release | 23:15 |
| *** smatzek has quit IRC | 23:16 | |
| *** dimtruck is now known as zz_dimtruck | 23:16 | |
| mriedem | some comments in the grenade change https://review.openstack.org/#/c/424730/ | 23:21 |
| *** tlian has joined #openstack-nova | 23:21 | |
| *** tjones has left #openstack-nova | 23:21 | |
| *** tblakes has quit IRC | 23:21 | |
| *** esberglu has quit IRC | 23:23 | |
| sfinucan | mriedem: Are we still merging code? | 23:25 |
| * sfinucan keeps odd, European hours | 23:25 | |
| *** esberglu has joined #openstack-nova | 23:25 | |
| mriedem | sfinucan: get these https://review.openstack.org/#/q/topic:bp/sriov-pf-passthrough-neutron-port-vlan+status:open | 23:26 |
| sfinucan | mriedem: That's exactly what I meant :) On it | 23:26 |
| mriedem | dansmith: https://review.openstack.org/#/c/424730/ barfed | 23:28 |
| dansmith | wow sure did | 23:29 |
| mriedem | http://logs.openstack.org/30/424730/9/check/gate-grenade-dsvm-neutron-ubuntu-xenial/bd02e4d/logs/grenade.sh.txt.gz#_2017-01-26_23_08_37_014 | 23:29 |
| *** slaweq has quit IRC | 23:29 | |
| mriedem | /opt/stack/new/grenade/projects/60_nova/resources.sh: line 145: syntax error near unexpected token `10' | 23:29 |
| mriedem | sleep 10 | 23:29 |
| *** esberglu has quit IRC | 23:29 | |
| *** slaweq has joined #openstack-nova | 23:29 | |
| dansmith | lol yeah | 23:30 |
| dansmith | pythash | 23:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: fix vCPU usage reporing for LXC/QEMU guests https://review.openstack.org/393254 | 23:31 |
| *** tlian has quit IRC | 23:32 | |
| *** dtp has joined #openstack-nova | 23:35 | |
| *** slaweq has quit IRC | 23:36 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 23:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738 | 23:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436 | 23:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | 23:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882 | 23:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626 | 23:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix path parameters in os-hypervisors.inc https://review.openstack.org/416911 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512 | 23:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 23:41 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 23:41 |
| *** mingyu has joined #openstack-nova | 23:42 | |
| *** Swami has joined #openstack-nova | 23:43 | |
| *** takashin has joined #openstack-nova | 23:43 | |
| mriedem | claudiub: got the pci pass through one approved | 23:43 |
| *** Swami has quit IRC | 23:46 | |
| *** Swami has joined #openstack-nova | 23:46 | |
| claudiub | mriedem: \o/ Time to party! :D | 23:47 |
| *** annegentle has quit IRC | 23:50 | |
| *** david-lyle has quit IRC | 23:51 | |
| *** jaosorior has quit IRC | 23:53 | |
| *** david-lyle has joined #openstack-nova | 23:54 | |
| *** zz_dimtruck is now known as dimtruck | 23:54 | |
| sfinucan | mriedem: Anything else I need to look at before I log off for the night? | 23:54 |
| mriedem | sfinucan: nope | 23:55 |
| mriedem | sfinucan: everything else is in the gate or being watched by me and dan | 23:55 |
| sfinucan | mriedem: Sweet. Cheers :) | 23:55 |
| mriedem | thanks, later | 23:55 |
| mlavalle | mriedem: you may want to take a look at this bug: https://bugs.launchpad.net/nova/+bug/1659215 | 23:55 |
| openstack | Launchpad bug 1659215 in OpenStack Compute (nova) "Should not allow assign floating IPs that are already assigned to another port" [Undecided,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu) | 23:55 |
| mriedem | mlavalle: bugs are the last thing i want to look at right now | 23:55 |
| mlavalle | mriedem: cool, I'll mark it invalid and you can take a look later | 23:56 |
| mriedem | mlavalle: well, i'll forget, | 23:56 |
| *** rcernin has quit IRC | 23:56 | |
| mriedem | but if it's a big deal, or controversial, or whatever, just start a ML thread about it | 23:56 |
| mlavalle | mriedem: it's not. i'll take care of it. I just wanted a Nova team memeber to take a quick look. But I understand you are too busy now | 23:57 |
| *** rcernin has joined #openstack-nova | 23:57 | |
| mlavalle | mriedem: unless I yell for help, you can forget about it :-) | 23:58 |
| *** rcernin has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!