| *** thorst_ has joined #openstack-nova | 00:00 | |
| *** zz_dimtruck is now known as dimtruck | 00:00 | |
| *** edmondsw has quit IRC | 00:04 | |
| takashin | bauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments? | 00:04 |
|---|---|---|
| bauzas | takashin: hola | 00:04 |
| *** hongbin has quit IRC | 00:04 | |
| bauzas | takashin: sorry, it's 1:05am for me now | 00:05 |
| bauzas | takashin: I'm just about to visit my bed | 00:05 |
| bauzas | takashin: but I'll try to look at it by tomorrow in case my above change is not getting a new problme | 00:05 |
| takashin | bauzas: Thank you. | 00:05 |
| bauzas | takashin: FWIW, opening a tab to remember it | 00:06 |
| bauzas | takashin: but ping me later if you wish (I'm UTC+1) | 00:06 |
| takashin | bauzas: I will ping you later. | 00:07 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V PCI Passthrough https://review.openstack.org/420614 | 00:08 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add unit tests for JSON-Schema' items behavior https://review.openstack.org/415333 | 00:12 |
| takashin | oomichi: Are you around? | 00:16 |
| *** thorst_ has quit IRC | 00:17 | |
| *** thorst_ has joined #openstack-nova | 00:17 | |
| oomichi | takashin: yep | 00:17 |
| takashin | oomichi: Could you review https://review.openstack.org/#/c/408964/ ? | 00:18 |
| oomichi | may I help | 00:18 |
| oomichi | takashin: ok, will review it soon | 00:18 |
| takashin | oomichi: Thank you. | 00:18 |
| oomichi | takashin: oh, huge one ;) | 00:19 |
| oomichi | maybe alex_xu also will help | 00:19 |
| *** thorst_ has quit IRC | 00:22 | |
| takashin | oomichi: I understand that. | 00:22 |
| *** dimtruck is now known as zz_dimtruck | 00:28 | |
| *** rfolco has joined #openstack-nova | 00:29 | |
| amrith | andreykurilin, I will try | 00:31 |
| *** efried has quit IRC | 00:34 | |
| *** jdurgin has quit IRC | 00:37 | |
| *** jwcroppe has quit IRC | 00:41 | |
| *** thorst_ has joined #openstack-nova | 00:42 | |
| *** jwcroppe has joined #openstack-nova | 00:42 | |
| *** thorst_ has quit IRC | 00:44 | |
| *** breitz has joined #openstack-nova | 00:45 | |
| *** jwcroppe has quit IRC | 00:47 | |
| bauzas | mriedem: dansmith: FWIW, I think we probably have a grenade issue for the scheduler upcall change http://logs.openstack.org/61/417961/19/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/b497772/logs/new/screen-n-sch.txt.gz?level=TRACE#_2017-01-24_00_30_31_476 | 00:47 |
| *** hoangcx has joined #openstack-nova | 00:47 | |
| *** efried has joined #openstack-nova | 00:47 | |
| bauzas | I'm getting a MissingAuthPlugin exception from Keystone... | 00:47 |
| *** tbachman has quit IRC | 00:48 | |
| *** zhurong has joined #openstack-nova | 00:48 | |
| *** claudiub has quit IRC | 00:49 | |
| *** jamesdenton has joined #openstack-nova | 00:49 | |
| *** jdurgin has joined #openstack-nova | 00:51 | |
| *** tbachman has joined #openstack-nova | 00:52 | |
| *** jamesden_ has joined #openstack-nova | 00:53 | |
| *** mingyu has joined #openstack-nova | 00:53 | |
| *** dtp has quit IRC | 00:53 | |
| *** jamesdenton has quit IRC | 00:54 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 00:56 |
| *** browne has quit IRC | 00:56 | |
| dansmith | mriedem: bauzas: melwitt: ^ all three patches are passing now, just updated to remove the WIP from the last one | 00:56 |
| bauzas | dansmith: I'll look at it tomorrow morning my time | 00:57 |
| dansmith | bauzas: kthx | 00:57 |
| bauzas | dansmith: in the meantime, it seems we don't provide the placement opts for grenade | 00:58 |
| *** mingyu has quit IRC | 00:58 | |
| dansmith | bauzas: yeah I saw above, have't looked yet tho | 00:58 |
| bauzas | dansmith: ie. http://logs.openstack.org/61/417961/19/check/gate-tempest-dsvm-cells-ubuntu-xenial/e99ce7c/logs/etc/nova/nova.conf.txt.gz has a placement section | 00:58 |
| bauzas | dansmith: vs. http://logs.openstack.org/61/417961/19/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/b497772/logs/etc/nova/nova.conf.txt.gz not having it | 00:58 |
| *** phuongnh has joined #openstack-nova | 00:58 | |
| bauzas | dansmith: so my WIP change is currently +1 for all the dsvm jobs but not for grenade | 00:58 |
| bauzas | possibly because we miss https://github.com/openstack-dev/devstack/blob/master/lib/placement#L102 in grenade | 00:59 |
| dansmith | yeah | 01:00 |
| bauzas | so the problem is that we have not the above for the Newton cloud | 01:01 |
| bauzas | which means that it's not really working in grenade | 01:02 |
| bauzas | I mean, the placement job | 01:02 |
| bauzas | looks terrible to me | 01:02 |
| *** jamielennox is now known as jamielennox|away | 01:02 | |
| bauzas | dansmith: I need direction here before going to bed | 01:04 |
| bauzas | dansmith: because tomorrow morning I won't be knowing what to do | 01:05 |
| dansmith | bauzas: if we have something we have to do in order to upgrade, that has to go into grenade | 01:05 |
| *** a-pugachev has quit IRC | 01:05 | |
| bauzas | dansmith: when we have a config option missed by the old version but needed by the new version, what to do ? | 01:05 |
| dansmith | bauzas: however, I think you could just make the grenade job do whatever we do in newton to enable placement, so that you don't make a grenade change | 01:05 |
| bauzas | just adding it straight to grenade ? | 01:06 |
| dansmith | which config option? | 01:06 |
| bauzas | dansmith: I guess those two https://github.com/openstack-dev/devstack/blob/master/lib/placement#L102-L103 | 01:06 |
| dansmith | it's possible to start placement in newton | 01:06 |
| dansmith | you mean devstack/newton can't? | 01:06 |
| bauzas | maybe, lemme look at the stable branch | 01:06 |
| *** armax has quit IRC | 01:07 | |
| dansmith | bauzas: if not, I think it's going to be kinda ugly.. starting that in grenade, because you'll have to alter the devstack config and because what we *want* is people to start placement in newton | 01:07 |
| bauzas | dansmith: mmm, weirdo https://github.com/openstack-dev/devstack/blob/stable/newton/lib/placement#L110-L111 | 01:07 |
| bauzas | dansmith: just remembering how grenade works | 01:08 |
| bauzas | dansmith: so, we first use the devstack stable branch for running the cloud, then applying the master branch | 01:08 |
| bauzas | right? | 01:08 |
| bauzas | I'm not very expert of grenade unfortunatelty | 01:09 |
| bauzas | nevermind, seeing https://github.com/openstack-dev/grenade#basic-flow | 01:09 |
| *** zz_dimtruck is now known as dimtruck | 01:10 | |
| bauzas | okay, I'll try to investigate then | 01:10 |
| dansmith | yes, that's how it works | 01:11 |
| bauzas | dansmith: okay, thanks | 01:12 |
| bauzas | just stopping today for me | 01:12 |
| bauzas | bye | 01:12 |
| dansmith | o/ | 01:12 |
| *** baoli has joined #openstack-nova | 01:15 | |
| *** jamielennox|away is now known as jamielennox | 01:17 | |
| *** kevinz has joined #openstack-nova | 01:20 | |
| *** baoli has quit IRC | 01:20 | |
| *** mlavalle has quit IRC | 01:23 | |
| *** mvk has quit IRC | 01:26 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add unit tests for JSON-Schema' items behavior https://review.openstack.org/415333 | 01:27 |
| *** markvoelker has joined #openstack-nova | 01:27 | |
| *** mtanino has quit IRC | 01:30 | |
| *** mtanino has joined #openstack-nova | 01:32 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952 | 01:33 |
| *** sofie has joined #openstack-nova | 01:34 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | 01:37 |
| *** armax has joined #openstack-nova | 01:38 | |
| *** rfolco has quit IRC | 01:45 | |
| *** Swami has quit IRC | 01:49 | |
| *** mingyu has joined #openstack-nova | 01:54 | |
| *** mingyu has quit IRC | 01:58 | |
| *** Sukhdev_ has quit IRC | 02:01 | |
| *** kaisers_ has joined #openstack-nova | 02:05 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Don't delete neutron port when attach failed https://review.openstack.org/403568 | 02:07 |
| *** kaisers has quit IRC | 02:08 | |
| *** mingyu has joined #openstack-nova | 02:09 | |
| *** Apoorva has quit IRC | 02:10 | |
| *** edmondsw has joined #openstack-nova | 02:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 02:33 |
| *** diga has joined #openstack-nova | 02:33 | |
| *** mtanino has quit IRC | 02:40 | |
| *** yuntongjin has joined #openstack-nova | 02:40 | |
| *** jose-phillips has quit IRC | 02:44 | |
| *** harlowja has quit IRC | 02:44 | |
| *** tovin07_ has joined #openstack-nova | 02:44 | |
| *** thorst_ has joined #openstack-nova | 02:49 | |
| *** thorst_ has quit IRC | 02:49 | |
| *** edmondsw has quit IRC | 02:51 | |
| *** edmondsw has joined #openstack-nova | 02:52 | |
| *** edmondsw has quit IRC | 02:54 | |
| *** edmondsw has joined #openstack-nova | 02:54 | |
| *** tovin07 has quit IRC | 02:56 | |
| *** hongbin has joined #openstack-nova | 02:56 | |
| *** mriedem has quit IRC | 02:57 | |
| *** edmondsw has quit IRC | 02:59 | |
| openstackgerrit | gengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache https://review.openstack.org/423754 | 03:05 |
| *** tovin07 has joined #openstack-nova | 03:07 | |
| *** tbachman has quit IRC | 03:09 | |
| *** yamahata has quit IRC | 03:22 | |
| *** armax has quit IRC | 03:23 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix device taging after API microversion 2.37 https://review.openstack.org/423952 | 03:24 |
| *** thorst_ has joined #openstack-nova | 03:33 | |
| *** thorst_ has quit IRC | 03:34 | |
| *** jamesden_ has quit IRC | 03:34 | |
| *** zhurong has quit IRC | 03:40 | |
| *** jamesdenton has joined #openstack-nova | 03:45 | |
| *** sudipto has joined #openstack-nova | 03:46 | |
| *** sudipto_ has joined #openstack-nova | 03:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 03:47 |
| *** tbachman has joined #openstack-nova | 03:47 | |
| *** mdnadeem has joined #openstack-nova | 03:48 | |
| *** nicolasbock has quit IRC | 03:54 | |
| *** yuntongjin has quit IRC | 03:55 | |
| *** ociuhandu has quit IRC | 03:57 | |
| *** tbachman has quit IRC | 03:58 | |
| *** jerrygb_ has quit IRC | 04:02 | |
| *** jwcroppe has joined #openstack-nova | 04:02 | |
| *** jwcroppe has quit IRC | 04:02 | |
| *** jwcroppe has joined #openstack-nova | 04:02 | |
| *** jerrygb has joined #openstack-nova | 04:09 | |
| *** jerrygb has quit IRC | 04:10 | |
| *** Apoorva has joined #openstack-nova | 04:11 | |
| gmann | Kevin_Zheng: few comments on tagging fix | 04:12 |
| Kevin_Zheng | I added those test files just for functional testing, do you have any suggestion? cos I found that only one create-req file could exist for one microversion | 04:13 |
| gmann | Kevin_Zheng: actually common req resp file should be fine as with 2.37 one | 04:14 |
| gmann | Kevin_Zheng: all other version req etc should be ok with those till they do not add mandatory field ion req or resp | 04:14 |
| *** tlian has quit IRC | 04:14 | |
| Kevin_Zheng | I will have a closer check after lunch, thanks alot | 04:15 |
| openstackgerrit | Huan Xie proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428 | 04:15 |
| gmann | 2.37 was added because it add networks filed as mandatory in req | 04:15 |
| *** Apoorva_ has joined #openstack-nova | 04:16 | |
| gmann | alex_xu: johnthetubaguy oomichi: what do you think whether it will break users - https://review.openstack.org/423952 | 04:17 |
| gmann | if someone using wrong tag pattern then yes otherwise no change on tag length etc | 04:17 |
| *** Apoorva has quit IRC | 04:20 | |
| *** hongbin has quit IRC | 04:20 | |
| *** ociuhandu has joined #openstack-nova | 04:21 | |
| *** sree has joined #openstack-nova | 04:24 | |
| *** pbandark has joined #openstack-nova | 04:24 | |
| *** sdague has joined #openstack-nova | 04:28 | |
| *** ayogi has joined #openstack-nova | 04:29 | |
| *** jamesdenton has quit IRC | 04:30 | |
| *** jwcroppe has quit IRC | 04:31 | |
| *** udesale has joined #openstack-nova | 04:34 | |
| *** avolkov has quit IRC | 04:38 | |
| *** psachin has joined #openstack-nova | 04:39 | |
| *** diga has quit IRC | 04:43 | |
| *** sree has quit IRC | 04:54 | |
| *** sree has joined #openstack-nova | 04:56 | |
| *** dikonoor has joined #openstack-nova | 04:59 | |
| *** armax has joined #openstack-nova | 05:00 | |
| *** takashin has left #openstack-nova | 05:00 | |
| *** sneti_ has joined #openstack-nova | 05:01 | |
| *** nic has quit IRC | 05:05 | |
| *** adisky_ has joined #openstack-nova | 05:06 | |
| *** kevinz has quit IRC | 05:09 | |
| *** dikonoor has quit IRC | 05:09 | |
| *** diga has joined #openstack-nova | 05:10 | |
| *** jerrygb has joined #openstack-nova | 05:11 | |
| *** prateek has joined #openstack-nova | 05:11 | |
| *** yuntongjin has joined #openstack-nova | 05:16 | |
| *** jerrygb has quit IRC | 05:16 | |
| *** ssurana has joined #openstack-nova | 05:16 | |
| *** ssurana has quit IRC | 05:16 | |
| *** dimtruck is now known as zz_dimtruck | 05:16 | |
| *** sneti_ has quit IRC | 05:18 | |
| *** dikonoor has joined #openstack-nova | 05:19 | |
| *** tommylikehu1 has joined #openstack-nova | 05:20 | |
| *** tommylikehu has quit IRC | 05:20 | |
| *** tommylikehu1 is now known as tommylikehu | 05:20 | |
| *** sdague has quit IRC | 05:23 | |
| *** jwcroppe has joined #openstack-nova | 05:26 | |
| *** ratailor has joined #openstack-nova | 05:28 | |
| *** swamireddy has quit IRC | 05:30 | |
| *** vladikr has quit IRC | 05:34 | |
| *** thorst_ has joined #openstack-nova | 05:35 | |
| *** udesale has quit IRC | 05:36 | |
| *** udesale has joined #openstack-nova | 05:36 | |
| *** thorst_ has quit IRC | 05:40 | |
| *** sudipto_ has quit IRC | 05:47 | |
| *** sudipto has quit IRC | 05:49 | |
| *** guchihiro has joined #openstack-nova | 05:50 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259 | 05:52 |
| *** armax has quit IRC | 05:56 | |
| *** moshele has joined #openstack-nova | 06:04 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259 | 06:07 |
| openstackgerrit | gengchc2 proposed openstack/nova: Improved-the-judgment-of-the-service-status-in-memcache https://review.openstack.org/423754 | 06:07 |
| *** kevinz has joined #openstack-nova | 06:11 | |
| *** lpetrut has joined #openstack-nova | 06:15 | |
| *** satyar has joined #openstack-nova | 06:16 | |
| Kevin_Zheng | gmann: are you still around? | 06:19 |
| gmann | Kevin_Zheng: yea | 06:20 |
| Kevin_Zheng | gmann: hi | 06:20 |
| Kevin_Zheng | gmann: I understand what you are saying in the comment | 06:20 |
| Kevin_Zheng | what I want to do is to test adding tags for virt devices for version 2.37 | 06:21 |
| Kevin_Zheng | because we did it wrong in version 237 before | 06:22 |
| gmann | Kevin_Zheng: yea, in 2.37 file it is fine | 06:23 |
| gmann | Kevin_Zheng: and you can add tests with higher version also by using the same 2.37 json file | 06:23 |
| gmann | 2.40 json file is not needed i think | 06:24 |
| Kevin_Zheng | hmm, maybe I can create two servers in 2.37 json? | 06:24 |
| *** jwcroppe has quit IRC | 06:24 | |
| gmann | Kevin_Zheng: 2 servers means ? | 06:24 |
| Kevin_Zheng | because in 237 we actually tested using "auto" for networks, | 06:24 |
| Kevin_Zheng | we cannot add tag to network parameter | 06:24 |
| Kevin_Zheng | thats why I added another one | 06:25 |
| Kevin_Zheng | and it seems the test structure can only read file name with server-create-req.json | 06:25 |
| gmann | Kevin_Zheng: you can change that auto to what you want to tests - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/server-create-req-v237.json.tpl | 06:25 |
| gmann | Kevin_Zheng: under 2.37, auto bits are being tested alone - https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_samples/servers/v2.37/server-create-req.json.tpl | 06:26 |
| Kevin_Zheng | yeah, I did that in the last patchset | 06:26 |
| Kevin_Zheng | no before the last | 06:27 |
| gmann | Kevin_Zheng: ok | 06:27 |
| Kevin_Zheng | but the compuete node seems not supported tagging | 06:27 |
| Kevin_Zheng | could you have a check and maybe show me how to fix it? because I tried alittle but failed so I tried this way | 06:27 |
| *** sacharya_ has quit IRC | 06:28 | |
| *** armax has joined #openstack-nova | 06:28 | |
| gmann | Kevin_Zheng: sure, ll look | 06:28 |
| Kevin_Zheng | patchset 5 | 06:28 |
| *** sridharg has joined #openstack-nova | 06:28 | |
| *** armax has quit IRC | 06:28 | |
| *** zzzeek has quit IRC | 06:29 | |
| *** ekuris_ has joined #openstack-nova | 06:29 | |
| *** harlowja has joined #openstack-nova | 06:34 | |
| openstackgerrit | Moshe Levi proposed openstack/nova: Remove mox in network/test_linux_net.py https://review.openstack.org/316427 | 06:34 |
| *** mjura has joined #openstack-nova | 06:36 | |
| *** mnestratov has joined #openstack-nova | 06:36 | |
| openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(6): Introduce base PowerVM driver (ssp drv) https://review.openstack.org/422594 | 06:39 |
| *** diga has quit IRC | 06:40 | |
| *** armax has joined #openstack-nova | 06:43 | |
| *** armax has quit IRC | 06:43 | |
| satyar | Hi jaypipes | 06:43 |
| satyar | jaypipes around | 06:44 |
| gmann | Kevin_Zheng: that is strange for me, functional tests runs with fake driver | 06:46 |
| * gmann checking.. | 06:46 | |
| *** armax has joined #openstack-nova | 06:47 | |
| *** bkopilov has quit IRC | 06:47 | |
| *** armax has quit IRC | 06:48 | |
| Kevin_Zheng | gmann: yeah, Thanks | 06:51 |
| *** claudiub has joined #openstack-nova | 06:51 | |
| alex_xu | Kevin_Zheng: just checked https://review.openstack.org/#/c/415330/17, that is what I expected. | 06:52 |
| satyar | Kevin_Zheng is the nova_api_cell0 changed to nova_cell0 now? | 06:53 |
| Kevin_Zheng | alex_xu: thanks, then lets work on the tests | 06:53 |
| *** udesale__ has joined #openstack-nova | 06:53 | |
| alex_xu | Kevin_Zheng: thanks for working on it | 06:53 |
| Kevin_Zheng | satyar: sorry I think you asked the wrong person | 06:53 |
| satyar | :P sorry | 06:53 |
| satyar | alex_xu | 06:54 |
| *** claudiub|2 has joined #openstack-nova | 06:54 | |
| satyar | i saw some changes from Dan Smith | 06:54 |
| satyar | not sure whats the handler here | 06:54 |
| alex_xu | satyar: dansmith is right person to answer that, but I saw this patch https://review.openstack.org/#/c/420437/ | 06:55 |
| *** udesale has quit IRC | 06:56 | |
| *** lpetrut has quit IRC | 06:56 | |
| satyar | Thanks alex_xu | 06:57 |
| *** claudiub has quit IRC | 06:57 | |
| alex_xu | satyar: np | 06:57 |
| *** nkrinner_afk is now known as nkrinner | 06:59 | |
| satyar | Hi dansmith | 06:59 |
| *** jerrygb has joined #openstack-nova | 07:00 | |
| openstackgerrit | Béla Vancsics proposed openstack/nova: Reduce code duplication https://review.openstack.org/342187 | 07:00 |
| *** swamireddy has joined #openstack-nova | 07:00 | |
| *** udesale has joined #openstack-nova | 07:01 | |
| *** udesale__ has quit IRC | 07:03 | |
| *** udesale has quit IRC | 07:04 | |
| *** avolkov has joined #openstack-nova | 07:04 | |
| *** jerrygb has quit IRC | 07:06 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 07:08 |
| *** andreas_s has joined #openstack-nova | 07:12 | |
| *** udesale has joined #openstack-nova | 07:12 | |
| moshele | alex_xu: hi can you review https://review.openstack.org/#/c/423608/ ? | 07:13 |
| *** oanson has quit IRC | 07:16 | |
| *** lpetrut has joined #openstack-nova | 07:16 | |
| *** oanson has joined #openstack-nova | 07:17 | |
| *** adisky_ has quit IRC | 07:19 | |
| *** markus_z has joined #openstack-nova | 07:19 | |
| *** Oku_OS-away is now known as Oku_OS | 07:20 | |
| *** sridharg has quit IRC | 07:21 | |
| *** sridharg has joined #openstack-nova | 07:21 | |
| *** Apoorva_ has quit IRC | 07:23 | |
| *** harlowja has quit IRC | 07:26 | |
| *** sacharya has joined #openstack-nova | 07:28 | |
| *** sacharya has quit IRC | 07:33 | |
| *** mvk has joined #openstack-nova | 07:35 | |
| *** thorst_ has joined #openstack-nova | 07:36 | |
| *** baoli has joined #openstack-nova | 07:36 | |
| *** tesseract has joined #openstack-nova | 07:37 | |
| *** avolkov has quit IRC | 07:38 | |
| *** Sukhdev has joined #openstack-nova | 07:38 | |
| *** mvk has quit IRC | 07:40 | |
| *** baoli has quit IRC | 07:40 | |
| *** thorst_ has quit IRC | 07:40 | |
| *** yuntongjin has quit IRC | 07:45 | |
| alex_xu | moshele: just add it to my list | 07:46 |
| moshele | alex_xu: thanks :) | 07:46 |
| *** ralonsoh has joined #openstack-nova | 07:47 | |
| alex_xu | moshele: np | 07:47 |
| *** mvk has joined #openstack-nova | 07:50 | |
| *** lpetrut has quit IRC | 07:50 | |
| *** ijw has quit IRC | 07:55 | |
| *** udesale__ has joined #openstack-nova | 07:55 | |
| *** udesale has quit IRC | 07:58 | |
| *** sacharya has joined #openstack-nova | 07:59 | |
| *** guchihiro has quit IRC | 08:00 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** gszasz has joined #openstack-nova | 08:04 | |
| *** sacharya has quit IRC | 08:04 | |
| *** lpetrut has joined #openstack-nova | 08:06 | |
| *** praveen has joined #openstack-nova | 08:17 | |
| *** jpena|off is now known as jpena | 08:22 | |
| *** amotoki has quit IRC | 08:24 | |
| *** gszasz has quit IRC | 08:25 | |
| alex_xu | gmann: just prepare to send a mail about the device tag | 08:26 |
| gmann | alex_xu: nice, thanks. | 08:28 |
| gmann | alex_xu: looks like some issue in functional tests also. debugging that | 08:29 |
| *** udesale__ has quit IRC | 08:30 | |
| *** udesale has joined #openstack-nova | 08:30 | |
| alex_xu | gmann: let us put all the info in the mail and discuss at here | 08:31 |
| alex_xu | s/here/there/ | 08:31 |
| *** Sukhdev has quit IRC | 08:31 | |
| *** slaweq has quit IRC | 08:31 | |
| gmann | alex_xu: +1 | 08:32 |
| *** amotoki has joined #openstack-nova | 08:33 | |
| *** slaweq has joined #openstack-nova | 08:33 | |
| *** jpena is now known as jpena|off | 08:33 | |
| *** jpena|off is now known as jpena | 08:40 | |
| *** mfeoktistov has joined #openstack-nova | 08:44 | |
| *** pcaruana has joined #openstack-nova | 08:45 | |
| *** kashyap has quit IRC | 08:47 | |
| *** openstackgerrit has joined #openstack-nova | 08:51 | |
| *** amotoki has quit IRC | 08:53 | |
| snikitin | alex_xu: Hi, Alex! I changed a file name in diagnostics patch and lost your +2 :( Can you look again please? Also I left a comment about your proposal for docs https://review.openstack.org/#/c/355540/ | 08:54 |
| alex_xu | snikitin: ok, I will check that | 08:55 |
| snikitin | thanks! | 08:55 |
| *** lpetrut has quit IRC | 08:56 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** jerrygb has joined #openstack-nova | 09:02 | |
| *** a-pugachev has joined #openstack-nova | 09:03 | |
| *** karimb has joined #openstack-nova | 09:07 | |
| *** bkopilov has joined #openstack-nova | 09:08 | |
| *** jerrygb has quit IRC | 09:08 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/330285 | 09:13 |
| *** efoley has joined #openstack-nova | 09:13 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/330285 | 09:14 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Remove check_attach https://review.openstack.org/335358 | 09:14 |
| *** efoley_ has joined #openstack-nova | 09:17 | |
| *** efoley has quit IRC | 09:21 | |
| *** ijw has joined #openstack-nova | 09:23 | |
| *** owalsh-afk is now known as owalsh | 09:23 | |
| *** derekh has joined #openstack-nova | 09:25 | |
| *** ijw has quit IRC | 09:27 | |
| *** ekuris_ has quit IRC | 09:28 | |
| *** thorst_ has joined #openstack-nova | 09:30 | |
| moshele | sfinucan: hi can you review this https://review.openstack.org/#/c/423608/ | 09:31 |
| sfinucan | moshele: Sure | 09:31 |
| *** lucas-afk is now known as lucasagomes | 09:31 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver. https://review.openstack.org/407977 | 09:32 |
| *** yassine has joined #openstack-nova | 09:34 | |
| *** yassine is now known as Guest86718 | 09:34 | |
| *** thorst_ has quit IRC | 09:35 | |
| *** efoley__ has joined #openstack-nova | 09:39 | |
| *** karimb has quit IRC | 09:40 | |
| *** karimb has joined #openstack-nova | 09:41 | |
| *** mvk has quit IRC | 09:41 | |
| *** karimb has quit IRC | 09:42 | |
| sfinucan | moshele: Done | 09:42 |
| *** efoley_ has quit IRC | 09:43 | |
| *** mingyu has quit IRC | 09:43 | |
| *** kevinz has quit IRC | 09:44 | |
| *** mingyu has joined #openstack-nova | 09:45 | |
| moshele | sfinucan: thanks | 09:45 |
| sfinucan | bauzas: Could you take a look at https://review.openstack.org/#/c/419479 when you have a moment? | 09:47 |
| bauzas | sfinucan: currently under the water because of the scheduler upcall, but I'll try | 09:47 |
| *** sambetts|afk is now known as sambetts | 09:47 | |
| sfinucan | bauzas: No panic at all. Priorities :) | 09:47 |
| *** mingyu has quit IRC | 09:48 | |
| *** mingyu_ has joined #openstack-nova | 09:48 | |
| bauzas | sfinucan: I'm just investigating a grenade issue, hopefully to sort it out soonish | 09:50 |
| *** avolkov has joined #openstack-nova | 09:51 | |
| *** mingyu_ has quit IRC | 09:52 | |
| *** kashyap has joined #openstack-nova | 09:52 | |
| *** ekuris_ has joined #openstack-nova | 09:54 | |
| *** karimb has joined #openstack-nova | 09:56 | |
| *** amotoki has joined #openstack-nova | 09:57 | |
| *** mdnadeem has quit IRC | 09:58 | |
| johnthetubaguy | bauzas: I have added a few ideas on that call placement from scheduler thing: https://review.openstack.org/#/c/417961 | 09:58 |
| johnthetubaguy | bauzas: FWIW, the caching scheduler looks correct to me | 09:59 |
| bauzas | johnthetubaguy: lemme look at | 10:00 |
| *** efoley_ has joined #openstack-nova | 10:01 | |
| *** efoley__ has quit IRC | 10:04 | |
| *** tovin07_ has quit IRC | 10:04 | |
| *** satyar has quit IRC | 10:06 | |
| *** hoangcx has quit IRC | 10:06 | |
| johnthetubaguy | mdbooth: was reading your comment on here: https://review.openstack.org/#/c/408002 | 10:09 |
| johnthetubaguy | mdbooth: very, very valid | 10:09 |
| bauzas | johnthetubaguy: got a few mins for discussing about https://review.openstack.org/#/c/417961 ? | 10:09 |
| johnthetubaguy | mdbooth: I thought of a slight alternative, we could update the config option docs to very clearly state there are 10 steps | 10:09 |
| mdbooth | johnthetubaguy: I wonder if anybody has ever tuned this, tbh. | 10:10 |
| johnthetubaguy | mdbooth: most people just tune the 500 total timeout, AFAIK | 10:10 |
| johnthetubaguy | mdbooth: kill it all might be a better solution (i.e. just hard code it) | 10:11 |
| johnthetubaguy | bauzas: sure thing | 10:11 |
| bauzas | johnthetubaguy: so, AFAICU we're discussing on how to have a right interface | 10:11 |
| mdbooth | We could add a new config variable which is a total, and immediately deprecate the old 2. The new value will default to the product of the deprecated values if not set explicitly. We hardcode 10 steps. | 10:12 |
| bauzas | johnthetubaguy: so, you'd prefer to have https://review.openstack.org/#/c/417961/19/nova/scheduler/host_manager.py@635 in the scheduler report client ? | 10:13 |
| mdbooth | johnthetubaguy: If this is up against the wire I can probably write that today myself, btw. Is this on anybody's radar? | 10:14 |
| johnthetubaguy | mdbooth: we already have the total as a config setting I think, thats the delay between steps, not the size of the steps | 10:14 |
| johnthetubaguy | mdbooth: pkoniszewski is usually responsive if he is around | 10:14 |
| mdbooth | I don't think there's a total time, it's calculated. | 10:14 |
| *** mdnadeem has joined #openstack-nova | 10:15 | |
| pkoniszewski | I'm around | 10:15 |
| pkoniszewski | yeah, I also agree with mdbooth comment, very good point | 10:15 |
| johnthetubaguy | bauzas: I think I would like to see the scheduler directly call the placement client, then pass the return value into the host_state to get back the list of objects | 10:15 |
| johnthetubaguy | bauzas: it could go into the scheduler or the placement client I think | 10:15 |
| johnthetubaguy | mdbooth: I think live_migration_downtime is the config I mean | 10:16 |
| bauzas | johnthetubaguy: you mean the scheduler driver, not the host manager ? | 10:16 |
| bauzas | johnthetubaguy: so we could just drill down a list of hosts to the host manager? | 10:16 |
| johnthetubaguy | mdbooth: there is the total timeout, and the time to reach the total timeout in the steps | 10:16 |
| *** mvk has joined #openstack-nova | 10:16 | |
| bauzas | johnthetubaguy: I need to consider that if so | 10:16 |
| johnthetubaguy | mdbooth: given we also define a time after which the live-migrate is considered failed and we give up, we could use that to define the steps | 10:16 |
| bauzas | johnthetubaguy: I actually made that split because of the CachingScheduler, but lemme think about that loud | 10:17 |
| pkoniszewski | johnthetubaguy: live migration timeout can be set to 0 to disable it | 10:17 |
| johnthetubaguy | bauzas: I think we would pass resource providers into the host manager | 10:17 |
| pkoniszewski | johnthetubaguy: however, nova still needs to increase downtime over time | 10:17 |
| bauzas | johnthetubaguy: I'm not sure I like that | 10:17 |
| johnthetubaguy | bauzas: it shouldn't affect the caching scheduler | 10:17 |
| bauzas | johnthetubaguy: I would pass hosts, not RPs to the Hostmanager | 10:17 |
| gmann | alex_xu: seems like we just broke the validation part, feature still should work | 10:17 |
| johnthetubaguy | pkoniszewski: yeah, we would need a default if that timeout is zero | 10:17 |
| pkoniszewski | we would need some kind of a magic number | 10:17 |
| bauzas | johnthetubaguy: I mean, lemme clarify | 10:18 |
| bauzas | johnthetubaguy: I think having the filter scheduler directly calling the reportclient to get the list of RPs is a good idea | 10:18 |
| alex_xu | gmann: is there still a way to set tag to the bdm or network device? | 10:18 |
| johnthetubaguy | pkoniszewski: it could be some multiple of the 500 seconds setting, if overall timeout is 0 | 10:18 |
| bauzas | johnthetubaguy: what I'm saying is that the translation from RP to compute nodes should still be filter scheduler thing | 10:18 |
| johnthetubaguy | bauzas: agreed | 10:18 |
| johnthetubaguy | bauzas: I think the filter scheduler method stays the same, its just whats in there that changes | 10:19 |
| bauzas | johnthetubaguy: from an interface PoV, that's actually an excellent point | 10:19 |
| bauzas | I mean, the filter scheduler returns compute nodes | 10:19 |
| bauzas | the host manager returns host states | 10:19 |
| johnthetubaguy | bauzas: I kinda like passing the spec_obj into the placement client | 10:19 |
| bauzas | that, I'm not sure | 10:19 |
| johnthetubaguy | ah, OK, you want that to be resource providers? | 10:20 |
| johnthetubaguy | thats fair enough | 10:20 |
| bauzas | johnthetubaguy: because I'd like to see the "spec to RC usage" logic be still a scheduler thing | 10:20 |
| bauzas | the placement client shouldn't expect anything about how the scheduler works | 10:20 |
| mdbooth | johnthetubaguy pkoniszewski: Sorry, even though I only read it yesterday, I still had to refresh it :) | 10:21 |
| gmann | alex_xu: for bdm yes as there is no additionalProperties=False there but yes for network it is not allowed as additionalProperties=False :( | 10:21 |
| bauzas | johnthetubaguy: in particular given I'm now very opiniated on having the resource query being optional depending on the filters | 10:21 |
| gmann | alex_xu: i am modifying tempest device tag tests with all combination and with all version mentioned by you | 10:21 |
| mdbooth | So there's live_migration_downtime, which is the maximum permitted downtime of an instance during live migration | 10:21 |
| gmann | alex_xu: let's see how bdm tag behave on those | 10:21 |
| bauzas | johnthetubaguy: the last 3 days convinced me we need to opt-in the filters | 10:21 |
| *** udesale has quit IRC | 10:21 | |
| johnthetubaguy | mdbooth: totally with you on need to refresh, I guess thats the problem the operators are having too | 10:22 |
| *** kashyap has quit IRC | 10:22 | |
| mdbooth | Then there live_migration_downtime_steps, which is the number of steps to take towards that maximum, and live_migration_downtime_delay, which is the delay between each step. | 10:22 |
| bauzas | johnthetubaguy: either way, thanks for reviewing, that's very good insight, and I can do a new iteration this morning | 10:22 |
| bauzas | johnthetubaguy: FWIW, I'm stuck with grenade not liking the placement service in newton | 10:22 |
| johnthetubaguy | bauzas: I was thinking it would ideally be an object we pass into the placement client (that could be empty) | 10:22 |
| mdbooth | So the total time until we go with the maximum is live_migration_downtime_steps * live_migration_downtime_delay | 10:22 |
| mdbooth | pkoniszewski: Am I reading that right? ^^^ | 10:22 |
| johnthetubaguy | bauzas: ah yeah, that... :( | 10:22 |
| alex_xu | gmann: initial I also think there is no addtionalProperties, but I found it copy that from bdm v1 schema https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/block_device_mapping.py#L61 | 10:22 |
| pkoniszewski | johnthetubaguy: but im still considering a new config option, i see a case where operator might want to get to target downtime in a couple of seconds but still such live migration might need 10+ minutes to complete | 10:23 |
| bauzas | johnthetubaguy: for the moment, I was seeing a dict | 10:23 |
| pkoniszewski | mdbooth: right, that's the current state | 10:23 |
| bauzas | johnthetubaguy: but longer term, why not an object, agreed | 10:23 |
| johnthetubaguy | bauzas: honestly, a TODO in there saying this argument sucks might be all I need on that bit, lol | 10:23 |
| bauzas | I'm just thinking it shouldn't be the Spec object | 10:23 |
| *** adisky_ has joined #openstack-nova | 10:23 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 10:24 |
| johnthetubaguy | bauzas: yeah, thats cool, I just re-read that file, it has to be resource providers | 10:24 |
| bauzas | yup zactly | 10:24 |
| gmann | alex_xu: ahh, yea, thanks for pointing that | 10:24 |
| bauzas | and the scheduler has some internal logic for translating the Spec object into a ResourceProviderQuery object | 10:24 |
| mdbooth | pkoniszewski: My idea just was to add a new option which is the total time, hardcode the number of steps to 10 as you've done, and default the total to the product of the set deprecated values (if they're set). | 10:24 |
| bauzas | whatever the object is | 10:24 |
| johnthetubaguy | bauzas: so maybe if you pass the return value of placement into host_manger get, even if thats just the list of uuids, that would be better | 10:24 |
| alex_xu | gmann: np, I drop in that trap also :) | 10:24 |
| johnthetubaguy | bauzas: yeah, that sounds good | 10:25 |
| johnthetubaguy | bauzas: right now its a dict, but thats OK for now I guess | 10:25 |
| bauzas | johnthetubaguy: I can forge a patch soon | 10:25 |
| mdbooth | pkoniszewski: Incidentally, I also wonderered about setting guest.migrate_configure_max_downtime() on every iteration, regardless of steps. | 10:25 |
| mdbooth | Would that be expensive? | 10:25 |
| bauzas | johnthetubaguy: and I'll wait for sean about how to discuss the grenade thing | 10:25 |
| bauzas | because the issue I guess is that we don't default running the placement service in newton | 10:25 |
| johnthetubaguy | bauzas: cool, hopefully that helps, just didn't quite read as I expected | 10:26 |
| gmann | alex_xu: heh | 10:26 |
| bauzas | so, when upgrading, it fails because the config file is not correctly setup | 10:26 |
| bauzas | that would suppose we would modify the config between newton and ocata, but that's pretty high impacty | 10:26 |
| johnthetubaguy | bauzas: honestly, we might just need to support not having placement while the min_service_version is below a threshold, and only start using it after that point? | 10:27 |
| *** sileht has quit IRC | 10:27 | |
| *** haplo37 has quit IRC | 10:27 | |
| bauzas | johnthetubaguy: that's why I'm waiting the US folks to be up before engaging that convo | 10:27 |
| bauzas | :) | 10:27 |
| *** sileht has joined #openstack-nova | 10:27 | |
| *** kashyap has joined #openstack-nova | 10:27 | |
| bauzas | lots of discussions went already around about the upgrade path | 10:27 |
| johnthetubaguy | mdbooth: we still need something that sets QEMU occasionally on some periodic task, but thats a good point, you can just work out where you should be on the line, and set that value | 10:27 |
| johnthetubaguy | bauzas: yeah | 10:28 |
| johnthetubaguy | bauzas: just curious why we don't do it the usual way, but thats for later | 10:28 |
| bauzas | johnthetubaguy: meaning be gentle with not having the placement service for newton ? | 10:28 |
| bauzas | and gracefully fallback if we don't have the version supported ? | 10:28 |
| bauzas | that's one option but the consensus was that it was okay to have a maintenance window | 10:29 |
| johnthetubaguy | bauzas: well its not really a maintenance window right, its just if you want no outage, you have to do more work | 10:29 |
| openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager https://review.openstack.org/424570 | 10:33 |
| *** efoley__ has joined #openstack-nova | 10:33 | |
| *** derekh has quit IRC | 10:35 | |
| *** haplo37 has joined #openstack-nova | 10:36 | |
| *** efoley_ has quit IRC | 10:37 | |
| *** phuongnh has quit IRC | 10:37 | |
| bauzas | johnthetubaguy: tried to summarize our convo in https://review.openstack.org/#/c/417961/19/nova/scheduler/client/report.py@212, just drop a note if you think I misunderstood our agreement | 10:38 |
| bauzas | meanwhile, writing a new iteration | 10:38 |
| gmann | alex_xu: johnthetubaguy oomichi additionalProperties=False saved us many times but this we only got under its hammer :) | 10:38 |
| gmann | *this time | 10:38 |
| johnthetubaguy | bauzas: we would pass resource providers uuids into the host manager I guess? | 10:41 |
| openstackgerrit | Huan Xie proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428 | 10:41 |
| bauzas | johnthetubaguy: I'm not opiniated on that | 10:42 |
| bauzas | johnthetubaguy: that's fine to me | 10:42 |
| bauzas | because a RP uuid is the compute uuid | 10:42 |
| johnthetubaguy | bauzas: me neither, that just seems simplest at the moment | 10:42 |
| bauzas | so I'd name it compute_uuids | 10:42 |
| bauzas | just to make it clear that I'd never name something related to resource providers into the host manager | 10:43 |
| bauzas | the hostmanager only knows hosts and returns host states | 10:43 |
| bauzas | hence why I think you made an excellent and valid comment | 10:43 |
| bauzas | because my current proposal sucked | 10:43 |
| johnthetubaguy | bauzas: it wasn't that bad, but yeah, that sounds worth a try | 10:44 |
| bauzas | johnthetubaguy: it was poorly designed, if you prefer | 10:44 |
| *** rfolco has joined #openstack-nova | 10:44 | |
| johnthetubaguy | a class was operating on multiple levels of abstractions, causing some confusion, or something like that | 10:44 |
| bauzas | the exact reason why I haven't yet written UTs :) | 10:45 |
| bauzas | because I needed kind of an agreement on the interfaces before moving on | 10:45 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test https://review.openstack.org/424574 | 10:46 |
| BobBall | johnthetubaguy: https://bugs.launchpad.net/nova/+bug/1658877 - found a bug which prevents all XAPI live migrations and we'd really appreciate your input on it. | 10:47 |
| openstack | Launchpad bug 1658877 in OpenStack Compute (nova) "live migration failed with XenServer as hypervisor" [Undecided,In progress] - Assigned to huan (huan-xie) | 10:47 |
| johnthetubaguy | BobBall: I think I saw that patch pass by, will take a peak | 10:48 |
| BobBall | Awesome, thanks. | 10:48 |
| johnthetubaguy | BobBall: why did it work before without the vif mappings there? | 10:49 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix races in glusterfs mount/umount https://review.openstack.org/423402 | 10:50 |
| BobBall | johnthetubaguy: The addition of the interim network to fix the neutron vlan tagging on vif/tap bug (and also to support neutron security groups) introduces a per-VIF network. The per-VIF network doesn't exist (by name) on the destination and therefore XAPI can no longer make a good guess for what the vif mapping should be. | 10:51 |
| johnthetubaguy | BobBall: that would totally do it | 10:51 |
| BobBall | johnthetubaguy: Indeed :( | 10:52 |
| johnthetubaguy | BobBall: this isn't backportable, because of the object version stuff | 10:53 |
| johnthetubaguy | as a heads up | 10:53 |
| BobBall | Understood. I am trying to also understand whether we actually need to pass the mapping back; if we create a network with the same name on the target wouldn't XAPI just do the right thing(tm)? | 10:54 |
| *** ekuris_ has quit IRC | 10:54 | |
| BobBall | Anyway - I'll put review comments in the code. Just wanted to highlight it for you as a heads up. | 10:54 |
| *** derekh has joined #openstack-nova | 10:56 | |
| *** yonglihe has quit IRC | 10:57 | |
| johnthetubaguy | BobBall: why is the vif thing only used for VM.migrate_send? | 10:57 |
| johnthetubaguy | BobBall: is it not accepted by the other call? | 10:57 |
| BobBall | johnthetubaguy: Not needed for sure - it would probably be ignored if it was present. | 10:58 |
| BobBall | johnthetubaguy: Good comment though, we can check the API to be sure. | 10:58 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 11:01 |
| *** jerrygb has joined #openstack-nova | 11:04 | |
| *** tbachman has joined #openstack-nova | 11:04 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | 11:05 |
| *** efoley_ has joined #openstack-nova | 11:05 | |
| *** amotoki has quit IRC | 11:07 | |
| *** ekuris_ has joined #openstack-nova | 11:07 | |
| dims | sean-k-mooney : around? | 11:07 |
| dims | sean-k-mooney : https://review.openstack.org/#/c/423718/ is ready. got the linuxbridge thing working | 11:07 |
| *** efoley__ has quit IRC | 11:08 | |
| *** jerrygb has quit IRC | 11:09 | |
| *** hfu has joined #openstack-nova | 11:10 | |
| *** aloga has quit IRC | 11:17 | |
| *** edmondsw has joined #openstack-nova | 11:20 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | 11:20 |
| bauzas | johnthetubaguy: new iteration, comments welcome $ | 11:20 |
| * bauzas goes afk for lunch | 11:21 | |
| *** mnestratov has quit IRC | 11:22 | |
| *** dikonoo has joined #openstack-nova | 11:22 | |
| *** mnestratov has joined #openstack-nova | 11:22 | |
| *** prateek has quit IRC | 11:22 | |
| *** prateek has joined #openstack-nova | 11:23 | |
| *** ekuris_ has quit IRC | 11:24 | |
| *** edmondsw has quit IRC | 11:24 | |
| *** dikonoor has quit IRC | 11:26 | |
| *** ratailor has quit IRC | 11:27 | |
| *** sree has quit IRC | 11:28 | |
| *** tbachman has quit IRC | 11:28 | |
| *** amotoki has joined #openstack-nova | 11:30 | |
| *** thorst_ has joined #openstack-nova | 11:31 | |
| *** thorst_ has quit IRC | 11:36 | |
| *** ekuris_ has joined #openstack-nova | 11:37 | |
| mdbooth | pkoniszewski: Hey, I'm just looking at https://review.openstack.org/#/c/244489/ | 11:37 |
| *** tbachman has joined #openstack-nova | 11:37 | |
| mdbooth | Inevitably looking at live migration flow | 11:38 |
| mdbooth | So, source does a call to destination.check_can_live_migrate_destination(), which itself does a call back to source.check_can_live_migrate_source(), and then the destination returns the result of the call to the source back to the source over rpc | 11:39 |
| mdbooth | So we're calling check_can_live_migrate_source() on the source, sending the results to the destanation, which then sends them back to the source | 11:39 |
| mdbooth | That seems a little inefficient :) | 11:40 |
| mdbooth | Anyway, that's a problem for another day | 11:40 |
| mdbooth | More immediately, I think there might be a deadlock if there's an exception in _do_check_can_live_migrate_destination, but I'd very much like a second opinion | 11:41 |
| mdbooth | Although... I think I may just have provided my own :) | 11:42 |
| * mdbooth thinks again | 11:42 | |
| pkoniszewski | mdbooth: its not source that calls check_can_live_migrate_destination | 11:42 |
| pkoniszewski | but conductor | 11:42 |
| mdbooth | Ah, es | 11:42 |
| mdbooth | Ok | 11:42 |
| *** tbachman has quit IRC | 11:42 | |
| * mdbooth still doesn't understand why we use conductor here | 11:43 | |
| mdbooth | It just seems like an additional source of potential failure | 11:43 |
| *** owalsh is now known as owalsh-brb | 11:43 | |
| *** nicolasbock has joined #openstack-nova | 11:44 | |
| mdbooth | Re the deadlock, I was thinking that the lock held by live_migration_claim would be held for the duration of the claim context, but of course it's only held whilst generating the claim | 11:45 |
| mdbooth | There's no deadlock | 11:45 |
| *** smatzek_ has joined #openstack-nova | 11:45 | |
| *** owalsh-brb has quit IRC | 11:48 | |
| *** owalsh-brb has joined #openstack-nova | 11:50 | |
| *** owalsh-brb is now known as owalsh | 11:53 | |
| *** aloga has joined #openstack-nova | 11:54 | |
| *** udesale has joined #openstack-nova | 11:55 | |
| *** rmart04 has joined #openstack-nova | 11:57 | |
| johnthetubaguy | mdbooth: its only partially implemented, compute <-> compute RPC traffic shouldn't be allowed, from a security point of view, so ideally you have the conductor own the task, and send messages to the two compute nodes as required, and monitor progress. But naturally we don't have any of that, just the bad bits | 12:01 |
| *** dikonoo has quit IRC | 12:03 | |
| *** hoangcx has joined #openstack-nova | 12:08 | |
| *** hoangcx has quit IRC | 12:09 | |
| *** hoangcx has joined #openstack-nova | 12:11 | |
| *** sahid has joined #openstack-nova | 12:12 | |
| *** sahid has quit IRC | 12:12 | |
| *** sahid has joined #openstack-nova | 12:13 | |
| *** gouthamr has joined #openstack-nova | 12:13 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | 12:16 |
| *** catintheroof has joined #openstack-nova | 12:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/395347 | 12:18 |
| *** lucasagomes is now known as lucas-hungry | 12:19 | |
| *** bvanhav has joined #openstack-nova | 12:20 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | 12:21 |
| *** hoangcx has quit IRC | 12:25 | |
| *** ducttape_ has joined #openstack-nova | 12:27 | |
| *** aojea has quit IRC | 12:28 | |
| *** hfu has quit IRC | 12:30 | |
| *** hfu has joined #openstack-nova | 12:30 | |
| *** hfu has quit IRC | 12:31 | |
| *** aojea has joined #openstack-nova | 12:31 | |
| *** hfu has joined #openstack-nova | 12:31 | |
| *** hfu has quit IRC | 12:31 | |
| *** hfu has joined #openstack-nova | 12:32 | |
| *** hfu has quit IRC | 12:32 | |
| *** gszasz has joined #openstack-nova | 12:33 | |
| *** udesale has quit IRC | 12:37 | |
| *** hoangcx has joined #openstack-nova | 12:37 | |
| *** lpetrut has joined #openstack-nova | 12:37 | |
| *** edmondsw has joined #openstack-nova | 12:41 | |
| openstackgerrit | Moshe Levi proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port https://review.openstack.org/424639 | 12:41 |
| *** edmondsw has quit IRC | 12:45 | |
| *** thorst_ has joined #openstack-nova | 12:47 | |
| *** hoangcx has quit IRC | 12:48 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 12:50 |
| *** stvnoyes has quit IRC | 12:50 | |
| *** sahid has quit IRC | 12:50 | |
| openstackgerrit | Neil Jerram proposed openstack/nova: libvirt: avoid generating script with empty path https://review.openstack.org/411936 | 12:51 |
| *** sahid has joined #openstack-nova | 12:51 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | 12:51 |
| alex_xu | johnthetubaguy: gmann ^ just done the policy one | 12:51 |
| *** krtaylor has quit IRC | 12:51 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | 12:53 |
| *** mingyu has joined #openstack-nova | 12:53 | |
| *** hoangcx has joined #openstack-nova | 12:54 | |
| *** bkopilov has quit IRC | 12:55 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: WIP: libvirt: Always enable firewall https://review.openstack.org/424647 | 12:57 |
| *** mingyu has quit IRC | 12:58 | |
| *** hoangcx has quit IRC | 12:58 | |
| andreykurilin | hi folks! there are several blocked projects(horizon, trove, cinder?!, murano-dashboard...) due to bug with token auth method. Here is a fix https://review.openstack.org/#/c/419441 . Functional tests are also attached there. | 12:59 |
| andreykurilin | Please review as soon as possible | 12:59 |
| andreykurilin | alex_xu johnthetubaguy sdague ^ | 12:59 |
| *** mtanino has joined #openstack-nova | 13:00 | |
| *** owalsh is now known as owalsh-lunch | 13:00 | |
| macsz | danpb ping | 13:00 |
| andreykurilin | Also, I found that token auth method via CLI was broken for a long time(for several novaclient's releases). Fix is the next patch in the chain | 13:00 |
| *** baoli has joined #openstack-nova | 13:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy' https://review.openstack.org/408192 | 13:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate 'console_driver' https://review.openstack.org/408193 | 13:01 |
| kashyap | macsz: He's not on the channel | 13:01 |
| *** baoli has quit IRC | 13:01 | |
| andreykurilin | amrith: several folks verified that fix to novaclient helped with horizon (it uses token auth too). It should help in your case too. let's merge it, make new novaclient's release and recheck trove's code | 13:01 |
| macsz | kashyap do you know where can i find him? | 13:02 |
| kashyap | macsz: Maybe email him or, if it's a public Nova issue, write to upstream openstack-dev list, and CC him | 13:02 |
| johnthetubaguy | andreykurilin: I am running to lunch, but do we know which patch caused the problem? | 13:02 |
| macsz | kashyap: thanks | 13:02 |
| *** baoli has joined #openstack-nova | 13:02 | |
| *** liverpooler has joined #openstack-nova | 13:02 | |
| andreykurilin | johnthetubaguy: bon appetit! | 13:02 |
| sfinucan | johnthetubaguy: An easy, post-merge conflict +2/+W for you (for after lunch :)) https://review.openstack.org/408193 | 13:03 |
| andreykurilin | johnthetubaguy: for python-api - my patch which removes custome implementation of HTTPClient made it. there were a bunch of patches with + from keystone cores, but we missed to transmit several variables to keystone Token class | 13:03 |
| openstackgerrit | Steven Webster proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | 13:04 |
| *** krtaylor has joined #openstack-nova | 13:04 | |
| *** sree has joined #openstack-nova | 13:04 | |
| *** lpetrut has quit IRC | 13:04 | |
| andreykurilin | johnthetubaguy: as for CLI, imo, https://github.com/openstack/python-novaclient/commit/1f11840dd84f3570330d1fcd53d1e8eea5ff7922 broke it. more than a year ago.. | 13:04 |
| *** takashin has joined #openstack-nova | 13:05 | |
| *** cdent has joined #openstack-nova | 13:05 | |
| takashin | bauzas: Are you around? | 13:05 |
| *** jerrygb has joined #openstack-nova | 13:05 | |
| *** stvnoyes has joined #openstack-nova | 13:05 | |
| mdbooth | Do we currently recalculate numa topology on live migration? | 13:06 |
| andreykurilin | johnthetubaguy: in case of python-API: previously, Token auth method worked only via our custom HTTPClient implementation. It means that only Keystone V2 was supported. Switch to SessionClient for 100% cases was done here - https://review.openstack.org/#/c/304035/ | 13:07 |
| sfinucan | mdbooth: Narp | 13:08 |
| sfinucan | mdbooth: Isn't that the patch you were reviewing last night? | 13:08 |
| mdbooth | sfinucan: Ok, cool. | 13:08 |
| mdbooth | sfinucan: I'm reviewing it now, but I was wondering if it clashed with anything :) | 13:08 |
| *** sree has quit IRC | 13:08 | |
| * mdbooth thought we already did that for some reason. | 13:08 | |
| sfinucan | Aha, no - you're good. None of that stuff is recalculated at present, leading to a host of bugs around CPU pinning, hugepages and anything else NUMA-affinitized | 13:09 |
| mdbooth | sfinucan: Have you reviewed this, btw? | 13:09 |
| *** jerrygb has quit IRC | 13:10 | |
| sfinucan | Aye, multiple times. I never made it to the end though before it got respun :) | 13:10 |
| mdbooth | I'm assuming that means that, priority list or not, it's not making it into Ocata. | 13:11 |
| mdbooth | It's 'one of those' | 13:12 |
| mdbooth | sfinucan: Incidentally, how do guests feel about having their instance topologies changed? | 13:13 |
| mdbooth | sahid: Do you know the answer to ^^^ ? | 13:13 |
| sfinucan | mdbooth: idk - it really needs to get in but we keep finding corner cases (race conditions, etc.) | 13:13 |
| sfinucan | ...and it's so damn big that reviewing it turns into a chore each time | 13:14 |
| mdbooth | Where have the races been? | 13:14 |
| mdbooth | There's one in there now, btw. I already commented on that. | 13:14 |
| mdbooth | It's trivial to fix, though, just a missing sync context manager | 13:14 |
| sfinucan | cfriesen pointed out a few some time back. I don't know if they were addressed | 13:14 |
| *** tbachman has joined #openstack-nova | 13:15 | |
| sfinucan | mdbooth: As for the instance topology, I don't think the actual topologies change | 13:15 |
| sfinucan | i.e. how many sockets/cores/threads everything has | 13:15 |
| *** lucas-hungry is now known as lucasagomes | 13:16 | |
| sfinucan | rather, how these are aligned under the hood | 13:16 |
| sfinucan | on the host, that is | 13:16 |
| * mdbooth hasn't looked at the implementation of numa_fit_instance_to_host | 13:16 | |
| *** dave-mccowan has joined #openstack-nova | 13:18 | |
| *** edmondsw has joined #openstack-nova | 13:18 | |
| sfinucan | I could be wrong there though. The scheduler is still mostly black magic to me :( | 13:19 |
| *** edmondsw has quit IRC | 13:20 | |
| sfinucan | mdbooth: numa_fit_instance_to_host takes an already defined instance_topology and shouldn't change anything about that (besides pinning information, which is the bug I'm sidestepping here https://review.openstack.org/#/c/419479/) | 13:20 |
| *** edmondsw has joined #openstack-nova | 13:20 | |
| mdbooth | sfinucan: Cool. | 13:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname https://review.openstack.org/396130 | 13:23 |
| *** ijw has joined #openstack-nova | 13:23 | |
| *** tbachman has quit IRC | 13:24 | |
| *** tbachman has joined #openstack-nova | 13:26 | |
| *** ayogi has quit IRC | 13:26 | |
| *** ijw has quit IRC | 13:28 | |
| *** ducttape_ has quit IRC | 13:29 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 13:32 |
| *** gouthamr has quit IRC | 13:32 | |
| *** armax has joined #openstack-nova | 13:34 | |
| *** sree has joined #openstack-nova | 13:36 | |
| *** kylek3h has joined #openstack-nova | 13:37 | |
| *** praveen has quit IRC | 13:38 | |
| *** hoangcx has joined #openstack-nova | 13:39 | |
| *** mdnadeem has quit IRC | 13:39 | |
| *** acabot has joined #openstack-nova | 13:41 | |
| *** Jeffrey4l_ is now known as Jeffrey4l | 13:42 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Added instance.reboot.error to the legacy notifications https://review.openstack.org/411816 | 13:44 |
| *** pbandark has quit IRC | 13:44 | |
| *** jpena is now known as jpena|lunch | 13:45 | |
| *** vladikr has joined #openstack-nova | 13:45 | |
| *** huanxie has joined #openstack-nova | 13:50 | |
| bauzas | johnthetubaguy: not sure I see which points in particular you want to change for https://review.openstack.org/#/c/417961/20 ? | 13:50 |
| *** udesale has joined #openstack-nova | 13:50 | |
| bauzas | johnthetubaguy: just a naming thing, or more about how to not return a NoValidHosts in case we don't have the placement service ready yet ? | 13:50 |
| johnthetubaguy | bauzas: the naming thing was my main worry | 13:50 |
| bauzas | the latter needs discussion because I think the general agreement was against that | 13:50 |
| bauzas | but that's tied to the grenade issue | 13:51 |
| bauzas | maybe an hangout could help with folks around | 13:51 |
| bauzas | but we would be missing jaypipes and matt | 13:51 |
| bauzas | :( | 13:51 |
| bauzas | in the meantime, I can do the naming thing | 13:52 |
| cdent | bauzas, johnthetubaguy : I'm not yet caught up on that review, but will be within about two hours. Will try to add my perspective, if it differs from anything already there. | 13:52 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | 13:52 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot.error notification https://review.openstack.org/411791 | 13:53 |
| bauzas | cdent: refrain your pencil, I have a patch to do for modifying the interface name | 13:53 |
| cdent | ✔ | 13:53 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 13:53 |
| *** armax has quit IRC | 13:54 | |
| andreykurilin | bauzas: hi! please look at https://review.openstack.org/#/c/419441 it is critical fix for several projects | 13:54 |
| *** cdent has quit IRC | 13:56 | |
| *** udesale has quit IRC | 13:57 | |
| takashin | bauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments? | 13:59 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot.error notification https://review.openstack.org/411791 | 13:59 |
| tdurakov | paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk mrhillsman raj_singh wznoinsk siva_krishnan hi folks, live migration subteam meeting in a minute | 13:59 |
| *** owalsh-lunch is now known as owalsh | 14:00 | |
| *** karimb has quit IRC | 14:00 | |
| takashin | bauzas: Are you around? | 14:01 |
| johnthetubaguy | bauzas: I think I don't really understand fully what the current proposal for update is / means, so its hard to comment on it. | 14:01 |
| bauzas | johnthetubaguy: that's why I think an hangout could be nice | 14:02 |
| *** prateek has quit IRC | 14:02 | |
| takashin | bauzas: Could you review https://review.openstack.org/#/c/408955/ again and check my comments? | 14:02 |
| bauzas | johnthetubaguy: so you could give your insight once knowing all | 14:02 |
| *** karimb has joined #openstack-nova | 14:02 | |
| *** timello has quit IRC | 14:03 | |
| johnthetubaguy | bauzas: yeah, that could work | 14:03 |
| bauzas | johnthetubaguy: and honestly, I tend to listen to your voice for operating insights :) | 14:03 |
| bauzas | takashin: yup, in my queue, I haven't forgotten | 14:03 |
| bauzas | just feeling the FF breeze chilling me | 14:03 |
| takashin | bauzas: Thank you. | 14:03 |
| openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager https://review.openstack.org/424570 | 14:04 |
| bauzas | unrelated, having the UTs running with osprofiler anytime seems sooo wrong to me | 14:04 |
| bauzas | DinaBelova: around ? | 14:05 |
| bauzas | DinaBelova: why are we needing to verify osprofiler anytime we run U | 14:05 |
| bauzas | UTs? | 14:05 |
| bauzas | can't it be part of the regular unittest job? | 14:05 |
| bauzas | as a developer, I don't really need to verify that anytime I'm modifying an internal change | 14:06 |
| bauzas | that's... silly | 14:06 |
| bauzas | but I truly understand it could be part of the UT coverage | 14:06 |
| bauzas | or a specific job | 14:06 |
| *** ducttape_ has joined #openstack-nova | 14:06 | |
| *** acabot has quit IRC | 14:08 | |
| *** mdrabe has joined #openstack-nova | 14:08 | |
| *** jamesdenton has joined #openstack-nova | 14:08 | |
| *** tblakes has joined #openstack-nova | 14:09 | |
| *** bvanhav_ has joined #openstack-nova | 14:10 | |
| *** jsheeren has joined #openstack-nova | 14:10 | |
| *** bvanhav has quit IRC | 14:11 | |
| jsheeren | hi all, the default flavors in mitaka and earlier had a naming like m1.small etc, what is the origin of this? to be similar to amazon? | 14:11 |
| *** ducttape_ has quit IRC | 14:11 | |
| *** timello has joined #openstack-nova | 14:12 | |
| *** rmart04 has quit IRC | 14:12 | |
| andreykurilin | ACHTUNG! Nova's intergration with Horizon, Trove, Murano-dashboard, Cinder(?!) is broken - https://review.openstack.org/#/c/419441 | 14:12 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | 14:13 |
| *** mtanino has quit IRC | 14:13 | |
| andreykurilin | jaypipes ^ | 14:13 |
| bauzas | andreykurilin: on it | 14:14 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 14:14 |
| andreykurilin | bauzas: thanks :) | 14:14 |
| bauzas | andreykurilin: AFAIK, it's impacting TripleO as well, so I'd recommend to tag the bug as critical | 14:14 |
| andreykurilin | bauzas: done | 14:15 |
| *** takashin has left #openstack-nova | 14:15 | |
| *** gouthamr has joined #openstack-nova | 14:16 | |
| *** esberglu has joined #openstack-nova | 14:16 | |
| bauzas | andreykurilin: diana_clarke: there is a follow-up for fixing CLI, correct? | 14:17 |
| diana_clarke | bauzas: yup | 14:17 |
| andreykurilin | bauzas: https://review.openstack.org/#/c/424256 | 14:17 |
| bauzas | okay, let's merge the first one and see the CLI then | 14:17 |
| andreykurilin | bauzas: it is broken for more than a year :( | 14:18 |
| bauzas | diana_clarke: could you please mark your change as Related-bug ? | 14:18 |
| *** krtaylor has quit IRC | 14:18 | |
| diana_clarke | ^ andreykurilin | 14:18 |
| diana_clarke | (I don't have a change to mark as related) | 14:19 |
| andreykurilin | bauzas: I think we do not have a right bug-report for CLI, but I can create it for proper history | 14:19 |
| bauzas | andreykurilin: oh wait, the bug is 6 month old ? | 14:19 |
| bauzas | if so, that's definitely not a critical :p | 14:20 |
| andreykurilin | lol | 14:20 |
| andreykurilin | bauzas: token auth via python API is broken since 7.0.0 | 14:20 |
| andreykurilin | it is just several weeks | 14:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect job completion https://review.openstack.org/399735 | 14:20 |
| andreykurilin | bauzas: keystoneauth1 provides helpers for CLI layer and usage of it was broken from the beggining (~1 year) | 14:21 |
| *** sahid has quit IRC | 14:21 | |
| *** smatzek_ has quit IRC | 14:21 | |
| johnthetubaguy | andreykurilin: had some concerns with the CLI patch, not sure if I am correct though | 14:21 |
| *** tbachman has quit IRC | 14:22 | |
| johnthetubaguy | bauzas: andreykurilin: when is release freeze for the client though? | 14:22 |
| *** gszasz has quit IRC | 14:23 | |
| johnthetubaguy | I think its this week | 14:23 |
| *** mingyu has joined #openstack-nova | 14:23 | |
| bauzas | johnthetubaguy: it was last week | 14:24 |
| *** flaper87 has quit IRC | 14:24 | |
| bauzas | hence my concern about the prio of the bug | 14:24 |
| johnthetubaguy | wasn't that non-clients | 14:24 |
| bauzas | oh wait | 14:24 |
| bauzas | I guess you're right | 14:24 |
| bauzas | sec, verifying | 14:24 |
| johnthetubaguy | seems like we just released something that is really quite broken | 14:24 |
| johnthetubaguy | and it used to work in the previous "stable" release | 14:24 |
| bauzas | Jan 23 - Jan 27 | 14:24 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_attach notification https://review.openstack.org/401992 | 14:24 |
| bauzas | https://releases.openstack.org/ocata/schedule.html | 14:24 |
| johnthetubaguy | yeah, thats how I read it too | 14:24 |
| bauzas | we're all good | 14:25 |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_detach notification https://review.openstack.org/408676 | 14:25 |
| johnthetubaguy | bauzas: it does feel quite urgent to me | 14:25 |
| bauzas | johnthetubaguy: agreed, just wanted to understand the problem statement | 14:26 |
| *** tovin07_ has joined #openstack-nova | 14:26 | |
| bauzas | and why it's broken since weeks | 14:26 |
| bauzas | the bug is open since early January | 14:26 |
| *** sree has quit IRC | 14:27 | |
| diana_clarke | bauzas: because it wasn't used by other projects until u-c was bumped, IIUC. | 14:27 |
| *** acabot has joined #openstack-nova | 14:27 | |
| bauzas | when was the bump ? | 14:27 |
| diana_clarke | bauzas: 19th | 14:27 |
| bauzas | diana_clarke: ah ok | 14:27 |
| diana_clarke | bauzas: https://review.openstack.org/#/c/414170/ | 14:27 |
| bauzas | that explains more | 14:27 |
| *** tbachman has joined #openstack-nova | 14:27 | |
| johnthetubaguy | yeah, I was just checking that | 14:28 |
| *** mingyu has quit IRC | 14:28 | |
| johnthetubaguy | that makes sense | 14:28 |
| *** satyar has joined #openstack-nova | 14:28 | |
| *** amotoki has quit IRC | 14:29 | |
| *** mlavalle has joined #openstack-nova | 14:29 | |
| *** tovin07_ has quit IRC | 14:29 | |
| *** breitz has quit IRC | 14:30 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.volume_detach notification https://review.openstack.org/408676 | 14:30 |
| *** krtaylor has joined #openstack-nova | 14:31 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 14:31 |
| andreykurilin | johnthetubaguy: fixed your comment ^ | 14:31 |
| johnthetubaguy | andreykurilin: sorry, I added another comment after I spotted something else | 14:32 |
| johnthetubaguy | around the domain being optional | 14:33 |
| andreykurilin | johnthetubaguy: I left an answer to it :) | 14:33 |
| andreykurilin | johnthetubaguy: it is optional but has default values | 14:33 |
| *** udesale has joined #openstack-nova | 14:34 | |
| *** larainema has joined #openstack-nova | 14:34 | |
| andreykurilin | johnthetubaguy: since it exist in both token and password auth methods, it is ok. user_id exists only in password method and in case of token one, it is just filtered and no metter do we have default values or not | 14:34 |
| johnthetubaguy | andreykurilin: doh, I can't read problem, I see your comment now, makes sense | 14:34 |
| johnthetubaguy | s/read problem/read properly/ | 14:34 |
| andreykurilin | johnthetubaguy: :) | 14:35 |
| *** amotoki has joined #openstack-nova | 14:35 | |
| *** eharney has joined #openstack-nova | 14:37 | |
| *** ducttape_ has joined #openstack-nova | 14:37 | |
| *** krtaylor has quit IRC | 14:37 | |
| *** tovin07_ has joined #openstack-nova | 14:38 | |
| kuzko | hello,I would like to know if there are special command lines or something special to do to allow for UEFI boot of a volume? | 14:38 |
| *** bvanhav_ is now known as bvanhav | 14:38 | |
| *** tovin07_ has quit IRC | 14:38 | |
| andreykurilin | bauzas johnthetubaguy: there is one more high priority bug, which affects cinder and horizon(and openstackclient ?!). Fix is almost ready, just require proper release note. I'll try to reach the author of fix to make it asap | 14:39 |
| johnthetubaguy | andreykurilin: cool, thanks for chasing, as always! | 14:39 |
| *** jsheeren has quit IRC | 14:39 | |
| bauzas | andreykurilin: have you discussed with matt about a release soon ? | 14:39 |
| bauzas | andreykurilin: do you want me to tag the release ? | 14:40 |
| *** cdent has joined #openstack-nova | 14:40 | |
| bauzas | andreykurilin: I mean, I'm theorically the release liaison so release management cores would be okay with me providing this change without matt +1ing it | 14:41 |
| andreykurilin | bauzas: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2017-01-23.log.html#t2017-01-23T17:31:51 | 14:41 |
| andreykurilin | bauzas: yesturday I informed Matt about an issue and notified him about required release, he gave ack :) | 14:42 |
| *** lpetrut has joined #openstack-nova | 14:43 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager https://review.openstack.org/424570 | 14:43 |
| bauzas | andreykurilin: johnthetubaguy: I have a nit about the reno note | 14:44 |
| andreykurilin | bauzas: again. CLI brackage was introduced a year ago | 14:44 |
| *** jerrygb has joined #openstack-nova | 14:44 | |
| andreykurilin | in 2015 | 14:44 |
| andreykurilin | :) | 14:44 |
| bauzas | andreykurilin: I'd prefer if you could respin very quick so I could apply a +2/+W based on john's already giving you +2 | 14:44 |
| bauzas | andreykurilin: sure, but the novaclient thing is new | 14:44 |
| andreykurilin | bauzas: I attached a bug report in commit message with link to patch that introduced an issue | 14:44 |
| bauzas | andreykurilin: please consider application developers that fetch novaclient and look at the release notes to see what changed | 14:45 |
| bauzas | andreykurilin: those people wouldn't read the commit msg | 14:45 |
| bauzas | andreykurilin: I got that the CLI breakage is old, but the novaclient thing is new, right? | 14:45 |
| bauzas | andreykurilin: so, maybe 2 bullets is fine by me, but you should at least explain since when we had that regression | 14:46 |
| andreykurilin | bauzas: usage via python api yes - it is new:) via cli is old. | 14:46 |
| *** sahid has joined #openstack-nova | 14:46 | |
| bauzas | or people would say "WAT? I wasn't able to use token auth? seriously?" | 14:46 |
| andreykurilin | We broke CLI in 3.1.0 release of novaclient. lol | 14:47 |
| bauzas | 3.1.0 is not that old | 14:47 |
| bauzas | we have people running it | 14:47 |
| bauzas | that I know | 14:47 |
| andreykurilin | heh | 14:47 |
| dansmith | johnthetubaguy: if you have any time to review the bottom two patches on the cells series I'd appreciate it: https://review.openstack.org/#/c/396775/42 | 14:47 |
| dansmith | johnthetubaguy: those three patches basically get us to our goal for cellsv2 for the cycle | 14:47 |
| bauzas | so, yeah, I think that's important for us to comment when the breakage was introduced | 14:47 |
| *** jerrygb_ has joined #openstack-nova | 14:47 | |
| andreykurilin | ok. I'll update my patch in seconds to not scare people:) | 14:47 |
| *** pradk has quit IRC | 14:47 | |
| bauzas | dansmith: I haven't forgotten you | 14:47 |
| *** pradk has joined #openstack-nova | 14:48 | |
| johnthetubaguy | dansmith: I will take a peak at that now | 14:48 |
| *** gouthamr_ has joined #openstack-nova | 14:49 | |
| *** jerrygb__ has joined #openstack-nova | 14:49 | |
| *** vladikr has quit IRC | 14:49 | |
| *** jpena|lunch is now known as jpena | 14:49 | |
| *** psachin has quit IRC | 14:50 | |
| *** rmart04 has joined #openstack-nova | 14:50 | |
| *** tovin07_ has joined #openstack-nova | 14:50 | |
| *** gouthamr has quit IRC | 14:50 | |
| mdbooth | pkoniszewski: Just been reading through the review history on that patch. moshele mentioned the save() issue here: https://review.openstack.org/#/c/244489/46/nova/compute/manager.py | 14:50 |
| *** jerrygb has quit IRC | 14:51 | |
| mdbooth | My confidence is growing that the rollback issue is real. | 14:51 |
| *** gouthamr_ is now known as gouthamr | 14:51 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 14:51 |
| andreykurilin | bauzas: ^ | 14:52 |
| *** jerrygb_ has quit IRC | 14:52 | |
| *** smatzek has joined #openstack-nova | 14:53 | |
| pkoniszewski | mdbooth: that's right | 14:53 |
| pkoniszewski | mdbooth: but the pre_live_migration bit is correct | 14:53 |
| mdbooth | Yeah. I didn't see a problem there, btw. | 14:54 |
| *** karimb has quit IRC | 14:54 | |
| *** knikolla has joined #openstack-nova | 14:55 | |
| *** belmoreira has joined #openstack-nova | 14:55 | |
| mdbooth | I think it's probably futile to try to prevent calling save on the instance object on such a wide ranging function. Perhaps we should just concede it will happen and deal with it? | 14:55 |
| mdbooth | Well, for live migration we *know* it happens, because we do it in compute manager. | 14:56 |
| openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: ListExtResource given in place of ListExtManager https://review.openstack.org/424570 | 14:57 |
| *** rmart04 has quit IRC | 14:57 | |
| *** amotoki has quit IRC | 14:57 | |
| *** karimb has joined #openstack-nova | 14:57 | |
| *** krtaylor has joined #openstack-nova | 14:58 | |
| *** rmart04 has joined #openstack-nova | 14:58 | |
| andreykurilin | bauzas: and yes, it will be cool, if you propose a new novaclient's release. Not sure about right version- 7.0.1 (since it fixes several issues from 7.0.0) or 7.1.0 (since it contains a bit feauture - support of osprofiler) | 14:58 |
| *** pbandark has joined #openstack-nova | 14:58 | |
| *** armax has joined #openstack-nova | 14:58 | |
| andreykurilin | bauzas johnthetubaguy: it is another high priority fix - https://review.openstack.org/#/c/424570 . just +10, -1 with release notes | 14:59 |
| *** jwcroppe has joined #openstack-nova | 15:00 | |
| *** tbachman has quit IRC | 15:00 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: set vlan tag for macvtap on SR-IOV VFs https://review.openstack.org/421186 | 15:00 |
| *** prateek has joined #openstack-nova | 15:01 | |
| *** tovin07_ has quit IRC | 15:01 | |
| *** jerrygb has joined #openstack-nova | 15:01 | |
| *** sahid has quit IRC | 15:02 | |
| *** mriedem has joined #openstack-nova | 15:02 | |
| dansmith | johnthetubaguy: thanks.. it's going to be a hard push to get this in by thurs, but I'm still trying | 15:03 |
| *** tovin07_ has joined #openstack-nova | 15:04 | |
| *** tlian has joined #openstack-nova | 15:04 | |
| *** jerrygb__ has quit IRC | 15:05 | |
| mriedem | dansmith: don't forget to breath | 15:05 |
| dansmith | mriedem: hoo hoo heee, hoo hoo heee | 15:05 |
| mriedem | exactly | 15:06 |
| *** hoangcx has quit IRC | 15:06 | |
| *** sahid has joined #openstack-nova | 15:07 | |
| *** hongbin has joined #openstack-nova | 15:08 | |
| andreykurilin | johnthetubaguy: Can you put +2 again to https://review.openstack.org/424256 ?) | 15:08 |
| *** kfarr has joined #openstack-nova | 15:09 | |
| *** tbachman has joined #openstack-nova | 15:10 | |
| *** vladikr has joined #openstack-nova | 15:11 | |
| *** sree has joined #openstack-nova | 15:12 | |
| bauzas | dansmith: who's core in grenade ? | 15:12 |
| dansmith | bauzas: me, sdague and dtroyer | 15:12 |
| bauzas | dansmith: I'm firing a patch for making sure we run the placement-engine in Ocata when upgrading, which is not the case | 15:13 |
| *** mtanino has joined #openstack-nova | 15:13 | |
| dansmith | ack | 15:13 |
| *** gouthamr has quit IRC | 15:13 | |
| bauzas | dansmith: http://logs.openstack.org/61/417961/20/check/gate-grenade-dsvm-neutron-ubuntu-xenial/35a48ec/logs/new/local.conf.txt.gz | 15:13 |
| bauzas | dansmith: there is no enabled service that runs the placement engine | 15:13 |
| *** cdelatte has joined #openstack-nova | 15:13 | |
| bauzas | hence the grenade failure on my change | 15:13 |
| dansmith | ack part deux | 15:14 |
| bauzas | so I'm thinking of updating https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/from-newton/upgrade-nova | 15:14 |
| bauzas | dansmith: but any idea how I would do that ? | 15:14 |
| bauzas | is the above pre calling devstack ? | 15:14 |
| *** mtanino has quit IRC | 15:15 | |
| diana_clarke | bauzas: dansmith beat me to it, but for those following along from home, you can see the core here: https://review.openstack.org/#/admin/groups/188,members | 15:15 |
| *** mtanino has joined #openstack-nova | 15:15 | |
| diana_clarke | s/core/cores | 15:15 |
| *** rmart04 has quit IRC | 15:16 | |
| dansmith | bauzas: you can call devstack functions if they're included, yeah, like initialize_database there is from devstack | 15:17 |
| *** rmart04 has joined #openstack-nova | 15:17 | |
| *** READ10 has joined #openstack-nova | 15:17 | |
| *** markvoelker has quit IRC | 15:18 | |
| bauzas | dansmith: I think I got the idea from https://github.com/openstack-dev/grenade/blob/master/projects/60_nova/from-mitaka/upgrade-nova | 15:19 |
| bauzas | I could source lib/placement | 15:19 |
| johnthetubaguy | dansmith: should I be worried about the order of the list of CELLS we are iterating over being the same on all API workers? | 15:19 |
| dansmith | johnthetubaguy: from a sorting perspective? | 15:19 |
| dansmith | er, instance sorting? | 15:19 |
| johnthetubaguy | dansmith: yeah, I was thinking from a fetching a marker perspective | 15:19 |
| *** sahid has quit IRC | 15:20 | |
| bauzas | johnthetubaguy: you mean adding a new cell meanwhile we're iterating ? | 15:20 |
| dansmith | johnthetubaguy: well, so the deal here is that this code is here to officially support only one cell for ocata, | 15:20 |
| johnthetubaguy | dansmith: good point | 15:20 |
| bauzas | johnthetubaguy: if so, I discussed on that yesterday with dansmith and we agreed on not being a problem for ocata | 15:20 |
| dansmith | johnthetubaguy: but so that we can move to the third patch where we're creating in conductor (and thus potentially multiple cells). None of the naive sorting stuff is in here yet, so I think any concern for that is moot, | 15:20 |
| dansmith | but this enables people to play with it | 15:21 |
| *** sahid has joined #openstack-nova | 15:21 | |
| johnthetubaguy | dansmith: in terms of staging things so we get someone, totally makes sense | 15:21 |
| johnthetubaguy | s/someone/somewhere | 15:21 |
| dansmith | johnthetubaguy: right | 15:21 |
| *** markvoelker has joined #openstack-nova | 15:21 | |
| *** amotoki has joined #openstack-nova | 15:22 | |
| dansmith | johnthetubaguy: but yes, following this, we'll want stable sorting of cells, reloading of the cells list, a naive sort approach, etc | 15:22 |
| *** vladikr has quit IRC | 15:22 | |
| johnthetubaguy | dansmith: ack | 15:22 |
| mriedem | oh great device tags is all fubar in the api now too huh | 15:23 |
| *** sree has quit IRC | 15:24 | |
| dansmith | bauzas: johnthetubaguy: sfinucan: the patch after that, by the way, is just a tweak to the api_samples setup, and an approach sdague suggested, so it should be fairly easy to hit I think | 15:24 |
| dansmith | to prevent api_samples from tripping over itself in the final patch | 15:24 |
| bauzas | dansmith: yeah I just began to look at it | 15:25 |
| dansmith | cool | 15:25 |
| *** jaosorior has joined #openstack-nova | 15:25 | |
| *** zz_dimtruck is now known as dimtruck | 15:25 | |
| *** sree has joined #openstack-nova | 15:26 | |
| dansmith | mriedem: if you want an easy one to +W to make your vacation feel productive, this trivial one from sfinucan would be good: https://review.openstack.org/#/c/419479/5 | 15:26 |
| *** amotoki has quit IRC | 15:26 | |
| amrith | thx andreykurilin | 15:26 |
| *** amotoki has joined #openstack-nova | 15:26 | |
| amrith | please let me know once the novaclient patch is released | 15:26 |
| amrith | that'll be the easiest way to test in the gate | 15:27 |
| amrith | could we mark 7.0.0 as bad? | 15:27 |
| *** amotoki has quit IRC | 15:27 | |
| mriedem | amrith: 7.0 isn't in g-r is it? | 15:27 |
| *** amotoki has joined #openstack-nova | 15:27 | |
| mriedem | or u-c rather | 15:27 |
| amrith | well, it is what we're getting now from pypi | 15:27 |
| andreykurilin | mriedem: 7.0 is a version from u-c now :) | 15:27 |
| mriedem | are you using upper-constraints? | 15:27 |
| andreykurilin | also it is a min version of requirements | 15:28 |
| mriedem | andreykurilin: ok, then i guess we should blacklist 7.0 in g-r | 15:28 |
| mriedem | really? why? | 15:28 |
| amrith | mriedem, yes | 15:28 |
| diana_clarke | mriedem: it was merged into u-c on the 19th https://review.openstack.org/#/c/414170/ | 15:28 |
| amrith | global-requirements.txt:python-novaclient>=2.29.0,!=2.33.0 # Apache-2.0 | 15:28 |
| amrith | projects.txt:openstack/python-novaclient | 15:28 |
| amrith | upper-constraints.txt:python-novaclient===7.0.0 | 15:28 |
| amrith | mriedem, yes we're using u-c | 15:28 |
| andreykurilin | mriedem: I think today we will have everything for next release (7.0.1/7.1.0) and we will able to make everything together - blacklist and put right version | 15:28 |
| mriedem | i don't know why we'd require 7.0 as the minimum | 15:29 |
| *** bkopilov has joined #openstack-nova | 15:29 | |
| *** ducttape_ has quit IRC | 15:29 | |
| amrith | mriedem, andreykurilin it may be a good idea to have periodic jobs that test against the tip of master in nova client like we do with oslo. I'll propose such a periodic job | 15:29 |
| mriedem | also the wifi here sucks so everything takes forever to load | 15:29 |
| mriedem | amrith: and where do the results of those jobs go and who is going to be monitoring them? | 15:30 |
| amrith | mriedem, I get an email when they fail | 15:30 |
| amrith | let me find out how that is setup | 15:30 |
| amrith | it is something that dims (I believe) setup a while back | 15:30 |
| mriedem | ok | 15:30 |
| amrith | in general, I'd think that is something that for trove, should be trove's to monitor | 15:31 |
| mriedem | amrith: have you talked to the requirements team about getting a trove unit test job to run as part of changes like this? https://review.openstack.org/#/c/414170/ | 15:31 |
| amrith | have not | 15:31 |
| andreykurilin | mriedem: because all "right version" from min to max should be compatible. we have too much changes now to use 2.29 as a min (like it was previously) | 15:31 |
| amrith | but it is a good idea as well | 15:31 |
| andreykurilin | I mean it is a hard task to write a compatible code for 2.29 and 7.0 | 15:32 |
| mriedem | andreykurilin: well yeah, and that's why we use semver for major changes | 15:32 |
| mriedem | even with fixing the token thing, 7.0 probably breaks a bunch of things | 15:32 |
| andreykurilin | mriedem: it breaks two things - token auth via python API (for CLI it was broken for a year) and list_extension | 15:33 |
| andreykurilin | both of these things have fixes on review | 15:33 |
| mriedem | well by 'break' i mean, intentional changes to remove functionality | 15:34 |
| bauzas | 7.0.0 is breaking more than the token thing ? | 15:34 |
| mriedem | which is why we released it with a major version bump | 15:34 |
| bauzas | do we have a g-r change that blocks it ? | 15:34 |
| mriedem | bauzas: the requirements changes aren't run against trove unit tests, | 15:34 |
| mriedem | otherwise something might have been caught | 15:34 |
| bauzas | and if we have a couple of fixes, let's name the next release 7.0.1 even if we add the osprofiler thing | 15:34 |
| andreykurilin | mriedem: I think we done everything in backward compatible way (except usage of our inner variables) | 15:34 |
| *** armax has quit IRC | 15:34 | |
| *** armax_ has joined #openstack-nova | 15:34 | |
| bauzas | mriedem: yeah, but as per andreykurilin 7.0.0 blew up more than just trove | 15:35 |
| *** prateek has quit IRC | 15:35 | |
| bauzas | mriedem: at least the tripleo folks and the murano folks AFAICS | 15:35 |
| mriedem | bauzas: new features need to be a min version bump at least to 7.1.0 | 15:35 |
| bauzas | I know | 15:35 |
| andreykurilin | bauzas: one more thing that is broken by 7.0 - https://review.openstack.org/#/c/424570/ :) | 15:35 |
| bauzas | I'm saying 7.0.0 is doomed so we would signal that there is a new release fixing it | 15:36 |
| mriedem | on https://review.openstack.org/#/c/423808/ i would have made the min 6.0, and u-c 7.0 | 15:36 |
| andreykurilin | ok, let's use 6.0 as a min, but not 2.29 like it was | 15:36 |
| bauzas | yup :( | 15:36 |
| mriedem | andreykurilin: do you want me to push that change quick? | 15:37 |
| *** huanxie has quit IRC | 15:37 | |
| mriedem | >=6.0.0,!=7.0.0 | 15:37 |
| andreykurilin | mriedem: no, please take a rest. you are on vacation | 15:37 |
| andreykurilin | I'll do it | 15:37 |
| *** sneti_ has joined #openstack-nova | 15:37 | |
| mriedem | it's morning and i've got a caffiene headache but ok | 15:38 |
| mriedem | *caffeine | 15:38 |
| bauzas | mriedem: you okay if I'm tagging a 7.1.0 with the help of andreykurilin ? | 15:38 |
| bauzas | once all the fixes are done of course | 15:38 |
| mriedem | bauzas: that's fine | 15:38 |
| mriedem | alex_xu: cdent: artom: gmann: where are we on the device tags thing? | 15:39 |
| bauzas | mriedem: client libraries freeze is thursday as well ? | 15:39 |
| mriedem | bauzas: yes client release freeze is thursday | 15:39 |
| bauzas | ok | 15:39 |
| cdent | mriedem: I don't know, haven't revisited since I lit the fire... | 15:40 |
| *** sneti_ has quit IRC | 15:40 | |
| mriedem | it's a time that i wish we could just fix the bugs in the api w/o the microversion | 15:40 |
| artom | mriedem, nowhere as far as I can tell - what's the plan? We document before ocata FF and unfuck it in Pike? | 15:40 |
| artom | If so I can submit the documentation patch | 15:41 |
| mriedem | (a) this version works, but (b) x-y don't work, except z, so (c) we'll fix it all in microversion 2.50 | 15:41 |
| artom | But I wasn't sure we had consensus on that | 15:41 |
| robcresswell | diana_clarke: Thanks for the response on the horizon discussion, that was useful | 15:41 |
| *** amotoki has quit IRC | 15:41 | |
| *** aojea has quit IRC | 15:41 | |
| mriedem | artom: if we're not going to fix it with a microversion in ocata we can document it probably whenever before ocata rc1 | 15:41 |
| *** marst has joined #openstack-nova | 15:42 | |
| artom | mriedem, do we have time to squeeze it in in 2 days? I can write the code... | 15:42 |
| artom | (The new microversion I mean) | 15:42 |
| mriedem | artom: we probably don't have the review bandwidth in 2 days | 15:42 |
| *** jose-phillips has joined #openstack-nova | 15:43 | |
| mriedem | alternatively we microversion it for a bug fix and it's not tied to FF since it's not a feature, it's a bug fix | 15:43 |
| diana_clarke | robcresswell: np, I know the whole approach is somewhat sub-optimal, but I'm not sure how else we could have proceeded. | 15:43 |
| mriedem | i thought we did that with the vm status microversion in newton | 15:43 |
| artom | mriedem, oh right, I forgot FF != halt all evarything | 15:43 |
| *** ekuris_ has quit IRC | 15:44 | |
| artom | mriedem, if I have your PTLness backing me on this, I can drive it as a microversion bugfix before ocata release | 15:44 |
| artom | ;) | 15:44 |
| cdent | I think bugfix sounds like the right approach | 15:44 |
| cdent | gives some time to do it right | 15:44 |
| *** nkrinner is now known as nkrinner_afk | 15:44 | |
| cdent | and it _is_ a bugfix | 15:44 |
| *** aojea has joined #openstack-nova | 15:45 | |
| robcresswell | diana_clarke: Yeah, understood | 15:45 |
| mriedem | especially this one https://review.openstack.org/#/c/304510/64/nova/api/openstack/compute/block_device_mapping.py i'd really like to just fix that w/o a microversion, | 15:45 |
| mriedem | but that probably goes against everything we've always said | 15:45 |
| *** sacharya has joined #openstack-nova | 15:46 | |
| *** ducttape_ has joined #openstack-nova | 15:46 | |
| artom | mriedem, I don't think we can. For all intents and purposes, there's no tag in >=2.33. And adding an API parameter is a new microversion... | 15:47 |
| mriedem | yes i know, but 2.33->2.43 or whatever with no bdm tag support, and then it's back in, is just super terrible UX | 15:48 |
| *** ociuhandu has quit IRC | 15:48 | |
| cdent | bauzas: are your placement changes in a good state to review now? | 15:48 |
| *** vladikr has joined #openstack-nova | 15:48 | |
| bauzas | cdent: it is indeed | 15:48 |
| cdent | on it | 15:48 |
| bauzas | cdent: I need to write a grenade change for fixing the related jobs but that shouldn't be impacting my WIP | 15:48 |
| artom | mriedem, I totally agree on that point... And to be fair, I can't think of any core that would stop working | 15:48 |
| *** burgerk has joined #openstack-nova | 15:49 | |
| bauzas | cdent: FWIW, there is now only one patch left, I abandoned the fixture one | 15:49 |
| cdent | k | 15:49 |
| artom | Tags were optional, so if you tried to use them in 2.33 it would break, but no one filed a but so no one noticed | 15:49 |
| artom | But if you weren't using them re-adding them as an optional parameter doesn't break anything | 15:49 |
| *** mvk has quit IRC | 15:49 | |
| artom | Hrmm, maybe we *can* just silently re-add them | 15:49 |
| artom | Same logic goes for networks | 15:49 |
| bauzas | dansmith: quick question on grenade, do you think it's a valid approach to just source the placement lib, and call out the appropriate functions, or try to modify local.conf to include placement? | 15:50 |
| mriedem | i doubt anyone noticed because (a) most clouds aren't at newton yet and/or (b) no one is using them, yeah | 15:50 |
| *** burgerk_ has joined #openstack-nova | 15:50 | |
| dansmith | bauzas: source and use existing functions | 15:50 |
| *** acabot_ has quit IRC | 15:50 | |
| mriedem | however, | 15:50 |
| bauzas | dansmith: that would mean local.conf wouldn't be accurate then | 15:50 |
| *** hieulq_ has joined #openstack-nova | 15:51 | |
| *** breitz has joined #openstack-nova | 15:51 | |
| mriedem | 2.1 and microversions is all about correcting mistakes, and in the old 2.0 API we always said we couldn't fix things regardless of the wart | 15:51 |
| bauzas | dansmith: if that's not a necessary requirement, I'm fine | 15:51 |
| mriedem | unless we used extensions or some garbage like that | 15:51 |
| dansmith | bauzas: oh, thought you meant nova.conf.. I still think that's okay and consistent, FWIW | 15:51 |
| bauzas | dansmith: the fact is that the grenade-upgrade local.conf wouldn't be valid in case the deployer wants to unstack/stack | 15:52 |
| mriedem | andreykurilin: ping me when your requirements change is up to change the minimum back to 6.0 and blacklist 7.0 | 15:52 |
| cdent | mriedem: sounds like you should join the thread about api compatbility/stability seeing as you have opinions ;)/2 | 15:52 |
| andreykurilin | mridem: it is here https://review.openstack.org/#/c/424705/ | 15:52 |
| mriedem | cdent: well i lean toward the microversion fix | 15:53 |
| mriedem | just because it's the "right thing to do" | 15:53 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | 15:53 |
| *** burgerk has quit IRC | 15:53 | |
| openstackgerrit | sahid proposed openstack/nova: numa: add numa constraints for emulator threads policy https://review.openstack.org/385023 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell https://review.openstack.org/400874 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: numa: fit instance topology with cpus reserved onto cores https://review.openstack.org/400875 | 15:54 |
| artom | mriedem, it *is* more transparent | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: virt: update overhead to take into account vCPUs https://review.openstack.org/385024 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: numa: take into account cpus reserved https://review.openstack.org/400876 | 15:54 |
| openstackgerrit | sahid proposed openstack/nova: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877 | 15:54 |
| artom | Yeah, anyone can dig through the git logs and review history, but putting it in the API version history is more accessible if folks start wondering wtf | 15:54 |
| lyarwood | mdbooth: https://review.openstack.org/399735 could use another review if you have time today | 15:55 |
| *** briancurtin has left #openstack-nova | 15:55 | |
| *** jdurgin1 has joined #openstack-nova | 15:56 | |
| *** amotoki has joined #openstack-nova | 15:57 | |
| mdbooth | lyarwood: Yep. It takes me almost 10 minutes to make a moka of coffee, I'll do it then :) | 15:57 |
| *** udesale has quit IRC | 15:58 | |
| *** mdrabe has quit IRC | 15:58 | |
| *** _ducttape_ has joined #openstack-nova | 15:59 | |
| mriedem | sfinucan: "While this doesn't cause any issues currently, it is a latent bug that has caused issues downstream." - in other words, it's currently causing issues :) | 16:02 |
| *** aojea has quit IRC | 16:02 | |
| sfinucan | mriedem: You got it :) | 16:02 |
| *** ducttape_ has quit IRC | 16:03 | |
| sfinucan | I meant "this doesn't cause issues with upstream-only code", of course | 16:03 |
| *** dillaman has joined #openstack-nova | 16:03 | |
| *** cdent_ has joined #openstack-nova | 16:04 | |
| *** cdent has quit IRC | 16:04 | |
| *** cdent_ is now known as cdent | 16:04 | |
| andreykurilin | mriedem: btw, are you ok about putting 7.1.0 to u-c ? | 16:05 |
| *** jose-phillips has quit IRC | 16:05 | |
| mriedem | sfinucan: is it blowing up another out of tree scheduler filter or something? | 16:05 |
| mriedem | sfinucan: or you're just not allowed to talk about it? | 16:05 |
| mriedem | andreykurilin: yes | 16:05 |
| andreykurilin | nice | 16:05 |
| *** amoralej|off has quit IRC | 16:06 | |
| *** ltomasbo has quit IRC | 16:06 | |
| mriedem | sfinucan: dansmith: ok +W | 16:06 |
| *** dmellado has quit IRC | 16:07 | |
| sfinucan | mriedem: Aye, we've a downstream only workaround to handle that long running "nova doesn't recalculate CPU topologies on live migration" bug | 16:07 |
| mriedem | thanks for not ramming that in all red hat cores | 16:07 |
| *** jpena has quit IRC | 16:07 | |
| andreykurilin | johnthetubaguy: your comment about transmitting --os-user-id in case of token auth made gates to fail :( it requires more changes in novaclient's code. will recent a fix soon | 16:07 |
| *** breitz has quit IRC | 16:07 | |
| *** sree has quit IRC | 16:07 | |
| *** breitz has joined #openstack-nova | 16:08 | |
| sfinucan | We check for CPU pinning info in the topology and compare it against the free host cores. The pinning info should only exist in a live migrate case, but that bug broke the assumption and broke scheduling :) | 16:08 |
| *** jerrygb has quit IRC | 16:08 | |
| *** mfeoktistov has quit IRC | 16:09 | |
| sfinucan | mriedem: Thanks for the review. I can go sleep now, heh | 16:09 |
| dansmith | yea, it's pretty nasty | 16:09 |
| *** cdent has quit IRC | 16:09 | |
| *** mat128|afk is now known as mat128 | 16:09 | |
| *** jerrygb has joined #openstack-nova | 16:09 | |
| *** cdent has joined #openstack-nova | 16:09 | |
| *** a-pugachev has quit IRC | 16:10 | |
| *** rmart04 has quit IRC | 16:11 | |
| *** _ducttape_ has quit IRC | 16:11 | |
| *** ducttape_ has joined #openstack-nova | 16:12 | |
| mdbooth | lyarwood: I've still got a -1 on its parent, right? | 16:13 |
| mdbooth | Or is it direct on master now? Gerrit doesn't make this clear. | 16:13 |
| mdbooth | At a glance, anyway. | 16:14 |
| lyarwood | mdbooth: yeah it really doesn't, it's direct on master now | 16:14 |
| mdbooth | k | 16:14 |
| lyarwood | mdbooth: there's an additional workaround in there so it can be btw | 16:15 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 16:15 |
| lyarwood | mdbooth: https://review.openstack.org/#/c/399735/18/nova/virt/libvirt/guest.py | 16:15 |
| *** aojea has joined #openstack-nova | 16:15 | |
| *** mlavalle has quit IRC | 16:16 | |
| mdbooth | lyarwood: How's your xpath-fu? | 16:16 |
| *** pcaruana has quit IRC | 16:16 | |
| * mdbooth wrote a *lot* of xpath in a previous life | 16:16 | |
| lyarwood | mdbooth: not great but that's a copy paste from the original | 16:16 |
| mdbooth | and xslt | 16:16 |
| mdbooth | You can do the source/target thing in a single query :) | 16:17 |
| mdbooth | I won't inflict that on anybody, though. | 16:17 |
| mdbooth | (Well, I probably would if I'd written it ;)) | 16:17 |
| *** a-pugachev has joined #openstack-nova | 16:17 | |
| lyarwood | even with a different attribute for both? | 16:17 |
| lyarwood | nice | 16:17 |
| mdbooth | Yeah | 16:18 |
| mriedem | dansmith: so what do you want me to look at for cells v2? | 16:18 |
| *** ijw has joined #openstack-nova | 16:18 | |
| dansmith | mriedem: this and the following: https://review.openstack.org/#/c/410473/13 | 16:18 |
| mriedem | keeping in mind i've got a 5 year old girl asking me when i'm going to take a shower so i can go swimming | 16:18 |
| dansmith | mriedem: I had to recheck the d-g patch, let me go check that again | 16:18 |
| mriedem | i just rechecked it | 16:19 |
| dansmith | okay it's +1 | 16:19 |
| dansmith | I emailed sdague about it yesterday but don't see that he looked at it | 16:19 |
| mriedem | on https://review.openstack.org/#/c/396775/ and the stable sort limitation, | 16:19 |
| dansmith | I'll poke clarkb | 16:19 |
| mriedem | are we going to just doc that in a reno? or will we just say in release notes that multiple cells aren't supported in ocata? | 16:20 |
| *** ociuhandu has joined #openstack-nova | 16:21 | |
| dansmith | mriedem: yeah, I've been kinda waiting to see how far I get, but a release note with the status of things was my plan | 16:21 |
| EmilienM | mriedem: hi! quick question, do we wait https://review.openstack.org/#/c/424256/ to release the next novaclient? | 16:22 |
| *** ijw has quit IRC | 16:23 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259 | 16:23 |
| sfinucan | dansmith: (Best effort) comments left on https://review.openstack.org/#/c/410473 | 16:24 |
| *** marst_ has joined #openstack-nova | 16:26 | |
| *** marst has quit IRC | 16:26 | |
| dansmith | sfinucan: thanks, I'll explain in there | 16:27 |
| sfinucan | (y) | 16:27 |
| *** edleafe- is now known as edleafe | 16:27 | |
| mriedem | EmilienM: yes, andrey has a patch up in reqs repo to blacklist 7.0 | 16:27 |
| *** bvanhav has quit IRC | 16:28 | |
| *** bvanhav_ has joined #openstack-nova | 16:28 | |
| *** _ducttape_ has joined #openstack-nova | 16:28 | |
| EmilienM | mriedem: ok, thank you ! | 16:28 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 16:29 |
| *** baoli has quit IRC | 16:29 | |
| *** annegentle has joined #openstack-nova | 16:29 | |
| *** tbachman has quit IRC | 16:30 | |
| *** mdrabe has joined #openstack-nova | 16:30 | |
| dansmith | sfinucan: I tried to re-state the commit message.. let me know if that makes any more sense and if you think I should tweak what I have in some way | 16:30 |
| dansmith | sfinucan: it is a pretty complicated problem that took a long time to figure out, although the actual change is rather small | 16:30 |
| sfinucan | dansmith: Cheers. Will do | 16:31 |
| *** ducttape_ has quit IRC | 16:31 | |
| mriedem | dansmith: i'll start keeping a tally of things we need to reno in the cells v2 wiki | 16:32 |
| dansmith | mriedem: okay | 16:33 |
| dansmith | mriedem: I could also just start a reno patch that we can keep augmenting for a while | 16:33 |
| mriedem | that works too | 16:33 |
| dansmith | lemme do that while I'm waiting | 16:33 |
| andreykurilin | mriedem: About your reply to "Device tag in the API breaks in the old microversion". If the fix should be done via new microversion, should we wait a bit for adding it to new novaclient's release ? | 16:33 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | 16:34 |
| mriedem | andreykurilin: we're going to have to bug fix it in novaclient | 16:34 |
| mriedem | andreykurilin: e.g. --nic tag won't work in 2.37+ | 16:34 |
| melwitt | dansmith: this block is still commented out. I don't quite understand the comment, does it need to be moved to the conductor tests or? https://review.openstack.org/#/c/319379/72/nova/tests/unit/compute/test_compute.py@7937 | 16:34 |
| mriedem | so the client will probably need to handle that | 16:34 |
| dansmith | melwitt: I moved it | 16:34 |
| dansmith | oh, did I forgetto remove? | 16:35 |
| *** hamzy has quit IRC | 16:35 | |
| andreykurilin | mriedem: sure, but should we wait for that bug fix to release it with 7.1.0 ? | 16:35 |
| dansmith | melwitt: https://review.openstack.org/#/c/319379/72/nova/tests/unit/conductor/test_conductor.py | 16:35 |
| dansmith | I forgot to remove, sorry | 16:35 |
| mriedem | andreykurilin: i don't think we'll probably have time, unless someone fixes it today | 16:35 |
| melwitt | dansmith: okay, I see | 16:35 |
| andreykurilin | mriedem: nobody can do it until fix is not merged in nova's at first :) | 16:36 |
| mriedem | alex_xu: cdent: Kevin_Zheng: do we have a bug to track the device tags issue? | 16:36 |
| *** tovin07_ has quit IRC | 16:36 | |
| mriedem | andreykurilin: we already have a bug in novaclient | 16:36 |
| dansmith | melwitt: thanks for catching those, I'm blind to this at this point | 16:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719 | 16:36 |
| mriedem | andreykurilin: i.e. if you try to create a server with the latest microversion and specify bdm or nic tags, it won't work | 16:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 16:36 |
| mriedem | andreykurilin: i'm guessing you'd get a 400 for the schema validation error | 16:37 |
| cdent | mriedem: https://bugs.launchpad.net/nova/+bug/1658571 ? | 16:37 |
| openstack | Launchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu) | 16:37 |
| cdent | or do we need an additional one | 16:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port https://review.openstack.org/424639 | 16:37 |
| mriedem | cdent: looks right | 16:37 |
| mriedem | we'll use one | 16:37 |
| mriedem | added novaclient to it | 16:38 |
| *** tbachman has joined #openstack-nova | 16:38 | |
| cdent | ✔ | 16:38 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | 16:39 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 16:39 |
| *** ociuhandu has quit IRC | 16:40 | |
| andreykurilin | mriedem:as far as I understand nothing special should be done at novaclient's side | 16:40 |
| andreykurilin | mriedem: just bumping max version | 16:40 |
| andreykurilin | since it is just validation step at API side | 16:40 |
| mriedem | andreykurilin: at a minimum, the help text on the nova boot command will need to be updated | 16:40 |
| mriedem | to say that bdm tags only work with 2.32, and nic tags only work with 2.32->2.36 | 16:41 |
| mriedem | otherwise someone will be wondering why they can't create a server with device tags and microversion 2.40, for example | 16:41 |
| andreykurilin | mriedem: can we reserve next microversion for that bug-fix, so it will be possible to release novaclient with support of that microversion today and than merge patch to API side? | 16:42 |
| *** tbachman_ has joined #openstack-nova | 16:42 | |
| melwitt | dansmith: I pointed out on PS71 but didn't notice it's still there (sorry). did you want this logging here? https://review.openstack.org/#/c/319379/73/nova/compute/api.py@2517 | 16:42 |
| andreykurilin | *next microversion number | 16:42 |
| mriedem | andreykurilin: i'd rather not try to reserve a microversion | 16:42 |
| *** _ducttape_ has quit IRC | 16:42 | |
| mriedem | andreykurilin: since there are some patches still up for review for nova before FF that bump microversions | 16:42 |
| *** tbachman has quit IRC | 16:42 | |
| *** tbachman_ is now known as tbachman | 16:42 | |
| dansmith | melwitt: yeah I was going to keep that and the related ones as it helped me debug and only runs once | 16:43 |
| melwitt | okay, cool | 16:43 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: neutron: re-raise 401 for a non-admin client https://review.openstack.org/422696 | 16:43 |
| andreykurilin | mriedem: but it sounds like only possible solution to release novaclient with fixed bug | 16:43 |
| mdbooth | lyarwood: Have the test changes in that patch gotten mixed up with one of the other patches? | 16:44 |
| mriedem | andreykurilin: it's already broken in older versions of novaclient, | 16:44 |
| mdbooth | lyarwood: https://review.openstack.org/#/c/399735/18/nova/tests/unit/virt/libvirt/test_driver.py | 16:44 |
| mriedem | andreykurilin: so i'm less worried about rushing a fix in on the client side for a new microversion, | 16:44 |
| mriedem | andreykurilin: i think it's good to just get a change into novaclient for ocata that updates the help to note the limitation on usage | 16:44 |
| mriedem | andreykurilin: we can get the novaclient fix with the new microversion released in pike | 16:44 |
| *** gszasz has joined #openstack-nova | 16:45 | |
| *** jpena_ has joined #openstack-nova | 16:45 | |
| *** sridharg has quit IRC | 16:45 | |
| *** andreas_s has quit IRC | 16:46 | |
| *** jpena_ is now known as jpena | 16:46 | |
| *** luis5tb has joined #openstack-nova | 16:46 | |
| lyarwood | mdbooth: I don't think so, it was easier to rewrite some of the snapshot tests in mock that have increased the size if that's an issue | 16:47 |
| mdbooth | lyarwood: Couldn't really see what was changing, tbh. | 16:47 |
| *** dmellado has joined #openstack-nova | 16:48 | |
| *** luis5tb is now known as ltomasbo | 16:48 | |
| mdbooth | However, if it's just my lack of understanding... | 16:48 |
| mdbooth | lyarwood: Personally I'd have called that out in the commit message, or ideally do the test rewriting in the patch before. | 16:48 |
| lyarwood | mdbooth: so we shouldn't really change anything aside from mocking out the additional XMLDesc calls | 16:48 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Clarify description for tags https://review.openstack.org/424745 | 16:49 |
| andreykurilin | mriedem: do you mean something like this - https://review.openstack.org/424745 ? | 16:49 |
| mdbooth | It's just a surprising amount of churn. If it's necessary then ok, I'll just look harder. | 16:49 |
| lyarwood | mdbooth: yeah, maybe I'm missing a smaller change we can make to the original mox tests tbh | 16:50 |
| lyarwood | mdbooth: and if I am please feel free to call it out and I'll go over this again | 16:50 |
| *** a-pugachev has quit IRC | 16:50 | |
| *** stewie925_ has joined #openstack-nova | 16:50 | |
| mdbooth | lyarwood: I'll keep looking. I thought you'd just made a mistake so I didn't look all that hard. | 16:51 |
| *** stewie925_ is now known as stewie925 | 16:51 | |
| *** ltomasbo has quit IRC | 16:53 | |
| *** jpena has quit IRC | 16:53 | |
| *** dmellado has quit IRC | 16:53 | |
| *** tbachman has quit IRC | 16:53 | |
| sfinucan | vladikr: I don't know why mriedem removed his -2 on this https://review.openstack.org/#/c/405951 - doesn't it still require a version bump? | 16:53 |
| vladikr | sfinucan, looking | 16:54 |
| sfinucan | Actually, wait - you did bump the version. nvm :) What about a reno? | 16:54 |
| mriedem | sfinucan: i had a -2 on it when the series was much longer and i wanted to make sure the tempest testing was done and testing that API change first | 16:54 |
| *** mlavalle has joined #openstack-nova | 16:55 | |
| *** browne has joined #openstack-nova | 16:55 | |
| mriedem | vladikr: you should link to the tempest change in the commit message | 16:55 |
| *** sdague has joined #openstack-nova | 16:55 | |
| sfinucan | mriedem: Gotcha | 16:55 |
| sfinucan | mriedem: Also, aren't you supposed to be drinking cocktails on a beach somewhere? :) | 16:55 |
| *** sudipto has joined #openstack-nova | 16:55 | |
| *** sudipto_ has joined #openstack-nova | 16:56 | |
| vladikr | mriedem, ok, got it. so I need a new tempest test written for this right? | 16:56 |
| mriedem | vladikr: i thought you already had one started | 16:56 |
| vladikr | mriedem, no, but will do now | 16:56 |
| vladikr | sfinucan, do I need a reno for that change? I thought we wanted to update the user guide | 16:57 |
| *** owalsh is now known as owalsh-afk | 16:57 | |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder https://review.openstack.org/366724 | 16:57 |
| mriedem | i'd have a feature reno for it and the metadata API version change | 16:57 |
| sfinucan | vladikr: if it introduces a new, user-visible change then I would assume so? | 16:58 |
| *** lucasagomes is now known as lucas-afk | 16:58 | |
| vladikr | sfinucan, mriedem, will add now | 16:58 |
| *** nic has joined #openstack-nova | 16:58 | |
| sfinucan | (y) | 16:59 |
| *** ltomasbo has joined #openstack-nova | 16:59 | |
| johnthetubaguy | melwitt: I had a sudden memory of how the flavor stuff avoid duplicates earlier, I added a comment on that quota patch | 16:59 |
| *** annegentle has quit IRC | 16:59 | |
| *** dmellado has joined #openstack-nova | 16:59 | |
| melwitt | johnthetubaguy: I saw and replied. thanks :) I will go that route. working through all of the changes on the series now | 17:00 |
| johnthetubaguy | melwitt: cool | 17:00 |
| *** jpena|off has joined #openstack-nova | 17:01 | |
| *** moshele has quit IRC | 17:01 | |
| *** jaypipes_ has joined #openstack-nova | 17:01 | |
| mriedem | vladikr: will this change work for config drive too? | 17:01 |
| *** sudipto has quit IRC | 17:01 | |
| *** sudipto_ has quit IRC | 17:01 | |
| *** tbachman has joined #openstack-nova | 17:01 | |
| *** a-pugachev has joined #openstack-nova | 17:01 | |
| *** claudiub has joined #openstack-nova | 17:02 | |
| vladikr | mriedem, yes, sure | 17:02 |
| *** annegentle has joined #openstack-nova | 17:02 | |
| mriedem | vladikr: i'm not so sure, because that's done separately in the libvirt driver https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L3180 | 17:03 |
| vladikr | mriedem, config drive uses InstanceMetadata to build | 17:03 |
| mriedem | yes i know, | 17:03 |
| vladikr | looking | 17:03 |
| mriedem | but what you're changing in the metadata is the route from an API request to get the metadata | 17:03 |
| *** sudipto has joined #openstack-nova | 17:04 | |
| mriedem | artom: have you noticed that we build the device metadata for an instance (which hits the db) even if we don't build the config drive? https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L3180 | 17:04 |
| *** sudipto_ has joined #openstack-nova | 17:04 | |
| *** claudiub|2 has quit IRC | 17:04 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py https://review.openstack.org/399036 | 17:05 |
| dansmith | johnthetubaguy: see if those explanations make sense | 17:05 |
| *** jpena|off is now known as jpena | 17:05 | |
| dansmith | johnthetubaguy: sorry for saying this was simple. I've factored out all the complexity of "why" in my head I guess :) | 17:05 |
| johnthetubaguy | dansmith: will take a peak, was just looking at next one | 17:05 |
| *** bkopilov has quit IRC | 17:05 | |
| johnthetubaguy | dansmith: heh, no worries | 17:05 |
| johnthetubaguy | dansmith: in that follow up, I saw a comment about 404 if nova-api service minimum version < 15, can't we avoid that? | 17:06 |
| dansmith | johnthetubaguy: let me refresh my memory but I don't think we can | 17:07 |
| mriedem | vladikr: ok i see how InstanceMetadata.metadata_for_config_drive is called from the config drive builder in the virt driver, | 17:07 |
| mriedem | so it should work, | 17:07 |
| mriedem | but i'm wondering why we have the explicit _build_device_metadata stuff in the libvirt driver then for device tags? | 17:07 |
| dansmith | johnthetubaguy: oh that's in a piece that is already merged right? | 17:08 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Clarify description for tags https://review.openstack.org/424745 | 17:08 |
| artom | mriedem, we need it for the metadata API, but I agree that it's a weird place to put it | 17:08 |
| dansmith | johnthetubaguy: actually, I'm not sure which of the version<15 checks you're talking about.. linky? | 17:09 |
| melwitt | dansmith: I think he means this https://review.openstack.org/#/c/319379/73/nova/tests/functional/integrated_helpers.py@226 | 17:09 |
| *** markmcclain has quit IRC | 17:09 | |
| johnthetubaguy | dansmith: yeah, https://review.openstack.org/#/c/319379/73/nova/tests/functional/integrated_helpers.py@228 | 17:10 |
| melwitt | that is, immediately after requesting a boot you could assume the instance exists before. but with the move to conductor, you can't | 17:10 |
| mriedem | artom: vladikr: oh i see, so we build the device metadata in the virt driver and store that on instance.device_metadata, which the metadata API uses to build the md json for the config drive | 17:10 |
| *** ducttape_ has joined #openstack-nova | 17:10 | |
| johnthetubaguy | I thought we would return it in the API list, because the uuid would be in the cell mapping table to avoid that | 17:10 |
| dansmith | ohg that | 17:10 |
| melwitt | yeah, I mean wouldn't we have the build request to create the instance from with the new stuff? | 17:10 |
| artom | mriedem, we have to build the device metadatain (or at least from) the virt driver because only it knows the hardware metadata like devices addresses | 17:11 |
| *** markmcclain has joined #openstack-nova | 17:11 | |
| artom | mriedem, but I don't think the metadata API builds anything for the config drive... | 17:11 |
| vladikr | artom is typing much faster :) | 17:11 |
| dansmith | johnthetubaguy: melwitt good question, that might've been an early attempt by avolkov to address the sync spawn thing, lemme check | 17:11 |
| artom | When the config drive builds itself (for lack of a better work) it gets the instance metadata on its own | 17:11 |
| *** cdelatte has quit IRC | 17:11 | |
| artom | vladikr, jinx ;) | 17:11 |
| *** dave-mccowan has quit IRC | 17:11 | |
| melwitt | dansmith: yeah, I would think we don't need that change because we should be getting the same behavior as before via build request | 17:12 |
| mriedem | artom: well it's used here v | 17:12 |
| mriedem | https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/configdrive.py#L69 | 17:12 |
| dansmith | melwitt: yeah, I dunno, I'll try removing it | 17:12 |
| mriedem | and i suppose we persist instance.device_metadata later in the compute manager when it calls instance.save() | 17:12 |
| mriedem | so that later metadata API requests (when not using config drive) can retrieve the device tags | 17:13 |
| dansmith | johnthetubaguy: I would think that if it's really an api thing we'd be failing tempest | 17:13 |
| johnthetubaguy | dansmith: yeah, +1 | 17:13 |
| *** sudipto_ has quit IRC | 17:14 | |
| *** sudipto has quit IRC | 17:14 | |
| artom | mriedem, ah, didn't know about metadata_for_configdrive | 17:14 |
| artom | Then yeah, the metadata service (not API surely?) builds the metadata for the config drive | 17:14 |
| sfinucan | vladikr, sahid: Could ye take a look at https://review.openstack.org/#/c/370374 at some point? I think it looks good but I'd like more opinions and moshele is offline | 17:14 |
| artom | mriedem, the instance.save() part is I think just lucky, because when coding the tagged attached stuff I don't recall ever seeing it in the existing code | 17:15 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix races in glusterfs mount/umount https://review.openstack.org/423402 | 17:15 |
| artom | For attach I have to call it explicitly | 17:15 |
| vladikr | sfinucan, sure | 17:15 |
| dansmith | johnthetubaguy: sfinucan: so for that flag set in the api_samples patch, all I can think of as a comment to help is: | 17:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname https://review.openstack.org/396130 | 17:15 |
| dansmith | johnthetubaguy: sfinucan: "Default our global database connection info to be the first cell for any non-cells-aware code" | 17:15 |
| mriedem | artom: yeah after driver.spawn(), the compute manager changes the state to ACTIVE on the instance and calls instance.save() | 17:15 |
| gibi | mriedem: I think I have solution for the randomly failing notification sample functional test https://review.openstack.org/#/c/424574/ | 17:15 |
| dansmith | johnthetubaguy: sfinucan: would that help? | 17:15 |
| mriedem | so anything the virt driver changed on the instance during spawn is going to get persisted with that | 17:15 |
| sfinucan | vladikr: Cheers. No panic, mind - VLAN stuff take priority | 17:16 |
| johnthetubaguy | dansmith: that would work for me I think | 17:16 |
| dansmith | johnthetubaguy: ack | 17:16 |
| *** sahid has quit IRC | 17:16 | |
| artom | mriedem, cool - not sure if that was intentional on our part to not call save() from the virt drive to save on DB requests, but glad that it works :D | 17:16 |
| * dansmith notes he started toast toasting an hour ago | 17:17 | |
| artom | (toast)^2ing | 17:18 |
| *** ducttape_ has quit IRC | 17:20 | |
| mdbooth | sfinucan: ^^^ TODO'd btw | 17:22 |
| * sfinucan looks | 17:22 | |
| mdbooth | dansmith: I was trying to reference something the other day which says that reboot() has a secondary function of 'try to fix all the hypervisor things'. | 17:23 |
| mdbooth | Are you aware of anything? | 17:23 |
| dansmith | mdbooth: um, what? | 17:24 |
| mdbooth | dansmith: I'm guessing that a no ;) | 17:24 |
| dansmith | heh | 17:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test https://review.openstack.org/424574 | 17:24 |
| mdbooth | So, when you reboot an instance we rewrite the domain xml and recreate backing files which should already exist. | 17:24 |
| mdbooth | cburgess: ^^^ | 17:24 |
| mdbooth | Anyway, this is very messy and sahid proposed a patch to remove it. However, if this is operator-expected behaviour then we can't do that without replacement. | 17:25 |
| *** dtp has joined #openstack-nova | 17:25 | |
| gibi | mriedem: thanks for the quick review. I've fixed your comments | 17:26 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37 https://review.openstack.org/424759 | 17:31 |
| * artom WIPs up some fixes to the tag disappearing and continues with the functional tests | 17:31 | |
| dansmith | johnthetubaguy: melwitt: confirmed, that integrated helpers hack isn't needed | 17:33 |
| melwitt | cool, good catch johnthetubaguy | 17:33 |
| johnthetubaguy | it was jst that comment that made my eyes pop out a little | 17:33 |
| melwitt | heh | 17:34 |
| johnthetubaguy | dansmith: I am missing why we need to call _validate_bdm twice in there, are there more accurate instance details the second time around? | 17:34 |
| *** baoli has joined #openstack-nova | 17:35 | |
| sfinucan | mdbooth: and +2'd | 17:35 |
| *** mjura has quit IRC | 17:35 | |
| johnthetubaguy | dansmith: thinking about: https://review.openstack.org/#/c/319379/73/nova/compute/api.py@1227 | 17:35 |
| dansmith | johnthetubaguy: see the comments in there. we previously figured out that we do need to do that, but we don't remember why. so I've stacked a patch on the end we can experiment with | 17:35 |
| melwitt | johnthetubaguy: I pointed that out too, and I remember dansmith, mriedem and I all dug into once on a different review. but I can't remember what review it was so we can look at it | 17:35 |
| johnthetubaguy | dansmith: melwitt: ah, gotcha, sorry, didn't check the history around that bit | 17:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 17:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719 | 17:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | 17:36 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 17:36 |
| dansmith | johnthetubaguy: np, good eye :) | 17:36 |
| mriedem | wasn't it the object copy thing? | 17:36 |
| dansmith | melwitt: johnthetubaguy: comment added on the first, and that hack removed from the second ^ | 17:36 |
| melwitt | mriedem to the rescue | 17:37 |
| mriedem | it was avolkov's patch | 17:37 |
| *** tjones has joined #openstack-nova | 17:37 | |
| dansmith | mriedem: yeah, but we must have discussed on irc | 17:37 |
| mriedem | i thought we had captured the conversation in the review too | 17:38 |
| *** amotoki has quit IRC | 17:38 | |
| mriedem | i don't remember the context on the object copy thing now either | 17:38 |
| *** cdelatte has joined #openstack-nova | 17:38 | |
| johnthetubaguy | its odd how we update the BDM, after the initial validate, duno if thats related: https://github.com/openstack/nova/blob/065cd6a8d69c1ec862e5b402a3150131f35b2420/nova/compute/api.py#L1302 | 17:39 |
| melwitt | I thought we discussed on the review too | 17:39 |
| mriedem | https://review.openstack.org/#/c/374267/ is the patch i'm thinking of fwiw | 17:40 |
| melwitt | yep that's the one | 17:40 |
| melwitt | let's see if we recorded the detail of what's going on there | 17:40 |
| *** cdent has quit IRC | 17:41 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 17:41 |
| mriedem | https://review.openstack.org/#/c/374267/21/nova/compute/api.py@1197 | 17:41 |
| *** belmoreira has quit IRC | 17:42 | |
| *** ducttape_ has joined #openstack-nova | 17:43 | |
| melwitt | nice | 17:43 |
| *** derekh has quit IRC | 17:44 | |
| *** claudiub|2 has joined #openstack-nova | 17:44 | |
| *** mvk has joined #openstack-nova | 17:44 | |
| *** d34dh0r53 is now known as ID-Ten-T | 17:45 | |
| sfinucan | dansmith: Yeah, that comment WFM too. Re-reviewing now | 17:46 |
| dansmith | sfinucan: cool | 17:46 |
| *** claudiub has quit IRC | 17:46 | |
| *** hieulq_ has quit IRC | 17:46 | |
| paw | Hi, how do you specify a microversion for nova/api? I'm trying to test some interoperability issue. Thanks. | 17:47 |
| *** ID-Ten-T is now known as blarnath | 17:48 | |
| *** annegentle has quit IRC | 17:48 | |
| *** ijw has joined #openstack-nova | 17:48 | |
| *** ijw has quit IRC | 17:48 | |
| *** blarnath is now known as d34dh0r53 | 17:48 | |
| artom | paw, in the client? --os-compute-api-version=2.40 | 17:49 |
| *** ijw has joined #openstack-nova | 17:49 | |
| paw | as in the python-novaclient? | 17:49 |
| *** dave-mccowan has joined #openstack-nova | 17:50 | |
| paw | aries: confirmed. thanks | 17:50 |
| artom | paw, that option I gave is for the client, yes - both novaclient and openstackclient accept I think | 17:50 |
| paw | artom: thanks | 17:51 |
| artom | paw, you're welcome :) | 17:51 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 17:52 |
| dansmith | johnthetubaguy: gdi. | 17:52 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719 | 17:52 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | 17:52 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 17:52 |
| *** Sukhdev has joined #openstack-nova | 17:52 | |
| dansmith | johnthetubaguy: I don't know what to do in a world where _you_ are finding _my_ typos :P | 17:52 |
| *** tblakes has quit IRC | 17:55 | |
| johnthetubaguy | dansmith: its a very crazy day! | 17:55 |
| dansmith | heh | 17:55 |
| cburgess | mdbooth Yes correct. An in general do anything we can to make sure the VM comes up. | 17:56 |
| cburgess | mdbooth Think of it as a check list of what can we do to attempt to fix *anything* that might be wrong. | 17:56 |
| *** karimb has quit IRC | 17:56 | |
| *** jose-phillips has joined #openstack-nova | 17:56 | |
| melwitt | from what I can tell, I don't see why we would need the second _validate_bdm call. it doesn't seem to do anything except check things | 17:57 |
| *** a-pugachev has quit IRC | 17:57 | |
| melwitt | in that other patch where we discussed the double validation, it was more than that, it was two calls of the self._bdm_validate_set_size_and_instance function, which does more | 17:58 |
| *** nvela has joined #openstack-nova | 17:58 | |
| dansmith | melwitt: well, lets see if we get a full run of the wip patch | 18:00 |
| * melwitt nods | 18:00 | |
| mriedem | well i'm going to call it a morning and head out for awhile, i'm already in trouble | 18:01 |
| melwitt | o/ | 18:01 |
| *** ralonsoh has quit IRC | 18:02 | |
| dansmith | mriedem: thanks | 18:02 |
| *** krtaylor has quit IRC | 18:02 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 18:02 |
| *** Apoorva has joined #openstack-nova | 18:03 | |
| *** ijw has quit IRC | 18:04 | |
| *** amotoki has joined #openstack-nova | 18:04 | |
| *** ijw has joined #openstack-nova | 18:05 | |
| *** ijw has quit IRC | 18:05 | |
| openstackgerrit | Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634 | 18:05 |
| *** ijw has joined #openstack-nova | 18:05 | |
| *** amotoki has quit IRC | 18:06 | |
| *** bvanhav__ has joined #openstack-nova | 18:07 | |
| *** bvanhav_ has quit IRC | 18:07 | |
| *** tblakes has joined #openstack-nova | 18:09 | |
| *** Swami has joined #openstack-nova | 18:10 | |
| *** bkopilov has joined #openstack-nova | 18:12 | |
| *** annegentle has joined #openstack-nova | 18:13 | |
| *** rfolco has quit IRC | 18:14 | |
| *** mfeoktistov has joined #openstack-nova | 18:14 | |
| *** cdent has joined #openstack-nova | 18:15 | |
| *** markus_z has quit IRC | 18:16 | |
| *** sean-k-mooney has quit IRC | 18:16 | |
| *** sean-k-mooney has joined #openstack-nova | 18:17 | |
| *** efoley_ has quit IRC | 18:17 | |
| *** annegentle has quit IRC | 18:18 | |
| *** aarefiev is now known as aarefiev_afk | 18:18 | |
| *** chyka has joined #openstack-nova | 18:20 | |
| *** ducttape_ has quit IRC | 18:21 | |
| *** ducttape_ has joined #openstack-nova | 18:21 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment https://review.openstack.org/415622 | 18:22 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | 18:22 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment https://review.openstack.org/391941 | 18:22 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: API support for tagged device attachment https://review.openstack.org/376021 | 18:22 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | 18:22 |
| *** sambetts is now known as sambetts|afk | 18:22 | |
| *** hfu has joined #openstack-nova | 18:24 | |
| *** ducttape_ has quit IRC | 18:26 | |
| *** hamzy has joined #openstack-nova | 18:27 | |
| *** rfolco has joined #openstack-nova | 18:28 | |
| openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_confirm notification https://review.openstack.org/390654 | 18:28 |
| *** mriedem has quit IRC | 18:29 | |
| openstackgerrit | Gábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py https://review.openstack.org/399036 | 18:29 |
| *** dave-mccowan has quit IRC | 18:30 | |
| *** pbandark has quit IRC | 18:30 | |
| *** sdague has quit IRC | 18:33 | |
| *** jwcroppe_ has joined #openstack-nova | 18:34 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37 https://review.openstack.org/424759 | 18:36 |
| *** jwcroppe has quit IRC | 18:37 | |
| *** jwcroppe_ has quit IRC | 18:38 | |
| *** tesseract has quit IRC | 18:39 | |
| *** Sukhdev has quit IRC | 18:43 | |
| *** krtaylor has joined #openstack-nova | 18:44 | |
| *** hfu has quit IRC | 18:44 | |
| *** bvanhav__ has quit IRC | 18:45 | |
| *** jpena is now known as jpena|off | 18:46 | |
| *** hfu has joined #openstack-nova | 18:46 | |
| *** moshele has joined #openstack-nova | 18:46 | |
| *** hfu has quit IRC | 18:46 | |
| *** Sukhdev has joined #openstack-nova | 18:47 | |
| *** adisky_ has quit IRC | 18:49 | |
| *** moshele has quit IRC | 18:50 | |
| *** bvanhav__ has joined #openstack-nova | 18:50 | |
| *** yamahata has joined #openstack-nova | 18:53 | |
| *** kfarr has quit IRC | 18:55 | |
| *** sdague has joined #openstack-nova | 18:55 | |
| *** dave-mccowan has joined #openstack-nova | 18:57 | |
| *** swamireddy has quit IRC | 18:58 | |
| *** Sukhdev has quit IRC | 19:01 | |
| *** slaweq has quit IRC | 19:04 | |
| *** slaweq has joined #openstack-nova | 19:06 | |
| *** belmoreira has joined #openstack-nova | 19:07 | |
| *** belmoreira has quit IRC | 19:07 | |
| *** ducttape_ has joined #openstack-nova | 19:11 | |
| *** karts has joined #openstack-nova | 19:12 | |
| *** karthiks has quit IRC | 19:15 | |
| *** ducttape_ has quit IRC | 19:15 | |
| *** lpetrut has quit IRC | 19:16 | |
| cdent | bauzas: in your (not so) copious free time, you might find this bug fix to the resource tracker interesting: https://review.openstack.org/#/c/424305/ | 19:17 |
| *** sdague has quit IRC | 19:18 | |
| *** alexpilotti has quit IRC | 19:18 | |
| *** alexpilotti has joined #openstack-nova | 19:19 | |
| *** Oku_OS is now known as Oku_OS-away | 19:20 | |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 19:20 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 19:20 |
| *** alexpilo_ has joined #openstack-nova | 19:22 | |
| *** eharney has quit IRC | 19:22 | |
| dansmith | melwitt: johnthetubaguy: okay I think I can just nuke the extra validate, so I did ^ | 19:22 |
| *** alexpilotti has quit IRC | 19:23 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: experiment https://review.openstack.org/424809 | 19:24 |
| *** ducttape_ has joined #openstack-nova | 19:26 | |
| *** alexpilo_ has quit IRC | 19:27 | |
| *** owalsh-afk has quit IRC | 19:27 | |
| *** ijw has quit IRC | 19:28 | |
| *** owalsh-afk has joined #openstack-nova | 19:30 | |
| *** sdague has joined #openstack-nova | 19:31 | |
| *** jdurgin1 has quit IRC | 19:33 | |
| artom | Well crap, how does a vif in network_info end up with a vlan? I'm working on the tempest test for https://review.openstack.org/#/c/405951/ and the only way I've found to set a vlan on a Neutron network is to use provider:segmentation_id, but that required provider:network_type to be vxlan and for me to be an admin | 19:34 |
| *** sdague has quit IRC | 19:36 | |
| *** eharney has joined #openstack-nova | 19:37 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell https://review.openstack.org/400874 | 19:38 |
| *** smatzek has quit IRC | 19:40 | |
| *** tbachman has quit IRC | 19:40 | |
| *** harlowja has joined #openstack-nova | 19:41 | |
| dansmith | johnthetubaguy I think this is good to go now: https://review.openstack.org/#/c/410473/ | 19:42 |
| *** Sukhdev has joined #openstack-nova | 19:49 | |
| *** ijw has joined #openstack-nova | 19:49 | |
| *** ijw has quit IRC | 19:54 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951 | 19:54 |
| openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_revert notification https://review.openstack.org/396811 | 19:55 |
| *** flaper87 has joined #openstack-nova | 19:59 | |
| *** rfolco has quit IRC | 20:00 | |
| bauzas | dansmith: cdent: I could probably need some help for my grenade change | 20:02 |
| bauzas | http://logs.openstack.org/30/424730/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/15ad17c/logs/grenade.sh.txt.gz#_2017-01-24_17_11_42_862 | 20:02 |
| * cdent looks | 20:03 | |
| *** armax_ is now known as armax | 20:03 | |
| *** alexpilotti has joined #openstack-nova | 20:03 | |
| bauzas | cdent: we need to deploy the placement engine by grenade | 20:03 |
| bauzas | given the newton devstack doesn't deploy yet the placement service | 20:04 |
| dansmith | bauzas: you're not sourcing something that brings in the base variable I imagine | 20:05 |
| cdent | $FILES is not defined, looks like it is usually defined by stack.sh | 20:05 |
| bauzas | mmm ok | 20:05 |
| * bauzas looking where FILES is provided | 20:06 | |
| dansmith | looks like in stack.sh | 20:06 |
| dansmith | so define it in there before you call those methods | 20:06 |
| dansmith | $TOP_DIR/files | 20:06 |
| cdent | bauzas: see upgrade-tempest for an example | 20:08 |
| cdent | bauzas: and/or projects/30_swift/upgrade.sh | 20:08 |
| bauzas | cdent: roger | 20:08 |
| cdent | looks like those use $TARGET_DEVSTACK_DIR/files | 20:09 |
| bauzas | dansmith: I guess I can deploy grenade on my local devstack for testing ? | 20:11 |
| dansmith | if you're really really lucky :) | 20:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 20:11 |
| bauzas | dansmith: you mean it's difficult? | 20:12 |
| dansmith | bauzas: I mean I often have issues | 20:13 |
| cdent | bauzas: I agree with dansmith: I often have issues, and in addition it takes forever to reach those issues, at which point you throw your hands up in the air | 20:14 |
| dansmith | yeah | 20:14 |
| bauzas | okay, so let's hit the gate... | 20:14 |
| *** smatzek has joined #openstack-nova | 20:15 | |
| *** slaweq has quit IRC | 20:17 | |
| *** moshele has joined #openstack-nova | 20:18 | |
| *** lennyb has quit IRC | 20:18 | |
| *** slaweq has joined #openstack-nova | 20:19 | |
| *** sdague has joined #openstack-nova | 20:20 | |
| *** READ10 has quit IRC | 20:21 | |
| *** karimb has joined #openstack-nova | 20:25 | |
| *** sdague has quit IRC | 20:26 | |
| *** vsaienko has joined #openstack-nova | 20:28 | |
| *** tbachman has joined #openstack-nova | 20:31 | |
| *** aojea has quit IRC | 20:31 | |
| *** xyang1 has joined #openstack-nova | 20:36 | |
| amrith | andreykurilin, the patch to requirements repo has come down to trove via the req bot. I've dep'ed your change on that. Hope that's what you intended. | 20:37 |
| *** slaweq has quit IRC | 20:39 | |
| *** sdague has joined #openstack-nova | 20:40 | |
| *** slaweq has joined #openstack-nova | 20:41 | |
| *** oanson has quit IRC | 20:41 | |
| andreykurilin | amrith: everything should work now in trove | 20:42 |
| andreykurilin | without my patch | 20:42 |
| *** oanson has joined #openstack-nova | 20:42 | |
| *** aojea has joined #openstack-nova | 20:44 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | 20:45 |
| amrith | andreykurilin, cool. in that case I'm going to announce my retirement and move to a beach somewhere where it is warm. | 20:45 |
| amrith | :) | 20:46 |
| andreykurilin | heh | 20:46 |
| amrith | thanks andreykurilin I very much appreciate your help with this set of changes. | 20:46 |
| andreykurilin | amrith: I'll return to them with new novaclient 7.1.0 :) but I'll try to do it before breaking gates | 20:47 |
| amrith | OK, and I'll propose some of the tests that I mentioned this morning against head of nova | 20:47 |
| andreykurilin | amrith: it will be cool, thanks | 20:48 |
| openstackgerrit | STEW TY proposed openstack/nova: Transform instance.resize_revert notification https://review.openstack.org/396811 | 20:51 |
| *** bvanhav__ has quit IRC | 20:54 | |
| *** karimb has quit IRC | 20:54 | |
| *** moshele has quit IRC | 20:57 | |
| *** _ducttape_ has joined #openstack-nova | 20:57 | |
| *** gcb has joined #openstack-nova | 21:01 | |
| *** kaisers_ has quit IRC | 21:01 | |
| *** ducttape_ has quit IRC | 21:01 | |
| *** jerrygb_ has joined #openstack-nova | 21:01 | |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 21:01 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 21:01 |
| *** kaisers has joined #openstack-nova | 21:02 | |
| *** jerrygb has quit IRC | 21:03 | |
| *** jerrygb_ has quit IRC | 21:04 | |
| *** tjones has quit IRC | 21:04 | |
| *** vsaienko has quit IRC | 21:05 | |
| *** alexpilotti has quit IRC | 21:08 | |
| *** satyar has quit IRC | 21:08 | |
| *** alexpilotti has joined #openstack-nova | 21:08 | |
| *** ijw has joined #openstack-nova | 21:10 | |
| *** dave-mccowan has quit IRC | 21:10 | |
| *** lpetrut has joined #openstack-nova | 21:10 | |
| *** spligak has joined #openstack-nova | 21:11 | |
| *** mriedem has joined #openstack-nova | 21:11 | |
| *** sacharya has quit IRC | 21:12 | |
| mriedem | i hope my insurance covers a bad case of sand crack | 21:12 |
| *** alexpilotti has quit IRC | 21:13 | |
| *** sacharya has joined #openstack-nova | 21:14 | |
| *** sdague has quit IRC | 21:14 | |
| cdent | get some talcum powder on that ass | 21:15 |
| *** dimtruck is now known as zz_dimtruck | 21:15 | |
| *** pradk has quit IRC | 21:16 | |
| *** gszasz has quit IRC | 21:18 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: check OSC https://review.openstack.org/420941 | 21:19 |
| *** vsaienko has joined #openstack-nova | 21:21 | |
| *** pradk has joined #openstack-nova | 21:23 | |
| mriedem | vladikr: so i was thinking about vlan vifs and tempest testing, we probably don't have any jobs that use vlan tags on ports do we? | 21:23 |
| *** READ10 has joined #openstack-nova | 21:28 | |
| *** kaisers has quit IRC | 21:29 | |
| *** kaisers_ has joined #openstack-nova | 21:29 | |
| cdent | bauzas: your grenade run has just finished | 21:29 |
| bauzas | cdent: yup, was following | 21:29 |
| cdent | on the old side it looks like placement auth isn't in place: http://logs.openstack.org/30/424730/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/6ccea97/logs/old/screen-n-cpu.txt.gz#_2017-01-24_20_36_57_937 | 21:30 |
| bauzas | cdent: that's for the full grenade job right? | 21:30 |
| bauzas | cdent: if so, I think it's not a problem | 21:31 |
| cdent | Oh, is it just changed for one of the jobs not all? | 21:31 |
| bauzas | cdent: I was rather looking at the multinode job | 21:31 |
| bauzas | cdent: I provided a from-newton script | 21:31 |
| bauzas | cdent: so it's not changing the old side AFAICU | 21:32 |
| cdent | ah, I follow now | 21:32 |
| bauzas | cdent: that said, I'd like to see the old compute calling the new scheduler by grenade | 21:33 |
| bauzas | cdent: so IIUC it's the multinode job | 21:33 |
| bauzas | but maybe dansmith can insight? | 21:33 |
| bauzas | I think I'm also starting the placement engine for any node, including a specific compute only | 21:34 |
| *** vsaienko has quit IRC | 21:34 | |
| *** Jeffrey4l_ has joined #openstack-nova | 21:34 | |
| cdent | bauzas: I've got to call it a night, but if there's something I can do to help out tomorrow morning leave me a note somewhere (email or here is fine) | 21:34 |
| bauzas | cdent: I'm just rechecking the scheduler change | 21:34 |
| * cdent waves goodnight | 21:34 | |
| bauzas | cdent: for seeing if it's now happy | 21:35 |
| bauzas | cdent: sure | 21:35 |
| *** catintheroof has quit IRC | 21:35 | |
| *** cdent has quit IRC | 21:35 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** catintheroof has joined #openstack-nova | 21:35 | |
| *** catintheroof has quit IRC | 21:35 | |
| *** _ducttape_ has quit IRC | 21:37 | |
| dansmith | bauzas: from-$release only runs on the main node AFAK | 21:37 |
| *** zz_dimtruck is now known as dimtruck | 21:37 | |
| *** ducttape_ has joined #openstack-nova | 21:37 | |
| bauzas | dansmith: I replied to you on the ML thread about optional resources | 21:38 |
| bauzas | dansmith: have you seen my other emails ? | 21:38 |
| dansmith | yeah | 21:38 |
| *** ducttape_ has quit IRC | 21:38 | |
| bauzas | and why I think it's understandable, I think asking that for Ocata seems difficult to me | 21:39 |
| bauzas | the gate itself is even not running DiskFilter... | 21:39 |
| bauzas | oops | 21:39 |
| bauzas | CoreFilter I meant | 21:39 |
| *** ducttape_ has joined #openstack-nova | 21:39 | |
| bauzas | and we also have an assertion that says amount can't be 0 - but we have a lot of flavors having root_gb=0 | 21:39 |
| bauzas | so what should I ask for if a flavor is set to root_gb=0 for example ? | 21:40 |
| bauzas | I mean, I totally understand jaypipes's opinion about why it's a wrong direction | 21:41 |
| bauzas | I just think it's not something we should stop by Ocata | 21:41 |
| cburgess | dansmith: If I have an instance object (returned from novaclient) is there an easy way to refresh the status and task_status from the DB? Or do I have to do a full server.get() again? | 21:42 |
| dansmith | cburgess: you don't get instance objects back from novaclient, you get a dict.. so yeah, you have to .get() again | 21:43 |
| cburgess | OK well not from the DB since clearly it has to make an API call since I'm using novaclient. I mean do you just get it again or is there some swanky built-in to refresh it? | 21:43 |
| cburgess | Oh ok.. | 21:43 |
| bauzas | dansmith: saw my points above ? | 21:44 |
| cburgess | Hmm weird.. its got methods defined on it, but I get your point. I'll re-fetch it. | 21:44 |
| dansmith | bauzas: yes, I've read your emails and the points above, I'm not sure what to say and I'm frantically trying to get other work done | 21:44 |
| dansmith | bauzas: it's just MHO | 21:44 |
| *** kaisers has joined #openstack-nova | 21:45 | |
| bauzas | dansmith: okay again, I don't disagree with both of you | 21:45 |
| bauzas | dansmith: I'm just trying to be pragmatic | 21:45 |
| *** kaisers_ has quit IRC | 21:48 | |
| vladikr | mriedem, sorry I was away.. Yes, I didn't find any jobs that uses vlans | 21:49 |
| vladikr | mriedem, also, in order to test it, we need something that will set the {binding:{details:{vlan: X}}} | 21:50 |
| vladikr | mriedem, which is not available for all vnic types | 21:51 |
| mriedem | vladikr: right that's what got me thinking about it | 21:51 |
| mriedem | if we don't have a job that sets the vlan tag on the port details, | 21:51 |
| mriedem | then any tempest test for checking it probably isn't going to do anything | 21:52 |
| vladikr | mriedem, I'm still looking for how to do it.. artom is helping as well (took a break to pickup the kids though) - but I don't know if it's all possible | 21:53 |
| mriedem | vladikr: if the vif details don't have a vlan tag, do we not put anything into the metadata json response? if we always have something in there for vlan tags, even if it's just None or [], we could check for that | 21:54 |
| vladikr | mriedem, if we don't have anything in the binding we just skip the device (unless it has tags) | 21:55 |
| *** thorst_ has quit IRC | 21:55 | |
| *** gszasz has joined #openstack-nova | 21:55 | |
| mriedem | bauzas: replied to your thread with a question/clarification | 21:58 |
| *** breitz has quit IRC | 21:59 | |
| *** breitz has joined #openstack-nova | 22:00 | |
| *** kaisers_ has joined #openstack-nova | 22:01 | |
| *** amotoki has joined #openstack-nova | 22:02 | |
| *** kaisers__ has joined #openstack-nova | 22:02 | |
| bauzas | mriedem: I think your clarification works with me | 22:03 |
| bauzas | mriedem: I'm not only worried by CDs like TripleO | 22:03 |
| bauzas | mriedem: I'm more worried of people trying to change their cloud because we decided so without a warning cycle | 22:03 |
| *** READ10 has quit IRC | 22:04 | |
| *** kaisers__ has quit IRC | 22:04 | |
| bauzas | in general, we try to first notice them for a cycle and do the cut on the next one | 22:04 |
| *** kaisers has quit IRC | 22:04 | |
| bauzas | here, if you're not changing your cloud before upgrading, you won't get any failure but the scheduler won't work like you set it previosuly | 22:05 |
| *** kaisers has joined #openstack-nova | 22:05 | |
| bauzas | so I'm pretty sure lots of folks will be confused then | 22:05 |
| *** kaisers_ has quit IRC | 22:05 | |
| bauzas | that said, I'm still having 2 concerns | 22:05 |
| mriedem | bauzas: well you should be reading the release notes before upgrading | 22:06 |
| bauzas | mriedem: I know | 22:06 |
| bauzas | mriedem: and I'm all in favor of that | 22:06 |
| bauzas | but for example, take the flavor root_gb=0 | 22:06 |
| bauzas | people do that for avoiding having issues with shared volumes, right? | 22:07 |
| bauzas | I know we're going to help them with the aggregates BP | 22:07 |
| bauzas | but for the moment, they still have flavors set with that zero size | 22:07 |
| mriedem | we account for that in the RT don't we? | 22:07 |
| mriedem | *scheduler report client | 22:08 |
| mriedem | for disk inventory | 22:08 |
| bauzas | mriedem: but what should we ask to the PlacementAPI if the flavor is 0 ? | 22:08 |
| *** baoli has quit IRC | 22:08 | |
| bauzas | mriedem: eg. https://review.openstack.org/#/c/417961/22/nova/scheduler/filter_scheduler.py@164 | 22:08 |
| mriedem | looking at https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L129 | 22:09 |
| *** tblakes has quit IRC | 22:09 | |
| mriedem | it looks like we wouldn't include the DISK_GB resource class if the flavor is 0 root_gb | 22:09 |
| mriedem | bauzas: yeah what you have in there looks correct | 22:10 |
| bauzas | mriedem: because we don't accept an amount of 0 | 22:10 |
| bauzas | in the PlacementAPI | 22:10 |
| bauzas | anyway, my thoughts are: we all agree it's bad to disable those filters | 22:11 |
| bauzas | people should rather use allocation ratios | 22:11 |
| bauzas | and that, we all agreed multiple times in the past | 22:11 |
| *** aojea has quit IRC | 22:12 | |
| bauzas | what I'm advocating is a certain deprecation window for operators | 22:12 |
| bauzas | asking them to make sure they set correct allocation ratios to their computes | 22:12 |
| bauzas | that could be infinite | 22:12 |
| bauzas | that's where I want to be pragmatic | 22:13 |
| mriedem | i personally don't have a problem with that, if we're deprecating the Core/RAM/Disk filters at the same time | 22:13 |
| mriedem | the thing is, | 22:13 |
| mriedem | if we mark those as deprecated, people will probably remove them from their enabled_filters list | 22:13 |
| mriedem | which then gets them into this situation where we don't request VCPU and log a warning saying you don't have the CoreFilter in enabled_filters | 22:13 |
| mriedem | so it gets weird | 22:13 |
| amrith | mriedem, andreykurilin I see that the requirements change has blocked novaclient 7.0.0 | 22:14 |
| amrith | is there a new client version coming? | 22:14 |
| mriedem | amrith: working on it | 22:14 |
| amrith | ok, thx mriedem | 22:14 |
| bauzas | mriedem: the fact with those legacy filters is that johnthetubaguy pointed out that CachingScheduler still needs them | 22:15 |
| mriedem | ok so we can't deprecate them, | 22:15 |
| bauzas | mriedem: so I haven't targeted to deprecate them | 22:15 |
| bauzas | exactly | 22:15 |
| mriedem | and if CoreFilter isn't in the enabled_filters list for the filter scheduler, it's going to log a warning? | 22:16 |
| bauzas | why so? | 22:16 |
| *** smatzek has quit IRC | 22:16 | |
| dansmith | mriedem: we have to account for swap and ephemeral in DISK_GB, remember.. | 22:16 |
| mriedem | because long-term we don't want to rely on that | 22:16 |
| mriedem | bauzas: i'm trying to figure out at what point this becomes an error, | 22:16 |
| mriedem | and how you plan to signal that | 22:16 |
| bauzas | mriedem: I was rather thinking of the contrary | 22:18 |
| bauzas | mriedem: ie. signal that by Pike you shouldn't use the legacy filters *if and only if you run the FilterScheduler* | 22:18 |
| *** eharney has quit IRC | 22:18 | |
| *** baoli has joined #openstack-nova | 22:19 | |
| mriedem | which means removing CoreFilter from the enabled_filters list right? | 22:19 |
| bauzas | mriedem: yup | 22:19 |
| bauzas | ideally, deployers should stop having the CoreFilter set by Pike | 22:20 |
| bauzas | unless they use another scheduler driver | 22:20 |
| mriedem | and when you make that a hard requirement, you'll remove any conditional check on the CoreFilter such that you're always requesting VCPU filtering of RPs in the filter scheduler? | 22:20 |
| bauzas | yup | 22:20 |
| bauzas | people in general don't disable all three legacy filters | 22:21 |
| bauzas | so they would still get a warning for at least one | 22:21 |
| mriedem | still, | 22:21 |
| mriedem | "ideally, deployers should stop having the CoreFilter set by Pike" | 22:21 |
| mriedem | so at runtime in Ocata, are you going to log a warning if CoreFilter is in enabled_filters? | 22:21 |
| bauzas | mriedem: that's not part of my change yet but I could do that | 22:22 |
| mriedem | but if you do that, | 22:22 |
| mriedem | it means, 'remove CoreFilter from enabled_filters before pike' | 22:22 |
| mriedem | which also means, you don't get an VCPU filtering with RPs in the filter scheduler | 22:22 |
| mriedem | so it's a catch-22 | 22:22 |
| bauzas | mmm good point | 22:22 |
| mriedem | s/an/any/ | 22:22 |
| bauzas | lemme reconsider that | 22:23 |
| bauzas | okay, so your option | 22:23 |
| bauzas | within the FilterScheduler, log a warning if one of the 3 filters is disabled | 22:23 |
| *** tbachman has quit IRC | 22:23 | |
| bauzas | that's for Ocata | 22:24 |
| *** aojea has joined #openstack-nova | 22:24 | |
| *** baoli has quit IRC | 22:24 | |
| bauzas | so people would need to change their ratios for that during Ocata and enable the filter in Ocata | 22:24 |
| bauzas | now, in Pike we would assume that all clouds have those 3 filters enabled and we would remove the conditionals I just wrote | 22:25 |
| *** karimb has joined #openstack-nova | 22:25 | |
| bauzas | honestly, I dunno | 22:26 |
| *** owalsh-afk is now known as owalsh | 22:26 | |
| bauzas | maybe it's because it's becoming late to me and my brain is fried | 22:26 |
| *** krtaylor has quit IRC | 22:27 | |
| *** alexpilotti has joined #openstack-nova | 22:27 | |
| bauzas | dansmith: FWIW, devstack uses the flavor #42 which is having both root, ephemeral and swap set to 0 | 22:27 |
| mriedem | enabling the filters just to say, 'don't do this b/c we're going to stop caring about them for the filter scheduler' is very weird | 22:28 |
| *** tbachman has joined #openstack-nova | 22:28 | |
| bauzas | mriedem: I agree, that doesn't sound a great plan | 22:28 |
| dansmith | bauzas: yeah, I know.. I'm not sure what root=0 has to do with this discussion at all | 22:29 |
| bauzas | dansmith: https://review.openstack.org/#/c/417961/22/nova/scheduler/filter_scheduler.py@164 | 22:30 |
| *** tblakes has joined #openstack-nova | 22:30 | |
| mriedem | bauzas: those are different issues, | 22:30 |
| *** baoli has joined #openstack-nova | 22:32 | |
| *** alexpilotti has quit IRC | 22:32 | |
| openstackgerrit | Steven Webster proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | 22:32 |
| mriedem | bauzas: given the retarded dance we'd have to come up with just to say this stuff is changing, i think i'd prefer to just always request VCPU/RAM/DISK_GB as outlined in the spec and make it clear in the release notes that if you didn't have those filters enabled before, you need to adjust for that with allocation ratios now before upgrading to ocata | 22:34 |
| mriedem | bauzas: and as dansmith said, we could also work that into the nova-status upgrade check | 22:34 |
| *** Guest86718 has quit IRC | 22:35 | |
| *** karts has quit IRC | 22:35 | |
| bauzas | mriedem: okay, I then need to hurry up to change a few more things | 22:36 |
| bauzas | and hope nobody won't complain too much | 22:36 |
| *** baoli has quit IRC | 22:36 | |
| mriedem | bauzas: and then reply to the ML thread signing away your consent | 22:37 |
| bauzas | mriedem: tbc, I won't have the bandwidth for the nova-status check | 22:37 |
| bauzas | mriedem: neither me notifying the operators they have to move on | 22:38 |
| mriedem | bauzas: i can do nova-status | 22:38 |
| bauzas | for what I see, I only have 1.5 day left for changing at least a couple of tests | 22:38 |
| bauzas | at least some of the functional tests | 22:38 |
| * mriedem overnights some meth to bauzas | 22:38 | |
| bauzas | mriedem: you're on vacation, remember :) | 22:38 |
| *** marst_ has quit IRC | 22:39 | |
| bauzas | mriedem: well, I don't have a RV for that | 22:39 |
| *** moshele has joined #openstack-nova | 22:40 | |
| mriedem | jaypipes: how are things looking for this last patch in the resource classes series? https://review.openstack.org/#/c/404472/ | 22:43 |
| bauzas | sooooo, the grenade change didn't help the scheduler change | 22:43 |
| bauzas | I'm depressed | 22:43 |
| *** lpetrut has quit IRC | 22:44 | |
| *** owalsh_ has joined #openstack-nova | 22:44 | |
| mriedem | jaypipes: er i guess it's no longer the last change in the series | 22:44 |
| *** alexpilotti has joined #openstack-nova | 22:45 | |
| bauzas | let's be clear, given the grenade problem, I'm not feeling we could merge https://review.openstack.org/#/c/417961 by Ocata | 22:46 |
| bauzas | anyway | 22:46 |
| bauzas | I'll need to bail out for the night or I'm doomed | 22:46 |
| *** owalsh has quit IRC | 22:47 | |
| *** karts has joined #openstack-nova | 22:47 | |
| bauzas | so in case folks have a bit of interest about https://review.openstack.org/#/c/417961 and are knowing grenade, feel free to help | 22:47 |
| *** burgerk__ has joined #openstack-nova | 22:48 | |
| *** esberglu has quit IRC | 22:48 | |
| *** esberglu has joined #openstack-nova | 22:48 | |
| *** alexpilotti has quit IRC | 22:49 | |
| *** david-lyle has quit IRC | 22:50 | |
| *** burgerk_ has quit IRC | 22:51 | |
| *** owalsh_ is now known as owalsh | 22:51 | |
| *** dimtruck is now known as zz_dimtruck | 22:52 | |
| *** esberglu has quit IRC | 22:53 | |
| *** david-lyle has joined #openstack-nova | 22:53 | |
| *** tblakes has quit IRC | 22:53 | |
| andreykurilin | stevemar: please, put W-1 at https://review.openstack.org/#/c/424847/1 . It breaks novaclient's gates | 22:54 |
| andreykurilin | :( | 22:54 |
| *** burgerk__ has quit IRC | 22:54 | |
| *** mdrabe has quit IRC | 22:54 | |
| andreykurilin | it looks like we need to bump openstacksdk and openstackclient versions together | 22:54 |
| mriedem | andreykurilin: reminder on https://review.openstack.org/#/c/418190/ in case you have to use it | 22:55 |
| *** alexpilotti has joined #openstack-nova | 22:55 | |
| stevemar | andreykurilin: that'll blow the requirements teams minds | 22:55 |
| mriedem | only thing on ^ is we'd have to cleanup the commit message | 22:55 |
| *** alexpilotti has quit IRC | 22:56 | |
| stevemar | mriedem: fi-lgtm | 22:56 |
| *** alexpilotti has joined #openstack-nova | 22:56 | |
| stevemar | andreykurilin: i rebased it, should be bumped out of the gate (don't think it even got that far) | 22:57 |
| dansmith | bauzas: it's not starting the placement api, looks like | 22:57 |
| dansmith | bauzas: I see no placement-api log | 22:57 |
| stevemar | andreykurilin: how would bumping OSC min solve the issue? | 22:57 |
| andreykurilin | mriedem: but why we have multiple networks with latest openstacksdk and do not have them with old version? | 22:58 |
| *** edmondsw has quit IRC | 22:58 | |
| *** alexpilo_ has joined #openstack-nova | 22:59 | |
| mriedem | andreykurilin: because the sdk broke the filtering on available networks :) | 22:59 |
| *** xyang1 has quit IRC | 22:59 | |
| andreykurilin | mriedem: oh | 22:59 |
| *** moshele has quit IRC | 22:59 | |
| mriedem | at least i think that's what kevinbenton found when he looked at that issue before | 23:00 |
| mriedem | his notes are in that patch | 23:00 |
| stevemar | andreykurilin: mriedem can we just get the nova functional tests working with the newer version? | 23:00 |
| andreykurilin | mriedem: can you update commit message? | 23:00 |
| stevemar | i guess that's what https://review.openstack.org/#/c/418190/ does | 23:00 |
| mriedem | stevemar: well shouldn't that be a major version bump on the sdk? | 23:00 |
| stevemar | mriedem: they have a stance that since they are pre 1.0 they are allowed to break compatibility | 23:01 |
| *** alexpilotti has quit IRC | 23:01 | |
| stevemar | mriedem: like how gmail was in beta for a decade | 23:02 |
| mriedem | stevemar: jesus h c | 23:02 |
| stevemar | osc and senlinclient *need* the latest version | 23:02 |
| bauzas | dansmith: roger, I'll try to investigate tomorrow morning but I'm just exhausted | 23:02 |
| andreykurilin | stevemar: I'm ok to merge mriedem fix for our gates and then look at the process of merging g-r update. I do not want to see g-r update at first, since we need to merge one patch before cutting new release | 23:02 |
| mriedem | well they should shit or get off that pot | 23:02 |
| *** esberglu has joined #openstack-nova | 23:02 | |
| andreykurilin | heh | 23:02 |
| stevemar | mriedem: soon (tm) | 23:02 |
| stevemar | andreykurilin: i would looove that | 23:03 |
| *** alexpilo_ has quit IRC | 23:03 | |
| *** alexpilotti has joined #openstack-nova | 23:03 | |
| stevemar | andreykurilin: rally is good right? | 23:03 |
| andreykurilin | stevemar: yes. setting quotas works. thanks | 23:04 |
| Kevin_Zheng | mriedem: https://bugs.launchpad.net/nova/+bug/1658571 | 23:04 |
| openstack | Launchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Artom Lifshitz (notartom) | 23:04 |
| andreykurilin | stevemar: PS: I wonder why are so dependent on pre 1.0 library which can do whatever they want(as you said) .. | 23:05 |
| andreykurilin | *why we are | 23:05 |
| mriedem | andreykurilin: yeah good question | 23:05 |
| *** gcb has quit IRC | 23:06 | |
| *** alexpilo_ has joined #openstack-nova | 23:06 | |
| mriedem | stevemar: so is OSC going to have a thing in it's release notes saying, oh btw, when you create private tenant networks in this release things are doing to be different? | 23:06 |
| stevemar | andreykurilin: theres some history there | 23:06 |
| mriedem | Kevin_Zheng: hi | 23:06 |
| mriedem | Kevin_Zheng: did you see the ML thread? | 23:06 |
| *** alexpilo_ has quit IRC | 23:06 | |
| *** esberglu has quit IRC | 23:06 | |
| *** alexpilo_ has joined #openstack-nova | 23:07 | |
| andreykurilin | stevemar: if they want to play with us in the same sandbox, they should follow the same rules | 23:07 |
| *** timello has quit IRC | 23:07 | |
| Kevin_Zheng | mriedem: not yet, left early yesterday | 23:07 |
| stevemar | mriedem: we can add that to the release notes, but i think we rename the column/info properly | 23:08 |
| *** alexpilotti has quit IRC | 23:08 | |
| *** harlowja has quit IRC | 23:08 | |
| bauzas | mriedem: what kind of important note should we write for telling to ops "folks, you need to change your cloud before upgrading to Ocata"? | 23:09 |
| bauzas | mriedem: given the upgrade section is already huuuuuge | 23:09 |
| *** krtaylor has joined #openstack-nova | 23:09 | |
| bauzas | possibly in the prelude I guess | 23:09 |
| dansmith | bauzas: made changes.. start_placement() isn't getting called which means no a2ensite, restart, etc | 23:10 |
| mriedem | bauzas: yeah and probably in the placement devref | 23:10 |
| *** timello has joined #openstack-nova | 23:10 | |
| bauzas | dansmith: kewl thanks ! | 23:10 |
| mriedem | bauzas: we'll have something in the prelude section for placement and cells v2 for sure | 23:10 |
| mriedem | i'd also like docs reflected in the devref which we have for placement and cells v2 | 23:10 |
| mriedem | for stuff like this | 23:10 |
| bauzas | dansmith:jam+1 | 23:10 |
| *** jamesdenton has quit IRC | 23:10 | |
| dansmith | heh | 23:11 |
| stevemar | mriedem: plus, everyone uses neutron anyway :P | 23:11 |
| *** alexpilo_ has quit IRC | 23:11 | |
| *** sacharya has quit IRC | 23:12 | |
| *** jaosorior has quit IRC | 23:12 | |
| Kevin_Zheng | mriedem: just read, so a new microversion? | 23:13 |
| *** zz_dimtruck is now known as dimtruck | 23:13 | |
| mriedem | Kevin_Zheng: yes | 23:13 |
| mriedem | Kevin_Zheng: but i think we can handle that as a bug fix after the feature freeze | 23:13 |
| mriedem | so we're not rushing toward thursday | 23:13 |
| Kevin_Zheng | Cool | 23:13 |
| bauzas | dansmith: wrt grenade, how can we make sure that we don't run a placement API in the compute-only for the multinode job ? | 23:14 |
| mriedem | stevemar: this is like earth-shattering issue #4 today so i've lost my sense of humor about it :) | 23:14 |
| Kevin_Zheng | But Chinese New Year comes this week | 23:14 |
| stevemar | mriedem: samesies | 23:14 |
| dansmith | bauzas: by not starting one in the subnode? | 23:14 |
| mriedem | Kevin_Zheng: i think artom is planning to work on it | 23:14 |
| Kevin_Zheng | Ok | 23:14 |
| dansmith | bauzas: the subnode only has ENABLED_SERVICES='n-cpu' or something | 23:14 |
| bauzas | dansmith: yeah, but since I'm updating from-newton, am I sure it's not for the subnode? | 23:15 |
| dansmith | yes | 23:15 |
| *** amotoki has quit IRC | 23:15 | |
| bauzas | dansmith: okay, but I'd still want to have the subnode running placement_compute_only | 23:15 |
| dansmith | bauzas: if that was a problem, all the db creation stuff above your code would run on the subnode too | 23:15 |
| andreykurilin | bauzas mriedem: can you look at https://review.openstack.org/#/c/424256/ ? neutron job stuck, but all others passed. | 23:16 |
| *** haplo37 has quit IRC | 23:18 | |
| mriedem | andreykurilin: looks like it's running | 23:18 |
| andreykurilin | mriedem: ~2,5 hours... | 23:19 |
| andreykurilin | usually it takes less than an hour | 23:19 |
| mriedem | oh hrm | 23:19 |
| mriedem | you might want to ask in -infra | 23:19 |
| mriedem | stevemar: so on https://review.openstack.org/#/c/418190/ you want me to basically just reword the commit to say, the sdk has changed things in a backward incompatible way which breaks osc used in devstack runs, so we have to workaround that now? | 23:20 |
| *** ducttape_ has quit IRC | 23:20 | |
| mriedem | i need to get cleaned up before dinner, full of salt water | 23:21 |
| *** amotoki has joined #openstack-nova | 23:22 | |
| *** haplo37 has joined #openstack-nova | 23:27 | |
| *** dimtruck is now known as zz_dimtruck | 23:27 | |
| *** Swami_ has joined #openstack-nova | 23:29 | |
| *** mtanino_ has joined #openstack-nova | 23:29 | |
| andreykurilin | mriedem: quick question: does version negotiation require to be authenticated ? | 23:29 |
| stevemar | mriedem: let dtroyer take a looksy, i told him about it in -sdks | 23:29 |
| stevemar | mriedem: i'm damn exhausted | 23:29 |
| *** shaner has quit IRC | 23:30 | |
| *** mtanino has quit IRC | 23:30 | |
| andreykurilin | mriedem: and please, check https://review.openstack.org/#/c/424745/ . Not sure is that what you want or not. | 23:32 |
| *** Swami has quit IRC | 23:32 | |
| *** dave-mccowan has joined #openstack-nova | 23:34 | |
| mriedem | andreykurilin: that varies by service, would need to test it out | 23:34 |
| *** edmondsw has joined #openstack-nova | 23:34 | |
| *** dtroyer has joined #openstack-nova | 23:34 | |
| *** owalsh is now known as owalsh-afk | 23:35 | |
| *** Swami_ has quit IRC | 23:35 | |
| *** stewie925 has quit IRC | 23:35 | |
| mriedem | why do we need to change grenade for placement? i thought from-newton was already doing something there? | 23:36 |
| *** takashin has joined #openstack-nova | 23:36 | |
| mriedem | nvm i guess we didn't, | 23:37 |
| mriedem | we made placement enabled by default in d-g on master | 23:38 |
| mriedem | but grenade would start on stable/newton | 23:38 |
| mriedem | andreykurilin: on https://review.openstack.org/#/c/424745/ i think there are also some things in the python API code that i need to look at, | 23:38 |
| *** edmondsw has quit IRC | 23:38 | |
| mriedem | but probably won't have time right now | 23:38 |
| andreykurilin | np | 23:39 |
| bauzas | mriedem: because placement is not defaulted by devstack in newton | 23:39 |
| bauzas | mriedem: that's why I started to write a script for from-newton | 23:40 |
| mriedem | yup | 23:40 |
| dtroyer | andreykurilin: your last comment on https://review.openstack.org/#/c/424847/, you are about to release another novaclient? | 23:40 |
| andreykurilin | dtroyer: yes | 23:40 |
| andreykurilin | dtroyer: we need just to merge https://review.openstack.org/#/c/424256/ . It is last known(for me) blocker | 23:41 |
| dtroyer | any chance https://review.openstack.org/#/c/418190/ can go in too? AIUI that'ss unblock the SDK stuff | 23:41 |
| mriedem | bauzas: was thinking about this https://github.com/openstack-infra/devstack-gate/commit/c1b64743b8404dad93d4c06bcb26cf87cbc5240c | 23:41 |
| *** amotoki has quit IRC | 23:42 | |
| mriedem | andreykurilin: so i'll update the commit message in https://review.openstack.org/#/c/418190/ quick | 23:42 |
| mriedem | since it sounds like we need it regardless | 23:42 |
| andreykurilin | dtroyer: ^ | 23:42 |
| bauzas | mriedem: yup, me too | 23:42 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | 23:43 |
| openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | 23:43 |
| bauzas | mriedem: that's why when I saw grenade being sad for my scheduler change, I looked around and saw there was no placement section | 23:43 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | 23:43 |
| andreykurilin | dtroyer: I think we will have a change that unblocks us soon, so we can start a process of merging updates of g-r. these two changes should not conflict. | 23:46 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Fix functional tests to deal with multiple networks https://review.openstack.org/418190 | 23:47 |
| mriedem | andreykurilin: ^ updated the commit message | 23:47 |
| andreykurilin | mriedem: cool! | 23:47 |
| mriedem | i have now done exactly 2 useful things today i think | 23:48 |
| andreykurilin | )) | 23:48 |
| andreykurilin | thanks! | 23:48 |
| andreykurilin | you are hero | 23:48 |
| mriedem | that calls for a chateaubriand | 23:48 |
| andreykurilin | mriedem bauzas: https://review.openstack.org/#/c/424256/10 posted results ;) it changes just cli, so result of neutron-tempest job should not be affected. it is the last nice-to-have feature before release | 23:50 |
| andreykurilin | ok, I need to go sleep. bye folks! | 23:52 |
| *** alexpilotti has joined #openstack-nova | 23:53 | |
| dtroyer | andreykurilin, mriedem: thanks, | 23:53 |
| gmann | mriedem: alex_xu artom I am +1 to fix in this cycle only | 23:54 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | 23:55 |
| artom | Kevin_Zheng, hey, yeah, I kinda stepped on your feet with my patch, apologies | 23:55 |
| dansmith | bauzas: did you get a run? | 23:55 |
| artom | Umm, I guess mine and yours are different enough that it's defensible to have two approaches proposed? | 23:55 |
| bauzas | dansmith: not yet | 23:55 |
| bauzas | dansmith: I just provided a new PS | 23:56 |
| dansmith | bauzas: but you just rev'd it? | 23:56 |
| bauzas | yup | 23:56 |
| dansmith | mmkay, was waiting for that run | 23:56 |
| bauzas | oh sorry :( | 23:56 |
| Kevin_Zheng | artom: ah, NP, I didn't see the ML yesterday, maybe your way is the way that we all like | 23:56 |
| bauzas | I haven't seen you rechecked it | 23:56 |
| bauzas | sorry :( | 23:56 |
| dansmith | it was still running, right? | 23:56 |
| *** thorst_ has joined #openstack-nova | 23:57 | |
| Kevin_Zheng | artom: also our holiday is coming so maybe you can fix it more faster than me :) | 23:57 |
| *** thorst_ has quit IRC | 23:57 | |
| mriedem | ok i've got to run for the night, will update the ML thread on the RP / enabled filters thing in the morning | 23:57 |
| *** alexpilotti has quit IRC | 23:57 | |
| *** mriedem has quit IRC | 23:57 | |
| *** ducttape_ has joined #openstack-nova | 23:58 | |
| artom | Kevin_Zheng, hah, OK, happy it works out then :D | 23:58 |
| bauzas | dansmith: I haven't looked at zuul | 23:58 |
| bauzas | before uploading it again | 23:58 |
| bauzas | so I dunno :( | 23:58 |
| *** harlowja has joined #openstack-nova | 23:58 | |
| dansmith | okay, well, it was like 15 minutes from a run completion or something | 23:58 |
| dansmith | anyway | 23:58 |
| * dansmith heads out for a bit | 23:58 | |
| *** Swami has joined #openstack-nova | 23:58 | |
| gmann | artom: Kevin_Zheng so this is one going as fix - https://review.openstack.org/#/c/424759/ | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!