Wednesday, 2017-01-11

*** moshele has joined #openstack-nova00:01
openstackgerritDan Smith proposed openstack/nova: WIP: Test cellsv1  https://review.openstack.org/41814100:04
*** dave-mccowan has quit IRC00:07
*** jamielennox is now known as jamielennox|away00:07
*** harlowja has quit IRC00:09
*** LeoZhang has quit IRC00:09
*** LeoZhang has joined #openstack-nova00:10
*** CristinaPauna has quit IRC00:10
*** CristinaPauna has joined #openstack-nova00:10
*** purplerbot has quit IRC00:11
*** jamielennox|away is now known as jamielennox00:11
*** ansiwen has quit IRC00:11
*** andrewbogott has quit IRC00:11
*** baoli has quit IRC00:12
*** efried has joined #openstack-nova00:12
*** macsz has quit IRC00:12
*** markvoelker has quit IRC00:12
*** vdrok has quit IRC00:12
*** haukebruno has quit IRC00:12
*** rpodolyaka has quit IRC00:12
*** johnsom has quit IRC00:12
*** macsz has joined #openstack-nova00:12
*** purplerbot has joined #openstack-nova00:12
*** med_ has quit IRC00:12
*** afazekas has quit IRC00:12
*** markvoelker has joined #openstack-nova00:12
*** pkoniszewski has quit IRC00:13
*** ansiwen has joined #openstack-nova00:13
*** ildikov has quit IRC00:13
*** haukebruno has joined #openstack-nova00:13
*** jroll has quit IRC00:14
*** Dave_____ has joined #openstack-nova00:14
openstackgerritTakashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host  https://review.openstack.org/40670700:15
*** andrewbogott has joined #openstack-nova00:15
*** hongbin has quit IRC00:15
*** pkoniszewski has joined #openstack-nova00:16
*** med_ has joined #openstack-nova00:16
*** med_ is now known as Guest4752000:17
*** afazekas has joined #openstack-nova00:17
*** Guest47520 is now known as medberry00:19
*** medberry has quit IRC00:19
*** medberry has joined #openstack-nova00:19
*** Dave has quit IRC00:19
*** rpodolyaka has joined #openstack-nova00:20
*** jroll has joined #openstack-nova00:21
*** ildikov has joined #openstack-nova00:21
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597800:21
*** vdrok has joined #openstack-nova00:22
*** johnsom has joined #openstack-nova00:22
*** vdrok has quit IRC00:25
*** vdrok has joined #openstack-nova00:25
*** johnsom has quit IRC00:25
*** johnsom has joined #openstack-nova00:25
*** thorst has joined #openstack-nova00:25
*** harlowja has joined #openstack-nova00:25
*** mlavalle has quit IRC00:31
*** tbachman has quit IRC00:32
*** jwcroppe has quit IRC00:32
*** chyka has quit IRC00:33
openstackgerritAlex Szarka proposed openstack/nova: Transform instance-exists notification  https://review.openstack.org/40366000:33
*** aslezil has quit IRC00:34
*** alezil is now known as aslezil00:34
*** mriedem has joined #openstack-nova00:35
*** woodster_ has quit IRC00:35
*** mriedem1 has joined #openstack-nova00:38
*** thorst has quit IRC00:42
*** mriedem has quit IRC00:42
*** thorst has joined #openstack-nova00:42
openstackgerritSarafraj Singh proposed openstack/nova: WIP: Add service_token for nova-glance interaction  https://review.openstack.org/41263400:43
openstackgerritSarafraj Singh proposed openstack/nova: DNM: Test service token  https://review.openstack.org/41323200:43
*** jaypipes has quit IRC00:44
*** dtp has quit IRC00:46
*** thorst has quit IRC00:46
*** tbachman has joined #openstack-nova00:49
*** tuanluong has joined #openstack-nova00:53
*** oomichi has quit IRC00:58
*** mriedem1 has quit IRC00:58
*** oomichi has joined #openstack-nova01:00
*** phuongnh has joined #openstack-nova01:04
*** nic has quit IRC01:06
*** huanxie has joined #openstack-nova01:06
*** ssurana has quit IRC01:09
*** LeoZhang has quit IRC01:11
*** thorst has joined #openstack-nova01:11
*** dave-mccowan has joined #openstack-nova01:12
*** ssurana has joined #openstack-nova01:13
oomichialex_xu: can you take a look at https://review.openstack.org/#/c/320375 ? it is a little difficult to understand for me01:14
*** ssurana has left #openstack-nova01:14
*** thorst has quit IRC01:16
openstackgerritDan Smith proposed openstack/nova: WIP: Test cellsv1  https://review.openstack.org/41814101:18
*** zz_dimtruck is now known as dimtruck01:22
*** yuntongjin has joined #openstack-nova01:25
openstackgerritmelanie witt proposed openstack/nova: WIP Count resources to check quota for cells  https://review.openstack.org/41652101:25
openstackgerritmelanie witt proposed openstack/nova: Make Quotas object favor the API database  https://review.openstack.org/41094501:25
openstackgerritmelanie witt proposed openstack/nova: Add online migration to move quotas to API database  https://review.openstack.org/41094601:25
openstackgerritHuan Xie proposed openstack/nova: XenAPI Use os-xenapi lib for nova  https://review.openstack.org/40605901:27
*** kevinz has joined #openstack-nova01:28
*** aweeks has joined #openstack-nova01:32
*** raunak has quit IRC01:33
*** test222 has joined #openstack-nova01:33
*** tjones has joined #openstack-nova01:34
*** briancurtin has joined #openstack-nova01:35
*** namnh has joined #openstack-nova01:39
*** markvoelker has quit IRC01:43
*** markvoelker has joined #openstack-nova01:44
*** markvoelker has quit IRC01:49
*** sree has joined #openstack-nova01:52
oomichialex_xu: johnthetubaguy: can you take a look at https://review.openstack.org/#/c/389314 ? That seems making sense for me.01:54
*** cdelatte has quit IRC01:54
*** sree has quit IRC01:56
*** unicell has quit IRC02:01
*** thorst has joined #openstack-nova02:02
*** thorst has quit IRC02:02
*** efried has quit IRC02:03
alex_xuoomichi: will review the patch after the meeting02:06
*** sacharya has quit IRC02:07
*** fengzhr has joined #openstack-nova02:07
openstackgerritHuan Xie proposed openstack/nova: XenAPI Remove useless files when use os-xenapi lib  https://review.openstack.org/41124102:08
*** browne has quit IRC02:08
*** jose-phillips has quit IRC02:12
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment  https://review.openstack.org/41562202:12
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment  https://review.openstack.org/41810002:12
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment  https://review.openstack.org/39194102:12
openstackgerritArtom Lifshitz proposed openstack/nova: API support for tagged device attachment  https://review.openstack.org/37602102:12
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment  https://review.openstack.org/41552002:12
*** efried has joined #openstack-nova02:13
*** dimtruck is now known as zz_dimtruck02:15
*** yingjun has joined #openstack-nova02:16
*** rama_y has joined #openstack-nova02:22
*** yingjun has quit IRC02:26
*** yingjun has joined #openstack-nova02:28
*** mdrabe has quit IRC02:29
*** voelzmo has joined #openstack-nova02:32
*** voelzmo has quit IRC02:37
*** raunak has joined #openstack-nova02:49
*** sree has joined #openstack-nova02:51
gmannoomichi: alex_xu johnthetubaguy  : yea even i did not find why we enforced volume policy in attachment APIs.02:53
gmannoomichi: alex_xu johnthetubaguy : for clear view we should separate volume attachment controller in separate file for easy maintenance.02:54
openstackgerrithuangtianhua proposed openstack/python-novaclient: Make _console() public  https://review.openstack.org/41436402:54
*** hongbin has joined #openstack-nova02:55
*** sree has quit IRC02:55
*** sacharya has joined #openstack-nova03:02
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bmd  https://review.openstack.org/41865403:07
*** sacharya has quit IRC03:07
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm  https://review.openstack.org/41865403:09
*** moshele has quit IRC03:10
*** zz_dimtruck is now known as dimtruck03:11
*** yamahata has quit IRC03:14
*** rama_y has quit IRC03:14
*** dave-mccowan has quit IRC03:17
openstackgerritWang Qing wu proposed openstack/nova: Introduce base PowerVM driver  https://review.openstack.org/39128803:17
*** bdeschenes has quit IRC03:18
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857103:20
*** thorst has joined #openstack-nova03:20
*** thorst has quit IRC03:20
*** gouthamr has quit IRC03:21
*** amotoki has quit IRC03:21
openstackgerritzhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm  https://review.openstack.org/41865403:26
*** diga has joined #openstack-nova03:27
*** amotoki has joined #openstack-nova03:29
*** nicolasbock has quit IRC03:31
*** salv-orl_ has quit IRC03:32
*** salv-orlando has joined #openstack-nova03:32
*** amotoki has quit IRC03:33
*** tbachman has quit IRC03:35
*** markvoelker has joined #openstack-nova03:36
*** yingjun has quit IRC03:46
*** links has joined #openstack-nova03:47
*** gongysh has joined #openstack-nova03:47
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment  https://review.openstack.org/41562204:07
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment  https://review.openstack.org/41810004:07
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment  https://review.openstack.org/39194104:07
openstackgerritArtom Lifshitz proposed openstack/nova: API support for tagged device attachment  https://review.openstack.org/37602104:07
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment  https://review.openstack.org/41552004:07
*** sacharya has joined #openstack-nova04:15
*** yamahata has joined #openstack-nova04:15
*** sacharya has quit IRC04:20
*** salv-orl_ has joined #openstack-nova04:23
*** salv-orlando has quit IRC04:26
*** jose-phillips has joined #openstack-nova04:27
*** jose-phillips has quit IRC04:30
*** sudipto_ has joined #openstack-nova04:32
*** sudipto has joined #openstack-nova04:32
*** voelzmo has joined #openstack-nova04:33
*** sheel has joined #openstack-nova04:34
*** ijw has quit IRC04:34
*** mdnadeem has joined #openstack-nova04:35
*** sree has joined #openstack-nova04:36
*** psachin has joined #openstack-nova04:40
*** voelzmo has quit IRC04:46
*** phuongnh has quit IRC04:48
*** aslezil_ has joined #openstack-nova04:58
*** dikonoor has joined #openstack-nova05:07
*** raunak_ has joined #openstack-nova05:08
*** thorst has joined #openstack-nova05:09
*** raunak has quit IRC05:09
*** raunak_ is now known as raunak05:09
*** adisky_ has joined #openstack-nova05:11
*** gcb has quit IRC05:13
*** thorst has quit IRC05:14
*** pbandark has joined #openstack-nova05:15
*** sudipto_ has quit IRC05:17
*** sudipto has quit IRC05:17
*** hongbin has quit IRC05:18
openstackgerritzhangyujun proposed openstack/nova: Update JSON Schema for flavor access  https://review.openstack.org/41868305:20
openstackgerritChangBo Guo(gcb) proposed openstack/nova: DNM: just test  https://review.openstack.org/41541305:20
*** tbachman has joined #openstack-nova05:21
*** tbachman has quit IRC05:26
*** yonglihe has quit IRC05:27
*** tbachman has joined #openstack-nova05:28
*** ayogi has joined #openstack-nova05:28
*** prateek has joined #openstack-nova05:34
*** raunak has quit IRC05:35
*** dikonoor has quit IRC05:40
*** aslezil_ has quit IRC05:41
*** sudipto_ has joined #openstack-nova05:42
*** sudipto has joined #openstack-nova05:42
*** ratailor has joined #openstack-nova05:45
*** raunak has joined #openstack-nova05:52
*** gongysh has quit IRC05:54
openstackgerritWang Qing wu proposed openstack/nova: WIP(2): Introduce base PowerVM driver (disk drv)  https://review.openstack.org/40940105:58
*** nkrinner_afk is now known as nkrinner06:04
*** gcb has joined #openstack-nova06:04
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597806:05
*** raunak has quit IRC06:05
*** tbachman has quit IRC06:05
*** tlian has quit IRC06:06
*** bkopilov has joined #openstack-nova06:06
*** unicell has joined #openstack-nova06:07
*** tbachman has joined #openstack-nova06:08
alex_xuoomichi: johnthetubaguy re:https://review.openstack.org/#/c/389314/ I added comment about a solution for deprecate the rule first and remove it next release, if we care about this should be process for removing a policy rule.06:08
*** tbachman_ has joined #openstack-nova06:09
*** raunak has joined #openstack-nova06:10
*** lpetrut has joined #openstack-nova06:10
*** tbachman has quit IRC06:12
*** tbachman_ is now known as tbachman06:12
*** gokhan has joined #openstack-nova06:13
*** dims has quit IRC06:13
*** unicell has quit IRC06:14
*** unicell has joined #openstack-nova06:14
*** tovin07 has joined #openstack-nova06:16
*** sacharya has joined #openstack-nova06:16
*** moshele has joined #openstack-nova06:16
*** raunak has quit IRC06:16
*** ijw has joined #openstack-nova06:18
*** sacharya has quit IRC06:20
*** gongysh has joined #openstack-nova06:21
*** tbachman has quit IRC06:22
*** ijw has quit IRC06:22
gokhanHi Team, I tried to create virtuozzo containers on nova but I am getting errors.My production is mitaka.  I have a compute node which is installed virtuoozo.These are  logs http://paste.openstack.org/show/594498/ Can you help me ?06:23
*** pcaruana has joined #openstack-nova06:25
*** efried has quit IRC06:26
*** satyar has joined #openstack-nova06:31
*** sridharg has joined #openstack-nova06:32
*** moshele has quit IRC06:33
*** sheel has quit IRC06:37
mnestratovgokhan:hi06:38
mnestratovI can help you06:38
*** efried has joined #openstack-nova06:38
*** gongysh has quit IRC06:39
mnestratovgokhan: what virtuozzo version do you have?06:39
gokhanmnestratov I have 7.0.1 I installed from https://download.openvz.org/virtuozzo/releases/openvz-7.0.1-554/x86_64/iso/openvz-iso-7.0.1.iso06:41
gokhanand for openstack I followed https://help.virtuozzo.com/customer/portal/articles/252401306:41
mnestratovgokhan: so you are trying devstack, right?06:43
*** lpetrut has quit IRC06:43
gokhanmnestratov, no not devstack, I am using it on production06:43
mnestratovgokhan: ok I see06:44
*** mjura has joined #openstack-nova06:44
gokhanmnestratov, I followed also https://openvz.org/Basic_operations_in_OpenVZ_environment for creating container. I have created container successfully. But with openstack, I didn't achieve it.06:47
*** ekuris has joined #openstack-nova06:49
*** bhagyashris has joined #openstack-nova06:51
*** ijw has joined #openstack-nova06:54
openstackgerritRoman Dobosz proposed openstack/nova-specs: Provide detailed error information for placement API  https://review.openstack.org/41839306:54
*** hfu has joined #openstack-nova06:56
*** lpetrut has joined #openstack-nova07:00
mnestratovgokhan: looks like you need commit d4aa455d53c91c6dfebbf9a9850f7b6c3fef4545 to fix this issue07:06
mnestratovgokhan: review https://review.openstack.org/#/c/182257/07:06
mnestratovgokhan: there was a lot of changes merged since mitaka regarding virtuozzo support07:07
*** lpetrut has quit IRC07:08
*** tesseract has joined #openstack-nova07:08
gokhanthanks mnestratov, I will try it07:09
mnestratovgokhan: thus, I'd recommend you to use newton07:09
*** tjones has quit IRC07:09
*** unicell has quit IRC07:10
*** unicell has joined #openstack-nova07:10
mnestratovgokhan: did you create a container image yourself or use our test one?07:11
gokhanmnestratov: I used test one07:12
mnestratovgokhan: ok, just wanted to clarify07:13
gokhanmnestratov: ok firstly I will commit these changes . If it doesn't work, I will try newton07:16
mnestratovgokhan: same error?07:16
mnestratovoh I thought you tried already07:17
*** lpetrut has joined #openstack-nova07:17
gokhanno I haven't tried yet.07:17
*** udesale has joined #openstack-nova07:19
*** yuntongjin has quit IRC07:20
*** yuntongjin has joined #openstack-nova07:20
*** andreas_s has joined #openstack-nova07:21
*** nherciu has joined #openstack-nova07:21
*** sapcc-bot has joined #openstack-nova07:22
*** carthaca_ has joined #openstack-nova07:22
*** dimtruck is now known as zz_dimtruck07:24
*** carthaca_ has quit IRC07:24
openstackgerritSergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class  https://review.openstack.org/39448007:26
openstackgerritSergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API.  https://review.openstack.org/35554007:26
openstackgerritSergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen  https://review.openstack.org/39961307:27
openstackgerritavnish proposed openstack/nova: Remove useless ddt requirements  https://review.openstack.org/41874707:27
*** amotoki has joined #openstack-nova07:28
*** kaisers has quit IRC07:32
*** lpetrut has quit IRC07:33
*** kaisers1 has quit IRC07:33
*** hwoarang has quit IRC07:35
*** markus_z has joined #openstack-nova07:36
*** moshele has joined #openstack-nova07:37
*** kevinz has quit IRC07:40
*** kevinz has joined #openstack-nova07:41
*** tojuvone has joined #openstack-nova07:41
*** hwoarang has joined #openstack-nova07:43
*** zenoway has joined #openstack-nova07:48
*** ralonsoh has joined #openstack-nova07:48
*** kaisers has joined #openstack-nova07:50
*** kaisers1 has joined #openstack-nova07:50
*** yonglihe has joined #openstack-nova07:50
*** bkopilov has quit IRC07:55
*** hogepodge has quit IRC07:56
*** sahid has joined #openstack-nova07:59
*** sacharya has joined #openstack-nova08:00
*** yuntongjin has quit IRC08:02
*** sapcc-bot has quit IRC08:03
*** sapcc-bot has joined #openstack-nova08:03
*** carthaca_ has joined #openstack-nova08:03
*** yamahata has quit IRC08:05
*** carthaca_ has quit IRC08:05
*** sacharya has quit IRC08:06
*** amotoki has quit IRC08:16
*** owalsh has joined #openstack-nova08:18
*** gcb has quit IRC08:19
*** sudipto has quit IRC08:21
*** salv-orl_ has quit IRC08:21
*** sudipto_ has quit IRC08:23
*** eglynn has joined #openstack-nova08:23
*** sudipto has joined #openstack-nova08:23
*** sudipto_ has joined #openstack-nova08:23
*** lpetrut has joined #openstack-nova08:24
*** voelzmo has joined #openstack-nova08:25
*** voelzmo has quit IRC08:28
*** lyarwood is now known as lyarwood_08:30
*** gcb has joined #openstack-nova08:33
*** Matias has quit IRC08:37
*** sapcc-bot has quit IRC08:37
*** carthaca_ has joined #openstack-nova08:38
*** dgonzalez_ has joined #openstack-nova08:38
*** sapcc-bot has joined #openstack-nova08:38
*** gcb has quit IRC08:40
*** dgonzalez_ has quit IRC08:40
*** carthaca_ has quit IRC08:40
*** Matias has joined #openstack-nova08:43
*** John341_ has joined #openstack-nova08:48
*** bkopilov has joined #openstack-nova08:51
*** ijw has quit IRC08:52
*** haplo37_ has quit IRC08:54
*** Dave_____ is now known as Dave08:55
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857108:57
*** haplo37_ has joined #openstack-nova08:57
*** sridhargaddam has joined #openstack-nova08:59
*** sridharg has quit IRC08:59
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-nova09:00
alex_xubauzas: johnthetubaguy good morning, I found this patch similar to the force param on evacuate https://review.openstack.org/#/c/408955/11/nova/compute/api.py@3145, but i feel that if the instance without request_spec obj, then the API just don't the thing user expected silently. Does it sounds ok? will Hydrate a fake spec very complex?09:12
bauzasalex_xu: not sure I understand your concern09:13
bauzasalex_xu: FWIW, all the instances are now having a RequestSpec09:14
bauzassince Newton09:14
bauzasbecause I wrote a DB migration for creating a RequestSpec for all the already created instances09:14
alex_xubauzas: oops, we have data migration for it? I saw this comment https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3897, just thought it may still have that case09:15
alex_xubauzas: ah, got it, cool09:15
bauzasalex_xu: yup, sec09:15
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248809:17
bauzasalex_xu: https://github.com/openstack/nova/commit/09f2d4d5ec3a699176d70c2407ced0ce7cd5819709:19
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248809:20
*** namnh has quit IRC09:20
*** avolkov has joined #openstack-nova09:21
alex_xubauzas: thanks, i see now. we probably just need some cleanup later09:22
*** amotoki has joined #openstack-nova09:22
bauzasalex_xu: what's missing is that we don't delete yet the RequetSpec if the instance is deleted09:22
alex_xubauzas: is there any blocker? or we just miss it?09:25
bauzasnothing but time :)09:26
alex_xubauzas: ok :)09:26
*** roeyc has joined #openstack-nova09:27
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597809:30
*** mvk has quit IRC09:32
*** lucas-afk is now known as lucasagomes09:38
*** sree has quit IRC09:40
*** BobBall_AWOL is now known as BobBall09:40
*** sree has joined #openstack-nova09:41
*** derekh has joined #openstack-nova09:42
*** mnestratov has quit IRC09:44
openstackgerritAbhishek Kekane proposed openstack/nova: Use is_valid_cidr and is_valid_ipv6_cidr from oslo_utils  https://review.openstack.org/32037509:44
gmannalex_xu:  why we want to handle  _* separately in https://review.openstack.org/#/c/408571/3609:47
gmannalex_xu:  i mean just 400 in server.py will be enough right instead of allowing it in schema and later allow to go from strip_additional_property09:48
gmannalex_xu: also how about treating that same as other additional property, just ignore09:49
*** hfu has quit IRC09:51
*** ijw has joined #openstack-nova09:52
lyarwood_mdbooth: morning, was anything blocking https://review.openstack.org/#/c/383859/ aside from core reviews?09:53
alex_xugmann: if we didn't put _* in the schema, they will be stripped out09:54
alex_xugmann: we have discuss it whether we can just ignore at last api meeting http://eavesdrop.openstack.org/meetings/nova_api/2017/nova_api.2017-01-04-13.00.log.html09:56
alex_xugmann: start from "13:07:35"09:56
alex_xugmann: but yes, I'm not sure people like current implement.09:57
*** ijw has quit IRC09:57
*** sridharg has joined #openstack-nova09:59
* alex_xu will back after few hours...09:59
*** ijw has joined #openstack-nova10:00
*** lyarwood_ is now known as lyarwood10:02
*** sridhargaddam has quit IRC10:02
gmannalex_xu: oh yea, for db model object internal attributes.10:03
*** lyarwood is now known as lyarwood_10:03
gmannalex_xu: but only allow in strip_additional and later 400 should be enough may be instead of explicitly allow in original schema ?10:04
*** ijw has quit IRC10:05
*** ayogi has quit IRC10:05
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857110:06
*** ayogi has joined #openstack-nova10:07
*** mvk has joined #openstack-nova10:10
*** zenoway has quit IRC10:11
*** zenoway has joined #openstack-nova10:12
*** zenoway has quit IRC10:16
*** udesale has quit IRC10:17
openstackgerritzhangyujun proposed openstack/nova: Update JSON Schema for flavor access  https://review.openstack.org/41868310:23
*** mdnadeem has quit IRC10:24
*** prateek is now known as Prateek|afk10:24
*** kevinz has quit IRC10:27
*** alexpilotti has quit IRC10:27
*** alexpilotti has joined #openstack-nova10:28
*** satyar has quit IRC10:29
*** carthaca_ has joined #openstack-nova10:30
*** dgonzalez_ has joined #openstack-nova10:30
*** dgonzalez_ has quit IRC10:31
*** carthaca_ has quit IRC10:31
*** rfolco has joined #openstack-nova10:32
*** cristicalin has joined #openstack-nova10:34
*** claudiub has joined #openstack-nova10:38
*** zenoway has joined #openstack-nova10:40
mdboothlyarwood_: Actually I've got it open right now. I was writing some docs for it at the suggestion of sfinucan and noticed a race, which I'm addressing.10:40
*** mdnadeem has joined #openstack-nova10:40
mdboothBut basically no.10:40
*** claudiub|2 has quit IRC10:41
*** sree has quit IRC10:43
*** sree has joined #openstack-nova10:43
openstackgerritJiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd.  https://review.openstack.org/41692810:44
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514210:45
*** rmart04 has joined #openstack-nova10:46
*** tuanluong has quit IRC10:46
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533010:46
*** ygl has joined #openstack-nova10:47
*** ygl has left #openstack-nova10:47
*** aarefiev has joined #openstack-nova10:47
*** sree has quit IRC10:48
*** vladikr has quit IRC10:48
openstackgerritavnish proposed openstack/nova: Removed unnecessary utf-8 encoding  https://review.openstack.org/41883810:49
openstackgerritavnish proposed openstack/python-novaclient: Removed unnecessary utf-8 encoding  https://review.openstack.org/41883910:49
*** aarefiev_afk has quit IRC10:50
sfinucanMorning/afternoon, folks. On this, review day, could I get some eyes on two bug fixes: https://review.openstack.org/#/c/396184/ and https://review.openstack.org/#/c/392643/10:52
sfinucanBoth should be somewhat self explanatory, but I'm here if anyone has any questions10:53
openstackgerritBalazs Gibizer proposed openstack/nova: Remove **kwargs passing in payload __init__  https://review.openstack.org/41848910:54
*** zenoway has quit IRC11:00
*** gcb has joined #openstack-nova11:00
*** cdent has joined #openstack-nova11:00
*** huanxie has quit IRC11:02
*** ijw has joined #openstack-nova11:02
*** sacharya has joined #openstack-nova11:02
*** sree has joined #openstack-nova11:06
*** zenoway has joined #openstack-nova11:06
*** ijw has quit IRC11:07
*** sacharya has quit IRC11:07
*** CristinaPauna has quit IRC11:09
*** sudipto has quit IRC11:15
*** sudipto_ has quit IRC11:15
*** sdague has joined #openstack-nova11:15
openstackgerritJohn Garbutt proposed openstack/nova: Populate network data in _validate_requested_network_ids  https://review.openstack.org/41851111:15
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance  https://review.openstack.org/41851211:15
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance  https://review.openstack.org/41851311:15
*** smatzek has joined #openstack-nova11:18
*** CristinaPauna has joined #openstack-nova11:19
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers  https://review.openstack.org/31248811:19
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597811:20
*** smatzek has quit IRC11:21
openstackgerritZhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail  https://review.openstack.org/40857111:21
*** smatzek has joined #openstack-nova11:21
openstackgerritZhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail  https://review.openstack.org/41514211:22
*** bhagyashris has quit IRC11:22
*** sapcc-bot has quit IRC11:27
*** sapcc-bot1 has joined #openstack-nova11:27
*** dgonzalez_ has joined #openstack-nova11:27
*** carthaca_ has joined #openstack-nova11:27
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533011:29
alex_xugmann: I feel explicity in the schema is better than hide some hacky deep into some method.11:29
*** dgonzalez_ has quit IRC11:29
*** carthaca_ has quit IRC11:29
*** nicolasbock has joined #openstack-nova11:35
*** dims has joined #openstack-nova11:39
*** JoseMello has joined #openstack-nova11:40
*** haplo37_ has quit IRC11:40
openstackgerritJohn Garbutt proposed openstack/nova: Extract preallocate_for_instance  https://review.openstack.org/41887611:40
*** cristicalin has quit IRC11:41
*** snikitin_ has joined #openstack-nova11:42
*** haplo37_ has joined #openstack-nova11:43
*** gszasz has joined #openstack-nova11:43
openstackgerritzhangyujun proposed openstack/nova: Query parameter validation for hosts API  https://review.openstack.org/41888011:49
openstackgerritClaudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization  https://review.openstack.org/39850911:49
openstackgerritZhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants  https://review.openstack.org/41533011:50
openstackgerritJohn Garbutt proposed openstack/nova: WIP: Call pre_allocate_for_instance before scheduler  https://review.openstack.org/41312411:51
openstackgerritJohn Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method.  https://review.openstack.org/41888111:51
*** ociuhandu has joined #openstack-nova11:52
*** claudiub|2 has joined #openstack-nova11:54
*** sapcc-bot1 has quit IRC11:56
*** ratailor has quit IRC11:57
*** claudiub has quit IRC11:57
openstackgerritJohn Garbutt proposed openstack/nova: Make allocate_for_instance take consistent args  https://review.openstack.org/41802411:58
*** mvk has quit IRC12:03
*** mpaolino has joined #openstack-nova12:03
*** gszasz has quit IRC12:06
openstackgerritzhangyujun proposed openstack/nova: Update JSON Schema for flavor access  https://review.openstack.org/41868312:06
*** kevinz has joined #openstack-nova12:06
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _validate_requested_network_ids  https://review.openstack.org/41802712:07
openstackgerritJohn Garbutt proposed openstack/nova: Add and use ProcessedNetworkRequest object  https://review.openstack.org/41802512:07
*** rtheis has joined #openstack-nova12:09
*** zenoway has quit IRC12:09
*** nik__ has joined #openstack-nova12:13
*** amotoki has quit IRC12:14
*** mvk has joined #openstack-nova12:15
*** moshele has quit IRC12:16
*** moshele has joined #openstack-nova12:16
*** zenoway has joined #openstack-nova12:17
*** ekuris has quit IRC12:19
*** moshele has quit IRC12:20
*** ekuris has joined #openstack-nova12:20
*** moshele has joined #openstack-nova12:23
*** bvanhav has joined #openstack-nova12:24
*** amotoki has joined #openstack-nova12:26
*** omnipresent has joined #openstack-nova12:26
*** zenoway has quit IRC12:29
*** yuntongjin has joined #openstack-nova12:31
*** kevinz has quit IRC12:31
*** vladikr has joined #openstack-nova12:31
*** kevinz has joined #openstack-nova12:32
*** gszasz has joined #openstack-nova12:34
*** thorst has joined #openstack-nova12:41
*** bdeschenes has joined #openstack-nova12:42
*** sree_ has joined #openstack-nova12:43
*** edmondsw has joined #openstack-nova12:43
*** ayogi has quit IRC12:43
*** sree_ is now known as Guest3639912:43
*** gcb has quit IRC12:45
*** sree has quit IRC12:45
*** omnipresent has quit IRC12:45
*** omnipresent has joined #openstack-nova12:46
*** liuyulong_ has joined #openstack-nova12:48
*** kevinz has quit IRC12:49
*** lucasagomes is now known as lucas-hungry12:50
*** mdnadeem has quit IRC12:50
*** kevinz has joined #openstack-nova12:50
*** amotoki has quit IRC12:50
*** liuyulong has quit IRC12:51
*** claudiub has joined #openstack-nova12:51
alex_xunova api sub-team meeting is 9mins at #openstack-meeting-412:51
*** claudiub|2 has quit IRC12:54
*** sudipto has joined #openstack-nova12:56
*** sudipto_ has joined #openstack-nova12:56
gmannalex_xu:  i see point now, for skipping  _* from strip_additional  we need in schema12:57
gmannalex_xu: thanks :)12:57
alex_xugmann: yea, but that is a little ugly12:58
*** sahid has quit IRC12:58
*** owalsh_ has joined #openstack-nova12:58
Kevin_Zhenglol12:59
gmannalex_xu  true, that's side effect of maintaining lot of versions and supported codes :)12:59
*** owalsh has quit IRC12:59
*** owalsh_ has quit IRC12:59
alex_xugmann: yea :)12:59
*** owalsh_ has joined #openstack-nova12:59
*** amotoki has joined #openstack-nova13:00
*** rfolco has quit IRC13:01
*** amotoki has quit IRC13:02
*** smatzek has quit IRC13:02
*** sacharya has joined #openstack-nova13:03
*** omnipresent has quit IRC13:04
*** LeoZhang has joined #openstack-nova13:04
*** zenoway has joined #openstack-nova13:04
*** liverpooler has quit IRC13:05
*** amotoki has joined #openstack-nova13:05
*** sacharya has quit IRC13:08
*** omnipresent has joined #openstack-nova13:08
*** tovin07_ has joined #openstack-nova13:09
*** zenoway has quit IRC13:09
*** LeoZhang has quit IRC13:10
*** LeoZhang has joined #openstack-nova13:10
*** smatzek has joined #openstack-nova13:12
*** ducttape_ has quit IRC13:14
*** tovin07 has quit IRC13:15
*** tovin07_ is now known as tovin0713:15
*** tovin07_ has joined #openstack-nova13:15
*** ducttape_ has joined #openstack-nova13:17
*** mvk has quit IRC13:21
*** omnipresent has quit IRC13:21
openstackgerritAlex Szarka proposed openstack/nova: Transform instance-exists notification  https://review.openstack.org/40366013:24
*** hfu has joined #openstack-nova13:26
*** efried has quit IRC13:27
*** amotoki has quit IRC13:28
bauzasartom: I have a question for you in https://review.openstack.org/#/c/415520/513:29
bauzas(reviewing all the blueprints for the review day)13:29
bauzasartom: at least, I put -1 because of the confusing docstring13:29
bauzasartom: heh, jinx for the recheck :)13:32
artombauzas, aha! Yeah, that probably makes sense13:32
artombauzas, heh, a lot of volumes tests failed on that one, so I got worried, but it looks like it's an unrelated MySQL failure and not my code13:33
bauzaszactmy13:33
bauzasartom: about the first change, amirite if I think you just need to signal something ?13:33
*** mvk has joined #openstack-nova13:33
bauzasyou don't really care about the value itsefl13:33
bauzasif so, is the tag info something we can get from the vif info ?13:34
bauzasartom: ^13:34
artombauzas, I don't think it's in vif info...13:34
bauzasokay13:34
*** bdeschenes has quit IRC13:35
bauzasif so, we need it in the signature indeed13:35
artomVif info is that weird network model class, right? If so (and IIRC it is) it's not in there13:35
*** mpaolino has quit IRC13:35
artombauzas, strictly speaking, we need it as a boolean flag, so... just check whether it's in kwargs? You think that'd be better?13:36
*** CristinaPauna has quit IRC13:36
bauzasartom: I'm thinking about the interface13:37
bauzasI mean that method signature13:37
bauzasand whether a single boolean is all that good13:37
bauzasI tend to avoid adding extra arguments just for a single conditional13:37
*** jheroux has joined #openstack-nova13:37
bauzasso I tend to regroup all the needed into objects13:38
artomObjects or dicts? Because we know how the latter worked out ;)13:38
bauzaswhen you can actually lookup the needed within the methods13:38
bauzasnah, objects13:38
bauzasI mean13:38
bauzasjust amending a virt signature for passing a boolean is a huge thing13:38
artomYeah, I agree with that13:39
*** swamireddy has quit IRC13:39
*** amotoki has joined #openstack-nova13:39
*** aloga has quit IRC13:39
bauzasthat's why I'm trying to understand whether we can either #1 get that elsewhere but not passed in as arg, or #2 pass a better argument that would help more than just a boolean13:39
*** mdrabe has joined #openstack-nova13:40
artomI guess we can add it as a field in the vif info?13:40
bauzaswell13:40
bauzasif so, that means a new os-vif version, right ?13:40
*** owalsh_ is now known as owalsh-lunch13:40
artomAlso, other virt drivers might need it, I suppose13:40
*** satyar has joined #openstack-nova13:40
artomAnd we pass the tag itself from the compute manager, not just a boolean flag13:40
*** lucas-hungry has quit IRC13:41
*** hfu has quit IRC13:41
artombauzas, hold up, daughter's awake, back a bit later13:42
bauzasnp13:43
*** Jeffrey4l_ has quit IRC13:45
*** huanxie has joined #openstack-nova13:45
*** annegentle has joined #openstack-nova13:46
*** bvanhav_ has joined #openstack-nova13:46
*** bvanhav has quit IRC13:47
*** lucasagomes has joined #openstack-nova13:47
*** yuntongjin has quit IRC13:51
*** winstonsullen has joined #openstack-nova13:51
*** snikitin_ has quit IRC13:52
*** ethenejumpy has joined #openstack-nova13:52
*** tyrola has quit IRC13:53
huanxieHi sdague, I have rebased my nova patch of using os-xenapi https://review.openstack.org/#/c/406059/, could you help review again? This patch already got +2/+w before, but there is a unit test conflict with upstream, so I rebased and fixed, now it's ready. Thanks a lot :)13:53
*** aloga has joined #openstack-nova13:54
*** tyrola has joined #openstack-nova13:54
*** CristinaPauna has joined #openstack-nova13:55
*** owalsh-lunch has quit IRC13:56
*** david-lyle has quit IRC13:56
*** tongli has joined #openstack-nova13:59
*** amotoki has quit IRC13:59
*** david-lyle has joined #openstack-nova13:59
*** mat128 has quit IRC13:59
*** baoli has joined #openstack-nova13:59
*** baoli has quit IRC14:00
*** tblakes has joined #openstack-nova14:00
*** mat128 has joined #openstack-nova14:00
*** baoli has joined #openstack-nova14:00
*** lamt has joined #openstack-nova14:01
*** links has quit IRC14:02
*** kylek3h has quit IRC14:03
*** mriedem has joined #openstack-nova14:03
*** Prateek|afk has quit IRC14:03
*** kaisers_ has joined #openstack-nova14:04
openstackgerritSergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class  https://review.openstack.org/39448014:04
openstackgerritSergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API.  https://review.openstack.org/35554014:04
openstackgerritSergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen  https://review.openstack.org/39961314:04
*** diga has quit IRC14:06
huanxieHi mriedem, I have rebased my patch https://review.openstack.org/#/c/406059/ which is to use os-xenapi lib, could you help have a review again? Thanks a lot!14:08
*** claudiub|2 has joined #openstack-nova14:12
sdaguehuanxie: no prob14:13
*** tlian has joined #openstack-nova14:13
huanxiesdague :)14:13
*** ducttape_ has quit IRC14:14
openstackgerritJohn Garbutt proposed openstack/nova: Add and use ProcessedNetworkRequest object  https://review.openstack.org/41802514:14
openstackgerritJohn Garbutt proposed openstack/nova: Make allocate_for_instance take consistent args  https://review.openstack.org/41802414:14
*** jamielennox is now known as jamielennox|away14:14
*** claudiub has quit IRC14:16
*** liverpooler has joined #openstack-nova14:16
*** xinliang has quit IRC14:16
*** david-lyle has quit IRC14:16
*** annegentle has quit IRC14:18
cdentKevin_Zheng: are you still working on https://review.openstack.org/#/c/410128/ ?14:19
*** winstonsullen has quit IRC14:20
*** claudiub has joined #openstack-nova14:20
*** Swami has joined #openstack-nova14:21
*** zz_dimtruck is now known as dimtruck14:22
*** udesale has joined #openstack-nova14:22
*** claudiub|2 has quit IRC14:23
*** karthiks has quit IRC14:26
openstackgerritPawel Koniszewski proposed openstack/nova: Update instance group during live migration  https://review.openstack.org/33958814:26
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: live-migration test hook for serial console  https://review.openstack.org/34747114:27
*** xinliang has joined #openstack-nova14:30
*** dave-mccowan has joined #openstack-nova14:31
*** kevinz has quit IRC14:31
*** tblakes has quit IRC14:32
*** jgrassler has joined #openstack-nova14:33
*** amotoki has joined #openstack-nova14:39
*** lamt has quit IRC14:40
*** Guest36399 has quit IRC14:42
*** huanxie has quit IRC14:44
*** ducttape_ has joined #openstack-nova14:45
openstackgerritDan Smith proposed openstack/nova: WIP: Test cellsv1  https://review.openstack.org/41814114:46
*** jwcroppe has joined #openstack-nova14:46
mriedemi smell a feature review sprint coming on https://etherpad.openstack.org/p/nova-ocata-feature-freeze14:46
bauzasdansmith: I stopped reviewing cellsv1 effort since a while14:47
*** owalsh-lunch has joined #openstack-nova14:47
bauzasdansmith: is there some change I should first look at14:47
bauzas?14:47
dansmithbauzas: that patch is trying to fix cellsv1 when cellsv2 is enabled14:47
dansmithand it's still a ways off from working, so.. ignore it for now14:47
bauzasmriedem: FWIW, looking at the BP whiteboards is somehow difficult14:47
bauzasdansmith: okay, that was because today means I should help others14:48
*** owalsh-lunch is now known as owalsh14:48
*** huanxie has joined #openstack-nova14:48
*** dimtruck is now known as zz_dimtruck14:49
*** tongli has quit IRC14:49
dansmithbauzas: yeah, you should do that instead of looking at my not-working patch :)14:49
bauzasroger.14:49
bauzasdansmith: today's cells meeting is at 2100UTC, right?14:50
*** huanxie has quit IRC14:50
bauzasI *need* to attend that one after lot of times missing it14:50
dansmithbauzas: are you asking me to be your calendar? today's meeting is in the later slot.14:50
*** huanxie has joined #openstack-nova14:50
bauzasdansmith: no, just verifying my own calendar that I don't trust :)14:51
*** cleong has joined #openstack-nova14:51
openstackgerritMatt Riedemann proposed openstack/nova: xenapi: support the hotplug of a neutron port  https://review.openstack.org/36550514:52
*** gouthamr has joined #openstack-nova14:52
mriedembauzas: how would you like me to custom tailor the etherpad to your delicate sensibilities? :)14:52
mriedembauzas: https://review.openstack.org/#/c/365505/ needs another core14:53
bauzasmriedem: nothing, just a comment :)14:53
bauzasmriedem: we should think about providing a dashboard for the next cycle14:53
bauzasbut meh14:53
mriedemhuanxie: got it14:54
*** tbachman has joined #openstack-nova14:54
huanxiemriedem thanks!14:55
mriedemhuanxie: note that i already updated the release note on the vif hot plugging patch14:55
mriedemso that's ready to go14:55
*** zhangyujun has quit IRC14:56
*** Jinxing has joined #openstack-nova14:58
*** ljxiash has joined #openstack-nova14:58
*** zhangyujun has joined #openstack-nova15:00
huanxiemriedem, I was just trying to ssh to my linux and change this, you have already done, many many thanks:)15:01
mriedemhuanxie: in case you haven't done it yet, you can use the edit button in the gerrit UI, or the 'fix' button next to a comment and make changes in the gerrit UI directly15:01
mriedemthat will make it diverge from your local copy so i only do it for trivial things that are ready to get approved15:02
*** tblakes has joined #openstack-nova15:02
*** efried has joined #openstack-nova15:04
huanxiemridem, I see, I haven't modified directly in gerrit UI, will have a try in my other patch, it's useful for very small change15:04
*** sacharya has joined #openstack-nova15:04
*** zhangyujun has quit IRC15:06
*** hongbin has joined #openstack-nova15:06
*** prateek has joined #openstack-nova15:06
cdentanywhere in particular I should put my eyes for sprinting, or just let the etherpad be my guide?15:07
*** moshele has quit IRC15:07
*** sacharya has quit IRC15:08
huanxiemriedem could you also help review this patch https://review.openstack.org/#/c/406059/, this patch is the first one when using os-xenapi, thanks a lot15:08
*** nkrinner is now known as nkrinner_afk15:09
mriedemhuanxie: that's already approved15:09
mriedemcdent: the diagnostics series could probably use a fresh set of eyes15:10
mriedemas i think it was recently rebased15:10
mriedemcdent: https://review.openstack.org/#/q/topic:bp/restore-vm-diagnostics,n,z15:10
cdentthanks mriedem15:11
*** rama_y has joined #openstack-nova15:11
*** claudiub|2 has joined #openstack-nova15:12
huanxiemriedem, I see, remember each patch needs to get two core reviewers +2 or one +2 is enough?15:12
*** zhangyujun has joined #openstack-nova15:12
mriedemhuanxie: the bottom change was already approved, you just rebased it so sdague fast-approved it again15:13
mriedemwhich is ok15:13
*** jaosorior has joined #openstack-nova15:13
*** psachin has quit IRC15:14
*** pradk has joined #openstack-nova15:15
*** claudiub has quit IRC15:16
huanxiemriedem, oh, I see, thanks for explaining this15:16
*** david-lyle has joined #openstack-nova15:17
*** kylek3h has joined #openstack-nova15:17
mriedemraj_singh: some easy things to cleanup in https://review.openstack.org/#/c/397399/ - mostly remove the reset_globals() thing in service_auth.py15:17
mriedemraj_singh: we don't want to repeat that pattern15:17
mriedemraj_singh: and on the devstack change https://review.openstack.org/#/c/409329/ that needs to depend on the nova change which defines the config15:19
raj_singhmriedem: ok, will respin it now. Thx for the review15:19
artombauzas, heya, back now. So yeah, I agree the method signature is not pretty, but I'm not sure I have a better idea15:20
*** zz_dimtruck is now known as dimtruck15:21
bauzasartom: yup, I understand15:21
bauzasartom: me too honestly15:21
bauzasfortunately, it's not a RPC API15:21
*** prateek has quit IRC15:21
*** david-lyle has quit IRC15:21
bauzasso probably we could just add it now and discuss later on how to have a better argument15:21
artombauzas, I'll definitely update the docstring though15:22
*** yamahata has joined #openstack-nova15:22
mriedemgibi: did you have a bug for the versioned notifications lazy-load issue?15:23
*** marst has joined #openstack-nova15:23
*** huanxie has quit IRC15:23
*** ekuris has quit IRC15:24
gibimriedem: yes15:24
gibimriedem: here it is https://review.openstack.org/#/c/415857/15:24
mriedemthanks15:25
*** sacharya has joined #openstack-nova15:25
*** READ10 has joined #openstack-nova15:26
*** raj_singh_ has joined #openstack-nova15:26
*** raj_singh_ has left #openstack-nova15:27
*** prateek has joined #openstack-nova15:27
*** raj_singh_ has joined #openstack-nova15:27
*** ljxiash has quit IRC15:27
*** markvoelker has quit IRC15:28
*** baoli has quit IRC15:28
cdentsnikitin: I left these as a comment, but how come the new NovaObject based DiskDiagnostics doesn't get an id, when the old one did?15:29
*** markvoelker has joined #openstack-nova15:29
*** sridharg has quit IRC15:31
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _validate_requested_network_ids  https://review.openstack.org/41802715:32
*** nklenke_ has joined #openstack-nova15:33
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment  https://review.openstack.org/41562215:34
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment  https://review.openstack.org/41810015:34
openstackgerritArtom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment  https://review.openstack.org/39194115:34
openstackgerritArtom Lifshitz proposed openstack/nova: API support for tagged device attachment  https://review.openstack.org/37602115:34
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment  https://review.openstack.org/41552015:34
*** markvoelker has quit IRC15:35
openstackgerritChristopher Martin proposed openstack/nova: Stop using mox in test_compute_cells.py  https://review.openstack.org/38975015:35
*** udesale has quit IRC15:36
*** raunak has joined #openstack-nova15:37
*** prateek has quit IRC15:37
*** prateek has joined #openstack-nova15:38
*** raunak has quit IRC15:40
*** Jeffrey4l has joined #openstack-nova15:40
*** lucasagomes has quit IRC15:44
*** lucasagomes has joined #openstack-nova15:46
*** hamzy has joined #openstack-nova15:46
artommriedem, heya - you mentioned bumping the RPC version for the tagged attachment patches. I'm wondering whether I squish both volume and nic stuff into one patch and have a bigger patch but only one version bump, or keep it split for easier to digest patches but 2 version bumps (one for each, nic and volume)15:47
*** Swami_ has joined #openstack-nova15:47
artoms/squish/squash/ (though squish is funnier)15:47
*** prateek has quit IRC15:47
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Refactor _post_live_migratiion  https://review.openstack.org/41302115:48
*** mvk has quit IRC15:48
*** burt has joined #openstack-nova15:49
openstackgerritSarafraj Singh proposed openstack/nova: Add service_token for nova-cinder interaction  https://review.openstack.org/39739915:49
*** Swami has quit IRC15:49
mriedemcdent: that came up in the spec review, i asked the same thing, i think it was ultimately decided that the disk id wasn't useful, but we could add one in later if needed, i.e. via bdm uuid or something15:50
*** Sukhdev has joined #openstack-nova15:50
cdentso how do you tell one disk from another?15:50
mriedemcdent: https://review.openstack.org/#/c/357884/ if it helps15:50
* cdent looks15:51
mriedemcdent: yeah i asked the same questions in the spec review15:51
mriedemwould have to go back through the conversation on that review to get the answer15:51
cdentheh :)15:51
* cdent is reading15:51
*** aslezil_ has joined #openstack-nova15:51
*** armax has joined #openstack-nova15:52
cdentthe gist appears to be: we never had good info there in the first place, and making it could be expensive, so we'll get rid of it for now15:52
*** eglynn has quit IRC15:52
mriedemcdent: https://review.openstack.org/#/c/357884/9/specs/ocata/approved/restore-vm-diagnostics.rst@14215:52
cdentsort-of-jinx15:52
mriedemi'm pretty sure we also asked if/how people were using it in the ops list and didn't get much of a response15:53
mriedemso we're kind of flying blind15:53
*** ethenejumpy has quit IRC15:54
*** shaner has quit IRC15:54
*** shaner has joined #openstack-nova15:54
mriedemthere was some response i guess http://lists.openstack.org/pipermail/openstack-operators/2016-October/011793.html15:54
openstackgerritSarafraj Singh proposed openstack/nova: WIP: Add service_token for nova-glance interaction  https://review.openstack.org/41263415:55
mriedemcdent: so i guess people use it as a poor mans way of bypassing ceilometer?15:55
mriedemeven though it's entire existence in the first place is for ceilometer i believe15:55
cdentapparently ceilometer is now going to be using something to bypass nova ;)15:55
mriedemdragon added it way back when15:55
mriedemnice15:55
cdentyeah, chaos everywhere, cats and dogs, etc15:56
*** markvoelker has joined #openstack-nova15:57
*** claudiub has joined #openstack-nova15:59
openstackgerritPawel Koniszewski proposed openstack/nova: Add new configuration option live_migration_scheme  https://review.openstack.org/41081716:01
*** claudiub|2 has quit IRC16:02
*** pbandark has quit IRC16:02
*** lamt has joined #openstack-nova16:03
*** ijw has joined #openstack-nova16:06
*** salv-orlando has joined #openstack-nova16:09
*** mjura has quit IRC16:10
*** ijw has quit IRC16:11
openstackgerritDan Smith proposed openstack/nova: WIP: Test cellsv1  https://review.openstack.org/41814116:12
*** annegentle has joined #openstack-nova16:13
*** dtp has joined #openstack-nova16:13
*** tovin07 has quit IRC16:15
*** tblakes has quit IRC16:15
mriedemwow, sudafed + 2 cups of coffee and i feel like a changed man16:15
mriedemthanks drugs!16:16
*** bkopilov has quit IRC16:16
*** tblakes has joined #openstack-nova16:16
dansmithsudafed ftw16:16
openstackgerritMatt Riedemann proposed openstack/nova: Update notification for flavor  https://review.openstack.org/41384616:16
artomBreaking news: open source project leader secretly a drug addict.16:21
*** jaypipes has joined #openstack-nova16:21
cdentI think we'd be more surprised about an open source project leader that wasn't a drug addict16:21
*** salv-orl_ has joined #openstack-nova16:22
*** Jinxing has quit IRC16:23
bauzasI need to be AFK for a few hours but will be back around 2000UTC16:23
gibimriedem: regarding https://review.openstack.org/#/c/413846/ not only flavor.project but flavor.extra_specs is also missing from the emitted payload16:24
gibimriedem: but it is expected to be solved by the same bug fix16:25
bauzasin the meatime, I'd appreciate some reviews for https://review.openstack.org/#/c/392569/2516:25
bauzas^ placement API microversion for RP get16:25
*** salv-orlando has quit IRC16:25
bauzasfolks , \o16:25
markus_zmriedem: Hand on heart, the newton backports for fixing live-migration with serial console won't make it, right? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%2216:26
markus_zI will only cry a little if you say "yes"16:26
mriedemgibi: you forgot that flavor.extra_specs is loaded up by default when we pull the flavor from the database https://github.com/openstack/nova/blob/fd91a25324b7b7fed1f3f10c5b56668b20a170f4/nova/objects/flavor.py#L40216:26
*** bvanhav_ has quit IRC16:26
mriedemgibi: that one is the special snowflake16:27
mriedemmarkus_z: hand on whose heart? mine or yours?16:27
*** rama_y has quit IRC16:27
markus_zmine of course ;P (probably I got the idiom wrong)16:27
*** bkopilov has joined #openstack-nova16:28
*** mdrabe has quit IRC16:28
gibimriedem: but it is still not shows up in the flavor.create payload16:28
gibimriedem: which seems contradicting to me16:29
*** bvanhav_ has joined #openstack-nova16:29
mriedemmarkus_z: i just have reservations about that one given the size of the series, the conflicts, and all of the kerfuffle around that stuff in newton, like i thought there were other things going on related to that series in newton, - it was just really hard to sort out at the time16:29
mriedemmarkus_z: so i'd need someone that was much closer to how all of that went down in newton to vouch for it, like pkoniszewski16:29
mriedemgibi: well flavor create is different16:29
mriedemthe known issue in that reno is talking about the instance payload16:30
mriedemnot flavor.create16:30
mriedeminstance payload will have the flavor sub-object based on Flavor.get_by_*16:30
mriedemwhich loads extra_specs16:30
mriedemhmm, why are we running a functional py35 job when it's just going to always fail/16:31
mriedemseems like a waste of resources16:31
mriedemdims: ^? since gcb isn't around.16:31
gibimriedem: sorry I still not get it. neither flavor.create nor instance.<action> samples shows the flavor.extra_specs but your reference points out that it is loaded. This seems a bug to me16:32
markus_zpkoniszewski: Do you see a chance to have a look at those patches for stable newton? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%22 When there are concerns about the risks, I'm fully OK with abandoning them.16:32
mriedemgibi: https://review.openstack.org/#/c/413846/10/doc/notification_samples/instance-create-end.json16:33
mriedemthat has the extra_specs key in the payload16:33
mriedemit's just empty, because the fake flavor used in those tests don't have any extra specs :)16:33
nik__cdent, thank you for review! I fixed you comments16:33
*** nik__ is now known as snikitin_16:34
cdentcool, will go back and have a look16:34
gibimriedem: you are right my eyes ticked me16:35
mriedemgibi: https://github.com/openstack/nova/blob/fd91a25324b7b7fed1f3f10c5b56668b20a170f4/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L13816:35
gibimriedem: instance.<action> has the extra spec16:35
mriedemyeah, so if we added an extra spec to that fake flavor those instance samples would have it16:35
mriedemit might be a nice clarification to add that in a separate change16:35
mriedemhw:watchdog_action=disable or something16:36
*** mdrabe has joined #openstack-nova16:37
artommriedem, I guess you missed my question earlier about 2 rpc versions bumps but smaller patches vs 1 bump but bigger patch in the tagged attachment series. Any opinions, or shall I plow on with what I think is best and let code review sort it out later?16:37
gibimriedem: I agree, let's add that in a separate patch16:37
*** cdent has quit IRC16:38
gibimriedem: so what is left over the existing reno limitation is that the flavor.create doesn't have the projects and the extra_specs field but I assume that the lazy-load bugfix will solve that as well16:39
*** andreas_s has quit IRC16:39
mriedemgibi: do you feel the need to update that release note to get into that amount of detail?16:40
mriedemgibi: on flavor create i don't think we have access or extra specs anyway, as those are different APIs to update an existing flavor16:40
gibimriedem: I think the current patch can go in, worst case we add another reno if the bug fix does not solve the flavor.create16:41
mriedemgibi: ok but like i said, flavor.create won't have access or extra specs,16:41
mriedemthose aren't available when the flavor is created16:41
mriedemthose are later POST actions on an existing flavor16:41
pkoniszewskimarkus_z: yeah, added series to my TODO list for tomorrow16:41
mriedemso those would be update notifications16:41
mriedemartom: i think i'd prefer separate16:42
mriedemartom: that series is easier to review when we're dealing with bdms and vifs separately16:42
mriedembut that's just me16:42
artommriedem, I think I agree16:43
gibimriedem: I agree that the flavor.extra_spec is empty at flavor.create but that empty dict still should be in the emited flavor.create payload16:43
artommriedem, human time > computer time16:43
artomOr in this case, computer complexity16:43
* artom thanks mriedem for the validation :)16:43
markus_zpkoniszewski: Thanks16:43
*** roeyc has quit IRC16:44
diana_clarkemriedem, sdague, alex_xu: I'm not sure if you saw my last comment here, but I'm not sure this should be shipped as-is. Thoughts? https://review.openstack.org/#/c/398755/16:44
*** FL1SK has quit IRC16:45
sdaguediana_clarke: it would be nice to make that a better error message16:45
dansmithmriedem: sdague: do you know what tox target I should run in tempest to be like what the cells job gets in the gate? if I do -efull I get ~100 more tests than we run16:46
mriedemdiana_clarke: hmm, i hadn't seen that16:46
mriedemdansmith: you need to use the rc file in the nova tree16:46
mriedemdansmith: https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc16:47
mriedemsec,16:47
*** FL1SK has joined #openstack-nova16:47
mriedemthat is sourced here https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L60116:48
*** moshele has joined #openstack-nova16:48
mriedemdansmith: and then used here https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L78916:49
dansmithmriedem: do I need to re-run devstack for that or can I just run tempest and point it at the regex?16:49
dansmithah16:49
gibimriedem: I just cherry-picked the bugfix top of the flavor update patch and the notificaion sample test blows up that the extra_spec field of the flavore in None and the extra_specs field of the falvor payload cannot be none. So I think we have an issue here16:49
mriedemdansmith: are you talking local runs?16:49
dansmithmriedem: yeah16:49
mriedemdansmith: then i think you just source that rc file to get the env variable exported,16:49
mriedemand then tox -eall $DEVSTACK_GATE_TEMPEST_REGEX16:50
mriedemwell: tox -e all -- $DEVSTACK_GATE_TEMPEST_REGEX16:50
dansmithoh okay16:50
dansmithconfusing16:50
*** nherciu has quit IRC16:51
gibimriedem: worst case I have to bump the version of the falvor payload to make the extra_specs nullable16:51
*** cdent has joined #openstack-nova16:51
gibimriedem: is it still OK as a bugfix?16:51
mriedemdansmith: alternatively, just do what the cellsv1 job does16:51
mriedemhttp://logs.openstack.org/55/398755/18/check/gate-tempest-dsvm-cells-ubuntu-xenial/22625aa/console.html.gz#_2017-01-04_09_21_05_12244616:51
dansmithit's working with sourcing that thing16:51
dansmiththanks16:51
mriedemdiana_clarke: maybe create a bug to track the error message cruft16:52
mriedemgibi: hmm, 'extra_specs': fields.DictOfStringsField(), so that's not nullable in the Flavor object itself16:53
mriedemso i imagine that's why it's not nullable in the flavor payload either16:53
mriedemgibi: is the api sample test setting it to None?16:53
mriedembecause that would be an invalid test16:53
diana_clarkemriedem: okie dokie16:53
gibimriedem: checking..16:54
*** tblakes has quit IRC16:55
*** dikonoor has joined #openstack-nova16:57
*** tblakes has joined #openstack-nova16:57
gibimriedem: as far as I see all the api sample tests are using flavors that has the extra_specs set to someting. This is possible because flavor.extra_specs are returned by a different api resource than the normal flavor object16:57
gibimriedem: so in a normal GET os-flavors there is no extra_specs ever16:58
*** tblakes_ has joined #openstack-nova17:01
gibimriedem: and the GET os-flavor-extra-specs will call objects.Flavor.get_by_flavor_id17:01
*** tblakes has quit IRC17:02
*** tblakes_ is now known as tblakes17:02
melwittdansmith, mriedem: I was just doing like the gate to run locally, just have to put the regex in single quotes: tempest run --regex '<regex stuff>'17:02
gibimriedem: so that works the same way as the code that emits the instance.<action> notifications17:02
diana_clarkemriedem, sdague, alex_xu: https://bugs.launchpad.net/nova/+bug/165571017:03
openstackLaunchpad bug 1655710 in OpenStack Compute (nova) "Query parameter validation using json schema - error messages" [Undecided,New]17:03
*** READ10 has quit IRC17:04
mriedemthanks17:05
mriedemdiana_clarke: so do you get a 400 or a 500 now?17:05
mriedemi assume you still get a 400 response17:05
diana_clarkemriedem: not sure off the top of my head, but I can check17:06
gibimriedem: we can fix flavor.create by adding the extra_specs in the expected_attr here https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L49417:06
*** markus_z has quit IRC17:06
mriedemgibi: wouldn't that already be done because of this? https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L49017:07
openstackgerritavnish proposed openstack/python-novaclient: Removed unnecessary utf-8 encoding  https://review.openstack.org/41883917:07
mriedemextra_specs is in OPTIONAL_FIELDS17:07
gibimriedem: I think not because extra_specs is not in updates at https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L49117:07
*** Sukhdev has quit IRC17:08
*** ijw has joined #openstack-nova17:08
mriedemoh right i missed the in updates check17:08
gibimriedem: Is it OK for you if I just fix this as part of the bugfix https://review.openstack.org/#/c/415857/17:10
*** briancurtin has quit IRC17:11
mriedemgibi: that's dealing with aggregates, so i'd think it'd be part of a separate change in that series? i guess it's hard for me to say without knowing in detail what the actual change is going to be - i don't have the context in my head right now17:11
mriedemraj_singh: fyi i updated the devstack series that's testing the service user token stuff17:12
*** raunak has joined #openstack-nova17:12
mriedemi want to see how that runs before i +2 the bottom change in the nova series17:12
*** ijw has quit IRC17:12
*** jaypipes has quit IRC17:12
gibimriedem: right, that patch getting mixed up with different object fixes due to the same root cause17:12
*** nic has joined #openstack-nova17:12
*** pcaruana has quit IRC17:12
gibimriedem: I can split it into a series of patches17:12
*** Zealoussnow_ has joined #openstack-nova17:13
raj_singh_mriedem: I am using https://review.openstack.org/#/c/413232/ to test the series, which is dependent on the devstack patch as well. BTW it works17:13
*** LeoZhang has quit IRC17:13
raj_singh_mriedem: http://logs.openstack.org/32/413232/4/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/fcaf67a/console.html17:13
*** nic has quit IRC17:13
*** rmart04 has quit IRC17:13
*** jose-phillips has joined #openstack-nova17:13
raj_singh_tempest.api.compute.admin.test_live_migration.LiveBlockMigrationTestJSON.test_live_block_migration [412.934140s] ... ok17:13
raj_singh_I put a sleep of 400 and this test took more than 400 with service token enabled. I will upadate the commit msg on DNM patches to avoid confusion17:14
*** Swami_ has quit IRC17:14
*** FL1SK has quit IRC17:15
*** mlavalle has joined #openstack-nova17:16
*** FL1SK has joined #openstack-nova17:16
diana_clarkemriedem: yup, 400 b/c exceptions.ValidationError inherits from exceptions.Invalid which has 400 for code17:17
mriedemdiana_clarke: ok17:17
mriedemraj_singh: yup cool17:17
dansmithmelwitt: okay, running with the config as the gate does, I now get fewer tests, and many more fails17:19
*** tesseract has quit IRC17:20
*** snikitin__ has joined #openstack-nova17:20
mriedemraj_singh: actually that's kind of odd that it's passing in your test patch,17:20
mriedemraj_singh: because we don't currently run volume-backed live migration tests in the live migration job17:20
mriedemthose are skipped for now due to bugs17:21
*** moshele has quit IRC17:21
*** snikitin___ has joined #openstack-nova17:21
openstackgerritSujitha proposed openstack/nova: Add post hook script to run tempest with old n-api  https://review.openstack.org/40139517:21
raj_singh_:)17:21
*** zhangyujun has quit IRC17:21
*** unicell has quit IRC17:23
openstackgerritBalazs Gibizer proposed openstack/nova: Refactor InstancePayload creation  https://review.openstack.org/41848817:24
openstackgerritBalazs Gibizer proposed openstack/nova: Remove **kwargs passing in payload __init__  https://review.openstack.org/41848917:24
*** FL1SK has quit IRC17:24
*** yamahata has quit IRC17:25
openstackgerritSujitha proposed openstack/nova: Add post hook script to run tempest with old n-api  https://review.openstack.org/40139517:25
openstackgerritDan Smith proposed openstack/nova: WIP: Test cellsv1  https://review.openstack.org/41814117:28
*** zhangyujun has joined #openstack-nova17:28
*** FL1SK has joined #openstack-nova17:28
melwittdansmith: hm, odd. I guess I didn't make note of how many total tests vs gate when I was running it17:31
*** FL1SK has quit IRC17:32
*** FL1SK has joined #openstack-nova17:33
dansmithmelwitt: a lot of my fails are keystone and cinder, so maybe it's not as bad17:33
dansmithbut the total is still different17:33
openstackgerritSujitha proposed openstack/nova: Add post hook script to run tempest with old n-api  https://review.openstack.org/40139517:35
openstackgerritSujitha proposed openstack/nova: Do not merge: Test newly introduced zero-downtime-upgrade gate job  https://review.openstack.org/41906617:35
*** baoli has joined #openstack-nova17:36
*** snikitin_ has quit IRC17:36
*** snikitin___ is now known as snikitin_17:36
openstackgerritMatt Riedemann proposed openstack/nova: DNM: Test service token  https://review.openstack.org/41323217:36
openstackgerritSujitha proposed openstack/nova: Do not merge: Test newly introduced zero-downtime-upgrade gate job  https://review.openstack.org/41906617:37
openstackgerritMatt Riedemann proposed openstack/nova: xenapi: support the hotplug of a neutron port  https://review.openstack.org/36550517:38
*** lpetrut has quit IRC17:38
*** tjones has joined #openstack-nova17:39
mriedemGET jaypipes returns a 40417:42
mriedem:(17:42
mriedemGET/nova-core/jaypipes I guess i should say17:43
* mriedem waits for cdent and edleafe to pounce17:43
diana_clarkeI've been working on adding microversion 2.40 support to the python-openstack client, but it currently doesn't do anything special for any of the compute microversions...17:43
mriedemdiana_clarke: yeah that's kind of a losing battle right now i think17:43
mriedemdiana_clarke: we don't have any microversion support in osc yet17:43
cdentmriedem: ZOMG YOU ARE DOING IT COMPLETELY WRONG, HOW COULD YOU, DIE IN A FIRE17:43
edleafecdent: +117:44
diana_clarkemriedem: okay, so perhaps I'll just abort that mission. Or it could be my new baby ;)17:44
mriedemdiana_clarke: raising your human baby might be easier than getting that done :)17:44
diana_clarkeLOL17:44
*** eharney has joined #openstack-nova17:44
mriedemfar less crying17:44
openstackgerritSujitha proposed openstack/nova: Add post hook script to run tempest with old n-api  https://review.openstack.org/40139517:45
mriedemto be fair at some point we really need someone to actually dig into making microversions work in osc,17:46
mriedemi just haven't given it the attention it needs17:46
*** browne has joined #openstack-nova17:46
openstackgerritSarafraj Singh proposed openstack/nova: DNM: Test service token  https://review.openstack.org/41323217:48
*** slaweq has quit IRC17:48
*** slaweq has joined #openstack-nova17:49
*** FL1SK has quit IRC17:50
*** sudipto has quit IRC17:50
*** sudipto_ has quit IRC17:50
*** lucasagomes is now known as lucas-afk17:50
mriedemdiana_clarke: i added something to https://etherpad.openstack.org/p/nova-ptg-pike for compute microversions in osc17:50
*** jaypipes has joined #openstack-nova17:52
openstackgerritSujitha proposed openstack/nova: Adding tags field to InstancePayload  https://review.openstack.org/40722817:52
*** FL1SK has joined #openstack-nova17:53
*** aarefiev is now known as aarefiev_afk17:54
*** yamahata has joined #openstack-nova17:54
diana_clarkemriedem: thx!17:54
*** Swami has joined #openstack-nova17:54
*** tbachman has quit IRC17:55
*** avolkov has quit IRC17:57
diana_clarkemriedem: I added a bit of additional info. I won't be traveling to trumpland for the PTG, but I'll follow along via the etherpads.17:58
*** vipuls has joined #openstack-nova17:58
*** mvk has joined #openstack-nova17:59
*** ociuhandu has quit IRC18:01
*** ralonsoh has quit IRC18:03
*** dikonoor has quit IRC18:03
*** nic has joined #openstack-nova18:03
openstackgerritJiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd.  https://review.openstack.org/41692818:04
*** liverpooler has quit IRC18:05
*** tbachman has joined #openstack-nova18:05
*** ijw has joined #openstack-nova18:08
*** nic has quit IRC18:08
openstackgerritSarafraj Singh proposed openstack/nova: Add service_token for nova-neutron interaction  https://review.openstack.org/41039418:09
*** gszasz has quit IRC18:09
*** derekh has quit IRC18:10
*** liverpooler has joined #openstack-nova18:12
*** ijw has quit IRC18:13
*** claudiub|2 has joined #openstack-nova18:15
*** david-lyle has joined #openstack-nova18:15
*** david-lyle has quit IRC18:16
*** david-lyle has joined #openstack-nova18:16
*** unicell has joined #openstack-nova18:17
openstackgerritClaudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization  https://review.openstack.org/39850918:18
*** claudiub has quit IRC18:19
openstackgerritSarafraj Singh proposed openstack/nova: DNM: Test service token  https://review.openstack.org/41323218:24
*** kfarr has joined #openstack-nova18:25
*** rama_y has joined #openstack-nova18:25
*** lpetrut has joined #openstack-nova18:31
*** amotoki has quit IRC18:32
*** FL1SK has quit IRC18:32
*** dharinic is now known as dharinic|lunch18:36
*** adisky_ has quit IRC18:39
*** aslezil_ has quit IRC18:39
*** raj_singh_ has quit IRC18:41
openstackgerritJohn Garbutt proposed openstack/nova: Extract preallocate_for_instance  https://review.openstack.org/41887618:45
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance  https://review.openstack.org/41851218:45
openstackgerritJohn Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance  https://review.openstack.org/41851318:45
*** ociuhandu has joined #openstack-nova18:45
artomclaudiub|2, around? Can you take a look at https://review.openstack.org/#/c/415520/ and https://review.openstack.org/#/c/418100/? It's the virt driver patches for the continuation of device tagging, tagged attachment of nics and volumes18:46
*** owalsh is now known as owalsh-afk18:46
artomI'm not sure I have a specific ask as of yet, as their shape could change in response to reviews, but would something like that be doable for hyper-v?18:46
claudiub|2looking18:50
claudiub|2meanwhile, happy new year. :D18:50
*** owalsh-afk has quit IRC18:50
*** FL1SK has joined #openstack-nova18:51
artomclaudiub|2, thanks, same to you :) And happy orthodox christmas, if you're into that stuff ^_^18:51
claudiub|2hm, i am orthodox, but my christmas was in 25th dec. :D18:52
claudiub|2artom: question: shouldn't the configdrive be regenerated, to also include the new tag?18:52
artomclaudiub|2, yeah, but that's trickier, since we need to wait for the instance to be off18:53
artomWe can't just yank it from underneath the guest while it's running18:53
artomIt may be mounted, etc18:53
*** cdent has quit IRC18:53
*** kfarr has quit IRC18:54
*** dave-mccowan has quit IRC18:54
*** dave-mcc_ has joined #openstack-nova18:54
claudiub|2hm, how about regenerating it on interface_attach, but don't attach it yet, and then attach the new one on power_on?18:55
*** lpetrut has quit IRC18:55
openstackgerritBalazs Gibizer proposed openstack/nova: Improve flavor sample in notification sample tests  https://review.openstack.org/41908618:56
claudiub|2artom: also, i suppose you will want to merge this before the feature-freeze, right?18:56
artomclaudiub|2, in my wildest dreams, yeah :)18:56
artomBut I'm aware this is pretty last minute18:56
*** abalutoiu has joined #openstack-nova18:58
claudiub|2anyways. it is doable for hyper-v18:58
gibimriedem: I improved the flavor extra_specs part of the instance.<action> notification samples test with the watchdog device as you suggested https://review.openstack.org/#/c/41908618:58
openstackgerritDan Smith proposed openstack/nova: Don't bypass cellsv1 replication if cellsv2 maps are in place  https://review.openstack.org/41814118:58
*** aslezil_ has joined #openstack-nova18:58
claudiub|2i'll have to send up a patch for it then. :)18:58
claudiub|2doesn't seem like much to be done, imo. only that configdrive regeneration is a bit trickier18:59
claudiub|2artom: also, regarding device tagging, are pci devices tagged as well?19:00
artomclaudiub|2, don't think so...19:00
artomThere's no API for it19:00
*** cmartin has joined #openstack-nova19:01
*** satyar has quit IRC19:01
mriedemgibi: ok19:01
mriedemGET /nova-core/jaypipes -> 200!19:02
*** mtanino has joined #openstack-nova19:02
mriedemjaypipes: when you have 10 free minutes, could you please manhandle this? https://review.openstack.org/#/c/140045/19:02
mriedemclaudiub|2: while you're around there were some comments in https://review.openstack.org/#/c/282407/ - i'm not sure if they are all valid though, so would be cool to respond to those sooner than later19:03
* mriedem goes to plow snow19:04
dansmithmriedem: um, I think you mean personhandle19:05
mriedemdansmith: do women womanhandle?19:06
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597819:06
dansmithmriedem: I feel like this is a trap19:06
mriedemit is, and you haven't yet taken your corporate training course on this yet for 201719:06
dansmithtrue story19:06
*** dtp has quit IRC19:06
jaypipesmriedem: hey yeah, I'm on it. spurious network connectivity and human bandwidth issues all this week, sorry.19:08
*** briancurtin has joined #openstack-nova19:09
*** chyka has joined #openstack-nova19:11
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_attach notification  https://review.openstack.org/40199219:15
edleafeWe need HA Jay19:15
*** dave-mcc_ has quit IRC19:15
jaypipesedleafe: *I* need HA Jay :(19:17
*** vladikr has quit IRC19:17
* jroll has a hotspare Jay you can borrow19:18
* jroll hands JayF to jaypipes19:18
jaypipes:)19:18
claudiub|2artom: i see. :)19:19
JayFI don't think you could even lift me, much less hand me over to someone ;)19:19
claudiub|2mriedem: replied. :)19:19
claudiub|2mriedem: although, not exactly sure how to treat a certain comment: Andrey Volkov was asking if there could be a way to warn operators that if they want to use hyper-v vnuma, they'd have to disable the numa spanning on the host. is there any other better way to do this (except release notes)?19:21
openstackgerritGábor Antal proposed openstack/nova: Transform instance.volume_detach notification  https://review.openstack.org/40867619:24
*** satyar has joined #openstack-nova19:24
*** dharinic|lunch is now known as dharinic19:26
*** amotoki has joined #openstack-nova19:32
*** krtaylor has quit IRC19:37
*** vladikr has joined #openstack-nova19:38
EmilienMI think I found something "weird" in nova-compute & nova-placement19:38
EmilienMif you start n-cpu *before* n-placement, n-compute will never retry to register the placement services19:39
diana_clarkedansmith: ^ was that what you were talking about yesterday? That you were going to change to keep retrying? Ignore me if I've missunderstood.19:41
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Ensure to_xml always returns an ASCII string  https://review.openstack.org/40238219:41
openstackgerritLee Yarwood proposed openstack/nova: libvirt: utils.get_disk return the target dev of the root device  https://review.openstack.org/40271619:41
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect when to pivot  https://review.openstack.org/39973519:41
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Make guest.BlockDevice only use the target dev of a disk  https://review.openstack.org/40216319:41
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Wait for abort_job to complete when not resizing  https://review.openstack.org/38244919:41
diana_clarkedansmith: perhaps this patch? https://review.openstack.org/#/c/418590/19:42
dansmithEmilienM: diana_clarke yep19:43
EmilienMoh wow19:43
EmilienMbut it's not only scheduler19:43
EmilienMit's also compute19:43
dansmithEmilienM: it's only compute, and it was intentional, but a little naive19:43
EmilienMhttps://review.openstack.org/#/c/418590/4/nova/scheduler/client/report.py is run by nova-compute?19:43
dansmithEmilienM: yes19:43
EmilienMnice19:44
EmilienMthanks!19:44
dansmithEmilienM: it's the scheduler *client* which is the client of the scheduler, which would be compute19:44
EmilienMwe need this patch :D19:44
dansmithEmilienM: I wrote it for you dude :)19:44
EmilienMdansmith: yeah? I just found the bug in tripleo :-P19:44
EmilienMwe deploy placement but in some random cases, it was not starting.19:45
*** salv-orl_ has quit IRC19:45
dansmithEmilienM: I did, specifically to make the upgrade case a little more graceful19:45
dansmithEmilienM: planning to backport that to newton19:45
*** jaosorior has quit IRC19:46
EmilienMdansmith++19:46
EmilienMdansmith: do you think https://review.openstack.org/#/c/418590/ can merge today?19:47
*** bvanhav__ has joined #openstack-nova19:47
*** bvanhav_ has quit IRC19:49
*** voelzmo has joined #openstack-nova19:51
dansmithEmilienM: you should hassle someone that can do something about it19:52
dansmithEmilienM: jaypipes once was +2 on that and may grant your wish19:52
EmilienMjaypipes: in case you have some time to review, please: https://review.openstack.org/#/c/418590/19:56
*** jaosorior has joined #openstack-nova19:56
*** morgan_ is now known as morgan19:58
*** nic has joined #openstack-nova20:01
mriedemclaudiub|2: you could emit a warning in the logs...20:01
mriedemclaudiub|2: i'd also get it into the numa docs in the admin guide: http://docs.openstack.org/admin-guide/compute-cpu-topologies.html - so tag the patch with DocImpact and leave a comment in the commit message about updating those docs?20:02
diana_clarkemriedem: I wasn't sure what to work on instead, so I am going to keep playing with microversions & osc. We'll see how it goes. https://review.openstack.org/#/c/419108/20:02
mriedemdansmith: are you going to tweek the docs in a follow up to https://review.openstack.org/#/c/418590/ ?20:03
mriedemi.e. http://git.openstack.org/cgit/openstack/nova/tree/doc/source/placement.rst?id=f5d7ea52c681611c2d85f344da643f9f630d1ef9#n10820:03
dansmithmriedem: tbh, it's not high on my list considering time available and the rush to unfsck the current stuff20:04
dansmithmriedem: if you think it's a priority for right now then I will,20:04
dansmithbut if not, maybe we could find someone interested in doing it?20:04
diana_clarkedansmith, mriedem: I can try and do it.20:05
*** tbachman has quit IRC20:05
dansmithdiana_clarke: cool, thanks20:05
mriedemi don't really see how spamming the logs fixes the complaints i was hearing from the red hat people yesterday,20:06
mriedembut if it's something you guys have agreed it makes your lives easier somehow, then ok20:06
mriedemthat's all, re: why i'm not rushing it in20:06
dansmithmriedem: spamming the logs doesn't fix anything for us, continuing to try does20:07
openstackgerritDan Smith proposed openstack/nova: Make metadata server know about cell mappings  https://review.openstack.org/41796220:07
openstackgerritDan Smith proposed openstack/nova: WTFWIP: Multicell support for instance listing  https://review.openstack.org/39677520:07
openstackgerritDan Smith proposed openstack/nova: Don't bypass cellsv1 replication if cellsv2 maps are in place  https://review.openstack.org/41814120:07
mriedemok so in a point release rhops rolls out creds to the newton computes and restarts nova-compute on them, right? which as long as they keep trying to connect to placement, it just happens whenever rhosp rolls out the placement service in an update for newton? i guess i just figured the restart that you need to do for the computes would come after placement is available, at which point we don't need the continual retry20:09
*** dtp has joined #openstack-nova20:09
dansmithmriedem: we can't really enforce that ordering,20:09
dansmithin general, and for a couple different approaches to the upgrade20:10
mriedemok so you/we might avoid an unnecessary restart of the computes depending on the order of the upgrade20:10
mriedemwhich is the point20:10
*** moshele has joined #openstack-nova20:10
mriedemw/o the patch, you could have deployed creds updates to the computes, restarted them, then rolled out placement, at which point you have to go back and restart all of the computes again20:11
mriedemand it's that potential 2nd mass restart that is the point of the patch (trying to avoid it)20:11
dansmithat least that yeah20:12
mriedemok20:13
mriedemi think i can smell what you're cooking now20:13
dansmithso, that and this gets us a little more nag spam in the logs to make sure that people running newton see that this is required before they have kicked off their upgradeand decided to skim the release notes once things are broken20:14
dansmithwhich goes back to our not so awesome messaging, retroactive "oh and also..." thing in the point release, etc20:14
*** dtp has quit IRC20:21
EmilienMdansmith: look at what we have to do when we missed nova cells v2 in newton https://review.openstack.org/#/c/419121/1/elements/puppet-stack-config/puppet-stack-config.pp20:21
jaypipesmriedem, claudiub|2: hyper-v osvif patch reviewed.20:22
*** satyar has quit IRC20:22
dansmithEmilienM: what about it?20:23
edleafejaypipes: got a resource provider question if you have a few minutes20:23
EmilienMdansmith: I just wanted to show you the complexity of things about nova cells v2 upgrade from newton to ocata20:23
dansmithEmilienM: to make me feel bad?20:23
EmilienMdansmith: no :-) so you can maybe give feedback20:24
EmilienMand yes, hopefully you feel very sad20:24
EmilienMbecause we missed it in tripleo/newton, now we have to do that thing20:25
edleafejaypipes: if I have a reference to a provider, say 'rp', and call rp.set_inventory(inv), that 'rp' reference is now stale, since it now 1 generation behind the DB.20:25
openstackgerritDiana Clarke proposed openstack/nova: docs - Connect to placement service & retries  https://review.openstack.org/41912320:25
EmilienMjaypipes: thx for the +w :-)20:25
edleafejaypipes: my question is: should methods that change generation also update the generation field in the current object?20:26
claudiub|2jaypipes: ty, will upload a new ps shortly. :D20:26
diana_clarkedansmith: It's hard to write about things you don't know much about, but there goes ;) ^^20:26
dansmithdiana_clarke: looks good tome20:26
dansmithalso to me20:26
dansmithdiana_clarke: mriedem will -1 one time to eff up my stats, but otherwise I think it covers all the things20:27
*** browne has quit IRC20:28
mriedemdansmith: EmilienM: jaypipes: postmortem https://review.openstack.org/#/c/418590/ +1 fwiw with a more detailed recap of my understanding of the issue the patch is trying to avoid/fix20:29
mriedemi just got distracted with PTG talk in another channel20:29
dansmithmriedem: it's not dead yet.. it's like peri-mortem20:30
EmilienMmriedem: ack20:30
EmilienMI like the idea of https://review.openstack.org/#/c/418590/ being backported fwiw20:30
EmilienMI'm pretty sure it will really help deployers20:30
jaypipesedleafe: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L30620:31
jaypipesEmilienM: np :)20:31
edleafejaypipes: that's a static method that only updates the DB20:32
mriedemEmilienM: so in retrospec, i guess we're going to need to figure out a working relationship on how to communicate to the tripleo guys that even though something is optional now, you're going to want to bake it into your tooling, because release notes aren't going to cut it20:32
edleafejaypipes: the object that called it is now stale20:32
mriedem*retrospect20:32
*** voelzmo has quit IRC20:32
*** nic has quit IRC20:32
EmilienMmriedem: I do agree20:32
mriedemi.e. if nova has to touch grenade for ANY reason, someone from tripleo needs to know20:32
*** browne has joined #openstack-nova20:33
mriedems/tripleo/any of the 40 openstack deployment projects/20:33
*** voelzmo has joined #openstack-nova20:33
dansmithmriedem: I was just about to say, it's in the grenade history20:33
jaypipesedleafe: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L37220:33
jaypipesedleafe: the object that called it is self.20:33
edleafejaypipes: IOW, if you make two set_inventory calls with the same object, the second will throw a ConcurrentUpdateDetected20:33
dansmithmriedem: tempted to start up a twitter account and git commit hook :)20:33
mriedemso i'll add something to the nova docs in our review guide - albeit chances are low anyone will read that20:33
mriedemdansmith: you or me?20:34
dansmithmriedem: I'm tempted20:34
jaypipesedleafe: I don't believe that is true.20:34
EmilienMmriedem: we are building a grenade like job in tripleo, where for the first time we'll test in gate upgrades with complex deployments20:34
EmilienMmriedem: it might be useful to have the job in experimental pipeline in nova (one day)20:34
edleafejaypipes: I'm getting it in some of my tests.20:34
openstackgerritClaudiu Belu proposed openstack/nova: Adds Hyper-V OVS ViF driver  https://review.openstack.org/14004520:35
edleafejaypipes: let me see if there is somewhere else it is getting changed20:35
mriedemEmilienM: well the thing is, placement and cells v2 were optional in newton,20:36
mriedemso we had to explicitly enable those in specific jobs in newton to test them out20:37
*** bvanhav__ has quit IRC20:37
mriedemEmilienM: which takes the forethought to know you have to toggle those bits, we're missing that as part of our process right now for non-devstack/grenade things20:37
*** voelzmo has quit IRC20:37
*** krtaylor has joined #openstack-nova20:38
*** jaosorior has quit IRC20:39
*** snikitin__ has quit IRC20:42
*** snikitin_ has quit IRC20:42
*** nklenke_ has quit IRC20:42
*** dtp_ has joined #openstack-nova20:43
*** nic has joined #openstack-nova20:44
mriedemdiana_clarke: i'll approve the doc update once https://review.openstack.org/#/c/418590/ is merged20:47
diana_clarkemriedem: thanks, I probably should have has a depends on20:48
diana_clarkehad20:48
openstackgerritEric Fried proposed openstack/nova: Introduce base PowerVM driver  https://review.openstack.org/39128820:48
openstackgerritMatt Riedemann proposed openstack/nova: docs - Connect to placement service & retries  https://review.openstack.org/41912320:49
mriedemdiana_clarke: done20:49
openstackgerritEric Fried proposed openstack/nova: WIP(2): Introduce base PowerVM driver (disk drv)  https://review.openstack.org/40940120:50
edleafejaypipes: found it. _check_capacity_exceeded() creates new RP objects, and these are the ones whose generation gets updated instead of the originals20:50
edleafejaypipes: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1078-L108120:50
openstackgerritEric Fried proposed openstack/nova: WIP(3): Introduce base PowerVM driver (console)  https://review.openstack.org/40940220:51
dansmithdiana_clarke: mriedem: thanks20:51
EmilienMdiana_clarke: fyi, depends-on works for inter-projects connection, but for the same project, you better to use git rebase20:52
mriedemdansmith: dash doesn't support multiple changes for the -c option does it...?20:52
mriedemEmilienM: it's fine either way in this case20:53
EmilienMright, just fyi again20:53
dansmithmriedem: dunno, I never use that20:54
dansmithmriedem: patches accepted :)20:54
openstackgerritEric Fried proposed openstack/nova: WIP(4): Introduce base PowerVM driver (cfg drv)  https://review.openstack.org/40940420:54
diana_clarkeEmilienM: Oh right. I did know that, but I just drank some flu meds so I'm a bit groggy ;)20:54
EmilienMdiana_clarke: oops :-)20:54
mdrabedansmith: Is something enforcing having cells v2 in ocata?20:54
dansmithmdrabe: various bits of cellsv2 have been required each release recently20:55
mriedemmdrabe: yes, a db schema migration20:55
dansmithmdrabe: there is more in ocata sure20:55
*** xyang1 has joined #openstack-nova20:55
mriedemmdrabe: you can't upgrade the api db schema without doing some setup first20:55
openstackgerritJay Pipes proposed openstack/nova: placement: adds REST API for nested providers  https://review.openstack.org/38480720:56
openstackgerritJay Pipes proposed openstack/nova: placement: allow filter providers in tree  https://review.openstack.org/37721520:56
openstackgerritJay Pipes proposed openstack/nova: pci: add uuid field to PciDevice object  https://review.openstack.org/41476820:56
openstackgerritJay Pipes proposed openstack/nova: placement: SRIOV PF devices as child providers  https://review.openstack.org/41476920:56
openstackgerritJay Pipes proposed openstack/nova: placement: update client to set parent provider  https://review.openstack.org/38569320:56
openstackgerritJay Pipes proposed openstack/nova: placement: add nested resource providers  https://review.openstack.org/37713820:56
jaypipesedleafe: le sigh... yeah, line 1169 needs to be changed to:20:58
mdrabemriedem: What if you're starting fresh on ocata?20:58
jaypipes rp.generation = _increment...20:58
openstackgerritLee Yarwood proposed openstack/nova: libvirt: utils.get_disk return the target dev of the root device  https://review.openstack.org/40271620:59
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Use the mirror element to detect when to pivot  https://review.openstack.org/39973520:59
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Make guest.BlockDevice only use the target dev of a disk  https://review.openstack.org/40216320:59
mriedemmdrabe: same deal20:59
mriedemmdrabe: you still have to have a cell0 cell mapping record in the api db20:59
mriedemactually...20:59
dansmithmriedem: the blocker doesn't enforce that it's done first,20:59
mriedemi think the db schema migration ends early20:59
dansmithbut you still need that20:59
mriedemif there are no flavors in the api db then it's a noop20:59
mriedemmdrabe: we're also working on this nova-status upgrade check CLI for checking this stuff at any time prior to install/upgrade21:00
mriedemjust haven't integrated that yet into the grenade tooling we have21:00
*** jamielennox|away is now known as jamielennox21:01
*** lyarwood_ is now known as lyarwood21:02
*** dtp_ is now known as dtp21:02
*** rama_y has quit IRC21:05
*** rama_y_ has joined #openstack-nova21:05
mdrabemriedem: So say I didn't have any cells in my deployment down the road, things are certainly not going to work right? The cells requirement isn't just for want?21:06
*** tbachman has joined #openstack-nova21:06
openstackgerritJay Pipes proposed openstack/nova: pci: add uuid field to PciDevice object  https://review.openstack.org/41476821:07
openstackgerritJay Pipes proposed openstack/nova: placement: SRIOV PF devices as child providers  https://review.openstack.org/41476921:07
openstackgerritJay Pipes proposed openstack/nova: placement: update client to set parent provider  https://review.openstack.org/38569321:07
dansmithmdrabe: you can have a cell of one, of course, if that's what you mean21:07
dansmithmdrabe: everyone will be transitioning to a single-cell deployment all the time21:07
*** dimtruck is now known as zz_dimtruck21:07
mdrabedansmith: But if I had none like we could in newton that's not gonna fly?21:08
dansmithmdrabe: I'm not sure what you mean.. "one" cell is just a single row in the database -- nothing else is different21:08
dansmithmdrabe: meaning, moving from a newton deployment to an ocata one with just one cell is just adding a row to the database, which says your existing stuff is "cell 1"21:09
dansmithmdrabe: no extra services or configuration like normal cells (i.e. cellsv1) requires21:10
mdrabedansmith: But if I didn't have a single cell could I still deploy?21:11
dansmithmdrabe: no, there's no such thing as "no cells" anymore21:11
dansmithmdrabe: well, you could deploy with no cells, but you could never create any instances.. :P21:12
*** smatzek has quit IRC21:13
mdrabebecause the instance has to be built to a specific cell21:14
*** jwcroppe has quit IRC21:14
dansmithyes21:14
openstackgerritEd Leafe proposed openstack/nova: Fix missing RP generation update  https://review.openstack.org/41913721:16
edleafejaypipes: The fix ^^21:16
jaypipesedleafe: cheers man21:17
jaypipesmriedem: I'm good with https://review.openstack.org/#/c/140045/ now.21:17
jaypipesfeel free to wallaby.21:17
*** tbachman has quit IRC21:18
jaypipesedleafe, reviewed.21:19
*** moshele has quit IRC21:19
*** cdent has joined #openstack-nova21:19
edleafejaypipes: the functional test that was failing was in the later patch that removed Allocation.create()21:20
openstackgerritVasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441321:20
edleafejaypipes: I'll see what I can add that would be close21:21
jaypipesedleafe: cool, thanks Ed.21:21
cdentmore stuff borked?21:21
edleafecdent: one effect of removing Allocation.create() is that AllocationList.create_all() is much more stringent in its checking21:22
edleafecdent: and that uncovered a slew of ResourceProvider references that were stale as far as their generation was concerned21:23
cdentin?21:23
*** tbachman has joined #openstack-nova21:24
edleafecdent: see https://review.openstack.org/419137 for what I fixed21:24
cdentcool thanks21:24
*** salv-orlando has joined #openstack-nova21:25
edleafecdent: the tests in nova/tests/functional/db/test_resource_provider.py were creating allocations before there was any inventory21:25
edleafecdent: Allocation.create() allowed that. AllocationList.create_all() doesn't.21:26
*** zz_dimtruck is now known as dimtruck21:27
cdentgyres with gyres or something21:29
*** lpetrut has joined #openstack-nova21:33
openstackgerritJay Pipes proposed openstack/nova: pci: add uuid field to PciDevice object  https://review.openstack.org/41476821:34
openstackgerritJay Pipes proposed openstack/nova: placement: SRIOV PF devices as child providers  https://review.openstack.org/41476921:34
*** Jeffrey4l_ has joined #openstack-nova21:34
*** Jeffrey4l has quit IRC21:35
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Adds vNUMA implementation  https://review.openstack.org/28240721:36
*** rtheis has quit IRC21:38
*** lpetrut has quit IRC21:38
*** abalutoiu has quit IRC21:41
mriedemclaudiub|2: i was just about done commenting on that one :)21:42
dansmithmriedem: melwitt: don't mind me, just bragging: https://review.openstack.org/#/c/418141/21:43
claudiub|2ha, oups. :D21:43
*** nic has quit IRC21:44
*** jaosorior has joined #openstack-nova21:44
openstackgerritEd Leafe proposed openstack/nova: Fix missing RP generation update  https://review.openstack.org/41913721:44
mriedemclaudiub|2: comments posted21:44
mriedemdansmith: nice21:44
mriedemdansmith: i can see your nippies from here21:45
melwitt hah, yay21:45
mriedemi guess that should have been in a PM21:45
dansmithhaha21:45
openstackgerritVasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441321:46
*** cleong has quit IRC21:49
bauzasmriedem: jaypipes: could you maybe look at https://review.openstack.org/#/c/392569/ soon ?21:51
bauzasgiven it's adding a microversion, I'd make sure that this change could be quickly merged21:52
bauzasedleafe had some comments, but I could follow-up the change21:52
*** krtaylor has quit IRC21:54
*** dave-mccowan has joined #openstack-nova21:54
bauzasmriedem: do you know if we have a problem with the Xen 3rd party CI?21:54
bauzaswrt https://review.openstack.org/#/c/365505/21:54
bauzasI'm waiting to see it there21:54
*** thorst has quit IRC21:54
mriedembauzas: it was good before21:54
mriedembauzas: i've rechecked https://review.openstack.org/#/c/416797/ which runs the attach/detach interfaces tests on that patch21:55
mriedembauzas: and yeah on the placement API change, i'm trying to wrap up some of the hyperv patches and then can move on21:55
mriedembauzas: we should also get alex_xu and sdague to help review https://review.openstack.org/#/c/392569/21:56
bauzasmriedem: cool by me21:56
*** nic has joined #openstack-nova21:56
bauzasmriedem: last run of XenServer for the above change was -1 with http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/05/365505/22/check/dsvm-tempest-neutron-network/e2bfe3d/21:56
bauzasfor PS2221:57
mriedembauzas: that was some devstack setup issue http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/05/365505/22/check/dsvm-tempest-neutron-network/e2bfe3d/logs/devstacklog.txt.gz21:57
*** thorst has joined #openstack-nova21:57
*** ijw has joined #openstack-nova21:57
bauzasoh right21:57
bauzasmeh21:58
mriedemhttp://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/run_tests.log was happy on 1/921:58
*** dtp has quit IRC21:58
mriedembauzas: if you want to +2 and leave the +W to me that's fine too21:58
mriedemgiven time of day i mean21:59
bauzasmriedem: just looking at the XenServer change21:59
bauzasI mean the tempest test removal21:59
bauzaswell, the exception removal rather21:59
bauzasmriedem: how can we be sure that https://review.openstack.org/#/c/416797/ is run by XenServer CI ?22:00
bauzasI'm verifying that22:00
*** tblakes has quit IRC22:01
bauzasactually looking at the regex here http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/run_tests.log22:01
*** thorst has quit IRC22:02
bauzasawesome {2} tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces [349.753425s] ... ok22:02
bauzasmriedem: okay, +Wing it22:02
bauzasbecause of ^22:02
mriedemhttp://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/logs/devstacklog.txt.gz22:02
mriedem2017-01-10 03:15:31.180 | + functions-common:git_clone:566           :   git show --oneline 2017-01-10 03:15:31.194 | 823b053 xenapi: support the hotplug of a neutron port22:03
mriedemtells you which nova change it's testing22:03
mriedemwhich is our happy friend the vif hotplug patch22:03
mriedembtw, easy tangential patch to the flavor notification series https://review.openstack.org/#/c/419086/22:04
mriedembut i'm going to mark that bp complete since the update patch is merged22:04
*** tblakes has joined #openstack-nova22:10
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/41597822:11
mriedemclaudiub|2: tweak needed here :) https://review.openstack.org/#/c/140045/22:13
mriedemor i'll just do it if you're trying to end your day22:13
dansmith"end your day" .. sounds ominous22:14
* cdent ends his day22:15
*** cdent has quit IRC22:15
claudiub|2mriedem: i'm not trying to end my days. :D22:16
mriedemif you're trying to rest your weary head22:16
*** jaypipes has quit IRC22:16
mriedemthe plurality is significant22:17
claudiub|2still, VirtualInterfaceUnplugException does have a reason formatting argument, while the VirtualInterfacePlugException doesn't.22:17
claudiub|2i was expecting both of them to have a reason argument.22:18
claudiub|2https://github.com/openstack/nova/blob/f55815b2f90b934801a88e10bf750876b0587328/nova/exception.py#L13222:18
zzzeekmriedem: dumb Q as I am clueless.  does the nova.task_log table grow unbounded and if so is that part of truncate/cleanup22:20
mriedemclaudiub|2: yeah i just noticed the same and left a comment to correct that unplug type22:20
mriedemzzzeek: let me look22:20
*** salv-orl_ has joined #openstack-nova22:22
mriedemzzzeek: so it's going to be unbounded,22:23
mriedemruns in a periodic task as long as CONF.instance_usage_audit is True22:23
openstackgerritClaudiu Belu proposed openstack/nova: Adds Hyper-V OVS ViF driver  https://review.openstack.org/14004522:24
mriedemzzzeek: the archive command should move it from the nova.task_log table to the nova.shadow_task_log table22:24
mriedemzzzeek: but nothing deletes those records as far as i know22:24
zzzeekmriedem: OK so on a highly used nova DB i might have 30-40M rows in this thing, at least in the shadow table22:24
mriedemsure22:25
mriedemmy understanding of this thing is it's for the REST API to pull these audit logs which ceilometer consumes22:25
zzzeekmriedem: right, but the DB size is never mitigated22:25
mriedemhttp://developer.openstack.org/api-ref/compute/#server-usage-audit-log-os-instance-usage-audit-log22:25
mriedemzzzeek: nope22:26
*** salv-orlando has quit IRC22:26
mriedemneither is...anything except for nova.tags and anything in the nova_api db22:26
zzzeekmriedem: and...not anytime soon, but people might someday like that DB tables like these don't grow to be billions of rows?  or that's how they want it22:26
mriedemall of the old tables in the nova db use the soft delete mixin22:26
zzzeekmriedem: right but task_log seems to be, accumulate rows just for doing things, so it's a fast grower22:27
mriedemzzzeek: i think most operators have their own purge scripts, i know there are some in the osops tooling repos22:27
zzzeekmriedem: OK22:27
mriedemthere was a bp at one point to add a purge cli to nova22:27
mriedemfor not archiving, no shadow tables, but delete things over a certain age22:27
mriedemlast i remember someone from red hat was looking into implementing that22:28
mriedemi'll try to find it22:28
mriedemzzzeek: v22:28
mriedemhttps://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/purge-deleted-instances-cmd.html22:28
*** markvoelker has quit IRC22:29
mriedem^ only addresses instances though, so that'd have to be tweaked to handle task_log22:29
mriedemor to add something to nova to self-clean that table22:29
mriedemlike only keep audit logs under a certain age22:29
*** baoli has quit IRC22:30
openstackgerritJay Pipes proposed openstack/nova: placement: create aggregate map in report client  https://review.openstack.org/40730922:30
*** markvoelker has joined #openstack-nova22:32
mriedemzzzeek: what's even funnier/sadder about that thing,22:32
mriedemzzzeek: is the periodic task emits a notification, which someone (ceilometer) is consuming and probably throwing that data into a time series db22:33
*** annegentle has quit IRC22:33
mriedemso nova storing it is probably much less relevant, except for nova's own REST API22:33
*** markvoelker has quit IRC22:34
zzzeekmriedem: im on a search to figure out how big people's databases might be reasonably getting22:34
*** markvoelker has joined #openstack-nova22:34
openstackgerritDan Smith proposed openstack/nova: Make metadata server know about cell mappings  https://review.openstack.org/41796222:35
openstackgerritDan Smith proposed openstack/nova: Multicell support for instance listing  https://review.openstack.org/39677522:35
mriedemzzzeek: at one point not too long ago dansmith had a fairly large db for testing the archive command22:36
* dansmith crosses all crossable appendages22:36
mriedemdansmith: did that have task_log stuff in it?22:36
dansmithmriedem: probably22:36
dansmithit's in a bug somewhere22:36
mriedemmikal might be able to get his hands on some large db with task_log in it since that feature was all added by rax people22:37
dansmiththe dump I mean22:37
mriedemzzzeek: or jhesketh22:37
mriedemif i had 1% more energy right now i might email the operators list asking if anyone uses the nova REST API for this feature22:38
*** jheroux has quit IRC22:38
*** markvoelker_ has joined #openstack-nova22:39
*** markvoelker has quit IRC22:39
zzzeekmriedem: yeah i can manufacture fake large DBs with a script here am more wondering, if i went into the nova DB of some huge customer, how big would these tables be.  because migrating from mariadb5.5 -> 10.1 requires a dump+ restore22:39
zzzeekand for tens of millions of rows it's a hit22:39
mriedemzzzeek: so i'd ask jhesketh b/c he has some large dbs for just that kind of question22:40
mriedemzzzeek: otherwise we'd have to ask some godaddy or cern people probably22:40
zzzeekmriedem: thanks22:40
*** kberger has joined #openstack-nova22:41
*** marst has quit IRC22:44
mriedemdansmith: so i guess on https://review.openstack.org/#/c/416585/ we have some kind of weird catch-22 because the cellsv1 job fails on that patch, but passes on your nova one that uses that22:46
mriedemhttp://logs.openstack.org/85/416585/8/experimental/gate-tempest-dsvm-cells-ubuntu-xenial/e9f1fe9/console.html#_2017-01-11_19_25_38_19100522:47
dansmithmriedem: we might be able to merge the nova patch before the devstack one, if you want to try22:47
dansmithor we just queue the nova one up and let the devstack one gate it, which I think is probably fine given the stability of things right now22:47
dansmithyour call22:47
dansmithI needed the depends-on to test them together22:48
mriedemso we don't need the depends-on to make the nova one pass?22:48
dansmithI don't know22:48
dansmithwe might not22:48
dansmithprobably don't22:48
mriedemok, well the cells v1 job is gating of nova and other repos (not devstack though sadly) so if we land the devstack change first, it's going to break things until the nova one lands22:49
mriedems/of/on/22:49
openstackgerritSarafraj Singh proposed openstack/nova: Add service_token for nova-glance interaction  https://review.openstack.org/41263422:49
dansmithyeah, but we can get them both in the gate together22:49
dansmithbut I'll remove it and let is run to see22:49
*** catintheroof has quit IRC22:50
mriedemok22:50
openstackgerritDan Smith proposed openstack/nova: Make metadata server know about cell mappings  https://review.openstack.org/41796222:51
openstackgerritDan Smith proposed openstack/nova: Multicell support for instance listing  https://review.openstack.org/39677522:51
openstackgerritDan Smith proposed openstack/nova: Don't bypass cellsv1 replication if cellsv2 maps are in place  https://review.openstack.org/41814122:51
*** catintheroof has joined #openstack-nova22:51
*** cmartin has quit IRC22:51
*** catintheroof has quit IRC22:55
openstackgerritSujitha proposed openstack/nova: Adding auto_disk_config field to InstancePayload  https://review.openstack.org/41918522:56
*** Swami has quit IRC22:56
openstackgerritSujitha proposed openstack/nova: Adding auto_disk_config field to InstancePayload  https://review.openstack.org/41918522:58
*** dtp has joined #openstack-nova23:00
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Adds vNUMA implementation  https://review.openstack.org/28240723:00
*** krtaylor has joined #openstack-nova23:02
*** tblakes has quit IRC23:04
*** raunak has quit IRC23:05
*** mdrabe has quit IRC23:06
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Adds vNUMA implementation  https://review.openstack.org/28240723:07
*** nic has quit IRC23:07
claudiub|2well, i'm out. thanks for the reviews!23:07
*** efried has quit IRC23:09
mriedemzzzeek: http://lists.openstack.org/pipermail/openstack-operators/2017-January/012425.html23:09
*** burt has quit IRC23:09
zzzeekmriedem: wow thanks!23:10
*** dave-mccowan has quit IRC23:11
*** slaweq has quit IRC23:11
*** lamt has quit IRC23:11
*** mlavalle has quit IRC23:14
*** claudiub|2 has quit IRC23:16
*** raunak has joined #openstack-nova23:18
openstackgerritSujitha proposed openstack/nova: Adding auto_disk_config field to InstancePayload  https://review.openstack.org/41918523:20
openstackgerritJay Pipes proposed openstack/nova: Expose a REST API for a specific list of RPs  https://review.openstack.org/39256923:29
*** jaypipes has joined #openstack-nova23:30
jaypipesedleafe: good pickup on the location of the except block in https://review.openstack.org/#/c/392569/. Pushed a fix for that. Please re-review at your earliest.23:30
jaypipesmriedem: ^ is mostly written by me so I don't want to +2 it.23:31
jaypipesif you and dansmith could tackle, that would be great.23:31
*** markvoelker_ has quit IRC23:32
mriedemjaypipes: yeah it's on my list, would also like alex_xu and sdague to look23:32
jaypipesmriedem: thx23:33
jaypipesmriedem: going through the feature freeze review list now, trying to get reviews done.23:33
*** JoseMello has quit IRC23:35
*** edmondsw has quit IRC23:36
mriedemcool we've made some solid progress today, 1 merged and have 3 in the queue23:36
*** pradk has quit IRC23:38
*** markvoelker has joined #openstack-nova23:40
*** FL1SK has quit IRC23:41
*** dimtruck is now known as zz_dimtruck23:47
*** thorst_ has joined #openstack-nova23:48
*** salv-orl_ has quit IRC23:52
*** thorst_ has quit IRC23:53
*** jaosorior has quit IRC23:54
*** xyang1 has quit IRC23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!