| *** dimtruck is now known as zz_dimtruck | 00:00 | |
| *** ducttape_ has joined #openstack-nova | 00:01 | |
| *** hongbin has quit IRC | 00:12 | |
| *** nic has quit IRC | 00:21 | |
| *** zz_dimtruck is now known as dimtruck | 00:24 | |
| *** mtanino has quit IRC | 00:25 | |
| *** Zer0Byte__ has quit IRC | 00:28 | |
| *** amoralej|off has quit IRC | 00:28 | |
| *** ajo has quit IRC | 00:29 | |
| *** jschwarz has quit IRC | 00:29 | |
| *** dmellado has quit IRC | 00:29 | |
| *** markmc has quit IRC | 00:30 | |
| *** ltomasbo has quit IRC | 00:30 | |
| *** ducttape_ has quit IRC | 00:40 | |
| *** _gryf_ has joined #openstack-nova | 00:41 | |
| *** coreywright_ has joined #openstack-nova | 00:42 | |
| *** dillaman has joined #openstack-nova | 00:42 | |
| *** mariusv_ has joined #openstack-nova | 00:45 | |
| *** hfu has joined #openstack-nova | 00:45 | |
| *** ssurana has quit IRC | 00:45 | |
| *** _gryf has quit IRC | 00:45 | |
| *** lbeliveau_ has quit IRC | 00:45 | |
| *** coreywright has quit IRC | 00:45 | |
| *** kragniz has quit IRC | 00:45 | |
| *** jdillaman has quit IRC | 00:45 | |
| *** mariusv has quit IRC | 00:45 | |
| *** kragniz has joined #openstack-nova | 00:47 | |
| *** lbeliveau has joined #openstack-nova | 00:48 | |
| *** uu has quit IRC | 00:50 | |
| *** yingjun has joined #openstack-nova | 00:53 | |
| *** Kevin_Zheng has joined #openstack-nova | 00:55 | |
| *** ajo has joined #openstack-nova | 00:56 | |
| *** tuanluong has joined #openstack-nova | 00:56 | |
| *** uu has joined #openstack-nova | 00:56 | |
| *** dimtruck has quit IRC | 00:57 | |
| *** scottda has quit IRC | 00:57 | |
| *** pkholkin has quit IRC | 00:57 | |
| *** tlian has quit IRC | 00:58 | |
| *** hoangcx has joined #openstack-nova | 00:59 | |
| *** ltomasbo has joined #openstack-nova | 01:01 | |
| *** amoralej has joined #openstack-nova | 01:01 | |
| *** dmellado has joined #openstack-nova | 01:03 | |
| *** phuongnh has joined #openstack-nova | 01:05 | |
| *** zz_dimtruck has joined #openstack-nova | 01:07 | |
| *** scottda has joined #openstack-nova | 01:07 | |
| *** pkholkin has joined #openstack-nova | 01:07 | |
| *** markmc has joined #openstack-nova | 01:07 | |
| *** tlian has joined #openstack-nova | 01:11 | |
| *** uu has quit IRC | 01:12 | |
| *** uu has joined #openstack-nova | 01:16 | |
| *** mtanino has joined #openstack-nova | 01:16 | |
| *** roeyc has quit IRC | 01:17 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Notifications on flavor operations https://review.openstack.org/398171 | 01:19 |
|---|---|---|
| openstackgerrit | Li Yingjun proposed openstack/nova: Update notification for flavor https://review.openstack.org/413846 | 01:19 |
| *** amoralej has quit IRC | 01:19 | |
| *** ajo has quit IRC | 01:20 | |
| *** ltomasbo has quit IRC | 01:20 | |
| *** markmc has quit IRC | 01:20 | |
| *** dmellado has quit IRC | 01:21 | |
| *** jamesdenton has quit IRC | 01:23 | |
| *** zz_dimtruck is now known as dimtruck | 01:24 | |
| *** markmc has joined #openstack-nova | 01:27 | |
| *** ducttape_ has joined #openstack-nova | 01:27 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix misleading port delete description https://review.openstack.org/410582 | 01:30 |
| *** dmellado has joined #openstack-nova | 01:30 | |
| *** ltomasbo has joined #openstack-nova | 01:31 | |
| *** ajo has joined #openstack-nova | 01:32 | |
| *** jschwarz has joined #openstack-nova | 01:32 | |
| *** jamesdenton has joined #openstack-nova | 01:32 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix metadata update in race condition https://review.openstack.org/411327 | 01:33 |
| *** diogogmt has joined #openstack-nova | 01:35 | |
| *** amoralej has joined #openstack-nova | 01:38 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Fix typo https://review.openstack.org/413634 | 01:38 |
| *** catintheroof has quit IRC | 01:42 | |
| *** ssurana has joined #openstack-nova | 01:43 | |
| *** ssurana has quit IRC | 01:44 | |
| *** tlian has quit IRC | 01:45 | |
| *** wlhc has joined #openstack-nova | 01:47 | |
| *** yufei has joined #openstack-nova | 01:48 | |
| *** lbeliveau_ has joined #openstack-nova | 01:49 | |
| *** raunak has quit IRC | 01:51 | |
| *** yamahata has quit IRC | 01:53 | |
| *** unicell has quit IRC | 01:59 | |
| *** Jeffrey4l has joined #openstack-nova | 02:00 | |
| *** dimtruck is now known as zz_dimtruck | 02:00 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix BDM JSON-Schema validation https://review.openstack.org/413453 | 02:04 |
| *** liusheng has quit IRC | 02:05 | |
| *** yuntongjin has joined #openstack-nova | 02:09 | |
| *** yingjun has quit IRC | 02:16 | |
| *** eharney has quit IRC | 02:22 | |
| *** yingjun has joined #openstack-nova | 02:24 | |
| *** sreeram_v has joined #openstack-nova | 02:31 | |
| *** sreeram_v has quit IRC | 02:35 | |
| *** jamesdenton has quit IRC | 02:37 | |
| *** jamesden_ has joined #openstack-nova | 02:37 | |
| *** baoli has joined #openstack-nova | 02:40 | |
| *** liusheng has joined #openstack-nova | 02:44 | |
| *** wlhc has quit IRC | 02:44 | |
| *** wlhc has joined #openstack-nova | 02:45 | |
| openstackgerrit | Spencer Yu proposed openstack/nova: [1/3]Replace six.iteritems() with .items() https://review.openstack.org/413431 | 02:45 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Update hostname of server when updating its name https://review.openstack.org/404583 | 02:49 |
| *** wlhc has quit IRC | 02:53 | |
| *** mriedem has joined #openstack-nova | 02:53 | |
| *** wlhc has joined #openstack-nova | 02:53 | |
| *** baoli has quit IRC | 03:04 | |
| *** ducttape_ has quit IRC | 03:05 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Update notification for flavor https://review.openstack.org/413846 | 03:09 |
| openstackgerrit | Li Yingjun proposed openstack/nova: Notifications on flavor operations https://review.openstack.org/398171 | 03:09 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876 | 03:10 |
| *** mtanino has quit IRC | 03:10 | |
| Kevin_Zheng | ping mriedem | 03:13 |
| mriedem | Kevin_Zheng: hi | 03:13 |
| Kevin_Zheng | mriedem: hi, while you are online, what do you think about this? https://review.openstack.org/#/c/411327/ | 03:14 |
| mriedem | the commit message is a bit sparse :) would be nice to provide an explanation of what the bug is and how the patch fixes it | 03:15 |
| mriedem | i'm also wondering how we can test this | 03:16 |
| Kevin_Zheng | https://bugs.launchpad.net/nova/+bug/1650188 | 03:18 |
| openstack | Launchpad bug 1650188 in OpenStack Compute (nova) "Concurrently update server's metadata are handled badly" [Medium,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu) | 03:18 |
| *** ducttape_ has joined #openstack-nova | 03:19 | |
| Kevin_Zheng | Ah, I have reported it here | 03:19 |
| Kevin_Zheng | quite detailed | 03:19 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Fix python3 issues with devstack https://review.openstack.org/413789 | 03:21 |
| mriedem | Kevin_Zheng: yeah i just read through that | 03:21 |
| mriedem | rpodolyaka_afk has a decent idea about etags, cdent might have some input there too | 03:22 |
| mriedem | Kevin_Zheng: https://en.wikipedia.org/wiki/HTTP_ETag | 03:22 |
| Kevin_Zheng | hmm thanks I will read it | 03:23 |
| Kevin_Zheng | have we ever used it somewhere？ | 03:24 |
| *** liusheng has quit IRC | 03:25 | |
| mriedem | Kevin_Zheng: not in nova but it was discussed when they were designing the REST API for the placement service, | 03:25 |
| mriedem | the resource provider model has a generation id that works similarly I believe | 03:25 |
| *** liusheng has joined #openstack-nova | 03:25 | |
| Kevin_Zheng | hmm, I will try to learn it | 03:25 |
| mriedem | i.e. you have to pass the generation id in with the request and if it's not the latest by the time we commit the data, it's a 409 and forces the client to fetch the latest version of the data (with the updated generation id) and then resubmit the request | 03:25 |
| Kevin_Zheng | hm | 03:26 |
| mriedem | Kevin_Zheng: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L197 | 03:26 |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/nova: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/413885 | 03:27 |
| Kevin_Zheng | ah thats useful | 03:28 |
| Kevin_Zheng | thanks alot | 03:28 |
| *** ducttape_ has quit IRC | 03:29 | |
| mriedem | yw | 03:30 |
| *** shuquan has joined #openstack-nova | 03:31 | |
| *** amotoki has joined #openstack-nova | 03:36 | |
| *** links has joined #openstack-nova | 03:42 | |
| *** yingjun has quit IRC | 03:43 | |
| *** yingjun has joined #openstack-nova | 03:44 | |
| *** zz_dimtruck is now known as dimtruck | 03:45 | |
| *** gouthamr has quit IRC | 03:47 | |
| *** lbeliveau_ has quit IRC | 03:50 | |
| *** tjones has joined #openstack-nova | 03:52 | |
| *** tjones has left #openstack-nova | 03:53 | |
| *** diogogmt has quit IRC | 03:54 | |
| *** psachin has joined #openstack-nova | 04:00 | |
| *** hongbin has joined #openstack-nova | 04:05 | |
| *** shuquan_ has joined #openstack-nova | 04:06 | |
| *** shuquan has quit IRC | 04:08 | |
| *** yingjun has quit IRC | 04:09 | |
| *** nicolasbock has quit IRC | 04:09 | |
| *** pbandark has joined #openstack-nova | 04:09 | |
| *** yamahata has joined #openstack-nova | 04:10 | |
| *** Daisy has joined #openstack-nova | 04:16 | |
| *** Daisy has quit IRC | 04:16 | |
| *** Daisy has joined #openstack-nova | 04:17 | |
| *** Daisy has quit IRC | 04:17 | |
| *** mdnadeem has joined #openstack-nova | 04:20 | |
| *** tuanluong has quit IRC | 04:23 | |
| *** phuongnh has quit IRC | 04:24 | |
| *** phuongnh has joined #openstack-nova | 04:24 | |
| *** ducttape_ has joined #openstack-nova | 04:29 | |
| *** ducttape_ has quit IRC | 04:34 | |
| *** ssurana has joined #openstack-nova | 04:38 | |
| *** phuongnh has quit IRC | 04:41 | |
| *** mtreinish has quit IRC | 04:44 | |
| *** mtreinish has joined #openstack-nova | 04:45 | |
| *** sreeram_v has joined #openstack-nova | 04:47 | |
| *** yingjun has joined #openstack-nova | 04:47 | |
| *** hongbin has quit IRC | 04:58 | |
| *** tiendc has joined #openstack-nova | 05:00 | |
| *** yingjun has quit IRC | 05:00 | |
| *** ayogi has joined #openstack-nova | 05:01 | |
| *** moshele has joined #openstack-nova | 05:01 | |
| *** tiendc has quit IRC | 05:01 | |
| *** tiendc has joined #openstack-nova | 05:02 | |
| *** moshele has quit IRC | 05:08 | |
| *** yufei has quit IRC | 05:13 | |
| *** ssurana has quit IRC | 05:19 | |
| *** ratailor has joined #openstack-nova | 05:23 | |
| *** diga has joined #openstack-nova | 05:23 | |
| *** ducttape_ has joined #openstack-nova | 05:31 | |
| *** prateek has joined #openstack-nova | 05:31 | |
| *** ducttape_ has quit IRC | 05:35 | |
| *** yingjun has joined #openstack-nova | 05:41 | |
| openstackgerrit | gengchc2 proposed openstack/nova-specs: Fix a typo in server-count-api.rst,etc https://review.openstack.org/413916 | 05:44 |
| *** unicell has joined #openstack-nova | 05:47 | |
| *** amotoki has quit IRC | 05:47 | |
| *** ssurana has joined #openstack-nova | 05:52 | |
| *** stvnoyes1 has joined #openstack-nova | 05:55 | |
| *** zhangjl has joined #openstack-nova | 05:55 | |
| *** stvnoyes has quit IRC | 05:57 | |
| *** Sukhdev has joined #openstack-nova | 06:08 | |
| *** salv-orlando has joined #openstack-nova | 06:12 | |
| *** pcaruana has joined #openstack-nova | 06:17 | |
| *** tuanluong has joined #openstack-nova | 06:21 | |
| *** hfu has quit IRC | 06:28 | |
| *** hfu has joined #openstack-nova | 06:29 | |
| *** ayogi has quit IRC | 06:32 | |
| *** sridharg has joined #openstack-nova | 06:34 | |
| *** lpetrut has joined #openstack-nova | 06:36 | |
| *** ayogi has joined #openstack-nova | 06:37 | |
| *** armax has joined #openstack-nova | 06:42 | |
| *** dimtruck is now known as zz_dimtruck | 06:44 | |
| *** Sukhdev has quit IRC | 06:45 | |
| *** psachin has quit IRC | 06:47 | |
| *** psachin has joined #openstack-nova | 06:47 | |
| *** raunak has joined #openstack-nova | 06:47 | |
| *** openstackgerrit has quit IRC | 06:48 | |
| *** tesseract has joined #openstack-nova | 06:58 | |
| *** tesseract has quit IRC | 06:58 | |
| *** tesseract has joined #openstack-nova | 06:59 | |
| *** tesseract is now known as Guest47337 | 06:59 | |
| *** hoangcx has quit IRC | 07:02 | |
| *** openstackgerrit has joined #openstack-nova | 07:04 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Update hostname of server when updating its name https://review.openstack.org/404583 | 07:04 |
| *** salv-orlando has quit IRC | 07:04 | |
| *** vtech has joined #openstack-nova | 07:05 | |
| *** mjura has joined #openstack-nova | 07:07 | |
| *** amotoki has joined #openstack-nova | 07:08 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Create migration context for live-migration https://review.openstack.org/413555 | 07:10 |
| *** mjura has quit IRC | 07:14 | |
| *** mjura has joined #openstack-nova | 07:14 | |
| *** ssurana has quit IRC | 07:14 | |
| openstackgerrit | jeck proposed openstack/nova: [TrivialFix] Fix comment typo error https://review.openstack.org/413940 | 07:15 |
| openstackgerrit | jeck proposed openstack/nova: [TrivialFix] Fix comment and function name typo error https://review.openstack.org/413945 | 07:24 |
| *** armax has quit IRC | 07:24 | |
| *** GB21 has joined #openstack-nova | 07:25 | |
| *** amotoki_ has joined #openstack-nova | 07:26 | |
| *** fragatina has joined #openstack-nova | 07:28 | |
| *** amotoki has quit IRC | 07:28 | |
| *** fragatina has quit IRC | 07:28 | |
| *** fragatina has joined #openstack-nova | 07:29 | |
| *** raunak has quit IRC | 07:30 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix BDM JSON-Schema validation https://review.openstack.org/413453 | 07:32 |
| *** ducttape_ has joined #openstack-nova | 07:32 | |
| *** ayogi has quit IRC | 07:34 | |
| *** Oku_OS-away is now known as Oku_OS | 07:34 | |
| *** ayogi has joined #openstack-nova | 07:35 | |
| *** ducttape_ has quit IRC | 07:37 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix BDM JSON-Schema validation https://review.openstack.org/413453 | 07:37 |
| *** lpetrut has quit IRC | 07:38 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix BDM JSON-Schema validation https://review.openstack.org/413453 | 07:41 |
| *** ftersin has joined #openstack-nova | 07:43 | |
| *** _gryf_ is now known as _gryf | 07:45 | |
| *** yuntongjin has quit IRC | 07:47 | |
| *** ihrachys has joined #openstack-nova | 07:47 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-nova | 07:48 | |
| openstackgerrit | Vasyl Saienko proposed openstack/nova: Fix error if free_disk_gb is None in ironic_host_manager https://review.openstack.org/413631 | 07:48 |
| *** yuntongjin has joined #openstack-nova | 07:50 | |
| *** raunak has joined #openstack-nova | 07:53 | |
| *** rdo has quit IRC | 07:53 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Use JSON-Schema to validate query parameters for keypairs API https://review.openstack.org/398755 | 07:54 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571 | 07:54 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Adds support for versioned schema validation for query parameters https://review.openstack.org/389003 | 07:54 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Fix BDM JSON-Schema validation https://review.openstack.org/413453 | 07:55 |
| gmann | oomichi: alex_xu can one of you check this - https://review.openstack.org/#/c/407886/ | 07:56 |
| *** rdo has joined #openstack-nova | 07:57 | |
| *** takashin has left #openstack-nova | 07:59 | |
| oomichi | gmann: ^^^ is for you as a trade :) | 08:00 |
| oomichi | gmann: one question about your patch: | 08:03 |
| *** raunak has quit IRC | 08:03 | |
| oomichi | gmann: That will allow us to change REST API input when changing objects, and it would be easy to forget the effect because such patch doesn't seem to change REST API layer | 08:04 |
| oomichi | gmann: We are already doing the same thing on the other parameters, and this patch also is fine maybe | 08:05 |
| oomichi | this is just a small question before that | 08:05 |
| *** raunak has joined #openstack-nova | 08:05 | |
| *** ihrachys has quit IRC | 08:07 | |
| *** yufei has joined #openstack-nova | 08:08 | |
| oomichi | Kevin_Zheng: alex_xu: gmann: I have a small idea about https://review.openstack.org/#/c/402372 | 08:09 |
| oomichi | can you check it? | 08:09 |
| gmann | oomichi: yea thats true, and this way we can catch any accidental changes in object side | 08:09 |
| *** raunak has quit IRC | 08:10 | |
| Kevin_Zheng | Actually I did that in the client, but not sure we cover all the cases, I mean your idea about https://review.openstack.org/#/c/402372 | 08:11 |
| *** zenoway has joined #openstack-nova | 08:11 | |
| *** yufei has quit IRC | 08:12 | |
| openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 08:13 |
| openstackgerrit | Vasyl Saienko proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | 08:14 |
| *** GB21 has quit IRC | 08:18 | |
| *** rnoriega has quit IRC | 08:18 | |
| *** jschlueter has quit IRC | 08:19 | |
| *** yufei has joined #openstack-nova | 08:19 | |
| *** raunak has joined #openstack-nova | 08:19 | |
| *** jschlueter has joined #openstack-nova | 08:20 | |
| *** rnoriega has joined #openstack-nova | 08:23 | |
| oomichi | Kevin_Zheng: yeah, both seems better than current behavior(just ignoring) anyways. | 08:23 |
| *** brault|away is now known as brault | 08:23 | |
| *** raunak has quit IRC | 08:25 | |
| *** hoangcx has joined #openstack-nova | 08:27 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Use bdm destination type allowed values hard coded https://review.openstack.org/407886 | 08:29 |
| *** amotoki_ has quit IRC | 08:30 | |
| *** vtech has quit IRC | 08:30 | |
| *** salv-orlando has joined #openstack-nova | 08:30 | |
| gmann | oomichi: done ^^ | 08:31 |
| gmann | oomichi: also your patch looks good, just waiting for jenkin | 08:31 |
| *** shuquan has joined #openstack-nova | 08:32 | |
| *** xinliang has quit IRC | 08:32 | |
| *** ducttape_ has joined #openstack-nova | 08:33 | |
| *** shuquan_ has quit IRC | 08:34 | |
| *** salv-orlando has quit IRC | 08:35 | |
| *** vtech has joined #openstack-nova | 08:37 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/413967 | 08:37 |
| *** ducttape_ has quit IRC | 08:38 | |
| *** GB21 has joined #openstack-nova | 08:38 | |
| *** lpetrut has joined #openstack-nova | 08:40 | |
| *** jschlueter has quit IRC | 08:42 | |
| *** rnoriega has quit IRC | 08:42 | |
| *** slagle has quit IRC | 08:43 | |
| *** rnoriega has joined #openstack-nova | 08:43 | |
| *** GB21 has quit IRC | 08:44 | |
| *** salv-orlando has joined #openstack-nova | 08:44 | |
| *** jschlueter has joined #openstack-nova | 08:44 | |
| *** slagle has joined #openstack-nova | 08:45 | |
| alex_xu | gmann: oomichi yea, that can avoid to change the API accidential | 08:46 |
| *** sahid has joined #openstack-nova | 08:49 | |
| *** xinliang has joined #openstack-nova | 08:50 | |
| *** sahid has quit IRC | 08:51 | |
| *** ralonsoh has joined #openstack-nova | 08:52 | |
| *** lpetrut has quit IRC | 08:54 | |
| *** lpetrut has joined #openstack-nova | 08:54 | |
| *** GB21 has joined #openstack-nova | 08:56 | |
| *** slaweq has quit IRC | 08:57 | |
| *** slaweq has joined #openstack-nova | 08:58 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** ralonsoh_ has joined #openstack-nova | 09:00 | |
| *** zzzeek has joined #openstack-nova | 09:00 | |
| *** amotoki has joined #openstack-nova | 09:02 | |
| *** ralonsoh has quit IRC | 09:02 | |
| *** slaweq has quit IRC | 09:03 | |
| *** GB21 has quit IRC | 09:04 | |
| *** slaweq has joined #openstack-nova | 09:05 | |
| oomichi | alex_xu: how about having pep8 rule for blocking importing the other layer definition into json-schema definition? | 09:07 |
| *** lpetrut has quit IRC | 09:08 | |
| *** wlhc has quit IRC | 09:11 | |
| *** yuntongjin has quit IRC | 09:14 | |
| *** hfu has quit IRC | 09:15 | |
| *** yuntongjin has joined #openstack-nova | 09:15 | |
| *** amotoki has quit IRC | 09:15 | |
| *** hfu has joined #openstack-nova | 09:15 | |
| *** markvoelker has quit IRC | 09:20 | |
| *** GB21 has joined #openstack-nova | 09:22 | |
| *** lucas-afk is now known as lucasagomes | 09:23 | |
| alex_xu | oomichi: if pep8 can help on that, that will be great | 09:25 |
| *** sreeram_v has quit IRC | 09:30 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Check destination_type when booting with bdm provided https://review.openstack.org/402372 | 09:30 |
| *** yassine has joined #openstack-nova | 09:32 | |
| *** yassine is now known as Guest52965 | 09:32 | |
| *** ralonsoh_ is now known as ralonsoh | 09:33 | |
| openstackgerrit | Tovin Seven proposed openstack/python-novaclient: Add profiling support to novaclient https://review.openstack.org/254699 | 09:38 |
| *** psachin has quit IRC | 09:41 | |
| *** roeyc has joined #openstack-nova | 09:41 | |
| openstackgerrit | Vasyl Saienko proposed openstack/nova: Fix error if free_disk_gb is None in ironic_host_manager https://review.openstack.org/413631 | 09:42 |
| *** hfu has quit IRC | 09:42 | |
| *** yingjun has quit IRC | 09:44 | |
| *** GB21 has quit IRC | 09:51 | |
| *** amotoki has joined #openstack-nova | 09:51 | |
| *** hfu has joined #openstack-nova | 09:52 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for VmWare https://review.openstack.org/413967 | 09:53 |
| *** hfu has quit IRC | 09:59 | |
| *** hfu has joined #openstack-nova | 09:59 | |
| *** jaosorior has joined #openstack-nova | 09:59 | |
| *** tiendc has quit IRC | 10:01 | |
| *** derekh has joined #openstack-nova | 10:03 | |
| *** hfu has quit IRC | 10:04 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for VmWare https://review.openstack.org/413967 | 10:06 |
| *** hieulq has quit IRC | 10:07 | |
| *** psachin has joined #openstack-nova | 10:07 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for VmWare https://review.openstack.org/413967 | 10:11 |
| *** hoangcx has quit IRC | 10:12 | |
| *** yamahata has quit IRC | 10:14 | |
| *** amotoki has quit IRC | 10:20 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for VmWare https://review.openstack.org/413967 | 10:21 |
| *** markvoelker has joined #openstack-nova | 10:21 | |
| *** markvoelker has quit IRC | 10:26 | |
| *** lpetrut has joined #openstack-nova | 10:27 | |
| *** zhangjl has left #openstack-nova | 10:33 | |
| *** gongysh has joined #openstack-nova | 10:39 | |
| pkoniszewski | tdurakov: hi, can you take a look at my response there https://review.openstack.org/#/c/244489/ ? | 10:49 |
| *** vtech has quit IRC | 10:49 | |
| *** vtech has joined #openstack-nova | 10:52 | |
| *** shuquan has quit IRC | 10:54 | |
| *** ihrachys has joined #openstack-nova | 10:57 | |
| *** dmp has joined #openstack-nova | 11:05 | |
| *** ducttape_ has joined #openstack-nova | 11:05 | |
| *** brault_ has joined #openstack-nova | 11:06 | |
| *** rfolco has joined #openstack-nova | 11:06 | |
| dmp | I am trying to write extention to base nova driver. Is there any developer guideline to write new nova extention ? | 11:06 |
| bauzas | dmp: what do you mean by extension ? | 11:08 |
| bauzas | dmp: a new nova virt driver? | 11:08 |
| dmp | yes | 11:08 |
| *** brault has quit IRC | 11:10 | |
| dmp | bauzas: triying to write a new virt driver, which will privide start/stop instance, live migrate instance, spawn new instance etc etc | 11:10 |
| bauzas | dmp: some information can be found http://docs.openstack.org/developer/nova/feature_classification.html | 11:10 |
| bauzas | dmp: there is also the support matrix http://docs.openstack.org/developer/nova/support-matrix.html | 11:11 |
| bauzas | dmp: that tells you which operations you need to support | 11:11 |
| bauzas | dmp: the idea is that it would be an out-of-tree driver until you get a proper 3rd-party CI that would vote against any change | 11:12 |
| bauzas | dmp: once you have a stable out-of-tree driver and the confidence that you have a stable CI that catches any regression that could occur, then you could ask for inclusion in the nova tree | 11:13 |
| bauzas | dmp: but that's a long road | 11:13 |
| dmp | bauzas: thanks for the info. i understand 3rd-party CI is must. do we have any CI how to page ? | 11:15 |
| bauzas | dmp: you wanna know how to setup a 3rd-party CI ? | 11:15 |
| bauzas | sec | 11:15 |
| dmp | bauzas: yes.. how to setup CI, i did followed one link to setup CI for our new cinder driver but not sure with that work for nova as well | 11:17 |
| bauzas | dmp: that's basically the same, only the job will potentially be different if you run different Tempest tests | 11:18 |
| dmp | bauzas: i followed http://docs.openstack.org/infra/system-config/third_party.html for cinder | 11:18 |
| bauzas | yeah that one | 11:18 |
| bauzas | dmp: out of curiousity, which driver are you going to implement ? | 11:19 |
| *** yuntongjin has quit IRC | 11:20 | |
| bauzas | either way, I need to drop off | 11:20 |
| bauzas | bbiab (out to lunch) | 11:21 |
| dmp | bauzas: you can see our cinder driver at https://review.openstack.org/#/c/382097/ | 11:21 |
| dmp | bausas: similarly i am working on nova virt driver extention | 11:22 |
| *** zenoway has quit IRC | 11:25 | |
| *** ducttape_ has quit IRC | 11:26 | |
| *** vtech has quit IRC | 11:26 | |
| *** salv-orlando has quit IRC | 11:29 | |
| *** smatzek has joined #openstack-nova | 11:30 | |
| *** sreeram_v has joined #openstack-nova | 11:31 | |
| *** gszasz has joined #openstack-nova | 11:31 | |
| *** ociuhandu has quit IRC | 11:33 | |
| *** yuntongjin has joined #openstack-nova | 11:33 | |
| *** ducttape_ has joined #openstack-nova | 11:35 | |
| *** sreeram_v has quit IRC | 11:36 | |
| *** sdague has joined #openstack-nova | 11:36 | |
| *** nicolasbock has joined #openstack-nova | 11:38 | |
| dims | sdague : this one will help with py35 effort too - https://review.openstack.org/#/c/413789/ | 11:38 |
| *** salv-orlando has joined #openstack-nova | 11:43 | |
| *** zenoway has joined #openstack-nova | 11:44 | |
| sdague | dims: already approved that | 11:46 |
| dims | ah thanks! | 11:47 |
| *** ducttape_ has quit IRC | 11:52 | |
| *** pbandark has quit IRC | 12:03 | |
| *** tuanluong has quit IRC | 12:05 | |
| *** gongysh has quit IRC | 12:08 | |
| *** hfu has joined #openstack-nova | 12:10 | |
| *** yuntongjin has quit IRC | 12:10 | |
| *** yuntongjin1 has joined #openstack-nova | 12:10 | |
| *** bkopilov has joined #openstack-nova | 12:12 | |
| *** sridharg has quit IRC | 12:13 | |
| *** sreeram_v has joined #openstack-nova | 12:17 | |
| *** bkopilov has quit IRC | 12:18 | |
| *** fragatina has quit IRC | 12:20 | |
| *** ociuhandu has joined #openstack-nova | 12:20 | |
| *** fragatina has joined #openstack-nova | 12:21 | |
| *** markvoelker has joined #openstack-nova | 12:22 | |
| *** pbandark has joined #openstack-nova | 12:25 | |
| *** salv-orlando has quit IRC | 12:26 | |
| *** fragatina has quit IRC | 12:27 | |
| *** markvoelker has quit IRC | 12:28 | |
| *** dmp has quit IRC | 12:32 | |
| *** ayogi has quit IRC | 12:33 | |
| *** sreeram_v has quit IRC | 12:41 | |
| *** fragatina has joined #openstack-nova | 12:41 | |
| *** diga has quit IRC | 12:43 | |
| *** lucasagomes is now known as lucas-hungry | 12:47 | |
| openstackgerrit | Jay Jahns proposed openstack/nova: Add connection pool size to vSphere settings https://review.openstack.org/414085 | 12:47 |
| *** derekh has quit IRC | 12:49 | |
| *** ratailor has quit IRC | 12:49 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for VmWare rebased https://review.openstack.org/414088 | 12:51 |
| *** ducttape_ has joined #openstack-nova | 12:52 | |
| openstackgerrit | jichenjc proposed openstack/nova: WIP: add zvm migration object https://review.openstack.org/414090 | 12:56 |
| *** ducttape_ has quit IRC | 12:57 | |
| *** gouthamr has joined #openstack-nova | 13:00 | |
| *** ayogi has joined #openstack-nova | 13:06 | |
| *** slaweq has quit IRC | 13:07 | |
| *** bhagyashris has quit IRC | 13:09 | |
| *** vladikr has quit IRC | 13:12 | |
| *** pbandark has quit IRC | 13:12 | |
| *** psachin has quit IRC | 13:12 | |
| *** hfu has quit IRC | 13:18 | |
| *** links has quit IRC | 13:18 | |
| *** gouthamr has quit IRC | 13:19 | |
| *** gouthamr has joined #openstack-nova | 13:20 | |
| openstackgerrit | jichenjc proposed openstack/nova: make 2.31 microversion wording better https://review.openstack.org/410191 | 13:20 |
| *** psachin has joined #openstack-nova | 13:20 | |
| *** JoseMello_ has joined #openstack-nova | 13:25 | |
| *** eglynn has joined #openstack-nova | 13:26 | |
| *** JoseMello_ is now known as JoseMello | 13:26 | |
| *** lucas-hungry is now known as lucasagomes | 13:26 | |
| *** esberglu has joined #openstack-nova | 13:27 | |
| *** esberglu has quit IRC | 13:27 | |
| *** esberglu has joined #openstack-nova | 13:27 | |
| *** amoralej is now known as amoralej|lunch | 13:28 | |
| *** yufei has quit IRC | 13:29 | |
| *** hfu has joined #openstack-nova | 13:30 | |
| sdague | alex_xu: I had one final question on https://review.openstack.org/#/c/393205/19 which is about why is there a new policy bit | 13:33 |
| *** pbandark has joined #openstack-nova | 13:36 | |
| *** mdnadeem has quit IRC | 13:37 | |
| *** matrohon has joined #openstack-nova | 13:38 | |
| *** markvoelker has joined #openstack-nova | 13:48 | |
| *** matrohon has quit IRC | 13:56 | |
| *** shuquan has joined #openstack-nova | 13:56 | |
| *** shuquan has quit IRC | 13:57 | |
| *** lamt has joined #openstack-nova | 13:59 | |
| *** armax has joined #openstack-nova | 14:03 | |
| *** vtech has joined #openstack-nova | 14:05 | |
| *** matrohon has joined #openstack-nova | 14:05 | |
| *** vtech has quit IRC | 14:07 | |
| *** baoli has joined #openstack-nova | 14:15 | |
| *** baoli has quit IRC | 14:15 | |
| *** baoli has joined #openstack-nova | 14:16 | |
| *** ducttape_ has joined #openstack-nova | 14:19 | |
| *** prateek has quit IRC | 14:21 | |
| *** matrohon has quit IRC | 14:22 | |
| *** eharney has joined #openstack-nova | 14:30 | |
| *** smatzek has quit IRC | 14:30 | |
| *** dave-mccowan has joined #openstack-nova | 14:32 | |
| *** ducttape_ has quit IRC | 14:32 | |
| *** vladikr has joined #openstack-nova | 14:32 | |
| *** jamesden_ has quit IRC | 14:33 | |
| *** jamesdenton has joined #openstack-nova | 14:35 | |
| *** eharney has quit IRC | 14:37 | |
| *** yuntongjin1 has quit IRC | 14:38 | |
| *** amoralej|lunch is now known as amoralej | 14:38 | |
| *** jheroux has joined #openstack-nova | 14:41 | |
| *** sreeram_v has joined #openstack-nova | 14:41 | |
| *** Guest52965 has quit IRC | 14:44 | |
| *** yingjun has joined #openstack-nova | 14:45 | |
| *** cfriesen has quit IRC | 14:45 | |
| *** sreeram_v has quit IRC | 14:46 | |
| *** bkopilov has joined #openstack-nova | 14:47 | |
| *** cfriesen has joined #openstack-nova | 14:47 | |
| mriedem | sdague: that was pointed out in your ML thread on this | 14:48 |
| mriedem | "This would make things like `project_id` and `all_tenants` valid filters for regular users. However, if we interpret them within the user's context, that's fine. `all_tenants` means "All tenants that I am allowed to see". For a Nova admin, that's everyone. In a future with hierarchical multi tenancy, this might be a subtree. project_id is fine as long as it's filtered by the project_id's you have access to in your context. M | 14:48 |
| mriedem | i imagine people are going to be confused with the behavior change where nova list --all-tenants for non-admins used to fail with a 403 but now it will just list your instances | 14:48 |
| mriedem | sdague: oh i guess you're asking why a policy for all_tenants, why not just check context.is_admin() and do the thing based on that? | 14:49 |
| *** eharney has joined #openstack-nova | 14:50 | |
| mriedem | a policy seems fine to me, maybe you want to allow a certain class of users the ability to see all tenants in a cloud, but not see hosts for example | 14:52 |
| sdague | mriedem: yeh, I'd rather just hard code it | 14:52 |
| sdague | but, I'm fine niggling on that in code reviews, that's going to be towards the end of the stack I assume | 14:52 |
| sdague | the rest of that all looks fine to me | 14:52 |
| bauzas | mriedem: just noted a few things on https://review.openstack.org/#/c/411517/6 | 14:53 |
| sdague | mriedem: were you ok with the conf addition here - https://review.openstack.org/#/c/389003/20 ? | 14:53 |
| sdague | I feel like that was a sticking point | 14:53 |
| bauzas | mriedem: I'm basically +W on it, I just want you to read those and yell if you disagree | 14:54 |
| bauzas | that's a totally separate command, so I'm fine redoing stuff later on | 14:54 |
| mriedem | sdague: i haven't reviewed https://review.openstack.org/#/c/389003/ yet | 14:54 |
| bauzas | mriedem: but the hard dependency for an enum seems to me a bit overkill | 14:54 |
| *** ducttape_ has joined #openstack-nova | 14:56 | |
| *** hfu has quit IRC | 14:57 | |
| *** vsaienk0 has joined #openstack-nova | 14:58 | |
| *** baoli has quit IRC | 14:58 | |
| *** mlavalle has joined #openstack-nova | 14:58 | |
| *** Guest52965 has joined #openstack-nova | 14:59 | |
| *** baoli has joined #openstack-nova | 14:59 | |
| mriedem | bauzas: responded | 14:59 |
| vsaienk0 | nova team, in ironic during last several weeks we experiencing random job timeouts, the root cause is unknown. Could you please have look https://bugs.launchpad.net/nova/+bug/1651678. It looks like request stuck at Nova compute (_do_build_and_run_instance /opt/stack/new/nova/nova/compute/manager.py:1754) | 14:59 |
| openstack | Launchpad bug 1651678 in OpenStack Compute (nova) "Slow nodes at the gate leads to ironic tempest timeouts" [Undecided,New] | 14:59 |
| *** baoli has quit IRC | 14:59 | |
| *** yingjun has quit IRC | 15:00 | |
| *** baoli has joined #openstack-nova | 15:00 | |
| *** Guest52965 has quit IRC | 15:00 | |
| bauzas | mriedem: fine, you responded so +W | 15:01 |
| *** yassine has joined #openstack-nova | 15:01 | |
| bauzas | mriedem: I just don't want to block on that | 15:01 |
| bauzas | mriedem: we can follow-up on that | 15:01 |
| *** yassine is now known as Guest28025 | 15:01 | |
| bauzas | mriedem: the Enum thing is a bit scary to me, but okay, I don't want to miss 2016 target for something like that :) | 15:02 |
| mriedem | embrace the enum | 15:02 |
| mriedem | become the enum | 15:02 |
| mriedem | i'll change the 10 rc to 255 in a follow up then | 15:02 |
| *** mtanino has joined #openstack-nova | 15:03 | |
| bauzas | mriedem: yeah, sdague already +2d, no need to go under the bus for something that nitty | 15:03 |
| bauzas | just put that at the end of the series | 15:03 |
| *** Fdaisuke has quit IRC | 15:04 | |
| *** zenoway has quit IRC | 15:06 | |
| *** yingjun has joined #openstack-nova | 15:07 | |
| bauzas | mriedem: sdague: other point, I know we're not at quorum now for discussing, but when should we require the Placement API to run ? before someone upgrades the scheduler, or before their expands the DB contract? | 15:07 |
| bauzas | mriedem: or before they upgrade their controllers? | 15:08 |
| mriedem | before you upgrade the nova-scheduler code to ocata and restart the service | 15:10 |
| mriedem | since we aren't going to do the fallback plan if the placement api doesn't return resource providers | 15:10 |
| *** ayogi has quit IRC | 15:13 | |
| bauzas | mriedem: that's why I thought originally | 15:13 |
| bauzas | mriedem: so the nova-status command would say an error, but it would honestly be a problem only when restarting the scheduler, right? | 15:13 |
| *** smatzek has joined #openstack-nova | 15:13 | |
| *** yuntongjin has joined #openstack-nova | 15:14 | |
| *** cleong has joined #openstack-nova | 15:15 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: adding vlans field to virtual_interface https://review.openstack.org/405949 | 15:15 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951 | 15:15 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: vlans field to NetworkInterfaceMetadata object https://review.openstack.org/405950 | 15:15 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954 | 15:15 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: update vlan in virtual_interface object https://review.openstack.org/405953 | 15:15 |
| sdague | bauzas: well, it would demonstrate you are not ready to upgrade | 15:18 |
| sdague | which was kind of the point | 15:18 |
| jaypipes | vsaienk0: looking into that bug now... | 15:18 |
| bauzas | sdague: I'm fine with that, I understand the reasoning, I just mean that it could be something that operators could tell to us | 15:18 |
| jaypipes | vsaienk0: is there a particular time that this this started occurring? | 15:18 |
| mriedem | bauzas: correct | 15:19 |
| *** ducttape_ has quit IRC | 15:19 | |
| mriedem | bauzas: yeah so nova-status upgrade check means, 'if these aren't all successful, you shouldn't be restarting your services with ocata code' | 15:19 |
| bauzas | mriedem: what do you mean by failback plan ? the fact that we aren't optionally calling the placement API in the scheudler ? | 15:19 |
| bauzas | if so, I'm fine with that | 15:20 |
| mriedem | bauzas: no the fallback plan was if the placement API returned 0 RPs, we'd call ComputeNode.get_all() | 15:20 |
| bauzas | mriedem: yeah, okay, so that's basically the point I was thinking of | 15:20 |
| bauzas | I mean, that I was meaning | 15:20 |
| *** avolkov has joined #openstack-nova | 15:20 | |
| mriedem | bauzas: this part https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/resource-providers-scheduler-db-filters.html#other-deployer-impact | 15:20 |
| mriedem | bauzas: which i said i'd amend in that spec at some point | 15:21 |
| bauzas | mriedem: yeah I remember | 15:21 |
| *** jheroux has quit IRC | 15:21 | |
| lbeliveau | jaypipes: got a minute to review this rt bug ? https://review.openstack.org/#/c/405575/ | 15:22 |
| openstackgerrit | John Haan proposed openstack/nova: VM with cross_az_attach raised InvaldBDM error https://review.openstack.org/409680 | 15:22 |
| *** pbandark has quit IRC | 15:23 | |
| cfriesen | where are the Newton upgrade docs for nova? http://docs.openstack.org/releasenotes/nova/newton.html mentions them but I can't find them. | 15:25 |
| vsaienk0 | jaypipes: according to logstach first failure was at December 13 | 15:25 |
| openstackgerrit | chenyingnan proposed openstack/nova: Replace "Openstack" with "OpenStack" https://review.openstack.org/414195 | 15:26 |
| *** ducttape_ has joined #openstack-nova | 15:26 | |
| *** salv-orlando has joined #openstack-nova | 15:26 | |
| *** fragatina has quit IRC | 15:28 | |
| vsaienk0 | jaypipes: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%20%5C%22Timed%20out%20waiting%20to%20get%20Ironic%20node%20by%20instance%20id%5C%22%20and%20project%3A%20%5C%22openstack%2Fironic%5C%22 | 15:28 |
| mriedem | cfriesen: something is busted there, 14.0.0 isn't listed | 15:28 |
| mriedem | same for mitaka | 15:28 |
| mriedem | dhellmann: is there a known issue with releasenotes not publishing newton base release? | 15:28 |
| bauzas | mriedem: reno just upgraded | 15:29 |
| bauzas | mriedem: and I think they had a couple of issues with that | 15:29 |
| dhellmann | we had one issue with projects that didn't have tags at the base of their branches, but that wouldn't have affected nova | 15:29 |
| dhellmann | there is a change in logic to prevent reno from scanning the whole history of the project on every branch, maybe that's what you mean | 15:30 |
| mriedem | sdague: alex_xu: Kevin_Zheng: ok i've gone through https://review.openstack.org/#/c/393205/ again - several questions inline | 15:30 |
| mriedem | dhellmann: just noting that http://docs.openstack.org/releasenotes/nova/newton.html doesn't list 14.0.0 | 15:31 |
| mriedem | which was newton GA for nova | 15:31 |
| dhellmann | yeah, that looks like a bug | 15:31 |
| *** salv-orlando has quit IRC | 15:31 | |
| dhellmann | I'll take a look after this meeting I'm in | 15:31 |
| mriedem | ok | 15:31 |
| mriedem | dhellmann: https://bugs.launchpad.net/reno/+bug/1652092 for tracking | 15:32 |
| openstack | Launchpad bug 1652092 in reno "14.0.0 tag (nova newton GA) isn't displayed in newton release notes" [Undecided,New] | 15:32 |
| jaypipes | lbeliveau: done | 15:32 |
| dhellmann | mriedem : thanks | 15:32 |
| *** psachin has quit IRC | 15:33 | |
| lbeliveau | jaypipes: thanks sir ! | 15:33 |
| jaypipes | mriedem: so I'm looking at the logs from vsaienk0's bug (http://logs.openstack.org/39/404239/14/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_snmp-tinyipa-ubuntu-xenial-nv/8f98498/logs/screen-n-cpu.txt.gz?level=WARNING#_2016-12-21_13_24_24_307). Lots of WARNINGs in there about Invalid inventory for VCPU on resource provider. reserved value is greater than total... I'm wondering what on earth we have the reserved value set for VCPU...? | 15:34 |
| *** mtan_____ has joined #openstack-nova | 15:34 | |
| jaypipes | mriedem: it should be reserved of 0. which means the total is either 0 or negative? | 15:35 |
| cfriesen | mridem: where is the actual source for the release notes? | 15:35 |
| sdague | johnthetubaguy: you still around or did you already split for the holidays? | 15:35 |
| *** mtanino has quit IRC | 15:35 | |
| jaypipes | mriedem: ooooh, unless the VCPU returned from the Ironic virt driver's get_available_resource() is 0? hmmm... I'll look into it further. | 15:36 |
| *** jheroux has joined #openstack-nova | 15:36 | |
| jaypipes | mriedem: yeah, looks like we're trying to set a total vcpus value of 0 somewhere... | 15:38 |
| mriedem | cfriesen: it's in the nova code | 15:39 |
| mriedem | cfriesen: tox -r -e releasenotes | 15:39 |
| mriedem | jaypipes: we aren't using placement for scheduling yet | 15:39 |
| mriedem | or you're just saying something is busted with resource reporting in the virt driver? | 15:39 |
| jaypipes | mriedem: no, this is n-cpu, not n-sched | 15:39 |
| jaypipes | yeh | 15:40 |
| mriedem | we don't log any of that stuff at debug? | 15:40 |
| jaypipes | mriedem: yeah, somewhere we're trying to set the inventory of VCPU of an ironic node to 0. | 15:40 |
| mriedem | jaypipes: Final resource view: name=f4e34046-fa46-47ca-ab90-c1c2cfb0238f phys_ram=0MB used_ram=0MB phys_disk=0GB used_disk=0GB total_vcpus=0 used_vcpus=0 pci_stats=[] | 15:41 |
| mriedem | ha | 15:41 |
| jaypipes | mriedem: right.. | 15:41 |
| *** ducttape_ has quit IRC | 15:41 | |
| mriedem | http://logs.openstack.org/39/404239/14/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_snmp-tinyipa-ubuntu-xenial-nv/8f98498/logs/screen-n-cpu.txt.gz#_2016-12-21_13_21_14_198 | 15:41 |
| mriedem | Hypervisor/Node resource view: name=f4e34046-fa46-47ca-ab90-c1c2cfb0238f free_ram=384MB free_disk=10GB free_vcpus=1 pci_devices=None _report_hypervisor_resource_view | 15:41 |
| cfriesen | mriedem: thanks | 15:42 |
| mriedem | jaypipes: have your refactor changes landed yet? | 15:42 |
| jaypipes | mriedem: no | 15:43 |
| jaypipes | mriedem: if you're referring to the "use a single RT object" series. | 15:43 |
| jaypipes | mriedem: I'll put some verbose logging into a local branch and push something up. | 15:44 |
| jaypipes | mriedem: there shouldn't be any time where vcpus == 0... | 15:44 |
| mriedem | i'm checking logstash | 15:47 |
| *** salv-orlando has joined #openstack-nova | 15:48 | |
| openstackgerrit | int32bit proposed openstack/nova: Add more actions to instance action logs https://review.openstack.org/396510 | 15:49 |
| mriedem | which provider is cloud1? | 15:49 |
| mriedem | osic? | 15:50 |
| mriedem | that's where "phys_ram=0MB used_ram=0MB phys_disk=0GB used_disk=0GB total_vcpus=0 used_vcpus=0 pci_stats=[]" mostly shows up | 15:50 |
| *** yingjun has quit IRC | 15:50 | |
| *** slaweq has joined #openstack-nova | 15:52 | |
| openstackgerrit | jichenjc proposed openstack/nova: add zvm migration object https://review.openstack.org/414090 | 15:53 |
| mriedem | jaypipes: sdague: i'm not seeing request ids from n-cpu in the placement api logs, | 15:54 |
| mriedem | e.g. req-f3cfc8fa-df45-4da4-adf2-83688458fa16 is a failed request in n-cpu, but it's not in the placement logs | 15:54 |
| mriedem | i was hoping to see the body of one of the failed requests in the placement api logs | 15:55 |
| mriedem | i'll open a bug for that, maybe it's a known thing | 15:55 |
| sdague | mriedem: it's a separate REST service | 15:55 |
| jaypipes | mriedem: well, the placement API is clearly being called, because the 400 Bad Request contains the exact error message from the placement API. | 15:56 |
| sdague | it's not going to be the same req id | 15:56 |
| sdague | we only have the same req-id across the nova daemons because the context is passed around | 15:56 |
| sdague | over rabbit | 15:56 |
| *** Sukhdev has joined #openstack-nova | 15:56 | |
| mriedem | can't we pass the request id from n-cpu to the placement service in a header? | 15:57 |
| sdague | mriedem: we could pass the request-id to placement | 15:57 |
| sdague | it's an API change | 15:57 |
| sdague | it's probably a good idea | 15:57 |
| *** roeyc has quit IRC | 15:57 | |
| sdague | but it should also have at least a small spec to just think through the implications | 15:57 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1652099 | 16:00 |
| openstack | Launchpad bug 1652099 in OpenStack Compute (nova) "placement requests from n-cpu logs not found in placement-api logs" [Undecided,New] | 16:00 |
| mriedem | would be nice to log the request bodies somewhere too, like n-cpu has when talking to cinder | 16:01 |
| mriedem | in that case it's actually cinderclient that's logging the request and response at debug level | 16:01 |
| *** hongbin has joined #openstack-nova | 16:01 | |
| mriedem | maybe we don't do it always, but could log the body at debug level on a failure like this in n-cpu | 16:02 |
| *** Guest47337 has quit IRC | 16:03 | |
| *** mlavalle has quit IRC | 16:04 | |
| *** mlavalle has joined #openstack-nova | 16:04 | |
| *** sahid has joined #openstack-nova | 16:05 | |
| *** liverpooler has joined #openstack-nova | 16:07 | |
| sdague | mriedem: yeh, logging the placement request id back on the nova side would probably be more akin to how the cinder interaction works | 16:08 |
| *** baoli has quit IRC | 16:09 | |
| *** baoli has joined #openstack-nova | 16:10 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Resource tracker doesn't free resources on confirm resize https://review.openstack.org/405575 | 16:11 |
| lbeliveau | jaypipes: ^ | 16:11 |
| openstackgerrit | Jay Pipes proposed openstack/nova: DNM: Trying to figure out bug1651678 https://review.openstack.org/414214 | 16:13 |
| *** slaweq has quit IRC | 16:13 | |
| *** JoseMello has quit IRC | 16:14 | |
| *** ducttape_ has joined #openstack-nova | 16:15 | |
| *** raunak has joined #openstack-nova | 16:15 | |
| *** mjura has quit IRC | 16:15 | |
| jaypipes | lbeliveau: nice work. +2 from me. | 16:17 |
| *** nkrinner_afk has quit IRC | 16:17 | |
| jaypipes | mriedem: lbeliveau's patch above is ready for your review, IMHO. | 16:17 |
| lbeliveau | jaypipes: thanks Jay for the reviews :) | 16:17 |
| jaypipes | np | 16:17 |
| jaypipes | vsaienk0: have you been able to determine a pattern on bug 1651678? Is it always one cloud provider? is it always the ironic-ipa-wholedisk-pce-snmp-tinyipa-ubuntu-xenial-nv job? | 16:19 |
| openstack | bug 1651678 in OpenStack Compute (nova) "boot server request randomly hanging at n-cpu side, and didn't get to Ironic" [High,New] https://launchpad.net/bugs/1651678 - Assigned to Jay Pipes (jaypipes) | 16:19 |
| *** zz_dimtruck is now known as dimtruck | 16:20 | |
| *** Oku_OS is now known as Oku_OS-away | 16:20 | |
| *** raunak has quit IRC | 16:22 | |
| *** jwcroppe has quit IRC | 16:23 | |
| *** jwcroppe has joined #openstack-nova | 16:24 | |
| vsaienk0 | jaypipes: all jobs are affected, and I found that it was reproduced at least on osic and bhs1 cloud (ubuntu-xenial-osic-cloud1-s3700-6324141 and ubuntu-xenial-ovh-bhs1-6325566) | 16:25 |
| mriedem | sdague: i'm -1 on the config option for logging warnings on bad user requests in https://review.openstack.org/#/c/389003/ | 16:25 |
| mriedem | sdague: thanks for pointing that out | 16:25 |
| mriedem | i don't think it makes sense to log a warning for a bad user request - the operator can't do anything about that | 16:26 |
| mriedem | i'm OK with always logging those ignored parameters at INFO level too | 16:28 |
| mriedem | just don't think we need a config for it | 16:28 |
| *** ralonsoh has quit IRC | 16:31 | |
| *** xinliang has quit IRC | 16:33 | |
| *** ducttape_ has quit IRC | 16:34 | |
| *** baoli has quit IRC | 16:34 | |
| *** vtech has joined #openstack-nova | 16:36 | |
| *** siva_krish has joined #openstack-nova | 16:37 | |
| sdague | mriedem: ok, the reason for config is that it might be a lot of noise, even at info | 16:38 |
| sdague | but, I'm fine pulling that back in later if we need it | 16:38 |
| sdague | I actually thought that would be defered to later in the patch series | 16:38 |
| mriedem | the noise is why i suggested debug | 16:39 |
| mriedem | but in production you won't be running debug in your api node | 16:39 |
| mriedem | so if the user reports a ticket and you have to figure out why their request parameter was ignored, then you would need to enable debug for a recreate, | 16:40 |
| mriedem | seems like a lot of fuss over something that a user reading the docs or using a client package/sdk should not do in the first place | 16:40 |
| *** jwcroppe has quit IRC | 16:40 | |
| *** jwcroppe has joined #openstack-nova | 16:41 | |
| *** liverpooler has quit IRC | 16:42 | |
| *** smatzek has quit IRC | 16:44 | |
| *** liverpooler has joined #openstack-nova | 16:44 | |
| *** Jeffrey4l has quit IRC | 16:46 | |
| siva_krish | Hi tdurakov! have a question on post_copy_switch in libivrt/driver.py. I see two calls made to trigger_post_copy_switch in same elseif loop https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6310 https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6354. Why do we do so ? | 16:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: WIP: Add more debug logging on RP inventory update failures https://review.openstack.org/414230 | 16:52 |
| *** browne has joined #openstack-nova | 16:55 | |
| *** raunak has joined #openstack-nova | 16:56 | |
| *** lucasagomes is now known as lucas-afk | 16:59 | |
| jaypipes | vsaienk0: k, thx for the info | 17:00 |
| openstackgerrit | int32bit proposed openstack/nova: Add missing 'algorithm' argument to create_key https://review.openstack.org/414233 | 17:02 |
| *** eglynn has quit IRC | 17:02 | |
| *** slaweq has joined #openstack-nova | 17:02 | |
| *** gszasz has quit IRC | 17:02 | |
| *** jaosorior has quit IRC | 17:05 | |
| *** ducttape_ has joined #openstack-nova | 17:05 | |
| *** jaosorior has joined #openstack-nova | 17:05 | |
| *** bkopilov has quit IRC | 17:06 | |
| *** Jeffrey4l has joined #openstack-nova | 17:07 | |
| *** tlian has joined #openstack-nova | 17:07 | |
| *** slaweq has quit IRC | 17:09 | |
| *** bkopilov has joined #openstack-nova | 17:12 | |
| *** fragatina has joined #openstack-nova | 17:12 | |
| *** Jeffrey4l has quit IRC | 17:15 | |
| *** Jeffrey4l has joined #openstack-nova | 17:15 | |
| pkoniszewski | hey folks, can we have some eyes on https://review.openstack.org/#/c/244489/ ? the patch is >1 year old, I'm aware that it is huge, but it does not make sense to make it in smaller chunks :( | 17:16 |
| *** ayogi has joined #openstack-nova | 17:17 | |
| *** ducttape_ has quit IRC | 17:18 | |
| *** burt has joined #openstack-nova | 17:20 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: PCI: Update MAC address for NICs PF passthrough devices https://review.openstack.org/361438 | 17:20 |
| *** unicell has quit IRC | 17:22 | |
| *** flaper87 has quit IRC | 17:22 | |
| *** Jeffrey4l has quit IRC | 17:23 | |
| *** Jeffrey4l has joined #openstack-nova | 17:23 | |
| mriedem | jaypipes: vsaienk0: fyi i've also got this debugging patch up https://review.openstack.org/#/c/414230/ | 17:29 |
| mriedem | heading out to lunch, so results should be in by the time i'm back | 17:29 |
| *** fragatina has quit IRC | 17:33 | |
| *** flaper87 has joined #openstack-nova | 17:35 | |
| *** ayogi has quit IRC | 17:42 | |
| *** baoli has joined #openstack-nova | 17:44 | |
| *** nic has joined #openstack-nova | 17:44 | |
| *** jaypipes has quit IRC | 17:46 | |
| *** ociuhandu has quit IRC | 17:48 | |
| *** unicell has joined #openstack-nova | 17:48 | |
| sfinucan | mriedem, sdague: Could one of ye look at this at some point https://review.openstack.org/#/c/406425 Would like to know if you agree with what we've done to "fix" python 3 for this particular test | 17:49 |
| *** weshay is now known as weshay_afk | 17:54 | |
| *** ihrachys has quit IRC | 17:56 | |
| *** dimtruck is now known as zz_dimtruck | 17:57 | |
| *** unicell has quit IRC | 17:58 | |
| *** gszasz has joined #openstack-nova | 17:58 | |
| *** jaypipes has joined #openstack-nova | 18:00 | |
| *** nicolasbock has quit IRC | 18:01 | |
| *** pradk has quit IRC | 18:01 | |
| *** yamahata has joined #openstack-nova | 18:04 | |
| *** dave-mccowan has quit IRC | 18:05 | |
| *** nicolasbock has joined #openstack-nova | 18:06 | |
| *** palexster has quit IRC | 18:11 | |
| jaypipes | mriedem: yeah, my patch that added an exception raise if vcpus == 0 passed Jenkins with flying colors :( | 18:12 |
| *** lpetrut has quit IRC | 18:13 | |
| *** palexster has joined #openstack-nova | 18:17 | |
| *** ducttape_ has joined #openstack-nova | 18:18 | |
| *** Sukhdev has quit IRC | 18:22 | |
| *** ociuhandu has joined #openstack-nova | 18:23 | |
| *** ducttape_ has quit IRC | 18:23 | |
| *** unicell has joined #openstack-nova | 18:25 | |
| *** unicell has quit IRC | 18:25 | |
| *** unicell has joined #openstack-nova | 18:25 | |
| *** lpetrut has joined #openstack-nova | 18:33 | |
| *** pradk has joined #openstack-nova | 18:36 | |
| *** salv-orlando has quit IRC | 18:43 | |
| *** zz_dimtruck is now known as dimtruck | 18:45 | |
| *** lpetrut has quit IRC | 18:46 | |
| *** esberglu has quit IRC | 19:00 | |
| *** esberglu has joined #openstack-nova | 19:01 | |
| *** amoralej is now known as amoralej|off | 19:01 | |
| *** yamahata has quit IRC | 19:02 | |
| *** esberglu has quit IRC | 19:05 | |
| *** hongbin has quit IRC | 19:05 | |
| *** cfriesen has quit IRC | 19:06 | |
| *** ducttape_ has joined #openstack-nova | 19:06 | |
| *** lpetrut has joined #openstack-nova | 19:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/414299 | 19:06 |
| *** cfriesen has joined #openstack-nova | 19:06 | |
| cfriesen | when upgrading to Newton is it necessary to do anything related to cells if we're not actually using cells? | 19:07 |
| *** cheran has joined #openstack-nova | 19:12 | |
| mriedem | cfriesen: not in newton no | 19:14 |
| mriedem | cells v2 becomes required in ocata | 19:14 |
| cfriesen | mriedem: okay, thanks. | 19:16 |
| mriedem | sfinucan: i'm fine with that | 19:19 |
| sfinucan | mriedem: Sweet. I wasn't 100% sure whether we allowed skipIf for such conditions | 19:20 |
| *** ducttape_ has quit IRC | 19:23 | |
| openstackgerrit | Eric Brown proposed openstack/nova: VMware: Update supported OS types for ESX 6.5 https://review.openstack.org/403492 | 19:28 |
| *** Guest28025 has quit IRC | 19:36 | |
| *** rcernin has joined #openstack-nova | 19:38 | |
| *** yamahata has joined #openstack-nova | 19:41 | |
| *** sreeram_v has joined #openstack-nova | 19:42 | |
| *** sgordon has quit IRC | 19:44 | |
| *** baoli has quit IRC | 19:46 | |
| *** baoli has joined #openstack-nova | 19:46 | |
| *** sreeram_v has quit IRC | 19:47 | |
| *** baoli has quit IRC | 19:47 | |
| mriedem | lbeliveau: are you guys doing like auto-confirm resizes? | 19:47 |
| *** baoli has joined #openstack-nova | 19:56 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: DO NOT MERGE diagnostics squash https://review.openstack.org/414318 | 19:58 |
| *** sgordon has joined #openstack-nova | 19:59 | |
| lbeliveau | mriedem: no, manual confirm | 20:00 |
| *** rfolco has quit IRC | 20:00 | |
| mriedem | lbeliveau: ok i was just looking at https://review.openstack.org/#/c/405575/ and the commit message made me think that this was only a problem if the resize was confirmed under the default 60 second windows that update_available_resources runs | 20:01 |
| *** baoli has quit IRC | 20:05 | |
| cfriesen | mriedem: that's my impression too based on the commit message. we do have people doing manual tests though, and they're confirming the resize basically as soon as it's completed. | 20:05 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: adding vlans field to virtual_interface https://review.openstack.org/405949 | 20:05 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951 | 20:05 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: vlans field to NetworkInterfaceMetadata object https://review.openstack.org/405950 | 20:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954 | 20:06 |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: neutron: update vlan in virtual_interface object https://review.openstack.org/405953 | 20:06 |
| *** baoli has joined #openstack-nova | 20:07 | |
| *** raunak has quit IRC | 20:10 | |
| *** baoli has quit IRC | 20:10 | |
| *** xyang1 has joined #openstack-nova | 20:15 | |
| *** baoli has joined #openstack-nova | 20:17 | |
| *** esberglu has joined #openstack-nova | 20:18 | |
| mriedem | if anyone else loves this stacktrace in n-cpu http://logs.openstack.org/75/405575/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e1c5575/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-12-22_17_20_27_622 | 20:21 |
| mriedem | then don't review this... https://review.openstack.org/#/c/403925/ | 20:22 |
| lbeliveau | mriedem: you're right, it's only an issue within the resource audit window, still is a bug, also I've added comments to clarify a few things and removed something that nobody knew why it was there in the first place :) | 20:22 |
| mriedem | lbeliveau: yeah +W | 20:23 |
| lbeliveau | thanks ! | 20:23 |
| *** ducttape_ has joined #openstack-nova | 20:24 | |
| mriedem | jaypipes: http://logs.openstack.org/75/405575/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e1c5575/logs/screen-n-cpu.txt.gz?level=TRACE | 20:24 |
| mriedem | Unable to allocate inventory: Unable to create allocation for 'DISK_GB' on resource provider '93cd0be5-801d-4d00-aaab-7b6772656683'. The requested amount would violate inventory constraints. ) | 20:24 |
| mriedem | maybe we shouldn't make that a warning for everything... | 20:24 |
| mriedem | or it is a warning, and we're just hitting it a ton in the CI jobs | 20:25 |
| jaypipes | mriedem: we made it a warning so as not to break deployments that had oversubscribed stuff, IIRC. | 20:25 |
| jaypipes | mriedem: DISK_GB was the resource class that would look like it was oversubscribed. | 20:26 |
| jaypipes | mriedem: I'm still not sure how the CI environments had any Ironic node at vcpus=0, though. that one has me stumped :( | 20:26 |
| mriedem | jaypipes: yeah, note ^ is not ironic though | 20:28 |
| mriedem | i was just looking at how many warnings we have in the compute logs in gate runs now | 20:28 |
| mriedem | i'm also going to fix this to not be a warning http://logs.openstack.org/75/405575/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e1c5575/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-12-22_16_52_19_551 | 20:29 |
| *** ducttape_ has quit IRC | 20:29 | |
| mriedem | we shouldn't warn on a 404 when trying to delete something | 20:29 |
| *** salv-orlando has joined #openstack-nova | 20:30 | |
| jaypipes | mriedem: ya ++ | 20:30 |
| *** browne has quit IRC | 20:31 | |
| mriedem | ooo i didn't know https://review.openstack.org/#/c/199488/ was merged already, cool | 20:31 |
| mriedem | lbeliveau: seems we should have a feature release note for this https://review.openstack.org/#/c/199488/ | 20:32 |
| mriedem | i.e. hey you can use regex with pci whitelist now | 20:32 |
| jaypipes | mriedem: "The requested URL /placement/resource_providers was not found on this server" | 20:33 |
| jaypipes | mriedem: seems like it's a problem with the keystone catalog maybe? | 20:33 |
| *** esberglu has quit IRC | 20:33 | |
| jaypipes | mriedem: but then later on it seems to return OK from the placement API... :( | 20:33 |
| *** yuntongjin has quit IRC | 20:33 | |
| *** esberglu has joined #openstack-nova | 20:34 | |
| mriedem | jaypipes: i think that's a service order startup thing we've known about since newton | 20:34 |
| *** yuntongjin has joined #openstack-nova | 20:34 | |
| mriedem | the n-cpu service is started before the placement service in devstack i believe | 20:34 |
| jaypipes | mriedem: ah, k | 20:34 |
| mriedem | because placement was optional in newton and tacked on later | 20:34 |
| jaypipes | right.. | 20:35 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: DO NOT MERGE https://review.openstack.org/414328 | 20:35 |
| *** esberglu has quit IRC | 20:38 | |
| jaypipes | mriedem: where can I find the placement-api logs? | 20:38 |
| *** Sukhdev has joined #openstack-nova | 20:38 | |
| *** tjones has joined #openstack-nova | 20:38 | |
| jaypipes | mriedem: nm, found it. | 20:38 |
| jaypipes | mriedem: we need a log here: http://logs.openstack.org/75/405575/6/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/e1c5575/logs/apache/placement-api.txt.gz#_2016-12-22_16_41_04_883 | 20:40 |
| *** dtp has joined #openstack-nova | 20:40 | |
| jaypipes | mriedem: there is an inventory conflict happening, returning a 409, but no log as to what the conflict was :( | 20:41 |
| mriedem | jaypipes: https://review.openstack.org/#/c/414230/ | 20:41 |
| mriedem | yeah | 20:41 |
| mriedem | i've got the client side change up for that, WIP though just to see what it looks like | 20:41 |
| jaypipes | mriedem: also.. | 20:43 |
| jaypipes | Allocation for DISK_GB on resource provider 93cd0be5-801d-4d00-aaab-7b6772656683 violates min_unit, max_unit, or step_size. Requested: 0, min_unit: 1, max_unit: 149, step_size: 1 | 20:43 |
| jaypipes | looks like we're still submitting requests for 0 resources... :( | 20:43 |
| *** baoli has quit IRC | 20:46 | |
| *** baoli has joined #openstack-nova | 20:46 | |
| *** takashin has joined #openstack-nova | 20:47 | |
| *** browne has joined #openstack-nova | 20:49 | |
| *** browne has quit IRC | 20:49 | |
| *** pradk has quit IRC | 20:51 | |
| *** sahid has quit IRC | 20:53 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: nova-status: return 255 for unexpected errors https://review.openstack.org/414329 | 20:57 |
| mriedem | nova team meeting time | 21:00 |
| *** rfolco has joined #openstack-nova | 21:00 | |
| *** rfolco has quit IRC | 21:00 | |
| mriedem | hmm, do responses from webob / requests override bool? | 21:01 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L428 | 21:02 |
| mriedem | that's false if r.status_code is 404 | 21:02 |
| *** browne has joined #openstack-nova | 21:03 | |
| *** juszczus has quit IRC | 21:04 | |
| *** siva_krish has quit IRC | 21:06 | |
| *** juszczus has joined #openstack-nova | 21:08 | |
| *** mtan_____ has quit IRC | 21:09 | |
| jaypipes | mriedem: I had changed that to look at the response code explicitly, yeah.. | 21:10 |
| *** pradk has joined #openstack-nova | 21:13 | |
| *** jaosorior has quit IRC | 21:16 | |
| *** takashin has left #openstack-nova | 21:21 | |
| mriedem | jaypipes: ah https://github.com/kennethreitz/requests/blob/master/requests/models.py#L645 | 21:21 |
| mriedem | requests.Response overrides __bool__ | 21:21 |
| jaypipes | heh, interesting. | 21:22 |
| jaypipes | learn something new every day. | 21:22 |
| *** liverpooler has quit IRC | 21:23 | |
| *** ducttape_ has joined #openstack-nova | 21:25 | |
| *** ducttape_ has quit IRC | 21:30 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| mriedem | jaypipes: didn't you have a patch which decoupled TestInventory and TestAllocations from SchedulerReportClientTestCase ? | 21:35 |
| mriedem | we're running all of the SchedulerReportClientTestCase tests 3 times | 21:35 |
| mriedem | and i'm not sure why except for the common setup | 21:36 |
| jaypipes | yep: https://review.openstack.org/#/c/406363/ | 21:36 |
| mriedem | ah right | 21:36 |
| mriedem | but people have to get through the forest of refactor to get those treats | 21:36 |
| jaypipes | mriedem: sorry :( you want me to break that out? | 21:38 |
| mriedem | doesn't matter much to me | 21:39 |
| mriedem | i'm just adding a new test case in TestAllocatoins | 21:39 |
| mriedem | which isn't affected by your change so not a problem | 21:39 |
| *** cleong has quit IRC | 21:41 | |
| jaypipes | kk | 21:41 |
| *** eharney has quit IRC | 21:42 | |
| *** mvk has quit IRC | 21:42 | |
| *** sreeram_v has joined #openstack-nova | 21:43 | |
| bauzas | oh man, I thought we were not having the meeting today :( | 21:44 |
| bauzas | mriedem: ^ | 21:44 |
| bauzas | sorry for missing it | 21:44 |
| *** gouthamr has quit IRC | 21:46 | |
| mriedem | the nova team meeting rests for no man | 21:47 |
| *** sreeram_v has quit IRC | 21:47 | |
| *** Jeffrey4l has joined #openstack-nova | 21:48 | |
| bauzas | jaypipes: about https://review.openstack.org/#/c/398470/14/nova/compute/resource_tracker.py since a lot of methods look at the ComputeNode by using the tuple (host, node) do you think long-term that we would remove it ? | 21:48 |
| bauzas | like we use hypervisor_hostname for a lot of things | 21:48 |
| jaypipes | bauzas: you mean eventually remove passing the host and nodename and instead just pass the hypervisor_hostname value only? | 21:49 |
| bauzas | jaypipes: for example, we have a Destination object using both of the fields | 21:49 |
| bauzas | jaypipes: I mean, I totally understand your change and your series | 21:50 |
| bauzas | jaypipes: since Ironic only needs it, once we will have the needed RP modifications for them, it should be okay to only have one RT | 21:51 |
| jaypipes | bauzas: eventually I'd like to just pass a single UUID, yeah, the resource provider UUID value... | 21:51 |
| bauzas | jaypipes: I just wonder long-term how to modify all the situations where we have that tuple | 21:51 |
| bauzas | because lots of places in Nova are using that | 21:51 |
| jaypipes | bauzas: and of course most of the xxx_claim() methods in the RT should go away (or be dramatically reduced) once claims can be done in the placement API, yeah? | 21:51 |
| bauzas | removing it seems huge | 21:51 |
| bauzas | jaypipes: well, we haven't yet agreed on that plan, but if so, yeah :) | 21:52 |
| jaypipes | other than the scheduler and the RT, what places in Nova use the (host, nodename) tuple to identify targets? | 21:52 |
| bauzas | jaypipes: lemme find those | 21:52 |
| bauzas | at least the conductor AFAIR | 21:53 |
| jaypipes | bauzas: conductor only uses host... it just passes along the nodename in payloads but only uses the host value for routing. | 21:53 |
| jaypipes | bauzas: but I hear your point... :) I will be very careful about what things I'm teasing apart in there! | 21:54 |
| bauzas | jaypipes: for example, we have the virt drivers looking at hypervisor_name IIRC, right? | 21:54 |
| bauzas | jaypipes: and we use the host field for mostly calling RPC | 21:55 |
| bauzas | jaypipes: so, if we want to only use a single field for both of them, changing all the places either looking at host or hypervisor_hostname seems huge | 21:56 |
| bauzas | I'm not saying impossible, just that cutting this seems not trivial :) | 21:56 |
| *** slaweq has joined #openstack-nova | 21:56 | |
| mriedem | wtf why can't i override __bool__ on a magic mock and make it work | 21:57 |
| jaypipes | mriedem: because we are living in a post-truth era. | 21:57 |
| mriedem | i just want to make magic mock great again | 21:57 |
| bauzas | jaypipes: anyway, I don't want to diverge that more | 21:57 |
| mriedem | and that starts with rick perry | 21:57 |
| bauzas | jaypipes: +W'd | 21:57 |
| jaypipes | bauzas: yep, I agree with you on the enormity of the task :) host is the service/RPC routing key. hypervisor_hostname is the nodename/target/virt-specific identifier. | 21:58 |
| bauzas | mriedem: False = True; False == True | 21:58 |
| *** toure is now known as toure|gone | 21:58 | |
| bauzas | mriedem: jk | 21:58 |
| jaypipes | :) | 21:58 |
| bauzas | mriedem: not sure I understand your problem ? | 22:00 |
| mriedem | riddle me this v | 22:00 |
| mriedem | http://paste.openstack.org/show/593205/ | 22:00 |
| mriedem | mock_log.info.assert_not_called() always fails | 22:00 |
| mriedem | because r is evaluating to True | 22:01 |
| bauzas | god loves syntaxic sugar | 22:01 |
| *** slaweq has quit IRC | 22:01 | |
| bauzas | mriedem: looking | 22:02 |
| *** slaweq has joined #openstack-nova | 22:03 | |
| jaypipes | mriedem: don't you need to use mock.patch.object() there for the LOG object in report.py? | 22:04 |
| bauzas | oh I see | 22:06 |
| bauzas | since r can return False right? | 22:06 |
| bauzas | I think I remember the specificity of the Response object | 22:06 |
| bauzas | something like it can be False or having a status code, right? | 22:07 |
| bauzas | mriedem: ^ | 22:07 |
| *** sdague has quit IRC | 22:08 | |
| *** raunak has joined #openstack-nova | 22:11 | |
| bauzas | mriedem: I just remembered this http://stackoverflow.com/questions/8909932/how-to-overload-pythons-bool-method | 22:12 |
| bauzas | actually http://stackoverflow.com/questions/2233786/overriding-bool-for-custom-class is more verbose | 22:13 |
| bauzas | (and six doesn't provide a compat layer AFAIK) | 22:14 |
| *** Sukhdev has quit IRC | 22:19 | |
| bauzas | oh fun, just discovered something : | 22:25 |
| bauzas | >>> ('a', 'b')[True] | 22:25 |
| bauzas | 'b' | 22:25 |
| bauzas | \o/ | 22:25 |
| *** slaweq has quit IRC | 22:29 | |
| *** slaweq has joined #openstack-nova | 22:31 | |
| *** Zer0Byte__ has joined #openstack-nova | 22:34 | |
| *** nic has quit IRC | 22:36 | |
| *** slaweq has quit IRC | 22:37 | |
| *** vtech has quit IRC | 22:38 | |
| *** jheroux has quit IRC | 22:40 | |
| *** Hazelesque_ has joined #openstack-nova | 22:41 | |
| *** Hazelesque has quit IRC | 22:41 | |
| *** dtp has quit IRC | 22:42 | |
| *** Zer0Byte__ has quit IRC | 22:46 | |
| mriedem | jaypipes: i think either is fine | 22:47 |
| mriedem | bauzas: ah nonzero | 22:48 |
| mriedem | gross | 22:48 |
| mriedem | ok | 22:48 |
| mriedem | i swear i've seen that before too for this same kind of thing | 22:48 |
| mriedem | maybe even in this same code :) | 22:48 |
| mriedem | yup in test_update_inventory_failed | 22:49 |
| mriedem | same deal | 22:49 |
| bauzas | ... :) | 22:50 |
| mriedem | and of course i didn't see it here https://docs.python.org/3/library/unittest.mock.html#unittest.mock.MagicMock | 22:51 |
| mriedem | because that's py3 so only talks about __bool__ | 22:51 |
| *** burt has quit IRC | 22:52 | |
| bauzas | I just remembered that booleans are very different between py2 and py3 | 22:52 |
| bauzas | like the above I provided, it's only for py2 | 22:53 |
| *** ducttape_ has joined #openstack-nova | 22:54 | |
| mriedem | yeah there examples in here from me to steal from | 22:57 |
| jlvillal | FYI: Seem to be having some random gate failures that show up like http://logs.openstack.org/99/414299/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/d9fda2a/logs/devstacklog.txt.gz#_2016-12-22_22_08_41_291 | 23:03 |
| *** Sukhdev has joined #openstack-nova | 23:04 | |
| jlvillal | My test patch gives an error about "Illegal instruction" http://logs.openstack.org/39/414339/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_snmp-tinyipa-ubuntu-xenial-nv/1d5e63d/logs/devstacklog.txt.gz#_2016-12-22_22_25_10_787 | 23:04 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Ignore 404s when deleting allocation records https://review.openstack.org/414349 | 23:05 |
| *** dimtruck is now known as zz_dimtruck | 23:08 | |
| *** Zer0Byte__ has joined #openstack-nova | 23:13 | |
| *** xyang1 has quit IRC | 23:25 | |
| *** ducttape_ has quit IRC | 23:25 | |
| *** lamt has quit IRC | 23:26 | |
| *** zz_dimtruck is now known as dimtruck | 23:28 | |
| *** lpetrut has quit IRC | 23:31 | |
| *** ijw has joined #openstack-nova | 23:38 | |
| *** mlavalle has quit IRC | 23:39 | |
| *** gszasz has quit IRC | 23:40 | |
| *** salv-orlando has quit IRC | 23:42 | |
| *** sreeram_v has joined #openstack-nova | 23:43 | |
| *** esberglu has joined #openstack-nova | 23:46 | |
| *** sreeram_v has quit IRC | 23:48 | |
| *** dimtruck is now known as zz_dimtruck | 23:49 | |
| *** yuntongjin has quit IRC | 23:50 | |
| *** tjones has quit IRC | 23:52 | |
| *** gouthamr has joined #openstack-nova | 23:52 | |
| *** Sukhdev has quit IRC | 23:55 | |
| *** baoli has quit IRC | 23:57 | |
| *** ducttape_ has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!