*** thorst has quit IRC | 00:06 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: List/show all server migration types https://review.openstack.org/407237 | 00:08 |
---|---|---|
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Abort Cold Migration https://review.openstack.org/334732 | 00:08 |
*** ducttape_ has joined #openstack-nova | 00:08 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Fix formatting errors and warnings https://review.openstack.org/407364 | 00:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova-specs: Amend cold-migration-with-target-ocata spec https://review.openstack.org/397193 | 00:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | 00:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436 | 00:09 |
*** baoli has quit IRC | 00:09 | |
*** dimtruck is now known as zz_dimtruck | 00:15 | |
*** fragatina has joined #openstack-nova | 00:40 | |
*** yingjun has joined #openstack-nova | 00:41 | |
*** Hazelesque has quit IRC | 00:42 | |
*** yingjun has quit IRC | 00:46 | |
*** Hazelesque has joined #openstack-nova | 00:51 | |
*** liusheng has quit IRC | 00:51 | |
*** ducttape_ has quit IRC | 00:52 | |
*** roeyc has quit IRC | 00:58 | |
*** hoangcx has joined #openstack-nova | 00:59 | |
*** phuongnh has joined #openstack-nova | 01:00 | |
*** baoli has joined #openstack-nova | 01:00 | |
*** ducnc has joined #openstack-nova | 01:03 | |
*** thorst has joined #openstack-nova | 01:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/412143 | 01:03 |
*** ducttape_ has joined #openstack-nova | 01:04 | |
mriedem | andreykurilin: i don't have a strong opinion | 01:04 |
mriedem | probably not a bad idea | 01:04 |
mriedem | btw i still haven't gotten the trove tempest tests to run on this change https://review.openstack.org/#/c/412113/ | 01:05 |
mriedem | i'm not sure what i'm missing there, i'll probably ask amrith to look tomorrow | 01:05 |
*** baoli has quit IRC | 01:05 | |
*** baoli has joined #openstack-nova | 01:07 | |
*** thorst has quit IRC | 01:11 | |
andreykurilin | mriedem: I think most of openstack projects, at least "integrated", uses manually created keystone session and transmit it to novaclient. Otherwise they should be broken, since keystone switched to V3 by default(I did not see a lot of complains about this switch) | 01:12 |
andreykurilin | So my patches for most cases are just cleanup(removing HTTPClient implementation) | 01:13 |
*** ducttape_ has quit IRC | 01:15 | |
*** liusheng has joined #openstack-nova | 01:15 | |
*** zhangyujun has joined #openstack-nova | 01:16 | |
oomichi | alex_xu: I put comments on https://review.openstack.org/#/c/389003 | 01:17 |
oomichi | alex_xu: I feel we are avoiding outputting logs related to BadRequest thing to avoid much logs on the server, | 01:18 |
andreykurilin | hm... It looks like I was wrong https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/trove/common/remote.py#L101 | 01:19 |
andreykurilin | mriedem: omg. Trove s*cks. They do not read any out warnings... https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/tools/trove-pylint.config#L363 | 01:22 |
*** zhangjl has joined #openstack-nova | 01:22 | |
andreykurilin | *our | 01:22 |
*** kevinz has joined #openstack-nova | 01:22 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: replace 'osapi_max_limit' with 'max_limit' https://review.openstack.org/412245 | 01:24 |
*** ducttape_ has joined #openstack-nova | 01:29 | |
*** yingjun has joined #openstack-nova | 01:37 | |
*** yuntongjin has joined #openstack-nova | 01:40 | |
*** yufei has joined #openstack-nova | 01:41 | |
*** tuanluong has joined #openstack-nova | 01:46 | |
*** trananhkma has joined #openstack-nova | 01:46 | |
*** yuntongjin has quit IRC | 01:49 | |
*** ducttape_ has quit IRC | 01:50 | |
*** elynn has joined #openstack-nova | 01:54 | |
*** thorst has joined #openstack-nova | 01:57 | |
*** elynn_ has joined #openstack-nova | 01:58 | |
*** thorst has quit IRC | 01:58 | |
*** elynn has quit IRC | 01:59 | |
*** zhs_ has joined #openstack-nova | 02:01 | |
*** gongysh has joined #openstack-nova | 02:07 | |
*** zz_dimtruck is now known as dimtruck | 02:08 | |
*** yuntongjin has joined #openstack-nova | 02:11 | |
*** zhangyujun has quit IRC | 02:11 | |
*** ducttape_ has joined #openstack-nova | 02:12 | |
*** fragatina has quit IRC | 02:17 | |
*** dimtruck is now known as zz_dimtruck | 02:18 | |
*** asettle has joined #openstack-nova | 02:22 | |
*** asettle has quit IRC | 02:26 | |
*** zhangyujun has joined #openstack-nova | 02:27 | |
*** yingjun has quit IRC | 02:28 | |
*** catintheroof has quit IRC | 02:28 | |
openstackgerrit | int32bit proposed openstack/nova: Fix wrong disk size for sparse flat files https://review.openstack.org/396873 | 02:29 |
*** catintheroof has joined #openstack-nova | 02:30 | |
*** catintheroof has quit IRC | 02:34 | |
*** ducttape_ has quit IRC | 02:37 | |
*** ducttape_ has joined #openstack-nova | 02:37 | |
openstackgerrit | int32bit proposed openstack/nova: Fix error if free_disk_gb is None in CellStateManager https://review.openstack.org/409501 | 02:37 |
*** yingjun has joined #openstack-nova | 02:42 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/nova: Removes unnecessary utf-8 encoding https://review.openstack.org/410054 | 02:50 |
*** ducttape_ has quit IRC | 02:52 | |
*** tbachman has joined #openstack-nova | 02:54 | |
*** baoli has quit IRC | 02:55 | |
*** yingjun has quit IRC | 02:56 | |
*** gouthamr has joined #openstack-nova | 02:56 | |
*** baoli has joined #openstack-nova | 02:57 | |
*** FL1SK has quit IRC | 03:00 | |
*** FL1SK has joined #openstack-nova | 03:01 | |
*** thorst has joined #openstack-nova | 03:03 | |
openstackgerrit | RocDove proposed openstack/python-novaclient: modified: novaclient/v2/servers.py https://review.openstack.org/412258 | 03:04 |
*** zz_dimtruck has quit IRC | 03:05 | |
*** Jeffrey4l has quit IRC | 03:05 | |
*** zz_dimtruck has joined #openstack-nova | 03:05 | |
*** Jeffrey4l has joined #openstack-nova | 03:05 | |
*** zz_dimtruck is now known as dimtruck | 03:06 | |
*** ediardo has quit IRC | 03:09 | |
*** yingjun has joined #openstack-nova | 03:09 | |
*** Nakato has quit IRC | 03:10 | |
*** Nakato has joined #openstack-nova | 03:10 | |
*** gouthamr has quit IRC | 03:11 | |
*** ediardo has joined #openstack-nova | 03:11 | |
*** noama has quit IRC | 03:12 | |
*** thorst has quit IRC | 03:12 | |
*** noama has joined #openstack-nova | 03:12 | |
*** kuzko has quit IRC | 03:14 | |
*** irenab_ has joined #openstack-nova | 03:15 | |
*** ducttape_ has joined #openstack-nova | 03:15 | |
*** kuzko has joined #openstack-nova | 03:15 | |
*** irenab has quit IRC | 03:17 | |
*** irenab_ is now known as irenab | 03:17 | |
*** frickler_ has joined #openstack-nova | 03:20 | |
*** frickler has quit IRC | 03:21 | |
*** elynn_ has quit IRC | 03:24 | |
*** elynn_ has joined #openstack-nova | 03:25 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port libvirt.test_vif to Python 3 https://review.openstack.org/403419 | 03:25 |
*** Prophidys has quit IRC | 03:25 | |
*** Prophidys has joined #openstack-nova | 03:26 | |
*** ducttape_ has quit IRC | 03:26 | |
*** mwhahaha has quit IRC | 03:26 | |
*** mwhahaha has joined #openstack-nova | 03:29 | |
*** baoli has quit IRC | 03:30 | |
*** baoli has joined #openstack-nova | 03:30 | |
*** baoli has quit IRC | 03:30 | |
alex_xu | oomichi: nice idea! | 03:31 |
*** elynn_ has left #openstack-nova | 03:31 | |
*** yingjun has quit IRC | 03:31 | |
alex_xu | oomichi: good point. so that is why there is option to turn that log off | 03:36 |
alex_xu | oomichi: the previous 'nice idea' point to the improvement of log message | 03:37 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Check destination_type when booting with bdm provided https://review.openstack.org/402372 | 03:40 |
*** nicolasbock has joined #openstack-nova | 03:53 | |
*** psachin has joined #openstack-nova | 03:53 | |
*** sudipto has joined #openstack-nova | 03:56 | |
*** thorst has joined #openstack-nova | 04:09 | |
*** marst has quit IRC | 04:11 | |
*** thorst has quit IRC | 04:18 | |
*** dimtruck is now known as zz_dimtruck | 04:18 | |
openstackgerrit | int32bit proposed openstack/nova: Add more actions to instance action logs https://review.openstack.org/396510 | 04:20 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port xenapi test_vm_utils to Python 3 https://review.openstack.org/401827 | 04:22 |
*** yuntongjin has quit IRC | 04:26 | |
*** ducttape_ has joined #openstack-nova | 04:26 | |
*** ducttape_ has quit IRC | 04:31 | |
*** baoli has joined #openstack-nova | 04:32 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/3) https://review.openstack.org/357105 | 04:32 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/3) https://review.openstack.org/408955 | 04:33 |
*** nicolasbock has quit IRC | 04:43 | |
*** zz_dimtruck is now known as dimtruck | 04:46 | |
*** siva_krish has joined #openstack-nova | 04:48 | |
*** prateek has joined #openstack-nova | 04:49 | |
*** Jeffrey4l has quit IRC | 04:53 | |
*** baoli has quit IRC | 04:53 | |
*** pbandark has joined #openstack-nova | 04:56 | |
oomichi | alex_xu: I feel the option should be disabled at the default at least | 04:59 |
*** ducttape_ has joined #openstack-nova | 05:00 | |
*** lpetrut has joined #openstack-nova | 05:04 | |
openstackgerrit | int32bit proposed openstack/nova: Add soft delete wrinkle to api-ref https://review.openstack.org/411440 | 05:11 |
openstackgerrit | int32bit proposed openstack/python-novaclient: Add CLI to show instance usage audit logs https://review.openstack.org/409413 | 05:12 |
openstackgerrit | int32bit proposed openstack/nova: Choose VMware datastore by the least provisioned space https://review.openstack.org/402632 | 05:12 |
*** sreeram_v has joined #openstack-nova | 05:14 | |
*** thorst has joined #openstack-nova | 05:15 | |
*** unicell1 has joined #openstack-nova | 05:16 | |
*** unicell has quit IRC | 05:16 | |
*** preethipy has joined #openstack-nova | 05:16 | |
*** preethi has joined #openstack-nova | 05:18 | |
*** sudipto has quit IRC | 05:18 | |
*** ratailor has joined #openstack-nova | 05:20 | |
*** preethipy has quit IRC | 05:21 | |
*** thorst has quit IRC | 05:22 | |
*** bks has joined #openstack-nova | 05:24 | |
*** hfu has joined #openstack-nova | 05:24 | |
*** lpetrut has quit IRC | 05:26 | |
*** diga has joined #openstack-nova | 05:31 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(3/3) https://review.openstack.org/408964 | 05:36 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.41 - Enable cold migration woth target host https://review.openstack.org/406707 | 05:37 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 05:37 |
*** ducttape_ has quit IRC | 05:39 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 05:40 |
*** sudipto has joined #openstack-nova | 05:47 | |
*** mdnadeem has joined #openstack-nova | 05:47 | |
*** yuntongjin has joined #openstack-nova | 05:47 | |
*** gcb has joined #openstack-nova | 05:49 | |
*** tojuvone has joined #openstack-nova | 05:53 | |
*** amotoki has joined #openstack-nova | 05:55 | |
*** amotoki has quit IRC | 05:58 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(3/3) https://review.openstack.org/408964 | 06:03 |
*** bkopilov has joined #openstack-nova | 06:04 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 06:04 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Remove unused validation code from block_device https://review.openstack.org/410006 | 06:06 |
*** jaosorior has joined #openstack-nova | 06:06 | |
*** ayogi has joined #openstack-nova | 06:07 | |
*** sridharg has joined #openstack-nova | 06:10 | |
alex_xu | oomichi: or we should let people notice the change first? | 06:13 |
oomichi | alex_xu: humm, I cannot catch your meaning.. Is that related to reno? | 06:13 |
alex_xu | oomichi: the option for the log | 06:14 |
alex_xu | oomichi: if we enable it by default, then people will be noticed there is a change | 06:14 |
alex_xu | oomichi: if they don't like it, they can turn it off. | 06:14 |
alex_xu | oomichi: if the option is disable default. I feel no-one will notice there is new option | 06:15 |
*** yingjun has joined #openstack-nova | 06:15 | |
oomichi | alex_xu: humm, it is better to avoid much logs which related to BadRequest on REST API layer basically | 06:15 |
alex_xu | oomichi: btw, sounds like you back to Japan, due to you didn't sleep now | 06:15 |
oomichi | alex_xu: yeah, gmann is back here :) | 06:16 |
alex_xu | oomichi: yea, agree with that, but thinking of the purpose of this option, it want to notice people there is a change | 06:16 |
*** yufei has quit IRC | 06:17 | |
alex_xu | oomichi: gmann back to Japan? I thought he was in Japan | 06:17 |
*** bkopilov has quit IRC | 06:17 | |
oomichi | alex_xu: hehe, after they know, they just start blaming us like "Why we should see much logs related to that?" | 06:17 |
oomichi | alex_xu: yeah, gmann is also in Japan now | 06:18 |
alex_xu | oomichi: then they notice that change, that is right our purpose | 06:18 |
*** amotoki has joined #openstack-nova | 06:18 | |
oomichi | alex_xu: I don't want to see blaming :-( | 06:18 |
alex_xu | oomichi: if we make it disable by default, I didn't see any reason why we want that option | 06:19 |
*** thorst has joined #openstack-nova | 06:19 | |
*** yufei has joined #openstack-nova | 06:21 | |
*** asettle has joined #openstack-nova | 06:23 | |
alex_xu | oomichi: also replied this patch https://review.openstack.org/#/c/398755/7 | 06:24 |
*** asettle has quit IRC | 06:27 | |
*** thorst has quit IRC | 06:28 | |
*** enginy has joined #openstack-nova | 06:32 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Fix misleading port delete description https://review.openstack.org/410582 | 06:32 |
*** yingjun has quit IRC | 06:33 | |
*** enginy has quit IRC | 06:34 | |
*** enginy has joined #openstack-nova | 06:35 | |
*** enginy has quit IRC | 06:36 | |
*** mnestratov has joined #openstack-nova | 06:36 | |
*** qwertyco has joined #openstack-nova | 06:36 | |
*** dimtruck is now known as zz_dimtruck | 06:37 | |
*** zerda2 has joined #openstack-nova | 06:42 | |
oomichi | johnthetubaguy: do you want to make the option enabled on the default with https://review.openstack.org/#/c/389003/15/nova/conf/api.py ? | 06:44 |
*** moshele has joined #openstack-nova | 06:48 | |
openstackgerrit | Alex Xu proposed openstack/nova: Use JSON-Schema to validate query parameters for keypairs API https://review.openstack.org/398755 | 06:48 |
openstackgerrit | Alex Xu proposed openstack/nova: Adds support for versioned schema validation for query parameters https://review.openstack.org/389003 | 06:48 |
*** lpetrut has joined #openstack-nova | 06:49 | |
*** ducttape_ has joined #openstack-nova | 06:57 | |
*** nherciu_ has joined #openstack-nova | 06:58 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Add some missing modules in API reference https://review.openstack.org/412315 | 06:59 |
*** oanson has joined #openstack-nova | 06:59 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Check destination_type when booting with bdm provided https://review.openstack.org/402372 | 07:00 |
*** ducttape_ has quit IRC | 07:02 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.41 - Enable cold migration woth target host https://review.openstack.org/406707 | 07:03 |
*** tbachman has quit IRC | 07:03 | |
*** mjura has joined #openstack-nova | 07:03 | |
*** tesseract has joined #openstack-nova | 07:04 | |
*** tesseract is now known as Guest33254 | 07:05 | |
*** mjura has quit IRC | 07:09 | |
*** mjura has joined #openstack-nova | 07:10 | |
*** amotoki has quit IRC | 07:10 | |
*** Oku_OS-away is now known as Oku_OS | 07:11 | |
*** yingjun has joined #openstack-nova | 07:15 | |
*** fragatina has joined #openstack-nova | 07:18 | |
*** baoli has joined #openstack-nova | 07:21 | |
*** sahid has joined #openstack-nova | 07:23 | |
*** thorst has joined #openstack-nova | 07:25 | |
*** baoli has quit IRC | 07:26 | |
*** amotoki has joined #openstack-nova | 07:32 | |
*** thorst has quit IRC | 07:33 | |
*** pcaruana has joined #openstack-nova | 07:33 | |
*** avolkov has joined #openstack-nova | 07:38 | |
*** takashin_ has joined #openstack-nova | 07:40 | |
*** andreas_s has joined #openstack-nova | 07:41 | |
*** takashin has quit IRC | 07:42 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | 07:44 |
openstackgerrit | zhangyanxian proposed openstack/nova-specs: Fix typo in same-instances-scheduling.rst https://review.openstack.org/412338 | 07:50 |
*** lpetrut has quit IRC | 07:50 | |
openstackgerrit | zhangyanxian proposed openstack/nova-specs: Fix typo in same-instances-scheduling.rst https://review.openstack.org/412338 | 07:51 |
lennyb | wznoinsk, pls review https://review.openstack.org/#/c/407958/ | 07:53 |
*** jaosorior has quit IRC | 07:58 | |
*** claudiub has joined #openstack-nova | 07:59 | |
*** tuanluong has quit IRC | 08:00 | |
tdurakov | sfinucan: hi, are you around? | 08:02 |
*** takashin_ has left #openstack-nova | 08:03 | |
*** ihrachys has joined #openstack-nova | 08:04 | |
*** amotoki has quit IRC | 08:06 | |
*** gongysh has quit IRC | 08:10 | |
Kevin_Zheng | ping oomichi | 08:16 |
oomichi | hello | 08:16 |
*** uu has joined #openstack-nova | 08:16 | |
oomichi | Kevin_Zheng: hi | 08:17 |
Kevin_Zheng | oomichi: Hi, I did a test after you left your comment | 08:17 |
oomichi | Kevin_Zheng: which one? | 08:17 |
oomichi | s/one/patch/ ? | 08:18 |
*** yingjun has quit IRC | 08:18 | |
Kevin_Zheng | the destination_type one | 08:19 |
Kevin_Zheng | DEBUG (session:342) REQ: curl -g -i -X POST http://10.3.150.17:8774/v2.1/os-volumes_boot -H "Accept: application/json" -H "User-Agent: python-novaclient" -H "OpenStack-API-Version: compute 2.37" -H "X-OpenStack-Nova-API-Version: 2.37" -H "X-Auth-Token: {SHA1}8cbcc4004bcc8e2acccfaaa4c0c8015657901267" -H "Content-Type: application/json" -d '{"server": {"name": | 08:19 |
Kevin_Zheng | "test3", "imageRef": "2ff3a1d3-ed70-4c3f-94ac-941461153bc0", "block_device_mapping_v2": [{"source_type": "image", "delete_on_termination": true, "boot_index": 0, "uuid": "2ff3a1d3-ed70-4c3f-94ac-941461153bc0", "destination_type": "local"}, {"source_type": "volume", "uuid": "99d92140-3d0c-4ea5-a49c-f94c38c607f0", "destination_type": "volume1"}], "flavorRef": | 08:19 |
Kevin_Zheng | "2", "max_count": 1, "min_count": 1, "networks": [{"uuid": "474cde7c-d959-46c1-a62e-4810058ba3a8"}]}}' | 08:19 |
Kevin_Zheng | ah maybe I can ping you in personal | 08:19 |
*** baoli has joined #openstack-nova | 08:22 | |
*** jaosorior has joined #openstack-nova | 08:24 | |
*** qwertyco has quit IRC | 08:24 | |
*** amotoki has joined #openstack-nova | 08:25 | |
*** avolkov has quit IRC | 08:26 | |
*** ducttape_ has joined #openstack-nova | 08:28 | |
*** thorst has joined #openstack-nova | 08:29 | |
*** ducttape_ has quit IRC | 08:33 | |
*** qwertyco has joined #openstack-nova | 08:36 | |
*** yuntongjin has quit IRC | 08:38 | |
*** thorst has quit IRC | 08:38 | |
*** masber has joined #openstack-nova | 08:39 | |
*** amotoki has quit IRC | 08:40 | |
*** avolkov has joined #openstack-nova | 08:44 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Added new fields in Diagnostics info https://review.openstack.org/412349 | 08:44 |
*** baoli has quit IRC | 08:45 | |
*** jaosorior has quit IRC | 08:45 | |
*** jaosorior has joined #openstack-nova | 08:46 | |
*** noama has quit IRC | 08:48 | |
*** pbandark has quit IRC | 08:49 | |
*** pbandark has joined #openstack-nova | 08:52 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Check destination_type when booting with bdm provided https://review.openstack.org/402372 | 08:53 |
*** rdo has quit IRC | 08:54 | |
sfinucan | tdurakov: I am now | 08:55 |
tdurakov | sfinucan: left a comment on https://review.openstack.org/#/c/410542/ already | 08:56 |
*** zzzeek has quit IRC | 09:00 | |
*** tuanluong has joined #openstack-nova | 09:01 | |
*** zzzeek has joined #openstack-nova | 09:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/412143 | 09:04 |
*** yamahata has quit IRC | 09:04 | |
*** hrw has joined #openstack-nova | 09:05 | |
hrw | hi | 09:05 |
openstackgerrit | Stephen Finucane proposed openstack/nova: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356 | 09:06 |
*** qwertyco has quit IRC | 09:06 | |
*** portdirect has joined #openstack-nova | 09:10 | |
*** roeyc has joined #openstack-nova | 09:11 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Always set MTU when plugging devices https://review.openstack.org/408781 | 09:11 |
*** tuanluong_ has joined #openstack-nova | 09:11 | |
*** sahid has quit IRC | 09:13 | |
*** sreeram_v has quit IRC | 09:15 | |
*** sreeram_v has joined #openstack-nova | 09:16 | |
*** sreeram_v has quit IRC | 09:20 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: relnotes: Fix config options deprecation notes https://review.openstack.org/375400 | 09:23 |
*** yassine has joined #openstack-nova | 09:23 | |
*** asettle has joined #openstack-nova | 09:23 | |
*** yassine is now known as Guest24205 | 09:23 | |
*** hrw has left #openstack-nova | 09:24 | |
openstackgerrit | Francesco Santoro proposed openstack/nova: bump os-vif min version https://review.openstack.org/411991 | 09:25 |
openstackgerrit | Francesco Santoro proposed openstack/nova: os-vif-util: set vif_name for vhostuser ovs os-vif port https://review.openstack.org/410737 | 09:25 |
openstackgerrit | Francesco Santoro proposed openstack/nova: os-vif: convert libvirt driver to use os-vif for fast path vhostuser https://review.openstack.org/385061 | 09:25 |
*** lucas-afk is now known as lucasagomes | 09:26 | |
*** yingjun has joined #openstack-nova | 09:26 | |
*** asettle has quit IRC | 09:28 | |
*** hieulq has joined #openstack-nova | 09:29 | |
*** gongysh has joined #openstack-nova | 09:31 | |
*** asettle has joined #openstack-nova | 09:32 | |
*** thorst has joined #openstack-nova | 09:35 | |
openstackgerrit | Alex Xu proposed openstack/nova: Use JSON-Schema to validate query parameters for keypairs API https://review.openstack.org/398755 | 09:37 |
openstackgerrit | Alex Xu proposed openstack/nova: Adds support for versioned schema validation for query parameters https://review.openstack.org/389003 | 09:37 |
*** rdo has joined #openstack-nova | 09:38 | |
alex_xu | snikitin: just in case I didn't clear in the review. I mean we should update api reference document http://developer.openstack.org/api-ref/compute/, the source is under https://github.com/openstack/nova/tree/master/api-ref/source. It isn't spec | 09:40 |
*** thorst has quit IRC | 09:42 | |
*** frickler_ is now known as frickler | 09:44 | |
*** yingjun has quit IRC | 09:45 | |
snikitin | alex_xu, Oh! now I understand. thank you I totally forgot about docs | 09:51 |
alex_xu | snikitin: np :) | 09:52 |
*** bkopilov has joined #openstack-nova | 09:52 | |
*** zenoway has joined #openstack-nova | 09:53 | |
*** Dinesh_Bhor has joined #openstack-nova | 09:54 | |
*** kashyap has joined #openstack-nova | 09:54 | |
*** amotoki has joined #openstack-nova | 09:56 | |
*** kevinz has quit IRC | 09:57 | |
*** ducttape_ has joined #openstack-nova | 09:58 | |
johnthetubaguy | oomichi: the worry was when admins get users complaining that their query has stop returning the results they are used to, there is at least a log you can look at to find out what happened | 09:59 |
*** tyrola has quit IRC | 10:00 | |
*** tyrola has joined #openstack-nova | 10:01 | |
*** pksingh has joined #openstack-nova | 10:01 | |
johnthetubaguy | oomichi: I am not sure if we need a configuration option to turn that off myself, we do add too many config options | 10:02 |
*** lpetrut has joined #openstack-nova | 10:03 | |
*** ducttape_ has quit IRC | 10:03 | |
*** amotoki has quit IRC | 10:06 | |
*** gongysh has quit IRC | 10:07 | |
*** bkopilov_ has joined #openstack-nova | 10:08 | |
*** amotoki has joined #openstack-nova | 10:09 | |
*** hfu has quit IRC | 10:15 | |
*** tuanluong has quit IRC | 10:16 | |
openstackgerrit | chenyingnan proposed openstack/nova: Port nova.cloudpipe.pipelib and nova.tests.unit.virt.xenapi.test_agent to Python 3 https://review.openstack.org/411676 | 10:17 |
*** sahid has joined #openstack-nova | 10:18 | |
*** trananhkma has quit IRC | 10:20 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Remove 'virt' file https://review.openstack.org/392566 | 10:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | 10:23 |
*** amotoki has quit IRC | 10:23 | |
*** Jeffrey4l has joined #openstack-nova | 10:24 | |
*** greeny___ has joined #openstack-nova | 10:29 | |
*** phuongnh has quit IRC | 10:38 | |
*** hoangcx has quit IRC | 10:38 | |
*** amotoki has joined #openstack-nova | 10:38 | |
*** thorst has joined #openstack-nova | 10:40 | |
*** derekh has joined #openstack-nova | 10:43 | |
*** bks has quit IRC | 10:43 | |
*** amotoki has quit IRC | 10:45 | |
*** thorst has quit IRC | 10:48 | |
*** greeny___ has quit IRC | 10:53 | |
*** tuanluong_ has quit IRC | 10:55 | |
*** ducttape_ has joined #openstack-nova | 11:03 | |
*** amoralej is now known as amoralej|brb | 11:05 | |
*** asettle has quit IRC | 11:05 | |
*** tbachman has joined #openstack-nova | 11:06 | |
*** sreeram_v has joined #openstack-nova | 11:06 | |
*** asettle has joined #openstack-nova | 11:09 | |
*** ociuhandu has joined #openstack-nova | 11:10 | |
*** sudipto has quit IRC | 11:10 | |
*** sreeram_v has quit IRC | 11:11 | |
*** cdent has joined #openstack-nova | 11:11 | |
*** ihrachys has quit IRC | 11:12 | |
*** asettle has quit IRC | 11:17 | |
*** yufei has quit IRC | 11:17 | |
*** ducttape_ has quit IRC | 11:21 | |
*** rfolco has joined #openstack-nova | 11:25 | |
*** dave-mccowan has joined #openstack-nova | 11:26 | |
*** pksingh has quit IRC | 11:28 | |
*** esmiurium has joined #openstack-nova | 11:30 | |
*** mnasiadka has joined #openstack-nova | 11:33 | |
*** ducttape_ has joined #openstack-nova | 11:33 | |
*** sdague has joined #openstack-nova | 11:33 | |
*** Dave has quit IRC | 11:33 | |
*** portdirect is now known as portdirect_away | 11:34 | |
*** pksingh has joined #openstack-nova | 11:36 | |
*** pksingh has quit IRC | 11:37 | |
*** nicolasbock has joined #openstack-nova | 11:38 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Docs: Added 'tags' to server show, update and detail responses https://review.openstack.org/412411 | 11:41 |
*** smatzek has joined #openstack-nova | 11:43 | |
*** ihrachys has joined #openstack-nova | 11:43 | |
*** baoli has joined #openstack-nova | 11:44 | |
*** tbachman has quit IRC | 11:44 | |
*** Dave has joined #openstack-nova | 11:45 | |
*** dave-mcc_ has joined #openstack-nova | 11:45 | |
*** thorst has joined #openstack-nova | 11:45 | |
*** tbachman has joined #openstack-nova | 11:45 | |
*** tbachman has quit IRC | 11:45 | |
*** baoli has quit IRC | 11:48 | |
*** dave-mccowan has quit IRC | 11:48 | |
*** ducttape_ has quit IRC | 11:49 | |
*** ratailor has quit IRC | 11:49 | |
*** Guest24205 has quit IRC | 11:52 | |
*** thorst has quit IRC | 11:52 | |
*** lucasagomes is now known as lucas-hungry | 11:55 | |
*** diga has quit IRC | 11:55 | |
*** ociuhandu has quit IRC | 11:57 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356 | 11:58 |
*** hfu has joined #openstack-nova | 11:59 | |
sfinucan | gcb: I think I have all of the goal-python35 changes reviewed now. Just three that need another look at | 12:00 |
*** gszasz has joined #openstack-nova | 12:07 | |
*** kevinz has joined #openstack-nova | 12:09 | |
*** Jeffrey4l has quit IRC | 12:10 | |
gcb | sfinucan, thanks. I still have at least patches to submit | 12:10 |
*** zhangjl has left #openstack-nova | 12:11 | |
gcb | sfinucan, will address your comments later | 12:11 |
*** thorst has joined #openstack-nova | 12:15 | |
*** amoralej|brb is now known as amoralej | 12:15 | |
*** catintheroof has joined #openstack-nova | 12:18 | |
*** ducnc has quit IRC | 12:18 | |
*** dave-mcc_ has quit IRC | 12:18 | |
*** ducnc has joined #openstack-nova | 12:18 | |
openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | 12:21 |
*** prateek has quit IRC | 12:24 | |
*** rtheis has joined #openstack-nova | 12:25 | |
*** yingjun has joined #openstack-nova | 12:27 | |
*** portdirect_away is now known as portdirect | 12:29 | |
*** hfu has quit IRC | 12:31 | |
*** hfu has joined #openstack-nova | 12:33 | |
*** vladikr has joined #openstack-nova | 12:37 | |
openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: [WIP] Add version field to LibvirtLiveMigrateData https://review.openstack.org/404607 | 12:38 |
*** hfu has quit IRC | 12:40 | |
*** bkopilov has quit IRC | 12:42 | |
*** bkopilov_ has quit IRC | 12:42 | |
*** portdirect is now known as portdirect_away | 12:43 | |
*** Jeffrey4l has joined #openstack-nova | 12:43 | |
*** baoli has joined #openstack-nova | 12:44 | |
*** flaper87 has joined #openstack-nova | 12:45 | |
*** siva_krish has quit IRC | 12:45 | |
wznoinsk | lennyb, reviewed | 12:47 |
*** vladikr has quit IRC | 12:47 | |
lennyb | wznoinsk, 10x | 12:47 |
*** ducttape_ has joined #openstack-nova | 12:49 | |
*** baoli has quit IRC | 12:49 | |
*** preethi has quit IRC | 12:53 | |
*** ducttape_ has quit IRC | 12:54 | |
*** siva_krish has joined #openstack-nova | 12:56 | |
*** ociuhandu has joined #openstack-nova | 12:58 | |
*** gibi has quit IRC | 12:59 | |
*** moshele has quit IRC | 13:01 | |
*** lucas-hungry is now known as lucasagomes | 13:01 | |
*** moshele has joined #openstack-nova | 13:01 | |
*** tbachman has joined #openstack-nova | 13:03 | |
*** yassine has joined #openstack-nova | 13:05 | |
sahid | dansmith: can you have a look at this serie https://review.openstack.org/#/c/408240/ - so i can rebase the work for emulator threads on top of it | 13:05 |
*** yassine is now known as Guest95167 | 13:06 | |
*** tbachman has quit IRC | 13:08 | |
*** hfu has joined #openstack-nova | 13:08 | |
*** portdirect_away is now known as portdirect | 13:09 | |
*** dbutts29 has joined #openstack-nova | 13:11 | |
*** lamt has quit IRC | 13:12 | |
*** gcb has quit IRC | 13:14 | |
*** rfolco has quit IRC | 13:16 | |
*** rfolco has joined #openstack-nova | 13:17 | |
*** tbachman has joined #openstack-nova | 13:21 | |
*** asettle has joined #openstack-nova | 13:22 | |
*** rfolco has quit IRC | 13:23 | |
*** jwcroppe_ has quit IRC | 13:26 | |
*** gouthamr has joined #openstack-nova | 13:26 | |
*** jaypipes has joined #openstack-nova | 13:27 | |
*** pradk has joined #openstack-nova | 13:31 | |
*** prateek has joined #openstack-nova | 13:31 | |
*** weshay_lata is now known as weshay | 13:31 | |
sdague | sahid: I think dansmith is out for the rest of the year | 13:32 |
*** rfolco has joined #openstack-nova | 13:33 | |
*** rfolco has quit IRC | 13:33 | |
*** rfolco has joined #openstack-nova | 13:33 | |
*** gcb has joined #openstack-nova | 13:36 | |
*** noama has joined #openstack-nova | 13:37 | |
*** portdirect has quit IRC | 13:38 | |
*** jheroux has joined #openstack-nova | 13:39 | |
*** noama has left #openstack-nova | 13:39 | |
alex_xu | johnthetubaguy: sdague, oomichi , hi, looks like we have different opinion about the config for invalid query message log https://review.openstack.org/#/c/389003/17, it will be great to have quick discussion if you are online | 13:39 |
sdague | alex_xu: sure | 13:41 |
johnthetubaguy | alex_xu: I am around | 13:41 |
alex_xu | as i know oomichi back to Japan, probably it is late for him | 13:42 |
sdague | ok, so the idea of logging the invalid content was a last minute add that I had | 13:42 |
sdague | it feels like *if* we do that, we should make it easy to turn off, because it could be really noisey | 13:42 |
sdague | johnthetubaguy: I think you were objecting to the conf value, but that's why I had suggested it | 13:42 |
alex_xu | I +1 for noisey | 13:42 |
sdague | I also agree with johnthetubaguy that WARN is way too high a value | 13:43 |
sdague | I guess I also wonder if there is enough information in the log message to make it worth while at all, because the idea was that the operators that care would be able to tell their users their app was wrong | 13:43 |
sdague | but that's going to require having a pretty detailed request log, including client IP / user-agent logged with this | 13:44 |
sdague | to the point that maybe we take this logging out of this patch all together, just keep with the old validation, and think about communicating things are wrong in January? | 13:45 |
johnthetubaguy | thats true, I had assumed everyone had that info for every request-id already | 13:45 |
johnthetubaguy | sdague: thats quite a good idea, we could punt on that for now | 13:45 |
*** baoli has joined #openstack-nova | 13:45 | |
johnthetubaguy | lets not block the good stuff on getting the logging right | 13:45 |
*** erhudy has joined #openstack-nova | 13:45 | |
alex_xu | cool :) | 13:46 |
alex_xu | sdague: do you mean remove the log and config for now? | 13:46 |
alex_xu | I think so, I didn't read wrong | 13:46 |
sdague | alex_xu: yeh | 13:46 |
alex_xu | oh yeah \o/ | 13:46 |
sdague | alex_xu: make it a dedicated patch after the existing ones | 13:46 |
*** clenimar has joined #openstack-nova | 13:46 | |
alex_xu | got it | 13:46 |
sdague | we can get the rest of this in, and talk about that piece later | 13:46 |
alex_xu | ok | 13:47 |
alex_xu | johnthetubaguy: sdague thanks | 13:47 |
sdague | alex_xu: thanks for driving this | 13:47 |
alex_xu | sdague: np | 13:47 |
*** mdnadeem has quit IRC | 13:49 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: WIP: testing LM grenade job https://review.openstack.org/411662 | 13:49 |
*** pbandark has quit IRC | 13:50 | |
sdague | cdent: when you have a chance, if you want to see that I got the placement API status checking right - https://review.openstack.org/#/c/411883/4/nova/cmd/status.py | 13:50 |
*** baoli has quit IRC | 13:50 | |
*** ducttape_ has joined #openstack-nova | 13:50 | |
cdent | sdague: certainly, will look at that asap | 13:51 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: WIP: testing LM grenade job https://review.openstack.org/411662 | 13:51 |
*** jwcroppe has joined #openstack-nova | 13:51 | |
*** diga has joined #openstack-nova | 13:55 | |
*** ducttape_ has quit IRC | 13:55 | |
jaypipes | edleafe-: we doing scheduler meeting today? can't remember if we cancelled it for the year... | 13:58 |
cdent | jaypipes, edleafe- I remember "if we feel like it and people are around" | 13:59 |
jaypipes | mriedem: thx for fixing up that one docstring comment on my patch over the weekend. | 14:03 |
*** hfu has quit IRC | 14:06 | |
*** sudipto has joined #openstack-nova | 14:08 | |
*** ayogi has quit IRC | 14:09 | |
*** amoralej is now known as amoralej|lunch | 14:10 | |
sahid | sdague: hum that is unfortunate, he asked me to make some clean before moving forward with my spec emulator threads https://review.openstack.org/#/c/400874/5/nova/objects/instance_numa_topology.py | 14:10 |
*** xyang1 has joined #openstack-nova | 14:11 | |
*** lamt has joined #openstack-nova | 14:12 | |
*** yogesh_ has joined #openstack-nova | 14:12 | |
*** yogesh_ has quit IRC | 14:12 | |
*** cleong has joined #openstack-nova | 14:14 | |
*** bkopilov has joined #openstack-nova | 14:15 | |
*** cdent has quit IRC | 14:16 | |
*** bkopilov_ has joined #openstack-nova | 14:16 | |
*** preethipy has joined #openstack-nova | 14:16 | |
*** moshele has quit IRC | 14:17 | |
sfinucan | sahid: I'll take a gawk now, but I'm not dansmith :) | 14:18 |
*** baoli has joined #openstack-nova | 14:19 | |
*** sdague_ has joined #openstack-nova | 14:21 | |
*** sdague has quit IRC | 14:24 | |
*** pradk has quit IRC | 14:25 | |
*** baoli has quit IRC | 14:25 | |
*** sdague_ is now known as sdague | 14:27 | |
*** preethipy has quit IRC | 14:27 | |
*** boggle has joined #openstack-nova | 14:28 | |
bauzas | sdague: hola, just a silly question | 14:28 |
bauzas | sdague: why are you adding https://review.openstack.org/#/c/409871/2/features.yaml@243 ? | 14:28 |
*** preethipy has joined #openstack-nova | 14:28 | |
openstackgerrit | Alex Xu proposed openstack/nova: Use JSON-Schema to validate query parameters for keypairs API https://review.openstack.org/398755 | 14:29 |
openstackgerrit | Alex Xu proposed openstack/nova: Adds support for versioned schema validation for query parameters https://review.openstack.org/389003 | 14:29 |
openstackgerrit | Alex Xu proposed openstack/nova: Refactor the code to add generic schema validation helper https://review.openstack.org/412473 | 14:29 |
sdague | bauzas: how do you tell a subnode that it should be configured with placement credentials? | 14:29 |
bauzas | sdague: I can see it's related to a "subnode" but I need to understand a bit more of the d-g logic | 14:29 |
sdague | see - https://review.openstack.org/#/c/411510/ | 14:29 |
*** baoli has joined #openstack-nova | 14:29 | |
bauzas | sdague: ah, thanks, that was the puzzle piece I was missing | 14:30 |
sdague | it was in the Depends-On :) | 14:31 |
bauzas | I missed that | 14:31 |
*** ducttape_ has joined #openstack-nova | 14:32 | |
*** psachin has quit IRC | 14:37 | |
*** esberglu has joined #openstack-nova | 14:38 | |
*** mnasiadka has quit IRC | 14:38 | |
*** smatzek has quit IRC | 14:39 | |
mriedem | andreykurilin: so does trove break with the latest novaclient code? | 14:41 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: DO NOT MERGE THE STEGOSAURUS ___________________________________ < I'M DEBUGGING THE LM+GRENADE GATE > ----------------------------------- \ . . \ / `. .' " \ .---. < https://review.openstack.org/411662 | 14:42 |
*** ducttape_ has quit IRC | 14:42 | |
*** jamesdenton has joined #openstack-nova | 14:42 | |
andreykurilin | mriedem: hi! based on the code which I saw there, trove doesn't work with https://github.com/openstack/python-novaclient/releases/tag/3.0.0 which was cut during mitaka cycle(it is even not the latest version of mitaka) | 14:43 |
*** yingjun has quit IRC | 14:44 | |
mriedem | andreykurilin: well, they might just not use the v1_1 module and don't actually get the warning from pylint anymore | 14:44 |
*** liverpooler has joined #openstack-nova | 14:44 | |
mriedem | if they are using upper-constraints in their ci jobs they are testing against novaclient 6.0.0 | 14:44 |
andreykurilin | mriedem: I think it is our fault, since we did not raise novaclient version for a long time https://github.com/openstack/requirements/blob/master/global-requirements.txt#L225 | 14:44 |
mriedem | andreykurilin: that's not what we test against thogh | 14:45 |
mriedem | *though | 14:45 |
andreykurilin | mriedem: they use unexist module - https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/trove/common/single_tenant_remote.py#L22 | 14:45 |
mriedem | hmm, they are testing against novaclient 6.0.0 though http://logs.openstack.org/99/412299/1/check/gate-tempest-dsvm-trove-ubuntu-xenial/c75e3cc/logs/pip2-freeze.txt.gz | 14:46 |
mriedem | so i don't see how any of that would be passing | 14:46 |
*** prateek has quit IRC | 14:46 | |
andreykurilin | mriedem: well, they have several modules which initialize novaclient. one of them is fully broken. another one looks ok to me - https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/trove/common/remote.py#L25 . It should not be broken(initialization looks good to me) | 14:47 |
mriedem | andreykurilin: i have a feeling that code isn't used http://git.openstack.org/cgit/openstack/trove/tree/trove/common/cfg.py#n325 | 14:48 |
mriedem | yeah that's the one that's used in the config | 14:48 |
mriedem | i agree that https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/trove/common/single_tenant_remote.py#L22 is broken and it's not tested | 14:48 |
mriedem | it's probably faked out | 14:48 |
andreykurilin | mriedem: and they do not transmit session to novaclient in remote.py, so my patches should help trove to support keystone v3:) | 14:48 |
*** burt has joined #openstack-nova | 14:49 | |
mriedem | i'll report a bug on the other busted code | 14:49 |
*** liverpooler has quit IRC | 14:49 | |
*** boggle has quit IRC | 14:49 | |
andreykurilin | mriedem: hm... https://github.com/openstack/trove/blob/48dcbb6dcd1b120e668d8330104a6c63a3c01a96/trove/common/remote.py#L104 this line is wrong and doesn't work any more. it looks like it is originaly was a bad behaviour and it is better to fix it at trove side | 14:50 |
*** kevinz has quit IRC | 14:50 | |
*** liverpooler has joined #openstack-nova | 14:51 | |
*** shaner_ has quit IRC | 14:51 | |
*** prateek has joined #openstack-nova | 14:52 | |
*** shaner has joined #openstack-nova | 14:52 | |
mriedem | nice | 14:52 |
mriedem | andreykurilin: anyway https://bugs.launchpad.net/trove/+bug/1651154 | 14:52 |
openstack | Launchpad bug 1651154 in OpenStack DBaaS (Trove) "ImportError for novaclient v1_1 in trove/common/single_tenant_remote.py" [Undecided,New] | 14:52 |
andreykurilin | mriedem: despite the fact that it is too late, I think we should update min version of novaclient for mitaka, newton and for master too | 14:52 |
*** eharney has joined #openstack-nova | 14:53 | |
mriedem | we aren't going to bump the minimum required versions of novaclient for mitaka or newton at this point | 14:53 |
mriedem | bumping minimum required versions of dependencies in stable is a big no-no | 14:53 |
andreykurilin | ok | 14:55 |
*** cfriesen has joined #openstack-nova | 14:55 | |
pkoniszewski | mriedem: hi, i did some more debugging of the LM+grenade gate, currently i'm stuck on this https://review.openstack.org/#/c/393441/ grenade change, I wonder whether this could break RPC somehow | 14:55 |
mriedem | sdague: on https://review.openstack.org/#/c/411883/ i was wondering what your thoughts were on testing the placement API parts of that? mock out the calls or use an actual API fixture like we have elsewhere in functional tests? | 14:55 |
andreykurilin | sdague: but at least for master, I hope we will raise min version :) | 14:55 |
*** cdent has joined #openstack-nova | 14:55 | |
*** tbachman_ has joined #openstack-nova | 14:55 | |
*** jamielennox is now known as jamielennox|away | 14:56 | |
*** tbachman has quit IRC | 14:56 | |
*** tbachman_ is now known as tbachman | 14:56 | |
mriedem | andreykurilin: but to what min version? | 14:56 |
*** amoralej|lunch is now known as amoralej | 14:56 | |
pkoniszewski | mriedem: I can see that live migration pre checks work, but the message to start pre_live_migration is lost | 14:56 |
mriedem | usually you don't raise the minimum until something actually requires a higher minimum for like a feature or a fix | 14:56 |
mriedem | cdent: thanks for the review on https://review.openstack.org/#/c/411883/ - you don't have to +1 though, it's a wip :) | 14:57 |
sdague | mriedem: honestly, I would do it with mocks. I can write that test class if you like | 14:57 |
*** mdnadeem has joined #openstack-nova | 14:57 | |
sdague | mostly I wrote the code by walking through devstack setup one step at a time | 14:57 |
sdague | and seeing the failures | 14:58 |
mriedem | sdague: yeah i pulled it down and played with some of that too | 14:58 |
mriedem | starting w/o placement, and then with placement but no auth config | 14:58 |
andreykurilin | mriedem: ideally, to uncoming release:) Imo, all releases between min and max should be compatible. Now we have several big releases which are not compatible at all. It is impossible to implement several use cases by one way which will work with all these versions | 14:58 |
cdent | mriedem: I like reviewing wips: sooner sanity gets checkec the sooner the insane can stop. | 14:58 |
sdague | mriedem: so, I'll to the test file you have here - https://review.openstack.org/#/c/411525/6 and explain how to reconstruct that in the "real" world | 14:58 |
mriedem | sdague: doesn't matter to me which of us writes the test class, i was going to work on the api/cell db query comparisons today | 14:58 |
*** sudipto has quit IRC | 14:59 | |
mriedem | sdague: sure, throw it in it's own test class | 14:59 |
andreykurilin | mriedem: In future, I think min version should be equal to version that supports all features from specific openstack release. | 14:59 |
mriedem | so when we drop these it's a clean drop | 14:59 |
*** sudipto has joined #openstack-nova | 14:59 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: Remove 'virt' file https://review.openstack.org/392566 | 14:59 |
sdague | mriedem: will do | 14:59 |
*** sudipto has quit IRC | 14:59 | |
cdent | mriedem: and besides I gotta keep up my "+1s later minused by a core" stats | 14:59 |
*** sudipto has joined #openstack-nova | 14:59 | |
*** sudipto_ has joined #openstack-nova | 15:00 | |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | 15:00 |
*** sudipto_ has quit IRC | 15:00 | |
*** sudipto has quit IRC | 15:00 | |
*** sudipto has joined #openstack-nova | 15:00 | |
*** eharney has quit IRC | 15:00 | |
*** sudipto has quit IRC | 15:00 | |
*** sudipto has joined #openstack-nova | 15:01 | |
*** sudipto_ has joined #openstack-nova | 15:01 | |
openstackgerrit | int32bit proposed openstack/nova: Add unit test for extract_snapshot with compression enabled https://review.openstack.org/412485 | 15:02 |
*** smatzek has joined #openstack-nova | 15:02 | |
mriedem | pkholkin: you were asking for things to work on, this hasn't started but was re-approved from newton https://blueprints.launchpad.net/nova/+spec/validate-project-with-keystone | 15:02 |
mriedem | pkholkin: or this https://blueprints.launchpad.net/nova/+spec/virt-device-tagged-attach-detach - might want to ask artom if he's going to start that? | 15:03 |
mriedem | pkholkin: or this https://blueprints.launchpad.net/nova/+spec/vendordata-reboot-ocata | 15:03 |
mriedem | pkholkin: order of importance in my mind on those would be vendordata, keystone project validation, then attach/detach tagged devices | 15:04 |
*** pradk has joined #openstack-nova | 15:04 | |
mriedem | sdague: ooo you didn't even question my enum34 usage :) | 15:05 |
*** jamesdenton has quit IRC | 15:07 | |
pkholkin | mriedem: oh thanks Matt! I will look these specs | 15:07 |
pkholkin | maybe will take smth for me ) | 15:08 |
*** zz_dimtruck is now known as dimtruck | 15:10 | |
*** eharney has joined #openstack-nova | 15:14 | |
openstackgerrit | int32bit proposed openstack/nova: Add unit test for extract_snapshot with compression enabled https://review.openstack.org/412485 | 15:14 |
*** liverpooler has quit IRC | 15:15 | |
*** liverpooler has joined #openstack-nova | 15:15 | |
sdague | mriedem: meh, seems like the cool kids all want to do it | 15:16 |
*** ducttape_ has joined #openstack-nova | 15:17 | |
*** tbachman has quit IRC | 15:17 | |
*** sshen has quit IRC | 15:19 | |
mriedem | sdague: i do prefer proper enums over hacky int constants :) | 15:19 |
*** preethipy has quit IRC | 15:19 | |
mriedem | that's why i went with it | 15:19 |
sdague | I'm most amused that apparently we have python 2.6 markers for it | 15:19 |
mriedem | even old school c guys could appreciate that | 15:20 |
mriedem | yeah i saw that | 15:20 |
mriedem | would have removed but you know, reqs | 15:20 |
sdague | ok, I'm all through with my mandatory training in the cyber, which I hear is going to be very big | 15:20 |
sdague | so I'll do those unit tests | 15:21 |
bauzas | oh that's fun, someone pointed out internally how the Hilton is far cheaper than the Sheraton for the Atlanta PTG | 15:25 |
bauzas | we're talking of $120 vs. $185 | 15:26 |
*** dirk has left #openstack-nova | 15:27 | |
mriedem | sdague: mandatory training in the cyber? | 15:29 |
*** mlavalle has joined #openstack-nova | 15:29 | |
mriedem | oh | 15:29 |
mriedem | security | 15:29 |
mriedem | the fate of our company rests on your shoulders sdague | 15:29 |
mriedem | don't click those links | 15:29 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | 15:32 |
andreykurilin | mriedem: https://review.openstack.org/412497 should fix trove to work with old and new novaclient releases | 15:33 |
*** marst has joined #openstack-nova | 15:34 | |
mriedem | looking for another core to go through the first 3 changes in this series https://review.openstack.org/#/c/398470/ i'm +2 on the bottom 3 | 15:37 |
mriedem | would be good to move those along as it's a large refactor so prone to rebase issues | 15:38 |
mriedem | andreykurilin: heh, have you ever noticed that this is a method and not a class? https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L275 | 15:40 |
mriedem | it's a factory so i guess that makes sense, just the Client bit has always thrown me | 15:41 |
*** weshay is now known as weshay_afk | 15:41 | |
*** aarefiev is now known as aarefiev_afk | 15:41 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Objectify requests_and_created_ports https://review.openstack.org/405398 | 15:41 |
andreykurilin | mriedm: sure, I know that. My first work in OpenStack was about unification all clients, so I spent a lot of time discovering them :) Btw, several clients named such method just like "get_client", but I prefer "Client" for entrypoint | 15:42 |
*** int32bit has joined #openstack-nova | 15:44 | |
*** baoli has quit IRC | 15:44 | |
*** prateek has quit IRC | 15:44 | |
*** baoli has joined #openstack-nova | 15:45 | |
*** weshay_afk is now known as weshay | 15:45 | |
*** mtanino has joined #openstack-nova | 15:50 | |
*** lbeliveau has quit IRC | 15:50 | |
*** lbeliveau has joined #openstack-nova | 15:51 | |
*** Sukhdev has joined #openstack-nova | 15:51 | |
dansmith | sahid: I am not here | 15:52 |
jroll | what a bum | 15:52 |
dansmith | sahid: I also meant that cleanup patch could come after your real set.. bonus points for rebasing on the cleanup, but not critical | 15:52 |
andreykurilin | mriedem: http://docs.openstack.org/developer/python-novaclient/ref/v2/index.html omg...we still have v1.1 reference in docs... | 15:53 |
*** Sukhdev has quit IRC | 15:53 | |
*** yamahata has joined #openstack-nova | 15:53 | |
mriedem | andreykurilin: heh yeah that's an easy cleanup | 15:54 |
mriedem | it's in doc/source/conf.py i think | 15:54 |
*** yamahata has quit IRC | 15:56 | |
bauzas | sdague: do you feel we would still need to update devstack for running the placement service by default ? | 15:56 |
bauzas | sdague: or is the d-g change only needed ? | 15:56 |
bauzas | I tend to think about the former | 15:57 |
*** yamahata has joined #openstack-nova | 15:57 | |
sahid | dansmith: ah cool happy to hear that so at least i can continue to expect to get reviews on the features then i will rebase the work done to clean the numa objects | 15:57 |
sdague | bauzas: we do need to *also* update devstack | 15:57 |
sdague | but the d-g change should go first | 15:58 |
openstackgerrit | Sean Dague proposed openstack/nova: nova-status: add basic placement status checking https://review.openstack.org/411883 | 15:58 |
sdague | mriedem: ^^^ | 15:58 |
sdague | I think that's about right | 15:58 |
mriedem | sdague: cool | 15:59 |
*** dimtruck is now known as zz_dimtruck | 15:59 | |
mriedem | bauzas: there is a default ENABLED_SERVICES in stackrc i think which could be updated independenty of sean's changes | 15:59 |
*** mvk has quit IRC | 16:00 | |
bauzas | mriedem: sdague: okay, I'll write that change then, I just wanted to doublecheck | 16:00 |
bauzas | mriedem: yeah, I was thinking about that one | 16:00 |
*** _ducttape_ has joined #openstack-nova | 16:00 | |
sdague | ok, d-g change is approved now | 16:02 |
* mriedem wishes gerrit had an 'expand all common lines' button | 16:02 | |
*** Guest33254 has quit IRC | 16:02 | |
*** roeyc has quit IRC | 16:03 | |
*** ratailor has joined #openstack-nova | 16:03 | |
mriedem | ooo there is one | 16:03 |
*** Sukhdev_ has joined #openstack-nova | 16:03 | |
*** ducttape_ has quit IRC | 16:04 | |
*** sdague has quit IRC | 16:06 | |
*** diga has quit IRC | 16:08 | |
*** keekz has quit IRC | 16:09 | |
*** schegi has quit IRC | 16:10 | |
*** schegi has joined #openstack-nova | 16:10 | |
*** hongbin has joined #openstack-nova | 16:10 | |
*** zz_dimtruck is now known as dimtruck | 16:10 | |
*** mjura has quit IRC | 16:11 | |
*** keekz has joined #openstack-nova | 16:11 | |
*** pcaruana has quit IRC | 16:15 | |
*** sreeram_v has joined #openstack-nova | 16:17 | |
*** sridharg has quit IRC | 16:20 | |
mriedem | jaypipes: how does RT.disabled ever return True? | 16:21 |
mriedem | given in update_available_resource we either have a compute node or we create one | 16:21 |
*** sreeram_v has quit IRC | 16:22 | |
*** zenoway has quit IRC | 16:24 | |
*** browne has joined #openstack-nova | 16:24 | |
*** cdent has quit IRC | 16:26 | |
jaypipes | mriedem: it returns True if things like instance_claim() are called before update_available_resource()./ | 16:26 |
*** tjones has joined #openstack-nova | 16:26 | |
mriedem | that seems...wrong | 16:27 |
mriedem | like, see https://review.openstack.org/#/c/398473/15/nova/compute/resource_tracker.py@121 | 16:27 |
mriedem | "# compute_driver doesn't support resource tracking" | 16:27 |
*** _ducttape_ has quit IRC | 16:27 | |
*** ducttape_ has joined #openstack-nova | 16:28 | |
jaypipes | mriedem: the disabled() thing really hasn't meant "doesn't support resource tracking" ever :) It was a leftover remnant of when we conflated the Service object (and servicegroup API) with the ComputeNode object. | 16:29 |
jaypipes | mriedem: at this point, it's more of a vestigial tail, but what I'm changing in this patch doesn't change the existing behaviour. That code comment is just wrong... | 16:29 |
mriedem | yeah i figured it meant, is the service record related to this compute node enabled or disabled | 16:29 |
mriedem | and shouldn't have claims made against it | 16:29 |
jaypipes | it used to be, yes. | 16:29 |
jaypipes | it used to mean that, yes' | 16:30 |
mriedem | ok...making notes inline | 16:31 |
mriedem | if we actually have a case where instance_claim can be called before update_available_resource, i'd think we should call update_available_resource from instance_claim rather than do a noop claim on the host | 16:32 |
mriedem | but i thought update_available_resource was called when the compute service started up | 16:32 |
mriedem | yeah pre_start_hook in compute manager | 16:32 |
jaypipes | mriedem: it is, yes. | 16:32 |
mriedem | so this disabled thing just all seems like malarky | 16:33 |
mriedem | and we'll just torch that at some point? | 16:33 |
*** moshele has joined #openstack-nova | 16:33 | |
jaypipes | mriedem: yes sir. | 16:34 |
*** smatzek has quit IRC | 16:34 | |
mriedem | ok i just wanted to be able to say malarkey | 16:34 |
*** weshay is now known as weshay_bbiab | 16:34 | |
jaypipes | mriedem: the check for disablement really should be in the nova.compute.manager.Manager class. | 16:34 |
jaypipes | mriedem: which is the thing that == the Service object == the servicegroup API. | 16:35 |
mriedem | and then we wouldn't erroneously recreate deleted compute nodes after you disabled the service via the REST API | 16:35 |
mriedem | and end up with ComputeNodeNotFound errors later | 16:35 |
mriedem | when listing services | 16:35 |
*** Oku_OS is now known as Oku_OS-away | 16:35 | |
jaypipes | mriedem: right. | 16:36 |
mriedem | ew, test_compute mucking with RT internals | 16:37 |
mriedem | that's fun | 16:37 |
*** smatzek has joined #openstack-nova | 16:38 | |
jaypipes | mriedem: yuuuup. :( | 16:39 |
*** Sukhdev_ has quit IRC | 16:39 | |
*** dbutts29 has quit IRC | 16:40 | |
andreaf | mriedem, sdague: it looks like https://bugs.launchpad.net/tempest/+bug/1646779 and https://bugs.launchpad.net/nova/+bug/1643911 may be different manifestations of the same issue - they both happen around the same tests in Tempest, and they both relate to a libvirt crash, even though it manifests in three different way | 16:42 |
openstack | Launchpad bug 1646779 in OpenStack Compute (nova) "libvirt killed by kernel on general protection or stack segment traps" [Undecided,Incomplete] | 16:42 |
openstack | Launchpad bug 1643911 in OpenStack Compute (nova) "libvirt randomly crashes on xenial nodes with "*** Error in `/usr/sbin/libvirtd': malloc(): memory corruption:"" [Medium,Confirmed] | 16:42 |
andreaf | memory corruption, general protection or stack segment traps | 16:43 |
andreaf | mriedem, sdague: I tried to reproduce the issue on my VM but unsuccessfully so far | 16:44 |
andreaf | would it be ok to merge the two issues? I have an e-r query merged now for one the two, I could extend the query | 16:44 |
mriedem | jaypipes: 2 tiny things in https://review.openstack.org/#/c/398473/ - do you want me to just address them quick so you don't get lost in the comments? | 16:44 |
lbeliveau | jaypipes: hi, would you have time to look at my rt bug ? https://review.openstack.org/#/c/405575/ | 16:45 |
andreaf | actually there is a e-r query for both issues already | 16:46 |
*** jaosorior has quit IRC | 16:48 | |
jaypipes | mriedem: nope, I'm actually addressiong the WIP patch at the HEAD of that series, so I'll do that in a rebase to master shortly. | 16:48 |
mriedem | ok | 16:48 |
jaypipes | lbeliveau: yup, soon as I finish up what I'm on right this second. | 16:48 |
lbeliveau | jaypipes: no rush :) | 16:48 |
*** jaosorior has joined #openstack-nova | 16:48 | |
jaypipes | mriedem: I'm adding the "auto-create these Ironic node resource classes in the placement API" stuff. | 16:49 |
jaypipes | mriedem: as requested by yourself and jroll in the ML thread on the topic. | 16:50 |
*** Guest95167 has quit IRC | 16:50 | |
*** yassine has joined #openstack-nova | 16:50 | |
*** tbachman has joined #openstack-nova | 16:51 | |
mriedem | ok, i'm in nova/cinder meeting fun times for the next hour, then will come back | 16:51 |
*** yassine is now known as Guest45867 | 16:51 | |
openstackgerrit | Akshil Verma proposed openstack/python-novaclient: Fixed the __ne__ implementation in base.Resource https://review.openstack.org/409549 | 16:51 |
*** cdent has joined #openstack-nova | 16:56 | |
cdent | jaypipes: I'm not sure what the right thing is on that latest not latest question I raised. Mentioned it because I simply dunno. | 16:57 |
jaypipes | cdent: I'd actually prefer to leave it at latest... it's for non-scheduler-report-client clients that I think is important to specify. | 16:58 |
cdent | that's cool with me | 16:59 |
*** ratailor has quit IRC | 17:01 | |
*** nic has joined #openstack-nova | 17:05 | |
*** _ducttape_ has joined #openstack-nova | 17:08 | |
*** Guest45867 has quit IRC | 17:08 | |
bauzas | mriedem: jaypipes: FYI, https://review.openstack.org/412537 | 17:09 |
bauzas | sean disappeared but I'd love getting his feedback on that devstack patch from a noobie | 17:09 |
* bauzas bails out but is back in the evening | 17:10 | |
jaypipes | bauzas: asked a ? on the reivew... | 17:11 |
*** ducttape_ has quit IRC | 17:11 | |
bauzas | jaypipes: replied | 17:12 |
mriedem | bauzas: let's add some context to the commit message for 51a225c5d7f7d8655be62cab0e4d677b6839f35a and the d-g change | 17:13 |
bauzas | that's for multinode devstacks | 17:13 |
bauzas | mriedem: sure, np | 17:13 |
bauzas | mriedem: on it | 17:13 |
*** cleong has quit IRC | 17:15 | |
*** cleong has joined #openstack-nova | 17:15 | |
*** siva_krish has quit IRC | 17:16 | |
*** moshele has quit IRC | 17:17 | |
*** Zer0Byte__ has joined #openstack-nova | 17:17 | |
sneti | johnthetubaguy, Can you please check this when you have time https://review.openstack.org/#/c/392305/. rebased this patch you previously +2d. | 17:17 |
jaypipes | bauzas: done. :) | 17:23 |
*** corey_ has joined #openstack-nova | 17:23 | |
*** cleong has quit IRC | 17:23 | |
*** corey_ is now known as Guest1622 | 17:24 | |
*** sudipto has quit IRC | 17:25 | |
*** sudipto_ has quit IRC | 17:25 | |
*** sudipto_ has joined #openstack-nova | 17:25 | |
*** sudipto has joined #openstack-nova | 17:25 | |
robcresswell | o/ Hey all, anyone particularly familiar with the api_versions.py in the pythonclient? Attempting to use the discover_version function with the client that Horizon has, but it alwars gets a 'versions' KeyError. I'm not entirely sure why. | 17:25 |
robcresswell | always* | 17:26 |
mriedem | robcresswell: andreykurilin is your guy | 17:26 |
robcresswell | mriedem: Thanks, any particular tz? | 17:27 |
andreykurilin | robcresswell: hi! can you share any trace? | 17:27 |
mriedem | robcresswell: andrey is on at all TZs | 17:28 |
robcresswell | andreykurilin: http://paste.openstack.org/show/592814/ | 17:28 |
andreykurilin | mriedem: heh | 17:28 |
robcresswell | The construction of the client on Horizons side is https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L464 | 17:29 |
andreykurilin | mriedem: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L474 they use the same way of initialization novaclient | 17:30 |
andreykurilin | but it is unrelated | 17:30 |
andreykurilin | robcresswell: does cli `nova version-list` works? | 17:31 |
mriedem | transcend was the word i was thinking of | 17:31 |
robcresswell | andreykurilin: It does | 17:32 |
*** dtp has joined #openstack-nova | 17:34 | |
andreykurilin | robcresswell: sorry, I need to switch to some urgent task. will return in 20 minutes | 17:35 |
robcresswell | andreykurilin: Sure, no rush | 17:35 |
robcresswell | I appreciate the help! | 17:35 |
*** mdnadeem has quit IRC | 17:37 | |
*** andreas_s has quit IRC | 17:39 | |
*** _ducttape_ has quit IRC | 17:40 | |
*** ducttape_ has joined #openstack-nova | 17:41 | |
*** siva_krish has joined #openstack-nova | 17:42 | |
*** nicolasbock has quit IRC | 17:43 | |
*** derekh has quit IRC | 17:44 | |
openstackgerrit | int32bit proposed openstack/nova: Page the db query when filter instances with IP https://review.openstack.org/405171 | 17:45 |
*** moshele has joined #openstack-nova | 17:45 | |
*** raunak has joined #openstack-nova | 17:46 | |
*** nicolasbock has joined #openstack-nova | 17:48 | |
*** lpetrut has quit IRC | 17:48 | |
*** sdague has joined #openstack-nova | 17:48 | |
*** ociuhandu has quit IRC | 17:49 | |
*** lucasagomes is now known as lucas-afk | 17:50 | |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: pass the nodename to public methods https://review.openstack.org/398470 | 17:50 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: remove fluff from test_resource_tracker https://review.openstack.org/398471 | 17:50 |
openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 17:50 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: explicitly pass compute node to _update() https://review.openstack.org/398472 | 17:50 |
openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | 17:50 |
*** sahid has quit IRC | 17:50 | |
*** weshay_bbiab is now known as weshay | 17:51 | |
*** sudipto_ has quit IRC | 17:51 | |
*** sudipto has quit IRC | 17:51 | |
*** Swami has joined #openstack-nova | 17:52 | |
*** liverpooler has quit IRC | 17:53 | |
*** liverpooler has joined #openstack-nova | 17:55 | |
openstackgerrit | int32bit proposed openstack/nova: Page the db query when filter instances with IP https://review.openstack.org/405171 | 17:55 |
*** slaweq_ has quit IRC | 17:56 | |
*** slaweq_ has joined #openstack-nova | 17:58 | |
*** unicell1 has quit IRC | 18:00 | |
*** gszasz has quit IRC | 18:00 | |
*** yamahata has quit IRC | 18:01 | |
*** int32bit has quit IRC | 18:01 | |
*** Jeffrey4l has quit IRC | 18:07 | |
*** slaweq_ has quit IRC | 18:08 | |
openstackgerrit | Akshil Verma proposed openstack/python-novaclient: Fixed the __ne__ implementation in base.Resource https://review.openstack.org/409549 | 18:09 |
andreykurilin | robcresswell: do you have local env with horizon and novaclient? | 18:18 |
*** sreeram_v has joined #openstack-nova | 18:18 | |
robcresswell | andreykurilin: Yep | 18:18 |
andreykurilin | robcresswell: nice. | 18:18 |
robcresswell | Is that causing the issue? | 18:19 |
openstackgerrit | Sean Dague proposed openstack/nova: nova-status: add basic placement status checking https://review.openstack.org/411883 | 18:19 |
sdague | mriedem: ok, I think I fixed all your concerns | 18:19 |
andreykurilin | robcresswell: no) | 18:20 |
*** ociuhandu has joined #openstack-nova | 18:20 | |
andreykurilin | robcresswell: which novaclient's version do you use? | 18:20 |
robcresswell | andreykurilin: 6.0.0 | 18:21 |
andreykurilin | robcresswell: Can you modify horizon code to transmit `auth_token=token_id, bypass_url=nova_url` to https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L466 and remove L474 and L475? and recheck everything(nothing should change, but at least old features should continue to work, i.e listing servers)? | 18:21 |
*** sreeram_v has quit IRC | 18:22 | |
andreykurilin | robcresswell: next step will be updating novaclient to master. it can help(after changes posted above) | 18:22 |
*** siva_krishnan_ has joined #openstack-nova | 18:23 | |
robcresswell | andreykurilin: Should L469 still be token_id? Or is that to be removed oto? | 18:24 |
robcresswell | too* | 18:24 |
*** armax has joined #openstack-nova | 18:25 | |
andreykurilin | robcresswell: let it be token_id for now. | 18:28 |
andreykurilin | actually, novaclient expects password there, but keystone allows to transmit token there | 18:28 |
robcresswell | that didnt seem to change anything, same issues | 18:29 |
*** unicell has joined #openstack-nova | 18:34 | |
openstackgerrit | Dan Peschman proposed openstack/nova: Option to always create network metadata information as static https://review.openstack.org/336293 | 18:34 |
openstackgerrit | Sean Dague proposed openstack/nova: nova-status: add basic placement status checking https://review.openstack.org/411883 | 18:35 |
*** matrohon has joined #openstack-nova | 18:36 | |
*** ihrachys has quit IRC | 18:37 | |
andreykurilin | robcresswell: can you update novaclient to master? | 18:40 |
*** yamahata has joined #openstack-nova | 18:40 | |
*** lpetrut has joined #openstack-nova | 18:40 | |
*** moshele has quit IRC | 18:41 | |
*** nic has quit IRC | 18:42 | |
*** nic has joined #openstack-nova | 18:42 | |
robcresswell | andreykurilin: ooo, new errors! | 18:43 |
robcresswell | I call that progress | 18:43 |
robcresswell | gimme a minute to figure out whats changed | 18:43 |
andreykurilin | robcresswell: waiting for paste:) | 18:43 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: refactor conf_fixture.py https://review.openstack.org/412581 | 18:50 |
robcresswell | andreykurilin: Its working now | 18:52 |
andreykurilin | cool | 18:53 |
robcresswell | andreykurilin: So, is this a novaclient bug? Or a Horizon implementation bug? | 18:53 |
robcresswell | (or both) | 18:54 |
andreykurilin | mriedem: usage of SessionClient instead of HTTPClient helped to discover microversions in horizon ^ We need to recheck everything and cut a release:) | 18:54 |
andreykurilin | robcresswell: I think both | 18:54 |
andreykurilin | robcresswell: recently, we merged a big change to novaclient which should fix a lot of issues. it is unreleased yet. | 18:55 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: added notifications group https://review.openstack.org/392145 | 18:55 |
andreykurilin | robcresswell: from horizon side, it sets properties of inner novaclient's object. it is wrong behaviour. Please, propose a patch to horizon repo with changes you made for initialization of novaclient | 18:56 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: remove deprecated ironic options https://review.openstack.org/405597 | 18:56 |
robcresswell | andreykurilin: Any rough ETA on that release? | 18:56 |
robcresswell | andreykurilin: Sure, I can just push that as part of the microversion patch | 18:57 |
openstackgerrit | Maciej Szankin proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | 18:57 |
andreykurilin | robcresswell: we need to check that our changes doesn't break anything:) also, there are small nits that should be fixed before release. I can't give you any ETA, mriedem may help you. | 18:58 |
andreykurilin | From my side, I'll propose all required patches this week | 18:58 |
mriedem | can someone summarize? i'm debugging a customer issue atm so i haven't been following along. | 18:58 |
*** baoli has quit IRC | 18:59 | |
*** baoli has joined #openstack-nova | 19:00 | |
robcresswell | mriedem: I'm not sure to be honest. In short, novaclient 6.0.0 failed consistently on api_versions.discover_version(). Updating it to master caused it to work as expected. | 19:00 |
robcresswell | I don't know any further details on the nova side. | 19:00 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: move few console opts to xenserver group https://review.openstack.org/389647 | 19:03 |
andreykurilin | mriedem, sum: horizon doesn't create keystone session manually, they transmit all arguments to novaclient. HTTPClient impl s*cks and for some reason doesn't work. SessionClient fixes all issues(after switching to use master branch) and horizon can use Nova's microversions now! :) | 19:04 |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.40 - Simple tenant usage pagination https://review.openstack.org/407825 | 19:04 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: move few console opts to xenserver group https://review.openstack.org/389647 | 19:04 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: WIP: restrict some properties https://review.openstack.org/412588 | 19:05 |
*** browne has quit IRC | 19:05 | |
*** stvnoyes has quit IRC | 19:06 | |
robcresswell | andreykurilin: So, we should be using SessionClient(...) instead of Client(...)? | 19:07 |
andreykurilin | robcresswell: no no no | 19:07 |
andreykurilin | it is our inner stuff | 19:07 |
andreykurilin | everything is done for you in master/branch of novaclient:) | 19:07 |
*** kylek3h is now known as kylek3h_ | 19:08 | |
robcresswell | andreykurilin: Right... just a little frustrating to not be able to implement microversions even by Ocata :/ | 19:13 |
*** fragatina has quit IRC | 19:13 | |
*** david-lyle_ has joined #openstack-nova | 19:13 | |
*** openstackstatus has quit IRC | 19:13 | |
*** jamespag` has joined #openstack-nova | 19:13 | |
*** jamespag` has quit IRC | 19:13 | |
*** jamespag` has joined #openstack-nova | 19:13 | |
*** david-lyle has quit IRC | 19:13 | |
*** jamespage has quit IRC | 19:13 | |
*** openstack has joined #openstack-nova | 19:15 | |
andreykurilin | @robcresswell: actually, there is a way to fix everything on horizon side without waiting our release, but it require more lines of code, so it is better to wait a bit. | 19:19 |
robcresswell | andreykurilin: Could you explain? I really dont think we have time to wait for a release without an ETA. | 19:19 |
*** matrohon has quit IRC | 19:20 | |
*** armax has quit IRC | 19:21 | |
mriedem | robcresswell: i'm hoping to have a novaclient release this week, | 19:21 |
mriedem | but trying to test it out against trove to make sure we don't break someone | 19:21 |
*** eharney has quit IRC | 19:22 | |
*** kfarr has joined #openstack-nova | 19:24 | |
mriedem | cburgess: nic: so before you guys had fast snapshots with rbd, how were you dealing with large disk snapshots not failing? i.e. the token expiring between the time that we're getting the disk snapshot and then uploading that to glance? just long token timeouts? | 19:24 |
mriedem | it seems really odd that nova creates a new session and new token with requests to other services like ironic, neutron and cinder but for glance we just pass the token through, which can timeout during a long running operation like snapshot | 19:26 |
*** tbachman_ has joined #openstack-nova | 19:26 | |
*** tbachman has quit IRC | 19:26 | |
*** tbachman_ is now known as tbachman | 19:26 | |
robcresswell | andreykurilin: Would you mind sharing how to fix this on the Horizon side? Cinder is broken for the exact same reason. | 19:27 |
*** armax has joined #openstack-nova | 19:31 | |
*** baoli has quit IRC | 19:32 | |
*** baoli has joined #openstack-nova | 19:32 | |
*** ducttape_ has quit IRC | 19:37 | |
*** eharney has joined #openstack-nova | 19:38 | |
openstackgerrit | Chris Dent proposed openstack/nova: [placement] placement_dev info for testing and gabbi https://review.openstack.org/412600 | 19:48 |
*** jaosorior has quit IRC | 19:52 | |
*** roeyc has joined #openstack-nova | 19:55 | |
*** rcernin has joined #openstack-nova | 19:56 | |
*** lpetrut has quit IRC | 20:00 | |
*** ducttape_ has joined #openstack-nova | 20:05 | |
*** rfolco has quit IRC | 20:11 | |
*** amoralej is now known as amoralej|off | 20:17 | |
*** sreeram_v has joined #openstack-nova | 20:18 | |
*** sreeram_v has quit IRC | 20:23 | |
alaski | mriedem: long timeouts is the only solution I've seen for that issue so far. It's been a long standing problem that trusts were supposed to help with, and more recently I think there have been other proposed solutions. But nothing solid ever materialized that I saw. | 20:24 |
mriedem | alaski: yeah https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/use-service-tokens.html is the future | 20:25 |
mriedem | "User start snapshot operation in Nova. User token expires during this operation. Nova call Glance to update final bits and that request is failed by Keystone due to expired user token." | 20:25 |
mriedem | ^ is exactly what i'm hitting with an 80GB disk :) | 20:25 |
alaski | yeah, it was happening fairly regularly in the large deployment I was involved in | 20:28 |
*** roeyc has quit IRC | 20:29 | |
alaski | looks like OSIC is on that spec. Hopefully they can push that forward | 20:29 |
*** jaypipes has quit IRC | 20:30 | |
*** Sukhdev has quit IRC | 20:33 | |
*** stvnoyes has joined #openstack-nova | 20:35 | |
*** cdent has quit IRC | 20:36 | |
*** slaweq_ has joined #openstack-nova | 20:38 | |
*** annegentle has joined #openstack-nova | 20:41 | |
*** weshay is now known as weshay_relocatin | 20:42 | |
sdague | mriedem: it does the same thing for cinder IIRC | 20:48 |
sdague | the neutron code is misleading | 20:48 |
*** baoli has quit IRC | 20:48 | |
mriedem | sdague: we have ksa stuff for cinder | 20:48 |
sdague | some times we work on behalf of the user with a user scoped token | 20:48 |
sdague | and sometimes we just admin it | 20:49 |
sdague | mriedem: hmmm... ok, I guess the cinder bits are a little different than I last remember them | 20:50 |
sdague | maybe when we purged all the proxies we got rid of some of that other stuff | 20:51 |
mriedem | speaking of purging things, we still need to purge the glance v1 code in nova | 20:56 |
*** siva_krishnan_ has quit IRC | 21:00 | |
*** siva_krishnan_ has joined #openstack-nova | 21:01 | |
*** tlian has joined #openstack-nova | 21:01 | |
*** jamielennox|away is now known as jamielennox | 21:04 | |
*** baoli has joined #openstack-nova | 21:04 | |
mriedem | alright, crisis postponed, i'll work on adding the RP counting to the placement nova-status patch now | 21:09 |
*** GMAzrael_ has joined #openstack-nova | 21:12 | |
*** rtheis has quit IRC | 21:13 | |
GMAzrael_ | Oh Wise developers. How would I increaase the idle timeout for websocketify? | 21:14 |
*** gouthamr has quit IRC | 21:17 | |
*** sreeram_v has joined #openstack-nova | 21:17 | |
stevemar | mriedem: hmm, jamielennox has been working on that stuff | 21:18 |
*** Guest1622 has quit IRC | 21:18 | |
stevemar | mriedem: actually, all the keystone and keystonemiddleware parts have landed | 21:18 |
stevemar | mriedem: http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ocata/allow-expired.html | 21:18 |
mriedem | stevemar: yeah | 21:19 |
mriedem | hence the nova spec to use them | 21:19 |
stevemar | mriedem: yessss, just making sure that you knew it revolved around validating expired tokens | 21:20 |
stevemar | and using a service token isn't enough | 21:21 |
*** sreeram_v has quit IRC | 21:22 | |
mriedem | alright | 21:24 |
*** smatzek has quit IRC | 21:29 | |
*** kfarr has quit IRC | 21:29 | |
*** _ducttape_ has joined #openstack-nova | 21:29 | |
*** ducttape_ has quit IRC | 21:33 | |
*** _ducttape_ has quit IRC | 21:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: rt: pass the nodename to public methods https://review.openstack.org/398470 | 21:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova: rt: remove fluff from test_resource_tracker https://review.openstack.org/398471 | 21:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 21:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova: rt: explicitly pass compute node to _update() https://review.openstack.org/398472 | 21:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | 21:34 |
*** ssurana has joined #openstack-nova | 21:36 | |
openstackgerrit | Anusha Unnam proposed openstack/nova: Do not merge: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 21:39 |
*** eharney has quit IRC | 21:40 | |
*** liverpooler has quit IRC | 21:41 | |
jamielennox | stevemar, mriedem: the extension of that spec however would be that we should change the policies for service->service operations so that a user/service token is sufficient rather than need the nova user to have admin priviledges | 21:46 |
*** thorst has quit IRC | 21:46 | |
*** thorst has joined #openstack-nova | 21:46 | |
*** fragatina has joined #openstack-nova | 21:48 | |
mordred | sdague: (or anyone else) ... http://developer.openstack.org/api-ref/compute/?expanded=show-usage-statistics-for-tenant-detail#usage-reports-os-simple-tenant-usage shows v2.40 in the URL - my understanding of microversions was that it was all header-based | 21:49 |
mordred | is that doc correct? | 21:49 |
mordred | (I also dont see a version in the URL in python-novaclient | 21:50 |
mriedem | mordred: the doc is busted | 21:51 |
mriedem | mordred: report a bug? | 21:51 |
mriedem | https://github.com/openstack/nova/blob/master/api-ref/source/os-simple-tenant-usage.inc#L78 | 21:52 |
mriedem | that shouldn't have v2.40 hard-coded into it | 21:52 |
mordred | I'll make a bug/patch | 21:52 |
mriedem | there might be v2.40 request/response wrinkles for the limit/marker, but those go into the parameters.yaml | 21:52 |
mriedem | fyi it comes from this recently merged patch https://github.com/openstack/nova/commit/83404013cb53aef16b97b5616c0627c50af76ac8 | 21:52 |
mriedem | diana_clarke: ^ | 21:53 |
*** browne has joined #openstack-nova | 21:53 | |
mriedem | i bet it was just a mistake when making a similar change to the ../../doc/api_samples/os-simple-tenant-usage/v2.40/simple-tenant-usage-get-detail.json example | 21:53 |
mordred | yah - that's what it seems like | 21:53 |
diana_clarke | mriedem: looking | 21:53 |
diana_clarke | mriedem: I'll toss a patch up that removes the min version | 21:54 |
openstackgerrit | Monty Taylor proposed openstack/nova: Remove v2.40 from URL string in usage API docs https://review.openstack.org/412624 | 21:54 |
mordred | diana_clarke: ^^ | 21:54 |
*** fragatina has quit IRC | 21:54 | |
*** thorst has quit IRC | 21:55 | |
*** fragatina has joined #openstack-nova | 21:55 | |
mriedem | +1 | 21:56 |
mriedem | oops +2 | 21:56 |
mriedem | the response examples in there now are for 2.40 and confuse someone that assumes they are for v2.1 | 21:56 |
diana_clarke | mriedem: I originally left the old examples, but was told to switch them to the new examples. | 21:57 |
mriedem | ok, might be good to put a (v2.40) in the example title or something | 21:58 |
mriedem | also, it doesn't look like we have a description of tenant_usage_links in the response descriptions | 21:58 |
mordred | why do I get the feeling I'm about to have a BUNCH of fun learning what you fine people have been doing with microversions all this time | 21:58 |
*** fragatina has quit IRC | 21:58 | |
diana_clarke | mriedem: ah, good call. I can do those minor fixes over the holidays. | 21:59 |
*** fragatina has joined #openstack-nova | 21:59 | |
mriedem | mordred: as long as you're (1) not using nova-network and (2) are using v2.1 you should be fine | 21:59 |
mriedem | from a client pov | 21:59 |
mordred | mriedem: well.... that's just the thing | 22:00 |
mordred | I get the fun of using all of those things | 22:00 |
mriedem | mordred: then you should be happy about microversions | 22:00 |
mordred | I probably will be | 22:01 |
mordred | I've just been ignoring them so far because I wasn't doing direct REST calls for anything | 22:01 |
mordred | yay new learning | 22:01 |
mriedem | diana_clarke: my xmas gift to you https://bugs.launchpad.net/nova/+bug/1651254 | 22:02 |
openstack | Launchpad bug 1651254 in OpenStack Compute (nova) ""tenant_usage_links" isn't described in the v2.40 os-simple-tenant-usage API reference" [Low,Confirmed] | 22:02 |
*** tbachman has quit IRC | 22:03 | |
*** tbachman has joined #openstack-nova | 22:03 | |
mriedem | mordred: btw, thanks for bringing up the api-ref issue - things are much better than before but there are still plenty of loose ends and warts | 22:04 |
*** smatzek has joined #openstack-nova | 22:05 | |
mordred | mriedem: yah - the docs are actually REALLY good and usable now - to the point where when there is a weirdness it makes sense to ask about it | 22:05 |
*** fragatina has quit IRC | 22:06 | |
kukacz | hi, I got a couple of instances which can't be deleted using nova delete commands, neither reset-state helps | 22:07 |
kukacz | those instances are deleted from hypervisor however | 22:08 |
kukacz | is there a recommended process how to complete the deletion? | 22:09 |
*** Sukhdev has joined #openstack-nova | 22:10 | |
*** dave-mccowan has joined #openstack-nova | 22:11 | |
kukacz | I could find several blog posts about how to soft-delete them by sql calls on database | 22:12 |
kukacz | but there's also a nova_nuke.py https://gist.github.com/DavidWittman/6831237 which does that via python nova.db.sqlalchemy calls | 22:13 |
kukacz | I wonder if there's something more or less recommended by nova developers? | 22:14 |
*** annegentle has quit IRC | 22:17 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Missing usage next links in api-ref https://review.openstack.org/412632 | 22:19 |
diana_clarke | mriedem: ^ that's just following the established pattern which is pretty vague. Anyhoo, I also owe you and alex_xu a paragraph about 2.40. That, I'll do later. | 22:20 |
diana_clarke | from mexico!!! | 22:20 |
diana_clarke | mriedem: Oh, and before I forget. Here's the other follow-up patch I promised you last week. https://review.openstack.org/#/c/411441/ | 22:24 |
mriedem | thanks | 22:24 |
diana_clarke | mriedem: It documents & tests all the endpoints that support offset & limit. (I originally only fixed the one I needed fixed downstream) | 22:24 |
mriedem | kukacz: forceDelete? http://developer.openstack.org/api-ref/compute/?expanded=delete-server-detail,force-delete-server-forcedelete-action-detail#force-delete-server-forcedelete-action | 22:26 |
mriedem | diana_clarke: where in mexico? | 22:27 |
mriedem | we'll be in cabo in late january | 22:27 |
mriedem | btw, enjoy the 6 hour flight with a baby | 22:27 |
mriedem | :) | 22:27 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: WIP: Add service_token for nova-glance interaction https://review.openstack.org/412634 | 22:28 |
*** baoli has quit IRC | 22:29 | |
kukacz | mriedem: I've tried that earlier from nova CLI - did not help. the error I'm seeing logged at instance is 504 Gateway error | 22:30 |
diana_clarke | mriedem: My uncle just built a place near/in Punta de Mita. I'm pretty excited. | 22:33 |
diana_clarke | mriedem: Pro tip: if you don't pay for seat selection, they randomly place your family and strangers can look after your kids. | 22:33 |
diana_clarke | why would I pay to look after my kids?! | 22:34 |
*** smatzek has quit IRC | 22:37 | |
*** jheroux has quit IRC | 22:39 | |
kukacz | mriedem: it's Kilo release, instances booted from volumes, Ceph backend in Cinder. In most cases instance deletion deletion works smoothly for us | 22:40 |
kukacz | these instances are hanging there in error state for some time already. all seem to have passed through an unsuccesfull deletion attempt | 22:41 |
openstackgerrit | Diana Clarke proposed openstack/nova: Missing usage next links in api-ref https://review.openstack.org/412632 | 22:42 |
mriedem | sdague: just starting the rp / compute node comparisons, we might want to actually make that it's own check | 22:44 |
mriedem | because it's not trivial | 22:44 |
mriedem | like, cells v2 check, placement API check, resource providers check | 22:44 |
mriedem | testing it is going to get a bit funky | 22:45 |
mriedem | especially with stubbing out compute_nodes in multiple cell databases and relying on querying the api db | 22:45 |
mriedem | oh my | 22:45 |
*** slaweq_ has quit IRC | 22:46 | |
*** esberglu has quit IRC | 22:47 | |
*** esberglu has joined #openstack-nova | 22:48 | |
*** mvk has joined #openstack-nova | 22:51 | |
*** esberglu has quit IRC | 22:52 | |
*** thorst has joined #openstack-nova | 22:52 | |
*** xyang1 has quit IRC | 22:53 | |
*** Swami has quit IRC | 22:56 | |
*** baoli has joined #openstack-nova | 22:56 | |
*** eharney has joined #openstack-nova | 22:58 | |
*** thorst has quit IRC | 23:00 | |
*** baoli has quit IRC | 23:01 | |
*** esberglu has joined #openstack-nova | 23:01 | |
*** pradk has quit IRC | 23:01 | |
*** annegentle has joined #openstack-nova | 23:04 | |
*** esberglu has quit IRC | 23:05 | |
*** annegentle has quit IRC | 23:12 | |
*** mlavalle has quit IRC | 23:19 | |
*** nherciu_ has quit IRC | 23:21 | |
*** ducttape_ has joined #openstack-nova | 23:31 | |
*** lamt has quit IRC | 23:32 | |
*** Sukhdev has quit IRC | 23:34 | |
*** ducttape_ has quit IRC | 23:34 | |
*** ducttape_ has joined #openstack-nova | 23:35 | |
*** tlian has quit IRC | 23:35 | |
*** ducttape_ has quit IRC | 23:39 | |
openstackgerrit | Sujitha proposed openstack/nova: Adding tags to InstancePayload https://review.openstack.org/407228 | 23:42 |
*** sdague has quit IRC | 23:44 | |
*** rfolco has joined #openstack-nova | 23:50 | |
*** rfolco has quit IRC | 23:50 | |
*** dave-mccowan has quit IRC | 23:50 | |
*** nicolasbock has quit IRC | 23:54 | |
openstackgerrit | Sujitha proposed openstack/nova: Adding tags to InstancePayload https://review.openstack.org/407228 | 23:54 |
*** ducttape_ has joined #openstack-nova | 23:55 | |
*** thorst has joined #openstack-nova | 23:57 | |
*** gouthamr has joined #openstack-nova | 23:58 | |
*** jwcroppe has quit IRC | 23:58 | |
*** jwcroppe has joined #openstack-nova | 23:59 | |
*** tlian has joined #openstack-nova | 23:59 | |
*** Sukhdev has joined #openstack-nova | 23:59 | |
*** ducttape_ has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!