*** markvoelker has quit IRC | 00:02 | |
*** efoley has quit IRC | 00:03 | |
*** Fdaisuke has joined #openstack-nova | 00:10 | |
*** ducttape_ has quit IRC | 00:12 | |
*** amotoki has joined #openstack-nova | 00:14 | |
*** thorst has joined #openstack-nova | 00:25 | |
*** devkulkarni has quit IRC | 00:25 | |
*** thorst has quit IRC | 00:26 | |
*** thorst has joined #openstack-nova | 00:27 | |
*** ijw has joined #openstack-nova | 00:35 | |
*** thorst has quit IRC | 00:35 | |
*** hoangcx has joined #openstack-nova | 00:38 | |
*** tuanluong has joined #openstack-nova | 00:39 | |
*** ijw has quit IRC | 00:40 | |
*** tovin07 has joined #openstack-nova | 00:48 | |
*** hoangcx has quit IRC | 00:49 | |
*** hoangcx has joined #openstack-nova | 00:49 | |
*** tovin07 has quit IRC | 00:56 | |
*** tovin07 has joined #openstack-nova | 00:57 | |
*** Jeffrey4l has joined #openstack-nova | 01:03 | |
*** phuongnh has joined #openstack-nova | 01:04 | |
*** ducttape_ has joined #openstack-nova | 01:13 | |
*** mingyu has joined #openstack-nova | 01:16 | |
*** ducttape_ has quit IRC | 01:18 | |
*** devkulkarni has joined #openstack-nova | 01:27 | |
*** thorst has joined #openstack-nova | 01:29 | |
*** ljxiash has joined #openstack-nova | 01:29 | |
*** thorst has quit IRC | 01:29 | |
*** devkulkarni has quit IRC | 01:32 | |
*** zhangjl has joined #openstack-nova | 01:33 | |
*** thorst has joined #openstack-nova | 01:34 | |
*** mtanino has joined #openstack-nova | 01:35 | |
*** devkulkarni has joined #openstack-nova | 01:37 | |
*** thorst has quit IRC | 01:39 | |
*** yuntongjin has joined #openstack-nova | 01:41 | |
*** ducttape_ has joined #openstack-nova | 01:42 | |
*** mingyu has quit IRC | 01:45 | |
*** gcb has joined #openstack-nova | 01:47 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Set access_policy for messaging's dispatcher https://review.openstack.org/408494 | 01:48 |
---|---|---|
*** mtanino has quit IRC | 01:50 | |
*** ducttape_ has quit IRC | 01:53 | |
gcb | alex_xu, please help approve two simple patches : https://review.openstack.org/#/c/405921/ https://review.openstack.org/#/c/408589/ | 02:00 |
*** mingyu has joined #openstack-nova | 02:01 | |
*** mingyu has quit IRC | 02:05 | |
*** armax has joined #openstack-nova | 02:06 | |
*** armax has quit IRC | 02:08 | |
*** amotoki has quit IRC | 02:11 | |
*** mingyu has joined #openstack-nova | 02:11 | |
*** sacharya has joined #openstack-nova | 02:12 | |
*** int32bit_ has joined #openstack-nova | 02:19 | |
*** mingyu has quit IRC | 02:19 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port api.openstack.compute.test_disk_config to Python 3 https://review.openstack.org/403536 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port network.test_manager.LdapDNSTestCase to Python 3 https://review.openstack.org/406425 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port test_simple_tenant_usage to Python 3 https://review.openstack.org/406103 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port security group related tests to Python 3 https://review.openstack.org/401241 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port compute.test_user_data.ServersControllerCreateTest to Python 3 https://review.openstack.org/406435 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port test_matchers.TestDictMatches.test__str__ to Python 3 https://review.openstack.org/406437 | 02:23 |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port compute unit tests to Python 3 https://review.openstack.org/402010 | 02:23 |
*** int32bit_ has quit IRC | 02:23 | |
*** sacharya has quit IRC | 02:24 | |
*** sam_nowitzki has joined #openstack-nova | 02:32 | |
*** sam_nowitzki has quit IRC | 02:33 | |
*** sam_nowitzki has joined #openstack-nova | 02:33 | |
*** sam_nowitzki has quit IRC | 02:33 | |
*** mingyu has joined #openstack-nova | 02:34 | |
*** thorst has joined #openstack-nova | 02:36 | |
*** kaisers__ has joined #openstack-nova | 02:38 | |
*** fragatina has joined #openstack-nova | 02:41 | |
*** ducttape_ has joined #openstack-nova | 02:41 | |
*** kaisers_ has quit IRC | 02:42 | |
*** tuanluong has quit IRC | 02:44 | |
*** thorst has quit IRC | 02:44 | |
*** mingyu has quit IRC | 02:52 | |
*** fragatina has quit IRC | 02:55 | |
*** fragatina has joined #openstack-nova | 02:56 | |
*** tuanluong has joined #openstack-nova | 02:59 | |
*** markvoelker has joined #openstack-nova | 03:00 | |
*** devkulkarni has quit IRC | 03:01 | |
*** markvoelker has quit IRC | 03:05 | |
*** ducttape_ has quit IRC | 03:05 | |
*** fragatina has quit IRC | 03:11 | |
*** zhangjl has quit IRC | 03:15 | |
*** fragatina has joined #openstack-nova | 03:22 | |
*** ijw has joined #openstack-nova | 03:24 | |
*** ijw has quit IRC | 03:28 | |
*** int32bit has joined #openstack-nova | 03:28 | |
*** ducttape_ has joined #openstack-nova | 03:31 | |
*** yuntongjin has quit IRC | 03:35 | |
*** takashin has joined #openstack-nova | 03:41 | |
*** thorst has joined #openstack-nova | 03:42 | |
*** phuongnh has quit IRC | 03:42 | |
*** phuongnh has joined #openstack-nova | 03:43 | |
*** baoli has joined #openstack-nova | 03:45 | |
*** thorst has quit IRC | 03:48 | |
*** nicolasbock has joined #openstack-nova | 03:49 | |
*** kaisers__ has quit IRC | 03:50 | |
*** sudipto has joined #openstack-nova | 03:53 | |
*** diga has joined #openstack-nova | 03:58 | |
*** markvoelker has joined #openstack-nova | 04:01 | |
*** markvoelker has quit IRC | 04:05 | |
*** phuongnh has quit IRC | 04:06 | |
*** nicolasbock has quit IRC | 04:07 | |
*** tuanluong has quit IRC | 04:10 | |
*** ducttape_ has quit IRC | 04:10 | |
*** ducttape_ has joined #openstack-nova | 04:19 | |
*** sacharya has joined #openstack-nova | 04:24 | |
*** baoli has quit IRC | 04:24 | |
*** int32bit has quit IRC | 04:27 | |
*** ayogi has joined #openstack-nova | 04:29 | |
*** sacharya has quit IRC | 04:29 | |
*** ducttape_ has quit IRC | 04:29 | |
*** devkulkarni has joined #openstack-nova | 04:42 | |
*** kaisers_ has joined #openstack-nova | 04:45 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove mox in test_block_device_mapping_v1.py https://review.openstack.org/308746 | 04:46 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Stop using mox stubs in nova/tests/unit/cells https://review.openstack.org/323287 | 04:46 |
*** ratailor has joined #openstack-nova | 04:49 | |
*** cfriesen has quit IRC | 04:52 | |
*** pbandark has joined #openstack-nova | 04:54 | |
*** diga has quit IRC | 04:57 | |
*** pbandark is now known as pbandark`brb | 04:57 | |
*** claudiub|2 has joined #openstack-nova | 04:57 | |
*** markvoelker has joined #openstack-nova | 05:02 | |
*** ircuser-1 has joined #openstack-nova | 05:04 | |
*** markvoelker has quit IRC | 05:07 | |
*** Zer0Byte__ has joined #openstack-nova | 05:07 | |
*** diga has joined #openstack-nova | 05:09 | |
*** thorst has joined #openstack-nova | 05:09 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: ironic: Add trigger crash dump support to ironic driver https://review.openstack.org/376548 | 05:10 |
*** Zer0Byte__ has quit IRC | 05:12 | |
*** Apoorva has joined #openstack-nova | 05:13 | |
*** mdnadeem has joined #openstack-nova | 05:13 | |
*** thorst has quit IRC | 05:15 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/3) https://review.openstack.org/357105 | 05:22 |
*** baoli has joined #openstack-nova | 05:25 | |
*** sacharya has joined #openstack-nova | 05:26 | |
*** prateek has joined #openstack-nova | 05:28 | |
*** nandal has joined #openstack-nova | 05:30 | |
*** ducttape_ has joined #openstack-nova | 05:30 | |
*** sacharya has quit IRC | 05:30 | |
*** nandal_in has joined #openstack-nova | 05:31 | |
openstackgerrit | bailin.zhang proposed openstack/nova: Fix the file permissions of test_compute_mgr.py https://review.openstack.org/401109 | 05:32 |
*** fragatina has quit IRC | 05:32 | |
*** nandal has quit IRC | 05:35 | |
*** ducttape_ has quit IRC | 05:35 | |
*** fragatina has joined #openstack-nova | 05:42 | |
openstackgerrit | Michael Still proposed openstack/nova: Add more description for rx and tx param https://review.openstack.org/395139 | 05:42 |
*** sridharg has joined #openstack-nova | 05:45 | |
*** ayogi has quit IRC | 05:45 | |
*** tuanluong has joined #openstack-nova | 05:46 | |
*** sridharg has quit IRC | 05:48 | |
*** sridharg has joined #openstack-nova | 05:48 | |
*** kaisers_ has quit IRC | 05:53 | |
*** nkrinner_afk has quit IRC | 05:54 | |
*** nkrinner has joined #openstack-nova | 05:55 | |
*** baoli has quit IRC | 05:57 | |
*** yuntongjin has joined #openstack-nova | 05:58 | |
*** kaisers_ has joined #openstack-nova | 05:58 | |
*** markvoelker has joined #openstack-nova | 06:02 | |
*** lifeless_ has quit IRC | 06:02 | |
*** fragatina has quit IRC | 06:02 | |
*** tlian has quit IRC | 06:02 | |
*** lifeless has joined #openstack-nova | 06:03 | |
*** markvoelker has quit IRC | 06:07 | |
*** lpetrut has joined #openstack-nova | 06:07 | |
*** slaweq_ has joined #openstack-nova | 06:09 | |
*** thorst has joined #openstack-nova | 06:13 | |
*** slaweq_ has quit IRC | 06:15 | |
*** bkopilov_ has joined #openstack-nova | 06:15 | |
*** bkopilov has quit IRC | 06:15 | |
*** bkopilov_ is now known as bkopilov | 06:15 | |
*** yamahata has joined #openstack-nova | 06:16 | |
*** slaweq_ has joined #openstack-nova | 06:16 | |
*** diga has quit IRC | 06:16 | |
*** devkulkarni has quit IRC | 06:17 | |
*** mdnadeem has quit IRC | 06:18 | |
*** thorst has quit IRC | 06:20 | |
*** mingyu has joined #openstack-nova | 06:21 | |
*** mdnadeem has joined #openstack-nova | 06:22 | |
*** Apoorva has quit IRC | 06:22 | |
*** openstackgerrit_ has joined #openstack-nova | 06:23 | |
*** jaosorior has joined #openstack-nova | 06:23 | |
*** baoli has joined #openstack-nova | 06:24 | |
*** zhangjl has joined #openstack-nova | 06:24 | |
*** openstackgerrit_ has quit IRC | 06:25 | |
*** mingyu has quit IRC | 06:25 | |
*** openstackgerrit_ has joined #openstack-nova | 06:26 | |
*** openstackgerrit_ has quit IRC | 06:27 | |
*** ducttape_ has joined #openstack-nova | 06:31 | |
*** ijw has joined #openstack-nova | 06:33 | |
*** openstackgerrit_ has joined #openstack-nova | 06:34 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:35 | |
*** openstackgerrit_ has quit IRC | 06:35 | |
*** ducttape_ has quit IRC | 06:36 | |
*** ijw has quit IRC | 06:37 | |
*** mingyu has joined #openstack-nova | 06:39 | |
*** mdnadeem has quit IRC | 06:39 | |
*** oanson has joined #openstack-nova | 06:43 | |
*** Oku_OS-away is now known as Oku_OS | 06:50 | |
*** mdnadeem has joined #openstack-nova | 06:51 | |
*** dikonoor has joined #openstack-nova | 06:53 | |
*** nkrinner is now known as nkrinner_afk | 06:53 | |
*** mingyu has quit IRC | 06:54 | |
*** openstackgerrit_ has joined #openstack-nova | 06:59 | |
*** openstackgerrit_ has quit IRC | 07:00 | |
*** tbachman has quit IRC | 07:02 | |
openstackgerrit | Hironori Shiina proposed openstack/nova: ironic: Add trigger crash dump support to ironic driver https://review.openstack.org/376548 | 07:03 |
*** markvoelker has joined #openstack-nova | 07:03 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: The ResourceProviderTraits API - Manage traits with ResourceProviders https://review.openstack.org/345138 | 07:05 |
*** tbachman has joined #openstack-nova | 07:05 | |
*** baoli has quit IRC | 07:07 | |
*** markvoelker has quit IRC | 07:08 | |
*** sam_nowitzki has joined #openstack-nova | 07:15 | |
*** sam_nowitzki has quit IRC | 07:15 | |
*** thorst has joined #openstack-nova | 07:16 | |
*** arjun_ has joined #openstack-nova | 07:17 | |
*** ekuris has joined #openstack-nova | 07:18 | |
*** ihrachys has joined #openstack-nova | 07:19 | |
*** sam_nowitzki has joined #openstack-nova | 07:20 | |
*** Apoorva has joined #openstack-nova | 07:22 | |
*** nkrinner_afk is now known as nkrinner | 07:22 | |
*** sam_nowitzki has quit IRC | 07:22 | |
*** thorst has quit IRC | 07:23 | |
*** sam_nowitzki has joined #openstack-nova | 07:26 | |
*** sam_nowitzki has quit IRC | 07:26 | |
*** sacharya has joined #openstack-nova | 07:27 | |
*** Apoorva has quit IRC | 07:27 | |
*** lpetrut has quit IRC | 07:27 | |
*** markus_z has joined #openstack-nova | 07:28 | |
*** sacharya has quit IRC | 07:31 | |
*** ducttape_ has joined #openstack-nova | 07:32 | |
*** kiran-r has joined #openstack-nova | 07:32 | |
*** lennyb has quit IRC | 07:33 | |
*** baoli has joined #openstack-nova | 07:33 | |
openstackgerrit | Dirk Mueller proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/409077 | 07:34 |
openstackgerrit | Hironori Shiina proposed openstack/nova-specs: Add support booting baremetals from Cinder volume https://review.openstack.org/311696 | 07:35 |
*** ducttape_ has quit IRC | 07:37 | |
*** andreas_s has joined #openstack-nova | 07:39 | |
*** arjun_ has quit IRC | 07:39 | |
*** jaosorior has quit IRC | 07:40 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/nova: Change backup rotation min value from 0 to 1 https://review.openstack.org/409644 | 07:41 |
*** gouthamr has joined #openstack-nova | 07:43 | |
*** lennyb has joined #openstack-nova | 07:44 | |
*** nherciu has joined #openstack-nova | 07:46 | |
*** kiran-r has quit IRC | 07:49 | |
*** matrohon has joined #openstack-nova | 07:57 | |
*** int32bit_ has joined #openstack-nova | 07:58 | |
*** gouthamr has quit IRC | 08:00 | |
*** jaosorior has joined #openstack-nova | 08:00 | |
*** BlackDex_ is now known as BlackDex | 08:03 | |
*** markvoelker has joined #openstack-nova | 08:04 | |
*** Zer0Byte__ has joined #openstack-nova | 08:07 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Support tag instances when boot https://review.openstack.org/394321 | 08:09 |
*** markvoelker has quit IRC | 08:09 | |
*** tojuvone has quit IRC | 08:11 | |
*** flaper87 has quit IRC | 08:11 | |
*** flaper87 has joined #openstack-nova | 08:11 | |
*** Zer0Byte__ has quit IRC | 08:11 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/3) https://review.openstack.org/408955 | 08:13 |
*** ralonsoh has joined #openstack-nova | 08:16 | |
*** baoli has quit IRC | 08:20 | |
*** moshele has joined #openstack-nova | 08:24 | |
*** avolkov has joined #openstack-nova | 08:26 | |
*** pcaruana has joined #openstack-nova | 08:30 | |
*** amoralej|off is now known as amoralej | 08:31 | |
*** ljxiash has quit IRC | 08:35 | |
*** ljxiash has joined #openstack-nova | 08:36 | |
*** ljxiash has quit IRC | 08:36 | |
*** ljxiash has joined #openstack-nova | 08:36 | |
*** ljxiash has quit IRC | 08:36 | |
*** pcaruana has quit IRC | 08:37 | |
*** ljxiash has joined #openstack-nova | 08:37 | |
*** pcaruana has joined #openstack-nova | 08:38 | |
*** owalsh has joined #openstack-nova | 08:39 | |
*** owalsh has quit IRC | 08:40 | |
*** owalsh has joined #openstack-nova | 08:40 | |
*** ljxiash has quit IRC | 08:41 | |
*** avolkov has quit IRC | 08:41 | |
*** avolkov has joined #openstack-nova | 08:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(3/3) https://review.openstack.org/408964 | 08:44 |
*** baoli has joined #openstack-nova | 08:47 | |
*** takashin has left #openstack-nova | 08:58 | |
*** zzzeek has quit IRC | 09:00 | |
*** xinliang has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-nova | 09:00 | |
*** ljxiash has joined #openstack-nova | 09:01 | |
*** takashin has joined #openstack-nova | 09:01 | |
*** roeyc has joined #openstack-nova | 09:05 | |
*** zhangjl has quit IRC | 09:06 | |
*** thorst has joined #openstack-nova | 09:07 | |
*** sudipto has quit IRC | 09:08 | |
*** rwmjones has quit IRC | 09:08 | |
*** rwmjones has joined #openstack-nova | 09:09 | |
openstackgerrit | John Haan proposed openstack/nova: VM with cross_az_attach raised InvaldBDM error https://review.openstack.org/409680 | 09:12 |
*** xinliang has joined #openstack-nova | 09:13 | |
*** ircuser-1 has quit IRC | 09:13 | |
*** rwmjones has quit IRC | 09:15 | |
*** thorst has quit IRC | 09:15 | |
*** rwmjones has joined #openstack-nova | 09:15 | |
*** lpetrut has joined #openstack-nova | 09:16 | |
*** yassine has joined #openstack-nova | 09:16 | |
*** yassine has quit IRC | 09:16 | |
*** diga has joined #openstack-nova | 09:16 | |
*** yuntongjin has quit IRC | 09:19 | |
*** yassine has joined #openstack-nova | 09:23 | |
*** yassine is now known as Guest71690 | 09:23 | |
*** Guest71690 has quit IRC | 09:24 | |
*** lucas-pto is now known as lucasagomes | 09:24 | |
*** sapcc-bot2 has quit IRC | 09:25 | |
*** sapcc-bot has joined #openstack-nova | 09:25 | |
*** mkoderer_ has joined #openstack-nova | 09:25 | |
*** dgonzalez_ has joined #openstack-nova | 09:25 | |
*** tommy_ has joined #openstack-nova | 09:25 | |
*** databus23_ has joined #openstack-nova | 09:25 | |
*** tpatzig_ has joined #openstack-nova | 09:25 | |
*** carthaca_ has joined #openstack-nova | 09:25 | |
*** david_1 has joined #openstack-nova | 09:25 | |
*** tommy_ is now known as Guest42753 | 09:25 | |
gmann | snikitin: i replied to these, please check - https://review.openstack.org/#/q/topic:tag-schema | 09:26 |
*** david_1 has quit IRC | 09:27 | |
*** tpatzig_ has quit IRC | 09:27 | |
*** carthaca_ has quit IRC | 09:27 | |
*** dgonzalez_ has quit IRC | 09:27 | |
*** mkoderer_ has quit IRC | 09:27 | |
*** Guest42753 has quit IRC | 09:27 | |
*** databus23_ has quit IRC | 09:27 | |
*** xinliang has quit IRC | 09:27 | |
*** namnh has joined #openstack-nova | 09:28 | |
*** eliqiao has quit IRC | 09:28 | |
*** xinliang has joined #openstack-nova | 09:28 | |
*** eliqiao has joined #openstack-nova | 09:30 | |
*** ekuris has quit IRC | 09:31 | |
*** asettle has joined #openstack-nova | 09:33 | |
namnh | belliott_, Hi Mr.Brian. Are you free? May I ask a question which is related to Gracefull shutdown in Nova? | 09:33 |
*** yamahata has quit IRC | 09:33 | |
*** ducttape_ has joined #openstack-nova | 09:34 | |
*** ducttape_ has quit IRC | 09:38 | |
*** baoli has quit IRC | 09:41 | |
*** int32bit_ has quit IRC | 09:41 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port virt vmwareapi tests to Python 3 https://review.openstack.org/401080 | 09:43 |
* johnthetubaguy makes waking up from deep sleep noises | 09:44 | |
*** ekuris has joined #openstack-nova | 09:44 | |
*** thorst has joined #openstack-nova | 09:46 | |
*** zenoway has joined #openstack-nova | 09:50 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Port libvirt.test_vif to Python 3 https://review.openstack.org/403419 | 09:50 |
*** thorst has quit IRC | 09:53 | |
*** jamespag` is now known as jamespage | 09:53 | |
*** derekh has joined #openstack-nova | 09:54 | |
BobBall | Good morning + welcome back johnthetubaguy :) | 09:55 |
johnthetubaguy | BobBall: good morning to you too | 09:56 |
*** claudiub|2 has quit IRC | 09:56 | |
*** ihrachys has quit IRC | 09:57 | |
openstackgerrit | Oleg Bondarev proposed openstack/nova: Live migration: wait for vif-plugged event on pre live migration https://review.openstack.org/246910 | 09:58 |
*** yassine_ has joined #openstack-nova | 09:59 | |
alex_xu | johnthetubaguy: welcome back :) | 09:59 |
johnthetubaguy | alex_xu: :) | 09:59 |
*** markvoelker has joined #openstack-nova | 10:06 | |
*** mingyu has joined #openstack-nova | 10:06 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Transform instance.rebuild.error notification https://review.openstack.org/396621 | 10:07 |
*** baoli has joined #openstack-nova | 10:08 | |
*** romainh has joined #openstack-nova | 10:10 | |
*** markvoelker has quit IRC | 10:10 | |
*** romainh1 has joined #openstack-nova | 10:13 | |
*** daemontool has joined #openstack-nova | 10:14 | |
*** romainh has quit IRC | 10:15 | |
*** daemontool has quit IRC | 10:15 | |
takashin | johnthetubaguy: could you check my comment in https://review.openstack.org/#/c/349863/ ? | 10:17 |
*** tojuvone has joined #openstack-nova | 10:18 | |
*** gszasz has joined #openstack-nova | 10:18 | |
johnthetubaguy | takashin: taking a look | 10:18 |
takashin | johnthetubaguy: Thank you. | 10:19 |
*** cdent has joined #openstack-nova | 10:20 | |
*** hoangcx has quit IRC | 10:24 | |
*** claudiub|2 has joined #openstack-nova | 10:28 | |
johnthetubaguy | takashin: I think I discovered why I got confused | 10:28 |
johnthetubaguy | takashin: all the lines with changes are in fact no changed | 10:29 |
johnthetubaguy | s/no/not/ | 10:29 |
*** mingyu has quit IRC | 10:29 | |
*** sudipto has joined #openstack-nova | 10:30 | |
takashin | johnthetubaguy: I did not change my patch by your comment because it need not be changed. | 10:31 |
*** gibi has quit IRC | 10:32 | |
*** cdent has quit IRC | 10:33 | |
*** rwmjones has quit IRC | 10:34 | |
*** ducttape_ has joined #openstack-nova | 10:35 | |
*** cdent has joined #openstack-nova | 10:35 | |
cdent | johnthetubaguy: welcome back. am I understsanding correctly that you were on honeymoon? congrantulations and hope it was great, if so | 10:36 |
openstackgerrit | Roman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder https://review.openstack.org/366724 | 10:36 |
*** igordcard has quit IRC | 10:36 | |
*** mingyu has joined #openstack-nova | 10:36 | |
*** igordcard has joined #openstack-nova | 10:36 | |
*** igordcard has quit IRC | 10:36 | |
johnthetubaguy | cdent: yeah, was a good trip, thank you :) | 10:36 |
*** mingyu has quit IRC | 10:37 | |
*** gibi has joined #openstack-nova | 10:37 | |
*** rwmjones has joined #openstack-nova | 10:39 | |
*** ducttape_ has quit IRC | 10:39 | |
*** mingyu_ has joined #openstack-nova | 10:41 | |
*** mingyu has joined #openstack-nova | 10:42 | |
*** ekuris has quit IRC | 10:42 | |
*** zhs has joined #openstack-nova | 10:44 | |
gibi | johnthetubaguy: hi! There are two notification patches that need a second +2. If you have time, could you check them please? | 10:44 |
gibi | johnthetubaguy: https://review.openstack.org/#/c/398171 | 10:45 |
gcb | johnthetubaguy, welcome back :-) | 10:45 |
*** baoli has quit IRC | 10:45 | |
gibi | johnthetubaguy: and https://review.openstack.org/#/c/330128 | 10:45 |
johnthetubaguy | gibi: honestly, I suspect today I may get stuck in a *pile* of email trying to find the ones I need to read | 10:45 |
johnthetubaguy | totally plan to get back on the wagon for those soon! | 10:45 |
*** mingyu_ has quit IRC | 10:46 | |
gibi | johnthetubaguy: understandable. I will ping you later this week ;) | 10:46 |
*** ducttape_ has joined #openstack-nova | 10:50 | |
*** tuanluong has quit IRC | 10:50 | |
*** thorst has joined #openstack-nova | 10:51 | |
*** ekuris has joined #openstack-nova | 10:52 | |
*** mkoderer has joined #openstack-nova | 10:52 | |
*** pabardina has joined #openstack-nova | 10:58 | |
*** thorst has quit IRC | 10:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Add 'preallocate_images' to 'virt' group https://review.openstack.org/392567 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Move virt options to a group https://review.openstack.org/392566 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Detail the 'injected_network_template' opt https://review.openstack.org/392565 | 10:58 |
openstackgerrit | Alex Szarka proposed openstack/nova: Rebuild instance, if compute rebooted during any process https://review.openstack.org/346926 | 10:59 |
openstackgerrit | Alex Szarka proposed openstack/nova: Split exception cases in manager.py https://review.openstack.org/347275 | 11:00 |
openstackgerrit | Chris Dent proposed openstack/nova: rt: pass the nodename to public methods https://review.openstack.org/398470 | 11:00 |
openstackgerrit | Chris Dent proposed openstack/nova: rt: remove fluff from test_resource_tracker https://review.openstack.org/398471 | 11:00 |
openstackgerrit | Chris Dent proposed openstack/nova: rt: pass nodename to internal methods https://review.openstack.org/398469 | 11:00 |
openstackgerrit | Chris Dent proposed openstack/nova: rt: explicitly pass compute node to _update() https://review.openstack.org/398472 | 11:00 |
openstackgerrit | Chris Dent proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | 11:00 |
openstackgerrit | Alex Szarka proposed openstack/nova: Reduce code duplication https://review.openstack.org/347422 | 11:00 |
*** ihrachys has joined #openstack-nova | 11:01 | |
openstackgerrit | Alex Szarka proposed openstack/nova: Refactor init_instance:resume_guests_state https://review.openstack.org/349582 | 11:01 |
openstackgerrit | Alex Szarka proposed openstack/nova: Reduce code complexity - servers.py https://review.openstack.org/359861 | 11:01 |
openstackgerrit | Alex Szarka proposed openstack/nova: Reduce code complexity - manager.py https://review.openstack.org/359868 | 11:01 |
openstackgerrit | Alex Szarka proposed openstack/nova: Reduce code complexity - linux_net.py https://review.openstack.org/359871 | 11:02 |
*** boogibugs has joined #openstack-nova | 11:02 | |
openstackgerrit | Chris Dent proposed openstack/nova: placement: report client handle InventoryInUse https://review.openstack.org/404990 | 11:03 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: minor refactor _allocate_for_instance() https://review.openstack.org/405705 | 11:03 |
openstackgerrit | Chris Dent proposed openstack/nova: WIP: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | 11:03 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: correct improper test case inheritance https://review.openstack.org/406363 | 11:04 |
openstackgerrit | Chris Dent proposed openstack/nova: placement: create aggregate map in report client https://review.openstack.org/407309 | 11:05 |
openstackgerrit | Chris Dent proposed openstack/nova: Support filtering resource providers by aggregate membership https://review.openstack.org/407629 | 11:05 |
openstackgerrit | Chris Dent proposed openstack/nova: HTTP interface for resource providers by aggregates https://review.openstack.org/407742 | 11:06 |
lyarwood | kashyap: morning, if you have time could you take a look at my comment in https://bugs.launchpad.net/nova/+bug/1643911 re the libvirtd malloc failures in the gate? | 11:06 |
openstack | Launchpad bug 1643911 in OpenStack Compute (nova) "libvirt randomly crashes on xenial nodes with "*** Error in `/usr/sbin/libvirtd': malloc(): memory corruption:"" [Medium,Confirmed] | 11:06 |
kashyap | lyarwood: Hi | 11:07 |
*** markvoelker has joined #openstack-nova | 11:07 | |
kashyap | lyarwood: Is it occuring more frequently now? | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy' https://review.openstack.org/408192 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate 'console_driver' https://review.openstack.org/408193 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Replace use of CONF with monkey patching https://review.openstack.org/408191 | 11:07 |
lyarwood | kashyap: 30 hits in the last 7 days | 11:07 |
lyarwood | kashyap: http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22***%20Error%20in%20%60%2Fusr%2Fsbin%2Flibvirtd':%20malloc():%20memory%20corruption:%5C%22%20AND%20tags:%5C%22syslog%5C%22&from=7d | 11:08 |
*** roeyc has quit IRC | 11:08 | |
* kashyap clicks | 11:08 | |
kashyap | lyarwood: Me a bit under the weather today, forgive if my responses aren't super fast | 11:09 |
lyarwood | kashyap: np np | 11:09 |
*** markvoelker has quit IRC | 11:11 | |
*** baoli has joined #openstack-nova | 11:12 | |
*** roeyc has joined #openstack-nova | 11:13 | |
*** ducttape_ has quit IRC | 11:15 | |
*** ducttape_ has joined #openstack-nova | 11:18 | |
*** romainh1 has quit IRC | 11:21 | |
*** sridharg has quit IRC | 11:23 | |
openstackgerrit | Chris Dent proposed openstack/nova: Optional separate database for placement API https://review.openstack.org/362766 | 11:23 |
*** sdague_ has joined #openstack-nova | 11:24 | |
*** sean-k-m1 is now known as sean-k-mooney | 11:29 | |
*** sdague_ is now known as sdague | 11:31 | |
openstackgerrit | jichenjc proposed openstack/nova: move rest_api_version_history.rst to compute layer https://review.openstack.org/409741 | 11:35 |
*** nicolasbock has joined #openstack-nova | 11:35 | |
*** ratailor has quit IRC | 11:37 | |
*** cdent has quit IRC | 11:40 | |
sdague | alex_xu: I was thinking about the parameter validation, and the fact that we're going to be quietly ignoring bad requests. I wonder if we should warn on bad requests, with a config file to turn that off for people that don't care. | 11:41 |
sdague | warn == log warning message | 11:42 |
*** ociuhandu has joined #openstack-nova | 11:42 | |
*** tbachman has quit IRC | 11:44 | |
*** ducttape_ has quit IRC | 11:44 | |
alex_xu | sdague: that sounds ok also. there isn't too much overhead for a warn message. just not sure how that help the API user, as the warn message is on server side | 11:45 |
*** masuberu has quit IRC | 11:45 | |
*** masber has joined #openstack-nova | 11:46 | |
*** baoli has quit IRC | 11:48 | |
*** sapcc-bot has quit IRC | 11:52 | |
*** zhs_ has joined #openstack-nova | 11:54 | |
*** zhs has quit IRC | 11:55 | |
*** prashkre has joined #openstack-nova | 11:55 | |
*** thorst has joined #openstack-nova | 11:56 | |
johnthetubaguy | alex_xu: sdague: it would help operators answer awkward questions from their users | 11:58 |
*** Cristina__ is now known as CristinaPauna | 11:59 | |
alex_xu | johnthetubaguy: sdague, yea, that is helpful :) I will add it | 12:01 |
johnthetubaguy | hopefully, most folks are not using that API, so no one sees them | 12:02 |
openstackgerrit | YuYang proposed openstack/nova: VMware:fix vm get root deivce condition check https://review.openstack.org/402256 | 12:02 |
*** thorst has quit IRC | 12:02 | |
alex_xu | johnthetubaguy: sdague btw, the patches are here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters | 12:02 |
*** dikonoor has quit IRC | 12:02 | |
openstackgerrit | Pavel Gluschak proposed openstack/nova: don't store VNC/SPICE listen addrs in migration data if disabled https://review.openstack.org/396218 | 12:02 |
alex_xu | there are still missing one patch for white list of sort_key, Kevin_Zheng will work on it | 12:02 |
*** flwang has quit IRC | 12:03 | |
prashkre | alex_xu:johnthetubaguy: Hi john/alex. https://review.openstack.org/391113, could you please help me on the issue with build failure from "Intel NFV CI". | 12:03 |
prashkre | thr is a connection issue in the build causing it to fail. how can we get rid off this. | 12:04 |
*** dave-mccowan has joined #openstack-nova | 12:04 | |
*** markvoelker has joined #openstack-nova | 12:07 | |
*** namnh has quit IRC | 12:11 | |
*** markvoelker has quit IRC | 12:12 | |
*** rnoriega has joined #openstack-nova | 12:13 | |
*** baoli has joined #openstack-nova | 12:14 | |
*** mingyu has quit IRC | 12:21 | |
kashyap | lyarwood: I checked w/ one of the devs upstream, probably they're away for lunch. Do you think we can run ImagesTestJSON under Valgrind? | 12:23 |
*** mingyu_ has joined #openstack-nova | 12:24 | |
sdague | johnthetubaguy: yeh, that's what i was thinking. In smaller shops where there is more direct interaction between ops / consumers it would be useful feedback to know some users had buggy code | 12:24 |
*** bvanhav_ has joined #openstack-nova | 12:25 | |
prashkre | alex_xu: Hi Alex. regarding https://review.openstack.org/391113, could you please help me on the issue with build failure from "Intel NFV CI". Thr is a connection issue in the build causing it to fail. how can we fix this? | 12:27 |
*** bkopilov has quit IRC | 12:28 | |
sdague | alex_xu: in https://review.openstack.org/#/c/398755/4/nova/api/openstack/compute/keypairs.py ... is there a way to not have to specify that range twice? | 12:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova: hacking: Reword in the imperative https://review.openstack.org/363624 | 12:31 |
sdague | alex_xu: +2 on first patch, a couple of questions on the ones on top | 12:33 |
alex_xu | sdague: there should be a way, so just make it available for all the versions. Then the scople actually limit by api_version decorator. let me check | 12:33 |
alex_xu | sdague: thanks | 12:33 |
*** flwang has joined #openstack-nova | 12:34 | |
*** baoli has quit IRC | 12:37 | |
*** romainh has joined #openstack-nova | 12:37 | |
alex_xu | sdague: ip6 is valid for admin-user before 2.5. It is just valid for non-admin user after 2.5 | 12:38 |
*** mingyu has joined #openstack-nova | 12:42 | |
*** lucasagomes is now known as lucas-hungry | 12:44 | |
*** erlon-airlong has joined #openstack-nova | 12:45 | |
*** takashin has left #openstack-nova | 12:45 | |
*** ducttape_ has joined #openstack-nova | 12:45 | |
*** mingyu_ has quit IRC | 12:45 | |
*** cdent has joined #openstack-nova | 12:49 | |
*** ducttape_ has quit IRC | 12:50 | |
*** thorst has joined #openstack-nova | 12:50 | |
*** cdent_ has joined #openstack-nova | 12:51 | |
*** eglynn has joined #openstack-nova | 12:51 | |
*** devkulkarni has joined #openstack-nova | 12:51 | |
*** cdent has quit IRC | 12:53 | |
*** cdent_ is now known as cdent | 12:53 | |
openstackgerrit | Pavel Gluschak proposed openstack/nova: don't store VNC/SPICE listen addrs in migration data if disabled https://review.openstack.org/396218 | 12:53 |
*** diga has quit IRC | 12:56 | |
sdague | alex_xu: ah, ok | 12:58 |
sdague | right | 12:58 |
alex_xu | sdague: yea, all the parameters for admin or non-admin are in the schema | 12:58 |
sdague | alex_xu: ok, I'm good with that, especially as we're not causing 400 errors | 12:59 |
*** karthiks has quit IRC | 13:00 | |
sdague | johnthetubaguy / alex_xu : I revived this bug fix from jichen and fixed the one thing that I was -1 on - should eliminate a 500 error - https://review.openstack.org/#/c/282190/ | 13:00 |
*** gcb has quit IRC | 13:01 | |
*** gibi has quit IRC | 13:01 | |
*** bauwser is now known as bauzas | 13:01 | |
alex_xu | sdague: for the alaski's comment, we will address in the future? | 13:01 |
*** kylek3h_away has quit IRC | 13:01 | |
sdague | oh, I hadn't seen that yet | 13:01 |
bauzas | sdague: johnthetubaguy: hola, trivial change needing a +W https://review.openstack.org/#/c/409338/1 | 13:01 |
bauzas | given dansmith, sfinucan and me are within the same company... | 13:02 |
sdague | bauzas: +A | 13:02 |
bauzas | sdague: cool, thanks | 13:03 |
*** FransUrbo has joined #openstack-nova | 13:03 | |
*** mingyu has quit IRC | 13:04 | |
FransUrbo | Where in nova.conf do I specify what interface the instance should use for the network? | 13:04 |
FransUrbo | The default is apparently 'eth0', but for some reason I have 'ens3'! | 13:05 |
*** jwcroppe has quit IRC | 13:06 | |
*** mingyu has joined #openstack-nova | 13:06 | |
*** nherciu_ has joined #openstack-nova | 13:07 | |
*** nherciu has quit IRC | 13:07 | |
cdent | sdague: if you're on an approval kick these adjustments to the process.rst doc may give you some pleasure: https://review.openstack.org/#/c/404991/ | 13:08 |
*** gibi has joined #openstack-nova | 13:08 | |
*** aweeks has quit IRC | 13:09 | |
*** tblakes has joined #openstack-nova | 13:09 | |
*** aweeks has joined #openstack-nova | 13:09 | |
*** pbandark`brb has quit IRC | 13:09 | |
*** hoangcx has joined #openstack-nova | 13:12 | |
*** dirk has quit IRC | 13:12 | |
*** dirk has joined #openstack-nova | 13:12 | |
*** markvoelker has joined #openstack-nova | 13:15 | |
*** karthiks has joined #openstack-nova | 13:16 | |
*** kaisers_ has quit IRC | 13:16 | |
*** kaisers_ has joined #openstack-nova | 13:18 | |
*** kaisers_ has quit IRC | 13:23 | |
*** zenoway has quit IRC | 13:24 | |
*** zenoway has joined #openstack-nova | 13:24 | |
*** jaypipes has joined #openstack-nova | 13:24 | |
kashyap | lyarwood: Unless we can workout a narrow reproducer without running the wholel CI, upstream libvirt can't really pin-point the issue | 13:27 |
kashyap | s/wholel/whole/ | 13:27 |
*** jwcroppe has joined #openstack-nova | 13:29 | |
*** prashkre has quit IRC | 13:29 | |
*** diana_clarke has quit IRC | 13:31 | |
*** kaisers_ has joined #openstack-nova | 13:32 | |
*** figleaf is now known as edleafe | 13:33 | |
*** eharney has quit IRC | 13:34 | |
*** bhagyashris has joined #openstack-nova | 13:34 | |
*** prateek has quit IRC | 13:34 | |
*** diana_clarke has joined #openstack-nova | 13:35 | |
*** paul-carlton2 has joined #openstack-nova | 13:37 | |
*** rtheis has joined #openstack-nova | 13:38 | |
*** kaisers_ has quit IRC | 13:38 | |
johnthetubaguy | sdague: re that patch, we also have this fix up which is an interesting take on a very related issue: https://review.openstack.org/#/c/392305/ | 13:38 |
*** ljxiash has quit IRC | 13:40 | |
*** kylek3h_away has joined #openstack-nova | 13:40 | |
*** kaisers_ has joined #openstack-nova | 13:40 | |
*** baoli has joined #openstack-nova | 13:40 | |
*** baoli has quit IRC | 13:40 | |
*** ljxiash has joined #openstack-nova | 13:40 | |
*** baoli has joined #openstack-nova | 13:41 | |
*** kylek3h_away has quit IRC | 13:41 | |
*** briancurtin has quit IRC | 13:42 | |
*** briancurtin has joined #openstack-nova | 13:42 | |
*** ljxiash has quit IRC | 13:45 | |
sdague | johnthetubaguy: so... I'm not super sure that we should fix that one | 13:45 |
*** amoralej is now known as amoralej|lunch | 13:45 | |
edleafe | Scheduler subteam meeting in 15 minutes in #openstack-meeting-alt | 13:45 |
sdague | it's not like you can't find that instance | 13:45 |
johnthetubaguy | sdague: true, but its a very strange CLI experience | 13:47 |
sdague | johnthetubaguy: these are kind of the bugs inherent with regex, and given that instances can be renamed, I kind of wonder if we should instead provide a warning about not using these characters | 13:47 |
johnthetubaguy | sdague: the fallback to exact match seems non-terrible | 13:47 |
*** s1061123 has quit IRC | 13:48 | |
*** s1061123 has joined #openstack-nova | 13:48 | |
johnthetubaguy | sdague: possibly | 13:49 |
sdague | johnthetubaguy: honestly, if we are going to play with this, I'd change the order | 13:49 |
sdague | and always try exact match first | 13:49 |
*** amotoki has joined #openstack-nova | 13:50 | |
*** karthiks has quit IRC | 13:51 | |
johnthetubaguy | sdague: hmm that sounds attractive, but then this way we only do one DB query | 13:51 |
*** clenimar has joined #openstack-nova | 13:51 | |
*** zhenguo has quit IRC | 13:52 | |
*** zhenguo has joined #openstack-nova | 13:52 | |
*** bauzas has quit IRC | 13:53 | |
*** bauzas has joined #openstack-nova | 13:53 | |
sdague | johnthetubaguy: yeh, I don't know https://review.openstack.org/#/c/392305/6/nova/db/sqlalchemy/api.py just seems complicated enough to figure out what is going on that when the next bug fix gets applied it kind of sinks into the swamp | 13:53 |
sdague | johnthetubaguy: maybe I'll be convinced after this cup of coffee | 13:54 |
*** xyang1 has joined #openstack-nova | 13:56 | |
johnthetubaguy | sdague: thats a fair comment, its getting close | 13:56 |
*** kylek3h has joined #openstack-nova | 13:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/395347 | 13:57 |
*** liverpooler has joined #openstack-nova | 13:59 | |
*** dikonoor has joined #openstack-nova | 14:00 | |
edleafe | Scheduler subteam meeting starting now in #openstack-meeting-alt | 14:00 |
*** tlian has joined #openstack-nova | 14:00 | |
*** amotoki has quit IRC | 14:01 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: hacking: Reword in the imperative https://review.openstack.org/363624 | 14:02 |
*** lucas-hungry is now known as lucasagomes | 14:02 | |
*** oanson has quit IRC | 14:02 | |
*** tbachman has joined #openstack-nova | 14:04 | |
*** bvanhav__ has joined #openstack-nova | 14:04 | |
*** karthiks has joined #openstack-nova | 14:04 | |
*** hongbin has joined #openstack-nova | 14:04 | |
alex_xu | johnthetubaguy: sdague the pattern matching can't get benefit from db index, so we probably can remove it in the future | 14:04 |
*** diga has joined #openstack-nova | 14:04 | |
johnthetubaguy | alex_xu: except many folks rely on it, and searchlight can do it super quickly | 14:05 |
*** bvanhav_ has quit IRC | 14:06 | |
johnthetubaguy | alex_xu: don't get me wrong, I wish it was never added, hmm, I duno really | 14:06 |
alex_xu | johnthetubaguy: at least only do exact match after a microversion | 14:06 |
johnthetubaguy | maybe | 14:06 |
openstackgerrit | Chris Dent proposed openstack/nova: Quiet unicode warnings in functional test_resource_provider https://review.openstack.org/409802 | 14:07 |
cdent | trivial fix ^ | 14:07 |
*** ducttape_ has joined #openstack-nova | 14:10 | |
*** eharney has joined #openstack-nova | 14:12 | |
*** bvanhav__ is now known as bvanhav | 14:13 | |
*** zzzeek has quit IRC | 14:13 | |
*** flwang has quit IRC | 14:14 | |
*** zzzeek has joined #openstack-nova | 14:14 | |
*** diga has quit IRC | 14:15 | |
*** jheroux has joined #openstack-nova | 14:16 | |
*** ababich has quit IRC | 14:17 | |
*** mdnadeem has quit IRC | 14:18 | |
*** NightKhaos has quit IRC | 14:18 | |
*** jianghuaw has quit IRC | 14:18 | |
*** purplerbot has quit IRC | 14:18 | |
*** mingyu has quit IRC | 14:18 | |
*** paw has quit IRC | 14:18 | |
*** mingyu has joined #openstack-nova | 14:20 | |
*** eharney has quit IRC | 14:20 | |
*** ljxiash has joined #openstack-nova | 14:21 | |
*** paw has joined #openstack-nova | 14:23 | |
*** jianghuaw has joined #openstack-nova | 14:23 | |
*** ababich has joined #openstack-nova | 14:25 | |
*** amoralej|lunch is now known as amoralej | 14:25 | |
*** mingyu has quit IRC | 14:25 | |
*** ljxiash has quit IRC | 14:25 | |
*** NightKhaos has joined #openstack-nova | 14:26 | |
*** mdnadeem has joined #openstack-nova | 14:26 | |
*** mriedem has joined #openstack-nova | 14:27 | |
*** flwang has joined #openstack-nova | 14:31 | |
*** ayoung has joined #openstack-nova | 14:32 | |
*** esberglu has joined #openstack-nova | 14:33 | |
*** eharney has joined #openstack-nova | 14:34 | |
*** esberglu_ has joined #openstack-nova | 14:35 | |
*** esberglu has quit IRC | 14:37 | |
*** jamielennox is now known as jamielennox|away | 14:38 | |
*** ducttape_ has quit IRC | 14:40 | |
*** ducttape_ has joined #openstack-nova | 14:42 | |
*** siva_krish has joined #openstack-nova | 14:43 | |
cdent | bauzas, jaypipes, edleafe forgot to mention this in bug fix in the meeting (not mine): https://review.openstack.org/#/c/390984/ | 14:43 |
*** mingyu has joined #openstack-nova | 14:43 | |
cdent | it's about issues with free_ram_mb | 14:44 |
cdent | (edleafe thanks for already going round) | 14:44 |
bauzas | cdent: oula | 14:44 |
bauzas | that's a big deal | 14:44 |
bauzas | I mean, I know the problem but I fear it can be easily solvef | 14:45 |
bauzas | cdent: I'll look at the change and see | 14:45 |
cdent | thanks | 14:45 |
*** jamielennox|away is now known as jamielennox | 14:45 | |
*** prateek has joined #openstack-nova | 14:47 | |
*** jheroux has quit IRC | 14:47 | |
*** ducttape_ has quit IRC | 14:48 | |
edleafe | cdent: I sort of understand the fix, but couldn't find a test case where it changed the result | 14:49 |
*** siva_krish has quit IRC | 14:53 | |
*** mingyu has quit IRC | 14:55 | |
*** mingyu has joined #openstack-nova | 14:56 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Validate huge pages https://review.openstack.org/399653 | 14:56 |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Combine multiple NUMA-generation functions https://review.openstack.org/402561 | 14:56 |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Don't reinvent __init__ https://review.openstack.org/402560 | 14:56 |
openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: create functional test base class https://review.openstack.org/407055 | 14:56 |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Remove duplicate NumaHostInfo https://review.openstack.org/402562 | 14:56 |
*** ekuris has quit IRC | 14:57 | |
*** mingyu has quit IRC | 14:57 | |
*** baoli has quit IRC | 14:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: libvirt: create functional test base class https://review.openstack.org/407055 | 14:58 |
*** siva_krish has joined #openstack-nova | 14:58 | |
sfinucan | vladikr: If you get a chance, could you take a peek at ^, please? | 14:59 |
openstackgerrit | Maciej Szankin proposed openstack/nova: conf: fix N313 hacking check https://review.openstack.org/409818 | 14:59 |
*** cfriesen has joined #openstack-nova | 15:00 | |
openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(1): Introduce base PowerVM driver https://review.openstack.org/391288 | 15:00 |
vladikr | sfinucan, sure, will do | 15:01 |
*** jheroux has joined #openstack-nova | 15:01 | |
*** kaisers_ has quit IRC | 15:02 | |
*** purplerbot has joined #openstack-nova | 15:02 | |
* sfinucan embarks on a series of Mox->mock reviews. Oh boy | 15:03 | |
*** pradk has joined #openstack-nova | 15:04 | |
*** mtanino has joined #openstack-nova | 15:05 | |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting now to address acute performance issues, and will be back online momentarily. | 15:06 | |
cdent | bbl | 15:08 |
*** cdent has quit IRC | 15:08 | |
*** asettle__ has joined #openstack-nova | 15:08 | |
*** asettle has quit IRC | 15:10 | |
*** ayoung is now known as ayoung_afk | 15:11 | |
*** pkholkin has quit IRC | 15:15 | |
*** pkholkin has joined #openstack-nova | 15:15 | |
*** burt has joined #openstack-nova | 15:16 | |
dansmith | mriedem: wanna hit this one too? https://review.openstack.org/#/c/409706/ | 15:18 |
dansmith | lyarwood: thanks for being on those before I was even awake :) | 15:18 |
*** ducttape_ has joined #openstack-nova | 15:19 | |
*** whenry has quit IRC | 15:21 | |
lyarwood | dansmith: np | 15:21 |
*** hongbin has quit IRC | 15:22 | |
*** FransUrbo has left #openstack-nova | 15:23 | |
*** karlamrhein has quit IRC | 15:23 | |
*** karlamrhein has joined #openstack-nova | 15:24 | |
jaypipes | edleafe: I'll review https://review.openstack.org/#/c/390984/ simply due to the awesomeness of the submitter's name. | 15:24 |
jaypipes | a true Viking. | 15:24 |
*** bnemec has joined #openstack-nova | 15:25 | |
* edleafe considers changing his name to Leafe Edrickson | 15:25 | |
jaypipes | edleafe: :) | 15:25 |
sdague | jaypipes: once you get done with that, here is the interesting SQL optimization opportunity - https://bugs.launchpad.net/nova/+bug/1632247 | 15:25 |
openstack | Launchpad bug 1632247 in OpenStack Compute (nova) "We fetch all instance faults, then throw away all but the last ones on "nova list --all-tenants", potentinally making the command slow" [Medium,Confirmed] - Assigned to Sivasathurappan Radhakrishnan (siva-radhakrishnan) | 15:25 |
*** tbachman_ has joined #openstack-nova | 15:25 | |
jaypipes | sdague: coolio. will look at it shortly.] | 15:26 |
*** tbachman has quit IRC | 15:28 | |
*** tbachman_ is now known as tbachman | 15:28 | |
*** baoli has joined #openstack-nova | 15:30 | |
openstackgerrit | Diana Clarke proposed openstack/nova: Simple tenant usage pagination https://review.openstack.org/386093 | 15:30 |
sdague | hmmmm ceph seems to be going off the rails a bit - http://tinyurl.com/zerjov2 | 15:30 |
*** dave-mccowan has quit IRC | 15:31 | |
jaypipes | sdague: yeah, seems that way :( | 15:34 |
*** ratailor has joined #openstack-nova | 15:35 | |
*** ratailor has quit IRC | 15:35 | |
dansmith | sdague: got a link to an actual failed run? | 15:35 |
*** ratailor has joined #openstack-nova | 15:36 | |
sdague | dansmith: http://logs.openstack.org/90/282190/10/gate/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/87dc42f/ | 15:37 |
*** ociuhandu has quit IRC | 15:37 | |
sdague | that's a current gate reset | 15:37 |
openstackgerrit | Diana Clarke proposed openstack/nova: Simple tenant usage pagination https://review.openstack.org/386093 | 15:39 |
*** tbachman has quit IRC | 15:40 | |
lyarwood | sdague: I'm also seeing that against stable/newton btw - http://logs.openstack.org/74/409774/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/db56c77/console.html#_2016-12-12_14_07_13_293394 | 15:41 |
*** gcb has joined #openstack-nova | 15:42 | |
*** lpetrut has quit IRC | 15:42 | |
dansmith | so, mriedem had a change up to expand the size of the space we use for volumes right? | 15:42 |
dansmith | did that get merged? because: | 15:42 |
dansmith | http://logs.openstack.org/90/282190/10/gate/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/87dc42f/logs/screen-c-api.txt.gz?level=TRACE#_2016-12-12_14_56_03_184 | 15:42 |
*** burgerk has joined #openstack-nova | 15:42 | |
mriedem | dansmith: i think that's a false negative | 15:42 |
mriedem | i.e. negative tempest test | 15:42 |
mriedem | it's just that cinder api logs it as an error | 15:42 |
dansmith | yeah, I was just realizing | 15:43 |
dansmith | gross | 15:43 |
mriedem | BaseVolumeQuotasNegativeV2TestJSON | 15:43 |
mriedem | yeah | 15:43 |
mriedem | https://review.openstack.org/#/c/364887/ | 15:43 |
*** jdurgin1 has joined #openstack-nova | 15:44 | |
mriedem | dansmith: if you're hitting ceph failures my guess would be http://status.openstack.org//elastic-recheck/index.html#1648885 | 15:44 |
mriedem | which is spiking since friday | 15:44 |
dansmith | mriedem: yeah, sdague just brought it up above | 15:45 |
*** brault_ has joined #openstack-nova | 15:45 | |
gcb | mriedem, about https://review.openstack.org/#/c/408416/, can we enable py35 job voting now ? | 15:46 |
*** dikonoor has quit IRC | 15:47 | |
*** dave-mccowan has joined #openstack-nova | 15:47 | |
*** brault has quit IRC | 15:47 | |
*** romainh has quit IRC | 15:47 | |
*** romainh1 has joined #openstack-nova | 15:47 | |
*** mdnadeem has quit IRC | 15:48 | |
*** armax has joined #openstack-nova | 15:48 | |
kashyap | sdague: Is the change here worth it, since it's a backport (of yours) -- https://review.openstack.org/#/c/409775/1/nova/tests/unit/virt/test_images.py | 15:48 |
*** Sukhdev has joined #openstack-nova | 15:48 | |
mriedem | gcb: i think i'm ok with that, i just wanted to wait until monday because i didn't want to add a new voting job in nova's gate queue on a friday | 15:49 |
*** markus_z has quit IRC | 15:49 | |
gcb | mriedem, makes sense :-) | 15:49 |
mriedem | kashyap: sdague: why are we backporting https://review.openstack.org/#/c/409775/ to mitaka? | 15:49 |
mriedem | isn't that a rather latent issue? | 15:50 |
mriedem | i.e. not critical? | 15:50 |
kashyap | mriedem: Not worth it? | 15:50 |
sdague | mriedem: oh, mitaka's gone sec only now? | 15:50 |
kashyap | mriedem: We still 'support' them upstream, and is not really critical | 15:50 |
*** burgerk has quit IRC | 15:50 | |
sdague | yeh, probably not worth it for mitaka | 15:50 |
kashyap | But is useful, IMO | 15:50 |
kashyap | If you all disagree, can be dropped. | 15:50 |
mriedem | i don't see this as critical for mitaka | 15:51 |
sdague | mriedem: good point, I'll switch to -1 on that | 15:51 |
sdague | I still think for newton we should do it | 15:51 |
sdague | especially as it's super low risk | 15:51 |
mriedem | i'm fine with newton | 15:51 |
sdague | that would be the mitaka argument, this is very low risk | 15:51 |
*** harlowja_at_home has joined #openstack-nova | 15:52 | |
mriedem | sdague: dansmith: fyi gcb is requesting to make the py35 job voting and gating on nova ^ | 15:52 |
mriedem | https://review.openstack.org/#/c/408416/ | 15:52 |
sdague | can we drop the 34 job? | 15:53 |
mriedem | good question | 15:53 |
mriedem | gcb: ^? | 15:53 |
mriedem | do we need both py34 and py35 coverage? | 15:53 |
*** prateek has quit IRC | 15:54 | |
*** armax has quit IRC | 15:54 | |
gcb | mriedem, current we support both of them | 15:54 |
kashyap | sdague: mriedem: Yeah, for Newton, it's worth it | 15:54 |
*** _ducttape_ has joined #openstack-nova | 15:56 | |
*** yamahata has joined #openstack-nova | 15:56 | |
mriedem | gcb: nova doesn't claim to support any py3* | 15:56 |
mriedem | so if we're going to do one, why not just py35? | 15:56 |
openstackgerrit | Diana Clarke proposed openstack/nova: Simple tenant usage pagination https://review.openstack.org/386093 | 15:56 |
*** burgerk has joined #openstack-nova | 15:57 | |
gcb | I don't think we can drop py34 voting job now, other projects also have both of py34 and py35 . we need more work to claim py3* supporting | 15:58 |
*** ducttap__ has joined #openstack-nova | 15:58 | |
*** _ducttape_ has quit IRC | 15:58 | |
mriedem | gh | 15:58 |
mriedem | *ugh | 15:58 |
mriedem | how many py3*'s are there going to be? | 15:58 |
mriedem | py36 and py37? | 15:58 |
gcb | mriedem, py36 as I know | 15:59 |
*** ducttape_ has quit IRC | 15:59 | |
mriedem | dhellmann: for the py3 goal in pike are we going to be expected to be running 2+ py3x gate jobs just for py3 compliance? | 15:59 |
mriedem | plus py27? | 15:59 |
dhellmann | mriedem : I'm not sure I understand the question. | 16:00 |
gcb | mriedem, maybe we need ask infra guys about the py3* support plan | 16:00 |
mriedem | dhellmann: we already have a py34 job, | 16:00 |
mriedem | and a non-voting py35 job | 16:00 |
mriedem | gcb is requesting to make py35 voting and gating | 16:00 |
mriedem | and says there will be py36 eventually | 16:00 |
dhellmann | ah, yeah. I think we'd end up dropping the py34 job(s) | 16:00 |
dhellmann | there will be, but not any time soon | 16:00 |
mriedem | so i'm asking if we're going just target a single py3 | 16:00 |
dhellmann | that's only an rc, and no distros are packaging it yet in their long-term support versions | 16:00 |
dhellmann | yes, py35 | 16:01 |
*** alexpilotti has quit IRC | 16:01 | |
openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | 16:01 |
mriedem | can we drop py34 today then? | 16:01 |
dhellmann | the CTI has been updated to 3.5, but we haven't updated the job definitions | 16:01 |
dhellmann | I think so, but I'm not sure what the 3.5 status is in infra right now. You should be able to switch. | 16:01 |
*** eharney has quit IRC | 16:01 | |
mriedem | or are there distros we need to support for ocata that only have py34? | 16:01 |
*** alexpilotti has joined #openstack-nova | 16:01 | |
mriedem | even though nova doesn't support py34... | 16:01 |
mriedem | we're just running unit tests | 16:01 |
dhellmann | we're not claiming anyone can run under 3.4 for now | 16:01 |
mriedem | and a limited set at that | 16:01 |
mriedem | ok | 16:02 |
mriedem | gcb: so i'm going to -1 your change, | 16:02 |
dhellmann | some projects may claim that separately, and they can keep the 3.4 jobs | 16:02 |
mriedem | to drop py34 | 16:02 |
sdague | dhellmann: right, the question on the table right this second is making 3.5 unit tests vote. And the counter question is "can we drop the 3.4 unit test job at the same time". And I believe your answer is "yes". | 16:02 |
*** annegentle has joined #openstack-nova | 16:02 | |
dhellmann | sdague : I think so, yes. There may be implementation details that complicate that, but in principle it should be fine. | 16:03 |
sdague | dhellmann: ok, great, thanks | 16:03 |
gcb | mriedem, we just need py35 voting job ,right ? | 16:03 |
sdague | dhellmann: I'm fine if that's the right idea in principle, and we need implementation to catch up. Just wanted to clarify direction/intention | 16:03 |
mriedem | gcb: yes | 16:03 |
kashyap | mriedem: Oops, missed my mind that Mitaka is only 'Security-supported' | 16:04 |
*** armax has joined #openstack-nova | 16:04 | |
mriedem | gcb: i think you can just remove this "- name: python34-db-jobs" from https://review.openstack.org/#/c/408416/1/zuul/layout.yaml | 16:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy' https://review.openstack.org/408192 | 16:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate 'console_driver' https://review.openstack.org/408193 | 16:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova: tests: Replace use of CONF with monkey patching https://review.openstack.org/408191 | 16:04 |
edleafe | dhellmann: mriedem: https://www.python.org/dev/peps/pep-0494/#schedule | 16:04 |
edleafe | not that it will be in any distros any time soon | 16:04 |
mriedem | ok | 16:05 |
mriedem | we can probably follow up gcb's patch with a nova change to drop the py34 tox targets | 16:05 |
*** jaosorior has quit IRC | 16:10 | |
*** kristian__ has joined #openstack-nova | 16:10 | |
*** jaosorior has joined #openstack-nova | 16:10 | |
kristian__ | Hi, will someone be able to look at my spec for nova? | 16:11 |
kristian__ | https://gist.github.com/kristiandrucker/eaa863f5526c616f7452ca178fd6d241 | 16:11 |
*** moshele has quit IRC | 16:11 | |
kristian__ | and tell me if its alredy implemented or can somebody publish it if it will be alright? | 16:12 |
gcb | mriedem, just update https://review.openstack.org/#/c/408416 | 16:12 |
*** zenoway has quit IRC | 16:12 | |
*** zenoway has joined #openstack-nova | 16:13 | |
gcb | I also plan to create py35 functional tests job in https://review.openstack.org/#/c/408561/, that's just a draft ,would like more inputs | 16:14 |
mriedem | gcb: that seems ok | 16:15 |
*** eharney has joined #openstack-nova | 16:16 | |
*** zz_dimtruck has joined #openstack-nova | 16:16 | |
*** zz_dimtruck is now known as dimtruck | 16:17 | |
bauzas | jaypipes: I'm super not happy with https://review.openstack.org/#/c/390984/ as we're basically punting a problem by changing the behaviour | 16:17 |
*** zenoway has quit IRC | 16:18 | |
bauzas | jaypipes: at least, we need to make sure that compute.memory_mb_used is correctly getting the right values | 16:18 |
*** hongbin has joined #openstack-nova | 16:20 | |
*** roeyc has quit IRC | 16:23 | |
*** sajeesh has joined #openstack-nova | 16:26 | |
*** pradk- has joined #openstack-nova | 16:28 | |
*** pradk- has quit IRC | 16:28 | |
*** pradk- has joined #openstack-nova | 16:29 | |
*** pradk- has quit IRC | 16:29 | |
*** pradk- has joined #openstack-nova | 16:30 | |
*** pradk- has quit IRC | 16:30 | |
openstackgerrit | Julian proposed openstack/nova: Transform keypair.create notification https://review.openstack.org/408689 | 16:31 |
sfinucan | johnthetubaguy: What's your thoughts on this https://review.openstack.org/#/c/392566/ ? Kill 'nova/conf/virt' in favour of 'nova/conf/compute' | 16:31 |
*** pradk has quit IRC | 16:31 | |
johnthetubaguy | sfinucan: yeah, I am leaning that way | 16:31 |
sfinucan | johnthetubaguy: So am I | 16:31 |
*** pradk has joined #openstack-nova | 16:32 | |
*** nkrinner is now known as nkrinner_afk | 16:32 | |
sfinucan | I'll do that so | 16:32 |
*** bvanhav has quit IRC | 16:32 | |
johnthetubaguy | sfinucan: cool, thanks, didn't think about that till reading that this morning | 16:33 |
*** bvanhav has joined #openstack-nova | 16:34 | |
sfinucan | yeah, we could probably break compute up further, but I'll do that via groups rather than separate files | 16:34 |
sfinucan | also, as you're on a config-opt rampage: https://review.openstack.org/#/c/395683/ :P | 16:34 |
*** andreas_s has quit IRC | 16:34 | |
gcb | edleafe, about https://review.openstack.org/#/c/385686, I think we can keep basepython = python2.7, then I can rebase your patch :-) | 16:35 |
openstackgerrit | Diana Clarke proposed openstack/nova: Simple tenant usage pagination https://review.openstack.org/386093 | 16:35 |
*** diogogmt has joined #openstack-nova | 16:35 | |
bauzas | jaypipes: so, after thinking about https://review.openstack.org/#/c/390984/5 for a while, I think we can move forward and accept that one, but properly communicate the big change in it | 16:36 |
*** cdent has joined #openstack-nova | 16:39 | |
edleafe | gcb: I'll take care of it, thanks | 16:40 |
gcb | edleafe, thanks | 16:40 |
*** dikonoor has joined #openstack-nova | 16:40 | |
edleafe | gcb: melwitt: the functional tests were passing on my machine, and mriedem asked to have that removed | 16:40 |
edleafe | gcb: melwitt: but if the gate is different, I'd like to see the failures so that I can fix those, too | 16:41 |
gcb | edleafe, do we need a py35-functional-test job ? I'm not sure how many functional tests will failure, please see https://review.openstack.org/#/c/408561/1/tests-functional-py3.txt | 16:43 |
gcb | which are failure tests in my local machine, the number of items will be reduce when after merging https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/goal-python35 | 16:44 |
*** prashkre has joined #openstack-nova | 16:45 | |
*** asettle__ is now known as asettle | 16:45 | |
gcb | edleafe, maybe we need handle functional tests on Python 35 as we handle unit tests on Python 34, make sure the job run success with blacklist | 16:46 |
gcb | then reduce the items in blacklist | 16:46 |
*** ducttap__ has quit IRC | 16:48 | |
*** ducttape_ has joined #openstack-nova | 16:48 | |
* gcb I must go to bed now, edleafe ,please add comments, thanks | 16:49 | |
*** gcb has quit IRC | 16:49 | |
edleafe | gcb: will do | 16:50 |
*** ratailor has quit IRC | 16:51 | |
*** weshay is now known as weshay_brb | 16:54 | |
*** harlowja_at_home has quit IRC | 16:55 | |
*** owalsh is now known as owalsh-afk | 16:56 | |
*** mlavalle has joined #openstack-nova | 16:56 | |
*** tbachman has joined #openstack-nova | 16:56 | |
kristian__ | Please may someone look at my spec that I posted earlier? | 16:58 |
*** pcaruana has quit IRC | 16:59 | |
*** annegentle has quit IRC | 17:00 | |
*** kaisers_ has joined #openstack-nova | 17:02 | |
sfinucan | kristian__: Would it be possible to submit it to Gerrit instead? It would definitely get more attention there | 17:02 |
kristian__ | ok | 17:03 |
*** thorst has quit IRC | 17:03 | |
sfinucan | Anyone able to tell me the difference between 'CONF.default_schedule_zone' and 'CONF.default_availability_zone'? They look suspiciously similar -_- | 17:05 |
mriedem | dansmith: mayhap you'd like to peruse https://review.openstack.org/#/c/404456/ | 17:06 |
*** sacharya has joined #openstack-nova | 17:06 | |
kristian__ | sfinucan: where in gerrit | 17:06 |
*** kaisers_ has quit IRC | 17:06 | |
*** thorst has joined #openstack-nova | 17:06 | |
mriedem | kristian__: https://specs.openstack.org/openstack/nova-specs/readme.html | 17:06 |
*** ircuser-1 has joined #openstack-nova | 17:07 | |
sfinucan | ^ what he said | 17:07 |
*** gouthamr has joined #openstack-nova | 17:08 | |
*** nic has joined #openstack-nova | 17:08 | |
*** Oku_OS is now known as Oku_OS-away | 17:09 | |
*** annegentle has joined #openstack-nova | 17:09 | |
mriedem | sdague: so we want to make the placement service run by default in ocata changes, i had posted some notes on that to the ML which i can dig up, but i thought that might be as simple as tweaking some things in devstack-gate's feature matrix yaml file | 17:10 |
*** thorst has quit IRC | 17:10 | |
*** matrohon has quit IRC | 17:11 | |
*** sudipto has quit IRC | 17:13 | |
mriedem | sdague: in http://lists.openstack.org/pipermail/openstack-dev/2016-December/108404.html | 17:13 |
*** moshele has joined #openstack-nova | 17:14 | |
*** Sukhdev has quit IRC | 17:16 | |
*** Zer0Byte__ has joined #openstack-nova | 17:16 | |
sdague | yeh, what we probably want to do is make it a top level service | 17:19 |
sdague | mriedem / cdent you up for doing this now? I could push a WIP patch | 17:22 |
mriedem | sdague: it is a top level service | 17:22 |
mriedem | i think placement-api in devstack | 17:22 |
mriedem | so we just restrict it to ocata+ | 17:22 |
cdent | sdague: are you asking if now is the right time, or if one of us want to do the change? | 17:22 |
mriedem | i'm fine with a wip for now | 17:23 |
mriedem | to see what blows up if anything | 17:23 |
mriedem | like....cells v1? | 17:23 |
mriedem | although cells v1 should be ok, it's a different endpoint | 17:23 |
mriedem | so computes in the child cell can just talk to it, no up calls | 17:23 |
jaypipes | bauzas: I don't really share your concern that that patch changes behaviour of the RAM calculation (other than to account for overcommit ratio, which is a correct fix, no?) | 17:23 |
bauzas | jaypipes: I think we should at least explain to the operators that | 17:24 |
mriedem | we've been talking about a nova-manage ready_for_upgrade command to check that, but still need to flesh out some details, i.e. where is that run from? controller? computes? | 17:24 |
sdague | mriedem / cdent - https://review.openstack.org/409871 is maybe the right way to do that | 17:25 |
* cdent looks | 17:25 | |
mriedem | cool yeah i thought something like that | 17:26 |
mriedem | will check CI results when they are in | 17:26 |
sdague | yeh | 17:26 |
cdent | so the 'rm-services' concept is no longer needed? | 17:26 |
cdent | (or at least not in this case) | 17:26 |
cdent | oh because it is top level | 17:27 |
mriedem | at some point i want to try and get my thoughts down on the ready for upgrade command and then have a hangout to discuss it a bit, or the plan there | 17:27 |
sdague | cdent: the rm-services was mostly used for alternative configurations like neutron turning off nova-net | 17:27 |
sdague | this feels better to just define it as a truly top level thing like nova from the outset | 17:28 |
cdent | yeah | 17:28 |
jaypipes | bauzas: you mean explain that the filters/weights now properly account for overcommit ratio, yes? | 17:29 |
mriedem | sdague: cdent: things might get a bit weird with that patch in the multinode job | 17:30 |
mriedem | i.e. i wonder if the placement-api service will be running on the compute node | 17:30 |
mriedem | *subnode | 17:30 |
jaypipes | bauzas: sure, no disagreement that a reno note would be useful. | 17:30 |
sdague | mriedem: subnode is so weird and custom hard coded right now anyway | 17:30 |
bauzas | jaypipes: nope, just explaining that we had a problem with the RAMFilter that is fixed by checking a separate field | 17:31 |
*** dikonoor has quit IRC | 17:31 | |
mriedem | that hurts subnodes feelings | 17:31 |
jaypipes | bauzas: gotcha. | 17:31 |
jaypipes | bauzas: cool with me. | 17:31 |
*** akshilv has joined #openstack-nova | 17:31 | |
bauzas | jaypipes: so in case operators wonder why the filter is getting new computes, they can look at the release notes and say "okay, so I can go to the chan and ask for more" | 17:31 |
jaypipes | and... off I go to rebase all my patches :) | 17:31 |
bauzas | me too :) | 17:32 |
jaypipes | bauzas: ++ | 17:32 |
mriedem | heh the reno says to come to this channel and ask for info? | 17:33 |
mriedem | at which point we'll tell them, this isn't a support channel | 17:33 |
mriedem | i'd redirect to the bug or whatever actually has more info, rather than telling operators to come here | 17:33 |
mriedem | jaypipes: bauzas: ^ | 17:33 |
*** slaweq_ has quit IRC | 17:34 | |
*** akshilv has quit IRC | 17:35 | |
jaypipes | mriedem: well, yes, I didn't agree with telling operators to come to this channel for assistance :) just that a reno note saying something was changed/fixed in the ramfilter was useful. | 17:36 |
*** akshilv has joined #openstack-nova | 17:37 | |
bauzas | mriedem: I'm not saying that the reno note should tell that, for sure :) | 17:38 |
mwhahaha | hey guys, i wanted to bring https://bugs.launchpad.net/tripleo/+bug/1649341 to your attention. It looks like the db sync action for the new cells stuff may not be documented correctly (or even work). https://review.openstack.org/#/c/392227 was the requirement addition | 17:38 |
openstack | Launchpad bug 1649341 in tripleo "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Undecided,Triaged] | 17:38 |
bauzas | mriedem: I just think we should explain some stuff and leave the operators with that, so in case they have some question, they could go here :) | 17:39 |
*** lpetrut has joined #openstack-nova | 17:39 | |
*** bvanhav has quit IRC | 17:40 | |
*** bvanhav has joined #openstack-nova | 17:40 | |
*** slaweq_ has joined #openstack-nova | 17:40 | |
jaypipes | mwhahaha: hey Alex, thanks for bringing this to our attention. dansmith and I can look into it. | 17:41 |
mwhahaha | jaypipes: it looks like maybe transport url is a requirement of it, we don't currently configure it in tripleo (i'll get on that as well) | 17:41 |
*** weshay_brb is now known as weshay | 17:43 | |
kristian__ | Is it possible to run games on openstack? | 17:45 |
*** mlavalle has quit IRC | 17:45 | |
*** shardy has joined #openstack-nova | 17:46 | |
*** mlavalle has joined #openstack-nova | 17:46 | |
mriedem | mwhahaha: yeah should be the cell_v2 command group not db | 17:46 |
*** kristian__ has quit IRC | 17:46 | |
mriedem | that's a bug in nova on telling you the wrong command to run :( | 17:46 |
*** lucasagomes is now known as lucas-afk | 17:46 | |
mwhahaha | mriedem: the other issue is why is the transport-url required for that command? | 17:47 |
mwhahaha | when you have to provide the config | 17:47 |
mwhahaha | mriedem: shouldn't it pull it from the config? | 17:47 |
shardy | mriedem: Yeah I've been trying to figure out what to pass to cell_v2 simple_cell_setup --transport-url | 17:47 |
shardy | it appears to be mandatory, even if you pass -c /etc/nova/nova.conf | 17:47 |
shardy | and cut/paste of the transport_url from nova.conf doesn't work ref https://bugs.launchpad.net/tripleo/+bug/1649341/comments/2 | 17:48 |
openstack | Launchpad bug 1649341 in tripleo "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Undecided,Triaged] | 17:48 |
*** roeyc has joined #openstack-nova | 17:49 | |
*** gouthamr has quit IRC | 17:50 | |
*** matrohon has joined #openstack-nova | 17:51 | |
jaypipes | shardy: are you saying that when you run nova-manage cell_v2 simple_cell_setup --transport-url=<URL> that that command does not work? | 17:52 |
*** gouthamr has joined #openstack-nova | 17:52 | |
jaypipes | shardy: or just that the transport URL isn't read from the conf file? | 17:52 |
shardy | jaypipes: yes, I cut/paste the transport_url from nova.conf, and it fails, as in that link above | 17:52 |
*** Swami has joined #openstack-nova | 17:52 | |
*** gouthamr has quit IRC | 17:52 | |
shardy | I assume --transport-url expects a different format to the transport_url in the config file, but I'm not sure what | 17:53 |
jaypipes | shardy: gotcha. | 17:53 |
mwhahaha | from a deployment tooling perspective it would be beneficial not to require --transport-url on the command line either so if it doesn't pull it from the config that's also a problem | 17:53 |
*** BobBall is now known as BobBall_AWOL | 17:54 | |
*** prashkre has quit IRC | 17:54 | |
mwhahaha | credentials in command lines are bad | 17:54 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Fix instructions for running simple_cell_setup https://review.openstack.org/409876 | 17:54 |
jaypipes | mwhahaha: yeah. dansmith, any reason you can think of why the --transport-url CLI option is required instead of using the conf file value? | 17:54 |
mriedem | see | 17:55 |
mriedem | # TODO(melwitt): Remove this when the oslo.messaging function | 17:55 |
mriedem | # for assembling a transport url from ConfigOpts is available | 17:55 |
mriedem | which is why it's passed in today | 17:55 |
mwhahaha | mmm techdebt | 17:55 |
jaypipes | interesting | 17:55 |
dansmith | yeah, oslo.msg is a disaster for that opts stuff | 17:56 |
mwhahaha | I thought it has a way to build the url now? | 17:56 |
mriedem | melwitt would know the latest on that stuff, but i thought she was working a blueprint or something for it in newton | 17:57 |
mwhahaha | i added in transport_url support to all the puppet modules last month and i was using the oslo stuff as my reference | 17:57 |
*** openstack has joined #openstack-nova | 17:59 | |
*** fragatina has quit IRC | 17:59 | |
*** fragatina has joined #openstack-nova | 18:00 | |
mriedem | mwhahaha: why can't you pass the transport_url in? | 18:00 |
mwhahaha | mriedem: it may not be available to puppet | 18:00 |
mwhahaha | mriedem: this is a new requirement for end users as part of the configuration | 18:01 |
shardy | Even if we do have to pass it, it'd be kinda nice if the value set in nova.conf worked on the CLI | 18:01 |
dansmith | shardy: it does, right? | 18:02 |
shardy | dansmith: No, it doesn't AFAICS | 18:02 |
*** haplo37 has quit IRC | 18:02 | |
dansmith | shardy: meaning, it's the same value, you just have to pass it to us | 18:02 |
shardy | https://bugs.launchpad.net/tripleo/+bug/1649341 | 18:02 |
shardy | dansmith: see the backtrace in comment #2 - any idea what I'm doing wrong? | 18:02 |
*** derekh is now known as derekh_afk | 18:02 | |
shardy | I'm trying to find the transport_url from a grenade job to compare atm | 18:03 |
dansmith | shardy: that's probably due to the old o.msg pacakge, are you running the latest? | 18:03 |
*** jaosorior has quit IRC | 18:03 | |
dansmith | I just fixed a bug in oslo.msg | 18:03 |
mriedem | shardy: http://logs.openstack.org/27/392227/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/a4db7a1/logs/grenade.sh.txt.gz#_2016-12-06_01_14_37_580 | 18:03 |
*** ralonsoh has quit IRC | 18:04 | |
shardy | dansmith: aha, possibly not the very latest - we lag slightly with tripleo as periodic jobs need to pass before we get the very latest packages | 18:04 |
* shardy pulls latest oslo.msg | 18:04 | |
openstack | Launchpad bug 1649341 in OpenStack Compute (nova) "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 18:04 |
*** tbachman has quit IRC | 18:04 | |
*** roeyc has joined #openstack-nova | 18:04 | |
*** tbachman has joined #openstack-nova | 18:05 | |
*** haplo37 has joined #openstack-nova | 18:05 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restict usage *args for novaclient.client.Client https://review.openstack.org/406294 | 18:06 |
shardy | dansmith: Ah, yeah that helped, now I get a different error ;) | 18:06 |
shardy | Access denied for user nova_api - it can't access the nova_api_cell0 db | 18:07 |
dansmith | shardy: cool, that'd be your deal then :) | 18:07 |
dansmith | db setup and all | 18:07 |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.40 - Simple tenant usage pagination https://review.openstack.org/407825 | 18:07 |
shardy | dansmith: Yeah, I guess we'll have to handle that in the puppet layer | 18:07 |
shardy | pretty rough upgrade experience, but I guess we'll deal with it | 18:07 |
mwhahaha | dansmith: is the cell_v2 setup documented somewhere? | 18:07 |
shardy | thanks for the assistance! | 18:07 |
mwhahaha | as now i've got to go handle it magically | 18:08 |
*** siva_krish has quit IRC | 18:08 | |
dansmith | shardy: well, the release notes have indicated that this should have been done before it was required, | 18:09 |
dansmith | so we're kinda depending on the user reading those if they don't want to be surprised | 18:09 |
*** matrohon has quit IRC | 18:09 | |
mwhahaha | that's a tall order | 18:09 |
dansmith | it worked without those things done for a grace period but at some point we have to cut over | 18:09 |
mriedem | https://review.openstack.org/#/c/267153/ was a docs patch but needs to be picked up and cleaned up | 18:10 |
shardy | dansmith: well part of the problem was the release notes were wrong | 18:10 |
dansmith | mwhahaha: what would you like us to do? never make any changes? | 18:10 |
*** unicell has quit IRC | 18:10 | |
dansmith | shardy: which one? | 18:10 |
mwhahaha | dansmith: communication around large changes via ML at a minimum | 18:10 |
*** mlavalle has quit IRC | 18:10 | |
mwhahaha | dansmith: also you have users within the community you can trial these changes out with | 18:10 |
shardy | https://review.openstack.org/#/c/409876/ | 18:10 |
mriedem | shardy: as seen here http://git.openstack.org/cgit/openstack-dev/grenade/tree/projects/60_nova/from-newton/upgrade-nova#n8 | 18:10 |
* mwhahaha points to #puppet-openstack | 18:10 | |
mriedem | shardy: you'll need to create nova_api_cell0 | 18:10 |
mriedem | the nova_api_cell0 db that is | 18:10 |
shardy | dansmith: mriedem has fixed it, but that was the start of the confusion ;) | 18:10 |
mriedem | dansmith: https://review.openstack.org/#/c/409876/ | 18:11 |
*** mlavalle has joined #openstack-nova | 18:11 | |
*** stvnoyes has quit IRC | 18:11 | |
mwhahaha | we always end up playing catchup because we cannot be aware of all changes across all projects all the time | 18:11 |
shardy | mriedem: ack, thanks - I'll hack around it manually and we can handle that in puppet | 18:11 |
dansmith | mwhahaha: the grenade change feed is, like, a perfect source of this information for early warning :) | 18:11 |
dansmith | the release notes, minus human errors, the grenade change stream, etc | 18:12 |
*** haplo37 has quit IRC | 18:12 | |
*** stvnoyes has joined #openstack-nova | 18:12 | |
mriedem | i don't think we really call out creating a new db for cell0 in the reno | 18:12 |
mriedem | we talk about cell0, but not creating a new db | 18:12 |
mriedem | http://docs.openstack.org/releasenotes/nova/unreleased.html | 18:12 |
shardy | yeah might be a nice thing to add | 18:12 |
dansmith | that one was like two releases ago right? | 18:12 |
mwhahaha | i don't know why this isn't just part of the existing db setup | 18:13 |
*** thorst has joined #openstack-nova | 18:13 | |
mwhahaha | which is kinda why i'm confused on this whole thing because we already have ways of setting up dbs, why is this a new one? | 18:13 |
mriedem | dansmith: i think newton | 18:13 |
mriedem | yeah newton | 18:13 |
mriedem | just says "‘nova-manage db sync’ can now sync the cell0 database." | 18:13 |
mriedem | but we don't actually say, oh right, you need to create another new db :) | 18:13 |
openstackgerrit | Ed Leafe proposed openstack/nova: Corrects the type of a base64 encoded string https://review.openstack.org/385686 | 18:14 |
mwhahaha | didn't we run into this with the new api db? | 18:14 |
dansmith | The cell0 db is required to store instances that cannot be scheduled to | 18:14 |
dansmith | any cell. Before the 'db sync' command is called a cell mapping | 18:14 |
dansmith | for cell0 must have been created using 'nova-manage cell_v2 map_cell0'. | 18:14 |
mriedem | so, we know we need to doc the cellsv2 stuff better, which means cleaning up https://review.openstack.org/#/c/267153/ | 18:14 |
mwhahaha | dansmith: that doesn't tell me 1) how to create this db or 2) how this fits into a deployment of nova | 18:14 |
*** haplo37 has joined #openstack-nova | 18:14 | |
dansmith | the first line tells you how it fits into nova | 18:15 |
mwhahaha | not how it fits into nova | 18:15 |
mwhahaha | how it fits into the deployment of nova | 18:15 |
dansmith | and certainly the grenade stuff tells you what to do from the puppet side | 18:16 |
mwhahaha | what about people who want to do this themselves? | 18:16 |
mwhahaha | look i'm just point out a poor user experiance | 18:16 |
*** nherciu_ has quit IRC | 18:17 | |
dansmith | mriedem: agreed, we should fix and land that doc change before it's a year old | 18:17 |
shardy | http://paste.openstack.org/show/592134/ | 18:17 |
shardy | So creating the DB then makes simple_cell_setup say "nothing to do" | 18:17 |
shardy | but the api_db sync still fails | 18:17 |
* shardy looks at grenade scripts | 18:18 | |
*** ihrachys has quit IRC | 18:18 | |
mriedem | so simple_cell_setup calls map_cell0 https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1230 | 18:18 |
mriedem | w/o a database connection url passed in | 18:18 |
mriedem | which then makes it look up the api db connection from nova.conf https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1262 | 18:18 |
*** romainh1 has quit IRC | 18:19 | |
dansmith | that last command might be complaining about cell mappings for the hosts, nothing to do with cell0 | 18:19 |
*** haplo37 has quit IRC | 18:19 | |
*** harlowja has joined #openstack-nova | 18:20 | |
*** READ10 has joined #openstack-nova | 18:20 | |
*** sacharya_ has joined #openstack-nova | 18:21 | |
*** haplo37 has joined #openstack-nova | 18:22 | |
*** derekh_afk is now known as derekh | 18:22 | |
mriedem | i know what this is | 18:23 |
*** yamahata has quit IRC | 18:23 | |
mriedem | error: (pymysql.err.IntegrityError) (1062, u"Duplicate entry '00000000-0000-0000-0000-000000000000' | 18:23 |
mriedem | we handle that duplicate entry from simple_cell_setup https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1231 | 18:23 |
*** moshele has quit IRC | 18:23 | |
*** sacharya has quit IRC | 18:23 | |
dansmith | ah, you know | 18:23 |
mriedem | but not from map_cell0 if you called that directly | 18:23 |
dansmith | I wonder if this is because he pre-mapped cell0 | 18:23 |
mriedem | https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1283 | 18:23 |
dansmith | and we don't go on to do the migrations to do the host mapping | 18:24 |
dansmith | if you already have a cell0 map you will never do this: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L492-L1233 | 18:24 |
mwhahaha | so is the operator supposed to manually create a cell0 for themselves? | 18:24 |
dansmith | er | 18:24 |
mriedem | https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1237 ? | 18:25 |
dansmith | we'll bail here: https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1232-L1233 | 18:25 |
shardy | I tried running simple_cell_setup immediately after the DB sync, I omitted that from the paste | 18:25 |
dansmith | instead of moving on | 18:25 |
*** gszasz has quit IRC | 18:25 | |
dansmith | shardy: can you pastebin me your cell_mappings table? | 18:25 |
shardy | it said "Nothing to do", but the api_db sync failed, so I tried again adding the map_cell0 | 18:25 |
mriedem | shardy: map_cell0 will fail if you've already run it once | 18:25 |
openstackgerrit | Julian proposed openstack/nova: Transform keypair.create notification https://review.openstack.org/408689 | 18:25 |
mwhahaha | mriedem: so how can you check if it's already run? | 18:26 |
mwhahaha | mriedem: we need to know that for puppet so we don't run it twice | 18:26 |
dansmith | mwhahaha: it's all supposed to be idempotent.. the normal stuff | 18:26 |
dansmith | mwhahaha: normal users shouldn't have to run the map_cell0 bit themselves | 18:26 |
dansmith | i.e. puppet people | 18:26 |
mwhahaha | dansmith: ok so going back to my other question, are operators supposed to manually create these cell dbs or is there some integration into sync? | 18:27 |
mriedem | nova_api_cell0 has to be manually created, the db | 18:27 |
mwhahaha | dansmith: because i don't think there's any project where we have to manually create a db | 18:27 |
shardy | I don't have a cell_mappings table in the nova DB | 18:27 |
mriedem | just like the nova and nova_api dbs | 18:27 |
* mwhahaha goes double checking | 18:28 | |
mriedem | shardy: it'd probably be in your nova_api db | 18:28 |
dansmith | mwhahaha: nova won't create the database for you of course | 18:28 |
dansmith | mriedem: shardy right, in the api db | 18:28 |
shardy | ah, yeah, oops ;) | 18:28 |
mwhahaha | ah ok so we do when we setup the user | 18:28 |
* mwhahaha takes notes | 18:28 | |
shardy | http://paste.openstack.org/show/592137/ | 18:29 |
shardy | there it is | 18:29 |
*** nandal has joined #openstack-nova | 18:29 | |
*** matrohon has joined #openstack-nova | 18:30 | |
dansmith | yeah | 18:30 |
dansmith | so that's it | 18:30 |
dansmith | that code is naive in case you got a cell0 mapping but nothing else | 18:30 |
dansmith | shardy: can you nuke that row and try again? | 18:30 |
shardy | dansmith: sure, sec | 18:30 |
*** eharney has quit IRC | 18:30 | |
mriedem | so we could map map_cell0 idempotent but that changes the behavior of simple_cell_setup | 18:31 |
mriedem | s/map/make/ | 18:31 |
dansmith | right, it should be anyway, | 18:31 |
dansmith | but simple_cell_setup is too naive about thinking that cell0 means things are done | 18:31 |
*** nandal_in has quit IRC | 18:32 | |
dansmith | mriedem: I shall fix that | 18:32 |
mriedem | dansmith: ok, do it under bug 1649341 probably | 18:32 |
openstack | bug 1649341 in OpenStack Compute (nova) "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Undecided,In progress] https://launchpad.net/bugs/1649341 - Assigned to Matt Riedemann (mriedem) | 18:32 |
*** ayoung_afk is now known as ayoung | 18:32 | |
*** fragatina has quit IRC | 18:33 | |
dansmith | yeah | 18:33 |
sneti | johnthetubaguy, can you check this bug: https://bugs.launchpad.net/bugs/1640164. I think changing the doc would be enough for this. since db error is expected when sync is happening. | 18:33 |
openstack | Launchpad bug 1640164 in OpenStack Compute (nova) "Rolling upgrade M to N: DBDeadlock Error when create instance during sync database" [Undecided,In progress] - Assigned to Sujitha (sujitha-neti) | 18:33 |
cfriesen | can somone double-check me? it looks like in LibvirtDriver.detach_volume() we check whether the instance is running, then pass the "live" flag down into guest.detach_device_with_retry(). If the guest is stopped after that, we'll retry X times with the same "live" flag value which will be invalid. | 18:34 |
cfriesen | I'm wondering if maybe it'd be worth re-checking the guest state in between each retry | 18:35 |
mriedem | shardy: mwhahaha: tried to take some notes in https://bugs.launchpad.net/tripleo/+bug/1649341/comments/12 | 18:37 |
openstack | Launchpad bug 1649341 in OpenStack Compute (nova) "Undercloud upgrade fails with "Cell mappings are not created, but required for Ocata"" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 18:37 |
shardy | dansmith: possibly related to the problem you mentioned, the failure isn't persistent if the DB permissions are messed up: | 18:37 |
shardy | http://paste.openstack.org/show/592138/ | 18:37 |
*** unicell has joined #openstack-nova | 18:37 | |
shardy | the first time it fails with access denied, then without fixing the perms it says nothing to do | 18:38 |
dansmith | shardy: so it clearly has perms to do somethin | 18:38 |
dansmith | g | 18:38 |
dansmith | shardy: oh, does your user have alter permissions? | 18:38 |
dansmith | because after creating that mapping, it tries to sync that database | 18:38 |
dansmith | mapping would work with insert, but then would fail on the sync | 18:39 |
dansmith | I'll catch that and report too | 18:39 |
*** ljxiash has joined #openstack-nova | 18:41 | |
*** eharney has joined #openstack-nova | 18:41 | |
cfriesen | has it been decided yet whether nova will have Friday sessions at the PTG? | 18:44 |
*** ljxiash has quit IRC | 18:45 | |
shardy | dansmith: I just forgot to grant the nova_api user access to the new nova_api_cell0 DB, will add notes to the bug | 18:45 |
*** dharinic is now known as dharinic|lunch | 18:45 | |
dansmith | shardy: okay, so you're good now? | 18:46 |
shardy | dansmith: yup, thanks for the help - I'll note the workaround steps in the bug | 18:46 |
cdent | mriedem, sdague: the devstack gate change for placement just finished: https://review.openstack.org/#/c/409871/ | 18:46 |
dansmith | shardy: okay cool, I'll have this fix up in a bit | 18:46 |
sdague | it still looks like https://github.com/openstack/nova/blob/909410cdfbbaa796a9ec719ce9e6a7be5f54c2a2/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/030_require_cell_setup.py#L47 has the wrong error message as well | 18:47 |
sdague | dansmith: you going to update the nova-manage command in that error message with other fixes? | 18:47 |
dansmith | sdague: yeah, I'll fix the migration in this stack too | 18:47 |
sdague | dansmith: cool | 18:47 |
mriedem | cfriesen: yes | 18:48 |
mriedem | and yes | 18:48 |
mriedem | sdague: dansmith: i already have those fixed | 18:49 |
mriedem | just needs a +W | 18:49 |
sdague | mriedem: url? | 18:49 |
dansmith | mriedem: in the migration? thought it was just the reno | 18:49 |
mriedem | https://review.openstack.org/#/c/409876/ | 18:49 |
cdent | sdague, mriedem the placement related warnings (like this http://logs.openstack.org/71/409871/1/check/gate-tempest-dsvm-multinode-full-ubuntu-xenial-nv/ad9a6ed/logs/apache/placement-api.txt.gz#_2016-12-12_18_22_14_663 ) are fixed by this: https://review.openstack.org/#/c/407180/ | 18:49 |
mriedem | both | 18:49 |
sdague | cdent: http://logs.openstack.org/71/409871/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/6ac02ac/logs/apache/placement-api.txt.gz#_2016-12-12_18_03_29_718 | 18:49 |
sdague | cdent: the stack traces? | 18:49 |
cdent | sdague: jinx | 18:49 |
*** shardy is now known as shardy_afk | 18:50 | |
cdent | ya | 18:50 |
sdague | cdent: ok, though jaypipes wants changes on that, so I'll let him figure it out with you | 18:51 |
sdague | cdent: it seems odd that this would be a stacktrace regardless though | 18:51 |
*** READ10 has quit IRC | 18:52 | |
*** akshilv has quit IRC | 18:52 | |
cdent | yes, because there's an uncaught (because nobody thought of it) exception, so there needs to be a fix in the handler too | 18:53 |
cdent | i'll add to the review | 18:53 |
cdent | s/add/a comment/ | 18:53 |
*** ihrachys has joined #openstack-nova | 18:53 | |
*** tbachman has quit IRC | 18:54 | |
*** roeyc has quit IRC | 18:55 | |
melwitt | mriedem: the nova-manage commands will look for [DEFAULT]/transport_url in the nova.conf first, and if that's not set it has to be passed on the command line | 18:55 |
*** derekh is now known as derekh_afk | 18:56 | |
mriedem | melwitt: that's not what happens with simple_cell_setup | 18:56 |
mriedem | https://github.com/openstack/nova/blob/d9d9071af250409c0102e7a25e35d7521812172d/nova/cmd/manage.py#L1213 | 18:56 |
mriedem | it's a required arg, and if you don't pass it in argparse will puke | 18:56 |
sdague | cdent: I guess, this is the thing that's weird to me - https://github.com/openstack/nova/blob/45747030499b346c1b2318a87266d7e6c36a6b49/nova/objects/resource_provider.py#L1025-L1040 | 18:57 |
mriedem | melwitt: you might be thinking of your secret patches you're holding out of tree | 18:57 |
*** ihrachys has quit IRC | 18:57 | |
sdague | we should WARN or throw the exception, doing both seems like handling this in too many places | 18:57 |
sdague | so, throwing the exception, and doing the warn on the catch above, would be appropriate | 18:57 |
*** READ10 has joined #openstack-nova | 18:57 | |
cdent | sdague: I suspect that the warn was put in place while there was still some thinking that these methods might be called from somewhere else other than the http api | 18:58 |
cdent | thus, you want to log when something goes wrong, but still allow the caller to deal as they like | 18:58 |
cdent | now that we've moved away from that we could change it | 18:58 |
cdent | I still kind of think that the warn is right here | 18:58 |
melwitt | mriedem: urgh, okay, that shouldn't be required then. anything that needs transport_url should be looking at the conf first. I was seeing that the map_cell_and_hosts command looks in the conf | 18:58 |
*** moshele has joined #openstack-nova | 18:59 | |
cdent | the main problem is that the exception is not being caught at the api layer like it should be | 18:59 |
sdague | cdent: right, but that's where we'd typically do the warn | 18:59 |
cdent | even in the event of multiple different types of callers? | 19:00 |
sdague | where we've caught the exception, understood what it is, and translated that information into something for the user to understand | 19:00 |
cdent | (which is on longer true) | 19:00 |
cdent | s/on/no/ | 19:00 |
melwitt | cfriesen: what problem are you seeing with the guest.detach_device_with_retry()? | 19:00 |
sdague | the interface is that exception is thrown, and they get to decide whether it's something that's understood in their flow (so they catch, translate it into a context appropriate log message) | 19:00 |
*** lpetrut has quit IRC | 19:00 | |
sdague | or that they don't know what to do, and it bubbles all the way up | 19:00 |
*** fragatina has joined #openstack-nova | 19:03 | |
*** matrohon has quit IRC | 19:03 | |
cdent | sdague: okay, can we enumerate the issues we need to deal with, and perhaps make bugs (I'll make them if we can enumerate them). Otherwise I will forget. | 19:04 |
*** moshele has quit IRC | 19:04 | |
* cdent just burnt the rice | 19:08 | |
openstackgerrit | Dan Smith proposed openstack/nova: Make simple_cell_setup fully idempotent https://review.openstack.org/409890 | 19:10 |
cfriesen | melwitt: while trying to rebuild a server, we saw LibvirtDriver.detach_device() fail with "libvirtError: operation failed: domain is no longer running " | 19:10 |
dansmith | mriedem: ^ | 19:10 |
cdent | edleafe: you want me to get the fixes to https://review.openstack.org/#/c/407180/ or you good for that tonight | 19:11 |
cdent | sdague: I think I've managed to write everything down on that ^ review | 19:11 |
cdent | except for moving the log, which I'll make a bug for | 19:11 |
edleafe | cdent: got it in the queue to work on | 19:11 |
edleafe | cdent: thanks for the offer | 19:11 |
cdent | edleafe: I added some more stuff, thus the offer | 19:11 |
edleafe | cdent: it's all good | 19:12 |
cdent | roger | 19:12 |
cfriesen | melwitt: we also see nova livecycle events right around the same time indicating a VM shutdown | 19:12 |
mgagne | in Mitaka release, "Nova now requires a second database (called ‘API DB’).". does this upgrade step apply for someone using cells v1? | 19:12 |
cfriesen | melwitt: so my theory is a race between the guest shutdown/crash and nova trying to do the device_detach with "live" flag. | 19:12 |
*** tbachman has joined #openstack-nova | 19:13 | |
*** mlavalle has quit IRC | 19:13 | |
*** asettle has quit IRC | 19:14 | |
melwitt | cfriesen: hm, yeah. sounds like it | 19:15 |
cdent | sdague: we've currently got for different LOG.warning's in objects/resource_provider.py, all of them related to capacity being exceeded in some fashion. It it your opinion that all of them should move? | 19:17 |
cdent | 4, sigh | 19:18 |
cdent | or just those (2) where the logging happens and then an exception is raised? | 19:20 |
*** yamahata has joined #openstack-nova | 19:20 | |
cdent | https://bugs.launchpad.net/nova/+bug/1649384 | 19:22 |
openstack | Launchpad bug 1649384 in OpenStack Compute (nova) "in placement service capacity exceeded LOG.warning call is in wrong place" [Undecided,New] | 19:22 |
mriedem | mgagne: yes the RequestSpec object is persisted in the nova_api db | 19:23 |
*** fragatina has quit IRC | 19:23 | |
mriedem | which is done regardless of cells v1 | 19:23 |
*** fragatina has joined #openstack-nova | 19:24 | |
mgagne | mriedem: ok so do I need to configure this api database connection in all cells (api/compute) ? | 19:24 |
*** whenry has joined #openstack-nova | 19:24 | |
*** tbachman_ has joined #openstack-nova | 19:24 | |
mriedem | compute == child cell? | 19:25 |
*** tbachman has quit IRC | 19:25 | |
*** tbachman_ is now known as tbachman | 19:25 | |
mgagne | yes | 19:25 |
mriedem | i believe only the child cell | 19:25 |
mriedem | where the 'normal' n-api runs | 19:25 |
mriedem | not the top level api | 19:25 |
dansmith | um | 19:25 |
dansmith | that's a good question actually | 19:25 |
melwitt | don't you mean parent cell? | 19:25 |
mgagne | I'm confused now | 19:25 |
dansmith | you might kinda need both actually | 19:25 |
mgagne | parent/child is relative. I thought there was an api cell and compute cell. | 19:25 |
dansmith | right | 19:26 |
mgagne | and how is this database different from the existing API database? it's a new one? | 19:26 |
*** Sukhdev has joined #openstack-nova | 19:26 | |
dansmith | mgagne: this is for cellsv2 | 19:26 |
mriedem | mgagne: different schema | 19:26 |
dansmith | mgagne: eventually your existing api db will go away | 19:26 |
mgagne | dansmith: yes, hence my question "does this upgrade step apply for someone using cells v1?" | 19:26 |
dansmith | mgagne: it does | 19:26 |
mriedem | this is what uses it https://review.openstack.org/#/c/258628/ | 19:26 |
mgagne | ok, so I run cells v1. To upgrade to mitaka, I run the migration to create the database, add the config to API cell and that should be it? | 19:27 |
*** _ducttape_ has joined #openstack-nova | 19:27 | |
dansmith | mgagne: I think your parent and child cells will likely both have to point to the same new api database | 19:28 |
dansmith | I'd have to go look at the seams | 19:28 |
mgagne | ok. I would greatly appreciate a confirmation. the release notes mention cells v2 but nothing if you have cells v1, even if it's just "yes, it does apply to cells v1 user too" | 19:29 |
dansmith | mgagne: do you have a preprod environment you could help test with? | 19:29 |
dansmith | most of us don't have running cellsv1 environments | 19:30 |
*** ducttape_ has quit IRC | 19:31 | |
mgagne | I can and will create one to test the migration. | 19:31 |
melwitt | I would expect the API DB would only be needed for cells that run n-api, but maybe I'm missing something | 19:32 |
*** asettle has joined #openstack-nova | 19:32 | |
dansmith | melwitt: well, cellsv1 expects to be able to list instances without talking to the cells, right? | 19:32 |
dansmith | melwitt: you can't really do that without the stuff in api_db | 19:32 |
*** mlavalle has joined #openstack-nova | 19:33 | |
dansmith | melwitt: (right?) | 19:33 |
melwitt | dansmith: yeah, the top cell runs n-api and I was thinking it would need the API DB | 19:33 |
*** cardeois has quit IRC | 19:33 | |
dansmith | melwitt: but the child cells also run the compute/api code | 19:34 |
*** whenry has quit IRC | 19:34 | |
mgagne | we do not run the nova-api service in the compute node, well we do but it connects to compute database and we don't create instances using this endpoint, only for monitoring purposes. | 19:35 |
mgagne | compute cell* | 19:36 |
dansmith | mgagne: right, but the compute/api code runs there anyway, inside the cells service | 19:37 |
melwitt | dansmith: well, I guess only nova-conductors would need the connection info right? | 19:38 |
mgagne | oh right so new api database will be required for both type of cells anyway | 19:38 |
*** cardeois has joined #openstack-nova | 19:38 | |
dansmith | melwitt: and nova-cells right? | 19:38 |
melwitt | dansmith: there's the compute/cells_api.py stuff that runs per compute cell. if any of that accesses the API DB (which I don't know off the top of my head does) then nova-conductor would need the connection info | 19:39 |
*** _ducttape_ has quit IRC | 19:39 | |
dansmith | melwitt: that doesn't run in conductor, right? | 19:39 |
dansmith | melwitt: isn't compute/cells_api the bit that runs in the parent cell and delegates some things down to the cells? | 19:40 |
*** ducttape_ has joined #openstack-nova | 19:40 | |
melwitt | dansmith: hm, maybe not. is that what is in nova-cells? I actually am not sure | 19:40 |
*** dharinic|lunch is now known as dharinic | 19:40 | |
dansmith | melwitt: the compute/api bits happen in pieces at the top level, then we make a cells/rpc call down to nova-cells in the child cell, which re-runs the mostly-unchanged compute/api code down there right? | 19:41 |
melwitt | dansmith: yeah, looks like you're right. guess I don't remember this as well as I thought | 19:41 |
dansmith | so I would expect both places to potentially need to access the api db, | 19:42 |
dansmith | and the problem will be if they're not clean enough to avoid doing the same thing twice ... | 19:42 |
melwitt | dansmith: that's what I'm not sure about. I hadn't thought the compute/api code runs again | 19:42 |
dansmith | well, that must be okay because the test job would have a unified db | 19:42 |
*** READ10 has quit IRC | 19:42 | |
dansmith | melwitt: that's the whole point of cellsv1, right? it replicates compute/api in both places? | 19:42 |
*** thorst_ has joined #openstack-nova | 19:45 | |
melwitt | dansmith: yeah. I guess I was thinking then at the top it wouldn't do much. I'm looking at it now | 19:45 |
*** ihrachys has joined #openstack-nova | 19:46 | |
*** ihrachys has quit IRC | 19:46 | |
*** jamielennox is now known as jamielennox|away | 19:46 | |
dansmith | melwitt: well, the top is a lot more read-heavy than the bottom, | 19:46 |
*** gouthamr has joined #openstack-nova | 19:46 | |
dansmith | mgagne: so, circling back, | 19:47 |
mgagne | ok, I will do some tests once I package Mitaka. Would make sense to only give access to database to the API cell, compute cell shouldn't need *more* information than it has/needs no? | 19:47 |
dansmith | mgagne: I kinda expect you will need to configure both sides, but it would be super helpful if you could test for us | 19:48 |
dansmith | mgagne: I don't think it is going to be that easy, but that's a reasonable place to start yeah | 19:48 |
mgagne | ok, so: Yes, you need API database with cells v1. Which cell types need it is not known, need testing. | 19:48 |
mriedem | yeah | 19:48 |
dansmith | yeah | 19:48 |
mgagne | alright, thanks! | 19:48 |
*** thorst has quit IRC | 19:48 | |
mriedem | in mitaka we create the request spec and build requests in the api db | 19:48 |
mriedem | from the n-api code | 19:49 |
mriedem | i don't think we actually use that when listing instances in mitaka... | 19:49 |
mriedem | but would have to confirm | 19:49 |
mriedem | i know we do in newton | 19:49 |
mriedem | i get fuzzy on how much of this actually did anything in mitaka | 19:49 |
mriedem | since a lot of the meat happened in newton | 19:49 |
openstackgerrit | Sujitha proposed openstack/nova: Change host for osapi and metadata services in db. https://review.openstack.org/384724 | 19:49 |
openstackgerrit | Christopher Martin proposed openstack/nova: Bugfix: Changes to Instance Soft Delete https://review.openstack.org/386756 | 19:49 |
dansmith | mriedem: right, it may not be the same answer for mitaka and newton | 19:50 |
*** edmondsw has joined #openstack-nova | 19:50 | |
*** amoralej is now known as amoralej|off | 19:51 | |
*** edmondsw has quit IRC | 19:52 | |
*** thorst has joined #openstack-nova | 19:53 | |
*** jamielennox|away is now known as jamielennox | 19:53 | |
*** kfarr has joined #openstack-nova | 19:55 | |
*** thorst_ has quit IRC | 19:56 | |
*** thorst_ has joined #openstack-nova | 19:59 | |
*** bvanhav has quit IRC | 20:00 | |
*** woodster_ has joined #openstack-nova | 20:01 | |
*** kaisers_ has joined #openstack-nova | 20:02 | |
*** dimtruck is now known as zz_dimtruck | 20:03 | |
*** thorst has quit IRC | 20:03 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove support for the Cinder v1 API https://review.openstack.org/409904 | 20:03 |
mriedem | smcginnis: fyi ^ | 20:03 |
smcginnis | mriedem: Sweet | 20:03 |
*** stvnoyes has quit IRC | 20:06 | |
*** cdent has quit IRC | 20:06 | |
*** mtanin___ has joined #openstack-nova | 20:07 | |
*** kaisers_ has quit IRC | 20:07 | |
*** mtanino has quit IRC | 20:09 | |
*** mlavalle has quit IRC | 20:10 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Remove support for the Cinder v1 API https://review.openstack.org/409904 | 20:11 |
*** ijw has joined #openstack-nova | 20:11 | |
*** moshele has joined #openstack-nova | 20:12 | |
openstackgerrit | Diana Clarke proposed openstack/python-novaclient: Microversion 2.40 - Simple tenant usage pagination https://review.openstack.org/407825 | 20:13 |
*** thorst has joined #openstack-nova | 20:15 | |
*** ijw has quit IRC | 20:15 | |
*** thorst__ has joined #openstack-nova | 20:16 | |
*** thorst_ has quit IRC | 20:18 | |
*** bvanhav has joined #openstack-nova | 20:19 | |
*** ijw has joined #openstack-nova | 20:19 | |
*** thorst has quit IRC | 20:19 | |
*** thorst__ has quit IRC | 20:22 | |
*** mlavalle has joined #openstack-nova | 20:22 | |
*** stvnoyes has joined #openstack-nova | 20:24 | |
*** thorst has joined #openstack-nova | 20:25 | |
*** kaisers_ has joined #openstack-nova | 20:25 | |
*** derekh_afk is now known as derekh | 20:26 | |
*** TravT has quit IRC | 20:29 | |
*** kaisers_ has quit IRC | 20:29 | |
*** ijw_ has joined #openstack-nova | 20:29 | |
*** moshele has quit IRC | 20:30 | |
*** moshele has joined #openstack-nova | 20:30 | |
*** lpetrut has joined #openstack-nova | 20:30 | |
*** Sukhdev has quit IRC | 20:30 | |
*** moshele has quit IRC | 20:31 | |
*** ijw has quit IRC | 20:32 | |
*** zz_dimtruck is now known as dimtruck | 20:32 | |
*** bvanhav has quit IRC | 20:34 | |
*** lbeliveau has quit IRC | 20:34 | |
*** kaisers_ has joined #openstack-nova | 20:37 | |
*** thorst has quit IRC | 20:38 | |
*** tblakes_ has joined #openstack-nova | 20:39 | |
*** mtanino has joined #openstack-nova | 20:40 | |
*** mtanin___ has quit IRC | 20:42 | |
edleafe | jaypipes: regarding your comment on https://review.openstack.org/#/c/407180, there isn't any such field in o.vo, just NonNegativeInteger | 20:42 |
edleafe | jaypipes: I suppose we could add it to o.vo, or just enforce it in Allocations | 20:42 |
*** lbeliveau has joined #openstack-nova | 20:43 | |
*** tblakes has quit IRC | 20:43 | |
*** tblakes_ is now known as tblakes | 20:43 | |
*** gouthamr has quit IRC | 20:48 | |
*** ijw has joined #openstack-nova | 20:48 | |
*** ijw_ has quit IRC | 20:49 | |
*** shardy_afk has quit IRC | 20:49 | |
*** ihrachys has joined #openstack-nova | 20:50 | |
*** hoangcx has joined #openstack-nova | 20:50 | |
openstackgerrit | Doug Hellmann proposed openstack/nova: tell reno not to scan the entire master branch https://review.openstack.org/409916 | 20:53 |
*** oanson has joined #openstack-nova | 20:56 | |
*** mtanin___ has joined #openstack-nova | 20:58 | |
*** mtanino has quit IRC | 20:59 | |
*** haplo37 has quit IRC | 21:00 | |
*** jwcroppe has quit IRC | 21:01 | |
*** haplo37 has joined #openstack-nova | 21:02 | |
*** matrohon has joined #openstack-nova | 21:03 | |
*** asettle has quit IRC | 21:06 | |
mriedem | anyone else seeing this functional notification test failing? http://logs.openstack.org/90/409890/1/check/gate-nova-tox-db-functional-ubuntu-xenial/17015ce/testr_results.html.gz | 21:06 |
sdague | mriedem: yes | 21:07 |
sdague | I saw a couple of bounces this morning on it | 21:08 |
jaypipes | edleafe: ah, ok. sorry, I thought it was called PositiveIntegerField. | 21:08 |
*** haplo37 has quit IRC | 21:08 | |
melwitt | mriedem: yes | 21:09 |
melwitt | mriedem: looking at it, it looks like the test expects the instance will have ip address assigned and sometimes it doesn't have it yet at time it's checked | 21:10 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Deprecate compute options https://review.openstack.org/385165 | 21:10 |
*** haplo37 has joined #openstack-nova | 21:11 | |
melwitt | the function that boots a server waits until it's active, so I'm not sure how this is happening | 21:12 |
*** sacharya_ has quit IRC | 21:12 | |
mriedem | melwitt: but it's the fake virt driver, does that actually wait for network allocation to be done? | 21:12 |
mriedem | as it's all fake/stubbed | 21:12 |
*** sacharya has joined #openstack-nova | 21:12 | |
melwitt | mriedem: I'm not sure exactly what's going on, I haven't been looking for too long. but it's verifying that the expected instance updates happened and there's one about the ip address and that one is missing in the example I'm looking at | 21:14 |
mriedem | melwitt: yup same, ip_addresses isn't in there | 21:15 |
*** rtheis has quit IRC | 21:15 | |
mriedem | ok i'll open a bug and try to get an e-r query started | 21:16 |
*** haplo37 has quit IRC | 21:16 | |
openstackgerrit | Julian proposed openstack/nova: Transform instance.add_fixed_ip notification https://review.openstack.org/332876 | 21:17 |
sdague | I'm pretty sure the fakevirt instances start at active | 21:17 |
*** haplo37 has joined #openstack-nova | 21:18 | |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Move quota options to a config group. https://review.openstack.org/346869 | 21:19 |
*** derekh is now known as derekh_afk | 21:21 | |
*** mrhillsman has quit IRC | 21:22 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1649403 | 21:22 |
openstack | Launchpad bug 1649403 in OpenStack Compute (nova) "nova.tests.functional.notification_sample_tests.test_instance.TestInstanceNotificationSample.test_create_delete_server_with_instance_update randomly fails with ip_addresses not set in notifications" [Medium,Confirmed] | 21:22 |
mriedem | sdague: well, it's a task state transition from networking to block_device_mapping | 21:23 |
mriedem | so the network async wrapper is doing it's thing | 21:23 |
mriedem | so we're probably only lucky if the network_info is in the db when that notification goes out | 21:23 |
*** kaisers_ has quit IRC | 21:24 | |
melwitt | mriedem: at the end of a create, there's a notify_about_instance_action call that pulls network_info from the instance to generate that notification, so I think that means the instance is missing network_info filled in at that point | 21:24 |
sdague | mriedem: yeh | 21:24 |
mriedem | melwitt: yeah which i think would be possible as that's all async | 21:25 |
mriedem | i'd need to dig into the actual calls though | 21:25 |
*** lpetrut has quit IRC | 21:25 | |
mriedem | we should have network_info by the time driver.spawn is called though | 21:26 |
dansmith | sdague: can you think of anything rpc-related that is different in the api_samples tests, compared to the rest of functional? | 21:26 |
mriedem | dansmith: self.useFixture(fixtures.SpawnIsSynchronousFixture()) ? | 21:28 |
*** jdurgin has quit IRC | 21:28 | |
*** codebauss has joined #openstack-nova | 21:28 | |
*** codebauss is now known as mrhillsman | 21:28 | |
mriedem | self.useFixture(cast_as_call.CastAsCall(self.stubs)) | 21:29 |
mriedem | i actually thought ^ was done globally | 21:29 |
dansmith | mriedem: that's done for api_samples but not the rest of functional? | 21:30 |
mriedem | dansmith: looks like it | 21:30 |
dansmith | cast as call is done in integrated base | 21:30 |
mriedem | i'm looking at _IntegratedTestBase | 21:30 |
*** jdurgin has joined #openstack-nova | 21:30 | |
dansmith | where is the synchronous spawn? | 21:30 |
mriedem | and ApiSampleTestBase | 21:30 |
dansmith | oh, right, but that's the base for a lot of otherthings | 21:30 |
mriedem | dansmith: that's in ApiSampleTestBaseV21 | 21:31 |
*** haplo37 has quit IRC | 21:31 | |
sdague | yeh, CastAsCall may be the critical missing bit here | 21:31 |
sdague | also... curiously, the notifications sample base patches out the locker.... o_O | 21:32 |
dansmith | I think there are other things based on the integrated base class that work I think | 21:32 |
sdague | https://github.com/openstack/nova/blob/45747030499b346c1b2318a87266d7e6c36a6b49/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L57-L60 | 21:32 |
dansmith | which would rule out the castascall | 21:32 |
*** mtanino has joined #openstack-nova | 21:33 | |
sdague | patching out locking seems extremely suspect to me | 21:33 |
melwitt | hmm | 21:34 |
dansmith | so, spawnissynchronous might be it.. sdague mriedem, any idea why we need that in api samples and not other things? | 21:34 |
*** mtanin___ has quit IRC | 21:34 | |
*** Jeffrey4l has quit IRC | 21:34 | |
mriedem | probably for the async network stuff | 21:35 |
mriedem | but not really sure | 21:35 |
sdague | yeh, that is my guess | 21:35 |
dansmith | but that would apply to all the other functional stuff right? | 21:35 |
sdague | dansmith: only if they go and check for it | 21:35 |
dansmith | like functional/test_servers | 21:35 |
dansmith | which doesn't have that | 21:35 |
dansmith | sdague: check for network completing you mean? they check for instance state, which won't go active until it's done, so.. | 21:35 |
*** Jeffrey4l has joined #openstack-nova | 21:36 | |
*** thorst has joined #openstack-nova | 21:36 | |
*** eglynn has quit IRC | 21:36 | |
dansmith | yeah, so that seems related | 21:37 |
dansmith | I dunno why, but in the api samples tests with the cells stuff going, all the services never actually run or respond to rpc messages | 21:37 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Move quota options to a config group. https://review.openstack.org/346869 | 21:37 |
dansmith | if I disable that, it completes quickly, but doesn't match the template | 21:38 |
*** haplo37 has joined #openstack-nova | 21:38 | |
sdague | dansmith: disable which thing? | 21:39 |
dansmith | sdague: synchronous spawn | 21:39 |
dansmith | sdague: so, looking at test_servers, it seems like it's expecting everything to be filled out as a result of a server post, which isn't how it works in real life | 21:40 |
dansmith | sdague: i.e. it expects network allocation to be done when we return from post | 21:40 |
dansmith | that's bogus right? | 21:40 |
*** thorst_ has joined #openstack-nova | 21:40 | |
sdague | honestly, I don't have all these bits in my head any more, I'd have to go explore | 21:41 |
melwitt | mriedem: looks like that async wrapper only waits if something is accessed on the NetworkInfo. so it would at least start driver.spawn without it being done yet. it would be until something inside spawn accesses a NetworkInfo attribute, AFAICT | 21:41 |
*** thorst has quit IRC | 21:41 | |
mriedem | melwitt: oh yeah | 21:42 |
mriedem | i added SpawnIsSynchronousFixture to NotificationSampleTestBase and it made the test fail the same way as in that bug | 21:43 |
melwitt | and if the fake driver isn't doing anything ... going to check if we need to add a .wait() in spawn | 21:43 |
melwitt | for the fake driver | 21:43 |
*** thorst_ is now known as thorst | 21:43 | |
sdague | mriedem: have you looked at restoring the locking? | 21:43 |
mriedem | sdague: nope | 21:43 |
sdague | if you add SpawnIsSynchronousFixture, does it fail every time? | 21:44 |
*** akshilv has joined #openstack-nova | 21:44 | |
*** akshilv has left #openstack-nova | 21:45 | |
mriedem | sdague: yeah | 21:45 |
mriedem | the locking was mocked out in https://review.openstack.org/#/c/313654/ fwiw | 21:45 |
openstackgerrit | Jay Pipes proposed openstack/nova: Only return latest instance fault for instances https://review.openstack.org/409943 | 21:46 |
jaypipes | sdague: ^^ | 21:46 |
*** kaisers_ has joined #openstack-nova | 21:46 | |
melwitt | mriedem: I would try adding a network_info.wait() to nova/virt/fake.py in the spawn function for the fake driver to see if that makes things work in what you've repro'd | 21:46 |
mriedem | doesn't really mention why locking is mocked out | 21:46 |
melwitt | mriedem: it says in the docstring it was done to avoid setting REQUIRES_LOCKING = True | 21:47 |
mriedem | yeah, but why? | 21:47 |
melwitt | sorry in the comment above the patching | 21:47 |
*** jgriffith is now known as jgriffith_AutoAw | 21:47 | |
sdague | melwitt: right, that seems weird though. Especially in something that spawn real services is greenthreads | 21:47 |
*** eharney has quit IRC | 21:48 | |
melwitt | I have a feeling it might be because of a comment in the fixture. there's a thing in there that says not to add it to new tests. other than that, I have no idea | 21:48 |
melwitt | the comment about REQUIRES_LOCKING is in test.TestCase | 21:49 |
sdague | melwitt: right, but the right answer was for the tests to set it up themselves | 21:50 |
*** kaisers_ has quit IRC | 21:50 | |
melwitt | agreed it's definitely weird. I can't think of any other reason | 21:50 |
*** oanson has quit IRC | 21:50 | |
melwitt | have to ask gibi, he might know what's behind it | 21:51 |
*** jgriffith_AutoAw is now known as jgriffith | 21:52 | |
mriedem | i don't think the fake virt driver is getting any network_info..., i think it's coming in as None | 21:56 |
*** Sukhdev has joined #openstack-nova | 21:56 | |
openstackgerrit | Sean Dague proposed openstack/nova: restore locking in notification tests https://review.openstack.org/409951 | 21:56 |
dansmith | sdague: so, I figured out why the synchronous spawn fixture in api_samples is a problem for me | 21:57 |
mriedem | could be allocate_for_instance is getting stubbed out elsewhere | 21:57 |
sdague | whether or not the locking is causing (or exacerbating the issue) it seems wrong, and we should probably fix it | 21:57 |
dansmith | sdague: and it's not trivial to fix | 21:57 |
*** amotoki has joined #openstack-nova | 21:57 | |
dansmith | sdague: so when you get a chance, I'd like to maybe hangout about it | 21:57 |
sdague | dansmith: ok, cool. I need to drop now to start dealing with dinner. | 21:58 |
dansmith | okay | 21:58 |
sdague | Tomorrow is dicey, as they are doing the electrical service upgrade, so I have no idea when I'll have power in the house | 21:58 |
sdague | if things wrap up at a reasonable time in the afternoon, I'll poke you, otherwise wed? | 21:58 |
*** liverpooler has quit IRC | 21:58 | |
dansmith | sdague: okay I'm out for the rest of the year after friday | 21:59 |
dansmith | so | 21:59 |
dansmith | not much time to resolve things between then, but okay | 21:59 |
dansmith | maybe mriedem wants to talk to me about it | 21:59 |
dansmith | guess not | 22:01 |
melwitt | heh | 22:01 |
melwitt | mriedem: I'm trying some things, so far getting the same result with the wait() | 22:05 |
*** asettle has joined #openstack-nova | 22:06 | |
openstackgerrit | Christopher Martin proposed openstack/nova: Remove mox from unit/compute/test_compute_api.py(2) https://review.openstack.org/340660 | 22:07 |
*** asettle has quit IRC | 22:08 | |
*** asettle has joined #openstack-nova | 22:09 | |
openstackgerrit | Christopher Martin proposed openstack/nova: Remove mox from unit/compute/test_compute_api.py(2) https://review.openstack.org/340660 | 22:09 |
*** amotoki has quit IRC | 22:10 | |
openstackgerrit | Christopher Martin proposed openstack/nova: Remove mox from unit/compute/test_compute_api.py(2) https://review.openstack.org/340660 | 22:10 |
mriedem | dansmith: i do | 22:11 |
*** ihrachys has quit IRC | 22:11 | |
mriedem | i was getting my kid off the bus | 22:11 |
dansmith | is that code for something? | 22:11 |
dansmith | taking a dump? | 22:11 |
mriedem | dansmith: next to my own child, you're next in line of importance | 22:11 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: Remove few TODO's from cells.py https://review.openstack.org/385140 | 22:11 |
dansmith | woo | 22:12 |
dansmith | mriedem: good for hangout? | 22:12 |
dansmith | mriedem: https://hangouts.google.com/call/d46xoq27jfdebn2gqxrauaxd6ue | 22:12 |
mriedem | yeah, there might be a distraction at some point, she's crapping in the bathroom directly behind me | 22:12 |
dansmith | melwitt: you may want to get in on this action | 22:12 |
openstackgerrit | Christopher Martin proposed openstack/nova: Remove mox from unit/compute/test_compute_api.py(2) https://review.openstack.org/340660 | 22:12 |
dansmith | uh | 22:12 |
mriedem | i was told on friday that she holds it all day | 22:13 |
dansmith | ... | 22:13 |
melwitt | dansmith: k, will join | 22:13 |
melwitt | lol @ mriedem | 22:13 |
*** amotoki has joined #openstack-nova | 22:14 | |
*** amotoki has quit IRC | 22:15 | |
*** annegentle has quit IRC | 22:17 | |
*** baoli has quit IRC | 22:21 | |
*** kylek3h has quit IRC | 22:22 | |
*** jgriffith is now known as jgriffith_AutoAw | 22:23 | |
*** matrohon has quit IRC | 22:24 | |
*** lbeliveau_ has joined #openstack-nova | 22:25 | |
*** lbeliveau has quit IRC | 22:26 | |
*** asettle has quit IRC | 22:26 | |
mriedem | dansmith: melwitt: https://github.com/openstack/nova/commit/6b16c8731c44e4a6c80b803f3e8afdd88386d577 | 22:27 |
mriedem | that added it | 22:27 |
mriedem | sdague: melwitt: btw, i wouldn't be surprised if something i did here is making those notification samples fail the networking stubs https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/use-neutron-by-default | 22:31 |
mriedem | i think the notification samples all expect to use the neutron fixture | 22:31 |
*** thorst has quit IRC | 22:32 | |
*** thorst has joined #openstack-nova | 22:33 | |
*** tblakes has quit IRC | 22:35 | |
*** Swami has quit IRC | 22:36 | |
*** thorst has quit IRC | 22:41 | |
*** ljxiash has joined #openstack-nova | 22:41 | |
mriedem | could be this https://review.openstack.org/#/c/396824/3/nova/tests/unit/api/openstack/fakes.py | 22:43 |
openstackgerrit | Matt Riedemann proposed openstack/nova: restore locking in notification tests https://review.openstack.org/409951 | 22:44 |
*** slaweq_ has quit IRC | 22:45 | |
*** slaweq_ has joined #openstack-nova | 22:45 | |
*** asettle has joined #openstack-nova | 22:46 | |
*** ljxiash has quit IRC | 22:46 | |
*** lbeliveau_ has quit IRC | 22:47 | |
*** asettle has quit IRC | 22:49 | |
*** asettle has joined #openstack-nova | 22:49 | |
*** burgerk_ has joined #openstack-nova | 22:51 | |
mriedem | actually that shouldn't hit the functional tests, hmm | 22:51 |
*** lbeliveau has joined #openstack-nova | 22:53 | |
*** asettle has quit IRC | 22:53 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Do not post allocations that are zero https://review.openstack.org/407180 | 22:53 |
melwitt | mriedem: yeah, I tried letting that set up the plain network api and it didn't change anything | 22:53 |
*** Sukhdev has quit IRC | 22:54 | |
*** burgerk has quit IRC | 22:54 | |
*** esberglu_ has quit IRC | 22:55 | |
*** esberglu has joined #openstack-nova | 22:55 | |
dansmith | melwitt: rebuild runs mostly in the child cell, right? | 22:56 |
*** burgerk_ has quit IRC | 22:56 | |
*** esberglu_ has joined #openstack-nova | 22:56 | |
melwitt | dansmith: looks like it | 22:57 |
*** jgriffith_AutoAw is now known as jgriffith | 22:57 | |
dansmith | melwitt: and it looks at requestspec | 22:57 |
mwhahaha | hey is there a change out there to remove the requirement of --transport-url from the simple_cell_setup? | 22:57 |
melwitt | dansmith: hm, okay. guess I was way off on that then | 22:58 |
dansmith | melwitt: I think all of the things in cells/messaging call compute/api in the child cell | 22:58 |
dansmith | so any of those that look at anything api_db would be affected I think | 22:58 |
mriedem | mwhahaha: no, remember we said earlier today we were waiting for some functionality in oslo | 22:58 |
mriedem | mwhahaha: would need to ask melwitt for details i think | 22:59 |
melwitt | mwhahaha: not yet. do you want to do it? I can do it now if you're wanting to try it. the thing is that for it to work you'll have to make sure your nova.confs are updated to set the transport_url instead of all of the deprecated separate rpc backend options | 22:59 |
*** _ducttape_ has joined #openstack-nova | 22:59 | |
*** esberglu has quit IRC | 23:00 | |
*** rwmjones has quit IRC | 23:00 | |
mwhahaha | melwitt: I need it because where i was putting the setup we don't currently pass the transport-url in | 23:00 |
melwitt | mriedem, mwhahaha: we're no longer waiting on anything from oslo, that comment is old/wrong now. at best we can take transport_url from the conf but most older deployments don't specify the message queue connection setting in that way and would have to be converted by the operator | 23:00 |
mwhahaha | melwitt: we've deprecated the split rpc stuff in favor of transport_url so i'd be ok with a release note on our end about it | 23:01 |
*** jheroux has quit IRC | 23:01 | |
*** esberglu_ has quit IRC | 23:01 | |
mwhahaha | melwitt: but the problem i'm currently facing is the code that's out there right now requires transport-url so i'm going to have to do some code add/remove/crying to do some ci promotions around this | 23:01 |
openstackgerrit | Sarafraj Singh proposed openstack/nova: conf: move console opt to console group https://review.openstack.org/389647 | 23:01 |
mwhahaha | ideally i'd like to not pass transport_url to that call | 23:01 |
*** annegentle has joined #openstack-nova | 23:01 | |
mwhahaha | i mean it should be optional i guess for people who need it, but my preference is that it use whats in the config | 23:02 |
*** ducttape_ has quit IRC | 23:02 | |
melwitt | mwhahaha: right. that's a bug/mistake that it requires it, it should use what's in the config if not provided. I can put a change up for that in a few | 23:02 |
*** rwmjones has joined #openstack-nova | 23:03 | |
mwhahaha | melwitt: thanks | 23:03 |
melwitt | I was just noting that for it to work, [DEFAULT]/transport_url has to be the config setting because it's not going to handle the various deprecated rpc options | 23:03 |
*** _ducttape_ has quit IRC | 23:03 | |
mwhahaha | melwitt: I think that's an easier upgrade issue than having to specify it as part of the setup for us | 23:04 |
melwitt | mwhahaha: yeah, makes sense | 23:04 |
*** burt has quit IRC | 23:07 | |
*** kylek3h has joined #openstack-nova | 23:07 | |
mriedem | wtf | 23:08 |
mriedem | _send_instance_update_notification calls info_from_instance with network_info=None | 23:08 |
mriedem | so i don't see how the instance update notification ever had the network_info in it | 23:08 |
*** mlavalle has quit IRC | 23:09 | |
melwitt | when I tried network_info.wait() in fake driver spawn, it didn't blow up so it must not have been None at that point | 23:09 |
openstackgerrit | Samantha Blanco proposed openstack/nova: Add support matrix for attach and detach interfaces https://review.openstack.org/409967 | 23:09 |
mriedem | yeah it's not None, i verified that | 23:09 |
mriedem | also, NotificationSampleTestBase is running nova-network as a service | 23:09 |
mriedem | self.start_service('network', manager=CONF.network_manager) | 23:09 |
mriedem | but TestInstanceNotificationSample is also running self.neutron = fixtures.NeutronFixture(self) | 23:10 |
*** jwcroppe has joined #openstack-nova | 23:10 | |
*** annegentle has quit IRC | 23:12 | |
mriedem | anyway Instance.save() calls this https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L98 | 23:12 |
mriedem | which calls this https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L129 | 23:12 |
mriedem | which calls this https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L179 | 23:13 |
openstackgerrit | Sujitha proposed openstack/nova: Do not merge: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | 23:13 |
mriedem | which calls this https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L227 | 23:13 |
mriedem | and because network_info arg is None there, this is False https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L487 | 23:14 |
mriedem | so we wouldn't have fixed_ips in the notification | 23:14 |
mriedem | so i'm not sure how the functional test ever passed | 23:14 |
melwitt | :\ | 23:14 |
mriedem | oh i guess for the versioned notification https://github.com/openstack/nova/blob/8f354f777f27850caf857a5ce117f061cb3b1b3f/nova/notifications/base.py#L282 | 23:15 |
*** diogogmt has quit IRC | 23:18 | |
*** tbachman has quit IRC | 23:18 | |
mriedem | hrm, where do we store that in the db... | 23:20 |
mriedem | ah the update_instance_cache_with_nw_info decorator | 23:22 |
openstackgerrit | melanie witt proposed openstack/nova: Let nova-manage cell_v2 commands use transport_url from CONF https://review.openstack.org/409970 | 23:23 |
*** esberglu has joined #openstack-nova | 23:24 | |
melwitt | mwhahaha: ^ | 23:24 |
mwhahaha | melwitt: thanks | 23:25 |
mriedem | so the compute manager calls network_api.allocate_for_instance which eventually calls get_instance_nw_info which update_instance_cache_with_nw_info which creates the InstanceInfoCache in the db | 23:28 |
*** Sukhdev has joined #openstack-nova | 23:28 | |
mriedem | which is what the versioned notification uses, instance.info_cache.network_info | 23:28 |
*** esberglu has quit IRC | 23:28 | |
mriedem | i can't tell why adding the SpawnIsSynchronous fixture would actually make this fail | 23:29 |
*** claudiub|2 has quit IRC | 23:31 | |
*** rwmjones has quit IRC | 23:32 | |
melwitt | me either. I would have thought it had to do with the async wrapper not waiting but it's not that based on what I tried | 23:32 |
melwitt | or, I would have thought SpawnIsSynchronous wouldn't change anything | 23:33 |
dansmith | melwitt: mriedem: FWIW, ~500 of the api samples tests fail for a variety of reasons without spawnissynchronous | 23:33 |
*** rwmjones has joined #openstack-nova | 23:33 | |
dansmith | which tells me that they're really all pretty silly in what they're testing | 23:33 |
melwitt | ugh | 23:33 |
mriedem | 500, wow | 23:33 |
mriedem | well, my guess would be there is a basic thing that a lot of the tests use which makes them all fail | 23:34 |
mriedem | i.e. 90% of the tests post a server to do some other actions on that server, | 23:34 |
mriedem | but part of that setup is verifying the response and expects network details | 23:34 |
mriedem | so just fix that part and the others probably fall in line | 23:34 |
dansmith | yeah a lot fail for the same reason, but a lot fail with weirdness specifically around the state of an instance, the order in which things appear deleted, and even some races with setup of compute I think | 23:34 |
dansmith | not enough commonality to make me think that it's a reasonable one-day fix | 23:35 |
*** nandal_in has joined #openstack-nova | 23:36 | |
*** mkoderer has quit IRC | 23:36 | |
mriedem | melwitt: so i think i was doing the wait wrong | 23:37 |
mriedem | er hold | 23:37 |
mriedem | dear caller | 23:37 |
*** ducttape_ has joined #openstack-nova | 23:37 | |
melwitt | ? | 23:38 |
mriedem | nvm that didn't do anything | 23:38 |
*** nandal has quit IRC | 23:39 | |
*** thorst has joined #openstack-nova | 23:39 | |
*** pradk has quit IRC | 23:40 | |
mriedem | dansmith: this has just been a terrible nova day all around i think and we should probably just all call it a loss | 23:41 |
cburgess | LOL | 23:41 |
*** ducttape_ has quit IRC | 23:42 | |
*** rwmjones has quit IRC | 23:44 | |
*** tbachman has joined #openstack-nova | 23:44 | |
*** derekh_afk has quit IRC | 23:45 | |
*** rwmjones has joined #openstack-nova | 23:45 | |
*** thorst has quit IRC | 23:46 | |
*** asettle has joined #openstack-nova | 23:49 | |
*** Sukhdev has quit IRC | 23:52 | |
*** dave-mccowan has quit IRC | 23:53 | |
*** vladikr has quit IRC | 23:54 | |
*** asettle has quit IRC | 23:54 | |
*** thorst has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!