| *** mlavalle1 has quit IRC | 00:02 | |
| *** thorst has joined #openstack-nova | 00:03 | |
| *** claudiub|2 has quit IRC | 00:04 | |
| *** mriedem has joined #openstack-nova | 00:04 | |
| *** thorst has quit IRC | 00:05 | |
| mriedem | johnthetubaguy: bauzas: for when you guys are up, we have a couple of renos for stable/newton https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton | 00:11 |
|---|---|---|
| *** davidlenwell has quit IRC | 00:11 | |
| *** edmondsw has quit IRC | 00:11 | |
| mriedem | dansmith: alaski: oh fudge yeah http://logs.openstack.org/13/377113/5/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/3f0e2e3/logs/devstack-gate-post_test_hook.txt.gz | 00:12 |
| mriedem | we're going to want a bigger value | 00:12 |
| *** ijw has quit IRC | 00:14 | |
| *** kaisers2 has joined #openstack-nova | 00:15 | |
| *** aloga has quit IRC | 00:15 | |
| *** kaisers3 has joined #openstack-nova | 00:16 | |
| *** kaisers has quit IRC | 00:17 | |
| *** kaisers1 has quit IRC | 00:17 | |
| *** ijw has joined #openstack-nova | 00:19 | |
| *** markvoelker has joined #openstack-nova | 00:20 | |
| *** rrecio_ has quit IRC | 00:20 | |
| *** TravT has joined #openstack-nova | 00:23 | |
| *** aloga has joined #openstack-nova | 00:23 | |
| *** TravT has quit IRC | 00:23 | |
| *** TravT has joined #openstack-nova | 00:23 | |
| *** markvoelker has quit IRC | 00:25 | |
| *** davidlenwell has joined #openstack-nova | 00:25 | |
| *** trisq has joined #openstack-nova | 00:28 | |
| melwitt | mriedem: I was looking at that earlier. you did it! and yes, I noticed that too, it didn't even get to delete any instance rows yet heh | 00:32 |
| *** markvoelker has joined #openstack-nova | 00:34 | |
| mriedem | yeah, max_rows is really dumb | 00:35 |
| *** sgordon has quit IRC | 00:42 | |
| *** doffm has quit IRC | 00:42 | |
| *** beagles has quit IRC | 00:42 | |
| *** doffm has joined #openstack-nova | 00:42 | |
| *** sgordon has joined #openstack-nova | 00:43 | |
| *** b3nt_pin has joined #openstack-nova | 00:43 | |
| *** b3nt_pin is now known as Guest2018 | 00:43 | |
| *** gyee has quit IRC | 00:43 | |
| *** ijw has quit IRC | 00:45 | |
| *** Apoorva_ has joined #openstack-nova | 00:45 | |
| *** salv-orlando has joined #openstack-nova | 00:48 | |
| *** Apoorva has quit IRC | 00:48 | |
| *** hoangcx has joined #openstack-nova | 00:50 | |
| *** Apoorva_ has quit IRC | 00:50 | |
| *** salv-orlando has quit IRC | 00:52 | |
| *** cheneydc has joined #openstack-nova | 00:56 | |
| openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (1) https://review.openstack.org/342546 | 00:58 |
| *** raunak has quit IRC | 01:00 | |
| *** ijw has joined #openstack-nova | 01:05 | |
| *** trisq has quit IRC | 01:05 | |
| *** ducttape_ has quit IRC | 01:08 | |
| *** cheneydc has quit IRC | 01:09 | |
| *** ijw_ has joined #openstack-nova | 01:10 | |
| *** yuntongjin has joined #openstack-nova | 01:10 | |
| openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (2) https://review.openstack.org/342593 | 01:10 |
| *** ijw has quit IRC | 01:11 | |
| *** kaisers__ has quit IRC | 01:12 | |
| *** gongysh has joined #openstack-nova | 01:14 | |
| *** ijw_ has quit IRC | 01:15 | |
| *** alee_afk has quit IRC | 01:22 | |
| *** jvgrant has quit IRC | 01:22 | |
| *** jvgrant has joined #openstack-nova | 01:22 | |
| *** pkoniszewski has quit IRC | 01:25 | |
| *** lamt has joined #openstack-nova | 01:27 | |
| *** trisq has joined #openstack-nova | 01:30 | |
| *** lamt has quit IRC | 01:31 | |
| *** fishcried has joined #openstack-nova | 01:31 | |
| *** pkoniszewski has joined #openstack-nova | 01:31 | |
| *** fishcried has quit IRC | 01:32 | |
| *** thorst has joined #openstack-nova | 01:32 | |
| *** thorst has quit IRC | 01:32 | |
| *** ljxiash has joined #openstack-nova | 01:32 | |
| *** EinstCrazy has joined #openstack-nova | 01:35 | |
| *** ducttape_ has joined #openstack-nova | 01:36 | |
| *** ducttape_ has quit IRC | 01:37 | |
| *** haplo37_ has quit IRC | 01:38 | |
| *** yulong|away has joined #openstack-nova | 01:38 | |
| *** yulong|away is now known as liuyulong | 01:38 | |
| *** ljxiash has quit IRC | 01:39 | |
| *** ljxiash has joined #openstack-nova | 01:39 | |
| *** ducttape_ has joined #openstack-nova | 01:41 | |
| *** ljxiash has quit IRC | 01:44 | |
| *** haplo37 has quit IRC | 01:44 | |
| *** haplo37 has joined #openstack-nova | 01:45 | |
| *** tonytan4ever has joined #openstack-nova | 01:46 | |
| *** hieulq has joined #openstack-nova | 01:47 | |
| *** tonytan4ever has quit IRC | 01:50 | |
| *** browne has quit IRC | 01:51 | |
| *** ljxiash has joined #openstack-nova | 01:57 | |
| *** ljxiash has quit IRC | 01:57 | |
| *** ljxiash has joined #openstack-nova | 01:57 | |
| *** yuntongjin has quit IRC | 01:58 | |
| *** Jeffrey4l has joined #openstack-nova | 01:58 | |
| *** ljxiash_ has joined #openstack-nova | 01:58 | |
| *** yuntongjin has joined #openstack-nova | 01:59 | |
| *** phuongnh has joined #openstack-nova | 02:00 | |
| *** ljxiash has quit IRC | 02:02 | |
| *** kmartin has quit IRC | 02:02 | |
| *** liusheng has quit IRC | 02:03 | |
| mriedem | ildikov: i finally gave https://review.openstack.org/#/c/335358/ a good run through | 02:03 |
| openstackgerrit | John Hua proposed openstack/nova: XenAPI: device tagging https://review.openstack.org/333781 | 02:04 |
| *** liusheng has joined #openstack-nova | 02:04 | |
| *** baoli has quit IRC | 02:05 | |
| *** unicell has quit IRC | 02:08 | |
| *** ducttape_ has quit IRC | 02:09 | |
| *** baoli has joined #openstack-nova | 02:11 | |
| *** stewie925 has quit IRC | 02:12 | |
| *** ijw has joined #openstack-nova | 02:19 | |
| ildikov | mriedem: cool, tnx | 02:22 |
| mriedem | ildikov: why are you still up? | 02:22 |
| ildikov | mriedem: I'll check prolly tomorrow | 02:22 |
| mriedem | yeah get some sleep :) | 02:23 |
| ildikov | I'm at Seattle attending conferences :) | 02:23 |
| *** ijw has quit IRC | 02:23 | |
| ildikov | So I'm in time zone this time | 02:23 |
| *** ijw has joined #openstack-nova | 02:24 | |
| ildikov | But suffering from wifi issues at the event venue | 02:24 |
| openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648 | 02:24 |
| openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (end) https://review.openstack.org/342649 | 02:25 |
| *** ijw has quit IRC | 02:29 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Use is_valid_cidr from oslo_utils https://review.openstack.org/320375 | 02:29 |
| *** mriedem has quit IRC | 02:30 | |
| *** ijw has joined #openstack-nova | 02:31 | |
| *** salv-orlando has joined #openstack-nova | 02:36 | |
| *** salv-orlando has quit IRC | 02:40 | |
| *** browne has joined #openstack-nova | 02:42 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add support for archiving all deleted rows https://review.openstack.org/378177 | 02:43 |
| *** ijw has quit IRC | 02:44 | |
| *** baoli has quit IRC | 02:52 | |
| *** browne has quit IRC | 02:53 | |
| *** yuntongjin has quit IRC | 02:59 | |
| *** Sukhdev has joined #openstack-nova | 02:59 | |
| *** tuanla has joined #openstack-nova | 03:00 | |
| *** Sukhdev has quit IRC | 03:01 | |
| *** david-lyle has quit IRC | 03:04 | |
| *** ducttape_ has joined #openstack-nova | 03:09 | |
| *** rfolco_ has quit IRC | 03:14 | |
| *** sdake_ has quit IRC | 03:17 | |
| *** armax has quit IRC | 03:18 | |
| *** unicell has joined #openstack-nova | 03:21 | |
| *** aswadr_ has joined #openstack-nova | 03:21 | |
| openstackgerrit | Rong Han proposed openstack/nova: migration.source_compute should be unchanged after finish_revert_resize. https://review.openstack.org/335270 | 03:21 |
| *** jamesden_ has quit IRC | 03:26 | |
| *** ducttape_ has quit IRC | 03:33 | |
| *** ljxiash_ has quit IRC | 03:37 | |
| *** ljxiash has joined #openstack-nova | 03:38 | |
| *** sdake has joined #openstack-nova | 03:39 | |
| *** adisky has joined #openstack-nova | 03:39 | |
| *** namnh has joined #openstack-nova | 03:41 | |
| *** ljxiash has quit IRC | 03:43 | |
| *** dave-mccowan has quit IRC | 03:47 | |
| *** hemanthm|afk is now known as hemanthm | 03:50 | |
| *** sdake_ has joined #openstack-nova | 03:50 | |
| *** Sukhdev has joined #openstack-nova | 03:50 | |
| *** sdake has quit IRC | 03:51 | |
| *** tongli_ has quit IRC | 03:57 | |
| *** artom has quit IRC | 03:58 | |
| *** gongysh has quit IRC | 03:58 | |
| *** artom has joined #openstack-nova | 03:59 | |
| *** artom has quit IRC | 03:59 | |
| *** artom has joined #openstack-nova | 04:00 | |
| *** haplo37 has quit IRC | 04:00 | |
| *** dikonoo has joined #openstack-nova | 04:00 | |
| *** haplo37 has joined #openstack-nova | 04:01 | |
| *** pbandark has joined #openstack-nova | 04:08 | |
| openstackgerrit | Ha Van Tu proposed openstack/nova: Fix typo in comment https://review.openstack.org/378226 | 04:15 |
| *** raunak has joined #openstack-nova | 04:22 | |
| *** sai has quit IRC | 04:22 | |
| *** sai has joined #openstack-nova | 04:23 | |
| *** amotoki has joined #openstack-nova | 04:28 | |
| *** ekuris has joined #openstack-nova | 04:31 | |
| *** claudiub|2 has joined #openstack-nova | 04:31 | |
| *** sudipto_ has joined #openstack-nova | 04:38 | |
| *** sudswas__ has joined #openstack-nova | 04:38 | |
| *** prateek_ has joined #openstack-nova | 04:38 | |
| *** psachin has joined #openstack-nova | 04:41 | |
| *** unicell has quit IRC | 04:41 | |
| *** unicell has joined #openstack-nova | 04:42 | |
| *** artom has quit IRC | 04:45 | |
| *** artom has joined #openstack-nova | 04:45 | |
| *** artom has quit IRC | 04:46 | |
| *** artom has joined #openstack-nova | 04:46 | |
| *** sudipto_ has quit IRC | 04:46 | |
| *** sudswas__ has quit IRC | 04:46 | |
| *** unicell1 has joined #openstack-nova | 04:48 | |
| *** gongysh has joined #openstack-nova | 04:49 | |
| *** unicell has quit IRC | 04:51 | |
| *** unicell1 has quit IRC | 04:55 | |
| *** unicell has joined #openstack-nova | 04:56 | |
| *** haplo37- has quit IRC | 05:00 | |
| *** haplo37_ has joined #openstack-nova | 05:02 | |
| openstackgerrit | Lujin Luo proposed openstack/nova: Change type of "networks" and "security_groups" in compute-v2.1 https://review.openstack.org/378240 | 05:03 |
| *** siva_krish has joined #openstack-nova | 05:06 | |
| *** bks has joined #openstack-nova | 05:07 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** lujinluo has joined #openstack-nova | 05:08 | |
| *** Sukhdev has quit IRC | 05:08 | |
| *** links has joined #openstack-nova | 05:08 | |
| *** artom_ has joined #openstack-nova | 05:08 | |
| *** artom has quit IRC | 05:08 | |
| *** diga_ has joined #openstack-nova | 05:09 | |
| *** links has quit IRC | 05:15 | |
| *** links has joined #openstack-nova | 05:17 | |
| *** salv-orlando has joined #openstack-nova | 05:18 | |
| *** salv-orlando has quit IRC | 05:22 | |
| openstackgerrit | Atsushi SAKAI proposed openstack/nova: Fix typo on api-ref parameters https://review.openstack.org/378247 | 05:29 |
| *** woodster_ has quit IRC | 05:30 | |
| *** sdake_ has quit IRC | 05:30 | |
| *** unicell has quit IRC | 05:32 | |
| *** unicell1 has joined #openstack-nova | 05:32 | |
| *** paul-carlton2 has joined #openstack-nova | 05:34 | |
| openstackgerrit | Hironori Shiina proposed openstack/nova: Fix a few typos in API reference https://review.openstack.org/378248 | 05:37 |
| *** raunak has quit IRC | 05:39 | |
| *** kaisers has joined #openstack-nova | 05:39 | |
| *** sudipto has joined #openstack-nova | 05:40 | |
| *** sudipto_ has joined #openstack-nova | 05:40 | |
| *** jaosorior has joined #openstack-nova | 05:46 | |
| *** nherciu has joined #openstack-nova | 05:53 | |
| *** j_king has quit IRC | 05:53 | |
| *** ljxiash has joined #openstack-nova | 05:56 | |
| *** unicell has joined #openstack-nova | 05:58 | |
| *** unicell1 has quit IRC | 05:59 | |
| *** sahid has joined #openstack-nova | 06:01 | |
| *** lpetrut has joined #openstack-nova | 06:04 | |
| *** mjura has joined #openstack-nova | 06:09 | |
| *** ljxiash has quit IRC | 06:10 | |
| *** rcernin has joined #openstack-nova | 06:14 | |
| *** mjura has quit IRC | 06:16 | |
| *** tojuvone has joined #openstack-nova | 06:16 | |
| *** mjura has joined #openstack-nova | 06:16 | |
| *** nkrinner_afk is now known as nkrinner | 06:20 | |
| *** andreas_s has joined #openstack-nova | 06:24 | |
| *** liverpooler has joined #openstack-nova | 06:25 | |
| *** rhagarty__ has quit IRC | 06:26 | |
| *** rhagarty__ has joined #openstack-nova | 06:27 | |
| *** siva_krish has quit IRC | 06:31 | |
| *** crinkle_ is now known as crinkle | 06:33 | |
| *** andreas_s has quit IRC | 06:36 | |
| *** pcaruana has joined #openstack-nova | 06:37 | |
| *** ihrachys has joined #openstack-nova | 06:37 | |
| *** andreas_s has joined #openstack-nova | 06:38 | |
| *** ihrachys has quit IRC | 06:40 | |
| *** ihrachys has joined #openstack-nova | 06:41 | |
| openstackgerrit | Adam Kijak proposed openstack/nova: Last chance call to neutron if VIF plugin notification is lost https://review.openstack.org/378278 | 06:41 |
| *** ihrachys has quit IRC | 06:44 | |
| *** artom_ has quit IRC | 06:45 | |
| openstackgerrit | sahid proposed openstack/nova-specs: Libvirt driver emulator threads placement policy https://review.openstack.org/284094 | 06:46 |
| *** mrsoul has quit IRC | 06:47 | |
| *** mrsoul has joined #openstack-nova | 06:48 | |
| *** salv-orlando has joined #openstack-nova | 06:50 | |
| *** artom has joined #openstack-nova | 06:51 | |
| *** artom has quit IRC | 06:52 | |
| *** artom has joined #openstack-nova | 06:52 | |
| *** lpetrut has quit IRC | 06:55 | |
| *** Cristina__ has joined #openstack-nova | 06:56 | |
| *** muawiakhan has joined #openstack-nova | 06:58 | |
| *** msno has joined #openstack-nova | 07:00 | |
| *** tuanla has quit IRC | 07:01 | |
| *** kevin_ has joined #openstack-nova | 07:03 | |
| *** kevin_ is now known as kevinz | 07:04 | |
| *** diana_clarke has quit IRC | 07:05 | |
| *** matrohon has joined #openstack-nova | 07:10 | |
| *** pbandark has quit IRC | 07:14 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: WIP Transform instance.reboot notifications https://review.openstack.org/330224 | 07:16 |
| *** links has quit IRC | 07:16 | |
| *** slaweq has joined #openstack-nova | 07:18 | |
| *** artom_ has joined #openstack-nova | 07:28 | |
| *** artom has quit IRC | 07:28 | |
| *** pbandark has joined #openstack-nova | 07:30 | |
| *** jlanoux has joined #openstack-nova | 07:33 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve libvirt lvm https://review.openstack.org/378303 | 07:34 |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve libvirt lvm https://review.openstack.org/378303 | 07:42 |
| *** salv-orl_ has joined #openstack-nova | 07:43 | |
| *** links has joined #openstack-nova | 07:45 | |
| *** pbandark has quit IRC | 07:45 | |
| *** salv-orlando has quit IRC | 07:46 | |
| *** pilgrimstack has joined #openstack-nova | 07:50 | |
| *** ihrachys has joined #openstack-nova | 07:51 | |
| *** zenoway has joined #openstack-nova | 07:52 | |
| *** pbandark has joined #openstack-nova | 07:57 | |
| *** pbandark has quit IRC | 07:57 | |
| *** pbandark has joined #openstack-nova | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** pbandark has quit IRC | 08:01 | |
| *** zzzeek has joined #openstack-nova | 08:01 | |
| *** sc68cal_ has joined #openstack-nova | 08:02 | |
| *** ijw has joined #openstack-nova | 08:03 | |
| *** pbandark has joined #openstack-nova | 08:03 | |
| *** sc68cal has quit IRC | 08:03 | |
| *** yassine has joined #openstack-nova | 08:11 | |
| *** ijw has quit IRC | 08:11 | |
| *** yassine is now known as Guest99661 | 08:12 | |
| *** hfu has joined #openstack-nova | 08:14 | |
| *** eharney has quit IRC | 08:16 | |
| *** avolkov has joined #openstack-nova | 08:19 | |
| *** links has quit IRC | 08:21 | |
| *** code-R has joined #openstack-nova | 08:29 | |
| *** code-R_ has joined #openstack-nova | 08:31 | |
| *** Oku_OS is now known as Oku_OS-away | 08:32 | |
| *** kashyap has joined #openstack-nova | 08:33 | |
| *** code-R has quit IRC | 08:33 | |
| *** Oku_OS-away is now known as Oku_OS | 08:34 | |
| *** code-R_ has quit IRC | 08:36 | |
| *** links has joined #openstack-nova | 08:37 | |
| snikitin_ | mdbooth: Hi, Matthew! Why do you think that BDM id as stable id is useless if we are talking about admin only API? | 08:39 |
| *** snikitin_ is now known as snikitin | 08:39 | |
| *** snikitin_ has joined #openstack-nova | 08:41 | |
| *** sdake has joined #openstack-nova | 08:41 | |
| *** derekh has joined #openstack-nova | 08:41 | |
| bauzas | tonyb: around ? | 08:41 |
| *** _gryf_ is now known as _gryf | 08:41 | |
| *** sdake has quit IRC | 08:42 | |
| bauzas | tonyb: we have a couple of changes in https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/mitaka and I wonder whether we should plan to trample those that the master change was merged by Ocata, given Mitaka will become Phase-II once stable Newton becomes phase-I | 08:43 |
| bauzas | tonyb: like https://review.openstack.org/#/c/375873/ | 08:43 |
| *** jed56 has joined #openstack-nova | 08:45 | |
| *** danpawlik has joined #openstack-nova | 08:47 | |
| *** haplo37 has quit IRC | 08:47 | |
| *** priteau has joined #openstack-nova | 08:48 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| danpawlik | Hello, I run on xenial tox -e bindep and it fails. When I add into tox.ini into testenv:bindep => basepython = python2.7 it works good. Maybe it should be added into nova project? | 08:48 |
| *** moshele has joined #openstack-nova | 08:49 | |
| *** openstackgerrit has joined #openstack-nova | 08:49 | |
| tonyb | bauzas: Yeah I have it on my todo list to review all the nova things this week | 08:49 |
| *** haplo37 has joined #openstack-nova | 08:49 | |
| *** roeyc has joined #openstack-nova | 08:50 | |
| *** danpb has joined #openstack-nova | 08:51 | |
| *** claudiub|2 has quit IRC | 08:52 | |
| bauzas | tonyb: either way, I filed my concern in the above change, feel free to axe it | 08:52 |
| *** _oanson is now known as oanson | 08:55 | |
| *** kaisers3 has quit IRC | 08:57 | |
| *** Oku_OS is now known as Oku_OS-away | 08:57 | |
| *** artom_ has quit IRC | 08:58 | |
| *** kaisers1 has joined #openstack-nova | 08:59 | |
| *** artom has joined #openstack-nova | 08:59 | |
| *** jamielennox is now known as jamielennox|away | 08:59 | |
| *** alexchadin has joined #openstack-nova | 09:06 | |
| *** artom has quit IRC | 09:07 | |
| *** artom has joined #openstack-nova | 09:08 | |
| *** claudiub|2 has joined #openstack-nova | 09:11 | |
| *** kaisers has quit IRC | 09:12 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/nova: Avoid Forcing the Translation of Translatable Variables https://review.openstack.org/378449 | 09:13 |
| *** priteau has quit IRC | 09:15 | |
| *** priteau has joined #openstack-nova | 09:17 | |
| *** dmellado_ is now known as dmellado | 09:18 | |
| openstackgerrit | Adam Kijak proposed openstack/nova: Last chance call to neutron if VIF plugin notification is lost https://review.openstack.org/378278 | 09:24 |
| *** lpetrut has joined #openstack-nova | 09:36 | |
| *** lxsli0 is now known as lxsli | 09:36 | |
| *** roeyc has quit IRC | 09:37 | |
| *** code-R has joined #openstack-nova | 09:38 | |
| *** Oku_OS-away is now known as Oku_OS | 09:38 | |
| *** tuanla has joined #openstack-nova | 09:40 | |
| openstackgerrit | Chris Dent proposed openstack/nova: [placement] ensure that allow headers are native strings https://review.openstack.org/374800 | 09:40 |
| *** gongysh has quit IRC | 09:40 | |
| *** aswadr_ has quit IRC | 09:42 | |
| *** hfu has quit IRC | 09:42 | |
| *** haplo37_ has quit IRC | 09:44 | |
| *** claudiub|2 has quit IRC | 09:45 | |
| *** hfu has joined #openstack-nova | 09:46 | |
| *** haplo37_ has joined #openstack-nova | 09:47 | |
| *** alexchadin has quit IRC | 09:48 | |
| *** alexchadin has joined #openstack-nova | 09:49 | |
| *** code-R_ has joined #openstack-nova | 09:49 | |
| *** hfu has quit IRC | 09:50 | |
| *** markmc` is now known as markmc | 09:51 | |
| *** code-R has quit IRC | 09:52 | |
| *** alexchadin has quit IRC | 09:53 | |
| *** matrohon has quit IRC | 09:56 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/nova: Files with no code must be left completely empty https://review.openstack.org/378491 | 10:00 |
| mdbooth | Wow, was going to propose removing a workaround in the libvirt driver that was fixed in stable libvirt in November 2014. | 10:01 |
| mdbooth | However, it seems we still support running against stable libvit from January 2014. | 10:01 |
| *** mamandle has joined #openstack-nova | 10:05 | |
| mamandle | @alaski - I have a query regarding the commit https://github.com/openstack/nova/commit/f577f650c7ca9d8dd66eaec919e4805c09d16f6d | 10:07 |
| *** EinstCrazy has quit IRC | 10:08 | |
| openstackgerrit | Tovin Seven proposed openstack/nova: Remove mox in nova/tests/unit/virt/xenapi/image/test_bittorrent.py https://review.openstack.org/378496 | 10:08 |
| *** EinstCrazy has joined #openstack-nova | 10:08 | |
| *** cdent has joined #openstack-nova | 10:08 | |
| mamandle | With that commit after a scheduler failure the instance forever seems to be in scheduling state. | 10:09 |
| openstackgerrit | Tovin Seven proposed openstack/nova: Remove mox in virt/xenapi/image/test_bittorrent.py https://review.openstack.org/378496 | 10:10 |
| *** kaisers has joined #openstack-nova | 10:12 | |
| *** kaisers_ has joined #openstack-nova | 10:12 | |
| *** lujinluo has quit IRC | 10:13 | |
| *** EinstCrazy has quit IRC | 10:13 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve libvirt imagecache https://review.openstack.org/378497 | 10:13 |
| *** kaisers__ has joined #openstack-nova | 10:14 | |
| *** kaisers_ has quit IRC | 10:14 | |
| *** kaisers has quit IRC | 10:16 | |
| openstackgerrit | coolias proposed openstack/nova: Fixes remove_image to capture ImageBusy exception https://review.openstack.org/378501 | 10:16 |
| openstackgerrit | Tovin Seven proposed openstack/nova: Remove mox in virt/xenapi/image/test_bittorrent.py https://review.openstack.org/378496 | 10:16 |
| openstackgerrit | Lucian Petrut proposed openstack/nova: HyperV: use os-brick for volume related operations https://review.openstack.org/273504 | 10:20 |
| *** ihrachys has quit IRC | 10:22 | |
| *** mamandle has quit IRC | 10:24 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: config options: improve libvirt imagebackend https://review.openstack.org/378507 | 10:24 |
| kashyap | mdbooth: Yeah, 1.2.1 is from JAN 2014. And, danpb proposed the NEXT_MIN_LIBVIRT_VERSION to 1.2.9 (released: OCT 2014) - https://review.openstack.org/#/c/377923/ | 10:27 |
| * mdbooth needs 1.2.10 for this particular fix | 10:27 | |
| *** mamandle has joined #openstack-nova | 10:27 | |
| danpb | mdbooth: that's not going to be available for a while yet as it'd currently mean dropping Debian support | 10:29 |
| *** hoangcx has quit IRC | 10:29 | |
| * mdbooth wonders why we're interested in supporting users who want to continuously deploy openstack whilst running a 2 year old hypervisor. | 10:30 | |
| kashyap | mdbooth: "That's what the CI machines use"? | 10:31 |
| danpb | based on their 2 year cadence, i doubt we'll get new debian until mid-2017, so probably the Qxxxx release would be first where we can bump beyond the 1.2.9 version | 10:31 |
| * mdbooth proposes supporting openstack releases for 2 years. | 10:31 | |
| mdbooth | Well, I say 2 year old. It's 2.5 years old. | 10:32 |
| mdbooth | We should support openstack releases for 2.5 years. | 10:32 |
| * kashyap just learnt, the Qxxxx release is called "Queens" - https://releases.openstack.org/ | 10:33 | |
| johnthetubaguy | bauzas: I wasn't 100% if we are allowed to merge this: https://review.openstack.org/#/c/378057 | 10:33 |
| *** tuanla has quit IRC | 10:39 | |
| *** salv-orlando has joined #openstack-nova | 10:40 | |
| *** salv-orl_ has quit IRC | 10:40 | |
| *** tbachman has quit IRC | 10:44 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Add _rebuild_instance helper method https://review.openstack.org/376004 | 10:47 |
| *** trisq has quit IRC | 10:48 | |
| *** dingboopt_ has quit IRC | 10:50 | |
| *** diana_clarke has joined #openstack-nova | 10:50 | |
| *** smatzek__ has joined #openstack-nova | 10:50 | |
| *** alexchadin has joined #openstack-nova | 10:52 | |
| *** links has quit IRC | 10:53 | |
| *** priteau has quit IRC | 10:53 | |
| *** rmart04 has joined #openstack-nova | 10:56 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Return build_requests instead of instances https://review.openstack.org/374267 | 10:57 |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Add schedule_and_build_instances conductor method https://review.openstack.org/367557 | 10:57 |
| openstackgerrit | Andrey Volkov proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | 10:57 |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Tests: improve assertJsonEqual diagnostic message https://review.openstack.org/372644 | 10:57 |
| *** phuongnh has quit IRC | 10:58 | |
| *** oomichi_ has quit IRC | 10:59 | |
| msno | hi guyz.. | 11:00 |
| *** smatzek__ has quit IRC | 11:00 | |
| msno | snapshot of a instace which is boot from volume is getting zero size in HP helion cloud setup | 11:00 |
| msno | is it a known issue | 11:00 |
| msno | its based on Mitaka | 11:00 |
| *** links has joined #openstack-nova | 11:02 | |
| *** haplo37 has quit IRC | 11:02 | |
| *** haplo37 has joined #openstack-nova | 11:08 | |
| openstackgerrit | Daniel Berrange proposed openstack/os-vif: os-vif: add initial documentation about object model https://review.openstack.org/294596 | 11:09 |
| *** sdague has joined #openstack-nova | 11:09 | |
| *** moshele has quit IRC | 11:09 | |
| *** moshele has joined #openstack-nova | 11:10 | |
| *** hshiina has joined #openstack-nova | 11:13 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Restore V3 Diagnostics info https://review.openstack.org/357884 | 11:14 |
| *** rtheis has joined #openstack-nova | 11:16 | |
| *** karthiks has joined #openstack-nova | 11:16 | |
| *** kaisers__ has quit IRC | 11:17 | |
| *** bvanhav has joined #openstack-nova | 11:17 | |
| *** artom has quit IRC | 11:18 | |
| *** jojden has joined #openstack-nova | 11:18 | |
| jojden | Hi | 11:18 |
| *** artom has joined #openstack-nova | 11:19 | |
| *** artom has quit IRC | 11:19 | |
| *** artom has joined #openstack-nova | 11:19 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Add a post-test-hook to run the archive command https://review.openstack.org/376567 | 11:20 |
| sfinucan | msno: That might be something worth pinging HP directly about | 11:25 |
| msno | sfinucan, wanted to know if there is any such known issue in openstack itself | 11:26 |
| msno | or is it related to .. the backend volume which is used | 11:26 |
| msno | like .. the snashotting mechanism used in backend lun? | 11:26 |
| sfinucan | msno: Ah, I can't help you there, I'm afraid. Maybe search https://bugs.launchpad.net/nova | 11:27 |
| msno | sfinucan, thank you | 11:27 |
| *** lucas-afk is now known as lucasagomes | 11:29 | |
| *** mamandle has quit IRC | 11:29 | |
| *** pbandark has quit IRC | 11:30 | |
| *** namnh has quit IRC | 11:31 | |
| *** mamandle has joined #openstack-nova | 11:32 | |
| *** pbandark has joined #openstack-nova | 11:33 | |
| *** pilgrimstack has quit IRC | 11:36 | |
| *** pilgrimstack1 has joined #openstack-nova | 11:37 | |
| eantyshev | mbooth: Hello! Can we now discuss here libvirt block jobs in nova driver? | 11:39 |
| eantyshev | mdbooth: Hello! Can we now discuss here libvirt block jobs in nova driver? | 11:39 |
| mdbooth | eantyshev: Sure, if you like. I've pretty much said it in the review, though. | 11:40 |
| *** pilgrimstack has joined #openstack-nova | 11:40 | |
| *** pilgrimstack1 has quit IRC | 11:40 | |
| *** cdelatte has quit IRC | 11:40 | |
| eantyshev | mdbooth: can I ask you to review also this change: https://review.openstack.org/#/c/375652/ | 11:40 |
| *** trisq has joined #openstack-nova | 11:40 | |
| mdbooth | eantyshev: Just checking, are you running a really old libvirt, btw? | 11:41 |
| *** pilgrimstack has quit IRC | 11:42 | |
| eantyshev | mdbooth: 1.3.3.2 is not so old, isn't it? | 11:42 |
| mdbooth | eantyshev: No, that's ok. Just wondering why the wait_for_job_clean | 11:43 |
| mdbooth | As that seems to have been a workaround for a libvirt bug which was fixed in 2014 | 11:43 |
| eantyshev | mdbooth: common behavior for rebase/commit block jobs is that job dissapears when it's done | 11:44 |
| mdbooth | eantyshev: Yeah, I prefer the other patch, tbh. | 11:44 |
| *** salv-orlando has quit IRC | 11:44 | |
| mdbooth | Right, which should be represented by returning None from get_job_info, imho. | 11:44 |
| *** ldeptula has joined #openstack-nova | 11:45 | |
| mdbooth | I'm uncomfortable with it appearing to return data which is not returned by libvirt | 11:45 |
| eantyshev | mdbooth: the other doesn't fix anything. Call semantics is less important, IMHO | 11:45 |
| mdbooth | which was the original issue | 11:45 |
| mdbooth | Call semantics are a maintenance issue. | 11:45 |
| mdbooth | Which is expensive. | 11:46 |
| mdbooth | The issue we were originally addressing is that we were working around behaviour which didn't exist, which required anybody reading this code to think themselves into knots. | 11:46 |
| * mdbooth wonders why you'd want wait_for_job_clean=False | 11:47 | |
| eantyshev | mdbooth: I want it to be True actually | 11:48 |
| *** thorst has joined #openstack-nova | 11:48 | |
| mdbooth | eantyshev: Quite. Why would you ever want anything else? | 11:48 |
| eantyshev | at least in _volume_snapshot_delete | 11:48 |
| eantyshev | mdbooth: my primary purpose was fixing a bug I've found: https://bugs.launchpad.net/nova/+bug/1627134 | 11:50 |
| openstack | Launchpad bug 1627134 in OpenStack Compute (nova) "libvirt driver stuck deleting online snapshot" [High,In progress] - Assigned to Evgeny Antyshev (eantyshev) | 11:50 |
| mdbooth | eantyshev: I think the problem with wait_for_job_clean is that it's a race, no? | 11:50 |
| *** derekh has quit IRC | 11:52 | |
| eantyshev | mdbooth: not exactly. Problem that in _volume_delete_snapshot block/commit jobs the job dissapears, and not stays in cur==end state | 11:52 |
| *** sudipto_ has quit IRC | 11:52 | |
| *** sudipto has quit IRC | 11:52 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Log parsing tool and post_test_hook script https://review.openstack.org/376531 | 11:52 |
| mdbooth | eantyshev: With the current (and proposed) semantics, with wait_for_job_clean we'll return True from wait_for_job if the job doesn't exist. | 11:53 |
| mdbooth | Can we be sure that this isn't because it hasn't been created, yet? | 11:53 |
| mdbooth | kashyap: ^^^ | 11:53 |
| *** markvoelker has quit IRC | 11:53 | |
| kashyap | mdbooth: Reading the scrollback, and was looking at the bugs | 11:53 |
| mdbooth | Also, wait_for_job() should either wait or be called something else | 11:53 |
| mdbooth | That's a separate issue, though | 11:54 |
| kashyap | Indeed "thinking myself into knots" | 11:54 |
| mdbooth | kashyap: So, there's a real bug here which we need to fix | 11:54 |
| kashyap | mdbooth: Yeah, I was looking at the bug filed by eantyshev | 11:54 |
| eantyshev | mdbooth: well, I beleive the job is created ok when self._guest._domain.blockRebase succeeds | 11:54 |
| mdbooth | However, I'd like to come up with a way to fix it which doesn't invent libvirt api semantics | 11:54 |
| *** muawiakh_ has joined #openstack-nova | 11:55 | |
| mdbooth | eantyshev: Apparently not on really old libvirt | 11:55 |
| eantyshev | mdbooth: what version do you mean? | 11:55 |
| *** muawiak__ has joined #openstack-nova | 11:55 | |
| kashyap | eantyshev: That bug is also reproducible with NFS backend? | 11:55 |
| mdbooth | kashyap: So, how long is that job info supposed to hang around for? Why would eantyshev not be seeing an end condition where cur == end? | 11:55 |
| openstackgerrit | Sean Dague proposed openstack/nova: Log parsing tool and post_test_hook script https://review.openstack.org/376531 | 11:56 |
| *** muawiakhan has quit IRC | 11:56 | |
| kashyap | mdbooth: Refreshing my memory...one moment | 11:56 |
| eantyshev | kashyap, mdbooth: because the job stays in cur==end state in some distinct cases, like drive mirroring | 11:57 |
| mdbooth | eantyshev: This is in _live_snapshot(), right? | 11:57 |
| kashyap | eantyshev: In that case, one has to explicitly issue an abort | 11:57 |
| eantyshev | yes | 11:57 |
| mdbooth | eantyshev: Can you explain in more detail? The job is in cur==end, but the job is not complete? | 11:58 |
| eantyshev | that's when wait_for_job(wait_for_job_clean=False) should be used | 11:58 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: fix DiskSmallerThanImage when block migrate ephemerals https://review.openstack.org/378560 | 11:58 |
| *** baoli has joined #openstack-nova | 11:58 | |
| mdbooth | wait_for_job_clean() is a workaround for a race in an old libvirt, as per the comment. | 11:59 |
| mdbooth | Because blockRebase() used to be unintentionally async, iirc | 11:59 |
| mdbooth | i.e. it returned before the job had been created, which was a bug. | 11:59 |
| *** roeyc has joined #openstack-nova | 11:59 | |
| *** muawiakh_ has quit IRC | 11:59 | |
| ldeptula | Does nova report only memory usage of virtual machines itself? In case of bigger video memory requested it may be important to be concious of higher memory consumption on compute node | 12:00 |
| mdbooth | ldeptula: I don't think we track video memory. I don't recall anybody ever asking, though. | 12:00 |
| *** lucasagomes is now known as lucas-bbl | 12:01 | |
| *** Cassowary has quit IRC | 12:01 | |
| eantyshev | mdbooth: AFAIU, it was abort job which is async due to the bug you mean. see _swap_volume code | 12:01 |
| kashyap | I think what he means is that when copy is in cur==end state, the job remains mirroring, until one issues an explicit blockJobAbort() | 12:01 |
| eantyshev | kashyap: thank you, I was just looking for a link | 12:02 |
| mdbooth | eantyshev: Yep, was abort. | 12:02 |
| ldeptula | mdbooth: right now I'm testing following scenario. On compute node I have 512 huge pages each 2mb. I scheduled vm with 512 mb of memory and there's consumpted 256 pages for vm and 8 for video | 12:02 |
| mdbooth | Anything, thinking about that I don't think anything else should use it. | 12:02 |
| ldeptula | mdbooth: but in nova db there's info only about 256 pages consumpted | 12:02 |
| *** sdake has joined #openstack-nova | 12:02 | |
| mdbooth | ldeptula: Perhaps sahid or danpb might know more. | 12:03 |
| *** rfolco_ has joined #openstack-nova | 12:04 | |
| *** jaypipes has joined #openstack-nova | 12:05 | |
| *** haplo37_ has quit IRC | 12:05 | |
| mdbooth | kashyap: So, I think this hangs on the lifecycle of a block job. At what point is it no longer possible to query it for completion? | 12:06 |
| kashyap | mdbooth: Good question, I don't know top off my head, looking through that mail thread with Eric to see if I'll remember | 12:06 |
| danpb | ldeptula: video should be allocated out of normal memory, not huge page memory afaik | 12:07 |
| mdbooth | Is there any point at which we should assume that a return of 'no such job' means that it has completed? | 12:07 |
| *** haplo37_ has joined #openstack-nova | 12:07 | |
| kashyap | mdbooth: "If qemu doesn't report anything (because the job is not started yet), then libvirt should report cur=0, end=1 (the job still has 100% to go)." | 12:08 |
| openstackgerrit | Sean Dague proposed openstack/nova: Add a post-test-hook to run the archive command https://review.openstack.org/376567 | 12:08 |
| *** cdelatte has joined #openstack-nova | 12:09 | |
| mdbooth | kashyap: Right, but at what point does it stop returning anything because it's no longer tracking the job? | 12:09 |
| kashyap | mdbooth: Hmm, that detail is probably lurking in the libvirt code | 12:09 |
| *** dave-mccowan has joined #openstack-nova | 12:09 | |
| mdbooth | Is it after some specific call? Maybe something to delete the job record. Maybe after having returned info with cur==end, maybe time? | 12:09 |
| *** edmondsw has joined #openstack-nova | 12:09 | |
| mdbooth | eantyshev: You've highlighted that we're on shaky ground here :) | 12:10 |
| *** nshirokovskiy has joined #openstack-nova | 12:10 | |
| kashyap | Very much. | 12:10 |
| ldeptula | @danpb: /proc/3963/numa_maps:2aaacac00000 prefer:0 file=/dev/hugepages2M/libvirt/qemu/qemu_back_mem.vga.vram.WmjVlz\040(deleted) huge anon=8 dirty=8 N0=8 kernelpagesize_kB=2048 | 12:10 |
| mdbooth | eantyshev: However, I'd prefer to fix it properly rather than hack round it. | 12:10 |
| *** cdelatte has quit IRC | 12:11 | |
| kashyap | mdbooth: Eric knows this area of code like the back of his hand, let's see if he's around - Pinging him on public #virt on OFTC | 12:11 |
| *** diga_ has quit IRC | 12:11 | |
| mdbooth | eantyshev: If the last fix caused a regression, you should probably propose a revert. | 12:11 |
| kashyap | mdbooth: It's affecting only certain backends apparently? | 12:11 |
| mdbooth | Unless you want to take it on yourself, that is. | 12:11 |
| *** alexchadin has quit IRC | 12:11 | |
| mdbooth | kashyap: Yet more complication :) | 12:12 |
| *** mtanino has joined #openstack-nova | 12:12 | |
| *** alexchadin has joined #openstack-nova | 12:12 | |
| eantyshev | mdbooth: if the blockRebase libvirt call succeeds, then it definitely means the job is created | 12:13 |
| danpb | ldeptula: what qemu are you using - that is certainly not expected | 12:13 |
| mdbooth | eantyshev: In which case wait_for_job_clean isn't being used as intended | 12:14 |
| *** mamandle has quit IRC | 12:14 | |
| mdbooth | eantyshev: Are you using it to indicate completion when the job no longer exists, btw? | 12:15 |
| eantyshev | mdbooth: exactly | 12:15 |
| mdbooth | eantyshev: Right, that's not what it was added for, and that's not what it's documented to do. | 12:15 |
| mdbooth | It's what it does coincidentally. | 12:15 |
| *** baoli has quit IRC | 12:16 | |
| * mdbooth doesn't want to depend on another coincidental feature. I'd prefer to revert the thing that broke you, or fix it properly. | 12:16 | |
| ldeptula | danpb: qemu-kvm.x86_64 10:1.5.3-105.el7_2.4 | 12:16 |
| *** ducttape_ has joined #openstack-nova | 12:17 | |
| eantyshev | mdbooth: I'd rather fix it | 12:17 |
| mdbooth | eantyshev: Which libvirt hypervisor are you using again? | 12:17 |
| *** mat128 is now known as mat128|afk | 12:17 | |
| kashyap | eantyshev: Your CI logs don't have libvirt debug filters enabled | 12:17 |
| kashyap | Possible to re-do your test with that? | 12:18 |
| mdbooth | Was it virtuozzo? | 12:18 |
| kashyap | mdbooth: Yea | 12:18 |
| kashyap | http://openstack-3rd-party-storage-ci-logs.virtuozzo.com/28/314928/13/check/dsvm-tempest-kvm/5aae7aa/logs/libvirt/libvirtd.txt.gz | 12:18 |
| eantyshev | kashyap: I have these logs, what information do you need? | 12:18 |
| eantyshev | kashyap: libvirt debug logs pollute system log very much | 12:18 |
| kashyap | eantyshev: Not really if you use log filters | 12:19 |
| *** ducttape_ has quit IRC | 12:19 | |
| kashyap | eantyshev: We've enabled it in upstream DevStack, and they're not really large | 12:19 |
| *** ducttape_ has joined #openstack-nova | 12:19 | |
| mdbooth | kashyap: Can you raise https://review.openstack.org/#/c/375652/ with some libvirt folks? | 12:19 |
| mdbooth | I'd like to understand what the semantics 1) are supposed to be, 2) really are. | 12:20 |
| kashyap | mdbooth: Yeah, I added Eric to that review, usually when he's added, he notices | 12:20 |
| kashyap | mdbooth: Yeah, that was my goal with http://www.redhat.com/archives/libvir-list/2016-September/msg00011.html | 12:20 |
| mdbooth | kashyap: Yup. This seems to be related but different. That mail was exactly what we needed to proceed, though. | 12:20 |
| kashyap | mdbooth: Yeah, I see this code he's referring to is in _volume_snapshot_delete() | 12:21 |
| *** pilgrimstack has joined #openstack-nova | 12:21 | |
| openstackgerrit | Hussain Chachuliya proposed openstack/nova: Replace uuid4() with uuidsentinel https://review.openstack.org/377663 | 12:21 |
| *** mamandle has joined #openstack-nova | 12:22 | |
| kashyap | eantyshev: http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova_plugins/functions-libvirt#n112 | 12:23 |
| eantyshev | kashyap: I'll enable that, but if you need something specific right now, better ask | 12:25 |
| *** takedakn has joined #openstack-nova | 12:25 | |
| mdbooth | Who killed gerrit? | 12:25 |
| danpb | ldeptula: its a bug in that old version of qemu | 12:26 |
| kashyap | eantyshev: No, in the middle of something else. But please attach them to the bug, so libvirt block folks can analyze them in their own time. | 12:27 |
| *** jamielennox|away is now known as jamielennox | 12:29 | |
| *** ftersin has quit IRC | 12:29 | |
| ldeptula | danpb: do you have link to that defect? | 12:30 |
| *** alexchadin has quit IRC | 12:30 | |
| kashyap | eantyshev: mdbooth: The Nova commit (1cf793df) that introduced that code ('while dev.wait_for_job(abort_on_error=True') also say that they haven't tested it with network protocols. | 12:32 |
| danpb | ldeptula: i don't know of any bug - i just observe that it only happens with that older qemu | 12:32 |
| *** salv-orlando has joined #openstack-nova | 12:33 | |
| ldeptula | danpb: okay, thanks for all information | 12:33 |
| mdbooth | kashyap: I think he's talking about constructing urls though, right? | 12:34 |
| *** oanson has quit IRC | 12:34 | |
| *** ratailor has quit IRC | 12:34 | |
| kashyap | mdbooth: Probably that's what he's alluding to. Wasn't clear to me | 12:35 |
| eantyshev | kashyap: I've attached the relevant piece to https://bugs.launchpad.net/nova/+bug/1627134 | 12:35 |
| openstack | Launchpad bug 1627134 in OpenStack Compute (nova) "libvirt driver stuck deleting online snapshot" [High,In progress] - Assigned to Evgeny Antyshev (eantyshev) | 12:35 |
| *** mriedem has joined #openstack-nova | 12:37 | |
| mdbooth | sahid: https://review.openstack.org/#/c/378560/ nice | 12:38 |
| *** bks has quit IRC | 12:38 | |
| mdbooth | sahid: That would also have been creating the wrong backing file, btw | 12:39 |
| *** ducttape_ has quit IRC | 12:40 | |
| *** ababich1 has quit IRC | 12:41 | |
| alaski | mamandle: do you have a bug open for the re-schedule issue? I think I know how to fix it, I just need to test it | 12:41 |
| mdbooth | sahid: Incidentally, I already fixed that bug in my libvirt refactor :) | 12:42 |
| *** aarefiev has quit IRC | 12:42 | |
| *** gstepanov has quit IRC | 12:42 | |
| *** vnogin has quit IRC | 12:42 | |
| kashyap | mdbooth: Can you hop on #virt, OFTC? | 12:44 |
| kashyap | eantyshev: Thank you. You might want to join there, too | 12:44 |
| mdbooth | kashyap: apparently not, no | 12:44 |
| *** ababich has joined #openstack-nova | 12:44 | |
| *** vnogin has joined #openstack-nova | 12:44 | |
| mdbooth | #virt: Cannot join channel (+k) - bad key | 12:44 |
| *** aarefiev has joined #openstack-nova | 12:44 | |
| * mdbooth doesn't know what that means | 12:44 | |
| kashyap | mdbooth: Anyway, I'll summarize on the review, if Eric himself doesn't comment. He's already analzyed the pastebin from eantyshev above. | 12:45 |
| kashyap | mdbooth: So, from the pastebin above | 12:46 |
| mdbooth | kashyap: Awesome, thanks. Please also pass on thanks to eblake. | 12:46 |
| kashyap | On line-148, you see: | 12:46 |
| kashyap | Sep 20 15:10:39 localhost libvirtd: 85854: info : qemuMonitorSend:1007 : QEMU_MONITOR_SEND_MSG: mon=0x7f64f8010bc0 msg={"execute":"query-block-jobs","id":"libvirt-111"}#015#012 fd=-1 | 12:46 |
| *** gstepanov has joined #openstack-nova | 12:46 | |
| kashyap | libvirt is querying for block job status | 12:46 |
| kashyap | And, on on line-159, QEMU responds: | 12:46 |
| kashyap | ep 20 15:10:39 localhost libvirtd: 85849: info : qemuMonitorIOProcess:426 : QEMU_MONITOR_IO_PROCESS: mon=0x7f64f8010bc0 buf={"return": [], "id": "libvirt-111"}#015#012 len=37 | 12:46 |
| *** rodrigods has quit IRC | 12:47 | |
| kashyap | mdbooth: "so libvirt should NOT be reporting a job status" | 12:47 |
| *** rodrigods has joined #openstack-nova | 12:47 | |
| eantyshev | kashyap: job status could be got from event at line-95 | 12:49 |
| kashyap | eantyshev: True, that is the COMPLETED event | 12:49 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Log parsing tool and post_test_hook script https://review.openstack.org/376531 | 12:49 |
| alex_xu | nova api subteam meeting is in 10 mins at #openstack-meeting-4 | 12:50 |
| mdbooth | kashyap: Ah, so completion is signalled by processing a COMPLETED event? | 12:50 |
| mdbooth | Do we consume those? | 12:50 |
| eantyshev | kashyap, mdbooth: AFAIK no | 12:50 |
| kashyap | mdbooth: Yes, the COMPLETED event signals that | 12:50 |
| mdbooth | So, we're badly misusing the api :( | 12:50 |
| mdbooth | block job info is for monitoring progress, not signalling completion? | 12:51 |
| eantyshev | mdbooth: that's right | 12:52 |
| mdbooth | Well, that sucks. | 12:52 |
| mdbooth | eantyshev: Are you up for that? | 12:52 |
| *** mamandle has quit IRC | 12:52 | |
| mdbooth | kashyap: Is ^^^ also your reading, btw? | 12:52 |
| kashyap | mdbooth: Yes, reading it. | 12:52 |
| kashyap | virDomainBlockJobInfo reports status | 12:53 |
| mdbooth | i.e. virDomainGetBlockJobInfo is the wrong api to be using in the first place? | 12:53 |
| bauzas | johnthetubaguy: see my comment on https://review.openstack.org/#/c/378057/2 | 12:55 |
| kashyap | mdbooth: I can't really say that yet without reading the code a bit more | 12:55 |
| *** markvoelker has joined #openstack-nova | 12:55 | |
| *** pbandark has quit IRC | 12:55 | |
| *** tblakes has joined #openstack-nova | 12:55 | |
| johnthetubaguy | bauzas: yeah, that makes sense, just wanted to make sure that was true | 12:56 |
| mdbooth | kashyap: My original question was around when we should expect this api call to signal completion, and when it should return no result. | 12:56 |
| eantyshev | mdbooth: perhaps I could do it in scope of above LP bug: monitor complete events for block job status | 12:56 |
| mdbooth | kashyap: If I've understood your response correctly, the answer is that we don't know, because it's not supposed to be used for this. | 12:56 |
| kashyap | mdbooth: It sends a signal completion when len == offset, see line-98 | 12:57 |
| *** david-lyle has joined #openstack-nova | 12:57 | |
| mriedem | mdbooth: i believe it's been a known issue that we don't have listeneners for job completed events in the libvirt driver, but we could/should | 12:57 |
| mdbooth | kashyap: Have you got that pastebin url again, btw? | 12:57 |
| mriedem | like device attach/detach completed events | 12:57 |
| mriedem | so we don't have to poll | 12:57 |
| kashyap | mdbooth: http://paste.openstack.org/show/583277/ | 12:57 |
| *** kaisers has joined #openstack-nova | 12:58 | |
| *** vishwanathj has joined #openstack-nova | 12:58 | |
| mdbooth | mriedem: Sounds like eantyshev was up for fixing that? | 12:58 |
| kashyap | mdbooth: It's this line: | 12:58 |
| kashyap | Sep 20 15:10:39 localhost libvirtd: 85849: info : qemuMonitorEmitEvent:1272 : mon=0x7f64f8010bc0 event=BLOCK_JOB_COMPLETED data={"device":"drive-virtio-disk1","len":1073741824,"offset":1073741824,"speed":0,"type":"stream"} | 12:58 |
| * eantyshev confirms | 12:59 | |
| *** baoli has joined #openstack-nova | 12:59 | |
| alex_xu | nova-api subteam meeting is running at #openstack-meeting-4 | 13:00 |
| kashyap | mdbooth: Okay, to your question, Eric says that: the libvirt API itself won't return the BLOCK_JOB_COMPLETED event | 13:00 |
| kashyap | mdbooth: One has to write an event hook... | 13:00 |
| mdbooth | We already have some of those somewhere | 13:00 |
| mriedem | we have the lifecycle event monitor | 13:01 |
| mriedem | i expect this would be similar for job status | 13:01 |
| *** mamandle has joined #openstack-nova | 13:01 | |
| *** baoli_ has joined #openstack-nova | 13:02 | |
| mdbooth | eantyshev: I'd still support a revert of the patch that regressed if you need a faster fix. | 13:03 |
| kashyap | mdbooth: mriedem: Another interesting related point (err, buggy behavior?), from libvirt dev on OFTC: | 13:03 |
| kashyap | 14:44 <@eblake> the C code is tri-state: -1 for error in querying, 0 for no jobs to report (because it finished), or >0 for job status available | 13:03 |
| kashyap | 14:44 <@eblake> it may be that the conversion from C state to python is mistakenly populating an all-zero state object instead of recognizing a return of 0 as special | 13:03 |
| kashyap | 14:45 <@eblake> but it is normal for no state to be available when the job is complete (maybe future libvirt could track that a job has finished and provide state even when qemu didn't report any, but that wouldn't help you with current libvirt) | 13:03 |
| * kashyap is going to file an upstream libvirt bug to track the above behavior, so they can triage it properly | 13:03 | |
| mdbooth | kashyap: I've read the libvirt-python code which does this twice recently | 13:04 |
| mdbooth | First time I missed the difference between returning -1 and 0 | 13:04 |
| mdbooth | So, if virDomainGetBlockJobInfo returns -1, the python call returns None | 13:04 |
| mdbooth | If it return 0, it returns an empty dict | 13:04 |
| mdbooth | If it returns 1, it returns a fully populated dict | 13:04 |
| mdbooth | i.e. it's never partially populated, but it can be empty | 13:05 |
| mdbooth | My proposal in the get_job_info patch was that we map that to (exception, None, dict) | 13:05 |
| *** lucas-bbl is now known as lucasagomes | 13:05 | |
| *** baoli has quit IRC | 13:06 | |
| kashyap | mdbooth: Your proposal sounds super clear | 13:06 |
| *** niedbalski_ is now known as niedbalski | 13:06 | |
| *** niedbalski has quit IRC | 13:06 | |
| *** niedbalski has joined #openstack-nova | 13:06 | |
| mdbooth | kashyap: However, if we handled the COMPLETED job instead, this would also clear up the workaround for cur=0, end=0 | 13:06 |
| kashyap | And, accurately maps to the libvirt API | 13:06 |
| *** pbandark has joined #openstack-nova | 13:06 | |
| mdbooth | s/job/event/ | 13:06 |
| *** rlrossit has joined #openstack-nova | 13:06 | |
| *** liverpooler has quit IRC | 13:07 | |
| eantyshev | mdbooth: kashyap: and also to know the job result | 13:07 |
| frickler | could some bug admin take a look at https://bugs.launchpad.net/nova/+bug/1597596 ? it seems rather stuck to me than in progress. I'm also wondering whether I should add a new bug for "rescheduled instances get duplicate addresses assigned" | 13:07 |
| openstack | Launchpad bug 1597596 in OpenStack Compute (nova) "network not always cleaned up when spawning VMs" [Medium,In progress] - Assigned to Aihua Edward Li (aihuaedwardli) | 13:07 |
| kashyap | mdbooth: I'm not quite sure, if that fixes it. Let me see: | 13:07 |
| mdbooth | kashyap: Is it possible that the same bug that produces it also prevent libvirt from sending the event? | 13:08 |
| mdbooth | That would suck. | 13:08 |
| kashyap | mdbooth: This is what the Git in master libvirt says: | 13:08 |
| kashyap | If qemu reports 0/0 and "ready":false, then libvirt should report cur=0, end=1 (that is, we fudge the end to be larger, because the job is not done yet). | 13:08 |
| *** jamesdenton has joined #openstack-nova | 13:08 | |
| kashyap | mdbooth: No, I don't think it's the same bug | 13:08 |
| mdbooth | kashyap: The question is whether the COMPLETED event was sent anyway, thouhg. | 13:08 |
| kashyap | mdbooth: If Nova is not actively montoring for the event, then no way it could capture it, IIUC. | 13:09 |
| mdbooth | kashyap: Sure, we'd have to monitor for it. | 13:09 |
| kashyap | mdbooth: No, it won't be sent | 13:09 |
| *** mtanino has quit IRC | 13:09 | |
| *** hshiina has quit IRC | 13:09 | |
| openstackgerrit | Yingxin Cheng proposed openstack/nova: [POC][placement] Amend r-p/{uuid}/traits PUT to support os-traits https://review.openstack.org/378601 | 13:09 |
| mdbooth | Ah, so even if we were monitoring, we still wouldn't get the event? | 13:09 |
| kashyap | mdbooth: Right, in the case of 0/0. | 13:10 |
| mdbooth | Hmm | 13:10 |
| kashyap | me 's brain is hurting, can he go have quick a late lunch? BBIAB | 13:11 |
| mdbooth | eantyshev: Incidentally, were you able to join #virt? | 13:11 |
| *** ljxiash has joined #openstack-nova | 13:11 | |
| eantyshev | mdbooth: sorry, was looking into the code | 13:11 |
| *** claudiub has joined #openstack-nova | 13:12 | |
| *** psachin has quit IRC | 13:12 | |
| *** alexchadin has joined #openstack-nova | 13:12 | |
| kashyap | mdbooth: Also, if you want play around with the event `virsh qemu-monitor-event` is hooked to monitor events -- https://kashyapc.fedorapeople.org/virt/virsh-qemu-monitor-event.txt | 13:12 |
| kashyap | The above is the same blockRebase() test, and monitoring for the event on a different shell | 13:12 |
| *** Guest2018 is now known as beagles | 13:13 | |
| *** READ10 has joined #openstack-nova | 13:13 | |
| *** vladikr has joined #openstack-nova | 13:13 | |
| *** woodster_ has joined #openstack-nova | 13:13 | |
| *** eantyshev has left #openstack-nova | 13:14 | |
| *** eantyshev has joined #openstack-nova | 13:14 | |
| *** cmartin has joined #openstack-nova | 13:15 | |
| *** takedakn has quit IRC | 13:17 | |
| *** aswadr_ has joined #openstack-nova | 13:18 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova: HyperV: use os-brick for volume related operations https://review.openstack.org/273504 | 13:18 |
| *** psachin has joined #openstack-nova | 13:19 | |
| *** jaosorior has quit IRC | 13:20 | |
| *** ducttape_ has joined #openstack-nova | 13:20 | |
| *** jaosorior has joined #openstack-nova | 13:21 | |
| *** salv-orlando has quit IRC | 13:21 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: console: introduce basic framework for security proxying https://review.openstack.org/345396 | 13:22 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: console: introduce framework for RFB authentication https://review.openstack.org/345397 | 13:22 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398 | 13:22 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: console: provide an RFB security proxy implementation https://review.openstack.org/345399 | 13:22 |
| *** tbachman has joined #openstack-nova | 13:23 | |
| kashyap | mdbooth: Are you still wondering: "Why doesn't the BLOCK_JOB_COMPLETED event sent when cur =0, end=0? | 13:24 |
| kashyap | " | 13:24 |
| *** ducttape_ has quit IRC | 13:25 | |
| kashyap | If so, might want to re-read the commit message here - http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=988218c | 13:26 |
| *** mat128|afk is now known as mat128 | 13:27 | |
| *** ftersin has joined #openstack-nova | 13:28 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Add a post-test-hook to run the archive command https://review.openstack.org/376567 | 13:29 |
| mdbooth | kashyap: There's an implication in that commit: | 13:29 |
| mdbooth | "Apparently, some management applications use the following code | 13:29 |
| mdbooth | pattern when waiting for a block job to finish" | 13:29 |
| mdbooth | -> "some management applications are doing it wrong" ;) | 13:29 |
| macsz | sfinucan: do you remember the duration of deprecation? was it 2 or 3 releases? | 13:32 |
| dansmith | sdague: your change here doesn't let us see the result right? https://review.openstack.org/#/c/376567/9/tools/hooks/post_test_hook.sh | 13:32 |
| mdbooth | eantyshev: So, it sounds to me like, except in the abort case, we *can* assume that no job == completion. Although not necessarily successful completion. | 13:32 |
| sdague | dansmith: with the -x, it might | 13:32 |
| sdague | I was trying to figure out what it would look like | 13:32 |
| dansmith | sdague: not formatted I think | 13:33 |
| kashyap | mdbooth: :-) Yeah | 13:33 |
| sdague | that's possible | 13:33 |
| sdague | dansmith: trying to just get a good run on it, after my syntax error screw up to see | 13:33 |
| dansmith | alright | 13:33 |
| *** alexchadin has quit IRC | 13:33 | |
| mdbooth | eantyshev: So if you wanted to push ahead with that simpler patch I wouldn't be opposed. | 13:33 |
| sdague | turns out, we needed a 4th run to get the instances | 13:33 |
| sdague | but it would be nice to make sure we got to the end, but don't just idle loop | 13:34 |
| *** alexchadin has joined #openstack-nova | 13:34 | |
| mdbooth | However, I'd prefer that you cleaned up the comments around wait_for_job_clean with the updated context. | 13:34 |
| dansmith | yep, well, I had no idea until it wouldrun once | 13:34 |
| sdague | dansmith: yep, definitely | 13:34 |
| mdbooth | But... it still sounds to me as though processing the job event is the correct solution. | 13:34 |
| mdbooth | So if you wanted to do that I'd be delighted. | 13:34 |
| sdague | the reservations count was much higher than I anticipated, really handy to see what's in there in soft delete state | 13:35 |
| dansmith | sdague: yeah in derekh's sample db, there were many many thousands of records like that before I ever got to any meat | 13:36 |
| dansmith | somewhat eye-opening | 13:36 |
| sdague | yep | 13:36 |
| *** tongli has joined #openstack-nova | 13:37 | |
| *** links has quit IRC | 13:38 | |
| *** gaurangt has joined #openstack-nova | 13:38 | |
| *** moshele has quit IRC | 13:39 | |
| *** tonytan4ever has joined #openstack-nova | 13:40 | |
| *** bogdan has joined #openstack-nova | 13:40 | |
| alaski | mriedem: dansmith there's a pretty big bug with cellsv2 that was reported to me this morning, reschedules are broken. I have a fix put together and am writing a bug report now | 13:42 |
| bogdan | is there any description of nova boot behavior when both volume snapshot and image are provided? we observe some kind of merge when we do so, but we have no idea what exactly happens. Is this legal combination? what should we expect to have at the end on the filesystem? | 13:42 |
| dansmith | alaski: okay | 13:42 |
| alaski | I'll backport to stable/newton as well. just am not sure if it's worth looking at an RC<whatever> or if we're past that period | 13:43 |
| mriedem | alaski: ok we haven't cut rc2 yet | 13:43 |
| alaski | ahh, okay | 13:43 |
| mriedem | deadline is eod tomorrow for rc2 | 13:43 |
| mriedem | but that's pretty damn close, so i'd like to see it in by eod today | 13:43 |
| *** eharney has joined #openstack-nova | 13:43 | |
| *** alexchadin has quit IRC | 13:44 | |
| alaski | https://bugs.launchpad.net/nova/+bug/1628530 | 13:47 |
| openstack | Launchpad bug 1628530 in OpenStack Compute (nova) "Rescheduling an instance leaves it in a scheduling state and never succeeds" [Critical,New] - Assigned to Andrew Laski (alaski) | 13:47 |
| *** xyang1 has joined #openstack-nova | 13:47 | |
| *** vnogin has quit IRC | 13:47 | |
| bogdan | any idea about the boot behavior? I do not want to go through the code really :) | 13:48 |
| *** bdeschenes has joined #openstack-nova | 13:48 | |
| *** gaurangt has left #openstack-nova | 13:48 | |
| *** liusheng has quit IRC | 13:49 | |
| *** ducttape_ has joined #openstack-nova | 13:49 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Ignore BuildRequest during an instance reschedule https://review.openstack.org/378636 | 13:51 |
| alaski | dansmith: mriedem ^ | 13:51 |
| *** liusheng has joined #openstack-nova | 13:52 | |
| alaski | although, I need to run a full test run locally | 13:52 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: fix DiskSmallerThanImage when block migrate ephemerals https://review.openstack.org/378560 | 13:53 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: fix uncaugth exception during soft reboot https://review.openstack.org/376350 | 13:53 |
| bauzas | alaski: IMHO, you should rather look at the filter properties to know whether the instance is rescheduled | 13:58 |
| alaski | bauzas: sure. what in particular? | 13:58 |
| bauzas | alaski: the scheduler_utils.populate_retry() call should update it | 13:59 |
| *** mtanino has joined #openstack-nova | 13:59 | |
| bauzas | alaski: lemme look which field in particular, sec | 13:59 |
| bauzas | alaski: tbh, I'm trying to remember whether the ReqSpec is updated too | 14:00 |
| bogdan | please, give a hint on boot behavior, I tried to google but nothing to explain this scenario - when both volume snapshot and image are provided | 14:00 |
| *** anush has joined #openstack-nova | 14:00 | |
| *** andymaier has joined #openstack-nova | 14:01 | |
| *** hoangcx has joined #openstack-nova | 14:01 | |
| alaski | bauzas: filter_properties['retry']['num_attempts'] > 1? | 14:01 |
| bauzas | alaski: yeah | 14:02 |
| bauzas | alaski: because we're passing down filter_props to the compute service | 14:02 |
| bauzas | alaski: and then the callback uses the same dict | 14:02 |
| bauzas | alaski: just verify it in your test, but AFAIK, num_attempts will be 2 | 14:02 |
| bauzas | (in case of a reschedule) | 14:03 |
| bauzas | alaski: ideally, I would like to pass down the ReqSpec object to the compute service, but that's not merged yet | 14:03 |
| bauzas | for the moment, we're only passing dicts | 14:03 |
| bauzas | mriedem: FWIW, do I need to add a blueprint (and a spec) for asking to implement passing the RequestSpec object down to the compute service? | 14:04 |
| *** mtanino has quit IRC | 14:04 | |
| mriedem | to use it how? | 14:05 |
| bauzas | we have a couple of RPC interfaces that need to be cleaned up as well, like removing the old fields now that we're in Ocata | 14:05 |
| bauzas | mriedem: we're passing the old filter_props dict | 14:05 |
| mriedem | does it fix any bugs? or just technical debt cleanup? | 14:06 |
| bauzas | mriedem: in the conductor, we're getting a ReqSpec object (either created here, or passed by the API) but we're deshydrating it into a dict before calling the compute node | 14:06 |
| bauzas | mriedem: rather tech debty | 14:06 |
| bauzas | a cleanup task yeah | 14:06 |
| mriedem | i think a specless bp is probably good | 14:06 |
| bauzas | okay, I'll write it, and we could discuss that later on in a meeting or whatever else | 14:07 |
| *** efried has joined #openstack-nova | 14:07 | |
| bauzas | mriedem: thanks | 14:07 |
| eantyshev | mdbooth: if nobody objects, I would want https://review.openstack.org/#/c/375652/ to be applied | 14:08 |
| eantyshev | mdbooth: because we need this for our CI | 14:08 |
| *** kaisers has quit IRC | 14:09 | |
| mdbooth | eantyshev: Ok, as above I'm ok with that, but can you please change the docs on wait_for_job_clean. | 14:09 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Ignore BuildRequest during an instance reschedule https://review.openstack.org/378636 | 14:10 |
| mdbooth | eantyshev: As we now have a better understanding as to what it's for. | 14:10 |
| *** haplo37_ has quit IRC | 14:10 | |
| mdbooth | And that's not what's documented :) | 14:10 |
| *** anush has quit IRC | 14:10 | |
| *** gsilvis has quit IRC | 14:11 | |
| *** rrecio has joined #openstack-nova | 14:11 | |
| eantyshev | mdbooth: so, I'm going to remove that note for RH bug #1119173 | 14:12 |
| openstack | bug 1119173 in A SYLEAM Module - PDI Connector 7.0 "Display Job and Transformation step in OpenERP" [Wishlist,Confirmed] https://launchpad.net/bugs/1119173 - Assigned to Christophe CHAUVET (christophe-chauvet) | 14:12 |
| *** haplo37_ has joined #openstack-nova | 14:13 | |
| mdbooth | eantyshev: Wait a sec... | 14:13 |
| * mdbooth checks the other call site | 14:13 | |
| * mdbooth checks git history looking for a nova bug | 14:14 | |
| edleafe | bauzas: how about adding it to the scheduler meeting agenda? We could divide up the cleanup work and get it done quicker | 14:15 |
| *** tanvirt has joined #openstack-nova | 14:15 | |
| *** rrecio has quit IRC | 14:15 | |
| bauzas | edleafe: the main problem I see with that is that the contributors need to know all the RequestSpec uses we have atm | 14:16 |
| bauzas | edleafe: and where those objects are dehydrated and where they're just recreated | 14:16 |
| bauzas | edleafe: and also knowing where reschedules happen | 14:17 |
| bauzas | eg. some API move operations are rescheduling (and passing it back the object), some not | 14:17 |
| edleafe | bauzas: multiple people working on that will spread that knowledge to more people, don't you think? | 14:17 |
| *** anush has joined #openstack-nova | 14:17 | |
| *** kaisers has joined #openstack-nova | 14:17 | |
| bauzas | edleafe: sure, but that will mean more PSes IMHO | 14:18 |
| edleafe | bauzas: and reviews (especially from you) will be very helpful | 14:18 |
| bauzas | edleafe: lemme think about that, maybe an etherpad for working on that could be helpful | 14:18 |
| edleafe | bauzas: sounds goods | 14:18 |
| edleafe | good, even | 14:18 |
| sfinucan | macsz: You deprecate in one version (say, N) and remove in the next (M) | 14:18 |
| bauzas | edleafe: but I agree it's tribal knowledge that I would love to share | 14:19 |
| sfinucan | macsz: So if we deprecated an option in '14.0.0' then we can remove now (pre-15.0.0) | 14:19 |
| sfinucan | at least that's my take on the situation | 14:19 |
| edleafe | bauzas: I think that would be very helpful | 14:19 |
| *** salv-orlando has joined #openstack-nova | 14:20 | |
| mriedem | sfinucan: https://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html | 14:20 |
| mdbooth | eantyshev: See change Ib4d65e8812c7d3c28100155124218c75a94e16e7 | 14:22 |
| *** prateek_ has quit IRC | 14:22 | |
| mdbooth | That introduced wait_for_job_clean | 14:22 |
| raj_singh | macsz: sfinucan It has to be deprecated for 90 days before removal | 14:22 |
| mdbooth | eantyshev: There's no mention in that commit of why that was added. | 14:23 |
| mdbooth | I think that commit is the source of confusion here. | 14:23 |
| *** hamzy has quit IRC | 14:23 | |
| macsz | ok, i got confused | 14:23 |
| sfinucan | raj_singh: so there's a time aspect too? I didn't know that | 14:23 |
| mdbooth | eantyshev: Given what we know now, wait_for_job_clean should *always* be True | 14:23 |
| mdbooth | eantyshev: IoW we should just remove it everywhere. | 14:23 |
| raj_singh | sfinucan: yes | 14:24 |
| eantyshev | mdbooth: with an exception for _swap_volume f.e. | 14:24 |
| mdbooth | eantyshev: Why would we want an exception there? | 14:24 |
| eantyshev | mdbooth: drive mirroring sequence implies job termination after cur==end state is reached | 14:25 |
| *** sudipto has joined #openstack-nova | 14:25 | |
| *** sudipto_ has joined #openstack-nova | 14:25 | |
| mdbooth | wait_for_job_clean has nothing to do with cur==end, though | 14:25 |
| mdbooth | It means we should assume the job has completed if it no longer exists | 14:25 |
| eantyshev | mdbooth: and? | 14:25 |
| mdbooth | Which is always true by our new understanding. | 14:25 |
| *** tjones has joined #openstack-nova | 14:26 | |
| kashyap | Correct | 14:26 |
| *** bks has joined #openstack-nova | 14:27 | |
| eantyshev | mdbooth: this isn't so for drive mirroring, again. Job is hanging in cur==end until terminated with special flag | 14:27 |
| *** yamahata has joined #openstack-nova | 14:27 | |
| kashyap | eantyshev: No, don't remove reference to that RHBZ in wait_for_job() | 14:28 |
| *** gsilvis has joined #openstack-nova | 14:28 | |
| *** diablo_rojo has joined #openstack-nova | 14:28 | |
| kashyap | It is fixed only in upstream Git master. And to have that libvirt version as minimum in Nova, it'll take a couple of years | 14:28 |
| kashyap | (Git master of libvirt, ie.) | 14:28 |
| *** tjones has left #openstack-nova | 14:28 | |
| eantyshev | mdbooth, kashyap: it's going to be like: http://paste.openstack.org/show/583313/ | 14:29 |
| mdbooth | eantyshev: TBH, I'd prefer to see you rebase this on top of the changes to get_job_info in the other patch. | 14:30 |
| *** sudipto has quit IRC | 14:30 | |
| *** sudipto_ has quit IRC | 14:30 | |
| *** baoli_ has quit IRC | 14:31 | |
| mdbooth | Because right now we're not correctly handling the 'job doesn't exist' case. | 14:31 |
| * kashyap clicks | 14:31 | |
| mriedem | sdague: dansmith: the duplicate $out tracing here is ugly http://logs.openstack.org/13/377113/8/check/gate-grenade-dsvm-neutron-ubuntu-xenial/1bf52c8/logs/devstack-gate-post_test_hook.txt.gz | 14:31 |
| mriedem | we should send that to dev/null i think | 14:31 |
| mdbooth | Libvirt is telling us the job doesn't exist by returning an empty dict from blockJobInfo() | 14:31 |
| *** baoli has joined #openstack-nova | 14:31 | |
| John341 | hi everyone. my nova live-migration for rhel7/centos7 VMs fail on liberty with this error, can anyone pls help? WARNING nova.compute.manager [instance: cd0b605d] Instance shutdown by itself. Calling the stop API. Current vm_state: active, current task_state: None, original DB power_state: 4, current VM power_state: 4 | 14:31 |
| dansmith | mriedem: can't | 14:31 |
| mriedem | however, we don't get the verbose output then at all... | 14:31 |
| mdbooth | But we're ignoring it and returning fake values in a BlockDeviceJobInfo | 14:31 |
| mriedem | yeah | 14:32 |
| dansmith | mriedem: because it's the tracing | 14:32 |
| kashyap | eantyshev: Is there a hurry here? I realize you may need it in Virtuozzo CI, but also consider for the benefit of broader upstream | 14:32 |
| John341 | I get that error on the destination host, logged in console users on the vm freeze too | 14:32 |
| dansmith | mriedem: can we get the testing landed and worry about the output later? as long as we're seeing it... | 14:32 |
| mriedem | it must be PERFECT | 14:32 |
| eantyshev | mdbooth, kashyap: that patch for wait_for_job is going to take some time | 14:32 |
| mdbooth | eantyshev kashyap: I think these 2 things are really simple to do. No major code changes required at all. | 14:32 |
| John341 | For other OS, Win2012R2 and Ubuntu1404 live-migration works. | 14:32 |
| mdbooth | eantyshev: Why? | 14:32 |
| *** muawiak__ has quit IRC | 14:33 | |
| *** lennyb has quit IRC | 14:34 | |
| dansmith | mriedem: I have an idea of how to make it cleaner actually | 14:34 |
| eantyshev | mdbooth: because it's not ready | 14:34 |
| mdbooth | eantyshev: But it can be ready trivially, right? | 14:34 |
| sdague | dansmith: what about making a different return code when the command runs and doesn't have anything to archive? | 14:34 |
| sdague | which would make it easy to loop and know to stop | 14:34 |
| mdbooth | I'm pretty sure either of us could do it in under an hour. | 14:34 |
| dansmith | sdague: yeah, I said I was going to work on that | 14:34 |
| sdague | dansmith: oh, ok, I didn't realize that | 14:35 |
| eantyshev | mdbooth: I'm not a hurry, then | 14:35 |
| sdague | so if that's coming, we could just go back to version before the output capture | 14:35 |
| dansmith | mriedem: sdague I'll fix up this script in the patch that fixes that | 14:35 |
| sdague | realize it's going to add a minute to the placement runs, but that will get better, and move on | 14:35 |
| *** tblakes has quit IRC | 14:36 | |
| *** muawiakhan has joined #openstack-nova | 14:36 | |
| *** sudipto has joined #openstack-nova | 14:37 | |
| kashyap | eantyshev: Also, want to expand the description about the exception with a one-line summary, for future readers of the code | 14:37 |
| *** sudipto_ has joined #openstack-nova | 14:37 | |
| *** baoli has quit IRC | 14:38 | |
| *** dikonoo has quit IRC | 14:39 | |
| eantyshev | kashyap: right | 14:39 |
| *** annegentle has joined #openstack-nova | 14:41 | |
| *** hshiina has joined #openstack-nova | 14:42 | |
| dansmith | sdague: so are you going to +W what's there so we can get the project config change in the queue? | 14:44 |
| dansmith | in a bit I'll work on the result code and the --until-finished option | 14:44 |
| pbandark | ping mriedem, https://bugs.launchpad.net/nova/+bug/1334398 is only applicable for libvirt 1.2.2 version ? | 14:44 |
| openstack | Launchpad bug 1334398 in OpenStack Compute (nova) "libvirt live_snapshot periodically explodes on libvirt 1.2.2 in the gate" [Undecided,Confirmed] | 14:44 |
| *** burgerk has joined #openstack-nova | 14:45 | |
| mriedem | pbandark: we don't know | 14:45 |
| mriedem | pbandark: that's why we have https://review.openstack.org/#/c/373430/ | 14:45 |
| sdague | dansmith: sure, I wasn't clear if you were still iterating on it | 14:46 |
| sdague | +W | 14:46 |
| dansmith | sdague: I'm going to follow up.. I just want the first thing in so we can get the project-config change in and then we can iterate without the double patch chain | 14:46 |
| dansmith | thanks | 14:46 |
| sdague | yep, no prob | 14:46 |
| pbandark | ping kashyap any idea ^^ | 14:46 |
| kashyap | pbandark: Hi, as mriedem pointed out, upstream is still enabling it | 14:47 |
| kashyap | And, see what comes through from CI failures. | 14:47 |
| *** mlavalle has joined #openstack-nova | 14:48 | |
| *** rlrossit has quit IRC | 14:49 | |
| pbandark | ok mriedem kashyap | 14:49 |
| *** tjones has joined #openstack-nova | 14:49 | |
| openstackgerrit | Diana Clarke proposed openstack/nova: EventReporterStub https://review.openstack.org/378679 | 14:51 |
| *** muawiakhan has quit IRC | 14:52 | |
| *** rlrossit has joined #openstack-nova | 14:53 | |
| *** Swami has joined #openstack-nova | 14:53 | |
| *** _ducttape_ has joined #openstack-nova | 14:54 | |
| *** kmartin has joined #openstack-nova | 14:54 | |
| *** ekuris has quit IRC | 14:56 | |
| *** Vijayendra has quit IRC | 14:56 | |
| *** ducttape_ has quit IRC | 14:57 | |
| *** hamzy has joined #openstack-nova | 14:57 | |
| *** rmart04 has quit IRC | 14:58 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Restore V3 Diagnostics info https://review.openstack.org/357884 | 14:59 |
| *** kfarr has joined #openstack-nova | 15:00 | |
| *** armax has joined #openstack-nova | 15:01 | |
| openstackgerrit | Diana Clarke proposed openstack/nova: EventReporterStub https://review.openstack.org/378679 | 15:01 |
| *** marst has joined #openstack-nova | 15:02 | |
| *** andreas_s has quit IRC | 15:02 | |
| *** artom has quit IRC | 15:03 | |
| *** mjura has quit IRC | 15:03 | |
| *** lennyb has joined #openstack-nova | 15:03 | |
| *** rcernin has quit IRC | 15:04 | |
| *** artom has joined #openstack-nova | 15:04 | |
| *** jlanoux has quit IRC | 15:05 | |
| *** coreywright has quit IRC | 15:06 | |
| *** Swami_ has joined #openstack-nova | 15:06 | |
| *** tonytan_brb has joined #openstack-nova | 15:06 | |
| *** kfarr has quit IRC | 15:08 | |
| *** danpb has quit IRC | 15:08 | |
| *** ayoung_ has joined #openstack-nova | 15:09 | |
| *** Swami has quit IRC | 15:09 | |
| openstackgerrit | Gleb Stepanov proposed openstack/nova: Add _rebuild_instance helper method https://review.openstack.org/376004 | 15:09 |
| *** tonytan4ever has quit IRC | 15:09 | |
| *** roeyc has quit IRC | 15:10 | |
| *** ayoung_ is now known as ayoung | 15:11 | |
| *** adisky has quit IRC | 15:12 | |
| *** ljxiash has quit IRC | 15:12 | |
| *** ashyoung has joined #openstack-nova | 15:12 | |
| *** mamandle has quit IRC | 15:13 | |
| *** cmartin has quit IRC | 15:14 | |
| *** ldeptula has quit IRC | 15:14 | |
| *** amotoki has quit IRC | 15:16 | |
| *** coreywright has joined #openstack-nova | 15:19 | |
| *** zz_dimtruck is now known as dimtruck | 15:19 | |
| *** lucasagomes is now known as lucas-hungry | 15:22 | |
| *** dikonoo has joined #openstack-nova | 15:22 | |
| *** yamahata has quit IRC | 15:22 | |
| *** danpb has joined #openstack-nova | 15:22 | |
| *** xek__ has joined #openstack-nova | 15:23 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Fix drop_move_claim() on revert resize https://review.openstack.org/349060 | 15:23 |
| *** xek_ has quit IRC | 15:25 | |
| *** burt has joined #openstack-nova | 15:25 | |
| mriedem | melwitt: in https://review.openstack.org/#/c/377093/1/nova/rpc.py is there a reason we use an empty context instead of an admin context? | 15:25 |
| mriedem | like how we run other periodic tasks? | 15:26 |
| *** artom has quit IRC | 15:26 | |
| *** _ducttape_ has quit IRC | 15:26 | |
| *** artom has joined #openstack-nova | 15:27 | |
| *** nkrinner is now known as nkrinner_afk | 15:27 | |
| *** ducttape_ has joined #openstack-nova | 15:27 | |
| *** artom has quit IRC | 15:27 | |
| *** apuimedo is now known as apuimedo|away | 15:27 | |
| *** rfolco_ has quit IRC | 15:27 | |
| *** artom has joined #openstack-nova | 15:27 | |
| bogdan | please, give a hint on boot behavior, I tried to google but nothing to explain this scenario - when both volume snapshot and image are provided | 15:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Remove stale pyc files when running the cover job https://review.openstack.org/378706 | 15:28 |
| *** mdrabe has joined #openstack-nova | 15:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Modify 'disable_libvirt_livesnapshot' https://review.openstack.org/378710 | 15:30 |
| *** kfarr has joined #openstack-nova | 15:31 | |
| *** baoli has joined #openstack-nova | 15:31 | |
| *** rfolco_ has joined #openstack-nova | 15:31 | |
| mriedem | alaski: dansmith: do you know why we use an empty request context here? https://review.openstack.org/#/c/377093/1/nova/rpc.py | 15:33 |
| dansmith | mriedem: melwitt said something to me about that the other day | 15:34 |
| alaski | mriedem: what would be it be populated with? | 15:34 |
| dansmith | mriedem: I nodded to act like I understood | 15:34 |
| *** efried has quit IRC | 15:34 | |
| mriedem | alaski: the other periodic tasks are run with the admin context | 15:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make db archival return a meaningful result code https://review.openstack.org/378717 | 15:34 |
| openstackgerrit | Dan Smith proposed openstack/nova: Allow running db archiving continuously https://review.openstack.org/378718 | 15:34 |
| alaski | mriedem: that's because everyone sees that there's a helper method to create an admin context and uses it | 15:35 |
| alaski | there's nothing in the rpc periodic task that needs an admin context | 15:35 |
| *** ihrachys has joined #openstack-nova | 15:36 | |
| alaski | mriedem: is it causing an issue? | 15:37 |
| mriedem | or an empty context for that matter | 15:37 |
| mriedem | as far as i can tell | 15:37 |
| mriedem | well, the empty context didn't have overwrite=False | 15:37 |
| mriedem | which get_admin_context() would have | 15:37 |
| *** andymaier has quit IRC | 15:37 | |
| mriedem | she has the fix for it, i was just wondering why we didn't do the same as the other periodic tasks things in nova.service from the get-go | 15:38 |
| *** tblakes has joined #openstack-nova | 15:38 | |
| sdague | is there a reason it defaults the other way? | 15:38 |
| alaski | I complained about the unnecessary use of get_admin_context | 15:38 |
| *** ihrachys has quit IRC | 15:39 | |
| *** bks has quit IRC | 15:39 | |
| *** ihrachys has joined #openstack-nova | 15:39 | |
| *** bks has joined #openstack-nova | 15:39 | |
| *** dimtruck is now known as zz_dimtruck | 15:40 | |
| alaski | mriedem: the only reason to have the context there afaict is that it provides a request-id for logging | 15:40 |
| *** efried has joined #openstack-nova | 15:41 | |
| alaski | mriedem: https://github.com/testing-cabal/mock/blob/master/mock/mock.py#L908 | 15:41 |
| mriedem | gah | 15:43 |
| mriedem | gdi mock lib | 15:43 |
| *** hoangcx has quit IRC | 15:43 | |
| alaski | heh | 15:43 |
| mriedem | alaski: still shouldn't you use assert_called_once_with since that will work with py3? | 15:43 |
| mriedem | i'm actually confused, if you're on py3, and you import mock, what gets imported? | 15:44 |
| mriedem | the lib or stdlib package? | 15:44 |
| alaski | yeah, I'm going to switch it over. I just don't care what it's called with in this test so I didn't want to go to the trouble | 15:44 |
| alaski | mriedem: *shrug* | 15:44 |
| *** jlanoux has joined #openstack-nova | 15:44 | |
| *** kfarr has quit IRC | 15:45 | |
| alaski | https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_with | 15:45 |
| *** Guest75624 is now known as BobBall | 15:45 | |
| alaski | gdi wrong one | 15:46 |
| * dansmith sees alaski is on the "gdi bandwagon" | 15:46 | |
| *** Vijayendra has joined #openstack-nova | 15:46 | |
| sdague | mriedem: it looks like mock lib is mirroring latest python | 15:46 |
| sdague | that's in python 3.6 | 15:47 |
| alaski | dansmith: I suppose it gets to us all eventually | 15:47 |
| dansmith | yep | 15:47 |
| *** kumarb has joined #openstack-nova | 15:48 | |
| mriedem | well gfdi | 15:48 |
| *** bks has quit IRC | 15:48 | |
| bauzas | dansmith: mriedem: I did -1 https://review.openstack.org/#/c/375873/ because I thought Mitaka was becoming Phase-II once Newton becomes the phase-I stable | 15:48 |
| bauzas | dansmith: given you did https://review.openstack.org/#/c/378650/ I wonder if that should also be applicable to it ? | 15:49 |
| *** bogdan has quit IRC | 15:49 | |
| dansmith | bauzas: well, rules be damned, I think we need to backport that archive fix regardless | 15:49 |
| dansmith | bauzas: but .. newton is not phase 1 yet, right? | 15:49 |
| mriedem | no | 15:50 |
| mriedem | http://docs.openstack.org/project-team-guide/stable-branches.html#support-phases | 15:50 |
| dansmith | also, | 15:50 |
| dansmith | the archive change isn't in production code, which makes it really low risk | 15:50 |
| bauzas | dansmith: that's a question about when newton becomes phase-1, ie. after we GA it right? | 15:50 |
| dansmith | and, we know it's really broken | 15:50 |
| bauzas | dansmith: sure, I think it's okay to merge your change, I just wonder about the process | 15:50 |
| *** kumarb has quit IRC | 15:50 | |
| *** mdrabe has quit IRC | 15:51 | |
| bauzas | some of our contributors now create both backports for newton and mitaka | 15:51 |
| *** mdrabe has joined #openstack-nova | 15:51 | |
| bauzas | in case the change was merged after newton-1, ie. an ocata way | 15:51 |
| *** bks has joined #openstack-nova | 15:51 | |
| openstackgerrit | ianeta hutchinson proposed openstack/nova: Removes trailing bullet point symbol from CLI commands list. https://review.openstack.org/378731 | 15:52 |
| bauzas | mriedem: dansmith: not sure you understand my point, I mean : does that mean that once Newton general release is done, then Newton becomes phase-1 and mitaka phase-2 ? | 15:52 |
| dansmith | bauzas: I think it's technically 6 months after the release, unrelated to newton | 15:53 |
| dansmith | bauzas: also, the process says we can backport anything we want if we're confident, | 15:53 |
| dansmith | we're just not committed to any more | 15:53 |
| bauzas | mmm okay :) | 15:55 |
| *** coreycb has joined #openstack-nova | 15:55 | |
| coreycb | lxsli, hi can you restore this patch? https://review.openstack.org/#/c/307021/ | 15:56 |
| sdague | dansmith / alaski / mriedem - merged - https://review.openstack.org/#/c/376537/6 | 15:56 |
| *** aries_ has joined #openstack-nova | 15:56 | |
| coreycb | it's valid for xenial python-novaclient against newton+ nova deployments | 15:56 |
| coreycb | s/xenial/mitaka | 15:56 |
| dansmith | sdague: woot, thanks | 15:57 |
| alaski | sdague: awesome | 15:57 |
| dansmith | sdague: I will rebase my followups to get them to show it | 15:57 |
| sdague | dansmith: cool | 15:57 |
| openstackgerrit | Dan Smith proposed openstack/nova: Allow running db archiving continuously https://review.openstack.org/378718 | 15:57 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make db archival return a meaningful result code https://review.openstack.org/378717 | 15:57 |
| *** unicell1 has joined #openstack-nova | 15:58 | |
| sdague | I abandoned the d-g DNM change, because now we can just get patches proposed and get results off them in the normal way | 15:58 |
| dansmith | yup cool | 15:58 |
| lxsli | coreycb: sure go for it | 15:58 |
| coreycb | lxsli, it's all set thanks | 15:59 |
| *** tonytan_brb is now known as tonytan4ever | 15:59 | |
| *** kfarr has joined #openstack-nova | 16:00 | |
| *** unicell has quit IRC | 16:00 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix BlockDevice.wait_for_job when qemu reports no job https://review.openstack.org/378746 | 16:00 |
| mdbooth | eantyshev: Can you check out ^^^ ? | 16:00 |
| mdbooth | I think that also fixes your problem. | 16:00 |
| *** slaweq_ has joined #openstack-nova | 16:01 | |
| *** krtaylor has quit IRC | 16:01 | |
| *** moshele has joined #openstack-nova | 16:02 | |
| *** tbachman has quit IRC | 16:02 | |
| *** lamt has joined #openstack-nova | 16:03 | |
| *** ashyoung has quit IRC | 16:03 | |
| mriedem | sdague: mock.assert_called_once() is in python 3.6 yeah, but we test against 3.4 and 3.5 | 16:04 |
| *** mtanino has joined #openstack-nova | 16:04 | |
| mdbooth | eantyshev: Is there any way I can get your CI to vote on that patch, btw? | 16:06 |
| *** ijw has joined #openstack-nova | 16:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/378070 | 16:08 |
| *** winston-d_ has joined #openstack-nova | 16:09 | |
| *** rlrossit has quit IRC | 16:09 | |
| *** tbachman has joined #openstack-nova | 16:09 | |
| *** rrecio has joined #openstack-nova | 16:09 | |
| *** eliqiao has quit IRC | 16:10 | |
| *** stewie925 has joined #openstack-nova | 16:10 | |
| openstackgerrit | Lucian Petrut proposed openstack/nova: HyperV: use os-brick for volume related operations https://review.openstack.org/273504 | 16:11 |
| *** moshele has quit IRC | 16:11 | |
| *** browne has joined #openstack-nova | 16:11 | |
| *** Yingxin has quit IRC | 16:11 | |
| *** thorst_ has joined #openstack-nova | 16:11 | |
| *** thorst has quit IRC | 16:13 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Ignore BuildRequest during an instance reschedule https://review.openstack.org/378636 | 16:13 |
| *** tbachman_ has joined #openstack-nova | 16:14 | |
| kashyap | mdbooth: Nice work. your is_block_job_complete() method is much clearer | 16:14 |
| mdbooth | kashyap: It's clearer in my head, at least :) | 16:15 |
| *** mriedem has left #openstack-nova | 16:16 | |
| *** mriedem has joined #openstack-nova | 16:16 | |
| kashyap | mdbooth: Also, in BlockDeviceJobInfo (from get_job_info()), you're reporting the actual values, rather than "fudging" them | 16:16 |
| *** lpetrut has quit IRC | 16:16 | |
| mdbooth | kashyap: Right, that's the principal change, tbh. Everything else is tidying up after that. | 16:16 |
| kashyap | Yeah, so I think you didn't like the "cur=-1/end=-1, so that if cur and end are >=0 then you know the answer came from libvirt" | 16:16 |
| kashyap | Because it might just confuse future readers why we're "mangling" it, which requires more context... | 16:17 |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Removing duplicates from columns_to_join list https://review.openstack.org/342299 | 16:17 |
| openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: support user password settings in virtuozzo https://review.openstack.org/330643 | 16:17 |
| *** tbachman has quit IRC | 16:18 | |
| *** tbachman_ is now known as tbachman | 16:18 | |
| kashyap | mdbooth: But, I agree with your change, reporting them as-is, is much nicer than the status quo | 16:18 |
| *** nic has joined #openstack-nova | 16:18 | |
| dansmith | jroll: I love "dabble heavily" | 16:19 |
| jroll | dansmith: mostly by force | 16:19 |
| dansmith | jroll: "I delicately smash..." | 16:19 |
| dansmith | "I forcefully dip my toe" | 16:20 |
| jroll | hahaha | 16:20 |
| *** lucas-hungry is now known as lucasagomes | 16:20 | |
| *** jamielennox is now known as jamielennox|away | 16:21 | |
| *** Guest46101 is now known as mgagne | 16:21 | |
| *** mgagne has quit IRC | 16:21 | |
| *** mgagne has joined #openstack-nova | 16:21 | |
| *** msno has quit IRC | 16:23 | |
| *** kfarr has quit IRC | 16:23 | |
| sdague | mriedem: yeh, it does make me wonder if we should just be installing mock in python 3 test requirements | 16:23 |
| mriedem | sdague: we don't have a py3 specific test requirements | 16:24 |
| mriedem | so i'm not really sure how things work | 16:25 |
| slaweq_ | mdbooth: hello | 16:26 |
| mdbooth | slaweq_: Hey, sorry for stamping on your toes. | 16:26 |
| slaweq_ | I just made some comments in Your patch https://review.openstack.org/#/c/378746/ | 16:26 |
| slaweq_ | no problem | 16:26 |
| mdbooth | slaweq_: Cool, looking. | 16:26 |
| slaweq_ | just to be sure, I should probably abandon my patch https://review.openstack.org/#/c/365756/5, right? | 16:27 |
| slaweq_ | it's all included in this new one | 16:27 |
| *** jaosorior has quit IRC | 16:27 | |
| *** sahid has quit IRC | 16:27 | |
| mdbooth | slaweq_: https://en.wikipedia.org/wiki/Iff, btw ;) | 16:28 |
| mdbooth | slaweq_: Nah, hold off a minute. | 16:28 |
| slaweq_ | sorry, I didn't know that | 16:28 |
| mdbooth | slaweq_: Wait to see if my patch has a chance. I only did it so as not to hold up eantyshev. | 16:29 |
| *** haplo37_ has quit IRC | 16:29 | |
| slaweq_ | ok, I will wait :) | 16:29 |
| *** ihrachys has quit IRC | 16:29 | |
| *** thorst_ is now known as thorst | 16:30 | |
| *** haplo37_ has joined #openstack-nova | 16:31 | |
| *** Swami_ has quit IRC | 16:34 | |
| *** jlanoux has quit IRC | 16:34 | |
| *** Guest99661 has quit IRC | 16:34 | |
| *** baoli has quit IRC | 16:34 | |
| *** Vijayendra has quit IRC | 16:35 | |
| *** baoli has joined #openstack-nova | 16:35 | |
| *** armax has quit IRC | 16:36 | |
| *** annegentle has quit IRC | 16:36 | |
| johnthetubaguy | sfinucan: sorry, had a nit on the reno in this one: https://review.openstack.org/#/c/356604/9 | 16:36 |
| *** tblakes has quit IRC | 16:39 | |
| melwitt | mriedem: I used an empty context for my periodic task because it's part of the required function signature but I didn't need a RequestContext in my task, i.e. there are no db calls in it | 16:39 |
| *** Apoorva has joined #openstack-nova | 16:40 | |
| mriedem | ok | 16:40 |
| mriedem | melwitt: alaski straightened me out | 16:40 |
| mdbooth | kashyap: We're still at risk of interpreting a cancelled or failed job as have succeeded here, right? | 16:41 |
| melwitt | heh | 16:41 |
| mdbooth | So, if there no job, the only thing we know for certain is that it's no longer running. | 16:41 |
| kashyap | mdbooth: Yeah, was reading your patch | 16:41 |
| kashyap | # If the job no longer exists, it is because it has completed | 16:41 |
| kashyap | if status is None: | 16:41 |
| kashyap | return True | 16:41 |
| mdbooth | If we want to know why, we still need to read the event stream, right? | 16:41 |
| kashyap | Yes, if we could detect the BLOCK_JOB_COMPLETED event, that'd be the final nail in the coffin | 16:42 |
| mdbooth | So, if that's the case then I'll comment it, but not fix it | 16:42 |
| mdbooth | Because that's always been broken | 16:42 |
| mdbooth | And leave that one for another day | 16:42 |
| kashyap | Exactly, not a concern of this patch, can be a future enhancenemnt | 16:42 |
| kashyap | Yeah, was adding a comment to that effect, but you were faster here | 16:42 |
| mdbooth | kashyap: Leave your comment anyway :) | 16:43 |
| kashyap | Yes, for completeness | 16:43 |
| kashyap | mdbooth: For added fun, you've heard of BLOCK_JOB_READY flag, right? | 16:43 |
| mdbooth | Nope | 16:43 |
| kashyap | mdbooth: That is what is used to switch to the copy with 'drive-mirror' | 16:44 |
| kashyap | That event means source & dest are in sync, you may switch to dest whenever you may wish | 16:45 |
| kashyap | Rendering the source to contain the guest state at the point-in-time of the switch to dest | 16:45 |
| *** code-R_ has quit IRC | 16:45 | |
| *** slaweq_ has quit IRC | 16:48 | |
| *** danpb has quit IRC | 16:48 | |
| *** krtaylor has joined #openstack-nova | 16:50 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix BlockDevice.wait_for_job when qemu reports no job https://review.openstack.org/378746 | 16:50 |
| *** unicell1 has quit IRC | 16:50 | |
| alaski | cells meeting in 7 minutes in #openstack-meeting-3 | 16:53 |
| *** artom_ has joined #openstack-nova | 16:53 | |
| *** artom_ has quit IRC | 16:54 | |
| openstackgerrit | Kam Nasim proposed openstack/nova: Fixes exception during a swap to no swap resize https://review.openstack.org/300616 | 16:54 |
| *** artom_ has joined #openstack-nova | 16:54 | |
| *** sandanar has joined #openstack-nova | 16:55 | |
| johnthetubaguy | raj_singh: sfinucan: do we have two patches trying to do the same thing here: https://review.openstack.org/#/c/350122 and https://review.openstack.org/#/c/374701 ? | 16:55 |
| *** muawiakhan has joined #openstack-nova | 16:55 | |
| *** artom has quit IRC | 16:56 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Log parsing tool and post_test_hook script https://review.openstack.org/376531 | 16:56 |
| *** code-R has joined #openstack-nova | 16:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/378070 | 16:57 |
| raj_singh | johnthetubaguy: yup, funny thing is both reviewed each others patches :). I will abandon mine as sfinucan has some indentation fixes as well. | 16:57 |
| *** mamandle has joined #openstack-nova | 16:57 | |
| *** raunak has joined #openstack-nova | 16:58 | |
| johnthetubaguy | raj_singh: cool, thanks | 16:58 |
| *** muawiakh_ has joined #openstack-nova | 16:59 | |
| *** muawiakhan has quit IRC | 16:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/377527 | 16:59 |
| *** rama_y has joined #openstack-nova | 17:00 | |
| *** snikitin has quit IRC | 17:00 | |
| *** snikitin_ is now known as snikitin | 17:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/378890 | 17:00 |
| *** artom has joined #openstack-nova | 17:01 | |
| *** ducttape_ has quit IRC | 17:02 | |
| *** pbandark has quit IRC | 17:02 | |
| *** artom_ has quit IRC | 17:03 | |
| *** eliqiao has joined #openstack-nova | 17:03 | |
| *** Yingxin has joined #openstack-nova | 17:04 | |
| *** muawiakh_ has quit IRC | 17:06 | |
| *** muawiakhan has joined #openstack-nova | 17:06 | |
| *** rrecio has quit IRC | 17:07 | |
| *** muawiakhan has quit IRC | 17:07 | |
| *** artom has quit IRC | 17:07 | |
| *** rrecio has joined #openstack-nova | 17:07 | |
| *** psachin has quit IRC | 17:08 | |
| *** rlrossit has joined #openstack-nova | 17:09 | |
| *** maticue has joined #openstack-nova | 17:09 | |
| *** lpetrut has joined #openstack-nova | 17:10 | |
| *** mamandle has quit IRC | 17:12 | |
| *** rrecio has quit IRC | 17:13 | |
| *** artom has joined #openstack-nova | 17:13 | |
| mriedem | sdague: when are you on vacation again? | 17:14 |
| sdague | tomorrow -> next tues | 17:14 |
| sdague | this afternoon is going to be in and out with packing | 17:14 |
| mriedem | ok | 17:14 |
| *** bks has quit IRC | 17:16 | |
| dansmith | mriedem: sdague I don't see that we ran the hook here: http://logs.openstack.org/18/378718/2/check/gate-tempest-dsvm-neutron-placement-full-ubuntu-xenial-nv/c36a5c2/console.html#_2016-09-28_17_13_25_172160 | 17:16 |
| sdague | dansmith: possible race in getting the hook defined and that job running? | 17:16 |
| mriedem | dansmith: the p-c changes take i think a half hour to go out | 17:16 |
| dansmith | sdague: I pushed this after you said it was committed | 17:17 |
| dansmith | ah, damn okay | 17:17 |
| sdague | mriedem: I thought it was less time now, given that it doesn't have to push to all the jenkins | 17:17 |
| dansmith | mriedem: any way to tell if it's done? it's been more than 30m at this point, so maybe it's okay | 17:17 |
| sdague | dansmith: yeh, I would run recheck and assume it will be good | 17:17 |
| dansmith | alright | 17:17 |
| *** artom has quit IRC | 17:18 | |
| dansmith | mriedem: so since it's in master, are you cool with slamming in that archive patch to mitaka before it's too late, or do you want to wait until it's in newton? | 17:20 |
| sdague | mriedem / alaski / dansmith / johnthetubaguy - something to consider, the number of sessions proposed to - https://etherpad.openstack.org/p/ocata-cross-project-sessions is actually kind of small (I think less than the number of slots even). It might be a good idea to propose things like multi attach volumes, or other nova cross project collaboration points into that track | 17:22 |
| dansmith | sdague: okay, but we should propose things we _want_ to talk about, which puts multi-attach out of the running | 17:22 |
| sdague | I think there are at least 18 slots, and only 11 proposals right now. | 17:22 |
| sdague | dansmith: ok, I just assumed multi-attach was going to need another session there | 17:23 |
| *** unicell has joined #openstack-nova | 17:23 | |
| alaski | sdague: okay. I've been debating putting something together about the capabilities API since Cinder is looking at a similar thing. Unless you're doing that. | 17:23 |
| dansmith | that's not what I said.. :) | 17:23 |
| sdague | alaski: go for, you should run with it | 17:23 |
| mriedem | sdague: that's planned | 17:23 |
| mriedem | at least 1 nova/neutron and 1 nova/cinder | 17:23 |
| mriedem | i need to work out details with armax since i think he was planning one of the neutron sessions to host us | 17:24 |
| mriedem | and i was doing the same for them | 17:24 |
| sdague | mriedem: right, what I'm saying is you could look at putting into this other part of the calendar instead. | 17:24 |
| mriedem | oh right the xp sessions | 17:24 |
| sdague | especially as the normal project slots are down to 2.5 days | 17:24 |
| sdague | and the meetup is just the afternoon on friday | 17:25 |
| mriedem | and most people are going to be gone friday afternoon | 17:25 |
| sdague | right | 17:25 |
| mriedem | ok will keep it in mind | 17:25 |
| sdague | proposals need to be on that etherpad by Sat | 17:25 |
| sdague | as it's going to get decided next week, so that projects can adjust to content there | 17:26 |
| *** praneshp has joined #openstack-nova | 17:27 | |
| *** sc68cal_ is now known as sc68cal | 17:27 | |
| praneshp | hello nova. I’m on Liberty and see that keypairs are not propagated down to the cell that my instances are booting into. Is this a known issue? It’s basically https://bugs.launchpad.net/nova/+bug/1533874 which is marked as incomplete. | 17:28 |
| openstack | Launchpad bug 1533874 in OpenStack Compute (nova) "In kilo nova, cell mode, nova boot fail with key " [Undecided,Invalid] | 17:28 |
| *** ducttape_ has joined #openstack-nova | 17:29 | |
| *** Swami has joined #openstack-nova | 17:31 | |
| *** rrecio has joined #openstack-nova | 17:33 | |
| praneshp | melwitt: ^^ | 17:33 |
| *** apuimedo|away is now known as apuimedo | 17:34 | |
| openstackgerrit | ianeta hutchinson proposed openstack/nova: Fix small RST errors to align with OpenStack RST markup guideline. https://review.openstack.org/378936 | 17:36 |
| *** bogdan has joined #openstack-nova | 17:37 | |
| mriedem | stewie925: in case you haven't seen a fix for this yet, the volumeAttachment description is wrong here http://developer.openstack.org/api-ref/compute/?expanded=attach-a-volume-to-an-instance-detail | 17:37 |
| mriedem | it's using the same parameter description for the request and the response, but the request doesn't take a serverId in volumeAttachment | 17:37 |
| mriedem | but it returns it in the response | 17:37 |
| openstackgerrit | ianeta hutchinson proposed openstack/nova: Fix small RST markup errors https://review.openstack.org/378936 | 17:38 |
| *** baoli has quit IRC | 17:39 | |
| *** baoli has joined #openstack-nova | 17:39 | |
| *** stewie925 has quit IRC | 17:39 | |
| *** baoli has quit IRC | 17:40 | |
| *** baoli has joined #openstack-nova | 17:41 | |
| *** aswadr_ has quit IRC | 17:42 | |
| *** dikonoo has quit IRC | 17:45 | |
| *** thorst has quit IRC | 17:45 | |
| *** thorst has joined #openstack-nova | 17:46 | |
| *** sudipto_ has quit IRC | 17:47 | |
| *** sudipto has quit IRC | 17:47 | |
| *** sudipto has joined #openstack-nova | 17:47 | |
| *** burt has quit IRC | 17:47 | |
| *** hshiina has quit IRC | 17:48 | |
| melwitt | praneshp: in cells v1 it's a known limitation that many apis don't work correctly because parent db isn't synced with cell dbs. only instances are. so keypairs are only in the parent db and can't be queried from cells. you would have to sync them manually like flavors, etc | 17:48 |
| *** sudipto has quit IRC | 17:48 | |
| *** sudipto has joined #openstack-nova | 17:48 | |
| *** sudipto_ has joined #openstack-nova | 17:48 | |
| praneshp | melwitt: sync them manually == insert those rows in the db yourself, or use some sync tool? Sorry if this is covered in docs. | 17:49 |
| *** ftersin_ has joined #openstack-nova | 17:50 | |
| praneshp | melwitt: thanks for your time! I’ll find out how we sync flavors here, and just do the same for keypairs | 17:51 |
| *** tbachman has quit IRC | 17:51 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add get_context helper method https://review.openstack.org/378941 | 17:52 |
| melwitt | praneshp: it's not covered in docs but operators have developed their own tools to do syncing. that's what I was about to suggest, if you are already syncing some tables, it will be similar | 17:52 |
| *** tbachman has joined #openstack-nova | 17:52 | |
| praneshp | yep! | 17:52 |
| *** _ducttape_ has joined #openstack-nova | 17:53 | |
| ftersin_ | melwitt: hi. i found you recently reviewed https://review.openstack.org/#/c/325708/ | 17:55 |
| ftersin_ | melwitt: could you please also take a look at an alternative solution https://review.openstack.org/#/c/334609/ | 17:56 |
| mriedem | alaski: question in https://review.openstack.org/#/c/378636/3/nova/tests/unit/conductor/test_conductor.py to check my understanding | 17:56 |
| *** ducttape_ has quit IRC | 17:57 | |
| mriedem | ah yes | 17:58 |
| mriedem | # retry is enabled, update attempt count: | 17:58 |
| mriedem | retry = filter_properties.setdefault( | 17:58 |
| mriedem | 'retry', { | 17:58 |
| mriedem | 'num_attempts': 0, | 17:58 |
| mriedem | 'hosts': [] # list of compute hosts tried | 17:58 |
| mriedem | }) | 17:58 |
| mriedem | retry['num_attempts'] += 1 | 17:58 |
| alaski | mriedem: you are correct sir. I commented on it | 17:58 |
| alaski | yeah, and the assert in the test shows it at 2 | 17:58 |
| mriedem | yeah nice assertion there | 17:58 |
| mriedem | +2 | 17:58 |
| melwitt | ftersin_: okay | 17:58 |
| mriedem | dansmith: melwitt: bauzas: https://review.openstack.org/#/c/378636/ | 17:58 |
| *** annegentle has joined #openstack-nova | 17:59 | |
| mriedem | bbiab | 17:59 |
| *** mriedem has quit IRC | 17:59 | |
| dansmith | alaski: help me understand why <=1 and not == 0 | 18:01 |
| alaski | dansmith: well, it would be == 1. but just me being paranoid | 18:02 |
| *** sandanar_ has joined #openstack-nova | 18:02 | |
| dansmith | alaski: we only want to do this on the first round, right? why isn't that retries=0? | 18:02 |
| alaski | num_attempts is incremented as soon as it's set, so on the first round it's 1 | 18:03 |
| alaski | the code in mriedems comment shows how it's initialized | 18:03 |
| dansmith | hmm | 18:03 |
| dansmith | but where is that? | 18:03 |
| dansmith | oh heh | 18:03 |
| alaski | it's poorly named | 18:03 |
| alaski | scheduler/utils.py | 18:03 |
| dansmith | in the thing you commented when you told him when he asked the same thing | 18:03 |
| dansmith | sorry | 18:03 |
| dansmith | I pretty much read from his ping down :) | 18:04 |
| *** sandanar has quit IRC | 18:05 | |
| alaski | heh, no problem | 18:06 |
| *** Vijayendra has joined #openstack-nova | 18:07 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Remove the sample policy file https://review.openstack.org/378947 | 18:12 |
| *** rlrossit has quit IRC | 18:12 | |
| *** stewie925 has joined #openstack-nova | 18:13 | |
| *** _ducttape_ has quit IRC | 18:13 | |
| *** ducttape_ has joined #openstack-nova | 18:13 | |
| *** sudipto_ has quit IRC | 18:14 | |
| *** sudipto has quit IRC | 18:14 | |
| *** ijw has quit IRC | 18:16 | |
| openstackgerrit | Chris Dent proposed openstack/nova: [placement] add a placement_aggregates table to api_db https://review.openstack.org/362863 | 18:17 |
| openstackgerrit | Chris Dent proposed openstack/nova: Add {get_,set_}aggregates to objects.ResourceProvider https://review.openstack.org/355263 | 18:17 |
| openstackgerrit | Chris Dent proposed openstack/nova: Implement get and set aggregates in the placement API https://review.openstack.org/357993 | 18:18 |
| *** jheroux has joined #openstack-nova | 18:18 | |
| *** artom has joined #openstack-nova | 18:18 | |
| *** zenoway has quit IRC | 18:22 | |
| *** richil has joined #openstack-nova | 18:22 | |
| *** zenoway has joined #openstack-nova | 18:23 | |
| *** artom_ has joined #openstack-nova | 18:24 | |
| *** bvanhav has quit IRC | 18:25 | |
| *** artom has quit IRC | 18:27 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Log parsing tool and post_test_hook script https://review.openstack.org/376531 | 18:27 |
| *** zenoway has quit IRC | 18:27 | |
| *** Jeffrey4l has quit IRC | 18:28 | |
| *** baoli has quit IRC | 18:28 | |
| *** mriedem has joined #openstack-nova | 18:29 | |
| *** bvanhav has joined #openstack-nova | 18:29 | |
| alaski | mriedem: where was that regex that caused changes to the tools/ dir to not trigger devstack jobs? | 18:30 |
| *** tbachman_ has joined #openstack-nova | 18:30 | |
| mriedem | alaski: sec | 18:30 |
| mriedem | alaski: https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L1358 | 18:31 |
| *** whenry has quit IRC | 18:31 | |
| alaski | thanks. I'm thinking we want tools/hooks/ to still trigger devstack runs | 18:31 |
| *** krtaylor has quit IRC | 18:32 | |
| mriedem | alaski: yeah | 18:32 |
| *** tbachman has quit IRC | 18:32 | |
| *** tbachman_ is now known as tbachman | 18:32 | |
| mriedem | alaski: that regex gets really gross though | 18:32 |
| sdague | mriedem / alaski or move this stuff to gate/ | 18:32 |
| mriedem | e.g. https://review.openstack.org/#/c/371065/ | 18:32 |
| sdague | which makes it more clear that it's gate related stuff, because the rest of tools is very different kinds of stuff | 18:32 |
| alaski | mriedem: ugh | 18:33 |
| mriedem | sdague: btw you should totally +2 this before you leave https://review.openstack.org/#/c/371065/ | 18:33 |
| mriedem | i swear it's perfect | 18:33 |
| sdague | mriedem: it still kind of scares me | 18:33 |
| mriedem | sdague: ok does this scare you? https://review.openstack.org/#/c/378751/ | 18:33 |
| *** zz_dimtruck is now known as dimtruck | 18:33 | |
| sdague | but, damn the torpedos | 18:33 |
| mriedem | for rc2 | 18:33 |
| mriedem | dansmith: https://review.openstack.org/#/c/378751/ | 18:34 |
| alaski | sdague: that's a possibility too, though I wish we had done that yesterday so we don't need another project-config change :) | 18:34 |
| *** salv-orlando has quit IRC | 18:34 | |
| sdague | alaski: yeh, well, the joys of d-g hooks :) | 18:34 |
| sdague | honestly though, we can probably do it with a symlink change | 18:35 |
| alaski | ah, trickery | 18:35 |
| sdague | so move stuff to gate/ | 18:35 |
| sdague | make the old things be symlinks | 18:35 |
| sdague | then get project-config changed | 18:35 |
| sdague | then delete symlinks | 18:35 |
| alaski | okay. I'll play around with that | 18:36 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for ISO images https://review.openstack.org/333569 | 18:36 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: objects: Removes base code that already exists in o.vo https://review.openstack.org/307041 | 18:36 |
| sdague | maybe wait until dansmith's fixes go in? | 18:36 |
| sdague | so we don't slow those down | 18:36 |
| alaski | sure. there's no rush, I just realized my patch didn't actually trigger what it should have | 18:37 |
| sdague | yeh | 18:37 |
| alaski | mriedem: speaking of context https://review.openstack.org/#/c/378941/ | 18:37 |
| sdague | alaski: I can try to throw together something quick | 18:38 |
| sdague | it will at least test that theory | 18:38 |
| alaski | cool | 18:38 |
| *** woodster_ has quit IRC | 18:40 | |
| *** ijw has joined #openstack-nova | 18:41 | |
| *** ducttape_ has quit IRC | 18:41 | |
| *** tbachman_ has joined #openstack-nova | 18:41 | |
| openstackgerrit | Sean Dague proposed openstack/nova: move gate hooks to gate/ https://review.openstack.org/378952 | 18:41 |
| *** yamahata has joined #openstack-nova | 18:43 | |
| *** TravT_ has joined #openstack-nova | 18:44 | |
| *** tbachman has quit IRC | 18:44 | |
| *** tbachman_ is now known as tbachman | 18:44 | |
| sdague | mriedem: https://review.openstack.org/#/c/377989/ is the clean up for circular import in the archive code from the other day | 18:46 |
| *** sdake has quit IRC | 18:46 | |
| *** ijw has quit IRC | 18:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: support user password settings in virtuozzo https://review.openstack.org/330643 | 18:46 |
| *** TravT has quit IRC | 18:47 | |
| *** TravT_ has quit IRC | 18:48 | |
| *** krtaylor has joined #openstack-nova | 18:48 | |
| *** cdelatte has joined #openstack-nova | 18:50 | |
| alaski | mriedem: thanks for proposing the backport | 18:50 |
| mriedem | sdague: i glanced at that the other day and it hurt my brain | 18:50 |
| dansmith | sdague: I got it, forgot about that | 18:51 |
| sdague | mriedem: ok, it was just shuffling some bits around | 18:51 |
| dansmith | mriedem: it's just moving a thing | 18:51 |
| richil | sdague, Can I get some guidance on this bug https://bugs.launchpad.net/nova/+bug/1582693? | 18:53 |
| openstack | Launchpad bug 1582693 in OpenStack Compute (nova) "Image and flavor metadata for libvirt watchdog is handled erroneously" [Undecided,In progress] - Assigned to Richil Bhalerao (richil-bhalerao) | 18:53 |
| *** annegentle has quit IRC | 18:54 | |
| mriedem | easy bp add if someone wants it https://review.openstack.org/#/c/330643/ | 18:55 |
| *** ducttape_ has joined #openstack-nova | 18:55 | |
| sdague | mriedem: done | 18:56 |
| mriedem | thanks | 18:56 |
| *** baoli has joined #openstack-nova | 18:56 | |
| mriedem | i've been keeping a burndown of bp proposals/approvals/completions | 18:56 |
| mriedem | so i like to see the graph move | 18:57 |
| sdague | mriedem: where is the burndown? | 18:57 |
| mriedem | my google drive | 18:57 |
| mriedem | https://docs.google.com/spreadsheets/d/1Wt7IrSTzSOgC7683FtpjWgYY7lZCHxslYGFUZlpnljI/edit?usp=sharing | 18:58 |
| mriedem | it's definitely not sexy | 18:58 |
| mriedem | i was thinking after the release we could throw that data into nova-specs or something for tracking/showing how things worked out | 18:59 |
| mriedem | since lp doesn't do it | 18:59 |
| sdague | so, that just lp queries? | 19:00 |
| sdague | I could probably hack up a thing next week | 19:01 |
| *** hogepodge has quit IRC | 19:01 | |
| mriedem | well, i check https://blueprints.launchpad.net/nova/ocata each day yea | 19:02 |
| mriedem | since lp doesn't keep track of when a state change happened on a thing, | 19:02 |
| mriedem | but honestly i haven't dug into the lp api to find out | 19:02 |
| *** Vijayendra has quit IRC | 19:03 | |
| mriedem | but you could easily get the ocata blueprints each day, get the status on them and throw that info into some table | 19:03 |
| mriedem | with a timestamp | 19:03 |
| *** TravT has joined #openstack-nova | 19:04 | |
| *** baoli has quit IRC | 19:05 | |
| *** baoli has joined #openstack-nova | 19:06 | |
| *** mbirru has quit IRC | 19:07 | |
| *** ftersin_ has quit IRC | 19:08 | |
| *** mbirru has joined #openstack-nova | 19:08 | |
| *** TravT has quit IRC | 19:09 | |
| alaski | buffer 16 | 19:10 |
| *** lpetrut has quit IRC | 19:11 | |
| *** tblakes has joined #openstack-nova | 19:12 | |
| dansmith | orly | 19:12 |
| *** yamahata has quit IRC | 19:13 | |
| alaski | yeah :| on my laptop keyboard so I keep missing keys | 19:13 |
| *** hoonetorg has quit IRC | 19:14 | |
| richil | sdague: Looks like for flavor extra spec 'hw_watchdog_action' format is deprecated in current release and 'hw:watchdog_action' is recommended to be used instead. Is it safe to say that fix for https://bugs.launchpad.net/nova/+bug/1582693 is really in Horizon and not in Nova? | 19:15 |
| openstack | Launchpad bug 1582693 in OpenStack Compute (nova) "Image and flavor metadata for libvirt watchdog is handled erroneously" [Undecided,In progress] - Assigned to Richil Bhalerao (richil-bhalerao) | 19:15 |
| openstackgerrit | ianeta hutchinson proposed openstack/nova: Fixes RST markup error to a create code-box. https://review.openstack.org/378966 | 19:16 |
| *** anush has quit IRC | 19:17 | |
| *** anush has joined #openstack-nova | 19:17 | |
| openstackgerrit | ianeta hutchinson proposed openstack/nova: Fixes RST markup error to create a code-box. https://review.openstack.org/378966 | 19:17 |
| *** burt has joined #openstack-nova | 19:18 | |
| *** snikitin has quit IRC | 19:18 | |
| *** raunak has quit IRC | 19:20 | |
| *** salv-orlando has joined #openstack-nova | 19:22 | |
| *** sandanar_ has quit IRC | 19:22 | |
| *** rlrossit has joined #openstack-nova | 19:23 | |
| *** jinli has quit IRC | 19:26 | |
| *** syjulian has quit IRC | 19:26 | |
| *** MikeG451 has quit IRC | 19:26 | |
| *** yohoffman has quit IRC | 19:26 | |
| *** stew925 has quit IRC | 19:26 | |
| *** xenogear has quit IRC | 19:26 | |
| *** yohoffman has joined #openstack-nova | 19:27 | |
| *** diablo_rojo has quit IRC | 19:28 | |
| *** rlrossit has quit IRC | 19:28 | |
| *** MikeG451 has joined #openstack-nova | 19:31 | |
| *** TravT has joined #openstack-nova | 19:31 | |
| *** hoonetorg has joined #openstack-nova | 19:31 | |
| *** TravT has quit IRC | 19:32 | |
| *** xenogear has joined #openstack-nova | 19:32 | |
| *** cnf has left #openstack-nova | 19:33 | |
| *** sdake has joined #openstack-nova | 19:34 | |
| *** TravT has joined #openstack-nova | 19:36 | |
| *** TravT has quit IRC | 19:36 | |
| *** jinli has joined #openstack-nova | 19:36 | |
| *** TravT has joined #openstack-nova | 19:36 | |
| *** TravT has quit IRC | 19:37 | |
| *** READ10 has quit IRC | 19:37 | |
| cdent | edleafe: no argument on the routes thing being fragile and funky, but I think protecting against the b'' thing would mask errors not prevent them | 19:37 |
| *** TravT has joined #openstack-nova | 19:38 | |
| edleafe | cdent: well yeah, that's a realy ugly solution, which is why I wanted to discuss alternatives | 19:40 |
| *** syjulian has joined #openstack-nova | 19:40 | |
| alaski | dansmith: melwitt bauzas thoughts on how to handle "with target_cell(): instance = objects.Instance.get_by_uuid()" in terms of whether or not instance._context has affinity to a cell? | 19:40 |
| dansmith | alaski: meaning whether to override the cell of the context inside instance after we exit the context manager? | 19:41 |
| alaski | dansmith: yep | 19:41 |
| alaski | so that instance.save() works automatically, or require with target_cell again | 19:41 |
| dansmith | alaski: I would think it probably should retain the cell | 19:41 |
| dansmith | yeah | 19:41 |
| dansmith | else we'll have to target the cell everywhere | 19:42 |
| alaski | yeah. I like that as well | 19:42 |
| dansmith | and if you want to save it to a different cell, then with target_cell it at that point | 19:42 |
| alaski | yeah | 19:42 |
| *** salv-orl_ has joined #openstack-nova | 19:43 | |
| bauzas | alaski: not sure I got your question honestly, even with dansmith's one :) | 19:43 |
| alaski | I think I'll want to add something to check if an object, or context, is currently targeting a cell. | 19:43 |
| *** nherciu has quit IRC | 19:44 | |
| melwitt | I didn't understand it at first but I think that makes sense. that reading it out from a cell makes it okay to affiliate that instance's context with the cell after the read | 19:44 |
| alaski | bauzas: should instance._context.db_connection still be set from the example above | 19:44 |
| *** oanson has joined #openstack-nova | 19:45 | |
| alaski | melwitt: yep. cool | 19:45 |
| *** stew925 has joined #openstack-nova | 19:46 | |
| bauzas | alaski: IIUC, then yes | 19:46 |
| *** salv-orlando has quit IRC | 19:46 | |
| bauzas | alaski: because it's a good way to get the context set | 19:46 |
| *** TravT has quit IRC | 19:47 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Guard against overwriting a deleting task state https://review.openstack.org/288933 | 19:47 |
| melwitt | alaski: it might make it confusing to know when target_cell is actually needed I guess. but I'm having trouble coming up with examples of where instance._context wouldn't be set, if we're in some function where instance was passed in as an argument | 19:49 |
| *** dimtruck is now known as zz_dimtruck | 19:49 | |
| alaski | melwitt: yeah. all I can think of right now is the initial instance create | 19:49 |
| melwitt | same | 19:49 |
| dansmith | for things other than instance we have some examples | 19:50 |
| dansmith | but those are globals anyway | 19:50 |
| dansmith | er, api-level | 19:50 |
| melwitt | so if we with target_cell(): instance.save() would that also set the context, I guess it would. so later actions would be covered | 19:50 |
| dansmith | I think it's probably mostly just instance create | 19:50 |
| melwitt | er, sorry instance.create() | 19:51 |
| alaski | yeah, I think we'll have a general pattern of object.create() needs target_cell and object.save() does not | 19:52 |
| *** richil has quit IRC | 19:52 | |
| alaski | if object is something in a cell db | 19:52 |
| melwitt | yeah, what I mean is will target_cell() set the context on the instance object after the create() so that later saves work. and I think it's yes | 19:53 |
| alaski | oh. yeah that's what I would expect | 19:53 |
| *** whenry has joined #openstack-nova | 19:53 | |
| melwitt | yeah, I was just getting mixed up. target_cell will always set the object._context | 19:55 |
| *** rlrossit has joined #openstack-nova | 19:56 | |
| *** rlrossit has quit IRC | 19:56 | |
| *** code-R has quit IRC | 19:59 | |
| *** bvanhav has quit IRC | 20:03 | |
| openstackgerrit | Paul Carlton proposed openstack/python-novaclient: [microversion] Bump to 2.39 https://review.openstack.org/316026 | 20:03 |
| *** lucasagomes is now known as lucas-afk | 20:04 | |
| openstackgerrit | Paul Carlton proposed openstack/nova: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | 20:05 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 20:05 |
| *** salv-orl_ has quit IRC | 20:07 | |
| *** salv-orlando has joined #openstack-nova | 20:08 | |
| *** cdelatte has quit IRC | 20:08 | |
| *** raunak has joined #openstack-nova | 20:17 | |
| *** oanson has quit IRC | 20:20 | |
| *** tonytan4ever has quit IRC | 20:23 | |
| openstackgerrit | Paul Carlton proposed openstack/python-novaclient: [microversion] Bump to 2.39 https://review.openstack.org/316026 | 20:23 |
| *** annegentle has joined #openstack-nova | 20:25 | |
| *** winston-d_ has quit IRC | 20:26 | |
| stewie925 | hello guys, I have run 'tox -e api samples' and it was successful, but I dont know whether any new api-samples were generated. | 20:28 |
| stewie925 | here are the results of the 'tox api-sample' run==>http://paste.openstack.org/show/583379/ | 20:28 |
| *** baoli has quit IRC | 20:29 | |
| sdague | stewie925: git diff | 20:30 |
| mriedem | oh zuul please come back to me | 20:32 |
| openstackgerrit | Paul Carlton proposed openstack/nova: API changes for live migration of rescued instance https://review.openstack.org/328280 | 20:33 |
| stewie925 | sdague: thank you, my git diff returned nothing | 20:33 |
| artom_ | o/` Hey Zuul, don't make it bad / Take a failed test and make it better o/` | 20:33 |
| *** Apoorva_ has joined #openstack-nova | 20:33 | |
| *** Apoorva has quit IRC | 20:36 | |
| *** rfolco_ has quit IRC | 20:44 | |
| *** jamielennox|away is now known as jamielennox | 20:45 | |
| *** diablo_rojo has joined #openstack-nova | 20:45 | |
| stewie925 | sdague: but supposedly any new generated api-samples should go to ~/nova/doc/api_samples/ directory, is that right? | 20:46 |
| sdague | stewie925: yes | 20:46 |
| sdague | oh, if it's new stuff | 20:46 |
| stewie925 | thank you | 20:46 |
| sdague | git status | 20:46 |
| sdague | I don't think we .gitignore that directory... hopefully we don't | 20:46 |
| stewie925 | oh let me check... I hope not too | 20:47 |
| stewie925 | but I did do a manual compare (before and after) - and there was no difference | 20:47 |
| *** burgerk has quit IRC | 20:49 | |
| openstackgerrit | Chris Dent proposed openstack/nova: [placement] reorder middleware to correct logging context https://review.openstack.org/374833 | 20:50 |
| openstackgerrit | Chris Dent proposed openstack/nova: [placement] reorder middleware to correct logging context https://review.openstack.org/374833 | 20:51 |
| *** cdent has quit IRC | 20:55 | |
| *** ijw has joined #openstack-nova | 21:00 | |
| *** ijw has quit IRC | 21:01 | |
| *** ijw has joined #openstack-nova | 21:01 | |
| *** annegentle has quit IRC | 21:03 | |
| *** ijw has quit IRC | 21:03 | |
| *** rtheis has quit IRC | 21:03 | |
| *** ijw has joined #openstack-nova | 21:05 | |
| *** ijw has quit IRC | 21:05 | |
| *** ijw has joined #openstack-nova | 21:05 | |
| *** annegentle has joined #openstack-nova | 21:05 | |
| *** yamahata has joined #openstack-nova | 21:06 | |
| *** baoli has joined #openstack-nova | 21:06 | |
| *** mat128 is now known as mat128|afk | 21:11 | |
| openstackgerrit | Sujitha proposed openstack/nova: Remove deprecated manager classes in service.py https://review.openstack.org/338553 | 21:14 |
| openstackgerrit | John Griffith proposed openstack/nova: Implement new attach/detach Cinder flow https://review.openstack.org/330285 | 21:15 |
| openstackgerrit | Chris Dent proposed openstack/nova: [placement] reorder middleware to correct logging context https://review.openstack.org/374833 | 21:15 |
| *** bogdan has quit IRC | 21:16 | |
| *** diablo_rojo has quit IRC | 21:18 | |
| *** tbachman has quit IRC | 21:19 | |
| *** krtaylor has quit IRC | 21:21 | |
| *** tbachman has joined #openstack-nova | 21:22 | |
| *** eharney has quit IRC | 21:23 | |
| *** tonytan4ever has joined #openstack-nova | 21:23 | |
| *** edmondsw has quit IRC | 21:25 | |
| *** sdague has quit IRC | 21:27 | |
| *** cdelatte has joined #openstack-nova | 21:28 | |
| *** tonytan4ever has quit IRC | 21:28 | |
| *** hogepodge has joined #openstack-nova | 21:28 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add support for archiving all deleted rows https://review.openstack.org/378177 | 21:32 |
| *** whenry has quit IRC | 21:34 | |
| *** yamahata has quit IRC | 21:35 | |
| openstackgerrit | Sujitha proposed openstack/nova: Improve help text for libvirt options https://review.openstack.org/372722 | 21:35 |
| mriedem | melwitt: thanks, bp approved | 21:35 |
| *** maticue has quit IRC | 21:35 | |
| melwitt | mriedem: thanks! | 21:35 |
| *** jheroux has quit IRC | 21:36 | |
| *** tanvirt has quit IRC | 21:37 | |
| *** mriedem has quit IRC | 21:44 | |
| *** richil has joined #openstack-nova | 21:44 | |
| *** tbachman has quit IRC | 21:48 | |
| *** marst has quit IRC | 21:50 | |
| *** mdrabe has quit IRC | 21:51 | |
| *** mdrabe has joined #openstack-nova | 21:51 | |
| openstackgerrit | Anusha Unnam proposed openstack/nova: Improve help text for interval_opts https://review.openstack.org/331761 | 21:53 |
| *** baoli has quit IRC | 21:53 | |
| *** tbachman has joined #openstack-nova | 21:54 | |
| openstackgerrit | melanie witt proposed openstack/nova: Make releasenotes reminder detect added and untracked notes https://review.openstack.org/379015 | 21:57 |
| *** trisq has quit IRC | 21:58 | |
| *** baoli_ has joined #openstack-nova | 21:58 | |
| *** jamesdenton has quit IRC | 22:01 | |
| *** jamesdenton has joined #openstack-nova | 22:03 | |
| *** baoli_ has quit IRC | 22:04 | |
| *** tblakes has quit IRC | 22:05 | |
| *** marst has joined #openstack-nova | 22:07 | |
| *** lamt has quit IRC | 22:09 | |
| *** mdrabe has quit IRC | 22:09 | |
| *** salv-orlando has quit IRC | 22:10 | |
| *** krtaylor has joined #openstack-nova | 22:10 | |
| *** praneshp has quit IRC | 22:11 | |
| *** jamesdenton has quit IRC | 22:12 | |
| *** thorst has quit IRC | 22:13 | |
| *** baoli has joined #openstack-nova | 22:13 | |
| *** thorst has joined #openstack-nova | 22:14 | |
| *** maticue has joined #openstack-nova | 22:14 | |
| *** rfolco_ has joined #openstack-nova | 22:14 | |
| *** annegentle has quit IRC | 22:14 | |
| *** rfolco_ has quit IRC | 22:14 | |
| *** baoli has quit IRC | 22:16 | |
| *** thorst has quit IRC | 22:18 | |
| *** bdeschenes has quit IRC | 22:20 | |
| *** ducttape_ has quit IRC | 22:22 | |
| *** tonytan4ever has joined #openstack-nova | 22:23 | |
| dansmith | mriedem_meeting: I still don't see it running: http://logs.openstack.org/18/378718/2/check/gate-tempest-dsvm-neutron-placement-full-ubuntu-xenial-nv/c2b2e5f/console.html#_2016-09-28_21_00_53_208959 | 22:27 |
| *** rrecio has quit IRC | 22:27 | |
| *** Apoorva_ has quit IRC | 22:27 | |
| *** Apoorva has joined #openstack-nova | 22:28 | |
| *** praneshp has joined #openstack-nova | 22:28 | |
| *** vishwanathj has quit IRC | 22:29 | |
| *** bdeschenes has joined #openstack-nova | 22:31 | |
| *** thorst has joined #openstack-nova | 22:33 | |
| *** annegentle has joined #openstack-nova | 22:36 | |
| *** annegentle has quit IRC | 22:36 | |
| *** markvoelker has quit IRC | 22:36 | |
| *** thorst has quit IRC | 22:38 | |
| *** thorst has joined #openstack-nova | 22:38 | |
| *** mlavalle has quit IRC | 22:42 | |
| *** thorst has quit IRC | 22:43 | |
| *** ducttape_ has joined #openstack-nova | 22:46 | |
| *** ijw has quit IRC | 22:46 | |
| *** thorst has joined #openstack-nova | 22:48 | |
| *** salv-orlando has joined #openstack-nova | 22:48 | |
| *** tonytan4ever has quit IRC | 22:51 | |
| *** ducttape_ has quit IRC | 22:52 | |
| *** salv-orlando has quit IRC | 22:52 | |
| *** thorst has quit IRC | 22:52 | |
| *** Swami has quit IRC | 22:53 | |
| *** sdake has quit IRC | 22:56 | |
| *** ijw has joined #openstack-nova | 22:58 | |
| *** ducttape_ has joined #openstack-nova | 22:58 | |
| *** raunak has quit IRC | 22:59 | |
| *** raunak has joined #openstack-nova | 23:02 | |
| *** ijw has quit IRC | 23:03 | |
| *** raunak has quit IRC | 23:10 | |
| openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova: live migrate instance in active state on failure https://review.openstack.org/379032 | 23:11 |
| *** ducttape_ has quit IRC | 23:13 | |
| *** ijw has joined #openstack-nova | 23:19 | |
| *** raunak has joined #openstack-nova | 23:20 | |
| *** ijw has quit IRC | 23:24 | |
| *** TravT has joined #openstack-nova | 23:28 | |
| *** ijw has joined #openstack-nova | 23:29 | |
| *** sdake has joined #openstack-nova | 23:32 | |
| *** ijw has quit IRC | 23:34 | |
| *** sdake_ has joined #openstack-nova | 23:35 | |
| *** markvoelker has joined #openstack-nova | 23:37 | |
| *** sdake has quit IRC | 23:38 | |
| *** markvoelker has quit IRC | 23:41 | |
| *** ijw has joined #openstack-nova | 23:47 | |
| *** rama_y has quit IRC | 23:50 | |
| *** raunak has quit IRC | 23:52 | |
| *** ijw has quit IRC | 23:53 | |
| *** xyang1 has quit IRC | 23:54 | |
| *** TravT_ has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!