Thursday, 2016-09-08

*** zul has quit IRC00:01
*** bhagyashri has quit IRC00:11
*** ducttape_ has quit IRC00:12
*** mingyu has joined #openstack-nova00:14
openstackgerritGhanshyam Mann proposed openstack/nova: Fix policy tests for project_id enforcement  https://review.openstack.org/35469000:18
*** felix23ma has joined #openstack-nova00:19
openstackgerritGhanshyam Mann proposed openstack/nova: Fix policy tests for project_id enforcement  https://review.openstack.org/35469000:20
*** ducttape_ has joined #openstack-nova00:20
*** liangy has quit IRC00:21
*** Apoorva_ has joined #openstack-nova00:24
*** trisq has joined #openstack-nova00:26
*** Apoorva has quit IRC00:27
*** claudiub|2 has quit IRC00:28
*** Apoorva_ has quit IRC00:28
*** harlowja has joined #openstack-nova00:29
*** ducttape_ has quit IRC00:30
*** diogogmt has joined #openstack-nova00:35
*** akshai has joined #openstack-nova00:39
*** kaisers1 has joined #openstack-nova00:42
*** ducttape_ has joined #openstack-nova00:43
*** kaisers has quit IRC00:43
*** thorst has joined #openstack-nova00:43
*** hoangcx has joined #openstack-nova00:46
*** akshai has quit IRC00:48
*** eharney has quit IRC00:49
*** cdelatte has quit IRC00:51
*** gouthamr_ has quit IRC00:51
*** kevinz has joined #openstack-nova00:52
*** jdurgin1 has joined #openstack-nova00:55
*** mingyu has quit IRC00:56
*** amrith has left #openstack-nova00:56
*** kevinz has quit IRC00:57
*** gongysh has joined #openstack-nova00:58
*** ssurana1 has quit IRC00:58
*** dimtruck is now known as zz_dimtruck01:00
*** unicell has quit IRC01:00
*** rfolco has quit IRC01:02
*** akshai has joined #openstack-nova01:03
*** trisq has quit IRC01:03
*** ducttape_ has quit IRC01:03
openstackgerritEli Qiao proposed openstack/nova: Libvirt: Correct PERF_EVENTS_CPU_FLAG_MAPPING  https://review.openstack.org/36584201:05
*** zz_dimtruck is now known as dimtruck01:06
*** gouthamr has joined #openstack-nova01:06
*** mars_toktonaliev has joined #openstack-nova01:08
*** cheneydc has joined #openstack-nova01:09
*** cheneydc has quit IRC01:10
*** Sukhdev_ has quit IRC01:10
*** marst has quit IRC01:12
*** raj_singh_ has joined #openstack-nova01:13
suxiangI have a question about security group of nova version juno.And i config security_group_api=neutron in the nova.conf.After creating a tenant and a new user belongs to the project,I create a VM on dashboard by using eth user.Then default security group was created in neutron.What makes me confused is that default security group is also stored in table security_groups of nova without uuid.01:13
*** ducttape_ has joined #openstack-nova01:14
suxiangAfter scanning source code of nova, I can't find where the action of storing default secrutiy group in table security_groups of nova happened.Can anybody tell me where it is?01:18
*** READ10 has joined #openstack-nova01:22
*** salv-orlando has joined #openstack-nova01:23
*** raunak has quit IRC01:25
*** salv-orlando has quit IRC01:26
*** ducttape_ has quit IRC01:28
*** trisq has joined #openstack-nova01:29
*** xinliang has quit IRC01:30
*** wuhg has joined #openstack-nova01:31
*** sdake has joined #openstack-nova01:32
*** wangqun has joined #openstack-nova01:35
*** ducttape_ has joined #openstack-nova01:36
*** armax has quit IRC01:36
*** xinliang has joined #openstack-nova01:38
*** openstack has joined #openstack-nova01:44
*** vladikr has quit IRC01:44
*** gouthamr has quit IRC01:48
*** gouthamr has joined #openstack-nova01:49
*** liuyulong|away is now known as liuyulong01:49
*** baoli has joined #openstack-nova01:50
*** baoli has quit IRC02:08
*** bkopilov has quit IRC02:10
*** bkopilov_ has quit IRC02:10
*** tuanla_ has joined #openstack-nova02:12
openstackgerritDao Cong Tien proposed openstack/nova: Enable py3 tests for unit.api.openstack.compute.test_console_output  https://review.openstack.org/31667802:13
*** dimtruck is now known as zz_dimtruck02:14
*** hoangcx has quit IRC02:16
*** raunak has joined #openstack-nova02:16
*** ociuhandu has joined #openstack-nova02:18
*** hoangcx has joined #openstack-nova02:19
*** yamahata has quit IRC02:21
*** Swami has quit IRC02:25
*** ociuhandu has quit IRC02:26
gongyshalex_xu, hi02:29
alex_xugongysh: hi02:29
gongyshhi02:30
*** ociuhandu has joined #openstack-nova02:30
gongysh  nova/policy.json is empty02:30
gongyshhow does it do authz?02:30
alex_xuyea, all of those move to central place, nova/policies02:30
*** READ10 has quit IRC02:31
gongyshalex_xu, where? the keystone?02:31
gongyshalex_xu, it gets it from keystone?02:31
alex_xugongysh: nothing changed for keystone02:31
alex_xugongysh: just move the default policy rule into the python code02:31
*** ducttape_ has quit IRC02:31
*** jdurgin1 has quit IRC02:32
*** ducttape_ has joined #openstack-nova02:32
alex_xugongysh: there is a tools you can generate the policy.json sample file just like oslo.config02:32
*** salv-orlando has joined #openstack-nova02:33
alex_xugongysh: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/policy-in-code.html02:34
*** ociuhandu has quit IRC02:34
*** ducttape_ has quit IRC02:34
*** armax has joined #openstack-nova02:34
*** baoli has joined #openstack-nova02:37
*** vishwana_ is now known as vishwanathj_zzz02:38
gongyshalex_xu, why does not nova provide one place to do authz checking?02:41
gongyshalex_xu, the context.can is everywhere.02:41
alex_xugongysh: need mapping to the each url?02:41
gongyshalex_xu, some kind of it.02:42
alex_xugongysh: there is target in the context.can parameter02:42
*** raunak has quit IRC02:42
alex_xuyou need get the target from the db02:42
alex_xuotherwise, as you said, just enforce the policy in one place02:43
gongyshalex_xu, in neutron, there is a layer after the API URL mapping, to do the authz.02:43
*** mingyu has joined #openstack-nova02:43
*** salv-orlando has quit IRC02:43
alex_xugongysh: yea, but the code structure different with neutron02:43
gongyshalex_xu, there is no policy checking in other codes.02:43
*** raunak has joined #openstack-nova02:44
*** raunak has quit IRC02:45
*** felix23ma has quit IRC02:47
*** tjones has joined #openstack-nova02:48
*** tjones has left #openstack-nova02:50
*** hoangcx has quit IRC02:51
*** hoangcx has joined #openstack-nova02:54
*** raunak has joined #openstack-nova02:54
gongyshalex_xu, hi02:56
alex_xugongysh: yea02:56
gongyshalex_xu.  does normal user create flavor?02:56
alex_xugongysh: no02:56
*** ducttape_ has joined #openstack-nova02:56
*** ociuhandu has joined #openstack-nova03:14
*** raunak has quit IRC03:19
*** ociuhandu has quit IRC03:19
*** hoangcx has quit IRC03:27
*** bkopilov_ has joined #openstack-nova03:28
*** bkopilov has joined #openstack-nova03:28
*** ociuhandu has joined #openstack-nova03:29
*** mingyu has quit IRC03:32
*** mingyu has joined #openstack-nova03:32
*** ociuhandu has quit IRC03:34
*** hoangcx has joined #openstack-nova03:35
*** ducttape_ has quit IRC03:35
*** tongli has quit IRC03:38
*** raunak has joined #openstack-nova03:40
*** salv-orlando has joined #openstack-nova03:42
*** rfolco has joined #openstack-nova03:44
*** bhagyashri has joined #openstack-nova03:47
*** rfolco has quit IRC03:47
*** salv-orlando has quit IRC03:49
*** thorst has quit IRC03:53
*** thorst has joined #openstack-nova03:53
*** thorst has quit IRC03:58
*** thorst has joined #openstack-nova03:59
*** jgriffith is now known as jgriffith_away04:00
*** baoli has quit IRC04:01
*** ociuhandu has joined #openstack-nova04:03
*** lpetrut has joined #openstack-nova04:03
*** thorst has quit IRC04:04
*** GB21 has joined #openstack-nova04:05
*** ssurana has joined #openstack-nova04:06
*** sudipto has joined #openstack-nova04:07
*** sudipto_ has joined #openstack-nova04:07
*** ociuhandu has quit IRC04:08
*** thorst has joined #openstack-nova04:15
*** code-R has joined #openstack-nova04:19
*** rfolco has joined #openstack-nova04:20
*** RuiChen has quit IRC04:21
*** amotoki has joined #openstack-nova04:23
*** oanson has joined #openstack-nova04:23
*** links has joined #openstack-nova04:28
*** sudipto has quit IRC04:29
*** sudipto_ has quit IRC04:29
*** harlowja_at_home has joined #openstack-nova04:29
*** lpetrut has quit IRC04:30
*** markvoelker has quit IRC04:30
*** thorst has quit IRC04:30
*** markvoelker has joined #openstack-nova04:31
*** ekuris has joined #openstack-nova04:32
*** prateek has joined #openstack-nova04:32
*** prateek_ has joined #openstack-nova04:32
*** thorst has joined #openstack-nova04:33
*** hieulq has quit IRC04:35
*** GB21 has quit IRC04:35
*** hieulq has joined #openstack-nova04:35
*** ducttape_ has joined #openstack-nova04:36
*** prateek has quit IRC04:36
*** irenab has quit IRC04:37
*** shangxdy has joined #openstack-nova04:37
*** thorst has quit IRC04:38
*** diga has joined #openstack-nova04:38
*** dikonoor has joined #openstack-nova04:39
*** woodster_ has quit IRC04:39
*** can8dnSix has joined #openstack-nova04:40
*** ducttape_ has quit IRC04:40
*** fragatina has joined #openstack-nova04:41
*** fragatina has quit IRC04:45
*** GB21 has joined #openstack-nova04:51
*** salv-orlando has joined #openstack-nova04:52
*** gongysh has quit IRC04:52
*** dikonoor has quit IRC04:54
*** mfedosin has joined #openstack-nova04:55
*** dikonoor has joined #openstack-nova04:56
*** shangxdy has quit IRC04:56
*** sdake has quit IRC04:56
*** code-R_ has joined #openstack-nova04:57
*** akshai has quit IRC04:58
*** moshele has joined #openstack-nova04:58
*** salv-orl_ has joined #openstack-nova04:59
*** salv-orl_ has quit IRC04:59
*** salv-orlando has quit IRC04:59
*** mingyu has quit IRC04:59
*** salv-orlando has joined #openstack-nova05:00
*** sdake has joined #openstack-nova05:00
*** code-R has quit IRC05:00
*** Jeffrey4l__ has joined #openstack-nova05:00
*** lixiaoy1 has joined #openstack-nova05:01
*** Jeffrey4l_ has quit IRC05:03
*** sudipto has joined #openstack-nova05:06
*** sudipto_ has joined #openstack-nova05:06
*** thorst has joined #openstack-nova05:07
*** code-R_ has quit IRC05:08
*** thorst has quit IRC05:09
*** can8dnSix has quit IRC05:10
*** jaosorior has joined #openstack-nova05:10
*** unicell has joined #openstack-nova05:13
*** GB21 has quit IRC05:14
*** mfedosin has quit IRC05:15
*** ratailor has joined #openstack-nova05:15
*** unicell has quit IRC05:16
*** unicell has joined #openstack-nova05:16
*** nkrinner_afk is now known as nkrinner05:16
*** Shashi has joined #openstack-nova05:19
*** unicell1 has joined #openstack-nova05:22
*** unicell has quit IRC05:23
*** GB21 has joined #openstack-nova05:27
*** phuongnh has joined #openstack-nova05:29
*** links has quit IRC05:31
*** rfolco has quit IRC05:32
*** raj_singh_ has quit IRC05:32
*** mamandle has joined #openstack-nova05:33
*** dikonoor has quit IRC05:33
*** PaulMurray has joined #openstack-nova05:33
*** ducttape_ has joined #openstack-nova05:37
*** John341 has joined #openstack-nova05:40
*** ducttape_ has quit IRC05:41
John341Hi, I'm not sure if this is a bug or not: Why does 'nova quota-show --tenant ID' give different number of volumes, than 'openstack quota show ID', this causes my newly created projects and users not being able to provision VMs?05:42
*** links has joined #openstack-nova05:46
*** harlowja_at_home has quit IRC05:46
*** code-R has joined #openstack-nova05:47
*** dikonoor has joined #openstack-nova05:48
*** lpetrut has joined #openstack-nova05:50
*** raj_singh_ has joined #openstack-nova05:50
*** gcb has joined #openstack-nova05:52
*** fragatina has joined #openstack-nova05:52
*** code-R_ has joined #openstack-nova05:55
*** raj_singh_ has quit IRC05:55
*** gouthamr has quit IRC05:55
*** sdake_ has joined #openstack-nova05:56
*** fragatina has quit IRC05:56
gcbalex_xu,  can you look at a simple patch to remove deprecated config option , it's nice to have it done in Newton   https://review.openstack.org/31954305:56
*** gouthamr has joined #openstack-nova05:56
*** thorst has joined #openstack-nova05:57
*** code-R has quit IRC05:57
*** sdake has quit IRC05:58
*** thorst_ has joined #openstack-nova05:58
*** code-R_ has quit IRC06:00
*** thorst_ has quit IRC06:00
*** thorst has quit IRC06:01
*** dikonoor has quit IRC06:03
*** thorst has joined #openstack-nova06:03
*** annp has joined #openstack-nova06:04
*** paul-carlton2 has joined #openstack-nova06:07
*** PaulMurray has quit IRC06:07
ShashiHello, I created devsatck and configured backend sucessfully. Now when I am trying to create an Instance, I am gettinng error as "Instance failed network setup after 1 attempt"06:09
ShashiCan anyone help me out here?06:10
*** unicell has joined #openstack-nova06:10
*** unicell1 has quit IRC06:13
*** baoli has joined #openstack-nova06:13
*** baoli has quit IRC06:17
*** gongysh has joined #openstack-nova06:20
*** liverpooler has quit IRC06:21
*** mamandle has quit IRC06:21
*** unicell1 has joined #openstack-nova06:24
*** unicell has quit IRC06:24
*** hoonetorg has quit IRC06:25
*** mjura has joined #openstack-nova06:25
*** yamahata has joined #openstack-nova06:26
*** ttrumm_ has joined #openstack-nova06:27
*** gongysh has quit IRC06:37
*** ducttape_ has joined #openstack-nova06:38
*** mingyu has joined #openstack-nova06:39
gmannjohnthetubaguy: alex_xu can you check this - https://review.openstack.org/#/c/354690/06:39
gmanni remove the policy overridden tests06:39
openstackgerritHa Van Tu proposed openstack/nova: [api-ref] Correct parameter type  https://review.openstack.org/36711706:41
openstackgerrithuan proposed openstack/nova: xenapi: support the hotplug of a neutron port  https://review.openstack.org/36550506:41
*** mamandle has joined #openstack-nova06:41
*** ducttape_ has quit IRC06:43
*** gouthamr_ has joined #openstack-nova06:47
*** tonytan4ever has quit IRC06:49
*** zenoway has joined #openstack-nova06:49
*** gouthamr has quit IRC06:51
*** nkrinner has quit IRC06:52
*** mamandle has quit IRC06:52
*** ttx has quit IRC06:54
*** salv-orlando has quit IRC06:54
*** sahid has joined #openstack-nova06:54
*** ttx has joined #openstack-nova06:54
*** hoangcx_ has joined #openstack-nova06:54
*** ttx has quit IRC06:54
*** ttx has joined #openstack-nova06:55
*** nkrinner has joined #openstack-nova06:55
*** hoangcx has quit IRC06:57
*** Jeffrey4l__ has quit IRC07:00
*** suxiang has quit IRC07:00
alex_xugmann: in a meeting, will check after meeting07:00
*** claudiub|2 has joined #openstack-nova07:01
*** trisq has quit IRC07:01
*** ttrumm_ has quit IRC07:01
*** ssurana has quit IRC07:01
*** trisq has joined #openstack-nova07:02
*** nkrinner has quit IRC07:02
*** Jeffrey4l__ has joined #openstack-nova07:02
*** tesseract- has joined #openstack-nova07:04
*** matrohon has joined #openstack-nova07:08
*** trisq has quit IRC07:08
*** ttrumm has joined #openstack-nova07:09
*** trisq has joined #openstack-nova07:09
*** ttrumm_ has joined #openstack-nova07:10
*** ttrumm has quit IRC07:13
*** trisq has quit IRC07:14
*** trisq has joined #openstack-nova07:15
*** nkrinner has joined #openstack-nova07:15
*** roeyc has joined #openstack-nova07:17
*** sridharg has joined #openstack-nova07:17
*** oomichi has quit IRC07:18
*** oomichi has joined #openstack-nova07:19
*** adisky has joined #openstack-nova07:21
*** lixiaoy1 has quit IRC07:21
*** liverpooler has joined #openstack-nova07:22
openstackgerritZhenyu Zheng proposed openstack/nova: Should not be able to sort instances based on joined tables  https://review.openstack.org/35913407:22
*** jlanoux has joined #openstack-nova07:24
*** maestropandy has joined #openstack-nova07:25
*** maestropandy has left #openstack-nova07:25
*** irenab has joined #openstack-nova07:28
*** armax has quit IRC07:29
*** lixiaoy1 has joined #openstack-nova07:31
*** ttrumm has joined #openstack-nova07:32
*** jed56 has joined #openstack-nova07:33
*** openstackgerrit has quit IRC07:33
*** openstackgerrit has joined #openstack-nova07:34
*** gouthamr_ has quit IRC07:35
*** raunak has quit IRC07:35
*** ttrumm_ has quit IRC07:35
*** RuiChen has joined #openstack-nova07:36
*** thorst has quit IRC07:36
*** ttrumm has quit IRC07:37
*** markus_z has joined #openstack-nova07:37
*** ihrachys has joined #openstack-nova07:39
*** nherciu has joined #openstack-nova07:40
*** hoangcx_ has quit IRC07:43
*** ihrachys has quit IRC07:45
*** tonytan4ever has joined #openstack-nova07:50
*** ttrumm has joined #openstack-nova07:51
*** edand has joined #openstack-nova07:52
gmannalex_xu: Thanks07:53
*** tonytan4ever has quit IRC07:54
*** andreas_s has joined #openstack-nova07:56
*** ttrumm has quit IRC07:56
*** karthiks has joined #openstack-nova07:57
*** hoangcx has joined #openstack-nova07:57
*** danpb has joined #openstack-nova07:58
*** mingyu has quit IRC07:59
*** salv-orlando has joined #openstack-nova07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** maestropandy has joined #openstack-nova08:00
*** yamahata has quit IRC08:01
*** salv-orlando has quit IRC08:01
*** paul-carlton2 has quit IRC08:01
*** ttrumm has joined #openstack-nova08:02
*** paul-carlton2 has joined #openstack-nova08:02
*** ttrumm_ has joined #openstack-nova08:03
*** ttrumm_ has quit IRC08:05
*** ttrumm has quit IRC08:05
*** paul-carlton2 has quit IRC08:06
* johnthetubaguy returns from unpacking boxes08:07
*** kaisers has joined #openstack-nova08:12
*** murali__ has quit IRC08:13
*** maestropandy has left #openstack-nova08:15
*** ajo_ has quit IRC08:16
*** sdake_ is now known as sdake08:17
*** sridhargaddam has joined #openstack-nova08:18
*** jogo has quit IRC08:20
*** Jeffrey4l__ has quit IRC08:20
*** ttrumm has joined #openstack-nova08:20
*** sridharg has quit IRC08:21
*** yassine has joined #openstack-nova08:23
*** salv-orlando has joined #openstack-nova08:23
*** yassine is now known as Guest5206808:23
*** dikonoor has joined #openstack-nova08:24
*** jogo has joined #openstack-nova08:25
*** paul-carlton2 has joined #openstack-nova08:25
*** salv-orl_ has joined #openstack-nova08:30
*** ihrachys has joined #openstack-nova08:31
*** salv-orlando has quit IRC08:33
wangqunHi all, I meet a bug when I set quota for a project. I am using kilo version of openstack.08:35
wangqunwhen I run the following command.08:35
wangqun openstack --debug quota set --volumes 20 623051a1ce4f417ea5b99e2bedca5e3908:36
wangqunIt will show the error.08:36
wangqun File "/usr/local/lib/python2.7/dist-packages/openstackclient/common/quota.py", line 124, in take_action08:36
wangqun**volume_kwargs)08:36
wangqunFile "/usr/local/lib/python2.7/dist-packages/cinderclient/v1/quotas.py", line 47, in update08:36
wangqunresult = self._update('/os-quota-sets/%s' % (tenant_id), body)08:36
wangqunI don't know how to fix the problem.08:37
wangqunCan anyone help me?08:37
wangqunping alex_xu08:40
*** jaosorior is now known as jaosorior_lunch08:40
*** moshele has quit IRC08:47
rpodolyakawangqun: that's an error in python-cinderclient and must have nothing to do with Nova08:48
*** moshele has joined #openstack-nova08:48
rpodolyakaunfortunately, it's only a part of the traceback, so it's hard to say what exactly went wrong08:48
*** gongysh has joined #openstack-nova08:48
*** raj_singh_ has joined #openstack-nova08:49
mdboothedleafe: Thank you for change I6173274a03! I know that's from ages ago, but last time I used that log message it wasn't remotely that useful.08:50
*** raj_singh_ has quit IRC08:53
*** derekh has joined #openstack-nova08:55
mdboothbauzas: I assume, btw, that DiskFilter not knowing that Rbd doesn't require local disk is a known issue. Under the ResourceProvider umbrella?08:56
*** thorst has joined #openstack-nova08:56
*** pilgrimstack1 has quit IRC08:57
danpbmdbooth: DiskFilter in general is utterly fubar with anything except 100% local non-shared disk08:58
mdboothdanpb: Was guessing as much :) Just checking.08:58
danpbiirc, recommendation is to not use DiskFilter08:59
* mdbooth anticipated the recommendation \o/08:59
*** code-R has joined #openstack-nova09:00
mdboothdanpb: Incidentally, I've now managed to get a 2G instance with 2 vcpus which can live migration in my devstack environment09:00
mdboothThis is what I'm going to use to try to usefully force post-copy09:00
*** thorst has quit IRC09:01
mdboothWith smaller disks it just wasn't getting anywhere09:01
*** pilgrimstack has joined #openstack-nova09:01
*** thorst has joined #openstack-nova09:01
mdboothIf this doesn't work I may switch the nics to something a bit slower09:01
mdboothdanpb: Does realtek support 1G?09:02
danpbeven with 1 Gig-E networking, if you use the stress program it should be possible to make migration fail with a mere 1 GB guest09:02
*** code-R_ has joined #openstack-nova09:02
danpbmdbooth: guest nic models have no bearing on migration success / failure09:03
mdboothI mean the virtual nic of the vm which is running the compute host09:03
*** maestropandy has joined #openstack-nova09:03
mdboothAssuming that if I switch those to something slower it'll all slow down09:03
danpboh right you're using nested virt09:03
mdboothYeah09:03
*** thorst has quit IRC09:04
*** jsheeren has joined #openstack-nova09:04
danpbmdbooth: setup a traffic filter on your guest nic09:04
danpbhttp://libvirt.org/formatnetwork.html#elementQoS09:04
danpbthe 'peak' attribute can be used to throttle it09:04
mdboothdanpb: Ooh, nice09:04
*** code-R has quit IRC09:05
openstackgerritZhenyu Zheng proposed openstack/nova: Should not be able to sort instances based on joined tables  https://review.openstack.org/35913409:09
*** thorst has joined #openstack-nova09:09
*** lixiaoy1 has quit IRC09:12
*** thorst has quit IRC09:15
prateek_alex_xu, can you please look into https://review.openstack.org/#/c/327706/09:15
*** Jeffrey4l__ has joined #openstack-nova09:17
prateek_does anyone here has a link for setting up a devstack environ for live migration ? I am trying to set up using this http://docs.openstack.org/developer/devstack/guides/multinode-lab.html but am getting errors09:17
ratailoropenstack, can any core-reviewer pl review https://review.openstack.org/#/c/312887/09:18
*** sridharg has joined #openstack-nova09:19
*** thorst has joined #openstack-nova09:19
*** thorst has quit IRC09:20
*** lucasagomes is now known as lucas-relocate09:21
*** sridhargaddam has quit IRC09:22
mdboothdanpb: On a related note, my question yesterday about polling vs async notifications from libvirt09:25
mdboothAFAICT the only thing nova is doing today is polling09:25
mdboothWere you suggesting that there's a better way?09:25
*** Zoya has joined #openstack-nova09:26
danpbmdbooth: that's not true - nova listens for async events too09:26
ZoyaHi All,09:26
ZoyaI have an issue09:26
danpbmdbooth: when it constructs the nova.virt.libvirt.host.Host object09:26
mdboothdanpb: Do you happen to know where?09:26
* mdbooth looks there09:27
*** Zoya is now known as Guest6038109:27
danpbmdbooth: it passes in a callback that is invoked09:27
danpbthe Host object has a native thread that gets events from libvirt and dispatches them into the greenthread09:27
prateek_kashyap, can you please point me out to how you set up devstack for live migration ?09:27
mdboothdanpb: Ah, that gets stopped/started/paused/resumed09:27
danpbmdbooth: you'll need to extend the Host object though, as currently it only reports out the event type09:27
danpbmdbooth: and discards the event reason09:28
mdboothSo, the live migration monitor loop is polling for this info09:28
danpbs/reason/detail/09:28
mdboothPractically speaking, I'm going to have to stick with the polling approach for now, I think09:28
danpband you'd need the detail to see that the pause/resume event was triggered by post-copy09:28
mdboothBecause mixing polling and async is a nightmare I don't want just for this09:28
alex_xuwangqun: you should file a bug and put all the error info into the bug report first09:28
danpbwell if you're doing this inside the live migration monitor thread09:28
mdboothdanpb: But it sounds like the whole loop could be replaced with async?09:28
danpbthen you don't need to poll either09:29
alex_xuprateek_: yea, will try to reach that tonight09:29
kashyapprateek_: Some configs and notes are here - https://kashyapc.fedorapeople.org/virt/openstack/multi-node-configs/09:29
danpbbecause that thread knows exactly when it invokes the switch to post-copy09:29
prateek_alex_xu, ok09:29
Guest60381while booting a vm in Single server environment using flavor with extra_specs,getting this error:09:29
prateek_kashyap, thanks09:29
Guest60381{"message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance 2444e8c5-fa03-43bf-8941-b513e07e2b75. Last exception: XML error: Element 'memnode' is invalid without any guest NUMA cells", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/conductor/manager.py\", line 393, in build_instances09:29
*** PaulMurray has joined #openstack-nova09:29
Guest60381can anyone help me out09:29
wangqunalex_xu: Thanks. I will do it.09:29
mdboothdanpb: Right. But the loop itself polls.09:29
mdboothIt polls get_job_info()09:30
mdboothI guess if all of the state changes it's looking for have associated events, we could replace the polling09:30
danpbno, afraid not, because the loop does much more stuff that's not related to state transitiions09:30
danpbeg it is dynamically changing max downtime throughout the migration process09:31
mdboothOk, cool.09:31
danpbas well as updating progress data on the migration object09:31
mdboothI don't see any reason to do the networking stuff anywhere else, btw.09:31
danpbyeah, makes sense09:31
*** praveen has joined #openstack-nova09:32
*** jsheeren has quit IRC09:33
*** thorst has joined #openstack-nova09:37
*** thorst has quit IRC09:38
*** thorst has joined #openstack-nova09:38
ratailorjohnthetubaguy, could you pl review https://review.openstack.org/#/c/312887/09:38
*** thorst has quit IRC09:39
*** thorst has joined #openstack-nova09:40
*** ducttape_ has joined #openstack-nova09:41
*** pilgrimstack has quit IRC09:42
*** diga has quit IRC09:43
*** mvk has quit IRC09:43
*** mfedosin has joined #openstack-nova09:45
*** pilgrimstack has joined #openstack-nova09:45
*** ducttape_ has quit IRC09:46
*** thorst has quit IRC09:51
Guest60381Hi All09:52
Guest60381getting this error while nova booting:09:53
Guest60381{"message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance 2444e8c5-fa03-43bf-8941-b513e07e2b75. Last exception: XML error: Element 'memnode' is invalid without any guest NUMA cells", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/conductor/manager.py\", line 393, in build_instances09:53
Guest60381using flavor with extra specs09:53
Guest60381can anyone help me out09:53
sfinucanGuest60381: what version of nova?09:53
openstackgerritGleb Stepanov proposed openstack/nova: Pin HTTP response codes to API microversions  https://review.openstack.org/30536909:55
Guest60381<sfinucan> Its 13.0.009:55
Guest60381I think its problem with flavor09:56
sfinucanGuest60381: Can you paste and share a copy of your flavor ('openstack flavor show') here http://paste.openstack.org/09:56
Guest60381as I have included extra specs09:56
sfinucanGuest60381: yeah, but AFAICT nova should stop you doing something silly like that09:56
sfinucan:)09:56
ratailorjohnthetubaguy, thanks :)09:57
Guest60381<sfinucan> http://paste.openstack.org/show/569086/09:57
Guest60381<sfinucan>: Do I need to set anything related to nova09:58
sfinucanGuest60381: Thanks. Ok, drop the hugepages extra_spec first and see if that boots09:58
Guest60381I have disabled this09:59
sfinucanGuest60381: no, if you're using upstream nova with the libvirt driver then it should just work (TM)09:59
*** annp has quit IRC09:59
*** kevinz has joined #openstack-nova09:59
Guest60381ok..fine10:01
sfinucanGuest60381: so you're flavor should look exactly the same but without the 'hw:mem_page_size' parameter. Does that boot?10:01
sfinucan*your10:01
Guest60381<sfinucan> Sorry I dn't know.. iam new to this concept :)10:04
sfinucanGuest60381: just create a new flavour like before but without that parameter :)10:04
*** lucas-relocate is now known as lucasagomes10:05
Guest60381<sfinucan> without extra_specs parameters to flavor, nova boot was successful10:05
*** GB21 has quit IRC10:05
sfinucanGuest60381: OK. Now create a new flavor with all the extra specs except for 'hw:mem_page_size' and boot with that10:06
*** liuyulong is now known as liuyulong|away10:06
*** gszasz has joined #openstack-nova10:06
Guest60381 <sfinucan> http://paste.openstack.org/show/569139/10:07
Guest60381with this flavor also, got the same error10:07
sfinucanGuest60381: I don't know if that's valid. I don't recognise the 'hw:cpu_list' parameter10:08
sfinucanGuest60381: something like this http://paste.openstack.org/show/569140/10:09
*** hoangcx has quit IRC10:10
danpbyeah, there is no such 'hw:cpu_list'  property in nova - perhaps that's some out of tree downstream vendor addition10:10
*** GB21 has joined #openstack-nova10:11
Guest60381<sfinucan> Without this "hw:cpu_list" parameter, able to boot the Vm10:12
Guest60381:)10:13
Guest60381Thanks a lot10:13
*** mvk has joined #openstack-nova10:13
sfinucanGuest60381: np. Out of curiosity, where did you find the 'hw:cpu_list' parameter documented?10:14
Guest60381Didn't remember..but i got to know from my colleague10:15
rpodolyakajohnthetubaguy: thanks for review! could you please take a look at the follow up patch https://review.openstack.org/347948 ?10:18
johnthetubaguyrpodolyaka: yeah, sorry I got distracted, getting back to that in a sec10:19
rpodolyakano worries! just want to make sure you don't miss it :P10:20
*** sridhargaddam has joined #openstack-nova10:20
*** gongysh has quit IRC10:21
*** sridharg has quit IRC10:23
mdboothdanpb: I think I must have fundamentally misunderstood the post-copy networking problem, because I can't reproduce it.10:26
*** cdent has joined #openstack-nova10:26
*** ababich has joined #openstack-nova10:27
mdboothI'm assuming that neutron is not behaving as I expect, which presumably means I don't understand neutron :) (Not a surprise there)10:27
danpbmdbooth: what network setup as you using10:27
danpbi wouldn't be surprised if it didn't impact linux-bridge10:27
mdboothI can now reliably force post-copy10:27
mdboothBut 2 guests can continue to ping each other throughout10:27
mdboothEven when I deliberately hold-up the post job which should fix networking10:28
danpbmdbooth: how long is the guest in the post-copy phase for ?10:28
mdboothdanpb: Seconds10:28
*** cdent has quit IRC10:28
danpbok, long enough to see a ping delay10:28
mdboothLike, maybe 2 seconds10:28
mdboothHowever, I stuck a break point in the post job10:28
mdboothSo networking is not being reconfigured on the dest for an arbitrarily long time10:29
danpbso what neutron plugin have you got ?10:29
mdboothAnd during that time, networking continues to work10:29
mdboothAlready you're exceeding my neutron knowledge :)10:29
danpbok, does 'brctl show'  show a bridge device with your guest's nics in it10:29
mdboothYes10:30
danpbif so, you're using linuxbridge, if not, i guess  oopenvswitch10:30
mdboothOk, so I'm guessing I need to run the other one10:30
openstackgerritPaul Carlton proposed openstack/nova: Update instance group during live migration  https://review.openstack.org/33958810:30
danpbyeah, i get the feeling it might need openvswitch usage10:30
*** phuongnh has quit IRC10:30
mdboothOk. Is there a simple devstack switch to make it do that?10:30
danpbi had it working once10:31
danpb(with emphasis on the "once")10:31
mdboothHehe, ok10:31
* mdbooth sharpens his yak shears10:31
ShashiHello, I created devsatck and configured backend sucessfully. Now when I am trying to create an Instance, I am gettinng error as "Instance failed network setup after 1 attempt"10:34
ShashiCan anyone help me out here?10:34
mdboothdanpb: Is 'ml2' the linux bridge thing?10:36
danpbi don't think so10:37
danpbbut then i also don't entirely understand neutron terminologyu10:37
mdboothneutron appears to be configured to use 'ml2'10:37
kashyapmdbooth: "The Modular Layer 2 (ML2) neutron plug-in is a framework allowing OpenStack Networking to simultaneously use the variety of layer 2 networking technologies found in complex real-world data centers."10:38
kashyapmdbooth: This page explains it nicely -- http://docs.openstack.org/mitaka/networking-guide/config-ml2-plug-in.html10:38
mdboothkashyap: I just want to break it :)10:38
kashyap"Linux bridge" is one of the "type drivers"10:39
mdboothkashyap: Ah, ok.10:39
mdboothSo I want ml2 with open vswitch by the sounds of it10:39
kashyapdanpb: Yes10:40
kashyapErr, mdbooth, I mean10:40
kashyapThat's also what the default DevStack setup with Neutron gives you10:40
mdboothdanpb: Whoa, just got a soft-lockup on the host with the guest running your stress10:41
danpbmdbooth: the real host, or the virtual host10:41
openstackgerritEli Qiao proposed openstack/nova: Libvirt: Correct PERF_EVENTS_CPU_FLAG_MAPPING  https://review.openstack.org/36584210:41
mdbooththe level 1 virt host10:41
mdboothi.e. the vm which is hosting the guest10:41
mdbooththe vm which is running a vm containing the guest10:42
danpbcould be that vm was not scheduled by the real host10:42
*** tbachman has quit IRC10:42
*** andrey-mp has joined #openstack-nova10:42
mdboothFor 54s?10:42
*** ducttape_ has joined #openstack-nova10:42
mdboothWas stuck in khugepaged10:42
*** andrey-mp has left #openstack-nova10:43
mdboothI guess something could have triggered a ton of io10:43
*** wangqun has quit IRC10:46
*** ducttape_ has quit IRC10:47
*** amotoki has quit IRC10:48
kashyapmdbooth: Are you using F24 Kernels?10:48
mdboothkashyap: Yes10:49
mdboothWell, physical is running RHEL710:49
kashyapmdbooth: In the past I've reported upstream soft lockups, and they turned out to be real bugs -- https://bugzilla.kernel.org/show_bug.cgi?id=6949110:49
openstackbugzilla.kernel.org bug 69491 in kvm "Booting into a guest on Intel Haswell (bare-metal) throws soft lockups [qemu-system-x86:911]" [Normal,Resolved: code_fix] - Assigned to virtualization_kvm10:49
mdboothNested vms are both F2410:49
kashyapAh, baremetal is RHEL-710:49
johnthetubaguyrpodolyaka: quick question on that patch, why does it move to using request context, rather than admin context when listing ComputeNode objects?10:49
mdboothkashyap: So, there's a file called ml2_conf.ini10:50
mdboothwhich contains: mechanism_drivers = openvswitch,linuxbridge10:50
kashyapmdbooth: Yes, I was going to paste mine, the contents should look like this - http://paste.openstack.org/show/569150/10:50
kashyapThat's the output of `grep -v ^$ ml2_conf.ini | grep -v ^#`10:50
kashyapmdbooth: At the end you'd see an [ovs] section10:50
*** edand has quit IRC10:50
mdboothThat looks more complex than I need10:50
mdboothAlthough... that looks pretty much like the default, no?10:51
kashyapmdbooth: Exactly, you don't have to muck with it.10:51
mdboothOk, so what I need is to kill all traces of linuxbridge10:51
*** sudipto has quit IRC10:52
*** sudipto_ has quit IRC10:52
*** PaulMurray has quit IRC10:52
*** dikonoor has quit IRC10:53
kashyapmdbooth: How did you end up with Linux Bridge (as opposed to OVS)?  Did you explicitly configure it?10:56
mdboothkashyap: No, I know nothing of neutron, so I touched nothing. Defaults all the way.10:56
kashyapHaving this in your local.conf should directly bring you OVS -- ENABLED_SERVICES= [...] quantum,q-svc,q-agt,q-dhcp,q-l3,q-meta10:56
*** baoli has joined #openstack-nova10:57
mdboothkashyap: I have that, and my setup is using neutron with ml210:58
rpodolyakajohnthetubaguy: iirc there was a comment in one of the previous patch sets that we do not really need an admin context, and elevated() is preferred10:58
*** cdent has joined #openstack-nova10:58
mdboothThe guests seem to be using linuxbridge, which seems to be something which ml2 also does10:58
johnthetubaguyrpodolyaka: sorry, found those comments now, I see what the other was updated now10:58
mdboothI'm just trying again with a configuration which explicitly removes 'linuxbridge' from the ml2 config10:58
kashyapAh, right.  Hope simply restarting Neutron services would suffice10:59
rpodolyakajohnthetubaguy: no problem!10:59
mdboothHeh, already blown everything away :)10:59
*** rpodolyaka is now known as rpodolyakaLunch10:59
mdboothJust coming back up, ml2_conf.ini now has:11:00
mdboothmechanism_drivers = openvswitch11:00
mdboothno linuxbridge11:00
*** bkopilov has quit IRC11:01
*** bkopilov_ has quit IRC11:02
*** baoli has quit IRC11:05
*** sdague has joined #openstack-nova11:06
*** jsheeren has joined #openstack-nova11:08
mdboothpaul-carlton2: Do you know anything about https://bugs.launchpad.net/nova/+bug/160501611:09
openstackLaunchpad bug 1605016 in OpenStack Compute (nova) "Post copy live migration interrupts network connectivity" [High,Confirmed] - Assigned to Matthew Booth (mbooth-9)11:09
mdboothSpecifically, how to reproduce it?11:09
jsheerenhi all11:09
paul-carlton2a bit11:09
mdboothI'm having trouble creating a neutron configuration which fails in the manner described.11:09
jsheerenwhen we launch an instane, nova updates the mtime for the _base image to let the image cache manager know the image is activaly used11:10
paul-carlton2mdbooth, I think the issue is that if the post copy phase take a while you will see a network outage11:10
jsheereni'm seeing errors in my nova compute log, where it cannot do this. triggering a reschedule on another compute node11:10
mdboothpaul-carlton2: That's the issue. I don't see an outage.11:10
mdboothjsheeren: Why would it not be able to do that?11:11
jsheerenfor my setup  i have 3 compute nodes. i'm seeing this error on all three compute nodes11:11
mdboothjsheeren: That's not an expected failure.11:11
paul-carlton2mdbooth, suspect in most test scenarios the post copy phase lasts a second or so11:11
jsheerenwell, that 's why I'm here :-)11:11
jsheerenwe're using an nfs export for shared storage11:11
mdboothjsheeren: What is the failure when it tries to update the mtime?11:11
mdboothpaul-carlton2: Nah, I've artificially extended it.11:11
mdboothNo network outage at all.11:11
*** trisq has quit IRC11:12
jsheerenmbooth: Stderr: u"/bin/touch: setting times of '/var/lib/nova/instances/_base/79e34519bacb47ad6f64c4baca4d33fd5c57d34d': Input/output error11:12
jsheerenthis error particulary shows itself when launching multiple instances at once11:12
mdboothjsheeren: Can you normally touch one of those files?11:12
jsheerenyes11:12
jsheerenas nova user with rootwrap11:12
mdboothAt first touch I'd suspect a storage issue11:12
jsheerenand offcourse as root user11:12
jsheerenwe're using an nfs4.1 export11:13
paul-carlton2mdbooth, you sure it is not talking to source instance?11:13
*** baoli has joined #openstack-nova11:13
mdboothpaul-carlton2: Well the source instance shouldn't still be running, right?11:13
mdboothThat would be bad.11:13
jsheerencan it be that when launching say 20 instnaces at once, we're seeing some sort of race conditions?11:13
mdboothjsheeren: For sure, but I wouldn't expect a race to manifest like that.11:14
*** kevinz has quit IRC11:14
paul-carlton2mdbooth, it should pause it when it switches to post copy I'd have thought but worth checking11:14
mdboothFor a race failure I'd expect something like trying to update the mtime on a file which doesn't exist.11:14
mdboothHowever io/error trying to touch a file which does exist...11:14
mdboothThat just smells like storage config to me11:15
jsheerenmbooth: using default nfs options, like local_lock=none.  so i would assume that would be safe enough11:15
jsheerencan it be we're experiencing some sort of latencies then?   (i'm not an nfs expert .heh)11:15
mdboothjsheeren: The question is why you get an io error when running touch11:16
paul-carlton2mdbooth, if you are connected to an instance via ssh and do a migration with extended post copy phase I'd expect the ssh session to freeze when past copy switch occurs, but if you check the source instance and find it is not paused then that would explain it11:16
prateek_johnthetubaguy, can you please review ?11:16
mdboothEPERM Or EEXIST would obviously be nova11:16
prateek_johnthetubaguy, can you please review https://review.openstack.org/#/c/294513/ ?11:17
mdboothpaul-carlton2: The issue as I understood it before I tried to reproduce11:17
mdboothIs that networking isn't reconfigured on the destination until the migration completes11:17
paul-carlton2yep11:18
mdboothSo, I stuck a breakpoint there11:18
mdboothThen I forced post-copy migration11:18
mdboothAnd hit my breakpoint11:18
paul-carlton2so at post copy you should see source paused, dest running, is that the case?11:18
jsheerenon a side note; because of the reschedules on other compute nodes, we get multiple private ips for the instances; which is annoying11:19
paul-carlton2i.e. once post copy switch is complete11:19
mdboothWell, when you hit the breakpoint the migration is complete11:19
mdboothBut networking has not yet been reconfigured11:19
*** maestropandy has quit IRC11:19
mdboothFor non-post-copy this happens straight away11:19
jsheerenthis is similar to bug https://bugs.launchpad.net/nova/+bug/160952611:19
openstackLaunchpad bug 1609526 in OpenStack Compute (nova) "nova should clean up network ports when an image fails to download from glance" [Undecided,Confirmed] - Assigned to Zhenyu Zheng (zhengzhenyu)11:19
mdboothFor post-copy the delay could be longer11:19
*** baoli has quit IRC11:19
mdboothHowever, in either case, networking should work yet, right?11:19
mdbooths/should/shouldn't/11:20
paul-carlton2mdbooth, you know the libvirt/qemu code better than me but surely you need the breakpoint after switch to target instance but before all remaining pages of memory are copied11:20
openstackgerritjichenjc proposed openstack/nova: no instance info cache update if instance deleted  https://review.openstack.org/36358511:20
*** coolsvap is now known as _coolsvap_11:21
mdboothpaul-carlton2: Unless I'm still misunderstanding (possible!) libvirt/qemu is irrelevant here11:21
mdboothBecause networking shouldn't work until post_live_migration completes11:21
mdboothThat should be true for post-copy or non-post-copy11:21
*** sridharg has joined #openstack-nova11:22
mdboothThe additional complication for post-copy is that we do the switch before the migration completes11:22
mdboothSo in the intervening period we have no networking11:22
mdboothExcept that we do11:22
paul-carlton2mdbooth, as I understand it the issue is that at present nova fires of libvirt/qemu migration and waits for it complete then when it is done switches networking11:22
openstackgerritjichenjc proposed openstack/nova: prevent non-admin user search soft-delete server  https://review.openstack.org/25847211:22
*** salv-orl_ has quit IRC11:22
mdboothRight, so I stuck the breakpoint before the code which switches the networking11:22
mdboothSo I've got a migrated guest whose networking has not yet been switched11:23
*** dikonoor has joined #openstack-nova11:23
mdboothBut its networking still works anyway11:23
*** sridhargaddam has quit IRC11:24
*** baoli has joined #openstack-nova11:24
paul-carlton2mdbooth, if post copy is used then at some point during processing of live migration by qemu it is told by nova to switch to post copy mode at which poit it should pause the source instance and resume the target instance so target is now active instance and starts doing work11:24
paul-carlton2however at this point network is still connected to source instance11:24
*** roeyc has quit IRC11:25
mdboothjsheeren: I believe there are lots of races in that code, btw. What you're describing may be the symptom of a bug in Nova, but unless we can work out why an NFS operation returns EIO, we don't have much chance of working out what's going on.11:25
mdboothAnd it's also possible it's not a Nova bug at all, just a storage configuration error.11:25
mdboothpaul-carlton2: Right, but it works anyway.11:25
paul-carlton2mdbooth, if source instance is paused then the open connections will hang and new attemptes will fail, is that not what you are seeing?11:26
mdboothpaul-carlton2: So, iiuc this has nothing to do with the source instance.11:27
mdboothAnd in fact, post-copy is an irrelevance, as at this point in the code the migration has completed11:27
mdboothSo, lets ignore post-copy for a moment.11:27
mdboothThe migration has completed11:27
*** rtheis has joined #openstack-nova11:27
mdboothAt this point, the guest is running on the destination, but its networking has not been reconfigured yet11:27
mdboothMy expectation was that guest networking would not work11:28
mdboothHowever, it does11:28
*** dikonoor has quit IRC11:28
*** dikonoor has joined #openstack-nova11:29
paul-carlton2mdbooth, yes if you let libvirt/qemu complete migration but prevent nova from switching network then networking is still connected to source instance11:29
danpbpaul-carlton2: that's not in itself a problem11:29
mdboothpaul-carlton2: Yes, that's exactly what's so confusing11:29
mdboothBecause despite that, it still works11:29
danpbIIUC it is only an issue for network topologies where neutron must manually switch a port to being active11:29
mdboothSo, has neutron created us a bridge which it has previously spanned across both hosts?11:30
danpblinux bridge for example "just works" with no manual steps required as bridges just learn the new topology when qemu sends the gratuitous ARP after migration11:30
paul-carlton2mdbooth, I had imagined that when libvirt sees migration by qemu complete it pauses (or destroys) source and unpauses target, no?11:30
*** baoli has quit IRC11:30
mdboothSo when the migrated guest connects to it, it can already arp11:30
danpbi think its only an issue for network systems can't can't automatically re-configure themsellves based on he ARP11:30
mdboothpaul-carlton2: So, I think what danpb is describing is that this issue is completely irrelevant if you're using bridging.11:32
mdboothI was wondering if anybody in your team had a reproducer11:33
mdboothWhich would presumably involve a different neutron setup.11:33
mdboothI'm hoping to shortcut working out the neutron config11:33
*** fragatina has joined #openstack-nova11:36
paul-carlton2mdbooth, not sure anyone here has worked on this, you'd need a neutron networking setup such that the source and destination compute hosts require different routing to access instance11:37
*** gongysh has joined #openstack-nova11:37
*** zenoway has quit IRC11:37
paul-carlton2mdbooth, afraid I don't know enough about networking to know how to create such a scenario, could you just supress arp'ing?11:38
mdboothI think I'm going to have to go ask the neutron folks11:38
paul-carlton2mdbooth, good plan, by the way it seems arp suppression is easy http://linux-ip.net/html/ether-arp.html11:40
*** dikonoor has quit IRC11:40
*** fragatina has quit IRC11:41
*** panbalag has joined #openstack-nova11:43
*** baoli has joined #openstack-nova11:43
*** ducttape_ has joined #openstack-nova11:43
openstackgerritAlex Xu proposed openstack/nova: Ensure ResourceProvider/Inventory created before add Allocations record  https://review.openstack.org/36730711:44
*** rfolco has joined #openstack-nova11:44
*** ducttape_ has quit IRC11:48
*** lucasagomes is now known as lucas-hungry11:48
*** tonytan4ever has joined #openstack-nova11:51
*** jsheeren has quit IRC11:51
*** links has quit IRC11:52
*** jaosorior_lunch is now known as jaosorior11:56
*** tonytan4ever has quit IRC11:56
*** baoli_ has joined #openstack-nova11:56
*** baoli has quit IRC12:00
*** rpodolyakaLunch is now known as rpodolyaka12:02
openstackgerritLudovic Beliveau proposed openstack/nova: PCI: Fix PCI with fully qualified address  https://review.openstack.org/36388412:05
*** jsheeren has joined #openstack-nova12:09
*** kylek3h_ has joined #openstack-nova12:09
*** mriedem has joined #openstack-nova12:10
*** ducttape_ has joined #openstack-nova12:11
*** kylek3h has quit IRC12:12
*** takedakn has joined #openstack-nova12:13
*** kylek3h_ has quit IRC12:13
mriedemtonyb: claudiub|2: mikal: can i get you to take a look at this mitaka backport that's holding up another backport that sits on top of it? https://review.openstack.org/#/c/357566/12:16
mriedemBobBall: is something up with the citrix xenserver ci? it's failing a lot recently it seems12:16
mriedemBobBall: i guess i'm seeing different issues in each failure run i'm seeing, so maybe it's just random12:18
mriedemwznoinsk: is the intel nfv ci supposed to be running on stable/liberty12:18
mriedem?12:18
*** thomasem has quit IRC12:18
wznoinskmriedem: it's disabled at the moment as it was giving rubbish results, I still need to look into it12:19
mriedemwznoinsk: ok it ran on https://review.openstack.org/#/c/366996/ yesterday and failed12:19
wznoinskchecking12:20
*** wuhg has quit IRC12:21
*** thomasem has joined #openstack-nova12:22
*** sridhargaddam has joined #openstack-nova12:22
*** pradk has joined #openstack-nova12:22
BobBallmriedem: http://ci-watch.tintri.com/project?project=nova doens't seem to show a consistent issue?12:24
BobBallmriedem: Got a linky I can look at?12:24
wznoinskmriedem: I see a misconfig there, I'll ping you when it's fixed12:24
*** gcb has quit IRC12:24
BobBallmriedem: Or is this just on stable branches?12:25
BobBallmriedem: We know that we broke stable branches a few days ago - but fixed it today after Tony highlighted the issue (we were relying on some changes that haven't been backported)12:25
*** praveen has quit IRC12:25
*** sridharg has quit IRC12:26
*** xinliang has quit IRC12:26
*** bkopilov_ has joined #openstack-nova12:27
*** kevinz has joined #openstack-nova12:28
*** toure has joined #openstack-nova12:28
mriedemBobBall: https://review.openstack.org/#/c/366994/12:29
*** bkopilov has joined #openstack-nova12:29
mriedemthere was a stable/liberty devstack failure yesterday, that looked like a mirror issue12:29
mriedemwznoinsk: thanks12:30
BobBallOK - that latest failure is the one I mentioned we fixed this morning after Tony highlighted it12:30
BobBallIt would have failed all stable branches I believe12:31
BobBallThe devstack failure yesterday was fixed by a recheck; just a transient issue I guess12:31
*** mdrabe has joined #openstack-nova12:31
*** tbachman has joined #openstack-nova12:31
*** EinstCrazy has joined #openstack-nova12:31
BobBallCorrection - the devstack failure was actually 3 weeks ago - hence the recheck to get a relatively recent attempt12:32
*** akshai has joined #openstack-nova12:32
BobBallSee https://review.openstack.org/#/c/358152/ for the pass12:32
*** lpetrut has quit IRC12:33
BobBallSo I'm going to say that I think everything is OK ATM? :)12:33
johnthetubaguymriedem: I can take a peak at that backport for you12:34
mriedemBobBall: since i'm not seeing a pattern of the same failures i guess they are just random yeah12:35
prateek_alex_xu, or anyone willing to answer :), one question suppose I have an operation throwing 500 and the correct error code is 409, which needs a microversion, so can i map the error to 400 error code and handle that ?12:35
*** kevinz has quit IRC12:35
*** kevinz has joined #openstack-nova12:35
*** akshai_ has joined #openstack-nova12:36
*** su_zhang has joined #openstack-nova12:36
mriedemjohnthetubaguy: thanks12:36
*** ducttape_ has quit IRC12:36
BobBallmriedem: Do let me know if you see something though - we are enabling more tests ATM and while we haven't seen any increase in races (other than the stable branches, which we fixed today), it's quite possible that there are some.12:36
*** GB21 has quit IRC12:36
*** lucas-hungry is now known as lucasagomes12:38
johnthetubaguymriedem: got all moved house now, so I am back around, let me know if there are urgent things, currently going through patches with +2s already, seeing which ones are ready to go12:38
alex_xuprateek_: the change from 500 to 409 needn't microversion12:38
*** akshai has quit IRC12:39
alex_xumriedem: morning, I have one patch for back-port https://review.openstack.org/36461312:39
*** xinliang has joined #openstack-nova12:40
*** tbachman has quit IRC12:41
*** cdelatte has joined #openstack-nova12:42
mriedemalex_xu: ok, we could almost just ignore that since i doubt anyone is using it, given we didn't even know it existed until 2.3612:42
*** kylek3h has joined #openstack-nova12:42
openstackgerritLudovic Beliveau proposed openstack/nova: Don't parse PCI whitelist eveytime neutron ports are created  https://review.openstack.org/33723612:43
bauzasmriedem: do you know the OSC project name in Launchpad ? I need to punt https://bugs.launchpad.net/nova/+bug/1621391 to those folks12:45
openstackLaunchpad bug 1621391 in OpenStack Compute (nova) "Error "Could not find resource cirros" even image is created" [Undecided,New]12:45
prateek_alex_xu, https://github.com/openstack/nova/blob/master/doc/source/api_microversion_dev.rst says "When fixing 500 errors that previously caused stack traces, try to map the new error into the existing set of errors that API call could previously return (400 if nothing else is appropriate). Changing the set of allowed status codes from a request is changing the contract, and should be part of a microversion (except in [2]).," So that12:45
prateek_means that a patch does not adhere to this, is it ?12:45
mriedembauzas: https://bugs.launchpad.net/python-openstackclient12:46
*** maestropandy has joined #openstack-nova12:46
*** burgerk has joined #openstack-nova12:46
mriedemalex_xu: +W12:46
* bauzas owes some stuff for mriedem 12:47
*** tbachman has joined #openstack-nova12:47
*** amotoki has joined #openstack-nova12:48
mriedemi'll accept payment in cheese form12:48
*** diana_clarke has joined #openstack-nova12:49
*** mmedvede has quit IRC12:49
bauzasmriedem: you're fortunate that Barcelona is in the Schengen area12:49
*** jaosorior has quit IRC12:51
*** jaosorior has joined #openstack-nova12:51
*** vladikr has joined #openstack-nova12:53
bauzasdoes someone know a bit of noVNC ?12:53
bauzashttps://bugs.launchpad.net/nova/+bug/1621257 claims there is a regression but I'd bet it's unrelated to Nova, rather to the novnc package12:53
openstackLaunchpad bug 1621257 in OpenStack Compute (nova) "VNC console keeps reporting "setkeycodes 00" exception" [Undecided,New]12:53
*** dikonoor has joined #openstack-nova12:54
mriedembauzas: the only person i know of was solly ross12:54
mriedemwho no longer works on it12:54
*** maestropandy has quit IRC12:54
bauzasyeah...12:55
* bauzas looking at the last commits12:55
*** ratailor has quit IRC12:55
*** cleong has joined #openstack-nova12:56
openstackgerritSean Dague proposed openstack/nova: Additional logging for placement API  https://review.openstack.org/36618612:56
*** xyang1 has joined #openstack-nova12:57
*** liverpooler has quit IRC12:58
*** migi has quit IRC13:00
openstackgerritSean Dague proposed openstack/nova: Additional logging for placement API  https://review.openstack.org/36618613:00
sdaguemriedem: ok, that logging patch should be ready to go13:00
*** maestropandy has joined #openstack-nova13:00
*** liverpooler has joined #openstack-nova13:01
*** tbachman has quit IRC13:02
*** pwnall has joined #openstack-nova13:03
*** pwnall is now known as Guest1916713:03
*** oanson has quit IRC13:04
alex_xumriedem: thanks13:04
alex_xuprateek_: oops, you are right, I missed that point13:04
*** prateek_ has quit IRC13:05
*** mingyu has joined #openstack-nova13:06
vladikrmriedem, Hi, wanted to ask about https://review.openstack.org/#/c/335676/ if you have a moment. seems to me that I'll do what you are asking for it won't be testable..13:06
*** tonytan4ever has joined #openstack-nova13:07
alex_xusdague: do we still follow this rule http://docs.openstack.org/developer/nova/api_microversion_dev.html#f1 ?13:07
*** tuanla_ has quit IRC13:07
*** raj_singh_ has joined #openstack-nova13:08
*** jheroux has joined #openstack-nova13:09
*** yamahata has joined #openstack-nova13:09
*** mingyu has quit IRC13:09
openstackgerritjichenjc proposed openstack/nova: Catch DevicePathInUse in attach_volume  https://review.openstack.org/36735813:10
mriedemvladikr: how is it that the code is not testable?13:10
mriedemw/o the refactor?13:11
*** tblakes has joined #openstack-nova13:11
mriedemvladikr: i don't really care if the refactor is before or after the bug fix, but it shouldn't be in the same change as the bug fix13:11
mriedemsdague: ok. breakfasting and then have to send my daughter off to the first day of kindergarten and try not to weep in public.13:12
*** jraju has joined #openstack-nova13:12
*** tonytan4ever has quit IRC13:12
mriedembut it's in a tab13:12
vladikrmriedem, yea, w/o sprinting that part out it will be very hard to test it. I'll split and make the fix on top. thanks13:13
*** raj_singh_ has quit IRC13:13
vladikrs/sprinting/splitting13:13
*** mingyu has joined #openstack-nova13:13
sdaguealex_xu: yeh, is there a patch up somewhere that you are questioning?13:13
mriedemvladikr: cool13:13
*** timello has quit IRC13:13
*** tonytan4ever has joined #openstack-nova13:14
alex_xusdague: thanks for confirm. no patch, just prateek ask me about that.13:15
*** jsheeren has quit IRC13:15
*** PaulMurray has joined #openstack-nova13:15
*** eharney has joined #openstack-nova13:15
*** su_zhang has quit IRC13:16
*** su_zhang has joined #openstack-nova13:16
*** mmedvede has joined #openstack-nova13:17
*** jsheeren has joined #openstack-nova13:17
*** su_zhang_ has joined #openstack-nova13:20
*** sdake_ has joined #openstack-nova13:20
*** timello has joined #openstack-nova13:20
*** su_zhang has quit IRC13:20
dikonoormriedem: Hi13:21
*** sdake has quit IRC13:22
*** jsheeren has quit IRC13:22
dikonoormriedem: I have a query about VM deploys using key-pair.13:22
*** jsheeren has joined #openstack-nova13:23
*** sridharg has joined #openstack-nova13:23
*** aloga_ has joined #openstack-nova13:24
dikonoormriedem: I am not sure who's the right person I should be talking to ..if you can let me know great..The VM deploy flow currently uses the user_id from the context object to fetch the key_name13:24
dikonoormriedem: and if there isn't a key with that name associated with that user, the deploy fails.13:24
*** yamahata has quit IRC13:25
dikonoormriedem: We have a specific case where we want the admin to be able to deploy VM for a user such that the key that corresponds to a user (other than the admin himself) is used.13:25
*** sridhargaddam has quit IRC13:26
dikonoormriedem: and that flow obviously does not work here.. An admin user can create a key-pair for a specific user but not use that key-pair to do deploys..13:27
*** ducttape_ has joined #openstack-nova13:28
*** liverpooler has quit IRC13:28
*** baoli_ has quit IRC13:29
openstackgerritSam Betts proposed openstack/nova: [WIP] Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441313:29
*** jsheeren_ has joined #openstack-nova13:30
*** liverpooler has joined #openstack-nova13:30
*** takedakn has quit IRC13:31
dikonooralex_xu: perhaps mriedem is not in yet.. Would you know whom I should be talking to on this ?13:32
*** mingyu has quit IRC13:32
*** jsheeren has quit IRC13:33
johnthetubaguyI think he has just headed out but he is back in a bit13:33
*** xenogear has quit IRC13:34
*** jinli has quit IRC13:34
*** MikeG451 has quit IRC13:34
*** stewie925 has quit IRC13:34
*** cmartin has quit IRC13:34
*** syjulian has quit IRC13:34
*** salv-orlando has joined #openstack-nova13:34
dikonoorjohnthetubaguy: Thanks..Would you be able to take my query ?13:34
johnthetubaguydikonoor: AFAIK, the admin can't create a vm on the users behalf at the moment, unless they can get an impersonation token13:34
johnthetubaguythe key pair stuff was more about listing and deleting them, I can't remember the specific use case now13:35
*** jsheeren_ has quit IRC13:35
*** stewie925 has joined #openstack-nova13:36
dikonoorjohnthetubaguy: yes..admin cannot because the key_name is mapped to another user.. the other way to get this working would be to pass a user_id attribute as part of the request body and use that to fetch the key-pair . If the user_id isn't present in the request, then use the user_id in the context13:37
johnthetubaguydikonoor: right, its an API feature we don't support today13:37
dikonoorjohnthetubaguy: this is similar to how key-pairs are created.13:37
cdentsdague: there's a potential wart in your logging patch, I offered up some ways out depending on your goal13:37
*** mingyu has joined #openstack-nova13:38
*** ttrumm has quit IRC13:38
dikonoorjohnthetubaguy: the create key-pair flow first checks if there's a userid in the request body .If not present, use it from the context13:38
*** gongysh has quit IRC13:38
*** ttrumm has joined #openstack-nova13:38
dikonoorhttp://developer.openstack.org/api-ref-compute-v2.1.html13:39
*** jamesdenton has joined #openstack-nova13:40
sdaguecdent: ah, yeh, the get_all_by_consumer_id sounds right13:40
sdaguecdent: let me respin that13:40
cdentsdague: sorry my comment is not quite correct13:40
*** ducttape_ has quit IRC13:40
dikonoorjohnthetubaguy: if we need to add support to consider the user_id in the request body so that admins can use the keys created by the users in a particular project , then would that be a nova defect or does it need like a blueprint?13:40
cdentyou can do the following three:13:41
johnthetubaguydikonoor: that needs to be a spec, its a new API feature13:41
*** ducttape_ has joined #openstack-nova13:41
dikonoorjohnthetubaguy : I mean for the deploy flow13:41
*** ducttape_ has quit IRC13:41
cdentAllocationList.get_all_by{consumer_id,resource_provider_uuid}, UsageList.get_all_by_resource..13:41
dikonoorjohnthetubaguy: ok..and If I am not wrong, specs are closed for newton and it has to be proposed for ocata13:41
cdentyou _can't_ do UsageList.get_all_by_consumer_id13:41
*** ducttape_ has joined #openstack-nova13:41
sdaguecdent: yeh, right, that just sunk in13:41
johnthetubaguydikonoor: I am not sure if keystone should be in charge of that kind of thing though, but thats a deeper discussion for the spec13:42
johnthetubaguydikonoor: thats correct, proposed of ocata is the option now13:42
*** salv-orlando has quit IRC13:42
*** ttrumm has quit IRC13:43
dikonoorjohnthetubaguy: ok ..sure..Thanks .. Will work on proposing a spec for this then..13:43
johnthetubaguydikonoor: cool, we can think through the details in there13:43
dikonoorjohnthetubaguy: sure13:44
*** hshiina has joined #openstack-nova13:44
johnthetubaguydikonoor: just curious, is this related to people who are admins creating instances, or other services creating instances?13:44
*** _ducttape_ has joined #openstack-nova13:44
*** _ducttape_ has quit IRC13:45
*** woodster_ has joined #openstack-nova13:45
dikonoorjohnthetubaguy: its the former... admins creating instance on behalf on other users within the same project13:45
*** _ducttape_ has joined #openstack-nova13:45
*** rlrossit has joined #openstack-nova13:47
*** roeyc has joined #openstack-nova13:47
*** ducttape_ has quit IRC13:48
*** jinli has joined #openstack-nova13:48
johnthetubaguydikonoor: OK, thanks, good to know13:48
*** xenogear has joined #openstack-nova13:50
*** brian_price has quit IRC13:50
*** bhagyashri has quit IRC13:51
dansmithsdague: are you reviewing the GET on allocations patch?13:53
sdaguedansmith: I am not, which patch do you want me to look at?13:53
dansmithoh I thought maybe it was the reason for the above discussion13:54
dansmithhttps://review.openstack.org/#/c/366789 and the patch that depends on it13:54
mdboothdansmith: https://bugs.launchpad.net/nova/+bug/160501613:54
openstackLaunchpad bug 1605016 in OpenStack Compute (nova) "Post copy live migration interrupts network connectivity" [High,Confirmed] - Assigned to Matthew Booth (mbooth-9)13:54
mdboothOr mriedem ^^^13:54
sdaguedansmith: no, that was the logging one13:54
mdboothI'm looking for assistence with devstack13:54
sdaguecdent: I updated the logging one13:54
*** liverpooler has quit IRC13:55
dansmithsdague: okay13:55
*** takashin has joined #openstack-nova13:56
*** brian_price has joined #openstack-nova13:56
sdaguecdent: why aren't allocations just a list here - https://review.openstack.org/#/c/366789/1 ?13:56
mriedemmdbooth: devstack is neutron by default now13:56
*** jaypipes has joined #openstack-nova13:56
*** roeyc has quit IRC13:57
mriedemmdbooth: are you looking for devstack multinode setup to recreate?13:57
mdboothmriedem: Right. I have neutron, but it didn't reproduce.13:57
mdboothmriedem: I already have that. I have working neutron multinode.13:57
mriedemxenial?13:57
mdboothHowever, it doesn't reproduce the issue.13:57
*** ekuris has quit IRC13:57
*** roeyc has joined #openstack-nova13:57
mdboothFedora 2413:57
mriedemwell, new enough libvirt13:57
mriedemok13:57
mriedemPaulMurray: ^13:57
mriedemnova meeting in 2 minutes13:57
*** diogogmt_ has joined #openstack-nova13:58
mdboothI have also been able to force post-copy, but as I note I don't think that's relevant here13:58
cdentsdague: did you see my posting on the next steps of resource providers thread?13:58
sdagueI guess not yet13:58
mdboothIncidentally, post-copy is *fast*13:58
cdentthere's debate over when to use list of dicts and when to use dict of dicts13:58
PaulMurraymriedem, mdbooth looking - what am I looking at ?13:59
mriedemmdbooth: does the size of the vm matter? to slow it down i mean13:59
*** mingyu has quit IRC13:59
mdboothmriedem: So post-copy is completely orthogonal to the issue I'm having13:59
mdboothThe issue I'm having is that even when I prevent nova from doing the network switchover completely13:59
mdboothThe networking still works anyway13:59
openstackgerritDiana Clarke proposed openstack/nova: Remove paramiko dependency  https://review.openstack.org/36739514:00
mdboothI believe that's an artifact of a particular neutron implementation14:00
cdentsdague: basically from my perspective a dict of dicts is more flexible in terms of answer questions and also represents the constraints of the data more accurately, so I did that, because there was no spec. as the commit message implies: other opinions are valid and we need to figure it out14:00
mriedemPaulMurray: mdbooth is trying to recreate https://bugs.launchpad.net/nova/+bug/160501614:00
mdboothI suspect there's some other neutron setup which does have the problem, but it's not the default.14:00
*** diogogmt has quit IRC14:00
*** diogogmt_ is now known as diogogmt14:00
openstackLaunchpad bug 1605016 in OpenStack Compute (nova) "Post copy live migration interrupts network connectivity" [High,Confirmed] - Assigned to Matthew Booth (mbooth-9)14:00
*** anush has joined #openstack-nova14:00
dansmithmriedem: meeting time? or did I miss that it's canceled?14:00
mriedemit's on14:00
sdaguecdent: ok, so where is the state of the debate. A list of dicts seems more sensible to me. But I'm not sure where things currently stand.14:00
PaulMurraymdbooth, dir will certainly have the problem14:01
mdbooth'dir'?14:01
cdentif you read the message it has a link to some irc discussion last night, and then it tailed off because people had to leave. I made the posting because I needed to know how it resolved, but nothing yet14:01
PaulMurrays/dir/dvr/14:01
*** amotoki has quit IRC14:01
mdboothPaulMurray: So, I know essentially nothing about virtual networking14:01
mdboothDVR is distributed virtual routing, right?14:02
*** amotoki has joined #openstack-nova14:02
PaulMurraymdbooth, yes, CVR is generally a switch in the middle14:02
PaulMurraymdbooth, DVR is each host doing its own routing14:02
*** liangy has joined #openstack-nova14:02
mdboothMy reproducer doesn't involve routing14:02
mdboothSo if the problem requires routing, then I haven't understood it14:03
PaulMurraymdbooth, so DVR needs the agents on each host to be reconfigured to route to the right host14:03
*** MikeG451 has joined #openstack-nova14:03
mdboothBut the guest still just sees a network segment, right?14:03
PaulMurraymdbooth, neutron will handle that, we just need to tell it to rebind the ports, but there might be some implementations that will work anyway14:03
*** cmartin has joined #openstack-nova14:03
mdboothAnd it expects that the network segment remains the same throughout the migration process.14:04
mdboothIs my test a valid test?14:04
PaulMurrayVas will do gap after migration so the ip address routing might be updated in some cases14:04
PaulMurrayDVR will not14:04
mdboothHow would I configure DVR?14:04
PaulMurraygood question14:04
PaulMurraysorry - reading back my laptop is auto-correcting every acronym I'm typing14:05
*** burgerk has quit IRC14:05
mdboothPaulMurray: I just wrote an essay in the bug, btw :)14:05
*** mingyu has joined #openstack-nova14:06
mdboothI think I know how to fix it, but I don't want to spend time on it until I've reproduced it.14:06
mdboothBecause otherwise I won't know if I've understood the problem, or if I've fixed it.14:06
diana_clarkeI'd love to hear any thoughts you folks have on https://review.openstack.org/36739514:06
diana_clarke(I'm currently trying to address the regression for Liberty & Mitaka, but also perhaps remove the paramiko dependency in time for Newton)14:07
PaulMurraymdbooth, if the networks work during post copy it implies there is no need to rebind the ports after the migration either14:07
PaulMurraywhich is probably not right - but I don't know enough neutron to be sure14:07
mdboothI *suspect* the fact that the network works anyway is just an artifact of this backend.14:08
mdboothBut I'd like to see it not work with a different backend.14:08
*** kfarr has joined #openstack-nova14:09
*** _coolsvap_ is now known as coolsvap14:09
*** tongli has joined #openstack-nova14:09
mdboothdiana_clarke: Fun!14:10
*** sdake has joined #openstack-nova14:10
*** roeyc has quit IRC14:11
*** sdake_ has quit IRC14:12
kashyapmdbooth: dgilbert already has posted a potential reproducer info for you in response to your essay :-)14:12
mdboothdiana_clarke: So, paramiko 2.0 is fine, right?14:12
diana_clarkemdbooth: yes14:13
*** su_zhang_ has quit IRC14:13
mdboothdiana_clarke: And Newton has paramiko 2.0?14:13
diana_clarkemdbooth: yes14:13
*** mingyu has quit IRC14:13
*** su_zhang has joined #openstack-nova14:13
mdboothSo you really want this just for mitaka and liberty, because they have old paramiko?14:13
mdboothJust trying to find out if I've understood14:14
*** roeyc has joined #openstack-nova14:14
*** Guest19167 has quit IRC14:14
mdboothThe suggestion: mitaka and liberty have broken paramiko keygen, make them use ssh-keygen instead.14:14
mdboothNewton is fine, because paramiko 2 keygen is fine.14:15
diana_clarkemdbooth: Ideally, I would just remove the dependency entirely.14:15
*** EinstCrazy has quit IRC14:15
diana_clarkefrom liberty, mitaka, and newton14:15
mdboothOh, is that the only thing we use paramiko for?14:15
diana_clarke(but I'm open to other suggestions)14:15
diana_clarkemdbooth: yup14:16
mdboothWow14:16
mdboothYeah, we should totally ditch that imho14:16
mdboothA parallel ssh implementation gives me the heebie jeebies anyway.14:16
*** thorst has joined #openstack-nova14:16
mdboothI thought we were using custom crypto because it gave us some useful deep integration.14:17
PaulMurraymdbooth, https://wiki.openstack.org/wiki/Neutron/DVR/HowTo14:17
*** amotoki has quit IRC14:17
mdboothPaulMurray: It starts with a video. I'm nervous already :)14:17
mdboothThanks, I'll read it.14:18
mdbooth(and watch)14:18
*** su_zhang has quit IRC14:18
PaulMurrayget pop corn :)14:18
PaulMurrayI haven't watched it yet14:18
dansmithjaypipes: cdent https://hangouts.google.com/call/z5va66cnczakredqf7m37oaqvie14:18
mriedemoh it's dvr related14:18
mriedemgreat14:18
*** vishwanathj_zzz is now known as vishwanathj14:18
* cdent gets headphones14:18
*** zz_dimtruck is now known as dimtruck14:19
*** thorst_ has joined #openstack-nova14:19
dansmithsdague: bauzas ^14:19
PaulMurraymdbooth, if that doesn't work out I can find someone who can be helpful14:19
mdboothPaulMurray: Thanks.14:19
PaulMurraymost of dir was implemented by us14:19
PaulMurray(but not me)14:19
*** EinstCrazy has joined #openstack-nova14:19
PaulMurrayDVR DVR - I hate auto-correct14:19
jaypipesbauzas, johnthetubaguy, dansmith, alex_xu, sdague, mriedem, cdent, alaski: https://hangouts.google.com/hangouts/_/pgy6ze6alnahldh2e546ldzk2ee14:20
dansmithjaypipes: we're all on the above hangout already14:20
*** mlavalle has joined #openstack-nova14:20
*** zul has joined #openstack-nova14:20
mriedemPaulMurray: does mdbooth also need this? https://review.openstack.org/#/c/275073/14:21
*** roeyc has quit IRC14:21
*** takashin has left #openstack-nova14:22
mdboothmriedem: I did notice that looked like a no-op, btw14:22
*** thorst has quit IRC14:22
*** zul has quit IRC14:22
*** zul has joined #openstack-nova14:23
*** rlrossit_ has joined #openstack-nova14:23
mdboothmriedem: Although, unless it breaks it, it's not what I'm looking for.14:24
*** sridhargaddam has joined #openstack-nova14:24
*** _ducttape_ has quit IRC14:24
mdboothmriedem: My current problem is that it works when I was hoping it was broken :)14:24
*** bnemec has quit IRC14:24
*** ljxiash has joined #openstack-nova14:24
PaulMurraymriedem, I don't think that is needed - its an optimisation14:25
*** ihrachys has quit IRC14:25
PaulMurraymriedem, hm, although in the end they should work together14:25
PaulMurraybut for testing the problem it shouldn't be needed14:25
*** rlrossit has quit IRC14:26
PaulMurraymriedem, oh, I see, its in14:26
*** sridharg has quit IRC14:27
*** ihrachys has joined #openstack-nova14:27
jrolljaypipes: quick question, can mysql do alter column (specifically text -> longtext) without read locks these days? (and what are the chances people are actually using those versions?)14:27
PaulMurraymriedem, mdbooth the steps taken after migration now are the steps that should be taken when the post-copy switch happens14:27
*** bnemec has joined #openstack-nova14:27
PaulMurrayso its largely the same - just need to know when to do it14:28
*** amotoki has joined #openstack-nova14:28
*** nkrinner is now known as nkrinner_afk14:28
*** directxman12 has joined #openstack-nova14:29
*** moshele has quit IRC14:29
*** directxman12 has quit IRC14:29
*** sridhargaddam has quit IRC14:31
rpodolyakajroll: according to http://dev.mysql.com/doc/refman/5.7/en/innodb-create-index-overview.html concurrent reads should be ok14:32
*** burgerk has joined #openstack-nova14:32
*** amotoki has quit IRC14:33
jrolloh, interesting14:33
jroll5.6+14:33
rpodolyakayeah, I think they improved a lot  since 5.6 in terms of online DDL operations14:33
*** rodrigods has quit IRC14:35
*** rodrigods has joined #openstack-nova14:35
*** scarab_ has joined #openstack-nova14:37
*** salv-orlando has joined #openstack-nova14:40
mriedemburgerk: how are things looking on https://review.openstack.org/#/c/366955/ ?14:41
*** shangxdy has joined #openstack-nova14:41
*** EinstCrazy has quit IRC14:41
* sfinucan comes up from a refactor that took way too long14:42
burgerkmriedem: plan to have new patch up in about an hour14:42
*** pwnall has joined #openstack-nova14:42
*** mvk has quit IRC14:42
mriedemok14:42
*** pwnall is now known as Guest3472314:42
* sfinucan has realized how many things can go wrong when scheduling an instance with NUMA topo and is amazed it works at all14:43
*** baoli has joined #openstack-nova14:43
*** sridhargaddam has joined #openstack-nova14:44
*** mars_toktonaliev has quit IRC14:45
*** zenoway has joined #openstack-nova14:45
mdboothsfinucan: LOL, don't touch it!14:46
sfinucanmdbooth: Just wait til you see this exception list in a doctring14:46
sfinucan...and I'm almost sure I missed some :)14:46
*** armax has joined #openstack-nova14:49
cdentdansmith, jaypipes: I just though of another reason why a list of anon dicts is sometimes good: if the result is going to be long (say all the allocations on a shared resource provider) a list is less complex to limit/filter/sort14:50
sdaguedansmith: oh, one other thing that exposes with the logging patch - https://review.openstack.org/#/c/366186/ - we never have disk allocations14:51
dansmithsdague: right14:52
dansmithsdague: because we have zero-disk flavors right?14:52
sdagueyes14:52
dansmithin the gate14:52
dansmithlocally I definitely see disk allocations14:52
cfriesensfinucan: you should have seen it back in Havana. :)14:52
sdagueshould we just flag that as a bug to fix later?14:52
*** dikonoor has quit IRC14:52
dansmithsdague: it's not a bug14:52
dansmithsdague: we have no disk, thus no disk allocation14:52
sdaguezero-disk flavors still take up disk14:53
dansmithsdague: .. you mean because of the config file? :)14:53
*** baoli has quit IRC14:53
sdagueno, because that just means autosize to glance image size14:53
*** baoli has joined #openstack-nova14:54
dansmithsdague: we've never tracked that, AFAIK, and the whole point of this is to not charge instances with no local disk against the compute node14:54
*** marst has joined #openstack-nova14:55
sdaguedansmith: ok, but no local disk is different, and not indicated by disk == 014:55
dansmithsdague: zero root disk instances in the real world are volume-backed and thus don't have any local residue other than image caches, right?14:55
sdaguewe just added a new api to really mean, don't give me a local disk14:55
*** abalutoiu has joined #openstack-nova14:55
sdaguedansmith: they don't have to be14:55
dansmithsdague: oh you mean when an ephemeral is root=0, which means image size, I see what you mean14:56
sdagueyes14:56
dansmithand you said that sorry.. how does the RT deal with that now?14:56
sdagueI don't know14:56
dansmithbecause I kinda expect it does what we do here which is count it as zero14:56
*** Guest34723 has quit IRC14:56
sdaguejaypipes / bauzas do you know the current RT handling here?14:57
dansmithsdague: I dont see that it is handled at all in RT14:59
dansmithcounted as zero AFAICT14:59
*** gouthamr has joined #openstack-nova14:59
*** jraju has quit IRC14:59
*** TravT has joined #openstack-nova15:00
*** rlrossit_ has quit IRC15:00
*** gouthamr_ has joined #openstack-nova15:00
dansmithsdague: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L972-L97615:00
openstackgerritJay Pipes proposed openstack/nova-specs: Amend placement API with correct PUT inventory  https://review.openstack.org/36688815:00
jaypipescdent, dansmith: just running all tests on the code.15:01
dansmithjaypipes: thanks15:01
*** aloga_ has quit IRC15:02
*** rlrossit_ has joined #openstack-nova15:03
cdentjaypipes, dansmith: put allocation is currently a list of doubly nested dicts:http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/generic-resource-pools.html#put-allocations-consumer-uuid15:03
cdentthat's not very useful as a representation on the response15:03
*** rlrossit_ has quit IRC15:04
cdentI'll do what I think is right and then we can talk about it15:04
*** gouthamr has quit IRC15:04
*** rlrossit_ has joined #openstack-nova15:04
*** akshai_ has quit IRC15:04
burgerkmriedem: for test_migrations functional test, I would need to add the row during the previous test (check_019) then assert type change and row remains in check_020?15:05
*** READ10 has joined #openstack-nova15:05
mriedemburgerk: the _check_020 runs after the migration is applied15:05
mriedemthere is a pre-migration method to populate the data15:05
mriedemburgerk: called _pre_upgrade_02015:06
mriedemburgerk: e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/db/test_migrations.py#L64515:06
alaskiburgerk: you can look at tests/unit/db/test_migrations.py to see how it's done for the other db which has some tests that load data15:06
burgerkok that is what I was missing15:06
*** jlanoux has quit IRC15:06
burgerkmriedem: alaski: thanks15:08
*** sridhargaddam has quit IRC15:08
*** scarab_ has quit IRC15:10
*** su_zhang has joined #openstack-nova15:12
*** akshai has joined #openstack-nova15:14
*** prateek has joined #openstack-nova15:14
*** raunak has joined #openstack-nova15:14
*** ducttape_ has joined #openstack-nova15:15
mdboothIn neutron, what is dhcp associated with?15:15
mdboothA network, a subnet, a router15:15
ZZellemdbooth, a network15:16
*** kevinz has quit IRC15:16
ZZellemdbooth, oups not exactly15:16
ZZellemdbooth, a network is associated to dhcp-agents and you configure dhcp per subnet15:16
openstackgerritMatt Riedemann proposed openstack/nova: virt: handle unicode when logging LifecycleEvents  https://review.openstack.org/36745515:16
mriedemeasy fix ^ lifecycle events in the virt layer are broken if you're not using english locales15:17
mdboothZZelle: If I update public-subnet to set enable_dhcp=True, will the neutron fairy make magic?15:17
ZZellemdbooth, yes or at least it should :)15:18
mdboothmriedem: Sorry, that appears to be an issue with your language provider. Please select correct heritage and retry.15:18
mriedemheh15:18
*** akshai has quit IRC15:19
*** akshai has joined #openstack-nova15:19
*** prateek has quit IRC15:20
mdboothZZelle: have invoked neutron fairy :)15:20
* mdbooth claps his hands furiously15:20
jaypipesdansmith, cdent: k, done with meeting. had a few func test failures. fixing those up now. shouldn't be more than half hour to push. thx for patience.15:21
*** sdake_ has joined #openstack-nova15:21
dansmithjaypipes: cool, thanks15:21
*** abalutoiu has quit IRC15:21
*** adisky has quit IRC15:21
*** sdake has quit IRC15:22
*** rrecio has joined #openstack-nova15:22
openstackgerritDiana Clarke proposed openstack/nova: Remove paramiko dependency  https://review.openstack.org/36739515:23
*** mjura has quit IRC15:24
openstackgerritMikhail Feoktistov proposed openstack/nova: Check hypervisor version while getting bus type  https://review.openstack.org/28239815:24
*** rloo has joined #openstack-nova15:25
*** annegentle has joined #openstack-nova15:27
sdaguemriedem: +215:27
*** amotoki has joined #openstack-nova15:29
*** mriedem has quit IRC15:29
*** zenoway has quit IRC15:30
rloohi, ironic is adding notifications. i was looking at nova notifications (https://wiki.openstack.org/wiki/SystemUsageData) and wondering what your guidelines were wrt event types.15:30
rloowhy do some have phases start/end, or start/end/error, and others don't?15:31
*** hshiina has quit IRC15:31
mdboothPaulMurray: That HowTo says:15:31
mdbooth"Be sure that your firewall or security groups allows UDP traffic over the vxlan port to pass between the hosts"15:31
mdboothWhat does that mean?15:32
mdboothI ask in the context that I have to instances on the same network but different hosts which can't ping each other.15:32
mdboothAlthough I haven't done the security-group dance, yet15:32
mdboothIs that required?15:32
*** akshai has quit IRC15:32
*** akshai has joined #openstack-nova15:33
*** amotoki has quit IRC15:34
*** jlanoux has joined #openstack-nova15:35
*** matrohon has quit IRC15:37
PaulMurraycarl_baldwin, are you around?15:37
carl_baldwinPaulMurray: indeed I am15:37
*** mgoddard_ has joined #openstack-nova15:37
PaulMurraymdbooth, is trying to set up a DVR devstack - any advice ?15:37
PaulMurraycarl_baldwin, ^^15:38
*** zenoway has joined #openstack-nova15:39
*** zul has quit IRC15:39
haleybmdbooth: you can have a single-node dvr setup in devstack by putting Q_DVR_MODE=dvr_snat in local.conf.  A multi-node setup is a little harder, but doable15:39
*** jvgrant has joined #openstack-nova15:40
*** zul has joined #openstack-nova15:40
*** mgoddard has quit IRC15:40
haleybthat setting will trigger all the namespaces to be configured15:40
*** zul has quit IRC15:40
openstackgerritStephen Finucane proposed openstack/nova: virt: Split out 'numa' and 'compat' modules  https://review.openstack.org/36746715:41
openstackgerritStephen Finucane proposed openstack/nova: numa: Rework docstrings  https://review.openstack.org/36746815:41
openstackgerritStephen Finucane proposed openstack/nova: numa: Standardize '_get_XXX_constraints' functions  https://review.openstack.org/36746915:41
openstackgerritStephen Finucane proposed openstack/nova: numa: Flatten functions  https://review.openstack.org/36747015:41
*** hemnafk is now known as hemna15:41
*** zul has joined #openstack-nova15:41
PaulMurraymdbooth, is there a default security group ?15:41
carl_baldwinPaulMurray: mdbooth: looks like haleyb is a little quicker than I am. You're in good hands. I'll keep an eye out here in case I can add anything.15:41
PaulMurraycarl_baldwin, thanks15:41
*** andreas_s has quit IRC15:42
*** READ10 has quit IRC15:42
haleybcarl_baldwin: i added an irc filter to highlight 'dvr' today, so now see it's all over the place15:42
*** gouthamr_ is now known as gouthamr15:42
PaulMurrayhaleyb, that's because everyone loves it so much15:43
*** _ducttape_ has joined #openstack-nova15:44
*** browne has joined #openstack-nova15:44
* haleyb can feel the sarcasm all the way across the ocean :)15:44
*** zenoway has quit IRC15:44
*** ducttape_ has quit IRC15:44
*** mgoddard_ has quit IRC15:44
sdaguehmmm... what's up with - No instance_mapping found for instance 0edb43c0-b007-40eb-a9eb-7a294cb9de57. This should not be happening and will lead to errors in the future. Please open a bug at https://bugs.launchpad.net/nova15:44
sdaguehapping hundreds of times in every gate run?15:44
jaypipesalaski: ^15:45
carl_baldwinhaleyb: I wondered how you were all over that.15:46
sdaguehttp://logs.openstack.org/18/361518/9/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fb629d7/logs/screen-n-api.txt.gz?level=TRACE#_2016-09-07_07_18_15_878 as an example15:46
bauzassdague: I had the same problem with my local devstack, I thought it was a local conf issue15:47
dansmithsdague: see the dbdeadlock right below that?15:48
sdaguedansmith: yeh, but that's unrelated15:48
dansmithsdague: you know that?15:48
sdaguethis happens 2400 times15:48
dansmithI mean aside from that it's once and the other is a lot15:48
dansmithit's kinda in the same path15:49
sdagueyes, the db deadlock is related to the get me a network issue15:49
openstackgerritDiana Clarke proposed openstack/nova: Remove paramiko dependency  https://review.openstack.org/36739515:49
sdaguedansmith: ok, there is 1 deadlock on one test15:49
*** pwnall has joined #openstack-nova15:49
sdaguethere are 2400+ of this warning, happening on basically every test15:49
dansmithyeah, I get that ;)15:50
*** pwnall is now known as Guest5021815:50
dansmithis there an issue open for the deadlock?15:50
diana_clarkesdague, mdbooth: Thanks for the reviews! I added a bug # in the latest revision ^^^15:50
sdaguedansmith: there is not yet, I was just looking at one of the uncategorized fails15:50
sdagueand noticed this other issue15:50
dansmithsdague: just curious based on the log discussion earlier15:50
*** mriedem has joined #openstack-nova15:51
*** jgriffith_away is now known as jgriffith15:53
mriedemdims: you worked on a lot of the pycrypto/cryptodome/paramiko stuff, so you might want to take a look at https://review.openstack.org/#/c/367395/15:53
dansmithmriedem: you know anything about this get-me-a-network deadlock thing?15:53
mriedemhuh?15:54
dansmithmriedem: sdague says this is get-me-a-network related: http://logs.openstack.org/18/361518/9/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fb629d7/logs/screen-n-api.txt.gz?level=TRACE#_2016-09-07_07_18_16_68115:54
mriedemno15:54
mriedemit's not15:54
dansmithlooks like it's actually a deadlock in the rollback of whatever the real error is maybe?15:55
*** maestropandy has quit IRC15:55
mriedemit's an old bug i'm trying to find the link15:55
*** READ10 has joined #openstack-nova15:55
mriedemhttps://bugs.launchpad.net/nova/+bug/148030515:56
openstackLaunchpad bug 1480305 in OpenStack Compute (nova) "DBDeadlock inserting into instance_extra" [Medium,Triaged]15:56
mriedemour e-r query is stale15:56
mriedemhttp://status.openstack.org//elastic-recheck/index.html#148030515:56
dansmithoh, nm that's in a finally block15:56
dimsmriedem : looking15:57
*** BjoernT has joined #openstack-nova15:57
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ec2_instance_create%5C%22%20AND%20message%3A%5C%22DBDeadlock%5C%22%20AND%20message%3A%5C%22u'INSERT%20INTO%20instance_extra%5C%22%20AND%20tags%3A%5C%22screen-n-api.txt%5C%22%20AND%20voting%3A1&from=7d15:57
mriedemi'll fix the query15:58
*** akshai has quit IRC15:58
*** mgoddard has joined #openstack-nova15:58
*** rlrossit_ has quit IRC15:59
*** akshai has joined #openstack-nova15:59
*** sayalilunkad has quit IRC16:00
mriedemdansmith: there was a quick fix attempt here https://review.openstack.org/#/c/292800/16:00
mriedemi suggested doing the instance-related table inserts in separate transactions16:01
mriedemalthough the retry decorator would be simple16:02
*** su_zhang has quit IRC16:02
*** su_zhang has joined #openstack-nova16:03
dansmithI kinda think they should be in the same transaction16:03
dansmithwe assume that they're both there in a lot of code now I think, so we wouldn't really want one to succeed and one to fail16:04
*** paul-carlton has joined #openstack-nova16:04
mriedemsince no one else is working on it, i'm fine with just humping in the retry decorator16:06
dansmithyeah16:06
openstackgerritMatt Riedemann proposed openstack/nova: db: retry on deadlocks while adding an instance  https://review.openstack.org/29280016:06
dansmithI think that's probably the best option here although it always feels like a hack16:06
mriedem+W if you want, i just +2ed and rebased16:07
*** su_zhang has quit IRC16:07
*** liverpooler has joined #openstack-nova16:08
dansmithmriedem: got it16:09
diana_clarkeI don't think I have the ability to add milestones to this bug: https://bugs.launchpad.net/nova/+bug/162153616:11
openstackLaunchpad bug 1621536 in OpenStack Compute (nova) "Remove paramiko dependency" [Undecided,In progress] - Assigned to Diana Clarke (diana-clarke)16:11
mriedemdiana_clarke: which milestone would you target?16:11
diana_clarke(I'd like it to be considered for Newton still, if possible)16:11
mriedemdiana_clarke: doesn't seem justified for newton16:12
diana_clarkemriedem: Newton, Mitaka, and Liberty16:12
openstackgerritChris Dent proposed openstack/nova: [placement] add two ways to GET allocations  https://review.openstack.org/36678916:12
mriedemdiana_clarke: backporting that is going to be not fun16:12
*** zenoway has joined #openstack-nova16:12
cdentdansmith, jaypipes I've got some concerns on that ^ (Noted in commit message and todos within the diff)16:12
diana_clarkemriedem: packaging or code-wise?16:12
cdentwill update the etherpad16:12
mriedemdiana_clarke: code16:13
dansmithmriedem: yeah, sdague said not for newton too and I agree16:13
dansmithcdent: okay16:13
*** ljxiash has quit IRC16:13
diana_clarkemriedem: it's pretty easy code-wise16:13
mriedemdiana_clarke: it's a pretty non-trivial change for something like stable/liberty at this point16:13
mriedemand i don't see the justification16:14
*** burt has joined #openstack-nova16:14
diana_clarkedansmith, mriedem: ah, I misunderstood sdague then. I thought he was saying: "add a bug, so we can consider it for newton"16:14
artomAsking here because brain is mostly fried from awful night - is there a specific exception that oslo messaging raises if the recipient is at a lower RPC version than the sender?16:14
mriedemthe paramiko/pycrypt/cryptodome stuff has been a hairy mess which is why i'd like to avoid a lot of that complexity right now16:14
dansmithdiana_clarke: he said hold until master re-opens, which means not newton, wait for ocata16:14
artomI would be very grateful for at least pointers to where to look in the code :)16:14
alaskisdague: looking into it16:15
mriedemartom: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/exceptions.py ?16:15
artomEx: I send 1.13 but the recipient hasn't been upgraded yet is only understands 1.1216:15
dansmithartom: you only get that on a call (not cast) and that should never actually happen because of the pin16:15
mriedemthere are others in here https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/client.py16:16
artommriedem, thanks :) It would be InvalidTarget then? "certain pre-conditions" is pretty vague :/16:16
dansmithartom: so we don't really catch it anywhere since it shouldn't be a thing (and doesn't work for cast)16:16
diana_clarkemriedem, sdague, dansmith: okie dokie. I'll just work on it downstream then.16:16
*** zenoway has quit IRC16:16
artomdansmith, is pinning an automatic thing then?16:17
dansmithartom: there is an 'auto' mode now, but in general it's a manual thing16:17
dansmithartom: and it's just kinda your responsibility if you run mixed versions to have set the pin properly.. always has been16:17
dansmithartom: my point is, I don't think there's any prior art for trying to handle the InvalidTarget automatically because it can't be universally applied and because the way we handle compatibility is via the pin16:18
dansmithcdent: which concerns exactly? just the sort/filter limiting?16:18
artomdansmith, context here is our downstream backports of the dhcp_release thing (I guess maybe move this to our internal channel?)16:18
dansmithartom: right, so backports of such things are really really hard to get right, which is why we try to never do them :)16:19
cdentdansmith: sort/filter and lack of self describing: the output from /reso..allo and /alloca... look nearly the same but the key of the dict is an entirely different thing. Do we care?16:19
dansmithartom: is that a call or a cast? I thought the latter16:19
artomdansmith, it's a call16:19
dansmithcdent: they're different resources so I don't really see why it matters16:19
dansmithartom: okay, well, anyway, with my upstream hat on "that's a problem for you to solve downstream, so good luck with that" :P16:19
*** diana_clarke has left #openstack-nova16:20
*** sahid has quit IRC16:20
cdentdansmith: i'm cool with that16:21
*** tesseract- has quit IRC16:21
dansmithcdent: okay16:21
*** diana_clarke has joined #openstack-nova16:21
cdentdansmith: so the other conflict is PUT allocations looks nothing like GET allocations16:22
*** diana_clarke has left #openstack-nova16:22
cdent(I put that on the etherpad)16:22
*** markus_z has quit IRC16:22
dansmithcdent: ugh.. pretty uncool that we got so sideways on this :/16:22
*** thorst_ has quit IRC16:23
*** nic has joined #openstack-nova16:23
*** diana_clarke has joined #openstack-nova16:23
*** unicell has joined #openstack-nova16:23
*** thorst has joined #openstack-nova16:23
pumaranikardoes anyone know how nova logging setup behave with testr.16:24
*** kaisers has quit IRC16:24
pumaranikaris this the place https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L8716:24
cdentdansmith: I have no idea what happened in general, but for me it was simply review fatigue and naivety on the extent to which we would iterate during the cycle (rather than at the end). I just kind of assumed we would make a lot of changes throughout the cycle in a paced fashion and that the details were effectively stubs16:24
dansmithyeah, just commenting not blaming :)16:25
*** unicell1 has quit IRC16:25
diana_clarkemriedem: re: "the paramiko/pycrypt/cryptodome stuff has been a hairy mess". Isn't that an argument *for* removing this dependency before shipping newton?16:25
mriedemdiana_clarke: against16:25
cdentand I'm not excusing, just conversing16:25
* cdent IS SO LONELY :)16:26
dansmithlol16:26
*** praveen has joined #openstack-nova16:26
mriedemdiana_clarke: as in, i don't like touching something that has had a lot of complicated churn in the past 1 week from RC1 if it's not a critical bug16:26
dansmithcdent: M-x eliza ?16:26
* cdent shuns dansmith 16:26
dansmither, M-x doctor16:27
diana_clarkemriedem: but, but... it's a revert back to the state before all that churn.16:27
* dansmith couldn't recall it from cold storage quick enough16:27
diana_clarkemriedem: anyhoo, I'll move on ;)16:27
cdentno dansmith, I'm shunning emacs16:27
* cdent gives a cookie to diana_clarke 16:27
*** browne has left #openstack-nova16:27
diana_clarkecdent: thanks, much needed ;)16:28
cdentnow I want one16:28
* cdent has run out of cookies16:28
*** cher75 has joined #openstack-nova16:28
*** timello has quit IRC16:29
alaskisdague: that warning message shows up because the cells setup doesn't happen in the gate. But since we need to assume that deployments won't upgrade immediately in N it'll be best to remove that.16:29
danpbdiana_clarke: if the nova code switch from ssh -> paramiko had been something we'd done in the last few months, then it would be a reason to consider reverting for this release16:29
*** rama_y has joined #openstack-nova16:29
danpbdiana_clarke: but we've had this paramiko code in nova since Liberty now, so its hard to make a case that its critical to revert at this point in the release cycle16:29
*** dimtruck is now known as zz_dimtruck16:30
openstackgerritGábor Antal proposed openstack/nova: Throw exception if numa_nodes is not set to integer greater than 0  https://review.openstack.org/33738016:30
openstackgerritEric Brown proposed openstack/nova: Fix config option types  https://review.openstack.org/16848116:31
jaypipescdent: see comment on commit messagte16:31
*** amotoki has joined #openstack-nova16:31
*** amotoki has quit IRC16:31
openstackgerritEric Brown proposed openstack/nova: VMware: Enforce minimum vCenter version of 5.5  https://review.openstack.org/25366616:31
*** amotoki has joined #openstack-nova16:31
openstackgerritEric Brown proposed openstack/nova: Update man pages with latest version and dates  https://review.openstack.org/32544116:31
*** thorst has quit IRC16:31
*** ametts has joined #openstack-nova16:32
*** browne has joined #openstack-nova16:32
diana_clarkedanpb: yup, it's just a shame that adoption lags so far behind that by time we get these error reports it's too late... anyhoo, I'll play in the downstream sandbox instead ;)16:33
cdentthanks jaypipes16:33
cdentdansmith: how you feel about jaypipes's suggestion on https://review.openstack.org/#/c/366789/16:33
*** zz_dimtruck is now known as dimtruck16:34
*** READ10 has quit IRC16:34
dansmithcdent: I shall comment16:35
cdentgracias16:35
* cdent is in two meetings, so I'll wait to do anything for a while16:35
*** fragatina has joined #openstack-nova16:37
jaypipesdansmith, cdent: cool to remove the top-level 'resource_providers' key sure16:37
cdentstandard to have some kind of top level key so we can later add a 'links' key or some such16:37
* cdent shrugs16:37
dansmithcdent: oh I thought this was under allocations16:38
dansmithcdent: top level of allocations makes sense to me16:38
cdentdansmith: can you comment for sake of memory, otherwise I'll forget16:38
*** jlanoux has quit IRC16:38
cdentplease and thank you16:38
dansmithcdent: I did16:39
cdentdansmith: i mean about which top level you want16:39
jaypipesso we'd have two 'allocations' keys?16:40
auggydiana_clarke: thanks for looking into the paramiko issue. we've had a number of bugs reported for things related to this, i'll have to dig them up to find out how we resolved them16:40
*** tongli_ has joined #openstack-nova16:41
*** fragatina has quit IRC16:41
auggydiana_clarke: https://bugs.launchpad.net/nova/+bug/148313216:42
openstackLaunchpad bug 1483132 in OpenStack Compute (nova) "ssh-keygen-to-Paramiko change breaks third-party tools" [Low,Fix released] - Assigned to Corey Wright (coreywright)16:42
*** timello has joined #openstack-nova16:42
dansmithauggy: did you see the commit message? lots of links in there, including that one I think16:43
*** clenimar has joined #openstack-nova16:43
auggydansmith: ah ok no i didn't, sorry16:43
*** raunak has quit IRC16:43
*** tongli has quit IRC16:44
auggydansmith: oh geez it helps if i actually read the bug :/16:44
auggydiana_clarke: sorry for the redundancy there :)16:45
*** cher75 has quit IRC16:45
jaypipescdent, dansmith: like cdent says, it's probably good to keep 'resource_providers' as top-level key in the response. in future, I can see adding a links collection with links to "filtered" results, etc16:45
diana_clarkeauggy: no worries :)16:45
dansmithjaypipes: I'm cool with a toplevel, but GET /allocations with a resource_providers toplevel makes no sense to me16:45
*** tongli_ has quit IRC16:46
jaypipesdansmith: the alternative is to have the resource provider generation repeated for each allocation record and use anon dicts.16:46
*** code-R_ has quit IRC16:47
*** rlrossit has joined #openstack-nova16:47
dansmithjaypipes: I don't see what the toplevel has to do with list of anon dicts or not being able to do the generation16:47
*** lucasagomes is now known as lucas-dinner16:48
jaypipesdansmith: where would you put the resource provider generation in cdent's proposed response format?16:49
*** derekh has quit IRC16:49
dansmithjaypipes: I see, you added yet another level underneath the provider uuid for allocations16:49
jaypipesyeh16:50
dansmithI guess I would call that resources:16:50
dansmithwhatever16:50
dansmithjust seems weird to me to ask for allocations and get back resource_providers16:50
jaypipessure, that would work16:50
openstackgerritAndrew Laski proposed openstack/nova: Remove misleading warning message  https://review.openstack.org/36751016:52
alaskisdague: ^16:52
cdentdansmith, jaypipes I'll try to digest this into something that makes sense. if you guys have a concrete (and new) proposal, please put it on the review. otherwise I'll chew on what's been discussed and poop out some goodness16:52
jaypipescdent: k16:53
cdentthe main goal is: get the generation in there, right?16:53
*** Apoorva has joined #openstack-nova16:55
*** devananda|travel is now known as devananda16:56
*** lpetrut has joined #openstack-nova16:56
*** jheroux has quit IRC16:57
*** danpb has quit IRC17:00
*** anush has quit IRC17:00
*** diana_clarke has left #openstack-nova17:00
*** jaosorior has quit IRC17:01
*** unicell has quit IRC17:01
*** ducttape_ has joined #openstack-nova17:01
*** swamireddy has quit IRC17:03
*** migi has joined #openstack-nova17:03
*** paul-carlton has quit IRC17:03
openstackgerritMatt Riedemann proposed openstack/nova: Add deprecated_reason for use_usb_tablet option  https://review.openstack.org/36751717:03
mriedembauzas: johnthetubaguy: ^17:04
mriedemwe had a reno for that but the help text didn't make it clear17:04
*** tongli has joined #openstack-nova17:04
*** _ducttape_ has quit IRC17:04
openstackgerritMatt Riedemann proposed openstack/nova: Add deprecated_reason for use_usb_tablet option  https://review.openstack.org/36751717:05
*** paul-carlton has joined #openstack-nova17:05
*** tongli has quit IRC17:08
*** zul has quit IRC17:10
*** ducttape_ has quit IRC17:12
*** cmartin_ has joined #openstack-nova17:13
*** ducttape_ has joined #openstack-nova17:13
cmartin_Could anybody review my commit? https://review.openstack.org/#/c/364337/17:13
*** zul has joined #openstack-nova17:14
*** su_zhang has joined #openstack-nova17:15
*** sudipto has joined #openstack-nova17:16
*** Guest50218 has quit IRC17:16
*** sudipto_ has joined #openstack-nova17:16
*** rlrossit has quit IRC17:17
openstackgerritKenneth Burger proposed openstack/nova: Increase BDM column in build_requests table  https://review.openstack.org/36695517:18
*** rlrossit has joined #openstack-nova17:18
mriedemdansmith: thanks, i was just commenting17:19
mriedemi had the feeling this was whack a mole17:19
dansmithmriedem: np17:19
*** rlrossit has quit IRC17:22
mriedemgibi: fyi i'm seeing these in gate runs http://logs.openstack.org/55/367455/1/check/gate-tempest-dsvm-cells/1d8af83/logs/screen-n-api.txt.gz?level=TRACE#_2016-09-08_15_53_14_61917:23
mriedemnot sure what needs to be set to get rid of that warning17:23
*** pwnall has joined #openstack-nova17:23
*** pwnall is now known as Guest8307317:24
mriedemalaski: were you talking to sdague earlier about removing this warning? http://logs.openstack.org/55/367455/1/check/gate-tempest-dsvm-cells/1d8af83/logs/screen-n-api.txt.gz?level=TRACE#_2016-09-08_15_58_30_53817:24
mriedemb/c it's all over the cells v1 job logs17:24
alaskimriedem: yep, it's going to be all over any run that hasn't migrated to cellsv217:24
alaskihttps://review.openstack.org/36751017:24
openstackgerritPaul Carlton proposed openstack/nova: Update instance group during live migration  https://review.openstack.org/33958817:25
mriedemcould we keep the warning if we can detect cells v2 setup has been done, like if the cell0 mapping exists?17:25
alaskimriedem: I considered that. It would require a db lookup and I wasn't sure it was worth it for a log message. But I'm happy to add it17:26
mriedemyeah...not sure17:26
mriedemalaski: i'd say we do that after we make cellsv2 the mainline default in devstack17:28
*** unicell has joined #openstack-nova17:28
alaskimriedem: put back the warning?17:29
*** thorst has joined #openstack-nova17:29
*** rlrossit has joined #openstack-nova17:29
mriedemyeah17:29
mriedemor do that lookup17:29
mriedemwell, warning conditional on the lookup17:29
alaskiokay. I'll add a TODO there17:29
mriedembut after we make cellsv2 the default path in devstack17:29
mriedemok17:29
*** tongli has joined #openstack-nova17:30
edleafecdent: commented on https://review.openstack.org/#/c/36678917:30
mriedemgibi: btw, that warning on the notification thing is only showing up in the cellsv1 job17:31
cdentedleafe: the thing we want to achieve is allow comparisons of dicts with minimal manipulation so having generation and resource classes at the same level in the dict is not desirable17:32
cdenti'm late for dinner, or I'd stop and say more17:32
openstackgerritSam Betts proposed openstack/nova: [WIP] Support Ironic interface attach/detach in nova virt  https://review.openstack.org/36441317:32
burgerkmriedem: alaski:  new patch uploaded https://review.openstack.org/#/c/366955/17:33
openstackgerritAndrew Laski proposed openstack/nova: Remove misleading warning message  https://review.openstack.org/36751017:33
*** tongli has quit IRC17:34
*** code-R has joined #openstack-nova17:35
*** thorst has quit IRC17:37
*** ssurana has joined #openstack-nova17:37
*** sudipto_ has quit IRC17:37
*** sudipto has quit IRC17:37
*** code-R_ has joined #openstack-nova17:38
*** rlrossit has quit IRC17:39
edleafecdent: agree, and really don't understand the need for returning generation17:39
*** abalutoiu has joined #openstack-nova17:39
edleafecdent: but if it's gotta be there...17:40
*** swamireddy has joined #openstack-nova17:40
*** code-R has quit IRC17:42
*** rrecio has quit IRC17:44
*** rama_y has quit IRC17:44
*** ducttape_ has quit IRC17:45
*** whenry has quit IRC17:47
*** tongli has joined #openstack-nova17:48
*** gszasz has quit IRC17:49
*** krtaylor has quit IRC17:49
dansmithedleafe: right, currently the generation does nothing for us from the client side during allocation activities17:50
*** PaulMurray has quit IRC17:50
dansmithit may in the future if we try to do a more consolidated RT update sorta thing, but right now it's superfluous17:50
*** tongli has quit IRC17:52
*** akshai has quit IRC17:54
*** jlk has joined #openstack-nova17:54
cdentdansmith, edleafe: I"m thinking:$.allocations.$provider_uuid.generation: 517:54
cdent$.allocations.$resource_uuid.resources: {VCPU: 4, DISK_GB: 20}17:55
dansmithcdent: yeah that's what I suggested earlier,17:55
*** su_zhang has quit IRC17:55
dansmithso obviously I'm cool with that :D17:55
cdentso effectively what jay has done, but with s/resource_providers/allocations/17:55
cdentyeah, cool17:55
jlkHi all. I've got a couple mitaka clouds and we're trying to get NUMA scheduling tested. But first, we seem to not be getting any NUMA details reported into novadb from the compute host. Selecting "numa_topology from compute_nodes" is showing NULL. Could somebody help me debug where this info is getting lost?17:55
cdentit preserves the key part  of having a comparable piece at a predictable key17:55
jlkif I understand things, that data should be coming through if the hardware itself has NUMA details17:56
edleafecdent: that sounds good to me17:56
cdent✔17:56
dansmithcdent: yes17:56
cdentcoming soon to a gerrit near you17:56
*** prateek has joined #openstack-nova17:57
mriedemjlk: have you gone through http://docs.openstack.org/admin-guide/compute-cpu-topologies.html ?17:59
mriedemjlk: cfriesen, sfinucan or lbeliveau might be able to help17:59
jlkmriedem: We were reading an old version something like that http://docs.openstack.org/developer/nova/testing/libvirt-numa.html18:00
jlklet me read this new link and see if it gells18:00
mriedemjlk: yeah that devref one is pretty old18:00
*** fragatina has joined #openstack-nova18:01
jlkeh18:01
jlkthat link you sent doesn't cover anything other than "turn on the filter"18:01
jlkWe've got the filter in, and it fails ever attempt to build with NUMA, stating no hosts match18:01
jlkand since the numa data is all NULL, I can see why18:01
*** kfarr has quit IRC18:02
*** akshai has joined #openstack-nova18:02
mriedemi swear there is another doc about configuring for nfv things like numa, and lbeliveau helped work on that18:02
mriedemand sfinucan18:02
cfriesenjlk: does "virsh capabilities" show numa node information?18:02
mriedemalaski: just had a cellsv1 failure with this http://logs.openstack.org/55/367455/1/check/gate-tempest-dsvm-cells/1d8af83/logs/screen-n-api.txt.gz#_2016-09-08_15_59_02_553 got a 500 from the api on delete18:03
mriedemalaski: in this test, it creates the server and then immediately deletes it18:03
mriedemdoesn't wait for active18:03
*** rlrossit has joined #openstack-nova18:04
jlkcfriesen: I see this      <topology> <cells num='2'>18:05
jlkam I looking for that, or something else?18:05
*** vishwanathj is now known as vishwanathj_18:06
jlkmaybe that's somethin gelse.18:06
*** twaldrop has joined #openstack-nova18:06
*** swamireddy has quit IRC18:06
cfriesenjlk: that's promising...then you should see <cell id='0'> with some "pages" entries and some cpus, then  <cell id='1'> and some memory/cpu info18:06
jlkcorrect18:06
*** wasmum has quit IRC18:06
cdentjaypipes: if I was going to make my decision to visit your home based on your recent tweets: _no way_18:07
jlk            <cpu id='0' socket_id='0' core_id='0' siblings='0,24'/>18:07
*** ducttape_ has joined #openstack-nova18:07
cfriesenjlk: okay, that's good.  what version of libvirt/qemu are you using?18:08
jaypipescdent: ikr?18:08
*** swamireddy has joined #openstack-nova18:08
alaskimriedem: okay. looks like there's a small race there. I can add some exception handling18:08
jaypipesedleafe: my issue with your proposed response format there is that then we need some kind of tribal knowledge to know that "generation" is not a resource class identifier.18:08
jlkcfriesen: libvirt is 1.2.2-0ubuntu13.1.17  qemu-kvm is 2.0.0+dfsg-2ubuntu1.2218:09
cfriesenjlk: just to confirm, you're using libvirt as the hypervisor?18:09
jaypipesedleafe: and the generation is *not* an attribute of the allocation/resource record, but rather the resource provider itself.18:09
jaypipesedleafe: so it feels, well, weird :)18:09
mriedemalaski: https://bugs.launchpad.net/nova/+bug/162157418:09
openstackLaunchpad bug 1621574 in OpenStack Compute (nova) "Instance fails to delete while building in cells v1 due to "ObjectActionError: Object action destroy failed because: host changed"" [Undecided,Confirmed]18:09
mriedemalaski: is that related to BuildRequests?18:09
sdaguealaski: thanks for https://review.openstack.org/#/c/367510/2 - +A18:09
*** ociuhandu has joined #openstack-nova18:10
alaskimriedem: yes. It's because we don't have this try/except also around line 224 http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/cells_api.py#n24218:10
cfriesenjlk: ah, here we go.  in virt/libvirt/driver.py, MIN_LIBVIRT_NUMA_VERSION = (1, 2, 7) and MIN_LIBVIRT_HUGEPAGE_VERSION = (1, 2, 8)18:10
mriedemalaski: cool18:11
cfriesenjlk: your version of libvirt is too old for NUMA support18:11
mriedemjlk: time to move to xenial18:11
mriedemor, kilo cloud archive18:11
jlkcfriesen: yeah, libvirt as the HV.18:12
jlkoh wtf?18:12
*** kaisers has joined #openstack-nova18:12
jlkWe had been using a newer version at some point, I wonder what changed18:12
mriedemlarry in accounting happened18:13
edleafejaypipes: Agreed, but it feels weird to have generation in there in the first place.18:13
cfriesenjlk: just as a heads-up, if you're enabling NUMATopologyFilter you're probably going to want to somehow enable debug logs, at least for that filter.  There are a bunch of obscure ways that a host can fail the filter.18:14
*** akshai has quit IRC18:14
*** lakshmiS has joined #openstack-nova18:14
jlkyeah, that's our plan. this is for a potential customer to test a work load, not a thing we'd want to turn on all the time18:14
*** ihrachys has quit IRC18:15
*** lakshmiS has left #openstack-nova18:15
jaypipesedleafe: the alternative is to do multiple REST API calls and hope that something doesn't change in between the two calls, which isn't much of an alternative IMHO :P18:16
*** efoley has joined #openstack-nova18:17
*** lpetrut has quit IRC18:17
*** rama_y has joined #openstack-nova18:17
*** kaisers has quit IRC18:17
*** shangxdy has quit IRC18:18
sdaguedansmith: that's an odd objects failure - http://logs.openstack.org/55/367455/1/check/gate-tempest-dsvm-cells/1d8af83/logs/screen-n-api.txt.gz?level=INFO#_2016-09-08_15_59_02_553 - is that just because cells v1 is odd?18:20
dansmithsdague: hmm18:21
dansmithsdague: that's a sanity check, so it's good that it's failing, but not sure when it would happen in the gate18:21
mriedemdansmith: sdague: scroll up18:21
dansmithoh in delete18:21
*** nic has left #openstack-nova18:21
*** krtaylor has joined #openstack-nova18:24
*** karthiks has quit IRC18:24
sdagueyeh, it's in the tear down of some servers18:24
mriedemi emailed sahid but i think we have a bug with the pointer_model config option that was added in newton18:24
mriedemhttp://logs.openstack.org/26/367526/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1479bdd/logs/screen-n-api.txt.gz?level=TRACE#_2016-09-08_17_31_42_49018:24
mriedemhttps://review.openstack.org/#/c/367526/18:24
*** lpetrut has joined #openstack-nova18:25
mriedemso use_usb_tablet is deprecated, but defaults to True. replaced by pointer_model, which defaults to None.18:25
*** tongli has joined #openstack-nova18:25
mriedemif you don't set pointer_model, we fallback to using use_usb_tablet18:25
mriedembut the defaults have different meanings18:25
mriedemand if you want that thing off, you can't really straddle it18:25
jlkso uh, related questions.18:26
jlkwhat concerns are there when upgrading qemu and libvirt versions on an existing cloud?18:26
mriedemupgrading libvirt shouldn't be an issue since it's an api over qemu18:27
mriedemrestarting qemu would restart the guests18:27
mriedemso i'd think you'd need to hot patch qemu or migrate instances off that compute prior to the upgrade18:27
*** sdake_ is now known as sdake18:27
sdagueqemu doesn't restart per say18:27
jlkright it's just a series of running processes18:28
sdaguethe guests will just be on the old version until you bounce them18:28
*** tongli has quit IRC18:28
jlkthat's fine18:28
*** tongli has joined #openstack-nova18:28
sdagueI believe you can just do the upgrade in place, then nova reboot on the computes when you can handle an outage for each compute, and you'll be fine18:29
dansmithyep18:29
jlkand what if they just are left running until the customer does a reboot action?18:29
jlkor rebuild or whatever?18:29
dansmithjlk: yep, fine18:30
sdaguethen they are left running18:30
jlkalright. I thought at one point there were some issues with the XML formats18:30
dansmithnope18:30
jlkand some scenarios where things would go sideways18:30
dansmithnot that I know of18:30
jlkneat.18:30
*** tongli has quit IRC18:30
dansmiththere were some live migration issues because of a bug in qemu18:30
sdaguewhile things are running, it's fine. They aren't getting new xml fed to them anyway, it's just a process18:30
dansmithbut nothing I've ever heard of regarding them being on a single host18:30
*** tongli has joined #openstack-nova18:31
*** RuiChen has quit IRC18:31
*** tongli has quit IRC18:32
*** tongli has joined #openstack-nova18:32
*** su_zhang has joined #openstack-nova18:33
sdaguedansmith: hmmm... http://logs.openstack.org/89/366789/2/check/gate-tempest-dsvm-cells/04607f2/logs/screen-n-api.txt.gz?level=ERROR#_2016-09-08_16_40_57_87718:33
sdaguesame error on delete in cellsv118:33
sdaguedifferent test18:33
*** tongli has quit IRC18:33
dansmithsdague: I'm thinking that's an early delete18:33
dansmithsdague: so it gets created with no host and then assigned then deleted?18:33
*** paul-carlton has quit IRC18:33
dansmithI have to run off now, but blame alaski18:34
dansmithit18:34
*** tongli has joined #openstack-nova18:34
dansmithit's not an objects thing regardless.. the assertion is just in that code18:34
*** thorst has joined #openstack-nova18:34
alaskiI need to replicate the try except at http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/cells_api.py#n242 a few lines up on line 22418:35
sdagueok, it just failed one of the placement patches on the hot list18:35
alaskiI have a patch, just figuring out testing18:35
sdaguealaski: ok, great18:35
*** akshai has joined #openstack-nova18:35
mriedemsdague: dansmith: yes it's an early delete18:35
mriedemthe tests are deleting the server while it's building18:35
mriedemsdague: i pushed the e-r query for this about 20 min ago18:36
mriedemjust fyi18:36
mriedemi could use some feedback on this https://bugs.launchpad.net/nova/+bug/162158218:36
openstackLaunchpad bug 1621582 in OpenStack Compute (nova) "use_usb_tablet and pointer_model have different defaults making switching hard" [Undecided,Confirmed]18:36
mriedemif it's an rc blocker or not18:36
*** jichen has joined #openstack-nova18:39
sdaguemriedem: yeh, that seems like an annoying upgrade issue we should avoid18:39
*** Swami has joined #openstack-nova18:39
mriedemi'm annoyed, yes18:39
mriedem:)18:39
jlkThanks for the help folks, we'll keep plugging away at this with a newer libvirt.18:40
*** mfedosin has quit IRC18:41
*** Jeffrey4l__ has quit IRC18:42
*** thorst has quit IRC18:42
mriedemsdague: added to the newton rc list so we don't forget about it, i've also emailed it to sahid to see if he has ideasd18:43
mriedemit was his bp18:43
*** mgoddard has quit IRC18:43
jaypipesgrr, still working on one remaining test failure...18:46
*** su_zhang has quit IRC18:47
*** Sukhdev has joined #openstack-nova18:51
*** david-lyle has quit IRC18:53
openstackgerritVladik Romanovsky proposed openstack/nova: libvirt: inject files when config drive is not requested  https://review.openstack.org/33567618:53
openstackgerritVladik Romanovsky proposed openstack/nova: cleanup: sparating the creation of a local root to it's own method  https://review.openstack.org/36757118:53
*** david-lyle has joined #openstack-nova18:53
*** Jeffrey4l__ has joined #openstack-nova18:54
openstackgerritDoug Hellmann proposed openstack/nova: standardize release note page ordering  https://review.openstack.org/36757818:56
*** vishwanathj_ is now known as vishwanathj19:00
*** abalutoiu has quit IRC19:01
*** tbachman has joined #openstack-nova19:01
openstackgerritChris Dent proposed openstack/nova: [placement] add two ways to GET allocations  https://review.openstack.org/36678919:03
*** rlrossit has quit IRC19:04
cdentjaypipes, edleafe, dansmith, bauzas ^ I think that hits the right notes on the representations. will add it to the etherpad19:04
*** TravT has quit IRC19:05
*** salv-orlando has quit IRC19:06
*** rlrossit has joined #openstack-nova19:07
*** rrecio has joined #openstack-nova19:08
openstackgerritVladik Romanovsky proposed openstack/nova: libvirt: inject files when config drive is not requested  https://review.openstack.org/33567619:10
openstackgerritVladik Romanovsky proposed openstack/nova: cleanup: separate the creation of a local root to it's own method  https://review.openstack.org/36757119:10
sdaguecdent: out of curiosity, when are we going to start the api-ref doc for all of this?19:11
cdentsdague: an excellent question. a) we probably need to have a more in depth discussion on how we'd like that to be b) we need to wait for us to stop changing things :(19:13
cdentI'm hoping it won't be just me19:13
sdaguepseudo related question, are the uuids in the paths format checked?19:15
jaypipescdent: ++ nice19:15
cdentsdague: you mean is /resource_providers/{uuid} check to be a uuid before we try to load that resource provider?19:15
cdentif that's the question the answer is no19:16
cdentI had some pattern matching on the Routes side that would not match the route if it was not a uuid but then got rid of it so that we had the option to make a better NotFound inside the handlers19:17
sdagueok, so if we send utf8 dolphin down that pipe, what happens?19:17
cdentit should be a 404, I've started some tests near that vein, but not quite exactly in:19:18
cdenthttps://review.openstack.org/#/c/365688/19:18
cdentsdague: btw, I still think we should do the "better noffound inside the handlers" at some point. My understanding of how the review process would flow this cycle was full of bad understandings.19:20
sdagueok, yeh, that doesn't seem to cover this case19:20
cdentyes, exactly, thus "near that vein"19:20
cdentI'm trying it now19:20
sdagueok, cool19:20
sdaguefor floating ips we are actually returning 400 on badly formatted path element19:20
sdaguebecause it turns out people do silly typos19:21
cdentthat seems odd19:21
sdagueand just doing 404 to people because they missed an octet in a copy to the command line ends up masking a lot of issues19:21
sdagueit exposed a bunch of client bugs where they were trying to do deletes with completely the wrong representation19:22
*** coolsvap has quit IRC19:22
edleafecdent: got one bug in https://review.openstack.org/#/c/366789, otherwise I'm +119:23
cdentsdague I understand the motivation, but if the URI is correctly formed (uses characters that are okay) but there's no resource, that's a 40419:23
edleafecdent: that method is a bit too clever19:23
cdentthanks edleafe will look in a sec19:23
cdentedleafe: yeah, I had two different ones before and felt bad about so made one and then felt bad about that too19:23
oomichisdague: cdent: hi, a question about https://review.openstack.org/#/c/33738019:23
oomichisdague: cdent: If flavor setting is invalid and "create a server" API needs to return an error response, what is the best status code?19:24
cdentand then decided to just see what people said19:24
sdaguecdent: but if we know that it's not even possible for that uri to exist, it seems weird to not be helpful and tell the user19:24
sdagueoomichi: the 400 seems right19:24
cdentsdague: sure, but that would be in the 404's message, not changing the 40419:24
oomichisdague: cdent: current patch returns 400, but wrong flavor setting is due to operator, not user. 400 doesn't seem right19:24
*** moshele has joined #openstack-nova19:25
oomichisdague: cdent: or should we consider users specify wrong flavor?19:25
cdentoomichi: i haven't had a chance to read it yet, what's the alternative to 400?19:25
sdaguecdent: well, turns out people assume 404s are because they already deleted the thing in question19:26
mriedemhemanthm: in addition to those examples, the biggest online data migration, and i think the first, was moving flavor info from instance.system_metadata to instance.flavor in kilo19:26
cdentsdague: I don't know how to respond to that. Some people assume stop signs are optional and suffer no consequences as a result, but doing so isn't right.19:28
mriedemhemanthm: this will probably hurt your eyes, but https://review.openstack.org/#/c/135700/19:28
mriedemhemanthm: like i said, that was the biggest and most complicated online data migration19:28
cdent(snowman resource provider uuid gives a 404 as expected, will add those tests)19:28
mriedemhemanthm: with the nova db to api db migrations, those are mostly a pattern of new things go to the api db, we do lookups in the api db first and then fallback to the nova (old) db, and then have a nova-manage command to force that migration during upgrades19:29
mriedemwe don't migrate on lookup like in https://review.openstack.org/#/c/135700/19:29
mriedemhemanthm: i'm assuming glance will have a summit session about rolling upgrade plans?19:30
mriedemand keystone probably is too?19:30
stevemarmriedem: probably19:30
hemanthmmriedem: yep, there's a fishbown session on rolling upgrades19:30
hemanthm*fishbowl19:30
mriedemhemanthm: you can probably do similar things w/o versioned objects for these data migrations19:31
mriedemwe do them in the objects since that's where we access the db apis and it's a convenient abstraction19:31
stevemarmriedem: depends on who the sucker^H^H^H ptl is at the time19:31
hemanthmmriedem: +1, that's what I'm trying to research.19:32
mriedemhemanthm: but like in this series https://review.openstack.org/#/q/topic:bp/cells-keypairs-api-db i don't think we actually needed to bump the version on the instance object, except when adding the new field19:33
mriedemotherwise the data migrations don't require a version bump19:33
hemanthmI guess putting all that logic into db layer will probably make it a lot more messy19:33
*** su_zhang has joined #openstack-nova19:33
openstackgerritKenneth Burger proposed openstack/nova: Increase BDM column in build_requests table  https://review.openstack.org/36695519:33
hemanthmand oslo.vo maybe an overkill for glance at this point19:33
mriedemwell, you're going to have conditionals somewhere19:33
mriedemstevemar: that's not going to be you?19:34
*** mgoddard has joined #openstack-nova19:36
stevemarmriedem: i can be a sucker too19:38
*** su_zhang has quit IRC19:38
*** thorst has joined #openstack-nova19:39
openstackgerritChris Dent proposed openstack/nova: [placement] Add some tests ensuring unicode resource provider info  https://review.openstack.org/36568819:39
*** cmartin_ has quit IRC19:40
oomichicdent: yeah, that is my question. In this case, operator needs to fix the flavor. I cannot find better one, tbh19:40
cdentoomichi: I don't think you want anything in the 5xx range, and none of the specific options in the 4xx range seem to fix, so 400 is the reasonable fallback19:40
oomichicdent: ok, now I feel 400 can cover this case also like https://github.com/openstack/api-wg/blob/master/guidelines/http.rst#use-of-501---not-implemented19:40
*** efoley has quit IRC19:40
oomichicdent: yeah, I cannot find valid 50x in this case19:41
* cdent nods19:41
*** Apoorva has quit IRC19:41
oomichicdent: it seems enough to report back a reson in response.19:41
oomichicdent: sdague: I got it, thanks :)19:42
*** tongli_ has joined #openstack-nova19:43
*** burgerk has quit IRC19:43
openstackgerritjichenjc proposed openstack/nova: Catch DevicePathInUse in attach_volume  https://review.openstack.org/36735819:44
openstackgerritAndrew Laski proposed openstack/nova: Handle ObjectActionError during cells instance delete  https://review.openstack.org/36759719:44
* cdent is the king of adding undesirable whitespace19:45
*** tongli has quit IRC19:46
*** thorst has quit IRC19:47
*** code-R_ has quit IRC19:47
*** yamahata has joined #openstack-nova19:49
*** sdake_ has joined #openstack-nova19:50
*** Jeffrey4l__ has quit IRC19:50
openstackgerritChris Dent proposed openstack/nova: [placement] add two ways to GET allocations  https://review.openstack.org/36678919:50
melwittI triaged a numa bug recently where it looks like we've been using the wrong image metadata key names for a few things. is that something we would want to look at as rc potential? https://bugs.launchpad.net/nova/+bug/156819119:50
openstackLaunchpad bug 1568191 in Glance "Pre-defined VirtCPUTopology metadata should have the same name as flavor extra specs in nova" [Undecided,In progress] - Assigned to Ying Zuo (yingzuo)19:50
openstackgerritjichenjc proposed openstack/nova: refactory query user_id code for quota-sets  https://review.openstack.org/28016519:51
melwittthat is assuming that glance is the source of truth for the key names19:51
*** sdake has quit IRC19:52
mriedemmelwitt: sfinucan has a comment in there, "For things like CPU policies, image metadata will take precedence over flavor extra specs, but both are valid."19:53
mriedemthat's how i've seen things work for some other keys, there are image meta keys and flavor extra specs, and not always the same19:53
mriedembut one takes precedence19:53
melwittmriedem: yeah, but if we pull the data using the wrong key names we won't get it?19:53
* cdent waves19:54
*** cdent has quit IRC19:54
mriedemmelwitt: the code would need to know to use the proper key name right19:54
mriedemand why they'd be different idk19:54
mriedemthat's just asking for problems19:54
*** prateek has quit IRC19:54
sdaguemriedem: because they namespace differently I think19:54
sdaguehttps://github.com/openstack/glance/blob/1c242032fbb26fed3a82691abb030583b4f8940b/etc/metadefs/compute-vcputopology.json#L19 vs https://github.com/openstack/glance/blob/1c242032fbb26fed3a82691abb030583b4f8940b/etc/metadefs/compute-vcputopology.json#L1019:55
*** ducttape_ has quit IRC19:55
sdagueoh, there is an extra _ in the nova names?19:56
mriedemyeah there was something for a bp in newton that i was reviewing that was like this, i think the hyper-v uefi stuff19:56
melwittours is for flavor extra specs, for example hw:cpu_max_sockets and in glance image meta it's hw_cpu_maxsockets19:56
*** kaisers has joined #openstack-nova19:56
sdaguehttps://github.com/openstack/nova/blob/f5c0b59fd68e88aa37ec69b8e544c31e6809da44/nova/virt/hardware.py#L273-L28019:56
*** Oku_OS is now known as Oku_OS-away19:56
mriedemhttps://review.openstack.org/#/c/209581/45/releasenotes/notes/hyperv-uefi-secure-boot-a2a617ac2c313afd.yaml19:57
sdaguemelwitt: so, mostly it's fine that they are different, but it looks like our definitions for glance are just wrong19:57
melwittthe person proposed a change to change glance's key names to match ours, it's currently -2ed https://review.openstack.org/#/c/303658/19:57
melwittsdague: right. that's what it appeared to me too19:57
sdaguemelwitt: so you just need to delete some underscores right?19:57
sdaguehttps://github.com/openstack/nova/blob/f5c0b59fd68e88aa37ec69b8e544c31e6809da44/nova/virt/hardware.py#L316-L31819:58
melwittsdague: I think so19:58
mriedemfor that hyperv uefi one the pattern is the same, image meta starts with os_* and extra spec starts with os:*19:58
sdaguemriedem: right, I don't think that kind of change is a thing here, but the narrower one that melwitt has is probably fine for rc19:58
sdagueit should be a pretty small patch19:58
mriedemis this a regression?19:59
melwittI don't think it's a regression. afaict it's been like this19:59
mriedemyeah, so not an rc blocker, but simple sounding fix19:59
mriedemand we could backport it19:59
sdaguemriedem: we could, but it also doesn't get in the way to get it in20:00
sdaguewe wouldn't hold the rc for the bug20:00
*** kaisers has quit IRC20:00
mriedemagree20:00
sdaguebut it's a valid bug I think to fix20:00
sdaguebefore the rc20:00
melwittdoes the newton-rc-potential tag mean "hold the release for it"?20:01
sdaguemelwitt: yes20:01
mriedemmelwitt: yup20:01
melwittokay, thanks20:01
mriedemit at least means, potentially hold the release20:01
sdagueso don't tag it that way, but if you get a patch up with it and it gets in, we're good. This seems super quick to get in.20:01
mriedemmelwitt: yeah just ping for attention20:02
mriedemi know you're usually very pushy about people reviewing your code and all :)20:02
sdagueheh20:02
mriedemyou also suffer from laski syndrome20:02
melwittokay, cool. I haven't noticed a trend in the tagged ones i.e. they're not all regressions so I wasn't sure20:02
melwitthaha, that's true :)20:03
*** moshele has quit IRC20:03
mtreinishmriedem: that sounds contagious20:05
mriedemmtreinish: i don't think so,20:05
mriedempeople don't generally get nicer20:06
mriedembauzas: is this a regression in newton? https://bugs.launchpad.net/nova/+bug/160025120:06
openstackLaunchpad bug 1600251 in OpenStack Compute (nova) "live migration does not honor server group policy" [High,In progress] - Assigned to Paul Carlton (paul-carlton2)20:06
mriedemsince it's marked for mitaka-backport-potential i'm assuming not20:06
mriedempaul-carlton2: ^20:07
bauzasmriedem: that regressed in Mitaka unfortunatly :(20:07
*** cdelatte has quit IRC20:08
oomichimriedem: could you go back to https://review.openstack.org/#/c/358152/ again?20:10
*** su_zhang has joined #openstack-nova20:10
mriedemoomichi: i'm not sure what "So I am not sure we need to drop this on Nova side or not." means20:11
oomichimriedem: ah, sorry about that. I wanted to mean the corresponding neutron patch is merged into liberty branch as https://review.openstack.org/#/c/338200/20:13
mriedemoomichi: i'm not sure how the neutron patch is related20:14
mriedemoomichi: does the neutron change mean that the nova error won't happen?20:14
mriedemif you have that neutron change i mean20:14
mriedemi.e. nova won't get the port not found that the nova change is handling20:14
mriedemin other words, will fip['port_id'] in https://review.openstack.org/#/c/358152/1/nova/network/neutronv2/api.py just be None?20:15
*** Guest60381 has quit IRC20:16
*** praveen has quit IRC20:16
*** mgoddard has quit IRC20:16
*** Oku_OS-away is now known as Oku_OS20:16
mriedemoomichi: the other thing was there were no logstash hits for that failure, which to me means we're not hitting this often in the gate20:17
mriedemso i don't see the justification for landing that in liberty if it's not really going to benefit tempest runs20:18
*** su_zhang has quit IRC20:18
*** salv-orlando has joined #openstack-nova20:18
*** ducttape_ has joined #openstack-nova20:18
oomichimriedem: ok, I will check the code deeply later. About the policy of stable branches, do backporting patches need to be verified on the gate?20:20
*** yamahata has quit IRC20:20
mriedemoomichi: well we run ci on them20:21
mriedemoomichi: but i'm not sure that's what you're asking20:21
mriedemoomichi: my point is, stable/liberty is more or less locked down20:21
mriedemhttp://docs.openstack.org/project-team-guide/stable-branches.html20:22
mriedemliberty is in phase 320:22
mriedemso we need justification for landing things in liberty, like if they are fixing a security or critical bug, or if landing them would unblock something else, like a new tempest test / change for example, or unblock the gate20:22
*** salv-orlando has quit IRC20:22
mriedemfrom a high percentage test failure20:22
oomichimriedem: ah, I saw the point. (Phase III (more than 12 months): Only security patches are acceptable)20:23
*** su_zhang has joined #openstack-nova20:23
mriedemit's not always security fixes,20:23
mriedembut phase 3 branch changes get more scrutiny20:23
oomichimriedem: I got it, thanks for the explanation20:24
oomichimriedem: I just had a question about difference between mitaka patch and liberty patch, that is clear now20:25
*** Oku_OS is now known as Oku_OS-away20:26
mriedemnp20:27
*** jichen has quit IRC20:30
*** Oku_OS-away is now known as Oku_OS20:31
*** TravT has joined #openstack-nova20:31
*** su_zhang has quit IRC20:32
*** salv-orlando has joined #openstack-nova20:33
*** thorst has joined #openstack-nova20:34
mriedemalaski: what was the donut place in portland that you loved?20:37
alaskiblue star20:37
mriedemdansmith: i don't want to alarm you, but my parents are going to be in portland next week20:37
mriedemi've informed them that you live in a mountain stronghold on TMNT ave20:37
dansmithmriedem: do I have to see them?20:37
dansmithhaha20:37
sdaguedansmith: you back and about? In looking at the request timings with / without my logging patch - https://review.openstack.org/#/c/366186/ - it's really only on order a couple of ms per request. Which, during our initial phase here isn't a huge cost for being able to know if things are working20:38
*** hamzy has quit IRC20:38
sdagueand we can tune it down later once our comfort level goes up20:38
dansmithsdague: yeah, I hear you, I just don't think we should do that20:38
sdagueok, so without that, I really can't debug anything here.20:39
dansmithsdague: I didn't -1 and poked jaypipes and he said he'd think about it20:39
dansmithI dunno where he went though20:39
mriedembtw, there could be a CONF.trace option in ocata https://review.openstack.org/#/c/366422/20:40
mriedemto hide that behind20:40
*** Oku_OS is now known as Oku_OS-away20:40
*** Apoorva has joined #openstack-nova20:41
sdaguemriedem: right, and I'm fine tuning that down later. The cost for this verification seems really low20:42
dansmithyou're doing a bunch of other DB queries every time we do something that was supposed to be a single transaction into the database20:42
*** thorst has quit IRC20:42
sdaguethey are all reads, and they are cheap reads based on the timing there20:43
dansmiththe measured penalty in a gate scenario with a few allocations per provider doesn't really mean much to me20:43
sdagueok, that's fine, I'm totally ok not doing anything more on the placement api side. But I couldn't figure out any of the allocation issues without this patch.20:44
*** burgerk has joined #openstack-nova20:44
dansmithis that like "I refuse to do anything else if we don't merge my logging patch" ? :)20:45
sdaguethis is the way that I can see that things actually work, without it, I feel like we're pretty blind20:45
*** ducttape_ has quit IRC20:46
sdagueanyway, it's dinner time, catch you all tomorrow20:46
dansmithbut see,20:46
dansmithyou can get all that data from the /usage part of the api20:46
*** Apoorva has quit IRC20:46
dansmithso logging the allocations and the inventories is definitely cool,20:47
dansmithbut we can poke the usage calculation externally any time we need, which seems like the appropriate thing to do here20:47
dansmithbut again, just MHO, I didn't even -120:47
*** russellb has left #openstack-nova20:48
dansmithmriedem: I'm cool with that trace patch... should I review/+2?20:49
dansmithmriedem: and your reno says "may bring system to knees" so seems more appropriate to hide something that does extra queries behind too20:50
openstackgerritmelanie witt proposed openstack/nova: Correct image metadata key names to glance definition  https://review.openstack.org/36762720:51
*** sdague has quit IRC20:52
*** tongli_ has quit IRC20:52
*** tongli has joined #openstack-nova20:53
*** ducttape_ has joined #openstack-nova20:55
*** tongli_ has joined #openstack-nova20:56
*** Guest83073 has quit IRC20:57
*** tongli has quit IRC20:57
*** mvk has joined #openstack-nova20:58
*** harlowja_ has joined #openstack-nova20:59
*** harlowja has quit IRC21:00
*** abalutoiu has joined #openstack-nova21:01
mriedemdansmith: are you oslo.log core?21:02
*** pwnall1 has joined #openstack-nova21:02
*** su_zhang has joined #openstack-nova21:03
*** abalutoiu has quit IRC21:03
*** pwnall1 has quit IRC21:07
*** pwnall1 has joined #openstack-nova21:08
*** su_zhang has quit IRC21:08
*** mmedvede has quit IRC21:09
*** devananda is now known as devananda|bbl21:09
*** pwnall1 has quit IRC21:09
mriedemcan we do a thing where we call the usage API only if we hit a conflict or failure in the RT as a debug tool?21:11
*** kevinz has joined #openstack-nova21:12
rlrossitI'll jump in here because I apparently care about logging now too... with sdague's patch, even if we have log.trace, it's still going to do all of those operations right? and then the only configurable part is logging it or not21:13
rlrossitis there any case of if we're doing logging, do all of these heavy operations and log it out, else noop?21:14
burgerkmriedem: do you know of any examples of checking if ia column is MEDIUMTEXT.   It seems the column is just returning TEXT for the type field21:16
mriedemburgerk: not sure, would have to look for existing migrations that change a type on a field21:16
mriedemburgerk: zzzeek might know21:16
*** nherciu has quit IRC21:17
*** kevinz has quit IRC21:17
alaskimriedem: https://review.openstack.org/#/c/367597/21:18
*** ametts has quit IRC21:19
mriedemyup had it open but then got distracted21:20
alaskicool. I just read scrollback and saw your comment to melwitt so figured I had better ping you21:21
melwittheh21:22
*** pwnall1 has joined #openstack-nova21:23
*** tongli_ has quit IRC21:26
*** tonytan4ever has quit IRC21:27
*** cleong has quit IRC21:30
*** pwnall1 has quit IRC21:30
*** ametts has joined #openstack-nova21:31
mriedemmelwitt: how does your image meta change not break on a version bump?21:34
mriedemsince the field is being renamed?21:34
melwittmriedem: I considered that but I thought since the keys are wrong it's currently a no-op? I'm not sure21:36
mriedemmelwitt: probably need to ask dansmith21:37
mriedemseems like an upgrade issue though21:37
mriedemlike, i'd think we'd need 3 new keys that translate for the old keys if used21:37
mriedemand then we drop the old keys in v2.0 of that object21:37
melwitthm21:38
*** thorst has joined #openstack-nova21:39
*** rmcall has joined #openstack-nova21:40
*** lpetrut has quit IRC21:41
melwittmriedem: well, the patch just failed the "test object versions" test so looks like you're right21:42
mriedemYES!21:42
melwitt:)21:42
*** diana_clarke has joined #openstack-nova21:43
*** whenry has joined #openstack-nova21:44
*** kaisers has joined #openstack-nova21:45
*** thorst has quit IRC21:47
*** kaisers has quit IRC21:49
*** whenry has quit IRC21:50
*** mmedvede has joined #openstack-nova21:53
*** su_zhang has joined #openstack-nova21:53
*** tblakes has quit IRC21:54
*** ametts has quit IRC21:57
*** annegentle has quit IRC21:58
*** annegentle has joined #openstack-nova21:59
mriedemalaski: question inline in https://review.openstack.org/#/c/367597/22:01
*** rlrossit has quit IRC22:02
*** rtheis has quit IRC22:04
*** marst has quit IRC22:05
*** jamesdenton has quit IRC22:06
*** burt has quit IRC22:09
*** dimtruck is now known as zz_dimtruck22:11
*** mdrabe has quit IRC22:12
*** tristanC has quit IRC22:12
*** baoli has quit IRC22:13
*** tristanC has joined #openstack-nova22:13
*** baoli has joined #openstack-nova22:13
*** hemna is now known as hemnafk22:16
*** BjoernT has quit IRC22:17
*** harlowja has joined #openstack-nova22:18
*** harlowja_ has quit IRC22:22
*** mvk has quit IRC22:23
*** artom has quit IRC22:25
alaskimriedem: answered22:27
*** tonytan4ever has joined #openstack-nova22:28
*** su_zhang has quit IRC22:31
mriedemalaski: so if host was set, then cell_name should also be set?22:31
mriedemand elif instance.cell_name should pass?22:31
*** claudiub|2 has quit IRC22:32
*** artom has joined #openstack-nova22:32
*** tonytan4ever has quit IRC22:33
*** sdake has joined #openstack-nova22:34
*** sdake_ has quit IRC22:36
*** mriedem has quit IRC22:36
*** mvk has joined #openstack-nova22:37
*** kylek3h has quit IRC22:38
*** akshai has quit IRC22:42
*** BjoernT has joined #openstack-nova22:42
*** thorst has joined #openstack-nova22:44
*** sai has quit IRC22:49
*** krtaylor has quit IRC22:51
*** thorst has quit IRC22:53
*** sai has joined #openstack-nova22:54
*** xyang1 has quit IRC22:56
*** rrecio has quit IRC22:59
*** sdake has quit IRC22:59
*** Sukhdev has quit IRC23:00
*** BjoernT has quit IRC23:01
*** baoli has quit IRC23:06
*** annegentle has quit IRC23:08
*** pradk has quit IRC23:08
*** sai has quit IRC23:11
*** lucas-dinner has quit IRC23:12
*** Apoorva has joined #openstack-nova23:18
*** tjones has joined #openstack-nova23:21
*** kylek3h has joined #openstack-nova23:23
*** markvoelker has quit IRC23:25
*** mriedem has joined #openstack-nova23:25
*** sai has joined #openstack-nova23:26
*** lucasagomes has joined #openstack-nova23:26
*** vladikr has quit IRC23:29
*** jamesdenton has joined #openstack-nova23:31
*** Guest52068 has quit IRC23:31
*** kaisers has joined #openstack-nova23:34
*** annegentle has joined #openstack-nova23:36
*** kaisers has quit IRC23:38
*** annegentle has quit IRC23:39
openstackgerritmelanie witt proposed openstack/nova: Correct image metadata key names to glance definition  https://review.openstack.org/36762723:40
*** gongysh has joined #openstack-nova23:40
*** krtaylor has joined #openstack-nova23:45
mriedemburgerk: i'm guessing the test was having issues with MediumText because it's not actually a thing in sqla23:47
mriedemit's some variant thing23:48
*** devananda|bbl is now known as devananda23:48
*** thorst has joined #openstack-nova23:50
*** Swami has quit IRC23:51
openstackgerritmelanie witt proposed openstack/nova: Pass GENERATE_HASHES to the tox test environment  https://review.openstack.org/36769523:52
*** BjoernT has joined #openstack-nova23:52
mriedemburgerk: the tests are failing for postgres and sqlite, not mysql23:54
mriedemhttp://logs.openstack.org/55/366955/3/check/gate-nova-tox-db-functional-ubuntu-xenial/22ae96a/console.html#_2016-09-08_19_51_07_12244723:54
mriedembecause MediumText is a mysql variant as defined in the migration23:54
mtreinishmriedem: that's easy to workaround in the test (assuming that's behavior you actually want)23:55
mtreinishwhich I'm not sure why it would be23:56
openstackgerritTracy Jones proposed openstack/nova: VMware: Refactor the image transfer  https://review.openstack.org/28113423:56
mriedemyeah we can make the check conditional on the db engine23:56
mriedembut i'm not sure if that's right23:56
*** thorst has quit IRC23:57
mriedemidk, that seems to be what we did for the other migrations that use mediumtext like this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/migrate_repo/versions/216_havana.py#L3223:58
mriedemthere are no backend specific checks for those23:58
mriedemi don't know what the difference is for that between mysql and pg23:58
mriedemhttp://docs.sqlalchemy.org/en/latest/core/custom_types.html?highlight=with_variant#sqlalchemy.types.TypeDecorator.with_variant23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!