| *** markvoelker has joined #openstack-nova | 00:00 | |
| *** shaohe_feng has quit IRC | 00:01 | |
| *** shaohe_feng has joined #openstack-nova | 00:02 | |
| mriedem | oomichi: yeah, so looking at what calls that method, it looks like the instance we get here (or don't), doesn't even matter | 00:05 |
|---|---|---|
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L195 | 00:05 |
| mriedem | because the instance passed in for that method in neutron isn't used. | 00:05 |
| mriedem | doesn't look like the instance is used in the nova-network case either | 00:06 |
| *** baoli has joined #openstack-nova | 00:07 | |
| oomichi | mriedem: oops, I misunderstood the instance is used in nova-network case.. | 00:07 |
| mriedem | it's not used | 00:08 |
| mriedem | for DELETE os-floatingips | 00:08 |
| mriedem | we get the instance, then we pass it to the network API but it's not used by either network API | 00:08 |
| *** diogogmt has joined #openstack-nova | 00:11 | |
| *** shaohe_feng has quit IRC | 00:12 | |
| *** shaohe_feng has joined #openstack-nova | 00:12 | |
| oomichi | mriedem: humm, then current API layer is doing unnecessary operation for the delete | 00:14 |
| mriedem | yup | 00:14 |
| mriedem | disassociate_and_release_floating_ip and disassociate_floating_ip both take an instance but never use it | 00:14 |
| mriedem | so, i'm going to put up a WIP patch to see what removing instance from those network APIs does | 00:15 |
| oomichi | mriedem: ok, I see that on the code now. How about fixing the bug on current one and removing that lately? | 00:16 |
| mriedem | because none of them are versioned either so might be fine to just clean this up | 00:16 |
| oomichi | mriedem: cool | 00:16 |
| mriedem | yeah i already +2d your change | 00:16 |
| mriedem | there are comments inline | 00:16 |
| mriedem | the logged message is redundant | 00:16 |
| mriedem | if you fix i'd +2 again | 00:16 |
| oomichi | mriedem: ok, I changed the code localy and waiting pep8 check | 00:21 |
| *** shaohe_feng has quit IRC | 00:22 | |
| *** shaohe_feng has joined #openstack-nova | 00:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove nova/api/validator.py https://review.openstack.org/355392 | 00:23 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Return None in get_instance_id_by_floating_address https://review.openstack.org/351960 | 00:24 |
| oomichi | mriedem: ^^^ done | 00:24 |
| *** Swami has quit IRC | 00:24 | |
| mriedem | ok | 00:25 |
| *** thorst_ has joined #openstack-nova | 00:28 | |
| *** woodster_ has quit IRC | 00:29 | |
| *** shaohe_feng has quit IRC | 00:32 | |
| cfriesen | Could someone take a look at this and see if I'm smoking crack? I think I'm hitting an issue that would affect Liberty/Mitaka upgrades if you're using PCI device tracking. https://bugs.launchpad.net/nova/+bug/1613488 | 00:34 |
| openstack | Launchpad bug 1613488 in OpenStack Compute (nova) "changed fields of versionedobjects not tracked properly when down-versioning object" [Undecided,New] | 00:34 |
| cfriesen | basically it's tied to oslo_versionedobjects and how the "changed fields" are tracked during RPC calls when the object gets down-versioned | 00:35 |
| *** shaohe_feng has joined #openstack-nova | 00:35 | |
| *** hieulq has joined #openstack-nova | 00:36 | |
| *** gongysh has joined #openstack-nova | 00:36 | |
| mriedem | damn, so disassociate_floating_ip is decorated with @refresh_cache which does take an instance, that's the point | 00:37 |
| mriedem | oomichi: ^ | 00:37 |
| *** smatzek has joined #openstack-nova | 00:38 | |
| mriedem | and if we don't pass an instance, we might hit a value error in there | 00:38 |
| mriedem | except ValueError: | 00:38 |
| mriedem | msg = _('instance is a required argument to use @refresh_cache') | 00:38 |
| mriedem | raise Exception(msg) | 00:38 |
| mriedem | disassociate_and_release_floating_ip doesn't have the refresh_cache decorator, but for nova-network disassociate_and_release_floating_ip calls disassociate_floating_ip, which does refresh the cache | 00:40 |
| mriedem | looks like we don't do that in the caes of neutron, which is probably a separate bug | 00:41 |
| *** shaohe_feng has quit IRC | 00:42 | |
| *** shaohe_feng has joined #openstack-nova | 00:43 | |
| mriedem | dansmith: you know what's awesome, network api methods with decorators forcing code in the rest api which is totally obfuscated ^ | 00:44 |
| mriedem | rest api: pass this down to the network api, even if the parameter isn't directly used by the method, but note the decorator... | 00:44 |
| dansmith | mriedem: I don't even know what you just said | 00:45 |
| dansmith | sounds bad tho | 00:45 |
| mriedem | ha | 00:45 |
| mriedem | when you disassociate a floating IP from a server, we're passing the server down to the network API but the server parameter is only used by the refresh_cache decorator, | 00:46 |
| mriedem | and only for nova-network | 00:46 |
| mriedem | :( | 00:46 |
| mriedem | s/disassociate/delete/ a floating ip | 00:46 |
| *** amotoki has joined #openstack-nova | 00:47 | |
| *** jamielennox is now known as jamielennox|away | 00:48 | |
| *** smatzek has quit IRC | 00:49 | |
| *** jamielennox|away is now known as jamielennox | 00:49 | |
| *** tonytan4ever has joined #openstack-nova | 00:50 | |
| *** csmart has quit IRC | 00:52 | |
| *** shaohe_feng has quit IRC | 00:53 | |
| *** csmart has joined #openstack-nova | 00:53 | |
| *** shaohe_feng has joined #openstack-nova | 00:53 | |
| *** cheneydc has joined #openstack-nova | 00:55 | |
| *** hoangcx has joined #openstack-nova | 00:56 | |
| *** phuongnh has joined #openstack-nova | 00:58 | |
| *** nic has quit IRC | 00:59 | |
| *** cheneydc has quit IRC | 01:01 | |
| *** sameo has quit IRC | 01:03 | |
| *** shaohe_feng has quit IRC | 01:03 | |
| *** shaohe_feng has joined #openstack-nova | 01:04 | |
| *** gongysh has quit IRC | 01:05 | |
| dansmith | mriedem: this passed ironic and the gate is clear, so ready for +W https://review.openstack.org/#/c/355659/ | 01:07 |
| *** baoli has quit IRC | 01:10 | |
| *** baoli has joined #openstack-nova | 01:12 | |
| *** shaohe_feng has quit IRC | 01:13 | |
| mriedem | dansmith: what about this https://review.openstack.org/#/c/355602/ ? | 01:13 |
| mriedem | also need that or not? | 01:13 |
| mriedem | or that's just the revert of the revert | 01:13 |
| *** BjoernT has joined #openstack-nova | 01:14 | |
| *** shaohe_feng has joined #openstack-nova | 01:14 | |
| dansmith | mriedem: right, I'll finish that tomorrow | 01:15 |
| *** BjoernT has quit IRC | 01:18 | |
| *** Apoorva_ has joined #openstack-nova | 01:19 | |
| mriedem | so https://review.openstack.org/#/c/355659/ doesn't fix the cellsv1 job failure does it? looks like https://review.openstack.org/#/c/355602/ fixes that since the job was failing setup with "No hosts found to map to cell, exiting." | 01:21 |
| mriedem | but i guess even if we got past that, you'd get a duplicate entry exception | 01:21 |
| mriedem | which is what https://review.openstack.org/#/c/355659/ is for | 01:21 |
| mriedem | because of this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L144 | 01:22 |
| *** Apoorva has quit IRC | 01:23 | |
| *** shaohe_feng has quit IRC | 01:23 | |
| *** shaohe_feng has joined #openstack-nova | 01:24 | |
| *** Apoorva_ has quit IRC | 01:24 | |
| *** haplo37__ has joined #openstack-nova | 01:24 | |
| *** sameo has joined #openstack-nova | 01:24 | |
| *** kevinz has joined #openstack-nova | 01:25 | |
| *** ijw has quit IRC | 01:32 | |
| *** shaohe_feng has quit IRC | 01:34 | |
| *** EinstCrazy has joined #openstack-nova | 01:34 | |
| *** shaohe_feng has joined #openstack-nova | 01:35 | |
| *** wangqun has joined #openstack-nova | 01:37 | |
| *** ijw has joined #openstack-nova | 01:38 | |
| *** thorst_ has quit IRC | 01:38 | |
| *** thorst_ has joined #openstack-nova | 01:39 | |
| *** rfolco has quit IRC | 01:39 | |
| *** baoli has quit IRC | 01:43 | |
| *** amotoki has quit IRC | 01:43 | |
| *** vishwanathj has quit IRC | 01:44 | |
| *** shaohe_feng has quit IRC | 01:44 | |
| *** shaohe_feng has joined #openstack-nova | 01:44 | |
| *** Sukhdev has quit IRC | 01:44 | |
| *** gongysh has joined #openstack-nova | 01:45 | |
| *** thorst_ has quit IRC | 01:48 | |
| *** ijw has quit IRC | 01:49 | |
| *** baoli has joined #openstack-nova | 01:51 | |
| openstackgerrit | xhzhf proposed openstack/nova: [vncproxy] log for closing web is misleading https://review.openstack.org/353807 | 01:52 |
| *** haplo37__ has quit IRC | 01:53 | |
| *** su_zhang has quit IRC | 01:54 | |
| *** shaohe_feng has quit IRC | 01:54 | |
| *** shaohe_feng has joined #openstack-nova | 01:55 | |
| *** gongysh has quit IRC | 01:55 | |
| *** EinstCrazy has quit IRC | 01:59 | |
| *** ijw has joined #openstack-nova | 02:01 | |
| *** thorst_ has joined #openstack-nova | 02:02 | |
| *** tiendc has joined #openstack-nova | 02:02 | |
| *** thorst_ has quit IRC | 02:03 | |
| *** EinstCrazy has joined #openstack-nova | 02:03 | |
| *** gongysh has joined #openstack-nova | 02:04 | |
| *** shaohe_feng has quit IRC | 02:04 | |
| *** dimtruck is now known as zz_dimtruck | 02:05 | |
| *** shaohe_feng has joined #openstack-nova | 02:05 | |
| *** zz_dimtruck is now known as dimtruck | 02:05 | |
| *** ijw has quit IRC | 02:06 | |
| *** jamielennox is now known as jamielennox|away | 02:07 | |
| *** xinliang has quit IRC | 02:09 | |
| *** xinliang has joined #openstack-nova | 02:09 | |
| *** xinliang has quit IRC | 02:09 | |
| *** xinliang has joined #openstack-nova | 02:10 | |
| *** EinstCra_ has joined #openstack-nova | 02:11 | |
| *** pradk has quit IRC | 02:12 | |
| *** EinstCrazy has quit IRC | 02:14 | |
| *** shaohe_feng has quit IRC | 02:15 | |
| *** shaohe_feng has joined #openstack-nova | 02:15 | |
| *** gongysh has quit IRC | 02:20 | |
| *** baoli has quit IRC | 02:21 | |
| *** shaohe_feng has quit IRC | 02:25 | |
| *** raunak has quit IRC | 02:25 | |
| *** shaohe_feng has joined #openstack-nova | 02:26 | |
| *** jamielennox|away is now known as jamielennox | 02:26 | |
| *** mriedem is now known as mriedem_away | 02:27 | |
| *** zerda2 has joined #openstack-nova | 02:27 | |
| *** gcb_ has joined #openstack-nova | 02:31 | |
| *** shaohe_feng has quit IRC | 02:35 | |
| *** rama_y has joined #openstack-nova | 02:35 | |
| *** houming has joined #openstack-nova | 02:36 | |
| *** gongysh has joined #openstack-nova | 02:36 | |
| *** shaohe_feng has joined #openstack-nova | 02:36 | |
| *** sameo has quit IRC | 02:37 | |
| *** mdrabe has joined #openstack-nova | 02:39 | |
| *** ijw has joined #openstack-nova | 02:40 | |
| *** fragatin_ has joined #openstack-nova | 02:42 | |
| *** fragatina has quit IRC | 02:45 | |
| *** shaohe_feng has quit IRC | 02:45 | |
| *** zhenguo has joined #openstack-nova | 02:46 | |
| *** shaohe_feng has joined #openstack-nova | 02:46 | |
| *** fragatin_ has quit IRC | 02:46 | |
| *** gongysh_ has joined #openstack-nova | 02:48 | |
| *** code-R has joined #openstack-nova | 02:48 | |
| openstackgerrit | Michael Still proposed openstack/nova: Documentation for the vendordata reboot. https://review.openstack.org/353793 | 02:50 |
| *** yamahata has quit IRC | 02:54 | |
| *** ijw has quit IRC | 02:54 | |
| *** shaohe_feng has quit IRC | 02:56 | |
| *** shaohe_feng has joined #openstack-nova | 02:56 | |
| *** sudipto has joined #openstack-nova | 02:57 | |
| *** sudipto_ has joined #openstack-nova | 02:57 | |
| *** gongysh_ has quit IRC | 02:57 | |
| *** baoli has joined #openstack-nova | 03:01 | |
| *** code-R has quit IRC | 03:01 | |
| *** krtaylor has joined #openstack-nova | 03:02 | |
| *** yamahata has joined #openstack-nova | 03:03 | |
| *** thorst_ has joined #openstack-nova | 03:03 | |
| *** shaohe_feng has quit IRC | 03:06 | |
| *** shaohe_feng has joined #openstack-nova | 03:07 | |
| *** dimtruck is now known as zz_dimtruck | 03:07 | |
| *** raunak has joined #openstack-nova | 03:08 | |
| *** thorst_ has quit IRC | 03:11 | |
| *** shaohe_feng has quit IRC | 03:16 | |
| *** shaohe_feng has joined #openstack-nova | 03:16 | |
| *** raunak has quit IRC | 03:20 | |
| *** daidv has joined #openstack-nova | 03:20 | |
| *** raunak has joined #openstack-nova | 03:21 | |
| *** haplo37__ has joined #openstack-nova | 03:22 | |
| *** su_zhang has joined #openstack-nova | 03:24 | |
| *** vishwanathj has joined #openstack-nova | 03:25 | |
| *** baoli has quit IRC | 03:26 | |
| *** gongysh has quit IRC | 03:26 | |
| *** shaohe_feng has quit IRC | 03:26 | |
| *** shaohe_feng has joined #openstack-nova | 03:27 | |
| *** gongysh has joined #openstack-nova | 03:28 | |
| *** tiendc has quit IRC | 03:31 | |
| *** diogogmt has quit IRC | 03:34 | |
| *** shaohe_feng has quit IRC | 03:37 | |
| *** shaohe_feng has joined #openstack-nova | 03:37 | |
| *** tiendc has joined #openstack-nova | 03:37 | |
| *** yamahata has quit IRC | 03:43 | |
| *** daidv has quit IRC | 03:45 | |
| *** shaohe_feng has quit IRC | 03:47 | |
| *** shaohe_feng has joined #openstack-nova | 03:48 | |
| openstackgerrit | Maciej Szankin proposed openstack/nova: Fix check_config_option_in_central_place https://review.openstack.org/355597 | 03:48 |
| *** tbachman has quit IRC | 03:49 | |
| *** gongysh has quit IRC | 03:52 | |
| *** vishwanathj has quit IRC | 03:54 | |
| hieulq | mikal: can you take a look at this patch-set https://review.openstack.org/#/c/316539/ ? | 03:55 |
| *** cfriesen has quit IRC | 03:56 | |
| *** gongysh has joined #openstack-nova | 03:56 | |
| *** hshiina has joined #openstack-nova | 03:56 | |
| *** cfriesen has joined #openstack-nova | 03:56 | |
| *** code-R has joined #openstack-nova | 03:56 | |
| *** shaohe_feng has quit IRC | 03:57 | |
| *** shaohe_feng has joined #openstack-nova | 03:58 | |
| *** code-R_ has joined #openstack-nova | 03:59 | |
| *** GB21 has joined #openstack-nova | 04:01 | |
| *** code-R has quit IRC | 04:03 | |
| *** shaohe_feng has quit IRC | 04:07 | |
| *** sudipto_ has quit IRC | 04:08 | |
| *** sudipto has quit IRC | 04:08 | |
| *** shaohe_feng has joined #openstack-nova | 04:08 | |
| *** gongysh has quit IRC | 04:09 | |
| *** thorst_ has joined #openstack-nova | 04:10 | |
| *** code-R_ has quit IRC | 04:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:12 | |
| *** code-R has joined #openstack-nova | 04:12 | |
| *** daidv has joined #openstack-nova | 04:14 | |
| *** GB21 has quit IRC | 04:17 | |
| *** vishwanathj has joined #openstack-nova | 04:17 | |
| *** thorst_ has quit IRC | 04:17 | |
| *** shaohe_feng has quit IRC | 04:18 | |
| *** shaohe_feng has joined #openstack-nova | 04:18 | |
| *** links has joined #openstack-nova | 04:20 | |
| *** raunak has quit IRC | 04:22 | |
| *** code-R has quit IRC | 04:22 | |
| *** gongysh has joined #openstack-nova | 04:23 | |
| *** raunak has joined #openstack-nova | 04:24 | |
| *** fragatina has joined #openstack-nova | 04:24 | |
| *** bkopilov has joined #openstack-nova | 04:25 | |
| *** bkopilov is now known as bkopilov_wfh | 04:25 | |
| *** tbachman has joined #openstack-nova | 04:25 | |
| *** tonytan4ever has quit IRC | 04:27 | |
| *** shaohe_feng has quit IRC | 04:28 | |
| *** fragatina has quit IRC | 04:29 | |
| *** chandankumar has joined #openstack-nova | 04:30 | |
| *** shaohe_feng has joined #openstack-nova | 04:30 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix 'No data to report' error https://review.openstack.org/355716 | 04:34 |
| *** Dinesh_Bhor has quit IRC | 04:35 | |
| *** shaohe_feng has quit IRC | 04:38 | |
| *** shaohe_feng has joined #openstack-nova | 04:38 | |
| *** hieulq has quit IRC | 04:39 | |
| *** irenab has quit IRC | 04:42 | |
| *** marst has quit IRC | 04:42 | |
| *** Sukhdev has joined #openstack-nova | 04:43 | |
| *** sudipto has joined #openstack-nova | 04:43 | |
| *** sudipto_ has joined #openstack-nova | 04:43 | |
| *** pbandark has joined #openstack-nova | 04:44 | |
| *** hieulq has joined #openstack-nova | 04:45 | |
| *** shaohe_feng has quit IRC | 04:48 | |
| *** moshele has joined #openstack-nova | 04:49 | |
| *** shaohe_feng has joined #openstack-nova | 04:49 | |
| *** mdrabe has quit IRC | 04:54 | |
| *** shaohe_feng has quit IRC | 04:59 | |
| *** marst has joined #openstack-nova | 04:59 | |
| *** shaohe_feng has joined #openstack-nova | 04:59 | |
| *** tonytan4ever has joined #openstack-nova | 05:03 | |
| *** GB21 has joined #openstack-nova | 05:03 | |
| *** raunak has quit IRC | 05:05 | |
| *** raunak has joined #openstack-nova | 05:06 | |
| *** shaohe_feng has quit IRC | 05:09 | |
| *** takedakn has joined #openstack-nova | 05:09 | |
| *** shaohe_feng has joined #openstack-nova | 05:10 | |
| *** rama_y has quit IRC | 05:10 | |
| *** rama_y has joined #openstack-nova | 05:10 | |
| *** irenab has joined #openstack-nova | 05:11 | |
| *** code-R has joined #openstack-nova | 05:15 | |
| *** ecelik has joined #openstack-nova | 05:15 | |
| *** thorst_ has joined #openstack-nova | 05:15 | |
| *** su_zhang has quit IRC | 05:16 | |
| *** shaohe_feng has quit IRC | 05:19 | |
| *** shaohe_feng has joined #openstack-nova | 05:20 | |
| *** raunak has quit IRC | 05:20 | |
| *** ekuris has joined #openstack-nova | 05:21 | |
| *** raunak has joined #openstack-nova | 05:21 | |
| *** thorst_ has quit IRC | 05:22 | |
| *** houming has quit IRC | 05:24 | |
| *** tiendc has quit IRC | 05:25 | |
| *** lpetrut has joined #openstack-nova | 05:26 | |
| *** Sukhdev has quit IRC | 05:26 | |
| *** shaohe_feng has quit IRC | 05:29 | |
| *** jaosorior has joined #openstack-nova | 05:30 | |
| *** Wenzhi has quit IRC | 05:30 | |
| *** shaohe_feng has joined #openstack-nova | 05:30 | |
| *** Wenzhi_ has joined #openstack-nova | 05:31 | |
| *** Wenzhi_ has quit IRC | 05:32 | |
| *** prateek has joined #openstack-nova | 05:33 | |
| *** raunak has quit IRC | 05:35 | |
| *** baoli has joined #openstack-nova | 05:38 | |
| *** code-R has quit IRC | 05:39 | |
| *** shaohe_feng has quit IRC | 05:40 | |
| *** fragatina has joined #openstack-nova | 05:40 | |
| *** shaohe_feng has joined #openstack-nova | 05:40 | |
| *** haplo37__ has quit IRC | 05:41 | |
| *** baoli has quit IRC | 05:42 | |
| *** raunak has joined #openstack-nova | 05:43 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:43 | |
| *** fragatina has quit IRC | 05:45 | |
| *** sridharg has joined #openstack-nova | 05:46 | |
| *** rama_y has quit IRC | 05:46 | |
| *** tonytan4ever has quit IRC | 05:46 | |
| *** shaohe_feng has quit IRC | 05:50 | |
| *** raunak has quit IRC | 05:50 | |
| *** shaohe_feng has joined #openstack-nova | 05:51 | |
| *** tiendc has joined #openstack-nova | 05:51 | |
| *** tonytan4ever has joined #openstack-nova | 05:54 | |
| *** raunak has joined #openstack-nova | 05:55 | |
| *** oanson has joined #openstack-nova | 05:58 | |
| *** markvoelker has quit IRC | 05:58 | |
| *** shaohe_feng has quit IRC | 06:00 | |
| *** shaohe_feng has joined #openstack-nova | 06:01 | |
| *** tonytan4ever has quit IRC | 06:04 | |
| *** paul-carlton2 has joined #openstack-nova | 06:07 | |
| *** raunak has quit IRC | 06:09 | |
| *** shaohe_feng has quit IRC | 06:10 | |
| *** shaohe_feng has joined #openstack-nova | 06:11 | |
| *** rcernin has joined #openstack-nova | 06:14 | |
| *** Hosam_ has joined #openstack-nova | 06:16 | |
| *** mitchel_jhonson has joined #openstack-nova | 06:16 | |
| *** raunak has joined #openstack-nova | 06:17 | |
| mitchel_jhonson | hi all, can I backport a patch which has object version bump? | 06:17 |
| *** wangqun_ has joined #openstack-nova | 06:18 | |
| mitchel_jhonson | suppose I have changed a version from 1.6 to 1.7 in objects/request_specs then can I backport it to stable/mitaka branch? | 06:18 |
| *** rama_y has joined #openstack-nova | 06:19 | |
| *** thorst_ has joined #openstack-nova | 06:20 | |
| *** shaohe_feng has quit IRC | 06:21 | |
| *** wangqun has quit IRC | 06:21 | |
| *** raunak has quit IRC | 06:21 | |
| *** shaohe_feng has joined #openstack-nova | 06:22 | |
| *** diga_ has joined #openstack-nova | 06:22 | |
| *** gongysh has quit IRC | 06:22 | |
| *** raunak has joined #openstack-nova | 06:25 | |
| *** tbachman has quit IRC | 06:25 | |
| *** gongysh has joined #openstack-nova | 06:25 | |
| *** xinliang has quit IRC | 06:26 | |
| *** thorst_ has quit IRC | 06:27 | |
| *** maestropandy has joined #openstack-nova | 06:28 | |
| *** lpetrut has quit IRC | 06:29 | |
| *** Jeffrey4l has joined #openstack-nova | 06:30 | |
| *** unicell has joined #openstack-nova | 06:30 | |
| *** liusheng has quit IRC | 06:30 | |
| *** shaohe_feng has quit IRC | 06:31 | |
| *** liusheng has joined #openstack-nova | 06:31 | |
| *** shaohe_feng has joined #openstack-nova | 06:32 | |
| *** maestropandy has quit IRC | 06:32 | |
| *** maestropandy has joined #openstack-nova | 06:32 | |
| *** zhangjn has quit IRC | 06:33 | |
| *** ljxiash has joined #openstack-nova | 06:33 | |
| *** raunak has quit IRC | 06:35 | |
| *** zhangjn has joined #openstack-nova | 06:36 | |
| *** ljxiash has quit IRC | 06:37 | |
| *** EinstCra_ has quit IRC | 06:38 | |
| *** bkopilov_wfh is now known as bkopilov | 06:39 | |
| *** shaohe_feng has quit IRC | 06:41 | |
| *** EinstCrazy has joined #openstack-nova | 06:42 | |
| *** shaohe_feng has joined #openstack-nova | 06:42 | |
| *** xinliang has joined #openstack-nova | 06:43 | |
| openstackgerrit | Dinesh Bhor proposed openstack/nova: Remove code duplication in enums https://review.openstack.org/355745 | 06:44 |
| *** raunak has joined #openstack-nova | 06:47 | |
| *** ihrachys has joined #openstack-nova | 06:47 | |
| *** ljxiash has joined #openstack-nova | 06:49 | |
| *** raunak has quit IRC | 06:50 | |
| *** markvoelker has joined #openstack-nova | 06:51 | |
| *** shaohe_feng has quit IRC | 06:51 | |
| *** shaohe_feng has joined #openstack-nova | 06:52 | |
| *** takedakn has quit IRC | 06:52 | |
| *** yamahata has joined #openstack-nova | 06:53 | |
| *** liverpooler has joined #openstack-nova | 06:53 | |
| *** jojden has joined #openstack-nova | 06:56 | |
| jojden | question regarding the evacuate | 06:56 |
| jojden | Is there any chance to get the status of the evacuate. | 06:56 |
| jojden | Like evacuation is complete or in progress like that | 06:57 |
| jojden | ? | 06:57 |
| *** lpetrut has joined #openstack-nova | 06:57 | |
| *** ljxiash has quit IRC | 07:00 | |
| *** shaohe_feng has quit IRC | 07:02 | |
| *** ljxiash has joined #openstack-nova | 07:02 | |
| *** yamahata has quit IRC | 07:02 | |
| _gryf | jojden, afaik no. It is just rebuilding process, so the only change you'll see is the moment of rebuilding, which will become either active or error | 07:02 |
| *** shaohe_feng has joined #openstack-nova | 07:03 | |
| jojden | oh | 07:03 |
| jojden | but if we set the password then after the completion it will return the admin password | 07:03 |
| jojden | so we can say it is completed right ? | 07:04 |
| jojden | _gryf | 07:04 |
| _gryf | jojden, ttaa | 07:04 |
| _gryf | sorry | 07:04 |
| _gryf | jojden, you can check the destination host | 07:04 |
| *** maestropandy1 has joined #openstack-nova | 07:05 | |
| *** ljxiash has quit IRC | 07:05 | |
| *** ljxiash has joined #openstack-nova | 07:05 | |
| *** mingyu has joined #openstack-nova | 07:05 | |
| *** maestropandy has quit IRC | 07:05 | |
| jojden | check the destination host to verify that it contains the vms right ? | 07:05 |
| _gryf | actually | 07:05 |
| _gryf | you can either select destination host | 07:05 |
| jojden | yes | 07:06 |
| _gryf | or rely on the scheduler | 07:06 |
| jojden | ok | 07:06 |
| jojden | We are selecting the destination host | 07:06 |
| jojden | it is on shared storage | 07:07 |
| _gryf | either way destination host should differ from the (possibly down) source host | 07:07 |
| _gryf | oh | 07:07 |
| _gryf | so you gave to be sure that source host is down | 07:07 |
| _gryf | s/gave/have | 07:07 |
| jojden | yes | 07:07 |
| jojden | so how we can say that evacuation is done with success/fail | 07:08 |
| *** lpetrut has quit IRC | 07:08 | |
| jojden | means we have to check the destination is having the instances with same ID, name etc | 07:08 |
| jojden | right ? | 07:08 |
| jojden | _gryf | 07:09 |
| *** houming has joined #openstack-nova | 07:09 | |
| *** rstarmer_ has quit IRC | 07:09 | |
| _gryf | I think so | 07:09 |
| jojden | ok | 07:09 |
| jojden | thanks _gryf | 07:10 |
| *** shaohe_feng has quit IRC | 07:12 | |
| *** shaohe_feng has joined #openstack-nova | 07:12 | |
| *** maestropandy1 has quit IRC | 07:17 | |
| *** maestropandy has joined #openstack-nova | 07:17 | |
| *** nicolasbock has quit IRC | 07:18 | |
| *** nicolasbock has joined #openstack-nova | 07:19 | |
| *** tonytan4ever has joined #openstack-nova | 07:22 | |
| *** shaohe_feng has quit IRC | 07:22 | |
| *** maestropandy has left #openstack-nova | 07:22 | |
| *** shaohe_feng has joined #openstack-nova | 07:23 | |
| openstackgerrit | LisaLi proposed openstack/nova: Use os-brick encryptors https://review.openstack.org/326788 | 07:23 |
| *** sahid has joined #openstack-nova | 07:24 | |
| *** jichen has joined #openstack-nova | 07:26 | |
| *** tonytan4ever has quit IRC | 07:26 | |
| *** thorst_ has joined #openstack-nova | 07:28 | |
| *** markus_z has joined #openstack-nova | 07:28 | |
| *** GB21 has quit IRC | 07:28 | |
| *** raunak has joined #openstack-nova | 07:30 | |
| *** ljxiash has quit IRC | 07:31 | |
| *** nicolasbock has quit IRC | 07:31 | |
| *** nicolasbock has joined #openstack-nova | 07:32 | |
| markus_z | FYI: nova-bugs-team meeting in 30 min in #openstack-meeting-4 https://wiki.openstack.org/wiki/Meetings/Nova/BugsTeam | 07:32 |
| *** shaohe_feng has quit IRC | 07:32 | |
| *** thorst_ has quit IRC | 07:32 | |
| *** shaohe_feng has joined #openstack-nova | 07:33 | |
| prateek | oomichi, can you please take a look, i have addressed your review comments | 07:34 |
| *** liverpooler has quit IRC | 07:35 | |
| frickler | markus_z: I won't have time for the meeting, but maybe someone can look at https://bugs.launchpad.net/nova/+bug/1608934 which is a regression, currently it is not clear to me whether it was introduced into mitaka only recently or whether it has been lurking for over a year | 07:36 |
| openstack | Launchpad bug 1608934 in OpenStack Compute (nova) "ephemeral disk creation fails for local storage with image type raw/lvm" [Undecided,In progress] - Assigned to Dr. Jens Rosenboom (j-rosenboom-j) | 07:36 |
| *** ljxiash has joined #openstack-nova | 07:36 | |
| *** liverpooler has joined #openstack-nova | 07:37 | |
| markus_z | frickler: OK, I'll check that one. | 07:37 |
| *** raunak has quit IRC | 07:37 | |
| *** ljxiash_ has joined #openstack-nova | 07:38 | |
| *** daidv has quit IRC | 07:38 | |
| *** daidv has joined #openstack-nova | 07:38 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Eliminate additional DB queries in nova lists https://review.openstack.org/355558 | 07:38 |
| *** bauzas_off is now known as bauzas | 07:38 | |
| bauzas | good morning Nova | 07:38 |
| *** fragatina has joined #openstack-nova | 07:41 | |
| *** ljxiash has quit IRC | 07:41 | |
| *** shaohe_feng has quit IRC | 07:43 | |
| *** rama_y has quit IRC | 07:44 | |
| *** gongysh has quit IRC | 07:45 | |
| *** raunak has joined #openstack-nova | 07:45 | |
| *** belmoreira has joined #openstack-nova | 07:46 | |
| *** fragatina has quit IRC | 07:46 | |
| moshele | johnthetubaguy: hi can you review some pci patches https://review.openstack.org/#/c/349060/ and https://review.openstack.org/#/c/347444/ | 07:46 |
| *** shaohe_feng has joined #openstack-nova | 07:48 | |
| *** RuiChen has joined #openstack-nova | 07:48 | |
| markus_z | moshele: You're leading the sriov subteam, right? I wanted to ask if you could check out some bug reports in that area. | 07:48 |
| *** prateek has quit IRC | 07:48 | |
| *** prateek_ has joined #openstack-nova | 07:48 | |
| *** baoli has joined #openstack-nova | 07:50 | |
| moshele | markus_z: yes, what bug? | 07:50 |
| markus_z | moshele: for example https://bugs.launchpad.net/nova/+bug/1572826 | 07:50 |
| openstack | Launchpad bug 1572826 in OpenStack Compute (nova) "dev name in the pci whitelist is not honored for SRIOV" [Undecided,New] | 07:50 |
| *** GB21 has joined #openstack-nova | 07:50 | |
| markus_z | https://bugs.launchpad.net/nova/+bug/1582822 | 07:51 |
| openstack | Launchpad bug 1582822 in OpenStack Compute (nova) "PCI-PT : SRIOV enabled interface dev_name in pci whitelist does not give the product_id of PF for the direct-physical_network , it always take the VF's product_id" [Undecided,New] - Assigned to Chen Fan (fan-chen) | 07:51 |
| markus_z | https://bugs.launchpad.net/nova/+bug/1606747 | 07:51 |
| openstack | Launchpad bug 1606747 in OpenStack Compute (nova) "[sriov] nova does't regard second nic after booting" [Undecided,New] - Assigned to xhzhf (guoyongxhzhf) | 07:51 |
| *** gongysh has joined #openstack-nova | 07:51 | |
| *** gongysh has quit IRC | 07:51 | |
| markus_z | moshele: These are the 3 I currently know about. | 07:51 |
| *** raunak has quit IRC | 07:52 | |
| *** code-R has joined #openstack-nova | 07:52 | |
| *** shaohe_feng has quit IRC | 07:53 | |
| moshele | markus_z: sure, I will add the to the agenda, thanks | 07:53 |
| markus_z | moshele: Cool, thanks a lot! | 07:53 |
| *** shaohe_feng has joined #openstack-nova | 07:54 | |
| *** baoli has quit IRC | 07:54 | |
| *** Hosam has joined #openstack-nova | 07:54 | |
| *** code-R has quit IRC | 07:57 | |
| *** Hosam_ has quit IRC | 07:57 | |
| *** josecastroleon has joined #openstack-nova | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-nova | 08:00 | |
| *** pilgrimstack has joined #openstack-nova | 08:01 | |
| *** markvoelker has quit IRC | 08:01 | |
| *** shaohe_feng has quit IRC | 08:03 | |
| *** shaohe_feng has joined #openstack-nova | 08:04 | |
| *** paul-carlton2 has quit IRC | 08:04 | |
| *** pilgrimstack has quit IRC | 08:05 | |
| *** raunak has joined #openstack-nova | 08:06 | |
| *** pilgrimstack has joined #openstack-nova | 08:07 | |
| *** roeyc has joined #openstack-nova | 08:07 | |
| *** pkoniszewski_ has joined #openstack-nova | 08:08 | |
| *** danpb has joined #openstack-nova | 08:09 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c https://review.openstack.org/303345 | 08:10 |
| *** raunak has quit IRC | 08:11 | |
| *** shaohe_feng has quit IRC | 08:13 | |
| *** shaohe_feng has joined #openstack-nova | 08:14 | |
| *** matrohon has joined #openstack-nova | 08:19 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Change default value of live_migration_tunnelled to False https://review.openstack.org/350480 | 08:19 |
| *** lucas-dinner is now known as lucasagomes | 08:21 | |
| *** tonytan4ever has joined #openstack-nova | 08:23 | |
| *** shaohe_feng has quit IRC | 08:24 | |
| *** paul-carlton2 has joined #openstack-nova | 08:24 | |
| *** shaohe_feng has joined #openstack-nova | 08:24 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Add create cell command https://review.openstack.org/332713 | 08:26 |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Trivial: add ability to define action description https://review.openstack.org/355781 | 08:26 |
| *** wangqun_ has quit IRC | 08:27 | |
| *** tonytan4ever has quit IRC | 08:28 | |
| openstackgerrit | John Hua proposed openstack/nova: Use physical utilisation for cached images https://review.openstack.org/353862 | 08:29 |
| *** mvk has quit IRC | 08:29 | |
| *** thorst_ has joined #openstack-nova | 08:30 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag https://review.openstack.org/334860 | 08:31 |
| *** shaohe_feng has quit IRC | 08:34 | |
| *** shaohe_feng has joined #openstack-nova | 08:35 | |
| *** dikonoor has joined #openstack-nova | 08:35 | |
| *** maestropandy has joined #openstack-nova | 08:35 | |
| *** maestropandy1 has joined #openstack-nova | 08:36 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova: Do not reserve device before reserving the volume https://review.openstack.org/290793 | 08:36 |
| *** thorst_ has quit IRC | 08:37 | |
| *** cdent has joined #openstack-nova | 08:39 | |
| *** maestropandy has quit IRC | 08:40 | |
| *** zenoway has joined #openstack-nova | 08:41 | |
| mitchel_jhonson | hi all, can I backport a patch which has object version bump? | 08:41 |
| mitchel_jhonson | suppose in nova I have changed a version from 1.6 to 1.7 in objects/request_specs then can I backport it to stable/mitaka branch? | 08:41 |
| *** takashin has left #openstack-nova | 08:42 | |
| *** tiendc has quit IRC | 08:44 | |
| *** shaohe_feng has quit IRC | 08:44 | |
| *** hshiina has quit IRC | 08:45 | |
| *** shaohe_feng has joined #openstack-nova | 08:45 | |
| *** Hosam_ has joined #openstack-nova | 08:48 | |
| *** maestropandy1 has left #openstack-nova | 08:49 | |
| openstackgerrit | Chen Fan proposed openstack/nova: log: delay the variables interpolation in logging code https://review.openstack.org/355789 | 08:49 |
| *** Hosam has quit IRC | 08:52 | |
| *** cristicalin has joined #openstack-nova | 08:53 | |
| *** PaulMurray has joined #openstack-nova | 08:54 | |
| *** shaohe_feng has quit IRC | 08:54 | |
| *** daidv has quit IRC | 08:55 | |
| *** shaohe_feng has joined #openstack-nova | 08:55 | |
| *** mvk has joined #openstack-nova | 08:55 | |
| *** takashin has joined #openstack-nova | 08:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/354459 | 08:58 |
| *** efoley has joined #openstack-nova | 09:01 | |
| *** markvoelker has joined #openstack-nova | 09:02 | |
| *** derekh has joined #openstack-nova | 09:03 | |
| *** shaohe_feng has quit IRC | 09:05 | |
| *** shaohe_feng has joined #openstack-nova | 09:05 | |
| *** cristicalin has quit IRC | 09:06 | |
| openstackgerrit | hejiawei proposed openstack/nova: a patch to force detach volume https://review.openstack.org/355799 | 09:07 |
| *** markvoelker has quit IRC | 09:07 | |
| openstackgerrit | Evgeny Antyshev proposed openstack/nova: WIP Image format naming conversion from qemu to libvirt https://review.openstack.org/355800 | 09:07 |
| *** tiendc has joined #openstack-nova | 09:11 | |
| jamespd | anyone able to give me a clue about getting the following after a Kilo -> Liberty upgrade? "Unknown column 'compute_nodes.ram_allocation_ratio' in 'field list'" | 09:12 |
| *** ljxiash_ has quit IRC | 09:12 | |
| *** shaohe_feng has quit IRC | 09:15 | |
| *** shaohe_feng has joined #openstack-nova | 09:15 | |
| openstackgerrit | Pavel Gluschak proposed openstack/nova: Make live migration possible with libvirt vz driver https://review.openstack.org/355805 | 09:16 |
| PaulMurray | johnthetubaguy, do you need anything for neutron in lm meet today ? | 09:17 |
| *** GB21 has quit IRC | 09:18 | |
| bauzas | jamespd: did you run the db sync ? | 09:19 |
| johnthetubaguy | PaulMurray: good question, I have started a write up, it would be nice to get more eyes on that: https://review.openstack.org/#/c/353982/ | 09:20 |
| johnthetubaguy | PaulMurray: I will probably try refresh/improve the live-migrate section in a little bit | 09:20 |
| *** xavpaice has joined #openstack-nova | 09:20 | |
| jamespd | bauzas: yeah, now we are getting a bunch of "Cannot call obj_load_attr on orphaned Instance object" | 09:20 |
| PaulMurray | johnthetubaguy, I'll put a mention on the agenda | 09:21 |
| *** Hosam has joined #openstack-nova | 09:21 | |
| johnthetubaguy | PaulMurray: great stuff, thanks | 09:21 |
| openstackgerrit | John Garbutt proposed openstack/nova: Improve help text for service options. https://review.openstack.org/332861 | 09:21 |
| PaulMurray | I see no the mid cycle page you are going on wednesday? | 09:21 |
| openstackgerrit | Raghuveer Shenoy proposed openstack/nova-specs: Support SR-IOV and PCI statistics through Nova API https://review.openstack.org/342001 | 09:23 |
| markus_z | frickler: I've put it as an agenda item on the nova meeting (see "open discussion"). https://wiki.openstack.org/wiki/Meetings/Nova | 09:23 |
| johnthetubaguy | PaulMurray: I should be there wed 10am (ish) through to the end of friday | 09:24 |
| markus_z | frickler: I couldn't figure out the exact change(s) but left a suspicious one as comment in the bug report you gave me. | 09:24 |
| *** Hosam_ has quit IRC | 09:25 | |
| PaulMurray | johnthetubaguy, I doubt you'll need anything from me but let me know if I can be of help | 09:25 |
| johnthetubaguy | PaulMurray: armax was hoping to pencil in some Nova stuff on Thursday morning | 09:25 |
| openstackgerrit | Pavel Gluschak proposed openstack/nova: openvz: make live migration possible with libvirt driver https://review.openstack.org/355805 | 09:25 |
| johnthetubaguy | PaulMurray: appreciate it, more eyes on that patch is probably the best thing | 09:25 |
| PaulMurray | np | 09:25 |
| *** shaohe_feng has quit IRC | 09:25 | |
| *** rstarmer_ has joined #openstack-nova | 09:26 | |
| johnthetubaguy | PaulMurray: I am thinking a join nova, cinder and neutron session at the summit is going to be the best way forward with these new live-migrate flows, discuss a concrete plan there, ideally with POCs already completed | 09:26 |
| johnthetubaguy | s/join/joint/ | 09:26 |
| johnthetubaguy | possibly including keystone for the token issues we are all having | 09:26 |
| PaulMurray | sounds a lot for a single session | 09:27 |
| *** shaohe_feng has joined #openstack-nova | 09:28 | |
| PaulMurray | do you know how far the keystone part has got - I had the idea that its just implementation on our part left? | 09:28 |
| johnthetubaguy | PaulMurray: I haven't checked with keystone recently, this isn't the trusts thing, its something different (that is less crazy for deployers) | 09:29 |
| *** rstarmer_ has quit IRC | 09:29 | |
| johnthetubaguy | PaulMurray: we went through some of it at the last summit, in a cross project session, I think thats the last I followed up with that | 09:29 |
| PaulMurray | johnthetubaguy, I was thinking about token refresh | 09:30 |
| * PaulMurray has a meeting | 09:30 | |
| johnthetubaguy | PaulMurray: this was more token delegates, for want of a better word | 09:30 |
| *** thorst_ has joined #openstack-nova | 09:35 | |
| pkoniszewski_ | johnthetubaguy: hi, i just updated reno here (default value of live_migration_tunelled) - https://review.openstack.org/#/c/350480/ - please let me know whether it is enough, not sure if i should describe it with more details | 09:35 |
| *** shaohe_feng has quit IRC | 09:35 | |
| johnthetubaguy | pkoniszewski_: thank you, that looks good now | 09:36 |
| *** shaohe_feng has joined #openstack-nova | 09:36 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: WIP: live-migration test hook for serial console https://review.openstack.org/347471 | 09:36 |
| johnthetubaguy | pkoniszewski: I was worried about not telling users about the security impact, that covers it nicely | 09:36 |
| *** lpetrut has joined #openstack-nova | 09:37 | |
| pkoniszewski_ | johnthetubaguy: yeah, non-tunnelled might not mean non-secure | 09:39 |
| pkoniszewski_ | johnthetubaguy: thanks! | 09:39 |
| *** ociuhandu has joined #openstack-nova | 09:40 | |
| *** cheneydc has joined #openstack-nova | 09:41 | |
| *** thorst_ has quit IRC | 09:41 | |
| *** fragatina has joined #openstack-nova | 09:43 | |
| *** pkoniszewski_ has quit IRC | 09:44 | |
| *** shaohe_feng has quit IRC | 09:46 | |
| *** dmellado has quit IRC | 09:46 | |
| *** shaohe_feng has joined #openstack-nova | 09:46 | |
| *** fragatina has quit IRC | 09:48 | |
| *** cheneydc has quit IRC | 09:50 | |
| *** GB21 has joined #openstack-nova | 09:51 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova: Remove nova/api/validator.py https://review.openstack.org/355392 | 09:52 |
| *** code-R has joined #openstack-nova | 09:53 | |
| *** shaohe_feng has quit IRC | 09:56 | |
| *** dmellado has joined #openstack-nova | 09:56 | |
| *** shaohe_feng has joined #openstack-nova | 09:56 | |
| *** ihrachys has quit IRC | 09:58 | |
| *** code-R has quit IRC | 09:58 | |
| *** roeyc has quit IRC | 10:00 | |
| *** EinstCrazy has quit IRC | 10:01 | |
| *** markvoelker has joined #openstack-nova | 10:03 | |
| *** jed56 has joined #openstack-nova | 10:03 | |
| *** EinstCrazy has joined #openstack-nova | 10:04 | |
| *** shaohe_feng has quit IRC | 10:06 | |
| *** Hosam_ has joined #openstack-nova | 10:06 | |
| *** shaohe_feng has joined #openstack-nova | 10:07 | |
| *** markvoelker has quit IRC | 10:08 | |
| *** Hosam has quit IRC | 10:09 | |
| Dinesh_Bhor | johnthetubaguy: Hi, I have a question regarding backporting. Can I backport a patch which has object version bump ? | 10:14 |
| *** ihrachys has joined #openstack-nova | 10:14 | |
| *** shaohe_feng has quit IRC | 10:16 | |
| *** shaohe_feng has joined #openstack-nova | 10:17 | |
| *** hoangcx has quit IRC | 10:18 | |
| *** dikonoor has quit IRC | 10:20 | |
| *** lpetrut has quit IRC | 10:20 | |
| *** mingyu has quit IRC | 10:21 | |
| *** ecelik has quit IRC | 10:22 | |
| *** lpetrut has joined #openstack-nova | 10:22 | |
| *** mingyu has joined #openstack-nova | 10:22 | |
| *** ecelik has joined #openstack-nova | 10:22 | |
| *** sdague has joined #openstack-nova | 10:23 | |
| *** ihrachys has quit IRC | 10:23 | |
| *** Sravan has joined #openstack-nova | 10:24 | |
| *** tiendc has quit IRC | 10:24 | |
| *** tonytan4ever has joined #openstack-nova | 10:24 | |
| *** jdillaman has quit IRC | 10:24 | |
| *** mvk has quit IRC | 10:25 | |
| Sravan | @cdent : Need some help | 10:25 |
| cdent | hi Sravan what's up? | 10:25 |
| Sravan | I am new to micro versions and I gone through the document | 10:26 |
| Sravan | regarding gerrit change | 10:26 |
| Sravan | https://review.openstack.org/#/c/349952/2 | 10:26 |
| *** mvk has joined #openstack-nova | 10:26 | |
| Sravan | Need some suggestions, how to create micro versions and upload | 10:26 |
| *** shaohe_feng has quit IRC | 10:27 | |
| *** shaohe_feng has joined #openstack-nova | 10:28 | |
| Sravan | @cdent , If you have any sample change of micro versions.. That would be very helpful for me to understand | 10:28 |
| cdent | Sravan: the important part of that document that I pointed at is the section with the title 'Other necessary changes'. Let me find another change that updated the microversions, just a sec | 10:28 |
| *** tonytan4ever has quit IRC | 10:28 | |
| Sravan | ok | 10:29 |
| cdent | Sravan: here's a recent change that bumped the microversion: https://review.openstack.org/#/c/284868/ | 10:29 |
| *** ftersin_ has joined #openstack-nova | 10:30 | |
| Sravan | Thanks Chris.. I will go through with that change | 10:30 |
| Sravan | and let you know.. if I stuck at anywhere | 10:31 |
| Sravan | Thanks much for the help | 10:31 |
| cdent | you're welcome | 10:32 |
| *** ftersin_ is now known as ftersin | 10:32 | |
| *** jdillaman has joined #openstack-nova | 10:36 | |
| *** shaohe_feng has quit IRC | 10:37 | |
| johnthetubaguy | Dinesh_Bhor: I think the answer is no | 10:37 |
| johnthetubaguy | Dinesh_Bhor: although the real answer might well be "it depends" | 10:37 |
| *** shaohe_feng has joined #openstack-nova | 10:38 | |
| *** josecastroleon has quit IRC | 10:40 | |
| *** thorst_ has joined #openstack-nova | 10:41 | |
| *** smatzek has joined #openstack-nova | 10:42 | |
| *** dikonoor has joined #openstack-nova | 10:44 | |
| *** EinstCrazy has quit IRC | 10:44 | |
| *** roeyc has joined #openstack-nova | 10:45 | |
| *** EinstCrazy has joined #openstack-nova | 10:45 | |
| *** dikonoor has quit IRC | 10:47 | |
| *** thorst_ has quit IRC | 10:47 | |
| *** fragatina has joined #openstack-nova | 10:47 | |
| *** shaohe_feng has quit IRC | 10:47 | |
| *** dikonoor has joined #openstack-nova | 10:47 | |
| *** shaohe_feng has joined #openstack-nova | 10:48 | |
| *** phuongnh has quit IRC | 10:49 | |
| *** EinstCrazy has quit IRC | 10:50 | |
| *** dikonoor has quit IRC | 10:50 | |
| *** shaohe_feng has quit IRC | 10:57 | |
| *** shaohe_feng has joined #openstack-nova | 10:58 | |
| *** roeyc has quit IRC | 11:01 | |
| *** Hosam has joined #openstack-nova | 11:01 | |
| moshele | johnthetubaguy: hi can you review some pci patches https://review.openstack.org/#/c/349060/ and https://review.openstack.org/#/c/347444/ | 11:01 |
| *** dingboopt has joined #openstack-nova | 11:02 | |
| *** dmsimard is now known as dmsimard|afk | 11:03 | |
| *** mlavalle has joined #openstack-nova | 11:03 | |
| *** markvoelker has joined #openstack-nova | 11:04 | |
| *** Hosam_ has quit IRC | 11:04 | |
| *** mingyu has quit IRC | 11:05 | |
| *** mingyu has joined #openstack-nova | 11:06 | |
| *** roeyc has joined #openstack-nova | 11:06 | |
| *** shaohe_feng has quit IRC | 11:08 | |
| *** markvoelker has quit IRC | 11:08 | |
| *** shaohe_feng has joined #openstack-nova | 11:09 | |
| *** mingyu has quit IRC | 11:10 | |
| johnthetubaguy | moshele: I am trying to focus on the priority specs and things right now I am afraid, hopefully will get to those soon-ish though | 11:10 |
| moshele | johnthetubaguy: ok thanks | 11:12 |
| BlackDex | Hello there. Is there a way to prevent local storage from being used via both the Horizon Dashboard and the nova-api? | 11:13 |
| *** baoli has joined #openstack-nova | 11:14 | |
| johnthetubaguy | BlackDex: no, the code for that blueprint was not completed this cycle, let me find a link to it for you | 11:14 |
| johnthetubaguy | BlackDex: http://specs.openstack.org/openstack/nova-specs/specs/newton/approved/flavor-root-disk-none.html | 11:15 |
| johnthetubaguy | BlackDex: tracking info is here: https://blueprints.launchpad.net/nova/+spec/flavor-root-disk-none | 11:15 |
| * johnthetubaguy goes for some lunch | 11:16 | |
| BlackDex | thx | 11:16 |
| BlackDex | darn | 11:16 |
| BlackDex | we want to force volumes only | 11:16 |
| *** bvanhav has joined #openstack-nova | 11:17 | |
| *** shaohe_feng has quit IRC | 11:18 | |
| *** sudipto_ has quit IRC | 11:18 | |
| *** sudipto has quit IRC | 11:18 | |
| *** shaohe_feng has joined #openstack-nova | 11:19 | |
| *** baoli has quit IRC | 11:19 | |
| *** fragatin_ has joined #openstack-nova | 11:19 | |
| *** ociuhandu has quit IRC | 11:20 | |
| *** haplo37__ has joined #openstack-nova | 11:20 | |
| *** dikonoor has joined #openstack-nova | 11:23 | |
| *** fragatina has quit IRC | 11:23 | |
| *** Dinesh_Bhor has quit IRC | 11:23 | |
| *** GB21 has quit IRC | 11:24 | |
| BlackDex | no other way of forcing volumes only? | 11:25 |
| *** shaohe_feng has quit IRC | 11:28 | |
| *** josecastroleon has joined #openstack-nova | 11:28 | |
| *** shaohe_feng has joined #openstack-nova | 11:29 | |
| sdague | cdent: I think jaypipes needs gerrit lessons - https://review.openstack.org/#/c/352573/ - patches need both a +2 and +W to be prolog sufficient to move forward | 11:29 |
| *** GB21 has joined #openstack-nova | 11:29 | |
| sdague | :) | 11:29 |
| cdent | sdague: :) those three patches have been rather confused over the past few days | 11:30 |
| *** haplo37__ has quit IRC | 11:31 | |
| sdague | cdent: I'm a little surprised the update doesn't return a 200 with the updated resource in the body - https://review.openstack.org/#/c/329151/63/nova/api/openstack/placement/handlers/resource_provider.py | 11:33 |
| cdent | sdague there's some discussion about that on the spec, if I recall correctly. The gist being since you've already got the name and it is only the name that is in the representation (besides the links), and if you need the links it is quick GET, why bother with a body? | 11:34 |
| *** thorst_ has joined #openstack-nova | 11:35 | |
| *** jaosorior has quit IRC | 11:35 | |
| sdague | ok, well because I was reading on the Location header the other day, it's not really clear that it's supposed to be used with 204 - https://tools.ietf.org/html/rfc7231#section-7.1.2 | 11:35 |
| *** jaosorior has joined #openstack-nova | 11:36 | |
| *** sdake has joined #openstack-nova | 11:36 | |
| *** GB21 has quit IRC | 11:37 | |
| cdent | 204 is not mentioned, but my read is that those response codes that are mentioned are there to explain special cases, and the meaning of the header remains the same across different response codes: to refer to a | 11:38 |
| cdent | specific resource in relation to the response | 11:38 |
| *** shaohe_feng has quit IRC | 11:38 | |
| *** shaohe_feng has joined #openstack-nova | 11:39 | |
| cdent | sdague: If we were being hard core hateoas then an empty response is bad, but given how uptight people get about how many bytes get sent over the wire, despite it being tiny... | 11:41 |
| *** rfolco has joined #openstack-nova | 11:41 | |
| sdague | well, the empty response sits weird with me | 11:41 |
| sdague | for the update cases | 11:41 |
| *** sfinucan has quit IRC | 11:41 | |
| sdague | I thought the big concern was header bloat | 11:42 |
| sdague | because of quirks of http caching appliances | 11:42 |
| cdent | people seem to have lots of concerns | 11:42 |
| cdent | (to clarify: about performance when it doesn't seem warranted) | 11:44 |
| *** sfinucan has joined #openstack-nova | 11:44 | |
| cdent | I've linked to your comments here and my response on the review, I'll give it a few hours to see if there's any other comments | 11:44 |
| sdague | cdent: ok, sure | 11:45 |
| cdent | it's easy to change if it goes that way | 11:45 |
| sdague | yeh, lets at least wait for jaypipes to tell me I'm wrong :) | 11:45 |
| openstackgerrit | sravan proposed openstack/nova: Add tenant_name when list nova usage https://review.openstack.org/349952 | 11:46 |
| cdent | I suspect jay won't care in this case. And I already think you're wrong, but don't feel strongly enough to quibble ;) | 11:48 |
| *** shaohe_feng has quit IRC | 11:49 | |
| *** shaohe_feng has joined #openstack-nova | 11:49 | |
| *** Sravan has quit IRC | 11:50 | |
| *** rodrigods has quit IRC | 11:51 | |
| *** rodrigods has joined #openstack-nova | 11:51 | |
| *** Dinesh_Bhor has joined #openstack-nova | 11:53 | |
| *** baoli has joined #openstack-nova | 11:53 | |
| *** baoli_ has joined #openstack-nova | 11:54 | |
| *** tonytan4ever has joined #openstack-nova | 11:55 | |
| Dinesh_Bhor | johnthetubaguy: Thanks, suppose on master I have changed object version from 1.7 to 1.8 and in stable/mitaka the object has version 1.5 then can I backport my patch to stable/mitaka? | 11:57 |
| *** acabot has quit IRC | 11:57 | |
| *** baoli has quit IRC | 11:58 | |
| *** mlavalle has quit IRC | 11:58 | |
| *** jaypipes has joined #openstack-nova | 11:59 | |
| *** shaohe_feng has quit IRC | 11:59 | |
| *** tonytan4ever has quit IRC | 11:59 | |
| *** shaohe_feng has joined #openstack-nova | 12:00 | |
| *** markvoelker has joined #openstack-nova | 12:05 | |
| *** tiendc has joined #openstack-nova | 12:06 | |
| *** lucasagomes is now known as lucas-hungry | 12:06 | |
| *** tiendc has quit IRC | 12:06 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: [WIP] get instance diagnostic https://review.openstack.org/355540 | 12:06 |
| *** mriedem_away has quit IRC | 12:07 | |
| *** mlavalle has joined #openstack-nova | 12:07 | |
| *** Dinesh_Bhor has quit IRC | 12:07 | |
| johnthetubaguy | Dinesh_Bhor: I don't think thats possible to backport, can you link to the patch you are trying to backport? | 12:08 |
| *** ptm_away has joined #openstack-nova | 12:08 | |
| ftersin | Does anyone know who do i ask about numerous floating random faults of XenProject CI? | 12:08 |
| BobBall | ftersin: That would be anthonyper | 12:08 |
| *** PaulMurray has quit IRC | 12:08 | |
| ftersin | BobBall: thx | 12:09 |
| *** haplo37__ has joined #openstack-nova | 12:09 | |
| *** markvoelker has quit IRC | 12:09 | |
| *** shaohe_feng has quit IRC | 12:09 | |
| BobBall | ftersin: or email https://lists.xenproject.org/cgi-bin/mailman/listinfo/wg-openstack | 12:09 |
| *** moshele has quit IRC | 12:09 | |
| *** Dinesh_Bhor has joined #openstack-nova | 12:09 | |
| *** acabot has joined #openstack-nova | 12:10 | |
| *** shaohe_feng has joined #openstack-nova | 12:10 | |
| *** Hosam_ has joined #openstack-nova | 12:10 | |
| Dinesh_Bhor | johnthetubaguy: I am working on a fix on master which needs to be backported to stable mitaka and it includes object version bump on master so for confirmation I was asking. | 12:12 |
| *** haplo37__ has quit IRC | 12:13 | |
| johnthetubaguy | Dinesh_Bhor: it depends on the exact sort of change you are doing, in general its not possible | 12:14 |
| *** Hosam has quit IRC | 12:14 | |
| Dinesh_Bhor | johnthetubaguy: ok, thank you for your time and info. | 12:14 |
| *** su_zhang has joined #openstack-nova | 12:16 | |
| *** ducttape_ has joined #openstack-nova | 12:18 | |
| mdbooth | jaypipes: Thanks for making it so far through that series. I've got a few things to clear up. On the mock thing, though, mock 2 was released on 6th April this year and adds a bunch of stuff which I assume was previously only in python 3's mock. | 12:18 |
| mdbooth | So, assert_called_once() and assert_not_called() are both things now, but they weren't before. | 12:18 |
| mdbooth | Even better, though, assert_foo() will raise an attributeerror even on a MagicMock() unless you tell it not to | 12:19 |
| *** shaohe_feng has quit IRC | 12:19 | |
| mdbooth | By default, it no longer automatically mocks methods which start with assert_ | 12:20 |
| mdbooth | So typos in assertions now raise errors, unless you also typo 'assert_' | 12:20 |
| *** shaohe_feng has joined #openstack-nova | 12:20 | |
| *** prateek_ has quit IRC | 12:22 | |
| *** zenoway has quit IRC | 12:24 | |
| *** Hosam has joined #openstack-nova | 12:24 | |
| *** diga__ has joined #openstack-nova | 12:24 | |
| *** diga_ has quit IRC | 12:25 | |
| *** markvoelker has joined #openstack-nova | 12:26 | |
| *** pradk has joined #openstack-nova | 12:26 | |
| *** Hosam_ has quit IRC | 12:27 | |
| *** burgerk has joined #openstack-nova | 12:27 | |
| *** diga has quit IRC | 12:27 | |
| *** mdrabe has joined #openstack-nova | 12:29 | |
| *** takashin has left #openstack-nova | 12:30 | |
| *** shaohe_feng has quit IRC | 12:30 | |
| *** vladikr has joined #openstack-nova | 12:30 | |
| *** shaohe_feng has joined #openstack-nova | 12:30 | |
| *** gouthamr has joined #openstack-nova | 12:32 | |
| jroll | anyone have a good way to play with a metadata service, prior to doing all the network fancy to direct 169.254.169.254 traffic to the control plane? short of trying to spoof src IP? :) | 12:33 |
| johnthetubaguy | jroll: I think mikal just added a functional test for that | 12:35 |
| pilgrimstack | Question: is their a reason why starting an instance linked on a net without subnet is not possible but creating a port + attaching this port on the same network is possible? | 12:35 |
| johnthetubaguy | jroll: I think there are headers you can pass instead, basically, to claim the correct IP, with a given shared secret | 12:35 |
| *** ducttape_ has quit IRC | 12:35 | |
| pilgrimstack | ERROR: Network 3107fa9f-924e-4f00-8ed8-9976870e1598 requires a subnet in order to boot instances on. | 12:35 |
| johnthetubaguy | pilgrimstack: its a bug, they should both fail | 12:35 |
| jroll | johnthetubaguy: yeah, reading the code now, seeing that... thanks | 12:35 |
| johnthetubaguy | pilgrimstack: I am curious why you want to do that, use case wise | 12:36 |
| pilgrimstack | johnthetubaguy: from my point of view it should both work :) | 12:36 |
| pilgrimstack | good question | 12:37 |
| johnthetubaguy | pilgrimstack: the basic idea was to make nova+neutron easier to use by blocking "bad" things, like not having an IP | 12:37 |
| pilgrimstack | we have many users who want to manage manually (maybe puppet or something else) their IP address on the second network | 12:37 |
| pilgrimstack | currently they can do that but they need to create a subnet with a fake range and DHCP disabled | 12:38 |
| openstackgerrit | Andrey Shestakov proposed openstack/nova: Add support of attach_interface for ironic virt driver https://review.openstack.org/350047 | 12:38 |
| pilgrimstack | nova will allocate IPs anyway | 12:39 |
| pilgrimstack | it's just a declaration in DB, nothing is managed by OpenStack on thoses nics | 12:39 |
| johnthetubaguy | pilgrimstack: I think there was a plan for tagging a port with "i don't need an IP", to avoid all those checks | 12:39 |
| *** zenoway has joined #openstack-nova | 12:40 | |
| johnthetubaguy | pilgrimstack: ...but I don't remember if that got anywhere | 12:40 |
| *** shaohe_feng has quit IRC | 12:40 | |
| *** lpetrut1 has joined #openstack-nova | 12:41 | |
| *** shaohe_feng has joined #openstack-nova | 12:41 | |
| *** lpetrut has quit IRC | 12:41 | |
| *** lpetrut1 is now known as lpetrut | 12:41 | |
| johnthetubaguy | pilgrimstack: sounds like you actually want that on a network, saying "unmanaged IPs" or something like that | 12:41 |
| pilgrimstack | right | 12:41 |
| pilgrimstack | I need a L2 network and nothing more :) | 12:41 |
| pilgrimstack | no IP management | 12:41 |
| johnthetubaguy | pilgrimstack: yeah, seems like a think, just not sure we have APIs for that right now | 12:42 |
| *** sudipto has joined #openstack-nova | 12:42 | |
| *** sudipto_ has joined #openstack-nova | 12:42 | |
| johnthetubaguy | s/think/thing/ | 12:42 |
| pilgrimstack | In fact the workaround using port creation and attachement is what want | 12:42 |
| pilgrimstack | but I would like to do it when I create an instance too | 12:43 |
| *** rlrossit has joined #openstack-nova | 12:43 | |
| openstackgerrit | Sean Dague proposed openstack/nova: Documentation for the vendordata reboot. https://review.openstack.org/353793 | 12:43 |
| johnthetubaguy | pilgrimstack: right, but supporting that breaks the error handing for most users that do want an IP address | 12:44 |
| pilgrimstack | If I want an IP address, I have to create a subnet and activate DHCP | 12:45 |
| pilgrimstack | Question, what is the use case for a subnet management without DHCP management ? | 12:45 |
| johnthetubaguy | pilgrimstack: config drive only with cloud-init setup | 12:46 |
| johnthetubaguy | pilgrimstack: basically what rackspace public cloud does | 12:46 |
| *** mlavalle has quit IRC | 12:46 | |
| pilgrimstack | ok, good point | 12:46 |
| *** diga has joined #openstack-nova | 12:46 | |
| *** gcb_ has quit IRC | 12:47 | |
| johnthetubaguy | in theory, those VIFs should be locked down to only the allowed mac and IP address, if configured correctly | 12:47 |
| jaypipes | mdbooth: assert_called_once() is not a thing. | 12:47 |
| *** ociuhandu has joined #openstack-nova | 12:47 | |
| mdbooth | jaypipes: It is on the mock I have locally, from pypi | 12:48 |
| *** ociuhandu has quit IRC | 12:48 | |
| mdbooth | running 2.7 | 12:48 |
| *** devkulkarni has joined #openstack-nova | 12:49 | |
| *** ociuhandu has joined #openstack-nova | 12:49 | |
| mdbooth | jaypipes: http://paste.openstack.org/show/558374/ | 12:49 |
| mdbooth | I'm pretty sure it's new in mock 2 | 12:49 |
| pilgrimstack | So from OSI point of view, a L2 network connexion should not require a subnet, that's how it implemented on Neutron side, I think Nova should work like this too | 12:50 |
| mdbooth | But whenever it was added, it certainly exists now | 12:50 |
| *** ociuhandu has quit IRC | 12:50 | |
| *** Hosam_ has joined #openstack-nova | 12:50 | |
| *** bswartz has joined #openstack-nova | 12:50 | |
| *** shaohe_feng has quit IRC | 12:50 | |
| *** ociuhandu has joined #openstack-nova | 12:50 | |
| *** shaohe_feng has joined #openstack-nova | 12:51 | |
| pilgrimstack | johnthetubaguy: does it help if I create a blueprint/backlog-spec ? | 12:51 |
| *** mitchel_jhonson has quit IRC | 12:52 | |
| johnthetubaguy | pilgrimstack: yeah. its worth capturing, I would catch armax in the neutron channel, I feel like there is one already about, but I don't remember where | 12:52 |
| *** kevinz has quit IRC | 12:52 | |
| pilgrimstack | ko | 12:53 |
| pilgrimstack | ok | 12:53 |
| *** Hosam has quit IRC | 12:53 | |
| *** devkulkarni has quit IRC | 12:53 | |
| *** devkulkarni has joined #openstack-nova | 12:54 | |
| jaypipes | mdbooth: it's not a thing in py3.5 then... | 12:55 |
| jaypipes | mdbooth: I see no mention of it in https://docs.python.org/3/library/unittest.mock.html | 12:55 |
| mdbooth | jaypipes: Ah... | 12:55 |
| jaypipes | mdbooth: in any case, all the uses of assert_called_once() can easily be replaced with assert_called_once_with(), no? | 12:56 |
| *** sonofthor has joined #openstack-nova | 12:56 | |
| mdbooth | jaypipes: Sure, but I didn't have a reason to do that until you mentioned forward compat. | 12:56 |
| * mdbooth wonders why they would diverge at this stage. | 12:56 | |
| jaypipes | mdbooth: good question, wondering the same :/ | 12:56 |
| *** irenab has quit IRC | 12:57 | |
| *** ociuhandu has quit IRC | 12:57 | |
| jaypipes | mdbooth: you think you can address those issues in the patches and re-push today? I should be able to re-review this afternoon for you. | 12:57 |
| mdbooth | jaypipes: Yeah, I'll update those. | 12:57 |
| jaypipes | kewl. | 12:57 |
| *** tblakes has joined #openstack-nova | 12:58 | |
| mdbooth | jaypipes: It looks like unittest.mock() at least has the feature of not adding methods starting with assert_ | 12:58 |
| mdbooth | iow the typo catcher | 12:58 |
| bauzas | jaypipes: morning :) | 12:59 |
| bauzas | jaypipes: I'm just looking at Gerrit to see what was merged | 13:00 |
| bauzas | jaypipes: AFAICS, the initial patch for the REST placement API was merged, right? | 13:00 |
| *** shaohe_feng has quit IRC | 13:00 | |
| bauzas | so I can try to add the CRUD operations for the dynamic-resource-classes | 13:01 |
| *** edand has joined #openstack-nova | 13:01 | |
| *** shaohe_feng has joined #openstack-nova | 13:01 | |
| jaypipes | bauzas: yup! | 13:02 |
| *** xyang1 has joined #openstack-nova | 13:03 | |
| *** woodster_ has joined #openstack-nova | 13:04 | |
| edleafe | bauzas: custom-resource-classes | 13:07 |
| edleafe | (we had a renaming while you were away) | 13:07 |
| *** andymaier has joined #openstack-nova | 13:08 | |
| bauzas | woohoo | 13:08 |
| *** dingboopt has quit IRC | 13:08 | |
| *** prateek has joined #openstack-nova | 13:08 | |
| bauzas | edleafe: I had this nit before I went away :p | 13:08 |
| edleafe | bauzas: yeah, I thought you'd like it | 13:08 |
| bauzas | but as a French guy, it was this kind of situation when I was afraid to ask for another name :p | 13:08 |
| *** ociuhandu has joined #openstack-nova | 13:08 | |
| bauzas | plus the not dired trait :p | 13:09 |
| bauzas | (trying to make a pun in your non-native language is awfully terrible) | 13:09 |
| *** houming has quit IRC | 13:09 | |
| edleafe | bauzas: even being able to attempt it is more than I can do, so kudos! | 13:09 |
| *** devkulkarni has quit IRC | 13:10 | |
| *** lucas-hungry is now known as lucasagomes | 13:10 | |
| *** edmondsw has joined #openstack-nova | 13:11 | |
| *** shaohe_feng has quit IRC | 13:11 | |
| *** lifeless has quit IRC | 13:11 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: WIP: live-migration test hook for serial console https://review.openstack.org/347471 | 13:11 |
| *** shaohe_feng has joined #openstack-nova | 13:11 | |
| *** mriedem has joined #openstack-nova | 13:12 | |
| jroll | mikal: do you have any plans to make the metadata API support the openstack-style metadata, rather than just ec2? | 13:12 |
| *** andymaier has quit IRC | 13:13 | |
| *** tbachman has joined #openstack-nova | 13:14 | |
| *** roeyc has quit IRC | 13:14 | |
| jroll | jaypipes: mdbooth: looks like that's coming in 3.6: http://bugs.python.org/issue26323 https://github.com/testing-cabal/mock/commit/7ca5d3afe293d5e4d769c1cb2dfccb0688ba1292 | 13:15 |
| mdbooth | jaypipes jroll: Hmm, in that case is it worth not using the new interfaces? I'm guessing 3.6 will release before Nova is deployable on python 3. | 13:16 |
| jroll | mdbooth: I think it's fine to use it, we use mock from pypi so that we don't have differences in mock between python versions | 13:17 |
| jroll | but I'm not a nova core :) | 13:17 |
| mdbooth | jroll: Well if they diverged we genuinely wouldn't want to use anything not available in both. | 13:17 |
| mdbooth | Regardless of source. However, this is an interesting time window. | 13:18 |
| jroll | mdbooth: I don't think we'll ever use the python stdlib version, idk | 13:18 |
| jroll | we use lots of mock features not in 2.7 :) | 13:18 |
| mdbooth | jroll: That's all of them , isn't it? | 13:19 |
| jroll | I think there's some in 2.7 | 13:19 |
| jroll | 2.6 didn't have it at all iirc | 13:19 |
| jroll | but idk | 13:19 |
| *** shaohe_feng has quit IRC | 13:21 | |
| *** shaohe_feng has joined #openstack-nova | 13:22 | |
| johnthetubaguy | mdbooth: the py35 vs py36 call is likely going to be a distro support thing | 13:23 |
| mdbooth | jroll is pointing out we don't use that mock anyway | 13:23 |
| *** jichen has quit IRC | 13:23 | |
| *** roeyc has joined #openstack-nova | 13:23 | |
| * mdbooth is genuinely on the fence on this, btw | 13:23 | |
| johnthetubaguy | mdbooth: yeah, thats true | 13:24 |
| jroll | right, the pypi version solely exists so we don't have to care about python version | 13:24 |
| * mdbooth doesn't mind making the requested changes, but sounds like it's worth a discussion at least | 13:24 | |
| johnthetubaguy | mdbooth: if it works in the gate, and aids readability, I would support it | 13:24 |
| johnthetubaguy | jroll: +1 | 13:24 |
| *** su_zhang has quit IRC | 13:24 | |
| mdbooth | johnthetubaguy: Specifically we're talking about assert_called_once() and assert_not_called() | 13:24 |
| openstackgerrit | Chris Dent proposed openstack/nova: Add support for resource_providers urls https://review.openstack.org/329151 | 13:25 |
| mdbooth | There's also the issue that, historically, a typo in a mock assert always passed | 13:25 |
| jaypipes | johnthetubaguy: I'd prefer to just use the methods that are available in the standard library mock modules and get this patch series through. We could bikeshed on this for a while. | 13:25 |
| *** su_zhang has joined #openstack-nova | 13:25 | |
| mdbooth | jaypipes: That, too. | 13:25 |
| cdent | jaypipes, sdague: that change ^^ updates the update method to return a body and a 200 and no location | 13:25 |
| cdent | I continue to think that's not necessary, but it is nice. | 13:25 |
| johnthetubaguy | jaypipes: true | 13:26 |
| jroll | jaypipes: which version of the stdlib? :) | 13:26 |
| jroll | jaypipes: we already use lots of things not available in 2.7 | 13:26 |
| jroll | or 3.4 | 13:26 |
| jroll | etc | 13:26 |
| * mdbooth is just going to make the updates :) | 13:26 | |
| jaypipes | jroll: the ones we gate on: py27 and py35 | 13:26 |
| jaypipes | mdbooth: ty | 13:26 |
| openstackgerrit | Chris Dent proposed openstack/nova: placement: add filtering by attrs to resource_providers https://review.openstack.org/343046 | 13:27 |
| jroll | jaypipes: lots to remove if we restrict ourselves to py27 | 13:27 |
| johnthetubaguy | so I thought mock was added in 3.x for some reason | 13:27 |
| cdent | jaypipes, sdague: the stack of three starting at https://review.openstack.org/#/c/352573/ ought to be good to go | 13:27 |
| *** prateek_ has joined #openstack-nova | 13:28 | |
| mriedem | speaking of mock https://review.openstack.org/#/c/355213/ | 13:28 |
| mriedem | ^ need that in to unblock getting neutronclient 5.1.0 in g-r | 13:28 |
| *** lifeless has joined #openstack-nova | 13:29 | |
| mriedem | johnthetubaguy: ^ which we need for carl_baldwin's neutronclient ip allocation client error handling thing for server build abort | 13:29 |
| bauzas | mriedem: I can help :) | 13:29 |
| *** su_zhang has quit IRC | 13:29 | |
| jaypipes | cdent: cheers | 13:29 |
| mriedem | jesus it's about time | 13:30 |
| * cdent goes to pub | 13:30 | |
| johnthetubaguy | mriedem: looking at that patch now | 13:30 |
| carl_baldwin | mriedem: Thanks for helping out with that. I've been traveling for our mid-cycle but I tried to get everything lined up on top of your fix. | 13:30 |
| jaypipes | mriedem: reviewing that now... | 13:30 |
| *** prateek has quit IRC | 13:30 | |
| johnthetubaguy | carl_baldwin: should see you there tomorrow morning around 10am ish! | 13:31 |
| *** shaohe_feng has quit IRC | 13:31 | |
| mriedem | sdague: these are good to go now https://review.openstack.org/#/q/topic:bug/1612410 | 13:31 |
| mriedem | the other failures i was hitting are not related to neutron, i fixed them separately | 13:31 |
| carl_baldwin | johnthetubaguy: Looking forward to it. | 13:31 |
| *** andymaier has joined #openstack-nova | 13:32 | |
| *** ashyoung has joined #openstack-nova | 13:32 | |
| sdague | mriedem: ok, approved the novaclient one | 13:32 |
| *** diogogmt has joined #openstack-nova | 13:33 | |
| mriedem | assuming the nv job passes right away, i'll push another change later to make it voting | 13:33 |
| *** parora has joined #openstack-nova | 13:34 | |
| *** shaohe_feng has joined #openstack-nova | 13:36 | |
| bauzas | mriedem: so AFAICS, this is just an immediate resolution patch for fixing the problem, but I hope we could see a different way to mock the neutronclient, right? | 13:36 |
| bauzas | longer-term of course | 13:36 |
| *** catintheroof has joined #openstack-nova | 13:36 | |
| jaypipes | mriedem: done | 13:37 |
| *** prateek_ has quit IRC | 13:37 | |
| mriedem | bauzas: yes | 13:37 |
| mriedem | jaypipes: thanks | 13:37 |
| mriedem | bauzas: i didn't want to re-write all of the neutron sec group tests on sunday morning | 13:37 |
| mriedem | :) | 13:37 |
| openstackgerrit | Matt Riedemann proposed openstack/os-vif: Add a reminder to remove Route.interface field https://review.openstack.org/355093 | 13:38 |
| bauzas | mriedem: sure, I didn't ask for you, just wanted to know if people are thinking about that :) | 13:38 |
| mriedem | yup, i am | 13:38 |
| mriedem | just don' have the time to rewrite it all before vacation and the freeze | 13:38 |
| bauzas | okay | 13:39 |
| openstackgerrit | Jay Pipes proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag https://review.openstack.org/334860 | 13:40 |
| *** shaohe_feng has quit IRC | 13:41 | |
| *** shaohe_feng has joined #openstack-nova | 13:42 | |
| *** niedbalski has joined #openstack-nova | 13:42 | |
| *** diogogmt has quit IRC | 13:42 | |
| *** ashyoung has quit IRC | 13:43 | |
| *** catintheroof has quit IRC | 13:43 | |
| *** pwnall has joined #openstack-nova | 13:44 | |
| mriedem | sdague: random thing to think/fret about, are we going to release the novaclient proxy (image/neutron) changes as a major version bump? i can see arguments for both ways (major or minor update) | 13:44 |
| mriedem | with 2.36 i think we said that's a major bump | 13:44 |
| sdague | mriedem: it's not backwards incompatible, right? | 13:46 |
| mriedem | no, | 13:46 |
| mriedem | so even for 2.36 i'm not sure it's a major release, | 13:46 |
| sdague | for 2.36 we should signal as major | 13:46 |
| mriedem | i checked the midcycle etherpad and we only said major bump when we drop the network CLIs | 13:46 |
| mriedem | the image/neutron proxy stuff is only incompatible if we can't find the proper entry in the service catalog that we're looking up... | 13:47 |
| mriedem | which we did differently between those two patches | 13:47 |
| *** TravT has joined #openstack-nova | 13:47 | |
| mriedem | the neutron one falls back to our proxy api if it can't find a 'network' endpoint | 13:47 |
| sdague | so, honestly, this is case and point to me why semver is a giant waste of time. :) | 13:47 |
| *** erhudy has joined #openstack-nova | 13:48 | |
| mriedem | 2.36 should probably be major b/c of the api side changes | 13:48 |
| sdague | yeh | 13:48 |
| mriedem | we handle the CLI, but if you're using the API it's going to be bad | 13:48 |
| mriedem | that's the same for the image proxy patch though | 13:49 |
| mriedem | oh wel, | 13:49 |
| mriedem | but in that patch we don't use 2.36 yet | 13:49 |
| mriedem | ok, so the 2.36 change is definitely major bump | 13:49 |
| erhudy | could a +2 look at https://review.openstack.org/#/c/355415/, fixes a regression introduced in https://review.openstack.org/#/c/187857/ | 13:49 |
| mriedem | i just didn't want to do like a 6.0 and then a 7.0 a week later | 13:49 |
| *** ashyoung has joined #openstack-nova | 13:50 | |
| openstackgerrit | sean mooney proposed openstack/nova: convert libvirt driver to use os-vif for vhost-user with ovs. https://review.openstack.org/334048 | 13:50 |
| *** ptm_away is now known as PaulMurray | 13:50 | |
| *** shaohe_feng has quit IRC | 13:52 | |
| *** mlavalle has joined #openstack-nova | 13:52 | |
| PaulMurray | Live migration meeting in 8 mins on #openstack-nova-3 PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk diana_clarke mrhillsman | 13:52 |
| *** shaohe_feng has joined #openstack-nova | 13:52 | |
| PaulMurray | oops - #openstack-meeting-3 PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski jlanoux yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk diana_clarke mrhillsman | 13:53 |
| *** pwnall has quit IRC | 13:53 | |
| *** hshiina has joined #openstack-nova | 13:53 | |
| *** tonytan4ever has joined #openstack-nova | 13:53 | |
| *** permalac has joined #openstack-nova | 13:53 | |
| *** ecelik has quit IRC | 13:53 | |
| sdague | mriedem: yeh | 13:53 |
| mriedem | and i'm wondering if there are things i should be looking at to get in before we land these | 13:54 |
| *** burgerk has quit IRC | 13:54 | |
| sdague | mriedem: the one other thing that occurred to me is cli flags to override the sc entry | 13:54 |
| sdague | which we used to do on volumes | 13:54 |
| mriedem | yup | 13:55 |
| sdague | which I'm of 2 minds on | 13:55 |
| *** haplo37__ has joined #openstack-nova | 13:55 | |
| sdague | 1) we should do those because we used to | 13:55 |
| *** yamahata has joined #openstack-nova | 13:55 | |
| sdague | 2) we *should not* and make cloud providers have a non insane sc | 13:55 |
| mriedem | 3) don't do it now and see what happens, we could always add in later | 13:55 |
| sdague | mriedem: yeh, that's always an option as well | 13:56 |
| mriedem | do 2 now, add 1 later if needed | 13:56 |
| sdague | right | 13:56 |
| mriedem | that was my plan anyway | 13:56 |
| sdague | see how big an issue it really is for people | 13:56 |
| mriedem | yup | 13:56 |
| mriedem | i think some of the cruft in there from long ago was from rax oddities | 13:56 |
| *** ashyoung has quit IRC | 13:56 | |
| sdague | some of it was | 13:56 |
| sdague | maybe we could get mordred to manually test on all his clouds | 13:57 |
| mordred | uhoh | 13:57 |
| * mordred reads | 13:57 | |
| *** burt has joined #openstack-nova | 13:57 | |
| mriedem | sdague: i forgot you can have duplicate networks in neutron (by name) | 13:58 |
| mriedem | your fake was throwing me off | 13:58 |
| mordred | sdague: is this a "double check that novaclient still works against existing clouds" ? | 13:58 |
| jroll | sdague: still going to be a problem for rackspace, at least internally, external users are probably fine. e.g. we have multiple nova service catalog entries for a single region in preprod | 13:58 |
| jroll | not saying don't do (2) | 13:58 |
| jroll | just pointing out the insanity | 13:58 |
| alaski | one point to consider on the cli flags override is that without them it's not possible to use the client to test endpoints before exposing them in the sc | 13:59 |
| openstackgerrit | Julian proposed openstack/nova: Add unit tests for nova.virt.firewall.IpTablesFirewallDriver (Part 4) https://review.openstack.org/355550 | 13:59 |
| jroll | alaski: good point | 14:00 |
| mordred | sdague: also, what's the overall thing(s) that should be verified? | 14:00 |
| *** ashyoung has joined #openstack-nova | 14:00 | |
| *** anush_ has joined #openstack-nova | 14:00 | |
| *** andymaier has quit IRC | 14:02 | |
| *** shaohe_feng has quit IRC | 14:02 | |
| *** jamesdenton has joined #openstack-nova | 14:03 | |
| *** shaohe_feng has joined #openstack-nova | 14:03 | |
| *** jistr is now known as jistr|debug | 14:03 | |
| mriedem | mordred: this change and below https://review.openstack.org/#/c/354981/ | 14:04 |
| mriedem | mordred: those are using the catalog to lookup the glance v2 image api and the neutron api so we no longer call proxy apis in nova for image/network things | 14:04 |
| mriedem | b/c the nova proxy apis are deprecated in microversion 2.36 and will return a 404 now | 14:04 |
| *** pbandark has quit IRC | 14:06 | |
| *** efried has joined #openstack-nova | 14:06 | |
| sdague | mordred: the test would be: nova boot --image $nameofimage --nic net-name=$nameofnet --flavor $nameofflavor myvm | 14:06 |
| *** pwnall has joined #openstack-nova | 14:06 | |
| *** mingyu has joined #openstack-nova | 14:06 | |
| sdague | name of image and name of net are hitting glance / neutron directly after that point | 14:06 |
| *** Hosam_ has quit IRC | 14:06 | |
| mordred | yah - I can do that - it won't be the quickest thing in the world as I don't have any automation set up to run nova cli things | 14:07 |
| mordred | so it'll be extra manual - but I can do it if it's helpful for sure | 14:07 |
| *** Hosam has joined #openstack-nova | 14:07 | |
| mordred | fwiw, I'm fairly certain that it's a safe change for shade/ansible as we stopped using nova proxy apis a while back \o/ | 14:07 |
| sdague | mordred: it would be a good sniff test... though we could also post to the ML and hope cloud providers might care to test | 14:07 |
| openstackgerrit | Maciej Szankin proposed openstack/nova: Updated flags for XVP config options https://review.openstack.org/349691 | 14:09 |
| *** lpetrut1 has joined #openstack-nova | 14:10 | |
| sdague | jroll: what about image / network endpoints? | 14:10 |
| *** mingyu has quit IRC | 14:10 | |
| sdague | compute is already covered by other things | 14:10 |
| *** armax has joined #openstack-nova | 14:10 | |
| *** lpetrut has quit IRC | 14:11 | |
| *** lpetrut1 is now known as lpetrut | 14:11 | |
| *** Hosam has quit IRC | 14:11 | |
| jroll | sdague: I think it's similar, e.g. I have NOVA_VOLUME_SERVICE_NAME=cloudBlockStoragePreProd2 laying around in various forms | 14:11 |
| *** shaohe_feng has quit IRC | 14:12 | |
| *** shaohe_feng has joined #openstack-nova | 14:13 | |
| mriedem | jroll: so for the image/network stuff in nova cli today, how would you be testing pre-prod? | 14:13 |
| mriedem | since the cli is going to the nova proxy APIs | 14:13 |
| mriedem | so you'd have to configure nova.conf to point at your pre-prod glance/neutron APIs right? | 14:13 |
| *** su_zhang has joined #openstack-nova | 14:13 | |
| *** alextricity25 has joined #openstack-nova | 14:13 | |
| mriedem | since nova doesn't use the catalog | 14:14 |
| *** liverpooler has quit IRC | 14:14 | |
| mriedem | so if we're not losing anything for image/network, i'm fine with not adding that hook right now | 14:14 |
| *** BjoernT has joined #openstack-nova | 14:14 | |
| *** tri2sing has joined #openstack-nova | 14:15 | |
| mriedem | sdague: want me to post something to the ops list? | 14:16 |
| mriedem | as a heads up | 14:16 |
| sdague | mriedem: yeh, sure | 14:16 |
| sdague | mriedem: nova does use the catalog | 14:16 |
| *** tanvirt has joined #openstack-nova | 14:16 | |
| *** jaosorior has quit IRC | 14:17 | |
| *** su_zhang has quit IRC | 14:18 | |
| mriedem | sdague: for glance it uses api_servers which is your hard-coded list of glance APIs right? | 14:19 |
| jroll | mriedem: hrm, why's novaclient even accept a volume_service_name? | 14:20 |
| sdague | oh, sorry, nova server | 14:20 |
| mriedem | jroll: b/c of rax silly pants | 14:20 |
| sdague | mriedem: no, not exactly | 14:20 |
| mriedem | i'm 3/4 joking | 14:20 |
| jroll | mriedem: if it just goes through the proxy APIs, I mean | 14:20 |
| mriedem | the volume service name stuff can be removed now though | 14:20 |
| mriedem | jroll: nova cli used to call cinder api directly | 14:20 |
| mriedem | not via the proxy | 14:20 |
| sdague | jroll: because when cinder was split off, the fix for the nova cli was to go directly to cinder instead | 14:21 |
| jroll | mriedem: ah, I see | 14:21 |
| mriedem | it was super awesome | 14:21 |
| mriedem | we removed that awhile back | 14:21 |
| *** ducttape_ has joined #openstack-nova | 14:21 | |
| mriedem | so the volume_service_name stuff should be removed, i think it's deprecated at least | 14:21 |
| * jroll nods | 14:21 | |
| jroll | I have nfi what we do today then, probably downgrade novaclient :) | 14:21 |
| *** gongysh has joined #openstack-nova | 14:21 | |
| * jroll hasn't worked on downstream much this cycle | 14:21 | |
| mdbooth | jaypipes: Did you have an opinion on passing an explicit mock.MagicMock() return value in order to make the patch decorator not add an unused method argument? | 14:21 |
| mriedem | jroll: thought rax had it's own cli? | 14:22 |
| mriedem | supernova or something | 14:22 |
| *** kevinz has joined #openstack-nova | 14:22 | |
| * mdbooth thinks it's marginally less ugly than unused arguments | 14:22 | |
| jroll | mriedem: no, just a metapackage that installs our lame plugins | 14:22 |
| *** devkulkarni has joined #openstack-nova | 14:22 | |
| jroll | mriedem: supernova is a wrapper around nova that sets env variables for you | 14:22 |
| mriedem | like VOLUME_SERVICE_NAME | 14:22 |
| mriedem | :) | 14:22 |
| jroll | yep! | 14:22 |
| mriedem | i do remember seeing it in there | 14:22 |
| *** shaohe_feng has quit IRC | 14:22 | |
| mdbooth | i.e. @mock.patch('foo.bar.baz', mock.MagicMock()) and then it doesn't add an argument to the test | 14:22 |
| jroll | it's actually quite nice, if you use multiple regions | 14:22 |
| jroll | supernova personal-iad list -> sources env variables under [personal-iad] in ~/.supernova and calls nova list | 14:23 |
| *** shaohe_feng has joined #openstack-nova | 14:23 | |
| *** su_zhang has joined #openstack-nova | 14:26 | |
| *** kevinz has quit IRC | 14:27 | |
| *** kevinz has joined #openstack-nova | 14:27 | |
| bauzas | mdbooth: AFAIK, use the 'new' attribute | 14:30 |
| *** ekuris has quit IRC | 14:30 | |
| * mdbooth looks that up | 14:30 | |
| *** zz_dimtruck is now known as dimtruck | 14:31 | |
| *** kfarr has joined #openstack-nova | 14:32 | |
| *** shaohe_feng has quit IRC | 14:33 | |
| mdbooth | bauzas: Ah, I have actually been using that all along, but without using new= | 14:33 |
| mriedem | yeah new is nice | 14:33 |
| *** edand has quit IRC | 14:33 | |
| *** shaohe_feng has joined #openstack-nova | 14:34 | |
| mdbooth | mriedem: Is it possible to use without specifying what it should return? | 14:34 |
| jaypipes | mdbooth: yes, my opinion is don't do that :) | 14:34 |
| jaypipes | mdbooth: be consistent with the code around it. | 14:34 |
| bauzas | mdbooth: http://www.voidspace.org.uk/python/mock/patch.html | 14:34 |
| mdbooth | bauzas: Yeah, read that. It's not exactly clear. | 14:34 |
| bauzas | mdbooth: try refraining yourself from using it if that's not super needed | 14:34 |
| *** mdrabe has quit IRC | 14:34 | |
| mdbooth | jaypipes: If there was any way to avoid a ton of unused arguments, though, that would be easier to read | 14:35 |
| *** mdrabe has joined #openstack-nova | 14:35 | |
| bauzas | mdbooth: in general, we prefer setting the explicit return value in the method itsefl | 14:35 |
| *** jed56 has quit IRC | 14:35 | |
| mdbooth | jaypipes: I know we have a lot of tests like that, but they're pretty ugly | 14:35 |
| mriedem | i might have been thinking of create= | 14:35 |
| openstackgerrit | Christopher Martin proposed openstack/nova: Fix for Nova API Dev Guide https://review.openstack.org/355978 | 14:35 |
| mdbooth | Meh | 14:36 |
| mdbooth | Like I said, I'm not a huge fan of either solution | 14:36 |
| bauzas | mdbooth: do you have a patch in hand so I could bite it ? | 14:36 |
| bauzas | there is no golden rule | 14:36 |
| *** burgerk has joined #openstack-nova | 14:37 | |
| cdent | mlavalle: you had any additional thoughts/issues about the placement api lately? (my todo list has just reminded me to check in with you) | 14:37 |
| *** diogogmt has joined #openstack-nova | 14:37 | |
| bauzas | but in case you want to see a difference between a good UT module and a wrong one, look at between test_tracker and test_resource_tracker and you'll understand | 14:37 |
| bauzas | mdbooth: | 14:37 |
| bauzas | the test_compute module is just insane too | 14:38 |
| bauzas | but the one who would fix that could be running for president if so | 14:38 |
| mlavalle | cdnet: not lately. Right now I am adding to Neutron the interaction with Nova using the placement api. I expect to start testing it later this week. So expect me to come back with comments next week | 14:38 |
| cfriesen | mriedem: dansmith: bauzas: I think I've found an issue that could bite Liberty/Mitaka upgrades. Fix proposed at https://review.openstack.org/355981 | 14:38 |
| bauzas | I mean, giving peace to the world should be easier than fixing test_compute | 14:38 |
| cdent | mlavalle: cool, thanks | 14:39 |
| *** links has quit IRC | 14:39 | |
| cfriesen | the trigger for the above issue is that in class PciDevice nova-conductor will write to the "parent_addr" field which is new in Mitaka, then in the downversioned object that field doesn't exist anymore but it's still listed as a changed field. | 14:39 |
| mlavalle | cdent: quck question. funny that you pinged exactly right now, when I am coding the creation of the clients. Are the nova client and the placement client always going to be separte? r are they going to fuse in one? | 14:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: nfs fix for xenial images https://review.openstack.org/329466 | 14:40 |
| bauzas | cfriesen: k, looking but I don't have a magic wand for o.vo repo :) | 14:40 |
| edleafe | mlavalle: they will be separate | 14:40 |
| cfriesen | bauzas: yeah...I was just wondering if what PciDevice is doing is legit | 14:40 |
| mlavalle | edleafe: ok, thanks | 14:41 |
| cdent | mlavalle: timing is weird. My expectation is that the placementclient library will always be separate and its cli will be generated by osc. This is in line with the expectation that eventually the placement service will be it's own separate thing. | 14:41 |
| bauzas | cfriesen: mmm, that's weird | 14:41 |
| *** marst has quit IRC | 14:41 | |
| bauzas | cfriesen: because a backport method should make sure to not update the object field when the version is old | 14:41 |
| bauzas | cfriesen: so that the field should not be part of obj_what_changed | 14:42 |
| mlavalle | cdent: ok, thanks. btw, I still owe you the cleaning of the execptions in the placement client. I'll take care of it over this week or next | 14:42 |
| cdent | mlavalle: that's great, but there's no huge rush: from the nova side there's no immediate dependencies brewing on that code | 14:42 |
| *** shaohe_feng has quit IRC | 14:43 | |
| cfriesen | bauzas: PciDevice._from_db_object() writes to pci_device.parent_addr unconditionally | 14:43 |
| mlavalle | cdent: I know. I just want you to know it is in my to do list ;-) | 14:43 |
| cdent | :) | 14:43 |
| *** shaohe_feng has joined #openstack-nova | 14:44 | |
| *** rama_y has joined #openstack-nova | 14:44 | |
| bauzas | cfriesen: but obj_make_compatible does the necessary https://github.com/openstack/nova/blob/master/nova/objects/pci_device.py#L133 | 14:45 |
| bauzas | cfriesen: so that the DB object is modified *before* calling out _from_db_object() | 14:45 |
| dansmith | cfriesen: commented on the review and the bug | 14:46 |
| mlavalle | cdent: I am on your side of the pond, attending the Neutron mid-cycle in Cork Ireland | 14:46 |
| *** brian_price has quit IRC | 14:46 | |
| cdent | mlavalle: Awesome, I've never been to Cork but I hear it is lovely | 14:46 |
| mlavalle | cdent: it is. Specially if you consider that in San Antonio, TX, where I am from, we get 40C+ degrees this time of the year :-) | 14:48 |
| cfriesen | dansmith: thanks. I'll check out the latest version of Liberty. What I was seeing is that the older version of the object preserves the nonexistant field in self._changed_fields, and the next time it calls self.save() it causes problems. | 14:49 |
| dansmith | cfriesen: then we should fix *that*, IMHO | 14:50 |
| *** jistr|debug is now known as jistr | 14:50 | |
| dansmith | cfriesen: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L434 | 14:51 |
| dansmith | cfriesen: that looks like it does the right thing to me | 14:51 |
| dansmith | cfriesen: doesn't take changes from the primitive unless they match a field we have | 14:51 |
| *** ashyoung has quit IRC | 14:52 | |
| cfriesen | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L223dansmith: | 14:52 |
| cfriesen | dansmith: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L223 | 14:52 |
| cfriesen | sorry, paste error | 14:52 |
| *** zenoway has quit IRC | 14:53 | |
| *** shaohe_feng has quit IRC | 14:53 | |
| dansmith | cfriesen: ah, remotable return right, well, all we have to do is filter that too, IMHO | 14:53 |
| *** zenoway has joined #openstack-nova | 14:53 | |
| cfriesen | dansmith: then when we call self.save() from the lower versioned object, we hit https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L651 and choke on the getattr() | 14:54 |
| *** shaohe_feng has joined #openstack-nova | 14:54 | |
| dansmith | cfriesen: we can make that get_changes() be more defensive too for good measure | 14:55 |
| bauzas | dansmith: question, why do we need to do https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L223 ? | 14:55 |
| *** marst has joined #openstack-nova | 14:55 | |
| bauzas | dansmith: if we recreate the object on the receiving side, then it will automatically set the fields, which will update the values, nope ? | 14:56 |
| *** tongli has joined #openstack-nova | 14:56 | |
| *** kenperkins has joined #openstack-nova | 14:56 | |
| dansmith | bauzas: that code mirrors the changed fields list from the calling side | 14:56 |
| dansmith | bauzas: so that if some remotable call touches a field, we see it as dirty on the calling side, | 14:57 |
| dansmith | and if it cleans one, we see it as clean | 14:57 |
| bauzas | oh ok | 14:57 |
| *** permalac has quit IRC | 14:58 | |
| *** rrecio has joined #openstack-nova | 14:58 | |
| cfriesen | dansmith: just to clarify...you don't think we need the changes in obj_to_primitive(), but should maybe add some robustness in obj_get_changes()? | 14:58 |
| *** lpetrut1 has joined #openstack-nova | 14:58 | |
| *** zenoway has quit IRC | 14:58 | |
| dansmith | cfriesen: no, I see why now, I think both hunks are fine, but I think you should add the robustness to get_changes while you're in there | 14:59 |
| *** rrecio_ has joined #openstack-nova | 14:59 | |
| dansmith | cfriesen: but if being on the latest liberty fixes this for you for nova, then I think we should just apply this to master and not try some complicated backport | 14:59 |
| cfriesen | dansmith: right, makes sense. | 15:00 |
| *** lpetrut has quit IRC | 15:00 | |
| *** lpetrut1 is now known as lpetrut | 15:00 | |
| *** raj_singh has left #openstack-nova | 15:00 | |
| dansmith | cfriesen: also would appreciate a trace in the bug.. I see that most of the detail is there, but my find-the-trace-and-spiral-out-from-there bug technique failed me because you used human words | 15:00 |
| *** raj_singh has joined #openstack-nova | 15:00 | |
| *** PaulMurray has left #openstack-nova | 15:00 | |
| mriedem | tdurakov: this doesn't look to bad for the live migration job after skipping the volume-backed tests http://tinyurl.com/zlbkq47 | 15:01 |
| mriedem | tdurakov: that's also check only so it's subject to more spikes | 15:01 |
| Dinesh_Bhor | Hi all, Can someone please take a look at a small cleanup patch: https://review.openstack.org/#/c/355745/ ? | 15:02 |
| *** rrecio has quit IRC | 15:03 | |
| mriedem | tracking the gate-tempest-dsvm-full-xenial job pretty closely actually http://goo.gl/NLRvl7 | 15:03 |
| *** su_zhang has quit IRC | 15:03 | |
| *** shaohe_feng has quit IRC | 15:03 | |
| mriedem | dansmith: sdague: johnthetubaguy: ^ we might want to consider making the live migration job voting now that the volume-backed tests are being skipped - those were causing the majority of the random fails on xenial | 15:04 |
| *** su_zhang has joined #openstack-nova | 15:04 | |
| mriedem | the multinode job also runs live migration but would remain non-voting | 15:04 |
| dansmith | should we maybe wait until n3 just to avoid a "thought it was ready but it's not" sort of situation? | 15:05 |
| dansmith | generally happy to have anything that is solid be voting, just worried about the timing | 15:05 |
| mriedem | that could also mean letting a regression in before n-3 | 15:05 |
| mriedem | we do control the tests for this job in tree | 15:05 |
| openstackgerrit | Danil Akhmetov proposed openstack/nova: Handle user-defined ephemeral disk size if provided https://review.openstack.org/352522 | 15:05 |
| *** su_zhang_ has joined #openstack-nova | 15:05 | |
| *** su_zhang has quit IRC | 15:06 | |
| *** shaohe_feng has joined #openstack-nova | 15:06 | |
| dansmith | yeah, true | 15:06 |
| *** zenoway has joined #openstack-nova | 15:07 | |
| johnthetubaguy | mriedem: I mean we are using the nodes anyways, so I am OK trying with it voting | 15:08 |
| mriedem | johnthetubaguy: yeah, and it takes 1/3 of the time of the gate-tempest-dsvm-neutron-multinode-full job | 15:09 |
| mriedem | ~30m vs ~90m | 15:09 |
| *** dikonoor has quit IRC | 15:11 | |
| johnthetubaguy | mriedem: ah, that would be a win, I didn't know that was a thing | 15:12 |
| *** devkulkarni has quit IRC | 15:13 | |
| *** devkulkarni has joined #openstack-nova | 15:13 | |
| *** shaohe_feng has quit IRC | 15:14 | |
| *** cdelatte has joined #openstack-nova | 15:15 | |
| *** shaohe_feng has joined #openstack-nova | 15:15 | |
| *** zenoway has quit IRC | 15:15 | |
| *** josecastroleon has quit IRC | 15:15 | |
| *** zenoway has joined #openstack-nova | 15:15 | |
| *** mfisch has joined #openstack-nova | 15:15 | |
| *** mfisch has quit IRC | 15:15 | |
| *** mfisch has joined #openstack-nova | 15:15 | |
| cfriesen | dansmith: I'm not seeing 'parent_addr' in stable/liberty.....what am I missing? | 15:15 |
| pkholkin | sahid: hello, are you here? | 15:15 |
| pkholkin | I am interested in implementing your spec https://review.openstack.org/#/c/85399 | 15:16 |
| *** devkulkarni has quit IRC | 15:16 | |
| *** devkulkarni has joined #openstack-nova | 15:16 | |
| dansmith | cfriesen: I'll have to go do some digging | 15:17 |
| *** brian_price has joined #openstack-nova | 15:17 | |
| *** roeyc has quit IRC | 15:17 | |
| *** belmoreira has quit IRC | 15:17 | |
| cfriesen | dansmith: trace added to bug report | 15:17 |
| sahid | pkholkin: hello | 15:18 |
| sahid | yes I think that have never been implemented | 15:18 |
| dansmith | cfriesen: okay I'm thinking of k->l and a different field: https://bugs.launchpad.net/nova/+bug/1474074 | 15:19 |
| openstack | Launchpad bug 1474074 in OpenStack Compute (nova) kilo "PciDeviceList is not versioned properly in liberty and kilo" [High,Fix released] - Assigned to Dan Smith (danms) | 15:19 |
| pkholkin | sahid: why not)? | 15:20 |
| pkholkin | I think this is a good spec | 15:20 |
| *** mtanino has joined #openstack-nova | 15:20 | |
| pkholkin | and I can take it for Ocata | 15:20 |
| sahid | pkholkin: no real reason, please do | 15:21 |
| pkholkin | sahid: so, you don't mind? | 15:21 |
| pkholkin | are not optimistic with it? | 15:22 |
| sahid | not sure to understand but for sure you can work on it, it a valid usecase | 15:23 |
| sahid | I expected to find time one day but... | 15:23 |
| pkholkin | understand | 15:23 |
| *** derekh has quit IRC | 15:24 | |
| *** oanson has quit IRC | 15:24 | |
| *** shaohe_feng has quit IRC | 15:24 | |
| pkholkin | so I want to start working on it | 15:24 |
| pkholkin | thanks | 15:24 |
| Dinesh_Bhor | johnthetubaguy: Hi, Could you please take a look at it : https://review.openstack.org/#/c/355745/ ? | 15:25 |
| *** shaohe_feng has joined #openstack-nova | 15:25 | |
| dansmith | cfriesen: you're going to add the robustness to the get_changes() call as well right? | 15:25 |
| *** ravikama_ has joined #openstack-nova | 15:25 | |
| *** tongli has quit IRC | 15:27 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Improve mocking of imagebackend disks https://review.openstack.org/333242 | 15:27 |
| *** tongli has joined #openstack-nova | 15:27 | |
| openstackgerrit | Jens Rosenboom proposed openstack/nova: Fix ephemeral disk creation https://review.openstack.org/355415 | 15:29 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rewrite test_rescue and test_rescue_config_drive https://review.openstack.org/335966 | 15:29 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rewrite _test_finish_migration https://review.openstack.org/337159 | 15:31 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot https://review.openstack.org/338993 | 15:32 |
| *** matrohon has quit IRC | 15:32 | |
| mriedem | melwitt: if you get some time, would be good to get this in https://review.openstack.org/#/c/354349/ - the change after it is ready to land | 15:34 |
| cfriesen | dansmith: yeah, that's the plan. I'm heading off on vacation tomorrow so hopefully can get this done. After tomorrow anyone can feel free to run with it if they want. | 15:34 |
| *** shaohe_feng has quit IRC | 15:34 | |
| dansmith | cfriesen: okay, I can do it myself if you would prefer | 15:34 |
| openstackgerrit | Benjamin VanHavermaet proposed openstack/nova: Integrate OSprofiler and Nova https://review.openstack.org/254703 | 15:35 |
| *** paul-carlton2 has quit IRC | 15:35 | |
| cfriesen | dansmith: if you've got time that'd be great | 15:35 |
| *** su_zhang_ has quit IRC | 15:35 | |
| *** shaohe_feng has joined #openstack-nova | 15:35 | |
| dansmith | cfriesen: I don't, but it's my code that's broken, so.. :) | 15:35 |
| mriedem | melwitt: a lot of that change is just making the fakes / stubs in the tests not suck by passing invalid image ids | 15:35 |
| cfriesen | dansmith: am I right that this could bite Liberty/Mitaka upgrades? | 15:36 |
| dansmith | cfriesen: I thought you are specifically seeing that? this has been this way for a while and it has never come up, which is part of my skepticism | 15:37 |
| *** diga has quit IRC | 15:37 | |
| cfriesen | dansmith: I'm actually on Kilo (yeah, I know). But the relevent code is the same for Kilo/Liberty, though it's moved to o.vo of course. | 15:37 |
| *** su_zhang has joined #openstack-nova | 15:38 | |
| dansmith | cfriesen: well, still, I'm not sure why you're hitting it but nobody else has reported it | 15:38 |
| cfriesen | dansmith: you need to be using pci devices | 15:38 |
| dansmith | maybe because of something stupid in PCI specifically, I dunno | 15:38 |
| dansmith | yeah | 15:38 |
| siva_krishnan | Hi alaski! Currently I am working on https://bugs.launchpad.net/nova/+bug/1599201. I found the root cause to be this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1240. I just found your TODO on top of it, Can you please let me know, if you had a chance to look into it ? | 15:40 |
| openstack | Launchpad bug 1599201 in OpenStack Compute (nova) "Device tagging does not work with block_device_mapping with source=blank,destination=local" [Medium,Confirmed] - Assigned to Sivasathurappan Radhakrishnan (siva-radhakrishnan) | 15:40 |
| *** amotoki has joined #openstack-nova | 15:40 | |
| *** andreykurilin has quit IRC | 15:41 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rewrite _test_finish_migration https://review.openstack.org/337159 | 15:41 |
| *** andreykurilin has joined #openstack-nova | 15:42 | |
| *** ekuris has joined #openstack-nova | 15:42 | |
| *** amotoki has quit IRC | 15:43 | |
| *** amotoki has joined #openstack-nova | 15:43 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot https://review.openstack.org/338993 | 15:43 |
| openstackgerrit | Vu Tran proposed openstack/nova: Improve error log when snapshot fails https://review.openstack.org/356020 | 15:44 |
| *** shaohe_feng has quit IRC | 15:44 | |
| pumaranikar | Hi johnthetubaguy , please have a look at expected_attr list fix when you get time https://review.openstack.org/#/c/342299/ | 15:45 |
| *** shaohe_feng has joined #openstack-nova | 15:45 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup test_create_configdrive https://review.openstack.org/339114 | 15:45 |
| *** rcernin has quit IRC | 15:46 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Cleanup spawn tests https://review.openstack.org/344175 | 15:47 |
| *** haplo37__ has quit IRC | 15:47 | |
| dansmith | cfriesen: seems you broke the fixture test too somehow.. did all tests run for you locally? | 15:48 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Rename Backend snapshot and image https://review.openstack.org/333272 | 15:48 |
| cfriesen | no, code was just a proof of concept. was just looking at the added robustness stuff. | 15:49 |
| cfriesen | it seems to work in practice though | 15:49 |
| johnthetubaguy | pumaranikar: sorry, not sure I will be able to get to that till after the freeze, given all the other things to look at | 15:50 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Never copy a swap disk during cold migration https://review.openstack.org/331115 | 15:50 |
| dansmith | cfriesen: actually my change makes one of yours not necessary | 15:51 |
| pumaranikar | johnthetubaguy, ok | 15:52 |
| cfriesen | dansmith: the remotable() one? | 15:52 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Don't re-resize disks in finish_migration() https://review.openstack.org/331118 | 15:52 |
| dansmith | cfriesen: no the other | 15:52 |
| dansmith | cfriesen: see what I just pushed | 15:52 |
| dansmith | cfriesen: I guess I need to write tests for your other change too | 15:52 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Don't check config disk during cold migration https://review.openstack.org/337158 | 15:53 |
| *** kevinz has quit IRC | 15:53 | |
| *** hieulq_ has joined #openstack-nova | 15:55 | |
| *** shaohe_feng has quit IRC | 15:55 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Combine injection info in InstanceConfig https://review.openstack.org/337790 | 15:55 |
| cfriesen | dansmith: not sure about your obj_what_changed() modification. I think that's running on the new side, so self.fields will include the new field | 15:55 |
| *** shaohe_feng has joined #openstack-nova | 15:56 | |
| dansmith | cfriesen: you mean for the middle hunk I deleted? yeah, you're right | 15:56 |
| *** jojden has quit IRC | 15:57 | |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Add create_from_image and create_from_func to Backend https://review.openstack.org/333244 | 15:57 |
| cfriesen | dansmith: I was thinking maybe something like this if we wanted more robustness: http://paste.openstack.org/show/558414/ | 15:57 |
| dansmith | cfriesen: no, that's confusing the set-ness on the current thing from the definition | 15:58 |
| openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Pass is_block_dev explicitly from create_from_func https://review.openstack.org/333263 | 15:58 |
| *** rawlin has joined #openstack-nova | 15:59 | |
| cfriesen | dansmith: the issue I saw is that on the new side we're calling obj_get_changes() on the new side with self._changed_fields including a field that isn't specified in self. So getattr(self,key) chokes. | 15:59 |
| dansmith | cfriesen: right | 16:00 |
| dansmith | cfriesen: obj_attr_is_set is not the proper thing though.. checking to see if it's in fields is the right thing | 16:00 |
| cfriesen | dansmith: but I don't see an easy way of the new side saying "is this field valid in the old object" | 16:00 |
| cfriesen | dansmith: but it's in fields on the new side, where the code is running | 16:00 |
| dansmith | cfriesen: you can't.. you can only see that after the primitive conversion | 16:00 |
| *** Sukhdev has joined #openstack-nova | 16:01 | |
| dansmith | cfriesen: the robustness for obj_get_changes() is to protect the old side from a potentially bad primitive sent to it from a newer one | 16:01 |
| *** markus_z has quit IRC | 16:01 | |
| *** anush_ has quit IRC | 16:02 | |
| cfriesen | dansmith: ah, okay. so then we should never send invalid self._changed_fields to the newer side in the first place | 16:02 |
| dansmith | cfriesen: from the newer side you mean | 16:02 |
| *** bwallis has quit IRC | 16:03 | |
| dansmith | cfriesen: actually, I think I meant to remove the other one of your changes -- the remotable one.. because if we're defensive in obj_get_changes() then the remotable fix didn't really need to clean things up, | 16:03 |
| cfriesen | dansmith: well, the problem I saw was the newer side sending invalid self._changed_fields to the older side, which sent it back to the newer side, which choked in obj_get_changes() calling getattr() on a field that wasn't set. | 16:04 |
| dansmith | and if the to-primitive change is there, then we'll stop returning bad things | 16:04 |
| dansmith | cfriesen: only because we persisted the change list, but filtered out the actual changed field | 16:04 |
| *** karthiks is now known as karthiks_afk | 16:05 | |
| cfriesen | dansmith: right. and object_action() in ConductorManager sets updates['obj_what_changed'] on the new side. | 16:05 |
| *** Sukhdev has quit IRC | 16:05 | |
| *** shaohe_feng has quit IRC | 16:05 | |
| dansmith | ...so is there still something to resolve? | 16:05 |
| *** shaohe_feng has joined #openstack-nova | 16:06 | |
| dansmith | heh, your change breaks a test because the test is returning invalid fields .. nice :) | 16:06 |
| cfriesen | dansmith: I think object_action() calls obj_what_changed on the newer side, so it's still going to include fields that only exist on the new side. | 16:07 |
| cfriesen | dansmith: so either we need to fix that, or else we need the remotable() change on the old side. | 16:07 |
| *** amotoki has quit IRC | 16:07 | |
| dansmith | cfriesen: yes, but then obj_to_primitive should filter them from the primitive after the backport | 16:07 |
| mdbooth | jaypipes dansmith: Everything updated for your further perusal. | 16:08 |
| *** sridharg has quit IRC | 16:09 | |
| *** sdake has quit IRC | 16:09 | |
| *** xyang1 has quit IRC | 16:09 | |
| *** rl_person has quit IRC | 16:09 | |
| cfriesen | dansmith: where would obj_to_primitive filter them from the set of changed fields? | 16:09 |
| dansmith | cfriesen: L612 of your patch? | 16:09 |
| openstackgerrit | Chris Dent proposed openstack/nova: In placement API send microversion header when error https://review.openstack.org/356036 | 16:10 |
| cfriesen | dansmith: oh, I thought you meant without the patch. :) | 16:10 |
| dansmith | cfriesen: no | 16:10 |
| cdent | sdague, jaypipes, alex_xu: patch for placement api (microversion handling improvement) outside of the rest of the stack: https://review.openstack.org/#/c/356036/ | 16:11 |
| cfriesen | dansmith: okay, so if we take my v1 patch and remove the remotable() changes, then yes I think that would do it. | 16:11 |
| dansmith | cfriesen: plus the defensiveness | 16:11 |
| dansmith | that's what I'm doing now | 16:12 |
| *** sahid has quit IRC | 16:13 | |
| dansmith | cfriesen: pushed | 16:13 |
| dansmith | cfriesen: note that the stable json fixture test was broken in the same way, caught by making this change | 16:14 |
| *** paul-carlton2 has joined #openstack-nova | 16:14 | |
| *** nic has joined #openstack-nova | 16:14 | |
| *** hshiina has quit IRC | 16:15 | |
| *** ftersin has left #openstack-nova | 16:15 | |
| *** shaohe_feng has quit IRC | 16:15 | |
| *** shaohe_feng has joined #openstack-nova | 16:16 | |
| cfriesen | dansmith: does that cover the ConductorManager.object_action() case? | 16:17 |
| dansmith | cfriesen: say more things | 16:18 |
| *** xyang1 has joined #openstack-nova | 16:18 | |
| cfriesen | dansmith: in object_action we set updates['obj_what_changed'] = objinst.obj_what_changed() | 16:18 |
| *** chandankumar has quit IRC | 16:19 | |
| dansmith | cfriesen: which will be new because it has to be | 16:19 |
| cfriesen | dansmith: which is used by remotable() on the other (lower-versioned) side to set self._changed_fields | 16:20 |
| dansmith | cfriesen: right, so we'll set the internal list to something bad, but nothing will ever see the bad thing because we filter it in get_changes, | 16:20 |
| dansmith | cfriesen: and for your case when we serialize for save, our outgoing list will be filtered thusly, which means the second trip into conductor will not see the changed-but-not-set field | 16:21 |
| cfriesen | dansmith: but remotable() doesn't call obj_what_changed(), rather it looks at updates.get('obj_what_changed') | 16:21 |
| dansmith | cfriesen: read what I said again | 16:22 |
| dansmith | cfriesen: remotable will set the internal list to the "new" list from conductor, | 16:22 |
| dansmith | but nothing will ever see it because we filter in obj_what_changed() | 16:22 |
| cdent | thanks sdague | 16:23 |
| *** pilgrimstack has quit IRC | 16:23 | |
| *** Sukhdev has joined #openstack-nova | 16:23 | |
| *** yamahata has quit IRC | 16:23 | |
| cfriesen | dansmith: and then when we call self.save(), won't we pass the internal (wrong) self._changed_fields back to nova-conductor? | 16:23 |
| dansmith | cfriesen: no because when we make the save call, we call obj_to_primitive(), which filters (after your change) the changes field | 16:24 |
| dansmith | actually, my defensiveness change will have filtered it before we even hit your new code | 16:25 |
| *** shaohe_feng has quit IRC | 16:25 | |
| dansmith | cfriesen: L605 here: https://review.openstack.org/#/c/355981/3/oslo_versionedobjects/base.py | 16:26 |
| dansmith | cfriesen: won't return the bogus field(s) anymore, which is where we're serializing the object to make the save() call | 16:26 |
| *** shaohe_feng has joined #openstack-nova | 16:26 | |
| cfriesen | dansmith: okay, I'm sold. We'll still need a backport to stable/liberty, right? | 16:27 |
| dansmith | cfriesen: note that I'm not saying the remotable change is wrong, I'm saying it should not be necessary, and that's critical code that's semi-hard to test, so less change is better, IMHO | 16:27 |
| cfriesen | dansmith: fair enough | 16:28 |
| dansmith | cfriesen: "we" are not backporting non-security things to liberty anymore | 16:28 |
| dansmith | cfriesen: and this is in a library, which also has all kinds of other implications that I would have to ask someone about | 16:28 |
| dansmith | cfriesen: for the specific pci thing, we should be able to craft a smaller fix that just trims the changes list in the backport method, which would be purely nova code as a fix | 16:29 |
| *** bwallis has joined #openstack-nova | 16:29 | |
| cfriesen | dansmith: right, that'd be more limited | 16:30 |
| cfriesen | dansmith: thanks for digging into this | 16:30 |
| dansmith | parent_addr was added in 2015-Nov.. is that liberty? | 16:30 |
| *** gongysh has quit IRC | 16:31 | |
| *** baoli_ has quit IRC | 16:31 | |
| melwitt | mriedem: looking at the novaclient patch now | 16:32 |
| *** unicell has quit IRC | 16:34 | |
| cfriesen | dansmith: as far as I can tell parent_addr was added in Mitaka | 16:34 |
| dansmith | oh you said liberty->mitaka, but you're on kilo right? | 16:34 |
| cfriesen | dansmith: yes, jumping to Mitaka | 16:34 |
| *** zenoway has quit IRC | 16:34 | |
| cfriesen | dansmith: I think we'll hit the bug doing Liberty/Mitaka upgrades | 16:35 |
| dansmith | cfriesen: meaning skipping liberty? | 16:35 |
| *** zenoway has joined #openstack-nova | 16:35 | |
| cfriesen | dansmith: yes. But I think the same bug would be hit upgrading from Liberty | 16:35 |
| *** shaohe_feng has quit IRC | 16:36 | |
| dansmith | maybe | 16:36 |
| *** shaohe_feng has joined #openstack-nova | 16:36 | |
| dansmith | haven't had it reported from anyone, some of which I know have gone through the upgrade with pci devices | 16:37 |
| dansmith | but I can't point to why not | 16:37 |
| mdbooth | Fun. Just noticed that ephemeral disks are cached according to instance.os_type, not guest_format | 16:37 |
| mdbooth | So if you specify a non-default guest_format for an ephemeral disk on a host which has previously generated an ephemeral disk with a different format | 16:38 |
| mdbooth | You'll get the previous format instead of the one you asked for. | 16:39 |
| cfriesen | mdbooth: nice | 16:39 |
| mdbooth | It gets better, if you migrate it to another host and you're using qcow2 | 16:40 |
| *** zenoway has quit IRC | 16:40 | |
| mdbooth | The backing file created on the destination will be of the default format, not the one you asked for | 16:40 |
| mdbooth | So, instant data corruption :/ | 16:40 |
| cfriesen | mdbooth: so the takeaway is don't use ephemeral disks till O? :) | 16:40 |
| mdbooth | My guess is that it's been this way since the feature was implemented | 16:41 |
| mdbooth | So at this point it probably means that nobody actually ever does this. | 16:41 |
| *** danpb has quit IRC | 16:41 | |
| mdbooth | It's a lot of hassle for a feature nobody seems to be using :/ | 16:42 |
| mriedem | let's remove ephemeral bdms and bdm v1 | 16:42 |
| mriedem | and cloudpipe | 16:42 |
| *** thumpba has joined #openstack-nova | 16:43 | |
| mdbooth | mriedem: Actually, this bug is exclusive to bdm v2 | 16:44 |
| mdbooth | I think... | 16:44 |
| mriedem | oh | 16:44 |
| mriedem | well, | 16:44 |
| mriedem | let's just remove bdms | 16:44 |
| *** shaohe_feng has quit IRC | 16:46 | |
| *** shaohe_feng has joined #openstack-nova | 16:47 | |
| *** su_zhang has quit IRC | 16:48 | |
| *** su_zhang has joined #openstack-nova | 16:50 | |
| dansmith | mriedem: do we still have something broken that is resetting the gate? | 16:52 |
| dansmith | mriedem: I'm just seeing a few patches of mine constantly getting reset as they try to make it through | 16:53 |
| dansmith | I thought with the devstack revert we should be good | 16:53 |
| jaypipes | mdbooth: cool, thanks, after meetings will re-review. | 16:53 |
| melwitt | jaypipes, alaski, dansmith: fyi, I have proposed a patch for the local disk scheduling/reporting for volume-backed instances that was discussed at the nova meeting last week, at https://review.openstack.org/355091 | 16:56 |
| dansmith | melwitt: yeah, I don't like it | 16:56 |
| dansmith | melwitt: was trying to decide how to reply on it | 16:56 |
| *** shaohe_feng has quit IRC | 16:56 | |
| melwitt | okay | 16:56 |
| mriedem | dansmith: yes | 16:56 |
| *** gjayavelu has joined #openstack-nova | 16:56 | |
| dansmith | basically, as I've said, I just think it's a bunch of debt and mess to fix a thing that has been around for years on the eve of fixing it for reals | 16:56 |
| dansmith | melwitt: I'm sure I'm in the minority on that though | 16:57 |
| mriedem | dansmith: https://launchpad.net/bugs/1613749 | 16:57 |
| openstack | Launchpad bug 1613749 in OpenStack-Gate "Timeouts when requesting a glance image created with a remote image from git.o.o" [Undecided,New] | 16:57 |
| *** shaohe_feng has joined #openstack-nova | 16:57 | |
| dansmith | mriedem: okay | 16:57 |
| mriedem | dansmith: possibly fixed with https://review.openstack.org/#/c/356010/ | 16:57 |
| dansmith | mriedem: oh that, heh :) | 16:57 |
| melwitt | dansmith: I get that. for whatever reason at present it seems like several people are hitting the bug and a backportable fix is worthwhile. I tried to make it something that would be easy to delete when we get resource-providers | 17:00 |
| *** su_zhang has quit IRC | 17:00 | |
| *** kfarr has quit IRC | 17:00 | |
| dansmith | melwitt: yeah and I get that | 17:01 |
| *** su_zhang has joined #openstack-nova | 17:01 | |
| *** lucasagomes is now known as lucas-dinner | 17:02 | |
| oomichi | mriedem: I am not sure the meaning of -1 on https://review.openstack.org/#/c/351960 | 17:05 |
| *** cdent has quit IRC | 17:05 | |
| oomichi | mriedem: are you digging it more deeply? | 17:05 |
| dansmith | mriedem: ah, that fix got promoted I guess? | 17:05 |
| *** yamahata has joined #openstack-nova | 17:05 | |
| mriedem | dansmith: yeah | 17:06 |
| *** shaohe_feng has quit IRC | 17:06 | |
| *** devkulkarni has quit IRC | 17:07 | |
| alextricity25 | cfriesen: Hey. Are you around? | 17:07 |
| johnsom | Hi Nova folks. Is there a python client binding for "Show Port Interface Details"? | 17:07 |
| mriedem | oomichi: so, the method your changing is called from 2 different APIs, | 17:07 |
| mriedem | oomichi: one for deleting a floating IP and one for just removing a floating IP from an instance, | 17:07 |
| mriedem | in the latter case, disassociate, if we don't find the port/instance, we don't disassociate the floating ip | 17:07 |
| *** shaohe_feng has joined #openstack-nova | 17:07 | |
| mriedem | if the former case, delete, we pass None to the network API | 17:07 |
| mriedem | oomichi: which last night i thought that instance wasn't used, but it's used by the refresh_cache decorator in the network API | 17:08 |
| mriedem | however, the delete floating IP flow doesn't use the refresh_cache decorator for some reason | 17:08 |
| johnsom | I see interface_list, interface_attach/detach but I'm not seeing an interface_show or similar | 17:08 |
| mriedem | so passing instance=None probably doesn't hurt | 17:08 |
| mriedem | johnsom: no, that's a proxy, use neutron or osc | 17:09 |
| *** oanson has joined #openstack-nova | 17:09 | |
| *** irenab has joined #openstack-nova | 17:09 | |
| mriedem | johnsom: those proxies are all returning 404s with the 2.36 microversion | 17:09 |
| mriedem | so move off of them | 17:09 |
| johnsom | Hmmm, ok, that is good information | 17:09 |
| *** david-lyle_ has joined #openstack-nova | 17:09 | |
| mriedem | oomichi: so i *think* your change won't break anything in the delete floating IP flow, for neutron anyway, but we probably have a latent bug here with not refreshing a server's network info cache when we delete a floating ip | 17:10 |
| mriedem | i haven't been able to test that though | 17:10 |
| *** tonytan4ever has quit IRC | 17:11 | |
| *** diga__ has quit IRC | 17:11 | |
| *** rawlin has left #openstack-nova | 17:11 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: objects: Move 'arch' to 'fields.Architecture' https://review.openstack.org/356067 | 17:12 |
| *** efoley has quit IRC | 17:12 | |
| oomichi | mriedem: yeah, that is as you said on the review. and that is separated bug | 17:12 |
| mriedem | disassociate_and_release_floating_ip is the network API method i'm worried about | 17:12 |
| mriedem | for nova-net that refreshes the cache, for neutron it doesn't | 17:12 |
| *** david-lyle has quit IRC | 17:13 | |
| mriedem | would be a good tempest test actually | 17:13 |
| *** david-lyle_ is now known as david-lyle | 17:13 | |
| mriedem | but would be racey since nova has to refresh the cache | 17:13 |
| *** unicell has joined #openstack-nova | 17:14 | |
| mriedem | actually no that shouldn't race | 17:14 |
| mriedem | the REST API is blocking on the network API call | 17:14 |
| *** shaohe_feng has quit IRC | 17:17 | |
| *** shaohe_feng has joined #openstack-nova | 17:17 | |
| oomichi | mriedem: in the dissociation case, if the instance is None as the patch, the API returns an error as the expectation | 17:19 |
| oomichi | mriedem: on https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L312 | 17:20 |
| *** smatzek has quit IRC | 17:20 | |
| oomichi | mriedem: that seems valid behavior, right? | 17:20 |
| *** smatzek has joined #openstack-nova | 17:20 | |
| alaski | siva_krishnan: I have not quite determined the reason behind that TODO I added | 17:21 |
| mriedem | oomichi: i didn't even see the else case here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L324 | 17:21 |
| *** lpetrut has quit IRC | 17:21 | |
| openstackgerrit | Alex Szarka proposed openstack/nova: [WIP] Reduce code complexity to 25 https://review.openstack.org/351176 | 17:22 |
| mriedem | oomichi: i'm +2 on the change, left a big comment | 17:22 |
| mriedem | oomichi: as for the DELETE call to os-floating-ips, that is a 404 with 2.36 now | 17:22 |
| mriedem | oomichi: so if tempest is using that, it should probably move off | 17:22 |
| alaski | siva_krishnan: there was a discussion with mriedem and mdbooth and it seems that ephemeral disks can be passed in as block device mappings but then should not be put into the database. But it's not clear if that's what we want or what would be the right thing to change. there just hasn't been much thought put into it | 17:22 |
| mriedem | it should call nova to disassociate the floating IP and then call neutron to delete the floating IP | 17:22 |
| mriedem | oomichi: is there somewhere in tempest i can hack to check the server.addresses before and after a floating IP is deleted? | 17:23 |
| mriedem | to verify the refresh cache bug? | 17:24 |
| * oomichi checking the code.. | 17:24 | |
| mriedem | i guess whatever calls self.floating_ips_client.delete_floatingip | 17:25 |
| mriedem | oomichi: at the end of test_minimum_basic_scenario i could maybe delete the floating IP | 17:26 |
| mriedem | before teardown runs | 17:26 |
| *** tonytan4ever has joined #openstack-nova | 17:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: objects: Move 'arch' to 'fields.Architecture' https://review.openstack.org/356067 | 17:27 |
| *** shaohe_feng has quit IRC | 17:27 | |
| *** shaohe_feng has joined #openstack-nova | 17:28 | |
| *** hieulq_ has quit IRC | 17:29 | |
| *** gyee has joined #openstack-nova | 17:30 | |
| oomichi | mriedem: yeah, the scenario seems basic one, and the test seems good place. The other existing tests are too complex for this case | 17:30 |
| *** cleong has joined #openstack-nova | 17:30 | |
| *** chandankumar has joined #openstack-nova | 17:32 | |
| mriedem | plus that test will hit both nova-net and neutron | 17:33 |
| *** baoli has joined #openstack-nova | 17:33 | |
| *** hieulq_ has joined #openstack-nova | 17:36 | |
| *** cdent has joined #openstack-nova | 17:36 | |
| *** shaohe_feng has quit IRC | 17:37 | |
| *** sudipto_ has quit IRC | 17:37 | |
| *** sudipto has quit IRC | 17:37 | |
| *** shaohe_feng has joined #openstack-nova | 17:38 | |
| *** paul-carlton2 has quit IRC | 17:38 | |
| *** shaohe_feng has quit IRC | 17:47 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: tests: verify pci passthrough with numa https://review.openstack.org/356077 | 17:48 |
| *** shaohe_feng has joined #openstack-nova | 17:48 | |
| oomichi | sdague: can you take a look at https://review.openstack.org/#/c/351960/ ? that will fix some gate jobs(gate-openstack-ansible-os, etc) | 17:49 |
| *** devkulkarni has joined #openstack-nova | 17:49 | |
| *** hieulq_ has quit IRC | 17:50 | |
| sdague | dansmith / alaski what's this all about - http://logs.openstack.org/60/351960/9/check/gate-tempest-dsvm-cells/33b510f/logs/devstacklog.txt.gz#_2016-08-16_00_55_26_481 ? | 17:51 |
| *** oanson has quit IRC | 17:52 | |
| dansmith | sdague: we need to skip that for cellsv1 | 17:52 |
| dansmith | sdague: because there are no hosts at the top level | 17:52 |
| sdague | dansmith: is there a patch? | 17:52 |
| dansmith | sdague: we reverted the devstack patch immediately to stop it | 17:52 |
| dansmith | because ironic breaks in the same way | 17:52 |
| dansmith | and I have a todo to finish my replacement | 17:52 |
| sdague | dansmith: but it hasn't landed yet? | 17:52 |
| dansmith | sdague: https://review.openstack.org/#/c/355599/ | 17:53 |
| sdague | oh, those test results are yesterday at 11:30pm | 17:53 |
| sdague | ok | 17:53 |
| dansmith | I shall go finish that thing now | 17:53 |
| *** Sukhdev has quit IRC | 17:53 | |
| sdague | ok | 17:53 |
| alaski | dansmith: let me know if you need reviews | 17:54 |
| *** sdake has joined #openstack-nova | 17:55 | |
| dansmith | alaski: yeah I just haven't been pushing up anything non-critical because of the backlog | 17:55 |
| *** baoli has quit IRC | 17:56 | |
| dansmith | alaski: so for the cells thing I guess we just don't do it at all if cellsv1 is in play/ | 17:57 |
| *** mlavalle has quit IRC | 17:57 | |
| *** baoli has joined #openstack-nova | 17:57 | |
| *** parora has quit IRC | 17:57 | |
| *** shaohe_feng has quit IRC | 17:58 | |
| alaski | dansmith: yeah. I think we may want something in the nova-manage cmd that will bail and explain that the simple command won't work with v1 | 17:58 |
| alaski | rather than in devstack | 17:58 |
| dansmith | oh | 17:58 |
| dansmith | well, that's more work | 17:58 |
| *** shaohe_feng has joined #openstack-nova | 17:58 | |
| dansmith | alaski: so we detect that in nova-manage how? | 17:58 |
| *** tonytan4ever has quit IRC | 17:59 | |
| openstackgerrit | Vladik Romanovsky proposed openstack/nova: adding debug info for pinning calculation https://review.openstack.org/355150 | 17:59 |
| dansmith | alaski: although we still need to ignore the failure status in devstack right? surely you don't want to exit with success for the v1 case right? | 17:59 |
| mriedem | couldn't nova-manage check the config? | 18:00 |
| mriedem | to see if you're running cells? | 18:00 |
| alaski | if we have a parsed config in nova-manage then CONF.cells.enable will work | 18:00 |
| dansmith | yeah, but.. I guess | 18:00 |
| mriedem | ps aux | grep cells | 18:00 |
| mriedem | :) | 18:00 |
| *** dmsimard|afk is now known as dmsimard | 18:01 | |
| dansmith | just sucks to have to always have a full config for some of this, especially for things like cellsv1 which requires different configs in different places | 18:01 |
| mriedem | how about the db? | 18:01 |
| cdent | jroll: is there no ironic v2 thing this week, I forget | 18:01 |
| *** rcernin has joined #openstack-nova | 18:01 | |
| jroll | cdent: just started it, but idk if we have anything to talk about | 18:01 |
| mriedem | there are tables in the db if you're using cells v1 or not right | 18:01 |
| mriedem | ? | 18:01 |
| cdent | jinx | 18:02 |
| alaski | dansmith: that's a fair point on the return code. I have no problem with a devstack skip, was just thinking of being more informative to users if they mistakenly use the simple cmd | 18:02 |
| dansmith | alaski: yeah I think we need both | 18:02 |
| alaski | mriedem: there would be entries in the cells table | 18:02 |
| alaski | but it's really to config that matters. I think you can configure it without any db entries | 18:03 |
| mriedem | well then config it up mothergrabber | 18:03 |
| dansmith | I shall | 18:03 |
| dansmith | we'll be able to merge things in just another few hours | 18:04 |
| * dansmith headdesks | 18:04 | |
| alaski | dansmith: lend infra some of your personal computing resources :) | 18:04 |
| dansmith | heh | 18:05 |
| *** code-R has joined #openstack-nova | 18:06 | |
| *** ociuhandu has quit IRC | 18:07 | |
| *** shaohe_feng has quit IRC | 18:08 | |
| *** shaohe_feng has joined #openstack-nova | 18:09 | |
| *** Hosam has joined #openstack-nova | 18:11 | |
| openstackgerrit | Sean Dague proposed openstack/python-novaclient: WIP: add support for user specified service types https://review.openstack.org/356085 | 18:14 |
| *** code-R has quit IRC | 18:14 | |
| sdague | mriedem: that's a first pass on service type flags on the cli | 18:14 |
| sdague | because, I have a feeling we are going to need it | 18:15 |
| *** cdent has quit IRC | 18:16 | |
| *** lpetrut has joined #openstack-nova | 18:16 | |
| *** shaohe_feng has quit IRC | 18:18 | |
| *** shaohe_feng has joined #openstack-nova | 18:19 | |
| *** jaosorior has joined #openstack-nova | 18:21 | |
| *** chandankumar has quit IRC | 18:24 | |
| *** fragatin_ has quit IRC | 18:24 | |
| *** fragatina has joined #openstack-nova | 18:24 | |
| *** jaosorior has quit IRC | 18:25 | |
| *** tri2sing has quit IRC | 18:27 | |
| *** shaohe_feng has quit IRC | 18:28 | |
| *** baoli has quit IRC | 18:29 | |
| *** baoli has joined #openstack-nova | 18:29 | |
| *** sameo has joined #openstack-nova | 18:29 | |
| *** shaohe_feng has joined #openstack-nova | 18:29 | |
| * dansmith makes a big flushing sound | 18:30 | |
| *** Jeffrey4l has quit IRC | 18:31 | |
| *** ociuhandu has joined #openstack-nova | 18:32 | |
| *** fragatina has quit IRC | 18:35 | |
| *** mvk has quit IRC | 18:38 | |
| *** shaohe_feng has quit IRC | 18:39 | |
| *** shaohe_feng has joined #openstack-nova | 18:39 | |
| *** rlrossit has quit IRC | 18:40 | |
| *** amotoki has joined #openstack-nova | 18:45 | |
| *** jdurgin1 has quit IRC | 18:45 | |
| *** prateek has joined #openstack-nova | 18:46 | |
| *** amotoki has quit IRC | 18:48 | |
| *** su_zhang has quit IRC | 18:49 | |
| *** shaohe_feng has quit IRC | 18:49 | |
| *** shaohe_feng has joined #openstack-nova | 18:49 | |
| *** cdent has joined #openstack-nova | 18:53 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Refuse to run simple_cell_setup on CellsV1 https://review.openstack.org/356097 | 18:53 |
| *** zenoway has joined #openstack-nova | 18:53 | |
| *** prateek_ has joined #openstack-nova | 18:54 | |
| *** prateek has quit IRC | 18:57 | |
| *** tonytan4ever has joined #openstack-nova | 18:58 | |
| *** devkulkarni1 has joined #openstack-nova | 18:59 | |
| siva_krishnan | alaski: thanks for the info. Bug mentions that even if the block device mapping doesn't go through, volume/device tagging should have entry in the table. I am not quite sure if there is way to do it, i thought both we interdependent on each other. Any suggestion would be welcome :) | 18:59 |
| *** shaohe_feng has quit IRC | 18:59 | |
| *** Sukhdev has joined #openstack-nova | 18:59 | |
| mriedem | siva_krishnan: is that the bug that artom reported? | 19:00 |
| *** shaohe_feng has joined #openstack-nova | 19:00 | |
| mriedem | i think it was basically a known issue/gap when doing the 2.32 microversion that we weren't tagging ephemeral bdms | 19:00 |
| siva_krishnan | mriedem: yes | 19:00 |
| mriedem | ok | 19:00 |
| *** edand has joined #openstack-nova | 19:00 | |
| mriedem | i hope that wasn't marked as low-hanging-fruit | 19:00 |
| *** prateek has joined #openstack-nova | 19:01 | |
| *** devkulkarni has quit IRC | 19:01 | |
| *** baoli has quit IRC | 19:01 | |
| alaski | it's not | 19:01 |
| *** prateek_ has quit IRC | 19:02 | |
| *** jichen has joined #openstack-nova | 19:02 | |
| alaski | siva_krishnan: they are interdependent. Being able to tag those will mean adding a bdm entry for them, and it's unclear what the side effects of doing that will be | 19:03 |
| siva_krishnan | mriedem since you confirmed it, i thought i would have a look at it. I was able to create a entry in block_device_mapping table if have volume size mentioned in the API request which shouldn't have an entry for it in the bdm table | 19:04 |
| *** fifieldt has quit IRC | 19:06 | |
| siva_krishnan | mriedem: alaski Sorry my last statement was unclear, I was about to say if volume size is mentioned in the request, I was able to create an bdm entry for epehemeral devices as well | 19:07 |
| *** kfarr has joined #openstack-nova | 19:07 | |
| mriedem | oh right | 19:08 |
| mriedem | yeah forgot about volume size | 19:08 |
| mriedem | it doesn't create the bdm entry in the db if the volume size is 0, but it doesn't fail either | 19:09 |
| *** shaohe_feng has quit IRC | 19:09 | |
| *** shaohe_feng has joined #openstack-nova | 19:10 | |
| *** fragatina has joined #openstack-nova | 19:13 | |
| *** fragatina has quit IRC | 19:13 | |
| siva_krishnan | mriedem Is this the way how it is supposed to work ? | 19:13 |
| *** fragatina has joined #openstack-nova | 19:13 | |
| *** sdake_ has joined #openstack-nova | 19:14 | |
| *** sdake has quit IRC | 19:14 | |
| siva_krishnan | If volume size is not mentioned, hypervisor driver calculates the size and would given a name for it which is why we dont tag it . Am I right ? mriedem | 19:15 |
| *** sdake_ has quit IRC | 19:15 | |
| *** sdake has joined #openstack-nova | 19:16 | |
| *** prateek_ has joined #openstack-nova | 19:16 | |
| mriedem | siva_krishnan: don't know | 19:16 |
| mriedem | what i do know | 19:16 |
| mriedem | is this is awesome http://www.sugarbushsquirrel.com/ | 19:16 |
| *** fifieldt has joined #openstack-nova | 19:19 | |
| cdent | OMG | 19:19 |
| *** prateek has quit IRC | 19:19 | |
| mriedem | legitimate success tag | 19:19 |
| *** shaohe_feng has quit IRC | 19:20 | |
| *** shaohe_feng has joined #openstack-nova | 19:20 | |
| * siva_krishnan likes the tagline "Grab ya nuts and follow me..." | 19:22 | |
| *** xyang1 has quit IRC | 19:29 | |
| *** shaohe_feng has quit IRC | 19:30 | |
| *** code-R has joined #openstack-nova | 19:30 | |
| *** shaohe_feng has joined #openstack-nova | 19:31 | |
| *** code-R_ has joined #openstack-nova | 19:32 | |
| *** parora has joined #openstack-nova | 19:34 | |
| *** code-R has quit IRC | 19:35 | |
| *** tongli has quit IRC | 19:35 | |
| *** prateek_ has quit IRC | 19:37 | |
| *** lpetrut has quit IRC | 19:39 | |
| *** shaohe_feng has quit IRC | 19:40 | |
| *** shaohe_feng has joined #openstack-nova | 19:41 | |
| *** bvanhav has quit IRC | 19:47 | |
| *** mnestratov has quit IRC | 19:50 | |
| *** shaohe_feng has quit IRC | 19:50 | |
| *** shaohe_feng has joined #openstack-nova | 19:51 | |
| *** zenoway has quit IRC | 19:54 | |
| *** zenoway has joined #openstack-nova | 19:55 | |
| *** su_zhang has joined #openstack-nova | 19:55 | |
| *** Apoorva has joined #openstack-nova | 19:55 | |
| *** annegentle has joined #openstack-nova | 19:59 | |
| *** zenoway has quit IRC | 19:59 | |
| *** parora has quit IRC | 20:00 | |
| *** shaohe_feng has quit IRC | 20:01 | |
| *** shaohe_feng has joined #openstack-nova | 20:02 | |
| *** edand has quit IRC | 20:09 | |
| *** matrohon has joined #openstack-nova | 20:09 | |
| *** shaohe_feng has quit IRC | 20:11 | |
| *** shaohe_feng has joined #openstack-nova | 20:12 | |
| *** TravT has quit IRC | 20:19 | |
| *** cdelatte has quit IRC | 20:19 | |
| *** shaohe_feng has quit IRC | 20:21 | |
| *** shaohe_feng has joined #openstack-nova | 20:22 | |
| *** TravT has joined #openstack-nova | 20:22 | |
| *** baoli has joined #openstack-nova | 20:24 | |
| mriedem | sdague: https://review.openstack.org/#/q/status:merged+project:openstack/python-novaclient+branch:master+topic:bp/deprecate-api-proxies are merged, so i'll rebase dan's change on top of that | 20:25 |
| mriedem | if there is anything we want to release before we land dan's change for 2.36 we should probably do that | 20:25 |
| mriedem | Vek: andreykurilin: ^ | 20:25 |
| andreykurilin__ | I'm ok about it | 20:26 |
| *** shaohe_feng has quit IRC | 20:31 | |
| *** tblakes_ has joined #openstack-nova | 20:32 | |
| andreykurilin__ | mriedem: what about keystone related changes? Sorry for asking about them, but I really want to abandon them since nobody is interested in them... | 20:32 |
| *** shaohe_feng has joined #openstack-nova | 20:32 | |
| mriedem | andreykurilin__: so those are just for keystone v3 or to just be using ksa sessions all the time? | 20:33 |
| mriedem | i'm honestly not well versed in keystone things | 20:33 |
| *** gouthamr has quit IRC | 20:33 | |
| andreykurilin__ | mriedem: usage of keystone session instead of own implementation solves several issues. One of them good keystone v3 support | 20:34 |
| *** hemanthm is now known as hemanthm|afk | 20:34 | |
| andreykurilin__ | Keystone folks were ok with these changes | 20:34 |
| mriedem | andreykurilin__: how was the keystone v3 only job passing on novaclient before that change? | 20:34 |
| *** tblakes has quit IRC | 20:35 | |
| *** tblakes_ is now known as tblakes | 20:35 | |
| andreykurilin__ | mriedem: in cli level we already use keystone session | 20:35 |
| andreykurilin__ | And our own httpclient works for base keystone v3 case | 20:35 |
| *** xyang1 has joined #openstack-nova | 20:36 | |
| andreykurilin__ | But in case of specific cases, it fails | 20:37 |
| andreykurilin__ | And nobody wants to maintain HTTPClient | 20:37 |
| andreykurilin__ | I can raise my patches at keystone meeting | 20:37 |
| andreykurilin__ | mriedem: btw, in our functional jobs I made change that creates keystone session and initialized novaclient with it | 20:39 |
| andreykurilin__ | See base class | 20:39 |
| mriedem | andreykurilin__: ok in https://review.openstack.org/#/c/304035/ you need to fix up the release note | 20:41 |
| mriedem | it's not formatting properly | 20:41 |
| *** jamesden_ has joined #openstack-nova | 20:41 | |
| andreykurilin__ | https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/base.py#L201 | 20:42 |
| *** shaohe_feng has quit IRC | 20:42 | |
| mriedem | oh i didn't realize there were 3 changes stacked up here | 20:42 |
| *** shaohe_feng has joined #openstack-nova | 20:43 | |
| andreykurilin__ | Ok, I'll update release notes when I get home | 20:43 |
| andreykurilin__ | Now I'm in karaoke:) lol | 20:43 |
| *** jamesdenton has quit IRC | 20:44 | |
| *** armax has quit IRC | 20:45 | |
| *** cleong has quit IRC | 20:49 | |
| mriedem | uh oh | 20:49 |
| *** shaohe_feng has quit IRC | 20:52 | |
| *** shaohe_feng has joined #openstack-nova | 20:53 | |
| *** xavpaice has left #openstack-nova | 20:53 | |
| *** Apoorva_ has joined #openstack-nova | 20:54 | |
| openstackgerrit | Sarah Ulmer proposed openstack/nova: Remove deprecated security_group_api option https://review.openstack.org/356128 | 20:54 |
| openstackgerrit | Jens Rosenboom proposed openstack/nova: Fix ephemeral disk creation https://review.openstack.org/355415 | 20:54 |
| *** matrohon has quit IRC | 20:55 | |
| *** Apoorva has quit IRC | 20:57 | |
| *** smatzek has quit IRC | 20:58 | |
| *** tonytan4ever has quit IRC | 20:59 | |
| mriedem | sdague: blam -2 https://review.openstack.org/#/c/310722/ | 21:02 |
| mriedem | well, -2 via abandon | 21:02 |
| *** erhudy has quit IRC | 21:02 | |
| *** thorst_ has quit IRC | 21:02 | |
| *** shaohe_feng has quit IRC | 21:02 | |
| *** shaohe_feng has joined #openstack-nova | 21:03 | |
| *** sdague has quit IRC | 21:04 | |
| *** tblakes_ has joined #openstack-nova | 21:07 | |
| *** tblakes has quit IRC | 21:11 | |
| *** tblakes_ is now known as tblakes | 21:11 | |
| *** Apoorva_ has quit IRC | 21:11 | |
| *** Apoorva has joined #openstack-nova | 21:12 | |
| *** shaohe_feng has quit IRC | 21:12 | |
| *** shaohe_feng has joined #openstack-nova | 21:13 | |
| *** matrohon has joined #openstack-nova | 21:18 | |
| *** lpetrut has joined #openstack-nova | 21:19 | |
| *** gyee has quit IRC | 21:20 | |
| *** cdent has quit IRC | 21:21 | |
| *** mvk has joined #openstack-nova | 21:23 | |
| *** shaohe_feng has quit IRC | 21:23 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add BuildRequestList object https://review.openstack.org/356137 | 21:23 |
| openstackgerrit | Andrew Laski proposed openstack/nova: WIP Pull from cell0 and build_requests for instance list https://review.openstack.org/356138 | 21:23 |
| *** gyee has joined #openstack-nova | 21:23 | |
| *** tanvirt has quit IRC | 21:24 | |
| mriedem | Vek: https://review.openstack.org/#/c/295681/ looks like a legit fix that we should keep, maybe you want to take that one over | 21:25 |
| *** shaohe_feng has joined #openstack-nova | 21:26 | |
| *** code-R_ has quit IRC | 21:26 | |
| *** rcernin has quit IRC | 21:27 | |
| mriedem | hmm it's marked opinion/wishlist in the bug report though for some reason | 21:28 |
| mikal | Morning | 21:28 |
| *** matrohon has quit IRC | 21:32 | |
| *** annegentle has quit IRC | 21:32 | |
| *** baoli has quit IRC | 21:33 | |
| *** shaohe_feng has quit IRC | 21:33 | |
| melwitt | mriedem: looks like that was me. I think I was thinking whether it's positional or not is an opinion | 21:34 |
| *** shaohe_feng has joined #openstack-nova | 21:34 | |
| mriedem | melwitt: well flavor is required | 21:34 |
| mriedem | right? | 21:34 |
| mriedem | oh, well, | 21:34 |
| mriedem | BFV... | 21:34 |
| mriedem | but you still provide a flavor when BFV don't you? | 21:35 |
| melwitt | I'm not sure we can change it to a positional parameter because of backward compat but we can make the optional param "required" I think | 21:35 |
| melwitt | yeah, you do | 21:35 |
| melwitt | I'm not sure that would help in the help text though. marking it as required | 21:35 |
| melwitt | (I'm not sure if required optional params get called out nicely in the help) | 21:36 |
| mriedem | we can make backward incompatible changes in a major version bump, if we needed to | 21:36 |
| *** jichen has quit IRC | 21:36 | |
| melwitt | okay. I think at the time we weren't doing major bumps or something, I can't remember. feel free to change it away from wishlist/opinion if it's something you'd like to do in a major bump | 21:37 |
| *** thorst_ has joined #openstack-nova | 21:39 | |
| * melwitt runs to an appointment | 21:41 | |
| mriedem | i don't really care i guess, i just want to clean up the old reviews for novaclient | 21:41 |
| *** shaohe_feng has quit IRC | 21:43 | |
| *** thorst_ has quit IRC | 21:43 | |
| *** shaohe_feng has joined #openstack-nova | 21:44 | |
| *** matrohon has joined #openstack-nova | 21:46 | |
| *** jamesden_ has quit IRC | 21:47 | |
| *** kevinz has joined #openstack-nova | 21:50 | |
| *** annegentle has joined #openstack-nova | 21:51 | |
| *** shaohe_feng has quit IRC | 21:53 | |
| *** thorst_ has joined #openstack-nova | 21:54 | |
| *** shaohe_feng has joined #openstack-nova | 21:54 | |
| *** kevinz has quit IRC | 21:55 | |
| *** annegentle has quit IRC | 21:58 | |
| *** edmondsw has quit IRC | 21:58 | |
| *** shaohe_feng has quit IRC | 22:04 | |
| *** mriedem has quit IRC | 22:04 | |
| *** shaohe_feng has joined #openstack-nova | 22:04 | |
| *** devkulkarni1 has quit IRC | 22:08 | |
| *** burt has quit IRC | 22:08 | |
| *** kfarr has quit IRC | 22:12 | |
| *** chrichip has quit IRC | 22:13 | |
| *** shaohe_feng has quit IRC | 22:14 | |
| *** marst has quit IRC | 22:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs: Amend spec for 'get me a network' https://review.openstack.org/356147 | 22:14 |
| *** shaohe_feng has joined #openstack-nova | 22:15 | |
| *** mdrabe has quit IRC | 22:17 | |
| *** tblakes has quit IRC | 22:24 | |
| *** shaohe_feng has quit IRC | 22:24 | |
| *** shaohe_feng has joined #openstack-nova | 22:25 | |
| *** marst has joined #openstack-nova | 22:27 | |
| *** sdake has quit IRC | 22:27 | |
| *** sdake has joined #openstack-nova | 22:28 | |
| *** dimtruck is now known as zz_dimtruck | 22:29 | |
| *** zz_dimtruck is now known as dimtruck | 22:29 | |
| *** yamahata has quit IRC | 22:31 | |
| *** lpetrut has quit IRC | 22:31 | |
| *** shaohe_feng has quit IRC | 22:34 | |
| *** annegentle has joined #openstack-nova | 22:34 | |
| *** shaohe_feng has joined #openstack-nova | 22:35 | |
| *** dimtruck is now known as zz_dimtruck | 22:39 | |
| *** gouthamr has joined #openstack-nova | 22:39 | |
| *** gouthamr_ has joined #openstack-nova | 22:40 | |
| *** matrohon has quit IRC | 22:40 | |
| *** pwnall has quit IRC | 22:42 | |
| *** gouthamr has quit IRC | 22:44 | |
| *** gouthamr_ is now known as gouthamr | 22:44 | |
| *** shaohe_feng has quit IRC | 22:45 | |
| *** shaohe_feng has joined #openstack-nova | 22:45 | |
| *** thumpba has quit IRC | 22:46 | |
| *** thumpba has joined #openstack-nova | 22:49 | |
| *** thumpba has quit IRC | 22:49 | |
| *** thorst_ is now known as thorst | 22:49 | |
| *** yamahata has joined #openstack-nova | 22:51 | |
| *** burgerk has quit IRC | 22:51 | |
| *** shaohe_feng has quit IRC | 22:55 | |
| *** shaohe_feng has joined #openstack-nova | 22:56 | |
| *** chrichip has joined #openstack-nova | 22:58 | |
| *** thumpba has joined #openstack-nova | 22:59 | |
| *** thumpba has quit IRC | 22:59 | |
| *** thumpba has joined #openstack-nova | 22:59 | |
| *** shaohe_feng has quit IRC | 23:05 | |
| *** shaohe_feng has joined #openstack-nova | 23:06 | |
| *** chrichip has quit IRC | 23:07 | |
| *** bwallis has quit IRC | 23:08 | |
| *** xyang1 has quit IRC | 23:14 | |
| *** shaohe_feng has quit IRC | 23:15 | |
| *** shaohe_feng has joined #openstack-nova | 23:16 | |
| *** thorst has quit IRC | 23:17 | |
| *** thorst has joined #openstack-nova | 23:17 | |
| *** ducttape_ has quit IRC | 23:18 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Change api-site to v2.1 format https://review.openstack.org/356163 | 23:20 |
| *** shaohe_feng has quit IRC | 23:26 | |
| *** thorst has quit IRC | 23:26 | |
| *** shaohe_feng has joined #openstack-nova | 23:26 | |
| *** takashin has joined #openstack-nova | 23:27 | |
| *** shaohe_feng has quit IRC | 23:36 | |
| *** shaohe_feng has joined #openstack-nova | 23:37 | |
| *** thumpba_ has joined #openstack-nova | 23:37 | |
| *** thumpba has quit IRC | 23:39 | |
| *** jklare has quit IRC | 23:39 | |
| *** zz_dimtruck is now known as dimtruck | 23:40 | |
| *** bwallis has joined #openstack-nova | 23:42 | |
| *** jamesdenton has joined #openstack-nova | 23:44 | |
| *** shaohe_feng has quit IRC | 23:46 | |
| *** BjoernT has quit IRC | 23:47 | |
| *** shaohe_feng has joined #openstack-nova | 23:47 | |
| *** bswartz has quit IRC | 23:49 | |
| *** annegentle has quit IRC | 23:50 | |
| *** ihrachys has joined #openstack-nova | 23:50 | |
| *** Hosam has quit IRC | 23:51 | |
| *** shaohe_feng has quit IRC | 23:56 | |
| *** shaohe_feng has joined #openstack-nova | 23:57 | |
| *** ducttape_ has joined #openstack-nova | 23:57 | |
| oomichi | alex_xu: hi, https://bugs.launchpad.net/nova/+bug/1606740 exists in long-term, I guess. How did you know that? | 23:58 |
| openstack | Launchpad bug 1606740 in OpenStack Compute (nova) "The schema of quota's update isn't include networks quota" [High,In progress] - Assigned to Alex Xu (xuhj) | 23:58 |
| *** jklare has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!