Wednesday, 2016-07-27

*** baoli has joined #openstack-nova00:00
*** sameo has quit IRC00:01
*** browne has quit IRC00:01
sdaguegmann: done, thanks00:07
gmannsdague: Thanks :)00:07
*** shaohe_feng has quit IRC00:08
*** shaohe_feng has joined #openstack-nova00:09
sdaguegmann / alex_xu - https://review.openstack.org/#/c/324068/ is probably in a close enough form that if anyone wanted to start digging in on implementation, we could get the spec and patch landed this week00:09
sdagueabout to head off for the night, but thought I'd bring that one back to the forefront. We should probably talk about it during the API meeting tomorrow as well00:09
*** baoli has quit IRC00:11
gmannsdague: Thanks. i will check that.00:11
*** hoangcx2 has quit IRC00:11
*** MikeG451_ has quit IRC00:12
*** jamielennox is now known as jamielennox|away00:12
*** baoli has joined #openstack-nova00:13
*** eil397 has quit IRC00:14
*** sdague has quit IRC00:16
*** shaohe_feng has quit IRC00:18
*** shaohe_feng has joined #openstack-nova00:19
*** dimtruck is now known as zz_dimtruck00:19
oomichigmann: hi, did you read https://review.openstack.org/#/c/324068/3/specs/newton/approved/user_id_based_policy_enforcement.rst ?00:21
*** rama_y has joined #openstack-nova00:21
oomichigmann: I could not catch sdague before his today work finishing00:22
gmannoomichi: reading the same as pointed by sdague too00:22
*** jamespd_ has left #openstack-nova00:22
gmannoomichi: of that spec?00:22
oomichigmann: yeah. line 7700:22
oomichigmann: on the spec, users can reboot servers which are owned by different users?00:23
*** baoli has quit IRC00:23
oomichigmann: means the user policy is not checked on reboot action?00:23
oomichigmann:00:25
oomichigmann: I will put some comments on that anyways00:25
gmannoomichi: i do think so00:25
gmannoomichi: sorry do->do not00:26
oomichigmann: the user policy should be checked on the reboot action?00:26
oomichigmann: if so, I agree with that00:27
*** diogogmt has quit IRC00:27
*** zz_dimtruck is now known as dimtruck00:28
*** shaohe_feng has quit IRC00:28
*** erlon has joined #openstack-nova00:29
*** nic has quit IRC00:29
*** shaohe_feng has joined #openstack-nova00:29
*** armax has quit IRC00:29
gmannoomichi: actually line are not much clear but after reading 2-3 times, i understand reboot operation will check the user_id along with other destructive actions00:30
*** Swami has quit IRC00:31
*** armax has joined #openstack-nova00:34
*** TravT has quit IRC00:34
*** rama_y has quit IRC00:35
*** thorst has joined #openstack-nova00:36
*** hoangcx has joined #openstack-nova00:38
*** shaohe_feng has quit IRC00:38
*** shaohe_feng has joined #openstack-nova00:39
*** code-R has joined #openstack-nova00:42
*** thorst has quit IRC00:42
*** thorst has joined #openstack-nova00:43
*** code-R_ has joined #openstack-nova00:44
*** sdake_ has quit IRC00:45
*** code-R has quit IRC00:47
*** sdake has joined #openstack-nova00:47
*** tonytan4ever has joined #openstack-nova00:47
*** code-R_ has quit IRC00:48
*** mtanin___ has quit IRC00:48
*** shaohe_feng has quit IRC00:49
*** code-R has joined #openstack-nova00:49
*** shaohe_feng has joined #openstack-nova00:49
*** zhs__ has joined #openstack-nova00:51
*** Sukhdev has quit IRC00:52
*** hieulq has quit IRC00:52
*** tonytan4ever has quit IRC00:53
*** zhs_ has quit IRC00:54
*** hoangcx2 has joined #openstack-nova00:54
*** ducttape_ has quit IRC00:54
*** ducttape_ has joined #openstack-nova00:56
*** oomichi has quit IRC00:57
*** shaohe_feng has quit IRC00:59
*** shaohe_feng has joined #openstack-nova01:00
*** hoangcx2 has quit IRC01:01
*** hoangcx2 has joined #openstack-nova01:02
*** sdake has quit IRC01:04
*** kaisers_ has joined #openstack-nova01:06
*** shaohe_feng has quit IRC01:09
*** shaohe_feng has joined #openstack-nova01:10
*** kaisers_ has quit IRC01:11
openstackgerritAnush Krishnamurthy proposed openstack/nova: Improve consistency in cert  https://review.openstack.org/33265001:11
*** ijw has joined #openstack-nova01:14
*** ducttape_ has quit IRC01:17
*** Apoorva has quit IRC01:18
*** dimtruck is now known as zz_dimtruck01:19
*** shaohe_feng has quit IRC01:19
*** shaohe_feng has joined #openstack-nova01:20
*** hoangcx2 has quit IRC01:23
*** hoangcx2 has joined #openstack-nova01:24
*** ijw has quit IRC01:25
*** ljxiash has joined #openstack-nova01:27
*** shaohe_feng has quit IRC01:30
*** kevin_zh has joined #openstack-nova01:30
*** shaohe_feng has joined #openstack-nova01:30
*** ljxiash has quit IRC01:32
*** ljxiash has joined #openstack-nova01:33
*** openstackgerrit has quit IRC01:33
*** openstackgerrit has joined #openstack-nova01:34
*** hoangcx2 has quit IRC01:34
*** TravT has joined #openstack-nova01:35
*** hoangcx2 has joined #openstack-nova01:36
*** woodster_ has quit IRC01:39
*** shaohe_feng has quit IRC01:40
*** shaohe_feng has joined #openstack-nova01:41
*** baoli has joined #openstack-nova01:41
*** jwcroppe has quit IRC01:42
*** jaypipes has quit IRC01:43
*** mingyu has joined #openstack-nova01:43
openstackgerritAlex Xu proposed openstack/nova: Add networks to quota's update json-schema when network quota enabled  https://review.openstack.org/34758801:45
*** ljxiash has quit IRC01:46
*** zz_dimtruck is now known as dimtruck01:47
*** thorst has quit IRC01:48
*** ljxiash has joined #openstack-nova01:48
*** thorst has joined #openstack-nova01:48
*** tonytan4ever has joined #openstack-nova01:49
*** shaohe_feng has quit IRC01:50
*** hoangcx2 has quit IRC01:51
*** ljxiash has quit IRC01:53
*** shaohe_feng has joined #openstack-nova01:53
*** tonytan4ever has quit IRC01:53
*** ljxiash has joined #openstack-nova01:54
*** mingyu has quit IRC01:54
*** thorst has quit IRC01:57
*** TravT has quit IRC01:59
openstackgerritAlex Xu proposed openstack/nova: Remove the useless version calculation for proxy api deprecated version  https://review.openstack.org/34759302:00
*** shaohe_feng has quit IRC02:00
*** shaohe_feng has joined #openstack-nova02:01
openstackgerritHironori Shiina proposed openstack/nova: Allow empty CPU info of hypervisors  https://review.openstack.org/34686802:02
*** TravT has joined #openstack-nova02:03
*** coolsvap_ has joined #openstack-nova02:04
*** thorst has joined #openstack-nova02:06
*** thorst has quit IRC02:06
openstackgerritliuxiuli proposed openstack/nova: Modify request numa_topology when resize  https://review.openstack.org/34027002:09
*** armax has quit IRC02:10
*** shaohe_feng has quit IRC02:11
*** shaohe_feng has joined #openstack-nova02:11
*** sdake has joined #openstack-nova02:12
*** eliqiao has quit IRC02:12
*** eliqiao has joined #openstack-nova02:12
*** TravT has quit IRC02:12
*** baoli has quit IRC02:17
*** TravT has joined #openstack-nova02:18
*** shaohe_feng has quit IRC02:21
*** shaohe_feng has joined #openstack-nova02:21
*** salv-orl_ has quit IRC02:21
*** StevenK has joined #openstack-nova02:22
*** unicell has quit IRC02:23
*** lixiaoy1 has quit IRC02:23
*** Jeffrey4l has joined #openstack-nova02:26
openstackgerritTakashi NATSUME proposed openstack/nova: Add a hacking rule for string interpolation at logging  https://review.openstack.org/33484402:30
*** shaohe_feng has quit IRC02:31
*** baoli has joined #openstack-nova02:32
*** shaohe_feng has joined #openstack-nova02:34
*** yamahata has quit IRC02:34
*** tonytan4ever has joined #openstack-nova02:35
*** mingyu has joined #openstack-nova02:39
*** jamielennox|away is now known as jamielennox02:41
*** shaohe_feng has quit IRC02:41
*** TravT has quit IRC02:42
*** shaohe_feng has joined #openstack-nova02:42
*** ducttape_ has joined #openstack-nova02:48
*** TravT has joined #openstack-nova02:51
*** shaohe_feng has quit IRC02:52
*** zerda2 has joined #openstack-nova02:52
*** baoli has quit IRC02:52
*** shaohe_feng has joined #openstack-nova02:53
*** ljxiash has quit IRC02:53
*** sdake has quit IRC02:53
*** ducttape_ has quit IRC02:53
*** kaisers_ has joined #openstack-nova02:55
*** ljxiash has joined #openstack-nova02:56
*** ljxiash has quit IRC02:58
*** ljxiash has joined #openstack-nova02:59
*** kaisers_ has quit IRC02:59
*** TravT has quit IRC03:00
*** shaohe_feng has quit IRC03:02
*** shaohe_feng has joined #openstack-nova03:02
*** gyee has quit IRC03:03
*** TravT has joined #openstack-nova03:05
*** thorst has joined #openstack-nova03:07
*** baoli has joined #openstack-nova03:10
*** mingyu has quit IRC03:10
*** mingyu has joined #openstack-nova03:11
*** abalutoiu_ has joined #openstack-nova03:12
*** shaohe_feng has quit IRC03:12
*** sdake has joined #openstack-nova03:12
*** shaohe_feng has joined #openstack-nova03:13
*** TravT has quit IRC03:14
*** thumpba has joined #openstack-nova03:15
*** abalutoiu has quit IRC03:15
*** mingyu has quit IRC03:15
*** thorst has quit IRC03:16
*** baoli has quit IRC03:17
*** thumpba has quit IRC03:18
*** TravT has joined #openstack-nova03:19
*** mingyu has joined #openstack-nova03:19
*** ljxiash has quit IRC03:20
*** salv-orlando has joined #openstack-nova03:22
*** shaohe_feng has quit IRC03:22
*** shaohe_feng has joined #openstack-nova03:23
*** RuiChen has joined #openstack-nova03:24
*** ljxiash has joined #openstack-nova03:26
*** erlon has quit IRC03:26
*** salv-orlando has quit IRC03:28
openstackgerritJianghua Wang proposed openstack/nova-specs: Xenapi: a new VDI store via streaming  https://review.openstack.org/27404503:28
*** eliqiao has quit IRC03:29
*** ljxiash has quit IRC03:30
*** eliqiao has joined #openstack-nova03:31
*** ducttape_ has joined #openstack-nova03:31
*** TravT has quit IRC03:33
*** shaohe_feng has quit IRC03:33
*** shaohe_feng has joined #openstack-nova03:33
*** TravT has joined #openstack-nova03:34
*** TravT has quit IRC03:35
*** TravT has joined #openstack-nova03:35
*** ducttape_ has quit IRC03:36
*** oanson has joined #openstack-nova03:40
*** shaohe_feng has quit IRC03:43
*** shaohe_feng has joined #openstack-nova03:44
*** dikonoor has joined #openstack-nova03:46
*** sheel has joined #openstack-nova03:48
*** harlowja_at_home has joined #openstack-nova03:52
*** shaohe_feng has quit IRC03:53
*** links has joined #openstack-nova03:54
*** shaohe_feng has joined #openstack-nova03:54
*** tbachman has joined #openstack-nova03:57
*** lpetrut has joined #openstack-nova03:59
*** dimtruck is now known as zz_dimtruck03:59
*** oanson has quit IRC04:00
*** thumpba has joined #openstack-nova04:00
*** unicell has joined #openstack-nova04:02
*** shaohe_feng has quit IRC04:03
*** thumpba has quit IRC04:06
*** shaohe_feng has joined #openstack-nova04:06
*** kaisers_ has joined #openstack-nova04:07
*** kaisers_ has quit IRC04:07
*** links has quit IRC04:09
*** wcriswelc has joined #openstack-nova04:11
*** stewie925 has quit IRC04:12
*** links has joined #openstack-nova04:12
*** xenogear has quit IRC04:13
*** shaohe_feng has quit IRC04:14
*** wcriswell has quit IRC04:14
*** shaohe_feng has joined #openstack-nova04:14
*** thumpba has joined #openstack-nova04:15
*** thorst has joined #openstack-nova04:15
*** RuiChen has quit IRC04:18
*** diga has joined #openstack-nova04:18
*** sree has joined #openstack-nova04:20
*** thorst has quit IRC04:21
*** harlowja_at_home has quit IRC04:22
*** ljxiash has joined #openstack-nova04:23
*** salv-orlando has joined #openstack-nova04:24
*** shaohe_feng has quit IRC04:24
*** shaohe_feng has joined #openstack-nova04:25
*** TravT has quit IRC04:25
*** thumpba has quit IRC04:27
*** stewie925 has joined #openstack-nova04:27
*** ljxiash has quit IRC04:27
*** TravT has joined #openstack-nova04:28
*** salv-orlando has quit IRC04:28
*** lpetrut has quit IRC04:30
*** jamielennox is now known as jamielennox|away04:30
*** bks has joined #openstack-nova04:31
*** vishwanathj has quit IRC04:32
*** chandankumar has joined #openstack-nova04:33
*** liverpooler has quit IRC04:34
*** shaohe_feng has quit IRC04:34
*** shaohe_feng has joined #openstack-nova04:35
*** thumpba has joined #openstack-nova04:36
*** GB21 has joined #openstack-nova04:39
*** shaohe_feng has quit IRC04:44
*** shaohe_feng has joined #openstack-nova04:45
*** mingyu has quit IRC04:47
*** TravT has quit IRC04:47
*** TravT has joined #openstack-nova04:51
*** jamielennox|away is now known as jamielennox04:51
*** shaohe_feng has quit IRC04:55
*** shaohe_feng has joined #openstack-nova04:55
*** ducttape_ has joined #openstack-nova04:57
*** yamahata has joined #openstack-nova05:00
*** adisky has joined #openstack-nova05:00
*** ducttape_ has quit IRC05:02
*** GB21 has quit IRC05:03
*** GB21 has joined #openstack-nova05:03
*** takedakn has joined #openstack-nova05:04
*** mingyu has joined #openstack-nova05:04
*** ratailor has joined #openstack-nova05:05
*** TravT has quit IRC05:05
*** shaohe_feng has quit IRC05:05
*** shaohe_feng has joined #openstack-nova05:06
*** moshele has joined #openstack-nova05:08
*** pbandark has joined #openstack-nova05:08
*** takedakn has quit IRC05:09
*** TravT has joined #openstack-nova05:09
*** TravT has quit IRC05:14
*** browne has joined #openstack-nova05:14
*** salv-orlando has joined #openstack-nova05:14
*** shaohe_feng has quit IRC05:15
*** shaohe_feng has joined #openstack-nova05:16
*** ekuris has joined #openstack-nova05:17
*** moshele has quit IRC05:19
*** thorst has joined #openstack-nova05:20
*** browne has quit IRC05:20
openstackgerritTaku Izumi proposed openstack/nova-specs: libvirt: Time synchronization with qemu guest agent when resuming VM  https://review.openstack.org/34762505:21
*** maestropandy has joined #openstack-nova05:21
*** ljxiash has joined #openstack-nova05:24
*** oanson has joined #openstack-nova05:24
*** GB21 has quit IRC05:25
*** shaohe_feng has quit IRC05:25
*** thorst has quit IRC05:26
*** beagles has quit IRC05:26
*** shaohe_feng has joined #openstack-nova05:26
*** GB21 has joined #openstack-nova05:27
*** bks has quit IRC05:29
*** ljxiash has quit IRC05:29
*** muawiakhan has joined #openstack-nova05:31
*** shaohe_feng has quit IRC05:36
*** shaohe_feng has joined #openstack-nova05:37
*** jianghuaw has joined #openstack-nova05:37
*** ecelik has joined #openstack-nova05:37
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Adjust MySQL access with eventlet  https://review.openstack.org/33809305:40
*** mingyu has quit IRC05:45
*** shaohe_feng has quit IRC05:46
*** shaohe_feng has joined #openstack-nova05:47
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Remove deprecated configuration option network_device_mtu  https://review.openstack.org/31954305:48
*** GB21 has quit IRC05:49
*** ljxiash has joined #openstack-nova05:50
*** GB21 has joined #openstack-nova05:51
*** hieulq has joined #openstack-nova05:52
*** EinstCrazy has joined #openstack-nova05:53
*** maestropandy has quit IRC05:54
*** edand has joined #openstack-nova05:55
*** coolsvap_ is now known as coolsvap05:56
*** shaohe_feng has quit IRC05:56
*** shaohe_feng has joined #openstack-nova05:57
*** EinstCrazy has quit IRC05:58
*** unicell has quit IRC05:58
*** ducttape_ has joined #openstack-nova05:58
*** thorst has joined #openstack-nova06:01
*** EinstCrazy has joined #openstack-nova06:02
*** unicell has joined #openstack-nova06:02
*** nkrinner_afk is now known as nkrinner06:02
*** ducttape_ has quit IRC06:02
*** mingyu has joined #openstack-nova06:06
*** shaohe_feng has quit IRC06:06
*** shaohe_feng has joined #openstack-nova06:07
*** thorst has quit IRC06:08
*** edand has quit IRC06:09
*** EinstCra_ has joined #openstack-nova06:12
*** code-R has quit IRC06:12
*** code-R has joined #openstack-nova06:13
*** tbachman has quit IRC06:13
*** GB21 has quit IRC06:15
*** GB21 has joined #openstack-nova06:16
*** EinstCrazy has quit IRC06:16
*** sdake has quit IRC06:16
*** shaohe_feng has quit IRC06:17
*** shaohe_feng has joined #openstack-nova06:18
*** GB21 has quit IRC06:21
*** moshele has joined #openstack-nova06:25
openstackgerritTaku Izumi proposed openstack/nova-specs: libvirt: Time synchronization with qemu guest agent when resuming VM  https://review.openstack.org/34762506:26
*** abalutoiu_ has quit IRC06:26
*** shaohe_feng has quit IRC06:27
*** shaohe_feng has joined #openstack-nova06:27
*** salv-orl_ has joined #openstack-nova06:28
*** salv-orlando has quit IRC06:31
*** liverpooler has joined #openstack-nova06:31
*** shaohe_feng has quit IRC06:37
*** shaohe_feng has joined #openstack-nova06:38
*** GB21 has joined #openstack-nova06:40
*** tesseract- has joined #openstack-nova06:44
*** abalutoiu has joined #openstack-nova06:45
*** sdake has joined #openstack-nova06:45
*** rcernin has joined #openstack-nova06:47
*** cfriesen_ has quit IRC06:47
*** shaohe_feng has quit IRC06:47
*** shaohe_feng has joined #openstack-nova06:48
*** maestropandy has joined #openstack-nova06:48
*** ameade has quit IRC06:49
*** zhiyan has quit IRC06:49
*** briancurtin has quit IRC06:49
*** ildikov has quit IRC06:50
*** ildikov has joined #openstack-nova06:51
*** briancurtin has joined #openstack-nova06:52
*** zhiyan has joined #openstack-nova06:52
*** ameade has joined #openstack-nova06:52
*** thumpba has quit IRC06:53
*** nkrinner has quit IRC06:54
*** nkrinner has joined #openstack-nova06:57
openstackgerritChen Fan proposed openstack/nova: context: change the name 'rule' to 'action' in context.can  https://review.openstack.org/34765106:58
*** shaohe_feng has quit IRC06:58
*** mjura has joined #openstack-nova06:58
*** shaohe_feng has joined #openstack-nova06:58
*** ljxiash has quit IRC06:59
*** ducttape_ has joined #openstack-nova06:59
*** sdake has quit IRC07:01
*** cfriesen_ has joined #openstack-nova07:03
*** ducttape_ has quit IRC07:03
*** nkrinner has quit IRC07:05
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334507:07
*** thorst has joined #openstack-nova07:08
*** shaohe_feng has quit IRC07:08
openstackgerritMANJUNATH PATIL proposed openstack/nova: Handling devname exception in PCI whitelist.  https://review.openstack.org/34592507:08
*** sridharg has joined #openstack-nova07:08
*** shaohe_feng has joined #openstack-nova07:09
*** diga has quit IRC07:11
*** thorst has quit IRC07:14
*** markus_z has joined #openstack-nova07:15
*** thumpba has joined #openstack-nova07:15
*** ljxiash has joined #openstack-nova07:15
*** nkrinner has joined #openstack-nova07:18
*** thumpba has quit IRC07:18
*** shaohe_feng has quit IRC07:18
*** shaohe_feng has joined #openstack-nova07:19
*** amotoki has joined #openstack-nova07:19
*** vdrok has quit IRC07:22
*** mingyu has quit IRC07:22
*** vdrok has joined #openstack-nova07:23
*** salv-orlando has joined #openstack-nova07:25
*** salv-orl_ has quit IRC07:25
*** shaohe_feng has quit IRC07:28
*** andreas_s has joined #openstack-nova07:29
*** shaohe_feng has joined #openstack-nova07:29
*** sc68cal has quit IRC07:33
*** sc68cal has joined #openstack-nova07:33
*** jlanoux has joined #openstack-nova07:34
*** isq_ has quit IRC07:34
*** isq_ has joined #openstack-nova07:34
*** hemnafk has quit IRC07:35
*** adreznec has quit IRC07:35
*** diga has joined #openstack-nova07:35
*** andrearosa has quit IRC07:35
*** hemnafk has joined #openstack-nova07:35
*** andrearosa has joined #openstack-nova07:35
*** mtreinish has quit IRC07:36
*** mtreinish has joined #openstack-nova07:36
*** code-R has quit IRC07:37
*** jogo has quit IRC07:38
*** rdo has quit IRC07:38
*** code-R has joined #openstack-nova07:38
*** maestropandy has quit IRC07:38
*** xenogear has joined #openstack-nova07:39
*** shaohe_feng has quit IRC07:39
*** shaohe_feng has joined #openstack-nova07:39
*** adreznec has joined #openstack-nova07:39
*** lennyb has quit IRC07:40
*** jogo has joined #openstack-nova07:40
*** lennyb has joined #openstack-nova07:41
openstackgerritChen Fan proposed openstack/nova: policy: verifying forced_host's target should have self.project_id  https://review.openstack.org/34767307:41
*** takedakn has joined #openstack-nova07:42
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/33199607:47
*** shaohe_feng has quit IRC07:49
*** shaohe_feng has joined #openstack-nova07:49
bauzasgood morning Nova07:56
*** tonytan4ever has quit IRC07:58
*** GB21 has quit IRC07:58
*** tonytan4ever has joined #openstack-nova07:59
*** shaohe_feng has quit IRC07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** ducttape_ has joined #openstack-nova08:00
*** shaohe_feng has joined #openstack-nova08:00
*** derekh has joined #openstack-nova08:03
*** ducttape_ has quit IRC08:04
*** sameo has joined #openstack-nova08:05
*** chandankumar has quit IRC08:07
*** phschwartz has quit IRC08:08
*** phschwartz has joined #openstack-nova08:08
*** jogo has quit IRC08:09
openstackgerritArtom Lifshitz proposed openstack/nova: NUMA: include orphan threads with policy prefer  https://review.openstack.org/34499208:09
*** ihrachys has joined #openstack-nova08:09
*** shaohe_feng has quit IRC08:09
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
*** shaohe_feng has joined #openstack-nova08:10
*** salv-orlando has quit IRC08:10
*** jdurgin has quit IRC08:11
*** tonytan4ever has quit IRC08:11
*** danpb has joined #openstack-nova08:11
*** thorst has joined #openstack-nova08:11
*** chandankumar has joined #openstack-nova08:11
openstackgerritArtom Lifshitz proposed openstack/nova: NUMA: fix require policy assume 2 threads per core  https://review.openstack.org/34620708:11
*** jogo has joined #openstack-nova08:11
*** salv-orlando has joined #openstack-nova08:12
*** yassine has joined #openstack-nova08:12
*** jdurgin has joined #openstack-nova08:12
*** yassine is now known as Guest988808:13
*** hoonetorg has quit IRC08:13
*** gszasz has joined #openstack-nova08:15
*** jlanoux has quit IRC08:16
*** jlanoux has joined #openstack-nova08:16
*** RuiChen has joined #openstack-nova08:17
*** hoonetorg has joined #openstack-nova08:17
*** salv-orlando has quit IRC08:17
*** thorst has quit IRC08:18
*** mingyu has joined #openstack-nova08:18
*** shaohe_feng has quit IRC08:20
*** shaohe_feng has joined #openstack-nova08:20
*** code-R has quit IRC08:21
*** hshiina has joined #openstack-nova08:22
*** diga has quit IRC08:24
*** lucas-dinner is now known as lucasagomes08:24
*** sudipto has joined #openstack-nova08:25
*** shaohe_feng has quit IRC08:30
*** shaohe_feng has joined #openstack-nova08:30
*** takedakn1 has joined #openstack-nova08:33
*** takedakn has quit IRC08:33
*** takedakn1 is now known as takedakn08:33
*** shaohe_feng has quit IRC08:40
*** shaohe_feng has joined #openstack-nova08:40
lyarwoodMorning all, I'm looking for core reviews on https://review.openstack.org/#/c/318266/ if anyone has the time this morning.08:41
*** priteau has joined #openstack-nova08:43
*** rdo has joined #openstack-nova08:44
*** efoley has joined #openstack-nova08:44
*** EinstCra_ has quit IRC08:45
*** EinstCrazy has joined #openstack-nova08:46
*** efoley_ has joined #openstack-nova08:46
*** zhangjn has quit IRC08:47
*** EinstCrazy has quit IRC08:47
*** EinstCrazy has joined #openstack-nova08:47
*** roeyc has joined #openstack-nova08:49
*** efoley has quit IRC08:49
*** shaohe_feng has quit IRC08:50
*** shaohe_feng has joined #openstack-nova08:51
*** zhangjn has joined #openstack-nova08:52
*** GB21 has joined #openstack-nova08:53
openstackgerritArtom Lifshitz proposed openstack/nova: Call release_dhcp via RPC to ensure correct host  https://review.openstack.org/32536108:53
artomlyarwood, your time zone condemns you :)08:55
*** bks has joined #openstack-nova08:56
artomLooking at that review, mriedem and dansmith are involved, you might have a better chance if you catch them when they wake up08:56
lyarwoodartom: haha yeah, that or they are all hiding108:56
*** priteau has quit IRC08:57
lyarwoodartom: yeah, just wanted to get some additional eyes on it now while I'm around to sort any issues out08:57
* lyarwood has a growing backlog of bugfixes to get reviewed08:57
lyarwoodartom: why on earth are you awake at this time btw? :D08:57
*** hshiina has quit IRC08:57
openstackgerritChen Fan proposed openstack/nova: policy: verifying forced_host's target should have context.project_id  https://review.openstack.org/34767308:58
artomlyarwood, if you ever find an answer to that question, let me know08:58
lyarwoodartom: ah forgot, kids :)08:59
artomlyarwood, hah, not even, both are sleeping soundly, not that it was ever an issue for the oldest09:00
artomI just... woke up09:00
artomAnd since once I'm awake it takes me hours to get back to sleep...09:00
artomMight as well get some Nova time in, since the day will likely consists of other stuff09:00
*** ducttape_ has joined #openstack-nova09:01
*** tonytan4ever has joined #openstack-nova09:01
*** shaohe_feng has quit IRC09:01
*** shaohe_feng has joined #openstack-nova09:01
openstackgerritPavel Kholkin proposed openstack/nova: test_keypairs_list_for_different_users for v2.10  https://review.openstack.org/34746209:02
artomlyarwood, shoot me a review for one of those bugfixes - I'd be useless on that driver detach patch, but I have time for other endeavours :)09:02
*** tonytan4ever has quit IRC09:05
*** ducttape_ has quit IRC09:05
*** efoley__ has joined #openstack-nova09:07
*** GB21 has quit IRC09:07
*** efoley_ has quit IRC09:09
*** GB21 has joined #openstack-nova09:11
*** fragatina has joined #openstack-nova09:11
*** shaohe_feng has quit IRC09:11
*** fragatina has quit IRC09:11
*** fragatina has joined #openstack-nova09:12
*** shaohe_feng has joined #openstack-nova09:12
*** thorst has joined #openstack-nova09:16
*** EinstCrazy has quit IRC09:17
*** fragatina has quit IRC09:17
*** ljxiash has quit IRC09:19
*** maestropandy has joined #openstack-nova09:19
*** GB21 has quit IRC09:20
*** shaohe_feng has quit IRC09:21
*** shaohe_feng has joined #openstack-nova09:22
*** thorst has quit IRC09:23
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Fix wrong override value of config option vswitch_name  https://review.openstack.org/32869109:24
*** EinstCra_ has joined #openstack-nova09:25
*** fragatina has joined #openstack-nova09:26
*** EinstCra_ has quit IRC09:27
*** EinstCrazy has joined #openstack-nova09:28
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Fix wrong override value of config option proxyclient_address  https://review.openstack.org/32869809:30
lyarwoodartom: yo sorry missed your last, https://review.openstack.org/#/q/status:open+topic:%255Ebug.*+branch:master+owner:%22Lee+Yarwood+%253Clyarwood%2540redhat.com%253E%22 , I'll sort the conflicts out shortly.09:31
*** nherciu has joined #openstack-nova09:31
*** fragatina has quit IRC09:31
*** shaohe_feng has quit IRC09:31
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Use the recreated config disk during a rescue  https://review.openstack.org/33588409:32
*** shaohe_feng has joined #openstack-nova09:32
openstackgerritLee Yarwood proposed openstack/nova: libvirt: Fix the clean up of resize-revert for volume backed instances  https://review.openstack.org/32903009:32
openstackgerritLee Yarwood proposed openstack/nova: compute: Use stashed connector during local deletes  https://review.openstack.org/34095109:32
openstackgerritLee Yarwood proposed openstack/nova: block_device: Make refresh_conn_infos py3 compatible  https://review.openstack.org/34211109:32
*** dansmith has quit IRC09:33
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Make sure config option public_interface with correct override value  https://review.openstack.org/32574909:33
*** dansmith has joined #openstack-nova09:35
*** dansmith is now known as Guest4106909:35
*** ftersin has joined #openstack-nova09:40
*** muawiakhan has quit IRC09:41
*** muawiakhan has joined #openstack-nova09:41
*** EinstCra_ has joined #openstack-nova09:42
*** shaohe_feng has quit IRC09:42
*** shaohe_feng has joined #openstack-nova09:42
*** EinstCrazy has quit IRC09:43
openstackgerritJianghua Wang proposed openstack/nova-specs: XenAPI: support VGPU via passthrough PCI  https://review.openstack.org/28009909:45
*** hoobaman has joined #openstack-nova09:45
hoobamanhi09:45
*** rdo has quit IRC09:45
hoobamani am currently testing qos frontend support in liberty09:45
*** muawiakhan has quit IRC09:45
hoobamanhowever it cannot set these extra specs through horizon, the qos frontend functionality included in horizon does not seem to be libvirt/nova related09:47
hoobamanit only works through nova manage09:47
hoobamanis this normal?09:47
*** liusheng has quit IRC09:47
*** roeyc has quit IRC09:48
*** tangchen has quit IRC09:50
*** tangchen_ has quit IRC09:50
*** yuelongguang has quit IRC09:50
*** shaohe_feng has quit IRC09:52
*** shaohe_feng has joined #openstack-nova09:53
ftersinhoobaman: hi. you probably need to ask it in horizon channel09:56
hoobamanftersin: ok thx for the feedback :)09:57
*** maestropandy has quit IRC09:57
ftersinbtw, recently i successfully set custom extra specs via horizon on liberty09:57
hoobamanftersin: can you share on how you dit this? :)09:57
ftersinon existing flavor click metadata (or edit), then type key name on the left side and key value on the right side09:59
*** muawiakhan has joined #openstack-nova10:00
ftersinthe extra specs key was not related to qos, but it was my custom key10:00
ftersini saw that the pop-up had some pre-existing keys, but did not try to use them10:01
ftersinanyway, i believe this is offtopic here :/10:01
hoobamanftersin: ok many thanks, i look into it10:02
*** shaohe_feng has quit IRC10:02
*** shaohe_feng has joined #openstack-nova10:03
*** tangchen_ has joined #openstack-nova10:04
*** tangchen has joined #openstack-nova10:04
openstackgerritPawel Koniszewski proposed openstack/nova: [libvirt] Remove live_migration_flag & block_migration_flag  https://review.openstack.org/33486010:05
*** mvk has quit IRC10:07
*** muawiakhan has quit IRC10:08
*** edand has joined #openstack-nova10:12
*** shaohe_feng has quit IRC10:12
*** EinstCra_ has quit IRC10:13
*** EinstCrazy has joined #openstack-nova10:13
*** shaohe_feng has joined #openstack-nova10:13
openstackgerritChen Fan proposed openstack/nova: exception: throw a NotFound exception when we don't find the flavor  https://review.openstack.org/34774510:19
openstackgerritGábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests  https://review.openstack.org/34774810:22
*** shaohe_feng has quit IRC10:23
*** thorst has joined #openstack-nova10:23
openstackgerritAlexis Lee proposed openstack/nova: VNC: Strip cookies containing brackets  https://review.openstack.org/34775010:23
*** shaohe_feng has joined #openstack-nova10:24
openstackgerritBalazs Gibizer proposed openstack/nova: doc: fix disk=0 use case in flavor doc  https://review.openstack.org/33903410:26
*** maestropandy has joined #openstack-nova10:27
*** gabor_antal has joined #openstack-nova10:28
*** thorst has quit IRC10:29
*** ociuhandu has joined #openstack-nova10:30
openstackgerritAlexis Lee proposed openstack/nova: VNC: Strip cookies containing brackets  https://review.openstack.org/34775010:31
*** hoangcx has quit IRC10:33
*** shaohe_feng has quit IRC10:33
*** shaohe_feng has joined #openstack-nova10:33
openstackgerritMANJUNATH PATIL proposed openstack/nova: Handling devname exception in PCI whitelist.  https://review.openstack.org/34592510:34
*** mvk has joined #openstack-nova10:38
*** tbachman has joined #openstack-nova10:38
*** Satya_ has joined #openstack-nova10:38
Satya_Hi10:38
*** Satya_ has quit IRC10:39
*** hoangcx has joined #openstack-nova10:41
*** shaohe_feng has quit IRC10:43
*** takedakn has quit IRC10:45
*** shaohe_feng has joined #openstack-nova10:46
*** sudipto has quit IRC10:47
*** yamahata has quit IRC10:48
*** maestropandy has quit IRC10:51
*** shaohe_feng has quit IRC10:53
*** shaohe_feng has joined #openstack-nova10:54
*** yuikotakadamori has joined #openstack-nova11:00
*** mingyu has quit IRC11:03
*** rtheis has joined #openstack-nova11:03
*** shaohe_feng has quit IRC11:04
*** shaohe_feng has joined #openstack-nova11:05
*** mingyu has joined #openstack-nova11:05
*** zhs__ has quit IRC11:08
*** zhs__ has joined #openstack-nova11:09
*** salv-orlando has joined #openstack-nova11:09
*** mingyu has quit IRC11:10
*** roeyc has joined #openstack-nova11:10
*** rmart04 has joined #openstack-nova11:12
*** zerda2 has quit IRC11:12
*** lucasagomes is now known as lucas-hungry11:13
*** shaohe_feng has quit IRC11:14
*** shaohe_feng has joined #openstack-nova11:15
danpbmarkus_z: did you see my Q on the qemu bug about virtlogd11:16
tdurakovhi folks11:18
*** bvanhav has joined #openstack-nova11:18
tdurakovdo we have any guides on api-ref? I wonder how this should be done: https://review.openstack.org/#/c/345652/2/api-ref/source/parameters.yaml11:18
*** hoangcx2 has joined #openstack-nova11:21
*** hoangcx has quit IRC11:21
*** rdo has joined #openstack-nova11:23
artomtdurakov, hrmm, maybe have two block_migration params?11:23
artomOne boolean, pre-2.25, one string, post-2.25?11:23
tdurakovartom: yeah, I was thinking about it, or as alternative  it's possible to mention about the change in description11:24
*** shaohe_feng has quit IRC11:24
*** takedakn has joined #openstack-nova11:25
*** muawiakhan has joined #openstack-nova11:26
openstackgerritYuiko Takada Mori proposed openstack/nova: Move OVSvApp driver to from networking-vsphere repository  https://review.openstack.org/34777211:26
*** thorst has joined #openstack-nova11:26
artomtdurakov, the two params thing might not pass tests, something might complain about duplicate params11:26
artomBut if it works I think I'd prefer that, FWIW11:27
*** shaohe_feng has joined #openstack-nova11:27
tdurakovartom: yes, I haven't found pattern you proposed in current paramseters.yaml, but for me it seems ok11:27
tdurakovif it pass all generations and tests, of course11:27
artomI know in novaclient, when a command line argument had a new key added, that's what I did to reflect the change in the help text: https://review.openstack.org/#/c/299222/20/novaclient/v2/shell.py@44211:28
artomI realize it's a different context entirely, but the larger logic is the same11:28
tdurakovartom, feel free to review:)11:29
artom(In that link specifically, --block-device got a new tag key in 2.32, so I put two --block-device, each with a different help text and wrapped in versioned utils.args)11:29
*** sdague has joined #openstack-nova11:30
kevin_zhdanpb: Hi Daniel, I have sent you  an email about the bug "Nova can't delete instance with nvram", if you have a moment, pls give some comments11:30
*** thorst has quit IRC11:31
kevin_zhdanpb: The title is "Question about : Qemu: don't refuse to undefine a guest with NVRAM file". Big Thanks~11:31
danpb[please just keep discussion on the reviews11:31
*** takedakn has quit IRC11:32
*** ociuhandu has quit IRC11:33
Cassowary_Hi all, does anyone know the reason for, VM resizing time to increase faster if you continuously increase CPU or DISK resources by +1 (e.g. 1-2, 2-3, 3-4, 4-5). Whereas, when you increase from 1 to any other (e.g. 1-2, 1-2, 1,3, 1-4, 1-5) it takes less time in comparison. Can anyone give an explanation for this? I have plotted two graphs.11:33
Cassowary_https://www.dropbox.com/s/5e8xrrctu0rcwx3/CPU%20scaling%20%20-%20continuous%20vs%20increasing%20from%201.png?dl=011:33
Cassowary_https://www.dropbox.com/s/txpkb8k6mpyexv8/CPU%20scaling%20-%20increase%20from%201.png?dl=011:33
Cassowary_The first graph shows the VM CPU resize time (y axis) vs number of vCPUs (x axis) of continuous (blue) and resize from a VM with 1 vCPU (green) scenarios.The second graph shows the VM CPU resize time (y axis) vs number of vCPUs (x axis), when resized from a VM with 1 vCPU at each step (The green line in first graph). The error bars show the standard error of11:33
Cassowary_the gathered values at each step, as I did resize multiple times to get a mean value.11:33
Cassowary_Thanks!11:33
*** shaohe_feng has quit IRC11:34
*** shaohe_feng has joined #openstack-nova11:35
*** ociuhandu has joined #openstack-nova11:35
tdurakovCassowary_: it's strange, because especially cpu resize is only kind of editing domain definition, disk resize is almost the same as qemu-img resize afair11:37
Cassowary_tdurakov: :(11:39
Cassowary_I thought I was missing something here.11:40
kevin_zhdanpb: OK~ I am not sure that for bug 1567807 "nova delete doesn't work with EFI booted VMs", we need to modify Nova to fix it   or    wait for libvirt to change its code(change to "don't refuse to undefine a guest with NVRAM file")?11:40
openstackbug 1567807 in OpenStack Compute (nova) "nova delete doesn't work with EFI booted VMs" [Low,In progress] https://launchpad.net/bugs/1567807 - Assigned to Ching Kuo (gene-kuo)11:40
artomtdurakov, I posted what can only be described as a rant on that review :P11:41
*** diga has joined #openstack-nova11:41
*** shaohe_feng has quit IRC11:45
kevin_zhdanpb: I see you have submited a patch to libvirt for this in 201511:45
*** Sukhdev has joined #openstack-nova11:45
*** shaohe_feng has joined #openstack-nova11:45
danpbkevin_zh: i've commented on the review https://review.openstack.org/#/c/335512/411:46
kevin_zhdanpb: Great ~ Thanks~11:47
*** cdelatte has joined #openstack-nova11:48
*** thorst has joined #openstack-nova11:49
*** erlon has joined #openstack-nova11:51
*** takedakn has joined #openstack-nova11:54
*** shaohe_feng has quit IRC11:55
*** shaohe_feng has joined #openstack-nova11:55
*** thorst has quit IRC11:56
*** rfolco has joined #openstack-nova12:00
*** thorst has joined #openstack-nova12:02
*** ducttape_ has joined #openstack-nova12:03
*** sree has quit IRC12:04
*** ducttape_ has quit IRC12:05
*** kevin_zh is now known as kevinz12:05
*** shaohe_feng has quit IRC12:05
*** ducttape_ has joined #openstack-nova12:06
*** shaohe_feng has joined #openstack-nova12:06
*** rodrigods has quit IRC12:09
*** rodrigods has joined #openstack-nova12:09
markus_zdanpb: yes, I've seen it, thanks for pinging me though. I still have that system, so I should have that command you're asking for somewhere in the qemu logs I guess?12:10
danpbyep12:10
markus_zOK, I'll collect that and update the bug report.12:11
*** andymaier has joined #openstack-nova12:12
*** pradk has joined #openstack-nova12:12
*** aysyd has joined #openstack-nova12:12
*** ratailor has quit IRC12:12
eliqiaohi johnthetubaguy , around?12:13
johnthetubaguyyep yep12:13
eliqiaoalex_xu just noticed me that he can not host today's meeting.12:14
openstackgerritNolwennCauchois proposed openstack/nova: Clean up second ephemeral disk  https://review.openstack.org/34100812:14
eliqiaowould you give a hand? johnthetubaguy12:14
*** ljxiash has joined #openstack-nova12:14
johnthetubaguyhappy to, although sdague might have more context in his head to help drive that.12:15
eliqiaookay, that would be great help. thanks you :)12:15
eliqiaos/s//12:15
*** shaohe_feng has quit IRC12:15
*** maestropandy has joined #openstack-nova12:16
*** shaohe_feng has joined #openstack-nova12:16
*** lucas-hungry is now known as lucasagomes12:17
*** tonytan4ever has joined #openstack-nova12:17
*** ljxiash has quit IRC12:19
*** tonytan4ever has quit IRC12:22
*** ducttape_ has quit IRC12:22
*** claudiub has joined #openstack-nova12:22
openstackgerritJohn Garbutt proposed openstack/nova: Option registration consistency for availability_zone.py  https://review.openstack.org/34446612:22
*** sdake has joined #openstack-nova12:23
openstackgerritArnaud Morin proposed openstack/nova: Add a small debug line to show selection location  https://review.openstack.org/33873612:25
*** shaohe_feng has quit IRC12:26
*** shaohe_feng has joined #openstack-nova12:27
*** yuikotakadamori has quit IRC12:27
openstackgerritJohn Garbutt proposed openstack/nova: Option Consistency for availability_zone.py  https://review.openstack.org/34446612:28
openstackgerritJohn Garbutt proposed openstack/nova: Deprecate barbican options  https://review.openstack.org/31768412:30
*** diga has quit IRC12:31
*** chandankumar has quit IRC12:31
sdaguejohnthetubaguy: after the month of non regular work, I'm not sure I do. But I'll be there :)12:32
*** beagles has joined #openstack-nova12:35
*** shaohe_feng has quit IRC12:36
anush-mikal: could you please take a look at https://review.openstack.org/#/c/332650/ again. tox was failing due to expected carriage return and I made that change between patch 11 & 1212:36
*** shaohe_feng has joined #openstack-nova12:36
*** JoseMello has joined #openstack-nova12:38
*** claudiub|2 has joined #openstack-nova12:39
*** gmann_ has joined #openstack-nova12:40
*** EinstCrazy has quit IRC12:40
*** vishwanathj has joined #openstack-nova12:42
openstackgerritGleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set  https://review.openstack.org/34747912:42
*** claudiub has quit IRC12:43
markus_zdanpb: Do you mean this: http://paste.openstack.org/show/542559/ ?12:43
johnthetubaguygibi: curious if you seen this https://review.openstack.org/#/c/321336/5 I think search light needs a few extra things, and we need searchlight to help with cells, although ironically not for the flavor stuff12:45
*** tbachman has quit IRC12:45
danpbmarkus_z: yes12:46
*** shaohe_feng has quit IRC12:46
*** c64cosmin has joined #openstack-nova12:46
*** shaohe_feng has joined #openstack-nova12:47
*** tbachman has joined #openstack-nova12:49
*** woodster_ has joined #openstack-nova12:49
*** baoli has joined #openstack-nova12:49
gibijohnthetubaguy: looking12:50
*** baoli_ has joined #openstack-nova12:50
johnthetubaguygibi: its for ocata, and I haven't looked yet, but it might be a good source of "notification friends" :)12:51
gibijohnthetubaguy: I reviewd it in May but I will re-review it now12:51
sdaguejohnthetubaguy - https://review.openstack.org/#/c/347430/ is the os-certificates deprecation12:52
sdaguethat we talked about landing at mid cycle12:53
*** efoley__ has quit IRC12:53
johnthetubaguysdague: ah, that came up the other day around some config options12:54
*** baoli has quit IRC12:55
*** sheel has quit IRC12:56
*** ekuris has quit IRC12:56
danpbsean-k-mooney: fyi i requested a new os-vif release https://review.openstack.org/#/c/347808/12:56
*** shaohe_feng has quit IRC12:56
*** shaohe_feng has joined #openstack-nova12:57
johnthetubaguynova-api meeting time over in -413:02
*** oanson has quit IRC13:04
*** tblakeslee has joined #openstack-nova13:05
*** coolsvap is now known as coolsvap_13:07
*** shaohe_feng has quit IRC13:07
*** shaohe_feng has joined #openstack-nova13:07
*** carolynvs has joined #openstack-nova13:07
*** links has quit IRC13:08
*** vgridnev has joined #openstack-nova13:09
*** chandankumar has joined #openstack-nova13:10
*** rlrossit has joined #openstack-nova13:11
*** mdrabe has joined #openstack-nova13:11
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances  https://review.openstack.org/32325013:11
*** carolynvs has quit IRC13:11
*** edmondsw has joined #openstack-nova13:17
sean-k-mooneydanpb: a thanks for letting me know. how does that work? will a bot automatically tag and push the pip package when that is mergered?13:17
*** liverpooler has quit IRC13:17
*** shaohe_feng has quit IRC13:17
openstackgerritPavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update  https://review.openstack.org/25080713:17
danpbsean-k-mooney: once someone approves that review, its all magic :-)13:17
*** shaohe_feng has joined #openstack-nova13:17
sean-k-mooneydanpb: i have previously done release for networking-ovs-dpdk by hand but ok cool. ill keep an eye on the review13:18
*** matrohon has joined #openstack-nova13:18
*** tosky has joined #openstack-nova13:20
*** diana_clarke has joined #openstack-nova13:20
*** adisky has quit IRC13:21
*** akshai has joined #openstack-nova13:21
vgridnevis there a way to use directly nova-network in current upstream without proxies? we (sahara team) had a nova-network job that was creating security groups, but now it's falling with the following logs:13:23
vgridnevhttp://logs.openstack.org/06/347406/3/check/gate-sahara-dsvm-scenario-nova-heat/391bf43/logs/screen-h-eng.txt.gz?level=WARNING13:23
*** xyang1 has joined #openstack-nova13:24
openstackgerritPavel Kholkin proposed openstack/nova: removed db_exc.DBDuplicateEntry in bw_usage_update  https://review.openstack.org/25080713:25
*** cleong has joined #openstack-nova13:26
*** kevinz has quit IRC13:26
sdaguevgridnev: that seems to be talking to neutron13:27
*** shaohe_feng has quit IRC13:27
*** shaohe_feng has joined #openstack-nova13:28
*** admin0 has joined #openstack-nova13:31
*** mriedem has joined #openstack-nova13:31
vgridnevsdague, but actually heat is creating nova client for creating security groups: https://github.com/openstack/heat/blob/master/heat/engine/resources/aws/ec2/security_group.py#L5413:31
admin0hi all .. if nova schedule is slow . where could the bottlenecks be ?13:31
*** david-lyle_ has joined #openstack-nova13:31
*** david-lyle_ has quit IRC13:31
admin0sorry13:31
admin0nova shelve13:31
sdaguevgridnev: the way I read that stack trace is that it's not, it's using neutron client, and there is no neutron endpoint, so it explodes13:32
*** tjones has joined #openstack-nova13:34
*** david-lyle has quit IRC13:34
*** eliqiao has quit IRC13:34
*** ducttape_ has joined #openstack-nova13:36
*** code-R has joined #openstack-nova13:37
*** shaohe_feng has quit IRC13:37
*** shaohe_feng has joined #openstack-nova13:38
*** efried has joined #openstack-nova13:40
*** ayoung has joined #openstack-nova13:41
*** maestropandy has left #openstack-nova13:42
*** eliqiao has joined #openstack-nova13:43
*** shaohe_feng has quit IRC13:48
*** Guest41069 is now known as dansmith13:48
*** shaohe_feng has joined #openstack-nova13:49
*** code-R_ has joined #openstack-nova13:49
*** ecelik has quit IRC13:51
*** code-R has quit IRC13:52
-openstackstatus- NOTICE: Gerrit is being restarted now to relieve performance degradation13:53
*** kevin_zh has joined #openstack-nova13:54
*** takedakn has quit IRC13:55
*** ctrath has joined #openstack-nova13:56
*** Fdaisuke has joined #openstack-nova13:57
lxslidansmith: at the midcycle you said the service version flag needs to be mutable, please can you tell me the exact name of that?13:57
*** shaohe_feng has quit IRC13:58
*** gmann_ has quit IRC13:58
*** dikonoor has quit IRC13:58
dansmithlxsli: service_version is calculated, it's not a flag.. if you see that somewhere someone probably mistyped or misunderstood13:59
*** shaohe_feng has joined #openstack-nova13:59
*** burt has joined #openstack-nova13:59
*** sudipto has joined #openstack-nova13:59
*** rmart04 has quit IRC13:59
johnthetubaguyI guess I was thinking about this one: https://github.com/openstack/nova/blob/master/nova/conf/upgrade_levels.py#L98 but if we get that switched to auto, we should be fine13:59
openstackgerritMark Doffman proposed openstack/nova: Integrate OSprofiler and Nova  https://review.openstack.org/25470314:00
lxslijohnthetubaguy: so 'auto' is smart enough to only upgrade the version once all computes will support it? Neat!14:01
*** kevin_zh has quit IRC14:01
johnthetubaguylxsli: sig_hup triggers the reload of finding the min service version, its cool14:02
*** kevin_zh has joined #openstack-nova14:02
lxsliah I see, OK cool14:02
*** pilgrimstack has joined #openstack-nova14:02
mriedemsdague: seems we should maybe update the wording on this wiki https://wiki.openstack.org/wiki/VersionDiscovery#id14:02
mriedem"Id versions follow semantic versioning and thus backwards compatibility  is implied by a version numbering with the same major version and higher  minor version number. For example an advertised version of "2.3" will  maintain compatibility with of its calls with versions "2.0", "2.1", and  "2.2" as well as all included patch versions.  "14:02
mriedemsince that's not true for 2.3614:03
mriedemor 2.3714:03
sdaguemriedem: probably, that super predates mv14:03
mriedemyeah, it's linked from the api docs though14:03
*** admin0 has quit IRC14:03
sdagueok, which ones?14:03
*** jwcroppe has joined #openstack-nova14:03
*** admin0 has joined #openstack-nova14:03
sdagueand agreed, we should fix that, and pull it all up into rst docs somewhere14:04
mriedemhttp://developer.openstack.org/api-ref.html14:04
*** pilgrimstack1 has quit IRC14:04
mriedem"This version is under development or contains                      features that are otherwise subject to change. For more information                      about API                       status values and version                      information, see Version                         Discovery.                                         "14:04
mriedemyikes14:04
mriedemthe link to 'Version Discovery'14:04
*** code-R_ has quit IRC14:05
sdagueok, that's in the global api-ref, any idea which repo that is in?14:05
sdagueit's very specific to keystone actually, looks like it was basically written by jamielennox14:05
*** code-R has joined #openstack-nova14:05
*** cdent has joined #openstack-nova14:06
*** eliqiao has quit IRC14:06
mikalMorning14:07
*** Swami has joined #openstack-nova14:07
stevemarsdague: mriedem we could move that into the keystone v3 specific APIs14:07
*** code-R_ has joined #openstack-nova14:07
dansmithmikal: ping with fire14:07
mriedemsdague: i assume it's openstack-manuals14:07
mikaldansmith: please not the fire, anything but that!14:07
dansmithheh14:08
*** ababich has quit IRC14:08
mriedemor now api-ref14:08
mriedem*no14:08
mikalSo I talked to gus and he was going to leave some questions on the review, but I haven't had a chance to check that thing yet14:08
mikalBut those questions were minor, and he seemed happy enough14:08
*** shaohe_feng has quit IRC14:08
mriedemhttps://github.com/openstack/api-site/blob/master/api-ref-guides/src/preface.xml14:08
*** eliqiao has joined #openstack-nova14:09
*** shaohe_feng has joined #openstack-nova14:09
*** Swami has quit IRC14:09
*** chandankumar has quit IRC14:10
*** Swami has joined #openstack-nova14:10
*** code-R has quit IRC14:11
openstackgerritJohn Garbutt proposed openstack/nova: Improve help text for floating ips options.  https://review.openstack.org/31830914:11
*** yuelongguang has joined #openstack-nova14:11
*** aswadr_ has joined #openstack-nova14:11
mriedemsdague: stevemar: anyway it's api-site repo14:11
mriedemi'm lost in the xml14:11
*** mingyu has joined #openstack-nova14:13
*** bks has quit IRC14:13
openstackgerritJohn Garbutt proposed openstack/nova: Improve help text for floating ips options.  https://review.openstack.org/31830914:13
*** abalutoiu has quit IRC14:14
bauzasmriedem: I heard about your big stick for people not writing Tempest tests for microversions they provide :)14:14
mriedembauzas: you did?14:14
bauzasmriedem: so, here is the thing, do you think we should Tempest test the behavioural change I made for evacuate and live-migrate in the 2.29 and 2.30 microversions ?14:15
bauzasevacuate is kinda hard stuff for Tempest, nope ?14:15
sdaguebauzas: yeh, you have to take compute service offline14:16
sdagueso.... not really viable in normal runs14:16
dansmithmikal: okay, sounds like gus was missing quite a bit of context14:16
*** roeyc has quit IRC14:16
*** zz_dimtruck is now known as dimtruck14:16
sdaguemikal: right, his primary concern seems to be the venv question14:16
mriedembauzas: tempest tests for features/microversions/things we can test in tempest should be the rule, but there are exceptions14:17
sdaguebut I'm a little confused there, because my code just moves into code the solution that was being pushed with filters changes14:17
sdagueso, if my thing doesn't work, then the other thing didn't either14:17
mriedembauzas: but as i was telling ken'ichi last night, we do a shit job of holding people to the testing they say they'll provide when they write a spec14:17
*** tonytan4ever has joined #openstack-nova14:17
bauzasmriedem: yup, so I think testing evacuate in that precise context is hard14:17
*** ababich has joined #openstack-nova14:17
mriedembauzas: evacuate is something we don't test in tempest, right, so it would get an exception14:18
bauzasmriedem: but I could take a look on how I could test my live-mig change14:18
bauzasie. the 2.30 microversion14:18
mriedembauzas: i think someone already has a tempest patch up for that stuff14:18
mriedembauzas: i'd ask tdurokov14:18
bauzastdurakov: aloha ?14:18
tdurakovbauzas: hi14:18
*** shaohe_feng has quit IRC14:18
dansmithsdague: yeah I think he's confused about that14:19
bauzasmriedem: I like when a plan comes together14:19
sdaguemikal: do you have any further thoughts on that?14:19
sdaguebecause I'm not sure I understand what I'd do differently here14:19
*** shaohe_feng has joined #openstack-nova14:20
bauzastdurakov: see the log, I was wondering if it was worth testing the 2.30 microversion about live-migrations checking the scheduler14:20
tdurakovbauzas: I thought we decided to test every microversion to reduce debt,  but test only latest on gates, right14:21
ababichmriedem: Hi! Please, take a look at https://review.openstack.org/#/c/346966 . It will allow to close bug https://bugs.launchpad.net/nova/+bug/160649614:21
openstackLaunchpad bug 1606496 in OpenStack Compute (nova) "Instance affinity filters do not work in a heterogeneous cloud with Ironic computes " [High,In progress] - Assigned to Roman Podoliaka (rpodolyaka)14:21
tdurakovbauzas: I think mriedem talks about this https://review.openstack.org/#/c/338256/14:21
bauzastdurakov: sure, my point was rather about whether someone already wrote that for me14:21
bauzastdurakov: mmm, that's 2.3314:22
tdurakovbauzas: I haven't seen at least14:22
bauzastdurakov: okay, so I should write one for 2.3014:22
mikalsdague: I think it probably just works. I think he's just saying we need to make sure we test it.14:23
*** rlrossit has quit IRC14:23
dansmithand we did right?14:23
sdaguemikal: ok, but I'm not sure what a valid test is for that, because it's the same paths we already have, and we don't do anything like this in our gate14:23
*** claudiub|2 has quit IRC14:24
sdagueand... I'm not sure which kind of venv config is a valid test here, as that's not part of any deployment model I'm familiar with14:24
*** sudipto has quit IRC14:24
rpodolyakaababich: I'm still working on the follow up change to close it properly, will try to upload it later today or tomorrow14:24
*** tosky has quit IRC14:24
sdagueI wonder if we could move forward with this, get the 5.0.0 out there, and know that if we hit an issue we can spin a 5.0.1 to address14:25
*** andymaier has quit IRC14:25
openstackgerritMaciej Szankin proposed openstack/nova: Improve consistency in API  https://review.openstack.org/33217614:26
mikalSo, OSA (Rckspace's thing) deploys venvs I think14:26
ababichrpodolyaka: tnx for info!14:26
mikalLet me check with them when they come back to their desks14:26
*** anush_ has joined #openstack-nova14:26
*** liverpooler has joined #openstack-nova14:27
mriedemwe also deploy in venvs14:27
openstackgerritMoshe Levi proposed openstack/nova: jsonutils.loads only if hypervisor.cpu_info is not None  https://review.openstack.org/34787014:28
mriedemi have a test env, is there something that needs specific testing?14:28
mriedemi guess pulling in that rootwrap change and using os-brick 4.1.014:28
mriedem?14:28
mikalmriedem: gus wants us to verify that we can run privsep-helper via rootwrap when privsep-helper is in the venv not the system path14:29
*** shaohe_feng has quit IRC14:29
sdaguemikal: but if we can't, then everything is f'ed anyway, right14:29
openstackgerritJim Rollenhagen proposed openstack/nova: Move extra_specs_ops to oslo.utils  https://review.openstack.org/30840314:29
sdaguebecause adding privsep-helper to compute.filters would also fail14:29
*** shaohe_feng has joined #openstack-nova14:30
sdaguethis is the thing I do not understand14:30
sdaguethe path processing is 100% the same as the assumed working model14:30
mikalYeah, I get that. I think it was a last minute "hey we should check"14:30
mikalSo, we should check, but not freak out just yet14:30
sdaguemikal: ok, and if it doesn't work, we delete privsep entirely?14:31
johnthetubaguyif we drop priv sep from our filters in master, would that not test it?14:31
*** gszasz_ has joined #openstack-nova14:31
sdaguejohnthetubaguy: no, it's exactly the same14:31
mikalsdague: yes, and become hermits14:31
sdaguethat's the point, and that's my frustration14:31
mikalsdague: but let's just hold off on that now14:31
sdaguejohnthetubaguy: if this patch is not valid, neither is our entire strategy of putting privsep-helper in compute.filters14:32
dansmithmriedem: sdague: aren't we supposed to not add docstrings on tests? https://review.openstack.org/#/c/325361/7/nova/tests/unit/network/test_manager.py14:32
*** tosky has joined #openstack-nova14:32
sdaguedansmith: no, not any more14:32
sdaguethat was just a nose thing14:32
johnthetubaguysdague: true14:32
*** gszasz has quit IRC14:32
dansmithsdague: meaning we're back to "it's okay to add docstrings" now?14:32
sdaguedansmith: yes14:32
dansmithokay thnaks14:32
sdaguewe should honestly probably try to encourage people to add them14:33
sdaguethey are super helpful some times on refactoring tests14:33
*** chandankumar has joined #openstack-nova14:33
*** artom2 has joined #openstack-nova14:34
dansmithsdague: well, comment blocks serve that purpose too, but anyway14:35
sdaguedansmith: sure, they could be that as well14:35
sdaguebut, some preamble for tests is useful14:35
dansmithyes14:35
sdagueand not using docstrings was just because nose used those instead of test names14:36
sdaguewhich made it much harder to figure out failures14:36
*** kevin_zh is now known as kevinz14:38
*** cgalan has joined #openstack-nova14:39
*** aysyd has quit IRC14:39
*** shaohe_feng has quit IRC14:39
dansmithyep14:39
*** diga has joined #openstack-nova14:39
*** shaohe_feng has joined #openstack-nova14:40
*** ljxiash has joined #openstack-nova14:40
mriedemartom: small thing to fix in that patch14:40
*** siva_krish has joined #openstack-nova14:40
artom2mriedem, which one?14:41
mriedemartom2: https://review.openstack.org/#/c/325361/7/nova/tests/unit/network/test_manager.py14:41
artom2I literally copy pasted the existing test, but OK :)14:41
artom2I'll address it when I'm back home14:41
mikalsdague: so I do think its reasonable to remember that this rootwrap thing was not how gus intended privsep to work, its a hack we added later to work around some things14:43
tonyb.... rootwraps search path comes from exec_dirs in .... etc/nova/rootwrap.conf14:43
sdaguetonyb: or path, if it's not set14:43
*** claudiub|2 has joined #openstack-nova14:43
*** aysyd has joined #openstack-nova14:43
*** abalutoiu has joined #openstack-nova14:44
sdaguetonyb: https://review.openstack.org/#/c/344450/2/oslo_rootwrap/wrapper.py@5214:44
mikalIf PATH is as set for the parent process, it would just work I think14:44
sdaguemikal: yes14:45
sdagueI commented in the review, where that is being calculated14:45
mikalWorst case, can't the deployer write a 2 line shell script which is on the system path that activates a venv and then runs privsep-helper?14:45
*** pbandark has quit IRC14:45
tonybsdague: okay.14:46
sdagueprivsep-helper will need to be installed in the same venv as nova, but as soon as it's in requirements.txt, then it will be14:46
sdaguewhich it will be as soon as we start landing code that can use it14:46
tonybmikal: if PATH is set and there is no exec_dirs in the config14:46
mikalSo I think that means we think we're fine?14:47
mikalAnd could all be a bit less angry at each other?14:47
sdaguemikal: right, that was my point :)14:47
mikalOk, so why no hugs?14:47
dims_pong sdague14:47
mikalHUG ME14:47
* dims_ hugs mikal 14:47
mikalAwww14:47
sdaguemikal: ok, this is where I was starting14:47
dims_:)14:47
tonyb"other duties as required"14:47
sdagueI think that through code inspection, we believe that gus's last bit of -1 is already covered by existing code14:48
*** yamahata has joined #openstack-nova14:48
bauzasjohnthetubaguy: alaski: in case people want to chime in, I have a High prio bugfix for making sure resizes are checking the right flavor https://review.openstack.org/#/c/347387/14:48
sdaguein which case, I'd move to get another +2 on this, land it, get the release out14:48
markus_ztdurakov: did you ever encounter this in the live-migration hooks: http://logs.openstack.org/71/347471/1/check/gate-tempest-dsvm-multinode-live-migration/3e9cb73/console.html#_2016-07-26_16_48_29_475471 ?14:48
sdagueand if there is anything that got missed, we can always fix it in 5.0.114:49
*** ctrath has quit IRC14:49
*** shaohe_feng has quit IRC14:49
sdaguemikal / tonyb: opinions on that?14:49
dims_sdague : mikal : do we want to let https://review.openstack.org/#/c/344450/ in before gus takes his -1 back?14:50
mikalsdague: I need to re-read the review, please hold14:50
dansmithmriedem: the mox usage in there is existing, right? and he's copying the stub_out that is already there14:50
*** shaohe_feng has joined #openstack-nova14:50
sdaguedims_: that's what I'm proposing. I feel like gus put a very specific concern in for the grounds of his -1.14:50
mriedemdansmith: it's a new test14:50
dansmithmriedem: I'd rather he fix the bug and then refactor the tests (or vice versa)14:50
mriedemdansmith: we shouldn't use mox in new tets14:50
dansmithmriedem: but it's a copy of the test above14:50
mriedemdansmith: so?14:50
dansmithmriedem: if he copies a test and rewrites it it's much harder for me to quickly see that it's the same thing14:51
sdagueand that we've verified that the existing code seems to cover that case14:51
* dims_ waiting for mikal to answer14:51
dims_sdague : ack14:51
artom2bauzas, is https://review.openstack.org/#/c/340270/ doing the same thing as your bug fix?14:51
*** ctrath has joined #openstack-nova14:51
mriedemdansmith: it's like one mox14:52
artom2I only have my phone right now, but they look related...14:52
*** code-R_ has quit IRC14:52
*** code-R has joined #openstack-nova14:52
dims_gus : ping in case you are up early14:52
tdurakovmarkus_z: I'd expect that NOVA_CONF is not defined14:52
dims_gus : let's move forward on this please14:52
tdurakovmarkus_z: you could check it by echoing it before calling14:52
tonybI *think* we're good.  My only worry about landing this with gus's -1 are interpersonal rather than technical14:52
*** oanson has joined #openstack-nova14:53
tdurakovor just redefine it NOVA_CONF=${NOVA_CONF:-/etc/nova/nova.conf}14:53
bauzasartom2: kinda related, but I think not the same problem14:53
dims_tonyb : it's 3 lines of code essentially there in that review14:53
markus_ztdurakov: I thought it's defined somewhere before. I'll add a little more echos. Thanks14:53
artom2bauzas, right, that one is for mums only14:54
artom2numa14:54
bauzasheh, mums14:54
artom2OK, I'm out, that's a sign I need to leave14:54
mriedemdansmith: artom2: so L1781 was what showed up in my 5..6 diff, so don't change that test14:54
markus_ztdurakov: dang it, you're right. copy/paste issue14:55
tdurakovmarkus_z: np14:55
artom2mriedem, so... we're good?14:55
dims_tonyb : can you please mark a +1 there?14:55
dansmithmriedem: I'm not sure what you mean, he didn't change that line in the final version14:56
mriedemL1731 is the new change14:56
mriedemi was diffing 5..6 patchsets14:56
mriedemand test_deallocate_fixed_rpc_pinned shows up as a new test14:56
mriedemwith mox, mock and fixtures14:56
tonybdims_: Yeah.14:56
mriedemnow that i just look at patch set 6 by itself, it see it's different14:56
sdaguetonyb: I do get that, but I also think that given the TZ delay we're going to keep grinding here. At least in nova if you -1 with a specific reason, and the rest of the core team realizes the reason is resolved, we just move ahead14:56
sdagueI get that oslo may be different14:57
artom2it is a new test, copied verbatim from an existing one, with one change unrelated to mox mock etc14:57
sdaguebut I also know how much is backed up behind getting this out there14:57
*** mdrabe has quit IRC14:57
dims_sdague : will let this in by end of our day today one way or another14:58
sdagueand it feels like we can definitely fix any edge issues in a follow on to the 5.0.0 release in parallel to unblocking os-brick and os-vif14:58
mriedemartom2: yeah but we also don't like propagating tests that use mox, those are opportunities to get rid of mox usage14:58
mriedemwhich is in the docs14:58
mriedemif this is going to cause a bunch of stress i can drop my -114:58
*** nkrinner has quit IRC14:58
artom2mriedem, like I said, I'll address the feedback :)14:58
mriedem#4 here btw http://docs.openstack.org/infra/manual/developers.html#peer-review14:59
dansmithmriedem: 4.2 covers us IMHO14:59
artom2I suppose it's better to have one test that follows guidelines add opposed to none, even if it's inconsistent14:59
*** coolsvap_ is now known as coolsvap14:59
*** admin0 has quit IRC14:59
artom2*as14:59
dansmithI know 4.3 says change it all up too,14:59
dansmithbut in this case, seeing that they're the same is valuable, IMHO14:59
*** shaohe_feng has quit IRC14:59
artom2OK, really have to bounce now15:00
*** jistr is now known as jistr|call15:00
*** artom2 has quit IRC15:00
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: WIP: live-migration test for serial console  https://review.openstack.org/34747115:00
*** shaohe_feng has joined #openstack-nova15:00
mriedemffs, if this is the difference between the fix merging today or not, then let's just approve it15:00
*** nkrinner has joined #openstack-nova15:00
mriedem+W15:01
mriedemer +215:01
mriedembut we have py3 race failures b/c of mox and because we don't clean house on it, so we're just making more work for ourselves later15:01
dansmithmriedem: I'm refactoring them now15:02
*** admin0 has joined #openstack-nova15:02
alex_xujohnthetubaguy: sdague sorry, i can't make the meeting. a little uncomfortable today. anyway i will check the meeting log later. and will back to work tomorrow if lucky15:04
sdaguealex_xu: no prob, hope you feel better tomorrow15:05
alex_xusdague: thanks15:05
*** mdrabe has joined #openstack-nova15:05
bauzasartom: I'm unclear where the numa related information is passed by the old model when resizing, was that thanks to the flavor ?15:05
*** nkrinner has quit IRC15:08
*** shaohe_feng has quit IRC15:10
*** liverpooler has quit IRC15:10
*** shaohe_feng has joined #openstack-nova15:11
*** rrecio has joined #openstack-nova15:11
*** sridharg has quit IRC15:12
*** syjulian_ has joined #openstack-nova15:13
openstackgerritMaciej Szankin proposed openstack/nova: config options: Improve help for base  https://review.openstack.org/32455915:13
*** gszasz_ has quit IRC15:13
*** mtanino has joined #openstack-nova15:14
*** odyssey4me has joined #openstack-nova15:14
odyssey4meo/15:14
zzzeeklazy nova question:  the database tables in models.BASE and in api_models.API_BASE are mutually exclusive to the "main" and "api" databases, right?15:14
openstackgerritGleb Stepanov proposed openstack/nova: Skip malformed cookies  https://review.openstack.org/34609015:15
odyssey4memikal you had a question about using rootwrap with venvs?15:15
*** kenperkins has joined #openstack-nova15:16
odyssey4meOpenStack-Ansible has been using venvs since Liberty for all services. We implement the venv path as the first in line for the rootwrap config: we ensure that the venv patch is first in line in the rootwrap config: https://github.com/openstack/openstack-ansible-os_nova/blob/master/templates/rootwrap.conf.j2#L1315:16
odyssey4me*path15:16
odyssey4meurgh, my keyboard skills are lacking today15:16
*** pcaruana has quit IRC15:17
sdagueodyssey4me: cool15:18
openstackgerritDan Smith proposed openstack/nova: Refactor deallocate_fixed tests to use one mock approach instead of three  https://review.openstack.org/34789315:18
dansmithmriedem: artom ^15:18
sdagueodyssey4me: makes total sense15:18
sdagueso as soon as privsep is in nova's requirements.txt, it will end up in that path, and all will be good15:19
odyssey4mesdague sounds good to me, as soon as that switch is ready for roader testing feel free to ping me so that we can put up a review to try it out in OSA15:19
diana_clarkedansmith: I15:20
diana_clarkelol15:20
dansmithdiana_clarke: J15:20
sdagueodyssey4me: yeh, we need this rootwrap patch and release, then that code should start flowing in15:20
*** shaohe_feng has quit IRC15:20
*** sudipto has joined #openstack-nova15:20
*** syjulian_ has quit IRC15:20
sdagueif that release happens next week, I'd expect we start landing this stuff next week15:20
*** shaohe_feng has joined #openstack-nova15:21
diana_clarkedansmith: I'm a bit nervous about rebasing mdbooth's entire patch series. Instead I just pushed the change to the bottom patch you wanted.15:21
dansmithdiana_clarke: nervous why?15:21
*** nkrinner has joined #openstack-nova15:22
*** armax has joined #openstack-nova15:22
diana_clarkedansmith: But that might have been a mistake b/c now the ones that follow after don't "line up" in the "related changes" gerrit list.15:22
dansmithdiana_clarke: right, they're all orhaned now15:23
diana_clarkedansmith: nervous because there is some sort of timing issue with large patch series, and after the first couple they will all fail to merge.15:23
*** sudipto has quit IRC15:23
diana_clarkeand then I have to manually recheck them all, unless someone knows a better way15:23
dansmithdiana_clarke: just because the series touches everything15:23
mikalsdague / odyssey4me: So its puppies and kittens the whole way down15:24
dansmithdiana_clarke: if they get into conflict, you need to rebase anyway to really fix it15:24
*** rcernin has quit IRC15:24
sdaguemikal: sounds like15:24
sdaguedims_ just hit the +A button on it15:24
sdagueso now once that is in, we can get the release cut, and start moving on os-brick and os-vif15:25
diana_clarkedansmith: sure, but mdbooth had some scripts that rebased them one at a time so that it didn't trigger the infra timing issue15:25
*** gszasz_ has joined #openstack-nova15:25
diana_clarkedansmith: I should have asked for them b/c I'm not sure how he was getting around it15:25
diana_clarkedansmith: anyhoo, I'll just rebase from the top then, and manually recheck them all when I trigger the timing bug I guess15:26
*** raj_singh_ has joined #openstack-nova15:26
dansmithdiana_clarke: really not sure what "infra timing issue" you're referring to15:26
dansmithdiana_clarke: rebasing them whole stack will run a check on all of them since they're all "new"15:26
*** admin0 has quit IRC15:27
*** GB21 has joined #openstack-nova15:27
diana_clarkeIt's been mentioned here a few times (the known infra timing issue with large patch series). mriedem probably understands what I'm talking about.15:27
bhagyashrimriedem: Hi, could you please take a look at it, https://review.openstack.org/#/c/320787/15:27
*** mjura has quit IRC15:28
*** code-R has quit IRC15:28
diana_clarkedansmith: yes, that's what it *should* do, but in practice they are all going to auto-fail after the fire few in the series15:29
diana_clarkes/fire/first/15:29
dansmithclarkb: fungi: is that a thing? ^15:29
*** andreas_s has quit IRC15:29
fungidiana_clarke: dansmith: that doesn't ring a bell. can you elaborate?15:30
*** shaohe_feng has quit IRC15:30
dansmitheither way, that series is large enough that by the time we merge the next few, we'll have to rebase it anyway I expect15:31
fungithe only issue i'm aware of breaking large patch series is that if they're all approved together then the jgit in gerrit has trouble with n-way octopus merges come time to finally merge them into the branch after passing15:31
*** shaohe_feng has joined #openstack-nova15:31
mriedemis there some magic incantation to getting glanceclient debug logs on nova-compute? i thought setting the default_log_levels config option would do it, but apparently not15:32
mriedemplus sending debug=True when creating glanceclient15:32
fungiso you'll get the first 4 or so merged, and then gerrit will report a merge conflict on the next one because jgit's merge conflict resolution is terribad, and then the changes that all depend on that will mark as failed because a required change failed to merge15:32
*** kevin_zh has joined #openstack-nova15:32
dansmithfungi: yeah, that's on merge and for hairy things, but not on check, AFAIK right?15:33
mriedemdiana_clarke: you'll just have to recheck the rest that have the merge failed message15:33
*** kevinz has quit IRC15:33
openstackgerritMaciej Szankin proposed openstack/nova: config options: Improve help for base  https://review.openstack.org/32455915:33
mriedemjeblair knows about it15:33
fungidansmith: right, everywhere besides the final merge-down after passing the gate, zuul is using cgit to calculate merges (albeit with most complex resolution algorithms disabled to try and approximate the awfulness that is jgit)15:34
mriedemhe upped some timeouts or something when i was complaining about it in a large series15:34
dansmithmriedem: are you talking about on merge or check?15:34
*** aysyd has quit IRC15:34
diana_clarkemriedem: Yup, I know. If I understood correctly, dansmith that was surprised to hear that you need to manually recheck large patch series because they fail to merge as a rule (I've been told b/c of timing issues).15:34
*** aysyd has joined #openstack-nova15:35
mriedemdansmith: check15:35
*** jistr|call is now known as jistr15:35
mriedemi hit it every time after the first couple of changes when my get-me-a-network series was large15:35
dansmithhmm, that's not a thing I know about15:35
*** READ10 has joined #openstack-nova15:36
dansmith(nor fungi apparently)15:36
dansmithis this a post-jenkins recent thing somehow?15:36
*** ducttape_ has quit IRC15:37
dansmithI've not noticed this in prior large set pushes.. my resource attribute set a couple weeks ago was like ten big and didn't suffer this fate15:37
*** sudipto has joined #openstack-nova15:38
dansmithdiana_clarke: regardless, I can't even walk the first few in order now because they're orphaned, so a rebase to get the bottom few to be happy would be good15:38
diana_clarkedansmith: okie dokie15:38
*** oanson has quit IRC15:39
fungimriedem: dansmith: possibly related, gerrit 2.11 seems to seriously bloat its git repos with unreferenced objects, and we weren't garbage-collecting (because before we upgraded to 2.11 in december it wasn't really needed), so the nova repo there grew to around 50gb in size over the months since. a week or so ago we were finally comfortable with our gc tests to turn it on, and now that repo is back15:40
fungidown around 5gb. that may have been causing unusually inflated query lag for zuul particularly when trying to handle nova change lokups15:40
dansmithah, interesting15:40
*** shaohe_feng has quit IRC15:40
funginow we git gc all the repos on gerrit weekly (cron job that fires early sundays utc)15:41
*** sudipto has quit IRC15:41
danpbwow, that's fun15:41
*** shaohe_feng has joined #openstack-nova15:41
tonybfungi is that in system-config somewhere?  I'd like to gc my local clones as they're pretty big and y'all have done the work to know what's safe ;P15:42
danpbi guess whatever gerrit is doing doesn't trigger git  auto-gc ?15:42
*** david-lyle has joined #openstack-nova15:43
*** liverpooler has joined #openstack-nova15:43
danpbtonyb:  you can just run a plain 'git gc' on any local repo checkout15:43
*** diogogmt has joined #openstack-nova15:44
*** chandankumar has quit IRC15:44
*** code-R has joined #openstack-nova15:44
*** chandankumar has joined #openstack-nova15:44
tonybdanpb: don't you need to do somethign smart with the reflog to free up more 'HEADS' to discard?15:44
fungitonyb: yep, http://git.openstack.org/cgit/openstack-infra/puppet-gerrit/tree/manifests/cron.pp15:45
tonybfungi: thanks.15:46
fungitonyb: in our configuration that boils down to `find /home/gerrit2/review_site/git/ -type d -name \"*.git\" -print -exec git --git-dir=\"{}\" gc \\;`15:46
fungitonyb: note those are bare repos, hence the .git extensions on them15:46
fungitonyb: but as danpb says, it's just `git gc` in the repo basically15:47
tonybfungi: okay.  perhaps I'm overestimating the size reduction I shoudl expect15:47
fungitonyb: if you want to _seriously_ clean up and reset your repos to freshness, this is what i do: http://paste.openstack.org/show/542616/ (note that i also am religious about pushing my work in progress up to gerrit consistently and not keeping anything important in local topic branches)15:48
moshelemriedem, dansmith: can you review some pci patches https://review.openstack.org/#/c/347509/ and https://review.openstack.org/#/c/347444/ and https://review.openstack.org/#/c/347558/15:49
openstackgerritMatt Riedemann proposed openstack/nova: DNM: enable glanceclient debug logging  https://review.openstack.org/34791415:49
*** jlanoux has quit IRC15:50
tonybfungi: Yeah I'm not that religious but I could certainly modify that to drop all the review branches15:50
tonybfungi: Thanks again15:51
*** shaohe_feng has quit IRC15:51
fungitonyb: also that ls-projects file referenced in the script is generated with my clone updating script that i also run periodically: http://paste.openstack.org/show/542618/15:51
*** shaohe_feng has joined #openstack-nova15:52
fungiand that's where i'm also correcting remotes, pruning remote branches, et cetera15:52
fungiwith this, i maintain a mostly up-to-date mirror of all the repos we host in gerrit15:52
fungiwhich comes in really handy if i need to script up mass changes across a large slice of them15:53
*** sudipto has joined #openstack-nova15:53
tonybfungi: interesting that you manually set the gerrit remote/url rather then running git review -s15:53
fungidanpb: the reason what gerrit is doing doesn't trigger auto-gc is that it's not using cgit. it's using jgit, which doesn't auto-gc15:54
danpbah right15:54
fungitonyb: yeah, it's a quick and dirty script. it could just as well git review -s15:55
*** jwcroppe has quit IRC15:55
fungiwhich would have the side benefit of also grabbing the gerrit commit hook15:55
*** unicell1 has joined #openstack-nova15:55
tonybfungi: Mine is functionally similar http://paste.openstack.org/show/542620/ only it has half implemented detection of moved projects15:55
fungitonyb: since i totally blow away non-upstream content anyway, i opted to punt on renames and eat the recloning hit on those rare occasions15:56
*** matrohon has quit IRC15:56
tonybfungi: and deals with some of my "dirty" directories15:56
*** markus_z has quit IRC15:56
tonybfungi: yeah that's reasonable15:57
*** cgalan has quit IRC15:57
*** unicell has quit IRC15:57
*** hemnafk is now known as hemna15:57
openstackgerritMaciej Szankin proposed openstack/nova: config options: Improve help for SPICE  https://review.openstack.org/31704615:57
fungii considered it, but a lot of added complexity for minimal benefit15:58
fungialso we don't have a really good mechanism for identifying renames other than announcing them... otherwise i'd script up that detection and use it to "fix" my gertty databases15:58
*** tjones has left #openstack-nova16:00
*** sudipto has quit IRC16:00
tonybfungi: yeah.  I had a script that dropped the gerrit remote and then re-created it after rename but that assumes that it was just a namespace change ie {stackforge,openstack/foo-project16:00
tonybfungi: if we rename the repo that script blows up16:01
fungiwhich is basically the only renaming we do since last fall16:01
*** code-R has quit IRC16:01
fungier, last spring for you16:01
tonyb:)16:01
*** shaohe_feng has quit IRC16:01
fungilate last year16:01
*** thorst is now known as thorst_afk16:01
* fungi curses his lingering hemisphericentrism16:01
*** shaohe_feng has joined #openstack-nova16:02
tonybfungi: :) I think we've taken over the nova channel long enough ;P16:02
openstackgerritYves-Gwenael Bourhis proposed openstack/nova: Reduce time and memory usage of tenant usage.  https://review.openstack.org/34373416:03
*** gszasz_ has quit IRC16:03
openstackgerritMaciej Szankin proposed openstack/nova: config options: improve help netconf  https://review.openstack.org/31938416:03
*** claudiub|2 has quit IRC16:04
*** raj_singh_ has quit IRC16:04
*** armax has quit IRC16:04
*** tyrola has joined #openstack-nova16:05
openstackgerritMichael Still proposed openstack/nova: Refuse to have negative console ttls  https://review.openstack.org/34704016:06
*** kevin_zh has quit IRC16:07
mriedemdanpb: i've got libvirt/qemu taking like 99% cpu on a compute node, with not really any errors/warnings in the libvirtd.logs - is there something easy to check? i think i've got a hosed instance16:07
mriedemi haven't enabled libvirt debug logging (yet)16:07
*** TravT has joined #openstack-nova16:07
*** tyrola_ has joined #openstack-nova16:10
*** chandankumar has quit IRC16:10
*** chandankumar has joined #openstack-nova16:11
*** tyrola_ has quit IRC16:11
mriedemlooks like it was a rogue instance, i had a hung snapshot16:11
*** shaohe_feng has quit IRC16:11
mriedemdeleted the instance and now libvirt is back to normal16:11
*** shaohe_feng has joined #openstack-nova16:12
*** ducttape_ has joined #openstack-nova16:12
*** jwcroppe has joined #openstack-nova16:13
*** itlinux has quit IRC16:13
*** armax has joined #openstack-nova16:13
*** tyrola has quit IRC16:13
*** unicell1 has quit IRC16:14
*** nkrinner is now known as nkrinner_afk16:14
*** nic has joined #openstack-nova16:15
*** code-R has joined #openstack-nova16:15
*** kevin_zh has joined #openstack-nova16:15
*** slunkad_ has quit IRC16:15
*** sudipto has joined #openstack-nova16:15
*** chandankumar has quit IRC16:16
*** sayalilunkad has joined #openstack-nova16:17
*** chandankumar has joined #openstack-nova16:17
artomDammit http://logs.openstack.org/61/325361/7/gate/gate-nova-python27-db-ubuntu-xenial/8121e0a/console.html16:18
artomScrew it, CLOSED EVERYTHINGHATESME16:18
openstackgerritMaciej Szankin proposed openstack/nova: Improve consistency in API  https://review.openstack.org/33217616:20
*** cgalan has joined #openstack-nova16:21
*** shaohe_feng has quit IRC16:21
*** shaohe_feng has joined #openstack-nova16:22
*** edand has quit IRC16:23
*** kevin_zh has quit IRC16:23
openstackgerritMoshe Levi proposed openstack/nova: jsonutils.loads only if hypervisor.cpu_info is not None  https://review.openstack.org/34787016:24
*** sayalilunkad has quit IRC16:25
*** ctrath has quit IRC16:25
*** Apoorva has joined #openstack-nova16:25
mriedemartom: a failure like that hates everyone equally16:26
openstackgerritMichael Still proposed openstack/nova: Move quota options to a config group.  https://review.openstack.org/34686916:27
*** thorst_afk is now known as thorst16:27
*** ijw has joined #openstack-nova16:27
*** ftersin has left #openstack-nova16:27
artommriedem, so I'm finally part of the cool gang of hated everyones?16:27
*** david-lyle has quit IRC16:28
*** dikonoor has joined #openstack-nova16:29
*** ijw has quit IRC16:29
mriedemnice, glance has a allow_additional_image_properties config16:29
mriedemdefaults to true, but if you set it to false, interop issues16:29
mriedemthe schema changes based on config16:29
danpbmriedem: check that the guest isn't running a 100% cpu workload :-)16:29
mriedemdanpb: cirros guest16:29
*** ijw has joined #openstack-nova16:29
mriedemdanpb: i think the snapshot just went crazy or something, but virsh said the domain was running, so idk16:30
*** shaohe_feng has quit IRC16:32
*** shaohe_feng has joined #openstack-nova16:32
*** ljxiash has quit IRC16:33
openstackgerritPushkar Umaranikar proposed openstack/nova: Add server admin actions to general purpose feature matrix  https://review.openstack.org/34570816:33
*** code-R_ has joined #openstack-nova16:34
*** haleyb has joined #openstack-nova16:34
*** ctrath has joined #openstack-nova16:36
*** yamahata has quit IRC16:37
*** code-R has quit IRC16:37
*** abalutoiu_ has joined #openstack-nova16:37
*** sayalilunkad has joined #openstack-nova16:38
*** chandankumar_ has joined #openstack-nova16:39
*** mvk has quit IRC16:39
*** tjones has joined #openstack-nova16:40
*** chandankumar has quit IRC16:40
*** tjones has left #openstack-nova16:40
*** abalutoiu has quit IRC16:40
*** derekh has quit IRC16:42
*** shaohe_feng has quit IRC16:42
*** shaohe_feng has joined #openstack-nova16:43
openstackgerritGleb Stepanov proposed openstack/nova: [WIP] Init allocated ports set  https://review.openstack.org/34747916:44
*** chandankumar_ has quit IRC16:44
*** Sukhdev has quit IRC16:44
*** tjones has joined #openstack-nova16:46
*** tjones has left #openstack-nova16:48
openstackgerritBrian Haley proposed openstack/nova: Revert "raise exception ComputeHostNotFound if host is not found"  https://review.openstack.org/34794516:50
mriedemsdague: well i figured out why snapshot fails with glance v2 for us16:50
mriedemit's awesome16:50
*** READ10 has quit IRC16:51
mriedemwe don't deploy https://github.com/openstack/glance/blob/master/etc/schema-image.json - which if you don't have that, you can't pass kernel_id or ramdisk_id=None, which is exactly what nova does https://github.com/openstack/nova/blob/master/nova/image/glance.py#L84916:51
mriedemwe don't fail upstream ci because devstack sets all of this up16:51
mriedemand allow_additional_image_properties defaults to True in glance config, but if you set that to False, then you can't pass kernel_id/ramdisk_id at all16:52
mriedemso nova is making a bunch of assumptions based on how devstack works, which i guess shouldn't be surprising16:52
*** shaohe_feng has quit IRC16:52
*** READ10 has joined #openstack-nova16:52
*** Apoorva_ has joined #openstack-nova16:53
openstackgerritRoman Podoliaka proposed openstack/nova: ironic_host_manager: fix population of instances info on schedule  https://review.openstack.org/34696616:53
openstackgerritRoman Podoliaka proposed openstack/nova: WIP ironic_host_manager: fix population of instances info on start  https://review.openstack.org/34794816:53
*** shaohe_feng has joined #openstack-nova16:53
*** lucasagomes is now known as lucas-dinner16:55
*** Apoorva has quit IRC16:56
*** nherciu has quit IRC17:00
johnthetubaguypumaranikar: hey, just got a worry about this bit: https://review.openstack.org/#/c/344483/3/doc/source/feature_matrix_gp.ini@25717:01
johnthetubaguypumaranikar: is that really true?17:01
*** shaohe_feng has quit IRC17:02
openstackgerritAnusha Unnam proposed openstack/nova: Config options consistency for cell.py  https://review.openstack.org/34795417:03
*** shaohe_feng has joined #openstack-nova17:03
*** moshele has quit IRC17:04
*** muawiakhan has quit IRC17:05
*** Swami has quit IRC17:05
*** BobBall is now known as BobBall_AWOL17:06
*** unicell has joined #openstack-nova17:07
openstackgerritSarafraj Singh proposed openstack/nova: Adding functional tests for 2.3 microversion  https://review.openstack.org/34754417:07
johnthetubaguydo folks know, is this the only ironic job that runs on nova right now? http://logs.openstack.org/72/339072/5/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa/cbbd8ec/console.html17:10
raj_singhjohnthetubaguy: gate-tempest-dsvm-ironic-pxe_ipa-nv17:12
*** ctrath has quit IRC17:12
raj_singhjohnthetubaguy: This was the job last time I checked, might have changed now17:12
*** tesseract- has quit IRC17:13
*** shaohe_feng has quit IRC17:13
*** shaohe_feng has joined #openstack-nova17:13
*** links has joined #openstack-nova17:15
*** sdake has quit IRC17:15
pumaranikarjohnthetubaguy, no its not true. I need to change tag for ironic17:18
openstackgerritClenimar Filemon proposed openstack/nova: Support Identity v3 when connecting to Ironic  https://review.openstack.org/30015417:18
pumaranikarjohnthetubaguy, I will check and update accordingly.17:19
*** david-lyle has joined #openstack-nova17:20
*** rama_y has joined #openstack-nova17:21
*** shaohe_feng has quit IRC17:23
*** david-lyle has quit IRC17:23
*** shaohe_feng has joined #openstack-nova17:23
*** ctrath has joined #openstack-nova17:23
*** david-lyle_ has joined #openstack-nova17:23
mriedemdiana_clarke: commented on https://review.openstack.org/#/c/343922/ - i'm not sure why we want/need the coverage job running on all changes in the check queue17:24
mriedemi'd be fine with experimental for running it on demand17:24
*** david-lyle_ is now known as david-lyle17:24
mriedemclarkb: does the coverage job in the post queue post results somewhere? like an html page that infra hosts?17:25
*** david-lyle_ has joined #openstack-nova17:25
diana_clarkemriedem: I like being able to see how a particular patch changes the overall coverage, and coverage takes 30 min for me to run locally.17:26
*** abalutoiu__ has joined #openstack-nova17:26
mriedemfor a particular patch, you can run it through the job in the experimental queue17:26
mriedemi don't think we care about it in check on every change17:26
dansmithyeah, if it takes 30 minutes locally,17:26
dansmiththat's a lot of extra work for the workers for pretty minimal gain17:27
diana_clarkeFWIW: That patch was prompted by this thread: http://lists.openstack.org/pipermail/openstack-dev/2016-July/099501.html17:28
mriedemsdague: do you have the rootwrap 5.0.0 release request queued up? else i can17:29
*** david-lyle has quit IRC17:29
*** abalutoiu_ has quit IRC17:30
*** Apoorva_ has quit IRC17:30
mriedemdiana_clarke: i'm fine with it in the experimental queue if someone wants to see the results but doesn't want to run it locally17:30
*** Apoorva has joined #openstack-nova17:30
mriedemdiana_clarke: as a reviewer though, i'm not going to be digging into coverage job results for patches that are passing tests17:30
mriedemwell, or at all really17:31
mriedemunless it's like a major test refactor17:31
*** shaohe_feng has quit IRC17:33
diana_clarkemriedem: okie dokie. I use coverage when I review to make sure the new code is actually covered by tests, but perhaps that's just me. I'll ditch it.17:33
*** david-lyle_ has quit IRC17:34
diana_clarke(thanks for the review!)17:34
mriedemdiana_clarke: again, s/check/experimental/17:34
mriedemtotally fine17:34
*** david-lyle_ has joined #openstack-nova17:34
*** shaohe_feng has joined #openstack-nova17:34
*** abalutoiu__ has quit IRC17:35
*** tonytan_brb has joined #openstack-nova17:36
*** abalutoiu__ has joined #openstack-nova17:36
*** syjulian has joined #openstack-nova17:36
*** browne has joined #openstack-nova17:37
*** tonytan4ever has quit IRC17:38
diana_clarkeman... rebasing someone else's 30+ patch series is difficult. I keep throwing it away, worried I've messed up.17:38
*** yamahata has joined #openstack-nova17:39
*** tosky has quit IRC17:39
openstackgerritGábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests  https://review.openstack.org/34774817:40
*** diga has quit IRC17:40
openstackgerritMike Fedosin proposed openstack/nova: Don't set empty kernel_id and ramdisk_id to glance image  https://review.openstack.org/34797117:41
*** david-lyle_ has quit IRC17:42
openstackgerritGábor Antal proposed openstack/nova: Fixed invalid UUIDs in unit tests  https://review.openstack.org/34774817:42
*** eil397 has joined #openstack-nova17:43
*** shaohe_feng has quit IRC17:43
*** shaohe_feng has joined #openstack-nova17:44
*** ihrachys has quit IRC17:44
*** abalutoiu_ has joined #openstack-nova17:45
*** ijw has quit IRC17:45
*** sdague has quit IRC17:46
*** sabari has quit IRC17:47
*** dikonoor has quit IRC17:48
*** sabari has joined #openstack-nova17:48
*** abalutoiu__ has quit IRC17:48
*** jaypipes has joined #openstack-nova17:49
*** mingyu has quit IRC17:52
*** danpb has quit IRC17:53
*** shaohe_feng has quit IRC17:54
*** sdague has joined #openstack-nova17:54
*** links has quit IRC17:54
*** mingyu has joined #openstack-nova17:54
*** shaohe_feng has joined #openstack-nova17:54
dansmithjaypipes: did you see the comment on this? https://review.openstack.org/#/c/334031/317:56
*** mvk has joined #openstack-nova17:58
sdaguemriedem: I have not yet17:59
sdaguemriedem: ... on the glance side, is it expected from a glance perspective that file is deployed?18:00
*** sudipto has quit IRC18:00
sdagueperhaps we should get the glance project to put the schemas in code instead of config, this seems to be another one of those state tracking problems18:00
mriedemsdague: i don't know if it's expected, but it shouldn't be expected to be the same as in tree since it's in /etc18:00
mriedemmost of the schema is in code18:01
mriedemthe required things i guess18:01
sdaguemriedem: I didn't quite parse the last bit there18:01
mriedemoptional / additionalProperties are configurable18:01
mriedemparse this https://review.openstack.org/#/c/316398/29/api-ref/source/servers.inc :)18:01
mriedemunrelated, but wanted your opinion on listing those samples18:01
*** MikeG451 has joined #openstack-nova18:03
*** shaohe_feng has quit IRC18:04
openstackgerritArun yerra proposed openstack/nova-specs: Proposal for standardizing hardware NIC capabilities.  https://review.openstack.org/34134118:04
*** shaohe_feng has joined #openstack-nova18:05
sdaguemriedem: I like the idea of a new sample for 2.37 because the structure of the new field is clearer with an example then with docs, I don't think we need to backfill all possible iterations before it18:06
sdagueI would also call it 2.37 with automatic networks, or something in describing it18:06
mriedemok, i won't do a version range then on the first one, just maybe note it's 2.118:07
dansmithmriedem: mark +1ed the previous patch before I fixed a test rebase conflict, and I think you said you were good if he was: https://review.openstack.org/#/c/318266/1818:07
*** jamielennox is now known as jamielennox|away18:10
mriedemforgot all about that change18:12
jaypipesdansmith: yep, getting there. lightning storms last night took out networking (hardwired not wireless, weirdly) at my house and had to get things "fixed" today18:13
dansmithjaypipes: heh, okay18:13
jaypipesdansmith: as you know, I am an electronics whizkid so it was an easy effort.18:14
dansmithindeed18:14
*** shaohe_feng has quit IRC18:14
mriedemjaypipes: flip the breaker?18:15
jaypipesmriedem: pretty much.18:15
*** mingyu has quit IRC18:16
*** shaohe_feng has joined #openstack-nova18:17
*** unicell has quit IRC18:18
*** baoli_ has quit IRC18:18
*** unicell has joined #openstack-nova18:18
openstackgerritIldiko Vancsa proposed openstack/nova: WIP: Allow multi-attach in compute api  https://review.openstack.org/27104718:19
openstackgerritIldiko Vancsa proposed openstack/nova: libvirt: Allow multiple volume attachments  https://review.openstack.org/26758718:19
*** sridharg has joined #openstack-nova18:19
*** ociuhandu has quit IRC18:21
*** Swami has joined #openstack-nova18:22
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Don't call _create_image from finish_migration  https://review.openstack.org/33716018:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Rename import of nova.virt.disk.api in driver  https://review.openstack.org/33352118:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Add DiskFromImage and DiskFromFunc  https://review.openstack.org/33352218:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Rewrite _test_finish_migration  https://review.openstack.org/33715918:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Don't check config disk during cold migration  https://review.openstack.org/33715818:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Rewrite test_rescue and test_rescue_config_drive  https://review.openstack.org/33596618:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Separate functions to get root, ephemeral, and swap  https://review.openstack.org/33398418:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Combine injection info in InstanceConfig  https://review.openstack.org/33779018:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Replace _create_images_and_backing in _hard_reboot  https://review.openstack.org/33778918:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Fix fake _disk_info data in LibvirtDriverTestCase  https://review.openstack.org/32836618:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional  https://review.openstack.org/34555318:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Add create_from_image and create_from_func to Backend  https://review.openstack.org/33324418:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Resize an existing disk  https://review.openstack.org/33241618:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Add check_backing_from_func & check_backing_from_image  https://review.openstack.org/32228518:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Fix invalid test data  https://review.openstack.org/33324118:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Update tests to mock create_from_*  https://review.openstack.org/34542718:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks  https://review.openstack.org/33324218:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test  https://review.openstack.org/33324318:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Add create_from_image & create_from_func for Qcow2  https://review.openstack.org/32061018:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Pass is_block_dev explicitly from create_from_func  https://review.openstack.org/33326318:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Cleanup test_create_configdrive  https://review.openstack.org/33911418:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Add _create_external_boot_disks  https://review.openstack.org/33398018:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Never copy a swap disk during cold migration  https://review.openstack.org/33111518:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver  https://review.openstack.org/33397918:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Don't re-resize disks in finish_migration()  https://review.openstack.org/33111818:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Don't create ephemerals or swap in _create_image  https://review.openstack.org/33947418:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Cleanup spawn tests  https://review.openstack.org/34417518:23
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Replace _create_images_and_backing in pre_live_migration  https://review.openstack.org/34222418:24
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Rename Backend snapshot and image  https://review.openstack.org/33327218:24
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Introduce ImageCacheLocalDir  https://review.openstack.org/27966918:24
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Test disk creation in test_hard_reboot  https://review.openstack.org/33899318:24
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test_prealloc_image  https://review.openstack.org/34416818:24
openstackgerritMatt Riedemann proposed openstack/nova: Add REST API support for get me a network  https://review.openstack.org/31639818:24
*** shaohe_feng has quit IRC18:24
*** zul_ has joined #openstack-nova18:25
*** zul has quit IRC18:25
*** ayoung has quit IRC18:25
*** shaohe_feng has joined #openstack-nova18:25
sdaguediana_clarke: in https://review.openstack.org/#/c/328366/15 it seems that 15 reverted to back to patch 13 that dansmith had a -1 on, so his -1 is back18:26
dansmithoye18:27
diana_clarkesdague: yeah... sorry about that18:27
dansmithmaybe we should split that series in the middle to avoid flooding the workers every time we have to rebase?18:27
dansmithjust pause in the middle somewhere18:27
dansmithsdague: ^18:28
*** mnestratov has quit IRC18:29
sdaguedansmith: yeh, that might be a good idea, cause that series does eat up a good percentage of CI when it gets rebase18:29
dansmithyeah and it's conflict-heavy so we know there will be multiple rebases before it all lands18:30
sdagueI mean if people are reviewing the whole stack every time, it's fine18:30
sdaguebut if people are only going 5 patches deep, we could optimize for turn around instead18:30
dansmithyeah the latter I think18:31
dansmithI've certainly not make it through more than a few at the bottom at a time18:31
sdagueyeh, then it's probably better to just pick the smaller working set, and rebase those get them fixed, landed18:31
*** baoli has joined #openstack-nova18:34
*** shaohe_feng has quit IRC18:35
*** shaohe_feng has joined #openstack-nova18:35
sdaguedansmith: anyway, is the bottom patch there really -1ed by you? I was mostly trying to figure out the mismatch between your last comment and the patch votes.18:35
dansmithsdague: yep, it contains unrelated damage to an instance structure18:37
dansmithwhich was removed in 14, but re-introduced in 1518:37
diana_clarkeI think True is an invalid value, and None is probably better.18:38
sdagueok, just checking18:38
dansmithdiana_clarke: but it's unrelated to the change, so if we fix that, we should do it separately18:39
diana_clarkehe did say as much in the commit message18:40
diana_clarkeAnyhoo, now that I've rebased with master, I can fix that again and squash the fix, unless you want me to stop.18:41
dansmithyou mean unsquash?18:42
diana_clarkeheh18:42
dansmithmy preference would be to re-fix the bottom patch, and then submit only 5-10 of the bottom ones to get it up there18:43
*** ericksonsantos has quit IRC18:44
*** tonytan_brb has quit IRC18:44
*** shaohe_feng has quit IRC18:45
*** shaohe_feng has joined #openstack-nova18:46
openstackgerritVladik Romanovsky proposed openstack/nova: NUMA: include orphan threads with policy prefer  https://review.openstack.org/34499218:46
*** cdent has quit IRC18:48
*** beagles is now known as beagles-brb18:51
diana_clarkedansmith: I know how to change just _one_ patch in the series (and orphan it), and I know how to change _all_ patches in the series (and squash fixes etc), but I don't know how to just change just _some_ of them.18:51
dansmithdiana_clarke: git review -d <pick-a-patch>18:52
dansmithgit rebase -i master18:52
dansmithfix the first one, then review18:52
dansmithdiana_clarke: is that what you're looking for?18:52
diana_clarkedansmith: That's what I did first (which orphaned it).18:52
dansmithdiana_clarke: you can also keep the full stack, and then just before review, check out one of the middle patches and review from that point in the stack18:53
*** dimtruck is now known as zz_dimtruck18:53
dansmithyou're looking to effectively orphan a set of them at the top18:53
diana_clarkeoh! if orphaning is the goal, then I know how to do that.18:54
dansmithyou can't resubmit the bottom ones and not the top ones without orphaning them18:54
dansmithso yeah18:54
diana_clarkeokie dokie, I thought I had to do this without orphaning any of the patches18:55
*** shaohe_feng has quit IRC18:55
diana_clarkemdbooth is totally going to kill me when he gets back...18:55
*** shaohe_feng has joined #openstack-nova18:56
dansmithnah18:56
dansmithmore patches merged == better18:56
dansmithyou're just going to blame me anyway, so he'll rage at me if he's going to :)18:56
*** david-lyle_ has joined #openstack-nova18:57
*** zz_dimtruck is now known as dimtruck18:57
*** abalutoiu__ has joined #openstack-nova18:59
*** abalutoiu_ has quit IRC19:02
*** shaohe_feng has quit IRC19:05
*** beagles-brb is now known as beagles19:06
*** shaohe_feng has joined #openstack-nova19:07
*** david-lyle_ is now known as david-lyle19:07
*** fifieldt has quit IRC19:08
*** sridharg has quit IRC19:09
*** haplo37__ has joined #openstack-nova19:09
mriedemdansmith: lyarwood: so i don't blow up stats i'm not -1ing but i'd like to see my comments addressed on https://review.openstack.org/#/c/318266/19:11
mriedemotherwise it looks ok19:11
*** shaohe_feng has quit IRC19:16
*** shaohe_feng has joined #openstack-nova19:16
*** tonytan4ever has joined #openstack-nova19:17
*** fifieldt has joined #openstack-nova19:18
*** READ10 has quit IRC19:19
*** coolsvap has quit IRC19:21
mriedemdoes conductor create the neutron ports now?19:21
mriedemgot a vif plug timeout but the instance doesn't have a host listed in nova show19:22
mriedemand neutron port-list is empty, so thinking nova cleaned it up?19:22
*** ctrath has quit IRC19:25
*** sdake has joined #openstack-nova19:25
*** shaohe_feng has quit IRC19:26
*** shaohe_feng has joined #openstack-nova19:27
dansmithmriedem: you LOGrolled me again19:27
mriedemLOGrolled you?19:27
mriedemat least i didn't -119:27
dansmithhit me up with log convention trivia19:27
dansmithbut makes sense of course, especially given the reason for those logs19:28
mriedemheh, -1 then19:28
mriedemsince you dropped the +219:28
mriedemlet's coordinate all scores19:28
dansmithI can fix it for him in a minute, he's probably gone for the day19:29
*** bvanhav has quit IRC19:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Fix fake _disk_info data in LibvirtDriverTestCase  https://review.openstack.org/32836619:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional  https://review.openstack.org/34555319:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver  https://review.openstack.org/33397919:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Fix invalid test data  https://review.openstack.org/33324119:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks  https://review.openstack.org/33324219:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test  https://review.openstack.org/33324319:31
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test_prealloc_image  https://review.openstack.org/34416819:32
diana_clarkedansmith: trying again with just the bottom 719:32
openstackgerritDan Smith proposed openstack/nova: compute: Skip driver detach calls for non local instances  https://review.openstack.org/31826619:32
dansmithmriedem: ^19:32
dansmithdiana_clarke: smaller list for sure19:33
dansmithI have to run do a thing and then I'll be back and can look19:33
diana_clarkedansmith: No rush, I'm on your timezone this week so I might be gone by then.19:34
* dansmith didn't know he had been invaded19:34
dansmithdiana_clarke: I normally work your timezone's hours :)19:34
diana_clarkedansmith: Our meetings are so early here!19:35
dansmithnahhh19:35
dansmithdiana_clarke: if you want sympathy for PDT timing, talk to melwitt :D19:36
*** shaohe_feng has quit IRC19:36
melwitthah19:36
*** shaohe_feng has joined #openstack-nova19:37
diana_clarkedansmith: so will cores know where to start reviewing now that I've orphaned the bottom 7 patches?19:37
diana_clarkeoh! the +2 magically came back19:39
mriedemdo we unbind the host from an instance on scheduling aborts?19:40
mriedemi've never seen that before19:40
*** anush_ has quit IRC19:40
mriedembauzas: ^?19:41
*** sdake has quit IRC19:43
openstackgerritClif Houck proposed openstack/nova: Add Image Remote Authentication Verification  https://review.openstack.org/33077319:44
mriedemoh i see it19:44
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L182919:45
mriedemself._nil_out_instance_obj_host_and_node(instance)19:45
mriedemmakes tracking down which compute the instance was building on kind of messy19:46
mriedemwhen you don't have logsatsh19:46
*** shaohe_feng has quit IRC19:46
*** shaohe_feng has joined #openstack-nova19:47
*** jamesdenton has joined #openstack-nova19:47
dansmithmriedem: fixed alignment19:49
openstackgerritDan Smith proposed openstack/nova: compute: Skip driver detach calls for non local instances  https://review.openstack.org/31826619:49
mriedemoh hot damn19:49
jaypipesmriedem: https://review.openstack.org/#/c/343120/ should be good to go, FYI19:50
*** sdake has joined #openstack-nova19:53
*** jdurgin has quit IRC19:53
mriedemjaypipes: will check it out - can you also take a look at this? https://review.openstack.org/#/c/347971/19:54
mriedemjaypipes: it's glance, so you love it19:54
*** shaohe_feng has quit IRC19:57
*** shaohe_feng has joined #openstack-nova19:58
openstackgerritSarafraj Singh proposed openstack/nova: Adding functional tests for 2.3 microversion  https://review.openstack.org/34754420:00
jaypipesmriedem: done.20:01
*** ctrath has joined #openstack-nova20:02
mriedemjaypipes: ok on that spec amendment,20:05
mriedem* `409 Conflict` if another process updated any existing inventory record20:05
mriedem  since the `resource_provider_generation` view marker was returned.20:05
mriedemis what i was hoping to see - basically the new PUT wipes out any existing inventories for the RP right?20:06
mriedemand if we have racing updates to the RP we will fail if one of them doesn't have the latest data (generation id?)20:06
*** shaohe_feng has quit IRC20:07
*** shaohe_feng has joined #openstack-nova20:08
*** Apoorva has quit IRC20:09
openstackgerritPushkar Umaranikar proposed openstack/nova: Add details to general purpose feature matrix  https://review.openstack.org/34448320:12
*** akshai has quit IRC20:15
*** shihanzhang has joined #openstack-nova20:17
*** tangchen has quit IRC20:17
*** eil397 has quit IRC20:17
*** cdelatte has quit IRC20:17
*** shaohe_feng has quit IRC20:17
*** ihrachys has joined #openstack-nova20:17
*** shz has quit IRC20:18
mriedemedleafe: ^?20:18
*** shaohe_feng has joined #openstack-nova20:18
*** tangchen has joined #openstack-nova20:19
*** ericksonsantos has joined #openstack-nova20:20
dansmithmriedem:  the put does replace all current inventories, if that's what you're asking20:21
mriedemdansmith: right, but the generation id is to make sure we're calling with the latest known state of the RP right?20:23
mriedemalthough if you're overwriting all inventories for an RP, i'm not sure why it matters20:24
dansmithmriedem: it does matter, and yes that's the reason20:24
dansmithmriedem: it's to avoid two things updating the inventories at the same time, so for example:20:24
dansmithI am the disk script, so I fetch the current set, update the disk amount and PUT20:25
dansmithyou are the memory script, and you do the same but for the memory20:25
* edleafe reads scrollback20:25
dansmithyou want to have a single consistent view, which will be wrong if we both win20:25
dansmithso the generation and retry is specifically to make sure those are serialized20:25
edleafemriedem: what dansmith said. If the generation doesn't match, it's a race, and the update is rejected20:26
* dansmith gets himself a cookie for being right20:27
*** shaohe_feng has quit IRC20:27
mriedemyeah, right,20:28
* edleafe envisions dansmith weighing 900 lbs with all those cookies20:28
mriedembut disk and ram scripts are doing a PUT with all inventories, or just their specific ones?20:28
dansmithedleafe: if only..20:28
dansmithmriedem: all20:28
*** shaohe_feng has joined #openstack-nova20:28
dansmithmriedem: which is why they need to know if one that they don't control has changed since they fetched20:28
mriedemyup20:29
*** JoseMello has quit IRC20:30
*** ducttape_ has quit IRC20:31
*** aswadr_ has quit IRC20:31
*** cleong has quit IRC20:35
*** tjones has joined #openstack-nova20:36
*** tjones has left #openstack-nova20:37
*** shaohe_feng has quit IRC20:38
*** shaohe_feng has joined #openstack-nova20:39
*** artom_ has joined #openstack-nova20:41
*** artom has quit IRC20:41
openstackgerritJay Pipes proposed openstack/nova-specs: Amend placement REST API with allocation records  https://review.openstack.org/33861820:41
*** artom_ has quit IRC20:42
*** artom_ has joined #openstack-nova20:42
*** oomichi has joined #openstack-nova20:43
*** Apoorva has joined #openstack-nova20:45
openstackgerritMatt Riedemann proposed openstack/nova: Default image.size to 0 when extracting v1 image attributes  https://review.openstack.org/34757120:46
*** sdake has quit IRC20:46
*** shaohe_feng has quit IRC20:48
*** shaohe_feng has joined #openstack-nova20:49
*** cdelatte has joined #openstack-nova20:51
*** ayoung has joined #openstack-nova20:55
*** abalutoiu_ has joined #openstack-nova20:55
*** thorst has quit IRC20:55
openstackgerritAnusha Unnam proposed openstack/nova: Remove deprecated manager option in cells.py  https://review.openstack.org/34803920:55
*** ducttape_ has joined #openstack-nova20:57
*** shaohe_feng has quit IRC20:58
*** abalutoiu__ has quit IRC20:59
*** shaohe_feng has joined #openstack-nova20:59
*** jamesdenton has quit IRC21:03
bauzasmriedem: sorry was afk21:04
bauzasmriedem: what's up ?21:04
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Use fake_imagebackend in functional  https://review.openstack.org/34555321:04
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Remove some unnecessary mocking in test_driver  https://review.openstack.org/33397921:04
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Improve mocking of imagebackend disks  https://review.openstack.org/33324221:04
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Pass object to _create_images_and_backing in test  https://review.openstack.org/33324321:04
openstackgerritDiana Clarke proposed openstack/nova: libvirt: Reset can_fallocate in test setUp()  https://review.openstack.org/34416821:04
bauzasscrolling back, but no clear explanation21:05
mriedembauzas: was debugging something where scheduling failed b/c of networking (vif plug timeout), hit BuildAbortException, and was trying to find which compute (of 400) the instance built on21:06
mriedemsince nova-show didn't show instance.host21:06
mriedemanyway, figured it out - we null out the host and node props on the instance in the compute manager when we hit BuildAbortException21:06
bauzasyup, by the exception21:08
*** clenimar has quit IRC21:08
*** shaohe_feng has quit IRC21:08
*** shaohe_feng has joined #openstack-nova21:09
*** jdurgin has joined #openstack-nova21:10
*** jamielennox|away is now known as jamielennox21:17
*** mingyu has joined #openstack-nova21:17
*** shaohe_feng has quit IRC21:19
*** shaohe_feng has joined #openstack-nova21:20
mriedemwe don't have ELK yet either so it was messy finding the compute node for that instance21:21
openstackgerritMatt Riedemann proposed openstack/nova: Add the ability to configure glanceclient debug logging  https://review.openstack.org/34791421:21
openstackgerritMatt Riedemann proposed openstack/nova: DNM: enable glanceclient debug logging  https://review.openstack.org/34804621:21
mriedemgrepping the nova-scheduler logs did the trick though21:21
*** mingyu has quit IRC21:21
*** rtheis has quit IRC21:22
*** david-lyle has quit IRC21:25
*** shaohe_feng has quit IRC21:29
openstackgerritAnusha Unnam proposed openstack/nova: Config options consistency for consoleauth.py  https://review.openstack.org/34805021:29
*** shaohe_feng has joined #openstack-nova21:30
*** admin0 has joined #openstack-nova21:32
*** xinliang has quit IRC21:37
openstackgerritEric Fried proposed openstack/nova: cleanup_live_migration_destination_check spacing  https://review.openstack.org/34805421:37
*** shaohe_feng has quit IRC21:39
*** shaohe_feng has joined #openstack-nova21:40
openstackgerritAnush Krishnamurthy proposed openstack/nova: Deprecate cert option  https://review.openstack.org/34805521:41
openstackgerritSarafraj Singh proposed openstack/nova: Deprecate cert option  https://review.openstack.org/34805521:46
tonybdansmith: so https://review.openstack.org/#/c/345633/ merged which is in the oposite direction to what we said at the mid-cycle21:46
dansmithtonyb: le sigh21:47
dansmithtonyb: you want to put up a revert and I'll +2 it?21:47
*** admin0 has quit IRC21:47
dansmithtonyb: we have a fast revert policy for things like this21:47
tonybdansmith: Sure.21:48
*** xinliang has joined #openstack-nova21:49
*** shaohe_feng has quit IRC21:49
*** shaohe_feng has joined #openstack-nova21:50
*** rfolco has quit IRC21:50
*** tonytan4ever has quit IRC21:51
*** haplo37__ has quit IRC21:52
openstackgerritTony Breeds proposed openstack/nova: Revert "Don't assert exact to_dict output"  https://review.openstack.org/34805721:54
openstackgerritAnush Krishnamurthy proposed openstack/nova: Deprecate cert option  https://review.openstack.org/34805521:54
*** admin0 has joined #openstack-nova21:55
mriedemmelwitt: should we just drop this? https://review.openstack.org/#/c/293800/ i don't plan on working on it21:57
dansmithmriedem: or melwitt: can you +W this per fast-revert policy? https://review.openstack.org/#/c/348057/121:57
*** sameo_ has joined #openstack-nova21:57
*** rama_y has quit IRC21:57
mriedemdansmith: i wasn't part of the midcycle discussion on that one21:57
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove unused validation code for quota_sets  https://review.openstack.org/34805921:57
dansmithmriedem: only tony and I were really21:58
mriedemsell me quick21:58
dansmithmriedem: they removed an assertion of what the context looks like on the wire so they can change it and potentially break us21:58
melwittmriedem: I want to keep it. I made it work and thought it would be useful21:58
dansmithmriedem: tonyb was going to make the test properly check for the old and new, and assert they're compatible21:59
*** tblakeslee has quit IRC21:59
mriedemdansmith: oh so rather than exact dict compare, this is like a subset21:59
*** shaohe_feng has quit IRC22:00
dansmithmriedem: right22:00
mriedemso they could add things to the to_dict() response and we wouldn't know about it22:00
tonybmriedem: I was going to keep the exact dict but add ashim to work with old and new22:00
dansmiththis is worth us being pedantic about.. the breakage is a good thing22:00
*** shaohe_feng has joined #openstack-nova22:00
*** sameo has quit IRC22:01
*** rama_y has joined #openstack-nova22:01
mriedem+W22:02
*** c64cosmin has quit IRC22:03
*** mdrabe has quit IRC22:03
*** efried has quit IRC22:04
*** abalutoiu_ has quit IRC22:04
*** ducttape_ has quit IRC22:05
mriedemmelwitt: should probably drop the WIP: prefix then huh22:06
melwittmriedem: yeah, I must have glossed over that. I'll remove the WIP22:07
mriedemmelwitt: there are also some TODOs in there about skipping until some bug is fixed, but the tests aren't actually skipped22:07
*** burt has quit IRC22:09
openstackgerritSarafraj Singh proposed openstack/nova: Remove deprecated manager option in cells.py  https://review.openstack.org/34803922:09
melwittmriedem: ah ... right. I must have been seeing if it worked in the gate and forgot to put the real skips in and remove the WIP, or something22:09
*** oomichi has quit IRC22:10
*** shaohe_feng has quit IRC22:10
*** shaohe_feng has joined #openstack-nova22:11
*** oomichi has joined #openstack-nova22:11
*** tziarko has quit IRC22:12
*** mriedem has quit IRC22:12
*** xyang1 has quit IRC22:13
*** salv-orlando has quit IRC22:13
openstackgerritAnush Krishnamurthy proposed openstack/nova: Update tags for Cache config option  https://review.openstack.org/34806422:17
*** salv-orlando has joined #openstack-nova22:17
*** hemna is now known as hemnafk22:18
*** tbachman has quit IRC22:20
*** shaohe_feng has quit IRC22:20
*** shaohe_feng has joined #openstack-nova22:21
*** david-lyle has joined #openstack-nova22:22
*** salv-orlando has quit IRC22:23
*** ctrath has quit IRC22:23
*** pwnall1 has joined #openstack-nova22:23
*** tbachman has joined #openstack-nova22:24
*** jaypipes has quit IRC22:24
*** edmondsw has quit IRC22:25
*** david-lyle has quit IRC22:25
*** eil397 has joined #openstack-nova22:25
*** david-lyle has joined #openstack-nova22:25
openstackgerritMichael Still proposed openstack/nova: Add support for vd2 user contet to other drivers  https://review.openstack.org/34806622:25
*** shaohe_feng has quit IRC22:30
openstackgerritMichael Still proposed openstack/nova: Add support for vd2 user context to other drivers  https://review.openstack.org/34806622:31
*** shaohe_feng has joined #openstack-nova22:31
*** diogogmt_ has joined #openstack-nova22:33
openstackgerritAnusha Unnam proposed openstack/nova: Improve help text for xenapi_session_opts  https://review.openstack.org/32232222:33
*** diogogmt has quit IRC22:34
*** diogogmt_ is now known as diogogmt22:34
*** TravT_ has joined #openstack-nova22:35
openstackgerritLudovic Beliveau proposed openstack/nova: Allocate PCI devices on migration  https://review.openstack.org/32898322:37
openstackgerritLudovic Beliveau proposed openstack/nova: Fixes for race conditions in revert migration with SR-IOV  https://review.openstack.org/33976522:37
*** TravT has quit IRC22:37
*** jwcroppe has quit IRC22:40
*** jwcroppe has joined #openstack-nova22:41
*** shaohe_feng has quit IRC22:41
*** shaohe_feng has joined #openstack-nova22:44
*** jwcroppe has quit IRC22:45
*** jamielennox is now known as jamielennox|away22:45
*** thorst_ has joined #openstack-nova22:47
*** david-lyle has quit IRC22:50
*** david-lyle_ has joined #openstack-nova22:50
*** tjones has joined #openstack-nova22:50
*** TravT_ has quit IRC22:51
openstackgerritTony Breeds proposed openstack/nova: Add support for oslo.context 2.6.0  https://review.openstack.org/34260422:51
*** shaohe_feng has quit IRC22:51
tonybdansmith: ^^ that's what I thought we talked about. happy to fix it if I messed up.22:52
*** shaohe_feng has joined #openstack-nova22:52
dansmithtonyb: yep, looking22:52
tonybdansmith: Thanks22:53
*** aysyd has quit IRC22:54
dansmithtonyb: so that test works because we assert the value is always there, which it is even with the old context because of the default, right? and then we'll need a conditional in the test to bump the req?22:55
*** diogogmt has quit IRC22:55
*** thorst_ has quit IRC22:55
*** zhs__ has quit IRC22:56
*** zhs__ has joined #openstack-nova22:56
*** diogogmt has joined #openstack-nova22:56
*** thorst_ has joined #openstack-nova22:56
tonybdansmith: it's always there because we add it if oslo.context is < 2.5.022:56
dansmithtonyb: you mean we always add it if it's not there (which would be <2.5.0) right? I see now, we're checking the wire format in the first one, which is post-mod22:57
tonybdansmith: so if we pass the attribute as a kwarg to the oldcontext oslo ignores it, if we don't pass it then we get the default22:57
dansmithso yeah, cool22:57
tonybYeah.22:58
*** dimtruck is now known as zz_dimtruck22:58
tonybdansmith: Do we wnat additional tesst to show the old/new combo's work?22:59
dansmithtonyb: you mean a from_dict with the older format?23:00
tonybdansmith: yeah23:00
dansmithI dunno, I mean, I guess that's extra ocd which is good23:01
*** siva_krish has quit IRC23:01
*** david-lyle_ has quit IRC23:01
*** shaohe_feng has quit IRC23:01
dansmithtonyb: so just a test_convert_from_dict_to_dict_version_2_4_x()23:01
dansmithyeah I guess23:01
*** siva_krish has joined #openstack-nova23:02
*** vishwanathj has quit IRC23:02
tonybdansmith: ok I'll do that thing23:02
*** shaohe_feng has joined #openstack-nova23:02
*** siva_krish has quit IRC23:03
*** siva_krish has joined #openstack-nova23:03
*** mriedem has joined #openstack-nova23:03
*** thorst_ has quit IRC23:04
*** abalutoiu has joined #openstack-nova23:05
*** siva_krish has quit IRC23:08
*** abalutoiu has quit IRC23:08
*** shaohe_feng has quit IRC23:12
*** shaohe_feng has joined #openstack-nova23:13
tonybHow do you guys work with the long delays in the check pipeline?  It's a whole new world ;P23:14
dansmithlol23:15
*** artom_ has quit IRC23:16
openstackgerritAnush Krishnamurthy proposed openstack/nova: Deprecate cert option  https://review.openstack.org/34805523:17
*** sdake has joined #openstack-nova23:17
*** artom has joined #openstack-nova23:21
mriedemlong delays?23:21
mriedemtonyb: if you run for reqs PTL, are you going to also run for stable PTL or let it lapse?23:21
mriedemor both?23:22
tonybmriedem: both23:22
*** shaohe_feng has quit IRC23:22
*** shaohe_feng has joined #openstack-nova23:23
tonybmriedem: If I *had* to choose stable would be #1 (unless you know you're going to come back into the fold ;P)23:23
mtreinishtonyb: you should sink one of the ships23:23
*** hoangcx2 has quit IRC23:24
tonybmtreinish: hehe, I could try to fold reqs into stable but that's a bit nuts23:24
*** hoangcx has joined #openstack-nova23:24
*** sdake has quit IRC23:25
openstackgerritJohn Griffith proposed openstack/nova: Implement new attach/detach Cinder flow  https://review.openstack.org/34807923:25
*** artom has quit IRC23:26
jgriffithgahh23:26
*** abalutoiu has joined #openstack-nova23:26
mriedemtonyb: i won't be stable PTL nope23:27
tonybmriedem: ;P23:27
mriedemit's mtreinish's turn23:27
*** artom has joined #openstack-nova23:29
*** abalutoiu_ has joined #openstack-nova23:29
mtreinishI will burn it to the ground23:29
mtreinishyou probably don't want me to do it23:29
mriedemmtreinish: i don't work on a distro anymore23:30
mriedemso meh23:30
mriedemi'm living the CD life now23:31
dansmithlivin' la via loca23:31
dansmither, vida23:31
*** shaohe_feng has quit IRC23:32
*** abalutoiu has quit IRC23:32
mriedemplease don't bring ricky martin into this23:33
*** shaohe_feng has joined #openstack-nova23:33
*** nic has quit IRC23:35
*** Sukhdev has joined #openstack-nova23:36
*** mtanino has quit IRC23:37
*** ducttape_ has joined #openstack-nova23:37
*** tjones has left #openstack-nova23:37
gussdague/dansmith/mikal/mriedem: So my venv concern was that: with an explicit privsep-helper entry in rootwrap filters, the deployer human/tool can easily modify the command to have some specific path that isn't in the usual sudoers $PATH.  There's no opportunity to modify the equivalent hardcoded privsep-helper entry.23:41
mriedemgus: does anyone do that?23:42
*** shaohe_feng has quit IRC23:42
guswell, I was thinking it _had_ to be done for venvs.23:42
*** salv-orlando has joined #openstack-nova23:42
gusdims_: oh, and fwiw, 1am is indeed "too early" for me to be awake ;)23:43
*** shaohe_feng has joined #openstack-nova23:43
gusSo I'm not clear from the overnight review comments or irc backlog - has someone actually tried it in a venv?23:44
*** abalutoiu_ has quit IRC23:45
gusspecifically, I'm wondering if PYTHONPATH gets set correctly via some magic I haven't found yet by code inspection.23:45
*** abalutoiu has joined #openstack-nova23:45
*** Guest9888 has quit IRC23:46
*** salv-orlando has quit IRC23:47
*** Apoorva_ has joined #openstack-nova23:49
*** artom has quit IRC23:50
*** rrecio has quit IRC23:51
tonybgus: I did some testing in a venv, but it was pretty basic23:51
*** artom has joined #openstack-nova23:52
guscool.  so long as privsep-helper starts, I think we're good.23:52
*** Apoorva has quit IRC23:52
tonybgus: it replies on privsep-helper being an unqualified filter, PATH being set correctly for the venv and the default (ie missing) exec_dirs23:52
*** shaohe_feng has quit IRC23:53
*** Apoorva_ has quit IRC23:53
*** shaohe_feng has joined #openstack-nova23:53
openstackgerritTony Breeds proposed openstack/nova: Add support for oslo.context 2.6.0  https://review.openstack.org/34260423:54
gus... and (in the venv case) that starts $venv/bin/python, and python's sys.path automatically picks up ../lib - ok, got it.23:54
clarkbif you activate a venv it sets $PATH properly too23:54
*** diogogmt has quit IRC23:55
tonybclarkb: Yeah you have to activate the venv or $PATH is incorrect but sys.path is ok23:56
*** code-R_ has quit IRC23:56
gusclarkb: not on the other side of sudo - which resets all the good bits of the environment.23:56
clarkbgus: right you'd have to sudo -E or source the activate file as part of your sudo command23:57
*** hoangcx2 has joined #openstack-nova23:58
mriedemgus: odyssey4me said they'd be testing it out in openstack-ansible too once it landed and was released23:58
gustonyb: it looks like rootwrap uses exec_dirs to find the executable, but doesn't actually propagate exec_dirs into PATH.  So it will be able to start privsep-helper fine, but privsep-helper won't be able to find any other commands in the venv if required.  I think that's probably fine in practice.23:58
mriedemi'm not sure that the rootwrap 5.0.0 release is queued up though23:59
gusmriedem: sure, I was hoping we could test it before then however ;)   .. as we have no done.23:59
mriedemoh here it is https://review.openstack.org/#/c/347983/23:59
gus*now done.23:59
mriedemgus: yeah the fear is having this creep to far23:59
mriedemwe want to land it and get it burnt in23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!