Monday, 2016-05-09

*** shaohe_feng has quit IRC00:02
*** shaohe_feng has joined #openstack-nova00:03
*** darrenc is now known as darren_afk00:09
*** shaohe_feng has quit IRC00:13
*** tbachman has joined #openstack-nova00:13
*** shaohe_feng has joined #openstack-nova00:13
*** ircuser-1 has quit IRC00:14
*** shaohe_feng has quit IRC00:23
*** sacharya has joined #openstack-nova00:23
*** shaohe_feng has joined #openstack-nova00:23
*** darren_afk is now known as darrenc00:23
*** sacharya has quit IRC00:29
*** markvoelker has quit IRC00:30
*** testUname has joined #openstack-nova00:30
*** Guest460 is now known as mfisch00:32
*** mfisch is now known as Guest8170400:32
*** shaohe_feng has quit IRC00:33
*** shaohe_feng has joined #openstack-nova00:33
*** baoli has joined #openstack-nova00:38
*** testUname has quit IRC00:39
*** jinxing has joined #openstack-nova00:39
*** vilobhmm11 has joined #openstack-nova00:40
*** jwcroppe has quit IRC00:42
*** shaohe_feng has quit IRC00:43
*** shaohe_feng has joined #openstack-nova00:44
*** itlinux has joined #openstack-nova00:48
*** ivase has quit IRC00:51
*** ivase has joined #openstack-nova00:52
*** shaohe_feng has quit IRC00:54
*** shaohe_feng has joined #openstack-nova00:54
*** catintheroof has joined #openstack-nova00:55
*** cheneydc has joined #openstack-nova00:56
*** itlinux has quit IRC00:57
*** iceyao has joined #openstack-nova01:02
*** iceyao_ has joined #openstack-nova01:03
*** shaohe_feng has quit IRC01:04
*** iceyao has quit IRC01:07
*** shaohe_feng has joined #openstack-nova01:07
*** EinstCra_ has joined #openstack-nova01:09
*** shaohe_feng has quit IRC01:14
*** shaohe_feng has joined #openstack-nova01:14
*** ljxiash has joined #openstack-nova01:22
*** fishcried has joined #openstack-nova01:23
*** shaohe_feng has quit IRC01:24
*** shaohe_feng has joined #openstack-nova01:25
*** ducttape_ has joined #openstack-nova01:28
*** ducttape_ has quit IRC01:33
*** jwcroppe has joined #openstack-nova01:35
*** shaohe_feng has quit IRC01:35
*** shaohe_feng has joined #openstack-nova01:35
*** kengo_sakai has joined #openstack-nova01:37
*** ivase_ has joined #openstack-nova01:39
*** jwcroppe has quit IRC01:40
*** ivase has quit IRC01:42
*** kengo_sakai has quit IRC01:42
*** baoli has quit IRC01:43
*** EinstCra_ is now known as EinstCrazy01:44
*** shaohe_feng has quit IRC01:45
*** shaohe_feng has joined #openstack-nova01:46
*** shaohe_feng has quit IRC01:55
openstackgerritbyhan proposed openstack/nova: modify comment  https://review.openstack.org/31395601:55
*** shaohe_feng has joined #openstack-nova01:56
*** houming has joined #openstack-nova01:56
*** Fdaisuke has joined #openstack-nova01:58
*** kengo_sakai has joined #openstack-nova02:02
*** ljxiash has quit IRC02:02
*** ljxiash has joined #openstack-nova02:03
*** shaohe_feng has quit IRC02:05
*** ljxiash has quit IRC02:06
*** ljxiash has joined #openstack-nova02:06
*** dedery has quit IRC02:06
*** shaohe_feng has joined #openstack-nova02:06
*** hoangcx has joined #openstack-nova02:07
*** ociuhandu has quit IRC02:15
*** shaohe_feng has quit IRC02:16
*** shaohe_feng has joined #openstack-nova02:16
openstackgerritZhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_pci_device  https://review.openstack.org/30761502:18
*** vilobhmm11 has quit IRC02:23
*** shaohe_feng has quit IRC02:26
*** shaohe_feng has joined #openstack-nova02:27
*** sacharya has joined #openstack-nova02:27
*** jwcroppe has joined #openstack-nova02:29
openstackgerritZhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_instance_faults  https://review.openstack.org/30712602:32
*** iceyao has joined #openstack-nova02:33
*** itlinux has joined #openstack-nova02:33
*** jwcroppe has quit IRC02:34
*** iceyao_ has quit IRC02:35
*** shaohe_feng has quit IRC02:36
*** shaohe_feng has joined #openstack-nova02:37
openstackgerritAlex Xu proposed openstack/nova: Add api-sample test for showing quota detail  https://review.openstack.org/31395902:37
openstackgerritAlex Xu proposed openstack/nova: Complete method verification of os-quotes  https://review.openstack.org/31396002:37
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Allow user to define the shutdown method through API when stop instances  https://review.openstack.org/29379002:40
*** salv-orlando has joined #openstack-nova02:42
*** baoli has joined #openstack-nova02:44
*** iceyao has quit IRC02:44
*** shaohe_feng has quit IRC02:46
*** salv-orlando has quit IRC02:47
*** shaohe_feng has joined #openstack-nova02:47
*** baoli has quit IRC02:49
*** ljxiash has quit IRC02:50
*** ljxiash has joined #openstack-nova02:50
openstackgerritZhenyu Zheng proposed openstack/nova: Add check of capabilities for detach interface  https://review.openstack.org/30811502:51
openstackgerritAlex Xu proposed openstack/nova: Complete method verification of os-shevle  https://review.openstack.org/31396102:52
*** ljxiash has quit IRC02:54
*** ljxiash has joined #openstack-nova02:54
openstackgerritAlex Xu proposed openstack/nova: Complete method verification of os-shevle  https://review.openstack.org/31396102:55
*** shaohe_feng has quit IRC02:57
*** shaohe_feng has joined #openstack-nova02:58
*** Guest81704 is now known as mfisch03:03
*** mfisch is now known as Guest3001803:04
*** sorrison_laptop has quit IRC03:05
*** shaohe_feng has quit IRC03:07
*** amotoki has joined #openstack-nova03:07
*** shaohe_feng has joined #openstack-nova03:08
openstackgerritAlex Xu proposed openstack/nova: Compelete method verification of os-servers-admin  https://review.openstack.org/31396603:09
*** Sukhdev has joined #openstack-nova03:09
*** iceyao has joined #openstack-nova03:09
*** ljxiash has quit IRC03:10
*** ljxiash has joined #openstack-nova03:11
*** sheel has joined #openstack-nova03:14
*** ljxiash has quit IRC03:15
*** shaohe_feng has quit IRC03:17
*** amotoki has quit IRC03:18
*** shaohe_feng has joined #openstack-nova03:18
*** markvoelker has joined #openstack-nova03:26
*** shaohe_feng has quit IRC03:27
*** shaohe_feng has joined #openstack-nova03:28
*** markvoel_ has joined #openstack-nova03:29
*** zz_dimtruck is now known as dimtruck03:29
*** ljxiash has joined #openstack-nova03:29
*** ducttape_ has joined #openstack-nova03:29
openstackgerritJohn Hua proposed openstack/nova: XenAPI: Remove ovs_integration_bridge default value  https://review.openstack.org/29909203:31
*** markvoelker has quit IRC03:32
*** RuiChen has joined #openstack-nova03:32
*** ducttape_ has quit IRC03:34
*** roeyc has joined #openstack-nova03:37
*** shaohe_feng has quit IRC03:38
*** shaohe_feng has joined #openstack-nova03:39
*** amotoki has joined #openstack-nova03:40
*** ljxiash has quit IRC03:40
*** ljxiash has joined #openstack-nova03:41
*** claudiub has joined #openstack-nova03:42
*** vilobhmm11 has joined #openstack-nova03:43
*** links has joined #openstack-nova03:44
*** ljxiash has quit IRC03:45
*** salv-orlando has joined #openstack-nova03:46
*** salv-orlando has quit IRC03:48
*** shaohe_feng has quit IRC03:48
*** shaohe_feng has joined #openstack-nova03:49
*** roeyc has quit IRC03:55
*** Sukhdev has quit IRC03:55
*** catintheroof has quit IRC03:56
*** fragatina has quit IRC03:58
*** shaohe_feng has quit IRC03:58
*** salv-orlando has joined #openstack-nova03:59
*** shaohe_feng has joined #openstack-nova03:59
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove APIRouter of legacy v2 API code  https://review.openstack.org/31390204:00
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove legacy v2 tests which use APIRouter  https://review.openstack.org/31318504:00
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Switch api unit tests to use v2.1 API  https://review.openstack.org/31390104:00
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove legacy v2 API tests which use wsgi_app()  https://review.openstack.org/31319204:00
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove fping dependency on legacy v2 API code  https://review.openstack.org/31291004:00
*** sacharya has quit IRC04:02
*** jwcroppe has joined #openstack-nova04:03
*** salv-orlando has quit IRC04:03
*** itamarl has quit IRC04:05
*** shaohe_feng has quit IRC04:08
*** dimtruck is now known as zz_dimtruck04:09
*** zz_dimtruck is now known as dimtruck04:09
*** shaohe_feng has joined #openstack-nova04:09
*** jwcroppe has quit IRC04:11
*** fragatina has joined #openstack-nova04:13
*** fragatina has quit IRC04:18
*** dimtruck is now known as zz_dimtruck04:19
*** shaohe_feng has quit IRC04:19
*** sree has joined #openstack-nova04:19
*** shaohe_feng has joined #openstack-nova04:19
*** browne has joined #openstack-nova04:21
*** fragatina has joined #openstack-nova04:29
*** shaohe_feng has quit IRC04:29
*** fragatina has quit IRC04:29
*** browne has quit IRC04:30
*** fragatina has joined #openstack-nova04:30
*** shaohe_feng has joined #openstack-nova04:30
*** ljxiash has joined #openstack-nova04:38
*** shaohe_feng has quit IRC04:39
*** shaohe_feng has joined #openstack-nova04:39
*** mdrabe has quit IRC04:41
*** hoangcx has quit IRC04:45
*** hoangcx has joined #openstack-nova04:45
*** amotoki_ has joined #openstack-nova04:46
*** amotoki has quit IRC04:49
*** shaohe_feng has quit IRC04:49
*** shaohe_feng has joined #openstack-nova04:50
*** irenab has quit IRC04:52
*** kengo_sa_ has joined #openstack-nova04:59
*** shaohe_feng has quit IRC05:00
*** shaohe_feng has joined #openstack-nova05:01
*** thorst has quit IRC05:01
*** fishcried has joined #openstack-nova05:02
*** thorst has joined #openstack-nova05:02
*** fishcried has quit IRC05:03
*** yonglihe has joined #openstack-nova05:04
*** shaohe_feng has quit IRC05:10
*** thorst has quit IRC05:10
*** shaohe_feng has joined #openstack-nova05:10
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove APIRouter of legacy v2 API code  https://review.openstack.org/31390205:15
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Switch api unit tests to use v2.1 API  https://review.openstack.org/31390105:15
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove legacy v2 API tests which use wsgi_app()  https://review.openstack.org/31319205:15
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Remove fping dependency on legacy v2 API code  https://review.openstack.org/31291005:15
*** roeyc has joined #openstack-nova05:16
*** ljxiash has quit IRC05:18
*** sridharg has joined #openstack-nova05:18
*** ljxiash has joined #openstack-nova05:18
*** prateek has joined #openstack-nova05:18
*** sudipto has joined #openstack-nova05:18
*** liverpooler has joined #openstack-nova05:18
*** ljxiash has quit IRC05:19
*** ljxiash has joined #openstack-nova05:19
*** markvoel_ has quit IRC05:20
*** shaohe_feng has quit IRC05:20
*** shaohe_feng has joined #openstack-nova05:21
*** salv-orlando has joined #openstack-nova05:23
*** apoorv has joined #openstack-nova05:27
*** salv-orlando has quit IRC05:30
*** ducttape_ has joined #openstack-nova05:30
*** shaohe_feng has quit IRC05:30
*** itlinux has quit IRC05:31
*** ljxiash has quit IRC05:34
*** ducttape_ has quit IRC05:34
*** irenab has joined #openstack-nova05:35
*** amotoki_ has quit IRC05:35
*** shaohe_feng has joined #openstack-nova05:35
*** salv-orlando has joined #openstack-nova05:36
*** salv-orlando has quit IRC05:36
*** salv-orlando has joined #openstack-nova05:36
*** liverpooler has quit IRC05:38
*** klkumar has joined #openstack-nova05:38
*** liverpooler has joined #openstack-nova05:39
*** ljxiash has joined #openstack-nova05:39
*** rcernin has joined #openstack-nova05:40
*** shaohe_feng has quit IRC05:41
*** shaohe_feng has joined #openstack-nova05:41
*** salv-orl_ has joined #openstack-nova05:42
*** salv-orlando has quit IRC05:45
*** roeyc has quit IRC05:45
*** esracelik has joined #openstack-nova05:46
*** sl_ has joined #openstack-nova05:47
*** dedery has joined #openstack-nova05:47
*** sl_ has quit IRC05:48
*** jinxing has quit IRC05:49
*** jaypipes has joined #openstack-nova05:50
openstackgerritbailin.zhang proposed openstack/nova: Create VM failed, unplug vifs  https://review.openstack.org/30621905:50
*** shaohe_feng has quit IRC05:51
*** amotoki has joined #openstack-nova05:51
*** kengo_sa_ has quit IRC05:52
*** jwcroppe has joined #openstack-nova05:52
*** shaohe_feng has joined #openstack-nova05:53
openstackgerritDinesh Bhor proposed openstack/nova: Fix flavor-create raises 500 error  https://review.openstack.org/31323405:54
*** adisky has joined #openstack-nova05:55
*** jwcroppe has quit IRC05:57
*** mjura has joined #openstack-nova05:57
*** kengo_sa_ has joined #openstack-nova05:58
*** shaohe_feng has quit IRC06:01
*** shaohe_feng has joined #openstack-nova06:01
*** sacharya has joined #openstack-nova06:03
*** mjura has quit IRC06:04
*** mjura has joined #openstack-nova06:04
*** sacharya has quit IRC06:08
*** Daisy has joined #openstack-nova06:08
*** Daisy_ has joined #openstack-nova06:09
*** thorst has joined #openstack-nova06:10
*** afazekas_ is now known as afazekas06:10
openstackgerritZhenyu Zheng proposed openstack/nova: Remove mox in tests/unit/objects/test_security_group  https://review.openstack.org/30713506:10
*** gcb has joined #openstack-nova06:10
*** shaohe_feng has quit IRC06:11
*** Daisy has quit IRC06:12
*** shaohe_feng has joined #openstack-nova06:12
*** kengo_sa_ has quit IRC06:13
*** markvoelker has joined #openstack-nova06:14
*** thorst has quit IRC06:15
*** dedery has quit IRC06:16
*** Oku_OS-away is now known as Oku_OS06:17
*** markvoelker has quit IRC06:19
*** shaohe_feng has quit IRC06:22
*** paul-carlton2 has joined #openstack-nova06:24
*** shaohe_feng has joined #openstack-nova06:24
*** klkumar has quit IRC06:25
*** salv-orl_ has quit IRC06:29
*** paul-carlton2 has quit IRC06:30
*** sree has quit IRC06:32
*** shaohe_feng has quit IRC06:32
*** jwcroppe has joined #openstack-nova06:33
*** shaohe_feng has joined #openstack-nova06:37
*** paul-carlton2 has joined #openstack-nova06:41
*** shaohe_feng has quit IRC06:42
*** itamarl has joined #openstack-nova06:42
*** shaohe_feng has joined #openstack-nova06:43
*** xek__ is now known as xek06:43
*** andymaier has joined #openstack-nova06:46
*** openstackgerrit has quit IRC06:47
*** openstackgerrit has joined #openstack-nova06:48
*** lpetrut has joined #openstack-nova06:51
*** shaohe_feng has quit IRC06:52
*** shaohe_feng has joined #openstack-nova06:55
*** jwcroppe has quit IRC06:56
*** jwcroppe has joined #openstack-nova07:00
*** tesseract has joined #openstack-nova07:01
*** shaohe_feng has quit IRC07:03
*** shaohe_feng has joined #openstack-nova07:04
*** sacharya has joined #openstack-nova07:04
*** fragatina has quit IRC07:04
*** jlanoux has joined #openstack-nova07:06
*** vtech has joined #openstack-nova07:08
*** sacharya has quit IRC07:08
*** markus_z has joined #openstack-nova07:12
openstackgerritAnkit Agrawal proposed openstack/nova: Move is_volume_backed_instance to compute.utils  https://review.openstack.org/27048207:12
openstackgerritAnkit Agrawal proposed openstack/nova: Fix evaluation of host disk usage by volume-backed instances  https://review.openstack.org/20087007:12
*** laszloh has joined #openstack-nova07:12
*** shaohe_feng has quit IRC07:13
*** sfinucan has joined #openstack-nova07:16
*** shaohe_feng has joined #openstack-nova07:18
*** mpavone has joined #openstack-nova07:19
*** esracelik has quit IRC07:20
*** gokhan_ has quit IRC07:20
openstackgerritTom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors  https://review.openstack.org/26767307:21
*** dedery has joined #openstack-nova07:22
*** hshiina has joined #openstack-nova07:22
*** shaohe_feng has quit IRC07:23
*** shaohe_feng has joined #openstack-nova07:24
*** ljxiash has quit IRC07:25
*** vtech_ has joined #openstack-nova07:26
*** vtech has quit IRC07:26
*** ducttape_ has joined #openstack-nova07:31
*** jichen has joined #openstack-nova07:31
*** gokhan_ has joined #openstack-nova07:33
*** esracelik has joined #openstack-nova07:33
*** shaohe_feng has quit IRC07:33
*** shaohe_feng has joined #openstack-nova07:34
*** ljxiash has joined #openstack-nova07:35
*** ducttape_ has quit IRC07:36
*** haukebruno has joined #openstack-nova07:36
*** Daisy_ has quit IRC07:37
*** Daisy has joined #openstack-nova07:37
*** fishcried has joined #openstack-nova07:38
*** voelzmo has joined #openstack-nova07:39
*** lpetrut has quit IRC07:40
*** shaohe_feng has quit IRC07:44
*** shaohe_feng has joined #openstack-nova07:44
*** daemontool has joined #openstack-nova07:45
*** vtech_ has quit IRC07:45
*** vtech has joined #openstack-nova07:45
openstackgerritTom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors  https://review.openstack.org/26767307:49
*** scheuran has joined #openstack-nova07:51
*** shaohe_feng has quit IRC07:54
bauzas_offgood morning Nova07:54
*** shaohe_feng has joined #openstack-nova07:55
*** salv-orlando has joined #openstack-nova08:01
*** paul-carlton2 has quit IRC08:02
*** markvoelker has joined #openstack-nova08:03
*** shaohe_feng has quit IRC08:04
*** shaohe_feng has joined #openstack-nova08:05
*** klkumar has joined #openstack-nova08:06
*** derekh has joined #openstack-nova08:07
*** markvoelker has quit IRC08:07
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334508:10
*** sridharg has quit IRC08:10
*** shaohe_feng has quit IRC08:14
*** PaulMurray has joined #openstack-nova08:15
PaulMurrayGood morning08:16
*** thorst has joined #openstack-nova08:17
*** openstackgerrit has quit IRC08:17
*** openstackgerrit has joined #openstack-nova08:18
*** jaosorior has joined #openstack-nova08:19
*** lucas-afk has quit IRC08:19
*** shaohe_feng has joined #openstack-nova08:20
*** danpb has joined #openstack-nova08:21
*** daemontool has quit IRC08:21
*** houming has quit IRC08:22
*** jed56 has joined #openstack-nova08:24
*** lucasagomes has joined #openstack-nova08:24
*** shaohe_feng has quit IRC08:25
*** thorst has quit IRC08:25
*** shaohe_feng has joined #openstack-nova08:26
*** scheuran has quit IRC08:27
*** andreas_s has joined #openstack-nova08:29
*** adisky has quit IRC08:30
*** jistr has joined #openstack-nova08:32
*** paul-carlton2 has joined #openstack-nova08:33
*** lpetrut has joined #openstack-nova08:34
*** shaohe_feng has quit IRC08:35
*** shaohe_feng has joined #openstack-nova08:36
*** fragatina has joined #openstack-nova08:36
*** yassine has joined #openstack-nova08:38
*** yassine is now known as Guest2830508:39
*** Guest28305 is now known as yassou08:39
openstackgerritSylvain Bauza proposed openstack/nova: Add requested_destination field to RequestSpec  https://review.openstack.org/31275708:39
*** jamielennox is now known as jamielennox|away08:40
*** Daisy has quit IRC08:41
*** Daisy has joined #openstack-nova08:42
*** shaohe_feng has quit IRC08:45
*** shaohe_feng has joined #openstack-nova08:46
*** Daisy has quit IRC08:46
*** sridharg has joined #openstack-nova08:49
*** lpetrut has quit IRC08:49
*** belmoreira has joined #openstack-nova08:49
*** shaohe_feng has quit IRC08:55
*** shaohe_feng has joined #openstack-nova08:56
*** lpetrut has joined #openstack-nova08:57
*** cdent has joined #openstack-nova08:58
*** zhongshengping has joined #openstack-nova08:58
*** moshele has joined #openstack-nova09:01
*** jlanoux has quit IRC09:03
*** jlanoux has joined #openstack-nova09:03
*** mkoderer__ has joined #openstack-nova09:03
*** sacharya has joined #openstack-nova09:05
*** dedery has quit IRC09:05
*** vilobhmm11 has quit IRC09:06
*** shaohe_feng has quit IRC09:06
*** shaohe_feng has joined #openstack-nova09:06
*** sacharya has quit IRC09:10
*** ljxiash has quit IRC09:10
*** Daisy has joined #openstack-nova09:12
*** kolesovdv has joined #openstack-nova09:13
*** ljxiash has joined #openstack-nova09:13
*** vilobhmm11 has joined #openstack-nova09:14
*** salv-orlando has quit IRC09:14
*** vilobhmm11 has quit IRC09:14
*** shaohe_feng has quit IRC09:16
*** vilobhmm11 has joined #openstack-nova09:16
*** Jeffrey4l_ has quit IRC09:16
*** shaohe_feng has joined #openstack-nova09:17
*** lpetrut has quit IRC09:17
*** lpetrut has joined #openstack-nova09:17
*** Daisy_ has joined #openstack-nova09:22
*** lpetrut has quit IRC09:23
*** Jeffrey4l_ has joined #openstack-nova09:23
*** mvk has joined #openstack-nova09:23
*** Daisy has quit IRC09:25
*** shaohe_feng has quit IRC09:26
*** shaohe_feng has joined #openstack-nova09:27
*** hshiina has quit IRC09:29
*** zhongshengping has quit IRC09:31
*** ducttape_ has joined #openstack-nova09:32
*** sfinucan has quit IRC09:32
*** sfinucan has joined #openstack-nova09:32
*** klkumar has quit IRC09:34
*** ducttape_ has quit IRC09:36
*** shaohe_feng has quit IRC09:36
*** shaohe_feng has joined #openstack-nova09:38
markus_zalex_xu: Could you take a look at https://review.openstack.org/#/c/309196/5/nova/conf/api.py please? The config option "osapi_hide_server_address_states" looks like it should be deprecated.09:40
*** cheneydc has quit IRC09:41
*** lpetrut has joined #openstack-nova09:44
*** vtech_ has joined #openstack-nova09:44
*** vtech has quit IRC09:44
*** daemontool has joined #openstack-nova09:45
*** shaohe_feng has quit IRC09:47
*** shaohe_feng has joined #openstack-nova09:47
*** baoli has joined #openstack-nova09:50
*** nkrinner_afk has quit IRC09:50
*** jwcroppe has quit IRC09:51
*** markvoelker has joined #openstack-nova09:51
*** baoli has quit IRC09:54
*** Sharath_ has joined #openstack-nova09:55
Sharath_Help09:55
*** markvoelker has quit IRC09:56
*** gszasz has joined #openstack-nova09:56
Sharath_ may i know how NFS maintained in VM cold migration ?09:56
Sharath_in cold migration , vm shutdown and boots up , which folders will be copied to new VM and who will initiate that process ?09:56
*** shaohe_feng has quit IRC09:57
*** yassou has quit IRC09:57
*** sambetts|afk is now known as sambetts09:57
Sharath_kindly help09:57
*** shaohe_feng has joined #openstack-nova09:58
*** sdague has joined #openstack-nova10:01
*** nkrinner_afk has joined #openstack-nova10:02
*** hshiina has joined #openstack-nova10:02
openstackgerritSean Dague proposed openstack/nova: api-ref: method verification and fixes for servers.inc  https://review.openstack.org/31351410:05
openstackgerritSean Dague proposed openstack/nova: WIP: api-ref: working on parameters validation for servers  https://review.openstack.org/31353210:05
*** shaohe_feng has quit IRC10:07
*** ljxiash has quit IRC10:08
*** klkumar has joined #openstack-nova10:09
Sharath_Help10:09
openstackgerritSean Dague proposed openstack/nova: Complete method verification of os-quotas  https://review.openstack.org/31396010:09
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334510:10
*** shaohe_feng has joined #openstack-nova10:10
*** daemontool_ has joined #openstack-nova10:11
*** Daisy_ has quit IRC10:13
*** Daisy has joined #openstack-nova10:14
*** daemontool has quit IRC10:14
*** hoangcx has quit IRC10:15
sdaguealex_xu: thanks for the catch on those return code issues10:15
*** rookie has quit IRC10:16
*** rook-lap has joined #openstack-nova10:16
*** ivase_ has quit IRC10:16
danpb....we seem to have a never ending supply of patches moving config options10:16
* danpb wonders how many more until we are done with this10:16
*** ivase has joined #openstack-nova10:16
mdboothdanpb: When they're all moved?10:17
* danpb considers just bulk approving them all10:17
*** shaohe_feng has quit IRC10:17
*** Daisy has quit IRC10:18
*** shaohe_feng has joined #openstack-nova10:18
*** dedery has joined #openstack-nova10:19
*** apoorv has quit IRC10:20
*** Sharath_ has left #openstack-nova10:20
*** yamahata has quit IRC10:21
mdboothdanpb: Why not? For big mechanical cleanup like that we should do way more of that.10:22
mdboothThey're merge conflict magnets.10:22
*** EinstCrazy has quit IRC10:22
*** gcb has quit IRC10:23
mdboothdanpb: Unrelated, imagine I want to move a file currently in use by a domain. I can obviously just move it and trust that the kernel will keep it open for qemu, but say I want to ensure that anybody looking at the domain xml will also see the updated path. Is there a simple way to achieve that?10:24
openstackgerritDaniel Berrange proposed openstack/nova: config: remove deprecated ironic.client_log_level  https://review.openstack.org/31200610:26
openstackgerritPrateek Arora proposed openstack/nova: Separate out the conf entries for iSCSI and FC multipath drivers  https://review.openstack.org/31067910:26
*** rook-lap has quit IRC10:27
openstackgerritRajesh Tailor proposed openstack/nova: Trivial-Fix: Remove unreachable code  https://review.openstack.org/31404010:28
*** thorst has joined #openstack-nova10:28
*** shaohe_feng has quit IRC10:28
*** jwcroppe has joined #openstack-nova10:29
danpbmdbooth: i don't think there's any way to force update the xml in that scenario10:30
mdboothdanpb: Ok, thanks. Might not be important.10:30
*** shaohe_feng has joined #openstack-nova10:30
*** daemontool__ has joined #openstack-nova10:31
*** vilobhmm11 has quit IRC10:31
danpbmdbooth: i'm trying to think if there's any scenario in which qemu would be unhappy with us renaming the file behind its back10:31
* mdbooth would hope not.10:32
danpbspecifically what scenarios might cause qemu to try to close + reopen its existing file10:32
mdboothAh, good point10:32
mdboothFor a disk?10:32
*** jwcroppe has quit IRC10:33
danpbjust asking the qemu folks for an opinion10:34
*** daemontool_ has quit IRC10:34
mdboothdanpb: How about a reboot initiated by the domain?10:34
danpba pure reboot is safe as qemu never stops running10:34
mdboothOk10:34
*** kengo_sa_ has joined #openstack-nova10:35
*** thorst has quit IRC10:35
mdboothdanpb: Can I do something like undefine the domain and redefine it with its new location, all without stopping it?10:36
danpbsure, you can change the persistent config at any time10:36
danpbits not reflected in the live config10:36
mdboothOk10:36
*** daemontool has joined #openstack-nova10:36
danpbfwiw, kwolf says that qemu closes+opens when it needs to make a backing file writable in order to merge two cow layers10:37
danpbopenstack doesn't do that, so you should be safe with renaming10:37
mdboothdanpb: Thanks10:37
*** daemontool__ has quit IRC10:37
*** shaohe_feng has quit IRC10:38
*** ivase has quit IRC10:39
*** shaohe_feng has joined #openstack-nova10:39
*** kengo_sa_ has quit IRC10:40
*** rook-lap has joined #openstack-nova10:40
*** daemontool_ has joined #openstack-nova10:40
kashyapmdbooth: On a related note, you might've noticed -- an example of undefine + redefine, libvirt blockcopy works only by an explicit undefine; perform blockcopy; redefine sequence.10:41
mdboothkashyap: Yeah, that's what made me think of it. I guess that doesn't update the running qemu process's config though, right?10:41
danpbmdbooth: dman, there's another case - when doing live snapshot the original image is reopened to become a backing file10:42
danpbs/dman/damn/10:42
danpband that'll affect openstacak10:42
kashyapAnd, blockcopy jobs last forever until canceled, which implies they last across domain restarts -- but QEMU doesn't yet provide a way to restart a copy operation on domain restart.10:42
mdboothdanpb: Of course10:42
*** daemontool__ has joined #openstack-nova10:43
mdboothdanpb: We could hardlink it, but then we'd still have to manage the lifecycle of the hardlinks10:43
kashyapmdbooth: (True, to answer your q., that doesn't update the runing config.)10:44
*** daemontool has quit IRC10:44
danpbmdbooth: what exactly are you renaming and why ?10:44
*** mariusv has joined #openstack-nova10:45
*** mariusv has quit IRC10:45
*** mariusv has joined #openstack-nova10:45
mdboothI'm reviewing paul-carlton2 's libvirt storage pools spec and thinking through upgrade scenarios10:45
mdboothI'm trying to think of a way we could bulk update everything without disruption10:45
danpbi was assuming we'd setup pools against the existing locations10:46
mdboothdanpb: Right, but currently local file storage has many locations10:46
*** daemontool_ has quit IRC10:46
mdboothWhereas ceph and lvm, for eg, have only 110:46
danpbmdbooth: the per-instance directories ?10:47
mdboothYes10:47
mdboothSo using storage pools for local storage is an option, but it's ugly10:47
mdboothYou need a pool per-instance10:47
* mdbooth wishes libvirt directory storage pools could handle subdirectories10:47
danpbyeah10:47
*** dmellado|off is now known as dmellado10:47
*** shaohe_feng has quit IRC10:48
*** shaohe_feng has joined #openstack-nova10:49
mdboothdanpb: Anyway, it would be cleaner to merge them, and also to have separate pools for separate backend types10:50
mdbootheg qcow2 vs 'raw'10:50
mdboothThat be a common scenario as it happens, as the default storage type is qcow2, but config disks are always 'raw'10:50
*** daemontool_ has joined #openstack-nova10:51
mdboothExcept when using rbd10:51
*** baoli has joined #openstack-nova10:51
markus_zjohnthetubaguy: I was thinking about https://review.openstack.org/#/c/309196/5 and the removal of the legacy_v2 code.10:55
*** baoli has quit IRC10:55
*** daemontool__ has quit IRC10:55
johnthetubaguymarkus_z: yep yep10:56
markus_zjohnthetubaguy: I think it would be better to get the move of the options merged before the removal deletes the legacy_v2 coe10:56
markus_z*code10:56
markus_zjohnthetubaguy: This makes me believe that it would be the better approach: https://review.openstack.org/#/c/312910/910:56
sdaguemarkus_z: honestly, the legacy_v2 code removal is moving faster than configs10:57
sdagueI don't want to hold up that work10:57
markus_zsdague: Hm. IMO the api config options could be merge today.10:58
sdaguemarkus_z: ok, it had a ton of -1s on it10:58
johnthetubaguybut the removal could merge in a few mins10:58
*** cdent has left #openstack-nova10:58
sdagueright, exactly10:58
johnthetubaguywell, could get a +W soon10:58
*** shaohe_feng has quit IRC10:58
markus_zah, well, OK. Than it would be done when edleafe comes online10:59
sdaguemaybe, that patch goes back to apr 20th10:59
*** daemontool__ has joined #openstack-nova10:59
johnthetubaguyits seems fine to rebase on the removal11:00
*** apoorv has joined #openstack-nova11:00
sdagueI get the concern of merge conflicts happening, but that's just kind of the cost of the conf work. It is both the giver and recipient of lots of merge conflicts11:00
openstackgerritJohn Hua proposed openstack/nova: XenAPI: Remove ovs_integration_bridge default value  https://review.openstack.org/29909211:00
markus_zsdague: It is one of the last 2 big chunks and I wanted it to get merged soon, that was my concern.11:00
mdboothChunking it is definitely a big help11:00
sdaguemarkus_z: right, but edleafe is going to need to fix that patch anyway, so now it will just need rebasing as well11:01
sdagueif that patch was clear to merge, I'd be fine rebasing on top of it11:01
markus_zOK, then lets merge legacy_v2 first. I'm going to post an update of the config options work today on the ML.11:01
markus_zbrb, meeting11:01
*** shaohe_feng has joined #openstack-nova11:02
sdaguebut I'm really not ok, holding up mergable nearly approved patches on patches that need work in an unrelated area.11:02
*** iceyao has quit IRC11:02
sdaguehmmm... anyone have the IRC nick for Sergey Nikitin ?11:03
*** daemontool_ has quit IRC11:03
*** daemontool has joined #openstack-nova11:04
johnthetubaguysniktin I thought, but I don't see him11:05
*** sacharya has joined #openstack-nova11:05
*** daemontool_ has joined #openstack-nova11:06
*** kengo_sa_ has joined #openstack-nova11:07
*** rodrigods has quit IRC11:07
*** rodrigods has joined #openstack-nova11:07
*** daemontool__ has quit IRC11:07
*** daemontool__ has joined #openstack-nova11:08
*** shaohe_feng has quit IRC11:09
*** shaohe_feng has joined #openstack-nova11:10
*** yassine has joined #openstack-nova11:10
*** daemontool has quit IRC11:10
*** yassine is now known as Guest5287411:10
*** sacharya has quit IRC11:10
sfinucanjohnthetubaguy: Should the NUMA/CPU pinning docs be tagged with the feature classification bp? https://review.openstack.org/#/c/312959/11:11
*** daemontool has joined #openstack-nova11:11
johnthetubaguysfinucan: not sure that makes sense, until they hit the ini file11:12
*** kengo_sa_ has quit IRC11:12
*** daemontool_ has quit IRC11:12
kashyapbauzas_off (or anyone): When you're 'on', is this due to mixing Mock and Mox? Or something else? -- https://review.openstack.org/#/c/314012/211:12
johnthetubaguysfinucan: it might be worth a little spec less BP for tracking all the docs adds, but its not required for merge11:12
* kashyap will be afk for an hour-ish in a bit, will come back and check scroll11:12
sfinucanjohnthetubaguy: OK, sounds fair11:12
sfinucanI'll add to an appropriate ini (if possible) next11:13
*** Guest52874 is now known as yassou11:13
*** daemontool_ has joined #openstack-nova11:14
johnthetubaguysfinucan: I am reworking the ini stuff right now11:14
johnthetubaguysfinucan: worth holding off on that bit11:14
*** daemontool__ has quit IRC11:15
*** jaosorior has quit IRC11:15
*** jaosorior has joined #openstack-nova11:16
*** klkumar has quit IRC11:17
*** daemontool has quit IRC11:18
paul-carlton2mdbooth, looking at your comments on libvirt storage pools spec.11:18
*** shaohe_feng has quit IRC11:19
sdaguejohnthetubaguy: ok, yeh, I was hoping for someone familiar with the server tags to actually write any user documentation for it, especially because things like the list behavior isn't super clear from the code11:19
*** shaohe_feng has joined #openstack-nova11:20
johnthetubaguysdague: ah, good idea. jaypipes might be able to track them down.11:20
paul-carlton2I'm thinking we need a directory type pool to hold any disk files (data disks, config drive or swap) that are on the 'local' disk11:20
paul-carlton2Don't see how it matters what type of backend we are using, the pool is simply a directory that will contain these files be that raw (NoBacking) or Qcow211:22
*** jwcroppe has joined #openstack-nova11:23
paul-carlton2If lvm, ploop or rbd backends are used then a separate pool, nova-lvm-pool, nova-ploop-pool or nova-rbd-pool will be created of the appropriate type to manage disk files stored there11:24
*** cdent has joined #openstack-nova11:25
*** smatzek has joined #openstack-nova11:26
*** jwcroppe has quit IRC11:28
*** shaohe_feng has quit IRC11:29
*** cdent has left #openstack-nova11:30
*** shaohe_feng has joined #openstack-nova11:30
*** danpb has quit IRC11:31
*** ducttape_ has joined #openstack-nova11:32
*** danpb has joined #openstack-nova11:33
*** jaosorior has quit IRC11:33
*** jaosorior has joined #openstack-nova11:33
*** amotoki has quit IRC11:36
*** ducttape_ has quit IRC11:37
*** markvoelker has joined #openstack-nova11:39
*** shaohe_feng has quit IRC11:39
*** shaohe_feng has joined #openstack-nova11:40
*** rtheis has joined #openstack-nova11:42
*** lucasagomes is now known as lucas-hungry11:43
*** markvoelker has quit IRC11:44
openstackgerritMoshe Levi proposed openstack/nova: pci: Deprecate is_new from pci request  https://review.openstack.org/31099011:47
*** sudipto has quit IRC11:48
*** shaohe_feng has quit IRC11:50
*** shaohe_feng has joined #openstack-nova11:51
*** Oku_OS is now known as Oku_OS-away11:51
*** Oku_OS-away is now known as Oku_OS11:51
*** fragatina has quit IRC11:54
alex_xumarkus_z: i feel the whole hide-address-servers extension looks like strange, it should deprecated that whole thing... but that is another thing, not related to this patch.11:55
alex_xusdague: np11:55
markus_zalex_xu: cool, thanks for double-checking. I noted it down as a todo.11:55
alex_xusdague: btw, i tested the servers tags, request to create tag [TAG, tag], i will got 500.11:56
alex_xumarkus_z: np11:56
*** baoli has joined #openstack-nova11:58
openstackgerritChris Dent proposed openstack/nova: WIP resource-pools/placement api  https://review.openstack.org/29310412:00
*** shaohe_feng has quit IRC12:00
*** shaohe_feng has joined #openstack-nova12:00
sdaguealex_xu: that's unfortunate12:00
sdaguealex_xu: I noticed the api samples tests only use a single tag, it's probably worth trying to update them to use multiple12:01
alex_xusdague: yes :(12:01
sdagueI was really wondering how that was all supposed to work in the case of multiple12:01
alex_xusdague: yea, agree12:02
alex_xui may cook a patch tomorrow12:02
openstackgerritPaul Carlton proposed openstack/nova-specs: Use libvirt storage pools  https://review.openstack.org/31050512:02
*** baoli has quit IRC12:03
*** raildo-afk is now known as raildo12:04
*** efried has joined #openstack-nova12:05
openstackgerritClaudiu Belu proposed openstack/nova: WIP: Adds HostCapabilities object model  https://review.openstack.org/28585612:06
*** thorst has joined #openstack-nova12:08
*** aysyd has joined #openstack-nova12:09
sdaguealex_xu: great, thanks12:09
*** ducttape_ has joined #openstack-nova12:10
*** shaohe_feng has quit IRC12:10
*** shaohe_feng has joined #openstack-nova12:13
*** inara has quit IRC12:14
*** baoli has joined #openstack-nova12:14
*** cdent has joined #openstack-nova12:19
claudiubalex_xu: hello. when you have to time, can you take a look at this? https://review.openstack.org/#/c/285856/512:20
openstackgerritjichenjc proposed openstack/nova: Complete method Verification of os-hypervisors  https://review.openstack.org/31202412:20
*** shaohe_feng has quit IRC12:20
claudiubalex_xu: still WIP, but I'm curious about your opinion12:20
*** ducttape_ has quit IRC12:21
*** shaohe_feng has joined #openstack-nova12:21
*** paul-carlton has joined #openstack-nova12:21
alex_xuclaudiub: cool, will check it asap12:21
*** efried has quit IRC12:22
*** apoorv has quit IRC12:23
openstackgerritjichenjc proposed openstack/nova: Complete Verification of server admin action  https://review.openstack.org/31172712:24
*** efried has joined #openstack-nova12:24
*** ivase has joined #openstack-nova12:25
*** thorst has quit IRC12:25
*** thorst has joined #openstack-nova12:26
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Fix exception when vcpu_pin_set is set to ""  https://review.openstack.org/31407612:27
*** Oku_OS is now known as Oku_OS-away12:27
*** sree has joined #openstack-nova12:30
*** edmondsw has joined #openstack-nova12:30
openstackgerritjichenjc proposed openstack/nova: Complete Verification of server-metadata  https://review.openstack.org/31172312:31
*** shaohe_feng has quit IRC12:31
*** shaohe_feng has joined #openstack-nova12:31
*** thorst has quit IRC12:31
*** thorst has joined #openstack-nova12:32
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353212:33
*** markvoelker has joined #openstack-nova12:33
*** sree__ has joined #openstack-nova12:35
*** sree has quit IRC12:35
*** thorst has quit IRC12:37
*** rfolco has joined #openstack-nova12:37
*** Oku_OS-away is now known as Oku_OS12:37
*** markvoelker has quit IRC12:38
*** agireud has quit IRC12:38
*** thorst has joined #openstack-nova12:38
*** lbeliveau has quit IRC12:39
*** agireud has joined #openstack-nova12:40
*** shaohe_feng has quit IRC12:41
*** shaohe_feng has joined #openstack-nova12:41
*** daemontool__ has joined #openstack-nova12:41
*** lbeliveau has joined #openstack-nova12:41
*** EinstCrazy has joined #openstack-nova12:42
*** thorst has quit IRC12:43
*** inara has joined #openstack-nova12:43
*** rlrossit has joined #openstack-nova12:43
*** cleong has joined #openstack-nova12:45
*** daemontool_ has quit IRC12:45
*** EinstCrazy has quit IRC12:46
*** EinstCrazy has joined #openstack-nova12:47
*** thorst has joined #openstack-nova12:49
*** thorst has quit IRC12:49
*** thorst has joined #openstack-nova12:50
openstackgerritPeter Wang proposed openstack/nova: Detach volume when deleting shelved server  https://review.openstack.org/31408312:50
*** EinstCrazy has quit IRC12:50
*** zul has quit IRC12:50
*** chuck__ has joined #openstack-nova12:51
*** chuck__ has quit IRC12:51
*** shaohe_feng has quit IRC12:51
*** pwnall has joined #openstack-nova12:52
*** cleong has quit IRC12:52
*** corey_ has joined #openstack-nova12:52
*** chuck__ has joined #openstack-nova12:52
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408512:52
*** thorst_ has joined #openstack-nova12:53
*** sree has joined #openstack-nova12:53
*** lucas-hungry is now known as lucasagomes12:54
*** thorst has quit IRC12:54
*** shaohe_feng has joined #openstack-nova12:54
*** sree__ has quit IRC12:56
*** mdrabe has joined #openstack-nova12:56
*** sree__ has joined #openstack-nova12:57
*** sree has quit IRC12:57
*** irenab_ has joined #openstack-nova12:57
*** zzzeek has joined #openstack-nova12:58
*** irenab has quit IRC12:58
*** pwnall has quit IRC12:59
*** pwnall has joined #openstack-nova12:59
*** vladikr has joined #openstack-nova12:59
*** kengo_sakai has quit IRC13:01
*** EinstCrazy has joined #openstack-nova13:01
*** shaohe_feng has quit IRC13:01
*** shaohe_feng has joined #openstack-nova13:02
*** irenab_ has quit IRC13:02
*** kengo_sakai has joined #openstack-nova13:02
*** links has quit IRC13:02
*** efried has quit IRC13:03
*** ccarmack has joined #openstack-nova13:04
*** claudiub has quit IRC13:05
*** irenab has joined #openstack-nova13:06
*** EinstCrazy has quit IRC13:06
*** sacharya has joined #openstack-nova13:06
*** kengo_sakai has quit IRC13:07
*** ctrath has joined #openstack-nova13:10
*** sacharya has quit IRC13:11
openstackgerritjichenjc proposed openstack/nova: Complete Verification of os-floating-ip-pools  https://review.openstack.org/31107013:11
*** jwcroppe has joined #openstack-nova13:11
*** shaohe_feng has quit IRC13:12
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: centralize exception options  https://review.openstack.org/31409113:12
*** eharney has joined #openstack-nova13:12
*** krtaylor has quit IRC13:12
*** shaohe_feng has joined #openstack-nova13:13
openstackgerritChuck Carmack proposed openstack/nova: :Add nova-manage quota_usage_refresh command  https://review.openstack.org/29962113:13
*** markvoelker has joined #openstack-nova13:13
*** burgerk has joined #openstack-nova13:14
*** EinstCrazy has joined #openstack-nova13:14
*** jwcroppe has quit IRC13:16
*** zzzeek has quit IRC13:16
*** thorst_ has quit IRC13:16
*** kylek3h has joined #openstack-nova13:17
*** amotoki has joined #openstack-nova13:17
edleafemarkus_z: geez, more merge conflicts? Between those and xen rechecks, I don't think the api config stuff will ever merge. :(13:17
edleafemarkus_z: Working on the rebase now13:17
markus_zedleafe: yeah, the removal of the legacy_v2 was faster13:18
*** zzzeek has joined #openstack-nova13:18
markus_zBut we are very close to let the merge conflicts behind us13:19
*** krtaylor has joined #openstack-nova13:19
markus_zI'm writing changes for the last moves and then it's "only" writing proper help texts, which shouldn't be as prone to merge conflicts like the moves.13:20
*** edmondsw has quit IRC13:20
mdboothpaul-carlton2: I think the use case for libvirt.use_storage_pools has gone away13:20
*** jichen has quit IRC13:20
mdboothI don't see any reason why it should ever be false13:21
mdboothWe're basically replacing the legacy image backends with new ones which use libvirt storage pools13:21
mdboothAnd that migration process will be managed automatically13:21
mdboothI don't think we should involve the user13:21
*** iceyao has joined #openstack-nova13:21
mdbooths/user/operator/13:21
mdboothThe ploop thing isn't even relevant here, because we aren't replacing that yet13:22
*** shaohe_feng has quit IRC13:22
*** sree__ has quit IRC13:22
*** shaohe_feng has joined #openstack-nova13:23
*** ljxiash has joined #openstack-nova13:23
johnthetubaguymarkus_z: +113:25
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceTypeFilter  https://review.openstack.org/31409713:27
*** svenkat has joined #openstack-nova13:28
*** ducttape_ has joined #openstack-nova13:28
*** vishwanathj has joined #openstack-nova13:28
openstackgerritJohn Garbutt proposed openstack/nova: Add prototype feature classification matrix  https://review.openstack.org/26471913:28
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for extensions resource  https://review.openstack.org/31410113:30
*** sree has joined #openstack-nova13:31
*** belmoreira has quit IRC13:31
*** shaohe_feng has quit IRC13:32
*** mtanino has joined #openstack-nova13:32
*** sudipto has joined #openstack-nova13:32
*** shaohe_feng has joined #openstack-nova13:33
*** mrkz has joined #openstack-nova13:34
*** wznoinsk has quit IRC13:34
*** jwcroppe has joined #openstack-nova13:34
*** wznoinsk has joined #openstack-nova13:35
*** ljxiash has quit IRC13:35
*** irenab has quit IRC13:36
*** mageshgv has joined #openstack-nova13:36
*** tonytan4ever has joined #openstack-nova13:37
*** klkumar has joined #openstack-nova13:37
*** thorst_ has joined #openstack-nova13:37
johnthetubaguysdague: alex_xu: I was looking at all the unauthorized(401) notes for the error response codes, do we need to be explicit about those. I guess there is no other way to show APIs that are not protected?13:38
*** ljxiash has joined #openstack-nova13:39
sdaguejohnthetubaguy: you mean the "this is default admin only" comments?13:39
johnthetubaguysdague: I like the comments, I was meaning in the error response codes list13:39
sdaguejohnthetubaguy: link?13:39
*** jaypipes has quit IRC13:40
sdaguejust so I can make sure we're talking about the same thing13:40
johnthetubaguyhttps://review.openstack.org/#/c/313514/2/api-ref/source/servers.inc@42613:40
johnthetubaguyI mean the list is correct, I just wonder if we need to tell folks about those errors on (almost?) ever API call13:41
sdagueyou mean the fast that we're listing 40113:41
johnthetubaguyyeah13:41
sdagueso, I think if we want to go through after and pull out common codes, that's fine13:41
sdaguebut they all pretty much list it already, so I think for this round, it's fine13:41
johnthetubaguytrue, that makes sense13:42
alex_xuyeah, i guess so, we should have some doc to describe common response code, like for request wrong content-type13:42
sdagueright13:42
*** shaohe_feng has quit IRC13:42
sdagueI think an interesting part of this whole exercise is thinking through the things we might want to pull out more generically as we read all of this13:43
*** shaohe_feng has joined #openstack-nova13:43
*** syjulian has joined #openstack-nova13:43
johnthetubaguysdague: yeah, very true, this is just one of those things13:43
sdaguebut I hesitate to do those things while we still have > 200 items in http://burndown.dague.org/ (even when we have > 50 items)13:43
*** efried has joined #openstack-nova13:43
johnthetubaguysdague: yep, you are right, just thinking out loud13:44
*** smatzek has quit IRC13:44
sdaguejohnthetubaguy: yeh, it's a good point, we might want to build a dedicated place to take notes like that after13:45
*** david-lyle_ has joined #openstack-nova13:48
*** mtanino has quit IRC13:49
*** bauzas_off is now known as bauzas13:49
*** sree__ has joined #openstack-nova13:49
*** mriedem1 has joined #openstack-nova13:49
*** david-lyle has quit IRC13:50
*** gagehugo has joined #openstack-nova13:50
paul-carlton2mdbooth?13:51
paul-carlton2why do you think we don't need flag?13:51
*** mriedem has joined #openstack-nova13:52
*** cdelatte has joined #openstack-nova13:53
*** shaohe_feng has quit IRC13:53
*** ametts has joined #openstack-nova13:53
*** sree has quit IRC13:53
*** shaohe_feng has joined #openstack-nova13:53
*** eharney has quit IRC13:54
*** mriedem1 has quit IRC13:54
*** pradk has joined #openstack-nova13:54
*** markvoelker has quit IRC13:55
edleafeNova scheduler subteam meeting in 5 minuts in #openstack-meeting-alt13:56
*** jaypipes has joined #openstack-nova13:56
edleafeminutes, even13:56
*** edmondsw has joined #openstack-nova13:57
*** mdrabe has quit IRC13:57
*** esracelik has quit IRC13:59
*** mriedem1 has joined #openstack-nova13:59
mriedem1am i the only person having irc issues?13:59
bauzasmriedem1: I can see you :)14:00
johnthetubaguypossibly14:00
*** ducttape_ has quit IRC14:00
bauzasbut sometimes, some IRC servers are joking, try changing to another one14:00
*** mriedem has quit IRC14:00
johnthetubaguyah, there is only one of you now14:00
*** sree__ has quit IRC14:01
edleafejaypipes: are you around for the scheduler meeting?14:01
*** sahid has joined #openstack-nova14:02
*** shaohe_feng has quit IRC14:03
*** catintheroof has joined #openstack-nova14:03
openstackgerritPaul Carlton proposed openstack/nova-specs: Use libvirt storage pools  https://review.openstack.org/31050514:03
*** shaohe_feng has joined #openstack-nova14:03
*** liverpooler has quit IRC14:03
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceAffinityFilter  https://review.openstack.org/31409714:03
*** gongysh has joined #openstack-nova14:04
*** dedery_ has joined #openstack-nova14:05
*** dedery__ has joined #openstack-nova14:06
openstackgerritJulian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver  https://review.openstack.org/31175814:07
*** links has joined #openstack-nova14:08
*** pwnall has quit IRC14:08
*** dedery has quit IRC14:08
jaypipesedleafe: I am now, sorry got a phone call just as meeting was starting...14:08
*** dedery_ has quit IRC14:10
*** mdrabe has joined #openstack-nova14:10
*** jamesden_ has joined #openstack-nova14:10
*** links has quit IRC14:11
*** dedery__ has quit IRC14:11
*** thorst_ has quit IRC14:11
*** gongysh has quit IRC14:11
*** sahid has quit IRC14:12
*** thorst_ has joined #openstack-nova14:12
*** eharney has joined #openstack-nova14:12
openstackgerritJulian proposed openstack/nova: WIP Add unit tests for nova.virt.firewall.IpTablesFirewallDriver  https://review.openstack.org/31175814:12
*** fragatina has joined #openstack-nova14:13
*** smatzek has joined #openstack-nova14:13
*** shaohe_feng has quit IRC14:13
*** shaohe_feng has joined #openstack-nova14:14
*** gszasz has quit IRC14:16
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: centralize default flavor option  https://review.openstack.org/31412314:16
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: deprecate "default_flavor" config option  https://review.openstack.org/31412414:16
*** thorst_ has quit IRC14:17
*** laszloh has quit IRC14:19
*** zz_dimtruck is now known as dimtruck14:21
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova-specs: New Nova Scheduler filter: AggregateInstanceAffinityFilter  https://review.openstack.org/31409714:21
openstackgerritPrateek Arora proposed openstack/nova: Separate out the conf entries for iSCSI and FC multipath drivers  https://review.openstack.org/31067914:22
*** andrewbogott has quit IRC14:22
*** andrewbogott has joined #openstack-nova14:22
*** shaohe_feng has quit IRC14:23
*** thorst_ has joined #openstack-nova14:24
*** shaohe_feng has joined #openstack-nova14:24
*** itamarl_ has joined #openstack-nova14:27
raj_singhmarkus_z: What is "Trivial Patch Monkey"?14:28
*** thorst_ has quit IRC14:28
markus_zraj_singh: When you see a very small patch which is trivial and ready to merge, ping the cores for this.14:28
markus_zraj_singh: In the past we had a lot of those changes and the people searching for those patches were the "monkeys" AFAIK :)14:29
*** itamarl has quit IRC14:29
*** itamarl_ is now known as itamarl14:29
markus_zraj_singh: I'm not sure where the term has its origins14:29
raj_singhmarkus_z: got it, thx.14:29
raj_singhmarkus_z: better I don't ask :)14:30
*** thorst_ has joined #openstack-nova14:30
*** smcginnis_ has quit IRC14:33
*** shaohe_feng has quit IRC14:34
*** amotoki has quit IRC14:34
*** hshiina has quit IRC14:34
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: deprecate "default_flavor" config option  https://review.openstack.org/31412414:35
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: centralize default flavor option  https://review.openstack.org/31412314:35
openstackgerritSean Dague proposed openstack/nova: WIP: api-ref: flavors  https://review.openstack.org/31413314:36
*** sdake has joined #openstack-nova14:36
*** syjulian has quit IRC14:36
*** shaohe_feng has joined #openstack-nova14:36
openstackgerritPaul Carlton proposed openstack/nova: Add a lock() context manager to image backend  https://review.openstack.org/27962514:37
openstackgerritPaul Carlton proposed openstack/nova: Rename Raw backend to NoBacking  https://review.openstack.org/27962614:37
openstackgerritPaul Carlton proposed openstack/nova: Introduce ImageCacheLocalPool  https://review.openstack.org/27966914:37
openstackgerritPaul Carlton proposed openstack/nova: Remove fake_imagebackend.Raw and cleanup dependent tests  https://review.openstack.org/26766114:37
openstackgerritPaul Carlton proposed openstack/nova: Rename Image.check_image_exists to Image.exists()  https://review.openstack.org/27099814:37
openstackgerritPaul Carlton proposed openstack/nova: Remove deprecated option libvirt.remove_unused_kernels  https://review.openstack.org/26588614:37
openstackgerritPaul Carlton proposed openstack/nova: Only attempt to inject files if the injection disk exists  https://review.openstack.org/25087214:37
openstackgerritPaul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools  https://review.openstack.org/31413414:37
*** sahid has joined #openstack-nova14:38
*** mtanino has joined #openstack-nova14:39
*** jdurgin1 has joined #openstack-nova14:40
*** ducttape_ has joined #openstack-nova14:41
*** fragatina has quit IRC14:42
openstackgerritPetrut Lucian proposed openstack/nova: HyperV: use os-brick for volume related operations  https://review.openstack.org/27350414:43
openstackgerritSean Dague proposed openstack/nova: Complete Verification of server admin action  https://review.openstack.org/31172714:43
openstackgerritMark Doffman proposed openstack/nova: Instance mapping save, properly load cell mapping  https://review.openstack.org/31361714:44
*** shaohe_feng has quit IRC14:44
*** jdillaman has joined #openstack-nova14:44
*** shaohe_feng has joined #openstack-nova14:44
openstackgerritSean Dague proposed openstack/nova: Complete Verification of server admin action  https://review.openstack.org/31172714:45
markus_zsdague: I'm looking at https://github.com/openstack/nova/blob/master/nova/image/s3.py and wonder if that was overlooked in commit https://git.openstack.org/cgit/openstack/nova/commit/?id=4140eb414:45
sdaguemarkus_z: it probably was14:45
markus_zsdague: If that's the case, I tend to remove it completely without any deprecation14:45
markus_zsdague: thanks14:46
*** gszasz has joined #openstack-nova14:46
*** gcb has joined #openstack-nova14:48
openstackgerritRonald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks  https://review.openstack.org/31413914:48
mriedem1markus_z: there was another ec2 removal patch, let me find it14:48
mriedem1https://review.openstack.org/#/c/266425/14:48
mriedem1abandoned now because it got tricky14:49
mriedem1i think it would be good to start in smaller chunks, like removing the s3 code14:49
*** dedery has joined #openstack-nova14:49
*** woodster_ has joined #openstack-nova14:49
markus_zyeah, I would remove only this s3 module due to their config options are not needed anymore.14:51
openstackgerritArtom Lifshitz proposed openstack/nova: libvirt: New configuration classes to parse device address element  https://review.openstack.org/30414714:51
openstackgerritArtom Lifshitz proposed openstack/nova: libvirt: attach configdrive after instance XML  https://review.openstack.org/30333514:51
openstackgerritArtom Lifshitz proposed openstack/nova: DB: add path, serial and address to block devices  https://review.openstack.org/31061514:51
openstackgerritArtom Lifshitz proposed openstack/nova: DB: add bus and bus_address to virtual interfaces  https://review.openstack.org/31061614:51
openstackgerritArtom Lifshitz proposed openstack/nova: objects: adding serial, path, bus_address fields to bdm object  https://review.openstack.org/31061714:52
openstackgerritArtom Lifshitz proposed openstack/nova: objects: adding bus and bus_address to virtual interfaces object  https://review.openstack.org/31061814:52
openstackgerritArtom Lifshitz proposed openstack/nova: Device tagging metadata API support  https://review.openstack.org/30451114:52
openstackgerritArtom Lifshitz proposed openstack/nova: Device tagging API support  https://review.openstack.org/30451014:52
openstackgerritArtom Lifshitz proposed openstack/nova: Compute manager device tagging support  https://review.openstack.org/26401714:52
openstackgerritArtom Lifshitz proposed openstack/nova: Libvirt driver implementation of device tagging  https://review.openstack.org/26401614:52
*** prateek has quit IRC14:52
*** dedery has quit IRC14:54
mriedem1markus_z: cool. we also want to remove that because it uses nova-cert which we want to eventually also remove14:54
*** mriedem1 is now known as mriedem14:54
*** shaohe_feng has quit IRC14:54
*** shaohe_feng has joined #openstack-nova14:54
* alex_xu forgets the power line at office again :(14:55
*** mspreitz has joined #openstack-nova14:56
*** ramki has joined #openstack-nova14:56
openstackgerritLudovic Beliveau proposed openstack/nova: Enable python34 tests for nova.tests.unit.pci.test_manager and test_stats  https://review.openstack.org/31097614:56
*** sacharya has joined #openstack-nova14:58
*** ijw_ has quit IRC14:58
openstackgerritChris Dent proposed openstack/nova: WIP resource-pools/placement api  https://review.openstack.org/29310414:59
*** Guest30018 is now known as mfisch14:59
*** dedery has joined #openstack-nova14:59
*** mfisch is now known as Guest5645914:59
*** eharney has quit IRC15:02
*** tonytan4ever has quit IRC15:03
mriedemsdague: on https://review.openstack.org/#/c/313514/2/api-ref/source/servers.inc for listing servers, i was looking at the 503 in the old docs. got me thinking that we currently have a bug where we fail to list servers if neutron is down (because we can't get security groups)15:03
mriedemsdague: but i think that's not even a 503, it's a 500, so unexpected and doesn't belong in the docs15:04
*** haplo37 has joined #openstack-nova15:04
mriedemhttps://bugs.launchpad.net/nova/+bug/156765515:04
openstackLaunchpad bug 1567655 in OpenStack Compute (nova) "500 error when trying to list instances and neutron-server is down" [Medium,Confirmed] - Assigned to Prateek Arora (parora)15:04
*** shaohe_feng has quit IRC15:04
*** lpetrut has quit IRC15:05
*** shaohe_feng has joined #openstack-nova15:05
*** lpetrut has joined #openstack-nova15:06
openstackgerritJay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools  https://review.openstack.org/30017615:07
mriedemalex_xu: on https://review.openstack.org/#/c/313514/ you can get a 404 when listing servers if you provided a marker that's not ofund15:07
mriedem*found15:07
*** voelzmo has quit IRC15:07
jaypipesmriedem, cdent, Yingxin, edleafe, bauzas: please see updates to ^^ spec, especially around new REST API calls for setting inventory records on resource pools.15:07
mriedemaye aye15:09
* mriedem need a break from his first api-ref review of the day :)15:09
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: config options: remove s3 related options  https://review.openstack.org/31414615:09
openstackgerritEd Leafe proposed openstack/nova-specs: resource-providers: Move allocation fields  https://review.openstack.org/30017715:10
edleafejaypipes: ^^15:10
*** thorst_ has quit IRC15:10
edleafejaypipes: made some changes to mention the move to the API database. Please review to make sure I didn't bork anything15:10
edleafejaypipes: rebased it, too :)15:10
jaypipesedleafe: danke.15:11
cdentthanks jaypipes will digest that soon15:11
*** thorst_ has joined #openstack-nova15:11
*** lpetrut has quit IRC15:12
*** eharney has joined #openstack-nova15:13
*** Daisy has joined #openstack-nova15:15
mriedemalaski: question came up in the generic-resource-pools spec about policy for the new placement api, do you envision we'd just ship a separate policy.json file for the placement api?15:15
*** shaohe_feng has quit IRC15:15
*** mdrabe has quit IRC15:15
alaskimriedem: yeah. I think we should keep that completely split out15:15
*** thorst_ has quit IRC15:15
*** shaohe_feng has joined #openstack-nova15:15
*** ptm_away has joined #openstack-nova15:16
*** rena9067 has joined #openstack-nova15:17
*** PaulMurray has quit IRC15:17
*** EinstCrazy has quit IRC15:18
*** itamarl has quit IRC15:18
mdboothpaul-carlton2: Sorry, had to head out. Got a minute now?15:19
*** Daisy has quit IRC15:19
alaskimriedem: commented15:20
jaypipesedleafe: reviewed. changes look fine, thank you sir.15:21
jaypipesmriedem: a review on the resource-providers-allocations spec would be most appreciated. thanks in advance.15:21
raj_singhsdague: For api-ref work are you guys following any pattern to avoid conflicts or should I just pick any file from api-ref/source/* and start working on it?15:22
openstackgerritAbhijeet Malawade proposed openstack/nova: Return HTTPBadRequest if incorrect params are provided to images api  https://review.openstack.org/31415315:23
*** davideagnello has joined #openstack-nova15:24
*** mpavone has quit IRC15:24
*** pwnall has joined #openstack-nova15:24
*** shaohe_feng has quit IRC15:25
*** shaohe_feng has joined #openstack-nova15:26
jaypipesmriedem: dansmith's https://review.openstack.org/#/c/312750/ should be an easy win if you15:27
jaypipes're up for it.15:27
*** mdrabe has joined #openstack-nova15:27
*** nic has joined #openstack-nova15:28
mriedemjaypipes: easy -2 yeah15:28
mriedemthanks :)15:28
*** ljxiash has quit IRC15:28
openstackgerritStephen Finucane proposed openstack/nova: Use assertGreater(A, X) instead of assertTrue(A > X)  https://review.openstack.org/30273415:29
*** Swami has joined #openstack-nova15:29
openstackgerritStephen Finucane proposed openstack/nova: Use assertLess(Equal) instead of assertTrue(A > X)  https://review.openstack.org/30840115:29
openstackgerritStephen Finucane proposed openstack/nova: Use assert(Not)Equal instead of assertTrue(A == X)  https://review.openstack.org/30840215:29
openstackgerritStephen Finucane proposed openstack/nova: Use assertNotIn instead of assertTrue(all(A != B))  https://review.openstack.org/31416915:29
*** xenogear has joined #openstack-nova15:30
*** tonytan4ever has joined #openstack-nova15:32
*** jistr has quit IRC15:33
openstackgerritPeter Wang proposed openstack/nova: Detach volume when deleting shelved server  https://review.openstack.org/31408315:33
*** Jeffrey4l_ has quit IRC15:34
*** lpetrut has joined #openstack-nova15:34
*** jed56 has quit IRC15:34
*** thorst_ has joined #openstack-nova15:35
*** shaohe_feng has quit IRC15:35
*** shaohe_feng has joined #openstack-nova15:36
*** andreas_s has quit IRC15:36
*** irenab has joined #openstack-nova15:38
paul-carlton2mdbooth, about to head out but have five mins can I call you?15:38
rbradforsdague, an api-ref style question.  When there is a JSON response we include an example, when a POST has no response it's blank, The response head basically flows into the next API call.  Would some text, such as "Check for valid HTTP response" help in legibility of documentation.15:38
mdboothpaul-carlton2: Sorry, in another meeting now :/ 9:30am tomorrow?15:39
*** nic has quit IRC15:39
paul-carlton2yep, talk to you then15:39
mriedemjaypipes: some small things in the generic-resource-pools spec https://review.openstack.org/#/c/300176/15:39
mriedemmostly copy/paste errors i think15:40
*** nic has joined #openstack-nova15:40
*** daemontool__ has quit IRC15:41
jaypipesmriedem: on it.15:41
*** kolesovdv has quit IRC15:43
*** jogo has quit IRC15:43
openstackgerritVladik Romanovsky proposed openstack/nova: tests: Adding functional tests to cover VM creation with sriov  https://review.openstack.org/29478015:43
*** cdent has quit IRC15:44
*** jogo has joined #openstack-nova15:44
openstackgerritJohn Garbutt proposed openstack/nova-specs: Add newton spec for ordered filter scheduler  https://review.openstack.org/25632315:45
*** Oku_OS is now known as Oku_OS-away15:45
*** shaohe_feng has quit IRC15:45
*** irenab has quit IRC15:46
*** shaohe_feng has joined #openstack-nova15:46
*** Sukhdev has joined #openstack-nova15:47
openstackgerritsahid proposed openstack/nova: network: handle unauthorized exception from neutron  https://review.openstack.org/31201415:47
*** klkumar has quit IRC15:48
*** irenab has joined #openstack-nova15:48
openstackgerritPaul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools  https://review.openstack.org/31413415:49
*** fragatina has joined #openstack-nova15:50
*** iceyao has quit IRC15:51
*** ptm__ has joined #openstack-nova15:52
kashyapmriedem: When you get a moment, mind poking a look at this (you've ACKed the Mitaka one)?  Is that due to mixing Mock/Mox? -- https://review.openstack.org/#/c/314012/15:52
danpbjaypipes: could you see the comments here about os-vif release version https://review.openstack.org/#/c/31242615:53
danpbjaypipes: and decide who's right :-)15:53
*** fragatina has quit IRC15:53
*** fragatin_ has joined #openstack-nova15:53
jaypipesdanpb: yep, will look at that shortly.15:54
mriedemkashyap: i actually tried doing that cherry pick myself last week and ran into the same issue, i wasn't able to easily sort it out and gave up on it15:54
*** jistr has joined #openstack-nova15:54
*** ircuser-1 has joined #openstack-nova15:54
kashyapmriedem: Okay, if _you_ are hitting a block, then I should wind up and look through the telescope near me at the Sun / Mercury :-)15:54
* kashyap is "working from the observatory"15:55
mriedemkashyap: no, i just didn't have the time to dig into it15:55
kashyapmriedem: No worries, I'll spend some time and look at it.15:55
*** ptm_away has quit IRC15:55
*** shaohe_feng has quit IRC15:56
*** shaohe_feng has joined #openstack-nova15:56
*** armax has joined #openstack-nova15:56
*** ramki has quit IRC15:56
*** mlavalle has joined #openstack-nova15:56
mlavallejohnthetubaguy: ping15:57
*** davideagnello has quit IRC15:58
*** mrkz has quit IRC15:58
*** hshiina has joined #openstack-nova15:58
johnthetubaguymlavalle: hi15:58
*** mrkz has joined #openstack-nova15:58
mlavallejohnthetubaguy: I have a question. For the refactoring of allocate_for_instance into the conductor, is this spec the only pre-requisite: https://review.openstack.org/#/c/300176/?15:59
johnthetubaguymlavalle: so my spec doesn't depend on the scheduler work at all16:00
johnthetubaguymlavalle: its largely just refactoring16:00
mlavallejohnthetubaguy: that's actually very good news :-)16:00
johnthetubaguymlavalle: now making the routed network stuff work will depend on the spec you mention, I don't remember if thats the only one, its certainly the key one16:01
Yingxinjaypipes: will resource tracker update the "reserved" fields of its compute node inventories?16:01
*** sridharg has quit IRC16:01
*** tesseract has quit IRC16:01
*** fragatin_ has quit IRC16:02
mlavallejohnthetubaguy: so, the way you envision this is that the refactoring will be done and then, on top of it, we will add the pieces needed to make it work with routed networks?16:02
johnthetubaguymlavalle: yes, that it16:03
johnthetubaguymlavalle: I was planning on working on the refactoring, and I was thinking you could tackle the next bit16:04
*** dedery has quit IRC16:04
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Testing latest u-c  https://review.openstack.org/30334516:04
mlavallejohnthetubaguy: that sounds like a plan :-)16:04
johnthetubaguymlavalle: currently a bit confused with how ironic works after the refactoring, I think it should be fine, but need to do some double checking16:05
mlavallejohnthetubaguy: as soon as you have anything up for review, let me know, so I can help16:05
*** rcernin has quit IRC16:06
*** shaohe_feng has quit IRC16:06
jaypipesYingxin: for some resource classes that it knows the reserved amount for, yes. For instance, the reserved_host_memory_mb configuration option indicates the reserved value for the compute node's RAM_MB inventory record will be updated by the resource tracker based on that configuration value.16:07
*** shaohe_feng has joined #openstack-nova16:07
*** fragatina has joined #openstack-nova16:07
mlavallejohnthetubaguy: also, tomorrow's routed networks meeting is at 1500 UTC. In case you want to participate. I'll ping you16:08
*** vtech_ has quit IRC16:10
*** unicell has quit IRC16:11
openstackgerritRonald Bradford proposed openstack/nova: [WIP] Complete method verification of os-networks  https://review.openstack.org/31419816:12
Yingxinjaypipes: so, if I shutdown the compute node and update the "reserved" configuration to the value that will violate the existing allocation records, what will happen to this node?16:14
Yingxinjaypipes: will the compute node fail to start, or force to update the "reserved" field?16:14
*** lpetrut has quit IRC16:15
belliottdansmith: so, service update doesn't appear to change in db on service restart - i'm not sure the best way to fix it since there's some special handling in the Service object with it as an immutable value16:15
belliottdansmith: shouldn't service version update in DB to the latest SERVICE_VERSION on restart?16:16
*** paul-carlton1 has joined #openstack-nova16:16
*** shaohe_feng has quit IRC16:16
belliottdansmith: i can put in some hokey tests where if SERVICE_VERSION != db_service['version'] then it should get updated on next save()16:17
*** shaohe_feng has joined #openstack-nova16:17
*** cdent has joined #openstack-nova16:17
*** palexster has quit IRC16:17
*** markus_z has quit IRC16:18
jaypipesYingxin: shutting down the nova-compute daemon has no impact on whether a call to, say, `openstack compute-node set inventory $CN_UUID --resource-class=DISK_GB --reserved=$NEW_VA` would return a failure due to the inventory's new total - reserved exceeding the existing allocations.16:18
jaypipesYingxin: the nova-compute daemon is stateless. the state is in the DB.16:19
*** ihrachys has joined #openstack-nova16:21
*** tonytan4ever has quit IRC16:22
*** andymaier has quit IRC16:23
*** apoorvad has joined #openstack-nova16:24
*** tonytan4ever has joined #openstack-nova16:24
*** shaohe_feng has quit IRC16:26
*** shaohe_feng has joined #openstack-nova16:27
jaypipesYingxin: when you would call something like `openstack compute-node update inventory` you would not be speaking to the nova-compute daemon at all.16:28
Yingxinjaypipes: I mean to modify "reserved_host_memory_mb" in nova.conf and *restart* the nova-compute service again.16:28
doffmjaypipes: Is it going totally stateless? There won't be any update to the in-memory 'host_state_map'?16:28
doffmJust wondering.16:28
*** mjura has quit IRC16:29
*** rbridgeman has joined #openstack-nova16:29
Yingxinjaypipes: so nova itself will update the reserved field according to the new configuration?16:29
sdaguerbradfor: if there is no Response body something like - http://developer.openstack.org/api-ref/compute/#id33 is appropriate (under the DELETE servers resource)16:29
jaypipesdoffm: nova-compute doesn't have an in-memory host_state_map. That's the scheduler..16:30
rbradforsdague, cool, exactly what I was asking, makes it very clear to reader.16:30
sdagueraj_singh: also look for the current open patches - https://review.openstack.org/#/q/project:openstack/nova+file:api-ref+status:open16:30
jrollmriedem: are you doing the writeup on the ironic/nova session or would you like me to?16:30
doffmjaypipes: Sorry, misunderstood conversation.16:30
mriedemjroll: it's on the todo list, but feel free to write that up, you'd probably know the details better16:31
sdaguemriedem: right, I don't think we ever document 500 in the returns, as that's not an expected error16:31
jrollmriedem: okay, I'll ping you when I do and you can expand if I've missed anything. thanks16:31
jaypipesYingxin: these are all brand new interfaces we're creating... right now reserved_host_memory_mb is set by the resource tracker (on init_compute_node() I think?) and written into the compute_nodes.reserved_host_memory_mb field. The only thing that the resource-providers stuff changes is moving that into the inventories table as the reserved amount for the RAM_MB resource class.16:31
*** rbridgeman_ has joined #openstack-nova16:35
*** haukebruno has quit IRC16:36
*** shaohe_feng has quit IRC16:37
*** ccarmack1 has joined #openstack-nova16:37
*** rcernin has joined #openstack-nova16:37
Yingxinjaypipes: OK, I'll review the actual implementations, and will understand what you say^ finally.16:37
Yingxinjaypipes: thanks16:37
*** tonytan4ever has quit IRC16:37
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408516:37
openstackgerritSean Dague proposed openstack/nova: api-ref: method verification and fixes for servers.inc  https://review.openstack.org/31351416:37
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353216:37
mriedemsdague: what allows you to filter instances by host in the api?16:38
*** shaohe_feng has joined #openstack-nova16:38
*** diogogmt has joined #openstack-nova16:38
sdaguemriedem: it's in the base servers controller16:38
sdagueiirc16:38
sdaguelet me get the link16:38
*** rbridgeman has quit IRC16:38
openstackgerritJay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools  https://review.openstack.org/30017616:39
*** ccarmack has quit IRC16:40
snetiHi johnthetubaguy...need some info in getting started with Nova-api ref. For method verification, what I understand is we need to make sure that the methods are in correct order as mentioned in the spec. And also16:40
sneticorrect the error status codes. How do I check the error response codes from the code. I see only few exceptions under @expected_exceptions for each method.16:40
jaypipesmriedem, Yingxin, bauzas, cdent, edleafe: ^^ OK, next rev up...16:41
cdentjaypipes: feh, I was just in the middle...16:41
sdaguemriedem: oh, you know what, that was vesitigial and I just assumed it was right16:41
cdentwill transfer them over if still relevant16:41
mriedemsdague: yes!16:41
mriedemsdague: i think i picked the very worst series to start reviewing for api-ref today16:41
mriedemserver request parameter validation16:42
mriedemsdague: don't update https://review.openstack.org/#/c/313532 yet i'm still going through it16:42
sdagueyeh, servers is wonky16:42
sdaguemriedem: sure, it did get rebased because I fixed the one underneath16:43
*** unicell has joined #openstack-nova16:43
sdaguemriedem: https://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/nova/api/openstack/compute/servers.py#L1137 is where I thought I saw it16:44
*** yamahata has joined #openstack-nova16:44
sdaguebut, again, un-spaghettifying servers.py in your head, is a thing16:44
*** palexster has joined #openstack-nova16:44
*** irenab has quit IRC16:45
*** moshele has quit IRC16:45
*** david-lyle_ is now known as david-lyle16:45
johnthetubaguysneti: sdague is a good person to ask about that, there are quite a few patches up to see what error codes they are generally including (the expected 4xx ones basically)16:46
mriedemsneakiness,16:46
*** irenab has joined #openstack-nova16:46
*** irenab has quit IRC16:46
mriedemi thought block_device_mapping_v2 in the request was wrong, but the bdm extension intercepts bdm_v2 and puts block_device_mapping in the server create request dict16:46
*** shaohe_feng has quit IRC16:47
johnthetubaguysneti: this is the topic I was meaning: https://review.openstack.org/#/q/topic:bp/api-ref-in-rst+status:open16:47
sdaguesneti: this is typically expected_errors + 401 & 403 + 404 (if the resource supports limit / marker). That's probably about as close as we are going to get at this stage16:48
*** shaohe_feng has joined #openstack-nova16:48
*** irenab has joined #openstack-nova16:49
*** ijw has joined #openstack-nova16:49
*** derekh has quit IRC16:50
snetisdague, so 401&403 should be added for each method and 404 only if the resource supports limit16:51
*** zenoway has joined #openstack-nova16:51
*** earlephilhower has joined #openstack-nova16:52
*** vtech has joined #openstack-nova16:54
*** ihrachys has quit IRC16:54
*** unicell has quit IRC16:54
johnthetubaguysdague: I was just digging into the floating-ip-pools stuff, I don't think we give a target, so I guess there is no "owner" concept for that API? https://review.openstack.org/#/c/311070/2/api-ref/source/os-floating-ip-pools.inc@19 or am I missing something here?16:55
*** salv-orlando has joined #openstack-nova16:55
*** ijw has quit IRC16:56
*** yassou has quit IRC16:56
*** ihrachys has joined #openstack-nova16:56
*** penick has joined #openstack-nova16:57
sdaguejohnthetubaguy: there is one implicitly in tenant_id the token16:57
*** shaohe_feng has quit IRC16:57
sdaguethat's what that is trying to express16:57
sdaguewordsmithing might be appropriate16:58
johnthetubaguysdague: but doesn't it need to compare that to something?16:58
*** shaohe_feng has joined #openstack-nova16:58
*** jaosorior has quit IRC16:58
*** unicell has joined #openstack-nova16:59
*** sdake has quit IRC17:00
*** zenoway has quit IRC17:00
*** zenoway has joined #openstack-nova17:00
sdaguejohnthetubaguy: yep, you are right, it has really confusing policy17:01
sdaguehttps://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/etc/nova/policy.json#L22117:01
*** sdake has joined #openstack-nova17:01
johnthetubaguysdague: +1 its a bit missleading17:01
johnthetubaguysdague: I kinda guessed users want to list the pools so they can request a floating ip from the correct one17:02
sdaguerigt17:02
sdagueright17:02
*** jistr has quit IRC17:02
*** gcb has quit IRC17:04
*** ijw has joined #openstack-nova17:05
*** sahid has quit IRC17:05
*** shaohe_feng has quit IRC17:07
*** omnipresent has joined #openstack-nova17:08
*** omnipresent has quit IRC17:08
*** daemontool__ has joined #openstack-nova17:09
*** ijw has quit IRC17:10
*** zenoway has quit IRC17:11
cdentthere ya go jaypipes17:11
*** jdurgin1 has quit IRC17:11
*** whenry has quit IRC17:11
*** whenry_ has quit IRC17:11
*** shaohe_feng has joined #openstack-nova17:12
dansmithbelliott: sorry, monday morning bring hours of calls for me17:13
dansmithbelliott: what is it you're seeing exactly?17:13
*** thorst_ has quit IRC17:14
*** thorst_ has joined #openstack-nova17:15
*** paul-carlton1 has quit IRC17:15
openstackgerritRonald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks  https://review.openstack.org/31413917:16
belliottdansmith: so if you update a compute node to new code (with a new SERVICE_VERSION), it never updates the version column in the D B17:16
*** roeyc has joined #openstack-nova17:17
dansmithbelliott: um, really? have you tracked down why?17:17
*** thorst__ has joined #openstack-nova17:17
*** shaohe_feng has quit IRC17:18
belliottdansmith: i'll throw a patch up17:18
*** shaohe_feng has joined #openstack-nova17:18
*** sdake_ has joined #openstack-nova17:18
dansmithokay17:19
belliottdansmith: save it set to never update it anyway https://github.com/openstack/nova/blob/master/nova/objects/service.py#L29417:19
*** thorst_ has quit IRC17:19
*** zenoway has joined #openstack-nova17:20
*** lpetrut has joined #openstack-nova17:21
dansmithbelliott: right, but on service startup and every minute we update the service record, right? that was the goal there17:21
*** sdake has quit IRC17:21
*** thorst__ has quit IRC17:22
*** sfinucan has quit IRC17:22
belliottdansmith: when the record is loaded from DB it uses the DB value, not the current constant from the code17:22
dansmithhrm, I was sure we validated all of this when we landed it, but it's been a while17:23
*** zenoway has quit IRC17:25
*** roeyc has quit IRC17:25
*** sdake_ has quit IRC17:25
belliottdansmith: what does this do https://github.com/openstack/nova/blob/master/nova/objects/service.py#L185 vs just saying self.version = db_service[key]17:26
*** paul-carlton1 has joined #openstack-nova17:26
belliottsorry, service.version = db_service[key]17:27
dansmithbelliott: bypasses the readonly-ness17:27
*** sdake has joined #openstack-nova17:27
*** lpetrut has quit IRC17:27
belliottdansmith: i don't see a read-only flag on the field17:27
*** shaohe_feng has quit IRC17:28
*** thorst_ has joined #openstack-nova17:28
*** shaohe_feng has joined #openstack-nova17:28
dansmithbelliott: heh, sure enough17:29
belliottok i thought i was short on coffee17:30
dansmithbelliott: yeah, wasn't in the landed patch either.. might have come out at some point and that bit remained17:30
*** gagehugo has quit IRC17:30
openstackgerritPaul Carlton proposed openstack/nova: Implementation of Libvirt Storage Pools  https://review.openstack.org/31413417:31
*** davideagnello has joined #openstack-nova17:32
*** ijw has joined #openstack-nova17:32
*** ijw has quit IRC17:33
*** ijw has joined #openstack-nova17:34
*** roeyc has joined #openstack-nova17:35
*** paul-carlton1 has quit IRC17:35
*** ptm__ has quit IRC17:36
*** thorst_ has quit IRC17:36
*** vilobhmm11 has joined #openstack-nova17:36
openstackgerritChris Friesen proposed openstack/nova-specs: Improve Scheduler Logging  https://review.openstack.org/30664717:37
rbradforsdague, I need a tenant_id that's in the body, not path. any suggestions for best name to add to in parameters.yaml?17:37
cfriesen^ updated as per bauzas' comments17:37
*** thorst_ has joined #openstack-nova17:37
*** shaohe_feng has quit IRC17:38
*** shaohe_feng has joined #openstack-nova17:39
*** ijw has quit IRC17:39
*** thorst_ has quit IRC17:42
*** lakshmiS has joined #openstack-nova17:42
*** davideagnello has quit IRC17:43
*** thorst_ has joined #openstack-nova17:44
*** avula has joined #openstack-nova17:45
*** harlowja has joined #openstack-nova17:48
*** thorst_ has quit IRC17:48
*** shaohe_feng has quit IRC17:48
*** syjulian has joined #openstack-nova17:49
openstackgerritDan Smith proposed openstack/nova: Add online migration to move keypairs from main to API database  https://review.openstack.org/31366417:49
openstackgerritDan Smith proposed openstack/nova: Add online migration to store keypairs with instances  https://review.openstack.org/31306017:49
*** shaohe_feng has joined #openstack-nova17:49
dansmithjaypipes: thanks for catching that thing in the second to last patch.. just got it fixed17:49
*** Sukhdev has quit IRC17:50
*** thorst_ has joined #openstack-nova17:50
jaypipesdansmith: will re-review shortly after reviewing all of cdent's patches in progress.17:50
*** vilobhmm111 has joined #openstack-nova17:52
*** vilobhmm11 has quit IRC17:53
*** vilobhmm111 has quit IRC17:53
*** vilobhmm11 has joined #openstack-nova17:54
*** PaulMurray has joined #openstack-nova17:54
*** thorst_ has quit IRC17:55
*** zenoway has joined #openstack-nova17:56
*** penick has quit IRC17:56
*** Sukhdev has joined #openstack-nova17:57
*** thorst_ has joined #openstack-nova17:57
*** davideagnello has joined #openstack-nova17:58
*** sdake_ has joined #openstack-nova17:58
*** shaohe_feng has quit IRC17:59
*** penick has joined #openstack-nova18:00
*** zenoway has quit IRC18:00
*** sdake has quit IRC18:01
mriedemsdague: i have to move on from https://review.openstack.org/#/c/313532/18:01
mriedemsdague: the various extensions and microversions make that one never ending18:01
jaypipescdent: in response to your comment about adding "more REST endpoints"...18:02
*** shaohe_feng has joined #openstack-nova18:02
*** penick has quit IRC18:02
jaypipescdent: I don't see a problem with the additional fine-grained endpoints in REST API. I took out the ability for PUT /resource-pools/{uuid} to be able to update inventory at all (only the name attribute of the resource pool may be updated with the PUT /resource-pools/{uuid} call now)'18:03
jaypipescdent: also, w.r.t the foreign key constraint addition, that's easy: we can do that when migrating the tables to the API database ;)18:03
mriedemgmann: sdague: couldn't/shouldn't we add a microversion to call the more standardized version of diagnostics now? https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/nova/api/openstack/compute/server_diagnostics.py#L38-L4418:03
*** zenoway has joined #openstack-nova18:03
*** lucasagomes is now known as lucas-dinner18:04
*** thorst_ has quit IRC18:04
jaypipescdent: why do you say that "this asymmetry is weird"?18:06
*** shaohe_feng has quit IRC18:09
*** hshiina has quit IRC18:10
*** shaohe_feng has joined #openstack-nova18:10
*** zenoway has quit IRC18:10
*** danpb has quit IRC18:12
*** mvk has quit IRC18:12
*** jichen has joined #openstack-nova18:13
*** ducttape_ has quit IRC18:13
*** zenoway has joined #openstack-nova18:15
cdentjaypipes: sorry, was making dinner (now eaten, was tasty)18:15
cdentit's pretty much what I said there: you post and inventories and return a resource_pool, that's asymmentrical18:15
*** sdake_ is now known as sdake18:15
cdenton the fk thing, yeah, nbd, was just confirming18:16
cdentjaypipes: as we've discussed before, doing a partial update on a PUT ("only the name attribute of the resource pool may be updated with the PUT /resource-pools/{uuid} call now") is bad grammar18:16
*** penick has joined #openstack-nova18:17
cdentso yeah, my reaction to your changes it largely dependent on which hat I'm wearing. If it's pedantic http guy, I'm kinda meh. Various other hats, yeah, it's fine18:17
jaypipescdent: why is updating only the name attribute (which is the only attribute of the resource pool entity itself) bad grammar?18:18
openstackgerritdane-fichter proposed openstack/nova: Add image cache verification  https://review.openstack.org/31422218:19
*** rena9067 has quit IRC18:19
cdentbecause the representation your using elsewhere server->client is a bunch of other stuff18:19
cdentdamnit: you're18:19
*** shaohe_feng has quit IRC18:19
*** shaohe_feng has joined #openstack-nova18:20
cdentso there's a lot of ambiguity about the state18:20
cdentals you say "I took out the ability for PUT /resource-pools/{uuid} to be able to update inventory at all" but that doesn't appear to be the case in the spec18:21
edleafecdent: isn't a partial PUT supposed to be a PATCH instead?18:22
cdentjaypipes: basically if the representation you have for the request at line 484 is correct, then strictly speaking a form of that is what should be PUT18:23
jaypipescdent: in the spec, for PUT /resource-pools/{uuid}, I messed up...18:24
jaypipescdent: fixing, sorry about this.18:24
cdentedleafe: yes, but there's been a lot of controversy on that because the format of a PATCH is arguable18:24
jaypipesggVG18:24
jaypipesoh ffs18:24
cdentjaypipes: I don't think it's a problem: it's making us have this conversation, which is good18:24
edleafejaypipes: heh, I understood that instantly18:24
*** sudipto has quit IRC18:25
*** ducttape_ has joined #openstack-nova18:26
*** sdake has quit IRC18:27
mriedemalaski: policy question for you, i.e. https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/etc/nova/policy.json#L2518:28
mriedemthe compute api has a policy check, which is admin or owner18:28
mriedembut the rest api policy for diagnostics is admin only by default18:28
cdentjaypipes: I'm going to go take a long walk and will come back to review again. In the interim if you can think about which hat you want me to wear in regard to this and tell me, I can do that. I can wear several if that's useful.18:28
cdentbiab18:28
mriedemwhy do we even have the separate check in the compute api code if the rest api has already enforced the policy?18:28
alaskimriedem: legacy v2 cruft18:29
alaskifor v2.1 all policy checks were moved into the rest api layer18:29
*** ijw has joined #openstack-nova18:29
mriedemthank god18:29
mriedemok18:29
alaskiwith the removal of v2 code a lot of compute_api checks can probably go away18:29
*** salv-orlando has quit IRC18:29
*** shaohe_feng has quit IRC18:29
kashyapdiana_clarke: I'm on a train & the network is spotty, wonder if you have time today to take a look at this 'final nail in the coffin' of that bug we've been working on, this one is for Liberty -- https://review.openstack.org/#/c/314012/18:30
*** shaohe_feng has joined #openstack-nova18:30
kashyapdiana_clarke: If you're occupied with other stuff, feel free to disregard me, I'll look into it first thing in the morning.18:30
sdaguemriedem: yes, we should18:30
sdaguerbradfor: I put a tenant_id_body into one of my servers patches, that's probably reusable here18:31
alaskimriedem: those policy checks are gated on http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n167, which supposedly is only False for v218:32
rbradforsdague, I guess it hasn't merged yet.18:32
rbradforI'll look around.18:32
kashyapdiana_clarke: I'm about to upload a new change with some tweaks, wait for the unit tests for this to pass before you consider spending your time on it.18:32
sdaguerbradfor: no it's https://review.openstack.org/#/c/31353218:32
alaskioomichi alex_xu something to consider, with the removal of v2 the compute/api.py policy checks can go away afaik18:32
sdaguemaybe stack on top of that18:32
*** openstackgerrit has quit IRC18:33
*** openstackgerrit has joined #openstack-nova18:33
mriedemalaski: yeah, for v2.1 the rest extension creates the compute api object as: self.compute_api = compute.API(skip_policy_check=True)18:34
openstackgerritJay Pipes proposed openstack/nova-specs: resource-providers: generic resource pools  https://review.openstack.org/30017618:34
mriedemsdague: should maybe break this out of the dep chain so we can land it by itself https://review.openstack.org/#/c/314085/18:36
rbradforsdague, thanks18:36
*** PaulMurray has quit IRC18:36
openstackgerritRobert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 was not addressed due to the compute node is already in that state so no corrective action is required. 404 is already covered.  https://review.openstack.org/31422818:37
openstackbug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42)18:37
*** zenoway has quit IRC18:37
*** browne has joined #openstack-nova18:38
*** thorst_ has joined #openstack-nova18:39
sdaguemriedem: maybe, it's pretty minor though18:39
*** shaohe_feng has quit IRC18:40
*** prateek has joined #openstack-nova18:40
*** lpetrut has joined #openstack-nova18:40
*** shaohe_feng has joined #openstack-nova18:41
sdaguemriedem: thanks for the deep review on the servers parameters, let me go fix those up18:41
*** browne has quit IRC18:41
*** ozialien10 has quit IRC18:43
*** ozialien10 has joined #openstack-nova18:44
*** ozialien10 has quit IRC18:44
*** ozialien10 has joined #openstack-nova18:45
*** markmc has quit IRC18:46
*** ajo has quit IRC18:47
*** migi has quit IRC18:47
*** dmellado has quit IRC18:47
*** rook-lap has quit IRC18:47
*** mtanino has quit IRC18:47
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423018:48
*** sdake has joined #openstack-nova18:49
*** neophy has joined #openstack-nova18:49
*** shaohe_feng has quit IRC18:50
*** shaohe_feng has joined #openstack-nova18:51
mriedemsdague: jichen: hmm, note the body isn't even used here https://github.com/openstack/nova/blob/7529b94f4a0be17fb3988362619f83b404ccad86/nova/api/openstack/compute/admin_actions.py#L5918:51
*** syjulian has quit IRC18:51
belliottdansmith: https://review.openstack.org/#/c/314230/18:52
jichenmriedem: yeah, indeed18:52
mriedemwhat a great api18:52
mriedemit takes the nw info cache from the instance and injects it back into itself18:53
sdaguemriedem: it's an action18:54
sdaguethe body is used to just tell it what action happens18:54
sdagueI do kind of wonder why stuff like that was added18:55
dansmithbelliott: commented18:55
*** cloudnul- has joined #openstack-nova18:55
mriedemsdague: yeah, ok, sure. but agree, wtf is this used for?18:56
*** baoli has quit IRC18:56
sdaguemriedem: right, that's a good question18:56
*** jlanoux has quit IRC18:56
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408518:57
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353218:57
*** claudiub has joined #openstack-nova18:57
sdaguemriedem: ok, I think I captured all your feedback in the base patch there18:57
*** cloudnul- has quit IRC18:57
*** ijw has quit IRC18:58
openstackgerritRobert Ellis proposed openstack/nova: Removed extra white spaces and rebased.  https://review.openstack.org/31423718:59
belliottdansmith: thanks18:59
mriedemsdague: is this the same thing? http://docs.openstack.org/developer/nova/support-matrix.html#guest_setup_inject_networking18:59
*** ijw has joined #openstack-nova18:59
dansmithbelliott: I just went to make _sure_ we tag the bug for backports, but see you did already .. thanks :)18:59
belliottdansmith: heh :)19:00
*** shaohe_feng has quit IRC19:00
sdaguemriedem: https://review.openstack.org/#/c/3020/ is about as far as git log -S gets back to, it's a little harder to trace after taht19:01
*** shaohe_feng has joined #openstack-nova19:01
mriedemcrazy ass rax19:02
*** pwnall has quit IRC19:03
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423019:03
*** gszasz has quit IRC19:04
sdaguemriedem: yeh, it's that the same thing19:06
*** sdake_ has joined #openstack-nova19:06
*** sdake has quit IRC19:07
*** Sukhdev has quit IRC19:08
dansmithbelliott: I predict I will +2 patch set 3 :P19:09
*** lpetrut has quit IRC19:10
*** shaohe_feng has quit IRC19:10
openstackgerritRobert Ellis proposed openstack/nova: Rebasing again.  https://review.openstack.org/31424119:12
belliottdansmith: hah19:13
*** mdrabe_ has joined #openstack-nova19:13
*** mdrabe has quit IRC19:13
*** shaohe_feng has joined #openstack-nova19:13
mriedemreset-network, another fun one that only the xen driver implements19:14
*** Sukhdev has joined #openstack-nova19:15
*** kfarr has joined #openstack-nova19:15
*** ihrachys has quit IRC19:15
mriedemsdague: what do you think about pointing out in rest api doc descriptions things that are only implemented by a single driver, like resetNetwork?19:18
sdaguemriedem: we should probably call out that it only works with xenserver backed hypervisors and should not be relied upon19:19
dansmithmriedem: is that different from (should-be-)deprecated ?19:19
mriedemdansmith: i think it means it's a candidate for deprecation19:20
mriedemi don't see anything in the rackspace api reference for resetNetwork either19:20
sdagueyeh, I'd agree it's a candidate for deprecation19:20
dansmithright, so I just wonder if it makes sense to categorize it as that and not specifically "single-virt"19:20
*** shaohe_feng has quit IRC19:21
sdaguemaybe, I think during this documentation exercise though it's ok to just call it out, then look at all the things we called out when we look at the deprecations19:21
mriedemyeah maybe, i need to read sdague's spec on api deprecations again19:21
sdagueand make sure as a whole we drop them19:21
sdaguemriedem: I only did the proxies19:21
mriedemah right19:21
*** shaohe_feng has joined #openstack-nova19:21
dansmithwe probably have other single-virt apis that are forward-looking instead of "things we really shouldn't have done"19:21
sdaguedansmith: right19:22
sdaguebut I think we'll be in a better possition to evaluate all of those once we call them all out19:22
mriedemalso,19:23
mriedemos-resetState shouldn't be a 20219:23
*** prateek has quit IRC19:23
mriedemit updates the db from the rest api19:25
mriedemand doesn't return anything, so 20419:25
mriedemcdent is rubbing off on me here19:25
*** corey_ has quit IRC19:25
dansmithbelliott: if you want I can just fix in the online editor and then +2, I just don't want to race with anything you're doing19:28
belliottdansmith: actually that's not enough - update_service_ref is only called from WSGIService.start(), not Service.start()19:29
dansmithbelliott: really?19:29
belliottdansmith: that's what it looks like :)19:29
sdaguemriedem: yeh, the success codes are all over the place19:29
mriedemsdague: i opened a bug for that one, but will need to batch those up into a single microversion, i feel like someone was already doing something like that at one point19:30
belliottdansmith: i don't actually think update_service_ref works19:30
dansmithbelliott: ah, because we're expecting to run the periodic I think19:30
belliottdansmith: hmmm19:31
*** shaohe_feng has quit IRC19:31
dansmithbelliott: definitely works for the api server: http://logs.openstack.org/64/313664/3/check/gate-grenade-dsvm-multinode/d881986/logs/new/screen-n-api.txt.gz#_2016-05-09_18_30_13_66919:32
dansmithbelliott: so I'd think we'd just need similar behavior either in the periodic or on startup of the base service19:32
*** shaohe_feng has joined #openstack-nova19:32
belliottdansmith: nvm it probably works i've got a hacked up local copy19:32
belliottdansmith: yeah copy that19:33
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408519:33
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353219:33
sdaguejichen: updated based on your comments, good catch on the name19:33
sdagueI messed that up when I remerged the updates around security group19:33
*** roeyc has quit IRC19:35
*** mspreitz has quit IRC19:36
belliottdansmith: i like saving it explicitly so i added a call19:37
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423019:37
belliottdansmith: instead of waiting on periodic19:37
belliottdansmith: doesn't the periodic solution assume you use the db driver for servicegroup?19:37
dansmithbelliott: no19:38
jichensdague: ok, thanks, will take another look19:38
dansmithbelliott: but agreed, it's not going to change at runtime anyway, so no need to do it on periodic19:38
*** salv-orlando has joined #openstack-nova19:38
belliottdansmith: it is at least consistent with the api service now19:38
mriedemrbradfor: looks like we need to update the policy descriptions for os-tenant-networks https://review.openstack.org/#/c/314139/19:39
mriedemthat's probably just old copy/paste, but the resource is networks, not servers19:40
rbradformriedem, will do, thanks.19:41
mriedemafter half a day of reviewing api-ref, i think we should just give up and delete it all :) the api is henceforth for the adventurous and strong of will19:41
*** shaohe_feng has quit IRC19:41
rbradformriedem, but I have a list of questions and improvements in testing nova, should we not put it to a vote!!19:41
*** lpetrut has joined #openstack-nova19:42
*** shaohe_feng has joined #openstack-nova19:44
*** baoli has joined #openstack-nova19:44
*** zenoway has joined #openstack-nova19:46
*** baoli has quit IRC19:47
*** baoli has joined #openstack-nova19:47
*** Sukhdev has quit IRC19:47
dansmithbelliott: we're just hitting the database twice for no reason now, right?19:49
*** tonytan4ever has joined #openstack-nova19:49
dansmithbelliott: I think a small change will collapse it back to one and still do the right thing19:49
openstackgerritRonald Bradford proposed openstack/nova: [WIP] Complete method verification of os-security-groups  https://review.openstack.org/31425519:50
*** tonytan_brb has joined #openstack-nova19:51
*** shaohe_feng has quit IRC19:51
sdaguemriedem: that's good motivation to deprecate some big chuncks of it, to get it within working memory19:52
openstackgerritSean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output  https://review.openstack.org/31425719:52
*** shaohe_feng has joined #openstack-nova19:52
*** omnipresent has joined #openstack-nova19:53
sdaguealso, git worktree add is my new best friend for doing a number of active bits in parallel19:53
openstackgerritSean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output  https://review.openstack.org/31425719:54
*** ctrath has quit IRC19:54
*** tonytan4ever has quit IRC19:54
*** zenoway has quit IRC19:55
mriedemso policy on os-tenant-networks:create doesn't exist, i guess that just means anyone can create a tenant network19:56
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408519:56
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353219:56
sdagueI thought the fall back was admin_or_owner19:56
*** zenoway has joined #openstack-nova19:57
mriedem"network:create": "rule:admin_or_owner",19:58
mriedemit is, jichen was just pointing out, how does owner work for a thing that doesn't exist yet19:58
sdaguehttps://github.com/openstack/nova/blob/1801a48cc6b529272c81687f1ffd41753e5c3e9a/etc/nova/policy.json#L419:58
sdaguemriedem: right, it means it's really just is_admin19:58
*** ijw has quit IRC20:00
*** ijw has joined #openstack-nova20:00
*** omnipresent has quit IRC20:01
*** shaohe_feng has quit IRC20:02
openstackgerritRonald Bradford proposed openstack/nova: Complete method verification of os-security-groups  https://review.openstack.org/31425520:02
*** shaohe_feng has joined #openstack-nova20:02
*** thorst_ has quit IRC20:03
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (1)  https://review.openstack.org/30919220:04
*** fragatina has quit IRC20:04
*** thorst_ has joined #openstack-nova20:04
*** d34dh0r53 is now known as th3r34ld0n4ld7ru20:05
sdaguejichen: regarding one of your comments, there is a whole missing server-tags.inc file in the api-ref. There was never any api documentation included with that resource in the old site20:05
sdaguemriedem: hit the last items of yours from - https://review.openstack.org/#/c/313532/20:05
sdaguehopefully that's mergable now20:05
*** th3r34ld0n4ld7ru is now known as therealmajorhayd20:05
*** thorst_ has quit IRC20:06
*** lucas-dinner has quit IRC20:06
*** thorst_ has joined #openstack-nova20:06
openstackgerritMatt Riedemann proposed openstack/nova: trivial: removed unused networks var from os-tenant-networks:create  https://review.openstack.org/31426120:06
*** therealmajorhayd is now known as d34dh0r5320:07
jichensdague: ok, it's newly added API so guess not old api doc for it20:07
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (2)  https://review.openstack.org/30919420:07
mriedemsdague: what about the other missing create server parameters i pointed out?20:07
mriedemadminPass and the multiple-create ones?20:07
*** mdrabe_ has quit IRC20:07
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L54520:08
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/multiple_create.py#L4620:08
sdaguemriedem: multiple create is documented separately20:10
*** pwnall has joined #openstack-nova20:10
mriedemsigh20:10
*** Daisy has joined #openstack-nova20:10
mriedemok, adminPass then :)20:10
sdagueadmin pass I lost when I fixed one of the other issues20:10
sdagueadding it back now20:10
mriedemsome things being in the server create request docs and some in extension specific docs is like a kick in the balls20:10
*** Daisy_ has joined #openstack-nova20:11
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (3)  https://review.openstack.org/30919620:11
mriedemfunny when it happens to someone else, but not me20:11
sdagueyeh, multiple create is different enough it's documented separately, which makes some sense20:11
mriedemsure20:11
mriedemlong-term, when we drop extensions, are we going to munge all of these together?20:11
*** shaohe_feng has quit IRC20:12
*** shaohe_feng has joined #openstack-nova20:13
*** baoli has quit IRC20:13
sdaguemultiple create... probably20:13
*** baoli has joined #openstack-nova20:14
*** mdrabe has joined #openstack-nova20:14
sdaguewe'd merge the back end code for a lot of things, which should make stuff more clear20:14
*** vilobhmm111 has joined #openstack-nova20:14
*** baoli has quit IRC20:14
*** vilobhmm11 has quit IRC20:14
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (4)  https://review.openstack.org/30919820:15
*** Daisy has quit IRC20:15
*** baoli has joined #openstack-nova20:15
*** rcernin has quit IRC20:15
*** Daisy_ has quit IRC20:16
openstackgerritRonald Bradford proposed openstack/nova: Complete method verification of os-security-group-rules  https://review.openstack.org/31426420:16
*** lucasagomes has joined #openstack-nova20:16
*** lucasagomes is now known as lucas-dinner20:17
*** pwnall has quit IRC20:18
*** baoli has quit IRC20:21
openstackgerritRobert Ellis proposed openstack/nova: Changed 202 for lock/unlock return code to 200. This addresses bug 1449811. 409 return code was not addressed as the compute node is already in that state so no corrective action is required. 404 is already covered by existing code.  https://review.openstack.org/31426720:21
openstackbug 1449811 in OpenStack Compute (nova) "nova lock/unlock api return code is not accurate" [Wishlist,Confirmed] https://launchpad.net/bugs/1449811 - Assigned to Robert Ellis (bob-ellis42)20:21
*** tonytan4ever has joined #openstack-nova20:21
*** shaohe_feng has quit IRC20:22
openstackgerritRonald Bradford proposed openstack/nova: Complete method verification of os-tenant-networks  https://review.openstack.org/31413920:23
*** shaohe_feng has joined #openstack-nova20:23
*** fragatina has joined #openstack-nova20:23
*** tonytan_brb has quit IRC20:25
openstackgerritSean Dague proposed openstack/nova: api-ref: complete verification for diagnostics.inc  https://review.openstack.org/31408520:25
openstackgerritSean Dague proposed openstack/nova: api-ref: update parameter validation on servers  https://review.openstack.org/31353220:25
openstackgerritSarafraj Singh proposed openstack/nova: [WIP] api-ref: Update method validation on images  https://review.openstack.org/31426820:26
*** zenoway has quit IRC20:26
*** smatzek has quit IRC20:27
*** ctrath has joined #openstack-nova20:28
*** sambetts is now known as sambetts|afk20:29
*** shaohe_feng has quit IRC20:32
*** pwnall has joined #openstack-nova20:33
*** jeblair has quit IRC20:33
*** shaohe_feng has joined #openstack-nova20:33
*** jeblair has joined #openstack-nova20:33
belliottdansmith: i had just followed the pattern in WSGIService earlier, but now I've corrected both to only hit the db once20:35
openstackgerritSean Dague proposed openstack/nova: api-ref: add url parameter to expand all sections  https://review.openstack.org/31427120:37
*** zenoway has joined #openstack-nova20:38
*** baoli has joined #openstack-nova20:38
mriedemsdague: i was just going over the notes from the glance session at the summit,20:39
mriedemthere might be some confusing directions in here,20:39
mriedemwe said we were going to copy v1 for v2, fix the v2 code to work with glance v2 and then drop v1 eventually20:40
mriedembut we also said that the code would use v2 for things that are implemented, and fallback to v1 for things that aren't yet, so it can go in a series20:40
sdaguemriedem: where eventually == as soon as v2 works for all drivers20:40
*** baoli has quit IRC20:40
mriedemyeah20:40
mriedemthing is, if we want to test this in pieces it seems mfedosin is still going to have version discovery logic in there20:41
sdaguewhy20:41
sdaguehttps://review.openstack.org/#/c/306447/1/specs/newton/approved/use-glance-v2-api.rst20:41
sdaguewe have a big top level switch20:41
*** baoli has joined #openstack-nova20:42
dansmithbelliott: cool20:42
mriedemso basically, he can have a patch per operation for v2, but none of it will work until the top change20:42
*** zenoway has quit IRC20:42
sdaguemriedem: sure20:42
mriedemand we'd run a job against that which disables glance v1 and configures nova to use_glancev2=True20:42
sdaguebut that's actually way less confusing than a request flow bouncing back and forth between versions20:42
sdaguemriedem: correct20:43
*** shaohe_feng has quit IRC20:43
sdaguemriedem: and at some point that starts passing20:43
*** xyang1 has joined #openstack-nova20:43
*** pwnall1 has joined #openstack-nova20:43
sdaguewe're using the conf value as a feature flag to keep it off when it's not fully implemented. It can still be unit tested in parts20:43
openstackgerritBrian Elliott proposed openstack/nova: Fix service version to update the DB  https://review.openstack.org/31423020:43
*** shaohe_feng has joined #openstack-nova20:44
*** fragatina has quit IRC20:44
*** pwnall has quit IRC20:44
*** pwnall has joined #openstack-nova20:44
*** sdake has joined #openstack-nova20:44
dansmithbelliott: do we have no test coverage for the code you're changing?20:45
mriedemsdague: ok, it's clear in my head now, the notes in the etherpad were conflicting, and i think mfedosin wanted to keep doing version discovery/conditional logic in the code series, so it has to be clear to him we're not doing that20:45
sdaguemriedem: right, I think that version discovery inline is part of what makes things confusing, because you have to handle both cases all the time, and in common code20:46
dansmithalaski: why do you think that metadata bit needs to be a different spec?20:46
*** pwnall has quit IRC20:46
dansmithalaski: moving keypairs out of the cell db necessitates us storing the full keypair with the instance, so I see them as one thing20:47
*** sdake_ has quit IRC20:47
belliottdansmith: seems not20:47
alaskidansmith: just because I like to split things as much as possible. I think they're definitely dependent, but two separate efforts20:47
*** baoli has quit IRC20:47
dansmithbelliott: well, feels like we should have something to validate that this behavior is (now) correct, right?20:48
alaskidansmith: I'm not going to filibuster on that though if others are okay with them merged20:48
dansmithalaski: but really needing another spec?20:48
*** pwnall1 has quit IRC20:48
*** baoli has joined #openstack-nova20:48
belliottdansmith: i'll add something to confirm service records are actually updated, not just created.  that seems to be the gap20:48
dansmithalaski: I mean, the patches are all split up, but it seems like the boiler plate in another spec will be almost as large as the description of the change...20:48
dansmithbelliott: cool, thanks20:48
mriedemsdague: nikhil: ok, summit session recap for nova/glance is sent out, let me know if i missed anything in htere20:49
mriedem*three20:49
mriedemdamn20:49
mriedemyou know what i mean20:49
sdaguemriedem: cool, I'll check in the morning, time to get the grill running here.20:49
sdaguehttps://review.openstack.org/#/c/314271/ should be a much easier review on the api-ref side20:50
sdagueoh, sorry, not that one, though it is too20:50
mikalMorning20:50
alaskidansmith: agreed. but the changes have two purposes, though they are related.20:50
alaskidansmith: I'm not going to -1 for it, but I would prefer it20:50
sdaguewow, gerrit has the slows for me20:50
*** BjoernT has joined #openstack-nova20:50
dansmithalaski: hmm, I'm not sure I get it.. if we weren't moving the keypairs out, then we wouldn't need to change the metadata code20:51
alaskidansmith: we wouldn't need to, but it's still a beneficial change on its own20:51
dansmithalaski: maybe you're reading too much into what he said about "reads the table directly" ?20:51
dansmithalaski: it just uses the object like anything else20:51
alaskiyeah, I get that20:52
dansmithand goes through conductor if you run metadata without use_local20:52
dansmithhmm, okay20:52
*** vtech has quit IRC20:53
alaskiI see migrating keypairs out of cells as one thing, like the other migrations. and I see attaching more data to the instance and passing it through as another thing, like flavors into instance_extra20:53
openstackgerritSean Dague proposed openstack/nova: api-ref: perform all 4 phases of verification for action console output  https://review.openstack.org/31425720:53
*** shaohe_feng has quit IRC20:53
*** neophy has quit IRC20:53
sdaguemriedem: that should be a much easier reviewable one. Some times the actions interface makes it easier to explain things :)20:53
*** shaohe_feng has joined #openstack-nova20:54
dansmithalaski: especially in this case I don't agree at all20:54
dansmithalaski: but anyway, I commented with my feelings20:55
*** smatzek has joined #openstack-nova20:55
nikhilmriedem: thanks for the heads-up20:56
*** mvk has joined #openstack-nova20:57
alaskidansmith: counter commented to clarify my vote20:57
dansmithalaski: I counter-counter-commented to clarify my dissent20:57
dansmith(not really, I just wanted to say counter-counter-commented020:57
alaski:)20:57
*** salv-orlando has quit IRC20:58
openstackgerritTom Patzig proposed openstack/nova-specs: Add "disable root_disk" option to flavors  https://review.openstack.org/26767320:58
*** baoli has quit IRC20:59
*** Sukhdev has joined #openstack-nova21:01
mriedemsdague: on https://review.openstack.org/#/c/313532/ i'm not seeing where you can update access IPs for diskConfig for a server21:01
mriedem*or diskConfig21:01
cdentjaypipes: I've just finished the second of two reviews on https://review.openstack.org/#/c/300176/ , two different hats21:02
*** pwnall has joined #openstack-nova21:02
*** mageshgv has quit IRC21:03
*** shaohe_feng has quit IRC21:03
*** rlrossit has quit IRC21:04
*** shaohe_feng has joined #openstack-nova21:04
*** unicell has quit IRC21:05
*** baoli has joined #openstack-nova21:06
*** smatzek has quit IRC21:06
bauzasjaypipes: still around ?21:07
bauzasjaypipes: I'm just reviewing the generic-resource-pools spec21:07
*** tjones has left #openstack-nova21:08
bauzasjaypipes: I have a question for you about resource classes and how an operator can know it21:09
*** avula has quit IRC21:09
bauzas(and if it's interop)21:09
*** unicell has joined #openstack-nova21:10
cdentbauzas: I _might_ be able to help, what's up?21:11
bauzascdent: lemme just upload my question21:11
cdent++21:11
*** fragatina has joined #openstack-nova21:11
cdentbauzas: are you just innately a night person or is there some other reason you're usually around late?21:12
bauzascdent: done, my question is up21:12
*** mageshgv has joined #openstack-nova21:12
bauzascdent: it's about using the --resource_class flag in the client, meaning that the operator knows it21:12
bauzascdent: I'm a night owl21:13
*** lpetrut has quit IRC21:13
bauzas(TBH, evenings are perfect for doing things you don't have time for it during workhours)21:13
*** jichen has quit IRC21:13
*** shaohe_feng has quit IRC21:13
bauzas(like reviewing specs you promised)21:14
cdent:)21:14
cdentbauzas: It turns out I think I can answer that question, will answer it there21:14
bauzasgreat21:14
*** shaohe_feng has joined #openstack-nova21:14
bauzasnote that I haven't voted21:14
bauzascdent: short answer maybe here ?21:15
*** Guest56459 is now known as mfisch21:15
cdentif you prefer sure:21:15
*** sheel has quit IRC21:15
*** mfisch is now known as Guest8708521:15
alaskidansmith: on https://review.openstack.org/#/c/312751/5, is there a test that already covers the case of a keypair being set at boot time?21:15
bauzascdent: well, just in case I have a follow-up question21:15
cdentbasically in the current implementatation of resource classes there are only a small number of them and in the nova.objects universe they an indexed enum. that is when you used them as a human you use a string, but when the get stored into a database, an int is stored but that int is the same across all deployments21:16
cdentso the deployer is supposed to know the names, via docs21:16
cdenthowever21:17
cdentthere is a spec in progress for dynamic resource classes21:17
bauzasoh right21:17
bauzasI missed that21:17
cdentfor deployment specific resource classes21:17
cdentwhen that's done (if it is) there will be an API for listing the names (both standard and dynamic)21:17
bauzasyeah, for dynamic resource classes, that would be necessary, but not in that spec21:18
cdentthe dynamic ones will also be stored as ints, but they will started at some high number21:18
dansmithalaski: in unit tests you mean? all the tempest ssh ones do, right?21:18
cdentbauzas: that answer it well enough?21:18
alaskidansmith: I was thinking unit test, but a tempest test works for me. just something to prove it doesn't go boom21:19
bauzascdent: yeah, just amending my comment21:19
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: Complete method verification of os-fping  https://review.openstack.org/31428721:19
bauzascdent: thnaks for answering21:19
*** Guest87085 is now known as mfisch21:19
cdentmy pleasure21:19
*** mfisch has quit IRC21:20
*** mfisch has joined #openstack-nova21:20
*** burgerk has quit IRC21:20
bauzascdent: my resource-* knowledge is currently on a 1.44MB virtual floppy disk, I should think of increasing that before asking questions :)21:21
*** xyang1 has quit IRC21:21
cdentI think you're going to need a TB21:21
*** aysyd has quit IRC21:22
*** dkliban has joined #openstack-nova21:22
*** lakshmiS has quit IRC21:22
*** rtheis has quit IRC21:23
*** NightKhaos has quit IRC21:23
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (4)  https://review.openstack.org/30919821:24
*** shaohe_feng has quit IRC21:24
dansmithalaski: https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L13621:24
*** unicell has quit IRC21:24
*** shaohe_feng has joined #openstack-nova21:25
alaskidansmith: cool. There did seem to a few tests using it21:25
dansmithyeah, in unit tests too21:25
dansmithbut the fact it works in tempest gives me higher confidence21:25
alaskiagreed21:26
*** svenkat has quit IRC21:27
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (3)  https://review.openstack.org/30919721:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (4)  https://review.openstack.org/30919921:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (1)  https://review.openstack.org/30919321:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (2)  https://review.openstack.org/30919521:28
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (5)  https://review.openstack.org/31429021:28
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (5)  https://review.openstack.org/31429121:28
*** edmondsw has quit IRC21:29
*** NightKhaos has joined #openstack-nova21:29
*** ivase has quit IRC21:30
nikhilmriedem: hey, I updated https://etherpad.openstack.org/p/nova-glance-newton line 62 to help mike be aware of the decisions and clarified that mike's comments on line 44 are old21:30
mriedemnikhil: thanks21:32
*** unicell has joined #openstack-nova21:33
*** unicell has quit IRC21:33
*** unicell has joined #openstack-nova21:33
cdentnight all21:33
*** cdent has quit IRC21:33
*** shaohe_feng has quit IRC21:34
*** ivase has joined #openstack-nova21:34
*** unicell1 has joined #openstack-nova21:35
*** unicell has quit IRC21:35
*** shaohe_feng has joined #openstack-nova21:37
nikhilmriedem: also, I wanted to explicitly point out the second last comment from my on https://review.openstack.org/#/c/301741/ . I'm not aware of the discussion on the image-list-details call. If there was none, we may need to re-discuss this bit :/21:37
nikhils/my/me/g21:37
mriedemnikhil: which line?21:38
nikhilmriedem: https://review.openstack.org/#/c/301741/4/specs/newton/approved/use-glance-v2-api.rst@11821:38
*** browne has joined #openstack-nova21:39
nikhilmriedem: last comment is most relevant21:39
*** ivase has quit IRC21:39
jaypipesbauzas: pls leave your question... will get to it in a bit.21:39
bauzasjaypipes: nah, it's all good21:40
bauzasjaypipes: cdent answered it before21:40
bauzasjaypipes: I just left my happy mark as a pet21:40
*** roook has joined #openstack-nova21:41
mriedemnikhil: ok, i haven't read those yet, and won't have time to right now, but will go back over them21:41
nikhilmriedem: np, I think if that's not agreed upon and most likely mike did not notice, we may need to discuss.21:42
bauzasjaypipes: tbc, my comment was about https://www.youtube.com/watch?v=FPQlXNH36mI21:44
*** shaohe_feng has quit IRC21:44
bauzass/about/related to21:45
*** shaohe_feng has joined #openstack-nova21:45
*** roeyc has joined #openstack-nova21:47
*** jamesden_ has quit IRC21:48
*** mriedem is now known as mriedem_afk21:50
*** Swami_ has joined #openstack-nova21:52
*** yamahata has quit IRC21:52
*** shaohe_feng has quit IRC21:54
*** Swami has quit IRC21:55
*** shaohe_feng has joined #openstack-nova21:55
*** Swami_ has quit IRC21:58
*** salv-orlando has joined #openstack-nova21:58
*** nic has quit IRC21:59
*** nic has joined #openstack-nova22:00
*** Sukhdev has quit IRC22:00
*** catintheroof has quit IRC22:01
siva_krishnanHad a question on centralizing config options. Should we delete opts.py  in each module after moving all options to nova/conf ? your thoughts on this please22:01
*** sdake has quit IRC22:02
*** salv-orlando has quit IRC22:03
*** amotoki has joined #openstack-nova22:03
edleafesiva_krishnan: yes, you should22:04
siva_krishnanedleafe gate-nova-docs are faling if i remove it22:05
*** shaohe_feng has quit IRC22:05
*** tonytan4ever has quit IRC22:05
edleafesiva_krishnan: you also have to remove the reference in setup.cfg22:06
*** mageshgv has quit IRC22:06
*** shaohe_feng has joined #openstack-nova22:07
siva_krishnanedleafe thanks for pointing that out :)22:09
*** ctrath has quit IRC22:09
openstackgerritAugustina Ragwitz proposed openstack/nova: WIP: api-ref: Verify methods for metadata.inc  https://review.openstack.org/31430922:09
*** kfarr has quit IRC22:10
*** browne has quit IRC22:10
*** dimtruck is now known as zz_dimtruck22:10
*** zz_dimtruck is now known as dimtruck22:10
openstackgerritSujitha proposed openstack/nova: Complete method verification of os-migrations  https://review.openstack.org/31431022:11
auggyok wow, it is really hard to tell what's being worked on for the api-ref stuff22:14
*** eharney has quit IRC22:14
*** shaohe_feng has quit IRC22:15
*** shaohe_feng has joined #openstack-nova22:16
*** dimtruck is now known as zz_dimtruck22:20
*** ducttape_ has quit IRC22:21
*** haplo37 has quit IRC22:22
*** dave-mccowan has quit IRC22:22
*** shaohe_feng has quit IRC22:25
*** shaohe_feng has joined #openstack-nova22:26
*** pradk has quit IRC22:29
*** salv-orlando has joined #openstack-nova22:29
aunnam_sdague, for the api-ref work how do we handle the deprecated commands, like the file os-volumes.inc which has the deprecated options like nova volume-list, nova volume-create. Should i continue updating the file for such deprecated options too?22:29
*** mrkz has quit IRC22:30
auggyaunnam_: i think sdague is gone for the day, but my guess is if the code supports it then it should be updated22:32
*** mdrabe has quit IRC22:32
*** pradk has joined #openstack-nova22:33
*** pradk has quit IRC22:33
*** rbridgeman_ has quit IRC22:33
*** dkliban has quit IRC22:33
*** mlavalle has quit IRC22:33
*** dkliban has joined #openstack-nova22:34
*** salv-orlando has quit IRC22:35
*** jamielennox|away is now known as jamielennox22:35
*** shaohe_feng has quit IRC22:35
aunnam_auggy, thanks for the reply. Ya the code supports but it gives the deprecated warning so i should update it then22:36
auggyaunnam_: i'd have to look at other docs but there should be something in the docs that say it's deprecated22:36
*** thorst_ has quit IRC22:36
*** Swami has joined #openstack-nova22:37
*** sacharya has quit IRC22:37
*** ccarmack1 has quit IRC22:37
*** ccarmack has joined #openstack-nova22:38
*** shaohe_feng has joined #openstack-nova22:38
*** vtech has joined #openstack-nova22:38
aunnam_auggy, i don't see any deprecated warning in the docs22:39
auggyaunnam_: I found this - https://github.com/openstack/nova/blob/master/api-ref/source/extensions.inc22:39
auggyso maybe it should go in the method name title for the section22:39
auggymaybe when alex_xu or oomichi are around they could provide some insight?22:40
*** BjoernT has quit IRC22:40
auggyto me, the logical thing would be to do Method Foo Bar (DEPRECATED)22:41
openstackgerritSivasathurappan Radhakrishnan proposed openstack/nova: centralized conf: nova/network/rpcapi.py  https://review.openstack.org/27421022:42
aunnam_auggy, that makes sense22:42
auggyaunnam_: then i'd just put a comment on your review asking about how we should handle deprecated methods22:42
*** sambetts|afk has quit IRC22:43
oomichiauggy: https://github.com/openstack/nova/blob/master/api-ref/source/extensions.inc#L8 means the deprecation of extension mechanism itself22:45
oomichiauggy: we can use microversions mechanism now instead of extension mechanism22:45
auggyoomichi: should we indicate deprecated methods in the api-ref docs?22:46
*** shaohe_feng has quit IRC22:46
auggylike in the title or something?22:46
*** zenoway has joined #openstack-nova22:46
*** tonytan4ever has joined #openstack-nova22:46
*** shaohe_feng has joined #openstack-nova22:46
oomichiauggy: at line 80 of https://etherpad.openstack.org/p/newton-nova-api22:46
*** sambetts has joined #openstack-nova22:47
oomichiauggy: they will be deprecated with a new microversion22:47
oomichiauggy: that means we still continue using these apis on original versions22:47
auggyoomichi: right, but should we indicate something in the api docs that those methods are deprecated?22:47
*** cdelatte has quit IRC22:47
auggyif not that's fine, it just seems logical to me that as an api user i'd want to know if i shouldn't use a particular method22:48
*** cdelatte has joined #openstack-nova22:48
oomichiauggy: so it is nice to update these api docs also, but that should be low priority by comparing the other part22:48
oomichiauggy: for the exsting users22:48
*** roeyc has quit IRC22:48
auggyaunnam_: oomichi: ok, so it looks like for now, don't do anything, just treat them as normal methods22:49
*** efried has quit IRC22:49
auggyaunnam_: oomichi: maybe if i manage to wake up in time for the next api meeting i can bring it up and ask how we want to deal with those in the docs, so we can discuss as a team :)22:49
*** cdelatte has quit IRC22:51
oomichiauggy: yeah, that will be nice discussion :-) maybe people have different opinions like "to enforce to use cinder api directly without proxy apis, we should not write them on api-ref" or something22:51
*** zenoway has quit IRC22:51
*** cdelatte has joined #openstack-nova22:51
auggyhooray i finally found a .inc file no one else is working on from what i can tell ;)22:52
*** tonytan4ever has quit IRC22:52
aunnam_auggy, you mean don't update such methods, just leave them?22:52
auggyaunnam_: no, do the verification, treat them as normal methods22:52
aunnam_auggy, ok git it :)22:53
auggybut feel free to put a comment in the review asking about how we should handle deprecated methods22:53
auggythat's what i'd do :)22:53
*** hemna is now known as hemnafk22:53
aunnam_auggy, sure thanks for the suggestions22:53
auggyaunnam_: also, when you start working on one of those, be sure to push a WIP patch right away with what section of the verification you are doing so someone else doesn't start work on teh same file22:54
auggyi didn't see your patch for the volumes stuff and almost started working on it22:54
auggyif you hadn't said anything in irc, i would have also been working on it, whoops :)22:54
aunnam_ya thats a major problem., will submit a patch right away22:55
openstackgerritAugustina Ragwitz proposed openstack/nova: WIP: api-ref: ips.inc parameter verification  https://review.openstack.org/31432022:55
*** shaohe_feng has quit IRC22:56
auggythx! i wish we had a better way to figure out what is being worked on:/22:56
*** shaohe_feng has joined #openstack-nova22:57
auggyright now i'm just keeping a spreadsheet :/22:57
aunnam_auggy, i wish there is an etherpad, where one can put their names on the files which they are working on22:58
*** sdague has quit IRC22:58
auggyyeah i think we decided not to do that because people were worried it would be out of date22:58
*** ccarmack has joined #openstack-nova22:58
*** ametts has quit IRC22:58
aunnam_ok22:59
auggyaunnam_: i just posted a message to the ML asking if we could come up with a better way to track who is working on what, so maybe someone will have some ideas23:01
*** claudiub has quit IRC23:01
*** gjayavelu has joined #openstack-nova23:02
*** ccarmack has left #openstack-nova23:03
aunnam_auggy, great lets see. Now it is taking more time to actually look for .inc file which is not taken and if it is taken, keeping track of what verification is left is also difficult23:05
auggyaunnam_: yeah agreed, i think it's an obstacle for people diving in23:05
auggyit would also be nice to mark ones that are good for people who are new to nova versus ones that are trickier23:05
*** shaohe_feng has quit IRC23:06
*** diogogmt has quit IRC23:06
*** shaohe_feng has joined #openstack-nova23:07
*** ijw has quit IRC23:07
*** ijw has joined #openstack-nova23:07
aunnam_auggy, ya that really helps a lot to the people like me who just started with nova23:08
*** zz_dimtruck is now known as dimtruck23:11
*** tjones has joined #openstack-nova23:12
*** tjones has left #openstack-nova23:16
*** shaohe_feng has quit IRC23:16
*** cdelatte has quit IRC23:17
*** shaohe_feng has joined #openstack-nova23:17
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (3)  https://review.openstack.org/30919723:18
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (4)  https://review.openstack.org/30919923:18
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (1)  https://review.openstack.org/30919323:18
openstackgerritEd Leafe proposed openstack/nova: Move config options from nova/api directory (5)  https://review.openstack.org/31429023:18
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (5)  https://review.openstack.org/31429123:18
openstackgerritEd Leafe proposed openstack/nova: Improve the help text for the API options (2)  https://review.openstack.org/30919523:18
* edleafe really messed up the rebase order of that stack ^^23:19
*** gongysh has joined #openstack-nova23:20
openstackgerritAugustina Ragwitz proposed openstack/nova: api-ref: ips.inc parameter verification  https://review.openstack.org/31432023:22
*** zenoway has joined #openstack-nova23:22
*** BjoernT has joined #openstack-nova23:24
*** vilobhmm111 has quit IRC23:25
openstackgerritAnusha Unnam proposed openstack/nova: WIP: api-ref: os-volumes.inc method verification  https://review.openstack.org/31432523:25
*** zenoway has quit IRC23:27
*** shaohe_feng has quit IRC23:27
auggyedleafe: hey i have a question on behalf of zeroDivisible23:27
*** shaohe_feng has joined #openstack-nova23:27
auggythey are interested in helping out with the config centralization stuff23:27
edleafeauggy: shoot23:28
*** penick has quit IRC23:28
auggyzeroDivisible: why don't you go ahead and ask :)23:28
*** BjoernT is now known as Bjoern_zZzZzZzZ23:30
zeroDivisibleauggy: hah, ok :) edleafe: basically, I've meant to look at doing one of the unmarked options (disable_rootwrap) as an easy way of introducing myself to the source code, but I think that it's in the correct place now - so I had been wondering if there's something in relation to this task with which I can help. I noticed that preallocate_images, once reevaluated maybe will need to be changed to23:30
zeroDivisibleBoolOpt, so was wondering if I can give it a go23:30
edleafezeroDivisible: so it's been moved into nova/conf already, right?23:32
zeroDivisibleedleafe: yeah, I think so23:32
zeroDivisibleit's in nova/conf/workarounds23:32
edleafezeroDivisible: yeah, looking at it now, it's moved, and the help text has been updated to be, well, more helpful :)23:33
*** Bjoern_zZzZzZzZ is now known as BjoernT23:33
edleafezeroDivisible: so this process is twofold: move the options into nova/conf unchanged, and then enhance their help text23:34
zeroDivisibleedleafe: gotcha.23:34
edleafeWe use this etherpad to track who's working on what: https://etherpad.openstack.org/p/config-options23:35
*** ijw has quit IRC23:35
*** ijw has joined #openstack-nova23:35
edleafezeroDivisible: I see that most are already being worked on, but there are a bunch of libvirt options that seem to have been added recently23:35
edleafeI'm not sure if 'hielq' is working on them or not23:36
*** shaohe_feng has quit IRC23:37
*** salv-orlando has joined #openstack-nova23:37
auggyzeroDivisible: lol i forgot i put my name on one, destroy_after_evacuate23:37
*** sacharya has joined #openstack-nova23:37
auggyyou can take that one23:37
zeroDivisibleedleafe: gotcha, I'll try to find out, if yes and other tasks are up to discussion, I may just pick something else which is simple23:37
edleafezeroDivisible: like this: https://review.openstack.org/#/c/301564/ - hasn't had any activity for 5 weeks23:37
*** BjoernT has quit IRC23:38
auggylooks like handle_virt_lifecycle_events and disable_libvirt_livesnapshot are free unless someone else has worked on them and not updated the etherpad23:38
*** shaohe_feng has joined #openstack-nova23:38
zeroDivisibleedleafe: if I'm checking correctly, destroy_after_evacuate has a not in releasenotes/notes that it had been removed as it's no longer necessary, I may cross the line in etherpad23:39
edleafezeroDivisible: yes, that's correct23:39
edleafezeroDivisible: my API config options patchset has been around so long (since December) that several opts have already been removed. :)23:40
*** sacharya has quit IRC23:42
*** salv-orlando has quit IRC23:42
zeroDivisibleedleafe: can't cry after deleted code :)23:43
*** roook has quit IRC23:43
openstackgerritAugustina Ragwitz proposed openstack/nova: WIP: api-ref: ips.inc example verification  https://review.openstack.org/31432823:44
*** rooooook has joined #openstack-nova23:46
*** abitha has joined #openstack-nova23:46
*** shaohe_feng has quit IRC23:47
*** shaohe_feng has joined #openstack-nova23:47
*** ijw_ has joined #openstack-nova23:56
*** ijw has quit IRC23:56
*** armax has quit IRC23:57
*** shaohe_feng has quit IRC23:57
*** Sukhdev has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!