Wednesday, 2016-03-09

*** rhagarty__ has quit IRC00:00
*** rhagarty__ has joined #openstack-nova00:00
*** rhagarty__ has quit IRC00:00
*** rhagarty__ has joined #openstack-nova00:00
*** haomaiwang has quit IRC00:01
*** rhagarty__ has quit IRC00:01
*** rhagarty__ has joined #openstack-nova00:01
*** rhagarty__ has quit IRC00:01
*** haomaiwang has joined #openstack-nova00:01
*** rhagarty__ has joined #openstack-nova00:01
*** rhagarty__ has quit IRC00:02
*** rhagarty_ has joined #openstack-nova00:02
*** thorst_ has joined #openstack-nova00:02
*** rhagarty_ has quit IRC00:02
*** rhagarty_ has joined #openstack-nova00:02
*** rhagarty_ has quit IRC00:03
*** rhagarty_ has joined #openstack-nova00:03
*** rhagarty_ has quit IRC00:03
*** rhagarty_ has joined #openstack-nova00:03
*** rhagarty_ has quit IRC00:04
*** rhagarty_ has joined #openstack-nova00:04
*** rhagarty_ has quit IRC00:04
*** rhagarty_ has joined #openstack-nova00:04
*** alex_xu has quit IRC00:05
*** rhagarty_ has quit IRC00:05
*** rhagarty_ has joined #openstack-nova00:05
*** akshai has quit IRC00:05
*** rhagarty_ has quit IRC00:05
*** rhagarty_ has joined #openstack-nova00:05
*** edmondsw has quit IRC00:06
*** rhagarty_ has quit IRC00:06
*** rhagarty_ has joined #openstack-nova00:06
*** rhagarty_ has quit IRC00:06
*** rhagarty_ has joined #openstack-nova00:06
*** rhagarty__ has joined #openstack-nova00:07
*** rhagarty_ has quit IRC00:07
*** alex_xu has joined #openstack-nova00:07
*** rhagarty__ has quit IRC00:07
openstackgerritGhanshyam Mann proposed openstack/nova: Stop raising 404 when no mountpoint for volume attachment  https://review.openstack.org/29019600:07
*** rhagarty__ has joined #openstack-nova00:07
*** davechen_afk has quit IRC00:07
*** rhagarty__ has quit IRC00:08
*** gongysh_ has joined #openstack-nova00:09
*** gyee has joined #openstack-nova00:10
*** gyee has quit IRC00:11
*** doug-fish has joined #openstack-nova00:11
*** gyee has joined #openstack-nova00:15
*** zenoway has joined #openstack-nova00:15
*** tbachman has joined #openstack-nova00:15
*** zenoway has quit IRC00:20
*** hemna is now known as hemnafk00:20
*** gjayavelu has joined #openstack-nova00:21
*** irenab_ has joined #openstack-nova00:23
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Fix sample version of service-update  https://review.openstack.org/29019800:23
*** fawadkhaliq has joined #openstack-nova00:23
*** irenab has quit IRC00:25
*** irenab_ is now known as irenab00:25
*** salv-orlando has joined #openstack-nova00:30
*** browne has quit IRC00:33
*** fawadkhaliq has quit IRC00:35
*** bapalm has quit IRC00:37
*** sheel has joined #openstack-nova00:39
*** yuntongjin has joined #openstack-nova00:40
*** salv-orlando has quit IRC00:40
*** apoorvad has quit IRC00:43
*** mriedem has joined #openstack-nova00:44
*** pwnall has quit IRC00:46
*** yuntongjin has quit IRC00:46
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Dont-merge: Kick function tests  https://review.openstack.org/29020800:48
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Dont-merge: Kick function tests without patch  https://review.openstack.org/29021000:49
*** zenoway has joined #openstack-nova00:51
openstackgerritChangBo Guo(gcb) proposed openstack/nova: virt: refactor method compute_driver_matches  https://review.openstack.org/26324300:52
*** Jeffrey4l has joined #openstack-nova00:52
*** Kevin_Zheng has joined #openstack-nova00:53
oomichigmann: about https://bugs.launchpad.net/nova/+bug/155444000:53
openstackLaunchpad bug 1554440 in OpenStack Compute (nova) "Show volume attachment exception does not looks good if server is in shelved_offloaded state" [High,In progress] - Assigned to Ghanshyam Mann (ghanshyammann)00:53
gmannoomichi: hi00:54
oomichigmann: the problem has happened since v2.20, right?00:54
*** bapalm has joined #openstack-nova00:54
gmannoomichi: yea but even in previous version (v2.1) too it does not seems good as list and show behaves differently for no mountpoint00:55
oomichigmann: https://review.openstack.org/#/c/290196/ changes the API behavior of old versions also.00:55
gmannoomichi: we discussed in yesterday api meeting and patch up and get more feedback if it is ok to fix in all version or only for v2.2000:55
*** zenoway has quit IRC00:55
*** harlowja has quit IRC00:55
gmannoomichi: yea it change but it is 404 -> 20000:55
gmannoomichi: because list API is 200 if no mountoint00:56
oomichigmann: that is gray area00:56
gmannand Show is 40400:56
*** ankita_wagh has quit IRC00:56
oomichigmann: v2 comp API is very inconsistent as you said. and that is a reason why we need microversions00:57
oomichifor fixing them00:57
*** gongysh_ has quit IRC00:57
gmannoomichi: in that patch am changing v2 also so that no issue with v2 comp API00:57
gmannoomichi: but yea we do microversion in those cases but this case seems just bug fix without version for me00:58
gmannbut yea need more feedback00:58
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-nova01:01
*** mtanino has quit IRC01:02
*** vilobhmm11 has quit IRC01:02
*** vilobhmm11 has joined #openstack-nova01:03
*** phuongnh has joined #openstack-nova01:03
*** vilobhmm11 has quit IRC01:04
*** jwcroppe has quit IRC01:04
*** vilobhmm11 has joined #openstack-nova01:04
*** sdague has joined #openstack-nova01:06
*** browne has joined #openstack-nova01:08
*** gcb has joined #openstack-nova01:10
*** apoorvad has joined #openstack-nova01:10
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability  https://review.openstack.org/27247101:12
*** ZZelle_ has quit IRC01:16
*** tbachman has quit IRC01:16
*** ducttape_ has joined #openstack-nova01:24
*** zz_dimtruck is now known as dimtruck01:25
*** tbachman has joined #openstack-nova01:31
*** haomaiwang has quit IRC01:32
*** daemontool has joined #openstack-nova01:37
*** sdague has quit IRC01:38
*** gongysh has joined #openstack-nova01:44
*** sdague has joined #openstack-nova01:46
*** gongysh_ has joined #openstack-nova01:46
*** gongysh_ has quit IRC01:50
*** ducttape_ has quit IRC01:52
*** zenoway has joined #openstack-nova01:53
*** mtanino has joined #openstack-nova01:53
*** mdrabe has joined #openstack-nova01:56
*** ducttape_ has joined #openstack-nova01:57
*** salv-orlando has joined #openstack-nova01:57
*** zenoway has quit IRC01:58
*** vilobhmm11 has quit IRC01:59
mriedemmikal: are my eyes going crazy? https://review.openstack.org/#/c/284025/5/nova/tests/unit/virt/ironic/test_driver.py02:03
*** vilobhmm11 has joined #openstack-nova02:03
*** vilobhmm11 has quit IRC02:03
*** vilobhmm11 has joined #openstack-nova02:03
*** salv-orlando has quit IRC02:04
*** gongysh_ has joined #openstack-nova02:04
*** sdague has quit IRC02:05
*** baoli has joined #openstack-nova02:06
openstackgerritEli Qiao proposed openstack/nova: API: Raise up HTTPNotFound when no availabe while get_console_output  https://review.openstack.org/27069502:07
*** allen_gao has quit IRC02:08
eliqiaoalex_xu: hi, can you help to take a look at https://review.openstack.org/#/c/285931/ , I replied in line.02:08
alex_xueliqiao: sure, will try to reach that asap02:09
*** ivase has joined #openstack-nova02:12
*** Allen_Gao has joined #openstack-nova02:13
*** mingyu has joined #openstack-nova02:14
*** pushkaru has quit IRC02:14
*** ducttape_ has quit IRC02:15
*** ivase has quit IRC02:16
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding  https://review.openstack.org/21756702:17
*** doug-fish has quit IRC02:19
*** doug-fish has joined #openstack-nova02:19
*** haomaiwang has joined #openstack-nova02:20
*** Allen_Gao has quit IRC02:21
*** Allen_Gao has joined #openstack-nova02:22
openstackgerritRong Han proposed openstack/nova: libvirt: Fix the content of "disk.config" lost after migrate/resize  https://review.openstack.org/28833402:22
*** vilobhmm11 has quit IRC02:22
*** doug-fis_ has joined #openstack-nova02:23
*** Allen_Gao has quit IRC02:23
*** doug-fish has quit IRC02:24
*** haomaiwang has quit IRC02:24
*** haomaiwa_ has joined #openstack-nova02:25
mriedemalaski: i'm +0'ing in your honor https://review.openstack.org/#/c/289967/2/nova/tests/unit/db/test_db_api.py02:26
*** haomaiwa_ has quit IRC02:26
*** haomaiwa_ has joined #openstack-nova02:26
*** haomaiwa_ has quit IRC02:27
mriedemnevermind, -1 :)02:27
*** 20WAAIE7U has joined #openstack-nova02:27
*** doug-fis_ has quit IRC02:27
*** 20WAAIE7U has quit IRC02:28
*** haomaiwa_ has joined #openstack-nova02:28
*** haomaiwa_ has quit IRC02:29
*** doug-fish has joined #openstack-nova02:29
*** zenoway has joined #openstack-nova02:29
*** haomaiwang has joined #openstack-nova02:29
*** haomaiwang has quit IRC02:30
*** haomaiwang has joined #openstack-nova02:30
openstackgerritMatt Riedemann proposed openstack/nova: WIP: Fix NoMoreNetworks functional test traces  https://review.openstack.org/29024002:30
*** liusheng has quit IRC02:30
*** gjayavel_ has joined #openstack-nova02:30
*** haomaiwang has quit IRC02:31
*** haomaiwang has joined #openstack-nova02:31
*** john51 has quit IRC02:31
*** haomaiwang has quit IRC02:32
*** liusheng has joined #openstack-nova02:32
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981302:32
*** haomaiwang has joined #openstack-nova02:32
*** baoli has quit IRC02:32
*** haomaiwang has quit IRC02:33
*** john51 has joined #openstack-nova02:33
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981302:33
*** haomaiwang has joined #openstack-nova02:33
*** zenoway has quit IRC02:33
*** haomaiwang has quit IRC02:34
*** gjayavelu has quit IRC02:34
*** baoli has joined #openstack-nova02:34
*** doug-fish has quit IRC02:35
*** armax has joined #openstack-nova02:35
*** mdrabe has quit IRC02:36
*** nic has quit IRC02:37
*** doug-fish has joined #openstack-nova02:40
*** haukebruno has joined #openstack-nova02:44
*** doug-fish has quit IRC02:45
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability  https://review.openstack.org/27247102:45
*** doug-fish has joined #openstack-nova02:50
*** gcb has quit IRC02:52
*** yamahata has quit IRC02:53
*** jwcroppe has joined #openstack-nova02:53
*** mriedem has quit IRC02:54
*** Allen_Gao has joined #openstack-nova02:54
*** vilobhmm11 has joined #openstack-nova02:55
*** Allen_Gao has quit IRC02:55
*** doug-fish has quit IRC02:55
*** Allen_Gao has joined #openstack-nova02:56
*** vilobhmm111 has joined #openstack-nova02:57
*** vilobhmm11 has quit IRC03:00
openstackgerritRong Han proposed openstack/nova: Modify instance_group_member record is not deleted when instance is deleted  https://review.openstack.org/28939203:01
*** yonglihe has quit IRC03:02
*** gyee has quit IRC03:02
*** zenoway has joined #openstack-nova03:04
*** thorst_ has quit IRC03:05
*** thorst_ has joined #openstack-nova03:06
*** Marga__ has joined #openstack-nova03:06
*** Allen_Gao has quit IRC03:07
*** allen_gao has joined #openstack-nova03:08
*** zenoway has quit IRC03:09
*** Marga_ has quit IRC03:10
*** allen_gao has quit IRC03:12
*** allen_gao has joined #openstack-nova03:12
*** gcb has joined #openstack-nova03:13
*** thorst_ has quit IRC03:14
*** haomaiwang has joined #openstack-nova03:14
openstackgerritLi Yingjun proposed openstack/nova: Make versioned notifications topic configurable  https://review.openstack.org/29025403:15
*** Marga__ has quit IRC03:20
*** Marga_ has joined #openstack-nova03:20
*** ankita_wagh has joined #openstack-nova03:25
*** dims has quit IRC03:25
*** ducttape_ has joined #openstack-nova03:25
*** mingyu has quit IRC03:27
*** apoorvad has quit IRC03:27
*** dimtruck is now known as zz_dimtruck03:29
*** zz_dimtruck is now known as dimtruck03:29
*** markvoelker has joined #openstack-nova03:30
*** salv-orlando has joined #openstack-nova03:32
eliqiaoYingxin: https://bugs.launchpad.net/nova/+bug/151744203:34
openstackLaunchpad bug 1517442 in OpenStack Compute (nova) "libvirt/xenapi: disk_available_least reported by the driver does not take into account instances being migrated to/from the host" [High,Confirmed] - Assigned to Wenzhi Yu (yuywz)03:34
*** salv-orlando has quit IRC03:35
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding  https://review.openstack.org/21756703:36
*** gongysh has quit IRC03:36
*** mingyu has joined #openstack-nova03:38
*** dimtruck is now known as zz_dimtruck03:39
*** zenoway has joined #openstack-nova03:40
*** haomaiwang has quit IRC03:40
*** haomaiw__ has joined #openstack-nova03:40
*** allen_gao has quit IRC03:42
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for driver attach_interfaces capability  https://review.openstack.org/27247103:44
*** zenoway has quit IRC03:44
*** zhangkepi has joined #openstack-nova03:45
*** yamahata has joined #openstack-nova03:47
zhangkepihello03:48
zhangkepianybody online03:48
zhangkepihello03:50
*** mingyu has quit IRC03:50
*** vilobhmm111 has quit IRC03:51
*** jwcroppe has quit IRC03:51
* eliqiao is lurking03:52
*** allen_gao has joined #openstack-nova03:53
*** jamielennox is now known as jamielennox|away03:54
*** ducttape_ has quit IRC03:55
openstackgerritShaoHe Feng proposed openstack/nova-specs: Attach/detach SR-IOV interface  https://review.openstack.org/13991003:55
openstackgerritEli Qiao proposed openstack/nova: API: Raise up HTTPNotFound when no availabe while get_console_output  https://review.openstack.org/27069503:59
openstackgerritRong Han proposed openstack/nova: libvirt: Fix the content of "disk.config" lost after migrate/resize  https://review.openstack.org/28833404:02
*** links has joined #openstack-nova04:03
*** baoli has quit IRC04:04
*** ducttape_ has joined #openstack-nova04:10
*** thorst_ has joined #openstack-nova04:12
*** vilobhmm11 has joined #openstack-nova04:12
*** thorst_ has quit IRC04:19
*** sayalilunkad has quit IRC04:22
*** armax has quit IRC04:23
*** Marga_ has quit IRC04:23
*** mingyu has joined #openstack-nova04:28
*** zz_dimtruck is now known as dimtruck04:33
*** sayalilunkad has joined #openstack-nova04:34
*** Marga_ has joined #openstack-nova04:35
*** baoli has joined #openstack-nova04:37
*** yamahata has quit IRC04:37
*** yamahata has joined #openstack-nova04:38
*** ducttape_ has quit IRC04:40
*** Marga_ has quit IRC04:40
*** allen_gao has quit IRC04:42
*** baoli has quit IRC04:43
*** sridharg has joined #openstack-nova04:45
*** fifieldt has joined #openstack-nova04:47
*** baoli has joined #openstack-nova04:47
*** sayalilunkad has quit IRC04:50
*** phuongnh has quit IRC04:51
*** sayalilunkad has joined #openstack-nova04:51
*** allen_gao has joined #openstack-nova04:51
*** Marga_ has joined #openstack-nova04:53
*** Marga_ has quit IRC04:54
*** Marga_ has joined #openstack-nova04:54
*** dimtruck is now known as zz_dimtruck04:54
*** Marga_ has quit IRC04:54
*** Marga_ has joined #openstack-nova04:54
*** Marga_ has quit IRC04:55
*** Marga_ has joined #openstack-nova04:55
*** EinstCrazy has joined #openstack-nova04:57
*** baoli has quit IRC05:00
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID  https://review.openstack.org/28770205:02
*** eliqiao has quit IRC05:04
*** eliqiao has joined #openstack-nova05:04
*** deepakcs has joined #openstack-nova05:06
*** salv-orlando has joined #openstack-nova05:07
*** salv-orlando has quit IRC05:13
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: nova quota-update shouldn't work with tenant-name  https://review.openstack.org/28404205:15
*** claudiub has quit IRC05:15
*** liusheng has quit IRC05:16
*** thorst_ has joined #openstack-nova05:17
*** liusheng has joined #openstack-nova05:18
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: nova quota-update shouldn't work with tenant-name  https://review.openstack.org/28404205:18
*** yuntongjin has joined #openstack-nova05:23
*** thorst_ has quit IRC05:23
*** EinstCrazy has quit IRC05:28
*** mingyu has quit IRC05:28
*** harlowja_at_home has joined #openstack-nova05:29
*** vilobhmm11 has quit IRC05:31
openstackgerritRong Han proposed openstack/nova: Modify instance_group_member record is not deleted when instance is deleted  https://review.openstack.org/28939205:33
*** vilobhmm11 has joined #openstack-nova05:33
*** baoli has joined #openstack-nova05:36
*** zenoway has joined #openstack-nova05:39
*** baoli has quit IRC05:40
*** gcb has quit IRC05:41
*** mingyu has joined #openstack-nova05:43
*** zenoway has quit IRC05:44
*** hoangcx has joined #openstack-nova05:45
*** yuntongjin1 has joined #openstack-nova05:46
*** fawadkhaliq has joined #openstack-nova05:47
*** yuntongjin has quit IRC05:48
*** jwcroppe has joined #openstack-nova05:52
*** hanrong has joined #openstack-nova05:52
*** nkrinner has joined #openstack-nova05:54
*** sudipto has joined #openstack-nova05:56
*** yuntongjin has joined #openstack-nova05:57
*** yuntongjin1 has quit IRC05:59
*** gcb has joined #openstack-nova05:59
*** dedery has joined #openstack-nova06:00
*** dedery has joined #openstack-nova06:01
openstackgerritjaveme proposed openstack/nova: raise exception ComputeHostNotFound if host is not found  https://review.openstack.org/24310506:02
*** zhangkepi has quit IRC06:07
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981306:07
*** ekuris_ has joined #openstack-nova06:08
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981306:08
*** liusheng has quit IRC06:08
*** rcernin has joined #openstack-nova06:09
*** liusheng has joined #openstack-nova06:09
*** gcb has quit IRC06:10
*** bnemec has quit IRC06:11
*** zenoway has joined #openstack-nova06:14
openstackgerritAlex Xu proposed openstack/nova: Report instance-actions for live migration force complete API  https://review.openstack.org/29028906:15
openstackgerritjaveme proposed openstack/nova: Missing to update task state for confirm_resize  https://review.openstack.org/24443306:17
openstackgerritjinquanni proposed openstack/nova: modify code for resize failure can rollback to exact vm_state  https://review.openstack.org/28777406:19
*** allen_gao has quit IRC06:19
*** hanrong has quit IRC06:19
*** zenoway has quit IRC06:19
*** thorst_ has joined #openstack-nova06:21
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/28884506:21
openstackgerritjaveme proposed openstack/nova: Remove sizelimit.py in favor of oslo_middleware.sizelimit  https://review.openstack.org/28218106:22
*** mingyu has quit IRC06:24
*** amotoki has joined #openstack-nova06:25
*** thorst_ has quit IRC06:28
*** esracelik has joined #openstack-nova06:29
openstackgerritAlex Xu proposed openstack/nova: modify code for resize failure can rollback to exact vm_state  https://review.openstack.org/28777406:29
*** allen_gao has joined #openstack-nova06:30
*** salv-orlando has joined #openstack-nova06:31
*** shaohe_feng has quit IRC06:32
*** mingyu has joined #openstack-nova06:34
openstackgerritjaveme proposed openstack/nova: VMware: Refactor the formatting instance metadata  https://review.openstack.org/26899406:35
*** salv-orlando has quit IRC06:36
*** mingyu has quit IRC06:36
*** PaulMurray has joined #openstack-nova06:38
openstackgerritYingxin Cheng proposed openstack/nova: split host_state.least_disk_mb out of free_disk_mb  https://review.openstack.org/29030206:40
openstackgerritjaveme proposed openstack/nova: VMware: Prefer ShutdownGuest to PowerOffVM_Task  https://review.openstack.org/18163406:44
*** vishwanathj has quit IRC06:49
*** omnipresent has joined #openstack-nova06:50
*** vishwanathj has joined #openstack-nova06:51
*** mingyu has joined #openstack-nova06:52
openstackgerritPavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api  https://review.openstack.org/28996706:53
*** omnipresent has quit IRC06:55
*** dave-mccowan has quit IRC07:02
*** harlowja_at_home has quit IRC07:03
*** sudipto has quit IRC07:04
*** zenoway has joined #openstack-nova07:05
*** claudiub has joined #openstack-nova07:07
*** lpetrut has joined #openstack-nova07:09
*** vishwana_ has joined #openstack-nova07:10
*** mjura has joined #openstack-nova07:12
*** vishwanathj has quit IRC07:13
*** sudipto has joined #openstack-nova07:17
*** paul-carlton2 has joined #openstack-nova07:20
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID  https://review.openstack.org/28770207:21
*** omnipresent has joined #openstack-nova07:22
*** zenoway has quit IRC07:25
*** thorst_ has joined #openstack-nova07:26
*** mingyu has quit IRC07:27
*** nkrinner has quit IRC07:27
*** fawadkhaliq has quit IRC07:28
*** ildikov has quit IRC07:28
*** mingyu has joined #openstack-nova07:29
*** allen_gao has quit IRC07:29
*** paul-carlton2 has quit IRC07:30
*** nkrinner has joined #openstack-nova07:31
*** hanrong has joined #openstack-nova07:33
*** thorst_ has quit IRC07:33
*** zenoway has joined #openstack-nova07:34
hanrongeliqiao: hi07:34
eliqiaohanrong: hi :)07:35
*** rdopiera has joined #openstack-nova07:35
*** omnipresent has quit IRC07:35
*** d34dh0r53 has quit IRC07:36
*** cloudnull has quit IRC07:38
*** paul-carlton2 has joined #openstack-nova07:38
*** allen_gao has joined #openstack-nova07:38
*** omnipresent has joined #openstack-nova07:38
*** hanrong has quit IRC07:39
*** zenoway has quit IRC07:40
openstackgerritEli Qiao proposed openstack/nova: Query procceeding status migration in confirm/revert_resize()  https://review.openstack.org/28593107:43
*** liverpooler has joined #openstack-nova07:46
*** cfriesen_ has quit IRC07:47
*** shaohe_robot has quit IRC07:56
*** belmoreira has joined #openstack-nova07:56
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: set service status based on vc connection  https://review.openstack.org/29031507:57
*** RuiChen has quit IRC07:59
*** scheuran has joined #openstack-nova08:00
*** RuiChen has joined #openstack-nova08:01
*** RuiChen has quit IRC08:05
*** RuiChen has joined #openstack-nova08:06
*** RuiChen has quit IRC08:06
*** RuiChen has joined #openstack-nova08:07
*** RuiChen has quit IRC08:07
openstackgerritRong Han proposed openstack/nova: Soft delete instance group member when delete instance  https://review.openstack.org/28939208:07
*** RuiChen has joined #openstack-nova08:07
*** dguitarbite has joined #openstack-nova08:10
*** hanrong has joined #openstack-nova08:10
*** e0ne has joined #openstack-nova08:10
openstackgerritPawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration  https://review.openstack.org/28736308:11
*** RuiChen has quit IRC08:11
*** ankita_wagh has quit IRC08:11
*** RuiChen has joined #openstack-nova08:11
*** browne has quit IRC08:11
*** ankita_wagh has joined #openstack-nova08:12
*** paul-carlton2 has quit IRC08:12
*** mpavone has joined #openstack-nova08:13
*** mjura has quit IRC08:13
*** lpetrut has quit IRC08:14
*** moshele has joined #openstack-nova08:16
*** ankita_wagh has quit IRC08:16
*** paul-carlton2 has joined #openstack-nova08:17
*** lpetrut has joined #openstack-nova08:18
*** e0ne has quit IRC08:19
*** erno has joined #openstack-nova08:21
*** gjayavel_ has quit IRC08:22
*** rk4n has joined #openstack-nova08:22
*** matrohon has joined #openstack-nova08:23
*** jichen has joined #openstack-nova08:23
*** vilobhmm11 has quit IRC08:25
*** jlanoux has joined #openstack-nova08:27
*** mjura has joined #openstack-nova08:28
*** macsz1 has joined #openstack-nova08:28
*** macsz1 has quit IRC08:29
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981308:30
openstackgerritBin Zhou proposed openstack/nova: upgrade connection_info when Ceph mon IP changed  https://review.openstack.org/28981308:30
*** pece has joined #openstack-nova08:31
*** thorst_ has joined #openstack-nova08:31
*** josecastroleon has quit IRC08:32
*** jwcroppe has quit IRC08:32
*** macsz has joined #openstack-nova08:32
*** jwcroppe has joined #openstack-nova08:32
*** josecastroleon has joined #openstack-nova08:33
*** ndipanov has quit IRC08:35
*** rk4n has quit IRC08:36
*** yuntongjin has quit IRC08:38
*** thorst_ has quit IRC08:39
*** lpetrut has quit IRC08:39
openstackgerritPaul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary  https://review.openstack.org/28837308:42
*** daemontool_ has joined #openstack-nova08:47
bauzasgood morning nova08:47
*** openstackgerrit has quit IRC08:47
*** ihrachys has joined #openstack-nova08:48
*** openstackgerrit has joined #openstack-nova08:48
*** whenry_ has quit IRC08:49
*** mkasprzy has joined #openstack-nova08:49
*** whenry_ has joined #openstack-nova08:49
*** daemontool has quit IRC08:49
*** mgoddard has joined #openstack-nova08:51
paul-carlton2bauzas, good morning, can you take a look at https://review.openstack.org/288373 pls08:51
*** RuiChen has quit IRC08:52
paul-carlton2Paul Murray and I re worded the release note slightly, hope it meets with your approval08:52
*** doug-fish has joined #openstack-nova08:52
*** huanxie has joined #openstack-nova08:53
*** hanrong has quit IRC08:53
*** whenry_ has quit IRC08:54
*** ndipanov has joined #openstack-nova08:55
*** links has quit IRC08:55
lyarwoodjohnthetubaguy and any other cores that are online, can I ask for reviews on https://review.openstack.org/#/q/topic:bug/1548450 (OSSA 2016-007 (CVE-2016-2140))08:57
*** doug-fish has quit IRC08:57
*** yuntongjin has joined #openstack-nova08:58
*** paul-carlton2 has quit IRC08:58
*** efried has quit IRC09:00
*** macsz has quit IRC09:01
*** huanxie has quit IRC09:01
openstackgerritLee Yarwood proposed openstack/nova-specs: Virtual instance rescue with stable disk devices  https://review.openstack.org/27312209:02
*** whenry_ has joined #openstack-nova09:03
*** jaosorior has joined #openstack-nova09:06
openstackgerritPawel Koniszewski proposed openstack/nova: Use migrate_data.block_migration instead of block_migration  https://review.openstack.org/28736309:07
*** mingyu has quit IRC09:08
*** efoley has joined #openstack-nova09:08
openstackgerritjinquanni proposed openstack/nova: manager:mark a vm that resume failed  https://review.openstack.org/28974509:09
*** andreykurilin__ has joined #openstack-nova09:10
*** amotoki has quit IRC09:10
*** efoley_ has joined #openstack-nova09:10
*** shaohe_feng has joined #openstack-nova09:10
bauzaspaul-carlton1: will do, sure09:11
bauzaspaul-carlton1: maybe just a quick nit, include_disabled is maybe a too long argument name09:12
*** mingyu has joined #openstack-nova09:12
bauzasI was thinking of 'disabled' only09:12
bauzasbut I'm terrible at naming09:12
*** sridhargaddam has joined #openstack-nova09:13
*** efoley has quit IRC09:13
*** shaohe_feng has quit IRC09:13
*** bapalm has quit IRC09:14
*** shaohe_feng has joined #openstack-nova09:14
*** efried has joined #openstack-nova09:14
*** sridhargaddam has quit IRC09:15
*** sridharg has quit IRC09:15
*** sridharg has joined #openstack-nova09:15
*** lucas-dinner is now known as lucasagomes09:16
*** palexster has joined #openstack-nova09:16
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: flavor-id should be only integer or UUID  https://review.openstack.org/28770209:18
*** jistr has joined #openstack-nova09:19
*** ildikov has joined #openstack-nova09:19
johnthetubaguylyarwood: I thought we normally get the cores on the bug that approved the change to quickly re-aprove in gerrit, not sure why that hasn't happened here, I will try dig into that09:21
*** slunkad has joined #openstack-nova09:21
*** salv-orlando has joined #openstack-nova09:21
paul-carlton1bauzas, 'disabled' was my first thought but that didn't describe the meaning of the parameter correctly, suggesting that you'd only get disabled hosts if you set it to True!09:23
*** yamahata has quit IRC09:23
*** d34dh0r53 has joined #openstack-nova09:23
bauzaspaul-carlton1: well, you're right09:23
openstackgerritAbhishek Talwar proposed openstack/python-novaclient: nova add-secgroup help updated with secgroup id  https://review.openstack.org/29034509:23
*** roeyc has joined #openstack-nova09:23
*** palexster has quit IRC09:24
bauzaspaul-carlton1: but I'm also leaving a comment asking to amend the docstring of nova.db.api :)09:24
*** paul-carlton2 has joined #openstack-nova09:24
*** shaohe_feng has quit IRC09:24
*** palexster has joined #openstack-nova09:24
*** shaohe_feng has joined #openstack-nova09:24
markus_zBobBall: I have a XenProject CI build error due to low memory, not sure if this is interesting for you09:25
*** amotoki has joined #openstack-nova09:25
markus_zBobBall: JFYI, http://logs.openstack.xenproject.org/01/275801/8/check/dsvm-tempest-xen/e51b77d/logs/libvirt/libxl/libxl-driver.txt.gz09:26
*** cloudnull has joined #openstack-nova09:27
*** liusheng has quit IRC09:27
*** yassine has joined #openstack-nova09:27
*** bapalm has joined #openstack-nova09:27
paul-carlton1good catch, not seeing your comments in gerrit yet, guess you are still reviewing?09:28
*** salv-orlando has quit IRC09:29
johnthetubaguylyarwood: got a slight concern on the master patch, adding a comment.09:29
markus_zBobBall: And I can't access the zuul UI at http://zuul.openstack.xenproject.org/09:29
*** yuntongjin has quit IRC09:30
*** gszasz has joined #openstack-nova09:31
markus_zBobBall: The Xen-CI didn't respond with a voting for this recheck: https://review.openstack.org/#/c/236051/7 That's why I wanted to look in zuul.09:31
*** Jeffrey4l has quit IRC09:31
markus_zBobBall: only bad news from me, sorry09:31
*** gongysh has joined #openstack-nova09:33
*** hoangcx has quit IRC09:33
*** amotoki has quit IRC09:34
*** shaohe_feng has quit IRC09:34
*** slunkad has quit IRC09:34
*** sayalilunkad_lap has joined #openstack-nova09:35
*** shaohe_feng has joined #openstack-nova09:35
*** thorst_ has joined #openstack-nova09:36
*** sridharg has quit IRC09:39
*** sridharg has joined #openstack-nova09:40
*** amotoki has joined #openstack-nova09:43
*** thorst_ has quit IRC09:44
*** shaohe_feng has quit IRC09:44
*** huanxie has joined #openstack-nova09:45
*** shaohe_feng has joined #openstack-nova09:45
*** derekh has joined #openstack-nova09:46
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class  https://review.openstack.org/29035909:47
* johnthetubaguy has bad headache this morning, moving away from compute to try and help it09:48
*** amotoki has quit IRC09:51
*** e0ne has joined #openstack-nova09:51
*** shaohe_feng has quit IRC09:54
*** amotoki has joined #openstack-nova09:55
*** shaohe_feng has joined #openstack-nova09:55
*** amotoki has quit IRC09:56
*** sfinucan has joined #openstack-nova09:57
*** danpb has joined #openstack-nova09:58
*** e0ne has quit IRC10:01
*** claudiub|2 has joined #openstack-nova10:03
*** e0ne has joined #openstack-nova10:04
*** shaohe_feng has quit IRC10:05
*** shaohe_feng has joined #openstack-nova10:06
*** claudiub has quit IRC10:06
*** amotoki has joined #openstack-nova10:06
*** gongysh has quit IRC10:06
gmannjohnthetubaguy: alex_xu have look this one for attachment API consistency -  https://review.openstack.org/#/c/290196/110:07
gmannas discussed in meeting10:08
*** lpetrut has joined #openstack-nova10:08
*** rk4n has joined #openstack-nova10:11
*** lpetrut has quit IRC10:13
lyarwoodjohnthetubaguy: sorry was on the train, looking now10:15
*** shaohe_feng has quit IRC10:15
*** shaohe_feng has joined #openstack-nova10:15
lyarwoodjohnthetubaguy: added a comment, thankfully disk.info only applies to imagebackend disks. brb.10:17
*** daemontool_ is now known as daemontool10:19
openstackgerritGleb Stepanov proposed openstack/nova: Improve line continuation  https://review.openstack.org/29037810:20
*** lpetrut has joined #openstack-nova10:20
*** mvk has joined #openstack-nova10:21
*** shaohe_feng has quit IRC10:25
*** shaohe_feng has joined #openstack-nova10:26
openstackgerritMoshe Levi proposed openstack/nova: ironic driver: Adding InfiniBand support  https://review.openstack.org/26654010:28
*** efried has quit IRC10:29
*** claudiub|2 has quit IRC10:32
*** ekuris_ has quit IRC10:33
*** gongysh_ has quit IRC10:34
openstackgerritMatthew Booth proposed openstack/nova: Don't convert raw disks to qcow2 during resize/migrate  https://review.openstack.org/28370210:34
*** rk4n has quit IRC10:34
*** shaohe_feng has quit IRC10:35
*** shaohe_feng has joined #openstack-nova10:36
*** mgoddard has quit IRC10:37
*** rk4n has joined #openstack-nova10:37
bauzasmarkus_z: are you planning to monitor every day new bugs coming in the pipe ?10:38
bauzasmarkus_z: I'm beginning to care of regressions noted by ops10:38
bauzasand those could possibly miss the RC tag10:38
*** rk4n has quit IRC10:40
*** rk4n has joined #openstack-nova10:40
*** mingyu has quit IRC10:41
*** roeyc has quit IRC10:41
lyarwoodmdbooth: can you take a look at https://review.openstack.org/#/c/281913/ if you have time this morning10:41
mdboothlyarwood: For you, sir, I will look immediately10:41
*** thorst_ has joined #openstack-nova10:42
*** efried has joined #openstack-nova10:42
lyarwoodmdbooth: tip of the hat to you sir10:43
mdboothIndubitably10:43
*** haomaiw__ has quit IRC10:45
bauzaspkoniszewski: just a comment as I'm reviewing https://bugs.launchpad.net/nova/+bug/1552303, please make sure to provide permalinks (using existing SHAs) when giving an URL like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L555410:45
openstackLaunchpad bug 1552303 in OpenStack Compute (nova) "Block live migrations are broken when nova calculates live migration type by itself" [Critical,In progress] - Assigned to Pawel Koniszewski (pawel-koniszewski)10:45
*** shaohe_feng has quit IRC10:46
*** shaohe_feng has joined #openstack-nova10:46
markus_zbauzas: That's what I want to establish with the bug skimming duty but getting volunteers is cumbersome10:47
*** thorst_ has quit IRC10:49
openstackgerritGleb Stepanov proposed openstack/nova: Remove unused variable and redundant code path  https://review.openstack.org/29038910:49
*** salv-orlando has joined #openstack-nova10:51
*** RuiChen has joined #openstack-nova10:53
*** cdent has joined #openstack-nova10:54
cdentp!spy10:55
cdentp!hist10:55
*** salv-orlando has quit IRC10:56
*** shaohe_feng has quit IRC10:56
openstackgerritPaul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary  https://review.openstack.org/28837310:56
*** shaohe_feng has joined #openstack-nova10:57
*** mgoddard has joined #openstack-nova10:59
*** purplerbot has quit IRC11:00
*** purplerbot has joined #openstack-nova11:00
*** CustosLimen has quit IRC11:03
*** dedery_ has joined #openstack-nova11:04
*** dedery has quit IRC11:05
*** efoley_ has quit IRC11:06
*** sdague has joined #openstack-nova11:06
*** shaohe_feng has quit IRC11:06
*** dims has joined #openstack-nova11:07
*** shaohe_feng has joined #openstack-nova11:07
openstackgerritGleb Stepanov proposed openstack/nova: Line indentation improvements  https://review.openstack.org/29039511:07
*** ildikov has quit IRC11:08
*** CustosLimen has joined #openstack-nova11:08
*** dedery_ has quit IRC11:08
*** huanxie has quit IRC11:09
openstackgerritStephen Finucane proposed openstack/nova: Address nits in I83a5f06ad  https://review.openstack.org/28934211:12
*** shaohe_feng has quit IRC11:16
*** doug-fish has joined #openstack-nova11:17
*** shaohe_feng has joined #openstack-nova11:17
*** danpb has quit IRC11:18
*** takedakn has joined #openstack-nova11:19
*** danpb has joined #openstack-nova11:19
*** efoley_ has joined #openstack-nova11:21
*** doug-fish has quit IRC11:22
*** PaulMurray has joined #openstack-nova11:22
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class  https://review.openstack.org/29035911:24
*** Daisy has joined #openstack-nova11:25
openstackgerritStephen Finucane proposed openstack/nova: plugins/xenserver: Resolve PEP8 issues  https://review.openstack.org/28949011:25
openstackgerritStephen Finucane proposed openstack/nova: plugins/xenserver: Add '.py' extension  https://review.openstack.org/28943111:25
openstackgerritGleb Stepanov proposed openstack/nova: Redundant parentheses removed  https://review.openstack.org/29041011:25
*** shaohe_feng has quit IRC11:27
*** shaohe_feng has joined #openstack-nova11:29
*** Daisy has quit IRC11:29
*** Daisy has joined #openstack-nova11:30
openstackgerritStephen Finucane proposed openstack/nova: Rework 'limited' and 'get_limit_and_marker'  https://review.openstack.org/24136111:31
*** sahid has joined #openstack-nova11:31
*** kmartin has quit IRC11:33
*** Daisy has quit IRC11:34
*** Daisy has joined #openstack-nova11:34
*** ociuhandu has quit IRC11:35
*** roeyc has joined #openstack-nova11:37
*** shaohe_feng has quit IRC11:37
*** shaohe_feng has joined #openstack-nova11:38
*** omnipresent has quit IRC11:39
*** dedery has joined #openstack-nova11:39
*** zenoway has joined #openstack-nova11:40
*** Daisy has quit IRC11:41
*** Daisy has joined #openstack-nova11:41
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWare> Attach/detach more than one SCSI LUN  https://review.openstack.org/28705511:43
*** zenoway has quit IRC11:44
*** dedery has quit IRC11:44
mdboothlyarwood: Eesh, that libvirt driver cleanup code is horrendously fragile11:44
mdboothIt's a nat's whisker away from deleting disks which are in use11:45
mdboothUnfortunately, I think your patch might just push it over11:45
*** delatte has quit IRC11:45
*** Daisy has quit IRC11:46
*** thorst_ has joined #openstack-nova11:47
*** shaohe_feng has quit IRC11:47
openstackgerritChris Dent proposed openstack/nova: Remove an unused method in FakeResourceTracker  https://review.openstack.org/29007611:48
*** shaohe_feng has joined #openstack-nova11:48
*** links has joined #openstack-nova11:48
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller.  https://review.openstack.org/27241411:49
lyarwoodmdbooth: hmmm, care to comment on the change and I'll follow up after lunch?11:50
*** mpavone has quit IRC11:50
*** mpavone has joined #openstack-nova11:51
mdboothlyarwood: Reviewed11:51
pkoniszewskibauzas: sure, thanks, will use that next time11:51
lyarwoodmdbooth: thanks11:52
*** zenoway has joined #openstack-nova11:52
*** takedakn has quit IRC11:53
*** takedakn has joined #openstack-nova11:53
*** thorst_ has quit IRC11:53
*** efoley__ has joined #openstack-nova11:53
*** efried has quit IRC11:54
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWARE> Add power state cache in compute manager  https://review.openstack.org/24200611:55
*** RuiChen has quit IRC11:57
*** efried has joined #openstack-nova11:57
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller  https://review.openstack.org/27241411:57
*** RuiChen has joined #openstack-nova11:57
*** efoley_ has quit IRC11:57
*** shaohe_feng has quit IRC11:57
*** shaohe_feng has joined #openstack-nova11:59
*** jaosorior has quit IRC12:02
*** jaosorior has joined #openstack-nova12:02
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Wrap interface_list by proper resource class  https://review.openstack.org/29035912:03
*** smatzek has joined #openstack-nova12:04
*** ildikov has joined #openstack-nova12:04
*** rfolco has joined #openstack-nova12:04
openstackgerritPavlo Shchelokovskyy proposed openstack/nova: Fix config generation for Neutron auth options  https://review.openstack.org/28851312:05
cdentwhy are deprecation warnings being spewed in the gate by the python34 tests but not python27?12:06
*** salv-orlando has joined #openstack-nova12:06
*** aysyd has joined #openstack-nova12:06
*** moshele has quit IRC12:07
*** shaohe_feng has quit IRC12:08
*** shaohe_feng has joined #openstack-nova12:09
*** dedery has joined #openstack-nova12:10
*** ekuris_ has joined #openstack-nova12:10
*** amotoki has quit IRC12:10
sdaguecdent: example?12:10
openstackgerritSean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods  https://review.openstack.org/29013412:10
mdboothlyarwood: If you'd care to return the favour: https://review.openstack.org/#/c/283702/ :)12:12
*** atuvenie_ has joined #openstack-nova12:15
*** atuvenie has joined #openstack-nova12:15
*** EinstCrazy has joined #openstack-nova12:15
*** atuvenie has quit IRC12:15
*** claudiub has joined #openstack-nova12:16
openstackgerritPavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api  https://review.openstack.org/28996712:17
cdentsdague: https://jenkins03.openstack.org/job/gate-nova-python34/5099/console12:17
*** shaohe_feng has quit IRC12:18
cdentsdague: I don't thinik that pkg_resource problem is showing up in 2.7 either12:18
*** shaohe_feng has joined #openstack-nova12:19
cdentbauzas, johnthetubaguy: I think I found a reasonable way to test https://review.openstack.org/#/c/289544/ so that's good to go now.12:20
*** mvk has quit IRC12:20
*** ociuhandu has joined #openstack-nova12:20
*** lucasagomes is now known as lucas-hungry12:21
*** baoli has joined #openstack-nova12:22
*** daemontool_ has joined #openstack-nova12:23
*** amotoki has joined #openstack-nova12:24
*** nelsnels_ has joined #openstack-nova12:24
*** omnipresent has joined #openstack-nova12:24
*** diana_clarke2 has joined #openstack-nova12:24
*** Marga__ has joined #openstack-nova12:24
openstackgerritChris Dent proposed openstack/nova: Insure resource tracker updated for deleted instances  https://review.openstack.org/28954412:25
*** Kevin_Zheng_ has joined #openstack-nova12:25
*** irenab_ has joined #openstack-nova12:25
*** MCoLo__ has joined #openstack-nova12:26
*** irenab has quit IRC12:26
*** irenab_ is now known as irenab12:26
*** lpetrut1 has joined #openstack-nova12:26
*** baoli has quit IRC12:26
*** Kevin_Zheng has quit IRC12:27
*** Kevin_Zheng_ is now known as Kevin_Zheng12:27
*** diana_clarke1 has quit IRC12:27
*** lpetrut has quit IRC12:27
*** greghaynes has quit IRC12:27
*** zenoway has quit IRC12:27
*** dguitarbite has quit IRC12:27
*** nkrinner has quit IRC12:27
*** Marga_ has quit IRC12:27
*** nelsnelson has quit IRC12:27
*** pkholkin_ has quit IRC12:27
*** MCoLo___ has quit IRC12:27
*** lpetrut1 is now known as lpetrut12:27
*** pkholkin__ has joined #openstack-nova12:27
*** jaosorior has quit IRC12:27
*** bapalm has quit IRC12:27
*** daemontool has quit IRC12:27
*** alaski has quit IRC12:27
*** jaosorior has joined #openstack-nova12:27
*** takedakn has quit IRC12:27
*** bapalm has joined #openstack-nova12:27
*** shaohe_feng has quit IRC12:28
sdaguecdent: no, it's in the py27 stuff as well12:28
*** shaohe_feng has joined #openstack-nova12:29
cdentsdague: that's what I get for trying to do 20 things at once12:29
*** mjura has quit IRC12:29
sdagueit's been there forever12:29
*** daemontool_ is now known as daemontool12:29
sdagueI think it's a deep pbr thing12:29
*** amotoki has quit IRC12:29
*** doug-fish has joined #openstack-nova12:31
*** alaski has joined #openstack-nova12:31
*** Daisy has joined #openstack-nova12:31
*** cdelatte has joined #openstack-nova12:32
cdentoh pbr, that thing which does lots of magic that we can't see?12:32
* cdent grinds teeth and axe12:32
* cdent relaxes12:33
cdentI read a headline earlier today that said that venting doesn't make anything better, in fact often makes it worse.12:33
cdentProbably should have read the article.12:33
sdagueheh12:36
openstackgerritjichenjc proposed openstack/python-novaclient: Prepare to move extension into core plugin  https://review.openstack.org/29044812:36
sdagueor burn it12:36
*** rodrigods has quit IRC12:37
*** rodrigods has joined #openstack-nova12:37
sdaguecdent: also, why the heck is that osapifixture taking 16 minutes?12:38
*** Jeffrey4l has joined #openstack-nova12:38
*** shaohe_feng has quit IRC12:38
*** Daisy has quit IRC12:39
cdentsdague: you talking about on py34 or both? I've noticed the py34 job is taking a good deal more time.12:39
*** Daisy has joined #openstack-nova12:39
*** shaohe_feng has joined #openstack-nova12:39
*** thorst_ has joined #openstack-nova12:39
sdagueon py2712:39
sdaguesorry12:39
sdaguepy3412:39
sdaguemuscle memory12:40
sdaguethat test run12:40
sdagueI noticed the slow test list at the end12:40
*** nkrinner has joined #openstack-nova12:40
sdagueoh, so I blamed pbr incorrectly12:40
sdagueit's oslo.versionutils12:40
*** greghaynes has joined #openstack-nova12:40
*** Daisy has quit IRC12:41
*** Daisy has joined #openstack-nova12:41
*** dguitarbite has joined #openstack-nova12:41
sdagueor, maybe it's both, pkg_resource defines it's warnings so badly it's hard to figure out12:42
*** mjura has joined #openstack-nova12:44
cdentedleafe: Is the bug still live? https://bugs.launchpad.net/nova/+bug/1369818  It looks like the latest patch on it was from you and it merged but things are still up in the air. What's still missing?12:44
openstackLaunchpad bug 1369818 in OpenStack Compute (nova) "Nova show will not display NoValidHost with right exception traces" [Medium,Confirmed]12:44
*** baoli has joined #openstack-nova12:46
*** Daisy has quit IRC12:47
*** Daisy has joined #openstack-nova12:48
*** doug-fish has quit IRC12:48
*** shaohe_feng has quit IRC12:49
*** shaohe_feng has joined #openstack-nova12:49
*** thumpba has joined #openstack-nova12:50
*** deepakcs has quit IRC12:51
*** mvk has joined #openstack-nova12:51
*** Daisy has quit IRC12:53
openstackgerritGleb Stepanov proposed openstack/nova: Improve line continuation  https://review.openstack.org/29037812:53
*** baoli_ has joined #openstack-nova12:53
*** ekuris_ has quit IRC12:54
lyarwoodmdbooth: yup, I'll take a look now12:56
*** baoli has quit IRC12:56
jaypipes*yawns*12:57
jaypipesmorooning folks12:57
ndipanovsdague, wanna enlighten me on "all kinds of things" we're talking about here? https://review.openstack.org/#/c/289477/12:59
*** shaohe_feng has quit IRC12:59
sdaguendipanov: tox -e docs12:59
ndipanovsdague, yeah that's one13:00
sdaguetox -r -e docs13:00
*** shaohe_feng has joined #openstack-nova13:00
sdagueand, the point is, the docs tree is stack13:00
sdaguethat's the actual point of the samples framework, there are templates that are dynamic, which are cross checked with static files that publish to the documentation13:00
ndipanovsdague, sure but this is a super straightforward substitution that is surely a net win13:01
sdagueif it's a huge burden that this value keeps incrementing on the documentation, perhaps it shouldn't be in the payload then.13:02
ndipanovsdague, well desinging payloads around documentation is not something we wanna do I think13:02
*** krtaylor has quit IRC13:02
ndipanovI don't know13:02
ndipanovbut seems silly to have to do this by hand every time...13:03
sdaguendipanov: we usually want to design payloads around documentation, because the point of them is they are consumed by humans, via docs13:03
johnthetubaguyso the service version is interesting during an upgrade, notification wise13:04
ndipanovjohnthetubaguy, it's generally useful I guess, and ultimately I don't think it's a massive burden for now to flip it13:04
johnthetubaguyis there a different way here, like mocking the service version in that test?13:05
ndipanovalthough rebases can get annoying during certain times of year13:05
*** dims has quit IRC13:05
*** dims_ has joined #openstack-nova13:05
ndipanovjohnthetubaguy, that could work maybe...13:05
sdaguejohnthetubaguy: you could not do the samples model13:05
sdaguethe issue here is that this is the samples model which is there is dynamic / template / and the published documentation (static)13:06
sdagueand you cross check all 3 so that you know you have valid code, and valid docs you are giving to the user13:06
ndipanovsdague, so how do we break that if we generate docs from code?13:06
*** atuvenie_ has quit IRC13:07
ndipanovit seems like the doc here is used to test the code which is backwards I think13:07
ndipanovanyway I don't think it's worth arguing about13:07
sdaguendipanov: if you come up with another path to provide docs to the end user, that's cool. But using this model you kind of want that safety check13:08
sdagueotherwise you can basically overmock yourself and not be testing anything13:08
*** markvoelker_ has joined #openstack-nova13:08
*** shaohe_feng has quit IRC13:09
*** shaohe_feng has joined #openstack-nova13:10
ndipanovsdague, so how come it didn't fail on the original patch?13:10
*** edmondsw has joined #openstack-nova13:10
*** dims_ has quit IRC13:10
sdaguendipanov: I don't know, I didn't do the full postmortem.13:10
sdaguebut the root cause was pretty clear from the bug at hand13:11
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWare> Attach/detach more than one SCSI LUN  https://review.openstack.org/28705513:11
*** markvoelker has quit IRC13:11
ndipanovsdague, so we would want to run the same code that generates temporary samples for docs and for func tests from common templates I think - would that make sense to you sdague ?13:12
*** ducttape_ has joined #openstack-nova13:12
sdaguendipanov: we specifically talked that through in Bristol and said no, lets build this as parallel, because of the complexity in differences here.13:13
*** dims has joined #openstack-nova13:14
*** jaosorior has quit IRC13:15
*** jaosorior has joined #openstack-nova13:15
sdaguelike I said, if you want a different model here not using the docs/ tree that's cool. But stuff in docs/ really needs to be static.13:16
ndipanovsdague, ok - I don't think it's a huge overhead for now so let's leave it at that13:17
*** shaohe_feng has quit IRC13:19
*** shaohe_feng has joined #openstack-nova13:20
*** markvoelker_ has quit IRC13:20
openstackgerritStephen Finucane proposed openstack/nova: Address nits in I83a5f06ad  https://review.openstack.org/28934213:21
*** efried has quit IRC13:22
*** dave-mccowan has joined #openstack-nova13:22
*** ducttape_ has quit IRC13:27
*** scheuran has quit IRC13:28
*** lucas-hungry is now known as lucasagomes13:28
openstackgerritNikola Dipanov proposed openstack/nova: trivial: remove unused argument from a method  https://review.openstack.org/28674313:29
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: Refactor _update_xml  https://review.openstack.org/28674213:29
openstackgerritNikola Dipanov proposed openstack/nova: live-mig: Add claims and proper resource tracking  https://review.openstack.org/24448913:29
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: live-migrate updates NUMA and cpus in the XML  https://review.openstack.org/28674413:29
*** doug-fish has joined #openstack-nova13:29
*** shaohe_feng has quit IRC13:30
*** shaohe_feng has joined #openstack-nova13:31
*** doug-fish has quit IRC13:31
*** doug-fish has joined #openstack-nova13:32
ndipanovjohnthetubaguy, https://review.openstack.org/#/c/281803/ is it too late for this?13:32
ndipanovI would assume no...13:32
cdentsorry ndipanov totally disagree with you on the bug thing, so left another coment on https://bugs.launchpad.net/nova/+bug/142777213:32
openstackLaunchpad bug 1427772 in OpenStack Compute (nova) "Instance that uses force-host still needs to run some filters" [Low,Confirmed] - Assigned to Anant Kaushik (anantkaushik-nsit)13:32
johnthetubaguyndipanov: reno stuff is cool, I think bauzas is tracking a bunch of them that got missed one way or the other13:33
bauzasyeah I'm on it13:33
johnthetubaguyndipanov: frankly I want to block the tag on getting all release notes in13:33
bauzascurrently doing reviews but also checking some notes we missed13:34
ndipanovbauzas, ok that one we missed as well13:34
johnthetubaguybauzas: ack, appreciate you digging into those13:34
bauzasndipanov: I +1d the above because I thought of a prelude section, but lemme +W it13:35
ndipanovcdent, well I agree with the sentiment - but this is not an opinion that does not have replication strategy - it's known to be broken13:35
*** links has quit IRC13:35
*** efried has joined #openstack-nova13:36
cdentbut the bug isn't really a bug. if someone wants to make it into a bug, then fine it can live and then people can do something with it. but right now it's just noise13:36
ndipanovthis shouldn't discourage you - I mean - it's down to what we want to use the bugtracker for13:36
ndipanovif we want it as a gamified get s*it done list - then yeah this is a backlog spec13:37
ndipanovor something13:37
ndipanovno it is totally a bug13:37
ndipanovit breaks all sorts of things13:37
cdentI don't dispute that it breaks all sorts of things.13:38
cdentI guess I just really take issue with things living so long in the tracker13:38
ndipanovcdent, I don't think there's a clear rule - it's up to us what we do with the bug tracker13:38
*** rtheis has joined #openstack-nova13:39
*** markvoelker has joined #openstack-nova13:39
ndipanovso if you don't want this to live on as a bug - close it. There's an email thread so ppl can dig through the archives... there;s definitely artifacts to be found13:39
*** shaohe_feng has quit IRC13:40
*** shaohe_feng has joined #openstack-nova13:41
sdagueI cleaned up mriedem's VirtNotImplemented patch to pass nearly all the test. But there is one real issue that got exposed with objects when that happened (which is a win) - http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html13:41
*** pkarikh has quit IRC13:41
*** rk4n has quit IRC13:41
openstackgerritStephen Finucane proposed openstack/nova: Fix outdated parameter network_info description in virt/driver  https://review.openstack.org/26316613:41
sdagueanyone more familiar with objects want to take a look13:41
sdagueit's failure to load a disk_format attr13:42
sdaguehttp://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html#_2016-03-09_12_24_48_10213:42
ndipanovsdague, it's highly likely just a bad mock13:42
sdaguendipanov: it might be13:42
sdaguebut I didn't want to just flip mocks around to make things pass and mask something else13:43
sdagueso would rather have someone be sure about the right way to address this13:43
openstackgerritGábor Antal proposed openstack/nova: Added appender methods to remove clones from config.py  https://review.openstack.org/23214513:43
mdboothlyarwood: Did my comments on the shared instance storage patch make sense, btw?13:47
*** rlrossit has joined #openstack-nova13:48
lyarwoodmdbooth: just about to switch to that now13:48
mdboothlyarwood: It's a bit convoluted, but in essence I think you changed it from broken but fail safe, to broken but fail <delete all user's stuff>13:49
lyarwoodmdbooth: well that obviously not what I wanted to do ;)13:50
lyarwoodthat's*13:50
*** shaohe_feng has quit IRC13:50
*** shaohe_feng has joined #openstack-nova13:51
*** amotoki has joined #openstack-nova13:54
ndipanovsdague, well those tests only use the unit/image/fake.py stuff so if they fail now it's due to that - the patch does not seem to be touching any of the stuff involved13:54
*** akshai has joined #openstack-nova13:55
*** claudiub has quit IRC13:55
*** salv-orlando has quit IRC13:55
*** pwnall has joined #openstack-nova13:55
openstackgerritZhengguang Ou proposed openstack/nova: libvirt: fix detach volume race condition  https://review.openstack.org/29051013:56
ndipanovsdague,disk_format is always set afaict since we make sure of that so I think it's safe to fix the mocks13:57
openstackgerritPaul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary  https://review.openstack.org/28837313:57
sdaguendipanov: so the issue is just that we do this - https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 and don't specify the required elements?13:58
*** huanxie has joined #openstack-nova13:58
*** markvoelker has quit IRC13:58
johnthetubaguysdague: hmm, that smells like a smoking gun, I will can take a quick look13:59
openstackgerritStephen Finucane proposed openstack/nova: Add a functional test for instance fault message with retry  https://review.openstack.org/24404614:00
edleafecdent: not sure about that bug. I added several things to improve visibility into host selection failures, but never heard back if that sufficed.14:00
*** shaohe_feng has quit IRC14:00
cdentedleafe: that seems to be the problem with many of the bugs: people looking to somewhere/someone/something for "is this right?"14:01
ndipanovsdague, well it's either mocks or we are not guarding against it properly when creating ImageMeta objects14:01
*** shaohe_feng has joined #openstack-nova14:01
ndipanovsdague, and it seems to me that we are doing that14:01
ndipanovaccording to the glance schema14:02
ndipanovso it's really just mocks left14:02
edleafecdent: yeah, I would mark that as fix released, as it went out in liberty14:02
edleafecdent: they can always file another with more specifics14:02
*** vladikr has joined #openstack-nova14:03
sdaguewell, it's our image create, it only adds the attributes we tell it to14:03
sdaguethen when that attempts to get objectified some point later, it's super partial14:03
sdagueand explodes14:03
*** daemontool_ has joined #openstack-nova14:03
johnthetubaguysdague: feels like partially filled out object causing issues14:03
sdagueunfortunately the explode was similar to a kind we were catching, so we never noticed it wasn't testing what we thought14:04
johnthetubaguyyeah, seems like a good catch in the change14:04
ndipanovsdague, right - but that never happens in the real glance interaction afaict so this is really a case of just fixing the mocks14:04
ndipanovyeah that change is quite good14:04
johnthetubaguycertainly the test was passing for the wrong reason before14:04
sdagueright14:04
johnthetubaguylike you say, adding disk_format into https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 might help14:05
ndipanovsdague, johnthetubaguy well the fake image has plenty of images14:05
ndipanovwhy not just use those or add a snapshot there (we might be missing some more attrs)14:06
johnthetubaguysure, using a correct image would fit it, seems to be whats needed here14:06
ndipanovinstead of doing that create() - just reuse one of the existing ones in nova/unit/image/fake.py14:06
johnthetubaguylike sdague was sayings, looks like https://github.com/openstack/nova/blob/3d7e403cc7a5d9ebcd9a011d6c2055bfbf56cb05/nova/tests/unit/virt/test_virt_drivers.py#L301 is not enough to make the test pass14:06
*** daemontool has quit IRC14:07
*** salv-orlando has joined #openstack-nova14:07
johnthetubaguyit feels like the objects could do with a better exception for this case for "field not defined" or something like that14:07
johnthetubaguybut thats probably a distraction14:08
*** gjayavelu has joined #openstack-nova14:08
*** jaugustine has joined #openstack-nova14:09
ndipanovjohnthetubaguy, that's a api breaking change in ovo I would think14:09
sdagueok, I'll look at making create be a bit more of a thing14:09
ndipanovsdague, that was what I was thinking too14:10
*** jwcroppe has quit IRC14:10
*** shaohe_feng has quit IRC14:11
johnthetubaguyndipanov: it could be yes, I would settle for a better named subclass14:11
*** shaohe_feng has joined #openstack-nova14:12
openstackgerritZhengguang Ou proposed openstack/nova: libvirt: fix detach volume race condition  https://review.openstack.org/29051014:12
*** dstepanenko has joined #openstack-nova14:12
*** ducttape_ has joined #openstack-nova14:12
*** gjayavelu has quit IRC14:12
sdagueok, fix local, just rerunning all the tests14:12
*** rk4n has joined #openstack-nova14:13
sdaguefake image is used so many places behavior change might have fallout14:13
*** ekuris_ has joined #openstack-nova14:13
*** mdrabe has joined #openstack-nova14:13
openstackgerritPawel Koniszewski proposed openstack/nova: Remove block_migration from virt drivers  https://review.openstack.org/29051914:14
*** salv-orlando has quit IRC14:14
*** gongysh has joined #openstack-nova14:14
*** pkarikh has joined #openstack-nova14:16
*** fifieldt has quit IRC14:16
*** nelsnelson has joined #openstack-nova14:17
*** nelsnels_ has quit IRC14:18
*** mriedem has joined #openstack-nova14:19
*** mtanino has quit IRC14:19
*** gongysh has quit IRC14:20
*** Drankis has joined #openstack-nova14:20
openstackgerritRyan Rossiter proposed openstack/nova: Add Forbidden to caught cinder exceptions  https://review.openstack.org/29052314:20
*** shaohe_feng has quit IRC14:21
*** xyang1 has joined #openstack-nova14:21
*** jichen has quit IRC14:22
*** shaohe_feng has joined #openstack-nova14:22
openstackgerritSean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods  https://review.openstack.org/29013414:22
sdaguemriedem: I think ^^^ is right now14:23
sdagueI pounded through the unit tests this morning14:23
mriedemsdague: geez i guess14:23
sdaguemriedem: well, it seems like a good change, so I wanted to help move it forward14:23
mriedemi see an issue14:25
*** rfolco has quit IRC14:25
*** gongysh has joined #openstack-nova14:25
bauzaspkoniszewski: trying to load more context of https://review.openstack.org/#/c/287363/ , the RCA is that block_migration is set to None by the API in case it's 'auto', right ?14:25
bauzaspkoniszewski: so since we then calculate correctly the migrate_data object in the driver, you propose to use it instead of that *after* the source and dest calls are done, right?14:26
bauzasand then abandon block_migration14:27
mriedemsdague: what's with the fake image stuff in https://review.openstack.org/#/c/290134/3/nova/tests/unit/image/fake.py ?14:27
*** rfolco has joined #openstack-nova14:28
sdaguemriedem: see the test results for PS214:28
sdaguehttp://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/14:28
pkoniszewskibauzas: exactly, having block_migration value under two different variables is not the good way to go14:29
pkoniszewskibauzas: since migrate data is objectifyed we can cleanup this mess14:29
mriedemsdague: oh it found a bug?14:29
sdaguewe were hitting a NotImplemented because of disk_format check on objs14:29
mriedemnice14:29
sdaguewell, we definitely caught an issue with us passing a test for the wrong reasons14:29
sdaguemriedem: also, interesting, that 0 tests caught the issue you found in review14:30
mriedemsdague: yeah, because the compute manager and rest api tests stub each other out14:30
mriedemso, not surprising14:30
bauzaspkoniszewski: I'm just not super happy with https://review.openstack.org/#/c/287363/6/nova/compute/manager.py@536714:31
*** shaohe_feng has quit IRC14:31
openstackgerritGleb Stepanov proposed openstack/nova: Fix wrong watermark state during live migration  https://review.openstack.org/27961614:31
bauzaspkoniszewski: how can you infer that other drivers are using shared_storage and consequently *not* needing to do clean-ups ?14:31
openstackgerritChris Dent proposed openstack/nova: Make force_ and ignore_hosts comparisons case insensitive  https://review.openstack.org/29053214:32
sdaguewe should probably just ban the use of NotImplementedError in the code overall, given that we can't distinguish who didn't implement what14:32
sdagueit could be a freaking db driver throwing it for all we know14:32
*** shaohe_feng has joined #openstack-nova14:32
sdaguemriedem: ok, I'll fix that up14:32
pkoniszewskibauzas: only libvirt and xenapi support block live migrations, we never call cleanups for other drivers14:32
*** jwcroppe has joined #openstack-nova14:32
bauzasthat, I know14:32
pkoniszewskibauzas: even that hyperv implements rollback_at_destination, we never used it yet14:32
bauzaspkoniszewski: I'm just saying14:33
pkoniszewskibauzas: tbh im not happy with that too, it should go to driver layer and be maintained per driver over there14:33
mriedemsdague: ok, there are some other comments in there, mostly minor14:33
ndipanovjaypipes, you will love this patch that I have that did not break any tests lol :)14:33
mriedemsdague: like there are 2 layers of vmware api stuff just to raise what the base Compute Driver does14:33
jaypipesndipanov: :)14:33
mriedemwe could just remove the redundancy14:33
sdaguemriedem: ok, I'll try to polish this off14:34
bauzaspkoniszewski: see the original stuff, we're still using the block_migration flag to know whether it's a block migration and consequently do the cleanup or not14:34
bauzaspkoniszewski: if we don't have the 'auto' value, it's understandable that it should work for other drivers too14:34
*** ducttape_ has quit IRC14:34
pkoniszewskiyeah, but by default block_migration is False, so it gives the same result14:34
bauzasI agree14:34
bauzasso14:34
sdaguemriedem: if we are removing - https://review.openstack.org/#/c/290134/3/nova/virt/vmwareapi/driver.py14:34
sdagueare we also going to remove the vmops of those?14:35
bauzaspkoniszewski: oh I see your point14:35
*** haukebruno has quit IRC14:35
*** gongysh has quit IRC14:35
pkoniszewski(None and False will give the same result there)14:35
*** artom has joined #openstack-nova14:35
mriedemsdague: i think we should14:35
bauzaspkoniszewski: if it wasn't a block migration, it was so set to False, so it was always True for other drivers14:35
mriedemsdague: er, i don't see any reason in keeping both14:36
mriedemthe driver and vmops raising NotImplementedError14:36
bauzaspkoniszewski: so that's necessarly a shared storage14:36
bauzasI see14:36
pkoniszewskibauzas: that's right14:36
sdaguemriedem: sure, that's fine14:37
lyarwoodmriedem: morning, not sure if you've seen https://review.openstack.org/#/q/topic:bug/1548450 in the stable/{liberty,kilo} queue this morning for OSSA 2016-007, hopefully a trivial ack if you have time to check.14:37
sdaguelets see how many other unit tests to fix now :)14:37
*** cleong has joined #openstack-nova14:37
markus_zsfinucan: FYI: https://etherpad.openstack.org/p/libvirt-latest-test-job If I remember correctly you wanted to see how this works, right?14:37
sfinucanmarkus_z: Ooh, yes please14:37
markus_zsfinucan: The gerrit patch has the needed changes.14:38
sfinucanmarkus_z: Sweet. I'll get on it14:38
markus_zsfinucan: There is also this blog entry which gives a bit background: http://abregman.com/2016/03/05/openstack-infra-jenkins-jobs/14:39
*** jwcroppe has quit IRC14:40
*** erno has quit IRC14:41
markus_zHopefully I can get it merged and running until the summit, then we can chat about it.14:41
*** shaohe_feng has quit IRC14:41
*** cfriesen_ has joined #openstack-nova14:42
*** ducttape_ has joined #openstack-nova14:42
sfinucanmarkus_z: Yes, hopefully14:42
sfinucanand thanks for the blog link. I know a few folks who'll enjoy that14:42
*** shaohe_feng has joined #openstack-nova14:42
*** Daisy has joined #openstack-nova14:43
lpetrutpkoniszewski bauzas : for the record, Hyper-V supports live block migration as well :)14:44
*** gongysh has joined #openstack-nova14:44
pkoniszewskilpetrut: is this supported by openstack?14:44
lpetrutyep, since Grizzly, I think14:44
*** smatzek has quit IRC14:44
pkoniszewskilpetrut: i went through drivers and block_migration argument is not used anywhere14:44
pkoniszewskilpetrut: is that something that is decided by hypervisor?14:45
pkoniszewskii mean, it isn't used in hyperv drivers14:45
*** burt has joined #openstack-nova14:45
openstackgerritMaciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state  https://review.openstack.org/16891614:45
lpetrutwe just did not use that argument, Hyper-V will always move the instance local disks when an instance is migrated. I guess that's what you use the 'block migration' flag, right?14:46
pkoniszewskilpetrut: for xen and libvirt, yes14:46
pkoniszewskilpetrut: so still we don't have to care about value of block_migration argument when hyperv is used under-the-hood, do we ?14:47
sdaguehmmm... it's not just a create fix14:47
lpetrutnope, while I think that we had issues because the rollback was not performed because of this flag14:47
*** knikolla has joined #openstack-nova14:47
*** markvoelker has joined #openstack-nova14:48
*** igornsa_ has joined #openstack-nova14:48
*** haomaiwang has joined #openstack-nova14:49
*** ivase has joined #openstack-nova14:49
lpetrutbut as far as I remember, there was a patch that was moving this logic to the driver side (deciding if a block migration is performed)14:49
pkoniszewskilpetrut: it was confusing to me when i found that we never performed rollback for hyperv, and all because of block_migration flag14:49
pkoniszewskilpetrut: yes, it is up for review14:50
pkoniszewskilpetrut: but it also might be worth to add 'block_migration' to hyperv object14:50
*** Daisy has quit IRC14:51
*** shaohe_feng has quit IRC14:52
*** mriedem is now known as mriedem_meeting14:52
*** shaohe_feng has joined #openstack-nova14:52
openstackgerritRyan Rossiter proposed openstack/nova: Translate OverLimit exceptions in Cinder calls  https://review.openstack.org/29055014:52
openstackgerritJuan Antonio Osorio Robles proposed openstack/nova: Set personality/injected_files to empty list if not specified  https://review.openstack.org/24866214:53
*** bnemec has joined #openstack-nova14:53
*** haukebruno has joined #openstack-nova14:53
*** igornsa_ has quit IRC14:55
bauzaspkoniszewski: lpetrut: I agree, we should expose the same way for all drivers about what's supported14:55
bauzasand not leave the driver code magically calculate whether it's okay or not14:55
*** Daisy has joined #openstack-nova14:55
bauzasin particular given block_migration is an user request query14:56
*** atuvenie_ has joined #openstack-nova14:56
*** atuvenie_ has quit IRC14:56
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Make quotas commands more user-friendly  https://review.openstack.org/29055614:57
*** esracelik has quit IRC14:59
pkoniszewskiwell I want to completely remove block_migration flag from drivers, so we will avoid any problems in the future where block_migration != migrate_data.block_migration14:59
*** danpb1 has joined #openstack-nova15:00
*** danpb has quit IRC15:00
pkoniszewskithis would force all drivers to use migrate_data as a canonical source of what is really supported15:00
*** mrkz has joined #openstack-nova15:00
pkoniszewskibauzas: lpetrut: ^^15:00
dansmithndipanov: there's a catch with your online data migration for pci_devices: http://logs.openstack.org/77/290077/1/check/gate-grenade-dsvm/f005ce8/logs/grenade.sh.txt.gz#_2016-03-08_19_38_01_73615:01
*** haomaiwang has quit IRC15:01
*** gongysh has quit IRC15:01
dansmithndipanov: if we did a full shutdown, upgraded the code, then ran that command, none of the services are upgraded15:01
*** haomaiwa_ has joined #openstack-nova15:01
*** shaohe_feng has quit IRC15:01
pkoniszewskibauzas: thanks for reviewing this patch, i need to drop in few minutes, in case u have more concerns please leave them in review15:01
openstackgerritArtom Lifshitz proposed openstack/nova: No direct XML parsing in libvirt driver  https://review.openstack.org/29056215:02
bauzasdansmith: given https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L318-L322 are we planning to keep that container-ish style supported for a while or should we ask callers to use obj_attr_is_set() explicitly?15:02
dansmithndipanov: so I think that we're going to either need to make that a warning and continue on, or have a --i-know-what-i-am-doing flag15:02
dansmithbauzas: we just added it into the base recently15:03
bauzasI saw15:03
bauzasI saw mriedem_meeting's doing that15:03
ndipanovdansmith, hmmm15:03
dansmithbauzas: yeah15:03
bauzasit was a DictCompat thing that was ported up15:03
bauzasso, hence my question15:03
ndipanovso that thing is supposed to check the actual service version15:03
dansmithndipanov: right, and it's working well :)15:03
bauzasif it was kept in a mixin, I would have thrown the axe15:03
ndipanovdansmith, oh ok15:03
*** shaohe_feng has joined #openstack-nova15:03
bauzasbut I always try to have things explicit, in particular with o.vo15:03
*** zz_dimtruck is now known as dimtruck15:03
*** Daisy has quit IRC15:04
bauzasdansmith: context is https://review.openstack.org/#/c/287363/6/nova/compute/manager.py@5236 and could be confusing15:04
*** danpb1 has quit IRC15:04
dansmithbauzas: what about it is confusing?15:04
bauzasdansmith: fortunately, the right above call is turning a possibly legacy dict into an object15:04
bauzasdansmith: people could think it's a dict15:05
dansmithoh confusing because you don't know if it is a dict?15:05
dansmithwell, it can't be a dict because the same statement uses attribute syntax15:05
bauzasdansmith: this can't be a dict because of the above call15:05
bauzasI agre15:05
dansmithand that15:05
bauzasagree15:05
*** xek_ is now known as xek15:05
bauzasso, it's something we keep supporting, objects will be containers for a long period of time ? woah, nice15:05
*** pushkaru has joined #openstack-nova15:06
ndipanovdansmith, I still don't get the problem you try to point out15:06
* bauzas just remembers all the times he litterally had to obj_attr_is_set()15:06
dansmithbauzas: the point of doing that was just because obj_attr_is_set() is annoying15:06
bauzasfair enough15:06
*** rk4n has quit IRC15:06
bauzasso I should kiss mriedem_meeting ?15:06
*** mtanino has joined #openstack-nova15:06
*** smatzek has joined #openstack-nova15:06
dansmithndipanov: in grenade, we start up a liberty set, run it, shut it down, then we try to do these online migrations after out db sync so that we are fully migrated, offline, before we start up15:07
dansmithndipanov: none of the services have run at mitaka level yet, which means this command refuses to run15:07
ndipanovI see15:07
dansmithwhich also means things like puppet/chef/ansible won't be able to do a full offline upgrade for you15:07
dansmithif you wanted such a thing (and that's how they do it today)15:07
ndipanovwe do need a --i-know-what-im-doing-shutup15:07
dansmithyeah15:07
dansmithor,15:08
dansmithwe just assume that command is that and just warn the user "okay, now you can't have any older services, kthx"15:08
ndipanovhmmm15:08
*** sc68cal has joined #openstack-nova15:08
dansmithbut the question is also: do we need to bump all the service versions? otherwise code that uses that to signal things might be confused about newer format stuff *and* older services15:08
sdaguehmmmm... dansmith I think I need to understand some objects magic in the tests, that change of mriedem_meeting's tripped over a non trivial issue where our tests passed for the wrong reasons15:09
*** pradk has joined #openstack-nova15:09
ndipanovdansmith, so I think we should have 2 commands15:10
* cdent waves at pradk 15:10
dansmithsdague: okay15:10
ndipanovthe other one called 'offline data migration and my newborn that I will never run an old version of the service ever'15:11
pradkcdent, howdy :)15:11
ndipanovfirst-born*15:11
sdaguedansmith: http://logs.openstack.org/34/290134/2/check/gate-nova-python27/77c9d8e/console.html#_2016-03-09_12_24_48_102 is the root error15:11
dansmithndipanov: instead of a --flag?15:11
sdagueI thought it was related to our FakeImage service building incomplete images, but once I get that sorted, the error is still there15:11
ndipanovwell yeah because you really should not run that unless you know what you are doing right15:11
dansmithsdague: right, this is what I was saying yesterday.. if you don't implement lazy-loading for your object (or for one attribute of your object) you get (and always have gotten) a notimplementederror if you trigger a lazy load15:12
ndipanovit's not an online data migration anymore15:12
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L41 seems to be returning empty image objects15:12
openstackgerritTim Pownall proposed openstack/nova: xenapi: fix when tar exits early during download  https://review.openstack.org/28742615:12
*** shaohe_feng has quit IRC15:12
dansmithndipanov: you mean to denote the offline-ness? I'm just concerned people will think that the "online migrations" and "offline migrations" are different things, two different steps, run the offline ones while offline, then the online ones later15:13
*** huanxie has quit IRC15:13
*** shaohe_feng has joined #openstack-nova15:13
ndipanovdansmith, how bad is it if we don't have offline ones15:13
*** edtubill has joined #openstack-nova15:14
sdaguedansmith: if I print instrument the code I the image_service.show returns line 1, and the image_obj is line 2 - http://paste.openstack.org/show/489858/15:14
*** Daisy has joined #openstack-nova15:14
*** pushkaru has quit IRC15:14
ndipanovit seems we are opening ourselves up to pain if we allow it15:14
dansmithndipanov: I think we break puppet (et al) users that would rather a longer offline but more pushbuttony upgrade15:14
ndipanovdansmith, we don't break them at all15:14
*** ekuris_ has quit IRC15:15
*** rk4n has joined #openstack-nova15:15
*** READ10 has joined #openstack-nova15:15
dansmithsdague: sorry, like six conversations in parallel right now, just a sec15:17
sdaguedansmith: yep, no worries, let me go get more coffee15:17
*** zengine has joined #openstack-nova15:18
*** Daisy has quit IRC15:19
*** pushkaru has joined #openstack-nova15:19
*** danpb has joined #openstack-nova15:20
dansmithsdague: so you're trying to figure out *why* you're getting a lazy-load right?15:22
sdaguedansmith: yeh15:22
sdaguegiven that it's objects.ImageMeta.from_dict(image)15:22
*** zengine has quit IRC15:22
*** shaohe_feng has quit IRC15:22
dansmithsdague: so the reason is that in the object (line 2) it's unset, which is what <?> means in the repr15:23
dansmithwhy that's not set is another question15:23
sdagueright15:23
sdagueit's getting fed a dict that has that attribute15:23
*** shaohe_feng has joined #openstack-nova15:23
sdaguelet me poke a bit more, I'm noticing some other oddities in this trace15:25
dansmithsdague: oh15:27
*** zengine has joined #openstack-nova15:27
dansmithsdague: should disk+format be inside the properties blob in the dict?15:28
dansmithmaybe the mock is giving you back something wrong?15:28
sdagueit's in the dict15:28
sdagueI actually fixed that part15:28
dansmithright, but the dict is two dicts nested15:28
dansmith{'properties': {'disk_format': 'raw'}}15:29
sdaguedisk_format is top level I'm pretty sure15:29
dansmithokay15:29
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/image/fake.py#L12615:29
sdaguewe treat it as top level everywhere else15:29
*** edtubill has quit IRC15:29
sdagueso, maybe this is a lazy load thing, because it's coming around through instances.image_meta15:30
sdagueinstance.image_meta15:30
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/virt/libvirt/driver.py#L1623 - that thing is "empty"15:30
sdaguesorry, one line up15:30
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/virt/libvirt/driver.py#L162215:30
sdagueeven though I've definitely got that image in the fake service, and it will return on a show15:31
dansmithhmm15:31
dansmithnot even sure what that is15:31
dansmithah,15:31
dansmithright15:31
dansmiththis is a non-objects @property that runs ImageMeta.from_instance(self)15:31
sdagueok15:31
openstackgerritTim Pownall proposed openstack/nova: xenapi: fix when tar exits early during download  https://review.openstack.org/28742615:32
sdagueso how do we get that to not be empty15:33
*** shaohe_feng has quit IRC15:33
*** mgoddard has quit IRC15:33
*** shaohe_feng has joined #openstack-nova15:33
*** mgoddard has joined #openstack-nova15:34
*** edtubill has joined #openstack-nova15:35
dansmithsdague: comes from here: https://github.com/openstack/nova/blob/master/nova/utils.py#L1242-L126815:37
dansmithI'm guessing we just don't store all the things for an instance so some of that will never be set when we're just pulling from an instance15:37
dansmithwe should ask danpb as I think this is all his15:37
*** krtaylor has joined #openstack-nova15:37
danpbdansmith: what/when/where15:38
*** ildikov has quit IRC15:40
*** mriedem_meeting is now known as mriedem15:40
*** palexster has quit IRC15:42
*** shaohe_feng has quit IRC15:43
*** shaohe_feng has joined #openstack-nova15:44
mriedemrlrossit: http://docs.openstack.org/releasenotes/nova/unreleased.html15:44
rlrossitmriedem: ah unreleased that's how it's divided up15:45
*** Swami has joined #openstack-nova15:45
dansmithdanpb: well, I expected sdague to jump in there15:45
sdaguedansmith: I'm not convinced we're running that code in this test15:45
dansmithsdague: oh?15:45
*** browne has joined #openstack-nova15:45
dansmithsdague: if it's doing instance.image_meta then it is15:46
dansmithunless it's mocked15:46
*** nkrinner has quit IRC15:46
sdagueoh, wait, wrong method, everything is named so close15:46
*** palexster has joined #openstack-nova15:46
sdagueyeh, we are in that method, figuring out what our inputs look like15:47
sdaguesystem_meta = {}15:48
sdagueso that's not great15:48
*** sayalilunkad_lap has quit IRC15:48
danpbis this in unit tests ?15:48
sdagueyeh15:48
*** sayalilunkad_lap has joined #openstack-nova15:49
*** zengine has quit IRC15:49
danpbour unit tests are sooooo awful at providing real world ImageMeta leaving out attributes that glance would always supply a value for15:49
sdaguedanpb: this is trying to get to the bottom of 1 test that doesn't work when we change to explicit exceptions for virt features15:49
sdaguehttps://review.openstack.org/#/c/290134/15:49
*** zengine has joined #openstack-nova15:49
*** efried has quit IRC15:50
sdagueand it turns out that nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_snapshot_running fails for the wrong reasons15:50
sdaguebut was masked because of exception overlap15:50
danpboh i see, that's nice15:51
danpbyeah that message looks very like problems i hit when converting libvirt tests to ImageMeta Objects15:52
*** efried has joined #openstack-nova15:52
*** shaohe_feng has quit IRC15:53
sdagueok, it looks like system_meta is actually {} from further back15:53
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L9415:54
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/utils.py#L8915:54
*** shaohe_feng has joined #openstack-nova15:54
sdaguemy local lines are a little shifted with some debug code15:54
*** zengine has quit IRC15:54
*** kmartin has joined #openstack-nova15:55
*** EinstCrazy has quit IRC15:56
*** liverpooler has quit IRC15:56
openstackgerritPaul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary  https://review.openstack.org/28837315:56
jaosoriormriedem: Hello, regarding the nova hooks issue (the personality/injected files thing), is this better as means for testing? https://review.openstack.org/#/c/248662/8/nova/tests/unit/api/openstack/compute/test_serversV21.py15:57
mriedemjaosorior: i'll look in a bit15:57
*** ssurana has joined #openstack-nova15:59
*** Sukhdev has joined #openstack-nova15:59
danpbsdague: yeah, i'd say that was the cause16:00
sdagueok, in a real world, what is system_metadata supposed to be here to get that image back?16:00
*** haomaiwa_ has quit IRC16:01
*** haomaiwang has joined #openstack-nova16:01
danpbsdague: in libvirt test_driver.py we just have16:01
danpb        'system_metadata': {16:01
danpb            'image_disk_format': 'raw',16:01
danpb        },16:01
sdagueok, but we actually have this image in our image store16:02
danpbi don't think it actually matters in this test case afaict16:02
*** zzzeek has quit IRC16:03
danpbi don't see code accessing the image store16:03
sdagueit would be kind of nice to actually populate it to be consistent instead of have another mock path16:03
*** mjura has quit IRC16:03
sdaguewe're definitely accessing the image store16:03
*** thorst_ is now known as thorst_afk16:03
*** shaohe_feng has quit IRC16:03
*** zzzeek has joined #openstack-nova16:04
*** Drankis has quit IRC16:04
*** shaohe_feng has joined #openstack-nova16:05
*** gcb has joined #openstack-nova16:05
*** roeyc has quit IRC16:05
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/virt/test_virt_drivers.py#L260-L26816:06
sdagueI guess we can just link it there16:08
sdaguedansmith: is there a to_dict?16:10
sdagueon objects16:10
*** yamahata has joined #openstack-nova16:10
johnthetubaguyis that to_primitive or something like that?16:10
cdentsdague: did you get any insight on to why the py34 job is slow or is that still pending?16:10
dansmithsdague: you can do base.obj_to_primitive() which tries to make an object into a dict, but it's usually a bad idea16:11
sdaguedansmith: well, many things assume images are dicts16:12
sdagueat least in this stack it seems16:12
dansmithsdague: it can bring in more stuff than you want, and if the object differs at all it will hide other problems16:12
ansiwendansmith: if I add external=True to utils.synchronized, what would be the right lock_path? other places in the code use `os.path.join(CONF.instances_path, 'locks')`, but I'm not sure this is true in this case.16:12
sdagueget_system_metadata_from_image for instance16:13
ansiwendansmith: if I don't set the lock_path, the tests bail out because of a missing option16:13
dansmithsdague: spawn expects a dict instead of an ImageMeta object? that doesn't seem right16:13
openstackgerritChris Dent proposed openstack/nova: Make force_ and ignore_hosts comparisons case insensitive  https://review.openstack.org/29053216:13
sdaguedansmith: no, it expects an object16:14
*** shaohe_feng has quit IRC16:14
dansmithsdague: what are you trying to convert to a dict then?16:14
dansmithsdague: image_from_sysmeta expects a dict of sysmeta, of course, but...16:14
sdagueI'm trying to populate system_metadata correctly16:14
sdaguefrom the image we have16:14
*** shaohe_feng has joined #openstack-nova16:15
*** hemnafk is now known as hemna16:15
sdaguebecause we have all the parts right next to each other in this test, we just don't link them16:15
dansmithsdague: and that happens in compute manager before this connection to spawn in reality?16:15
*** jwcroppe has joined #openstack-nova16:15
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/tests/unit/virt/test_virt_drivers.py#L260-L26816:16
danpbsdague: if you have a dict of image meta from the image store, then call  nova.utils.get_system_metadata_from_image16:16
sdaguedanpb: right16:17
sdagueexcept the image we have is an object16:17
*** gcb has quit IRC16:17
dansmithit should be fine, no?16:17
sdaguenope16:17
dansmithwhy do you think that method won't take an object?16:17
danpbget_system_metadata_from_image  assumes dict accessors16:17
sdaguebecause of that ^^^16:18
dansmithbut we have those on imagemeta right?16:18
sdaguewe do not have .get16:18
danpbno, i explicitly never added DictCompat interface to these objets16:18
dansmithwe do have get16:18
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/utils.py#L121916:18
dansmithon properties16:18
sdaguehttps://github.com/openstack/nova/blob/481832e3be5cbeac1daa1cf2b6bbab4658329fe9/nova/utils.py#L121816:18
sdaguethat fails16:18
dansmithokay, well, you can try base.obj_to_primitive()16:19
sdaguedansmith: right, trying that :)16:19
dansmithdanpb: is there some reason that shouldn't handle an object?16:19
danpbdansmith: ultimately it should take only an object16:19
dansmithsdague: https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L529-L52916:19
danpbdansmith: but i never went as far as converting the bits of code involved in this area16:19
dansmithsdague: get on properties, but not on the base object I guess16:20
dansmithdanpb: okay16:20
danpbi stopped once i have the compute manager passing objects into the virt driver16:20
danpbone day, we can finish the rest of the bits inside compute manager & before it16:20
danpbbut it wasn't a big priority for me once I had the virt drivers converted16:20
danpbi'd probably add  to_system_metadata() /from_system_metadata() methods on nova.objects.ImageMeta() and then delete the utils methods ultimately16:21
openstackgerritJuan Antonio Osorio Robles proposed openstack/nova: Set personality/injected_files to empty list if not specified  https://review.openstack.org/24866216:22
*** jwcroppe has quit IRC16:23
*** shaohe_feng has quit IRC16:24
*** shaohe_feng has joined #openstack-nova16:25
sdaguedansmith: seems like I actually need - image_meta.obj_to_primitive()['nova_object.data']16:25
dansmithsdague: no, you're using the wrong one16:25
dansmithdefinitely don't use that16:25
dansmithnova.objects.base.obj_to_primitive16:25
sdagueok, that's 100% what I need in this test16:25
dansmithit's not I promise :)16:25
sdaguenova.objects.base.obj_to_primitive(image_meta) ?16:25
dansmithyes16:25
mriedemwho's on first?16:26
sdagueok, there is no method on objects for this?16:26
sdaguethe static method also works16:27
sdagueok, time to get rid of all my debug and submit16:27
openstackgerritChangBo Guo(gcb) proposed openstack/nova: virt: refactor method compute_driver_matches  https://review.openstack.org/26324316:27
dansmithsdague: no, there is no method on the actual object16:28
dansmithturning them into dicts is not really something we want to make easy :)16:28
openstackgerritVladik Romanovsky proposed openstack/nova: Clean up networks with SR-IOV binding on reschedule  https://review.openstack.org/28319816:29
*** armax has joined #openstack-nova16:30
*** mpavone has quit IRC16:30
*** edtubill has quit IRC16:30
*** gcb_ has joined #openstack-nova16:30
*** edtubill has joined #openstack-nova16:31
openstackgerritSean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods  https://review.openstack.org/29013416:33
*** dims has quit IRC16:33
sdaguemriedem: hopefully that's right now16:34
*** shaohe_feng has quit IRC16:34
*** Jeffrey4l has quit IRC16:34
*** harlowja_at_home has joined #openstack-nova16:34
*** Jeffrey4l has joined #openstack-nova16:35
*** shaohe_feng has joined #openstack-nova16:35
mriedemi learned something today16:35
*** sridharg has quit IRC16:36
mriedemhttps://gist.github.com/mriedem/4f6ea2e61ea82d6ade6f16:36
mriedemwhich is fine i guess16:36
mriedemi thought NovaException message formatting was a bit more ruthless for kwargs,16:36
mriedembut it's only if there are subs in the message16:37
mriedemrlrossit: ^ which is why your test didn't fail16:37
johnthetubaguyoh... I always assumed that would fail too16:37
mriedemyeah i was trying to figure out why exception.Forbidden(reason=six.text_type(exc_value)) wasn't exploding16:38
openstackgerritSamuel Matzek proposed openstack/nova: Detach volume after deleting instance with no host  https://review.openstack.org/25605916:38
mriedemand it's because the Forbidden.msg_fmt doesn't have subs16:38
dederyhi all. https://review.openstack.org/#/c/287515 (Fix failed snapshot on VMs with SRIOV ports) is ready for review. I have a couple of open points there that i'd be happy to hear some thoughts about them. thanks :)16:39
mriedemdedery: ndipanov is probably your guy for that one16:39
dansmithsdague: so FYI, our new ceph failure alerting protocol noted that the ceph plugin job is spiking this morning and several of us looked into it. Turns out the patch from lyarwood that johnthetubaguy and alaski merged yesterday for a CVE broke the libvirt driver for non-file-image disk16:41
*** gcb_ has quit IRC16:41
dansmithspecifically https://review.openstack.org/#/c/289957/1/nova/virt/libvirt/driver.py16:41
mriedemdansmith: hmm, probably the same one that lyarwood was asking me to review on stable this morning16:42
dansmithmriedem: indeed16:42
dederymriedem: thanks. will catch him16:42
mriedemdansmith: ouch http://logs.openstack.org/57/289957/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/bf4a658/logs/screen-n-cpu.txt.gz?level=TRACE16:42
*** gcb_ has joined #openstack-nova16:43
dansmithmriedem: sdague: note that if the ceph job was gating, we wouldn't have merged this16:43
bauzasmriedem: yeah we're investigating on that16:43
lyarwoodyeah here sorry16:43
dansmithmriedem: right16:43
dederymriedem: there's an open issue there on PCI passthrough, is this also ndipanov's domain?16:43
mriedemdedery: i generally see ndipanov, baoli_ and moshelle reviewing pci/sriov stuff16:44
bauzasdansmith: lyarwood: that only means that UTs are not catching that case too16:44
*** dims has joined #openstack-nova16:44
bauzasnot only the ceph thing16:44
dansmithlyarwood: you wanna look at a quick fix or should we revert?16:44
bauzasceph job is just the canary16:44
dederymriedem: great. thanks again16:44
*** shaohe_feng has quit IRC16:44
mriedemdansmith: lyarwood: should be a simple fix16:45
lyarwooddansmith: there's a quick fix16:45
mriedemjust an order of calls problem16:45
dansmithcool16:45
mriedemi've -2ed the backports16:45
*** shaohe_feng has joined #openstack-nova16:46
dansmithas mikal would say: THE SYSTEM WORKS!16:46
*** jschlueter has quit IRC16:46
*** akshai has quit IRC16:46
johnthetubaguydansmith: OK, so I did question that on the patch, but went with the +2s in the bug report.... arg.16:47
*** paul-carlton2 has quit IRC16:47
dansmithjohnthetubaguy: yeah... it would have been caught if we were gating on those tests.. it's subtle16:47
johnthetubaguydansmith: true16:48
openstackgerritPaul Carlton proposed openstack/nova: Add include_disabled parameter to service_get_all_by_binary  https://review.openstack.org/28837316:48
bauzasso, the problem is that on_execute is only set on a conditional, what should be the default value if we want to keep it pass ?16:48
*** vishwana_ is now known as vishwanathj16:48
lbeliveaumriedem: ndipanov already +2 my bug fix, I need another core to look at it and +w, seems like you know the area so can you please look at it ? https://review.openstack.org/#/c/24257316:49
*** akshai has joined #openstack-nova16:49
mriedemlbeliveau: i do not know sriov stuff :)16:49
paul-carlton1dansmith, added the comment to service.py that you suggested.16:49
openstackgerritDavid Edery proposed openstack/nova: Fix failed snapshot on VMs with SRIOV ports  https://review.openstack.org/28751516:49
*** e0ne has quit IRC16:50
*** tbachman has quit IRC16:50
lbeliveaumriedem: no problem, I know you reviewed some stuff in neutronv2, taught you could review it16:50
*** yamahata has quit IRC16:50
*** tristanC has joined #openstack-nova16:50
mriedemlbeliveau: do any of the sriov/pci 3rd party ci's run a cold migration or resize test?16:51
*** paul-carlton_ has joined #openstack-nova16:51
*** belmoreira has quit IRC16:52
lbeliveaumriedem: I don't think so since it's broken (afaik since kilo or even earlier)16:52
*** wolsen has quit IRC16:52
mriedemit being cold migration?16:52
lyarwoodjohnthetubaguy: apologies I should've asked you to clarify your comment on the change this morning, I obviously missunderstood what you were trying to get at.16:52
lbeliveauye16:52
*** wolsen has joined #openstack-nova16:52
mriedemlbeliveau: could we get an sriov 3rd party ci to post results on your patch though running a resize/migrate test?16:52
mriedemprobably just resize since cold migrate would require multihost16:52
*** browne has quit IRC16:53
*** haomaiwang has quit IRC16:53
lbeliveaumriedem: how can I do that ?  the patch is not run through all the gates ?16:54
mriedemlbeliveau: i guess you'd get in contact with who runs an sriov 3rd party ci on nova changes and see if they can run their ci on your patch with a resize test unskipped16:54
*** jdurgin1 has joined #openstack-nova16:55
mriedemi'm not sure what the sriov 3rd party ci is, if that's mellanox or other?16:55
mriedemmaybe intel?16:55
*** shaohe_feng has quit IRC16:55
*** jaosorior has quit IRC16:55
lbeliveaugot it, will do16:55
mriedemlbeliveau: i'd just have more warm fuzzies knowing that there is a test system in place for NFV stuff16:55
*** shaohe_feng has joined #openstack-nova16:56
*** EinstCrazy has joined #openstack-nova16:56
lbeliveaumriedem: agreed, I'll look into putting such a test out there16:56
mriedemthanks16:56
*** matrohon has quit IRC16:56
mriedemlbeliveau: fyi https://wiki.openstack.org/wiki/ThirdPartySystems/Intel-SRIOV-CI16:57
sdaguedansmith: cool that the new alerting stuff caught that16:57
dansmithsdague: \o/16:57
mriedemshaohe_feng: ^ is the intel sriov ci running on nova changes?16:57
mriedemlbeliveau: also https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI16:58
lbeliveaumriedem: thanks for the tips !16:58
*** mgoddard_ has joined #openstack-nova16:58
mriedemi don't see the mellanox ci reporting on the latest patch set, and i'm not sure how to recheck it16:59
*** gcb_ has quit IRC16:59
*** haomaiwang has joined #openstack-nova17:00
lbeliveaumriedem: right, seems like it's not executed, have to figure why :)17:00
*** haomaiwang has quit IRC17:01
mriedemi've emailed the maintainer to ask if there is a way to recheck their ci17:01
lbeliveauawesome17:01
mriedemn0ano: shaohe_feng: is there a way to recheck this? https://wiki.openstack.org/wiki/ThirdPartySystems/Intel-SRIOV-CI17:01
*** mgoddard has quit IRC17:02
*** rk4n has quit IRC17:02
lbeliveaumriedem: I need to figure out how we can test cold migration in long term, will hook up with those guys17:02
mriedemn0ano: shaohe_feng: or how can we get the intel sriov ci to run on https://review.openstack.org/#/c/242573 ?17:02
lbeliveauwell I do in my lab ... but need gate validation17:02
mriedemlbeliveau: resize should at least cover part of it17:02
mriedemresize to same host17:02
lbeliveauagreed17:03
*** jlanoux has quit IRC17:03
alaskilyarwood: just catching up, when you get a fix up for the ceph breakage ping me if you need a core to look at tit17:03
alaski*it17:03
*** fawadkhaliq has joined #openstack-nova17:03
*** EinstCrazy has quit IRC17:03
*** fawadkhaliq has quit IRC17:03
dansmithalaski: to look at what now?17:04
*** shaohe_feng has quit IRC17:05
*** daemontool has joined #openstack-nova17:05
alaskiI will happily look at whatever is presented and leave it at that17:06
dansmithlol17:06
*** shaohe_feng has joined #openstack-nova17:06
*** jistr has quit IRC17:06
*** daemontool_ has quit IRC17:07
*** aghadge has joined #openstack-nova17:07
*** haomaiwa_ has joined #openstack-nova17:08
*** rk4n has joined #openstack-nova17:08
*** apoorvad has joined #openstack-nova17:09
*** thorst_afk is now known as thorst_17:09
*** rcernin has quit IRC17:09
n0anomriedem, not sure, I'll ping the owners of the CI and see what's happening17:09
*** roeyc has joined #openstack-nova17:09
*** fawadkhaliq has joined #openstack-nova17:10
*** yamahata has joined #openstack-nova17:10
*** aghadge has quit IRC17:11
mdboothdansmith: Hey17:11
*** rk4n has quit IRC17:11
rlrossitmriedem: so how come when a Forbidden is raised, it explicitly needs to be caught by the API in order to return a 403? Shouldn't that kinda be "automatic"?17:11
dansmithmdbooth: ohai17:11
danpbalaski:  lyarwood is just running for a train... said he might be back online once he catches it...17:11
mdboothSo I can see what the problem is here17:12
* rlrossit runs away to play ping pong17:12
*** rk4n has joined #openstack-nova17:12
mdboothIt looks pretty simple to fix17:12
mdboothIs the patch already reverted?17:13
mriedemmdbooth: it's not17:13
mdboothI can either post a very quick fix17:13
dansmithmdbooth: nope, not reverted17:13
mriedempost a fix17:13
*** paul-carlton2 has joined #openstack-nova17:13
mdboothOk17:13
mriedemthe backports will have to be squashed with that fix17:13
mdboothkk17:13
dansmithmdbooth: thanks for jumping on it17:13
alaskidanpb: good to know, thanks17:13
openstackgerritSven Anderson proposed openstack/nova: Avoid parallel DB queries of identical metadata  https://review.openstack.org/28556217:14
*** shaohe_feng has quit IRC17:15
mriedemrlrossit: there is this https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L1067 but i think that's only if the rest api raises a specific webob.exc.Forbidden17:16
openstackgerritNikola Dipanov proposed openstack/nova: tests: Add some basic compute_api tests for attaching volumes  https://review.openstack.org/29070517:16
*** omnipresent has quit IRC17:16
ndipanovalaski, mriedem dansmith ^^17:16
*** shaohe_feng has joined #openstack-nova17:16
ndipanoveasy testing fix17:16
ndipanovsdague, too17:16
mriedemndipanov: we don't have volume attach tests in test_compute.py?17:17
ndipanovmriedem, none that test this logic I think17:17
n0anomriedem, just to be clear, that's the Intel NFV CI you want to recheck, the PCI CI has already given a +117:17
mriedemn0ano: yeah i know17:18
openstackgerritStephen Finucane proposed openstack/nova: libvirt: Don't misuse InstanceNotFound exception  https://review.openstack.org/29070617:18
*** browne has joined #openstack-nova17:18
n0anoOK, I'll look into it17:18
ndipanovmriedem, hmmm17:18
ndipanovit seems we do17:19
ndipanovhow did I miss those...17:19
*** tbachman has joined #openstack-nova17:19
mriedemndipanov: yeah, look for compute_api.attach_volume in https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py17:19
ndipanovmriedem, but funnily enough they don't test the case I tested here with raising17:20
mriedemhmm, it's entirely possible some of the test_compute tests are busted, or just mocking over things that you care about17:21
ndipanovplus I have a follow up fix with more failure cases17:21
*** rwmjones is now known as rwmjones_hols17:21
*** Sukhdev has quit IRC17:21
*** Sukhdev has joined #openstack-nova17:22
*** daemontool_ has joined #openstack-nova17:22
*** daemontool has quit IRC17:23
ndipanovmriedem, there is actually no test that tests for failure of the attach RPC17:23
ndipanovhmm but that is a cast so maybe not so interesting...17:23
openstackgerritJohn Garbutt proposed openstack/nova: Add prototype feature classification matrix  https://review.openstack.org/26471917:25
openstackgerritJohn Garbutt proposed openstack/nova: Get support matrix notes from the ini file  https://review.openstack.org/26476317:25
*** shaohe_feng has quit IRC17:25
mdboothdansmith: I have to run for the hills in just a second. I have a patch. Unit tests pass and I think it's good. If I throw it over the wall would you mind taking it?17:26
dansmithmdbooth: yep sure17:26
*** shaohe_feng has joined #openstack-nova17:26
openstackgerritMatthew Booth proposed openstack/nova: Fixup that CVE thing  https://review.openstack.org/29071517:27
mdboothdansmith: ^^^17:27
*** sayalilunkad_lap has quit IRC17:27
mdboothYou might want to look at the commit message :)17:27
* mdbooth runs for the hills17:27
dansmithmdbooth: hhe, okay17:28
*** dimtruck is now known as zz_dimtruck17:30
*** zz_dimtruck is now known as dimtruck17:30
*** sfinucan has quit IRC17:30
*** gjayavelu has joined #openstack-nova17:31
*** mrkz has quit IRC17:32
*** rdopiera has quit IRC17:34
*** shaohe_feng has quit IRC17:36
openstackgerritNikola Dipanov proposed openstack/nova: tests: Add some basic compute_api tests for attaching volumes  https://review.openstack.org/29070517:36
*** mrkz has joined #openstack-nova17:36
ndipanovmriedem, ^^17:36
*** shaohe_feng has joined #openstack-nova17:37
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: set service status based on vc connection  https://review.openstack.org/29031517:37
*** whenry_ has quit IRC17:39
openstackgerritAysy Anne A. Duarte proposed openstack/nova: Add mock for some libvirt unit tests work on ppc64le architecture  https://review.openstack.org/29006117:40
*** sudipto has quit IRC17:44
*** shaohe_feng has quit IRC17:46
dederysahid: thank you for the review. I'll address the comments later and continue the conversation over the comments17:46
*** vilobhmm11 has joined #openstack-nova17:47
*** shaohe_feng has joined #openstack-nova17:47
openstackgerritPavel Kholkin proposed openstack/nova: Missing info_cache.save() in db sqlalchemy api  https://review.openstack.org/28996717:48
*** vilobhmm111 has joined #openstack-nova17:48
*** lpetrut has quit IRC17:49
*** Marga__ has quit IRC17:49
*** lpetrut has joined #openstack-nova17:49
*** thumpba has quit IRC17:50
sahiddedery: cool thanks17:50
*** thumpba has joined #openstack-nova17:51
*** vilobhmm11 has quit IRC17:51
*** dedery has quit IRC17:53
*** haukebruno has quit IRC17:53
*** rk4n has quit IRC17:53
openstackgerritMaciej Szankin proposed openstack/nova: Live migration failure in API leaves VM in MIGRATING state  https://review.openstack.org/16891617:55
*** shaohe_feng has quit IRC17:56
*** lpetrut has quit IRC17:57
*** amotoki has quit IRC17:57
*** shaohe_feng has joined #openstack-nova17:57
cfriesen_is anyone aware of a way to make the kvm virtual watchdog start ticking on guest creation (ie in the virtual BIOS) rather than only starting on guest boot?  I'd like to protect against a hung boot.17:58
*** sahid has quit IRC18:00
*** haomaiwa_ has quit IRC18:01
*** 20WAAIK4T has joined #openstack-nova18:01
*** gjayavelu has quit IRC18:05
*** Jeffrey4l has quit IRC18:05
*** derekh is now known as derekh_afk18:06
*** akshai has quit IRC18:06
*** shaohe_feng has quit IRC18:06
*** shaohe_feng has joined #openstack-nova18:07
*** vilobhmm111 has quit IRC18:08
*** Marga_ has joined #openstack-nova18:08
*** nic has joined #openstack-nova18:09
*** ankita_wagh has joined #openstack-nova18:09
*** Marga_ has quit IRC18:09
*** ihrachys has quit IRC18:10
*** daemontool__ has joined #openstack-nova18:10
*** renatoarmani has joined #openstack-nova18:10
*** Marga_ has joined #openstack-nova18:11
*** daemontool_ has quit IRC18:13
*** akshai has joined #openstack-nova18:14
*** mgoddard_ has quit IRC18:15
*** ankita_wagh has quit IRC18:16
*** daemontool__ has quit IRC18:16
*** PaulMurray has quit IRC18:16
*** shaohe_feng has quit IRC18:17
*** danpb has quit IRC18:17
*** Marga_ has quit IRC18:17
*** shaohe_feng has joined #openstack-nova18:18
*** lucasagomes is now known as lucas-dinner18:18
*** tbachman_ has joined #openstack-nova18:19
*** jaosorior has joined #openstack-nova18:21
*** tbachman has quit IRC18:21
*** tbachman_ is now known as tbachman18:21
*** Marga_ has joined #openstack-nova18:22
mriedemjaosorior: one little issue in your personality test18:22
mriedemotherwise looks good18:22
ndipanovmriedem, check this out now https://review.openstack.org/#/c/290705/2 - or do you think I should rework those in test_compute.py18:24
ndipanov?18:24
mriedemndipanov: i think we want to not add anything more to test_compute that's new if we can help it18:25
mriedemnew things should go in test_compute_api and test_compute_mgr18:25
mriedemb/c test_compute is a mess18:25
ndipanovmriedem, agreed18:25
*** shaohe_feng has quit IRC18:27
ndipanovmriedem, also I fixed that service version thing https://review.openstack.org/#/c/286743/18:27
*** mvk has quit IRC18:27
ndipanovso would be good to drop the -1 if possible18:28
*** roeyc has quit IRC18:28
mriedem+2!18:29
*** e0ne has joined #openstack-nova18:29
mriedemnot that it mattered really, but yeah18:29
*** shaohe_feng has joined #openstack-nova18:29
*** takedakn has joined #openstack-nova18:29
*** palexster has quit IRC18:29
*** takedakn has quit IRC18:30
mriedembbiab18:31
*** ildikov has joined #openstack-nova18:33
*** jdurgin1 has quit IRC18:34
*** renatoarmani has quit IRC18:34
*** mriedem has quit IRC18:36
*** mriedem has joined #openstack-nova18:36
*** shaohe_feng has quit IRC18:37
*** shaohe_feng has joined #openstack-nova18:38
*** renatoarmani has joined #openstack-nova18:39
*** RuiChen has quit IRC18:39
openstackgerritRyan Rossiter proposed openstack/nova: Translate OverLimit exceptions in Cinder calls  https://review.openstack.org/29055018:40
openstackgerritRyan Rossiter proposed openstack/nova: Add Forbidden to caught cinder exceptions  https://review.openstack.org/29052318:40
dansmithjbernard_: mriedem: FYI that patch from mdbooth looks like it does fix it, so I'll get it cleaned up18:42
dansmithsdague: ^18:42
*** pece has quit IRC18:42
*** paul-carlton2 has quit IRC18:42
openstackgerritLudovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports  https://review.openstack.org/24257318:43
lbeliveaundipanov, mriedem: ^ fixed minor comment18:43
*** dims has quit IRC18:44
*** claudiub has joined #openstack-nova18:45
*** dims has joined #openstack-nova18:46
mriedemdansmith: link? i lost irc18:46
dansmithmriedem: hang on I'm about to push it again18:47
mriedempush it real good?18:47
pwnall:P18:47
dansmithmriedem: you know it18:47
*** shaohe_feng has quit IRC18:47
*** shaohe_feng has joined #openstack-nova18:48
openstackgerritGiridhar Jayavelu proposed openstack/nova: pci: avoid parsing whitelist repeatedly  https://review.openstack.org/26451018:49
lyarwooddansmith: back online finally btw18:49
*** tbachman has quit IRC18:49
lyarwooddansmith: looking at Matt's patch now18:49
dansmithlyarwood: okay18:50
*** tbachman has joined #openstack-nova18:50
*** Marga_ has quit IRC18:53
*** Marga_ has joined #openstack-nova18:54
lyarwooddansmith: looks good, are you still pushing a cleaned up version? :)18:56
dansmithlyarwood: yeah, making a test tweak18:56
dansmithlyarwood: we could do another test for this case specifically which might be nice if you want to work on that,18:56
dansmithand then maybe we could land this ASAP to fix the actual problem18:56
openstackgerritDan Smith proposed openstack/nova: Fix processing of libvirt disk.info in non-disk-image cases  https://review.openstack.org/29071518:57
*** shaohe_feng has quit IRC18:58
*** mgoddard has joined #openstack-nova18:58
*** rlrossit has quit IRC18:58
*** lpetrut has joined #openstack-nova18:58
*** shaohe_feng has joined #openstack-nova18:58
*** jwcroppe has joined #openstack-nova18:59
*** READ10 has quit IRC19:00
*** rlrossit has joined #openstack-nova19:00
lyarwooddansmith: I can look into that now but my connection is going to get pretty bad on this train ride. If we need this fixed ASAP feel free to push on without it, I can always add it later.19:00
dansmithlyarwood: I mean later, no worries19:00
dansmithjust don't forget :)19:00
*** 20WAAIK4T has quit IRC19:01
dansmithmriedem: ^19:01
*** markvoelker has quit IRC19:01
*** haomaiwa_ has joined #openstack-nova19:01
*** cdent has quit IRC19:01
*** Sukhdev has quit IRC19:02
*** ducttape_ has quit IRC19:02
*** paul-carlton_ has quit IRC19:02
*** markvoelker has joined #openstack-nova19:03
mriedemi have to remember what add_job and remove_job do in the tracker19:03
mriedemkills the pid right?19:03
tristanCit seems like kilo is not affected by the ceph breakage, so is https://review.openstack.org/#/c/289960/ good to be merged as-is ?19:04
dansmithmriedem https://review.openstack.org/#/c/290715/2/nova/virt/libvirt/driver.py19:05
dansmithit was there before, just got moved inside the loop19:05
tristanCand then, for liberty, is the follow-up going to be squashed with the backport, or both be merged using depends-on ?19:05
dansmithtristanC: I'm sure kilo is impacted as well19:05
tristanCdansmith: but the gate-tempest-dsvm-full-devstack-plugin-ceph-nv return success19:06
mriedemyeah it's odd that the ceph job isn't failing kilo19:06
dansmithtristanC: I'm guessing that's because we run fewer tests or something19:06
*** vilobhmm11 has joined #openstack-nova19:06
*** liverpooler has joined #openstack-nova19:06
dansmithor unless the patch applied differently there and we got lucky,19:06
dansmithbut mriedem would have noticed I think19:07
*** ducttape_ has joined #openstack-nova19:07
lyarwoodit didn't, it must be due to missing tests in kilo19:08
*** shaohe_feng has quit IRC19:08
*** pwnall has quit IRC19:09
*** shaohe_feng has joined #openstack-nova19:09
openstackgerritAndrew Laski proposed openstack/nova: Change SpawnIsSynchronous fixture return  https://review.openstack.org/29078019:10
alaskimriedem: ^19:10
mriedemnice19:10
mriedemdansmith: mdbooth: why is that compression kwarg removed?19:11
*** zenoway has joined #openstack-nova19:12
*** andreykurilin__ has quit IRC19:13
dansmithmriedem: hmm, I dunno19:13
dansmithlyarwood: any idea?19:13
mriedemtristanC: lyarwood: dansmith: btw, kilo is running the same tests19:13
*** haomaiwa_ has quit IRC19:13
mriedembut passing19:13
mriedemmaster: http://logs.openstack.org/67/289967/5/check/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/86e0aa4/console.html#_2016-03-09_18_10_57_48119:13
mriedemkilo: http://logs.openstack.org/60/289960/1/check/gate-tempest-dsvm-full-ceph/90d5a22/console.html#_2016-03-08_15_35_17_73819:13
dansmithmriedem: well, it's a pretty mechanical problem, not sure how it's not broken there19:13
*** boris-42 has quit IRC19:14
*** haomaiwa_ has joined #openstack-nova19:14
mriedemyeah, there is some differences in the method between master and kilo wrt handling swaps19:16
mriedemand on master it's the swap block that was setting those vars19:17
mriedembut not in kilo19:17
mriedemso that's probably why it's not failing,19:17
mriedembut it's still wrong19:17
*** markvoelker has quit IRC19:17
*** markvoelker has joined #openstack-nova19:18
*** shaohe_feng has quit IRC19:18
*** shaohe_feng has joined #openstack-nova19:19
*** jschlueter has joined #openstack-nova19:19
*** doug-fis_ has joined #openstack-nova19:19
*** doug-fis_ is now known as doug-fish_19:20
*** doug-fish has quit IRC19:21
*** ociuhandu has quit IRC19:23
dansmithmriedem: that compression arg won't be available if we don't run the swap clause19:23
*** lpetrut has quit IRC19:25
openstackgerritNikola Dipanov proposed openstack/nova: Do not reserve device before reserving the volum  https://review.openstack.org/29079319:25
ndipanovmriedem, here's a nice one for you I know you love volumes ^^19:25
*** lpetrut has joined #openstack-nova19:25
dansmithmriedem: and it wasn't originally on this call because that call didn't exist19:25
dansmithmriedem: and was only for swap19:25
mriedemyeah19:25
mriedemdansmith: so just another copy/paste fail i guess19:25
dansmithmriedem: so I want to say that this was just copy/paste19:25
dansmithyeah19:25
*** lpetrut has quit IRC19:25
*** renatoarmani has quit IRC19:26
mriedem+2 but we should wait for the ceph job results19:26
*** lpetrut has joined #openstack-nova19:26
dansmithit passed ceph before I updated the commit message19:26
dansmithbut yeah19:26
dansmithno argument19:26
dansmithsince that's how we got here in the first place :)19:26
mriedemndipanov: added myself, a bit distracted19:27
*** baoli_ has quit IRC19:27
mriedemdansmith: it's already passed the resize tests in the ceph jobs19:28
mriedemhttps://jenkins07.openstack.org/job/gate-tempest-dsvm-full-ceph/8100/console19:28
mriedemhttps://jenkins04.openstack.org/job/gate-tempest-dsvm-full-devstack-plugin-ceph-nv/1921/console19:28
*** shaohe_feng has quit IRC19:29
dansmithcool19:29
*** shaohe_feng has joined #openstack-nova19:29
*** jschlueter has quit IRC19:30
*** jed56 has quit IRC19:33
*** thorst__ has joined #openstack-nova19:36
*** jwcroppe has quit IRC19:37
*** shaohe_feng has quit IRC19:39
*** mvk has joined #openstack-nova19:39
*** shaohe_feng has joined #openstack-nova19:39
*** yassine has quit IRC19:40
*** thorst_ has quit IRC19:40
*** efoley__ has quit IRC19:42
*** yamahata has quit IRC19:44
*** ociuhandu has joined #openstack-nova19:44
*** sdague has quit IRC19:45
*** jichen has joined #openstack-nova19:45
*** pushkaru has quit IRC19:48
*** pushkaru has joined #openstack-nova19:48
*** edtubill has quit IRC19:48
*** shaohe_feng has quit IRC19:49
*** edtubill has joined #openstack-nova19:50
*** shaohe_feng has joined #openstack-nova19:50
*** salv-orlando has joined #openstack-nova19:51
*** salv-orl_ has joined #openstack-nova19:53
*** sdague has joined #openstack-nova19:54
*** doug-fish has joined #openstack-nova19:55
*** doug-fish_ has quit IRC19:55
tristanCcan I cherry-pick 290715 on top of current backport ? I worry the advisory needs an errata asap19:56
*** salv-orlando has quit IRC19:56
sdaguemriedem / dansmith on the fix for ceph we're sure the 2 multinode fails aren't related - http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/console.html19:57
*** rlrossit has quit IRC19:58
sdagueone is the volumes backed live migration, which IIRC is completely hosed anyway19:58
dansmithsdague: did you see what the actual bug was?19:58
sdagueshelve offload looks like it's not getting the dhcp lease19:58
mriedemi've never seen this before http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/screen-n-cpu.txt.gz?level=TRACE#_2016-03-09_18_09_01_74819:58
dansmithjust moved setting a variable inside an if statement that only runs on things like ceph19:59
dansmith*unlike19:59
sdaguedansmith: ok19:59
dansmithmriedem: I have19:59
mriedemsdague: live block migration suddently aborted http://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/subnode-2/screen-n-cpu.txt.gz?level=TRACE#_2016-03-09_18_08_33_51019:59
mriedemwhich is known19:59
dansmithmriedem: when we had name clashes in multinode19:59
mriedem*unexpectedly failed19:59
*** shaohe_feng has quit IRC19:59
*** drankis has joined #openstack-nova19:59
*** renatoarmani has joined #openstack-nova20:00
*** shaohe_feng has joined #openstack-nova20:00
mriedemdansmith: checking the 2 n-cpu logs they have different hostnames it looks like20:00
*** haomaiwa_ has quit IRC20:01
mriedemshelve instance failed on an ssh thing20:01
*** haomaiwang has joined #openstack-nova20:01
*** rhagarty has joined #openstack-nova20:01
sdaguethe name clashes were addressed a long time ago ... but I agree, that looks kind of suspect20:01
sdagueanyway, this fix, is fine20:02
dansmithyeah, definitely weird20:02
*** rlrossi__ has joined #openstack-nova20:02
dansmithmriedem: did you look in logstash for that one?20:02
*** jaosorior has quit IRC20:02
mriedemnot yet20:02
*** jaosorior has joined #openstack-nova20:03
dansmithif this is reasonable: message:"another host's instance"20:03
mriedemhttp://goo.gl/cjoCAk20:03
dansmithit's got lots of hits20:03
dansmithyeah, cool20:03
mriedem2500+20:04
*** jichen has quit IRC20:04
mriedem68% successful runs when it shows up,20:04
mriedembut that's not really saying much since the multinode jobs fail anywhere between 25 and 75% of the time20:04
dansmithheh20:04
*** renatoarmani has quit IRC20:04
*** jichen has joined #openstack-nova20:05
*** Sukhdev has joined #openstack-nova20:05
sdaguemriedem: it looks like the records of the migrations are getting left in a state that the resource track hits on it's periodic and gets mad about20:07
sdaguehttp://logs.openstack.org/15/290715/1/check/gate-tempest-dsvm-multinode-full/03f92ff/logs/screen-n-cpu.txt.gz?level=INFO#_2016-03-09_18_09_00_77520:07
sdagueevery time that runs after a live migration has run, it generates an error20:07
mriedemsdague: ok, definitely shouldn't be an error level20:08
mriedemi can open a bug20:08
sdaguereferencing the live migration that completed20:08
dansmithyeah, I thought that was debug level actually20:08
dansmithmaybe some recent change with live migration work?20:08
sdaguewell, it seems like it shouldn't be either20:08
*** gjayavelu has joined #openstack-nova20:08
sdagueright?20:08
*** renatoarmani has joined #openstack-nova20:08
dansmitheither?20:08
dansmithmeaning not debug either?20:08
sdaguewe should have left things in a sane state for the resource tracker20:08
sdaguethe fact that after every live migration there is crud the resource tracker needs to clean up separately seems weird20:09
dansmithsure, I'm just saying I thought this specific one was a debug20:09
dansmithdoes it actually clean it up or ignore it?20:09
*** renatoarmani has quit IRC20:09
*** pushkaru has quit IRC20:09
*** pumarani__ has joined #openstack-nova20:09
mriedemhttps://bugs.launchpad.net/nova/+bug/155532020:09
openstackLaunchpad bug 1555320 in OpenStack Compute (nova) ""Migration for instance 0763227e-e192-4e0b-a49d-0ea0b181fca6 refers to another host's instance!" should not be an error" [Medium,Confirmed]20:09
*** shaohe_feng has quit IRC20:10
sdaguewell, it only happens once20:10
dansmithhmm okay20:10
sdagueper live migration20:10
sdaguewhich means something is cleaning it up20:10
sdagueand it's probably it20:10
dansmithI would expect the RT to not dick with other hosts' stuff20:10
dansmiththat's usually not a good thing20:10
mriedemdansmith: it's not new at least in the last week20:10
dansmithmriedem: yeah, I meant like this cycle20:10
*** shaohe_feng has joined #openstack-nova20:10
mriedemwell, there have been some people hacking on migration and resouce tracker20:11
mriedemunder the loving care of jaypipes20:11
*** mgoddard has quit IRC20:12
*** daemontool has joined #openstack-nova20:14
jaypipesI'm still teasing apart these damn pci unit tests :(20:14
*** efried has quit IRC20:14
sdagueI kind of feel like we need a version of Yakety Sax called mockety mocks that you have to play any time you try to unwind our unit tests :)20:17
dansmithsdague: did you look at the grenade fail?20:17
dansmithlooks like everyone lost the mq20:17
sdaguedansmith: which fail?20:17
dansmithsdague: on that ceph fix: http://logs.openstack.org/15/290715/2/check/gate-grenade-dsvm/056bc19/logs/grenade.sh.txt.gz#_2016-03-09_19_21_22_82020:18
dansmithlooks like maybe just during cleanup? but there are mq timeout errors in all the logs20:18
*** jwcroppe has joined #openstack-nova20:19
sdagueso that looks like the oslo.messaging issue which showed up in 4.1.0 that I thought was addressed20:20
*** shaohe_feng has quit IRC20:20
dansmithokay20:20
dansmithso recheck?20:20
*** acabot has quit IRC20:20
*** shaohe_feng has joined #openstack-nova20:20
sdaguecan you update this bug with links to it first - https://bugs.launchpad.net/oslo.messaging/+bug/154500220:21
openstackLaunchpad bug 1545002 in oslo.messaging "Grenade Failure - MessagingTimeout on floating IP remove" [High,New]20:21
*** jwcroppe has quit IRC20:21
dansmithyep20:21
openstackgerritSean Dague proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods  https://review.openstack.org/29013420:24
sdaguemriedem: once more into the breech20:25
*** pumarani__ has quit IRC20:25
sdagueI missed one test20:25
*** pumarani__ has joined #openstack-nova20:25
*** ihrachys has joined #openstack-nova20:25
*** whenry has joined #openstack-nova20:28
mriedemsdague: i saw that, was going to update this afternoon but got sidetracked20:28
mriedemwith ceph and ES health and trove20:28
*** Sukhdev has quit IRC20:29
*** shaohe_feng has quit IRC20:30
sdagueyep, no worries20:30
*** shaohe_feng has joined #openstack-nova20:31
*** whenry has quit IRC20:33
*** efried has joined #openstack-nova20:35
*** ircuser-1 has quit IRC20:36
mriedemsdague: you should add a co-author to https://review.openstack.org/#/c/290134/20:40
*** shaohe_feng has quit IRC20:40
*** shaohe_feng has joined #openstack-nova20:41
*** salv-orl_ has quit IRC20:43
*** burgerk has joined #openstack-nova20:45
dimsdansmith : sdague : i see 5 hits on that grenade timeout problem - http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22cinder_grenade%5C%22%20AND%20message:%5C%22_disassociate_floating_ip%5C%22%20AND%20message:%5C%22MessagingTimeout%5C%22%20AND%20tags:%5C%22screen-n-api.txt%5C%22&from=30d20:46
dimsdansmith : sdague : only thing common between them is they are on build_node devstack-trusty-osic-cloud1-XYZ20:46
dimsdansmith : sdague : seem to have started again on the 7th. and we have not had any oslo.messaging releases for a couple of weeks now20:47
dimsdansmith : are you able to recreate it locally? (so i can go try that)20:48
dansmithdims: I just saw it that once, sdague asked me to paste linkages20:48
dimsdansmith : locally or in the CI?20:49
*** edtubill has quit IRC20:49
*** doug-fish has quit IRC20:49
dansmithdims: in that one job20:50
dimsdansmith : thanks! i am all caught up now :)20:50
mriedemsdague: i'll add it, i have to restack this series on top of alaski's20:50
*** shaohe_feng has quit IRC20:51
*** ircuser-1 has joined #openstack-nova20:51
*** ihrachys has quit IRC20:51
*** shaohe_feng has joined #openstack-nova20:52
*** armax has quit IRC20:53
*** e0ne has quit IRC20:53
bauzasalaski: is my mind correct or we have some cells meeting in a few mins ?20:54
alaskibauzas: we're skipping this week20:54
*** armax has joined #openstack-nova20:54
bauzasoh, correct, that's not like if you sent an email20:54
bauzasI was for once thinking I was masterizing my agenda :'20:54
bauzastoo bad20:54
alaskiwe've got to keep you on your toes20:55
*** pwnall has joined #openstack-nova20:55
*** pumarani__ has quit IRC20:57
*** pushkaru has joined #openstack-nova20:57
tristanCsince I02f8a5f0e29816336e500a8fe8dcc9ece15968e9 has been +workflowed, I proposed backports to stable branch on top of the original fix20:57
*** whenry has joined #openstack-nova20:57
*** haomaiwang has quit IRC21:01
*** shaohe_feng has quit IRC21:01
*** haomaiwang has joined #openstack-nova21:01
openstackgerritjichenjc proposed openstack/python-novaclient: Prepare to move extension into core plugin  https://review.openstack.org/29044821:01
*** shaohe_feng has joined #openstack-nova21:02
*** pushkaru has quit IRC21:02
*** pushkaru has joined #openstack-nova21:02
mriedemtristanC: did you squash those or not?21:04
*** dims has quit IRC21:05
tristanCmriedem: just cherry-pick, mostly to get test result21:05
tristanCand it's also much easier advisories wise since the original patch is likely already merged in downstream branches21:09
*** roeyc has joined #openstack-nova21:11
*** shaohe_feng has quit IRC21:11
*** shaohe_feng has joined #openstack-nova21:12
*** thumpba has quit IRC21:13
*** thumpba has joined #openstack-nova21:14
*** smatzek has quit IRC21:15
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: check for optional LibvirtLiveMigrateData attrs before loading  https://review.openstack.org/28682821:17
openstackgerritMatt Riedemann proposed openstack/nova: Raise VirtNotImplemented for ComputeDriver methods  https://review.openstack.org/29013421:17
*** artom has quit IRC21:17
*** thumpba has quit IRC21:18
*** vladikr has quit IRC21:19
*** markvoelker has quit IRC21:20
*** shaohe_feng has quit IRC21:21
*** shaohe_feng has joined #openstack-nova21:22
*** sdague_ has joined #openstack-nova21:23
*** doug-fish has joined #openstack-nova21:25
*** sheel has quit IRC21:27
mriedemoomichi: rlrossi__ has a question about handling a 403 in basically all of the volume related APIs21:27
mriedemoomichi: as in, is there a way to generically handle a 403 from volume_api in all of the volume REST APIs21:27
*** derekh_afk is now known as derekh21:29
*** thorst__ is now known as thorst_21:30
cfriesen_is there a way to rebuild the volume for a boot-from-volume instance?  I don't think a general "rebuild" would do it.21:30
cfriesen_instance rebuild, I mean21:30
*** gszasz has quit IRC21:31
*** shaohe_feng has quit IRC21:32
*** shaohe_feng has joined #openstack-nova21:32
*** macsz has joined #openstack-nova21:34
*** baoli has joined #openstack-nova21:37
*** dims has joined #openstack-nova21:37
*** tbachman_ has joined #openstack-nova21:42
*** shaohe_feng has quit IRC21:42
*** shaohe_feng has joined #openstack-nova21:43
*** roeyc has quit IRC21:43
*** roeyc1 has joined #openstack-nova21:43
*** tbachman has quit IRC21:45
*** tbachman_ is now known as tbachman21:45
*** yamahata has joined #openstack-nova21:47
openstackgerritNikola Dipanov proposed openstack/nova: Do not reserve device before reserving the volum  https://review.openstack.org/29079321:48
*** cleong has quit IRC21:49
*** macsz has quit IRC21:49
mriedemcfriesen_: there might be some bugs open for that i think21:51
mriedemcfriesen_: rpodolyaka might have been working around that21:51
mriedemcfriesen_: https://bugs.launchpad.net/nova?field.searchtext=volume+rebuild&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&field.assignee=&field.bug_reporter=&field.omit_dupes=on&field.has_patch=&field.has_no_package=21:51
*** rk4n has joined #openstack-nova21:52
*** rtheis has quit IRC21:52
*** shaohe_feng has quit IRC21:52
*** shaohe_feng has joined #openstack-nova21:53
mriedemsee bug 137868921:53
openstackbug 1378689 in OpenStack Compute (nova) "error when rebuilding a instance booted from volume" [Undecided,Confirmed] https://launchpad.net/bugs/137868921:53
*** smatzek has joined #openstack-nova21:53
*** tbachman has quit IRC21:54
*** dims has quit IRC21:56
*** burt has quit IRC21:57
*** ndipanov has quit IRC21:57
*** tbachman has joined #openstack-nova21:57
*** dims has joined #openstack-nova21:58
*** ducttape_ has quit IRC21:59
*** Sukhdev has joined #openstack-nova21:59
*** haomaiwang has quit IRC22:01
*** shaohe_feng has quit IRC22:01
*** ducttape_ has joined #openstack-nova22:01
*** haomaiwang has joined #openstack-nova22:01
*** thorst_ has quit IRC22:02
*** eharney has quit IRC22:04
*** shaohe_feng has joined #openstack-nova22:04
*** thorst_ has joined #openstack-nova22:05
*** dimtruck is now known as zz_dimtruck22:07
*** thorst_ has quit IRC22:09
*** knikolla has quit IRC22:10
*** eharney has joined #openstack-nova22:11
*** shaohe_feng has quit IRC22:13
*** shaohe_feng has joined #openstack-nova22:13
*** Sukhdev has quit IRC22:14
*** sdague_ has quit IRC22:17
*** sdague has quit IRC22:17
*** burgerk_ has joined #openstack-nova22:18
*** jaugustine has quit IRC22:19
*** derekh has quit IRC22:19
*** roeyc1 has quit IRC22:19
*** david-lyle has quit IRC22:19
mriedemrlrossi__: fyi https://review.openstack.org/#/c/288966/22:19
rlrossi__i no22:20
*** dave-mccowan has quit IRC22:20
*** david-lyle has joined #openstack-nova22:20
rlrossi__stop pasting it at me22:20
*** burgerk has quit IRC22:21
*** drankis has quit IRC22:21
*** krtaylor has quit IRC22:23
*** shaohe_feng has quit IRC22:23
*** shaohe_feng has joined #openstack-nova22:24
*** thorst_ has joined #openstack-nova22:24
*** angdraug has joined #openstack-nova22:28
*** dims has quit IRC22:29
*** burgerk_ has quit IRC22:29
*** smatzek has quit IRC22:29
*** mriedem has quit IRC22:31
*** shaohe_feng has quit IRC22:33
*** shaohe_feng has joined #openstack-nova22:34
*** pushkaru has quit IRC22:34
*** dave-mccowan has joined #openstack-nova22:34
*** drankis has joined #openstack-nova22:35
*** yamahata has quit IRC22:35
*** krtaylor has joined #openstack-nova22:36
*** zz_dimtruck is now known as dimtruck22:38
*** zenoway has quit IRC22:38
*** drankis has quit IRC22:39
tristanCdansmith: lyarwood: mdbooth: so, backports of I02f8a5f0e29816336e500a8fe8dcc9ece15968e9 seems ok. could we please merge them after Idfc16f54049aaeab31ac1c1d8d79a129acc9fb87 on stable branch ?  for the record, this is the advisory errata: https://review.openstack.org/29087222:39
dansmithtristanC: it hasn't even landed on master yet, but regardless, it's up to mriedem22:40
*** shaohe_feng has quit IRC22:43
*** shaohe_feng has joined #openstack-nova22:44
*** Sukhdev has joined #openstack-nova22:44
*** dims has joined #openstack-nova22:44
*** Sukhdev has quit IRC22:46
*** rlrossi__ has quit IRC22:46
*** thorst_ has quit IRC22:51
*** thorst_ has joined #openstack-nova22:52
*** RuiChen has joined #openstack-nova22:52
*** shaohe_feng has quit IRC22:54
*** zenoway has joined #openstack-nova22:54
*** shaohe_feng has joined #openstack-nova22:54
*** browne has quit IRC22:55
*** Sukhdev has joined #openstack-nova22:55
*** baoli has quit IRC22:57
*** Sukhdev has quit IRC23:01
*** zenoway has quit IRC23:01
*** pwnall has quit IRC23:01
*** jichen has quit IRC23:01
*** baoli has joined #openstack-nova23:01
*** mariusv has quit IRC23:01
*** lunarlamp is now known as mariusv23:01
*** thorst_ has quit IRC23:01
*** haomaiwang has quit IRC23:01

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!