Wednesday, 2016-02-24

*** haomaiwang has quit IRC00:01
*** haomaiwang has joined #openstack-nova00:01
*** mrkz has quit IRC00:02
*** su_zhang has quit IRC00:02
*** su_zhang has joined #openstack-nova00:03
*** su_zhang has quit IRC00:03
*** su_zhang has joined #openstack-nova00:04
*** vilobhmm11 has joined #openstack-nova00:05
*** su_zhang has quit IRC00:05
*** darrenc_afk is now known as darrenc00:05
*** su_zhang has joined #openstack-nova00:05
*** su_zhang has quit IRC00:06
*** ivase has joined #openstack-nova00:06
*** su_zhang has joined #openstack-nova00:07
*** EinstCrazy has joined #openstack-nova00:10
*** ivase has quit IRC00:11
*** rk4n has joined #openstack-nova00:11
*** ducttape_ has quit IRC00:12
*** eil397 has quit IRC00:13
*** EinstCrazy has quit IRC00:14
*** markvoelker has quit IRC00:15
*** edtubill has joined #openstack-nova00:15
*** Sukhdev has quit IRC00:16
*** Sukhdev has joined #openstack-nova00:17
*** Sukhdev has quit IRC00:18
*** spandhe has quit IRC00:19
*** vilobhmm11 has quit IRC00:19
*** vilobhmm11 has joined #openstack-nova00:20
*** cdent has joined #openstack-nova00:20
*** vilobhmm11 has quit IRC00:21
*** vilobhmm11 has joined #openstack-nova00:21
*** vilobhmm11 has quit IRC00:21
*** vilobhmm11 has joined #openstack-nova00:22
*** zenoway has joined #openstack-nova00:23
cdentjaypipes: given copious free time I'd like to add approximate nearest neighbor (in n-dimensional space) and vector comparisons (via pandas series) strategies to you placement bench stuff. But I'll hold off until I actually have the time to know what I'm doing.00:24
jaypipescdent: cool with me :)00:26
cdentI have mental visual model that I think ought to be resolvable by one of those00:26
cdentbut it's just over the horizon00:26
*** zenoway has quit IRC00:27
*** spandhe has joined #openstack-nova00:28
*** sheel has joined #openstack-nova00:38
*** rfolco has quit IRC00:41
*** rk4n has quit IRC00:41
*** rk4n has joined #openstack-nova00:42
*** diogogmt has joined #openstack-nova00:42
*** cdent has quit IRC00:42
*** rfolco has joined #openstack-nova00:43
*** rfolco has quit IRC00:43
*** markvoelker has joined #openstack-nova00:46
*** zenoway has joined #openstack-nova00:47
*** zenoway has quit IRC00:51
*** hoangcx has joined #openstack-nova00:58
*** ducttape_ has joined #openstack-nova00:59
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-nova01:01
*** Bofu2MBP has quit IRC01:06
*** su_zhang has quit IRC01:07
*** su_zhang has joined #openstack-nova01:07
*** su_zhang has quit IRC01:08
*** kfarr has quit IRC01:08
*** gongysh has joined #openstack-nova01:08
*** su_zhang has joined #openstack-nova01:08
*** zenoway has joined #openstack-nova01:10
*** nic has quit IRC01:13
*** Guest75 has joined #openstack-nova01:13
*** Sukhdev has joined #openstack-nova01:14
*** zenoway has quit IRC01:15
*** mylu has quit IRC01:17
*** armax has joined #openstack-nova01:21
*** zhangyufei has joined #openstack-nova01:25
*** gtt116_ has quit IRC01:28
*** penick has quit IRC01:28
*** su_zhang has quit IRC01:28
*** su_zhang has joined #openstack-nova01:29
*** spandhe has quit IRC01:31
*** su_zhang has quit IRC01:33
*** zenoway has joined #openstack-nova01:34
*** lpetrut has quit IRC01:36
*** dmellado has quit IRC01:36
*** sgordon has quit IRC01:36
*** haomaiwang has quit IRC01:36
*** sgordon has joined #openstack-nova01:37
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/28213601:38
*** zenoway has quit IRC01:38
*** ducttape_ has quit IRC01:42
*** gyee has quit IRC01:46
*** gyee has joined #openstack-nova01:46
*** erlon has quit IRC01:46
*** jwcroppe has joined #openstack-nova01:54
*** rk4n has quit IRC01:55
*** kairo has joined #openstack-nova01:55
*** rk4n has joined #openstack-nova01:56
*** baoli has joined #openstack-nova01:58
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWare> Allocate free bus for new SCSI controller.  https://review.openstack.org/27241401:58
*** Sukhdev has quit IRC01:59
*** dims has quit IRC01:59
*** vilobhmm11 has quit IRC01:59
*** yamahata has quit IRC02:00
*** Sukhdev has joined #openstack-nova02:01
*** Sukhdev has quit IRC02:01
*** zhangyufei has quit IRC02:02
*** rk4n has quit IRC02:02
*** vilobhmm11 has joined #openstack-nova02:03
*** vilobhmm11 has quit IRC02:03
*** vilobhmm11 has joined #openstack-nova02:03
*** rk4n has joined #openstack-nova02:05
openstackgerritWenzhi Yu proposed openstack/nova-specs: Modify Nova API to reject invalid operations on physical servers  https://review.openstack.org/28390402:06
*** vishwanathj has quit IRC02:06
openstackgerritFelix Ma proposed openstack/nova: Catch iscsi VolumeDeviceNotFound when detaching  https://review.openstack.org/26568102:06
*** jdurgin1 has quit IRC02:07
*** pcaruana has quit IRC02:07
*** vilobhmm11 has quit IRC02:12
*** haomaiwang has joined #openstack-nova02:16
*** browne has quit IRC02:16
*** apoorvad has quit IRC02:19
*** pcaruana has joined #openstack-nova02:19
*** apoorvad has joined #openstack-nova02:22
*** ljxiash has joined #openstack-nova02:24
*** vishwanathj has joined #openstack-nova02:26
*** vishwana_ has joined #openstack-nova02:28
*** zhangyufei has joined #openstack-nova02:30
*** vishwanathj has quit IRC02:31
gusjohnthetubaguy/hemna: ok, https://review.openstack.org/#/c/277224/ (os-brick/privsep) works.02:32
*** mgoddard_ has joined #openstack-nova02:32
gusPlease review (and the depends-on changes in cinder+nova).02:33
*** mgoddard has quit IRC02:35
gusI also need a response to my question on https://review.openstack.org/#/c/277670/: sdague/matt riedemann wanted a release note added somewhere in nova (not os-brick), and I'm asking for some clarification over exactly how they want that done given that there isn't (at this stage) a hard requirement anywhere for nova to update to a privsep version of os-brick.02:36
*** houming has joined #openstack-nova02:38
*** Marga_ has quit IRC02:39
*** apoorvad has quit IRC02:45
*** zz_dimtruck is now known as dimtruck02:47
*** mingyu has quit IRC02:51
*** mingyu has joined #openstack-nova02:51
*** dmellado has joined #openstack-nova02:54
*** rk4n has quit IRC02:54
*** vilobhmm11 has joined #openstack-nova02:59
openstackgerritWenzhi Yu proposed openstack/nova: Make sure destination will rollback if live migration fails  https://review.openstack.org/27009303:00
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-nova03:01
*** pcaruana has quit IRC03:01
*** gongysh has quit IRC03:02
*** jyuso1 has joined #openstack-nova03:03
*** hoangcx has quit IRC03:06
*** dmellado has quit IRC03:06
*** zhangyufei has quit IRC03:06
*** zhangyufei has joined #openstack-nova03:07
*** browne has joined #openstack-nova03:09
*** dmellado has joined #openstack-nova03:11
*** dims has joined #openstack-nova03:13
*** pcaruana has joined #openstack-nova03:16
*** gongysh has joined #openstack-nova03:19
*** haomaiwang has quit IRC03:20
*** dmellado has quit IRC03:22
*** salv-orlando has joined #openstack-nova03:26
*** salv-orlando has quit IRC03:28
*** salv-orl_ has quit IRC03:29
*** unicell has quit IRC03:33
*** liusheng has quit IRC03:34
*** liusheng has joined #openstack-nova03:34
*** davideagle has quit IRC03:35
*** mylu has joined #openstack-nova03:36
*** gyee has quit IRC03:37
*** hoangcx has joined #openstack-nova03:41
*** dmellado has joined #openstack-nova03:45
*** links has joined #openstack-nova03:46
*** boris-42 has quit IRC03:54
*** baoli has quit IRC03:55
*** ducttape_ has joined #openstack-nova03:58
*** irenab has quit IRC03:59
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/28213603:59
*** irenab has joined #openstack-nova04:00
*** kairo has quit IRC04:00
*** pcaruana has quit IRC04:01
*** dmellado has quit IRC04:01
*** gongysh has quit IRC04:02
*** mylu has quit IRC04:02
*** baoli has joined #openstack-nova04:03
*** liusheng has quit IRC04:03
*** zhangyufei has quit IRC04:03
*** wanghao has quit IRC04:04
*** vilobhmm11 has quit IRC04:04
*** wanghao has joined #openstack-nova04:05
*** mylu has joined #openstack-nova04:06
*** mylu has quit IRC04:12
*** pcaruana has joined #openstack-nova04:15
*** ducttape_ has quit IRC04:15
*** thorst has joined #openstack-nova04:16
*** mylu has joined #openstack-nova04:16
*** thorst has quit IRC04:20
*** thorst has joined #openstack-nova04:20
*** thorst has quit IRC04:20
*** thorst has joined #openstack-nova04:21
*** ljxiash has quit IRC04:24
*** mylu has quit IRC04:25
*** dmellado has joined #openstack-nova04:26
*** sheel has quit IRC04:27
*** baoli has quit IRC04:28
*** baoli has joined #openstack-nova04:29
*** thorst has quit IRC04:30
*** dimtruck is now known as zz_dimtruck04:35
*** hoangcx has quit IRC04:35
*** Marga_ has joined #openstack-nova04:36
*** mylu has joined #openstack-nova04:38
*** dmellado has quit IRC04:38
*** baoli has quit IRC04:39
*** Marga_ has quit IRC04:40
*** Marga_ has joined #openstack-nova04:43
*** mubirru has joined #openstack-nova04:45
jgriffithjohnthetubaguy: hemna FYI I'm working on a patch for Cinder to help with the "stuck in detach" issue that you guys have been discussing on the ML04:46
jgriffithjohnthetubaguy: hemna hope to have something up for review tomorrow, I'll give you a shout04:47
*** penick has joined #openstack-nova04:48
*** sridharg has joined #openstack-nova04:50
*** penick_ has joined #openstack-nova04:50
*** penick has quit IRC04:53
*** penick_ is now known as penick04:53
*** harlowja_at_home has quit IRC04:53
*** jamielennox is now known as jamielennox|away04:54
*** Marga_ has quit IRC04:57
*** Marga_ has joined #openstack-nova04:58
*** garyk has joined #openstack-nova05:00
*** dmellado has joined #openstack-nova05:03
*** haomaiwang has joined #openstack-nova05:04
*** amotoki has joined #openstack-nova05:05
*** jwcroppe has quit IRC05:10
*** zhangjn has quit IRC05:14
*** mingyu has quit IRC05:17
*** mingyu has joined #openstack-nova05:18
*** unicell has joined #openstack-nova05:20
*** zhangjn has joined #openstack-nova05:20
*** sudipto has joined #openstack-nova05:25
*** hoangcx has joined #openstack-nova05:26
*** liverpooler has quit IRC05:27
*** thorst has joined #openstack-nova05:27
*** zhangyufei has joined #openstack-nova05:30
openstackgerritFeng Xi Yan proposed openstack/nova: <VMWARE> Add power state cache for host init and power state sync.  https://review.openstack.org/24200605:32
*** thorst has quit IRC05:34
*** zhangyufei has quit IRC05:36
*** salv-orlando has joined #openstack-nova05:36
*** gcb has quit IRC05:37
*** mylu has quit IRC05:37
*** pcaruana has quit IRC05:38
*** mylu has joined #openstack-nova05:39
*** chhavi has joined #openstack-nova05:40
openstackgerritJianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using XenServer + Neutron  https://review.openstack.org/24284605:41
*** qeelee has joined #openstack-nova05:42
*** Jeffrey4l has joined #openstack-nova05:44
*** mylu has quit IRC05:45
*** ijw has quit IRC05:46
*** dims has quit IRC05:48
*** salv-orlando has quit IRC05:49
*** ljxiash has joined #openstack-nova05:49
*** pcaruana has joined #openstack-nova05:53
*** zhangyufei has joined #openstack-nova05:56
*** liusheng has joined #openstack-nova05:56
*** gcb has joined #openstack-nova05:58
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-nova06:01
*** vilobhmm11 has joined #openstack-nova06:02
*** gongysh has joined #openstack-nova06:02
*** ekuris has joined #openstack-nova06:05
*** gongysh has quit IRC06:05
openstackgerritAlex Xu proposed openstack/nova: Generate better validation error message when using name regexes  https://review.openstack.org/28114306:08
*** irenab_ has joined #openstack-nova06:14
*** gongysh has joined #openstack-nova06:15
*** fawadkhaliq has joined #openstack-nova06:15
*** gongysh has quit IRC06:16
*** nkrinner has joined #openstack-nova06:16
*** irenab has quit IRC06:17
*** irenab_ is now known as irenab06:17
*** sridharg has quit IRC06:17
*** tyagiprince has joined #openstack-nova06:18
tyagiprinceHey everyone. In nova.conf, I made this config change. "osapi_compute_unique_server_name_scope = project"06:19
tyagiprinceI tried spawning instances with same instance name. In some openstack setup, it works and in others it doesn't work.06:20
tyagiprinceCan someone please tell me why is this happening?06:20
*** openstack has joined #openstack-nova13:21
sdaguePaulMurray: oh, sorry, wrong tab13:21
sdagueyes13:21
sdagueyou are correct, it's not landed13:22
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183713:22
PaulMurrayat least I'm in a known state now !13:22
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183713:22
sdagueihrachys: I think that boot image by tag from nova creates a lot more ambiguity and potential randomness13:22
openstackgerritChris Dent proposed openstack/nova: Add name to ResourceProvider object  https://review.openstack.org/28194513:23
ihrachyssdague: the assumption would be that there is only one tagged image; if more, fail as you do for multiple hits for the same name.13:23
*** subscope has quit IRC13:24
sdagueif glance had a facility that was unique enforced on it's side for a stable label, using that would be fine13:24
sdaguebut inventing that in a bunch of convention on tags seems really complicated and potentially breaking long term13:24
ihrachyssdague: is your concern just for nova or you think issues for other projects that could take the approach?13:25
sdaguebasically, I don't want nova getting into this guessing game, and having a junior admin tag a new image on upload then everything fall appart because it's not unique13:25
*** Guest65788 has quit IRC13:25
sdagueI think that imageRef is a known, stable, unique identifier13:25
sdaguewe should boot by something that's known unique13:26
*** rods has joined #openstack-nova13:26
ihrachyssdague: yeah I understand your compexity concern for nova. though for octavia we would still need to handle it somehow, and the glance tag could be a solution.13:26
sdagueit could be, however in an ideal world glance would have something else in place that would let you ask for a stable lable13:27
sdaguefor instance 'RHEL 7.0 base'13:27
ihrachyssdague: yeah, like mark a tag as unique when mapping it, then allowing to atomically switch it13:27
Yingxinjaypipes: really? what a terrible mistake13:27
*** edmondsw has joined #openstack-nova13:27
sdagueihrachys: well, honestly, your concern is the provider is reving an image right, and it gets a new id every time13:28
sdagueright?13:28
ihrachyssdague: yeah. every new version of the image is new id that we need to change in config file and restart to apply13:28
jaypipesYingxin: it's cool, just letting you know :)13:28
sdaguewhich I think is a very valid concern, and it would be nice if there was a construct of 'label' 'version'13:28
sdaguelable + version being forced unique13:29
sdagueso you can always ask for newest of label13:29
*** qeelee has quit IRC13:29
sdaguewhich is all a bunch of stuff that doesn't exist, but seems to be what you really want13:29
sdaguethat you might be able to hack together a 70% solution with tags13:30
ihrachysright, that would be ideal.13:30
sdagueif glance did that, I think having nova support it is a no brainer13:30
sdaguebut the 30% failure space on the tags overload leads you into some really confusing situations for users13:31
*** 32NAAD4T7 has quit IRC13:31
sdagueso I wouldn't want that in nova13:31
ihrachysyeah. I may need to work with glance folks on long term and maybe bake something with what I have now in short term. the latter won't probably belong to nova, agreed.13:32
ihrachysand later if we get uniqueness feature, we may want to reconsider it for nova.13:32
*** ildikov has quit IRC13:33
*** zhangjn has quit IRC13:33
sdagueihrachys: ++13:37
*** vladikr has joined #openstack-nova13:37
*** shyama has joined #openstack-nova13:38
sahidndipanov, danpb when you have a moment can you ack this change https://review.openstack.org/#/c/277422/13:38
*** mgoddard__ has joined #openstack-nova13:38
*** zhangjn has joined #openstack-nova13:38
*** mubirru has quit IRC13:39
*** dims has joined #openstack-nova13:40
*** mgoddard_ has quit IRC13:41
PaulMurrayandreykurilin, hi - are you working on https://review.openstack.org/#/c/278454/13:42
*** atuvenie__ has joined #openstack-nova13:42
*** chhavi has joined #openstack-nova13:43
andreykurilinPaulMurray: hi! imo, this patch is finished:) I will talk with mriedem when he will be available. About mentioned bug - I'll post a fix in separate patch in few hours13:44
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183713:44
*** amotoki has joined #openstack-nova13:44
johnthetubaguyihrachys: FWIW, I think we need those features in glance, so we can build well know names on top of that, so you can say "give me the latest Ubuntu 12.04 LTS please", and have that mean the same thing on all certified OpenStack clouds, but I can't say I have got very far with pushing that yet13:44
PaulMurrayandreykurilin, we have patches chained up behind you - will your fix affect those ?13:45
bauzasYingxin: jaypipes: shall I mention my name too ? :D13:45
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183713:45
*** atuvenie has quit IRC13:45
ihrachysjohnthetubaguy: do we have any patches uploaded?13:45
*** ccarmack has joined #openstack-nova13:46
johnthetubaguyihrachys: don't even have a spec for that at this point, AFAIK, its just an idea I was talking about on the defcore list, a little bit back, not had chance to move that any further forward sadly.13:46
*** shaohe_feng_ has joined #openstack-nova13:47
andreykurilinPaulMurray: I can put it to start of chain13:47
johnthetubaguyihrachys: well I presented the approach at the hong kong summit, just just not had chance to move it forward13:47
*** EinstCrazy has joined #openstack-nova13:47
*** porunov has joined #openstack-nova13:47
shaohe_feng_johnthetubaguy:  sdague :  ping13:48
PaulMurrayandreykurilin, I'll track what's going on with your patch - I need to get the whole chain merged by friday :)13:48
jaypipesbauzas: I had been calling you "Sil-vane" for a long time until I learned it was pronounced "Sil-vaaan". I have been suitably corrected.13:48
bauzasheh13:48
bauzasjaypipes: don't ask alaski how many times I tried to say "Andrew"13:49
shaohe_feng_johnthetubaguy:  sdague : I want to talk about https://review.openstack.org/#/c/258771/27/nova/api/openstack/compute/server_migrations.py13:49
andreykurilinPaulMurray: It would be nice to merge the whole chain as soon as possible:)13:50
openstackgerritChris Dent proposed openstack/nova: Add name to ResourceProvider object  https://review.openstack.org/28194513:50
shaohe_feng_johnthetubaguy: sdague: so I the flavor should be like:          "flavor": {             "id": "1",             "links": [                 {                     "href": "http://openstack.example.com/openstack/flavors/1",                     "rel": "bookmark"                 }             ]         },13:51
sdagueshaohe_feng_: right, that "id" isn't the same id as used by migrations13:51
PaulMurrayjaypipes, for max amusement value ask bauzas to say:13:51
PaulMurrayTheophilus Thistle, the successful thistle sifter,13:51
PaulMurrayIn sifting a sieve full of un-sifted thistles,13:51
PaulMurrayThrust three thousand thistles through the thick of his thumb.13:51
PaulMurrayIf Theophilus Thistle, the successful thistle sifter,13:51
PaulMurrayCan thrust three thousand thistles through the thick of his thumb,13:51
PaulMurraySee that thou, in sifting a sieve full of un-sifted thistles,13:51
PaulMurrayThrust not three thousand thistles through the thick of thy thumb.13:51
bauzasoh man13:51
jaypipesrofl13:52
ihrachysjohnthetubaguy: seems like a feature that would be interesting for multiple projects. I gotta talk to glance folks for sure. :)13:52
Bobbatonyb: You happy with the comments on https://review.openstack.org/#/c/281341/ regarding the CI?  I imagine that a -1 might just filter things out for you :)13:52
shaohe_feng_sdague: should I give the ref link also?13:52
sdagueshaohe_feng_: well, lets step back for a minute13:52
bauzasPaulMurray: les chaussettes de l'archiduchesse sont-elles sèches, archi-sèches?13:52
sdagueare the old_/new_ flavor ids actually useful in this case?13:52
*** zenoway has quit IRC13:53
sdaguebecause in live migration they are always the same, right?13:53
sdagueI kind of wonder if we just delete them entirely from representation for now13:53
johnthetubaguysdague: good point, thats for resize, dropping them is probably best13:53
johnthetubaguysdague: I wonder if there are other things in there too, now you mention it13:54
sdaguejohnthetubaguy: maybe, everything else seems kind of useful13:54
johnthetubaguyyeah, it does13:54
johnthetubaguyjust double checked13:54
*** sudipto has joined #openstack-nova13:55
sdagueshaohe_feng_: would deleting those fields cause any other issues you see?13:55
shaohe_feng_sdague: johnthetubaguy: we still need old_/new_ flavor field, but without id?13:55
johnthetubaguyI think just drop it, for now13:55
sdagueshaohe_feng_: why do you need to return it to the user?13:55
shaohe_feng_sdague: we do not need it, user can git it by the showserver \13:56
sdagueshaohe_feng_: right13:56
shaohe_feng_sdague: IMHO13:56
sdagueso how about we delete them from the REST representation here13:56
shaohe_feng_sdague: agree.13:56
sdagueand I think that removes my final concern, then I'm +2 on the patch13:56
*** eharney has joined #openstack-nova13:57
sdagueshaohe_feng_: so if you want to respin that, I think we are good13:57
shaohe_feng_sdague: OK. let remove the flavor field.13:58
jaypipescdent: doh, should be migrate_engine.connect() :)13:58
*** ildikov has joined #openstack-nova13:58
*** atuvenie__ has quit IRC13:58
cdentYeah, I fixed that13:58
cdentjaypipes: then that led to the DDL being wrong13:58
cdentbut I think I've fixed that too13:58
jaypipesheh13:58
shaohe_feng_sdague: will ping you after I update it,13:59
sdagueshaohe_feng_: sounds great, thank you13:59
jaypipesI think the Intel PCI CI is just dead.13:59
sdaguejaypipes: has it ever been really alive?14:00
johnthetubaguyjaypipes: I think mikal was trying to help those folks, not sure where that is at right now14:00
*** haomaiwa_ has quit IRC14:01
*** salv-orlando has joined #openstack-nova14:01
*** haomaiwang has joined #openstack-nova14:01
*** cfriesen has joined #openstack-nova14:01
PaulMurrayndipanov, I know pci passthrough doesn't work with live migration - does it work with cod migration (I've seen a couple of bugs about this)14:01
ndipanovPaulMurray, yes14:01
*** rfolco has joined #openstack-nova14:01
ndipanover14:01
ndipanovpci passthrough14:02
ndipanovno :(14:02
ndipanovI think not reliably no14:02
*** xyang1 has joined #openstack-nova14:02
ndipanovjaypipes, so there was a bug that was killing it that I quickly tried to fix14:02
ndipanovjaypipes, I think it was the same thing - NFV CI right?14:02
ndipanovjaypipes, never got much love after the patches were posted:14:03
ndipanovhttps://review.openstack.org/#/c/281483/14:03
ndipanov(hint: give it love)14:03
*** mdrabe has joined #openstack-nova14:03
jaypipesndipanov: k, will take a looksie shortly.14:03
ndipanovah so PCI CI is not the same thing14:04
*** efoley__ has joined #openstack-nova14:04
ndipanovstill both are useful14:04
*** tyagiprince has quit IRC14:04
*** dimtruck is now known as zz_dimtruck14:05
*** efoley_ has quit IRC14:06
*** edtubill has joined #openstack-nova14:06
*** ctrath has joined #openstack-nova14:07
*** salv-orlando has quit IRC14:08
*** ljxiash has joined #openstack-nova14:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Trying latest oslo.* from master  https://review.openstack.org/27520114:10
*** rtheis has joined #openstack-nova14:13
*** mriedem has joined #openstack-nova14:14
rtheisIs there a nova.conf configuration to accept ssh host keys by default for live migration?14:14
*** rlrossit_ has joined #openstack-nova14:17
Yingxinbauzas: :P14:18
*** jaosorior has quit IRC14:18
*** zenoway has joined #openstack-nova14:18
*** jaosorior has joined #openstack-nova14:19
*** bklei has joined #openstack-nova14:19
*** BharatK has joined #openstack-nova14:20
*** gmann_ has joined #openstack-nova14:21
dave-mccowanhello nova devs.  i have a question about the use_forwarded_for setting.  i want my nova-api.log to show the passed client address.  when i set use_forwarded_for = true, it does.  are there any other consequences (good or bad) to using this setting?14:22
*** ivase has joined #openstack-nova14:23
*** ociuhandu has quit IRC14:24
*** ivase has quit IRC14:25
*** ivase has joined #openstack-nova14:25
*** ociuhandu has joined #openstack-nova14:25
alaskibauzas: heh. it's mostly that you say it with an accent, not that it's wrong14:28
bauzasWAT? I do have an accent when speaking ? orly ? :D14:28
pkoniszewskirtheis: there isn't one or i'm not aware of that14:29
rtheisthanks14:30
sdaguemriedem: https://review.openstack.org/#/c/282012/ respun again. And to help with https://review.openstack.org/#/c/283837 I'm starting to try to unwind the craziness of sending the microversion on every method call explicitly14:32
*** smatzek_ has quit IRC14:32
mriedemsdague: ok, looking14:33
mriedemsdague: so on https://review.openstack.org/#/c/282012/5..6/nova/tests/functional/regressions/test_bug_1522536.py14:34
mriedemare these changes going to be running against v2.1 on v2.1 or v2.latest on v2.1?14:34
*** dedery_ has joined #openstack-nova14:34
sdaguev2.1 on v2.114:34
mriedemb/c i'd think for the tests to be useful, they should test against v2.latest to sniff out issues before they are merged14:34
*** shyama has quit IRC14:35
*** EinstCrazy has quit IRC14:35
sdaguethat assumes that there are changes between base and that14:35
sdagueI think if we want to do that later, that's fine. I don't think these tests are only useful if they run against v2.latest14:37
sdaguebecause in all the bugs I've been working at so far, they expose on all versions14:37
*** dedery has quit IRC14:38
mriedemi guess my thought process was for this list deleted instances thing, if we had a functional test for that which was testing against 2.1 it would be fine, but 2.16 broke it14:39
sdaguesure, which I think we know there14:39
mriedemso i'll add the test for 2.16, and that will handle regressions up to 2.1614:39
sdagueyeh14:40
mriedembut not if like 2.35 breaks something14:40
sdagueright, that's true. It's all trade offs14:40
*** rtheis has quit IRC14:40
mriedemwhat's not a trade off was making my 4 year old watch this with me last night http://www.rottentomatoes.com/m/krull/14:41
*** rtheis has joined #openstack-nova14:41
*** sc68cal has joined #openstack-nova14:41
sdaguebecause v2.latest would mean if someone broke common code that made v2.11 break, but work in v2.35 it would miss that14:41
sdaguenice14:41
pkoniszewskijohnthetubaguy: just FYI, i've uploaded review per my AR from yesterdays live migration meeting (fix force_complete according to API guideline) - https://review.openstack.org/#/c/284068/14:42
sdaguemriedem: I'm going to work through getting api_version out of the param list for the client right now14:42
*** diogogmt has quit IRC14:42
*** dedery_ has quit IRC14:42
sdagueyou can stack on top of that once I get it done14:42
*** dedery has joined #openstack-nova14:42
*** rtheis has quit IRC14:42
mriedemalright14:43
*** rtheis has joined #openstack-nova14:43
*** diogogmt has joined #openstack-nova14:44
openstackgerritPawel Koniszewski proposed openstack/nova: Fix return codes in force_complete API  https://review.openstack.org/28406814:45
sdaguealthough now I'm trapped in the massive land of over optimizing test cases through a ton of private methods .... :(14:45
openstackgerritShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations  https://review.openstack.org/25877114:46
*** Daisy_ has joined #openstack-nova14:46
mriedemsdague: you need the glaive14:47
*** armax has quit IRC14:47
mriedemit's easily accessible in a mountain climb, plus cave with river of fire14:47
* mriedem plans on referencing back to krull today14:48
sdagueheh14:48
shaohe_feng_sdague: johnthetubaguy : https://review.openstack.org/25877114:48
shaohe_feng_thanks14:48
pkoniszewskishaohe_feng: why did u remove flavor ids completely? it is part of a response in specification14:49
sdagueshaohe_feng_: you have to update the docs and samples14:50
*** claudiub|2 has joined #openstack-nova14:50
shaohe_feng_sdague: OK, have update the docs and sample14:51
shaohe_feng_s14:51
shaohe_feng_pkoniszewski:  will update the doc14:51
shaohe_feng_pkoniszewski: sorry, will update the spec14:51
sdaguepkoniszewski: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-02-24.log.html#t2016-02-24T13:52:4314:51
sdaguethe fields that were exposed were not useful14:52
sdagueand actually problematic because they leak out an index field that is never exposed to the user, and something they can't do anything with14:52
pkoniszewskisdague: it makes sense, just asking because it is still part of a spec, thanks!14:52
sdaguepkoniszewski: right, it was caught late in review14:52
*** claudiub has quit IRC14:53
shaohe_feng_pkoniszewski: thanks for reminder.14:53
sdaguegibi: you about?14:53
*** rlrossit_ has quit IRC14:53
*** rlrossit has joined #openstack-nova14:53
sdaguebecause I'm having a hard time making your test_server_group tests work if we set global microversion per test14:53
shaohe_feng_sdague: have update the doc and samples. Thanks for  remind14:55
*** rhagarty_ has quit IRC14:55
smcginnismriedem: Krull references? Really? :)14:56
bjornarHow can I disable the "rados df" on each compute host?14:56
openstackgerritPawel Koniszewski proposed openstack/nova: Fix return codes in force_complete API  https://review.openstack.org/28406814:56
rlrossitsmcginnis: don't encourage him14:57
smcginnisrlrossit: haha14:58
*** Daisy_ has quit IRC14:59
*** mtanino has joined #openstack-nova14:59
*** mrkz has joined #openstack-nova14:59
*** Daisy has joined #openstack-nova15:00
cfriesenAnyone here in touch with Phil Day?  I've proposed a fix to some changes he made around min_count and network quota constraints:  https://review.openstack.org/#/c/283861/115:00
*** rtheis has quit IRC15:00
*** smatzek_ has joined #openstack-nova15:00
*** haomaiwang has quit IRC15:01
*** ducttape_ has joined #openstack-nova15:01
*** rtheis has joined #openstack-nova15:01
*** armax has joined #openstack-nova15:01
*** haomaiwang has joined #openstack-nova15:01
*** diogogmt has quit IRC15:01
dansmithalaski: what is your feeling on this? https://review.openstack.org/#/c/282520/5//COMMIT_MSG15:02
*** jdillaman has quit IRC15:02
*** smatzek__ has joined #openstack-nova15:02
*** efoley__ has quit IRC15:02
*** krtaylor has quit IRC15:02
*** rtheis has quit IRC15:03
*** rtheis has joined #openstack-nova15:03
*** efoley__ has joined #openstack-nova15:03
shaohe_feng_jaypipes: pingt15:03
shaohe_feng_jaypipes: ping15:03
mriedemis anyone else seeing a bunch of these in tests now?15:04
mriedemObjectActionError: Object action obj_load_attr failed because: attribute id not lazy-loadable15:04
shaohe_feng_jaypipes: the unit is bytes. they are come from libvirt. libvirt are byte.15:04
sdaguejaypipes: really, you are -1ing for commit message typos?15:05
jaypipessdague: no.15:05
*** Daisy has quit IRC15:05
*** smatzek_ has quit IRC15:05
jaypipessdague: I am -1'ing because the REST API does not tell the user what the unit of measurement is.15:05
sdagueok15:05
jaypipessdague: please read my review comment.15:05
*** betherly_ is now known as betherly15:06
sdagueI read the inline bit, gerrit shows that first15:06
dansmithmriedem: link15:06
dansmith?15:06
jaypipesshaohe_feng: please do not leak libvirt specifics or tribal knowledge out of the public REST API. There is no way a user would know what unit of measurement that is.15:06
mriedemdansmith: this is local, but someone else was complaining about a unit test of theirs failing15:07
shaohe_feng_jaypipes: any suggestion to improve the patch?15:07
mriedemlogstash isn't showing me anything though15:07
sdaguejaypipes: so you would be happy with memory_units and disk_units ?15:07
dansmithmriedem: okay, yeah, haven't seen that15:08
jaypipessdague: no. I would be happy with memory_total_bytes and memory_processed_bytes15:08
*** salv-orlando has joined #openstack-nova15:08
sdaguejaypipes: in most cases the important bit is progress, not raw.15:08
jaypipessdague: same for disk.15:08
jaypipessdague: I actually thought memory_total was pages, not bytes. there's no way to know unless you have tribal knowledge of libvirt.15:08
jaypipessdague: thus my request to simply add the unit of measurement to the field names in the output.15:08
sdagueok, that's fair15:08
dansmithwhich patch is this? I'll -1 for the commit message typos :)15:09
jaypipesdansmith: instigator.15:09
dansmithjaypipes: s/instigator/connoisseur/15:09
mriedemapparently my functional test is hitting a 500 when deleting the instances15:09
mriedemlooks like some rpc stuff isn't stubbed out15:09
sdaguemriedem: I can look in a little bit, I'm trying to figure out this other unwind first15:10
*** burgerk has joined #openstack-nova15:12
*** krtaylor has joined #openstack-nova15:14
*** sridharg has quit IRC15:14
*** Swami has joined #openstack-nova15:14
sdaguedansmith: when did force down land?15:15
dansmithsdague: which part?15:15
bauzasgibi: around ?15:15
sdague the api15:15
dansmithI want to say liberty15:15
sdagueyep, 2.1115:15
sdaguethat's why gibi's tests in server_groups don't work15:15
*** lyanchih has joined #openstack-nova15:15
sdaguebecause he's using 2.15 behavior but not accounting for 2.11 changes15:16
bauzasgibi: I wonder if we have any problem with https://github.com/openstack/nova/blob/master/nova/test.py#L143-L159 when a method we want to mock is already decorated15:16
*** ivase_ has joined #openstack-nova15:16
bauzaslike with functools.wrap15:16
sdaguebauzas: you should delete that code15:16
sdaguemock already does that now15:17
ansiwenthe metadata caching conflicts with the lazy loading of - for example - flavor of the instance. the object is cached without it, resulting in a database request for each request.15:17
sdagueautomatically15:17
bauzassdague: kewl15:17
*** ivase has quit IRC15:17
ansiwenanyway I don't quite understand why it makes sense to store deep copies of python objects in memcached.15:18
*** atuvenie__ has joined #openstack-nova15:18
ansiweninstead of fixing I'd rather remove it15:18
*** rhagarty has joined #openstack-nova15:19
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [microversions] fix help msg for versioned args  https://review.openstack.org/28418615:20
andreykurilinmriedem: hi! can we discuss your comment to https://review.openstack.org/#/c/278454 ?15:21
alaskidansmith: on which part of https://review.openstack.org/#/c/282520/5//COMMIT_MSG ? From what I've seen I agree that we won't need a nova-manage command for the migration. I also think it will slow the first scheduler restart but I'm not convinced it will be a problematic slowdown15:21
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183715:23
cdentjaypipes: le sigh, still have nitpicky things to get that mysql specific aspect of the migration to go, but maybe nearly there15:23
dansmithalaski: wondering if you think the slow start will be a problem (worth worrying about)15:24
johnthetubaguyI guess its only one per agregate?15:25
johnthetubaguywhich at least isn't per host15:25
dansmithjohnthetubaguy: correct15:25
*** gszasz has quit IRC15:25
*** rtheis has quit IRC15:25
*** BharatK has quit IRC15:25
dansmithjohnthetubaguy: if you had a lot of aggregates, then it would be a thing, but I don't think having a million aggregates is likely15:25
mriedemsdague: well i don't know what i did, but now my test is passing15:25
dansmithjohnthetubaguy: or even a thousand15:25
mriedemthink i had to start the consoleauth service for some reason15:26
*** rtheis has joined #openstack-nova15:26
sdaguemriedem: really?15:26
sdaguethat seems odd15:26
mriedemthe integrated test base does that15:26
mriedemand i was seeing errors in the console service15:26
mriedemmessaging timeout (because it wasn't running i guess)15:26
sdaguemriedem: sure, but what were you triggering that would need that15:26
sdaguethat's the thing I'm confused by15:26
*** rtheis has quit IRC15:26
mriedemshrug15:26
*** rtheis has joined #openstack-nova15:27
alaskidansmith: I don't think it's going to be a problem because I agree that it's very unlikely someone will have a large number of aggregates. I think we mention it in a releasenote/doc and move on15:28
dansmithroger15:28
johnthetubaguyalaski: that sounds good15:28
*** zz_dimtruck is now known as dimtruck15:28
*** penick has joined #openstack-nova15:29
*** dims has quit IRC15:29
*** salv-orlando has quit IRC15:29
*** gszasz has joined #openstack-nova15:29
dansmithalaski: bauzas: so a reno in this?15:29
dansmithpatch15:29
bauzasdansmith: alaski: yeah hence my +215:30
bauzasdansmith: alaski: I don't want to block, just commenting out that we probably would need to document that15:30
openstackgerritMatt Riedemann proposed openstack/nova: WIP: add functional regression test for bug 1548980  https://review.openstack.org/28383715:30
openstackbug 1548980 in OpenStack Compute (nova) "nova list --deleted as admin fails with 404" [High,In progress] https://launchpad.net/bugs/1548980 - Assigned to Matt Riedemann (mriedem)15:30
mriedemsdague: ^ that passes now15:30
*** dims has joined #openstack-nova15:30
alaskidansmith: bauzas yep, reno seems appropriate15:30
dansmithbauzas: what reno category?15:30
bauzasdansmith: alaski: like saying in a reno 'upgrade' : if you have a lot of aggregates, the initial scheduler restart will take a bit of time15:31
bauzasdansmith: I think 'upgrades'15:31
dansmithokay15:31
bauzasit's not an issue15:31
bauzasneither a feature15:31
*** annasort has quit IRC15:31
sdaguemriedem: did it explode on the delete?15:32
bauzasdansmith: what's cool with that is that you won't need to add a nova-manage15:32
dansmithyeah15:32
mriedemsdague: yeah15:32
openstackgerritMatt Riedemann proposed openstack/nova: Add functional regression test for list deleted instances on v2.16  https://review.openstack.org/28383715:32
mriedemthat's what it was failing on15:32
bauzasdansmith: just restarting the scheduler will update all the aggregates, so there will be no need to really have some backwards compat15:32
*** atuvenie__ has quit IRC15:32
bauzasdansmith: and I don't except to see a lof of time for that, because it's just an update for a single column15:33
sdaguemriedem: hmmmm... curious15:33
mriedemsdague: https://review.openstack.org/#/c/283837/2..4/nova/tests/functional/regressions/test_bug_1548980.py15:33
openstackgerritDan Smith proposed openstack/nova: Allocate uuids for aggregates as they are created or loaded  https://review.openstack.org/28252015:34
mriedemi might have had the api versions screwed up, idk, but only thing i can think of was starting the consoleauth service,15:34
dansmithalaski: bauzas ^15:34
sdaguemriedem: ok, I want to poke at that to understand a bit more once I get this other thing cleaned up15:34
*** erno has quit IRC15:34
*** rtheis has quit IRC15:34
*** burt has quit IRC15:34
mriedemi'll comment that out and see if it starts failing again15:34
sdaguejust so I can figure out if consoleauth should be in the generic list for an OpenStackCloud fixture pattern15:34
*** dims has quit IRC15:34
*** krtaylor has quit IRC15:34
sdagueif we need it for deletes, it seems like yes15:35
*** burt has joined #openstack-nova15:35
*** rtheis has joined #openstack-nova15:35
*** burt has quit IRC15:35
*** rhagarty_ has joined #openstack-nova15:36
mriedemsdague: yup http://paste.openstack.org/show/488037/15:36
mriedemyou have to have the consoleauth service for deletes15:36
sdagueok, good to know. Do we know why? Are we issuing a cleanup for consoles?15:37
mriedem_clean_instance_console_tokens15:37
mriedemyes15:37
sdagueoh, yep15:37
mriedemFile "nova/compute/manager.py", line 5435, in _clean_instance_console_tokens15:37
*** rhagarty has quit IRC15:37
mriedemhonestly i'm tempted to just extend the _IntegratedTestBase which already does all of this setup for me15:38
sdagueok, I'm satisfied with that answer15:38
sdaguemriedem: no no no.15:38
mriedemi knew you'd say that15:39
sdagueI'm going to build some fixtures here15:39
*** yamahata has joined #openstack-nova15:39
sdagueit will get prettier15:39
mriedemSeansFunctionalTestRegressionFixtureFTW15:39
sdaguethe subclass craziness has to end, because it's so hard to unwind15:39
cdentbless you sdague15:40
scottdaildikov: I've started an etherpad for cinder-nova api changes: https://etherpad.openstack.org/p/cinder-nova-api-changes15:40
cdentinheritance is evil15:40
cdentsometimes15:40
ildikovscottda: cool, thanks much15:40
*** efoley__ has quit IRC15:40
openstackgerritgaryk proposed openstack/nova: VMware: make the opaque network attachment more robust  https://review.openstack.org/28412115:40
sdaguecdent: in tests, most of the time15:41
mriedemcdent: yeah that whole DRY idea is crazy....15:41
cdentmriedem: composition not inheritance15:42
cdentand, actually, DRY in tests is pretty bogus15:42
cdentbecause the last thing you want tin a test is magic action at a distance15:42
mriedemi guess...until you're like me and banging your head against why your test is failing, but the functional test base already has that handled15:43
mriedemanyway, ignore me15:43
*** burt has joined #openstack-nova15:43
dansmithexcept when you have a toooon of tests that statically encode the dict representation of some structure,15:43
dansmithwhich requires a thousand fixes when you tweak that slightly15:43
dansmithwhich encourages people to not change it to make it better, or do things in the real code so the tests won't fail15:43
dansmithlike anything, it's a balance15:44
sdagueagree15:44
*** nkrinner has quit IRC15:44
sdagueour balance is way too far on the subclass side now15:44
dansmithin some places, for sure15:44
shaohe_feng_sdague: jaypipes : this is the libvirt doc: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainJobInfo .15:44
shaohe_feng_sdague: jaypipes :  it is said: Data is measured in bytes unless otherwise specified and is measuring the job as a whole. For VIR_DOMAIN_JOB_UNBOUNDED, dataTotal may be less than the final sum of dataProcessed + dataRemaining in the event that the hypervisor has to repeat some data, such as due to dirtied pages during migration. For VIR_DOMAIN_JOB_BOUNDED, dataTotal shall always equal the sum of dataProcessed + dataRema15:45
mriedemalaski: re: cells v2 + neutron,15:45
mriedemalaski: will neutron api be global for all cells? or will the networks be per-cell?15:45
shaohe_feng_sdague: jaypipes : will update the patch. thanks for review.15:45
sdagueshaohe_feng_: thanks15:45
sdaguemriedem: how about I let you fix the test_server_groups tests that are all massively coupled, then we can discusss :)15:46
*** pushkaru has joined #openstack-nova15:46
kashyapmdbooth: When you get a moment, I learnt from Infra folks that which change is causing that "can't merge" errors from Gerrit.  Added a comment here with a (non-null) pointer - https://review.openstack.org/#/c/283702/115:46
alaskimriedem: neutron should be global for all cells, but networks per cell could be handled with the routed networking effort that Carl brought up in Bristol15:46
mriedemarmax: ^15:47
*** krtaylor has joined #openstack-nova15:47
pkoniszewskijaypipes: hi, still there?15:48
mriedemalaski: was just thinking about the case that you request a specific network,15:48
cdentsdague: I know you've been on this recently, what do I need to create in my local nova test environment to get opportunistc mysql tests happening?15:48
mdboothkashyap: Thanks!15:48
sdaguecdent: as mysql admin user....15:48
mriedembelmoreira: how many IP address per cell at CERN?15:48
mriedem*addresses15:49
mriedemrough idea15:49
mriedemhow many compute nodes15:49
alaskimriedem: it's dependent on works in progress, but the idea is that network segments will be tracked as resource pools in Nova so when a network is passed in Nova can determine which pool to schedule to15:49
sdaguecreate user 'openstack_citest'@'localhost' identified by 'openstack_citest'; grant all on *.* to 'openstack_citest'@'localhost';15:49
openstackgerritShaoHe Feng proposed openstack/nova: Add new APIs and deprecate old API for migrations  https://review.openstack.org/25877115:49
mriedemalaski: ok, i assumed that was the answer15:49
mriedemsdague: i'm just arguing to argue15:50
*** efoley__ has joined #openstack-nova15:51
openstackgerritSwaminathan Vasudevan proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507315:51
belmoreiramriedem number of nodes per cell is ~20015:51
*** andrearosa_web has joined #openstack-nova15:51
mriedemdougwig: ^15:51
*** haplo37 has joined #openstack-nova15:52
belmoreiramriedem number of IPs varies a lot depending in the cell use case15:52
*** Sukhdev has joined #openstack-nova15:52
shaohe_feng_sdague: jaypipes :done. https://review.openstack.org/258771 waiting for gate test.  thanks.15:52
belmoreiramriedem however we have ~5 segments per cell15:53
cdentthanks sdague, I am suitably empowered now15:53
openstackgerritSean M. Collins proposed openstack/os-vif: [WIP] Add mtu attribute to Network object  https://review.openstack.org/28420915:53
doffmbelmoreira: Thats alot of total segments.15:53
*** mdrabe has quit IRC15:53
sdaguecdent: that should go in the docs somewhere... just haven't gotten around to that yet15:54
kylek3hdansmith: I had some questions for you regarding migrate_data.py...specifically the LiveMigrateData objects.15:54
belmoreiradoffm yes... a segment per ~40 nodes15:54
dansmithkylek3h: okay15:54
shaohe_feng_sdague: what is WG?  API WG15:55
kylek3hdansmith: With the changeset that introduced sending LiveMigrateData objects around between the services we're no longer able to do live migration for the PowerVM compute driver.15:55
*** jaosorior has quit IRC15:55
kylek3hdansmith: For PowerVM we need to pass more data between the hosts than we can fit in the libvirt or xen objects.15:55
dansmithkylek3h: that's good, because those objects aren't for you :)15:55
sc68caljaypipes: https://review.openstack.org/284209 - first baby steps15:55
kylek3hdansmith: I've looked and I don't see a way to properly register an object for PowerVM through the driver since conductor needs it.15:55
kylek3hdansmith: Anything I'm missing?15:56
sdagueshaohe_feng_: ??15:56
kylek3hdansmith: For PowerVM it seems we need to propose a change set for a specific PowerVMLiveMigrateData object.15:56
dansmithkylek3h: yeah, drivers don't register objects15:56
*** matrohon has quit IRC15:56
dansmithkylek3h: yeah, but we're not going to take that into master for an out of tree driver15:56
danpbkylek3h: you'd have to install the python module that defines the objects in your conductor nodes15:56
kylek3hdansmith: What would you advise?15:56
jaypipessc68cal: coolio.15:57
danpbie, you'd need a separate nova-powervm-objects  python dist15:57
*** sridharg has joined #openstack-nova15:57
danpband your  nova-powervm-driver  python dist would depend on that15:57
*** daemontool has quit IRC15:57
dansmithkylek3h: something like danpb says, but it's going to have to require changes to core code to import that15:57
dansmithso they get registerd15:57
danpbthat way you can install the object definitions on conductor + compute nodes15:57
kylek3hdansmith: right...is there a mechanism for that today?15:57
dansmithkylek3h: no15:58
shaohe_feng_sdague: I have seen this comments on "From the API WG guidance" , do not know what stand for.15:58
*** penick has quit IRC15:58
dansmithkylek3h: because we don't support out of tree stuff15:58
*** baoli has quit IRC15:58
kylek3hdansmith: understand but we're working hard to get in tree, but facing these types of hurdles.15:58
*** baoli has joined #openstack-nova15:59
sdagueshaohe_feng_: right api working group15:59
shaohe_feng_sdague: got it. thank you.15:59
sdagueshaohe_feng_: https://wiki.openstack.org/wiki/API_Working_Group15:59
danpbkylek3h: well to be honest you don't need to have 100% coverage of all apis to submit it in tree15:59
danpbkylek3h: in fact when we took ironic in tree, we made them split it up so their initial driver contained just minimal featurs16:00
pkoniszewskisdague: can you have a quick look at https://review.openstack.org/#/c/284068/3 ? Im trying to fix force_complete API according to the API guideline16:00
danpbIOW you don't need to solve the live migration objects issue out of tree - its not a blocker for submitting & merging your driver in tree16:00
kylek3hdanpb: okay, understood.16:00
danpblive migration can be added later once its is in tree16:00
*** haomaiwang has quit IRC16:01
dansmithpresumably they just want to fix the regression16:01
dansmithwhich isn't going to be easy16:01
*** haomaiwang has joined #openstack-nova16:01
kylek3hdanpb: well, we're kind of going backwards since we had live migration work well...16:01
*** zenoway has quit IRC16:01
*** erlon has joined #openstack-nova16:02
pkoniszewskijaypipes: should we include units (bytes) in python-novaclient too? Im talking about this change https://review.openstack.org/#/c/281335/16:02
*** daemontool has joined #openstack-nova16:02
danpbright but you're out of tree, so we don't particularly care about regressions in out of tree, so unfortunately that's life16:02
dansmiththis ^16:02
kylek3hdansmith: understood.  I have a prototype that works .... it's about 20 LOC in migrate_data.py  :-)16:02
danpbif you want to avoid this, focus should be on doing everything possible & neccessary to get in tree asap16:02
jaypipespkoniszewski: yes, sir, thank you :)16:03
*** dims has joined #openstack-nova16:03
pkoniszewskijaypipes: thanks!16:03
*** lyanchih has quit IRC16:03
dansmithso actually16:03
dansmithkylek3h: conductor never sees this object, right?16:03
dansmithor maybe it does because of the pre call16:03
*** tomoiaga has quit IRC16:03
kylek3hit sends it so it needs the definition16:03
kylek3hright16:03
danpbkylek3h: as a partially sucky hack, you could create your own daemon startup program ie instead of using /usr/bin/nova-conductor, create a /usr/bin/nova-conductor-powervm16:04
mriedemdanpb: actually,16:04
mriedemconductor manager is pluggable16:04
kylek3hdansmith: I tried putting it in the driver itself and some of the orchestration worked but eventually conductor blew up16:04
dansmithkylek3h: yep16:04
openstackgerritDmitry Stepanenko proposed openstack/nova: Go away from using PciDeviceStats consume_requests  https://review.openstack.org/24313116:04
openstackgerritDmitry Stepanenko proposed openstack/nova: Deprecate ComputeNode pci_device_pools field  https://review.openstack.org/24769216:04
kylek3hmriedem: oh....16:04
openstackgerritDmitry Stepanenko proposed openstack/nova: Add PciDevicePoolList.get_all method  https://review.openstack.org/25075716:04
openstackgerritDmitry Stepanenko proposed openstack/nova: Added support_requests method to PciDevicePoolList  https://review.openstack.org/24208716:04
*** efoley__ has quit IRC16:04
mriedemCONF.conductor.manager16:04
dansmithmriedem: we should remove that16:04
danpbmriedem: oh, so they can subclass that and register their object that way16:04
mriedemdanpb: yeah maybe16:05
danpbwe should totally delete that config parameter16:05
kylek3hok, let me look at that.  It may be the piece I was missing!16:05
sdaguedansmith: push a deprecation patch then16:05
dansmithsdague: yeah, I should16:05
openstackgerritSean Dague proposed openstack/nova: make microversion a client level construct for tests  https://review.openstack.org/28422016:05
johnthetubaguydansmith: there are a few of those we need to deprecate... dang it16:05
sdagueI'll +2 the heck out of a deprecation patch for that16:05
* danpb wonders how many config params we've got left which let people load arbitrary code still16:05
dansmithjohnthetubaguy: yeah16:05
danpbi know there's the firewall_driver config parameter we should kill16:05
johnthetubaguydanpb: way more than you would hope16:05
mriedemcompute and network manager are also pluggable16:06
mriedemlots of the managers16:06
mriedemif not all16:06
mriedemidentity backend, all the things16:06
johnthetubaguyyeah, that one is a move to stevdore things, some are just pain kill them16:06
*** efoley__ has joined #openstack-nova16:06
sdaguemriedem: https://review.openstack.org/284220 will make your patch simpler16:06
dansmithyeah, mostly kill16:06
johnthetubaguydansmith: +116:06
mriedembtw,16:06
mriedemare there specific goals for the powervm driver to hit that are stated somewhere?16:07
mriedemi know (1) ci and (2) users16:07
johnthetubaguyhmm, probably only in an either mad16:07
johnthetubaguyoops, etherpad16:07
johnthetubaguythe other was diverse contributor base, would be ideal16:08
kylek3hmriedem: I know thorst has been working on that.16:08
*** browne has joined #openstack-nova16:08
mriedemit's just kind of harsh to say, sorry we broke you but that's life so suck it up, work on getting in tree, but oh btw we do'nt have anything stating what you have to do to get in tree16:08
*** salv-orlando has joined #openstack-nova16:08
*** mdrabe has joined #openstack-nova16:08
mriedemjohnthetubaguy: the hyperv, vmware and xenapi drivers arguably don't have a diverse contributor base16:09
mriedemlibvirt does b/c it's the reference16:09
dansmithmriedem: by that logic, we'd never be able to do anything that broke something out of tree that doesn't belong in nova16:09
mriedemdansmith: i'm not saying we can't16:09
dansmithmriedem: I don't think libvirt being reference has much to do with the contributor base16:09
dansmithI think it has to do with the user base16:09
danpbyeah, IMHO diverse contributor base is a non-requirement16:10
*** mjura has quit IRC16:10
danpbwhat we actually need is a /responsiveness/ contributor base committed to ongoing work16:10
mriedemi'm not saying libvirt is the reference b/c of it's contributor base16:10
sdaguedanpb: agree, I'm not sure where that popped up in conversation. xenserver driver definitely isn't16:10
mriedemi agree it's the user base b/c it's free16:10
*** yamahata has quit IRC16:10
johnthetubaguythat was in the summit, maybe my memory playing tricks with me16:10
johnthetubaguyI think it was diverse user base, more than anything16:11
johnthetubaguywell, really just a user base16:11
mriedemanyway, i will shut up again16:11
sdagueit seemed like the conversation was: ci, because we expect that for everyone16:11
danpbIMHO requirements for a new driver should be pretty much CI testing + committed group of maintainers + real world users16:11
sdagueusers, because we totally go powned by that in the past16:11
danpbie, we don't want to accept a toy academic project with no real users16:12
johnthetubaguywe have lxd on its way as well, I think, so we need to get this straight somewhere16:12
dansmithjohnthetubaguy: how about "has a mission in line with nova's mission" ?16:12
dansmiththat would be an easy way to answer the lxd crowd, IMHO16:12
johnthetubaguydanpb: yeah, I thats a bit part of it, those toy projects are best not being upstream16:12
sdaguedanpb: well, and also in the case we had a driver for this hypevisor before that burned a ton of review time, and then ended up with "oh forgot to tell you all, no one has ever run this code outside our test lab"16:13
johnthetubaguysdague: yeah, thats where the higher bar comes from16:13
danpbyeah, that's why i said real world users, as opposed to toy research project users16:13
johnthetubaguydansmith: true, thats got to be in there16:13
*** Kennan has quit IRC16:13
mriedemwell, lxd vs lxc?16:13
sdaguedanpb: sure, basically in agreement16:13
mriedemci for lxc is busted16:13
dansmithmriedem: lxc is basically free16:13
mriedemit's in tree b/c it's convenient16:13
mriedemyeah, that16:14
danpbmriedem: LXD is basically more akin to Docker these days16:14
dansmithso it gets a pass, IMHO, but I'd be the same way if we were pressed to add it today16:14
*** diogogmt has joined #openstack-nova16:14
*** annasort has joined #openstack-nova16:14
*** Kennan has joined #openstack-nova16:14
mriedemdanpb: ok16:14
*** mgoddard__ has quit IRC16:14
sdagueI think we've told a lot of people in the past that if you show up as a libvirt driver, you get a pass16:14
danpbit tries todo the whole container lifecycle & image mgmt thing now16:14
*** mgoddard has joined #openstack-nova16:14
sdaguelike the power kvm and z kvm folks16:14
dansmithaye16:14
dansmithbecause that addresses most of the problem of adding a new driver16:15
johnthetubaguydanpb: oh, I missed that happening, good to know16:15
johnthetubaguysdague: yeah, +1 on the libvirt thing, well, its a lower bar at least16:15
*** annasort_ has joined #openstack-nova16:15
cdentjaypipes: so the sticking point on this migration 318 is the use of server_default=text('0'). When the migration is compared with the model the two 'text' objects are different and it blows up. We need to 'text' otherwise 0 is added to the DDL as a string. I can avoid all this just by not using server_default at all, and just sticking with just default. What will that break if I do?16:15
johnthetubaguywell, parallels is probably the recent example16:15
sdaguewe explicitly tell most groups 'go be a libvirt driver, you'll largely get a pass'16:15
*** apearson has joined #openstack-nova16:15
danpbfor libvirt we'd still at minimum like to see a committed set of maintainers for the port16:15
openstackgerritSean M. Collins proposed openstack/os-vif: [WIP] Add mtu attribute to Network object  https://review.openstack.org/28420916:15
sdaguedanpb: agree16:16
danpbCI testing would be pretty desirable too16:16
jaypipescdent: just ditch the server_default. let's just move on.16:16
cdentjaypipes: or I can go the long way round and change the sync test, but.... blech16:16
cdentword16:16
cdentthanks16:16
danpbsince although the nova code should be largely unchanged, this doesn't mean the hypervisor supports the same features as existing libvirt hypervisors, so we like see where we stand on feature parity16:16
danpbin general a libvirt driver has very little ongoing dev burden, compared to a completely new nova driver though16:17
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183716:17
cdentjaypipes: I think that ^ gets it then. bauzas, alaski, dansmith, if you please, at your leisure, etc16:18
*** gszasz has quit IRC16:18
jaypipescdent: will do as soon as I see the gate check succeed.16:19
*** annasort has quit IRC16:19
*** annasort_ is now known as annasort16:19
*** dedery_ has joined #openstack-nova16:19
cdent:some slack emoji in jaypipes' direction:16:19
cdentbah, pep816:20
*** zenoway has joined #openstack-nova16:21
openstackgerritChris Dent proposed openstack/nova: Adjust resource-providers models for resource-pools  https://review.openstack.org/28183716:22
*** liverpooler has quit IRC16:22
*** dedery has quit IRC16:22
*** ekuris has quit IRC16:24
*** dedery_ has quit IRC16:24
openstackgerritDmitry Stepanenko proposed openstack/nova: Switch HostState to use pci device pools  https://review.openstack.org/25841716:25
thorstmriedmen johnthetubaguy danpb dansmith sdague: Sorry for the delay, was afk.  I agree with the stated goals (contributor base, user base, CI).  But at the same time one of the stated things in Tokyo was that nova doesn’t want out-of-tree drivers doing ‘weird’ things.  I just want to make sure that this won’t be considered ‘weird’ later on.  We just don’t want to do the wrong thing here...16:25
danpbthorst: you mean the migration object hack ?16:25
dansmiththorst: you mean hacking things up to get your object registered?16:25
thorstyeah - a separate objects project.16:26
dansmithyou don't need a separate project16:26
openstackgerritDmitry Stepanenko proposed openstack/nova: Change HostManager to load pci_dev_pools from db  https://review.openstack.org/26002316:26
danpbthat's not something you'd submit when you merged it in-tree, so its not a issue16:26
*** apearson has quit IRC16:27
thorstdanpb: OK.  That's the main thing.  We'd just add that to the existing object when merged in-tree16:27
*** apearson has joined #openstack-nova16:27
dansmithof course16:28
thorstcool...I was just worried when the review came it would be a 'what is this?' moment.  But sounds like its well understood and won't cause concern later16:28
*** belmoreira has quit IRC16:31
*** harlowja_at_home has joined #openstack-nova16:31
*** bjornar__ has joined #openstack-nova16:32
*** gszasz has joined #openstack-nova16:32
PaulMurrayhi mriedem - have you seen responses to your comments here: https://review.openstack.org/#/c/278454/1116:32
PaulMurraymriedem, that patch is blocking several live migration ones16:32
*** ihrachys has quit IRC16:33
PaulMurraymriedem, don't know if andreykurilin has had a chance to talk to you about it - he said he would16:33
mriedemPaulMurray: looking16:33
mriedemhe pinged earlier16:33
PaulMurraymriedem, thanks - good - sorry for being eager - got three patches queued by others16:35
mriedemsheesh16:35
mriedemreplied16:35
*** dstepanenko_ has quit IRC16:36
*** dstepanenko has joined #openstack-nova16:37
*** gszasz has quit IRC16:38
*** atuvenie__ has joined #openstack-nova16:38
*** fawadkhaliq has joined #openstack-nova16:38
*** ljxiash has quit IRC16:39
BobbaVek: Regarding https://review.openstack.org/#/c/283962/, what do you mean by a separate set of tests?  Do you mean independent of nova/tests/unit?16:40
*** 32NAAC6RR has quit IRC16:42
sdaguecdent: I see we both o_O at the same time on that16:42
cdentyeah16:42
cdentum16:42
cdentwat16:42
*** ducttape_ has quit IRC16:42
*** ducttape_ has joined #openstack-nova16:43
*** gyee has joined #openstack-nova16:43
cdentsdague: I for reasons not entirely clear to me took it a bit personal...curse of REST and all that. feh!16:43
sdagueheh16:44
*** apoorvad has joined #openstack-nova16:44
sdagueI mostly want to know why people keep saying it16:44
sdaguelike I feel like there is some post somewhere people read that makes them think it's true16:44
*** mgoddard_ has joined #openstack-nova16:44
*** ducttape_ has quit IRC16:45
*** jistr has quit IRC16:45
*** ducttape_ has joined #openstack-nova16:45
*** oomichi has joined #openstack-nova16:46
*** baoli_ has joined #openstack-nova16:46
*** vilobhmm11 has joined #openstack-nova16:46
*** apearson has quit IRC16:47
auggysdague: thanks for posting that, i honestly thought maybe i was just missing something16:47
* auggy usually blames myself16:47
*** mgoddard has quit IRC16:47
*** moshele has quit IRC16:48
*** baoli has quit IRC16:48
sdaguemriedem: hmm... this is interesting16:52
sdaguein trying to fix the server_groups tests16:52
sdagueevacuate > 2.11 fails16:52
mriedemsdague: http://docs.openstack.org/developer/nova/api_microversion_history.html#id1216:54
mriedem?16:54
*** zenoway has quit IRC16:54
sdaguemriedem: yep, that's is16:54
sdaguebut, the way it explodes is wonky16:54
*** zenoway has joined #openstack-nova16:55
sdagueoh, wait, maybe the stack trace is all fail16:55
sdaguemriedem: http://paste.openstack.org/show/488048/16:55
sdagueis that the thing you were chasing16:55
claudiub|2hello folks. If you have a minute, can anyone take a look at a bugfix? It's 13 lines long and it already has a +2. https://review.openstack.org/#/c/258614/16:55
openstackgerritSean Dague proposed openstack/nova: WIP: update test_server_groups to client microversion  https://review.openstack.org/28425716:56
sheelcdent: hi there16:56
mriedemsdague: i was seeing that too yeah16:56
*** Guest51435 is now known as mgagne16:56
*** mgagne has quit IRC16:56
*** mgagne has joined #openstack-nova16:56
mriedemsdague: kylek3h might have a patch for htat16:57
mriedem*that16:57
*** Sukhdev has quit IRC16:57
mriedemthe cancel events NoneType thing16:57
sheelcdent: its regarding https://review.openstack.org/#/c/282862/ ..... review comments are incorporated...16:57
sheelcdent: kindly go through it..16:57
bauzasjohnthetubaguy: you know what ? I'm getting mad trying to play with test_conductor for asserting the calls that we discussed this morning16:57
*** lbragstad has quit IRC16:58
cdentthanks sheel, will do soon16:58
sheelcdent: thank you..16:58
*** zenoway has quit IRC16:58
sdaguemriedem: is that posted anywhere?16:59
*** dims has quit IRC17:00
mriedemsdague: oh i was thinking of this https://review.openstack.org/#/c/281553/17:00
*** amotoki has quit IRC17:00
*** haomaiwang has quit IRC17:01
*** haomaiwang has joined #openstack-nova17:01
sdagueright, that seems different17:01
*** lbragstad has joined #openstack-nova17:02
*** thorst has quit IRC17:02
johnthetubaguybauzas: oh, thats no fun, it sounded like it should be an easy one, in theory17:02
bauzasjohnthetubaguy: the real problem is that test_conductor is messy17:03
bauzasjohnthetubaguy: all the checks are only for the manager17:03
*** thorst has joined #openstack-nova17:03
*** thorst has quit IRC17:03
bauzasjohnthetubaguy: but I think I'm about to provide a good catch17:03
*** atuvenie__ has quit IRC17:03
bauzasjust telling you FYI17:03
*** dims has joined #openstack-nova17:03
sdaguemriedem: I wonder if we now have an instance where cancel_events gets called twice17:04
johnthetubaguybauzas: cool17:04
bauzasjohnthetubaguy: tbc, we need to be very sure about the UTs we accept for test_conductor17:04
mriedemsdague: was just going to say that17:04
bauzasbecause the coverage is very small17:04
bauzas(for the RPC versioning I mean)17:04
sdaguemriedem: it seems like a simple safety check17:05
mriedemdo the tests kill the compute service twice?17:05
sdaguebut I'm going to try to get through this other patch first17:05
sdaguemaybe....17:05
*** yamahata has joined #openstack-nova17:06
*** belmoreira has joined #openstack-nova17:06
mriedemsdague: i see it17:07
mriedemthe base class uses ServiceFixture17:07
mriedemwhich has  self.addCleanup(self.service.kill)17:07
mriedemso the functional tests don't need to expliclity call it17:07
*** apearson has joined #openstack-nova17:07
bauzaslast fun stuff, when using the ServiceFixture, it seems that assert_called_with doesn't work with a mock.ANY arg :)17:08
openstackgerritMatt Riedemann proposed openstack/nova: Add functional regression test for list deleted instances on v2.16  https://review.openstack.org/28383717:09
bauzasit literally tells me that my expected mock.ANY is different from a dict :)17:09
bauzasmeh17:09
sdaguebauzas: review?17:11
bauzasnot yet17:11
bauzaslocally17:11
bauzashttp://paste.openstack.org/show/488054/17:11
*** pbacterio has quit IRC17:12
bauzaswith http://paste.openstack.org/show/488057/17:12
*** zenoway has joined #openstack-nova17:14
sdagueinteresting17:14
*** achanda has joined #openstack-nova17:15
*** achanda has quit IRC17:15
*** sheel has quit IRC17:15
*** achanda has joined #openstack-nova17:15
*** sfinucan has quit IRC17:16
*** sheel has joined #openstack-nova17:16
*** omnipresent has joined #openstack-nova17:17
bauzassdague: I'll workaround that by mocking the image api, but see, it's a bit weirdo17:19
openstackgerritMatt Riedemann proposed openstack/nova: Cleanup service.kill calls in functional tests  https://review.openstack.org/28426817:19
mriedemsdague: cleans up those redundant service.kill calls ^17:19
*** jlanoux has quit IRC17:20
mriedemwondering if i should add a check in the cancel_all_events method too17:20
*** zenoway has quit IRC17:20
*** mvk has quit IRC17:22
openstackgerritRoman Podoliaka proposed openstack/nova: libvirt: delete the last file link in _supports_direct_io()  https://review.openstack.org/22476417:23
*** edmondsw has quit IRC17:23
sdaguemriedem: cool, the check in cancel_all_events wouldn't hurt17:23
*** mpavone has quit IRC17:25
*** gyee has quit IRC17:25
mriedemok i'll do that17:25
*** ihrachys has joined #openstack-nova17:26
*** zenoway has joined #openstack-nova17:27
*** ihrachys has quit IRC17:29
*** omnipresent has quit IRC17:30
auggysdague: so i was having trouble duplicating the behavior in the mysql cli because i wasn't including the delete column in my insert, but when i did, it triggered the duplicate key error at the cli17:31
auggybecause i can read unique constraints!!17:31
sdagueah, nice17:32
*** rtheis has quit IRC17:32
*** rtheis has joined #openstack-nova17:33
*** josecastroleon1 has quit IRC17:34
openstackgerritgaryk proposed openstack/nova: VMware: remove deprecation warnings from oslo_versionedobjects  https://review.openstack.org/28428617:35
auggythe other odd thing, why is deleted NULL as default? i mean logically, if you're inserting wouldn't deleted be 0??17:35
openstackgerritMatt Riedemann proposed openstack/nova: Cleanup service.kill calls in functional tests  https://review.openstack.org/28426817:36
openstackgerritMatt Riedemann proposed openstack/nova: Gracefully handle cancelling all events more than once  https://review.openstack.org/28428717:36
*** sudipto has quit IRC17:36
*** sahid has quit IRC17:37
*** zenoway has quit IRC17:37
andreykurilinmriedem: just replied to your comment:) If you still disagree, I'll post new patch-set17:37
*** zenoway has joined #openstack-nova17:38
*** rtheis has quit IRC17:39
*** mrkz has quit IRC17:40
sdagueauggy: I forget, possibly an oversight17:40
auggyit sets it to an id on delete17:40
*** mrkz has joined #openstack-nova17:41
openstackgerritAndrea Rosa proposed openstack/python-novaclient: Support for abort an ongoing live migration  https://review.openstack.org/28429617:41
mriedemandreykurilin: so i guess i'll pull down https://review.openstack.org/#/c/284186/ first and then https://review.openstack.org/#/c/278454/ and see if the help message thing is fixed17:41
auggyit's ok, i was just curious, i assumed it was a binary field17:41
andreykurilinmriedem: thanks17:43
mriedemandreykurilin: can you write a test for the help message fix?17:44
*** nic has joined #openstack-nova17:45
*** sridharg has quit IRC17:46
*** ociuhandu has quit IRC17:46
*** zenoway has quit IRC17:47
*** edmondsw has joined #openstack-nova17:47
*** zenoway has joined #openstack-nova17:48
*** moshele has joined #openstack-nova17:48
andreykurilinmriedem: I didn't write it yet, since I wanted to work on more shell improvements(hint message about --os-compute-api-version after command description), but don't finished it yet.17:49
johnthetubaguysdague: jaypipes: for this live-migrate status, just thinking this negative test is a bit risky, feels like we should be picking out the known good states here? https://review.openstack.org/#/c/258771/29/nova/db/sqlalchemy/api.py17:49
mriedemandreykurilin: it doesn't seem to really work like i expected17:50
andreykurilinmriedem: will write it in 10 minutes17:50
*** rtheis has joined #openstack-nova17:50
mriedemandreykurilin: i pulled both changes down and now the help i get is this: http://paste.openstack.org/show/488066/17:50
sdaguejohnthetubaguy: I'm fine either way. I do see your concern about the lack of formal states and what that does later17:51
*** lucasagomes is now known as lucas-hungry17:51
sdagueI also think that could be fixed later17:51
sdagueas it doesn't really change the semantics of the API17:51
andreykurilinmriedem: It works like I expected(print the proper argument for chosen version)17:51
*** knikolla has joined #openstack-nova17:52
mriedemandreykurilin: for chosen version....17:52
mriedemhow is the version chosen?17:52
andreykurilin--os-compute-api-version17:52
mriedemi tried using --os-compute-api-version 2.20 with the help but it failed17:52
mriedemohhhhh17:52
mriedemhttp://paste.openstack.org/show/488067/17:53
mriedemi had the option in the wrong place17:53
andreykurilin:)17:54
*** rdopiera has quit IRC17:54
mriedemandreykurilin: ok, so i'm good with both if we can add a test for the shell fix, and order the changes such that we land the shell fix first17:55
*** Marga_ has quit IRC17:55
andreykurilinmriedem: ok. I'll write(and fix) unit tests for patch for help message and rebase v2.21 on it17:56
*** rtheis has quit IRC17:56
*** rtheis has joined #openstack-nova17:56
PaulMurraymriedem, andreykurilin - hi - oh, you're already sorting it out. I was about to talk about that17:57
andreykurilin:)17:57
*** moshele has quit IRC17:57
*** zenoway has quit IRC17:57
*** jdillaman has joined #openstack-nova17:58
mriedemthe task master17:58
*** zenoway has joined #openstack-nova17:59
mriedemPaulMurray: are you a certified PMP?17:59
openstackgerritKevin Benton proposed openstack/nova: Use MTU value from Neutron in OVS/LB VIF wiring  https://review.openstack.org/28384717:59
*** scheuran has quit IRC17:59
*** claudiub|2 has quit IRC18:00
*** haomaiwang has quit IRC18:01
*** rtheis has quit IRC18:01
*** haomaiwang has joined #openstack-nova18:01
*** derekh has quit IRC18:01
*** eil397 has joined #openstack-nova18:02
*** mgoddard_ has quit IRC18:02
*** ociuhandu has joined #openstack-nova18:02
*** mgoddard has joined #openstack-nova18:03
mriedemkevinbenton: heh, looking at your mtu patch18:05
mriedemhttps://github.com/openstack/nova/commit/44670135be0640622bf6ab74552aa4a9efd21b0c18:05
mriedemback in juno we deprecated the config option18:05
mriedemwe should probably actually use the deprecated_for_removal=True in the option so it warns when it's used18:05
mriedemcould be a separate change that builds on the neutron change you have18:05
jaypipesjohnthetubaguy: yeah, that's a very good point.18:06
dansmithansiwen: we probably just need to pre-load flavor data when we pull it for caching18:06
dansmithansiwen: (expected_attrs=['flavor'])18:06
dansmithansiwen: I think the flavor info is probably always going to be hit from metadata in almost every case, so just always pre-querying it is probably best18:06
*** porunov has quit IRC18:07
ansiwendansmith: I was doing this with a dummy get_flavor(), and indeed it fixes the problem18:07
dansmithyeah, so just add it to expected_attrs on your initial query and it'll be even better.. pulled in the first go18:07
dansmithalthough I thought I already did that for this metadata one.. have you checked in master?18:08
ansiwenso this is really the right way to fix it? shouldn't lazy loads trigger an update of the cache?18:08
openstackgerritChris Dent proposed openstack/nova: Add name to ResourceProvider object  https://review.openstack.org/28194518:09
dansmithansiwen: I think flavor should probably always be queried18:10
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [microversions] Enable 2.21  https://review.openstack.org/27845418:11
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [microversions] fix help msg for versioned args  https://review.openstack.org/28418618:11
dansmithansiwen: the problem with updating the cache on lazy load would be that you're refreshing the image, but without fresh data, right? so you'd have to wait longer for the cache to flush so you got some other instance attribute just because you happened to touch flavor, right?18:11
ansiwendansmith: I didn't check master. I'm investigating this on a kilo installation.18:11
dansmithansiwen: 3a761270581d1ac61a3b4669c130d211f1ad5a1718:11
andreykurilinmriedem: I added unit tests and rebased a change on it18:12
*** thorst has joined #openstack-nova18:13
openstackgerritSean Dague proposed openstack/nova: complete the removal of api_version from rest client parameters  https://review.openstack.org/28425718:13
*** dedery has joined #openstack-nova18:14
*** andreykurilin__ has joined #openstack-nova18:14
cdentjaypipes, dansmith, bauzas, alaski: gate finally says go: https://review.openstack.org/#/c/281837/18:14
openstackgerritSean Dague proposed openstack/nova: add a place for functional test to block specific regressions  https://review.openstack.org/28201218:14
ansiwendansmith: not sure what you mean with "fresh data". isn't the current instance object authoritative?18:15
dansmithansiwen: 1. Query metadata, cache instance18:16
dansmithansiwen: 2. Update display_name from the API externally18:16
dansmithansiwen: 3. Lazy-load flavor, which renews the instance TTL18:16
*** zenoway has quit IRC18:16
dansmithansiwen: 4. Wait longer to notice the display_name change from the metadata client side18:16
*** ctrath has quit IRC18:17
*** zenoway has joined #openstack-nova18:17
*** dedery_ has joined #openstack-nova18:18
ansiwendansmith: so, when lazy-load of flavor triggers a cache update in 3, why isn't the display_name updated as well?18:19
*** dedery has quit IRC18:19
openstackgerritDan Smith proposed openstack/nova: Deprecate conductor manager option  https://review.openstack.org/28433218:20
dansmithansiwen: because that's not how we do lazy-loads18:20
sdaguedoffm: so you realized you -1ed a patch because there wasn't a completely developer reference for a model in which we've landed 0 patches18:20
ansiwendansmith: IIUC the memcached cache object is just an deep object dump of meta_data object, right?18:21
dansmithansiwen: we could, but we'd need to be super careful not to overwrite any dirty fields, and potentially we'd be changing the consistent state of the instance for the base attributes18:21
*** zenoway has quit IRC18:21
sdaguemriedem: I think we've got about 8 patches in flight that build upon - https://review.openstack.org/#/c/282012/18:21
dansmithansiwen: I don't know how it gets serialized into memcache, TBH.. a deepcopy isn't really the right thing to do, TBH, but that may be what it's doing18:21
sdagueso we should start landing this stuff, or abandon it all and rage quit :)18:22
ansiwendansmith: I think I'm missing some important information about the architecture18:22
*** belmoreira has quit IRC18:23
ansiwendansmith: it's just my observation. if getting the metadata object from the cache "overwrites" meta_data.instance.flavor state (because it fetches the flavor again and again), it seems to be a deep copy18:24
dansmithansiwen: I was talking about lazy loads in the instance object, not anything metadata specific18:25
dansmithansiwen: also, I don't know what meta_data.instance.flavor is18:25
*** jwcroppe has quit IRC18:26
dansmithjaypipes: did you do that db patch we talked about yesterday yet?18:26
cdentjaypipes: yes, that double alter really frustrated me18:27
ansiwendansmith: the metadata object has an instance attribute, which is a nova object, which again has a flavor attribute18:28
jaypipesdansmith: currently working on it, sir.18:28
PaulMurrayjohnthetubaguy, just saw your comment on https://review.openstack.org/#/c/258771 - I wondered if that really matters now - the fucntion is the same as the existing one above18:28
dansmithjaypipes: okay18:28
kevinbentonmriedem: yeah, i laughed when i looked at the commit for that and saw it was in juno-eol18:28
PaulMurrayjohnthetubaguy, oops - I'm about to turn into a pumpkin if I don't run.......18:28
* PaulMurray runs18:29
dansmithansiwen: what is "the metadata object" ?18:29
*** Jeffrey4l has quit IRC18:29
*** lpetrut has quit IRC18:29
ansiwendansmith: class InstanceMetadata18:29
dansmithoh, that python object, I see18:29
ansiwenfrom nova/api/metadata/base.py18:30
ansiwendansmith: that's exactly the object that get's cached in memcached18:30
dansmithansiwen: yeah, I don't see where that caching happens18:31
dansmithbecause you have to serialize it in some way, and just json()ing it or something wouldn't retain the lazy-loading behavior18:31
ansiwendansmith: https://github.com/openstack/nova/blob/master/nova/api/metadata/handler.py#L9418:31
dansmithansiwen: that's caching the metadata result, right?18:32
dansmithnone of the internals, just the response we would have sent to the client, I thought18:32
ansiwendansmith: exactly18:32
*** PaulMurray has quit IRC18:32
dansmithI dunno what you're asking then :)18:33
ansiwendansmith: well, it uses the memcache library, which stores the whole object transparantly. so, I suppose it MUST do a deep copy, else you would have dangling references18:33
dansmithdims: is that right? are we like pickling things into memcache?18:33
ansiwenit just stores a python object. and when I resurrect it, the embedded instance object has an "old" state18:34
* dims catches up18:34
*** Marga_ has joined #openstack-nova18:34
dansmithansiwen: it can't just "store a python object" -- it has to serialize it in some way18:34
dansmithand using something like pickle to do that would be ... terrible18:34
dansmithand non-portable18:34
dansmithand a security risk18:34
ansiwendansmith: of course it has to18:35
*** zhangjn has quit IRC18:35
*** zhangjn has joined #openstack-nova18:36
*** READ10 has joined #openstack-nova18:36
ansiwendansmith: it's just my observation. that's also why I was wondering, why you would store a mashalled object in memcached, since it is not useful for any other nova-api process18:37
ansiwendansmith: but there is still a high likelyhood, that I got it completely wrong18:37
ansiwendansmith: I have to run and move home. I'll be back later. I'm very interested in understanding this.18:38
mriedemandreykurilin: +W on https://review.openstack.org/#/c/284186/18:39
*** josecastroleon has joined #openstack-nova18:39
dansmithansiwen: okay well, clearly I don't have the full picture of the backend of this, so not sure how much more I can help, but interested in not pickling if that's what we're doing :)18:39
dimsdansmith : what we store in memcached has not changed with the move to oslo.cache, it was what it was before :)18:40
dansmithdims: that's fine, I just figure you'd know18:41
*** liverpooler has joined #openstack-nova18:41
dimssnikitin : pkholkin_ : do you know exactly if pickling is what happens under the covers?18:41
*** irenab_ has joined #openstack-nova18:42
*** irenab has quit IRC18:44
*** irenab_ is now known as irenab18:44
dimsdansmith : ansiwen : i believe we have not added support for other formats (Encoding/Decoding data into another format - http://dogpilecache.readthedocs.org/en/latest/usage.html) and the default is still pickling18:44
*** mylu has joined #openstack-nova18:44
dansmithdims: doesn't that seem kinda scary to you?18:45
dansmithlike, I'm surprised that it even works for nova-objects and leaves them working enough to lazy-load things18:45
*** chhavi has quit IRC18:45
dansmithscary in the security sense18:45
*** ijw has joined #openstack-nova18:46
mriedemdoffm: i think you can drop your -1 on this https://review.openstack.org/#/c/278454/18:46
mriedemandreykurilin: you might be missing a test in https://review.openstack.org/#/c/278454/18:46
*** irenab_ has joined #openstack-nova18:48
dimsdansmith : yep it does18:48
*** danpb has quit IRC18:48
*** irenab has quit IRC18:50
*** irenab_ is now known as irenab18:50
*** Marga_ has quit IRC18:50
*** ijw has quit IRC18:50
*** ljxiash has joined #openstack-nova18:51
*** paul-carlton1 has quit IRC18:51
*** Marga_ has joined #openstack-nova18:51
ansiwendansmith: that was exactly my thought, how can that work? But I concluded that I just don't understand it.18:51
doffmmriedem: Yeahhhh.18:51
openstackgerritChris Dent proposed openstack/nova: Add name to ResourceProvider object  https://review.openstack.org/28194518:52
*** zenoway has joined #openstack-nova18:52
dimsansiwen : dansmith : threw in a but, but did not make it scary - https://bugs.launchpad.net/oslo.cache/+bug/154943818:53
openstackLaunchpad bug 1549438 in oslo.cache "Support option to specify Encoding/Decoding data" [Undecided,New]18:53
*** ctrath has joined #openstack-nova18:53
*** rtheis has joined #openstack-nova18:53
dansmithdims: okay18:53
*** efoley__ has quit IRC18:54
ansiwenSo, do you agree, that it makes no sense to use memcached in the first pace, because it can't be shared anyway?18:54
*** daemontool has quit IRC18:55
*** ljxiash has quit IRC18:55
*** zenoway has quit IRC18:57
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: [microversions] Enable 2.21  https://review.openstack.org/27845418:57
andreykurilin__mriedem: fixed:)18:58
ansiwendims: I don't think that encoding would help here. The problem is, we try to cache a whole object tree here18:58
dimsansiwen : then we should fix what we store/retrieve :)18:58
ansiwendims: exactly18:59
cdentdansmith, dims: dogpiles interface of encouraging the caching of methods is bad news as it makes people think they can just magically cache objects. Much better to explicitly serialize to at least a native dict18:59
*** ijw has joined #openstack-nova18:59
cdentbbl18:59
*** cdent has quit IRC18:59
dansmithagree19:00
dansmithagree19:00
dansmithoops :)19:00
dansmithbut .. really agree :)19:00
sdaguemriedem: ok, I'm going to step away from the keyboard for a bit. Review on the stack of test patches would be nice. Once those actually get in I can dump context and start working on the metadata server testing stack.19:00
dims+1 to do better :)19:01
*** haomaiwang has quit IRC19:01
*** 16WAAEDST has joined #openstack-nova19:01
ansiwenI think a first improvement would be to always use the internal cache in this case19:02
mriedemandreykurilin__: +219:03
mriedemnow you have to summon Vek19:03
*** ijw has quit IRC19:04
andreykurilin__mriedem: wow! thanks:) I'm happy19:04
andreykurilin__Vek: hi! I need your good mark for https://review.openstack.org/278454 :)19:05
*** ijw has joined #openstack-nova19:05
openstackgerritSean M. Collins proposed openstack/os-vif: Fix calls to create_ovs_vif_port  https://review.openstack.org/28435319:06
openstackgerritSean M. Collins proposed openstack/os-vif: [WIP] Add mtu attribute to Network object  https://review.openstack.org/28420919:07
*** lpetrut has joined #openstack-nova19:08
*** josecastroleon has quit IRC19:09
mriedemmelwitt: i think you're probably super happy with this now https://review.openstack.org/#/c/282012/19:09
*** Sukhdev has joined #openstack-nova19:10
*** browne has quit IRC19:11
mriedemsdague: if you had pep8 passing that would be easier :)19:11
mriedemoh hi-o!19:11
dimsmriedem : i keep getting bitten by pep8 too :)19:12
*** jwcroppe has joined #openstack-nova19:13
*** jbernard_ is now known as jbernard19:13
*** zenoway has joined #openstack-nova19:14
openstackgerritKevin Benton proposed openstack/nova: Use MTU value from Neutron in OVS/LB VIF wiring  https://review.openstack.org/28384719:14
*** rodrigods has quit IRC19:16
*** rodrigods has joined #openstack-nova19:16
*** zenoway has quit IRC19:16
*** zenoway has joined #openstack-nova19:17
*** READ10 has quit IRC19:19
*** belmoreira has joined #openstack-nova19:20
openstackgerritSean M. Collins proposed openstack/os-vif: [WIP] Add mtu attribute to Network object  https://review.openstack.org/28420919:21
*** irenab_ has joined #openstack-nova19:23
*** irenab has quit IRC19:25
*** jwcroppe has quit IRC19:25
*** irenab has joined #openstack-nova19:26
*** irenab_ has quit IRC19:28
*** claudiub|2 has joined #openstack-nova19:28
*** eil397 has quit IRC19:29
*** ctrath has quit IRC19:30
doffmandreykurilin__: Yeah thanks for that patch. I suppose I should have done that after getting the instance actions server stuff in.19:33
*** browne has joined #openstack-nova19:37
*** ducttape_ has quit IRC19:38
*** irenab has quit IRC19:39
*** fawadkhaliq has quit IRC19:40
*** irenab has joined #openstack-nova19:41
*** yamahata has quit IRC19:41
*** rtheis has quit IRC19:42
*** cfcp1 has joined #openstack-nova19:42
*** rtheis has joined #openstack-nova19:43
*** mylu has quit IRC19:44
*** mylu has joined #openstack-nova19:44
openstackgerritDan Smith proposed openstack/nova: Test to validate obj_make_compatible() strips old attributes  https://review.openstack.org/28079519:45
dansmithcan we please land that ASAP? It's rebase-bait :(19:45
dansmithalaski: jaypipes: mriedem ^19:45
andreykurilin__doffm:  my pleasure. I'm happy to do novaclient better :)19:45
*** mylu has quit IRC19:46
*** rtheis has quit IRC19:47
*** mylu has joined #openstack-nova19:48
*** omnipresent has joined #openstack-nova19:49
*** ducttape_ has joined #openstack-nova19:49
sdaguemriedem: doh!19:49
mriedemsdague: on the base change, i had one thing about the version in the header19:50
mriedemchecking for that19:50
mriedemthen i'm +219:50
openstackgerritSean Dague proposed openstack/nova: complete the removal of api_version from rest client parameters  https://review.openstack.org/28425719:50
*** rtheis has joined #openstack-nova19:51
oomichisdague: hi, about https://review.openstack.org/#/c/282012/19:52
*** zenoway has quit IRC19:53
oomichiwhat is a difference from Tempest tests? is that more lightwieght tests?19:53
jaypipessdague: may I get your help please? http://paste.openstack.org/show/488087/ been a couple months since I ran tox on nova locally and yet again I'm bombing on some pip versioning thing :(19:53
*** bklei has quit IRC19:54
mriedemdansmith: so to test this, i add or remove an attribute on an object and if i didn't add a compat check it should fail, right19:54
sdaguemriedem: so, it feels like that level of extra checking on headers to ensure that no one can use it wrong is about 2 orders of magnitude more locked down than any other convenience interface we have in the test stack19:55
sdagueas such, it seems overkill now, and could have unintended fallout / unwind later19:55
rlrossitdansmith: I was hoping we wouldn't have to add another static dict that we have to keep updating like the fingerprint dict...19:55
*** rtheis has quit IRC19:56
sdagueoomichi: for anything that doesn't require an actual kvm guest, testing in the functional tree is at least 10 times if not 100 or 1000 times more efficent19:56
*** rtheis has joined #openstack-nova19:56
sdaguejaypipes: looking19:56
mriedemsdague: i thought you wanted things done in a very specific way?19:56
mriedembecause part of the problem is random craziness in the tests19:57
sdaguemriedem: can we not solve this in parts?19:57
mriedemblerg, sec19:57
mriedemi have to finish up dan's review first19:58
sdaguemriedem: I'm feeling like the answer to cleaning up parts of this is that unless there is a fully formed perfect architecture for 20,000 existing tests we can't do anything19:58
sdaguejaypipes: virtualenv --version?19:58
*** irenab_ has joined #openstack-nova19:58
*** irenab has quit IRC19:59
*** irenab_ is now known as irenab19:59
oomichisdague: I see, thanks19:59
*** omnipresent has quit IRC20:00
edleafejaypipes: yeah, you need to update virtualenv20:00
edleafejaypipes: a few people got burned by that recently20:00
*** zenoway has joined #openstack-nova20:00
sdagueoomichi: for instance, there is no way we could land a tempest test for these kinds of regressions. We'd end up with 4 hour tempest run.20:00
*** 16WAAEDST has quit IRC20:01
*** penick has joined #openstack-nova20:01
sdaguemany of them run in 2 or 3 seconds in the functional tree, and work on any laptop20:01
*** rtheis has quit IRC20:01
*** haomaiwang has joined #openstack-nova20:01
jaypipessdague, edleafe: should I install virtualenv in a particular way? via pip?20:01
sdaguejaypipes: via pip20:02
jaypipesk20:02
*** omnipresent has joined #openstack-nova20:02
sdaguehowever, I found that 14 is dicey on ubuntu20:02
dansmithrlrossit: well, my magic 8 ball can't tell me when a thing was added20:02
sdaguepip install -U "virtualenv<14"20:02
sdagueis probably the most reliable20:02
*** irenab has quit IRC20:02
jaypipesffs,,,20:03
jaypipessdague: installed virtualenv 13.1.2. same error after clearing .tox directory. tried virtualenv 14.0.2. same error. :(20:03
sdaguejaypipes: https://github.com/pypa/virtualenv/issues/86920:03
sdaguejaypipes: hmmm....20:03
sdaguetox --version?20:03
jaypipeslemme check that20:04
jaypipesjaypipes@uberbox:~/repos/nova$ tox --version20:04
jaypipes2.1.1 imported from /usr/lib/python3/dist-packages/tox/__init__.py20:04
oomichisdague: yeah, I got the merit so well.20:04
*** ociuhandu has quit IRC20:04
sdaguejaypipes: python3 you say?20:04
*** irenab has joined #openstack-nova20:04
*** zenoway has quit IRC20:05
jaypipessdague: yes... is there something bad about that?20:05
*** dedery_ has quit IRC20:05
sdaguewell, what virtualenv / pip is python 3 using20:06
sdaguebecause if you are executing tox as python320:06
sdaguejaypipes@uberbox:~/repos/nova$ pip --version20:06
sdaguepip 8.0.2 from /usr/local/lib/python2.7/dist-packages (python 2.7)20:06
sdagueisn't the pip you are using20:06
jaypipesle sigh.20:07
*** zenoway has joined #openstack-nova20:07
jaypipespython packaging is becoming almost as bad as ruby.20:07
mriedemdansmith: should dropping attributes be caught by that test, or only adding?20:07
mriedemb/c https://gist.github.com/mriedem/c10fb017ee10c7cd2d33 wasn't a problem20:07
dansmithwell, you can't drop things20:08
dansmithwithout a major bump20:08
dansmithso it's looking for the opposite20:08
jaypipessdague: so, if I run tox -epy27, it creates the virtualenv but then attempts to do: /home/jaypipes/repos/nova/.tox/py27/bin/pip -chttps...20:08
mriedemok,20:09
mriedemtesting adding a thing w/o compat20:09
sdaguejaypipes: /home/jaypipes/repos/nova/.tox/py27/bin/pip --version20:09
jaypipessdague:20:09
jaypipesjaypipes@uberbox:~/repos/nova$ /home/jaypipes/repos/nova/.tox/py27/bin/pip --version20:09
jaypipespip 1.5.6 from /home/jaypipes/repos/nova/.tox/py27/local/lib/python2.7/site-packages (python 2.7)20:09
sdagueyep so that's the problem20:09
sdaguebecause tox is in your python 3 toolchain, and `which pip` is in your python 2 toolchain, pip install -U virutualenv only updated python220:10
sdagueyour python 3 virtualenv is ancient20:10
*** omnipresent has quit IRC20:10
sdaguepip install -U tox probably fixes it20:10
sdaguebecause that will stomp the system tox to python220:11
mriedemdansmith: https://gist.github.com/mriedem/c4f31e9849a260cb7a0d doesn't fail20:11
jaypipessdague: http://paste.openstack.org/show/488091/20:11
*** omnipresent has joined #openstack-nova20:12
dansmithmriedem: that's because instance isn't in the table20:12
sdaguejaypipes: tox --version?20:12
*** yassine__ has quit IRC20:12
mriedemdansmith: ok, that's what i thought20:12
jaypipessdague: jaypipes@uberbox:~/repos/nova$ tox --version20:12
jaypipes2.1.1 imported from /usr/lib/python3/dist-packages/tox/__init__.py20:12
sdaguedo you have a pip3 ?20:13
jaypipesnope. or at least, which pip3 doesn't return anything.20:13
mriedemdansmith: fixed ips is in the table though and this doesn't fail either https://gist.github.com/mriedem/c6e869b8a91e1f98ea0420:14
sdaguejaypipes: sudo apt-get remove python-tox ?20:15
dansmithmriedem: I just got done adding all the fields that we've added over the last two weeks because this was failing, so it should be working,20:15
dansmithmriedem: but instance should also be in there20:15
dansmithso I dunno20:15
dansmithI feel like maybe I don't care enough to fix this20:15
*** zenoway has quit IRC20:16
*** rhagarty_ has quit IRC20:16
*** rhagarty_ has joined #openstack-nova20:16
jaypipessdague: lol. wtf... http://paste.openstack.org/show/488093/20:16
sdaguejaypipes: honestly, I've tried very hard to not let python3 creep into my toolchain for doing stuff to openstack for reasons like this, because it kind of all falls appart20:16
mriedemdansmith: yeah...20:16
*** zenoway has joined #openstack-nova20:17
sdaguejaypipes: dpkg -S /usr/lib/python3/dist-packages/tox/__init__.py20:17
sdaguefigure out where the damn thing is coming from20:17
sdagueor, alternatively `which tox`20:17
jaypipesjaypipes@uberbox:~/repos/nova$ dpkg -S /usr/lib/python3/dist-packages/tox/__init__.py20:17
jaypipestox: /usr/lib/python3/dist-packages/tox/__init__.py20:17
sdaguebecause you just need a python2 tox, and then I think you'll be good20:18
jaypipesjaypipes@uberbox:~/repos/nova$ which tox20:18
jaypipes/usr/local/bin/tox20:18
sdagueyeh, so apt-get remove that20:18
sdagueand does the file look like it will run python220:18
_gryfjaypipes, I think that tox may just trying to use wrong version of interpreter to run the tests20:18
sdague_gryf: no, it's not getting that far20:19
sdague_gryf: tox will use the right version to run the tests once it can build environments, it's the bootstrapping thats the issue20:19
jaypipessdague: ah.... so I needed to apt-get remove *both* python-tox and tox.20:19
sdaguejaypipes: honestly, I would apt-get autoremove20:20
sdaguethere is a bunch of stuff in that list that might get you in trouble20:20
sdaguepython3-virtualenv tox virtualenv20:20
*** omnipresent has quit IRC20:20
*** mylu has quit IRC20:20
_gryfsdague, well, i've stepped on something opposite - running the py3 tests makes for some reason using py2 version of python to actually build the package20:20
sdague_gryf: in which circumstance?20:20
_gryfsdague, my pet project :) wel, the situation was as follows20:21
*** cleong has joined #openstack-nova20:21
sdaguesystem python happens at the top level20:21
_gryfi have the py2 env as a default one20:21
dansmithmriedem: any chance your test is failing to run?20:21
_gryfand wrote py3 little project20:21
dansmithmriedem: I just noticed that the new ServiceStatusPayload object is broken :(20:21
sdagueif the environment isn't one that tox implicitly understands, then you have to set the python version field20:21
*** mylu has joined #openstack-nova20:22
_gryfmade the tox conf for building and running the tests20:22
*** omnipresent has joined #openstack-nova20:22
sdague_gryf: https://github.com/openstack/nova/blob/master/tox.ini#L2920:22
_gryfwhere it turns out that setup.py, which was prepared for py3 was invoked with… py2 :/20:22
*** zenoway_ has joined #openstack-nova20:24
*** irenab_ has joined #openstack-nova20:24
*** irenab has quit IRC20:25
*** irenab_ is now known as irenab20:25
*** zenoway has quit IRC20:25
sdague_gryf: what did you name your environment?20:25
_gryfsdague, does it matter in any way?20:26
sdague_gryf: yes20:26
*** rk4n has quit IRC20:26
sdaguebecause tox has some very magical ones that it does the right thing for20:26
sdagueand everything else, you are on your own20:27
sdaguehttps://bitbucket.org/hpk42/tox/src/4dbfb1f1eb86b35cbd2c83461e1e294651e89cf6/tox/config.py?at=default&fileviewer=file-view-default#config.py-2420:27
*** Bjoern_ has joined #openstack-nova20:27
_gryfsdague, http://paste.openstack.org/show/488096/ it was something like this20:27
_gryfnothing fancy20:27
sdaguethe envlist was actually py34, and not py320:28
*** cdent has joined #openstack-nova20:28
jaypipessdague: k, I apt-get remove'd tox, python-tox, python3-tox, virtualenv, python-virtualenv, python3-virtualenv, then did this: http://paste.openstack.org/show/488097/20:28
jaypipessdague: amazing.20:28
*** omnipresent has quit IRC20:28
_gryfyet, because i'd like to have the package to be built, setup.py is invoked with py220:28
_gryfsdague, yep, that's what i had installed that day20:29
*** zenoway_ has quit IRC20:29
sdague_gryf: well if you show me the actual file I might be able to debug it for you20:29
sdaguejaypipes: yeh, so just re source your .bashrc right?20:29
*** zenoway has joined #openstack-nova20:30
jaypipessdague: gah. doh. /me weeps.20:30
jaypipessdague: ok, running now.20:30
*** irenab_ has joined #openstack-nova20:30
_gryfsdague, i didn;t upload it anywehre right now, because of that weirdness20:30
_gryfsdague, but i will, and i'll appreciate your help :D20:31
*** irenab has quit IRC20:32
*** irenab_ is now known as irenab20:32
jaypipessdague: thx much for your help, Sean20:32
cdentsdague, jaypipes was that bashrc src to get a 'hash -r'20:33
*** omnipresent has joined #openstack-nova20:34
sdaguejaypipes: no problem. In return might I suggest - https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:functional_mv20:36
*** zenoway_ has joined #openstack-nova20:37
*** zenoway has quit IRC20:37
*** omnipresent has quit IRC20:40
cfcp1hi, I'm wondering if someone might have a minute to give me some advice, I'm trying to setup an admin user so that I can start running VMs, but running into trouble on the keystone-install section, while installing python-keystoneclient20:43
cfcp1would anyone be able to advise?20:43
cfcp1the error im getting is:20:43
cfcp1There are no enabled repos.20:43
cfcp1 Run "yum repolist all" to see the repos you have.20:43
cfcp1 You can enable repos with yum-config-manager --enable <repo>20:43
*** rook-rook has quit IRC20:46
*** ihrachys has joined #openstack-nova20:47
*** Marga_ has quit IRC20:48
*** Sukhdev has quit IRC20:48
*** Marga_ has joined #openstack-nova20:48
*** boris-42 has joined #openstack-nova20:53
*** belmoreira has quit IRC20:53
*** jwcroppe has joined #openstack-nova20:54
mriedemcfcp1: this is not the channel to ask that20:56
mriedemtry #openstack20:56
cfcp1alright thanks20:57
mriedemdansmith: which test of mine?20:57
dansmithmriedem: my test you were running20:57
dansmithbut tbh, I'm done with it20:57
auggyjaypipes: i ended up just using pyenv and i created an openstack virtualenv, pyenv lets you do it by directory20:57
dansmiththe instance bug is because I wasn't running 1.1->1.0 on anything20:57
dansmithand after doing that, all kinds of other stupid behaviors from other objects popped out20:57
auggyin perl we have this neat tool called perlbrew that lets you run different perls all over the place ;)20:57
dansmithand so I just don't care anymore20:57
mriedemdansmith: it ran {0} nova.tests.unit.objects.test_objects.TestObjectAttributes.test_obj_make_compatible [0.213682s] ... ok20:57
*** cfcp1 has left #openstack-nova20:58
mriedemdansmith: you have to care!20:58
dansmithmriedem: okay, well, when I run it in tox/testr, I get that but when I run with unittest, I get a can-never-be-true failure20:58
*** rlrossit has quit IRC20:59
dansmithand rlrossit hurt my feelings20:59
mriedemhe'll do that20:59
*** penick has quit IRC21:00
* melwitt cues Phil Collins song21:00
mriedemwhich one?21:00
*** haomaiwang has quit IRC21:01
dansmithheh21:01
melwitt"I don't care anymore"21:01
melwittof course21:01
mriedemoh21:01
mriedemi thought sisudio21:01
*** haomaiwang has joined #openstack-nova21:01
auggyor the land of confusion?21:01
mriedem*sussudio21:01
*** achanda has quit IRC21:01
*** xyang1 has quit IRC21:02
* cdent realizes that mriedem is the dood in american psycho21:02
mriedemloved the movie21:02
mriedemthe book was rough21:02
mriedemit's about 1000x more graphic21:02
cdentwe should exchange business cards21:03
mriedemmine is bone21:03
* cdent lets dansmith follow up on that one21:03
*** aysyd has quit IRC21:03
*** ducttape_ has quit IRC21:04
*** ducttape_ has joined #openstack-nova21:04
auggyi keep thinking of jim carrey as the lead dude in the american psycho movie, even though it was actually batman21:05
*** andrearosa_web has quit IRC21:06
* cdent tries to imagine that21:06
*** rtheis has joined #openstack-nova21:06
mriedemjim carey makes everything infinitely worse21:07
*** Kennan has quit IRC21:08
*** Kennan has joined #openstack-nova21:08
*** annasort has quit IRC21:08
*** ctrath has joined #openstack-nova21:08
*** mylu has quit IRC21:09
mriedemdoffm: can you update https://review.openstack.org/#/c/201606/ after the cells meeting and then i'll +221:09
*** mylu has joined #openstack-nova21:09
*** thorst is now known as thorst_afk21:10
*** pcaruana has quit IRC21:10
*** ihrachys has quit IRC21:17
*** mingyu has quit IRC21:19
*** rlrossit_ has joined #openstack-nova21:19
*** lpetrut has quit IRC21:19
*** mingyu has joined #openstack-nova21:19
mriedemkevinbenton: tsk tsk https://review.openstack.org/#/c/283847/21:21
*** mylu has quit IRC21:24
*** smatzek__ has quit IRC21:24
*** salv-orl_ has joined #openstack-nova21:27
sdagueon the live migration front is self.driver.live_migration_abort(instance) async?21:27
jaypipessdague: should be, yes.21:27
sdagueso, sending start and end notifications seems weird21:27
*** kylek3h is now known as kylek3h__away21:28
sdaguehttps://review.openstack.org/#/c/277971/15/nova/compute/manager.py21:28
rlrossit_dansmith: maybe I'm too strung out, but from what I can see, your magic 8 ball has no premonition of history in the objects, so there's no way we can enforce removing fields right?21:28
rlrossit_so if someone adds a field, we don't know it wasn't there before, so we can't assert there should be something in object_attributes for it21:28
jaypipessdague: oh, sorry, I thought you were referring to whether the REST API call is a 202 or not.21:28
jaypipessdague: it should be a 202...21:28
rlrossit_if they do add it to the static dict, then we can start asserting on it21:29
jaypipessdague: I wasn't referring to whether the driver call was an RPC cast.21:29
*** salv-orlando has quit IRC21:29
sdaguejaypipes: we're in the compute manager, this isn't rpc21:29
jaypipessdague: so those two notifications essentially wrap the dom.abortJob() call. I don't see a problem with that in order to have external systems understand how long the abort took?21:30
sdagueself.driver.live_migration_abort(instance) -> dom.abortJob()21:30
sdaguewell, only if that's synchronous, right21:30
sdagueif that's just a signal then the answer is 021:31
sdaguethat was the question21:31
jaypipesI see.21:31
jaypipesok, sorry to interrupt you. I don't know the answer to that question.21:31
sdagueoh, no, it looks like it's a sync call - https://libvirt.org/sources/java/javadoc/org/libvirt/Domain.html#abortJob()21:32
openstackgerritSylvain Bauza proposed openstack/nova: Add test for unshelve in the conductor API  https://review.openstack.org/28442021:33
openstackgerritChris Friesen proposed openstack/nova: check max_net_count against min_count when booting  https://review.openstack.org/28386121:33
bauzas https://review.openstack.org/284420 : the longest UT ever21:34
*** ekarlso- has quit IRC21:34
*** ekarlso- has joined #openstack-nova21:34
jaypipesbauzas: you know my opinion on the shelve API :)21:34
cfriesen^ Minor fixup when booting multiple instances at once.21:35
bauzasjaypipes: heh, yeah :)21:35
bauzasjaypipes: but we have to support it :D21:35
sdaguebauzas: can you actually sleep 0?21:35
bauzassdague: not really21:35
bauzassdague: I tried21:35
sdaguehow about 0.0121:36
bauzasmaybe, lemme try locally21:36
bauzassdague: btw. I saw my problem about mock.ANY21:36
sdagueadding real sleep delays into the tests ends up covering up other async issues21:36
openstackgerritBrian Haley proposed openstack/nova: Implement setup_networks_on_host for Neutron networks  https://review.openstack.org/27507321:36
sdaguebauzas: what was it?21:36
bauzasit wasn't due to mock.ANY but rather the instance object21:36
sdagueah21:36
bauzaswhich is dehydrated over the wirtre21:36
bauzasso the ref changes21:37
sdagueok, that makes me feel better about the universe21:37
bauzasand since 2 objects aren't __eq__ so...21:37
jaypipessdague: omg test_server_groups makes me vomit.21:39
dansmithrlrossit_: it cat with a 1.0 element that removes everything, which I was trying to avoid for the mess21:40
dansmithrlrossit_: but I'm giving up on it, so just don't worry about it21:40
dansmith*can21:40
rlrossit_dansmith: :(21:41
openstackgerritKevin Benton proposed openstack/nova: Use MTU value from Neutron in OVS/LB VIF wiring  https://review.openstack.org/28384721:41
*** krtaylor has quit IRC21:41
*** mtanino__ has joined #openstack-nova21:41
sdaguejaypipes: yeh, well one thing at a time21:43
*** achanda has joined #openstack-nova21:43
*** achanda has quit IRC21:45
bauzassdague: so, sleep(0.01) sucks, but sleep(.1) does21:45
*** ndipanov has quit IRC21:45
jaypipessdague: yeah, I know... just slogging through the test code :)21:45
bauzassdague: ideally, I would signal that the mock is ready, because either time makes me a bit worried21:47
bauzasit's racy a lot21:47
*** cleong has quit IRC21:48
bauzassdague: hence me initially proposing 0.5 as a safeguard - to make sure that a slow node wouldn't -1 the job21:48
bauzassdague: so, open to ideas for seeing how we could mock a ServiceFixture related method21:48
sdaguebauzas: is this addressed if yuo do castascall?21:49
bauzassdague: oh21:49
*** _ducttape_ has joined #openstack-nova21:50
sdagueself.useFixture(cast_as_call.CastAsCall(self.stubs))21:50
sdagueit's used in all the full stack tests, as well as a bunch of conductor tests21:50
bauzasyeah21:50
bauzasI forgot that21:50
bauzasthat would help for sure21:51
bauzasbecause it should wait for the return21:51
sdagueyep21:51
bauzasgreat catch, thanks21:51
sdagueno prob21:51
bauzasI was knowing the trick, but I forgot :(21:51
bauzastesting now21:51
*** mylu has joined #openstack-nova21:53
bauzasawesomeness21:53
*** ducttape_ has quit IRC21:54
bauzassdague: <321:54
*** Sukhdev has joined #openstack-nova21:54
*** krtaylor has joined #openstack-nova21:55
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Trying latest oslo.* from master  https://review.openstack.org/27520121:56
*** jwcroppe has quit IRC21:57
*** gmann_ has quit IRC21:58
*** oomichi has quit IRC22:00
*** oomichi_ has joined #openstack-nova22:00
*** oomichi_ is now known as oomichi22:00
*** sc68cal has quit IRC22:00
*** haomaiwang has quit IRC22:01
*** haomaiwang has joined #openstack-nova22:01
openstackgerritSylvain Bauza proposed openstack/nova: Add test for unshelve in the conductor API  https://review.openstack.org/28442022:03
*** Sukhdev has quit IRC22:03
*** knikolla has quit IRC22:05
*** ljxiash has joined #openstack-nova22:07
openstackgerritMark Doffman proposed openstack/nova: Creates flavor* tables in API database  https://review.openstack.org/20160622:08
mriedemsdague: your thing is +W22:08
sdaguemriedem: thanks22:08
sdagueok, have a good evening folks22:10
*** ljxiash has quit IRC22:10
*** daemontool has joined #openstack-nova22:11
openstackgerritMark Doffman proposed openstack/nova: Creates flavor* tables in API database  https://review.openstack.org/20160622:13
*** Sukhdev has joined #openstack-nova22:14
*** dims has quit IRC22:14
*** _ducttape_ has quit IRC22:14
*** ducttape_ has joined #openstack-nova22:15
*** Sukhdev has quit IRC22:17
*** Sukhdev has joined #openstack-nova22:17
*** raildo is now known as raildo-afk22:19
*** cody-somerville has joined #openstack-nova22:19
*** smatzek__ has joined #openstack-nova22:21
openstackgerritAndrew Laski proposed openstack/nova: Create Instance from BuildRequest if not in a cell  https://review.openstack.org/26392722:21
openstackgerritAndrew Laski proposed openstack/nova: Populate instance_mappings during boot  https://review.openstack.org/26392522:21
*** daemontool has quit IRC22:23
*** _ducttape_ has joined #openstack-nova22:25
openstackgerritMatt Riedemann proposed openstack/nova: Add functional regression test for list deleted instances on v2.16  https://review.openstack.org/28383722:25
*** penick has joined #openstack-nova22:27
*** ducttape_ has quit IRC22:28
*** mrsoul has quit IRC22:28
*** Sukhdev has quit IRC22:29
*** haplo37 has quit IRC22:29
*** oomichi_ has joined #openstack-nova22:30
*** oomichi_ has quit IRC22:30
*** oomichi_ has joined #openstack-nova22:30
*** oomichi_ has quit IRC22:31
mriedemoomichi: do you know takashin?22:31
mriedemor if he is ever on irc22:31
mriedem?22:31
*** mrsoul has joined #openstack-nova22:32
*** delattec has joined #openstack-nova22:34
mriedemoomichi: if so, please tell him to reply or remove his -1 from this :) https://review.openstack.org/#/c/279839/22:34
oomichimriedem: I don't know takashin, which patch owner?22:35
* oomichi is setting up ZNC, not familer with it yet22:35
*** mylu has quit IRC22:36
oomichimriedem: ah, he is the other company guy and I met him once22:36
oomichiwill catch him via his coworker22:37
*** cdelatte has quit IRC22:37
*** smatzek__ has quit IRC22:37
mriedemthanks, i assumed maybe he was on irc when i wasn't due to timezone or something22:37
*** mylu has joined #openstack-nova22:38
*** vishwana_ is now known as vishwanathj22:39
oomichimriedem: yeah, now he just wakes up his timezone22:40
oomichi7:40am22:40
mriedemoomichi: obviously he's not hard-core such as yourself working already :)22:41
mriedemor do you work from home?22:41
oomichimriedem: I have migrated to USA now 2 week ago, we are on the same tz ;)22:42
mriedemoh wow22:42
mriedemwhere are you living?22:42
*** rtheis has quit IRC22:42
oomichiSan Jose, CA22:42
mriedemah, 2 hours different from me, but much closer than japan22:43
oomichimriedem: yeah, nice to meet you22:43
oomichibut now I am in Boston for QA code sprint with mtreinish :)22:44
*** aorourke has quit IRC22:44
*** burgerk has quit IRC22:45
mriedemoh right22:45
*** rtheis has joined #openstack-nova22:45
*** aorourke has joined #openstack-nova22:45
*** rfolco has quit IRC22:46
*** apearson has quit IRC22:46
doffmalaski, jaypipes: I'm going through resource pools. I don't see anything cells specific in there. Both of you are happy that you have a solution?22:47
*** jdillaman has quit IRC22:48
*** zenoway_ has quit IRC22:48
mriedemthe first rule of cells + resource pools,22:49
mriedemis not to ask about cells + resource pools22:49
jaypipesdoffm: yeah. the agreement was that we would house the resource_providers schema tables in the cell child database and the nova resource-pool-create would require an --aggregate-uuid argument.22:50
doffmjaypipes: Ok, that makes sense, but you were opposed to having the cell_id in the api. If the resource pool goes in a cell won't we still need a cell_id to know where to create it?22:52
jaypipesdoffm: the aggregate_uuid -> cell_id will be mapped in the API database.22:52
doffmAhhhh.22:52
doffmI was missing that bit.22:52
mriedembauzas: alaski: +2 on https://review.openstack.org/#/c/201606/ now that doffm fixed the flavors.root_gb nullable thing22:53
jaypipesdoffm: :)22:54
*** ctrath has quit IRC22:54
*** sheel has quit IRC22:57
alaskidoffm: yeah, I think we have it worked out with the above. but definitely poke holes if you see them22:59
*** mriedem has quit IRC23:00
*** jdillaman has joined #openstack-nova23:00
*** zenoway has joined #openstack-nova23:00
*** haomaiwang has quit IRC23:01
*** thorst_afk is now known as thorst23:01
*** haomaiwang has joined #openstack-nova23:01
*** burt has quit IRC23:01
*** claudiub has joined #openstack-nova23:02
doffmalaski: Still thinking about it. Is this described in the spec anywhere? If not I'm fine with that, will review as-is. But we should get down the cells plan soonish.23:02
doffmI see the aggregates stuff there, but not the mapping.23:02
alaskijust the aggregate stuff, not the cells specifics23:03
*** mdrabe has quit IRC23:03
alaskiuntil we move aggregates up to the api db we can't really use them to map23:04
*** zenoway has quit IRC23:04
*** claudiub|2 has quit IRC23:05
doffmYeah.23:05
doffmI'd better get the spec up for moving aggregates to the api.23:06
*** dims has joined #openstack-nova23:08
*** rlrossit_ has quit IRC23:10
openstackgerritAngus Lees proposed openstack/nova: Add os-brick rootwrap filter for privsep  https://review.openstack.org/27767023:10
openstackgerritAngus Lees proposed openstack/nova: Require privsep-based os-brick  https://review.openstack.org/27767123:10
*** achanda has joined #openstack-nova23:10
openstackgerritBartosz Górski proposed openstack/python-novaclient: Adds missing internationalization for help message  https://review.openstack.org/28445823:13
*** ccarmack has quit IRC23:13
openstackgerritAngus Lees proposed openstack/nova: Add os-brick rootwrap filter for privsep  https://review.openstack.org/27767023:14
openstackgerritAngus Lees proposed openstack/nova: Require privsep-based os-brick  https://review.openstack.org/27767123:14
*** _ducttape_ has quit IRC23:15
*** Sukhdev has joined #openstack-nova23:15
*** rtheis has quit IRC23:16
*** rtheis has joined #openstack-nova23:16
*** edtubill has quit IRC23:16
*** rtheis has quit IRC23:17
*** rtheis has joined #openstack-nova23:17
*** rtheis has quit IRC23:17
*** pushkaru has quit IRC23:18
*** rk4n has joined #openstack-nova23:18
*** abitha has joined #openstack-nova23:20
jaypipesdansmith: just wrapping up the compute_node_get_all patch.23:21
*** eharney has quit IRC23:23
*** Swami has quit IRC23:24
*** zenoway has joined #openstack-nova23:25
*** vilobhmm11 has quit IRC23:25
*** vilobhmm11 has joined #openstack-nova23:25
dansmithjaypipes: okay, I'll start on the one on top in the morning23:26
jaypipesdansmith: sorry for the delay.23:26
dansmiths'ok23:26
jaypipesdansmith: just adding some tests to double-check my SQL-work.23:26
dansmithit'll be what it'll be23:27
*** armax has quit IRC23:27
*** armax has joined #openstack-nova23:28
*** armax has quit IRC23:28
*** dimtruck is now known as zz_dimtruck23:28
*** zenoway has quit IRC23:29
*** cody-somerville has quit IRC23:29
*** Guest75 has joined #openstack-nova23:35
*** Guest75 has quit IRC23:37
shaohe_feng_johnthetubaguy:  ping. I's like to talk about the  in progress migration23:40
shaohe_feng_sdague: ping.23:41
*** hemna is now known as hemnafk23:41
*** mylu has quit IRC23:44
*** pushkaru has joined #openstack-nova23:45
*** Bjoern_ has quit IRC23:46
jaypipesshaohe_feng: it's nearly midnight for johnthetubaguy, FYI.23:46
*** cdent has quit IRC23:47
*** mylu has joined #openstack-nova23:48
shaohe_feng_jaypipes: got it. thank you.23:48
*** thorst has quit IRC23:48
*** Guest75 has joined #openstack-nova23:49
*** mylu has quit IRC23:50
*** pushkaru has quit IRC23:52
shaohe_feng_jaypipes: would you like to look at my patch?  https://review.openstack.org/#/c/258771/2923:57
jaypipesshaohe_feng: yup, will do shortly.23:57
shaohe_feng_jaypipes: Thanks.23:58
*** mrkz has quit IRC23:58
*** y_sawai has joined #openstack-nova23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!