| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwa_ has joined #openstack-nova | 00:01 | |
| *** mriedem is now known as mriedem_away | 00:10 | |
| *** zhangjn has joined #openstack-nova | 00:11 | |
| *** zhangjn has quit IRC | 00:15 | |
| *** pratikmallya has quit IRC | 00:24 | |
| *** oomichi has joined #openstack-nova | 00:32 | |
| *** jinxing has joined #openstack-nova | 00:41 | |
| *** Piet has joined #openstack-nova | 00:47 | |
| *** zhangjn has joined #openstack-nova | 00:56 | |
| *** zhangjn has quit IRC | 00:56 | |
| *** zhangjn has joined #openstack-nova | 00:57 | |
| *** davideagnello has joined #openstack-nova | 01:00 | |
| *** haomaiwa_ has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-nova | 01:01 | |
| *** zhangjn_ has joined #openstack-nova | 01:02 | |
| *** zhangjn has quit IRC | 01:04 | |
| *** EinstCrazy has joined #openstack-nova | 01:04 | |
| *** EinstCrazy has quit IRC | 01:04 | |
| *** EinstCrazy has joined #openstack-nova | 01:04 | |
| *** zhenguo has joined #openstack-nova | 01:15 | |
| *** makkie- has quit IRC | 01:22 | |
| *** Nathan__ has joined #openstack-nova | 01:23 | |
| *** Nathan__ is now known as Nathan | 01:23 | |
| *** haomaiwang has quit IRC | 01:25 | |
| *** RuiChen has quit IRC | 01:27 | |
| *** RuiChen has joined #openstack-nova | 01:28 | |
| gmann | alex_xu_: hi | 01:38 |
|---|---|---|
| eliqiao | gmann: alex is not around yet. :) | 01:50 |
| gmann | eliqiao: ohk, Thanks :) | 01:50 |
| gmann | ll catch him later | 01:50 |
| *** mitz has left #openstack-nova | 01:56 | |
| *** jinxing has quit IRC | 01:59 | |
| *** su_zhang has joined #openstack-nova | 02:01 | |
| *** otter768 has quit IRC | 02:02 | |
| *** jinxing has joined #openstack-nova | 02:03 | |
| *** jinxing_ has joined #openstack-nova | 02:04 | |
| *** jinxing has quit IRC | 02:07 | |
| *** ildikov has quit IRC | 02:09 | |
| *** seanw1 has quit IRC | 02:16 | |
| *** haomaiwa_ has joined #openstack-nova | 02:16 | |
| *** Nathan has quit IRC | 02:17 | |
| *** seanw1 has joined #openstack-nova | 02:17 | |
| *** haomaiwa_ has quit IRC | 02:19 | |
| *** haomaiwang has joined #openstack-nova | 02:19 | |
| *** haomaiwang has quit IRC | 02:19 | |
| *** haomaiwang has joined #openstack-nova | 02:19 | |
| *** haomaiwang has quit IRC | 02:21 | |
| *** haomaiwang has joined #openstack-nova | 02:22 | |
| *** jyuso1 has joined #openstack-nova | 02:30 | |
| *** vilobhmm11 has quit IRC | 02:31 | |
| *** jinxing_ has quit IRC | 02:32 | |
| *** jinxing has joined #openstack-nova | 02:32 | |
| *** aloga has joined #openstack-nova | 02:37 | |
| *** haomaiwang has quit IRC | 02:40 | |
| *** haomaiwang has joined #openstack-nova | 02:43 | |
| *** tjones has joined #openstack-nova | 02:44 | |
| *** jinxing has quit IRC | 02:46 | |
| *** jinxing has joined #openstack-nova | 02:50 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Remove duplicate keys in policy.json https://review.openstack.org/242902 | 02:52 |
| alex_xu_ | gmann: hi, I | 02:52 |
| *** vilobhmm11 has joined #openstack-nova | 02:52 | |
| alex_xu_ | 'm here | 02:52 |
| *** venkat_p has joined #openstack-nova | 02:52 | |
| *** su_zhang has quit IRC | 02:52 | |
| gmann | alex_xu_: quick question on swagger POC | 02:54 |
| alex_xu_ | gmann: yea | 02:54 |
| gmann | alex_xu_: where we can have ref for APi sample files? | 02:54 |
| gmann | alex_xu_: we will have schema, param, desc etc | 02:55 |
| alex_xu_ | gmann: actually I haven't answer yet :( I'm also think about that | 02:55 |
| gmann | alex_xu_: ahh | 02:55 |
| alex_xu_ | gmann: the most simple way is like api sample test which write the file name in the test | 02:55 |
| alex_xu_ | gmann: or resturcture the api sample files directory, make it found by something like url routes | 02:56 |
| gmann | alex_xu_: and those will be directly consumed by swagger UI not swagger.json right? | 02:57 |
| alex_xu_ | gmann: it should be swagger.json | 02:58 |
| gmann | alex_xu_: but not sure UI can take those separate or we need to bundle it in json | 02:58 |
| alex_xu_ | gmann: the swagger spec support output/input example directly | 02:58 |
| dims | alex_xu_ congrats! | 02:58 |
| alex_xu_ | dims: thanks :) | 02:59 |
| gmann | alex_xu_: ahh, thats what i was looking for | 02:59 |
| gmann | alex_xu_: did not find in http://editor.swagger.io/#/ | 02:59 |
| alex_xu_ | gmann: let me find the link for you | 02:59 |
| alex_xu_ | gmann: the spec describe it at http://swagger.io/specification/#responseObject | 03:00 |
| alex_xu_ | the 'examples' field | 03:00 |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-nova | 03:01 | |
| gmann | alex_xu_: ok, Thanks | 03:03 |
| alex_xu_ | gmann: np | 03:03 |
| *** mspreitz has quit IRC | 03:03 | |
| gmann | alex_xu_: and for request, 'Body' field | 03:07 |
| alex_xu_ | gmann: I remember swagger didn't support example for body | 03:08 |
| *** vilobhmm11 has quit IRC | 03:09 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add timestamp filter support for os-isntance-action API https://review.openstack.org/240401 | 03:13 |
| *** thorst has joined #openstack-nova | 03:14 | |
| gmann | alex_xu_: humm, let me check, i think there should be some way | 03:15 |
| alex_xu_ | gmann: ok | 03:17 |
| *** thorst has quit IRC | 03:19 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add timestamp filtering support for os-migrations API https://review.openstack.org/239869 | 03:19 |
| *** tjones has quit IRC | 03:22 | |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: scale-instance https://review.openstack.org/242913 | 03:26 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Trying to log policy stuff - please ignore https://review.openstack.org/242914 | 03:28 |
| *** davideagnello has quit IRC | 03:30 | |
| *** gongysh_ has quit IRC | 03:34 | |
| *** davideagnello has joined #openstack-nova | 03:40 | |
| *** Sree has joined #openstack-nova | 03:43 | |
| *** davideagnello has quit IRC | 03:45 | |
| *** shaohe_robot1 has quit IRC | 03:45 | |
| *** shaohe_robot has joined #openstack-nova | 03:45 | |
| *** gongysh has joined #openstack-nova | 03:53 | |
| *** zhangjn_ has quit IRC | 03:55 | |
| *** zhangjn has joined #openstack-nova | 03:58 | |
| *** zhangjn has quit IRC | 03:59 | |
| *** zhangjn has joined #openstack-nova | 04:00 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwa_ has joined #openstack-nova | 04:01 | |
| *** otter768 has joined #openstack-nova | 04:02 | |
| *** gongysh has quit IRC | 04:03 | |
| gmann | alex_xu_: looks like currently there is no, but they planned to add those | 04:03 |
| gmann | alex_xu_: https://github.com/swagger-api/swagger-spec/issues/39 | 04:03 |
| gmann | alex_xu_: through "basePathExamples" in API declaration | 04:04 |
| gmann | alex_xu_: I asked them about request thing if they have or plan to add | 04:04 |
| oomichi | alex_xu_: gmann: A new initiative is open: https://openapis.org/ | 04:05 |
| oomichi | alex_xu_: gmann: swagger seems standard in the world :-) | 04:06 |
| *** dims has quit IRC | 04:06 | |
| *** zhangjn has quit IRC | 04:07 | |
| *** otter768 has quit IRC | 04:07 | |
| alex_xu_ | gmann: cool, thanks for the investigate :) | 04:10 |
| alex_xu_ | oomichi: that's cool | 04:11 |
| *** pradipta has joined #openstack-nova | 04:11 | |
| *** dave-mccowan has quit IRC | 04:11 | |
| *** jinxing has quit IRC | 04:11 | |
| *** jinxing has joined #openstack-nova | 04:12 | |
| *** mdrabe has joined #openstack-nova | 04:17 | |
| oomichi | alex_xu_: will you propose nova-spec for swagger? | 04:19 |
| gmann | oomichi: thats nice | 04:20 |
| *** mdrabe has quit IRC | 04:29 | |
| jerrygb | Hi, having a problem nova cli. Could anyone please help | 04:29 |
| jerrygb | nova --debug quota-class-update --server_groups -1 default | 04:29 |
| alex_xu_ | oomichi: yea, will do that | 04:35 |
| *** zhangjn has joined #openstack-nova | 04:35 | |
| *** unicell1 has joined #openstack-nova | 04:36 | |
| alex_xu_ | oomichi: try to work out initial version this afternoon | 04:36 |
| oomichi | alex_xu_: cool :-) | 04:36 |
| *** unicell has quit IRC | 04:37 | |
| alex_xu_ | oomichi: yea, spec is good for us to know what we still need investigate, then let's work out all the issue | 04:37 |
| alex_xu_ | oomichi: how can we get agreement with tempest team on how to share response json-schema between nova and tempest? | 04:38 |
| *** Marga_ has quit IRC | 04:38 | |
| oomichi | alex_xu_: nice point, not yet ;-) | 04:41 |
| oomichi | alex_xu_: my idea was -1d from tempest PTL | 04:42 |
| oomichi | alex_xu_: via swagger | 04:42 |
| alex_xu_ | oomichi: :( | 04:42 |
| oomichi | alex_xu_: kurbernetes provides swagger spec via REST API. | 04:42 |
| alex_xu_ | oomichi: that's cool | 04:43 |
| oomichi | alex_xu_: I am imaging nova also will provide swagger spec via REST API instead of json-home | 04:43 |
| alex_xu_ | oomichi: why tempest PTL doesn't like that? | 04:43 |
| alex_xu_ | oomichi: yea, I'm also | 04:43 |
| oomichi | alex_xu_: then tempest can get response schema for using testing | 04:43 |
| alex_xu_ | oomichi: yup | 04:44 |
| oomichi | alex_xu_: to be honest, I could not catch the point due to fast conversation :( | 04:44 |
| oomichi | alex_xu_: I will discuss it on IRC | 04:44 |
| alex_xu_ | oomichi: it's fine, it's also my problem :) | 04:45 |
| gmann | oomichi: alex_xu_ : or there was another way also to do the validation on Nova (configurable) side than Tempest | 04:45 |
| alex_xu_ | oomichi: cool, thanks | 04:45 |
| gmann | how about that, i forgot the discussion on that | 04:45 |
| oomichi | gmann: yeah, that also nice | 04:45 |
| alex_xu_ | gmann: yea, we will have validation on nova side | 04:45 |
| *** otter768 has joined #openstack-nova | 04:45 | |
| alex_xu_ | gmann: but the tempest side validation can't be removed, is it right? | 04:45 |
| gmann | alex_xu_: response also? | 04:45 |
| alex_xu_ | gmann: yea, response | 04:46 |
| gmann | alex_xu_: oomichi i think can remove from Tempest side and request Nova to do the same | 04:46 |
| gmann | means all Tempest tests will have validation but through Nova | 04:46 |
| gmann | will have -> will do | 04:46 |
| oomichi | alex_xu_: gmann: from the other viewpoint, it is also nice to have same/different schemas on both nova and tempest | 04:47 |
| *** _RuiChen has joined #openstack-nova | 04:47 | |
| oomichi | alex_xu_: gmann: from tempest viewpoint, we can use schema for QA like client viewpoint. | 04:48 |
| oomichi | alex_xu_: gmann: it is nice to have schemas as clients' expectation. | 04:48 |
| gmann | oomichi: you means owner can be Nova and Tempest will sync those as oslo one is being used? | 04:48 |
| alex_xu_ | oomichi: you mean use different set of schemas on both side, then we can know which side is wrong? | 04:49 |
| oomichi | gmann: no, it is not mandatory to sync between nova and tempest | 04:49 |
| gmann | oomichi: but in case of any change in Nova side, we do on Tempest side manually? | 04:50 |
| *** RuiChen has quit IRC | 04:50 | |
| oomichi | alex_xu_: technically, nova side is right in most cases. but from QA viewpoint, tempest side also is nice. | 04:50 |
| alex_xu_ | oomichi: good point | 04:51 |
| oomichi | if schemas are contained in Nova side only, we can change responses in a single patch | 04:51 |
| oomichi | Now we need to post two patches for nova and tempest if breaking something. and we can get good reviews for blocking these changes. | 04:52 |
| oomichi | that is good for QA because we can review patches from different viewpoints. | 04:52 |
| alex_xu_ | yea, true | 04:52 |
| gmann | oomichi: yea nice, but will there be cross dependency ? | 04:52 |
| oomichi | gmann: sorry, I cannot catch it | 04:53 |
| gmann | Nova patch which changing schema can not be land till Tempest one is done and vice versa | 04:53 |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: scale-instance https://review.openstack.org/242913 | 04:53 |
| alex_xu_ | gmann: the schema only changed when microversion bump, so it will be fine | 04:54 |
| alex_xu_ | even there is bug | 04:54 |
| oomichi | alex_xu_: yeah, that is a point | 04:54 |
| gmann | alex_xu_: ah, yea | 04:54 |
| gmann | alex_xu_: oomichi : with that we can detect automatically if someone change schema without microversion (type range etc) | 04:55 |
| alex_xu_ | gmann: yea, that will be nice | 04:56 |
| alex_xu_ | looks like we get rid of one big block :) | 04:56 |
| oomichi | gmann: nice point, but after releasing we cannot make it for a new microversion | 04:57 |
| oomichi | gmann: ah, I misunderstood. that it right | 04:57 |
| *** jamielennox is now known as jamielennox|away | 04:57 | |
| *** haomaiwa_ has quit IRC | 05:01 | |
| *** haomaiwa_ has joined #openstack-nova | 05:01 | |
| *** jinxing_ has joined #openstack-nova | 05:04 | |
| *** jinxing has quit IRC | 05:07 | |
| *** amotoki has joined #openstack-nova | 05:08 | |
| *** otter768 has quit IRC | 05:10 | |
| *** Piet has quit IRC | 05:15 | |
| *** krtaylor has joined #openstack-nova | 05:19 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 05:22 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Enhance value check for option notify_on_state_change https://review.openstack.org/242717 | 05:22 |
| *** jamielennox|away is now known as jamielennox | 05:24 | |
| *** su_zhang has joined #openstack-nova | 05:25 | |
| *** Marga_ has joined #openstack-nova | 05:27 | |
| *** links has joined #openstack-nova | 05:29 | |
| *** venkat_p has quit IRC | 05:32 | |
| *** achanda has quit IRC | 05:38 | |
| *** davideagnello has joined #openstack-nova | 05:41 | |
| *** deepakcs has joined #openstack-nova | 05:41 | |
| *** davideagnello has quit IRC | 05:42 | |
| *** davideagnello has joined #openstack-nova | 05:42 | |
| *** davideagnello has quit IRC | 05:43 | |
| *** venkat_p has joined #openstack-nova | 05:43 | |
| *** salv-orlando has joined #openstack-nova | 05:47 | |
| *** sudipto has joined #openstack-nova | 05:47 | |
| *** lpetrut has joined #openstack-nova | 05:57 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** zhangjn_ has joined #openstack-nova | 06:01 | |
| *** haomaiwang has joined #openstack-nova | 06:01 | |
| *** links has quit IRC | 06:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/242727 | 06:03 |
| *** venkat_p has quit IRC | 06:04 | |
| *** zhangjn has quit IRC | 06:04 | |
| *** madhuri has joined #openstack-nova | 06:05 | |
| *** eliqiao has left #openstack-nova | 06:07 | |
| *** jfding has joined #openstack-nova | 06:07 | |
| *** shaohe_robot is now known as shaohe_feng | 06:09 | |
| *** lpetrut has quit IRC | 06:09 | |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: scale-instance https://review.openstack.org/242913 | 06:11 |
| *** alex_xu_ is now known as alex_xu | 06:14 | |
| *** jyuso1 has quit IRC | 06:15 | |
| *** jyuso1 has joined #openstack-nova | 06:16 | |
| *** zhangjn_ has quit IRC | 06:18 | |
| *** venkat_p has joined #openstack-nova | 06:20 | |
| *** markmc has quit IRC | 06:23 | |
| *** markmc has joined #openstack-nova | 06:24 | |
| *** moshele has joined #openstack-nova | 06:24 | |
| *** mnestratov has joined #openstack-nova | 06:25 | |
| *** zhangjn has joined #openstack-nova | 06:26 | |
| openstackgerrit | Tang Chen proposed openstack/nova: Improve inject_nmi() in libvirt driver and add tests. https://review.openstack.org/208794 | 06:27 |
| *** lpetrut has joined #openstack-nova | 06:28 | |
| *** claudiub has joined #openstack-nova | 06:28 | |
| *** EinstCrazy has quit IRC | 06:32 | |
| *** zhangjn has quit IRC | 06:33 | |
| *** zhangjn has joined #openstack-nova | 06:35 | |
| oomichi | alex_xu: today is nova-api meeting? | 06:35 |
| *** EinstCrazy has joined #openstack-nova | 06:36 | |
| alex_xu | oomichi: no, tomorrow | 06:36 |
| oomichi | alex_xu: ah, i see. thanks | 06:37 |
| alex_xu | oomichi: np :) | 06:37 |
| *** zhangjn has quit IRC | 06:38 | |
| *** achanda has joined #openstack-nova | 06:38 | |
| *** salv-orlando has quit IRC | 06:39 | |
| *** links has joined #openstack-nova | 06:41 | |
| *** oomichi has quit IRC | 06:42 | |
| *** oomichi has joined #openstack-nova | 06:44 | |
| *** zhangjn has joined #openstack-nova | 06:44 | |
| *** mjura has joined #openstack-nova | 06:45 | |
| *** achanda has quit IRC | 06:46 | |
| *** EinstCrazy has quit IRC | 06:46 | |
| *** zhangjn has quit IRC | 06:48 | |
| *** su_zhang has quit IRC | 06:50 | |
| *** amotoki_ has joined #openstack-nova | 06:53 | |
| openstackgerrit | Jianghua Wang proposed openstack/nova: xenapi: OVS agent updates the wrong port when using Xen + Neutron https://review.openstack.org/242846 | 06:53 |
| *** baoli has quit IRC | 06:53 | |
| *** amotoki has quit IRC | 06:54 | |
| *** lpetrut has quit IRC | 06:57 | |
| *** rotbeard has joined #openstack-nova | 07:00 | |
| *** garyk has joined #openstack-nova | 07:00 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| *** jinxing_ has quit IRC | 07:01 | |
| *** lpetrut has joined #openstack-nova | 07:05 | |
| *** jinxing has joined #openstack-nova | 07:05 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: use a constant for 'iscsi' https://review.openstack.org/242828 | 07:05 |
| *** EinstCrazy has joined #openstack-nova | 07:06 | |
| *** lsmola has joined #openstack-nova | 07:09 | |
| openstackgerrit | huan proposed openstack/nova: XenAPI:Resolve Nova/Neutron race condition https://review.openstack.org/241127 | 07:10 |
| *** otter768 has joined #openstack-nova | 07:10 | |
| *** garyk has quit IRC | 07:11 | |
| *** garyk has joined #openstack-nova | 07:11 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 07:11 |
| *** venkat_p has quit IRC | 07:13 | |
| *** otter768 has quit IRC | 07:15 | |
| *** irenab has quit IRC | 07:15 | |
| *** _RuiChen has quit IRC | 07:16 | |
| *** zhangjn has joined #openstack-nova | 07:18 | |
| *** zhangjn has quit IRC | 07:24 | |
| *** venkat_p has joined #openstack-nova | 07:25 | |
| *** RuiChen has joined #openstack-nova | 07:26 | |
| *** Marga_ has quit IRC | 07:26 | |
| *** zhangjn has joined #openstack-nova | 07:26 | |
| *** EinstCrazy has quit IRC | 07:27 | |
| *** EinstCrazy has joined #openstack-nova | 07:27 | |
| *** hjwang has joined #openstack-nova | 07:29 | |
| *** A110602877_ has joined #openstack-nova | 07:32 | |
| *** oomichi_ has joined #openstack-nova | 07:33 | |
| *** browne has quit IRC | 07:34 | |
| *** oomichi has quit IRC | 07:35 | |
| *** romainh has joined #openstack-nova | 07:36 | |
| *** EinstCrazy has quit IRC | 07:37 | |
| *** hjwang has quit IRC | 07:38 | |
| *** scheuran has joined #openstack-nova | 07:38 | |
| *** hjwang has joined #openstack-nova | 07:38 | |
| *** hjwang has quit IRC | 07:39 | |
| *** salv-orlando has joined #openstack-nova | 07:39 | |
| *** shhjwang has joined #openstack-nova | 07:40 | |
| *** lpetrut has quit IRC | 07:40 | |
| *** rdopiera has joined #openstack-nova | 07:40 | |
| *** liusheng has joined #openstack-nova | 07:42 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova-specs: libvirt: runtime image type detection https://review.openstack.org/240163 | 07:42 |
| *** davideagnello has joined #openstack-nova | 07:44 | |
| *** salv-orlando has quit IRC | 07:44 | |
| *** ihrachys has joined #openstack-nova | 07:45 | |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: scale-instance https://review.openstack.org/242913 | 07:46 |
| *** shhjwang has left #openstack-nova | 07:46 | |
| *** RuiChen has quit IRC | 07:46 | |
| *** RuiChen has joined #openstack-nova | 07:47 | |
| *** zhangjn has quit IRC | 07:47 | |
| *** venkat_p has quit IRC | 07:48 | |
| *** irenab has joined #openstack-nova | 07:48 | |
| *** davideagnello has quit IRC | 07:49 | |
| *** lsmola has quit IRC | 07:50 | |
| *** zhangjn has joined #openstack-nova | 07:53 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 07:53 |
| *** zhangjn has quit IRC | 07:54 | |
| *** jinxing_ has joined #openstack-nova | 07:55 | |
| *** liverpooler has joined #openstack-nova | 07:56 | |
| *** jinxing has quit IRC | 07:57 | |
| *** amotoki_ has quit IRC | 07:59 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-nova | 08:01 | |
| *** afazekas is now known as afazekas|sick | 08:01 | |
| *** ihrachys has quit IRC | 08:02 | |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Allow block live migration of an instance with attached volumes https://review.openstack.org/227278 | 08:02 |
| *** zhangjn has joined #openstack-nova | 08:03 | |
| *** lsmola has joined #openstack-nova | 08:04 | |
| *** AJaeger has joined #openstack-nova | 08:04 | |
| *** achanda has joined #openstack-nova | 08:05 | |
| AJaeger | Hi nova cores, could you try importing translations again, please ? https://review.openstack.org/#/c/237411/ failed the tests last night and a new version was uploaded. This one removes especially some old URLs. | 08:06 |
| *** jichen has joined #openstack-nova | 08:09 | |
| *** mpavone has joined #openstack-nova | 08:10 | |
| *** ttx has joined #openstack-nova | 08:10 | |
| *** sahid has joined #openstack-nova | 08:11 | |
| *** venkat_p has joined #openstack-nova | 08:11 | |
| *** amotoki has joined #openstack-nova | 08:11 | |
| *** alex_klimov has joined #openstack-nova | 08:12 | |
| *** amotoki has quit IRC | 08:12 | |
| *** amotoki has joined #openstack-nova | 08:12 | |
| *** baoli has joined #openstack-nova | 08:13 | |
| *** jianghuaw has joined #openstack-nova | 08:14 | |
| *** jianghuaw has quit IRC | 08:15 | |
| *** zigo has quit IRC | 08:16 | |
| *** A110602877_ has quit IRC | 08:17 | |
| *** mpavone has quit IRC | 08:17 | |
| *** baoli has quit IRC | 08:18 | |
| *** zigo has joined #openstack-nova | 08:19 | |
| *** ihrachys has joined #openstack-nova | 08:20 | |
| *** lpetrut has joined #openstack-nova | 08:21 | |
| *** nkrinner has joined #openstack-nova | 08:25 | |
| *** venkat_p has quit IRC | 08:26 | |
| *** zhangjn has quit IRC | 08:27 | |
| *** alex_klimov has quit IRC | 08:28 | |
| SamYaple | I cannot seem to propose a backport to the liberty branch in nova, message being "Change 237801 is closed" | 08:29 |
| SamYaple | I am not familiar with this error, has anyone seen this before? | 08:29 |
| bauzas | good morning Nova | 08:30 |
| bauzas | SamYaple: which change do you want to backport ? | 08:30 |
| AJaeger | SamYaple: what are you doing? Seems you push to the wrong branch | 08:30 |
| SamYaple | https://review.openstack.org/#/c/237799/ | 08:30 |
| SamYaple | AJaeger: bauzas ^ | 08:30 |
| SamYaple | i have tried both from gerrit | 08:30 |
| SamYaple | and my normal method, git cherry-pick -x | 08:31 |
| SamYaple | both fail | 08:31 |
| bauzas | that's a good candidate | 08:31 |
| *** kaisers has quit IRC | 08:31 | |
| bauzas | so, you just have to git pull your local master (to make sure having your patch merged in tree) | 08:31 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Live migration fails when the instance has a config_drive_format=iso9660 https://review.openstack.org/234659 | 08:31 |
| bauzas | then switch on the stable/liberty branch and get checkout -b | 08:32 |
| SamYaple | bauzas: yes I am very familiar with the backport process | 08:32 |
| SamYaple | but its failing | 08:32 |
| bauzas | then git cherry-pick -x | 08:32 |
| SamYaple | yup | 08:32 |
| *** kaisers has joined #openstack-nova | 08:32 | |
| bauzas | ok, so, assuming you have a local branch with one additional commit being the backport | 08:32 |
| SamYaple | indeed | 08:32 |
| bauzas | then git review stable/liberty | 08:33 |
| *** EinstCrazy has joined #openstack-nova | 08:33 | |
| *** zhangjn has joined #openstack-nova | 08:33 | |
| AJaeger | SamYaple: https://review.openstack.org/#/c/237801 is abandoned | 08:33 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 08:33 |
| AJaeger | If you push with the same change-id as 237799, it will fail | 08:33 |
| AJaeger | SamYaple: you first need to un-abandon 237801 | 08:33 |
| SamYaple | AJaeger: ah yea that makes sense | 08:33 |
| bauzas | oh correct, I thought you didn't already abandon one change | 08:33 |
| SamYaple | AJaeger: will do | 08:33 |
| SamYaple | yea i was staging a backport with the initial patch right after i submitted it a few weeks ago | 08:34 |
| *** shuquan has joined #openstack-nova | 08:34 | |
| *** markymark is now known as markus_z | 08:35 | |
| bauzas | SamYaple: fair enough :) | 08:36 |
| openstackgerrit | Pawel Koniszewski proposed openstack/nova: Enable live migration with iso9660 config drive format https://review.openstack.org/234659 | 08:36 |
| SamYaple | success! thanks bauzas AJaeger https://review.openstack.org/#/c/237801/ | 08:36 |
| AJaeger | ;) | 08:36 |
| *** zhangjn has quit IRC | 08:36 | |
| *** zhangjn has joined #openstack-nova | 08:37 | |
| *** venkat_p has joined #openstack-nova | 08:38 | |
| *** shuquan has quit IRC | 08:38 | |
| *** ZZelle has quit IRC | 08:38 | |
| *** kaisers has quit IRC | 08:39 | |
| *** ZZelle has joined #openstack-nova | 08:39 | |
| *** dguitarbite has joined #openstack-nova | 08:39 | |
| *** shuquan has joined #openstack-nova | 08:41 | |
| *** kaisers has joined #openstack-nova | 08:41 | |
| *** jamielennox is now known as jamielennox|away | 08:42 | |
| tangchen_ | bauzas: Do you have time to look at this patch: https://review.openstack.org/#/c/241476/ | 08:42 |
| tangchen_ | bauzas: You don't need to go to the detail | 08:43 |
| bauzas | tangchen_: it's in my review queue :) | 08:43 |
| tangchen_ | bauzas: Just the CI failed because it cannot load automaton. | 08:43 |
| tangchen_ | bauzas: And BTW, do you have interest in this spec ? https://review.openstack.org/#/c/229255/ | 08:44 |
| tangchen_ | bauzas: I want to have a discussion today if anyone has interest in it. | 08:45 |
| bauzas | tangchen_: have you heard of Guru Meditation Reports ? | 08:45 |
| *** salv-orlando has joined #openstack-nova | 08:45 | |
| *** klkumar has joined #openstack-nova | 08:45 | |
| bauzas | tangchen_: http://docs.openstack.org/developer/nova/gmr.html | 08:46 |
| tangchen_ | bauzas: No. What is that ? | 08:46 |
| *** e0ne has joined #openstack-nova | 08:46 | |
| bauzas | tangchen_: see my above link | 08:46 |
| tangchen_ | bauzas: Yes, looking at it. :) | 08:46 |
| *** jlanoux has joined #openstack-nova | 08:47 | |
| *** cdent has joined #openstack-nova | 08:48 | |
| bauzas | tangchen_: tbh, it's more about a nova process than a single instance coredump | 08:48 |
| tangchen_ | bauzas: OK, generate this report. And then ? | 08:49 |
| tangchen_ | bauzas: Is it about the CI question ? | 08:49 |
| bauzas | tangchen_: no, just thought about an existing way to introspect a nova process, was just balancing the idea of adding a new REST API resource for that | 08:50 |
| bauzas | tangchen_: but that's somehow understandable, will comment your spec | 08:50 |
| tangchen_ | bauzas: Oh, I got it. :) | 08:51 |
| tangchen_ | bauzas: But the spec is not going to dump a nova process, but an instance. | 08:51 |
| tangchen_ | bauzas: Such as Linux kdump. | 08:51 |
| bauzas | tangchen_: agreed, hence my "tbh" above | 08:51 |
| *** salv-orlando has quit IRC | 08:53 | |
| tangchen_ | Oh, yes. Thanks. :) | 08:54 |
| tangchen_ | bauzas: Oh, yes. Thanks. :) | 08:54 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes dict keys and items references for Python 3 https://review.openstack.org/232585 | 08:55 |
| *** e0ne has quit IRC | 08:55 | |
| *** takedakn has joined #openstack-nova | 08:56 | |
| *** e0ne has joined #openstack-nova | 08:57 | |
| *** AJaeger has quit IRC | 08:58 | |
| *** mkoderer has quit IRC | 08:59 | |
| *** matrohon has joined #openstack-nova | 09:00 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed extra spaces from double line strings https://review.openstack.org/242989 | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-nova | 09:01 | |
| *** mkoderer has joined #openstack-nova | 09:02 | |
| *** danpb has joined #openstack-nova | 09:02 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Transforms requests and responses into bytes https://review.openstack.org/238323 | 09:02 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Replaces izip_longest with six.moves.zip_longest https://review.openstack.org/238321 | 09:02 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes dict keys and items references for Python 3 https://review.openstack.org/232585 | 09:02 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes Python 3 compatibility for filter results https://review.openstack.org/232620 | 09:03 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Replaces longs with ints https://review.openstack.org/238239 | 09:03 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Converting nova.virt.hyperv to py3 https://review.openstack.org/232554 | 09:03 |
| *** takedakn1 has joined #openstack-nova | 09:03 | |
| *** Sree has quit IRC | 09:04 | |
| *** takedakn has quit IRC | 09:04 | |
| *** takedakn1 is now known as takedakn | 09:04 | |
| *** MarcF has joined #openstack-nova | 09:04 | |
| openstackgerrit | Andrey Pavlov proposed openstack/nova-specs: Added a spec for disable-termination and shutdown-termination flags https://review.openstack.org/234219 | 09:05 |
| *** Sree has joined #openstack-nova | 09:05 | |
| openstackgerrit | Ramakrishnan G proposed openstack/nova-specs: Add support for booting bare metals from Cinder volume https://review.openstack.org/211101 | 09:07 |
| *** yassine__ has joined #openstack-nova | 09:10 | |
| *** achanda has quit IRC | 09:10 | |
| *** otter768 has joined #openstack-nova | 09:11 | |
| *** irenab has quit IRC | 09:14 | |
| oomichi_ | alex_xu: are you still there? | 09:15 |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: Scale-instance: Scale virtual CPUs and memory resources allocated to live instances (for demonstration only) https://review.openstack.org/242913 | 09:15 |
| *** irenab has joined #openstack-nova | 09:15 | |
| *** otter768 has quit IRC | 09:16 | |
| RuiChen | hi johnthetubaguy: could you take a look these specs https://review.openstack.org/#/c/194990/ https://review.openstack.org/#/c/216578/ when you have time? | 09:16 |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: Scale-instance: Scale virtual CPUs and memory allocated to live instances https://review.openstack.org/242913 | 09:17 |
| *** openstack has joined #openstack-nova | 09:19 | |
| *** takedakn has quit IRC | 09:19 | |
| *** mgoddard has joined #openstack-nova | 09:19 | |
| *** subscope has joined #openstack-nova | 09:22 | |
| *** njirap has joined #openstack-nova | 09:24 | |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: Scale-instance: Scale virtual CPUs and memory allocated to live instances https://review.openstack.org/242913 | 09:25 |
| *** josecastroleon has joined #openstack-nova | 09:26 | |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: Scale-instance: Scale virtual CPUs and memory allocated to live instances https://review.openstack.org/242913 | 09:27 |
| *** irenab has quit IRC | 09:27 | |
| *** Sree has quit IRC | 09:30 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Gracefully handle a deleting instance during rebuild https://review.openstack.org/243005 | 09:30 |
| openstackgerrit | Jordan Pittier proposed openstack/nova: ScalityVolume:fix how remote FS mount is detected https://review.openstack.org/210468 | 09:30 |
| oomichi_ | alex_xu: can I update https://review.openstack.org/#/c/187112/ by myself? | 09:32 |
| *** klkumar has quit IRC | 09:32 | |
| oomichi_ | alex_xu: now we need to implement microversions thing in tempest-lib as library. | 09:33 |
| oomichi_ | alex_xu: and it is nice to build a consensus about microversions guideline for doing tat. | 09:33 |
| oomichi_ | alex_xu: s/tat/that/ | 09:33 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove duplicate default=None for option compute_available_monitors https://review.openstack.org/243007 | 09:33 |
| *** takedakn has joined #openstack-nova | 09:34 | |
| openstackgerrit | Dmitry Guryanov proposed openstack/nova-specs: virtuozzo storage volume driver in libvirt https://review.openstack.org/184295 | 09:36 |
| openstackgerrit | Ahmed ElKhouly proposed openstack/nova: Scale-instance: Scale virtual CPUs and memory of live instances https://review.openstack.org/242913 | 09:37 |
| *** shuquan has quit IRC | 09:39 | |
| *** andreykurilin has joined #openstack-nova | 09:41 | |
| *** jistr has joined #openstack-nova | 09:41 | |
| *** rubasov has joined #openstack-nova | 09:42 | |
| *** rubasov has quit IRC | 09:44 | |
| johnthetubaguy | RuiChen: in that second spec, have you taken a look at instance actions? | 09:44 |
| *** rubasov has joined #openstack-nova | 09:45 | |
| *** davideagnello has joined #openstack-nova | 09:45 | |
| *** klkumar has joined #openstack-nova | 09:45 | |
| bauzas | johnthetubaguy: RuiChen: +1, it's part of the on-going effort I'd like to kick-off for Mitaka | 09:46 |
| *** rubasov has quit IRC | 09:46 | |
| *** pkholkin has joined #openstack-nova | 09:46 | |
| *** rubasov has joined #openstack-nova | 09:46 | |
| bauzas | that's what we quickly agreed during the Summit, add more instance actions whenever it was needed | 09:47 |
| johnthetubaguy | oomichi_: just wondering about your comment on here: https://review.openstack.org/#/c/242206/7 | 09:48 |
| johnthetubaguy | oomichi_: I thought the idea with that change was to ensure there is no API impact, because previous the API nodes would not appear in the list, so the change makes sure they don't appear, as I understand it? | 09:48 |
| *** irenab has joined #openstack-nova | 09:48 | |
| oomichi_ | johnthetubaguy: hi | 09:49 |
| *** davideagnello has quit IRC | 09:49 | |
| *** aix has joined #openstack-nova | 09:50 | |
| oomichi_ | johnthetubaguy: I am gussing if nova-metadata is enable on an env, the change will affect the response | 09:50 |
| oomichi_ | johnthetubaguy: to be honest, nova-metadata is disabled on my env. so I don't check the behavior of the patch yet. | 09:50 |
| *** shuquan has joined #openstack-nova | 09:51 | |
| bauzas | oomichi_: johnthetubaguy: I need to double-check but IIRC, it also shows n-cond, n-api etc. | 09:52 |
| oomichi_ | bauzas: no, n-api doesn't appear on the API at least | 09:53 |
| bauzas | oomichi_: oh correct, made a typo | 09:53 |
| claudiub | johnthetubaguy: hello. Was wondering if we could add a "Py3 compatibility" section in the mitaka priority tracking etherpad | 09:53 |
| bauzas | oomichi_: n-api is not logged because it's not creating a new service entry hence superdan's change | 09:53 |
| bauzas | oomichi_: but it lists all the other services | 09:54 |
| bauzas | oomichi_: that said (me writing at the same I think) | 09:54 |
| bauzas | oomichi_: the goal was to add a new service entry for the api processes | 09:54 |
| johnthetubaguy | oomichi_: I thought none of those were listed currently | 09:55 |
| bauzas | oomichi_: so by doing the change, dan is just adding new entries to the services that he wants to not show | 09:55 |
| bauzas | oomichi_: so I feel it's not an API impact | 09:55 |
| johnthetubaguy | oomichi_: as bauzas said, there was no service entry for them | 09:55 |
| bauzas | oomichi_: here, dan just wants to have them persisted in DB, without showing them | 09:55 |
| johnthetubaguy | but thats based on my memory, which is often dubious | 09:56 |
| bauzas | johnthetubaguy: no no you're right | 09:56 |
| openstackgerrit | Derek Higgins proposed openstack/nova: Handle a NeutronClientException 404 Error for floating ips https://review.openstack.org/242158 | 09:56 |
| *** irenab has quit IRC | 09:56 | |
| bauzas | johnthetubaguy: because the whole goal of that series is to have a version capping for API processes | 09:56 |
| bauzas | johnthetubaguy: like we have for the conductor now | 09:56 |
| *** takedakn has quit IRC | 09:57 | |
| bauzas | johnthetubaguy: but given the API processes weren't writing in the services table, dan is just adding them in their (with a version number, because it's now a service entry) | 09:57 |
| bauzas | s/their/therer | 09:57 |
| * bauzas has fat fingers | 09:57 | |
| oomichi_ | johnthetubaguy, bauzas: thanks, dan adds filter for blocking additional data for preparing? | 09:57 |
| johnthetubaguy | bauzas: yep, thats was my thinking too | 09:58 |
| oomichi_ | johnthetubaguy, bauzas: and he will add some services after the patch? | 09:58 |
| bauzas | oomichi_: sec, lemme show you the changes | 09:58 |
| bauzas | here https://review.openstack.org/#/c/242206/7/nova/service.py,cm | 09:59 |
| bauzas | oomichi_: ^ | 10:00 |
| oomichi_ | bauzas: checking | 10:00 |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-nova | 10:01 | |
| bauzas | oomichi_: so for example, see how we add a new services table entry with the conductor https://github.com/openstack/nova/blob/master/nova/cmd/conductor.py#L42-L44 | 10:01 |
| *** zhenguo has quit IRC | 10:02 | |
| *** derekh has joined #openstack-nova | 10:02 | |
| bauzas | oomichi_: it generates a new Service object here https://github.com/openstack/nova/blob/master/nova/service.py#L266-L271 | 10:02 |
| *** MarcF has quit IRC | 10:02 | |
| oomichi_ | bauzas: thanks, and wait a minute | 10:02 |
| oomichi_ | bauzas: he will add service.Service.create(binary='nova-metadata', ...), right? | 10:03 |
| bauzas | oomichi_: and then, when we start the service, it adds a new row https://github.com/openstack/nova/blob/master/nova/service.py#L171 | 10:03 |
| RuiChen | johnthetubaguy: bauzas: this spec https://review.openstack.org/#/c/216578/ purpose to add new task_states into instance life cycle, not instance actions, it aims to solve some concurrent issues | 10:03 |
| *** gszasz has joined #openstack-nova | 10:03 | |
| johnthetubaguy | RuiChen: right, but we already have instance actions that are designed to tell you about how each API call has done, if there was an error or not, etc | 10:04 |
| johnthetubaguy | RuiChen: your spec claims there is no way of knowing, but the way of knowing is instance actions | 10:04 |
| *** klkumar has quit IRC | 10:06 | |
| oomichi_ | bauzas: ah, I see the point. thanks! | 10:06 |
| oomichi_ | bauzas: point is that line 423 at https://review.openstack.org/#/c/242206/7/nova/service.py,cm | 10:07 |
| *** can8dnSix has joined #openstack-nova | 10:07 | |
| oomichi_ | bauzas: the code adds new service names which don't appear on the API and need to filter them out on API layer | 10:08 |
| bauzas | oomichi_: right, because contrary to the conductor which is a Service, the osapi n-api service is a WSGIService which doesn't call the service creation | 10:08 |
| oomichi_ | bauzas: nice explanation, thanks so much! | 10:08 |
| RuiChen | johnthetubaguy: we can know which action execute on the instance from instance actions, but the concurrent actions will execute on one instance in nova-compute, that cause the instance ERROR | 10:08 |
| bauzas | oomichi_: so the change is adding those but then needs to filter them out from the existing API | 10:08 |
| oomichi_ | bauzas: yeah, I see. | 10:09 |
| RuiChen | johnthetubaguy: adding the task_states will reject the concurrent API request in nova-api, that will avoid the instance ERROR in concurrent case. | 10:10 |
| *** Marga_ has joined #openstack-nova | 10:15 | |
| johnthetubaguy | RuiChen: agreed, I was more meaning about discovering if your API action has completed or not | 10:16 |
| johnthetubaguy | RuiChen: for that, you can check, using the request id, using instance actions, if that doesn't work for the particular API calls you are worried about, we need to fix that first | 10:17 |
| *** BobBall_AWOL is now known as BobBall | 10:20 | |
| *** ptm_away is now known as PaulMurray | 10:20 | |
| *** shuquan has quit IRC | 10:21 | |
| johnthetubaguy | alex_xu: oomichi_: It seems instance actions are missing from the API complete reference, or am I just being blind? http://developer.openstack.org/api-ref-compute-v2.1.html | 10:25 |
| johnthetubaguy | alex_xu: oomichi_: my bad, found it | 10:25 |
| *** irenab has joined #openstack-nova | 10:27 | |
| *** klkumar has joined #openstack-nova | 10:32 | |
| RuiChen | johnthetubaguy: I got your point, but the instance actions checking isn't the mandatory requirement when we call Nova API, if we can add some protection in API itself to avoid the issue mentioned in my spec, the API will not depend the specify feature, make sense? | 10:36 |
| *** venkat_p has quit IRC | 10:36 | |
| *** belmoreira has joined #openstack-nova | 10:37 | |
| *** bradjones has joined #openstack-nova | 10:37 | |
| *** bradjones has quit IRC | 10:37 | |
| *** bradjones has joined #openstack-nova | 10:37 | |
| *** jinxing_ has quit IRC | 10:40 | |
| *** eliqiao_ has joined #openstack-nova | 10:41 | |
| *** ndipanov has joined #openstack-nova | 10:42 | |
| *** ndipanov has quit IRC | 10:42 | |
| johnthetubaguy | RuiChen: so my opinion on the spec is a bit too complicated to communicate via IRC, but let me try | 10:42 |
| *** pixelbeat has joined #openstack-nova | 10:43 | |
| johnthetubaguy | RuiChen: you state two problems, the first one we think has already been solved via an existing API | 10:43 |
| johnthetubaguy | RuiChen: the second one we haven't yet fixed, and I agree is important to fix | 10:43 |
| johnthetubaguy | RuiChen: there are a few worries with the proposed solution | 10:44 |
| johnthetubaguy | RuiChen: first is it violates our API change rules around microversions, and its not easy to resolve that | 10:44 |
| *** deepakcs has quit IRC | 10:44 | |
| johnthetubaguy | RuiChen: the second issue is that is stops users being able to run attach/detach interfaces and volumes in parallel, that they can do now very successfully in most cases | 10:45 |
| johnthetubaguy | RuiChen: I have added a few comments on the spec in gerrit to try and reflect that | 10:46 |
| *** jinxing has joined #openstack-nova | 10:46 | |
| johnthetubaguy | RuiChen: my preferred solution would allow those parallel operations, and isolate the majority of the API changes to a new microversion | 10:46 |
| bauzas | johnthetubaguy: just re-reading outcome of https://etherpad.openstack.org/p/mitaka-nova-error-handling because me reviewing https://review.openstack.org/#/c/224755/11/specs/mitaka/approved/versioned-notification-api.rst,cm do you remember if we agreed on versioning the envelop as well ? | 10:48 |
| *** madhuri has quit IRC | 10:48 | |
| bauzas | johnthetubaguy: because versioning the whole notification is only provided as an alternative atm | 10:48 |
| *** venkat_p has joined #openstack-nova | 10:49 | |
| bauzas | but I remember we said it's just a matter of importing o.vo in the consumer codepath | 10:49 |
| bauzas | but people arguing it was python only etc. and us saying it's just a JSON string that anyone can just rehydrate | 10:49 |
| johnthetubaguy | bauzas: not totally sure we reached full consensus, felt like it was time to see the code | 10:50 |
| bauzas | johnthetubaguy: okay, we punted that | 10:50 |
| bauzas | because honestly, I'm not a big fan of leaving an unversioned envelop | 10:51 |
| johnthetubaguy | bauzas: my take is we keep the old envelope, oslo owns that, and we worry about the payload, and getting some consistency around what goes into the envelope on our side | 10:51 |
| bauzas | while we're just about providing a versioned payload | 10:51 |
| johnthetubaguy | so cross project consistency wins me over on that one | 10:51 |
| bauzas | I see | 10:51 |
| bauzas | good point | 10:51 |
| *** subscope has quit IRC | 10:51 | |
| bauzas | okay, I guess we reached a substainable level of confidence with that spec then | 10:52 |
| johnthetubaguy | I would rather the whole thing was o.vo but its not really our choice | 10:52 |
| RuiChen | johnthetubaguy: got it, I will check your comments, and thank you patiently reply | 10:52 |
| johnthetubaguy | RuiChen: thank you for looking into this important stability issue, glad its getting attention! | 10:53 |
| *** alex_klimov has joined #openstack-nova | 10:53 | |
| *** sudipto has quit IRC | 10:53 | |
| *** subscope has joined #openstack-nova | 10:55 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Ensure that max is called between integers https://review.openstack.org/238322 | 10:57 |
| *** eliqiao_ has quit IRC | 10:59 | |
| *** lpetrut has quit IRC | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** eliqiao has joined #openstack-nova | 11:01 | |
| *** Sree has joined #openstack-nova | 11:01 | |
| *** jinxing has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-nova | 11:01 | |
| *** jichen has quit IRC | 11:02 | |
| *** subscope has quit IRC | 11:03 | |
| *** ihrachys has quit IRC | 11:05 | |
| *** eliqiao1 has joined #openstack-nova | 11:06 | |
| *** njirap has quit IRC | 11:08 | |
| *** njirap has joined #openstack-nova | 11:09 | |
| *** zhangjn has quit IRC | 11:10 | |
| *** EinstCrazy has quit IRC | 11:10 | |
| *** aysyd has joined #openstack-nova | 11:10 | |
| *** amotoki has quit IRC | 11:12 | |
| *** otter768 has joined #openstack-nova | 11:12 | |
| *** eliqiao has quit IRC | 11:13 | |
| gibi | bauzas: hi, If we now solve the versioning of the payload then later we can still change the envelope to a versioned one, so the two work can be done separately. I also agree with johnthetubaguy that changing the envelope is a lot bigger than just versioning the payload and that is already big enough. :) | 11:13 |
| *** eliqiao1 is now known as eliqiao | 11:13 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs: Add add-api-block-device-mapping.rst https://review.openstack.org/239116 | 11:13 |
| bauzas | gibi: that's exactly what I'm just commenting in your spec :) | 11:14 |
| openstackgerrit | jichenjc proposed openstack/nova: devref:Don't suggest decorate private method https://review.openstack.org/233022 | 11:14 |
| bauzas | gibi: but I needed a bit of context before reviewing :) | 11:14 |
| gibi | bauzas: great! thank for the review | 11:14 |
| *** aysyd has quit IRC | 11:15 | |
| *** moshele has quit IRC | 11:15 | |
| *** aysyd has joined #openstack-nova | 11:15 | |
| *** dims has joined #openstack-nova | 11:15 | |
| *** otter768 has quit IRC | 11:17 | |
| *** A110602877_ has joined #openstack-nova | 11:19 | |
| *** romainh has quit IRC | 11:19 | |
| *** eliqiao is now known as eliqiao_ | 11:20 | |
| dims | bauzas : congrats! | 11:20 |
| *** eliqiao has joined #openstack-nova | 11:20 | |
| *** e0ne has quit IRC | 11:21 | |
| *** A110602877_ has quit IRC | 11:22 | |
| *** eliqiao has joined #openstack-nova | 11:23 | |
| *** josecastroleon has quit IRC | 11:24 | |
| bauzas | dims: ty but I defer the congrats till the end of the proposal period :) | 11:25 |
| dims | bauzas i'll celebrate now :) you can later! | 11:25 |
| bauzas | dims: so Bristol is close to me, I should be able to bring some cheese | 11:26 |
| *** eliqiao_ has quit IRC | 11:26 | |
| bauzas | no need to walk thru the US border :p | 11:26 |
| dims | ++ bauzas | 11:26 |
| alex_xu | oomichi_: sure, free to update that, sorry for late update it | 11:26 |
| oomichi_ | alex_xu: no problem. it is hardest one as you know ;-) | 11:27 |
| alex_xu | oomichi_: yea :) | 11:28 |
| *** e0ne has joined #openstack-nova | 11:30 | |
| *** lpetrut has joined #openstack-nova | 11:31 | |
| *** moshele has joined #openstack-nova | 11:31 | |
| oomichi_ | alex_xu: done | 11:32 |
| alex_xu | oomichi_: so quick | 11:32 |
| oomichi_ | alex_xu: I prepared it :) | 11:32 |
| alex_xu | oomichi_: heh | 11:32 |
| openstackgerrit | Roman Bogorodskiy proposed openstack/nova-specs: User-controlled SR-IOV ports allocation https://review.openstack.org/182242 | 11:32 |
| tangchen_ | johnthetubaguy, alex_xu: Hi, about the inject nmi thing, would you please help to look at this patch ? https://review.openstack.org/#/c/208794/ | 11:32 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Remove duplicate keys in policy.json https://review.openstack.org/242902 | 11:33 |
| tangchen_ | johnthetubaguy, alex_xu: It is part of the BP, but I think it is just an improvement of a previous patch merged in Liberty. | 11:33 |
| *** Sree has quit IRC | 11:34 | |
| tangchen_ | johnthetubaguy, alex_xu: And it has nothing to do with the rest work. So would you please remove the -2, and let it merge first ? | 11:34 |
| alex_xu | tangchen_: I think we should get the nova-spec merge first | 11:34 |
| bauzas | +1 | 11:35 |
| johnthetubaguy | tangchen_: yes, we need a spec merged for the API change you have here: https://review.openstack.org/#/c/202617/18 | 11:35 |
| johnthetubaguy | tangchen_: the -2 will remain until we get the blueprint approved | 11:35 |
| *** eliqiao has quit IRC | 11:35 | |
| *** zhangjn has joined #openstack-nova | 11:36 | |
| *** zhangjn has quit IRC | 11:36 | |
| johnthetubaguy | tangchen_: I think sdague had some good ideas around the API, maybe having a crash dump API, rather than an NMI API, but I don't remember the current state of the spec discussion there | 11:36 |
| *** zhangjn has joined #openstack-nova | 11:36 | |
| johnthetubaguy | tangchen_: do you have a nova-spec for mitaka up for review for this? | 11:37 |
| *** EinstCrazy has joined #openstack-nova | 11:37 | |
| *** eliqiao has joined #openstack-nova | 11:37 | |
| tangchen_ | johnthetubaguy, alex_xu: Yes, there is a spec here. https://review.openstack.org/#/c/229255/ | 11:37 |
| *** EinstCrazy has quit IRC | 11:38 | |
| *** EinstCrazy has joined #openstack-nova | 11:38 | |
| alex_xu | looks like there are different opinion from api sub-team, so it's worth discuss it at tomorrow api meeting | 11:38 |
| tangchen_ | johnthetubaguy, alex_xu: I agree we should merge the spec first. But the patch I just updated almost has nothing to do with the spec. | 11:38 |
| *** ihrachys has joined #openstack-nova | 11:39 | |
| tangchen_ | johnthetubaguy, alex_xu: So I removed the "Implements" tag from the commit message. And I hope this patch can be merged as an "adding unit tests" patch. | 11:39 |
| johnthetubaguy | tangchen_: ah, OK, understood, did you want to add a bug to track that? | 11:40 |
| johnthetubaguy | tangchen_: actually, I guess thats not really worth it | 11:41 |
| tangchen_ | johnthetubaguy: Er...no, I think it is not a bug. Just there is no test for the libvirt driver api. | 11:41 |
| tangchen_ | johnthetubaguy: yes. | 11:41 |
| *** jaypipes has joined #openstack-nova | 11:41 | |
| tangchen_ | johnthetubaguy, alex_xu: So would you please help to review it, and merge it as an independent patch ? | 11:43 |
| *** shhjwang has joined #openstack-nova | 11:43 | |
| *** weihan has joined #openstack-nova | 11:43 | |
| *** ndipanov has joined #openstack-nova | 11:44 | |
| *** shhjwang has left #openstack-nova | 11:44 | |
| johnthetubaguy | tangchen_: I am focusing on spec reviews right now, I am afraid, that and the odd really critical nova patch | 11:45 |
| *** davideagnello has joined #openstack-nova | 11:46 | |
| *** liverpooler has quit IRC | 11:47 | |
| *** smatzek has joined #openstack-nova | 11:47 | |
| tangchen_ | johnthetubaguy: Sure. Thanks for removing the -2. And I think others will be able to review it. :) | 11:47 |
| *** eliqiao_ has joined #openstack-nova | 11:48 | |
| *** jlanoux has quit IRC | 11:48 | |
| *** moshele has quit IRC | 11:48 | |
| *** haomaiwang has quit IRC | 11:50 | |
| markus_z | PaulMurray: wrt the ownership of the "live-migration" bug tag. My intention is not to sneak in your commitment to triage those but I would highly welcome it. | 11:50 |
| *** davideagnello has quit IRC | 11:50 | |
| markus_z | PaulMurray: At the end of the day I cannot force you to anything. | 11:51 |
| markus_z | PaulMurray: I think you feel uncomfortable with the entry in the wiki so I will remove it. If you think you'd like to give a commitment there, feel free to re-enter your name. | 11:52 |
| *** eliqiao- has joined #openstack-nova | 11:52 | |
| *** pradipta has quit IRC | 11:52 | |
| PaulMurray | markus_z, no worries, you can leave it | 11:52 |
| PaulMurray | markus_z, there are a few people involved who are actively going through the live migration bugs and working on them | 11:53 |
| PaulMurray | markus_z, I can coordinate with them | 11:53 |
| *** cdent has quit IRC | 11:54 | |
| *** eliqiao has quit IRC | 11:54 | |
| *** eliqiao- has quit IRC | 11:54 | |
| *** eliqiao_ has quit IRC | 11:54 | |
| markus_z | PaulMurray: That would be awesome, thanks! | 11:54 |
| *** eliqiao1 has joined #openstack-nova | 11:54 | |
| *** eliqiao1 is now known as eliqiao | 11:54 | |
| *** eliqiao has left #openstack-nova | 11:54 | |
| *** eglynn has joined #openstack-nova | 11:56 | |
| *** jlanoux has joined #openstack-nova | 11:58 | |
| *** rfolco has joined #openstack-nova | 12:00 | |
| *** josecastroleon has joined #openstack-nova | 12:00 | |
| *** liverpooler has joined #openstack-nova | 12:02 | |
| *** venkat_p has quit IRC | 12:02 | |
| markus_z | mmmpork: I don't think it's necessary to add your name to the "project config funky bunch" (<= I should have named the bp like this :) ) | 12:04 |
| garyk | PaulMurray: we plan to add live migration support in the vmware driver. i am not sure that this is related to the effort that you are speaking about. if so then please let me know. if not then pleaselet me know and we can see if i can help out | 12:05 |
| markus_z | mmmpork: I'll organize things in a few hours from now. Basically an etherpad which helps planning and splitting up tasks. | 12:05 |
| *** eliqiao has joined #openstack-nova | 12:06 | |
| markus_z | mmmpork: I'll use this one: https://etherpad.openstack.org/p/config-options | 12:06 |
| *** eliqiao_ has joined #openstack-nova | 12:06 | |
| *** eliqiao- has joined #openstack-nova | 12:07 | |
| markus_z | hogepodge: #1 coolest nickname ever | 12:07 |
| *** eliqiao- has quit IRC | 12:07 | |
| *** eliqiao has quit IRC | 12:07 | |
| markus_z | hogepodge: #2 Thanks for your review on https://review.openstack.org/#/c/242472/ I left a few questions which you might be able to answer. | 12:08 |
| *** eliqiao_ is now known as eliqiao | 12:08 | |
| *** eliqiao has left #openstack-nova | 12:08 | |
| *** liverpooler has quit IRC | 12:11 | |
| *** alex_klimov has quit IRC | 12:11 | |
| *** liverpooler has joined #openstack-nova | 12:11 | |
| *** alex_klimov has joined #openstack-nova | 12:12 | |
| PaulMurray | garyk, the items we discussed are listed here: https://etherpad.openstack.org/p/mitaka-live-migration | 12:13 |
| PaulMurray | garyk, the objective is really to make live migration more robust and to fix some of the use cases that do not work under libvirt | 12:13 |
| *** subscope has joined #openstack-nova | 12:14 | |
| openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for os-extended-server-attributes https://review.openstack.org/232605 | 12:14 |
| PaulMurray | garyk, so adding vmware is additional and in the broad sense is related, so it is worth tracking | 12:14 |
| garyk | PaulMurray: ok, thanks for the update. | 12:14 |
| *** rk4n has joined #openstack-nova | 12:14 | |
| PaulMurray | garyk, the plan is not to get in anyones way | 12:15 |
| *** baoli has joined #openstack-nova | 12:15 | |
| PaulMurray | garyk, its more to help coordinate some things to make sure they get done. Please don't think we need to add bureaucracy to your task :) | 12:15 |
| garyk | PaulMurray: completely understand. i'll be happy to help out | 12:16 |
| PaulMurray | garyk, thanks | 12:16 |
| *** ig0r__ has joined #openstack-nova | 12:16 | |
| *** PaulMurray is now known as PaulMurray_lunch | 12:17 | |
| *** raildo-afk is now known as raildo | 12:17 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Fix wrong usage of config option use_neutron_default_nets https://review.openstack.org/243061 | 12:18 |
| *** baoli has quit IRC | 12:20 | |
| *** can8dnSix has quit IRC | 12:20 | |
| *** ociuhandu has joined #openstack-nova | 12:22 | |
| *** eliqiao has joined #openstack-nova | 12:22 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: test:clean up wrong value in method CONF.set_override https://review.openstack.org/242416 | 12:25 |
| openstackgerrit | John Garbutt proposed openstack/nova: docs: update the API faults concept guide https://review.openstack.org/243066 | 12:27 |
| *** daemontool has quit IRC | 12:27 | |
| sc68cal | mgagne: I know right? | 12:31 |
| sc68cal | mgagne: need to keep the closet datacenter usecase in mind | 12:31 |
| *** klkumar has quit IRC | 12:32 | |
| *** amotoki has joined #openstack-nova | 12:34 | |
| *** romainh has joined #openstack-nova | 12:34 | |
| *** eliqiao has left #openstack-nova | 12:38 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova-specs: libvirt: runtime image type detection https://review.openstack.org/240163 | 12:42 |
| *** jinxing has joined #openstack-nova | 12:42 | |
| *** eliqiao1 has joined #openstack-nova | 12:44 | |
| openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'host_mapping' https://review.openstack.org/242035 | 12:45 |
| *** eliqiao1 has left #openstack-nova | 12:45 | |
| *** eliqiao has joined #openstack-nova | 12:46 | |
| *** lucasagomes is now known as lucas-hungry | 12:49 | |
| *** lpetrut has quit IRC | 12:49 | |
| *** lpetrut has joined #openstack-nova | 12:49 | |
| *** sudipto has joined #openstack-nova | 12:50 | |
| *** moshele has joined #openstack-nova | 12:51 | |
| *** thorst has joined #openstack-nova | 12:51 | |
| *** liverpoo1er has joined #openstack-nova | 12:51 | |
| *** salv-orlando has joined #openstack-nova | 12:52 | |
| *** jichen has joined #openstack-nova | 12:52 | |
| *** shuquan has joined #openstack-nova | 12:54 | |
| *** salv-orlando has quit IRC | 12:56 | |
| *** aix has quit IRC | 12:56 | |
| *** weihan has quit IRC | 12:57 | |
| *** subscope has quit IRC | 12:57 | |
| *** moshele has quit IRC | 12:58 | |
| *** dims has quit IRC | 12:59 | |
| *** markus_z is now known as markus_z_meeting | 13:01 | |
| *** moshele has joined #openstack-nova | 13:03 | |
| openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for os-extended-server-attributes https://review.openstack.org/232605 | 13:04 |
| *** marcusvrn_ has quit IRC | 13:05 | |
| *** daemontool has joined #openstack-nova | 13:06 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Add missing policy rules https://review.openstack.org/243090 | 13:06 |
| *** jerrygb has quit IRC | 13:07 | |
| *** subscope has joined #openstack-nova | 13:08 | |
| *** haomaiwa_ has joined #openstack-nova | 13:13 | |
| *** otter768 has joined #openstack-nova | 13:13 | |
| *** dustins has joined #openstack-nova | 13:14 | |
| *** aix has joined #openstack-nova | 13:14 | |
| *** shuquan has quit IRC | 13:15 | |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Allow volume operations when shelved https://review.openstack.org/243096 | 13:17 |
| *** rdo has quit IRC | 13:17 | |
| *** otter768 has quit IRC | 13:18 | |
| *** shuquan has joined #openstack-nova | 13:18 | |
| *** Sree has joined #openstack-nova | 13:19 | |
| *** rdo has joined #openstack-nova | 13:19 | |
| *** amotoki has quit IRC | 13:22 | |
| openstackgerrit | Andrey Pavlov proposed openstack/nova-specs: Added a spec for disable-termination and shutdown-termination flags https://review.openstack.org/234219 | 13:23 |
| *** e0ne has quit IRC | 13:23 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Remove duplicate keys in policy.json https://review.openstack.org/242902 | 13:23 |
| *** Sree has quit IRC | 13:24 | |
| *** xyang1 has joined #openstack-nova | 13:25 | |
| *** amotoki has joined #openstack-nova | 13:27 | |
| *** Sree has joined #openstack-nova | 13:28 | |
| *** boris-42 has quit IRC | 13:28 | |
| *** edmondsw has joined #openstack-nova | 13:30 | |
| *** Sree has quit IRC | 13:30 | |
| *** Sree has joined #openstack-nova | 13:32 | |
| openstackgerrit | javeme proposed openstack/nova: Returns more accurate error msg for live migration https://review.openstack.org/243105 | 13:34 |
| bauzas | nova scheduler meeting in 25 mins on #openstack-meeting | 13:36 |
| bauzas | markus_z_meeting: FWIW, I'm planning to add a new bugs section in the meeting, feel free to jump in and complain | 13:37 |
| bauzas | :p | 13:37 |
| *** e0ne has joined #openstack-nova | 13:37 | |
| *** cfriesen__ has joined #openstack-nova | 13:37 | |
| *** baoli has joined #openstack-nova | 13:39 | |
| *** diogogmt has quit IRC | 13:40 | |
| *** PaulMurray_lunch is now known as PaulMurray | 13:41 | |
| *** diogogmt has joined #openstack-nova | 13:42 | |
| *** lbelivea has joined #openstack-nova | 13:42 | |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Detach and attach boot volumes https://review.openstack.org/221732 | 13:43 |
| *** mwagner has quit IRC | 13:44 | |
| *** baoli has quit IRC | 13:44 | |
| *** ccarmack1 has left #openstack-nova | 13:45 | |
| *** davideagnello has joined #openstack-nova | 13:47 | |
| *** amotoki has quit IRC | 13:47 | |
| *** davideagnello has quit IRC | 13:51 | |
| *** rlrossit has joined #openstack-nova | 13:52 | |
| *** cdent has joined #openstack-nova | 13:54 | |
| openstackgerrit | Andrey Pavlov proposed openstack/nova-specs: Added a spec for disable-termination and shutdown-termination flags https://review.openstack.org/234219 | 13:54 |
| jroll | tonyb: just read through the driver capabilities thread, feel free to ping me for help and/or review on that stuff | 13:54 |
| *** liverpoo1er has quit IRC | 13:56 | |
| *** salv-orlando has joined #openstack-nova | 13:58 | |
| *** rk4n_ has joined #openstack-nova | 13:58 | |
| *** rk4n has quit IRC | 13:58 | |
| *** boris-42 has joined #openstack-nova | 13:59 | |
| bauzas | nova-scheduler meeting now http://eavesdrop.openstack.org/#Nova_Scheduler_Team_Meeting | 14:00 |
| *** lucas-hungry is now known as lucasagomes | 14:00 | |
| *** amotoki has joined #openstack-nova | 14:00 | |
| *** haomaiwa_ has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-nova | 14:01 | |
| openstackgerrit | jichenjc proposed openstack/nova: libvirt:Fix a typo of test cases https://review.openstack.org/243117 | 14:01 |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Detach and attach boot volumes https://review.openstack.org/221732 | 14:02 |
| *** jyuso1 has quit IRC | 14:03 | |
| *** burgerk has joined #openstack-nova | 14:03 | |
| *** su_zhang has joined #openstack-nova | 14:04 | |
| *** ijuwang has joined #openstack-nova | 14:05 | |
| *** thumpba has joined #openstack-nova | 14:08 | |
| *** diogogmt has quit IRC | 14:10 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova-specs: libvirt: runtime image type detection https://review.openstack.org/240163 | 14:10 |
| *** jinxing has quit IRC | 14:13 | |
| *** jerrygb has joined #openstack-nova | 14:13 | |
| *** jinxing has joined #openstack-nova | 14:13 | |
| *** mdrabe has joined #openstack-nova | 14:13 | |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Detach and attach boot volumes https://review.openstack.org/221732 | 14:14 |
| *** shuquan has quit IRC | 14:15 | |
| *** mwagner has joined #openstack-nova | 14:15 | |
| *** thumpba has quit IRC | 14:17 | |
| openstackgerrit | Nikola Dipanov proposed openstack/nova-specs: spec document for sriov-physical-function-passthrough blueprint https://review.openstack.org/212472 | 14:17 |
| *** haomaiwang has quit IRC | 14:19 | |
| *** pratikmallya has joined #openstack-nova | 14:20 | |
| *** haomaiwa_ has joined #openstack-nova | 14:21 | |
| *** jichen has quit IRC | 14:21 | |
| *** mgoddard_ has joined #openstack-nova | 14:21 | |
| *** vladikr has joined #openstack-nova | 14:21 | |
| *** thangp has joined #openstack-nova | 14:22 | |
| *** thumpba has joined #openstack-nova | 14:22 | |
| *** thumpba has quit IRC | 14:22 | |
| *** rk4n_ has quit IRC | 14:23 | |
| *** dave-mccowan has joined #openstack-nova | 14:23 | |
| *** ndipanov has quit IRC | 14:24 | |
| *** mgoddard has quit IRC | 14:24 | |
| *** rk4n has joined #openstack-nova | 14:25 | |
| *** thumpba has joined #openstack-nova | 14:25 | |
| *** superdan is now known as dansmith | 14:27 | |
| *** baoli has joined #openstack-nova | 14:27 | |
| openstackgerrit | dstepanenko proposed openstack/nova: WIP: This is 2nd part of changes according to pci-generate-stats blueprint. https://review.openstack.org/243131 | 14:28 |
| *** su_zhang has quit IRC | 14:30 | |
| *** zhangjn has quit IRC | 14:30 | |
| *** ctrath has joined #openstack-nova | 14:31 | |
| *** jinxing has quit IRC | 14:34 | |
| *** mriedem_away is now known as mriedem | 14:35 | |
| *** smatzek has quit IRC | 14:35 | |
| *** dims has joined #openstack-nova | 14:36 | |
| *** thumpba has quit IRC | 14:37 | |
| *** tongli has joined #openstack-nova | 14:37 | |
| *** baoli has quit IRC | 14:38 | |
| *** su_zhang has joined #openstack-nova | 14:38 | |
| *** baoli has joined #openstack-nova | 14:38 | |
| *** subscope has quit IRC | 14:38 | |
| *** su_zhang has quit IRC | 14:40 | |
| *** signed8bit has joined #openstack-nova | 14:44 | |
| *** njirap has quit IRC | 14:44 | |
| *** CustosLim3n has left #openstack-nova | 14:44 | |
| *** CustosLim3n has joined #openstack-nova | 14:44 | |
| *** thumpba has joined #openstack-nova | 14:44 | |
| moshele | baoli: hi | 14:45 |
| claudiub | mriedem: hello. may I inquire your assistance? Could you review the spec for os-win in nova pls? Thanks! https://review.openstack.org/#/c/227827/ | 14:47 |
| mriedem | sure | 14:49 |
| *** annegentle has joined #openstack-nova | 14:49 | |
| openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for os-extended-server-attributes https://review.openstack.org/232605 | 14:49 |
| sdague | did the cells test change land? | 14:49 |
| mriedem | yes, on friday | 14:50 |
| mriedem | except stable | 14:50 |
| mriedem | there is a backport | 14:50 |
| mriedem | oh stable/liberty landed https://review.openstack.org/#/c/242756/ | 14:50 |
| mriedem | i think we also have to hit kilo | 14:50 |
| *** dustins has quit IRC | 14:50 | |
| mriedem | checking | 14:51 |
| *** breitz has joined #openstack-nova | 14:51 | |
| mriedem | our proposed fixes to use a bdm uuid are failing, still trying to sort that out | 14:51 |
| sdague | mriedem: ok - https://review.openstack.org/#/c/240159/3 still got hit by it, so I was wondering | 14:53 |
| mriedem | danpb: i was going to work on converting nova.image.api.API.get() to return ImageMeta objects rather than a dict, it's a simple change but lots of code/test impacts since ImageMeta doesn't have dict compat; do you have any issues with that? | 14:53 |
| mriedem | sdague: that failed on a different test | 14:53 |
| mriedem | sdague: e-r isn't reporting on things | 14:53 |
| *** sudipto has quit IRC | 14:53 | |
| mriedem | http://logs.openstack.org/59/240159/3/check/gate-tempest-dsvm-cells/a5d27f8/console.html#_2015-11-09_06_36_31_738 is a different cells bug | 14:53 |
| sdague | mriedem: ok | 14:54 |
| danpb | mriedem: hmm, not sure we particularly need that conversion or not | 14:54 |
| mriedem | danpb: came up b/c of a regression bug https://review.openstack.org/#/c/237801/ | 14:54 |
| mriedem | oops https://review.openstack.org/#/c/237799/ | 14:54 |
| danpb | as most code should really just call ImageMeta.from_dict or from_instance | 14:55 |
| *** IanGovett has joined #openstack-nova | 14:55 | |
| danpb | btw it would be nice to get manager.py converted https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:virtimageprops-19,n,z | 14:55 |
| mriedem | why not just convert at the source image API? | 14:56 |
| *** willsama has joined #openstack-nova | 14:56 | |
| mriedem | doing from_dict calls all over the code base seems yucky | 14:56 |
| dims | johnthetubaguy : here's the blueprint you had asked me to create for mitaka oslo work - https://blueprints.launchpad.net/nova/+spec/oslo-for-mitaka | 14:56 |
| danpb | mriedem: well ultimately there will only be a couple of calls to from_dict needed in compute manager | 14:56 |
| PaulMurray | jaypipes, do you know if tdurakov is on vacation? | 14:56 |
| danpb | as the virt driers will get given a ImageMeta object directly | 14:56 |
| *** thumpba has quit IRC | 14:56 | |
| *** irenab has quit IRC | 14:56 | |
| danpb | back to your question though, i was really trying to avoid using dict compat at all | 14:57 |
| danpb | because i feel that leads to a state where we never actually finish the conversion | 14:57 |
| sdague | mriedem: is the indexer just not working at all? | 14:57 |
| jaypipes | PaulMurray: nope, he's around. | 14:57 |
| danpb | as we've seen with Instance where after 3 releases we still haven't stopped using dict access everywhere | 14:57 |
| mriedem | danpb: yeah, i'm fine with not having dict compat | 14:58 |
| PaulMurray | jaypipes, haven't seen him on line - I'll try email | 14:58 |
| danpb | mriedem: so I was just trying todo an incremental full conversion to ImageMeta in each area of code and never use dict compat | 14:58 |
| mriedem | sdague: idk, i just don't see e-r commenting on anything | 14:58 |
| danpb | even if that makes for some rather largish test suite updates | 14:58 |
| mriedem | danpb: heh, well, changing nova.image.api.API.get() to return an object caused 382 test failures :) | 14:59 |
| mriedem | and the fake image fixtures | 14:59 |
| danpb | mriedem: the image of converting nova.image.api.API.get() to return ImageMeta, might be smaller if we finish converting the rest of the code first | 14:59 |
| dansmith | mriedem: I was just getting ready to look at the results for those patches... anything I can help with? | 14:59 |
| danpb | leave that bit as the last step int he conversion | 14:59 |
| *** smatzek has joined #openstack-nova | 14:59 | |
| mriedem | danpb: ok, i can pile on top of your series | 14:59 |
| openstackgerrit | venkatamahesh proposed openstack/nova: OpenStack typo https://review.openstack.org/243151 | 14:59 |
| mriedem | danpb: btw, i created a mitaka-objects bp for tracking general objects work if you wanted to use that | 14:59 |
| mriedem | dansmith: yeah, sec | 14:59 |
| mriedem | dansmith: failed on https://review.openstack.org/#/c/242603/ http://logs.openstack.org/03/242603/7/check/gate-tempest-dsvm-cells/d13935b/logs/screen-n-cell-region.txt.gz?level=TRACE | 15:00 |
| danpb | mriedem: even better if you can review my series :-) | 15:00 |
| mriedem | yeah :) | 15:00 |
| danpb | it was essentially ready for +A but we held off to avoid risk of destablizing the release | 15:00 |
| danpb | as the compute manager conversion is kinda hairy | 15:00 |
| openstackgerrit | Alexandre Levine proposed openstack/nova-specs: delete_on_termination modification spec https://review.openstack.org/234269 | 15:00 |
| danpb | and will break all out of tree drivers too | 15:00 |
| dansmith | mriedem: ah | 15:00 |
| danpb | as they'll have to be changed to expect an ImageMeta object instead of dict | 15:00 |
| *** haomaiwa_ has quit IRC | 15:01 | |
| *** baoli has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-nova | 15:01 | |
| mriedem | danpb: yeah saw that comment | 15:01 |
| mriedem | at least we don't have a nova stadium | 15:01 |
| *** salv-orlando has quit IRC | 15:02 | |
| *** pabardina has joined #openstack-nova | 15:02 | |
| sdague | mriedem: hmmmm | 15:03 |
| mriedem | dansmith: danpb: johnthetubaguy: do we want to track https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:virtimageprops-19,n,z against https://blueprints.launchpad.net/nova/+spec/mitaka-objects ? | 15:04 |
| sdague | it's not clear that ERROR logs are getting indexed | 15:04 |
| *** thumpba has joined #openstack-nova | 15:04 | |
| dansmith | mriedem: I don't think I have a strong opinion | 15:04 |
| mriedem | otherwise i'm +W on https://review.openstack.org/#/c/190145/ | 15:04 |
| dansmith | mriedem: so did you not convert cells to use block_device_create() if we have a uuid instead of update_or_create? | 15:04 |
| mriedem | dansmith: that's sitting on top of your change | 15:05 |
| mriedem | however, that also failed (in the revert of the skip on top of it) | 15:05 |
| sdague | mriedem: http://logstash.openstack.org/#dashboard/file/logstash.json?query=loglevel:ERROR that's pretty suspicious | 15:05 |
| dansmith | mriedem: oh, I see, this log is from my patch | 15:05 |
| danpb | mriedem: i thought i already had it tagged against an objects blueprint, but i see those last few patches don't actual;ly have a BP listed | 15:06 |
| *** amotoki has quit IRC | 15:06 | |
| openstackgerrit | Sven Anderson proposed openstack/nova: Split up test_is_volume_backed_instance() into five functions https://review.openstack.org/243155 | 15:06 |
| danpb | so happy to update the commit msg to point to whatever is best | 15:06 |
| mriedem | danpb: i'd like to track against https://blueprints.launchpad.net/nova/+spec/mitaka-objects | 15:06 |
| mriedem | i'll +W your bottom change if you update quick | 15:06 |
| openstackgerrit | Sven Anderson proposed openstack/nova: Repair and rename test_is_volume_backed_instance_no_bdms() https://review.openstack.org/243156 | 15:06 |
| *** baoli has joined #openstack-nova | 15:07 | |
| pabardina | Hello, is there a driver as https://github.com/openstack/ec2-driver but instead of speaking with ec2 speak with a remote nova compute ? I would like to use an other nova compute in my nova compute | 15:07 |
| *** liverpooler has quit IRC | 15:07 | |
| *** pratikma_ has joined #openstack-nova | 15:07 | |
| dansmith | mriedem: hmm, the fail on the revert is different.. I wonder if I should remove that restriction from my patch so we can land yours and then introduce it before (or when) we do the revert | 15:07 |
| *** amotoki has joined #openstack-nova | 15:08 | |
| mriedem | let me look at the fail on the revert again | 15:08 |
| *** slDabbler has joined #openstack-nova | 15:08 | |
| bauzas | dansmith: mriedem: so I went early to bed on Friday, what's the outcome ? | 15:09 |
| baoli | moshele: Hi | 15:09 |
| mriedem | bauzas: things are still failing, we're looking at it now | 15:09 |
| dansmith | bauzas: the outcome is that we have patches up and they're not quite working yet | 15:09 |
| mriedem | bauzas: https://review.openstack.org/#/c/242603/ | 15:09 |
| bauzas | IIUC, the whitelist now includes the BDM tests, right? | 15:09 |
| *** lpetrut has quit IRC | 15:09 | |
| *** pratikmallya has quit IRC | 15:09 | |
| mriedem | bauzas: blacklist, yeah | 15:09 |
| mriedem | and the revert also failed https://review.openstack.org/#/c/242698/ | 15:10 |
| bauzas | so we should no longer have cells job failing *for that specific issue*, right? | 15:10 |
| mriedem | right | 15:10 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 15:10 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 15:10 |
| *** pratikmallya has joined #openstack-nova | 15:10 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 15:10 |
| bauzas | mriedem: okay, so the strategy is to add an UUID, right? | 15:10 |
| danpb | mriedem: i rebased it to current git master | 15:10 |
| *** achanda has joined #openstack-nova | 15:10 | |
| moshele | baoli: I update the my bug https://bugs.launchpad.net/nova/+bug/1499204 with more logs and I wonder what is the best approach to fix it in https://review.openstack.org/#/c/227160/ | 15:10 |
| openstack | Launchpad bug 1499204 in OpenStack Compute (nova) "wrong check for physical function in pci utils" [Undecided,In progress] - Assigned to Moshe Levi (moshele) | 15:10 |
| bauzas | mriedem: okay, I see the series, I'll review it | 15:10 |
| mriedem | bauzas: yeah, and check for that in the cells code | 15:10 |
| mriedem | danpb: ok | 15:11 |
| mriedem | johnthetubaguy: dansmith: danpb: can we get someone to trivially approve this quick https://blueprints.launchpad.net/nova/+spec/mitaka-objects ? | 15:11 |
| dansmith | mriedem: done | 15:13 |
| mriedem | thanks | 15:13 |
| baoli | moshele: Let me take a look and get back to you later | 15:13 |
| *** pratikma_ has quit IRC | 15:13 | |
| moshele | baoli: thanks | 15:13 |
| baoli | moshele: you are welcome | 15:13 |
| *** stevemar_ has joined #openstack-nova | 15:13 | |
| mriedem | danpb: oh i see the image_meta property patch was on top of the compute manager conversion beast :) | 15:14 |
| *** thumpba has quit IRC | 15:14 | |
| *** otter768 has joined #openstack-nova | 15:14 | |
| *** inteq has quit IRC | 15:15 | |
| *** eharney has joined #openstack-nova | 15:16 | |
| *** mrkz has joined #openstack-nova | 15:16 | |
| *** openstackgerrit has quit IRC | 15:17 | |
| *** pumaranikar has joined #openstack-nova | 15:17 | |
| *** openstackgerrit has joined #openstack-nova | 15:17 | |
| *** smurke has joined #openstack-nova | 15:18 | |
| *** thumpba has joined #openstack-nova | 15:19 | |
| *** otter768 has quit IRC | 15:19 | |
| mriedem | dansmith: not sure i grokked "I wonder if I should remove that restriction from my patch so we can land yours and then introduce it before (or when) we do the revert" | 15:19 |
| *** kevinbenton_ has quit IRC | 15:20 | |
| dansmith | mriedem: my patch is choking on the fact that we're providing the uuid up to the parent and so the parent is assuming update instead of create, until your patch which forces create | 15:20 |
| dansmith | mriedem: so I should probably not fail there until your patch is applied, and then we can add the safety check back in | 15:20 |
| *** dsuper7 has quit IRC | 15:20 | |
| *** kevinbenton has joined #openstack-nova | 15:20 | |
| dansmith | or you can in your patch to use create explicitly | 15:20 |
| dansmith | I'll pull this set down and make that change | 15:21 |
| bauzas | johnthetubaguy: FWIW, created https://blueprints.launchpad.net/nova/+spec/scheduler-driver-use-stevedore | 15:21 |
| mriedem | ok | 15:21 |
| bauzas | johnthetubaguy: just to make sure, it doesn't require a spec, right? | 15:21 |
| *** vishwanathj has joined #openstack-nova | 15:22 | |
| *** tonytan4ever has joined #openstack-nova | 15:26 | |
| *** wlehman__ has joined #openstack-nova | 15:26 | |
| *** wlehman__ has quit IRC | 15:26 | |
| *** salv-orlando has joined #openstack-nova | 15:27 | |
| *** mc_nair has joined #openstack-nova | 15:27 | |
| mriedem | i guess the cells job isn't voting on stable/kilo so we don't have to care about skipping the failing test there | 15:28 |
| *** markus_z_meeting is now known as markus_z | 15:28 | |
| *** amotoki has quit IRC | 15:28 | |
| *** salv-orlando has quit IRC | 15:28 | |
| *** wlehman__ has joined #openstack-nova | 15:29 | |
| dansmith | mriedem: looking at the code this morning, I also think we can't fail there if a uuid is provided because we'll create one for existing ones in the child and then send an update to the parent, but it won't know the uuid until we've done that once | 15:29 |
| *** willsama has quit IRC | 15:29 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Revert "Exclude all BDM checks for cells" https://review.openstack.org/242698 | 15:30 |
| openstackgerrit | Dan Smith proposed openstack/nova: cells: check for existing BDM based on uuid in bdm_update_or_create_at_top https://review.openstack.org/242649 | 15:30 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 15:30 |
| openstackgerrit | Dan Smith proposed openstack/nova: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | 15:30 |
| mriedem | dansmith: ok so you removed the NotFound from the db api | 15:30 |
| dansmith | yeah | 15:31 |
| openstackgerrit | Alexandre Levine proposed openstack/nova-specs: delete_on_termination modification spec https://review.openstack.org/234269 | 15:31 |
| dansmith | and changed the logic to not skip the device_name check if uuid is provided | 15:31 |
| dansmith | i.e. changed the elif to an if and included "and results | 15:31 |
| markus_z | bauzas: Thanks for the info, I'll yell as loud as I can ;) | 15:31 |
| dansmith | er, "if not result and deviec_name" | 15:31 |
| mriedem | yeah, so try to find by uuid, if not found, try by device_name | 15:32 |
| *** krtaylor has quit IRC | 15:32 | |
| dansmith | yeah | 15:32 |
| bauzas | dansmith: so if you don't find an uuid, continue searching by device_name if so ? | 15:32 |
| dansmith | hopefully we can just remove this soon anyway, so | 15:32 |
| bauzas | ergh, jinxe | 15:32 |
| dansmith | it doesn't matter that it's perfect I guess | 15:32 |
| *** burgerk has quit IRC | 15:33 | |
| bauzas | that looks right tho | 15:33 |
| *** links has quit IRC | 15:34 | |
| *** thumpba has quit IRC | 15:34 | |
| mriedem | i'm still a bit worried about why the revert patch failed on the same test again, which comes after my change in the cells code | 15:34 |
| dansmith | yeah, I'm not sure about that | 15:35 |
| bauzas | dansmith: https://review.openstack.org/#/c/242602/7/nova/db/sqlalchemy/api.py,cm L3954 => shouldn't we update by also generating an UUID ? | 15:35 |
| *** mgoddard_ has quit IRC | 15:35 | |
| dansmith | I wonder if it was a failure to update the instance error state after we failed to update a bdm or something? | 15:35 |
| dansmith | bauzas: no | 15:35 |
| dansmith | bauzas: because then the parent and child cells could have different uuids | 15:35 |
| mriedem | my logic in the create=None/bdm with uuid/not found case might be wrong | 15:36 |
| mriedem | i'm assuming that if create==None and bdm.uuid, if not found then we should update | 15:36 |
| mriedem | i'm wondering if that should be bdm_update_or_create | 15:36 |
| mriedem | oh nvm | 15:36 |
| bauzas | dansmith: oh snap indeed, so since we only allow to generate it when creating it, that means we'll get it when updating the row | 15:36 |
| dansmith | it'd be nice if we were able to always use True or False for that flag now, | 15:36 |
| mriedem | that'd be the same as what the db api is already doing, so i set the create var to True | 15:37 |
| dansmith | but I guess we can't do that because you don't know at that level whether the parent has knowledge of the uuid yet | 15:37 |
| mriedem | yeah that's what i was trying to do in my change | 15:37 |
| dansmith | bauzas: right | 15:37 |
| mriedem | turn create=None into True/False | 15:37 |
| mriedem | if the bdm has a uuid | 15:37 |
| johnthetubaguy | bauzas: yeah, sounds fine to me | 15:37 |
| bauzas | johnthetubaguy: ack, FWIW I updated the low-hanging-fruit etherpad with it | 15:38 |
| johnthetubaguy | bauzas: oh, cool, good idea | 15:38 |
| *** tdurakov has joined #openstack-nova | 15:38 | |
| tdurakov | PaulMurray, hi | 15:38 |
| *** pratikma_ has joined #openstack-nova | 15:38 | |
| *** mgoddard has joined #openstack-nova | 15:39 | |
| *** thumpba has joined #openstack-nova | 15:41 | |
| *** pratikmallya has quit IRC | 15:41 | |
| mriedem | dansmith: bauzas: do you see anything wrong in https://review.openstack.org/#/c/242649/5/nova/cells/messaging.py ? | 15:41 |
| mriedem | or are we just waiting for a new test run to see what happens? | 15:41 |
| *** thumpba has quit IRC | 15:42 | |
| *** wlehman__ has quit IRC | 15:44 | |
| *** mtanino has joined #openstack-nova | 15:45 | |
| *** krtaylor has joined #openstack-nova | 15:45 | |
| bauzas | mriedem: so I wondered if the problem is that it doesn't change the behaviour | 15:45 |
| dansmith | hmm, I hadn't reviewed that, but it's kinda complicated | 15:45 |
| bauzas | mriedem: because if it doesn't get the uuid, it still calls update_or_create() | 15:45 |
| bauzas | which doesn't actually change anything IMHO | 15:46 |
| bauzas | like dansmith said, I'd rather force either a create or an update | 15:46 |
| mriedem | bauzas: but it should be getting a uuid now based on the dan's changes | 15:46 |
| mriedem | the dan | 15:46 |
| mriedem | heh | 15:46 |
| *** dansmith is now known as thedan | 15:46 | |
| mriedem | \o/ | 15:46 |
| *** thedan is now known as dansmith | 15:46 | |
| mriedem | one dan to rule them all | 15:46 |
| dansmith | mriedem: maybe add a few more log statements in there for now to make sure it's doing what you expect? | 15:47 |
| bauzas | mriedem: mmm, that's pretty unsure | 15:47 |
| mriedem | yeah, was thinking about doing that after the revert failed | 15:47 |
| *** davideagnello has joined #openstack-nova | 15:47 | |
| *** lpetrut has joined #openstack-nova | 15:47 | |
| danpb | jaypipes: can you remove your -2 from this now we agreed the way forward at the summit https://review.openstack.org/#/c/149625/ | 15:47 |
| dansmith | mriedem: so we can create the bdm in the cell now after my change, right? | 15:48 |
| mriedem | i mean, if create==None and not bdm.uuid, we could create the bdm uuid and insert the bdm too | 15:48 |
| dansmith | mriedem: so we could just create in the parent, get the uuid there, then include that in what we pass down to the child | 15:48 |
| mriedem | dansmith: as in remove the override on _create_block_device_mappings? | 15:48 |
| dansmith | and then never do create=Truthy from the child anymore | 15:48 |
| *** achanda has quit IRC | 15:48 | |
| dansmith | mriedem: yeah | 15:48 |
| *** emagana has joined #openstack-nova | 15:49 | |
| mriedem | let me pull down the latest and poke around | 15:51 |
| bauzas | mmm | 15:51 |
| bauzas | I'm wondering about something | 15:51 |
| *** pratikma_ has quit IRC | 15:51 | |
| *** garyk has quit IRC | 15:51 | |
| bauzas | so, we first create it on the child cell using the regular DB, and then we call the messaging bits to populate it on the api db, right? | 15:51 |
| dansmith | no | 15:52 |
| *** davideagnello has quit IRC | 15:52 | |
| dansmith | I mean, that's how it works now, | 15:52 |
| dansmith | but that's not how it *should* work | 15:52 |
| dansmith | we only did that because we needed to generate the virt-specific device name first | 15:52 |
| openstackgerrit | venkatamahesh proposed openstack/nova: OpenStack typo https://review.openstack.org/243151 | 15:52 |
| dansmith | but now we could create it in the api cell first, and update it with the device_name later | 15:52 |
| bauzas | dansmith: sure, that would ensure that uuids are unique | 15:53 |
| mriedem | yeah this was the change that overrode the api cell creating the bdms https://review.openstack.org/#/c/152257/ | 15:53 |
| *** willsama has joined #openstack-nova | 15:53 | |
| mriedem | that was because it keyed off device_name and volume_id, which weren't set | 15:54 |
| mriedem | now we can key off uuid | 15:54 |
| mriedem | ftw | 15:54 |
| mriedem | jaypipes: i've got 55 pounds of greasy bassett hound snoring behind me | 15:54 |
| dansmith | mriedem: aye | 15:54 |
| *** burgerk has joined #openstack-nova | 15:55 | |
| *** electrocucaracha has joined #openstack-nova | 15:55 | |
| bauzas | I'm just about repopulating my aquarium, should be far quieter | 15:55 |
| *** thumpba has joined #openstack-nova | 15:56 | |
| *** achanda has joined #openstack-nova | 15:57 | |
| *** morgabra has quit IRC | 15:58 | |
| mriedem | so i think we can also change bdm.update_or_create() in nova.compute.api.API._create_block_device_mapping to just bdm.create() | 15:59 |
| mriedem | we basically want to get rid of calls to update_or_create() | 15:59 |
| dansmith | yes | 16:00 |
| dansmith | although not sure we have anything else to forward bdm updates up to the parent, do we? | 16:00 |
| *** sfinucan has joined #openstack-nova | 16:00 | |
| dansmith | so we might just need to keep that cells for now, but only ever pass it create=False | 16:00 |
| mriedem | yeah | 16:00 |
| mriedem | but we can remove nova.objects.BlockDeviceMapping.update_or_create | 16:00 |
| mriedem | since only compute API was using it | 16:00 |
| *** haomaiwang has quit IRC | 16:01 | |
| mriedem | heh, we didn't even unit test it | 16:01 |
| dansmith | nice | 16:01 |
| mriedem | but...can i remove a remotable object method w/o a version bump? | 16:01 |
| dansmith | no | 16:01 |
| *** haomaiwang has joined #openstack-nova | 16:01 | |
| mriedem | shart | 16:01 |
| dansmith | but you can remove use of it, and mark it for deprecation | 16:01 |
| mriedem | yeah | 16:01 |
| *** eharney has quit IRC | 16:02 | |
| mriedem | how are we marking these for deprecation? logging a warning? or just TODO: remove in v2 of the BDM object | 16:02 |
| *** browne has joined #openstack-nova | 16:02 | |
| openstackgerrit | Ludovic Beliveau proposed openstack/nova: Update binding:profile for SR-IOV ports https://review.openstack.org/242573 | 16:03 |
| *** morgabra has joined #openstack-nova | 16:03 | |
| baoli | moshele: Hi | 16:04 |
| *** diogogmt has joined #openstack-nova | 16:04 | |
| moshele | baoli: hi | 16:04 |
| baoli | moshele: I think the whitelist definition is wrong, or you may want to take a look at https://github.com/openstack/nova/blob/master/nova/pci/manager.py#L115 | 16:06 |
| baoli | moshele, what's your virsh output on the particular PCI device (corresponding to a PF) look like on your system | 16:06 |
| dansmith | mriedem: yep, just the comment | 16:07 |
| *** thumpba has quit IRC | 16:07 | |
| *** krotscheck has joined #openstack-nova | 16:08 | |
| *** dustins has joined #openstack-nova | 16:08 | |
| *** stackdump has joined #openstack-nova | 16:08 | |
| *** thedodd has joined #openstack-nova | 16:08 | |
| *** salv-orlando has joined #openstack-nova | 16:09 | |
| moshele | baoli: you want me to run the virsh nodedev-dumpxml command ? | 16:10 |
| baoli | moshele, yes | 16:10 |
| sdague | mriedem: so on the ebtables collision between nova and libvirt, has anyone considered a [workaround] to have our own lock around libvirt commands and our own ebtables commands? | 16:10 |
| mriedem | sdague: not that i know of | 16:11 |
| *** mspreitz has joined #openstack-nova | 16:11 | |
| *** mgoddard_ has joined #openstack-nova | 16:11 | |
| sdague | I managed to trip it twice (on 2 different test jobs) in the same patch on liberty | 16:11 |
| sdague | :( | 16:11 |
| dansmith | are all the libvirt library commands synchronous? | 16:11 |
| sdague | dansmith: don't know | 16:12 |
| *** thedodd has quit IRC | 16:12 | |
| *** thumpba has joined #openstack-nova | 16:12 | |
| *** mgoddard has quit IRC | 16:12 | |
| jaypipes | danpb: done! | 16:12 |
| *** thedodd has joined #openstack-nova | 16:12 | |
| jaypipes | mriedem: lucky you! | 16:12 |
| moshele | baoli: the output of the 2 ports http://pastebin.com/4hQqhVvC | 16:13 |
| *** mspreitz has quit IRC | 16:13 | |
| openstackgerrit | Alexandre Levine proposed openstack/nova-specs: delete_on_termination modification spec https://review.openstack.org/234269 | 16:15 |
| *** scheuran has quit IRC | 16:16 | |
| *** alex_klimov has quit IRC | 16:16 | |
| *** mdrabe has quit IRC | 16:16 | |
| *** tonytan4ever has quit IRC | 16:16 | |
| *** dustins_ has joined #openstack-nova | 16:17 | |
| *** eharney has joined #openstack-nova | 16:17 | |
| *** Sree has quit IRC | 16:17 | |
| mriedem | dansmith: am i able to basically make bdm.update_or_create() a noop or do i still need to honor the update_or_create logic in that private _create method? basically i want to deprecate update_or_create and treat both create() and update_or_create() as create, no updates. | 16:18 |
| mriedem | b/c this logic is all assuming you can't create bdm's in the api cell | 16:18 |
| moshele | baoli: I have to go let talk tomorrow | 16:19 |
| *** dustins has quit IRC | 16:19 | |
| baoli | moshele: sure. | 16:19 |
| *** mjura has quit IRC | 16:19 | |
| *** dustins_ is now known as dustins | 16:19 | |
| *** pratikmallya has joined #openstack-nova | 16:20 | |
| *** ijw has joined #openstack-nova | 16:20 | |
| *** moshele has quit IRC | 16:21 | |
| *** pratikma_ has joined #openstack-nova | 16:23 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: ScalityVolume:fix how remote FS mount is detected https://review.openstack.org/210468 | 16:23 |
| *** tjones has joined #openstack-nova | 16:23 | |
| *** ccarmack1 has joined #openstack-nova | 16:24 | |
| *** eharney has quit IRC | 16:24 | |
| *** thumpba has quit IRC | 16:24 | |
| ccarmack1 | " | 16:24 |
| *** jdurgin1 has joined #openstack-nova | 16:24 | |
| *** pratikmallya has quit IRC | 16:26 | |
| *** thumpba has joined #openstack-nova | 16:26 | |
| dansmith | mriedem: you can't remove or neuter the rpc call, if that's what you're asking | 16:26 |
| *** e0ne has quit IRC | 16:26 | |
| mriedem | i didn't want to say the n word while mortimer was behind me | 16:26 |
| *** lpetrut has quit IRC | 16:26 | |
| dansmith | heh | 16:26 |
| *** rotbeard has quit IRC | 16:27 | |
| *** thumpba_ has joined #openstack-nova | 16:30 | |
| *** thumpba has quit IRC | 16:30 | |
| mriedem | should we update cells.bdm_destroy_at_top to also get a uuid (would be an rpc version bump) in this change or hold that off for later | 16:31 |
| *** sahid has quit IRC | 16:31 | |
| mriedem | right now it tries to find the bdm by device_name or volume_id in order to delete it | 16:31 |
| *** smurke has quit IRC | 16:32 | |
| *** garyk has joined #openstack-nova | 16:32 | |
| *** smurke has joined #openstack-nova | 16:33 | |
| mriedem | omitting for now | 16:33 |
| *** salv-orlando has quit IRC | 16:33 | |
| *** nkrinner has quit IRC | 16:33 | |
| *** mdrabe has joined #openstack-nova | 16:33 | |
| *** Piet has joined #openstack-nova | 16:34 | |
| *** e0ne has joined #openstack-nova | 16:34 | |
| *** sahid has joined #openstack-nova | 16:34 | |
| *** eharney has joined #openstack-nova | 16:36 | |
| smurke | https://bugs.launchpad.net/nova/+bug/1369563 I am curious to know exactly what is required as the patch for this bug was abondend. | 16:38 |
| openstack | Launchpad bug 1369563 in OpenStack Compute (nova) "Keep tracking image association when create volume from image" [Wishlist,Confirmed] - Assigned to Sumant Murke (sumant-murke) | 16:38 |
| *** baoli has quit IRC | 16:39 | |
| *** lsmola has quit IRC | 16:39 | |
| *** cdent has quit IRC | 16:39 | |
| *** dustins has quit IRC | 16:39 | |
| openstackgerrit | Alexandre Levine proposed openstack/nova-specs: delete_on_termination modification spec https://review.openstack.org/234269 | 16:40 |
| *** rk4n has quit IRC | 16:40 | |
| *** wverdugo500 has joined #openstack-nova | 16:40 | |
| *** aix has quit IRC | 16:45 | |
| dansmith | mriedem: okay | 16:45 |
| dansmith | mriedem: looks like those patches are happy now, yes? | 16:45 |
| *** diogogmt has quit IRC | 16:45 | |
| dansmith | or happier at least | 16:45 |
| mriedem | did they pass the cells job? | 16:46 |
| mriedem | i'm just finishing up mine | 16:46 |
| *** tonytan4ever has joined #openstack-nova | 16:46 | |
| *** lpetrut has joined #openstack-nova | 16:47 | |
| dansmith | looks like they might've based on my dash | 16:47 |
| dansmith | the revert is passing everything except one in the first third | 16:47 |
| dansmith | which would be all the cells ones I think | 16:47 |
| *** smurke has quit IRC | 16:47 | |
| *** dustins has joined #openstack-nova | 16:49 | |
| *** thumpba_ has quit IRC | 16:49 | |
| *** jlanoux has quit IRC | 16:49 | |
| markus_z | lxsli: I didn't forget you about the trivial patch list task. Apologies for my late notice. | 16:50 |
| markus_z | lxsli: I guess I need the next 2 days to bring a few things on track and then I can get back to this task. | 16:51 |
| *** smurke has joined #openstack-nova | 16:53 | |
| *** tdurakov has quit IRC | 16:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Revert "Exclude all BDM checks for cells" https://review.openstack.org/242698 | 16:55 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: cells: create block device mappings in API cell https://review.openstack.org/242649 | 16:55 |
| mriedem | dansmith: bauzas: ^ | 16:55 |
| *** ihrachys has quit IRC | 16:56 | |
| *** thumpba has joined #openstack-nova | 16:56 | |
| *** baoli has joined #openstack-nova | 16:58 | |
| mriedem | i'm not totally sure about all of the bdm object logic in there | 16:58 |
| mriedem | like, if a child compute cell creates a bdm and we pass that to the parent cell as an update, if the child and parent have different uuids for the bdm then we won't update the parent cell | 16:58 |
| mriedem | but i guess that'd just be a bug that the child cell is creating a bdm? | 16:58 |
| *** mgoddard__ has joined #openstack-nova | 17:00 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** aix has joined #openstack-nova | 17:01 | |
| *** haomaiwang has joined #openstack-nova | 17:01 | |
| *** su_zhang has joined #openstack-nova | 17:01 | |
| bauzas | mriedem: so I was otp and now I need to drop off for a bit, but we should keep consistency with UUIDs between api db and cells dbs | 17:02 |
| *** thumpba has quit IRC | 17:03 | |
| bauzas | mriedem: hence dansmith pointing out that the correct process should be to first create the entry in the parent db, get an UUID, and then pass the whole stuff (incl. the uuid) to the child cell | 17:03 |
| *** mgoddard_ has quit IRC | 17:03 | |
| *** daemontool has quit IRC | 17:04 | |
| *** daemontool has joined #openstack-nova | 17:04 | |
| bauzas | mriedem: okay, nevermind, /me stupid and having not looked yet at your update... | 17:04 |
| *** matrohon has quit IRC | 17:05 | |
| *** thumpba has joined #openstack-nova | 17:05 | |
| mriedem | i put a comment in my change related to that | 17:06 |
| *** edtubill has joined #openstack-nova | 17:06 | |
| *** Sree has joined #openstack-nova | 17:07 | |
| *** gszasz has quit IRC | 17:07 | |
| *** yassine__ has quit IRC | 17:08 | |
| *** edtubill has quit IRC | 17:08 | |
| *** edtubill has joined #openstack-nova | 17:08 | |
| *** achanda has quit IRC | 17:09 | |
| *** e0ne has quit IRC | 17:09 | |
| *** krotscheck has quit IRC | 17:12 | |
| *** moshele has joined #openstack-nova | 17:13 | |
| *** armax has joined #openstack-nova | 17:14 | |
| *** lpetrut has quit IRC | 17:14 | |
| *** nic has joined #openstack-nova | 17:14 | |
| *** otter768 has joined #openstack-nova | 17:15 | |
| *** tonytan4ever has quit IRC | 17:17 | |
| *** dustins has quit IRC | 17:18 | |
| *** dustins has joined #openstack-nova | 17:18 | |
| *** otter768 has quit IRC | 17:19 | |
| *** thumpba has quit IRC | 17:20 | |
| *** su_zhang has quit IRC | 17:21 | |
| *** su_zhang has joined #openstack-nova | 17:21 | |
| mriedem | danpb: there is a bug in _unshelve_instance when image is None https://review.openstack.org/#/c/189685/ | 17:23 |
| mriedem | i've gotten through the compute manager and base compute driver changes, i'll dig into the rest after addressing current comments | 17:24 |
| *** thumpba has joined #openstack-nova | 17:24 | |
| *** breitz has quit IRC | 17:24 | |
| danpb | mriedem: ok, i'll have a look | 17:25 |
| *** su_zhang has quit IRC | 17:28 | |
| hogepodge | markus_z: I left additional comments. | 17:28 |
| *** krotscheck has joined #openstack-nova | 17:29 | |
| hogepodge | markus_z: we should probably engage dhellmann over in #openstack-oslo to help figure out the best way forward. I also don't know enough about oslo to say for certainty. | 17:29 |
| markus_z | hogepodge: I need a moment to process your info in the review | 17:32 |
| ericksonsantos | Hi, everyone | 17:32 |
| dansmith | mriedem: I think you're failing unit tests on your patch | 17:32 |
| ericksonsantos | Recently I sent a patch to gerrit... I got a +1 from jenkins, but xen project CI gave me a -1. I've looked through the logs, and it doesn't seem to be something related to the changes I've made. May someone give me a help with this? | 17:32 |
| ericksonsantos | The test that doesn't pass is: tempest.api.compute.admin.test_servers_negative.ServersAdminNegativeTestJSON.test_migrate_server_invalid_state[id-b0b17f83-d14e-4fc4-8f31-bcc9f3cfa629,negative] | 17:32 |
| ericksonsantos | and that is my patch https://review.openstack.org/#/c/242514 | 17:33 |
| BobBall | ericksonsantos: If you're confident the issue is not related to your change, then try rechecking. There are details in the message sent from the XenProject CI | 17:33 |
| *** unicell1 has quit IRC | 17:34 | |
| *** moshele has quit IRC | 17:34 | |
| markus_z | ericksonsantos: There is also this mail thread which gives some pointers on how to debug the gate: http://markmail.org/thread/gvv62dafv53eyoth | 17:35 |
| markus_z | ericksonsantos: I recommend to watch the videos they are very educational. | 17:35 |
| ericksonsantos | Nice | 17:35 |
| ericksonsantos | thanks, BobBall and markus_z :-) | 17:36 |
| markus_z | hogepodge: switching to #openstack-oslo for that topic | 17:37 |
| openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/nova: Nested Quota Driver https://review.openstack.org/242626 | 17:37 |
| *** edtubill has quit IRC | 17:38 | |
| *** electrocucaracha has quit IRC | 17:40 | |
| *** eglynn has quit IRC | 17:46 | |
| *** apoorvad has joined #openstack-nova | 17:46 | |
| *** edtubill has joined #openstack-nova | 17:47 | |
| *** electrocucaracha has joined #openstack-nova | 17:47 | |
| *** stevemar_ has quit IRC | 17:48 | |
| *** derekh has quit IRC | 17:52 | |
| *** moshele has joined #openstack-nova | 17:52 | |
| *** tonytan4ever has joined #openstack-nova | 17:53 | |
| *** rlrossit has quit IRC | 17:53 | |
| *** ssurana has joined #openstack-nova | 17:54 | |
| mriedem | dansmith: i know i am | 17:55 |
| mriedem | dansmith: was waiting for cells job results before updating unit tests | 17:55 |
| dansmith | okay | 17:55 |
| *** rlrossit has joined #openstack-nova | 17:55 | |
| *** thumpba has quit IRC | 17:56 | |
| *** aix has quit IRC | 18:00 | |
| *** haomaiwang has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-nova | 18:01 | |
| *** lucasagomes is now known as lucas-afk | 18:01 | |
| mriedem | claudiub: i assume os-win isn't like oslo.vmware (going into oslo) because dims did a lot of work with the vmware driver | 18:02 |
| mriedem | but there aren't oslo cores that know much about hyper-v | 18:02 |
| mriedem | similar to os-brick | 18:02 |
| dims | mriedem os-win is not under oslo umbrella | 18:02 |
| dims | right | 18:02 |
| mriedem | yeah, just clarifying the rationale | 18:03 |
| *** jistr has quit IRC | 18:03 | |
| *** mgoddard has joined #openstack-nova | 18:03 | |
| *** mgoddard__ has quit IRC | 18:04 | |
| *** baoli has quit IRC | 18:04 | |
| *** ctrath has quit IRC | 18:05 | |
| openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/nova: Nested Quota Driver https://review.openstack.org/242626 | 18:05 |
| *** baoli has joined #openstack-nova | 18:06 | |
| *** electrocucaracha has quit IRC | 18:06 | |
| *** jichen has joined #openstack-nova | 18:06 | |
| *** unicell has joined #openstack-nova | 18:07 | |
| dims | mriedem exactly the objections raised by oslo folks, we have no clue about hyperv | 18:07 |
| *** belmoreira has quit IRC | 18:08 | |
| mriedem | claudiub: https://review.openstack.org/#/c/227827/ needs to be cleaned up a bit, then i'm +W | 18:09 |
| *** moshele has quit IRC | 18:09 | |
| *** vilobhmm has joined #openstack-nova | 18:10 | |
| *** electrocucaracha has joined #openstack-nova | 18:11 | |
| *** baoli has quit IRC | 18:11 | |
| *** baoli has joined #openstack-nova | 18:11 | |
| claudiub | mriedem: cool, thanks for the review. Yeah, as dims said, os-win is not under oslo. Will update the spec asap. | 18:14 |
| *** ctrath has joined #openstack-nova | 18:15 | |
| *** danpb has quit IRC | 18:15 | |
| *** ZZelle_ has joined #openstack-nova | 18:15 | |
| *** john5223 is now known as zz_john5223 | 18:17 | |
| mriedem | dansmith: | 18:17 |
| mriedem | 2015-11-09 18:11:55.051 | {2} tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_create_ebs_image_and_check_boot [59.735542s] ... ok 2015-11-09 18:12:55.355 | {2} tempest.scenario.test_volume_boot_pattern.TestVolumeBootPatternV2.test_create_ebs_image_and_check_boot [58.133536s] ... ok | 18:17 |
| mriedem | however, i apparently broke some other tests | 18:17 |
| mriedem | https://jenkins05.openstack.org/job/gate-tempest-dsvm-cells/1840/console | 18:17 |
| *** zz_john5223 is now known as john5223 | 18:19 | |
| mriedem | oy, that update at top logic needs work http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//logs/screen-n-cell-region.txt.gz?level=TRACE | 18:21 |
| *** lpetrut has joined #openstack-nova | 18:22 | |
| *** slDabbler has quit IRC | 18:22 | |
| *** thedodd has quit IRC | 18:23 | |
| *** thedodd has joined #openstack-nova | 18:23 | |
| *** davideagnello has joined #openstack-nova | 18:24 | |
| markus_z | mmmpork: Are you around? | 18:24 |
| *** su_zhang_ has joined #openstack-nova | 18:25 | |
| *** baoli has quit IRC | 18:25 | |
| *** baoli has joined #openstack-nova | 18:27 | |
| *** rlrossit has quit IRC | 18:28 | |
| markus_z | mmmpork: Please let me know what you think about: https://etherpad.openstack.org/p/config-options | 18:28 |
| *** romainh has quit IRC | 18:29 | |
| *** breitz has joined #openstack-nova | 18:29 | |
| *** davideagnello has quit IRC | 18:33 | |
| *** davideagnello has joined #openstack-nova | 18:33 | |
| *** breitz has quit IRC | 18:34 | |
| *** breitz has joined #openstack-nova | 18:35 | |
| *** rlrossit has joined #openstack-nova | 18:35 | |
| mriedem | alaski: what does cells_api._call_to_cells do? call from the parent cell to the child cell? | 18:36 |
| mriedem | or child to parent? | 18:36 |
| *** daemontool has quit IRC | 18:38 | |
| *** daemontool has joined #openstack-nova | 18:39 | |
| dansmith | mriedem: so did you want to try to start creating at the parent? | 18:39 |
| *** browne has quit IRC | 18:39 | |
| mriedem | dansmith: that's what https://review.openstack.org/#/c/242649/6/nova/compute/cells_api.py does | 18:39 |
| dansmith | oh, I'm out of date | 18:39 |
| mriedem | i'm seeing stuff like this now http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//logs/screen-n-cell-region.txt.gz#_2015-11-09_18_03_39_598 | 18:40 |
| *** browne has joined #openstack-nova | 18:40 | |
| mriedem | the only thing on that bdm is the image_id so it's the server boot, before the volume attach | 18:41 |
| mriedem | i have a feeling with my change we're not updating when we need to (or where we need to) | 18:41 |
| *** breitz has quit IRC | 18:41 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 18:41 | |
| mriedem | huh, i see a separate unrelated bug | 18:42 |
| *** breitz has joined #openstack-nova | 18:42 | |
| dansmith | mriedem: well, if you added some logging into the bdm.create() call, that might help us see that it's actually doing it at the top level | 18:43 |
| mriedem | yeah, ok | 18:43 |
| mriedem | also, https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L1009 | 18:43 |
| mriedem | if yo'ure using cells rpcapi 1.34 that instance param is a dict | 18:43 |
| dansmith | the cells rpc stuff is never right, AFAIK | 18:43 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/cells/rpcapi.py#L204 | 18:44 |
| mriedem | ok :) | 18:44 |
| *** signed8bit_ZZZzz is now known as signed8bit | 18:44 | |
| mriedem | seems we should fix that though right? | 18:44 |
| dansmith | sure, but only once you're out of real things to fix :) | 18:44 |
| mriedem | heh | 18:44 |
| mriedem | alright, i'll just open a bug, low-hanging-fruit for the masses | 18:45 |
| mriedem | and add logging on bdm.create() | 18:45 |
| dansmith | cool | 18:45 |
| openstackgerrit | Jay Pipes proposed openstack/nova-specs: Add concept of resource providers https://review.openstack.org/225546 | 18:45 |
| mriedem | dansmith: did you see my comment/question here? https://review.openstack.org/#/c/242649/6/nova/objects/block_device.py | 18:45 |
| *** achanda has joined #openstack-nova | 18:45 | |
| *** rlrossit has quit IRC | 18:45 | |
| *** achanda has quit IRC | 18:45 | |
| jaypipes | PaulMurray, lxsli, edleafe, johnthetubaguy, bauzas: ok, sorry, took a little longer than expected: https://review.openstack.org/225546 | 18:46 |
| dansmith | mriedem: we have to create in both places | 18:46 |
| bauzas | jaypipes: no worries | 18:46 |
| jaypipes | mriedem, dansmith: you too if you'd like... | 18:46 |
| bauzas | so I'm dot-following the cells issue... | 18:46 |
| *** electroc_ has joined #openstack-nova | 18:47 | |
| dansmith | dot-following? | 18:47 |
| bauzas | following in dot ? | 18:47 |
| * dansmith is confused | 18:48 | |
| *** diogogmt has joined #openstack-nova | 18:48 | |
| *** tonytan4ever has quit IRC | 18:48 | |
| dansmith | oh | 18:48 |
| dansmith | meaning just watching the action? | 18:48 |
| bauzas | http://www.linguee.fr/francais-anglais/search?source=auto&query=suivi+en+pointill%C3%A9 | 18:49 |
| *** ctrath has quit IRC | 18:49 | |
| bauzas | no, trying to follow the progress but only sometimes so missing some crucial bits | 18:49 |
| *** electrocucaracha has quit IRC | 18:49 | |
| dansmith | okay | 18:49 |
| bauzas | reading the scrollback is hard | 18:50 |
| *** tdurakov has joined #openstack-nova | 18:50 | |
| mriedem | bauzas: so the revert of the test skip passed the ebs test, which is good, | 18:50 |
| mriedem | but a bunch of volume attach tests failed, which is bad | 18:50 |
| bauzas | but IIUC, the series fixed the problem but had some side effects? | 18:50 |
| bauzas | okay, that's my understanding | 18:50 |
| bauzas | so, playing a whack-a-mole ? | 18:51 |
| mriedem | well, i feel like we're closing in | 18:51 |
| *** burt has joined #openstack-nova | 18:51 | |
| *** rook has joined #openstack-nova | 18:51 | |
| mriedem | if not for a kill, then maybe a crippling wound | 18:51 |
| openstackgerrit | Michael Turek proposed openstack/nova: Make pause_server a blocking call https://review.openstack.org/243258 | 18:52 |
| *** tdurakov has quit IRC | 18:53 | |
| *** pumaranikar has quit IRC | 18:53 | |
| *** ctrath has joined #openstack-nova | 18:53 | |
| *** daemontool has quit IRC | 18:54 | |
| *** breitz has quit IRC | 18:54 | |
| mriedem | actually, we should have logging in the parent cell, that's the screen-n-cell-region log right? | 18:55 |
| mriedem | we should be seeing _create_block_device_mapping in the logs | 18:55 |
| *** tdurakov has joined #openstack-nova | 18:55 | |
| mriedem | b/c of https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1272 | 18:55 |
| *** alex_xu has quit IRC | 18:56 | |
| bauzas | mriedem: correct me if I'm wrong, but I https://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L201 ? | 18:56 |
| *** pratikmallya has joined #openstack-nova | 18:57 | |
| mriedem | bauzas: i removed that | 18:57 |
| mriedem | dansmith: looks like it happens in hte child cell http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//logs/screen-n-cell-child.txt.gz#_2015-11-09_18_03_39_438 | 18:57 |
| bauzas | okay, I should stop commenting and do my homework | 18:57 |
| mriedem | bauzas: https://review.openstack.org/#/c/242649/6/nova/compute/cells_api.py | 18:57 |
| *** alex_xu has joined #openstack-nova | 18:57 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 18:57 | |
| dansmith | mriedem: is that logged from inside _create on the object? | 18:58 |
| mriedem | no | 18:58 |
| mriedem | from https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1272 | 18:58 |
| mriedem | which is what cells_api was overriding | 18:58 |
| dansmith | yeah, okay | 18:59 |
| *** pratikm__ has joined #openstack-nova | 18:59 | |
| dansmith | mriedem: and in the parent: http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//logs/screen-n-api.txt.gz#_2015-11-09_17_55_06_063 | 18:59 |
| *** e0ne has joined #openstack-nova | 19:00 | |
| *** pratikma_ has quit IRC | 19:00 | |
| dansmith | mriedem: so maybe logging out all the uuids and stuff on both sides low down enough to see if the uuid is not getting passed and thus generated in both place, or something | 19:00 |
| mriedem | what is the cells region log? | 19:00 |
| dansmith | mriedem: I wonder if, when we make the call to the child we're not using the full object | 19:00 |
| dansmith | mriedem: it's the nova-cells service at the top | 19:00 |
| *** haomaiwang has quit IRC | 19:01 | |
| mriedem | so the cells messaging code? right | 19:01 |
| dansmith | mriedem: so the request goes n-api -> n-cells-child -> n-cells-region | 19:01 |
| *** su_zhang_ has quit IRC | 19:01 | |
| dansmith | yeah | 19:01 |
| mriedem | where does the call to the child happen? | 19:01 |
| dansmith | mriedem: is this attach or boot? | 19:01 |
| *** breitz has joined #openstack-nova | 19:01 | |
| mriedem | attach | 19:01 |
| dansmith | okay | 19:01 |
| *** haomaiwa_ has joined #openstack-nova | 19:02 | |
| dansmith | the call to the child comes from nova-api, to the cells_api, which makes an rpc call to the child's nova-cells service | 19:02 |
| *** pratikmallya has quit IRC | 19:02 | |
| mriedem | so cells_api._call_to_cells is the call from the cells api (parent) to child, ok | 19:02 |
| mriedem | _call_to_cells(service) | 19:03 |
| dansmith | yeah | 19:03 |
| *** signed8bit_ZZZzz is now known as signed8bit | 19:03 | |
| dansmith | you probably need to dump the bdm before we call _call_to_cells in the parent, | 19:04 |
| dansmith | and again in compute_api in the child to make sure it's getting passed and that we're not dropping the uuid somewhere | 19:04 |
| dansmith | some of the cells paths have some unpacking and repacking I think | 19:04 |
| bauzas | correct, it's usually in the messaging module where we serialize/unserialize | 19:05 |
| dansmith | although I don't think that this one has any special cases, that I can see | 19:05 |
| bauzas | like where we put the cell path etc. | 19:05 |
| *** stevemar_ has joined #openstack-nova | 19:05 | |
| mriedem | yeah i don't see anything for attach_volume in the cells messaging code | 19:06 |
| *** peristeri has joined #openstack-nova | 19:06 | |
| dansmith | yeah, so some of them are straight up remoted | 19:07 |
| dansmith | others have an indirection layer in the message runner that have to reformulate the request so that it can continue at the child | 19:07 |
| *** electrocucaracha has joined #openstack-nova | 19:08 | |
| dansmith | like if we need to skip the compute_api piece for some operation | 19:08 |
| mriedem | we should at least get this merged so we can see what the bdm list contents are when we create them https://review.openstack.org/#/c/242617/ | 19:09 |
| *** e0ne has quit IRC | 19:10 | |
| *** yunpengli has joined #openstack-nova | 19:10 | |
| mriedem | right now we just log BlockDeviceMappingList(objects=[BlockDeviceMapping(UNKNOWN)]) | 19:10 |
| *** tdurakov has quit IRC | 19:10 | |
| *** e0ne has joined #openstack-nova | 19:10 | |
| dansmith | sdague: can you hit that ^ ? | 19:11 |
| *** electroc_ has quit IRC | 19:11 | |
| *** artom_ has quit IRC | 19:11 | |
| *** artom has joined #openstack-nova | 19:12 | |
| *** Sree has quit IRC | 19:13 | |
| mriedem | so in this failed attach test, we actually do get the volume attached and in-use in cinder: | 19:13 |
| mriedem | http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//console.html#_2015-11-09_18_17_55_584 | 19:13 |
| mriedem | the test fails b/c when we try to list attachments from the server in nova, we get 0 back and it expects 1 | 19:13 |
| mriedem | http://logs.openstack.org/98/242698/3/check/gate-tempest-dsvm-cells/45d0b58//console.html#_2015-11-09_18_17_55_586 | 19:13 |
| dansmith | yeah, because we attach at the child but the parent never knows we're attached I assume/ | 19:13 |
| *** moshele has joined #openstack-nova | 19:14 | |
| bauzas | so just wondering if boot from volume is supported by cells given that https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc#L73 | 19:14 |
| bauzas | mriedem: dansmith^ | 19:14 |
| dansmith | bauzas: I think it has to | 19:14 |
| dansmith | alaski: johnthetubaguy: belliott: ^ | 19:14 |
| mriedem | bauzas: i think we skipped that b/c of the ssh it does | 19:14 |
| mriedem | not b/c of BFV | 19:15 |
| *** su_zhang has joined #openstack-nova | 19:15 | |
| bauzas | nevermind I'm tired... | 19:15 |
| bauzas | do a git blame and enjoy the fun | 19:15 |
| mriedem | i don't exactly remmeber though, we'd need alaski to confirm (would also be nice if we put reminder comments in the rc file) | 19:16 |
| mriedem | git blame won't help, it was just a single big change | 19:16 |
| *** otter768 has joined #openstack-nova | 19:16 | |
| mriedem | there are lots of reasons we can skip scenario tests since they hit different things we might not support in a given job config | 19:16 |
| mriedem | bauzas: btw, that ebs test that is now passing in our series is a boot from volume test | 19:17 |
| bauzas | mriedem: nah I mean it's me who skipped the whole class | 19:17 |
| mriedem | boot from volume, create snapshot, create 2nd server from snapshot | 19:17 |
| mriedem | bauzas: yeah i know | 19:17 |
| *** moshele has quit IRC | 19:17 | |
| mriedem | but i think test_volume_boot_pattern (the test) was skipped for another reason | 19:17 |
| mriedem | oh i know why | 19:17 |
| mriedem | security groups | 19:17 |
| mriedem | which is why ccarmack1 is going down this path of glory https://review.openstack.org/#/c/225199/ | 19:18 |
| ccarmack1 | mriedem: huh? | 19:18 |
| mriedem | ignore | 19:18 |
| * mriedem goes to make coffee | 19:19 | |
| dansmith | bauzas: cover what? https://review.openstack.org/#/c/242603/8/nova/objects/block_device.py | 19:19 |
| *** pumaranikar has joined #openstack-nova | 19:19 | |
| *** ociuhandu has quit IRC | 19:19 | |
| bauzas | dansmith: sorry, I meant verifying that the primitive >1.16 doesn't include uuid | 19:20 |
| bauzas | oops <1.16 | 19:20 |
| dansmith | bauzas: oh, we don't do those for all things, because it's not technically necessary | 19:20 |
| dansmith | but I can if I respin | 19:20 |
| *** slDabbler has joined #openstack-nova | 19:20 | |
| dansmith | and we have a test that covers all possible backports to make sure the code actually runs | 19:20 |
| bauzas | dansmith: sure, that's not a real showstopper, but I thought it was something required when reviewing | 19:21 |
| *** otter768 has quit IRC | 19:21 | |
| bauzas | dansmith: because I don't see how we automatically verify that? | 19:21 |
| dansmith | we don't verify that it's actually removed automatically, no | 19:21 |
| dansmith | we verify that the code runs | 19:21 |
| dansmith | and we don't always require people to write tests for those, because the objects layer won't complain about things in the primitive that it doesn't know about | 19:22 |
| dansmith | so leaving it in isn't a problem, it's just cleanliness | 19:22 |
| bauzas | okay, I usually ship a bit of testing to verify the target primitive but your comment is understandable | 19:22 |
| dansmith | not saying we shouldn't require tests, I'm just saying we don't usually | 19:22 |
| bauzas | ack | 19:22 |
| bauzas | good to know btw. | 19:23 |
| dansmith | I should probably respin to address mriedem's concern of adding a get_by_uuid() in the same version anyway | 19:23 |
| *** signed8bit has quit IRC | 19:23 | |
| dansmith | mriedem: let me know when a good time to do that would be.. I think you're in the middle of stuff now | 19:23 |
| *** willsama has quit IRC | 19:23 | |
| mriedem | dansmith: do it now | 19:24 |
| dansmith | okay | 19:24 |
| *** eliqiao1 has joined #openstack-nova | 19:26 | |
| *** thumpba has joined #openstack-nova | 19:26 | |
| *** e0ne has quit IRC | 19:27 | |
| *** daemontool has joined #openstack-nova | 19:29 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Adds os-win dependency spec https://review.openstack.org/227827 | 19:29 |
| claudiub | mriedem: ^ done. | 19:30 |
| mriedem | ok | 19:30 |
| *** EinstCrazy has quit IRC | 19:31 | |
| *** EinstCrazy has joined #openstack-nova | 19:32 | |
| *** thumpba has quit IRC | 19:32 | |
| *** ihrachys has joined #openstack-nova | 19:35 | |
| *** tonytan4ever has joined #openstack-nova | 19:35 | |
| *** willsama has joined #openstack-nova | 19:36 | |
| *** willsama has quit IRC | 19:36 | |
| *** willsama has joined #openstack-nova | 19:37 | |
| *** packet has joined #openstack-nova | 19:37 | |
| *** packet has quit IRC | 19:37 | |
| mriedem | dansmith: i see the issue with attach... | 19:38 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4618 | 19:39 |
| mriedem | attach calls from the api to the compute manager to reserve names and create the bdm | 19:39 |
| mriedem | before my change, that create would go up top and cells would create there | 19:39 |
| mriedem | so i have to handle that somehow | 19:39 |
| dims | claudiub +1 | 19:40 |
| dansmith | mriedem: wonderful | 19:40 |
| *** Piet has quit IRC | 19:40 | |
| mriedem | well, i think it just means passing create=True from bdm.create to cells | 19:41 |
| mriedem | bdm.save always passes create=False | 19:41 |
| mriedem | and in the cells at top code, we check for the uuid | 19:42 |
| mriedem | to determind if we update or not | 19:42 |
| dansmith | or | 19:42 |
| dansmith | oh, I see | 19:42 |
| dansmith | hrm | 19:42 |
| mriedem | an alternative is overriding attach_volume in the cells API | 19:43 |
| dansmith | if check attach calls to the child,m | 19:43 |
| *** yunpengli has quit IRC | 19:43 | |
| dansmith | you could create in the cell with the result, although I guess you won't get back the uuid from that | 19:43 |
| *** tdurakov has joined #openstack-nova | 19:43 | |
| mriedem | the result of reserve_block_device_name would have the uuid in the bdm | 19:44 |
| *** angdraug has joined #openstack-nova | 19:44 | |
| dansmith | oh? then maybe do that? | 19:45 |
| mriedem | i guess the issue would be if we ever created a bdm in the parent with uuid 1 and then created basically the same bdm in the child with uuid 2, and the child passed that up to the parent, we'd look for uuid 2 in the cell db, not find it, and then create a duplicate | 19:45 |
| *** annegentle has quit IRC | 19:45 | |
| dansmith | it'd be nice if the only time we could change the cells communication to only ever update, never create | 19:45 |
| dansmith | not if we never allow creating from the bottom up | 19:46 |
| mriedem | if we didn't find the bdm in parent cell with uuid 2 we could check by device_name/volume_id.... | 19:46 |
| dansmith | not sure if there's ever a case where we'd need to do that | 19:46 |
| dansmith | but I wonder if some drivers create bdms for hypervisor-specific things or something | 19:46 |
| openstackgerrit | Dan Smith proposed openstack/nova: Revert "Exclude all BDM checks for cells" https://review.openstack.org/242698 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: cells: create block device mappings in API cell https://review.openstack.org/242649 | 19:47 |
| openstackgerrit | Dan Smith proposed openstack/nova: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | 19:47 |
| *** electrocucaracha has quit IRC | 19:47 | |
| mriedem | dansmith: i'd hope not... | 19:49 |
| dansmith | right, me either, but... | 19:49 |
| mriedem | i only see bdm create happening in these 2 places | 19:49 |
| mriedem | *today* | 19:50 |
| dansmith | yeah, well, if we're not today, then if that makes it cleaner I say do it | 19:50 |
| mriedem | ok i'll make that change and see what it buys us, i wouldn't be surprised if it just goes and breaks that ebs test again somehow :P | 19:51 |
| dansmith | heh | 19:51 |
| mriedem | you know, this cells v1 thing, it's kind of a problem... | 19:51 |
| dansmith | ... | 19:51 |
| mriedem | i | 19:51 |
| mriedem | i'm not sure if anyone has pointed that out before | 19:51 |
| dansmith | I know.. let's have another test job we have to debug! | 19:51 |
| mriedem | i got that passing on friday btw :) | 19:51 |
| dansmith | :| <-- this is my excited face | 19:52 |
| mriedem | reminds me of http://southparkstudios.mtvnimages.com/images/shows/south-park/clip-thumbnails/season-3/0305/south-park-s03e05c09-go-memphis-16x9.jpg? | 19:54 |
| *** Bent0_ has left #openstack-nova | 19:55 | |
| *** achanda has joined #openstack-nova | 19:56 | |
| *** pratikm__ has quit IRC | 19:58 | |
| *** baoli has quit IRC | 19:59 | |
| *** andrewbogott has quit IRC | 19:59 | |
| *** andrewbogott has joined #openstack-nova | 19:59 | |
| *** pm90_ has joined #openstack-nova | 19:59 | |
| *** rlrossit has joined #openstack-nova | 20:00 | |
| *** haomaiwa_ has quit IRC | 20:01 | |
| *** cfarquhar has quit IRC | 20:01 | |
| *** matrohon has joined #openstack-nova | 20:01 | |
| *** haomaiwang has joined #openstack-nova | 20:01 | |
| *** slDabbler has quit IRC | 20:02 | |
| *** terryyao has joined #openstack-nova | 20:03 | |
| *** terryyao_ has joined #openstack-nova | 20:03 | |
| *** cfarquhar has joined #openstack-nova | 20:07 | |
| *** cfarquhar has quit IRC | 20:07 | |
| *** cfarquhar has joined #openstack-nova | 20:07 | |
| *** slDabbler has joined #openstack-nova | 20:09 | |
| *** whenry has quit IRC | 20:12 | |
| *** annegentle has joined #openstack-nova | 20:13 | |
| *** pixelbeat has quit IRC | 20:16 | |
| *** electrocucaracha has joined #openstack-nova | 20:16 | |
| *** tdurakov has quit IRC | 20:19 | |
| openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Build timeouts task filters deleting instances https://review.openstack.org/240017 | 20:20 |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs: Add notification of shared resource usage. https://review.openstack.org/243297 | 20:22 |
| *** su_zhang has quit IRC | 20:22 | |
| sfinucan | mriedem: This patch is still failing on cells tests https://review.openstack.org/#/c/237762/ | 20:22 |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: objects: added 'os_secure_boot' property to ImageMetaProps object https://review.openstack.org/237593 | 20:23 |
| *** su_zhang has joined #openstack-nova | 20:23 | |
| sfinucan | It seems the patch I needed to wait for has been merged https://review.openstack.org/#/c/241258/ | 20:23 |
| sfinucan | Any suggestions on how to conquer the mighty gate? :) | 20:23 |
| edleafe | jaypipes: johnthetubaguy: bauzas: the alternate approach I mentioned in the meeting: https://review.openstack.org/240017 | 20:23 |
| bauzas | not sure I have the right review? | 20:24 |
| bauzas | edleafe: ^ | 20:24 |
| *** jichen has quit IRC | 20:24 | |
| mriedem | sfinucan: that's a different failure from the global failure thing everyone was hittting last week http://logs.openstack.org/62/237762/8/check/gate-tempest-dsvm-cells/5fd0f48/console.html#_2015-11-09_16_47_03_263 | 20:24 |
| dansmith | sfinucan: I don't think you're hitting the skipped thing | 20:24 |
| sfinucan | dansmith: mriedem: damn... | 20:25 |
| mriedem | sfinucan: yo'ure hitting http://status.openstack.org/elastic-recheck/index.html#1466696 | 20:25 |
| mriedem | just recheck on that bug | 20:25 |
| edleafe | bauzas: doh! | 20:25 |
| mriedem | jaypipes: now he's hiding half eaten chews around my office like it's easter sunday | 20:25 |
| edleafe | bauzas: jaypipes: johnthetubaguy: https://review.openstack.org/243297 | 20:25 |
| sfinucan | mriedem: recheck that bug? just 'recheck' right? | 20:25 |
| dansmith | sfinucan: recheck bug xxxxx | 20:25 |
| mriedem | sfinucan: yeah | 20:25 |
| sfinucan | or is there some specific syntax for bugs | 20:26 |
| sfinucan | ah | 20:26 |
| mriedem | either works | 20:26 |
| dansmith | for the records | 20:26 |
| sfinucan | I didn't know that | 20:26 |
| mriedem | dan keeps track | 20:26 |
| mriedem | like santa | 20:26 |
| dansmith | eff yeah I do | 20:26 |
| edleafe | jolly old saint dan | 20:26 |
| *** thumpba has joined #openstack-nova | 20:28 | |
| dansmith | jaypipes: alaski: can one of you +W this debug patch please? https://review.openstack.org/#/c/242617/ | 20:28 |
| *** thumpba has quit IRC | 20:28 | |
| jaypipes | dansmith: done | 20:29 |
| *** thumpba has joined #openstack-nova | 20:29 | |
| *** su_zhang has quit IRC | 20:30 | |
| dansmith | jaypipes: thanks | 20:31 |
| *** su_zhang has joined #openstack-nova | 20:32 | |
| *** thumpba has quit IRC | 20:33 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs: Add notification of shared resource usage. https://review.openstack.org/243297 | 20:34 |
| *** Marga_ has quit IRC | 20:35 | |
| diana_clarke | anteaya: I just finished the first video you suggested in the "Learning to Debug the Gate" thread, and I'm about to start the next one. Thanks for bringing them to my attention! | 20:36 |
| anteaya | diana_clarke: pleasure | 20:37 |
| anteaya | diana_clarke: I was looking around for you but you aren't at the sprint | 20:37 |
| *** tdurakov has joined #openstack-nova | 20:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Revert "Exclude all BDM checks for cells" https://review.openstack.org/242698 | 20:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: cells: create block device mappings in API cell https://review.openstack.org/242649 | 20:38 |
| diana_clarke | anteaya: No, I wasn't feeling up for the commute today. And I had a meeting at work, plus a PSF board meeting, so I would have been pretty preoccupied. | 20:38 |
| diana_clarke | anteaya: Was a pleasure to meet you! Sorry I didn't get to hang out more today. Next time :) | 20:39 |
| mriedem | dansmith: https://review.openstack.org/#/c/242649/ is updated - i think i've got the bases covered now | 20:39 |
| dansmith | mriedem: okay cool | 20:39 |
| anteaya | diana_clarke: no worried, sound like you made the right call | 20:39 |
| anteaya | s/no worried/no worries | 20:39 |
| *** rdopiera has quit IRC | 20:40 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: add first reno-based release note https://review.openstack.org/242008 | 20:41 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add reno for release notes management https://review.openstack.org/242007 | 20:41 |
| *** stackdump has quit IRC | 20:42 | |
| edleafe | mriedem: what's the deal with the new import line in nova/cells/messaging.py? | 20:44 |
| edleafe | mr in https://review.openstack.org/#/c/242649/8/nova/cells/messaging.py,cm | 20:44 |
| edleafe | mriedem: ^^ | 20:44 |
| mriedem | ha, wow | 20:44 |
| mriedem | tab complete | 20:45 |
| mriedem | fixing | 20:45 |
| edleafe | mriedem: figured it was fat-fingered or something | 20:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Revert "Exclude all BDM checks for cells" https://review.openstack.org/242698 | 20:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: cells: create block device mappings in API cell https://review.openstack.org/242649 | 20:50 |
| *** jichen has joined #openstack-nova | 20:50 | |
| *** achanda has quit IRC | 20:50 | |
| *** su_zhang has quit IRC | 20:54 | |
| *** nikhil_k has quit IRC | 20:54 | |
| *** alex_klimov has joined #openstack-nova | 20:56 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** haomaiwang has joined #openstack-nova | 21:01 | |
| *** tdurakov has quit IRC | 21:02 | |
| *** terryyao_ has quit IRC | 21:05 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: add release notes page for current master https://review.openstack.org/242008 | 21:06 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add reno for release notes management https://review.openstack.org/242007 | 21:06 |
| *** Piet has joined #openstack-nova | 21:08 | |
| *** jichen has quit IRC | 21:08 | |
| *** stackdump has joined #openstack-nova | 21:11 | |
| *** electroc_ has joined #openstack-nova | 21:11 | |
| *** terryyao has quit IRC | 21:12 | |
| *** thumpba has joined #openstack-nova | 21:12 | |
| *** electroc_ has quit IRC | 21:12 | |
| *** electrocucaracha has quit IRC | 21:13 | |
| mriedem | mrodden: you were asking about instance.cleaned the other day https://review.openstack.org/#/c/36596/ | 21:16 |
| bauzas | dhellmann: I just made a respin for the reno patch series re: Nova, would be awesome if you could take time to review those and leave a comment | 21:16 |
| bauzas | dhellmann: https://review.openstack.org/#/q/status:open+project:openstack/nova+topic:add-reno,n,z | 21:16 |
| *** subscope has joined #openstack-nova | 21:16 | |
| openstackgerrit | Erickson Filipe Guedes dos Santos proposed openstack/nova: Nested Quota Driver https://review.openstack.org/242626 | 21:17 |
| *** otter768 has joined #openstack-nova | 21:17 | |
| mriedem | tonyb: backporting https://review.openstack.org/#/c/219301/ to grizzly would be terrible, just fyi | 21:17 |
| mriedem | tonyb: requires nova objects, a new api and a db migration | 21:17 |
| mriedem | the unholy trifecta for backports | 21:18 |
| dansmith | mriedem: new rpc you mean, I asssume | 21:18 |
| dansmith | mriedem: who was suggesting backporting it that far? | 21:18 |
| dansmith | that person is probably really fun at parties | 21:18 |
| *** electrocucaracha has joined #openstack-nova | 21:19 | |
| mriedem | internal | 21:20 |
| mriedem | guy was asking me to see if he really needed to backport that through to grizzly, | 21:20 |
| mriedem | so i looked and it's like all of the worst possible things you'd have ot backport | 21:20 |
| mriedem | dansmith: the migration filter db api was added in a compute API change | 21:21 |
| mriedem | we could just fork the db/conductor api stuff yeah | 21:21 |
| mriedem | but a db migration too for the cleaned flag to be used in delete_instance_files | 21:21 |
| mriedem | it's just all the worst | 21:21 |
| *** electroc_ has joined #openstack-nova | 21:21 | |
| *** stackdump has quit IRC | 21:21 | |
| *** vladikr has quit IRC | 21:21 | |
| cburgess | Would be easier to re-write rather then backport. | 21:21 |
| dansmith | yeah, thought you meant REST, but yeah | 21:21 |
| *** electroc_ has quit IRC | 21:21 | |
| *** otter768 has quit IRC | 21:21 | |
| mriedem | all i can say is, i'm glad it's not assigned to me | 21:22 |
| *** smatzek has quit IRC | 21:22 | |
| *** stackdump has joined #openstack-nova | 21:22 | |
| *** jhesketh has quit IRC | 21:23 | |
| *** IanGovett has quit IRC | 21:24 | |
| *** electroc_ has joined #openstack-nova | 21:24 | |
| *** electrocucaracha has quit IRC | 21:25 | |
| *** jhesketh has joined #openstack-nova | 21:25 | |
| openstackgerrit | Arun Kant proposed openstack/nova: Fix for barbican endpoint discovery with service catalog case https://review.openstack.org/243322 | 21:28 |
| *** diegows has joined #openstack-nova | 21:29 | |
| *** thumpba has quit IRC | 21:29 | |
| *** su_zhang has joined #openstack-nova | 21:31 | |
| *** thumpba has joined #openstack-nova | 21:33 | |
| mriedem | dansmith: replies inline https://review.openstack.org/#/c/242649/ | 21:33 |
| *** thumpba has quit IRC | 21:34 | |
| *** rwmjones has quit IRC | 21:36 | |
| *** thumpba has joined #openstack-nova | 21:36 | |
| *** gjayavelu has joined #openstack-nova | 21:38 | |
| *** thumpba has quit IRC | 21:38 | |
| *** thumpba has joined #openstack-nova | 21:39 | |
| *** achanda has joined #openstack-nova | 21:40 | |
| *** achanda has quit IRC | 21:41 | |
| *** mwagner has quit IRC | 21:42 | |
| *** thumpba has quit IRC | 21:42 | |
| *** lpetrut has quit IRC | 21:42 | |
| sdague | mriedem: as you are skipping more things for cells, test_lock_unlock_server should probably be added to the list | 21:43 |
| sdague | I did some diving on one of my patches that it killed | 21:43 |
| sdague | cells just can't support that in a reliable way because of the db replay delay | 21:44 |
| mriedem | sdague: it doesn't fail enough that i've thought it's a major problem | 21:44 |
| sdague | mriedem: well, it killed me recently | 21:44 |
| mriedem | http://status.openstack.org/elastic-recheck/index.html#1466696 | 21:44 |
| mriedem | yeah, 38 hits in 10 days | 21:44 |
| mriedem | it's not 0 | 21:44 |
| dansmith | it has killed me several times in the last 24 hours | 21:45 |
| mriedem | i saw you talking about it in -qa, something about the microversion required to make it deterministic is a problem | 21:45 |
| dansmith | I was surprised the e-r graph was so low | 21:45 |
| sdague | mriedem: actually, it's not even that | 21:45 |
| mriedem | it does seem to be hitting more often, i don't know why | 21:45 |
| sdague | that won't matter | 21:45 |
| dansmith | it's not worth fixing for cellsv1 I think because cellsv2 should be the same as non-cells is today | 21:45 |
| sdague | right | 21:46 |
| sdague | the issue is the API layer says "looks good" | 21:46 |
| sdague | and the call progresses | 21:46 |
| sdague | the compute checks against a different db | 21:46 |
| sdague | which hasn't taken the update | 21:46 |
| sdague | it's a fundamental cells flaw | 21:46 |
| mriedem | alright, feel free to push a nova change to skip the test in the rc file | 21:47 |
| mriedem | add the bug in the rc file above the skip as a comment | 21:47 |
| sdague | is the bug supposed to be before or after the skip line? | 21:48 |
| *** jaypipes has quit IRC | 21:49 | |
| mriedem | before | 21:50 |
| mriedem | like https://review.openstack.org/#/c/241258/2/devstack/tempest-dsvm-cells-rc | 21:50 |
| *** salv-orlando has joined #openstack-nova | 21:51 | |
| *** devl_ has joined #openstack-nova | 21:51 | |
| sdague | so, a lot of this regex looks kind of drunk | 21:51 |
| dansmith | o.O | 21:51 |
| sdague | like why do so many things end in * | 21:52 |
| *** rwmjones has joined #openstack-nova | 21:52 | |
| sdague | because this isn't glob | 21:53 |
| sdague | ?:tempest\.scenario\.test_snapshot_pattern\.TestSnapshotPattern\.test_snapshot_pattern* | 21:53 |
| *** nic has quit IRC | 21:53 | |
| sdague | means that matches tempest\.scenario\.test_snapshot_pattern\.TestSnapshotPattern\.test_snapshot_pattern | 21:53 |
| sdague | and tempest\.scenario\.test_snapshot_pattern\.TestSnapshotPattern\.test_snapshot_patter | 21:53 |
| sdague | which, probably isn't hurting anything, but definitely drunk | 21:53 |
| sdague | and will likely lead to confusion later | 21:54 |
| mriedem | well, alaski was on about a 5th of whiskey per day when he got that cells job passing... | 21:54 |
| mriedem | feel free to clean it up | 21:54 |
| sdague | :) | 21:54 |
| sdague | also, double \\ on the rebuild thing, I'm not sure if that means it will get skipped correctly or not | 21:55 |
| mriedem | i see test_rebuild_server_with_manual_disk_config getting skipped | 21:55 |
| *** mrkz has quit IRC | 21:55 | |
| *** pm90_ has quit IRC | 21:56 | |
| *** gjayavelu has quit IRC | 21:56 | |
| sdague | test_rebuild_server_in_stop_state ? | 21:56 |
| sdague | that's the one with the double slash | 21:56 |
| *** mrkz has joined #openstack-nova | 21:56 | |
| mriedem | it's skipped | 21:56 |
| mriedem | dansmith: so new results: http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43//console.html | 21:56 |
| mriedem | dansmith: good news is volume attach works again, | 21:56 |
| mriedem | dansmith: bad news is that ebs test fails again | 21:56 |
| mriedem | i called it | 21:57 |
| *** matrohon has quit IRC | 21:58 | |
| rlrossit | yo dansmith: because we use manifested backports, can ImageMetaProps get ahead of ImageMeta in versions if something in there changes? (meaning can https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L137 become 1.8, and leave ImageMeta at 1.7?) | 21:58 |
| *** kfarr has joined #openstack-nova | 21:58 | |
| openstackgerrit | Sean Dague proposed openstack/nova: skip lock_unlock_server test for cells https://review.openstack.org/243327 | 21:58 |
| sdague | mriedem: there you go | 21:58 |
| *** nic has joined #openstack-nova | 21:59 | |
| *** baoli has joined #openstack-nova | 22:00 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-nova | 22:01 | |
| *** gjayavelu has joined #openstack-nova | 22:02 | |
| *** thorst has quit IRC | 22:03 | |
| *** thangp has quit IRC | 22:03 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs: Add notification of shared resource usage. https://review.openstack.org/243297 | 22:04 |
| *** salv-orlando has quit IRC | 22:05 | |
| *** gjayavelu has quit IRC | 22:06 | |
| dansmith | mriedem: heh | 22:07 |
| dansmith | rlrossit: we can untie their versions if we want now yeah | 22:08 |
| mriedem | sdague: i'm picking up what you're putting down | 22:09 |
| mriedem | if you can dig that | 22:09 |
| dansmith | heh | 22:09 |
| rlrossit | dansmith: is there anything in o.vo or nova that made mention to using obj_relationships? I figured there was something in the nova docs that was outdated that I should update to not use it anymore | 22:10 |
| rlrossit | I might just add something to the comments around obj_relationships in the base object in o.vo to say don't use it if you're using manifest backports | 22:11 |
| *** tjones has quit IRC | 22:11 | |
| *** gjayavelu has joined #openstack-nova | 22:11 | |
| *** achanda has joined #openstack-nova | 22:12 | |
| *** peristeri has quit IRC | 22:12 | |
| *** angdraug has quit IRC | 22:12 | |
| *** tjones has joined #openstack-nova | 22:14 | |
| *** gjayavelu has quit IRC | 22:16 | |
| *** dustins has quit IRC | 22:16 | |
| dansmith | rlrossit: not really, tmk, it was mostly that the tests enforced you to do it or at least ask about it | 22:18 |
| dansmith | you know, when they worked | 22:18 |
| rlrossit | I'm just wondering why https://review.openstack.org/#/c/237593/6 added them | 22:19 |
| rlrossit | oh wait... when was your removal of obj_relationships merged? | 22:19 |
| dansmith | rlrossit: right, they jsut rebased their patch on the removal and added them back | 22:20 |
| rlrossit | ok so it's a rebase relic... never mind on this doc stuff then. I thought we had it somewhere that they took it from | 22:20 |
| rlrossit | thanks dansmith | 22:20 |
| dansmith | yeah, good thought though | 22:21 |
| *** gjayavelu has joined #openstack-nova | 22:21 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova: Improve 'pci_passthrough_whitelist' documentation https://review.openstack.org/243335 | 22:24 |
| *** devl_ has quit IRC | 22:25 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: objects: added 'os_secure_boot' property to ImageMetaProps object https://review.openstack.org/237593 | 22:26 |
| *** nikhil has joined #openstack-nova | 22:27 | |
| *** rfolco has quit IRC | 22:30 | |
| *** thorst has joined #openstack-nova | 22:30 | |
| openstackgerrit | Simona Iuliana Toader proposed openstack/nova: objects: added 'os_secure_boot' property to ImageMetaProps object https://review.openstack.org/237593 | 22:33 |
| mriedem | dansmith: here is where we call from bdm.create() to the parent cell http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-cell-child.txt.gz#_2015-11-09_21_41_17_613 | 22:34 |
| *** dims_ has joined #openstack-nova | 22:34 | |
| *** thorst has quit IRC | 22:34 | |
| *** angdraug has joined #openstack-nova | 22:35 | |
| *** dims has quit IRC | 22:35 | |
| mriedem | dansmith: this is where the parent cell processes it and inserts to the db http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-cell-region.txt.gz#_2015-11-09_21_41_17_647 | 22:35 |
| dansmith | hmm | 22:36 |
| dansmith | looks right, right? | 22:36 |
| mriedem | yeah | 22:36 |
| mriedem | uuid is the same | 22:36 |
| dansmith | whisky tango foxtrot? | 22:36 |
| mriedem | we do an update later http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-cell-region.txt.gz#_2015-11-09_21_41_18_174 | 22:37 |
| *** jamielennox|away is now known as jamielennox | 22:38 | |
| mriedem | the update https://www.diffchecker.com/i4ki1kcx | 22:38 |
| mriedem | looks normal | 22:38 |
| dansmith | wait, so I don't see the error you were hitting before | 22:38 |
| dansmith | I guess you fixed that, but now the test is failing and you see no errors? | 22:39 |
| mriedem | the attach error was fixed | 22:39 |
| mriedem | but now we're back to the invalid boot sequence failure | 22:39 |
| mriedem | cell-region all looks normal | 22:39 |
| mriedem | i also need this https://review.openstack.org/#/c/241739/ | 22:40 |
| dansmith | yeah | 22:40 |
| dansmith | I can +W trivial patches all day | 22:40 |
| dansmith | keep 'em coming | 22:40 |
| *** devl_ has joined #openstack-nova | 22:42 | |
| mriedem | this is where we get the image snapshot metadata http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/console.html#_2015-11-09_21_49_21_425 | 22:42 |
| mriedem | you can see the 2 bdms in there | 22:42 |
| *** harlowja_ has quit IRC | 22:43 | |
| *** pm90_ has joined #openstack-nova | 22:43 | |
| mriedem | we don't persist the bdm uuid in the image metadata | 22:43 |
| dansmith | you mean in what we spit out of the api? | 22:44 |
| *** pm90__ has joined #openstack-nova | 22:46 | |
| *** baoli has quit IRC | 22:47 | |
| mriedem | in what we pass to glance when creating the image snapshot i think | 22:47 |
| mriedem | looking | 22:47 |
| mriedem | mapping_dict = mapping_dict.get_image_mapping() | 22:47 |
| mriedem | whatever that does, the bdm dict code probably needs a change to add uuid to that mapping | 22:48 |
| dansmith | oh sure | 22:48 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/block_device.py#L294 | 22:48 |
| mriedem | which probably belongs in your first change | 22:48 |
| dansmith | why do you want the image to maintain the uuid? | 22:49 |
| *** pm90_ has quit IRC | 22:49 | |
| *** stevemar_ has quit IRC | 22:49 | |
| *** baoli has joined #openstack-nova | 22:49 | |
| *** baoli has quit IRC | 22:49 | |
| *** baoli has joined #openstack-nova | 22:50 | |
| mriedem | good questionb | 22:50 |
| mriedem | so we get 2 bdms for the same instance uuid https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2335 | 22:51 |
| mriedem | so we have to still be double creating somewhere | 22:51 |
| mriedem | wtf | 22:51 |
| *** pm90__ has quit IRC | 22:52 | |
| mriedem | anyway, that logging patch will hopefully help | 22:53 |
| *** eharney has quit IRC | 22:53 | |
| *** alex_klimov has quit IRC | 22:53 | |
| *** pm90_ has joined #openstack-nova | 22:53 | |
| *** sahid has quit IRC | 22:54 | |
| *** tonytan4ever has quit IRC | 22:55 | |
| dansmith | okay | 22:55 |
| *** tonytan4ever has joined #openstack-nova | 22:56 | |
| *** electroc_ has quit IRC | 22:56 | |
| *** burgerk has quit IRC | 22:57 | |
| *** ijw has quit IRC | 22:57 | |
| *** tonytan4ever has quit IRC | 22:57 | |
| *** electrocucaracha has joined #openstack-nova | 22:58 | |
| *** mwagner has joined #openstack-nova | 22:58 | |
| *** jerrygb has quit IRC | 22:59 | |
| *** Marga_ has joined #openstack-nova | 23:00 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** ihrachys has quit IRC | 23:01 | |
| *** Marga_ has quit IRC | 23:01 | |
| *** Marga_ has joined #openstack-nova | 23:01 | |
| *** haomaiwang has joined #openstack-nova | 23:01 | |
| *** jerrygb has joined #openstack-nova | 23:02 | |
| *** krtaylor has quit IRC | 23:02 | |
| *** mdrabe has quit IRC | 23:03 | |
| *** edtubill has quit IRC | 23:03 | |
| *** burt has quit IRC | 23:03 | |
| *** tanee2 has joined #openstack-nova | 23:03 | |
| *** rlrossit has left #openstack-nova | 23:04 | |
| *** aysyd has quit IRC | 23:04 | |
| *** achanda has quit IRC | 23:05 | |
| *** tanee has quit IRC | 23:06 | |
| mriedem | dansmith: so i think we're literally just inserting the same bdm twice for the same instance, | 23:07 |
| mriedem | this is in the child cell http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-cell-child.txt.gz#_2015-11-09_21_41_17_606 | 23:07 |
| mriedem | via bdm.create() | 23:07 |
| dansmith | on the child cell you mean? | 23:07 |
| mriedem | this is in the cells service: | 23:07 |
| mriedem | http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-cell-region.txt.gz#_2015-11-09_21_41_17_647 | 23:07 |
| *** pixelbeat has joined #openstack-nova | 23:08 | |
| *** markmcclain has quit IRC | 23:09 | |
| mriedem | this is n-api where it creates the bdm http://logs.openstack.org/98/242698/6/check/gate-tempest-dsvm-cells/cae4a43/logs/screen-n-api.txt.gz#_2015-11-09_21_41_17_321 | 23:09 |
| openstackgerrit | Arun Kant proposed openstack/nova: Fix for barbican endpoint discovery with service catalog case https://review.openstack.org/243322 | 23:10 |
| *** markmcclain has joined #openstack-nova | 23:10 | |
| *** pm90_ has quit IRC | 23:14 | |
| *** krtaylor has joined #openstack-nova | 23:14 | |
| *** pm90_ has joined #openstack-nova | 23:16 | |
| *** ZZelle_ has quit IRC | 23:17 | |
| *** otter768 has joined #openstack-nova | 23:18 | |
| *** tanee has joined #openstack-nova | 23:19 | |
| *** tanee2 has quit IRC | 23:22 | |
| *** otter768 has quit IRC | 23:22 | |
| mriedem | dansmith: self._from_db_object(context, self, db_bdm) will update the field values on self (the bdm) right? | 23:24 |
| dansmith | yeah | 23:24 |
| mriedem | yeah nvm | 23:25 |
| mriedem | well fudge, idk | 23:25 |
| *** tanee has quit IRC | 23:25 | |
| *** willsama has quit IRC | 23:26 | |
| *** electrocucaracha has quit IRC | 23:26 | |
| *** tanee has joined #openstack-nova | 23:26 | |
| *** subscope has quit IRC | 23:26 | |
| *** electrocucaracha has joined #openstack-nova | 23:28 | |
| *** pm90_ has quit IRC | 23:28 | |
| *** gjayavelu has quit IRC | 23:29 | |
| *** su_zhang has quit IRC | 23:29 | |
| *** su_zhang has joined #openstack-nova | 23:30 | |
| *** tjones1 has joined #openstack-nova | 23:31 | |
| *** tjones has quit IRC | 23:32 | |
| *** mrkz has quit IRC | 23:35 | |
| *** achanda has joined #openstack-nova | 23:37 | |
| *** achanda has quit IRC | 23:38 | |
| *** diegows has quit IRC | 23:40 | |
| *** ijuwang has quit IRC | 23:45 | |
| *** otter768 has joined #openstack-nova | 23:45 | |
| *** claudiub has quit IRC | 23:45 | |
| *** stackdump has quit IRC | 23:46 | |
| *** smurke has quit IRC | 23:47 | |
| *** pumaranikar has quit IRC | 23:47 | |
| *** rfolco has joined #openstack-nova | 23:48 | |
| *** sfinucan has quit IRC | 23:50 | |
| *** ctrath has quit IRC | 23:51 | |
| *** rfolco has quit IRC | 23:52 | |
| *** mriedem is now known as mriedem_away | 23:54 | |
| *** otter768 has quit IRC | 23:57 | |
| *** boris-42 has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
