Wednesday, 2015-11-04

*** heyongli has quit IRC00:00
*** heyongli has joined #openstack-nova00:01
*** Savemech has quit IRC00:01
*** zhangjn has joined #openstack-nova00:02
*** Savemech has joined #openstack-nova00:02
*** ctrath has quit IRC00:04
*** sfinucan has quit IRC00:04
*** cfarquhar has quit IRC00:05
*** cfarquhar has joined #openstack-nova00:06
*** cfarquhar has quit IRC00:06
*** cfarquhar has joined #openstack-nova00:06
*** Kennan has joined #openstack-nova00:07
spandheHi folks, can I get one more +2 on https://review.openstack.org/#/c/240347/ ?00:07
*** heyongli has quit IRC00:10
*** heyongli has joined #openstack-nova00:11
*** zhangjn has quit IRC00:11
*** markvoelker has quit IRC00:11
*** josecastroleon has quit IRC00:15
*** pixelb has joined #openstack-nova00:16
*** pratikma_ has quit IRC00:17
*** stackdump has joined #openstack-nova00:18
*** rfolco has joined #openstack-nova00:18
*** slagle has quit IRC00:19
*** Jeffrey4l has joined #openstack-nova00:20
*** heyongli has quit IRC00:20
*** heyongli has joined #openstack-nova00:21
spandheCan someone from Nova team please review this change to Ironic virt driver? https://review.openstack.org/#/c/240357/00:26
*** vishwanathj has joined #openstack-nova00:27
*** dims has joined #openstack-nova00:28
*** browne has quit IRC00:29
*** sneti has joined #openstack-nova00:29
*** heyongli has quit IRC00:31
*** heyongli has joined #openstack-nova00:31
*** IanGovett has quit IRC00:32
*** edmondsw has quit IRC00:32
*** IanGovett has joined #openstack-nova00:33
*** ndipanov has joined #openstack-nova00:37
*** heyongli has quit IRC00:41
*** diogogmt has quit IRC00:42
*** heyongli has joined #openstack-nova00:42
*** jerrygb has joined #openstack-nova00:44
*** IanGovett has quit IRC00:46
*** bapalm has quit IRC00:46
*** slagle has joined #openstack-nova00:47
*** salv-orlando has joined #openstack-nova00:48
*** bapalm has joined #openstack-nova00:48
*** jerrygb has quit IRC00:48
*** heyongli has quit IRC00:51
*** heyongli has joined #openstack-nova00:52
*** slagle has quit IRC00:52
*** slagle has joined #openstack-nova00:54
*** zhangjn has joined #openstack-nova00:58
*** zhenguo has joined #openstack-nova01:00
*** heyongli has quit IRC01:01
*** ssurana has quit IRC01:02
*** achanda has quit IRC01:02
*** heyongli has joined #openstack-nova01:03
*** mrkz has quit IRC01:03
*** ndipanov has quit IRC01:07
*** salv-orlando has quit IRC01:07
*** RA_ has quit IRC01:07
*** RA_ has joined #openstack-nova01:09
*** heyongli has quit IRC01:12
*** markvoelker has joined #openstack-nova01:12
*** heyongli has joined #openstack-nova01:13
*** stackdump has quit IRC01:13
*** electrocucaracha has quit IRC01:15
*** RuiChen has joined #openstack-nova01:15
*** markvoelker has quit IRC01:17
*** thorst has joined #openstack-nova01:22
*** heyongli has quit IRC01:22
*** heyongli has joined #openstack-nova01:23
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742701:24
*** hemna is now known as hemnafk01:24
*** angdraug has quit IRC01:25
*** signed8bit has quit IRC01:28
*** gyee has quit IRC01:28
*** tjones has joined #openstack-nova01:30
tjones@melwitt - thanks for your comments on https://review.openstack.org/#/c/127427.  i'll address them soon01:31
*** heyongli has quit IRC01:32
*** heyongli has joined #openstack-nova01:33
*** su_zhang has quit IRC01:37
*** Jeffrey4l has quit IRC01:41
*** chenzeng has joined #openstack-nova01:41
*** Jeffrey4l has joined #openstack-nova01:41
*** armax has joined #openstack-nova01:42
*** heyongli has quit IRC01:42
*** jwcroppe has quit IRC01:43
*** heyongli has joined #openstack-nova01:44
*** pixelbeat_ has joined #openstack-nova01:45
*** pixelb has quit IRC01:46
openstackgerritlvdongbing proposed openstack/nova: Add oslo_config PortOpt support  https://review.openstack.org/23956901:48
openstackgerritGiridhar Jayavelu proposed openstack/nova-specs: VMware: placement policies within cluster  https://review.openstack.org/23780501:48
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: add flavor extra_spec for DRS vm group  https://review.openstack.org/24143601:50
*** smatzek has joined #openstack-nova01:51
*** ssurana has joined #openstack-nova01:52
*** heyongli has quit IRC01:53
*** heyongli has joined #openstack-nova01:54
*** jerrygb has joined #openstack-nova02:00
*** browne has joined #openstack-nova02:01
*** tjones has quit IRC02:02
*** heyongli has quit IRC02:03
*** oomichi has joined #openstack-nova02:03
*** oomichi has quit IRC02:03
*** heyongli has joined #openstack-nova02:04
*** rex_lee_ has joined #openstack-nova02:06
*** electrocucaracha has joined #openstack-nova02:09
*** dims has quit IRC02:13
*** heyongli has quit IRC02:13
*** heyongli has joined #openstack-nova02:14
*** ndipanov has joined #openstack-nova02:14
*** salv-orlando has joined #openstack-nova02:16
*** pratikmallya has joined #openstack-nova02:17
*** huanxie has quit IRC02:18
*** klkumar has joined #openstack-nova02:19
*** gonzalo2kx has joined #openstack-nova02:19
*** heyongli has quit IRC02:23
*** heyongli has joined #openstack-nova02:25
*** xyang1 has quit IRC02:28
*** ndipanov has quit IRC02:29
*** thorst has quit IRC02:31
*** heyongli has quit IRC02:34
*** heyongli has joined #openstack-nova02:35
*** seanw1 has quit IRC02:35
*** seanw1 has joined #openstack-nova02:35
*** salv-orlando has quit IRC02:36
*** unicell has quit IRC02:37
*** flyingtt has quit IRC02:38
*** inteq has joined #openstack-nova02:43
*** markvoelker has joined #openstack-nova02:43
*** heyongli has quit IRC02:44
*** thorst has joined #openstack-nova02:45
*** heyongli has joined #openstack-nova02:45
*** ccarmack has joined #openstack-nova02:48
*** markvoelker has quit IRC02:48
*** thorst has quit IRC02:49
*** dvlwrk_ has joined #openstack-nova02:49
*** thorst has joined #openstack-nova02:49
*** sneti has quit IRC02:52
*** thorst has quit IRC02:54
*** heyongli has quit IRC02:54
*** haomaiwang has joined #openstack-nova02:54
*** heyongli has joined #openstack-nova02:55
*** vilobhmm111 has quit IRC02:55
*** chenzeng has quit IRC02:59
*** dave-mccowan has joined #openstack-nova03:00
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-nova03:01
*** smatzek has quit IRC03:02
*** hemna has joined #openstack-nova03:03
*** chenzeng has joined #openstack-nova03:04
*** heyongli has quit IRC03:04
*** hwoarang has quit IRC03:05
*** heyongli has joined #openstack-nova03:06
*** hwoarang has joined #openstack-nova03:06
*** hwoarang has quit IRC03:06
*** hwoarang has joined #openstack-nova03:06
*** haomaiwang has quit IRC03:08
*** haomaiwang has joined #openstack-nova03:09
*** unicell has joined #openstack-nova03:11
*** jdurgin has quit IRC03:12
*** tpeoples has joined #openstack-nova03:13
*** heyongli has quit IRC03:15
*** heyongli has joined #openstack-nova03:16
*** sileht has joined #openstack-nova03:19
*** jmccrory has quit IRC03:23
*** hemna has quit IRC03:23
*** heyongli has quit IRC03:25
*** heyongli has joined #openstack-nova03:26
*** haomaiwang has quit IRC03:30
*** dims has joined #openstack-nova03:33
*** otter768 has joined #openstack-nova03:34
*** RuiChen has quit IRC03:34
*** _RuiChen has joined #openstack-nova03:34
*** heyongli has quit IRC03:35
*** spandhe has quit IRC03:36
*** heyongli has joined #openstack-nova03:36
*** jamielennox is now known as jamielennox|away03:38
*** vilobhmm11 has joined #openstack-nova03:38
*** rfolco has quit IRC03:39
*** jamielennox|away is now known as jamielennox03:40
*** salv-orlando has joined #openstack-nova03:43
*** achanda has joined #openstack-nova03:44
*** heyongli has quit IRC03:45
*** heyongli has joined #openstack-nova03:46
*** pratikmallya has quit IRC03:51
openstackgerritChaoyi Huang proposed openstack/nova-specs: Expose quiece unquiece API  https://review.openstack.org/23788103:54
*** vilobhmm11 has quit IRC03:54
*** heyongli has quit IRC03:56
*** heyongli has joined #openstack-nova03:57
*** Jeffrey4l has quit IRC03:57
*** su_zhang has joined #openstack-nova03:58
*** dims has quit IRC04:03
*** salv-orlando has quit IRC04:03
*** ssurana1 has joined #openstack-nova04:04
*** achanda has quit IRC04:04
*** ssurana has quit IRC04:06
*** mgoddard_ has joined #openstack-nova04:06
*** heyongli has quit IRC04:06
*** vishwana_ has joined #openstack-nova04:07
*** heyongli has joined #openstack-nova04:07
*** sballe_ has joined #openstack-nova04:07
*** paul-carlton1 has joined #openstack-nova04:09
*** bapalm_ has joined #openstack-nova04:10
*** Jeffrey4l has joined #openstack-nova04:10
*** kragniz_ has joined #openstack-nova04:10
*** gus_ has joined #openstack-nova04:10
*** hamzy_ has joined #openstack-nova04:11
*** mgoddard has quit IRC04:11
*** RA_ has quit IRC04:11
*** ameade has quit IRC04:11
*** paul-carlton has quit IRC04:11
*** browne has quit IRC04:11
*** adam_g has quit IRC04:11
*** sballe has quit IRC04:11
*** bapalm has quit IRC04:11
*** vishwanathj has quit IRC04:11
*** jhesketh has quit IRC04:11
*** anthonyper has quit IRC04:11
*** rook has quit IRC04:11
*** gus has quit IRC04:11
*** wverdugo500 has quit IRC04:11
*** hamzy has quit IRC04:11
*** kragniz has quit IRC04:11
*** jwcroppe has joined #openstack-nova04:11
*** wverdugo500 has joined #openstack-nova04:12
*** sballe_ is now known as sballe04:12
*** jhesketh has joined #openstack-nova04:12
*** _RuiChen_ has joined #openstack-nova04:12
*** gongysh has quit IRC04:13
*** anthonyper has joined #openstack-nova04:14
*** _RuiChen has quit IRC04:15
*** pixelbeat_ has quit IRC04:15
*** gcb has quit IRC04:15
*** browne has joined #openstack-nova04:15
*** gcb has joined #openstack-nova04:16
*** adam_g has joined #openstack-nova04:16
*** heyongli has quit IRC04:16
*** adam_g has quit IRC04:16
*** adam_g has joined #openstack-nova04:16
*** heyongli has joined #openstack-nova04:17
*** gus_ is now known as gus04:18
*** gongysh has joined #openstack-nova04:20
*** ameade has joined #openstack-nova04:21
*** gongysh has quit IRC04:24
*** chenzeng has quit IRC04:25
*** gongysh has joined #openstack-nova04:25
*** heyongli has quit IRC04:26
*** heyongli has joined #openstack-nova04:27
*** klkumar has quit IRC04:28
*** boris-42 has quit IRC04:28
*** zhangjn has quit IRC04:30
*** zhangjn has joined #openstack-nova04:31
*** zhangjn has quit IRC04:31
*** zhangjn has joined #openstack-nova04:32
*** klkumar has joined #openstack-nova04:33
*** heyongli has quit IRC04:37
*** heyongli has joined #openstack-nova04:38
*** tpeoples has quit IRC04:38
*** dave-mccowan has quit IRC04:38
*** otter768 has quit IRC04:41
*** klkumar has quit IRC04:42
*** greghaynes2 has joined #openstack-nova04:43
*** jmccrory has joined #openstack-nova04:44
*** tpeoples has joined #openstack-nova04:44
*** markvoelker has joined #openstack-nova04:44
*** klkumar has joined #openstack-nova04:44
*** Sree has joined #openstack-nova04:46
*** Sree has quit IRC04:46
*** heyongli has quit IRC04:47
*** Sree has joined #openstack-nova04:47
*** heyongli has joined #openstack-nova04:48
*** markvoelker has quit IRC04:49
*** deepakcs has joined #openstack-nova04:51
*** setuid has quit IRC04:52
*** su_zhang has quit IRC04:52
*** daemontool has quit IRC04:53
*** hparekh has quit IRC04:53
*** hparekh2 has joined #openstack-nova04:53
*** achanda has joined #openstack-nova04:54
*** daemontool has joined #openstack-nova04:54
*** setuid has joined #openstack-nova04:57
*** heyongli has quit IRC04:57
*** heyongli has joined #openstack-nova04:58
*** Sree_ has joined #openstack-nova05:01
*** Sree_ is now known as Guest4263905:01
*** links has joined #openstack-nova05:02
*** Sree has quit IRC05:04
*** salv-orlando has joined #openstack-nova05:04
*** artom_ has joined #openstack-nova05:04
*** artom has quit IRC05:04
*** mdrabe has joined #openstack-nova05:05
*** Jeffrey4l has quit IRC05:06
*** heyongli has quit IRC05:07
*** heyongli has joined #openstack-nova05:08
*** mdrabe has quit IRC05:11
*** subscope has joined #openstack-nova05:13
*** thorst has joined #openstack-nova05:14
*** dvlwrk_ has quit IRC05:15
*** subscope has quit IRC05:16
*** subscope has joined #openstack-nova05:16
*** Guest42639 has quit IRC05:17
*** Sree has joined #openstack-nova05:18
*** heyongli has quit IRC05:18
*** kragniz_ is now known as kragniz05:18
*** thorst has quit IRC05:18
*** heyongli has joined #openstack-nova05:19
*** Jeffrey4l has joined #openstack-nova05:19
*** ssurana1 has quit IRC05:21
*** changbl has joined #openstack-nova05:22
*** davideagnello has joined #openstack-nova05:22
*** ssurana has joined #openstack-nova05:25
*** jwcroppe has quit IRC05:28
*** heyongli has quit IRC05:28
*** heyongli has joined #openstack-nova05:29
*** salv-orlando has quit IRC05:30
*** greghaynes is now known as greghaynes_05:30
*** greghaynes2 is now known as greghaynes05:30
*** haomaiwang has joined #openstack-nova05:31
*** dvlwrk_ has joined #openstack-nova05:32
*** ssurana has quit IRC05:32
openstackgerritTang Chen proposed openstack/nova: WIP: Implement status machine for live-migration.  https://review.openstack.org/24147605:34
openstackgerritTang Chen proposed openstack/nova: WIP: Implement status machine for resize.  https://review.openstack.org/24147705:34
openstackgerritTang Chen proposed openstack/nova: WIP: Implement status machine for evacuation.  https://review.openstack.org/24147805:34
openstackgerritTang Chen proposed openstack/nova: WIP: Implement status machine for migration.  https://review.openstack.org/24147905:34
openstackgerritTang Chen proposed openstack/nova: WIP: Use status machines to manage the migraiton status.  https://review.openstack.org/24148005:34
*** jraju has joined #openstack-nova05:36
*** links has quit IRC05:37
*** heyongli has quit IRC05:38
*** heyongli has joined #openstack-nova05:39
*** shuquan has joined #openstack-nova05:45
*** cheikh_abc has joined #openstack-nova05:46
*** ramishra has quit IRC05:46
cheikh_abchello?05:46
*** ramishra has joined #openstack-nova05:46
cheikh_abcnobody here?05:47
*** heyongli has quit IRC05:48
*** davideagnello has quit IRC05:49
*** tpeoples has quit IRC05:49
*** heyongli has joined #openstack-nova05:49
*** eliqiao1 has joined #openstack-nova05:51
*** ZZelle_ has joined #openstack-nova05:51
*** eliqiao1 has quit IRC05:55
*** cheikh_abc has left #openstack-nova05:56
*** heyongli has quit IRC05:59
*** vilobhmm11 has joined #openstack-nova05:59
*** heyongli has joined #openstack-nova06:00
*** haomaiwang has quit IRC06:01
*** haomaiwa_ has joined #openstack-nova06:01
*** jerrygb has quit IRC06:01
openstackgerritChangBo Guo(gcb) proposed openstack/nova: Use version convert methods from oslo_utils.versionutils  https://review.openstack.org/20332206:02
*** irenab has joined #openstack-nova06:03
*** ZZelle_ has quit IRC06:06
*** heyongli has quit IRC06:09
*** heyongli has joined #openstack-nova06:10
*** eliqiao has joined #openstack-nova06:11
*** cfriesen_ has quit IRC06:11
*** jraju has quit IRC06:15
openstackgerritlvdongbing proposed openstack/nova: Add oslo_config PortOpt support  https://review.openstack.org/23956906:16
*** heyongli has quit IRC06:19
*** heyongli has joined #openstack-nova06:20
*** electrocucaracha has quit IRC06:22
openstackgerritChaoyi Huang proposed openstack/nova-specs: Expose quiece unquiece API  https://review.openstack.org/23788106:23
*** Kevin_Zheng has joined #openstack-nova06:24
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: vm placement on group of hosts within cluster  https://review.openstack.org/21081106:26
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: add flavor extra_spec for vm group  https://review.openstack.org/24143606:26
*** heyongli has quit IRC06:29
*** heyongli has joined #openstack-nova06:30
*** shuquan has quit IRC06:31
*** salv-orlando has joined #openstack-nova06:31
*** shuquan has joined #openstack-nova06:32
*** jlvillal has quit IRC06:32
*** jlvillal has joined #openstack-nova06:33
*** gongysh has quit IRC06:34
*** gongysh has joined #openstack-nova06:35
tangchencheikh_abc: Hi, I'm here. But I'm not a core developer or reviewer.06:36
tangchencheikh_abc: If you are looking for someone who can +2 your patch, please wait two more hours.06:37
*** unicell1 has joined #openstack-nova06:40
*** heyongli has quit IRC06:40
*** eliqiao has left #openstack-nova06:40
*** shuquan has quit IRC06:40
*** abhishekk has joined #openstack-nova06:40
*** e0ne has joined #openstack-nova06:40
*** heyongli has joined #openstack-nova06:41
*** unicell has quit IRC06:41
*** otter768 has joined #openstack-nova06:41
*** links has joined #openstack-nova06:42
*** subscope has quit IRC06:43
*** chenzeng has joined #openstack-nova06:43
*** baoli has joined #openstack-nova06:45
*** markvoelker has joined #openstack-nova06:45
*** otter768 has quit IRC06:46
*** baoli has quit IRC06:47
*** shuquan has joined #openstack-nova06:48
*** markvoelker has quit IRC06:49
*** e0ne has quit IRC06:50
*** heyongli has quit IRC06:50
*** heyongli has joined #openstack-nova06:51
*** veena has joined #openstack-nova06:52
*** markvoelker has joined #openstack-nova07:00
*** heyongli has quit IRC07:00
*** haomaiwa_ has quit IRC07:01
*** heyongli has joined #openstack-nova07:01
*** haomaiwa_ has joined #openstack-nova07:01
*** jamielennox is now known as jamielennox|away07:02
*** dstepanenko has quit IRC07:02
*** salv-orlando has quit IRC07:02
*** dstepanenko has joined #openstack-nova07:02
*** josecastroleon has joined #openstack-nova07:02
*** lsmola has joined #openstack-nova07:03
*** cristicalin has joined #openstack-nova07:04
*** rajesht has quit IRC07:04
*** markvoelker has quit IRC07:05
*** vilobhmm11 has quit IRC07:05
*** heyongli has quit IRC07:10
*** heyongli has joined #openstack-nova07:11
*** shuquan has quit IRC07:13
*** dstepanenko has quit IRC07:14
*** dstepanenko has joined #openstack-nova07:14
*** nkrinner has joined #openstack-nova07:15
*** thorst has joined #openstack-nova07:15
*** garyk1 has joined #openstack-nova07:16
*** shuquan has joined #openstack-nova07:17
*** thorst has quit IRC07:20
*** heyongli has quit IRC07:21
gibiandrearosa: sorry, but you just missed me yesterday07:22
*** heyongli has joined #openstack-nova07:22
*** gongysh has quit IRC07:24
*** inara` has joined #openstack-nova07:24
*** gongysh has joined #openstack-nova07:25
*** nithyag__ has quit IRC07:27
*** inara has quit IRC07:27
*** sc68cal has quit IRC07:27
*** _cerberus_ has quit IRC07:27
*** jamiec has quit IRC07:27
*** nithyag__ has joined #openstack-nova07:27
*** shz has quit IRC07:28
*** _cerberus_ has joined #openstack-nova07:29
*** heyongli has quit IRC07:31
*** heyongli has joined #openstack-nova07:32
*** chenzeng has quit IRC07:32
*** chenzeng has joined #openstack-nova07:32
*** sc68cal has joined #openstack-nova07:34
*** alexschm has joined #openstack-nova07:35
*** romainh has joined #openstack-nova07:36
*** heyongli has quit IRC07:41
*** heyongli has joined #openstack-nova07:42
*** moshele has joined #openstack-nova07:42
*** jerrygb has joined #openstack-nova07:47
*** mpavone has joined #openstack-nova07:49
*** veena has quit IRC07:49
*** heyongli has quit IRC07:51
*** jerrygb has quit IRC07:52
*** mpavone has quit IRC07:52
*** heyongli has joined #openstack-nova07:52
*** gongysh has quit IRC07:58
*** gongysh has joined #openstack-nova07:59
*** haomaiwa_ has quit IRC08:01
*** Sree_ has joined #openstack-nova08:01
*** Sree_ is now known as Guest8629808:01
*** haomaiwa_ has joined #openstack-nova08:01
*** salv-orlando has joined #openstack-nova08:01
*** heyongli has quit IRC08:02
*** chenzeng has quit IRC08:02
*** heyongli has joined #openstack-nova08:03
*** Sree has quit IRC08:04
*** shuquan has quit IRC08:05
*** hemnafk has quit IRC08:06
*** hemnafk has joined #openstack-nova08:06
*** achanda has quit IRC08:07
*** hemnafk has quit IRC08:07
*** hemnafk has joined #openstack-nova08:07
*** gonzalo2kx has quit IRC08:11
*** gongysh has quit IRC08:11
*** heyongli has quit IRC08:12
*** heyongli has joined #openstack-nova08:13
bauzasgood morning Nova08:13
kashyapMorning08:14
*** salv-orlando has quit IRC08:14
*** salv-orlando has joined #openstack-nova08:14
*** gongysh has joined #openstack-nova08:14
tangchenHi08:14
tangchenbauzas: I have post some WIP patches of state machine to Gerrit.08:15
tangchenbauzas: https://review.openstack.org/241476 ~ 24148008:16
bauzastangchen: ack, will review them08:16
tangchenbauzas: Thx08:16
tangchenBTW, one small question, do you know if there is any interface in cli or GUI that can modify VM's RTC ?08:17
*** thorst has joined #openstack-nova08:17
tangchene.g, <timer name='rtc' tickpolicy='catchup'/>08:18
tangchenThis is the xml file of libvirt.08:18
tangchenIf I want to modify it, any interface in Nova ?08:18
*** Guest86298 has quit IRC08:18
*** Sree has joined #openstack-nova08:19
*** rdopiera has joined #openstack-nova08:21
*** thorst has quit IRC08:22
*** heyongli has quit IRC08:22
*** heyongli has joined #openstack-nova08:23
*** subscope has joined #openstack-nova08:25
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: SameHostFilter should fail if host does not have instances  https://review.openstack.org/22903008:26
*** pratikmallya has joined #openstack-nova08:27
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: libvirt: make live_migration_uri flag dependent on virt_type  https://review.openstack.org/17578008:28
bauzastangchen: no, it's not possible using the REST API08:28
bauzastangchen: since it's really libvirt specific08:28
*** markmc has quit IRC08:30
tangchenbauzas: Then if I want to change the RTC config of a VM, is it doable in openstack ?08:30
*** gongysh has quit IRC08:31
*** chenzeng has joined #openstack-nova08:31
*** heyongli has quit IRC08:32
*** heyongli has joined #openstack-nova08:33
*** josecastroleon has quit IRC08:34
*** rotbeard has joined #openstack-nova08:36
bauzastangchen: I'd defer that to a libvirt expert like kashyap but I don't feel it's possible using a REST PUT like I said08:36
bauzasof course, you still have virsh for running instances08:36
andrearosagibi: morning, just a question about the sub-team for notification, as I told you in Tokyo I am interested but at the moment I can't tell you how much time I can invest on it, do you want me to put my name on the etherpad?08:37
*** gongysh has joined #openstack-nova08:37
*** ZZelle has quit IRC08:38
*** veena has joined #openstack-nova08:38
*** ZZelle has joined #openstack-nova08:38
*** rk4n has joined #openstack-nova08:39
*** sahid has joined #openstack-nova08:42
*** otter768 has joined #openstack-nova08:42
*** heyongli has quit IRC08:43
*** rotbeard has quit IRC08:43
tangchenbauzas: Thx. I'll try to ask him.08:43
*** rotbeard has joined #openstack-nova08:43
*** heyongli has joined #openstack-nova08:44
*** rk4n has quit IRC08:45
*** otter768 has quit IRC08:47
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: vm placement on group of hosts within cluster  https://review.openstack.org/21081108:48
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: affinity and anti-affinity within cluster  https://review.openstack.org/21081308:48
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: anti-affinity placement scheduling for cluster  https://review.openstack.org/21081208:48
openstackgerritGiridhar Jayavelu proposed openstack/nova: VMware: add flavor extra_spec for vm group  https://review.openstack.org/24143608:48
*** josecastroleon has joined #openstack-nova08:49
*** sahid has quit IRC08:50
gibiandrearosa: I think it is worth putting your name in the etherpad. It is no problem if you will just follow what is happening until you can commit to more08:51
andrearosagibi: ack08:53
*** heyongli has quit IRC08:53
gibiandrearosa: thanks :)08:53
*** gongysh has quit IRC08:54
*** heyongli has joined #openstack-nova08:54
tangchenkashyap: Hi kashyap, one of my VM's clock is far behind the real clock. And the qemu RTC catchup policy will catch up to the real clock. But the clock runs too fast, and user can feel that. For example, a double click will become a single click.08:58
tangchenkashyap: If I disable the catchup policy in libvirt, it becomes OK.08:58
kashyaptangchen: Hmm, time-keeping is a notorious problem.08:59
tangchenkashyap: So, is there any interface in openstack which is able to control this config ?08:59
kashyaptangchen: Still parsing your question, and looking at libvirt formatdomain page08:59
*** e0ne has joined #openstack-nova09:00
*** gongysh has joined #openstack-nova09:00
*** haomaiwa_ has quit IRC09:01
*** markvoelker has joined #openstack-nova09:01
*** haomaiwa_ has joined #openstack-nova09:01
tangchenkashyap: Thanks. in libvirt xml, it is <timer name='rtc' tickpolicy='catchup'/>09:01
kashyaptangchen: Yeah, found that.  Looking through Nova source to see if there's any Nova config09:02
kashyapWhen danpb is here, I'm sure he'd know for sure -- he fixed a couple of bugs in timers/clocks involving Windows guests, in Nova.09:02
kashyapHmm, Nova hardcodes the policy to 'catchup':09:03
kashyapnova/virt/libvirt/driver.py:        tmrtc.name = "rtc"09:03
kashyapnova/virt/libvirt/driver.py:        tmrtc.tickpolicy = "catchup"09:03
*** heyongli has quit IRC09:03
*** haomaiwa_ has quit IRC09:03
*** heyongli has joined #openstack-nova09:04
kashyaptangchen: So, when you say "disable"09:04
kashyapWhat option did you use? 'discard'?09:05
bauzaskashyap: like I said to tangchen, I feel that as very libvirt specific09:05
*** markus_z has joined #openstack-nova09:06
*** markvoelker has quit IRC09:06
kashyapbauzas: Yeah, timer policy is generated by the libvirt driver.09:07
tangchenkashyap, bauzas: By disable, I mean use 'delay', instead of 'catchup'.09:07
tangchenkashyap, bauzas: There are only two policies here, 'catchup' and 'delay'09:08
tangchenkashyap, bauzas: If we don't specify anything, it is delay by default.09:08
*** jistr has joined #openstack-nova09:08
*** ihrachys has joined #openstack-nova09:08
kashyaptangchen: Yeah the _set_kvm_timers() function09:09
kashyapin driver.py09:09
*** haomaiwang has joined #openstack-nova09:10
kashyaptangchen: The underlying libvirt driver allows more policies though (http://libvirt.org/formatdomain.html#elementsTime), but they're not exposed in Nova.09:11
*** haomaiwang has quit IRC09:11
*** sahid has joined #openstack-nova09:13
*** heyongli has quit IRC09:13
*** heyongli has joined #openstack-nova09:14
*** Sree_ has joined #openstack-nova09:15
tangchenkashyap: I found the comment says:09:16
*** Sree_ is now known as Guest4231109:16
tangchen        # TODO(berrange) One day this should be per-guest09:16
tangchen        # OS type configurable09:16
kashyaptangchen: Yep, was about to point that09:16
tangchenkashyap: Do we have any plan for this ?  If not, I'd like to post a BP. Of course, before I do, I need to do more investigation.09:17
kashyaptangchen: Go for it, I don't know of any existing plans.09:17
kashyaptangchen: Maybe write a small note to the upstream -dev list?09:18
tangchenkashyap: Sure. Thx for the help. :)09:18
openstackgerritZhenyu Zheng proposed openstack/nova: Add project-id and user-id when list server-groups  https://review.openstack.org/20901809:18
kashyapHeh, I did nothing.  I just know time-keeping is a hard problem others smarter than me are solving it :-)09:18
*** Sree has quit IRC09:18
*** pixelbeat_ has joined #openstack-nova09:19
*** klkumar has quit IRC09:20
kashyapWriting to the list would be best, as that'll let others who're not on IRC know that there's such a thing in the works.09:20
*** danpb has joined #openstack-nova09:20
*** aloga has quit IRC09:20
*** flyingtt_ has joined #openstack-nova09:21
*** yassine__ has joined #openstack-nova09:21
*** aloga has joined #openstack-nova09:22
*** klkumar has joined #openstack-nova09:23
*** heyongli has quit IRC09:24
*** heyongli has joined #openstack-nova09:25
*** pratikmallya has quit IRC09:28
openstackgerritgaryk proposed openstack/nova-specs: VMware: expand opaque network support  https://review.openstack.org/23042509:28
*** alex_klimov has joined #openstack-nova09:29
*** jwcroppe has joined #openstack-nova09:31
*** LukeHinds has joined #openstack-nova09:34
*** heyongli has quit IRC09:34
tangchenkashyap: Sorry, where is the dev list ?09:34
kashyaptangchen: You posted to it previously -- openstack-dev mailing list09:35
*** heyongli has joined #openstack-nova09:35
kashyaphttp://lists.openstack.org/pipermail/openstack-dev/09:35
tangchenkashyap: Oh, you mean the email list. OK. :)09:35
kashyapYeah09:35
tangchenOne more thing that has been discussed before, nova wants to desperate host maintenance mode.09:36
tangchenI was going to post a BP to do that. But now, there is only one user of host maintenance mode, that is Xen.09:37
kashyapdanpb: When you get a moment later, a question on time-keeping in Nova (from tangchen): "one of my VM's clock is far behind the real clock. And the qemu RTC catchup policy will catch up to the real clock. But the clock runs too fast, and user can feel that. For example, a double click will become a single click. If I disable the catchup policy in libvirt, it becomes OK.  By disable, I mean use 'del09:37
kashyapay', instead of 'catchup'".09:37
kashyapSome back and forth on that here: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2015-11-04.log.html#t2015-11-04T08:58:1709:37
*** salv-orlando has quit IRC09:37
*** browne has quit IRC09:37
tangchenIf we desperate host maintenance mode, what should we do about the Xen code ?09:37
bauzasdeprecating it09:38
tangchenReading the Xen code, I guess they want to implement their own migration using xen server's pool-migration functionality.09:38
danpbkashyap: really need to know more about the guest os in question09:39
kashyaptangchen: ^09:39
*** salv-orlando has joined #openstack-nova09:39
danpbi'm not convinced we need to change the clock timer modes for any mainstream guest OS09:39
kashyapHe wanted to work on the TODO item you noted in driver.py  _set_kvm_timers() function:09:39
kashyap"One day this should be per-guest OS type configurable"09:39
danpbthe settings we have by default should work for any mainstream OS in general. we support custom settings for windows now assuming the image is tagged correctly09:40
kashyapYep, I'm faimilar your work on  hyper-v timer enlightenments for windows guests.09:41
danpbso the only real time I'd expect we'd need to change is for dealing with old legacy OSs or special purpose embedded OS09:41
danpbwhich might have very specific timing keep needs due to limited or outdated hardware support they might have09:41
danpbthe intent is that we'll make use of libosinfo for this - ie have a section in libosinfo database for recording timer settings for OS09:42
danpbso we're really waiting for the libosinfo work to land before persuing it  further09:42
*** heyongli has quit IRC09:44
*** pratikmallya has joined #openstack-nova09:45
*** heyongli has joined #openstack-nova09:45
kashyapAh, I see.  Thanks for the details.09:46
kashyaptangchen: Please take a look at the above details from Dan.09:47
*** aix has joined #openstack-nova09:48
danpbi'd still be interested to know what guest OS is seeing trouble with current settings09:48
*** markmc has joined #openstack-nova09:48
*** salv-orlando has quit IRC09:50
*** jgriffith has quit IRC09:50
*** salv-orlando has joined #openstack-nova09:51
*** jgriffith has joined #openstack-nova09:51
*** jgriffith is now known as Guest9024209:51
*** dvlwrk_ has quit IRC09:54
*** alex_xu has quit IRC09:54
*** eglynn has joined #openstack-nova09:54
*** heyongli has quit IRC09:54
*** jamielennox|away is now known as jamielennox09:55
*** derekh has joined #openstack-nova09:55
*** heyongli has joined #openstack-nova09:55
tangchenkashyap: yes, reading.09:56
*** veena has quit IRC09:56
tangchendanpb: Well, I'm not sure if I have found the real cause of my problem.09:56
*** MarcF has joined #openstack-nova09:56
tangchendanpb: One of my VM (windows7 64bit), the clock is far behind the real clock.09:57
*** alex_xu has joined #openstack-nova09:57
tangchenThen 'catchup' policy will make the clock run faster, which made the double click became single click.09:57
tangchenI'd like to disable 'catchup'09:58
danpbtangchen: was the disk image for the windows VM tagged with   os_type=windows ?09:59
danpbtangchen: as doing that enables the hyperv clock & other hyperv extensions which provides a far more reliable paravirtualized clock source10:00
danpbat which point, IIUC, the other clock settings become pretty much irrelevant10:00
tangchendanpb: The tag is in xml file ?10:01
*** zhenguo has quit IRC10:03
tangchendanpb: I don't have such a tag in my xmlfile. os_type=windows10:03
tangchendanpb: I'll try it. Thx.10:04
kashyapI think it's a Glance image metadata property10:04
*** heyongli has quit IRC10:05
kashyaptangchen: Look up "os_type" here: http://docs.openstack.org/cli-reference/content/chapter_cli-glance-property.html10:05
*** pratikmallya has quit IRC10:05
tangchenkashyap: Ah, OK. I'll take a look. Thx.10:06
*** heyongli has joined #openstack-nova10:06
tangchenkashyap, danpb, bauzas: Thank you for your nice help. It is a little later here, and I have to go. See you tomorrow. Thx. :)10:07
openstackgerritDaniel Berrange proposed openstack/nova-specs: VIF port config versioned objects and driver plugin library  https://review.openstack.org/19366810:10
danpbtangchen: no, in the glance image10:10
*** heyongli has quit IRC10:15
*** MarcF has quit IRC10:15
*** heyongli has joined #openstack-nova10:16
*** rk4n has joined #openstack-nova10:22
*** alex_xu has quit IRC10:23
*** alex_xu has joined #openstack-nova10:24
*** jichen has joined #openstack-nova10:24
*** heyongli has quit IRC10:25
*** heyongli has joined #openstack-nova10:26
*** moshele has quit IRC10:32
*** heyongli has quit IRC10:35
*** heyongli has joined #openstack-nova10:36
*** salv-orlando has quit IRC10:37
openstackgerritBalazs Gibizer proposed openstack/nova-specs: Versioned notification API  https://review.openstack.org/22475510:40
openstackgerritTomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156210:42
*** otter768 has joined #openstack-nova10:43
*** dvlwrk_ has joined #openstack-nova10:44
*** heyongli has quit IRC10:46
*** heyongli has joined #openstack-nova10:47
*** otter768 has quit IRC10:48
*** jistr_ has joined #openstack-nova10:48
*** ihrachys_ has joined #openstack-nova10:48
*** jistr has quit IRC10:48
*** ihrachys has quit IRC10:48
*** ihrachys has joined #openstack-nova10:49
*** subscope has quit IRC10:50
*** daemontool has quit IRC10:51
*** jistr_ has quit IRC10:53
*** ihrachys_ has quit IRC10:53
*** Kennan has quit IRC10:53
*** khomkrit has joined #openstack-nova10:53
openstackgerritTomi Juvonen proposed openstack/nova: Add host_status attribute for servers/detail and servers/{server_id}  https://review.openstack.org/24156210:53
*** heyongli has quit IRC10:56
*** Kennan has joined #openstack-nova10:56
*** heyongli has joined #openstack-nova10:57
*** veena has joined #openstack-nova10:57
*** rotbeard has quit IRC10:58
*** markvoelker has joined #openstack-nova11:02
* alex_xu always learned knowledge from irc11:04
*** jistr_ has joined #openstack-nova11:05
*** markvoelker has quit IRC11:06
*** heyongli has quit IRC11:06
*** heyongli has joined #openstack-nova11:07
*** Guest42311 has quit IRC11:08
*** mmdurrant has quit IRC11:09
*** romainh has left #openstack-nova11:14
*** heyongli has quit IRC11:16
*** heyongli has joined #openstack-nova11:17
mdboothalaski: If you're awake yet, do you have a complete command line for this bug: https://bugs.launchpad.net/nova/+bug/1501851 . I get "Mapping image to local is not supported" when trying to do this.11:18
openstackLaunchpad bug 1501851 in OpenStack Compute (nova) "Nova can incorrectly think an instance is volume backed" [Low,In progress] - Assigned to Nimish Joshi (jnimish77)11:18
*** rotbeard has joined #openstack-nova11:18
*** gszasz has joined #openstack-nova11:21
*** drankis has joined #openstack-nova11:23
johnthetubaguymdbooth: not sure, but I think he is back from paternity tomorrow11:25
mdboothFun times :)11:25
mdboothIf anybody else happens to know what that bug might be about that would be useful11:25
*** heyongli has quit IRC11:27
*** heyongli has joined #openstack-nova11:27
*** pratikmallya has joined #openstack-nova11:30
*** deepakcs has quit IRC11:30
*** josecastroleon has quit IRC11:31
*** moshele has joined #openstack-nova11:34
openstackgerritRadomir Dopieralski proposed openstack/nova: Make the create_instance call accept security group ids as well as names  https://review.openstack.org/21729211:35
johnthetubaguymdbooth: hmm, interesting, I see what you mean, unsure how that bug is hit given the check you are hitting11:35
mdboothjohnthetubaguy: It's not desperately important, but if I'd been able to reproduce easily it looked like a good example bug11:36
*** heyongli has quit IRC11:37
*** heyongli has joined #openstack-nova11:38
*** mwagner has quit IRC11:40
johnthetubaguymdbooth: yeah, totally11:40
*** salv-orlando has joined #openstack-nova11:41
*** aix has quit IRC11:41
mdboothjohnthetubaguy: While I'm at it, this bug: https://bugs.launchpad.net/nova/+bug/141299311:42
openstackLaunchpad bug 1412993 in OpenStack Compute (nova) "Nova resize for boot-from-volume instance does not resize volume" [Undecided,Confirmed] - Assigned to Claudiu Belu (cbelu)11:42
mdboothI read this and had the same thoughts as both you and pmurray11:42
mdboothWhat's the procedure for closing this without a resolution?11:43
mdboothIn bugzilla this would be CLOSED NOTABUG11:43
johnthetubaguymdbooth: good call out, yeah, lets mark this as invalid11:43
mdboothjohnthetubaguy: Spotted, and done.11:44
mdboothThanks11:44
johnthetubaguymdbooth: no problems, thanks for digging11:44
*** aysyd has joined #openstack-nova11:45
*** salv-orlando has quit IRC11:46
*** heyongli has quit IRC11:47
*** subscope has joined #openstack-nova11:48
*** heyongli has joined #openstack-nova11:48
*** markmc has quit IRC11:49
*** markmc has joined #openstack-nova11:49
*** pratikmallya has quit IRC11:50
*** sahid has quit IRC11:51
*** Kennan has quit IRC11:51
*** dvlwrk_ has quit IRC11:53
*** Kennan has joined #openstack-nova11:54
*** jaypipes has joined #openstack-nova11:55
sdaguemorning folks11:57
*** heyongli has quit IRC11:57
*** heyongli has joined #openstack-nova11:58
*** markus_z has quit IRC11:59
*** thorst has joined #openstack-nova12:00
*** jwcroppe has quit IRC12:01
*** rfolco has joined #openstack-nova12:01
*** jwcroppe has joined #openstack-nova12:02
*** zhangjn has quit IRC12:02
*** ferest_ has joined #openstack-nova12:03
*** daemontool has joined #openstack-nova12:03
alex_xusdague: morning12:04
*** thorst has quit IRC12:04
*** jwcroppe has quit IRC12:06
*** salv-orlando has joined #openstack-nova12:07
*** ferest_ has quit IRC12:07
*** heyongli has quit IRC12:08
*** ericksonsantos has quit IRC12:08
*** heyongli has joined #openstack-nova12:08
*** ericksonsantos has joined #openstack-nova12:09
*** veena has quit IRC12:09
*** veena has joined #openstack-nova12:11
jaypipessdague: mornin.12:12
jaypipesalex_xu: mornin :)12:13
jaypipesalex_xu: or evening :)12:13
alex_xujaypipes: :)12:13
*** aix has joined #openstack-nova12:13
*** wasmum has quit IRC12:14
*** markvoelker has joined #openstack-nova12:17
*** dims has joined #openstack-nova12:18
*** heyongli has quit IRC12:18
*** heyongli has joined #openstack-nova12:19
johnthetubaguydanpb: jaypipes: is there any chance we could chat about this spec after lunch: https://review.openstack.org/#/c/190917/7/specs/mitaka/approved/nova-neutron-binding-negotiation.rst,cm12:19
johnthetubaguydanpb: jaypipes: it feels like the list of "preferred_binding_types" should live is OS VIF Lib, but I don't really know that code well enough12:20
danpbjohnthetubaguy: sure, my feeling is that it is really just part of the os-vif work12:20
johnthetubaguydanpb: I guess the question is do we add it now, and port it to os vif lib afterwards, or do we do it in os vif lib to start with?12:21
*** Kennan has quit IRC12:22
*** juzuluag has joined #openstack-nova12:22
*** markvoelker has quit IRC12:22
jaypipesjohnthetubaguy: sure thing. so, in about 30 minutes?12:22
*** thorst has joined #openstack-nova12:23
johnthetubaguyjaypipes: that works for me, I should run off and get something to eat, so quick chat at 13.00UTC12:23
jaypipessure, sounds good. I'll read that spec in the meantime.12:23
*** Kennan has joined #openstack-nova12:25
*** heyongli has quit IRC12:28
*** heyongli has joined #openstack-nova12:29
*** EinstCrazy has joined #openstack-nova12:30
*** heyongli has quit IRC12:38
*** A110602877_ has joined #openstack-nova12:39
*** heyongli has joined #openstack-nova12:39
*** chenzeng has quit IRC12:39
*** josecastroleon has joined #openstack-nova12:40
*** achanda has joined #openstack-nova12:40
sdaguehttp://tinyurl.com/p6l4lvd - the data on the grenade multinode seems pretty solid so far12:41
*** haomaiwang has joined #openstack-nova12:41
*** achanda has quit IRC12:42
*** dims has quit IRC12:43
*** jistr_ is now known as jistr12:44
*** otter768 has joined #openstack-nova12:44
*** klkumar has quit IRC12:45
*** moshele has quit IRC12:46
*** dave-mccowan has joined #openstack-nova12:47
*** jamielennox is now known as jamielennox|away12:48
*** heyongli has quit IRC12:49
*** klkumar has joined #openstack-nova12:49
*** otter768 has quit IRC12:49
*** heyongli has joined #openstack-nova12:49
*** wasmum has joined #openstack-nova12:50
*** ferest has joined #openstack-nova12:50
*** baoli has joined #openstack-nova12:53
*** baoli has quit IRC12:53
*** danpb has quit IRC12:55
*** baoli has joined #openstack-nova12:56
*** danpb has joined #openstack-nova12:56
*** daemontool has quit IRC12:57
*** ihrachys has quit IRC12:57
*** daemontool has joined #openstack-nova12:57
*** ihrachys has joined #openstack-nova12:58
alaskimdbooth: just here for a second, but it appears that the --image flag is needed as well in that case http://git.openstack.org/cgit/openstack/nova/tree/nova/block_device.py#n20512:58
*** heyongli has quit IRC12:59
*** jlanoux has joined #openstack-nova13:00
*** inara` has quit IRC13:00
*** heyongli has joined #openstack-nova13:00
*** ihrachys has quit IRC13:00
johnthetubaguysdague: those grenade multi-node things are looking very cool :)13:00
*** haomaiwang has quit IRC13:01
johnthetubaguydanpb: jaypipes: no is good for a quick chat, if you are free13:01
johnthetubaguydoh, now13:01
*** haomaiwang has joined #openstack-nova13:01
danpbok13:03
*** dvlwrk_ has joined #openstack-nova13:04
johnthetubaguyjust wondering what we want to do with that vif negotiation spec13:05
johnthetubaguydo we just let that happen in paralell with os vif lib to start with?13:05
*** pratikmallya has joined #openstack-nova13:06
danpbso the os vif lib will need negotiation support13:06
danpbi guess my concern with doing it in parallel is whether we'd implement negotiation once, then find it doesn't do what we need and then have to do it again13:07
danpband end up having to support 2 negotiation mechanisms :-(13:07
johnthetubaguyyeah, that seems like a valid concern to me13:07
danpbthat's not neccessarily to say we shouldn't approve the spec13:08
danpbit could just be something we resolve during impl time13:08
johnthetubaguywell, yes, but I think they have code they want to merge now13:09
*** dims has joined #openstack-nova13:09
*** heyongli has quit IRC13:09
johnthetubaguyI think we are saying, lets add the API using the OS VIF lib object-ey approach, to start with, so we don't have to do it twice, and that sounds good to me13:09
*** heyongli has joined #openstack-nova13:10
jaypipesjohnthetubaguy, danpb: I have some concerns on this spec. Still adding feedback to it...13:10
*** klkumar has quit IRC13:11
danpbjohnthetubaguy: yeah, that's pretty much exactly what i'm saying13:11
johnthetubaguyjaypipes: so I was wondering if we wanted a more a set of "hits" like interface, rather than a list of supported things13:11
johnthetubaguydanpb: cool, just wanted to make sure I am understanding you correctly13:11
danpbi guess ian wells' concern is that if  os-vif doesn't get merged in M, then his spec misses a cycle again13:11
danpbwhich is  a valid concern, but I hope we've mitigated against failure by making os-vif a priority13:12
johnthetubaguydanpb: +113:12
*** mwagner has joined #openstack-nova13:16
*** abhishekk has quit IRC13:17
*** ferest has quit IRC13:17
*** salv-orlando has quit IRC13:19
*** heyongli has quit IRC13:19
jaypipesjohnthetubaguy, danpb: ok, reviewed. please take a look at my comments and let me know if I'm crazy.13:20
*** ferest has joined #openstack-nova13:20
*** dims has quit IRC13:20
*** heyongli has joined #openstack-nova13:20
*** jwcroppe has joined #openstack-nova13:22
*** inteq has quit IRC13:23
*** markvoelker has joined #openstack-nova13:23
*** baoli_ has joined #openstack-nova13:23
johnthetubaguyjaypipes: your comment on ln 135, I has assumed neutron needed to do something different for each case, so tells nova which one it has chosen, but you make a very good point, we probably need some kind of retry I guess?13:24
*** baoli has quit IRC13:26
*** pratikmallya has quit IRC13:26
*** heyongli has quit IRC13:30
*** heyongli has joined #openstack-nova13:31
*** su_zhang has joined #openstack-nova13:33
*** edmondsw has joined #openstack-nova13:34
*** markus_z has joined #openstack-nova13:35
*** alex_klimov has quit IRC13:37
*** heyongli has quit IRC13:40
*** links has quit IRC13:41
*** heyongli has joined #openstack-nova13:41
*** dvlwrk_ has quit IRC13:43
*** salv-orlando has joined #openstack-nova13:43
*** heyongli has quit IRC13:50
*** heyongli has joined #openstack-nova13:51
*** rlrossit has joined #openstack-nova13:52
*** Sree has joined #openstack-nova13:55
*** jwcroppe has quit IRC13:55
*** dave-mccowan has quit IRC13:56
*** salv-orlando has quit IRC13:58
*** juzuluag has quit IRC13:59
*** ctrath has joined #openstack-nova14:00
*** mdrabe has joined #openstack-nova14:00
*** heyongli has quit IRC14:00
*** haomaiwang has quit IRC14:01
*** haomaiwa_ has joined #openstack-nova14:01
*** heyongli has joined #openstack-nova14:01
*** eglynn has quit IRC14:02
*** ijuwang has joined #openstack-nova14:02
*** mriedem has joined #openstack-nova14:02
*** Piet has quit IRC14:02
*** xyang1 has joined #openstack-nova14:02
*** burgerk has joined #openstack-nova14:03
*** dustins has joined #openstack-nova14:06
*** otter768 has joined #openstack-nova14:06
*** otter768 has quit IRC14:07
*** otter768 has joined #openstack-nova14:08
garyk1mriedem: johnthetubaguy: can you please see https://review.openstack.org/#/c/230425/14:08
*** heyongli has quit IRC14:11
*** mriedem has quit IRC14:11
*** heyongli has joined #openstack-nova14:11
johnthetubaguygaryk1: thanks for getting a good group of reviewers on that, will take a look14:12
*** otter768 has quit IRC14:12
garyk1np14:12
*** ferest has quit IRC14:13
johnthetubaguygaryk1: while I am thinking about it, once libvirt has adopted OS VIF Lib, that should help you folks with adding these kinds of things? I guess? (BTW, explicitly not blocking folks adding VIF things while we get that OS VIF lib stuff in place)14:13
*** mriedem has joined #openstack-nova14:14
*** moshele has joined #openstack-nova14:14
*** dave-mccowan has joined #openstack-nova14:14
*** mc_nair has joined #openstack-nova14:15
garyk1johnthetubaguy: i am not sure that that will help. this only uses the vif type. so it is orthogonal.14:15
garyk1i have a ton of concerns with the vif type lib. the main one is that if it is a external project to nova. getting the version updates into nova will be hard and also vendor specific14:16
garyk1that will also require all kinds of tweaks to libvirt which at the moment is very tricky14:16
*** veena_ has joined #openstack-nova14:17
*** links has joined #openstack-nova14:17
garyk1for example the request earlier today for th eopencontrail driver for libvirt (i think that was the name)14:17
*** veena has quit IRC14:17
garyk1i am also not sure if and when the neutron community will make these changes in the plugins14:17
garyk1so we will need at least a cycle or two to ensure support of existing and working neutron plugins14:18
garyk1sorry for being the party pooper14:18
johnthetubaguythere are a few bits to the os vif lib thing, its totally going to take a cycle or two, agreed there14:18
garyk1i would take the approach of doing it in nova and when it is working in nova spin it out to a seperate repo14:19
johnthetubaguyI think there is a whole class of things that go only into os vif lib, rather than in the core of Nova, so it should be able to move faster14:19
openstackgerritGábor Antal proposed openstack/nova: Replaced deprecated timeutils methods (isotime() and strtime())  https://review.openstack.org/24117914:19
*** jichen has quit IRC14:19
*** burgerk has quit IRC14:19
garyk1having it in a seperate repo will have the additional overhead of requirements project etc.14:19
garyk1once it is in nova and it 'compiles' we can start to see how neutron can consume and pass the data to nova14:20
johnthetubaguyyes, I think the idea is to release every week or so, like oslo, to try make it quick to get updates14:20
*** READ10 has joined #openstack-nova14:20
*** krtaylor has quit IRC14:20
johnthetubaguyso, it totally depends where the line is drawn, but gut says it looks good, but I will be more certain one I see the patches up I guess14:21
*** heyongli has quit IRC14:21
*** romainh has joined #openstack-nova14:21
sdaguemriedem: you respinning this today - https://review.openstack.org/#/c/225199/ ?14:22
*** ctrath has quit IRC14:22
mriedemsdague: i can14:22
*** heyongli has joined #openstack-nova14:22
mriedemsdague: are you around today?14:22
sdaguemriedem: I am14:22
mriedemcan we get this done? https://review.openstack.org/#/c/240020/14:22
sdaguemostly un jetlagged14:22
* mriedem throws sdague a scooby snack14:22
mriedemi want to get that novaclient release out before something else is merged14:23
sdaguemriedem: yes, though we should probably get dhellmann or dims to do the thing14:23
sdaguebecause the actual release mechanics are still a thing that I've not done in the new model yet14:23
*** klkumar has joined #openstack-nova14:23
*** Sree has quit IRC14:23
mriedemi'm just poking you b/c i poked in the release channel yesterday14:23
mriedembut you have +2 power14:24
mriedemwhich helps with the pokey14:24
mriedemgaryk1: https://review.openstack.org/#/c/230425/ is ready to go14:24
*** mrkz has joined #openstack-nova14:25
mriedemjohnthetubaguy: the bp is approved, want to drop your -2? https://review.openstack.org/#/c/165750/14:25
garyk1mriedem: johnthetubaguy: thanks!14:25
*** markus_z has quit IRC14:27
*** ccarmack has quit IRC14:28
sdaguemriedem: right, except, the +2 doesn't really do a thing. Basically it's a 1 +2 repo, that after you land the change you do the manual thing to do the release14:28
*** jerrygb has joined #openstack-nova14:28
mriedemi know i know, but it's symbolic14:29
mriedemsometimes they want ack from nova peeps14:29
mriedemon a nova release14:29
mriedemeven though i'm a nova release guy14:29
mriedemgaryk1: is the opaque network thing considered a high priority for the vmware subteam in mitaka? i'm assuming yes14:31
*** heyongli has quit IRC14:31
mriedemi'm wondering if subteam high priority + overall project low priority = medium priority in the bp in lp14:31
garyk1mriedem: yes, it is high priority. it is a huge pain point for us as the plugin was released in liberty in neutron.14:31
*** heyongli has joined #openstack-nova14:32
*** su_zhang has quit IRC14:33
garyk1mriedem: i also need to add a few patches following the comments in the spec.14:33
*** krtaylor has joined #openstack-nova14:33
mriedemyeah, just noted some of that in the code review14:33
garyk1mriedem: yes, just saw that. thanks14:34
*** ihrachys has joined #openstack-nova14:34
*** lbelivea has joined #openstack-nova14:34
mriedemsdague: this is a logging only change to help figure out a gate issue for the cells job, has a +2 on it https://review.openstack.org/#/c/241366/14:35
sdaguemriedem: +A14:35
*** ccarmack has joined #openstack-nova14:35
*** Jeffrey4l has quit IRC14:35
mriedemzzzeek: does a sqlalchemy result object from a statement exec (insert or update) provide some level of detail to tell us if we actually did an insert or update?14:36
mriedemlike here https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L393514:36
*** pece has joined #openstack-nova14:37
sdaguemriedem: if you turn on debug logging for sqla it will show exactly the sql statement getting executed14:37
sdaguewe turned it off because it was so verbose14:37
*** moshele has quit IRC14:38
mriedemi have a change at the end of the series which creates a unique constraint on the bdm teable14:38
mriedem*table14:38
mriedemso we'll literally blow up when we try a duplicate insert14:38
mriedemjust need to recheck until we hit that14:38
*** moshele has joined #openstack-nova14:38
mriedemi have some other ideas about avoiding the calls to block_device_mapping_update_or_create altogether14:39
mriedemsince it seems hokey14:39
*** heyongli has quit IRC14:41
mriedemwhy is it a request id originating from tempest to nova api is not the same request id that we find in the cells logs?14:42
bauzasmriedem: say what ? it is14:42
*** pradk_ has joined #openstack-nova14:42
*** pradk_ is now known as pradk14:42
*** heyongli has joined #openstack-nova14:43
mriedemthis is our 400 to create a server http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/console.html#_2015-11-03_21_50_38_50014:43
mriedemthe request id is req-f4c02d3a-b257-4e97-992d-54f5f56a414f right?14:43
bauzasright req-f4c02d3a-b257-4e97-992d-54f5f56a414f14:43
mriedemthat doesn't show up here http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz14:43
bauzasyou're looking at the cells/messaging call ?14:44
mriedemyeah14:44
mriedemi at least know the instance uuid now from previous logging we added yesterday14:45
mriedemb4d6d91b-a94c-45d9-80dc-3e40d83afcee14:45
sdaguemriedem: it's because it's replayed, right?14:45
mriedembut...we don't log that in the cells log14:45
sdaguethat request id is created in the API layer by middleware14:46
bauzasI'm quickly digging in the cells messaging code to see if we're providing the same context or another one14:46
*** mmdurrant has joined #openstack-nova14:46
sdaguemy guess is when you hit the child cell api it's regenerated14:46
bauzassdague: oh sec, that reminds me something I saw in the cells code14:46
*** openstackgerrit has quit IRC14:47
bauzasyeah, we're serializing the context14:47
bauzaslemme show you14:47
*** electrocucaracha has joined #openstack-nova14:47
*** openstackgerrit has joined #openstack-nova14:47
*** cfriesen_ has joined #openstack-nova14:49
*** tpeoples has joined #openstack-nova14:49
mriedemhold the phone14:50
mriedembauzas: in the bdm list on the 2nd server create where it fails b/c the boot_index on both is 0, http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-api.txt.gz#_2015-11-03_21_45_18_44914:50
mriedemthe snapshot_id is different between those two14:50
bauzasmriedem: sdague: so yeah the current context is serialized when calling the child cell https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L305-L30614:51
bauzasand then rehydrated there https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L1344-L134614:52
*** heyongli has quit IRC14:52
*** pratikmallya has joined #openstack-nova14:52
*** heyongli has joined #openstack-nova14:53
*** inteq has joined #openstack-nova14:54
bauzasmriedem: yeah, that's what we identified yesterday, 2 distinct snapshot ids, but the same boot index14:54
mriedemi hadn't noticed the snapshot ids were the same14:55
mriedemthe plot thickens14:55
mriedemhere is some of the new logging in the cells logs http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz#_2015-11-03_21_44_58_27314:56
mriedemi have a meeting, back in 45min14:56
*** ccarmack has quit IRC14:56
*** electrocucaracha has quit IRC14:56
*** mriedem is now known as mriedem_meeting14:56
*** links has quit IRC14:56
*** salv-orlando has joined #openstack-nova14:56
mriedem_meeting^ is the first initial server boot from volume14:57
mriedem_meetingbtw14:57
bauzasmriedem_meeting: ack, will continue investigating14:57
*** sfinucan has joined #openstack-nova14:58
*** mgoddard__ has joined #openstack-nova14:59
*** ccarmack has joined #openstack-nova15:00
*** haomaiwa_ has quit IRC15:01
*** 17SADZFC8 has joined #openstack-nova15:01
*** ccarmack has quit IRC15:01
*** heyongli has quit IRC15:02
*** otter768 has joined #openstack-nova15:02
*** mgoddard_ has quit IRC15:02
dansmithsdague: so what are you thinking about timing of replacing the partial job with the multinode one?15:03
*** moshele has quit IRC15:03
*** heyongli has joined #openstack-nova15:03
sdaguedansmith: I think the last thing we need is a way for grenade to verify both computes are working15:03
sdagueI'm going to get another cup of coffee and contemplate that15:04
dansmithsdague: okay15:04
*** ccarmack has joined #openstack-nova15:05
*** burgerk has joined #openstack-nova15:06
*** otter768 has quit IRC15:12
*** heyongli has quit IRC15:12
*** pumaranikar has joined #openstack-nova15:13
*** heyongli has joined #openstack-nova15:13
*** smurke has joined #openstack-nova15:13
*** signed8bit has joined #openstack-nova15:13
*** sneti has joined #openstack-nova15:14
*** emagana has joined #openstack-nova15:16
*** garyk1 has quit IRC15:19
*** burt has joined #openstack-nova15:21
*** Piet has joined #openstack-nova15:21
*** heyongli has quit IRC15:22
*** heyongli has joined #openstack-nova15:24
*** veena_ has quit IRC15:24
*** sneti has quit IRC15:26
*** sneti has joined #openstack-nova15:26
dansmithjohnthetubaguy: you ready to land the mitaka priorities review?15:28
johnthetubaguydansmith: yeah, I think its good, lots of +1s, including two folks that were not at the summit that I wanted to see vote on it15:29
*** mriedem_meeting is now known as mriedem15:29
dansmithyep, agree15:29
dansmithI'll hit the button15:29
*** tonytan4ever has joined #openstack-nova15:30
*** ZZelle is now known as ZZelle_away15:31
*** tpeoples has quit IRC15:31
dansmithbauzas: are you checking into this py34 fail? http://logs.openstack.org/98/217798/10/check/gate-nova-python34/f54e951/console.html.gz15:31
johnthetubaguydansmith: :D15:31
*** tpeoples has joined #openstack-nova15:31
*** inara has joined #openstack-nova15:31
*** jamiec has joined #openstack-nova15:31
*** dave-mccowan has quit IRC15:31
*** inara has quit IRC15:31
bauzasmeh, fun15:32
*** zhangjn has joined #openstack-nova15:32
bauzasdansmith: that remembers me some job failure15:32
*** heyongli has quit IRC15:33
bauzasdansmith: IIRC, the py34 job is whitelisting what he runs vs. what's not, so probably someone added those xenapi stuff15:33
dansmithreally?15:33
openstackgerritMichal Dubiel proposed openstack/nova: libvirt, vhostuser: Add support for OpenContrail vRouter  https://review.openstack.org/24165215:33
*** heyongli has joined #openstack-nova15:34
bauzasdansmith: yup, lemme see you15:34
*** cristicalin has quit IRC15:34
*** inara has joined #openstack-nova15:34
*** subscope has quit IRC15:34
johnthetubaguymriedem: just approved the blueprint behind this patch, need a -2 removing: https://review.openstack.org/#/c/209018/15:34
mriedemdone15:35
bauzasdansmith: https://github.com/openstack/nova/blob/master/tox.ini#L4715:36
bauzaswhich is https://github.com/openstack/nova/blob/master/tests-py3.txt15:36
dansmithah, blacklist15:37
dansmithyou said whitelist15:37
bauzasyup, my bad, checking logstash15:37
mriedem"Policy check for os_compute_api:os-extended-server-attributes failed" shows up a ton in a gate run15:38
mriedemdef soft_core_authorizer(api_name, extension_name):15:41
mriedemgreat name on that method15:41
*** ctrath has joined #openstack-nova15:41
mriedemlet's just call it cinemax_authorizer15:41
bauzasmriedem: so, back to the cell failure, I'm puzzled15:41
*** ssurana has joined #openstack-nova15:42
bauzasdansmith: will recheck, I don't understand why my code sucks15:42
dansmithbauzas: I'm trying it locally15:42
bauzas(I need anyway to recheck thanks to the lovely cells job failure)15:42
mriedembauzas: i'm trying to track the requests that lead to us getting 2 bdms with different snapshot ids15:43
mriedemwhich would happen from the first instance that has the volume attached15:43
bauzasmriedem: that's what I don't understand15:43
*** heyongli has quit IRC15:43
sdaguedansmith: how long before a compute is marked not up if there was an rpc mismatch failure?15:44
bauzaswe have distinct snapshot ids, but when looking at the cells parent log, can't find those15:44
*** heyongli has joined #openstack-nova15:44
bauzasmriedem: (speaking of the bdm_update logs you had)15:44
*** jwcroppe has joined #openstack-nova15:44
*** ociuhandu has joined #openstack-nova15:44
mriedembauzas: yeah i noticed that too15:44
dansmithsdague: you mean if RPCs are failing to check in as a service? or the fail-on-startup-if-we're-too-old thing?15:45
dansmithbauzas: works locally, that's weird15:45
sdaguein the grenade case, the compute is up15:45
sdaguethen we update conductor15:45
sdagueand it stops talking correctly15:45
*** subscope has joined #openstack-nova15:45
bauzasdansmith: I already saw that behaviour, but logstash doesn't show me a bad list of problems so I guess I went to a race for the mocks calls15:46
dansmithsdague: that would only be the case if something significant has changed in the service object path, which is probably not a strong enough indication that things are happy or unhappy15:46
dansmithbauzas: okay15:46
bauzasmriedem: so I guess the call to bdm_update_or_create_at_top is made when creating the volume, right?15:47
sdaguedansmith: ok, I'm just trying to think through what kind of check I could provide here to ensure that we've got as many working computes as we expect15:47
johnthetubaguymriedem: got another one here: https://review.openstack.org/#/c/205282/15:47
dansmithsdague: yeah, I'm thinking15:47
dansmithsdague: I mean, checking that both computes are "up" at the end of the new run is definitely some indication15:47
mriedembauzas: creating the volume?15:47
mriedemthe bdm you mean?15:47
sdaguedansmith: right, as in service-list up?15:47
dansmithsdague: but we could have failed every boot to node 1 and rescheduled to node 215:47
bauzasmriedem: yup, tired15:48
dansmithsdague: right15:48
sdaguedansmith: right15:48
mriedembauzas: yeah i think we're seeing the cells-region logs for the test only when doing the boot from volume on the first instance15:48
mriedemwhich is why the bdm has volume_id set15:48
dansmithsdague: is it too heavy to just boot an instance directed at each compute node to make sure it lands there?15:48
bauzasmriedem: that's my understanding too, because also the timings are not there15:48
mriedemjohnthetubaguy: done15:48
bauzasI mean15:48
sdaguedansmith: probably not15:49
sdaguedansmith: we'd need to do that post upgrade, right?15:49
*** ociuhandu has quit IRC15:49
dansmithsdague: yeah15:49
dansmithsdague: http://docs.openstack.org/user-guide-admin/cli_nova_specify_host.html15:49
bauzasmriedem: I mean it gives a 400 at 2015-11-03 21:45:18.449 for n-api15:49
sdagueso, conceptually15:49
sdague1) give grenade an expected node count15:50
sdague2) check that there are that many hypervisors15:50
sdague3) check that we can poke something to each hypervisor15:50
sdague3 only really needs to happen post upgrade15:50
bauzasmriedem: while the call to bdm_update_or_create in the messaging log is 2015-11-03 21:44:58.27315:50
mriedembauzas: i think there is something wonky going on when we are creating the snapshot image from the instance with the attached volume15:51
dansmithsdague: yeah15:51
sdaguethe others could happen pre and post as they are quick sanity checks15:51
dansmithyep15:51
mriedembauzas: yeah the logs we're seeing in the cells logs are from the first instance, with the attached volume, that we create the snapshot from15:51
sdagueok, this feels like a plan15:51
mriedembauzas: the 400 is when we try to boot the 2nd instance from the image snapshot from instance 115:51
sdagueI'll start coding15:51
bauzasmriedem: right, but it doesn't go to cells I guess15:51
mriedembauzas: which fails b/c of the duplicate bdms15:51
bauzasmriedem: yup yup15:52
mriedemright15:52
dansmithsdague: cool15:52
mriedemyeah, so something is f'ed up in the server create image flow15:52
mriedemso i'm tracking that15:52
*** tongli has joined #openstack-nova15:52
bauzasmriedem: so, we see the BDM created correctly in https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L171-L17215:53
bauzasbut something is trampled in https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L17515:53
bauzasso I'm tracking that req-id15:53
*** heyongli has quit IRC15:53
mriedembauzas: yeah, the problem is here i think15:54
*** breitz has quit IRC15:54
mriedemhttp://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/console.html#_2015-11-03_21_50_38_47415:54
mriedemwe have 2 bdms in that snapshot image response15:54
*** breitz has joined #openstack-nova15:54
*** heyongli has joined #openstack-nova15:54
bauzasmriedem: req-e6d08eaf-4dc8-4d11-b68d-f45ee08855db is the snapshot request, right?15:56
mriedemyeah15:57
bauzasmriedem: and the snapshot ids are consistent with the 400 request15:58
bauzasspeaking of http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-api.txt.gz#_2015-11-03_21_45_18_44915:59
bauzasso something gets wrong in req-e6d08eaf-4dc8-4d11-b68d-f45ee08855db, tracing it down15:59
mriedembauzas: yup16:00
*** matrohon has quit IRC16:00
mriedemtempest is also a bit busted16:00
mriedemif bdm and 'snapshot_id' in bdm[0]:16:00
mriedemtempest should be asserting that there is only 1 bdm16:00
*** alexschm has quit IRC16:00
mriedemfor the snapshot image16:00
*** 17SADZFC8 has quit IRC16:01
*** haomaiwa_ has joined #openstack-nova16:01
bauzasmelwitt: I won't be available for the cells meeting tonight16:01
bauzas1700UTC16:02
*** daemontool has quit IRC16:02
bauzasalaski: ^16:02
*** haomaiwa_ has quit IRC16:02
*** heyongli has quit IRC16:03
*** heyongli has joined #openstack-nova16:05
*** klkumar has quit IRC16:05
*** lsmola has quit IRC16:05
bauzasmriedem: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1066-L1067 doesn't sounds correct16:06
*** klkumar has joined #openstack-nova16:06
mriedemwhy? it uses that to figure out if it's a volume backed instance16:08
*** garyk has joined #openstack-nova16:08
bauzasmriedem: no sec, I think the problem is before that call16:09
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova: Added new scheduler filter: AggregateTypeExtraSpecsAffinityFilter  https://review.openstack.org/18927916:09
bauzasmriedem: but rather when creating the BDMs from the first boot from volume16:09
bauzasit should be duplicated16:10
bauzasmriedem: then when creating the image, it got persisted16:10
bauzasmriedem: and then failing when booting from the image16:10
mriedemso you think we're attaching 2 bdms to the first instance (volume bdms) and then creating 2 snapshots for the 2 volume bdms?16:10
bauzasmriedem: I feel so16:11
mriedemyeah maybe16:11
mriedemwould be helpful if we had >0 debug logging in here :(16:11
bauzaswhich explains why the snapshot ids are null when looking at the first bdm creations16:11
bauzasbut somehow, we're having duplicates16:12
mriedemyeah, so let's find where it's booting from volume in the compute manager16:12
* bauzas looking back at the cells.messaging logs you had16:12
*** zhangjn has quit IRC16:12
bauzasadded16:12
goodygumhey all16:13
goodygumI just want my Nova to inform me about creation and deletion of a VM via notifications16:13
mriedembauzas: here is where we attach the boot from volume on the first server create http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cpu.txt.gz#_2015-11-03_21_45_00_47216:13
goodygumBTW I have a Kilo version16:14
*** heyongli has quit IRC16:14
goodygumI want Nova to inform me thru RPC call, RabbitMQ and so on16:14
mriedemgoodygum: check the openstack docs16:15
*** heyongli has joined #openstack-nova16:15
mriedemthis is not a support channel16:15
*** haomaiwa_ has joined #openstack-nova16:15
bauzasmriedem: I can count 2 update_or_create calls with u'instance_uuid': u'2c9cecc1-c3db-4057-81bd-98e488c45ac2'16:15
goodygummhm, okay16:15
bauzasmriedem: http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz#_2015-11-03_21_44_58_273 and http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz#_2015-11-03_21_44_58_33216:15
bauzasso the question is, is the 2nd call to update_or_create doing either create or update ? :D16:16
* bauzas looking at the code16:16
mriedembauzas: when we delete the first instance (booted from volume), there is only 1 bdm that's terminated http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cpu.txt.gz#_2015-11-03_21_45_16_52616:17
bauzasmriedem: ah-ha16:18
pumaranikarwhile snapshoting an instance, if compute service restarts, snapshot continues to stay as queued/saving. Should we move it to error?16:20
bauzasmriedem: honesly, I feel we need more DNM logs16:21
*** krtaylor has quit IRC16:21
bauzasbecause the DB API checks if the device_name is set for updating the row16:21
mriedembauzas: https://www.diffchecker.com/gablzhqt16:21
mriedemthat's the diff between those bdm_update_or_create_at_top calls16:21
*** gonzalo2kx has joined #openstack-nova16:22
mriedemthe latter is probably from when the nova.virt.block_device object does it's save16:22
bauzasmriedem: I'll need to drop off for a bit - family time y'know16:23
mriedemsure16:23
bauzaswill continue to dig into that later this evening16:23
mriedemi'll probably add some more derbug logging16:23
*** heyongli has quit IRC16:24
bauzasmriedem: I was just about to say that we need to make sure we only create one BDM object when calling db.bdm_update_or_create16:24
bauzasgiven the ID is the device_name ://16:25
mriedemyeah, that's what alaski was pointing out yesterday16:25
bauzasthat's unfortunate we don't have an uuid...16:25
mriedembut the issue was knowing if we needed to create or update16:25
*** heyongli has joined #openstack-nova16:25
bauzasreally need to head off, ttyl16:25
mriedemlater16:26
edleafemriedem: btw, diffchecker looks great! Wish I had known about it earlier16:26
*** ZZelle has joined #openstack-nova16:26
*** mtanino has joined #openstack-nova16:26
mriedemi will take full credit for googling for it16:26
*** jdurgin has joined #openstack-nova16:27
*** hemnafk is now known as hemna16:27
*** mdrabe has quit IRC16:28
mriedemhmm: u'connection_info': u'null'16:29
mriedemconnection_info_string = jsonutils.dumps(16:29
mriedem                self.get('connection_info'))16:29
mriedem            if connection_info_string != self._bdm_obj.connection_info:16:29
mriedem                self._bdm_obj.connection_info = connection_info_string16:29
*** garyk has quit IRC16:29
mriedemtriggers an update to the bdm object16:29
mriedemb/c we go from None to 'null' due to json16:29
*** Kevin_Zheng has quit IRC16:32
*** dustins has quit IRC16:32
*** electrocucaracha has joined #openstack-nova16:34
*** krtaylor has joined #openstack-nova16:34
*** heyongli has quit IRC16:34
*** garyk has joined #openstack-nova16:35
*** vilobhmm11 has joined #openstack-nova16:35
*** heyongli has joined #openstack-nova16:35
*** vilobhmm11 has quit IRC16:36
*** tjones has joined #openstack-nova16:36
*** n0ano has quit IRC16:36
smcginnisjohnthetubaguy: Hey, question for you. The nova spec review etherpad was pointed out to me as something that might be useful for Cinder.16:36
smcginnisjohnthetubaguy: https://etherpad.openstack.org/p/mitaka-nova-spec-review-tracking16:36
smcginnisjohnthetubaguy: Wondering about the review stats link in there.16:37
smcginnisIs that someone's customer script?16:37
smcginniss/customer/custom/16:37
*** unicell has joined #openstack-nova16:38
*** unicell1 has quit IRC16:40
dansmithsmcginnis: that's his script16:41
smcginnisdansmith: Ah, OK. Thanks!16:41
dansmithsmcginnis: it's based on the reviewstats code, I think16:42
dansmithsmcginnis: http://russellbryant.net/openstack-stats/cinder-reviewers-30.txt16:42
smcginnisdansmith: Oh, the one from infra?16:42
dansmithsmcginnis: see the bottom16:42
smcginnisdansmith: Got it. Thank you.16:43
*** mdrabe has joined #openstack-nova16:44
*** drankis has quit IRC16:44
*** thorst has quit IRC16:44
*** achanda has joined #openstack-nova16:44
*** heyongli has quit IRC16:44
*** thorst has joined #openstack-nova16:45
*** mgoddard__ has quit IRC16:45
*** mgoddard has joined #openstack-nova16:45
*** heyongli has joined #openstack-nova16:46
*** r-daneel has joined #openstack-nova16:51
*** thorst_ has joined #openstack-nova16:51
*** mrkz has quit IRC16:52
*** gszasz has quit IRC16:53
*** mrkz has joined #openstack-nova16:54
*** thorst has quit IRC16:54
*** tongli has quit IRC16:55
*** daemontool has joined #openstack-nova16:55
*** heyongli has quit IRC16:55
*** heyongli has joined #openstack-nova16:56
*** mgoddard has quit IRC16:56
*** su_zhang has joined #openstack-nova16:57
*** tongli has joined #openstack-nova16:58
*** drankis has joined #openstack-nova16:59
*** mgoddard has joined #openstack-nova17:00
*** blackjack1 has joined #openstack-nova17:00
*** haomaiwa_ has quit IRC17:01
*** ihrachys has quit IRC17:01
*** haomaiwang has joined #openstack-nova17:01
blackjack1Hi guys. I want to set up nova rabbitmq notifications with no success. I set up nova.conf like in this answer: https://ask.openstack.org/en/question/2224/novaquantum-notifications-in-rabbitmq/ but don't receive any message on the channel. If I change my listener's rabbitmq routing key to "#" (catch-all) I get some service messages but not the one I want17:03
*** pumaranikar has quit IRC17:03
blackjack1release version is kilo17:03
johnthetubaguysmcginnis: yeah, what dansmith said, its based on that code17:03
tjonesblackjack1: i just did this yesterday using this example http://alesnosek.com/blog/2015/05/25/openstack-nova-notifications-subscriber17:04
*** pratikma_ has joined #openstack-nova17:04
johnthetubaguysmcginnis: I just upload the result to a swift container, see: http://reviews.johnthetubaguy.com it links to the code17:04
johnthetubaguysmcginnis: ah, cool, I should read scrollback better, I see you got that now17:05
blackjack1tjones: thanks, I'll try it now17:05
*** heyongli has quit IRC17:05
*** jlanoux has quit IRC17:06
*** heyongli has joined #openstack-nova17:06
*** pratikmallya has quit IRC17:07
*** salv-orlando has quit IRC17:08
*** jistr has quit IRC17:08
smcginnisjohnthetubaguy: Thanks!17:08
*** salv-orlando has joined #openstack-nova17:09
johnthetubaguysmcginnis: that branch is a hacked up mess right now, let me know if thats useful, and I should go back and tidy it up17:09
smcginnisjohnthetubaguy: Great. On my list now to look in to. I'll let you know if I have any feedback.17:10
*** su_zhang has quit IRC17:10
*** pratikmallya has joined #openstack-nova17:11
*** pratikma_ has quit IRC17:11
*** pratikma_ has joined #openstack-nova17:11
*** otter768 has joined #openstack-nova17:13
*** electrocucaracha has quit IRC17:14
blackjack1tjones: thanks, it helped!17:14
blackjack1So as I see there is no notification generated when new flavor was created/updated, is that right?17:14
*** nkrinner has quit IRC17:14
*** heyongli has quit IRC17:15
*** pratikmallya has quit IRC17:16
*** heyongli has joined #openstack-nova17:16
*** rlrossit has quit IRC17:17
*** otter768 has quit IRC17:17
*** derekh has quit IRC17:18
tjonesi had it set to only notify on vm_state change.  you can get more by switching it to vm_and_task_state.  not sure if you will get anything with a flavor change though17:18
*** sayali has quit IRC17:19
johnthetubaguyblackjack1: I don't think we have any notifications for those, its mostly focused around the instance operations right now17:19
*** rlrossit has joined #openstack-nova17:20
blackjack1johnthetubaguy: understood, thanks17:20
*** sayali has joined #openstack-nova17:20
johnthetubaguyblackjack1: if its useful, it might be a good add, but we are in the process of adding a new notification versioning system, gibi is setting up a notification subteam, if you are interested17:20
*** markmc has quit IRC17:22
sfinucanjohnthetubaguy: Would it be possible to take a look at this spec? I think (think :)) it should be a trivial re-approval https://review.openstack.org/#/c/241355/17:22
sfinucanthe original Liberty spec is here https://review.openstack.org/#/c/194221/17:23
sfinucanI'd ask Daniel Berrangealso, but he doesn't seem to be available17:23
danpbsfinucan: i'm here17:25
danpbi agree, we could just trivial re-approve that  thread's pinning one IMHO17:25
sfinucandanpb: I didn't know your IRC handle, apparently17:25
sfinucanwhoops17:25
*** heyongli has quit IRC17:25
*** r-daneel has quit IRC17:26
*** heyongli has joined #openstack-nova17:27
johnthetubaguysfinucan: danpb: seems like a trivial re-approval to me, not checked the pending ones today17:27
*** e0ne has quit IRC17:27
*** r-daneel has joined #openstack-nova17:27
*** y_sawai has joined #openstack-nova17:28
*** davideagnello has joined #openstack-nova17:28
*** vilobhmm11 has joined #openstack-nova17:30
*** garyk has quit IRC17:31
*** dustins has joined #openstack-nova17:32
*** davideagnello has quit IRC17:33
sfinucandanpb: johnthetubaguy: Thank you. I'll submit together the "clarification" patch later today17:33
*** smurke has quit IRC17:33
*** davideagnello has joined #openstack-nova17:34
*** heyongli has quit IRC17:36
*** daemontool has quit IRC17:36
jrollsfinucan: don't feel bad, in tokyo I asked danpb in person if daniel berrange was going to show up :D17:36
dansmiththat was awesome17:37
*** heyongli has joined #openstack-nova17:37
mriedemsdague: are you aware of any bugs for network dealloc failures in the large ops job? like this http://logs.openstack.org/97/241397/1/check/gate-tempest-dsvm-large-ops/be8ca35/logs/screen-n-cpu-1.txt.gz#_2015-11-04_14_46_57_63917:37
*** rk4n has quit IRC17:37
mriedemjroll: that could go worse17:37
jrollheh17:38
mriedemsdague: nvm, we already have 2 marked as invalid17:39
*** pratikma_ has quit IRC17:41
danpbjroll: next time we can have name badges where the font is actually large enough to read :-)17:42
* danpb curses who ever decided to use minute sized font for surnames17:42
jrolldanpb: I didn't even look, so not sure if that's helpful :P17:42
*** romainh has quit IRC17:43
*** nelsnelson has quit IRC17:43
sfinucanquick question - does Nova have any support for load balancing of instances17:46
mriedemno17:46
*** heyongli has quit IRC17:46
mriedemthere is a spec17:46
sfinucanOK, and is it on anyone's (public) roadmap yet17:46
mriedempretty sure it's not going to happen17:46
sfinucanAh17:46
*** heyongli has joined #openstack-nova17:47
sfinucanIs the spec approved? Any pointers?17:48
sfinucan*pointers to the spec17:48
mriedemtrying to find17:48
mriedemmight have been ML17:48
sfinucanA college buddy is considering it as a thesis project. Seems ambitious17:48
sfinucanand like something someone might already be working on17:48
*** tonytan4ever has quit IRC17:48
*** nelsnelson has joined #openstack-nova17:48
mriedemthere are projects that have already done it outside nova17:49
mriedemi think this new 'watcher' project is doing something like that17:49
mriedemibm platform resource scheduler (closed source) does some auto-migrate/evac stuff depending on 'policies'17:49
mriedemthere are projects that have done this17:49
tpeopleswatcher is doing resource optimization, but load balancing is probably not the best term for it17:49
mriedemi want to say some cisco guys had a thing in the ML at one point talking about similar things17:50
sfinucanI thought as much. It seems like a rather obvious feature for some deployments17:50
sfinucanHmm, OK that's his job to find that mail so17:51
mriedemi can't find anything, i thought i saw a spec at one point though17:51
tpeoplesmriedem: we're trying to contribute back what we've done with prs to the community through watcher17:51
tpeoplessfinucan: https://wiki.openstack.org/wiki/Watcher17:51
mriedemtpeoples: i always forget you're one of *those* people17:52
tpeoples:) :|17:52
mriedembut yeah, the answer on stuff like this is generally the same, we want less orchestratoin in nova, not more17:52
*** tojuvone has quit IRC17:53
sfinucanmriedem: tpeoples: That's great info. I'll pass on it on and tell him to carry on searching17:54
*** su_zhang has joined #openstack-nova17:54
sfinucantpeoples: I remember getting mails about watcher during the summit last week. Now I have reason to go read them :)17:54
*** tjones has quit IRC17:54
* mriedem loads up on fun size candy bars and moves rooms17:55
*** heyongli has quit IRC17:56
*** nelsnels_ has joined #openstack-nova17:57
*** heyongli has joined #openstack-nova17:57
*** ctrath has quit IRC17:58
*** nelsnelson has quit IRC18:00
*** mriedem has quit IRC18:00
*** haomaiwang has quit IRC18:01
*** haomaiwa_ has joined #openstack-nova18:01
*** unicell1 has joined #openstack-nova18:03
*** klkumar has quit IRC18:03
*** unicell has quit IRC18:03
*** danpb has quit IRC18:04
*** aix has quit IRC18:05
*** heyongli has quit IRC18:07
*** heyongli has joined #openstack-nova18:08
*** browne has joined #openstack-nova18:08
*** mriedem has joined #openstack-nova18:11
*** dave-mccowan has joined #openstack-nova18:16
*** sahid has joined #openstack-nova18:16
*** heyongli has quit IRC18:17
*** e0ne has joined #openstack-nova18:17
*** heyongli has joined #openstack-nova18:18
*** ctrath has joined #openstack-nova18:20
*** jerrygb has quit IRC18:21
*** pratikmallya has joined #openstack-nova18:25
*** heyongli has quit IRC18:27
*** heyongli has joined #openstack-nova18:28
*** pumaranikar has joined #openstack-nova18:29
*** smurke has joined #openstack-nova18:32
*** rk4n has joined #openstack-nova18:33
*** heyongli has quit IRC18:37
mriedemconfirmed that in this cells job failure we're creating 2 volume snapshots18:38
*** heyongli has joined #openstack-nova18:38
*** rlrossit has quit IRC18:45
mriedemso cells.messaing.bdm_update_or_create_at_top must be doing the bdm creates twice, when it should be doing an update the 2nd time18:46
*** ctrath has quit IRC18:46
*** ccarmack has quit IRC18:46
*** dvlwrk_ has joined #openstack-nova18:47
*** heyongli has quit IRC18:48
*** subscope has quit IRC18:48
*** heyongli has joined #openstack-nova18:49
johnthetubaguymriedem: ouch thats messy, updates have a habbit of getting out of order up there, so two save calls might be enough18:50
mriedemand the nova.virt.block_device objects that wrap bdms have a save on update mechanism18:51
*** ctrath has joined #openstack-nova18:51
*** rlrossit has joined #openstack-nova18:51
mriedemwhich will fire off successive updates to cells18:51
mriedemso if we don't have a unique constraint on the bdm table,18:51
johnthetubaguyoh, yeah, so we call save 1 million times, I remember looking at that at some point... curious18:52
*** rk4n has quit IRC18:52
mriedemwhy can't we enforce some unique constraint type logic in cells.messaging.bdm_update_or_create_at_top?18:52
mriedemlike it does when doing an update18:52
mriedemwe rely on this hacky create parameter being None/True/False18:52
*** Marga_ has joined #openstack-nova18:52
johnthetubaguyI think we should be able to... but I don't remember the context now18:52
johnthetubaguylike doing compare and swap style update, based on the object changes reported?18:53
mriedemyeah18:53
johnthetubaguymaybe we need to record the original values, not 100% sure if we have those?18:53
mriedemwe get the bdms from the db, and compare those to what's passed in18:53
mriedemif there are no bdms in the db yet, it's an insert18:53
*** alex_klimov has joined #openstack-nova18:54
mriedemif there are bdms, we check them against some keys and do an update if there is a match, else insert18:54
mriedemi'd think instance_uuid/volume_id/device_name would do a match ok18:54
mriedemvolume_id/snapshot_id/image_id18:54
johnthetubaguyso we did run a custom DB later on the nova-cells works, not sure if we got that removed yet, but alaski would know, we might be holding a patch in there for this18:54
*** Marga_ has quit IRC18:55
johnthetubaguyis device_name and instance_uuid not enough?18:55
mriedem"run a custom DB later on the nova-cells works"18:55
mriedemi'm not sure what that means18:55
*** Marga_ has joined #openstack-nova18:55
johnthetubaguywe patch out the DB api with a special one comstud wrote18:55
mriedemthat might be enough yeah, it's checking volume_id today too18:55
mriedemsee https://review.openstack.org/#/c/241390/18:56
johnthetubaguybeing trying to drop that for ages18:56
mriedemmaybe that's not needed18:56
*** ccarmack has joined #openstack-nova18:56
vilobhmm11bauzas : ping18:56
kashyap"If you would have asked your question, my response would have been your answer" :-)18:57
alaskijohnthetubaguy: we removed it briefly, but had to turn it back on for the db_update_and_get_original method to be fast enough to handle cells updates18:57
johnthetubaguymriedem: crap sorry, I really need to go an get some food and run out...18:57
johnthetubaguyalaski: ah, interesting, thanks18:58
mriedemalaski: are you guys talking about rax internal stuff?18:58
*** heyongli has quit IRC18:58
alaskimriedem: yeah, the mysql db api18:58
mriedemwhy do i have to always qualify my questions about cells/lxc with 'are you talking about rax internal patches?"18:58
mriedemah18:58
johnthetubaguymriedem: yeah, wondering if we fixed it in that sideways code18:58
johnthetubaguymriedem: you and me both, getting there slowly18:59
*** heyongli has joined #openstack-nova18:59
mriedemalaski: so in here https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L116718:59
mriedemwhen create is None,18:59
mriedemcouldn't we get the list of bdms from the db for the instance and then check for a match on device_name to determine if we do an insert or update?18:59
* johnthetubaguy bravely runs away to get some food18:59
mriedemi assume https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L1186 is here in case device_name is empty, which is apparently a thing19:00
alaskimriedem: that's essentially what the db method does19:00
mriedemit checks device_name,19:00
mriedemnot instance_uuid19:01
*** haomaiwa_ has quit IRC19:01
mriedem            result = query.filter_by(instance_uuid=values['instance_uuid'],19:01
mriedem                                     device_name=values['device_name']).first()19:01
mriedemf*19:01
*** haomaiwang has joined #openstack-nova19:01
mriedemhmmm19:01
mriedemso if not device_name,19:01
alaskiit checks it only if device_name, yeah19:01
mriedemcheck on volume_id/snapshot_id/image_id?19:01
openstackgerritRaildo Mascena de Sousa Filho proposed openstack/nova-specs: Moving Nested Quota Driver to Mitaka  https://review.openstack.org/20996919:02
raildojohnthetubaguy: ping, added the API example ^19:02
mriedemif i can get my unique constraint change to fail then i guess we'd see19:02
alaskimriedem: device_name was the same in the duplicate bdms right?19:03
dansmithmriedem: are you proposing a new constraint on the bdms stuff?19:03
*** sahid has quit IRC19:03
*** drankis has quit IRC19:03
mriedemalaski: it was https://review.openstack.org/#/c/241397/1/nova/db/sqlalchemy/migrate_repo/versions/313_add_bdm_unique_constraint.py19:03
mriedemoh, sec19:03
dansmithah, I see19:04
mriedemalaski: yeah it's /dev/vda in both bdms19:05
mriedemdansmith: just trying to trigger a failure to see where we're coming in from19:05
*** rk4n has joined #openstack-nova19:05
dansmithokay19:05
alaskiso the db method should have correctly done an update since device name matched19:06
mriedemi'm assuming that's after we already have the duplicates though19:07
mriedemwe probably create the duplicate bdms when device_name isn't set19:07
mriedemwhich is a thing that the libvirt driver code does now too19:07
mriedemsince liberty19:07
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L723219:08
mriedembdm.device_name = None19:08
mriedemblock_device_info = driver.get_block_device_info(instance,                                                         block_device_mapping)19:08
mriedem^ does the bdm.save() somewhere19:08
*** heyongli has quit IRC19:08
mriedemcells gets 2 bdms with no device_name and create=False19:09
mriedem*create=None19:09
mriedemand then inserts 219:09
alaskiwe try to prevent that with http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/block_device.py#n14119:09
alaskithough it's possible that it's happening via another path19:09
*** heyongli has joined #openstack-nova19:09
dansmiththis would probably be easier to debug if we had object tracing, which is something I've wanted for a while19:11
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/objects/block_device.py#n186 ?19:11
mriedemi assume it has to be coming from bdm.save() b/c that's what the nova.virt.block_device bdm wrapper objects do - update on save19:11
*** emagana_ has joined #openstack-nova19:13
*** emagana has quit IRC19:13
*** otter768 has joined #openstack-nova19:14
* bauzas raises hand19:14
mriedemif you search for the original volume id 35909d21-81b8-4fda-82b6-d3d75be61238 in http://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz you'll see we call db.block_device_mapping_update_or_create twice, but device_name is set in the bdm values each time19:15
bauzasmriedem: so it seems you agree with me about having 2 inserts ?19:15
mriedemwhich implies we're doing an update19:15
mriedembauzas: yeah, i added notes to the bug report, there are definitely 2 volume snapshots being created, i see them in the c-api logs19:15
mriedemfor the same volume19:15
mriedemand a single delete request on the vol snapshot, which comes from tempest teardown19:16
alaskimriedem: so I wanted to enhance the check to only send the save() if device_name had been changed from '' to something.  But I couldn't find a way to get that information from the object changelist19:16
bauzasoh good point to check the cinder logs19:16
*** LukeHinds has quit IRC19:16
mriedemalaski: in the bdm object or in the nova.virt.block_device code?19:16
alaskidansmith: that's a question for you, is there a way to tell if a field has just been set, vs modified19:16
alaskimriedem: object19:16
mriedemobj_what_changed? thought that was a thing19:17
bauzas+119:17
dansmithalaski: you mean if it is newly set vs. changed?19:17
alaskidansmith: yep19:17
dansmithalaski: not through the normal objects api, no. Instance keeps some extra tracking, but bdm does not19:18
dansmithI'm not sure why it matters though19:18
*** heyongli has quit IRC19:18
mriedemobj_get_changes() ?19:18
dansmithno19:18
dansmiththat won't distinguish19:18
*** otter768 has quit IRC19:19
mriedemblast19:19
dansmithyou'd have to pull the DB one to know. Usually we handle this kind of thing deep in the db api, where we've already pulled the original, or where we can say "update if device_name != table.device_name" or something19:19
*** heyongli has joined #openstack-nova19:19
alaskidansmith: it would allow us to send create=True/False vs the None we use now.  If device_name has just been set then create, if it's changed update19:20
*** jerrygb has joined #openstack-nova19:20
mriedemi guess that goes back to the db api call we have19:20
dansmithalaski: it's a pretty obscure case, so I don't think we need to build this in, but we can certainly do this in the BDM object for this field19:20
dansmithalaski: assuming you don't need to know across an RPC call19:21
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n394319:21
*** tonytan4ever has joined #openstack-nova19:21
alaskidansmith: I don't think we do19:21
alaskithe other thing to consider is if device_name can't change after it's set we can just assume an update in that case19:21
dansmithalaski: I can work up a patch to bdm to track this if you want19:21
alaskiI just wasn't sure on that19:22
dansmithalaski: ah, you can make it read-only and it will only let you set it once19:22
bauzasjust to be clear, we are having like a UK for device_name ?19:22
dansmithif you think that will help19:22
mriedemalaski: i think it can change19:22
*** spandhe has joined #openstack-nova19:22
bauzasI mean an UC like (instance, device_name) right?19:23
alaskidansmith: well, I'm not sure if we support the case where it changes19:23
mriedemi'd have to verify, but if the compute api creates the bdm and then the libvirt driver nulls it out, that's a change19:23
mriedembauzas: i have a patch that does that but it's DNM for testing19:23
mriedemto find an explosion19:23
alaskidansmith: if you get around to it go for it.  I can pick it up as well starting tomorrow19:23
mriedemof course i never know which bdm class i'm dealing with19:24
alaskidansmith: whatever works for you19:24
dansmithalaski: I can do it fairly quick.. mriedem you know what to do with it once I write that?19:24
alaskibauzas: I don't like having a UC on device_name because it's not static.  But I'm not sure what else we would use right now.19:24
alaskiI would love to look at adding uuids for bdms, but that might be too much19:25
dansmithalaski: we can't solve that with an update where clause?19:25
bauzasalaski: +1 for uuids19:25
mriedemdansmith: yeah19:25
bauzasalaski: that's something I thought this EU afternoon19:25
bauzasbut agreed as it's a big change19:26
*** bradjones has quit IRC19:26
alaskidansmith: hmm, not sure.  I need to consider that19:26
*** vishwana_ has quit IRC19:27
*** electrocucaracha has joined #openstack-nova19:28
*** heyongli has quit IRC19:29
alaskiI'm not sure that will work because we need to insert or update based on the where clause19:29
*** heyongli has joined #openstack-nova19:30
dansmithalaski: well, you update where and if that fails, insert, inside a transaction?19:30
dansmithI guess two transactions can still race without the UC19:30
*** rlrossit has quit IRC19:31
alaskiyeah.  I really think a UC is necessary here19:31
*** rlrossit has joined #openstack-nova19:32
dansmithso, adding a UC to a live DB is going to lock that table, right?19:32
alaskilooks like it19:35
openstackgerritDan Smith proposed openstack/nova: DNM: Add bdm_field_is_new() to BlockDeviceMapping  https://review.openstack.org/24173719:35
dansmiththat will suck :(19:35
dansmithmriedem: ^19:35
alaskiyeah19:35
*** diogogmt has joined #openstack-nova19:36
alaskiwe could look at creating the bdm in one place, and then always update after19:36
alaskicreate it early in the boot process19:36
dansmithI think that probably has some unfortunate side effects19:37
*** aysyd has quit IRC19:37
*** gjayavelu has joined #openstack-nova19:38
dansmithwe could create a new table with the constraint and hot migrate things to that table, but we probably need to evaluate the pain vs. reward for that19:38
dansmithI really don't want to regress our live upgrade abilities, but we should be pragmatic19:38
bauzasso, instead of that, could we think having only one way to insert into the table ?19:38
dansmithif people can choose to apply our migrations early, during a maintenance window, without having to touch any other code, maybe it's okay to require that level of impact in a migration, I dunno19:39
*** heyongli has quit IRC19:39
dansmithobviously solving this at a higher layer would be much nicer19:39
*** ctrath has quit IRC19:39
bauzaswell, that kind of migration for a cells v1 failure seems really overkill19:39
bauzasgiven cells v119:39
*** heyongli has joined #openstack-nova19:40
alaskiwell, the race exists outside of cells.  it's just very unlikely in that case19:40
bauzasthat's why I wonder why we shouldn't try to find a way to only have one way to call to insert - and then do like a transaction19:40
bauzasalaski: I don't get the conditionals for the race when it's not cells v119:41
alaskidansmith: a lock would also solve it, which is essentially what the UC gives us, but we would need a distributed lock19:41
bauzasoh man19:41
*** ctrath has joined #openstack-nova19:42
bauzasdon't say that too loud19:42
*** salv-orlando has quit IRC19:42
alaskibauzas: I'm not sure it would be possible to trigger it in the current code base, but create_or_update with no UC and no lock makes it possible to end up with two creates19:42
*** salv-orlando has joined #openstack-nova19:42
cfriesen_anyone know why nova doesn't have quotas for local/ephemeral storage?  is it just assumed to be to plentiful to ration?19:43
bauzasright, just considering what could be the 2 different services calling it19:43
alaskibauzas: I thought everyone agreed on their goodness at the summit :)19:43
dansmithalaski: ssshhh19:43
bauzasalaski: well19:43
dansmithalaski: and we're doing this too early to serialize ourselves at the compute node?19:43
bauzasalaski: it's.... complicated19:43
anteayawould someone care to add the nova mid-cycle details: http://lists.openstack.org/pipermail/openstack-dev/2015-October/078054.html to the sprints wikipage: https://wiki.openstack.org/wiki/Sprints please?19:44
mriedemnot it19:44
mmmporki can do it :)19:45
alaskidansmith: I htink we could serialize the sending of the update/create message, but in this case the processing happens on the api cell service19:45
patrickeasthey so i'm seeing a problem with test_create_ebs_image_and_check_boot in gate-tempest-dsvm-full-ceph on a stable/kilo review19:45
dansmithalaski: right, right19:45
patrickeaston https://review.openstack.org/#/c/229152/ recent runs are failing the test http://logs.openstack.org/52/229152/11/check/gate-tempest-dsvm-full-ceph/11bddbf/console.html#_2015-11-04_19_20_07_22619:45
bauzasheh19:46
*** su_zhang has quit IRC19:46
*** jichen has joined #openstack-nova19:46
patrickeastolder ones where it was passing it looks like the test was being skipped http://logs.openstack.org/52/229152/8/check/gate-tempest-dsvm-full-ceph/e74fd3b/console.html#_2015-11-02_21_51_13_92819:46
*** su_zhang has joined #openstack-nova19:46
mriedempatrickeast: the test was re-enabld in the last 2 days19:46
mriedemit's killing the cells job for reasons that we're discussing above19:46
patrickeastmriedem: :D that would explain the change19:46
* bauzas actually tempted to ask to skip again this test until we figure out a clear solution path19:46
mriedempatrickeast: ceph failure is something else19:46
patrickeastderp19:46
mmmporkanteaya: i don't see a section for mitaka sprints on that page19:46
* patrickeast should have read the scrollback first19:47
anteayayou will have to add it19:47
*** markmc has joined #openstack-nova19:47
mriedempatrickeast: don't bother19:47
bauzasmriedem: patrickeast: the ceph failure seems a bit different19:47
anteayafollow the examples of the prior sprints19:47
bauzasat least the rootcause19:47
anteayacopy paste should work and then use the review button to check you work before you publish19:47
mmmporkanteaya: maybe next time you ask people to add their info, you could make it a bit easier by making it easier for us? :)19:47
*** sfinucan has quit IRC19:48
*** smurke has quit IRC19:48
*** achanda has quit IRC19:49
*** heyongli has quit IRC19:49
*** heyongli has joined #openstack-nova19:50
*** achanda has joined #openstack-nova19:52
*** sfinucan has joined #openstack-nova19:53
openstackgerritMatt Riedemann proposed openstack/nova: Add logging to snapshot_volume_backed method  https://review.openstack.org/24173919:54
mriedemi can update the wiki if needed19:54
mriedemcopy/paste liberty table, replace with nova mitaka info from ML19:54
*** smurke has joined #openstack-nova19:55
mriedemgather karma points from anteaya19:55
anteayamriedem: you got 'em19:55
* anteaya knocks the mickey mouse ears off mriedem's head19:55
mmmporki'm working on it, it's just that the request was lacking some information19:55
mmmporkie, we needed to do more than just add our info to the wiki19:56
*** sneti has quit IRC19:57
*** heyongli has quit IRC19:59
*** baoli_ has quit IRC20:00
*** heyongli has joined #openstack-nova20:00
*** sneti has joined #openstack-nova20:00
*** haomaiwang has quit IRC20:01
*** haomaiwang has joined #openstack-nova20:01
sdaguemmmpork: probably worth stubbing out a Sprints/NovaMitakaSprint page while you are at it20:01
mmmporksdague: thanks I was just looking for it ;)20:02
*** su_zhang has quit IRC20:04
*** su_zhang has joined #openstack-nova20:06
openstackgerritMatt Riedemann proposed openstack/nova: cells: create bdm at top if device_name is set for first time in save()  https://review.openstack.org/24174220:07
mriedemalaski: ^ is that what you were looking for? based on dansmith's change20:07
*** smurke has quit IRC20:08
*** smurke has joined #openstack-nova20:08
*** heyongli has quit IRC20:09
*** su_zhang has quit IRC20:09
*** heyongli has joined #openstack-nova20:10
*** su_zhang has joined #openstack-nova20:11
*** smurke has quit IRC20:11
*** smurke has joined #openstack-nova20:12
mriedemalright, i need to take a break from this cells thing for awhile - time to review some more specs!20:12
*** ZZelle has quit IRC20:14
bauzasmriedem: shouldn't we consider skipping that test until we figure out a good way to fix that?20:15
*** gonzalo2kx has quit IRC20:15
mriedemumm20:15
mriedemwell20:15
bauzasmriedem: http://goo.gl/xGnRW620:15
*** smurke has quit IRC20:16
mriedemi sort of feel like pulling an old school leave it broken until people step up to help fix it20:16
mriedemit's definitely not like a top gate blocker20:16
*** smurke has joined #openstack-nova20:16
mriedembut it's painful enough that people should be helping out to debug20:16
bauzaswell, it's hard to debug because of $bdm and $cells20:17
mriedemi know,20:17
mriedembut that's where the fun is!20:17
bauzasit requires some knowledge that a very few have20:17
* mriedem laughs maniacally20:17
mmmporkanteaya: updated the wiki per your request20:17
mmmporksdague: stub page created20:17
mriedembauzas: we have a few changes up for debug help, we can monitor those and recheck as needed20:18
mriedemi still haven't seen the UC patch fail on cells20:18
bauzasmriedem: sure, it's a good learning path - hence me continuing digging - but the benefits are not huge20:18
sdaguemmmpork: thanks20:18
mriedembauzas: i would recommend sleep20:18
bauzas-ETOOEARLY20:18
mriedemi guess it's still early there20:18
mriedemyeah20:18
anteayammmpork: thank you20:19
mriedemi'm getting used to DST20:19
anteayamriedem: I'll still remove your mickey ears for you20:19
*** heyongli has quit IRC20:19
mriedemyou know i'd never wear those right20:19
mriedemthere were a lot of people though with them on that didn't have children20:19
sdaguemriedem: the best way to not get tripped up by DST20:19
mriedemwhich concerns me20:19
sdaguebe adjusting from JST at the same time20:19
mmmporksdague: i was just gonna say20:19
mmmporkgo to tokyo?20:20
mmmporkhahaha20:20
*** heyongli has joined #openstack-nova20:20
*** smurke has quit IRC20:20
bauzasno DST change for US yet, right?20:21
dansmithbauzas: yes20:21
*** rfolco has quit IRC20:22
bauzasack, because EU shifted one week before20:22
bauzasand I know we have like 3 weeks difference20:22
*** smurke has joined #openstack-nova20:23
*** angdraug has joined #openstack-nova20:23
*** su_zhang has quit IRC20:25
*** sfinucan has quit IRC20:25
*** sfinucan has joined #openstack-nova20:25
sdaguebauzas: RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU20:25
*** khomkrit has quit IRC20:26
sdagueit's just that the first of nov was the first sunday this year20:26
bauzasI see20:26
*** edtubill has joined #openstack-nova20:28
*** heyongli has quit IRC20:29
openstackgerritChris Friesen proposed openstack/nova-specs: Clarify the behaviour for the "require" thread policy  https://review.openstack.org/24175120:30
*** heyongli has joined #openstack-nova20:30
*** fawadkhaliq has joined #openstack-nova20:31
*** edtubill has quit IRC20:31
anteayamriedem: oh I picture you in mickey ears20:36
*** jamielennox|away is now known as jamielennox20:36
*** heyongli has quit IRC20:40
*** heyongli has joined #openstack-nova20:40
*** dave-mccowan has quit IRC20:43
*** edtubill has joined #openstack-nova20:44
cfriesen_I'm working on a bug where if we delete an instance while it's resizing we end up never calling self.vif_driver.unplug to unplug the network port. (https://bugs.launchpad.net/nova/+bug/1512907)  Who would be the right people to talk to?20:46
openstackLaunchpad bug 1512907 in OpenStack Compute (nova) "leak of vswitch port if delete an instance while resizing" [Undecided,New]20:46
mriedemcfriesen_: you're the point person on that one20:48
mriedemjust mark it low-hanging-fruit...20:48
mriedemthat's about the only way you can get anyone to look at nova bugs20:48
cfriesen_mriedem: :)20:48
*** edtubill has quit IRC20:49
*** edtubill has joined #openstack-nova20:49
cfriesen_mriedem: I'm considering just delaying the delete if a resize/migration is in progress until it gets to a vm_state of vm_states.RESIZED, at which point the deletion code can auto-confirm the resize/migration.20:49
*** heyongli has quit IRC20:50
*** rotbeard has quit IRC20:50
dansmithcfriesen_: we generally consider a delete operation to be valid at any point20:50
dansmithotherwise users get fairly mad20:50
sgordonarent you reliant on someone actually confirming the resize to get to that point20:50
sgordonoh nm20:50
*** heyongli has joined #openstack-nova20:51
cfriesen_dansmith: the problem is that if we do a delete after the new host is set but before we set vm_states.RESIZED, then nobody cleans up the resources on the source host.20:51
cfriesen_dansmith: or at least nobody cleans up the neutron ports20:51
*** aysyd has joined #openstack-nova20:52
*** huats has quit IRC20:52
vilobhmm11bauzas : can you please review this https://review.openstack.org/#/c/241016/20:52
dansmithcfriesen_: seems like a thing to fix, it would just be good to not solve it by blocking delete20:52
*** edtubill has quit IRC20:53
cfriesen_dansmith: I think git commit 18d6b5cc added an audit to clean up the instance files left by a similar case.20:55
mriedemsdague: i'm interested in your thoughts on this https://review.openstack.org/#/c/240271/20:55
*** raildo is now known as raildo-afk20:56
dansmithcfriesen_: yep20:56
cfriesen_dansmith: would it make sense to try to modify that to also clean up neutron ports?  Or would you prefer to get rid of that audit and clean everything up in the resize/migration code?  (Which I suspect might involve a new RPC call.)20:56
bauzasvilobhmm11: very slowly catching up my review backlog from the summit, but FWIW CC'd your change20:57
dansmithcfriesen_: seems like adding that (carefully) to the cleanup would be reasonable,20:58
dansmithcfriesen_: however these are different cases since the user sees the port residue and doesn't see the image residue20:58
dansmithso cleaning the images up later is not a problem20:58
dansmithhaving ports remain and then disappear minutes later may be confusing20:58
cfriesen_dansmith: true enough.  I'll poke around a bit more, see if I can come up with anything better.21:00
mriedemcan you check something when refreshing the network info cache?21:00
*** heyongli has quit IRC21:00
*** haomaiwang has quit IRC21:01
*** edtubill has joined #openstack-nova21:01
mriedemthe port has a host in it21:01
*** heyongli has joined #openstack-nova21:01
mriedemif port.host != CONF.host, unplug?21:01
mriedemwell, not that easy21:01
*** haomaiwa_ has joined #openstack-nova21:01
cfriesen_mriedem: I'm not really familiar with that code.21:01
mriedemi was thinking of how host is used here https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L184021:03
mriedemwhich is called when migration/resize finishes21:03
*** achanda has quit IRC21:03
*** edtubill has quit IRC21:04
*** e0ne has quit IRC21:06
vilobhmm11bauzas : np…jfyi , the agrregatespec filter seems broken and would lead to perf issues if this is not fixed…as this change allows to return immediately if extra_specs are empty21:06
*** yassine__ has quit IRC21:07
cfriesen_mriedem: I think what's missing is a call to virt.libvirt.driver.LibvirtDriver.unplug_vifs()  (at least when using libvirt).  So I'm not sure we can do anything from just in the neutron API.21:07
mriedemcfriesen_: yeah the neutron api code wouldn't be doing it21:07
mriedembut we refresh the network info cache in lots of places,21:08
mriedemwhich should have the port host in it21:08
mriedemand i was wondering if that could be used for some kind of logic in delete21:08
cfriesen_mriedem: normally this would be called from confirm_migration(), which is called by delete once the resize/migration gets far enough along21:08
cfriesen_I wonder if the delete code could just confirm the resize on the source host even if the migration hasn't reached the vm_states.RESIZED state21:10
*** READ10 has quit IRC21:10
*** heyongli has quit IRC21:10
mriedemso are you looking to delete the port?21:11
*** dave-mccowan has joined #openstack-nova21:11
*** heyongli has joined #openstack-nova21:11
dansmithdoesn't it matter if the neutron port has been updated for the new host?21:12
dansmitheither way, I'm not sure why we need to involve the source host21:12
dansmiththe destination should be able to cleanup everything, right?21:12
*** salv-orlando has quit IRC21:14
*** rk4n has quit IRC21:14
cfriesen_dansmith: we've got a custom vswitch running on each compute node.  the lack of cleanup on the source leaves a vswitch port allocated on the source host.21:14
mriedemi was thinking about this more from a generic orphaned ports standpoint,21:14
mriedemand wondering if neutron could send an event to cleanup21:14
dansmithcfriesen_: so you're talking about unplug, not port delete?21:14
cfriesen_dansmith: at least I think that's what is happening.  the networking details belong to someone else21:14
cfriesen_dansmith: yes, I believe so.21:14
*** salv-orlando has joined #openstack-nova21:14
dansmithcfriesen_: I officially care zero amount about your custom network stuff, of course :)21:15
*** otter768 has joined #openstack-nova21:15
cfriesen_dansmith: oh, sure21:15
cfriesen_:)21:15
cfriesen_but I think upstream will be susceptible to similar issues21:15
*** su_zhang has joined #openstack-nova21:15
mriedemcfriesen_: you might try to track down arosen to talk about orphaned port cleanup ideas, i know he and i used to talk about that a few times21:16
dansmithit'd be good if you could prove that before continuing down this path21:16
dansmithbecause if not, knowing why is probably your quickest path to success21:16
mriedemthose cleanup ideas usually invovled a periodic task though21:16
dansmithmriedem: those are port cleanup things, not local unplug things I think21:16
cfriesen_dansmith: fair enough.  I figured that the introduction of the cleanup audit for the instance files meant that cleanup wasn't happening. :)21:16
dansmithI think the image problem is sufficiently different21:17
dansmithobviously if we're susceptible to it with standard stuff, then we should fix it21:17
*** rowagner has quit IRC21:18
cfriesen_is there an easy way to check whether the network cleanup is being done?  I should be able to reproduce the race easily enough, just not sure what to check for with the standard vswitch.21:18
dansmithI think you'll have to ask neutron people that know about vswitch for that21:19
cfriesen_okay21:19
mriedemi was thinking more like neutron sending an network-vif-deleted event which then nova does an unplug, but at that point the instance would be deleted so it's too late21:19
dansmiththat you're detecting this problem through some non-standard interface to non-standard ovs makes me really curious21:20
*** otter768 has quit IRC21:20
*** pratikmallya has quit IRC21:20
dansmithmriedem: but we don't do that for the source host currently, only for the new one, AFAIK21:20
*** heyongli has quit IRC21:21
mriedemyeah, idk, seems like this would be hard to handle depending on where things are deleted in the migration operation21:21
mriedema periodic task is easy for cleanup - thigns are gone, cleanup what yo ucan21:21
*** heyongli has joined #openstack-nova21:21
cfriesen_dansmith: the output from our tool looks like this: http://paste.openstack.org/show/478015/    The "avp-guest" ones with a "link-state" of "down"  are ones that have been "leaked"  by my testing.  There's only one instance running with only one port.21:21
mriedemalso, don't delete things in the middle of a resize and expect everything to be hunky dory i guess21:21
dansmithcfriesen_: I can't click that link or I'll burst into flame21:22
mriedemoh cmon, it loaded in less than 10 seconds21:22
dansmithmriedem: I meant because it contains unclean things21:22
cfriesen_dansmith: got it. :)  joy of legal21:22
mriedem80085 like on a calculator?21:22
mriedemalternatively, cfriesen_ implements the task work so a delete can cancel an in-flight migration which does it's proper cleanup21:23
cfriesen_mriedem: not likely. :)21:24
*** rfolco has joined #openstack-nova21:26
*** e0ne has joined #openstack-nova21:26
mriedemso, this happened in my city today http://www.postbulletin.com/news/crime/broadway-avenue-businesses-closed-for-bomb/article_b1470825-9a4b-511a-b2e4-edf0274deb8c.html21:27
mriedem"The incident began about noon, when a woman called 911 to report a man driving erratically, yelling and masturbating near Second Street and Third Avenue Southwest. "21:27
*** devananda has left #openstack-nova21:27
*** pece has quit IRC21:27
*** devananda has joined #openstack-nova21:27
rlrossitI didn't see mriedem around noon................21:27
rlrossitmriedem: does tend to yell...21:28
dansmithhah21:28
*** rfolco has quit IRC21:29
rlrossitshould we switch up the meetup from bristol to rochester again?21:29
*** e0ne has quit IRC21:29
*** tjones has joined #openstack-nova21:29
*** jamielennox is now known as jamielennox|away21:30
*** baoli has joined #openstack-nova21:30
*** heyongli has quit IRC21:31
*** gonzalo2kx has joined #openstack-nova21:31
*** heyongli has joined #openstack-nova21:32
*** haomaiwa_ has quit IRC21:33
mriedemsfinucan: do you need to update the spec for this? https://review.openstack.org/#/c/202647/21:34
dansmithmriedem: that test patch passed cells21:34
dansmithmriedem: are we going to recheck it a bit?21:34
mriedemdansmith: yeah, lots of things are passing cells21:34
mriedemwhich is why i don't want to skip the test yet21:34
*** mwagner has quit IRC21:34
bauzasso I looked at the object21:34
bauzasand something is weird21:35
bauzashttps://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L132-L14821:35
bauzasgiven update_or_create = None21:35
sfinucanmriedem: I don't know, tbh21:35
bauzasor False rather21:36
mriedemsfinucan: well, i guess question is, should the enum be 'require' or 'prefer'21:36
mriedemsince they mean different thigns21:36
mriedemwe should probably be specific21:36
bauzasthen it will call db.bdm_create and then call the messaging.bdm_update_or_create, right?21:36
*** jerrygb has quit IRC21:36
sfinucanOh, I thought you were asking something else21:36
*** haomaiwang has joined #openstack-nova21:36
sfinucanI think I reworded that in the spec21:37
*** jamielennox|away is now known as jamielennox21:37
sfinucanmriedem: Yes, I did https://review.openstack.org/#/c/241355/1//COMMIT_MSG21:37
sfinucanThe purpose remains the same. The 'prefer' name didn't make sense, however21:37
*** jerrygb has joined #openstack-nova21:38
sfinucanIf you "prefer" something but then go reject all other options, you're not really "preferring" it :)21:38
mriedemsfinucan: ok i was looking at the liberty spec then, thanks21:38
mriedemi'd like the enum descriptions from the spec in the code where they are defined too, but that could be a separate change so you don't have to rebase the series21:39
sfinucanNo problem. Cheers for the feedback21:39
*** aix has joined #openstack-nova21:39
sfinucanYes, I need to address feedback edleafe to a similar end21:39
sfinucanActually, check in case a later patch addresses that particular issue21:40
*** e0ne has joined #openstack-nova21:40
*** baoli has quit IRC21:40
mriedembauzas: yeah, but i don't think we're getting called there with update_or_create=False21:40
sfinucanThe comments from edleafe concerned UTs. I'm going to address those in a follow up patch to avoid rebasing/gate issues21:40
bauzasmriedem: so I wonder why we have 2 messaging calls21:40
mriedembauzas: b/c of this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L128121:40
mriedembauzas: that'd be a question for alaski21:41
*** e0ne has quit IRC21:41
*** heyongli has quit IRC21:41
mriedemdifferent db's i guess?21:41
bauzasmriedem: what I wonder then is we would have a bdm.update_or_create followed by a bdm.savez21:41
bauzasmriedem: no21:41
bauzasmriedem: because it's _at_top()21:42
*** baoli has joined #openstack-nova21:42
bauzaswhich means it's the API DB21:42
*** heyongli has joined #openstack-nova21:42
bauzasnot the child d21:42
bauzasdb21:42
mriedemwell,21:42
mriedemif cell_type == 'compute' and db_bdm.get('device_name') is not None:21:42
mriedemso we don't do the messaging stuff to the cells api if we're already in the api db right?21:43
mriedemi just noticed this https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L11821:44
bauzasby cells api, you mean the compute cells api ?21:44
mriedemwhy don't we have that in save()?21:44
dansmithhmm21:45
dansmithmaybe cells is creating the BDM at the top via a cells message going up from the child?21:45
bauzaszactly21:46
bauzasthat's my guess21:46
*** baoli has quit IRC21:46
*** baoli has joined #openstack-nova21:46
bauzashttps://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L20421:46
bauzasmriedem: ^ to answer your question21:46
*** pratikmallya has joined #openstack-nova21:46
dansmithbauzas: well,21:47
dansmithbauzas: that only answers the question if it's creating it without the object21:47
dansmithbut it probably is21:47
*** Piet has quit IRC21:47
mriedembut bdm.save() can send the create up to the parent right?21:47
*** baoli has quit IRC21:47
mriedemb/c of https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L19321:48
dansmithin the child21:48
bauzasmriedem: that's called by the child IMHO21:48
bauzasmriedem: which then uses the messaging proxy to ask the parent to save it21:48
dansmithyeah, which is creating it with the raw DB method21:49
dansmithhttps://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L1156-L119421:49
*** baoli has joined #openstack-nova21:49
openstackgerritMark Doffman proposed openstack/nova: Cleanup rescue images on unrescue when using RBD.  https://review.openstack.org/24177721:50
bauzasthat looks like a way to sync the BDM update between the child cell DB and the API DB21:51
*** heyongli has quit IRC21:51
bauzasbecause it creates a row for the child DB before calling the messaging stuff to call the parent to also save it21:51
dansmithright21:51
dansmithso we don't create at the api with the object, we punt,21:51
dansmithcreate with the object in the child, and then call back to the parent to do this special create-at-top function21:52
bauzasyup21:52
dansmithjust a *tad circuitous21:52
*** heyongli has joined #openstack-nova21:52
*** aysyd has quit IRC21:52
bauzaswhich can be racy then21:53
*** baoli has quit IRC21:53
dansmithI wasn't paying attention to the early triage, so I'm not actually sure what is happening21:53
*** baoli has joined #openstack-nova21:53
bauzasgiven 2 calls for updating a BDM21:54
bauzassince it's a RPC payload21:54
bauzasand then going to the parent api cell, it could then be racy I guess21:54
*** edtubill has joined #openstack-nova21:54
dansmithwell, what really should be happening is the device name gets allocated at the child and then the parent create should be deterministic I think21:55
dansmithright?21:55
bauzasper the logs, the device names are set21:56
mriedemwell21:56
*** rdopiera has quit IRC21:56
bauzasbefore calling the messaging proxy21:56
mriedemfrom the logs we have21:56
mriedembut the values in the cells region logs for the bdm create or update do have the device_name in them yeah21:56
dansmithso what actually happens?21:56
bauzasso the problem is that the parent decides twice to create a new entry21:56
cfriesen_dansmith: mriedem: just thought of something...what about cleaning up PCI devices that were allocated to instances?  would we maybe leak those too if we delete during resize?21:57
dansmithcfriesen_: you can't migrate things with pci devices21:57
dansmithcurrently21:57
cfriesen_dansmith: ah....I think we've got someone proposing a fix for that.21:58
*** baoli has quit IRC21:59
*** baoli has joined #openstack-nova21:59
*** achanda has joined #openstack-nova22:00
*** haomaiwang has quit IRC22:01
*** su_zhang has quit IRC22:01
mriedemi cannot get https://review.openstack.org/#/c/241397/ to fail22:01
*** haomaiwang has joined #openstack-nova22:01
bauzasheh22:01
*** heyongli has quit IRC22:02
mriedemall of the changes under it can't pass the cells job though22:02
mriedemwtf22:02
bauzasso, given we have 2 messages for updating the api cell with 2 identical BDMs, it means that 2 calls are sent22:02
*** heyongli has joined #openstack-nova22:02
bauzasfrom the object, there are actually 2 places where you can fire a message to the parent cell : either .create_or_update() or save()22:03
bauzasso, it's either that we call twice in the code create_or_update() or that we call both the above22:04
*** baoli has quit IRC22:04
mriedemi know we call both22:04
*** baoli has joined #openstack-nova22:04
bauzaswhere? that's what I'm looking at now22:04
mriedemoh nvm, _create_block_device_mapping shouldn't happen for cells22:05
mriedemfrom what i can tell, that's the only thing that calls bdm.create_or_update22:05
sdaguemriedem: commented on the nova-manage logging review22:07
*** e0ne has joined #openstack-nova22:07
*** e0ne has quit IRC22:08
*** mdorman has joined #openstack-nova22:10
*** y_sawai has quit IRC22:11
*** heyongli has quit IRC22:12
*** su_zhang has joined #openstack-nova22:12
*** heyongli has joined #openstack-nova22:13
*** pratikmallya has quit IRC22:13
mdormanso i understand that this blueprint needs to have a spec written up in order to move forward:  https://blueprints.launchpad.net/nova/+spec/cells-v1-interface-events22:14
mdorman(i was the one that posted the original patch which led to this.)   i’m happy to work on writing up the spec, would i just do the normal nova-spec process, or is this a different situation since a blueprint already exists?22:15
dansmithmdorman: I thought we nak'd this?22:15
mdormantbh, unsure what the status is.  last i heard there was an ask for a spec22:15
*** baoli has quit IRC22:16
mdormanare you saying this is rejected?22:16
mriedemthe code change would require a bp and the bp would require a spec imo b/c it requires a cells + neutron job, which we don't have22:16
mriedemand which i started playing with before summit22:16
mdormanyeah i saw that other patch for that22:16
dansmithmdorman: I thought the string of deps was getting scary for it22:16
mriedemthere is concern about it detracting attention from cells v2 work22:17
mdormani guess what i really want to know is:  as an operator, what can i do to help with this?  if anything…22:17
mriedemmaybe it should be on the nova meeting agenda22:17
mriedembefore you write a spec22:17
mriedemor anyone22:17
mdormanyeah, i mean the thinking from the large deployers team is to just try to get some of these v1 patches into the tree so that we can stop carrying them locally.  understand that the major efforts are against v2 now, but we’re willing to help shepherd these v1 patches in, since we all need them.22:17
mdormanalright.22:17
mdormanwhat’s the proper way to get that as an agenda item?22:18
dansmithmdorman: and that's noble, it's just that we have said we're not doing any new features or even large bug fixes for v1, and especially if we don't have test coverage...22:18
dansmithmdorman: put it on the agenda wiki22:19
mdormandansmith:   yeah that’s fair, i understand that perspective.22:19
mriedemmdorman: just fit it in here https://wiki.openstack.org/wiki/Meetings/Nova22:19
*** sneti has quit IRC22:19
mriedemprobably under open discussion22:19
mdormankk will do22:20
*** baoli has joined #openstack-nova22:20
mriedembauzas: dansmith: so i'm assuming that if we're hitting bdm.save() twice, it's b/c of this as the 2nd call:22:20
mriedemhttp://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cpu.txt.gz#_2015-11-03_21_44_58_25222:20
mriedemthere is code in the compute manager where it sets the bdm.device_name and does bdm.save() for the root bdm,22:20
*** jwcroppe has quit IRC22:21
mdormanmriedem dansmith   thanks for guidance!22:21
mriedemand then calls the virt driver to set default device names, which for libvirt means nulling it out and saving22:21
mriedemthose would happen right after another22:21
*** andrewbogott has joined #openstack-nova22:22
*** heyongli has quit IRC22:22
bauzasmriedem: speaking of https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1690 ?22:22
mriedembauzas: yup22:23
mriedemand then that calls _default_device_names_for_instance which goes down into the virt driver which nulls it out22:23
*** heyongli has joined #openstack-nova22:23
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L723622:23
mriedemthen when that calls blockinfo.default_device_names...22:23
bauzasright22:23
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L46822:23
mriedemon that 2nd one from the libvirt driver, when we get to the db22:24
mriedemhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L394522:24
mriedemdevice_name isn't set so that evals to False and we do an insert22:24
bauzasyup22:24
bauzastwo saves22:25
*** lbelivea has quit IRC22:25
bauzasand the second one having a nullable device name22:25
*** yassine__ has joined #openstack-nova22:25
bauzashem, sec, no22:26
*** daemontool has joined #openstack-nova22:26
bauzashttp://logs.openstack.org/66/241366/1/check/gate-tempest-dsvm-cells/1d7551e/logs/screen-n-cell-region.txt.gz#_2015-11-03_21_44_58_332 was pointing out that device_name was also set for the 2nd call22:26
*** achanda has quit IRC22:26
mriedemhonestly i don't know why device_name is not null on that 2nd call22:28
bauzasI'm tempted to provide a DNM with a print_stack() :)22:29
mriedemblockinfo.get_info_from_bdm() might be re-setting the bdm.device_name before the 2nd bdm.save()22:30
*** achanda has joined #openstack-nova22:30
*** pumaranikar has quit IRC22:31
mriedemthe 2nd save is where device_type and disk_bus is set22:31
mriedemb/c of get_info_from_bdm22:31
*** pumaranikar has joined #openstack-nova22:31
bauzas++22:31
*** baoli has quit IRC22:31
bauzasokay, I feel we're quite finding the root problem22:32
*** lbelivea has joined #openstack-nova22:32
*** baoli has joined #openstack-nova22:32
*** rlrossit has left #openstack-nova22:32
*** heyongli has quit IRC22:32
*** mmedvede has quit IRC22:32
bauzasnow, I wonder if removing the first save() should be fine22:32
*** mmedvede has joined #openstack-nova22:33
*** heyongli has joined #openstack-nova22:33
bauzasbecause I'd prefer to find a way to avoid changing a scheme22:33
mriedemi'm not really sure where the first save is coming from22:34
mriedemif it's really this https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L169022:34
mriedemwe could use some debug logging in the conditions in _default_block_device_names22:36
mriedemanyway, i have to head out to pick up my kid22:36
*** pumaranikar has quit IRC22:36
*** smurke has quit IRC22:36
*** baoli has quit IRC22:37
*** mriedem has quit IRC22:37
*** baoli has joined #openstack-nova22:37
bauzaslaters22:39
andrewbogottI’m looking at the default nova policy.json and, wow, it sure has a lot of “” policies.22:40
andrewbogottI must not understand how policies work, because22:40
andrewbogott"compute:resize": "",22:40
andrewbogottlooks to me like any user can resize any instance in any project22:40
andrewbogottwhat am I missing?22:40
*** heyongli has quit IRC22:43
*** heyongli has joined #openstack-nova22:43
*** baoli has quit IRC22:46
*** mwagner has joined #openstack-nova22:48
*** baoli has joined #openstack-nova22:48
*** pratikmallya has joined #openstack-nova22:49
*** pratikma_ has joined #openstack-nova22:50
*** edtubill has quit IRC22:51
*** tonytan4ever has quit IRC22:51
*** heyongli has quit IRC22:53
*** heyongli has joined #openstack-nova22:54
*** pratikmallya has quit IRC22:55
*** stackdump has joined #openstack-nova22:55
*** ashyoung has joined #openstack-nova22:55
*** jichen has quit IRC22:59
*** baoli has quit IRC23:00
*** baoli has joined #openstack-nova23:00
*** haomaiwang has quit IRC23:01
*** haomaiwa_ has joined #openstack-nova23:01
*** notmorgan has joined #openstack-nova23:03
*** heyongli has quit IRC23:03
*** mdrabe has quit IRC23:03
*** pradk has quit IRC23:04
*** heyongli has joined #openstack-nova23:04
*** stackdump has quit IRC23:04
*** alex_klimov has quit IRC23:04
mgagneis there a reason for network_data.json being injected within this loop instead of with the others above? https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L481-L48323:05
*** yassine__ has quit IRC23:06
mgagneI tried to loosely backport the patch to kilo and when injection is done from within the loop, network_data.json doesn't appear in openstack/2015-10-15/ as expected. When moved outside the loop, everything is fine.23:07
*** baoli has quit IRC23:11
*** stackdump has joined #openstack-nova23:11
*** baoli has joined #openstack-nova23:12
*** su_zhang has quit IRC23:12
*** dvlwrk_ has quit IRC23:13
*** heyongli has quit IRC23:13
*** heyongli has joined #openstack-nova23:14
*** dave-mccowan has quit IRC23:14
*** tjones has quit IRC23:15
*** tjones has joined #openstack-nova23:15
*** otter768 has joined #openstack-nova23:16
*** dustins has quit IRC23:18
*** diogogmt has quit IRC23:20
*** dave-mccowan has joined #openstack-nova23:20
*** otter768 has quit IRC23:21
*** su_zhang has joined #openstack-nova23:21
*** burgerk has quit IRC23:22
*** baoli has quit IRC23:22
*** baoli has joined #openstack-nova23:23
*** heyongli has quit IRC23:24
*** thorst_ has quit IRC23:24
*** ctrath has quit IRC23:24
*** heyongli has joined #openstack-nova23:24
*** edmondsw has quit IRC23:25
*** diogogmt has joined #openstack-nova23:26
*** burt has quit IRC23:26
*** mriedem has joined #openstack-nova23:33
*** heyongli has quit IRC23:34
*** signed8bit is now known as signed8bit_ZZZzz23:35
*** heyongli has joined #openstack-nova23:35
*** baoli has quit IRC23:35
*** zhangjn has joined #openstack-nova23:39
*** signed8bit_ZZZzz is now known as signed8bit23:39
*** otter768 has joined #openstack-nova23:41
*** baoli has joined #openstack-nova23:43
*** heyongli has quit IRC23:44
*** haomaiwa_ has quit IRC23:45
*** jaypipes has quit IRC23:45
*** heyongli has joined #openstack-nova23:45
*** haomaiwa_ has joined #openstack-nova23:45
*** inteq has quit IRC23:47
*** _RuiChen_ has quit IRC23:47
*** mrkz has quit IRC23:48
*** dave-mccowan has quit IRC23:49
*** baoli has quit IRC23:52
*** n0ano has joined #openstack-nova23:52
*** baoli has joined #openstack-nova23:53
*** heyongli has quit IRC23:54
*** heyongli has joined #openstack-nova23:55
*** jerrygb has quit IRC23:56
*** ijuwang has quit IRC23:57
*** zhangjn has quit IRC23:57
*** sfinucan has quit IRC23:58
*** takedakn has joined #openstack-nova23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!