Tuesday, 2015-09-29

*** EinstCrazy has joined #openstack-nova00:01
*** pratikma_ has quit IRC00:01
*** yamahata has quit IRC00:01
*** gzhai2 has joined #openstack-nova00:03
*** emagana has joined #openstack-nova00:06
*** gzhai1 has quit IRC00:06
*** EinstCrazy has quit IRC00:09
*** VW has joined #openstack-nova00:09
*** Daisy_ has joined #openstack-nova00:09
*** VW has quit IRC00:10
*** NightKhaos has quit IRC00:10
*** VW has joined #openstack-nova00:10
*** gzhai3 has joined #openstack-nova00:13
*** Daisy_ has quit IRC00:14
*** gzhai2 has quit IRC00:15
*** NightKhaos has joined #openstack-nova00:16
*** zzzeek has quit IRC00:17
*** electroc_ has quit IRC00:21
*** su_zhang has quit IRC00:23
*** dims has joined #openstack-nova00:24
*** ociuhandu has joined #openstack-nova00:27
*** angdraug has quit IRC00:28
*** diegows has quit IRC00:30
*** pratikmallya has quit IRC00:30
*** VW has quit IRC00:32
openstackgerritSam Morrison proposed openstack/nova: Catch 404s from Neutron when floating IPs not enabled  https://review.openstack.org/22867600:32
*** VW has joined #openstack-nova00:32
*** tsekiyama has quit IRC00:33
*** VW has quit IRC00:36
*** oomichi has joined #openstack-nova00:39
*** aix has quit IRC00:39
*** aix has joined #openstack-nova00:40
*** VW has joined #openstack-nova00:46
*** leseb_ has quit IRC00:46
*** gongysh has quit IRC00:47
*** edmondsw has quit IRC00:47
*** pratikmallya has joined #openstack-nova00:49
*** jmccrory has joined #openstack-nova00:49
*** VW has quit IRC00:51
*** VW has joined #openstack-nova00:51
*** smatzek has joined #openstack-nova00:52
*** aix has quit IRC00:52
*** leseb_ has joined #openstack-nova00:52
*** gongysh has joined #openstack-nova00:54
*** shakamunyi has joined #openstack-nova00:55
*** aix has joined #openstack-nova00:55
*** VW has quit IRC00:55
*** andreykurilin__ has quit IRC00:56
*** marzif has joined #openstack-nova00:56
*** penick has quit IRC00:57
*** baoli has joined #openstack-nova00:58
*** aysyd has quit IRC00:58
*** zhangjn has joined #openstack-nova01:01
*** EinstCrazy has joined #openstack-nova01:01
*** browne has quit IRC01:02
*** thorst has joined #openstack-nova01:02
*** r-daneel has quit IRC01:04
*** thorst has quit IRC01:05
*** dave-mcc_ has joined #openstack-nova01:07
*** mtanino has quit IRC01:09
*** dave-mccowan has quit IRC01:10
*** Daisy_ has joined #openstack-nova01:16
*** zhangjn_ has joined #openstack-nova01:17
*** Marga_ has quit IRC01:18
*** Marga_ has joined #openstack-nova01:18
*** zhangjn has quit IRC01:19
alex_xujohnthetubaguy: thanks for the update01:21
*** apoorvad_ has joined #openstack-nova01:27
*** apoorvad has quit IRC01:31
*** apoorvad_ has quit IRC01:31
tonybAnyone in stable-maint able to look at: https://review.openstack.org/#/c/219301/ ?01:32
* tonyb eyes up mikal 01:32
*** unicell has quit IRC01:33
*** tpeoples has joined #openstack-nova01:39
openstackgerritAlex Xu proposed openstack/nova: docs: rerganize the API concept docs  https://review.openstack.org/22625301:42
oomichialex_xu: morning01:45
alex_xuoomichi: o ha yo01:46
oomichialex_xu: about https://review.openstack.org/#/c/21674601:46
oomichialex_xu: nihao :)01:46
alex_xuoomichi: ha, we can talk with many language01:46
oomichialex_xu: there is a similar patch https://review.openstack.org/#/c/22867601:46
oomichialex_xu: yeah, including python ;)01:46
alex_xuoomichi: heh01:47
*** dustins has joined #openstack-nova01:47
oomichialex_xu: I prefer the later: https://review.openstack.org/#/c/228676 by comparing 21674601:47
*** otter768 has joined #openstack-nova01:47
alex_xuoomichi: give me a sec think about01:47
oomichialex_xu: that seems simple and consistent for the other nova api01:48
oomichialex_xu: thanks:)01:48
alex_xuoomichi: yea, that sounds good pint, consistent for other api01:48
alex_xus/pint/point01:48
oomichialex_xu: the commit message seems too short anyways :)01:48
alex_xuoomichi: sounds good point, we better to match nova-network behavior01:49
alex_xuoomichi: as our network api support nova-network and neutron01:50
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] hacking check for contextlib.nested for py34 support  https://review.openstack.org/22868801:50
oomichialex_xu: good feedback, thanks for taking a look :)01:50
alex_xuoomichi: np, you are welcome01:51
*** otter768 has quit IRC01:52
alex_xuoomichi: wait a sec01:52
alex_xuoomichi: have you seen this one https://review.openstack.org/#/c/200001/9/doc/source/architecture_evolution_summary.rst01:52
alex_xuoomichi: about line 237 and 23801:52
*** pixelbeat has quit IRC01:53
oomichialex_xu: "we should change nova-networks interface to match"01:54
oomichialex_xu: is that?01:54
alex_xuoomichi: yea01:54
*** changbl has joined #openstack-nova01:55
*** baoli has quit IRC01:55
oomichialex_xu: I'm not sure that means to be honest.01:56
alex_xuoomichi: yea...actually I'm doubt also, not sure we can match it, I more like we can remove all of those apis directly :)01:56
oomichialex_xu: I see nova-networks API seems lacks of network information by comparing neutron01:56
oomichialex_xu: I guess the lines means we need to add some params to nova-networks API, I guess01:57
*** yamahata has joined #openstack-nova01:57
oomichialex_xu: ah, yeah. that is also nice direction.01:57
alex_xuoomichi: anyway, just match current behavior is not bad01:58
alex_xuoomichi: but look at this https://review.openstack.org/#/c/228676/1/nova/network/neutronv2/api.py again01:59
alex_xuoomichi: all the 404 return [], sounds too generic01:59
oomichialex_xu: it is nice to convert 404 to [] on REST API layer?02:00
*** Daisy_ has quit IRC02:00
alex_xuoomichi: what about create and delete action? they also may return 40402:01
openstackgerritjunxu proposed openstack/nova-specs: Allow force stop server in nova rest api  https://review.openstack.org/19541802:01
alex_xuoomichi: only index return [], others return 404?02:01
*** Alexus has quit IRC02:01
*** Daisy_ has joined #openstack-nova02:01
oomichialex_xu: only index return [], you are right.02:02
oomichialex_xu: but not sure 404 is the best for create02:02
oomichialex_xu: because I am proposing https://review.openstack.org/#/c/221163/ to api-wg02:03
oomichialex_xu: ;)02:03
alex_xuoomichi: ha, cool02:03
alex_xuoomichi: but 404 already existed in create, see line 127 https://review.openstack.org/#/c/216746/7/nova/api/openstack/compute/floating_ips.py02:04
oomichialex_xu: I feel create api should not return 404 because 404 should be used for not-found resource url.02:04
oomichialex_xu: yeah, nice point02:04
oomichialex_xu: nova contains this kind of inconsistency02:04
*** changbl has quit IRC02:04
alex_xuoomichi: yea, that should be 400?02:05
oomichialex_xu: then I hesitated -1ing for the reason.02:05
oomichialex_xu: I guess so.02:05
*** baoli has joined #openstack-nova02:06
alex_xuoomichi: so finally, we return [] for index, 400 for others?02:06
oomichialex_xu: after api-wg patch is merged, I can -1 the patch because we can get a guideline.02:06
oomichialex_xu: 404 is also possible options at this time, because the api-wg patch is not merged yet.02:07
oomichialex_xu: maybe I just want to notice the api-wg patch for you ;-)02:07
alex_xuoomichi: yea02:07
oomichialex_xu: anyway, [] should be for index, I beleive02:08
openstackgerritTang Chen proposed openstack/nova-specs: Host maintenance mode  https://review.openstack.org/22868902:08
alex_xuoomichi: yea, I'm ok with it02:08
alex_xuoomichi: not ok, it is +102:09
*** dims has quit IRC02:09
*** yamahata has quit IRC02:15
*** stevemar has joined #openstack-nova02:19
*** rushil has joined #openstack-nova02:25
*** achanda has joined #openstack-nova02:25
*** salv-orlando has joined #openstack-nova02:28
*** baoli has quit IRC02:32
*** zhenguo has joined #openstack-nova02:34
*** browne has joined #openstack-nova02:35
*** Marga__ has joined #openstack-nova02:36
*** salv-orlando has quit IRC02:37
*** Marga_ has quit IRC02:39
*** Marga__ has quit IRC02:40
*** oomichi has quit IRC02:46
*** baoli has joined #openstack-nova02:49
*** ijw has quit IRC02:51
*** haomaiwang has joined #openstack-nova02:51
*** asettle has quit IRC02:55
*** shyu has joined #openstack-nova02:56
*** baoli has quit IRC02:56
*** baoli has joined #openstack-nova02:57
*** ks1 has joined #openstack-nova02:59
*** haomaiwang has quit IRC03:01
*** asettle has joined #openstack-nova03:01
*** haomaiwang has joined #openstack-nova03:01
*** baoli has quit IRC03:03
*** VW has joined #openstack-nova03:05
*** achanda has quit IRC03:09
*** cfriesen has quit IRC03:09
*** dims has joined #openstack-nova03:09
*** rfolco has joined #openstack-nova03:10
*** dims has quit IRC03:16
*** bnemec has quit IRC03:17
*** jdurgin1 has joined #openstack-nova03:18
*** boris-42 has quit IRC03:19
*** hemna has joined #openstack-nova03:20
*** deepthi has joined #openstack-nova03:23
*** dave-mcc_ has quit IRC03:24
*** hitalia has quit IRC03:27
*** Daisy_ has quit IRC03:27
*** Daisy has joined #openstack-nova03:28
*** zerda-bis has joined #openstack-nova03:29
*** boris-42 has joined #openstack-nova03:29
*** rfolco has quit IRC03:30
*** smatzek has quit IRC03:30
*** baoli has joined #openstack-nova03:31
*** asettle is now known as asettle-afk03:32
*** Daisy has quit IRC03:32
*** dustins has quit IRC03:33
*** links has joined #openstack-nova03:36
*** baoli has quit IRC03:37
*** vilobhmm111 has quit IRC03:40
*** ks1 has quit IRC03:41
*** asettle-afk is now known as asettle03:42
*** Kennan2 is now known as Kennnan03:45
openstackgerritTang Chen proposed openstack/nova: Replace 'dummy' status with migration_status.DUMMY.  https://review.openstack.org/22817703:50
openstackgerritTang Chen proposed openstack/nova: Replace 'failed' status with migration_status.FAILED.  https://review.openstack.org/22817603:50
openstackgerritTang Chen proposed openstack/nova: Replace 'post-migrating' status with migration_status.POST_MIGRATING.  https://review.openstack.org/22816603:50
openstackgerritTang Chen proposed openstack/nova: Replace 'finished' statuses with migration_status.FINISHED.  https://review.openstack.org/22816703:50
openstackgerritTang Chen proposed openstack/nova: Replace 'migrating' status with migration_status.MIGRATING.  https://review.openstack.org/22816403:50
openstackgerritTang Chen proposed openstack/nova: Replace 'running' status with migration_status.MIGRATING.  https://review.openstack.org/22816503:50
openstackgerritTang Chen proposed openstack/nova: Replace 'preparing' status with migration_status.PREPARING.  https://review.openstack.org/22816203:50
openstackgerritTang Chen proposed openstack/nova: Replace 'pre-migrating' status with migration_status.PRE_MIGRATING.  https://review.openstack.org/22816303:50
openstackgerritTang Chen proposed openstack/nova: Introduce constants to indicate live migration status.  https://review.openstack.org/22816103:50
openstackgerritTang Chen proposed openstack/nova: Replace 'reverted' status with migration_status.REVERTED.  https://review.openstack.org/22817403:50
openstackgerritTang Chen proposed openstack/nova: Replace 'error' status with migration_status.ERROR.  https://review.openstack.org/22817503:50
openstackgerritTang Chen proposed openstack/nova: Replace 'confirmed' status with migration_status.CONFIRMED.  https://review.openstack.org/22817203:50
openstackgerritTang Chen proposed openstack/nova: Replace 'reverting' status with migration_status.REVERTING.  https://review.openstack.org/22817303:50
openstackgerritTang Chen proposed openstack/nova: Replace 'queued' status with migration_status.QUEUED.  https://review.openstack.org/22817003:50
openstackgerritTang Chen proposed openstack/nova: Replace 'confirming' status with migration_status.CONFIRMING.  https://review.openstack.org/22817103:50
openstackgerritTang Chen proposed openstack/nova: Replace 'completed' status with migration_status.FINISHED.  https://review.openstack.org/22816803:50
openstackgerritTang Chen proposed openstack/nova: Replace 'done' status with migration_status.FINISHED.  https://review.openstack.org/22816903:50
*** vilobhmm11 has joined #openstack-nova03:53
*** zhangjn_ has quit IRC03:54
*** vilobhmm11 has quit IRC03:54
*** markvoelker has quit IRC03:56
*** vilobhmm11 has joined #openstack-nova03:56
*** ociuhandu has quit IRC04:00
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-nova04:01
*** rushil has quit IRC04:02
*** hemna has quit IRC04:06
*** wanghua has quit IRC04:06
*** wanghua has joined #openstack-nova04:06
*** zhangjn has joined #openstack-nova04:10
*** VikasC has joined #openstack-nova04:12
*** Marga_ has joined #openstack-nova04:12
*** nikhil_k has joined #openstack-nova04:16
*** nikhil has quit IRC04:18
*** pratikmallya has quit IRC04:18
*** jdurgin1 has quit IRC04:21
*** pratikmallya has joined #openstack-nova04:24
*** pratikmallya has joined #openstack-nova04:27
*** salv-orlando has joined #openstack-nova04:29
*** achanda has joined #openstack-nova04:29
*** pratikmallya has quit IRC04:32
*** Marga_ has quit IRC04:34
*** Marga_ has joined #openstack-nova04:35
*** unicell has joined #openstack-nova04:35
*** Sree has joined #openstack-nova04:38
*** salv-orlando has quit IRC04:38
*** Sree has quit IRC04:38
*** Sree has joined #openstack-nova04:39
*** Marga_ has quit IRC04:39
openstackgerritvenkatesh proposed openstack/nova: make the driver.Scheduler as abstract class  https://review.openstack.org/21201604:45
*** Marga_ has joined #openstack-nova04:50
*** shyu has quit IRC04:51
*** su_zhang has joined #openstack-nova04:51
*** zhangjn has quit IRC04:52
*** zhangjn has joined #openstack-nova04:53
*** markvoelker has joined #openstack-nova04:57
*** vilobhmm11 has left #openstack-nova04:58
*** vilobhmm11 has joined #openstack-nova04:59
*** vilobhmm11 has left #openstack-nova04:59
*** vilobhmm11 has joined #openstack-nova05:00
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-nova05:01
*** markvoelker has quit IRC05:01
*** VW has quit IRC05:02
*** rotbeard has joined #openstack-nova05:02
*** VW has joined #openstack-nova05:02
*** stevemar has quit IRC05:03
*** nkrinner has joined #openstack-nova05:03
*** hemna has joined #openstack-nova05:03
*** hemna has quit IRC05:03
*** dims has joined #openstack-nova05:13
*** Marga_ has quit IRC05:15
*** Marga_ has joined #openstack-nova05:15
*** dims has quit IRC05:18
*** VW_ has joined #openstack-nova05:20
*** tpeoples has quit IRC05:20
*** VW_ has quit IRC05:22
*** VW_ has joined #openstack-nova05:23
*** krtaylor has quit IRC05:23
*** VW has quit IRC05:24
openstackgerritTang Chen proposed openstack/nova-specs: Host maintenance mode  https://review.openstack.org/22868905:26
openstackgerritTang Chen proposed openstack/nova-specs: Host maintenance mode  https://review.openstack.org/22868905:27
*** deepakcs has joined #openstack-nova05:32
*** garyk has quit IRC05:32
*** krtaylor has joined #openstack-nova05:32
*** sileht has quit IRC05:33
*** zhangjn has quit IRC05:36
*** achanda has quit IRC05:36
*** stevemar has joined #openstack-nova05:36
*** moshele has joined #openstack-nova05:37
*** _gryf has quit IRC05:38
gmannalex_xu: oomichi: regarding https://review.openstack.org/#/c/228676/05:41
gmannI think empty list in index gives kindda false impression that there is not FIPs instead of some plugin missing.05:42
*** stevemar_ has joined #openstack-nova05:42
gmannI feel index should raise exception in l3 plugin missing where list FIP through the same05:43
*** stevema__ has joined #openstack-nova05:43
*** stevemar has quit IRC05:45
*** stevemar_ has quit IRC05:46
*** otter768 has joined #openstack-nova05:49
*** Marga_ has quit IRC05:49
*** sahid has joined #openstack-nova05:50
*** otter768 has quit IRC05:53
*** VW_ has quit IRC05:54
*** VW has joined #openstack-nova05:54
*** lsmola has joined #openstack-nova05:58
*** VW has quit IRC05:59
*** garyk has joined #openstack-nova05:59
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-nova06:01
*** Murali has joined #openstack-nova06:01
*** browne has quit IRC06:03
*** Daisy has joined #openstack-nova06:06
*** jamielennox is now known as jamielennox|away06:12
*** irenab has quit IRC06:13
*** shuquan has joined #openstack-nova06:14
*** su_zhang has quit IRC06:15
*** openstackgerrit has quit IRC06:16
*** openstackgerrit has joined #openstack-nova06:17
*** Alexus has joined #openstack-nova06:20
*** oomichi has joined #openstack-nova06:20
*** fawadkhaliq has joined #openstack-nova06:21
*** armax has quit IRC06:24
*** oomichi has quit IRC06:25
*** e0ne has joined #openstack-nova06:28
*** stevema__ has quit IRC06:28
*** stevemar has joined #openstack-nova06:28
*** lpetrut has joined #openstack-nova06:28
*** fawadkhaliq has quit IRC06:30
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata  https://review.openstack.org/22713806:32
*** stevemar has quit IRC06:33
*** e0ne has quit IRC06:34
openstackgerritRui Chen proposed openstack/nova-specs: Task states improvement  https://review.openstack.org/21657806:35
*** deepakcs has quit IRC06:38
*** tdurakov has joined #openstack-nova06:38
tdurakovmikal, hi are you around?06:38
*** Marga_ has joined #openstack-nova06:39
*** Daisy has quit IRC06:39
tdurakovhttps://review.openstack.org/#/c/183057/ - left comment about spec readiness, could you check that?06:39
*** Daisy has joined #openstack-nova06:40
*** deepakcs has joined #openstack-nova06:42
*** Daisy has quit IRC06:42
*** Daisy has joined #openstack-nova06:42
*** salv-orlando has joined #openstack-nova06:44
*** markvoelker has joined #openstack-nova06:45
*** irenab has joined #openstack-nova06:46
*** salv-orlando has quit IRC06:47
*** markvoelker has quit IRC06:50
*** tdurakov has quit IRC06:51
*** tdurakov has joined #openstack-nova06:53
rajeshtany stable core around ?06:56
*** rdopiera has joined #openstack-nova06:59
rajeshtgaryk: could you please review stable/kilo patch https://review.openstack.org/#/c/223968/07:00
rajeshtgaryk: thanks :)07:00
*** haomaiwang has quit IRC07:01
gmannalex_xu: even this introduced new error code (need microversion :( )- https://review.openstack.org/#/c/216746/07:01
*** haomaiwang has joined #openstack-nova07:01
alex_xugmann: emm....maybe oomichi suggestion is right, return emtpy list07:02
*** Sree has quit IRC07:02
gmannalex_xu: but thats does not looks good for me.. we are returning positive response when neutron says floating IPs are not supported07:02
gmannalex_xu:  empty list will convey to user that there is no FIP and then they will try to create one and get 40407:03
*** jwcroppe has joined #openstack-nova07:04
gmannbecause FIP not supported from neutron tells clearly that requested resource is not available07:05
gmannand same nova should tell to user07:05
alex_xugmann: sorry, I'm in a meeting, will be back later07:05
bauzasgood morning Nova07:05
gmannalex_xu: sure07:05
alex_xugmann: http://docs.openstack.org/developer/nova/api_microversion_dev.html there is Footnotes[2], the infrastture always return 40407:06
*** e0ne has joined #openstack-nova07:07
*** FL1SK has quit IRC07:08
gmannalex_xu: that for 400 and 403 only right?07:09
*** e0ne has quit IRC07:09
*** Daisy has quit IRC07:09
*** Daisy has joined #openstack-nova07:10
*** matrohon has joined #openstack-nova07:10
*** vilobhmm11 has quit IRC07:12
openstackgerritbharaththiruveedula proposed openstack/nova-specs: Returning Compute Node IP address in hypervisor list  https://review.openstack.org/21520707:13
alex_xugmann: oops, I missed that07:13
*** Daisy has quit IRC07:14
*** e0ne has joined #openstack-nova07:21
*** salv-orlando has joined #openstack-nova07:28
*** alexpilotti has joined #openstack-nova07:31
*** Sree_ has joined #openstack-nova07:31
*** Sree_ is now known as Guest2218507:32
*** salv-orlando has quit IRC07:32
*** Guest22185 has quit IRC07:33
*** ildikov has joined #openstack-nova07:34
*** Sree has joined #openstack-nova07:35
*** yamahata has joined #openstack-nova07:35
*** exploreshaifali has joined #openstack-nova07:40
*** jichen has joined #openstack-nova07:41
openstackgerritSachi King proposed openstack/nova: DNM: Tox testing  https://review.openstack.org/22876407:42
*** alex_klimov has joined #openstack-nova07:42
*** romainh has joined #openstack-nova07:43
*** acc__ has joined #openstack-nova07:44
*** acc_ has quit IRC07:44
*** jlanoux has joined #openstack-nova07:45
*** garyk has quit IRC07:47
*** garyk has joined #openstack-nova07:47
*** otter768 has joined #openstack-nova07:50
openstackgerritZhenyu Zheng proposed openstack/python-novaclient: Add --metadata as optional input when do nova image-create  https://review.openstack.org/22876907:51
*** alexpilotti has quit IRC07:52
*** shuquan has quit IRC07:54
*** _gryf has joined #openstack-nova07:54
*** otter768 has quit IRC07:54
*** karimb has joined #openstack-nova07:56
*** shuquan has joined #openstack-nova07:56
openstackgerritRui Chen proposed openstack/nova-specs: Split network plane for live migration  https://review.openstack.org/19499007:57
*** asettle has quit IRC08:00
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-nova08:01
openstackgerritTimofey Durakov proposed openstack/nova: Wrap setup_networks_on_host with try/except  https://review.openstack.org/22789708:02
alex_xujohnthetubaguy: bauzas, good morning, just worked out the back port for upgrade bug https://review.openstack.org/22877408:03
*** xgsa has joined #openstack-nova08:03
bauzasalex_xu: ack, you could perhaps get a -2 because the RC2 is not yet open, but it should be done soon as per johnthetubaguy said in his email08:04
bauzasRC2 *window08:04
alex_xubauzas: ok08:05
*** Sree has quit IRC08:05
*** Sree has joined #openstack-nova08:06
*** lpetrut has quit IRC08:06
*** yassine__ has joined #openstack-nova08:07
*** derekh has joined #openstack-nova08:07
*** markus_z has joined #openstack-nova08:07
openstackgerritZhenyu Zheng proposed openstack/python-novaclient: Add --metadata as optional input when do nova image-create  https://review.openstack.org/22876908:08
*** nithyag_ has quit IRC08:15
*** lpetrut has joined #openstack-nova08:15
*** jistr has joined #openstack-nova08:16
*** mpaolino has joined #openstack-nova08:17
*** marzif has quit IRC08:18
openstackgerritRadoslav Gerganov proposed openstack/nova-specs: ConsoleAuthTokens should work for all console types  https://review.openstack.org/22877808:19
*** danpb has joined #openstack-nova08:23
*** Alexus has quit IRC08:31
*** Daisy has joined #openstack-nova08:32
*** pixelbeat has joined #openstack-nova08:34
*** salv-orlando has joined #openstack-nova08:35
kashyapOn Nova live block migration:08:36
kashyapIf you use these flags in nova.conf:08:36
kashyaplive_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE08:36
kashyapblock_migration_flag=VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_LIVE, VIR_MIGRATE_NON_SHARED_INC08:36
kashyapPerforming a `nova live-migration --block-migrat` *still* uses old style 'migrate inc' method (as I realize libvirt TUNNELLED migration + NBD does not play well yet) instead of using NBD-based approach.  Any hints why?08:36
kashyapI know that the current upstream default for 'live_migration_flag' still has TUNNELLED in it.  But in my test above, I explicitly removed it in my nova.conf. . .08:37
*** julien_ZTE has joined #openstack-nova08:38
*** VW has joined #openstack-nova08:40
*** VW has quit IRC08:40
*** VW has joined #openstack-nova08:41
* kashyap patches local driver.py manually and tests again08:41
kashyapBecause looking at my n-cpu.log, seems like my change in nova.conf didn't take effect -- the default flags from upstream are enforced.08:43
kashyapsahid (or anyone): Hi, when you have a moment -- shouldn't explicit values of a config variable set in nova.conf take precedence over upstream default?08:45
*** exploreshaifali has quit IRC08:45
*** VW has quit IRC08:45
rajeshtjaypipes: I have replied to your comments on https://review.openstack.org/17011808:45
rajeshtjaypipes: could you please give your suggestions ?08:46
rajeshtjaypipes: thanks :)08:46
*** markvoelker has joined #openstack-nova08:46
*** lpetrut has quit IRC08:48
rajeshtjaypipes: pl consider this patch set https://review.openstack.org/#/c/170118/17/nova/compute/manager.py08:49
*** shuquan has quit IRC08:49
*** shuquan has joined #openstack-nova08:51
rajeshtmikal: needs one more +2 on stable/kilo backport, could you pls check https://review.openstack.org/22396808:51
*** markvoelker has quit IRC08:51
openstackgerritvenkatesh proposed openstack/nova: make the driver.Scheduler as abstract class  https://review.openstack.org/21201608:52
*** jsuchome has joined #openstack-nova08:53
*** Kennnan2 has joined #openstack-nova08:54
*** Kennnan has quit IRC08:54
*** MarcF has joined #openstack-nova08:57
*** claudiub has joined #openstack-nova08:58
*** haomaiwang has quit IRC09:01
*** haomaiwang has joined #openstack-nova09:01
sahidkashyap: no you don't have, but i think that if you restart devstack it will override nova.conf09:02
*** jichen has quit IRC09:02
kashyapsahid: You mean, even if I explicitly set something that's *different* from default in config file, it'll be overridden once DevStack restarts?09:03
kashyapThat does not sound useful09:03
sahidkashyap: yes i think so09:03
johnthetubaguyalex_xu: bauzas: this patch does stop live upgrades working, if I understand this correctly? https://review.openstack.org/#/c/228304/09:04
kashyapsahid: Okay, I'll come back and test, have to step out for 20 min09:04
bauzasjohnthetubaguy: ?09:05
bauzasjohnthetubaguy: what do you mean ?09:05
sahidkashyap: i think here is a way to twek noca.conf in localerc09:05
sahidtweak09:05
*** FL1SK has joined #openstack-nova09:05
johnthetubaguybauzas: that patch you were talking to alex_xu about, its basically blocking upgrade right?09:05
bauzasjohnthetubaguy: the problem is that an instance backport was providing an InstanceV109:06
johnthetubaguywell, live upgrade09:06
bauzasjohnthetubaguy: where our checks were wrong09:06
johnthetubaguyfull of cold with a brain like mush, just making sure I am remembering it right09:06
*** sambetts has quit IRC09:07
bauzasjohnthetubaguy: so dansmith provided a new v2 object for instance09:07
*** haypo has joined #openstack-nova09:07
johnthetubaguybauzas: OK, I am confused now, do you have the patch for that?09:07
*** sambetts has joined #openstack-nova09:07
sahidkashyap: local.sh sorry09:07
*** ndipanov has quit IRC09:07
johnthetubaguybauzas: simpler question, is it work having another RC release, just for this patch: https://review.openstack.org/#/c/228774/109:08
johnthetubaguys/work/worth/09:08
bauzasjohnthetubaguy: https://github.com/openstack/nova/commit/713d8cb0777afb9fe4f665b9a40cac894b04aacb09:08
johnthetubaguybauzas: yes, I remember that patch09:09
johnthetubaguybauzas: thats why we need the above patch09:09
bauzasjohnthetubaguy: good question, but I thought we were waiting for a RC2 for translations, nope?09:09
bauzasyup09:09
johnthetubaguywe can make that RC309:09
bauzasnot sure I get that09:09
johnthetubaguymy question is really, did we work out why granade didn't find the bug09:10
johnthetubaguyjust we can do RC2 for the above patch, then RC3 for translations09:10
bauzasjohnthetubaguy: oh I see your question09:10
bauzaswell the grenade question is actually a good point09:11
bauzasjohnthetubaguy: I mean the partial n-cpu job should have found the problem09:11
johnthetubaguyright09:12
*** davideagnello has quit IRC09:12
*** oomichi has joined #openstack-nova09:13
bauzasjohnthetubaguy: I guess it hasn't been found because it was not covered09:13
bauzasjohnthetubaguy: by looking at the change, there are 4 impacted files09:13
*** davideagnello has joined #openstack-nova09:13
bauzasone is about numa topology, and we know we don't cover it09:13
bauzasone is about providing a request spec dict, but we're passing a new instance that we created on the Liberty controller, so I guess it's correct09:14
bauzas(speaking of https://review.openstack.org/#/c/228304/8/nova/scheduler/utils.py,cm)09:15
bauzaswell, it would probably need to be checked for migrations tho09:15
*** dims has joined #openstack-nova09:16
bauzasone is within the ReqSpec object, but we haven't yet used this object09:16
bauzasand the last one is when providing some instance info from the compute to the scheduler09:16
bauzasjohnthetubaguy: so I possibly think it was not covered09:18
*** ndipanov has joined #openstack-nova09:18
bauzasalex_xu: thoughts ?09:18
johnthetubaguybauzas: yeah, thats possible, although the bug seemed to suggest he was unable to boot, maybe with NUMA configured09:18
bauzasjohnthetubaguy: yeah I guess alex_xu tried something untested09:19
bauzasoh sec09:19
*** sakthi has joined #openstack-nova09:19
bauzasalex_xu: you said you were running 2015.1.009:19
johnthetubaguythat shouldn't impact that patch though09:19
bauzasalex_xu: could you please verify if the bug you mention is still valid with 2015.1.1 ? (doesn't require an upgrade09:19
sakthiNova compute manager error spawning instances09:20
sakthihelp  me regarding this.\09:20
*** salv-orl_ has joined #openstack-nova09:21
*** dims has quit IRC09:22
bauzasjohnthetubaguy: sure09:22
bauzasjohnthetubaguy: but I'm still wondering why grenade didn't catch up09:22
johnthetubaguysakthi: there should be folks on #openstack to help with more usage questions, this is really just for development chat09:22
bauzasjohnthetubaguy: https://bugs.launchpad.net/nova/+bug/1500289 is pretty explicit with the 2nd stacktrace09:23
openstackLaunchpad bug 1500289 in OpenStack Compute (nova) "Booting instance failed with Kilo stable compute node and liberty controller" [Critical,Fix committed] - Assigned to Alex Xu (xuhj)09:23
johnthetubaguysakthi: but what version are you running, and have you opened a bug for the issue at all?09:23
sakthirunning kilo version09:23
johnthetubaguybauzas: oh, I see, its the retry that actually breaks09:24
*** salv-orlando has quit IRC09:25
oomichijohnthetubaguy: hello :)09:25
*** julien_ZTE has quit IRC09:26
oomichijohnthetubaguy: can you take a look at https://review.openstack.org/#/c/227650/ again if available ?09:26
johnthetubaguysakthi: OK, have you tried asking on #openstack channel, where some folks can help with usage questions?09:26
*** julien_ZTE has joined #openstack-nova09:26
sakthiok09:27
openstackgerritVladyslav Drok proposed openstack/nova: DO NOT MERGE - Triggering experimental pipeline  https://review.openstack.org/22022909:28
bauzasjohnthetubaguy: yup, because it's in build_instances but with a v1 instance09:28
bauzasjohnthetubaguy: if it was a single instance creation, it should have been coming as a v209:28
bauzasthat's my understanding09:29
bauzasjohnthetubaguy: given the first stacktrace where the compute manager raised an exception09:29
*** julien_ZTE has quit IRC09:30
*** VW has joined #openstack-nova09:32
bauzasjohnthetubaguy: and to be clear, as grenade was running the latest stable kilo incl. the bugfix for the pci stuff, it didn't raised an exception in the spawn() process, thus not requiring a reschedule09:33
*** jlanoux has quit IRC09:33
*** digimonde has joined #openstack-nova09:33
rajeshtclaudiub: needs one more +2 on stable/kilo backport, could you pls check https://review.openstack.org/22396809:35
openstackgerritsahid proposed openstack/nova: libvirt: add cpu schedular priority config  https://review.openstack.org/19756709:35
openstackgerritsahid proposed openstack/nova: libvirt: rework membacking config to support future features  https://review.openstack.org/19756609:35
openstackgerritsahid proposed openstack/nova: virt: add contraint to handle realtime policy  https://review.openstack.org/19756809:35
openstackgerritsahid proposed openstack/nova: libvirt: add realtime support  https://review.openstack.org/19756909:35
openstackgerritsahid proposed openstack/nova: hardware: improve parse_cpu_spec to handle exclusion range  https://review.openstack.org/22678309:35
rajeshtclaudiub: thanks :)09:35
kashyapsahid: Im' back.  Yes, there _is_ a way to add Nova conf parameters in DevStack's local.conf, that's what I use:09:37
kashyap[[post-config|$NOVA_CONF]]09:37
kashyap[DEFAULT]09:37
*** VW has quit IRC09:38
rajeshtjohnthetubaguy: can we discuss about your comments on force-delete patch https://review.openstack.org/#/c/163798 if you have time09:38
johnthetubaguyoomichi: had some nits09:38
johnthetubaguyrajesht: sure thing09:38
*** VW has joined #openstack-nova09:38
rajeshtjohnthetubaguy: comment in https://review.openstack.org/#/c/163798/9/nova/compute/api.py line 194609:39
johnthetubaguyrajesht; just seems like we should raise raise exception.InstanceInvalidState on the duplicate force delete calls there09:40
rajeshtjohnthetubaguy: but here we can't add list of allowed task_states as it should allow force-delete on every task_state except force-deleting09:41
*** MarcF has quit IRC09:41
danpbc!09:42
*** zhenguo has quit IRC09:43
*** lpetrut has joined #openstack-nova09:44
kashyap   cfg.StrOpt('live_migration_flag',09:44
kashyap               default='VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, '09:44
rajeshtjohnthetubaguy: IMO we can't add task_state in check_instance_state which we want to reject. Is it true ?09:44
*** jlanoux has joined #openstack-nova09:45
rajeshtjohnthetubaguy: we can only have allowed states in check_instance_state decorator.09:45
rajeshtjohnthetubaguy: I am silently rejecting duplicate force-delete request in https://review.openstack.org/#/c/163798/9/nova/compute/api.py line #158109:46
*** dims has joined #openstack-nova09:47
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: hacking check for contextlib.nested for py34 support  https://review.openstack.org/22868809:47
*** lpetrut1 has joined #openstack-nova09:48
rajeshtjohnthetubaguy: as the same was done for duplicate delete request in https://github.com/openstack/nova/blob/master/nova/compute/api.py#L168909:48
*** lpetrut has quit IRC09:48
*** lpetrut1 is now known as lpetrut09:48
*** otter768 has joined #openstack-nova09:51
*** Alexus has joined #openstack-nova09:51
*** VW has quit IRC09:51
*** VW has joined #openstack-nova09:52
*** otter768 has quit IRC09:55
*** Daisy has quit IRC09:56
*** Daisy has joined #openstack-nova09:56
*** VW has quit IRC09:56
*** kbyrne has quit IRC09:58
*** shuquan has quit IRC09:58
*** ZZelle has quit IRC10:01
*** haomaiwang has quit IRC10:01
*** Daisy has quit IRC10:01
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order  https://review.openstack.org/22765010:01
*** haomaiwa_ has joined #openstack-nova10:01
*** yassine__ has quit IRC10:02
*** kbyrne has joined #openstack-nova10:03
oomichijohnthetubaguy: thanks for your review, applied your comments to ^^^10:03
*** sudipto has joined #openstack-nova10:03
*** IanGovett has joined #openstack-nova10:04
johnthetubaguyoomichi: thanks, they were a bit picky really10:07
johnthetubaguyrajesht: so I was waiting for my compute to make a noise, with the speaker on mute :(10:07
*** haomaiwa_ has quit IRC10:07
rajeshtjohnthetubaguy: np :)10:08
*** asettle has joined #openstack-nova10:08
johnthetubaguyrajesht: I am not talking about modifying the decorator, I just mean add the code in that method10:08
*** asettle has quit IRC10:08
johnthetubaguyrajesht: and make sure it raises an exception, rather than silently ignores the invalid state10:08
rajeshtjohnthetubaguy: In that case, I will raise exception in https://review.openstack.org/#/c/163798/9/nova/compute/api.py line 158510:09
johnthetubaguyrajesht: to be clear, duplicate delete requests are actually (normally) rejected by the the state check, L1689 is a bug, it should raise an exception, but thats a different patch10:09
johnthetubaguyrajesht: yep, that would be good I think10:09
*** asettle has joined #openstack-nova10:09
rajeshtjohnthetubaguy: ok , will upload a patch soon, thanks for your time :)10:09
johnthetubaguyrajesht: there was one more bit I think... hiding the new task state from the user, did that make sense, thats the most important comment really10:09
rajeshtjohnthetubaguy: Yeah, I checked that comment as well. Will do that as well :)10:10
sudiptoflaper87, are you around? :)10:10
*** ZZelle has joined #openstack-nova10:13
*** romainh has quit IRC10:15
*** paul-carlton has joined #openstack-nova10:22
*** tdurakov has quit IRC10:27
openstackgerritPaul Carlton proposed openstack/nova-specs: Query and cancel ongoing live migrations  https://review.openstack.org/22882810:29
*** tdurakov has joined #openstack-nova10:29
*** jlanoux_ has joined #openstack-nova10:31
openstackgerritSergey Nikitin proposed openstack/nova: Switch to oslo.cache lib  https://review.openstack.org/20304910:33
*** jlanoux has quit IRC10:34
*** smatzek has joined #openstack-nova10:35
openstackgerritDmitry Guryanov proposed openstack/nova: libvirt: support snapshots with parallels virt_type  https://review.openstack.org/18415310:36
*** EinstCrazy has quit IRC10:42
tojuvonejohnthetubaguy: Thanks for review, but still before making another patch, should I expose more host/service related things like enabled/disabled to this: https://review.openstack.org/192246/10:45
*** jlanoux has joined #openstack-nova10:45
*** markvoelker has joined #openstack-nova10:47
*** jlanoux_ has quit IRC10:48
*** jamielennox|away is now known as jamielennox10:49
*** markvoelker has quit IRC10:52
*** Daisy has joined #openstack-nova10:52
*** tojuvone is now known as tojuvone_away10:52
*** wanghua has quit IRC10:52
*** twinklechawla has joined #openstack-nova10:55
*** 18VAARFFB has joined #openstack-nova10:56
ndipanovjohnthetubaguy, hey should I be proposing this to stable/liberty https://review.openstack.org/#/c/226923/ ?10:57
ndipanovI can't seem to post the review10:57
ndipanovdo you do it before the RCs or?10:57
johnthetubaguyits good to line them up now10:57
ndipanovso I tagged the bug10:58
johnthetubaguycurrently, not seen anything bad enough to cut an RC before next tuesday10:58
ndipanovjust wasn't clear on who does the actual "backport"10:58
johnthetubaguyndipanov: generally the bug submitter10:58
johnthetubaguyndipanov: if they want to make sure it happens10:58
ndipanovhmmm so I can't seem to propose it then10:58
johnthetubaguywhat error do you get?10:58
flaper87sudipto: I am now10:59
ndipanovjohnthetubaguy, one sec10:59
*** claudiub has quit IRC10:59
sudiptoflaper87, ok sure. Just wanted to follow up on the review comment on the glance v1 to v2 stuff.10:59
johnthetubaguyndipanov: I am guessing you cherry picked the merged commit onto stable/liberty, then do git review stable/liberty or something like that?10:59
ndipanovjohnthetubaguy, yeah and it acts like the change is closed10:59
flaper87sudipto: sure10:59
johnthetubaguyndipanov: oh, you will need a new change id, I believe10:59
ndipanovjohnthetubaguy, that's not how stable usually works??11:00
flaper87sudipto: I'm working on the spec and I'll have a draft ready soon11:00
twinklechawlaHello everyone, I am interested in contributing in nova but I am totally new to this, so I need help!11:00
ndipanovit's very useful to have the same changeid11:00
*** gszasz has joined #openstack-nova11:00
sudiptoflaper87, sure.11:00
flaper87sudipto: That spec is the one that we should link on tha tchange you did11:00
sudiptoflaper87, yeah that makes sense. Sure.11:00
johnthetubaguyndipanov: good point, I don't remember ever having an issue with that11:00
bauzastwinklechawla: welcome :)11:00
flaper87sudipto: btw, there's another guy from Glance that would like to work on that as well. It'd be great to have you guys talk to each other11:00
bauzastwinklechawla: you can find a few pointers in https://wiki.openstack.org/wiki/Nova/Mentoring11:00
*** 18VAARFFB has quit IRC11:01
flaper87sudipto: would you mind joining #openstack-glance ?11:01
ndipanovok doing git review stable/liberty seems to have done it11:01
twinklechawlabauzas: Thank you!11:01
sudiptoflaper87, not at all, joining...11:01
*** haomaiwang has joined #openstack-nova11:01
flaper87sudipto: awesome, thanks!11:01
ndipanovgerrit would normally figure out the branch but oh well11:01
ndipanovjohnthetubaguy, ^11:01
johnthetubaguyndipanov: ah, cool, I see it there now: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/liberty,n,z11:01
ndipanovy11:02
ndipanovok moving on... :)11:02
*** exploreshaifali has joined #openstack-nova11:03
*** EinstCrazy has joined #openstack-nova11:04
*** jecarey has joined #openstack-nova11:05
twinklechawlabauzas: I have a query!11:06
*** yassine__ has joined #openstack-nova11:07
*** mpaolino has quit IRC11:09
twinklechawlaTill date I read about nova, cloned openstack-dev/devstack and openstack/nova. Further, what I have to do?11:09
*** haomaiwang has quit IRC11:11
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: libvirt: Log warning for wrong migration flag config options  https://review.openstack.org/22885311:16
*** twinklechawla has quit IRC11:16
*** Daisy has quit IRC11:19
*** Daisy has joined #openstack-nova11:20
alex_xujohnthetubaguy: bauzas that bug only trigger by kilo node send InstanceV1 to liberty controller node, the case I produce is there is something wrong when booting instance on kilo node, then kilo node will send retry request back to liberty conductor with an instancev111:21
alex_xuI guess that is the case grenade didn't tested11:21
*** salv-orl_ has quit IRC11:22
*** Daisy has quit IRC11:22
*** salv-orlando has joined #openstack-nova11:23
*** Daisy has joined #openstack-nova11:23
sdaguealex_xu: what kind of high level operation would trigger that?11:23
*** Daisy has quit IRC11:23
*** Daisy has joined #openstack-nova11:24
alex_xusdague: what means high level operation? I tested the booting new instance11:24
sdagueright, so we definitely boot a new instance on the partial upgrade test11:24
sdagueI'm mostly curious how it ended up getting missed11:25
alex_xuit's only triggered when booting new instance failed on the kilo compute node11:25
*** Daisy has quit IRC11:25
*** Daisy has joined #openstack-nova11:26
sdagueoh, so only if there is a fault11:26
sdaguethen a reschedule11:26
alex_xusdague: yeah11:26
sdagueyeh, we don't do fault injection11:26
johnthetubaguyyeah, its the rechedule11:26
johnthetubaguyI am thinking we make sure its in RC2 that we cut next week11:27
johnthetubaguybut not urgent enough to do a new RC this week11:27
johnthetubaguydoes that make sense, do you think?11:27
*** baoli has joined #openstack-nova11:27
*** thorst has joined #openstack-nova11:27
*** Daisy has quit IRC11:27
sdaguethat seems fine to me11:27
alex_xuok to me also11:27
*** Daisy has joined #openstack-nova11:27
*** marzif has joined #openstack-nova11:28
johnthetubaguycool, thanks11:28
*** Daisy has joined #openstack-nova11:28
*** baoli_ has joined #openstack-nova11:28
*** kiran-r has joined #openstack-nova11:29
*** deepthi has quit IRC11:29
*** jecarey has quit IRC11:31
*** baoli has quit IRC11:31
*** exploreshaifali has quit IRC11:32
*** Daisy has quit IRC11:33
*** stevemar has joined #openstack-nova11:40
*** tojuvone_away is now known as tojuvone11:41
*** dewsday has joined #openstack-nova11:43
*** asettle has quit IRC11:45
*** stevemar has quit IRC11:45
*** dewsday has quit IRC11:45
*** asettle has joined #openstack-nova11:46
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: hacking check for contextlib.nested for py34 support  https://review.openstack.org/22868811:50
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Remove novaclient.v1_1 module  https://review.openstack.org/21713111:50
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Remove novaclient.v1_1 module  https://review.openstack.org/21713111:51
*** otter768 has joined #openstack-nova11:52
alex_xunova api meeting in 8 mins11:52
*** VikasC has quit IRC11:56
*** otter768 has quit IRC11:57
dimsjaypipes: sdague: really easy one, doubles py34 coverage - https://review.openstack.org/#/c/228600/ - please take a look when you get a chance11:59
alex_xunova api meeting is running~12:01
sdaguedims: one thing in there, I thought we had decided to just use .items12:01
sdaguebecause the micro benchmarks are pointless here12:01
*** markvoelker has joined #openstack-nova12:03
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Identify more py34 tests that already pass  https://review.openstack.org/22860012:03
dimssdague: duh! slipped my mind. sorry, fixed.12:03
sdaguedims: +212:04
dimsthanks!12:04
openstackgerritgaryk proposed openstack/nova: VMware: Use actual VM state instead of using the instance vm_state  https://review.openstack.org/19062712:05
*** markus_z has quit IRC12:06
*** Kevin_Zheng has joined #openstack-nova12:06
*** markvoelker has quit IRC12:07
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Slightly better translation friendly formatting  https://review.openstack.org/22400912:07
*** exploreshaifali has joined #openstack-nova12:07
*** aarefiev has quit IRC12:09
openstackgerritJohn Garbutt proposed openstack/nova: docs: re-organise the API concept docs  https://review.openstack.org/22625312:10
*** romainh has joined #openstack-nova12:10
*** bfic has joined #openstack-nova12:10
*** SunSeeker has joined #openstack-nova12:11
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Enable options for oslo.reports  https://review.openstack.org/21691712:11
*** aarefiev has joined #openstack-nova12:12
*** markus_z has joined #openstack-nova12:13
*** pm90_ has joined #openstack-nova12:13
*** deepakcs has quit IRC12:17
*** aysyd has joined #openstack-nova12:17
*** pm90_ has quit IRC12:20
*** pm90__ has joined #openstack-nova12:20
openstackgerritSudipta Biswas proposed openstack/nova: use helper method to remove version hardcoding  https://review.openstack.org/22857812:20
*** pm90__ has quit IRC12:20
*** raildo-afk is now known as raildo12:21
bficHey guys, I need to get local block device names from instance to pass as a 'migrate-disks' param to migrateToURI3. How can I proper get them? Other methods in libvirt driver has "block_device_info" as a parameter, but live_migration_operation no. Any idea ?12:22
*** Daisy has joined #openstack-nova12:27
*** tdurakov has quit IRC12:30
*** rfolco has joined #openstack-nova12:30
*** Daisy has quit IRC12:30
*** tdurakov has joined #openstack-nova12:30
*** bswartz has quit IRC12:30
*** edmondsw has joined #openstack-nova12:31
*** Sree has quit IRC12:31
bauzassdague: yup, re: https://bugs.launchpad.net/nova/+bug/1500289 there is a reschedule coming from the compute (2nd stacktrace) because there was a driver exception on spawn() (1st trace)12:31
openstackLaunchpad bug 1500289 in OpenStack Compute (nova) "Booting instance failed with Kilo stable compute node and liberty controller" [Critical,Fix committed] - Assigned to Alex Xu (xuhj)12:31
*** claudiub has joined #openstack-nova12:31
*** Sree has joined #openstack-nova12:31
bauzassdague: so it called the conductor using the previous InstanceV112:32
*** kiran-r has quit IRC12:32
*** markvoelker has joined #openstack-nova12:32
*** EinstCrazy has quit IRC12:34
*** Sree has quit IRC12:36
*** dims_ has joined #openstack-nova12:36
*** aix has quit IRC12:37
*** artom has quit IRC12:37
*** EinstCrazy has joined #openstack-nova12:40
*** dims has quit IRC12:40
*** exploreshaifali has quit IRC12:40
*** meh_di has joined #openstack-nova12:45
bauzasjohnthetubaguy: feature classification ? that's not the first time I heard of it, but could you please explain me what is it ?12:47
meh_diHELP//12:47
bauzas(I mean, I have some idea but I'm perhaps wrong)12:47
*** oomichi_ has joined #openstack-nova12:47
meh_diplease tell me how can debug nova remotely12:47
*** xyang1 has joined #openstack-nova12:48
bauzasmeh_di: http://docs.openstack.org/developer/nova/devref/development.environment.html#using-a-remote-debugger12:49
openstackgerritSudipta Biswas proposed openstack/nova: use helper method to remove version hardcoding  https://review.openstack.org/22857812:49
*** Alexus has quit IRC12:51
*** alejandrito has joined #openstack-nova12:52
*** dims_ has quit IRC12:53
*** thangp has joined #openstack-nova12:54
meh_dibauzas: I know this, I am using pycharm. I followed the  http://blog.jetbrains.com/pycharm/2010/12/python-remote-debug-with-pycharm but I need to know what is the remote host in this case? Is that Compute Node ?12:54
*** breitz has quit IRC12:54
*** breitz has joined #openstack-nova12:54
bauzasmeh_di: from your opinion ?12:55
meh_dibauzas: I dont undrestand your question12:56
bauzasmeh_di: I was just asking you to consider your question12:57
bauzasmeh_di: so, you want to troubleshoot a process, right?12:57
meh_diyes12:57
bauzasmeh_di: in that case, you know that you'll run the remote option for12:58
bauzas*that* process12:58
*** Daisy has joined #openstack-nova12:58
bauzasie. nova-scheduler, nova-api, nova-conductor, nova-manager etc.12:58
johnthetubaguybauzas: its written up here: https://review.openstack.org/#/c/215664/12:59
bauzasjohnthetubaguy: ack, CC'ing it12:59
johnthetubaguybauzas: basically its the hypervisor support matrix, with more dimensions added12:59
bauzasjohnthetubaguy: okay I need to read the spec before hassling you with silly questions13:00
bauzas:)13:00
johnthetubaguybauzas: basically, link actual tempest test uuids, link to real docs, link to real CI results, in an ideal world13:00
*** ijuwang has joined #openstack-nova13:00
*** salv-orlando has quit IRC13:01
johnthetubaguybauzas: so you have a feature rating, and a rating for each feature against a specific CI setup13:01
sdaguebauzas: basically it's actually trying to describe to end users what they can get out of the cloud, because there are API features which are implementation specific13:01
johnthetubaguysdague: yeah +113:01
*** dims has joined #openstack-nova13:01
bauzassdague: I see, okay :)13:02
bauzasthanks for the pointer, will look into it13:02
*** sudipto has quit IRC13:02
*** dave-mccowan has joined #openstack-nova13:03
openstackgerritAnkit Agrawal proposed openstack/nova: Test patch libvirt race condition (do not merge)  https://review.openstack.org/19173213:03
oomichi_re: auto-generating api doc: We can get most part of api doc(resource url, normal status code, sample request/response) from tempest.log13:03
*** ildikov has quit IRC13:03
oomichi_re: auto-generating api doc: This way is possible to be applied to all projects13:03
*** mdrabe has joined #openstack-nova13:04
oomichi_re: auto-generating api doc: In nova, we can create the descriptions of api parameters of request from json-schema13:04
*** moshele has quit IRC13:04
johnthetubaguyoomichi_: yeah, json schema works13:05
oomichi_re: auto-generating api doc: there is json-schema of nova *response* in Tempest now13:05
johnthetubaguyyeah13:05
*** VW has joined #openstack-nova13:05
oomichi_re: auto-generating api doc: we will be able to migrate response schema also from Tempest to nova with Tempest's external plugin interface13:05
oomichi_re: auto-generating api doc: After the migration, we can get the descriptions of api parameters of response also13:06
oomichi_re: auto-generating api doc: then, we can get complete api doc automatically13:07
*** mriedem_away is now known as mriedem13:07
meh_dibauzas: replace the IP of Compute node  insteed of the IP of remote server13:07
bauzasmeh_di: that depends on what you want to introspect13:09
bauzasmeh_di: that's just a remote debugger13:10
johnthetubaguyoomichi_: seems like a very sound approach to me13:10
bauzasmeh_di: so you need to put a breakpoint on where you want to introspect13:10
*** annegentle has joined #openstack-nova13:11
bauzasmeh_di: meaning that you should point your IDE to the nova service you want to debug (again, either the API, or the conductor, or the scheduler, or one of the compute managers)13:11
pkholkinHello guys! We are working on patch 'switching to oslo_db.enginefacade' in nova. We already have init patch https://review.openstack.org/#/c/221310/12 and two other patches that use enginefacade13:11
meh_dii am studing nova code already13:12
pkholkinCould you please look, we are not sure that we configure enginefacade correctly13:12
bauzasmeh_di: so you don't need a remote debugger, static code analysis is enough IMHO13:12
pkholkinwe add 'configure' method in /cmd/manage.py but we don't really configure in services (in production code)13:12
jsuchomemriedem: hi, could I ask about https://review.openstack.org/#/c/225119/ ? Do you really think it has to wait until some discussion with cinder developers?13:12
bauzasmeh_di: begin with a very simple scenario : "I want to boot a single VM with just a flavor and an image"13:13
pkholkinjaypipes: Hello Jay! Could you help me with the question above13:13
bauzasmeh_di: so, start with the API resource corresponding to that and enter the rabbit hole13:13
mriedemjsuchome: this is the fix we want https://review.openstack.org/#/c/227564/13:13
pkholkinand advise whom to ask too13:13
openstackgerritKen'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order  https://review.openstack.org/22765013:13
bauzasjohnthetubaguy: oh, we haven't yet merged jogo's changes for the architecture ?13:15
bauzas(devref, I mean)13:15
jsuchomemriedem: ah, cool!13:15
bauzasmeh, pointing to the Kilo doc13:16
mriedemjsuchome: i also duplicated the bug on yours to something else13:16
jsuchomemriedem: yes, I was wondering, if your patch shouldn't also reference that bug13:16
bauzasjohnthetubaguy: nvm, my cookie was pointing me to a stable doc branch13:17
johnthetubaguybauzas: yeah, not sure we have, do you have the review link?13:17
bauzasjohnthetubaguy: nah it's good http://docs.openstack.org/developer/nova/architecture.html13:17
bauzasfor some reason, my doc footer was telling me I was looking at 2015.1.1 devref13:17
bauzasso I had to go up to the main docs site, and go back13:18
mriedemjsuchome: it depends on the case, in bug 1497253 you're talking about cross_az_attach being True and False13:18
openstackbug 1489575 in Cinder "duplicate for #1497253 Cinder always tries to create volumes in Cinder AZ with same name as Nova AZ" [Medium,Fix released] https://launchpad.net/bugs/1489575 - Assigned to Edmund Rhudy (erhudy)13:18
bauzasmeh_di: look at this http://docs.openstack.org/developer/nova/architecture.html13:18
mriedemin the False case, the AZ is set and has to be on the cinder side13:18
pkholkinmriedem: Good day Matt! Could you please help with patch related to enginefacade? https://review.openstack.org/#/c/221310/1213:18
mriedemjsuchome: if not set in cinder, then you either have to create the AZ in cinder or set allow_availability_zone_fallback=True in cinder.conf13:18
mriedempkholkin: why do we want this engine facade thing?13:19
bauzasmeh, catching up some convo about AZs13:19
bauzasmy AZ radar just blinked on my screen13:19
pkholkinmriedem: it related to this spec http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/oslo_db-enginefacade.html13:20
mriedempkholkin: why don't we have a specless trivial blueprint for the enginefacade stuff?13:20
*** dustins has joined #openstack-nova13:21
pkholkinmriedem: we communicate with Matthew Booth, he promised to update it for Mitaka13:21
mriedempkholkin: ok, seems that should be reproposed for mitaka as a trivial re-propose13:21
pkholkinmriedem: yes, right13:21
mriedempkholkin: and your changes aren't linked to the bp13:21
jsuchomemriedem: hm, my case is when cross_az_attach is False, and as I look at your last patch, I think it will behave the same way as it does now13:21
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: libvirt: Log warning for wrong migration flag config options  https://review.openstack.org/22885313:21
*** obedmr has joined #openstack-nova13:21
openstackgerritgaryk proposed openstack/nova: VMware: raise NotImplementedError for live migration methods  https://review.openstack.org/22889313:21
mriedemjsuchome: yes, my patch is really for the cross_az_attach case13:21
*** links has quit IRC13:22
pkholkinmriedem: yes, correct, it will be done, we already work on code13:22
mriedemjsuchome: like i said, if cross_az_attach is False you either have to have the same AZ in cinder as you're booting into in nova or you have to set allow_availability_zone_fallback=True in cinder.conf to avoid the error13:22
*** jdurgin1 has joined #openstack-nova13:23
pkholkinmriedem: we have a question related to the patch, could you try to help us13:23
jsuchomemriedem: I think that fallback does not help, it's there for cases when wanted cinder AZ would not be available, right?13:23
mriedemjsuchome: right13:23
mriedemi personally don't see a good reason for that fallback option in cinder, it's clearly a hack in cinder to workaround the bug(s) in nova related to that cross_az_attach option13:23
mriedemjsuchome: if you haven't noticed yet, there is a big thread in the ML about this13:24
jsuchomewhich is not my case, the problem is, volume is correcly created in existing AZ, instance would be correctly created in different nova's AZ,but user doesn't want this to happen13:24
mriedemthen set cinder.cross_az_attach=True in nova.conf13:25
pkholkinmriedem: there are two facades there for main and api databases, so we need to configure them exactly once with their config options, we inserted it here https://review.openstack.org/#/c/221310/12/nova/cmd/manage.py13:25
pkholkinmriedem: but we are not sure in this code, because we don't call configure in services like nova-api (in production code)13:25
pkholkinmriedem: do you know how it should be and what services need api database?13:26
jsuchomemriedem: ok, customer requires cross_az_attach=False... and it works if he provides explicit AZ to nova when booting instance, but not with no AZ provided13:26
jsuchome(yes, I've seen the ML)13:26
mriedemjsuchome: i guess you should provide more details in your bug report then. is this a boot from volume case where the volume is provided (bdm.source=volume)?13:27
mriedempkholkin: that's a good question for alaski but the api db would be for the nova-api service i believe13:27
*** Daisy has quit IRC13:27
oomichi_johnthetubaguy: sdague: gmann: If we can implement complete api doc and the same single API between clouds for interoperability,13:27
oomichi_johnthetubaguy: sdague: gmann:  the value of json-home is not so high13:27
jsuchomeit's boot from volume, but user doesn't want to explicitely provide AZ, just wants to nova to pick the one, and let cinder use the same name in cinder13:27
jsuchomemriedem: I'll update bug report, it's likely I wasn't clear enough13:28
oomichi_johnthetubaguy: sdague: gmann: because api users can know how to use api from the doc completely13:28
alaskimriedem: pkholkin reading scrollback13:28
*** alejandrito has quit IRC13:28
mriedemjsuchome: yeah, but my point is nova doesn't know the volume AZ unless the volume is provided in the boot from volume case13:28
*** rlrossit has joined #openstack-nova13:29
pkholkinmriedem: ok, thanks for adding him, do you think we should add such configure in some other services?13:29
mriedemjsuchome: if the case is, cinder.cross_az_attach=False, nova boot w/o nova AZ provided, and bdm.source=volume and volume has an AZ set - and you want to boot the instance into that same AZ that the volume is in, then that's a new thing13:29
alaskipkholkin: as mriedem said it will need to be configured for nova-api, and also nova-conductor.  For now.  That may expand later13:30
jsuchomemriedem: I think volume hasn't AZ set, several boots can can end in different AZ's, the requirement is just that they are same for nova and cinder side13:30
mriedemjsuchome: and nova is creating the volume?13:31
*** twinklechawla has joined #openstack-nova13:31
jsuchomeyes13:31
*** salv-orlando has joined #openstack-nova13:31
mriedemjsuchome: then if an AZ isn't specified on nova boot, then it should be None and there shouldn't be an AZ used for either the server or volume13:31
pkholkinalaski: ok, we will add 'configure' to /cmd for these services too13:31
*** ctrath has joined #openstack-nova13:31
mriedemjsuchome: if cinder is randomly assigning an AZ to the volume then that seems like a cinder bug13:31
mriedemotherwise if you want to be in a specific AZ for the server, that has to be provided at boot13:32
openstackgerritMarkus Zoeller (markus_z) proposed openstack/nova: libvirt: Log warning for wrong migration flag config options  https://review.openstack.org/22885313:32
*** oomichi_ has quit IRC13:32
jsuchomemriedem: I have to leave now, thanks for help, I'll look at cinder conf more closely13:33
pkholkinmriedem, alaski: another question, about nova-cells, we wanted to deploy devstack with nova-cells and try to test our patch but be can't13:33
*** jsuchome has quit IRC13:33
pkholkinmriedem, alaski: we found several guides and this doc http://docs.openstack.org/kilo/config-reference/content/section_compute-cells.html, is there something else?13:34
alaskipkholkin: why not?  There are instructions in the readme for Devstack13:34
*** stevemar has joined #openstack-nova13:34
mriedemhttp://docs.openstack.org/developer/devstack/configuration.html?highlight=cells#cells13:35
pkholkinalaski: could you please some link?13:35
pkholkinmriedem, alaski: should it be multinode rigth?13:35
*** stevemar_ has joined #openstack-nova13:36
mriedemit's single node in the gate13:36
alaskipkholkin: https://github.com/openstack-dev/devstack/blob/master/doc/source/configuration.rst#cells13:36
alaskiI guess it moved out of the Readme13:36
markus_zThe cell feature is done via a service? I thought it was solely done via the REST API?13:36
*** haomaiwang has joined #openstack-nova13:36
mriedemlet's all gather round and let old man laski explain cells v1 and cells v213:37
mriedemmarkus_z: http://docs.openstack.org/developer/nova/cells.html13:37
alaskimarkus_z: it's done by two main mechanisms.  The compute api is subclassed and methods or RPC methods are overridden.  They are overriden to send RPC messages to a cells service which proxies them to the appropriate cell13:37
*** stevemar_ has quit IRC13:37
*** stevemar_ has joined #openstack-nova13:38
pkholkinI also don't understand waht should be in nova_cell database and what it nova_api database, could you please explain?13:38
markus_zalaski: I see, thanks. I must have noted down something wrong.13:38
alaskipkholkin: you seem to be interested in the nova_api database which is not used in cells v1.  And devstack is only setup for cellsv113:39
*** stevemar has quit IRC13:39
alaskipkholkin: so you may be able to ignore that13:39
mriedemalthough devstack does create the nova-api db13:39
mriedemto run the migrations13:39
*** ildikov has joined #openstack-nova13:39
alaskiyeah13:39
*** alejandrito has joined #openstack-nova13:40
*** haomaiwang has quit IRC13:40
lxsliNow Mitaka is open, anyone fancy https://review.openstack.org/#/c/215568 and https://review.openstack.org/#/c/215613 re: bug 1428639 please? They've been up a while and had some +1s13:40
openstackbug 1428639 in openstack-ansible "Nova requires python-libguestfs in Kilo" [Medium,Fix released] https://launchpad.net/bugs/1428639 - Assigned to Kevin Carter (kevin-carter)13:40
alaskione key point that I should probably write down is that cellv2 will sort of just happen.  it shouldn't require much in the way of a different configuration for devstack13:40
alaskijust a few additional calls to setup the new db, and some migrations of data at some poitn13:40
*** aix has joined #openstack-nova13:40
*** haomaiwa_ has joined #openstack-nova13:40
*** tdurakov has quit IRC13:40
twinklechawlaHello everyone, Till date I read about nova, cloned openstack-dev/devstack and openstack/nova. I am new to this, so any one who can help me with it?13:41
pkholkinmriedem, alaski: sorry but I don't fully understand what information is stored in nova_api and what in nova_cell dbs and how are they related13:41
*** tdurakov has joined #openstack-nova13:42
alaskipkholkin: they are not is the short answer13:42
pkholkinalaski: ok) and could be describe also short about data in them)13:42
pkholkinalaski: ok) and could you describe also short about data in them)13:42
alaskipkholkin: the nova_api database will store information for the nova API to use to talk to the proper cell, as well as "global" data like flavors13:42
alaskithat's for cellsv213:43
alaskithe nova_cells db is for cellsv1, and has the local cell copy of the nova db.  In other words the nova db is an aggregate of all nova_cell dbs in a deployment13:43
*** burt has joined #openstack-nova13:44
bauzas... too ... much ... convos ... to ... read13:44
*** jaypipes has quit IRC13:44
markus_ztwinklechawla: A good starting point is here: https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer13:45
*** julien_ZTE has joined #openstack-nova13:46
pkholkinalaski: try to understand) hm, we will look through you given links and messages, thanks a lot!!!13:46
*** mdbooth_ has joined #openstack-nova13:46
pkholkinalaski: one last question right now, do you think if we add configuring facade in nova-api and nova-conductor services too should everything works ok?13:47
pkholkinI mean what should we try or test13:47
jrollbauzas: that's what you get for looking away from IRC for 2 seconds :D13:48
alaskipkholkin: the main thing right now is that the nova_api db migrations continue to run.  they're being run in devstack so you should see failures there if that breaks13:48
bauzasjroll: well, my radar screen gave me lots of plots about AZs and cells13:48
jrollheh13:49
mriedemdims: i see a few places in nova where context is passed as a kwarg to logging methods, like the instance kwarg - is there a reason for that?13:49
pkholkinalaski: ok (this job gate-tempest-dsvm-cell is for cells v1?)13:49
*** marzif has quit IRC13:49
*** jaypipes has joined #openstack-nova13:49
*** mdbooth has quit IRC13:49
*** mdbooth_ is now known as mdbooth13:49
mriedempkholkin: yes13:50
*** erlon has joined #openstack-nova13:50
pkholkinmriedem, alaski: Thanks you guys a lot for the answers! We will continue working in it13:50
dimsmriedem: i think when we elevate up the privilege to admin we have to log the original context (if i remember right)13:51
openstackgerritChuck Carmack proposed openstack/nova-specs: Allow user to set and retrieve the server Description  https://review.openstack.org/22890813:51
pkholkinmdbooth: Hello Matthew, could tou please update your spec related to enginefacade for Mitaka please http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/oslo_db-enginefacade.html13:51
mriedemdims: because the request info is in the context?13:51
dimsy13:52
pkholkinmdbooth: we continue working on our patches https://review.openstack.org/#/c/221310/1213:52
*** otter768 has joined #openstack-nova13:52
mriedemdims: seems that if we're using oslo.context's RequestContext, then we don't need to pass in the context kwarg http://docs.openstack.org/developer/oslo.log/usage.html#passing-context13:53
alaskipkholkin: mriedem the migration gets run if nnova-api is enabled https://github.com/openstack-dev/devstack/blob/master/lib/nova#L72213:53
mriedemdims: if i'm reading that correctly13:53
dimsmriedem: a real easy one - https://review.openstack.org/#/c/228600/ - doubles the py34 test coverage13:53
*** nkrinner has quit IRC13:53
dimsmriedem: let me go back and read the code13:53
mriedemdims: b/c otherwise i think we actually have problems in nova b/c i've seen elevated contexts passed as kwargs to logging methods13:53
alaskipkholkin: which means every nova tempest job will run it.  There are also functional tests in tree for the nova_api db13:53
*** Sree has joined #openstack-nova13:54
*** stevemar_ is now known as stevemar13:54
*** irenab has quit IRC13:54
dimsmriedem: right, if code is elevating, then the original context must be used as context= parameter13:55
pkholkinalaski, mriedem: the problem was that jenkins marked +1 but we were not sure that everything is configured correctly (mostly related to api db)13:56
dimsthis is clearly wrong mriedem13:56
dims        context = context.elevated()13:56
dims        LOG.info(_LI("Rebooting instance"), context=context, instance=instance)13:56
mriedemdims: yeah, i guess i'm trying to simplify it and just figure out (1) if you're using oslo.context in your app then (2) you shouldn't have to pass the context kwarg to logging methods13:56
mriedembecause if ^ is true we could have a hacking check for it in nova13:57
alaskipkholkin: I'm not actually sure if a failure would cause a test failure.  It depends on what the 'nova-manage db_sync' returns for a failure13:57
*** otter768 has quit IRC13:57
dimsmriedem: even if you are using oslo.context when you elevate you should still be able to specify the original context to log13:57
mriedemdims: but do you need to?13:58
*** pm90_ has joined #openstack-nova13:58
dimsmriedem: i believe so13:58
pkholkinalaski: yes, that's why we are asking) do you have thoughts how to test it for sure (with devstack e.g.)13:59
dimsmriedem: hang on, reading the elevated method in nova's context.py13:59
alaskimriedem: oslo.logging will use the context that's set in http://git.openstack.org/cgit/openstack/oslo.context/tree/oslo_context/context.py#n71.  If you want to log a different context you would pass it13:59
alaskiget_admin_context defaults to not overwriting that14:00
mriedemi don't know why we would pass a different one in though14:00
mriedemelevated() just sets the admin bit14:00
mriedemrequest id and user/project stay the same14:00
dimsalaski: if you are using elevated() looks like it will work fine. if you use get_admin_context() then it wont14:00
alaskiyeah, I can't think of a reason at the moment14:00
*** haomaiwa_ has quit IRC14:01
mriedemdims: yeah using get_admin_context() instead would be bad14:01
*** haomaiwa_ has joined #openstack-nova14:01
alaskiget_admin_context will create a new context, but not overwrite the one that logging would use.  so I guess it depends on what you intend on logging14:02
*** iurygregory has joined #openstack-nova14:02
dimsright, it's there in oslo.log if nova chooses to use it14:02
openstackgerritSylvain Bauza proposed openstack/nova: Manifesto for working on Tasks  https://review.openstack.org/22128014:03
dims+1 to check all usages and remove context= if it's not needed14:03
mriedemyeah....i just did a search14:03
mriedemat least 36 hits on the same line14:03
*** annegentle has quit IRC14:03
mriedemi can clean those up in a bit, i'm getting sidetracked14:04
*** tdurakov has quit IRC14:04
kashyapCan I just respond to launchpad bug emails from my mail client?  IIRC, LP allows that.14:05
kashyapHmm, this is off-topic here.14:05
markus_zkashyap: Some bug comments look like that this is possible14:05
twinklechawlaI cloned the code but I am unable to understand it  --> /devstack/nova14:06
kashyapmarkus_z: Yeah, I'm trying to confirm if I can just do that, it'd be much nicer rather than loading a million bugs in my browser.14:06
*** eharney has quit IRC14:06
mriedemdims: can you confirm the description in this bug makes sense? https://bugs.launchpad.net/nova/+bug/150089614:07
openstackLaunchpad bug 1500896 in OpenStack Compute (nova) "It's not necessary to pass context as kwarg to oslo.log in most cases" [Low,Triaged]14:07
*** mc_nair has joined #openstack-nova14:07
dimsmriedem: ++14:07
mriedemctrath: ccarmack: rlrossit: doffm_: low hanging fruit bug https://bugs.launchpad.net/nova/+bug/150089614:08
dimsmriedem: is cloudpipe stuff a thing anyone uses?14:10
dimsand the nova-objectstore14:10
markus_ztwinklechawla: I'm afraid you have to ask very specific questions.14:10
*** mdrabe has quit IRC14:11
mriedemdims: don't know14:11
twinklechawlamarkus_z: I am very new this, so need help!14:12
raildohi guys, I'm with a doubt here, there is some tests like this: https://github.com/openstack/nova/blob/master/nova/tests/unit/test_quota.py#L1209-L1214 that expect return the remains quotas for a project but the quota calculation sounds odd to me.14:12
markus_ztwinklechawla: Did you already have the change to read https://wiki.openstack.org/wiki/How_To_Contribute ?14:13
raildolike... I have a limit = 5, in_use =2, reserved = 2, how remains can be equal zero?14:13
markus_z*chance14:13
twinklechawlamarkus_z:I read this!14:13
markus_ztwinklechawla: OK, cool, any questions to that?14:14
*** achanda has joined #openstack-nova14:15
dimsmriedem: alaski: couple of easy ones if you get a chance https://review.openstack.org/#/c/228600/ and https://review.openstack.org/#/c/228688/ - first one doubles the py34 coverage and the 2nd one is a mechanical replacement with a hacking rule for contextlib.nested14:15
dimstwinklechawla: opw?14:15
twinklechawlamarkus_z: I went to "Getting_the_code" and cloned 'nova' to my filesystem but there are many files to understand.14:15
dimstwinklechawla: are you trying to pick a project to work on?14:15
twinklechawladims: yes!14:16
raildomelwitt, ping, are you around?14:16
dimstwinklechawla: so yes, Nova is a large codebase, i usually recommend picking up a small bug/problem and try to figure out the code just for that piece, as you go along you will learn more and more of it14:17
*** thangp has quit IRC14:19
twinklechawladims: okay, I got it. But can you plz help me to get that 'problem' which I can solve?14:19
*** rfolco has quit IRC14:19
*** rfolco has joined #openstack-nova14:19
markus_zdims: twinklechawla: Maybe that one: https://bugs.launchpad.net/nova/+bug/1357751 ?14:20
openstackLaunchpad bug 1357751 in OpenStack Compute (nova) "nova.tests.network.test_manager.AllocateTestCase should use mock" [Low,In progress]14:20
raildotwinklechawla, there is a low-hanging-fruit bug list here: https://bugs.launchpad.net/nova/+bugs?field.tag=low-hanging-fruit14:20
*** thangp has joined #openstack-nova14:21
raildotwinklechawla, usually this bugs are easy to solve14:21
*** achanda has quit IRC14:22
*** SunSeeker has quit IRC14:23
twinklechawlamarkus_z: raildo: dims: Please, make me understand, what kind of bugs are there in ''nova.14:23
mriedemtwinklechawla: there are 582 bugs that aren't in progress, so you can take your pick :)14:24
mriedemtwinklechawla: there is newcomer stuff in the nova wiki here https://wiki.openstack.org/wiki/Nova/Mentoring14:25
*** Murali has quit IRC14:25
*** changbl has joined #openstack-nova14:25
dimsalaski: thanks!14:25
alaskidims: np.  will find time for the second one in a bit14:26
dimsmriedem: ah! looks like i could use a mentor :)14:26
*** artom has joined #openstack-nova14:28
twinklechawlawell! I got very confused while watching these bugs :|14:29
*** asettle has quit IRC14:29
*** annegentle has joined #openstack-nova14:29
markus_ztwinklechawla: That's normal.14:30
twinklechawlaReally?14:30
markus_ztwinklechawla: yes. Get's better after a few months. :)14:31
raildotwinklechawla, what kind of bug do you expect resolve? docs? database? some exception error?14:31
raildomarkus_z, ++14:32
*** gszasz has quit IRC14:33
twinklechawlamarkus_z: Is it necessary to submit a patch, before Application Deadline?14:33
dimstwinklechawla: wrong channel for that question, you should ask the opw admins on their irc channel14:33
markus_zwhat's "opw"?14:34
twinklechawlamarkus_z: Outreachy Program for Women :)14:35
*** phschwartz has quit IRC14:36
*** phschwartz has joined #openstack-nova14:36
dimstwinklechawla: this may be a easier bug https://bugs.launchpad.net/nova/+bug/1398629, there are several tests that use REQUIRES_LOCKING = True, you can pick one of those tests and fix it as mentioned in the bug report14:36
openstackLaunchpad bug 1398629 in OpenStack Compute (nova) "Fix buggy tests that use REQUIRES_LOCKING=True" [Medium,Confirmed] - Assigned to Sean Dague (sdague)14:36
*** MVenesio has joined #openstack-nova14:38
*** mdrabe has joined #openstack-nova14:39
dimstwinklechawla: example see nova/tests/unit/virt/vmwareapi/test_configdrive.py, flip the REQUIRES_LOCKING variable to False and you will see that when you run tests using "tox -e py27" it will fail, you need to figure out how to fix the test and submit a patch14:39
*** salv-orlando has quit IRC14:39
dimsmarkus_z: agree? ^14:40
twinklechawladims: okey.. now I understood the thing! Thanks dim! Now I'll check it out!14:41
markus_zdims: yeah, sounds like a good start14:41
*** su_zhang has joined #openstack-nova14:43
*** electrocucaracha has joined #openstack-nova14:43
openstackgerritSergey Nikitin proposed openstack/nova: WIP: Use legacy engineFacade from oslo_db.enginefacade  https://review.openstack.org/22131014:44
openstackgerritSergey Nikitin proposed openstack/nova: WIP: use oslo_db.enginefacade  https://review.openstack.org/22897914:44
*** electrocucaracha has quit IRC14:44
openstackgerritChuck Carmack proposed openstack/nova-specs: Allow user to set and retrieve the server Description  https://review.openstack.org/22890814:45
*** electrocucaracha has joined #openstack-nova14:45
openstackgerritMatt Riedemann proposed openstack/nova: Add checkpoint logging when building an instance in compute manager  https://review.openstack.org/22898014:45
mriedemalaski: following up from logging talk yesterday with the large ops bug ^14:45
*** rfolco has quit IRC14:45
*** rfolco has joined #openstack-nova14:47
alaskimriedem: there's a StopWatch thing you can use from oslo.utils if you wish http://git.openstack.org/cgit/openstack/oslo.utils/tree/oslo_utils/timeutils.py#n325 but I'm not -1 on that14:47
*** mtanino has joined #openstack-nova14:47
*** digimonde has quit IRC14:48
alaskilooks reasonable otherwise14:48
mriedemalaski: seems like a sledehammer14:48
alaskiyeah, just wanted to mention it14:48
dansmithmriedem: do you really want info on all those except the timing one?14:48
dansmithmriedem: for a busy cloud that's a lot of noise14:49
mriedemthe timing one is debug14:49
dansmithright14:49
mriedemStarting instance is already info14:49
openstackgerritChuck Carmack proposed openstack/nova-specs: Allow user to set and retrieve the server Description  https://review.openstack.org/22890814:49
dansmithright, but you're adding several more infos for each instance14:49
dansmithif alaski thinks it's cool, then that's good enough for me14:49
mriedemlet me consult the all knowing and all powerful openstack logging guidelines handbook14:49
mriedemhttps://wiki.openstack.org/wiki/LoggingStandards#Messages_at_INFO_should_be_a_unit_of_work14:50
alaskiwell I might be a bit biased since we run on debug anyways.  but it's a fair point14:50
dansmithheh14:50
dansmithand also wow14:50
dansmithalthough not surprising14:50
mriedemi guess according to https://wiki.openstack.org/wiki/LoggingStandards#Messages_at_INFO_should_be_a_unit_of_work and what i'm adding, it'd fall into the 'bad' category14:51
mriedemalthough https://wiki.openstack.org/wiki/LoggingStandards#Messages_at_INFO_should_be_a_unit_of_work has always confused me14:51
alaskiit's a lot of data.  but I really can't imagine not having it right now14:51
mriedemgood = thing is done14:51
mriedembad = starting thing14:51
*** achanda has joined #openstack-nova14:51
dansmithright, I think that info for "building instance" or "instance is built" is a unit of work14:51
*** armax has joined #openstack-nova14:51
dansmith"doing step 12" is not14:51
*** twinklechawla has quit IRC14:52
mriedemi can change to all being debug14:52
alaskidansmith: you're recommending switching them all?14:52
dansmithalaski: well, I'm just asking, but they feel like debugs to me14:52
*** lykinsbd_ has joined #openstack-nova14:52
alaskiyeah.  although now you've almost convinced me that the "Took x seconds..." one should be info14:52
mriedemdo you need a biased 3rd party opinion?14:52
dansmithalaski: really?14:53
mriedemgiven https://wiki.openstack.org/wiki/LoggingStandards#Messages_at_INFO_should_be_a_unit_of_work the timing one would be info14:53
alaskiwell that one is a unit of work right?14:53
mriedemsince it's basically 'built instance'14:53
mriedem'build instance in x seconds'14:53
mriedem*built14:53
dansmiththere is an existing info for that right? or is that "starting build" ?14:53
mriedemthat's 'Starting instance'14:54
tojuvonedansmith: I was gathering these several comments to update get-valid-server-state review.. but to proceed better couple of questions14:54
mriedemat the top of that method14:54
mriedemwhich is arguably not info level14:54
*** salv-orlando has joined #openstack-nova14:54
dansmithmriedem: maybe the existing should be debug and your timing one should be info?14:54
dansmithtojuvone: sure, shoot14:54
mriedemdansmith: i think that's what alaski is saying14:54
mriedemand i'd be ok with that14:54
alaskiyeah, that seems the best to me14:54
mriedemand changing 'starting instance' to debug14:54
dansmithyep, okay14:54
mriedemhot damn!14:55
*** lpetrut has quit IRC14:55
tojuvonedansmith one would be if to expose even more from service, like enabled/disabled. Would that be good?14:55
dansmithtojuvone: yeah, I think I said that in one of my comments, and that seems to be the desire from the others14:55
dansmithtojuvone: I think it'd be good to think about what things to expose there and make them more abstract than the actual names we have for them14:55
dansmithtojuvone: meaning, maybe not enabled/disabled/force-down/unknown but something like 'normal/maintenance/down/unknown'14:56
tojuvoneyes, for now I was thinking: host_state and host_status14:56
tojuvoneenabled/disabled + up,forced_down and unknown14:57
dansmithtojuvone: hmm, so two keys?14:57
*** irenab has joined #openstack-nova14:57
tojuvonehost_status that is straight enabled/disabled14:58
*** tpeoples has joined #openstack-nova14:58
tojuvonehost_state that is up,forced_down or unknown14:58
dansmithtojuvone: but that becomes six possibilities instead of four14:58
dansmithtojuvone: I dunno, I feel like a single key is all we really need, but if you feel strongly, you can propose it and write up the reasoning and we can have a look14:59
tojuvoneok... so you mean disabled to be translateed as maintenance?14:59
*** annegentle has quit IRC14:59
*** achanda has quit IRC14:59
dansmithtojuvone: yeah, or something suitable14:59
openstackgerritAnkit Agrawal proposed openstack/nova: Test patch libvirt race condition (do not merge)  https://review.openstack.org/19173214:59
*** angdraug has joined #openstack-nova14:59
openstackgerritMarian Horban proposed openstack/nova: [WIP]Remove wsgi functionality  https://review.openstack.org/21924814:59
dansmithtojuvone: some non-operator looking at "disabled" may think it means more down-ness than it does in a nova context14:59
*** annegentle has joined #openstack-nova15:00
tojuvonewell, I also think future if need to expose more, but still one key might do15:00
dansmithtojuvone: well, if you can think of additional things we might want in the future, that's good for the reasoning part :)15:00
tojuvoneLike if there would be "going_for_maintenance_soon" later15:00
*** haomaiwa_ has quit IRC15:01
tojuvoneit could be exposed to user in similar fashion15:01
dansmithmaybe15:01
*** haomaiwang has joined #openstack-nova15:01
dansmithbut write it up and we can look at it in the spec -- that's what it's for :)15:01
alaski+1 for details in the spec.  I'd like to offer comments but am multitasking currently15:01
tojuvonelyes, just to write things bit better to skip week of review ;)15:02
*** moshele has joined #openstack-nova15:02
dansmithwell, that's where we should be having the bulk of the discussion, because it's recorded15:02
dansmithwell, that's where we should be having the bulk of the discussion, because it's recorded15:02
dansmithoops :)15:02
*** pm90__ has joined #openstack-nova15:03
*** Piet_ has quit IRC15:03
*** pm90___ has joined #openstack-nova15:03
tojuvonedansmith: Other things is if to use policy, I need to figure what to write to that as not familiar15:04
*** dims has quit IRC15:04
*** pm90_ has quit IRC15:04
dansmithtojuvone: okay if you look through the other api code for policy-based authorizations that should help15:05
*** rdopiera has quit IRC15:05
tojuvonedansmith: Anyhow thanks for this, was helpful, might save a round of patch set ;)15:06
*** n0ano has joined #openstack-nova15:06
*** lpetrut has joined #openstack-nova15:06
dansmithtojuvone: there is a call authorize() that should be easy to grep for15:06
dansmithtojuvone: cool, I look forward to the revision :)15:06
dansmithtojuvone: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/keypairs.py#L275-L27615:07
*** pm90__ has quit IRC15:07
dansmithtojuvone: that is a conditional exposure of a thing based on policy15:07
openstackgerritMatt Riedemann proposed openstack/nova: Add checkpoint logging when building an instance in compute manager  https://review.openstack.org/22898015:08
tojuvonedansmith: Thanks :)15:08
*** rushil has joined #openstack-nova15:09
*** julien_ZTE has quit IRC15:09
*** amotoki has joined #openstack-nova15:10
*** hemnafk is now known as hemna15:10
ctrathmriedem: Regarding https://review.openstack.org/228980 , is self.driver.spawn(…) synchronous?15:10
*** zzzeek has joined #openstack-nova15:10
*** changbl has quit IRC15:11
*** julien_ZTE has joined #openstack-nova15:11
*** zerda-bis has quit IRC15:12
*** markus_z has quit IRC15:13
dansmithctrath: kinda has to be or the resource tracking and error recovery bits in that function wouldn't work, right?15:13
*** dims__ has joined #openstack-nova15:16
*** haomai___ has joined #openstack-nova15:16
*** sudipto has joined #openstack-nova15:16
*** browne has joined #openstack-nova15:17
*** pm90___ has quit IRC15:17
ctrathdansmith: derp.. yup15:18
*** haomaiwang has quit IRC15:18
ccarmackmriedem: I'm getting SSH connection timeouts in gate-dvsm-tempest-full, test_snapshot_pattern.  I see a bug about that: https://bugs.launchpad.net/grenade/+bug/1355573.15:19
openstackLaunchpad bug 1355573 in grenade "grenade volume scenarios periodically fail /w SSHTimeout" [Undecided,New]15:19
ccarmackmriedem: is this something I should look at?15:20
*** EinstCrazy has quit IRC15:21
mriedemccarmack: intermittent?15:25
*** doffm_ is now known as doffm15:25
*** pm90_ has joined #openstack-nova15:25
ccarmackmriedem:  It failed on a commit yesterday and then again on a recheck... so 2 in a row15:26
ccarmackFYI - https://review.openstack.org/#/c/225199/15:26
*** pm90__ has joined #openstack-nova15:27
*** stevemar has quit IRC15:27
jaypipesdims__: is there an oslo-specs repository somewhere, or do oslo specs go to openstack-specs?15:27
*** stevemar has joined #openstack-nova15:27
dims__yep, we have one openstack/oslo-specs15:28
jaypipesah, k15:28
mriedemccarmack: well if it's always failing, and you're not providing security groups, there is probably an issue there15:29
mriedemlike it can't ssh into port 2215:29
mriedemb/c you didn't setup security group rules15:29
*** stevemar_ has joined #openstack-nova15:29
*** pm90_ has quit IRC15:31
*** stevemar has quit IRC15:32
*** VW has quit IRC15:33
*** VW has joined #openstack-nova15:33
ccarmackmriedem:  hmm, the test could ssh into the server earlier in the write_timestamp step15:33
*** stevemar_ has quit IRC15:34
mriedemccarmack: oh, well that's weird then15:34
ccarmackmriedem: maybe its something I did to the test, I temporarily back out my change15:35
ccarmackI'll ..15:35
*** haomai___ has quit IRC15:35
*** rushil has quit IRC15:37
*** Daisy has joined #openstack-nova15:39
openstackgerritRyan McNair proposed openstack/nova: Add retry logic for removing device with LibVirt  https://review.openstack.org/22785115:42
*** salv-orl_ has joined #openstack-nova15:43
*** READ10 has joined #openstack-nova15:43
*** Daisy has quit IRC15:43
*** salv-orlando has quit IRC15:46
*** mwagner_ has quit IRC15:48
*** julien_ZTE has quit IRC15:48
*** eharney has joined #openstack-nova15:48
*** julien_ZTE has joined #openstack-nova15:49
mriedemsahid: are you still -1 on this? https://review.openstack.org/#/c/226925/15:49
*** jdurgin1 has quit IRC15:49
*** wanghua has joined #openstack-nova15:50
*** vilobhmm11 has joined #openstack-nova15:52
*** otter768 has joined #openstack-nova15:53
*** marzif has joined #openstack-nova15:54
mriedemdansmith: johnthetubaguy: err, aren't we missing db migration placeholders in stable/liberty? https://github.com/openstack/nova/tree/stable/liberty/nova/db/sqlalchemy/migrate_repo/versions15:54
*** vilobhmm111 has joined #openstack-nova15:54
dansmithmriedem: we add them for liberty in master15:54
dansmithbut yeah, we need to do that15:54
mriedemliberty in master? liberty is no longer master15:55
dansmiththey're on the release checklist so I assume johnthetubaguy was waiting for the final RC15:55
dansmithmriedem: right15:55
mriedemok, i thought they went into rc115:55
dansmithmriedem: if we add them to liberty itself then people on liberty will burn them immediately15:55
dansmithwe need them to reserve spots in master in case we have to backport something to liberry15:55
dansmither, liberty15:55
mriedemno, i mean when we opened liberty we did the placeholders in that change https://review.openstack.org/#/c/172185/15:56
mriedemfor mitaka we just bumped the version15:56
mriedemso we need a thing like https://review.openstack.org/#/c/172185/ in stable/liberty now15:56
mriedemthat goes into rc215:56
mriedemanyway, i think we agree, i can push that change15:56
*** vilobhmm11 has quit IRC15:56
johnthetubaguybut we need them in mitaka not liberty, I thought?15:57
dansmithjohnthetubaguy: right15:57
dansmithmriedem: we do not want them *in* rc215:57
johnthetubaguyI remember getting totally mixed up about this last time15:57
dansmiththe patch above was adding them to master(liberty) right after we cut kilo15:57
johnthetubaguyas dansmith mentioned, its all in here, to try and reduce the chance of screwing up: https://wiki.openstack.org/wiki/Nova/ReleaseChecklist15:57
johnthetubaguytotally should get that into master ASAP though15:58
sahidmriedem: yes, i'm not with you on this, we should do not break authorship of a spec15:58
*** otter768 has quit IRC15:58
mriedemsahid: the author of the spec is still the author15:58
mriedemthey aren't implementing the code15:58
mriedemsahid: like a backlog spec basically15:58
*** fawadkhaliq has joined #openstack-nova15:59
*** claudiub has quit IRC15:59
openstackgerritNikola Dipanov proposed openstack/nova-specs: spec document for sriov-physical-function-passthrough blueprint  https://review.openstack.org/21247216:00
mriedemsahid: the alternative is i can abandon the spec, the author won't implement it, and it will just never happen16:00
*** su_zhang has quit IRC16:00
*** electrocucaracha has quit IRC16:00
sahidmriedem: what is the problem to put his name on other contributors?16:00
johnthetubaguymriedem: what about adding co-authored note on the spec commit? not sure we have ever done that before16:00
mriedemsahid: b/c it's in the implementation section16:00
johnthetubaguythe contributors are the folks intending to submit code, usually16:00
mriedemand the author isn't implementing it16:01
mriedemjohnthetubaguy: right16:01
*** electrocucaracha has joined #openstack-nova16:01
mriedemi can add co-authored-by in the commit message if that helps move this along16:01
openstackgerritTerry Wilson proposed openstack/nova: network: Add external id on OVS port/interface for bridge lookup  https://review.openstack.org/20383516:01
sahidi remember to have implemented some specs from danpb, i'm not sure he will be happy if i removed his name for the specs16:01
openstackgerritTerry Wilson proposed openstack/nova: network: Add external id on OVS port/interface for bridge lookup  https://review.openstack.org/20383516:02
mriedemchrist i'm not sure why we're even nit picking over this16:02
mriedemi'll add him then16:02
sahidwe always have worked like that, i do not understand why you do not want to keep original author, it's a recognition and help new contributors to join community even if they are not developers16:03
danpbmriedem: i tend to think that the author of the spec should stay listed a a co-author in general, even if they don't write code, because its useful to know who came up with the design when reviewing it16:03
mriedemthis is a re-proposal of an approved spec16:04
mriedemthe original authors name is all over the blueprint in LP16:04
*** marzif has quit IRC16:05
mriedemmaybe we should just drop 'other contributors' from the spec in general b/c it doesn't actually matter16:05
mriedemchewbacca could show up and push a change in my bp series and i wouldn't care16:05
mriedem-2 - you're not listed in the spec chewy, sorry16:05
* dansmith snickers16:05
*** mudassirlatif has joined #openstack-nova16:06
danpbmriedem: the whole primary vs other contributors split is kind of crude16:06
meh_dibauzas: I want to undrestand how the nova code is run on moreover, I have already studied codes but debuging the code gives you more opportunity to undrestand how methods are called.16:06
*** vishwanathj has joined #openstack-nova16:06
danpbas many of the features are the work of several people over time16:06
*** pixelbeat has quit IRC16:06
openstackgerritMatt Riedemann proposed openstack/nova-specs: Re-propose spec for refresh-quotas-usage  https://review.openstack.org/22692516:08
*** raildo is now known as raildo-afk16:08
*** kiran-r has joined #openstack-nova16:08
ndipanovoh btw if anyone's interested in an easy re-post of a spec: https://review.openstack.org/#/c/228528/16:08
ndipanovdanpb, ^16:08
ndipanovjohnthetubaguy, ^16:08
*** pixelbeat has joined #openstack-nova16:10
*** EinstCrazy has joined #openstack-nova16:10
*** alexpilotti has joined #openstack-nova16:11
*** jlanoux has quit IRC16:12
*** twinklechawla has joined #openstack-nova16:12
*** Sree has quit IRC16:12
*** annegentle has quit IRC16:12
*** pm90__ has quit IRC16:15
*** meh_di has left #openstack-nova16:15
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: SameHostFilter should fail if host does not have instances  https://review.openstack.org/22903016:18
*** vilobhmm111 has left #openstack-nova16:18
*** matrohon has quit IRC16:19
*** EinstCrazy has quit IRC16:21
*** raildo-afk is now known as raildo16:22
*** Sree has joined #openstack-nova16:23
*** digimonde has joined #openstack-nova16:23
*** kairo has joined #openstack-nova16:23
*** alex_klimov has quit IRC16:24
*** unicell has quit IRC16:24
*** jistr has quit IRC16:26
*** ijw has joined #openstack-nova16:26
*** coreywright has quit IRC16:27
*** Sree has quit IRC16:29
dims__sdague: mriedem: seeing a bunch of large ops failures16:29
*** yassine__ has quit IRC16:30
*** Sree has joined #openstack-nova16:30
openstackgerritSudipta Biswas proposed openstack/nova-specs: Report host memory bandwidth as a metric in Nova  https://review.openstack.org/22903416:30
mriedemdims__: known issue16:31
mriedemdims__: https://review.openstack.org/#/c/228636/16:31
dims__mriedem: k thanks.16:31
*** Sree_ has joined #openstack-nova16:32
*** Sree_ is now known as Guest7826216:32
*** angdraug has quit IRC16:33
*** twinklechawla has quit IRC16:33
*** angdraug has joined #openstack-nova16:34
*** Guest78262 has quit IRC16:34
*** Sree has quit IRC16:34
*** matrohon has joined #openstack-nova16:37
*** romainh has left #openstack-nova16:37
*** apoorvad has joined #openstack-nova16:38
*** dims__ has quit IRC16:38
*** dims__ has joined #openstack-nova16:39
*** karimb has quit IRC16:40
openstackgerritPawel Koniszewski proposed openstack/nova-specs: Force live migration  https://review.openstack.org/22904016:40
mriedemjohnthetubaguy: there is a question in this re-proposed spec that probably didn't come up in the liberty review https://review.openstack.org/#/c/226925/1/specs/mitaka/approved/refresh-quotas-usage.rst16:41
mriedemjohnthetubaguy: not sure what to do about that16:41
*** stevemar has joined #openstack-nova16:42
johnthetubaguymriedem: I think its OK to ask that question now, we miss things sometimes16:42
johnthetubaguymriedem: I wish I had questioned the hierarchical quota one when I could, rather than fast approving it, if that helps16:42
*** kiranr has joined #openstack-nova16:43
*** READ10 has quit IRC16:43
*** nic has joined #openstack-nova16:44
*** alexpilotti has quit IRC16:44
mriedemyeah, just wish i had a good answer for the question16:44
*** pkoniszewski has joined #openstack-nova16:46
*** rotbeard has quit IRC16:47
johnthetubaguymriedem: ah, yeah, thats the harder bit16:47
raildojohnthetubaguy, mriedem  I'm trying figure out how hierarchical quotas should works for users... since we didn't had quota for users on cinder, so we din't thought a lot on this case...16:50
*** digimonde has quit IRC16:51
raildocan we alllow more quotas for users that the hard limit, right?16:52
raildoallow*16:52
mriedemi don't understand the question16:52
*** kiran-r has quit IRC16:52
raildomriedem, I mean... in quotas, we set the limit for the resource, for example the user can create 10 instances. with nested quotas, if I want allocate 5 instances for a sub-project, I'll "remove" 5 instances to the parent project, and allocated for your subproject. But for users this doesn't apply, If I have 10 instances in a project, I can apply quota for  a user to 20 instances on this project, right?16:55
*** Sree has joined #openstack-nova16:55
*** mwagner_ has joined #openstack-nova16:56
*** derekh has quit IRC16:56
mriedemraildo: do you mean today w/o nested quotas?16:57
raildomriedem, today, without nested quotas.16:57
mriedemi thought limit applied the same to users and projects16:57
mriedemunless you change it via the api16:57
*** ctrath has quit IRC16:59
*** unicell has joined #openstack-nova17:00
*** READ10 has joined #openstack-nova17:00
*** Piet has joined #openstack-nova17:01
*** su_zhang has joined #openstack-nova17:01
*** danpb has quit IRC17:01
*** su_zhang has quit IRC17:03
*** su_zhang has joined #openstack-nova17:03
*** tonytan4ever has joined #openstack-nova17:05
raildomriedem, ok, so using the API I can say that a project have quota for 10 instances and a user in this project have quota for 15 instances.17:06
*** AJaeger has joined #openstack-nova17:06
*** smatzek has quit IRC17:06
raildousing this API call http://developer.openstack.org/api-ref-compute-v2.1.html#updatesquotauser17:06
*** Sree has quit IRC17:06
AJaegerCould I get another +2 and approval for a translation import from our bot for master, please? https://review.openstack.org/#/c/227138/17:07
mriedemraildo: yeah17:07
openstackgerritDan Smith proposed openstack/nova: Add get_minimum_version() to Service object and DB API  https://review.openstack.org/22332017:07
openstackgerritDan Smith proposed openstack/nova: Allow automatic determination of compute_rpc version by service  https://review.openstack.org/22332117:07
openstackgerritDan Smith proposed openstack/nova: Make service create/update fail if version is too old  https://review.openstack.org/22904917:07
mriedemraildo: like this http://docs.openstack.org/cli-reference/content/novaclient_commands.html#novaclient_subcommand_quota-update17:07
*** apoorvad_ has joined #openstack-nova17:08
*** ildikov has quit IRC17:09
*** thorst has quit IRC17:10
raildomriedem, great! so, thinking now in nested projects, we have to change something on this behavior? since a project_admin can set a quota for a subproject, maybe he can set quotas for a user in a subproject?17:10
mriedemseems reasonable17:11
*** apoorvad has quit IRC17:12
*** pm90_ has joined #openstack-nova17:13
*** lsmola has quit IRC17:14
*** wanghua has quit IRC17:14
raildomriedem, Is there any other issue or suggestion that you see? (sorry if I'm boring you, I'll repropose the nested quota spec and I'm trying do figure out what I can improve)17:14
*** PaulMurray has quit IRC17:15
mriedemraildo: honestly i'm not really familiar with the nested quotas stuf17:15
mriedem*stuff17:15
*** sudipto has quit IRC17:16
raildomriedem, ok, no problem, thanks for your time!17:16
*** ctrath has joined #openstack-nova17:17
*** tjones has joined #openstack-nova17:17
*** tjones has left #openstack-nova17:17
*** ccarmack has quit IRC17:17
*** salv-orl_ has quit IRC17:18
*** ijw has quit IRC17:18
*** marzif has joined #openstack-nova17:19
*** cfriesen has joined #openstack-nova17:20
*** ccarmack has joined #openstack-nova17:21
openstackgerritMark Doffman proposed openstack/nova: Point to cinder options in nova block alloc docs.  https://review.openstack.org/22905617:22
*** Sree has joined #openstack-nova17:24
*** emagana has quit IRC17:25
*** armax has quit IRC17:25
mriedemdoffm: i'd like more of your commit message titles to sound like dr seuss books17:25
*** asselin has quit IRC17:27
*** ijw has joined #openstack-nova17:27
*** sseverson has quit IRC17:27
*** sahid has quit IRC17:27
*** asselin has joined #openstack-nova17:28
*** sseverson has joined #openstack-nova17:28
*** achanda has joined #openstack-nova17:29
*** tdurakov has joined #openstack-nova17:29
*** fawadkhaliq has quit IRC17:30
doffmmriedem: I love Dr seuss books! Did that come through?17:31
*** Piet has quit IRC17:31
*** electrocucaracha has quit IRC17:32
*** sudipto has joined #openstack-nova17:33
*** coolsvap has quit IRC17:33
openstackgerritArtom Lifshitz proposed openstack/nova: WIP: Virtual device role tagging  https://review.openstack.org/22640917:35
openstackgerritChuck Carmack proposed openstack/nova: Make the server group invalid format message more verbose  https://review.openstack.org/21846817:35
openstackgerritDan Smith proposed openstack/nova-specs: Add service-version-behavior spec  https://review.openstack.org/22906217:35
dansmithalaski: ^17:35
dansmithalaski: worst-named spec ever17:36
*** lpetrut has quit IRC17:36
doffmndipanov: I've been looking at bug https://bugs.launchpad.net/nova/+bug/1497343. In looking at it i'm tempted to do some more cleanup around this, largely moving the detach functionality to block_device.py.17:36
openstackLaunchpad bug 1497343 in OpenStack Compute (nova) "Need to consolidate duplicated volume detach code between compute manager and block_device" [Low,Triaged] - Assigned to Mark Doffman (mjdoffma)17:36
*** thorst has joined #openstack-nova17:37
alaskidansmith: what about "service version manifesto"?17:37
dansmithalaski: so. played.17:37
doffmndipanov: Worth doing? or was there a reason that was left in compute/mananger.py17:37
*** coolsvap has joined #openstack-nova17:37
raildomriedem, btw, do you know how the remains quota calculation works? looking on the tests, sounds odd to me: https://github.com/openstack/nova/blob/master/nova/tests/unit/test_quota.py#L1209-L121417:37
*** pixelbeat has quit IRC17:37
*** mriedem has quit IRC17:38
*** salv-orlando has joined #openstack-nova17:38
*** exploreshaifali has joined #openstack-nova17:40
*** exploreshaifali has quit IRC17:41
*** krtaylor has quit IRC17:42
*** rlrossit has quit IRC17:42
*** mriedem has joined #openstack-nova17:42
*** emagana has joined #openstack-nova17:43
*** ijw has quit IRC17:44
*** sileht_ has joined #openstack-nova17:44
*** moshele has quit IRC17:44
*** sileht_ is now known as sileht17:45
*** sileht has quit IRC17:45
*** sileht has joined #openstack-nova17:45
*** baoli_ has quit IRC17:46
*** rlrossit has joined #openstack-nova17:47
*** jichen has joined #openstack-nova17:48
*** sudipto has quit IRC17:48
*** Sree has quit IRC17:49
*** penick has joined #openstack-nova17:51
AJaegerthanks, melwitt for the approval of the import!17:54
*** krtaylor has joined #openstack-nova17:54
*** otter768 has joined #openstack-nova17:55
melwittAJaeger: np17:55
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Use os-testr for py34 tox target  https://review.openstack.org/22906917:55
*** Marga_ has quit IRC17:56
*** tdurakov has quit IRC17:57
dims__mtreinish: ^^ yay!17:57
*** electrocucaracha has joined #openstack-nova17:58
*** annegentle has joined #openstack-nova17:58
*** penick has quit IRC17:58
*** sdague has quit IRC17:58
*** otter768 has quit IRC17:59
*** dims has joined #openstack-nova18:00
*** ctrath has quit IRC18:01
*** dims__ has quit IRC18:02
*** sdague has joined #openstack-nova18:02
*** apoorvad_ has quit IRC18:04
*** penick has joined #openstack-nova18:04
*** apoorvad has joined #openstack-nova18:04
*** ctrath has joined #openstack-nova18:04
*** ctrath has left #openstack-nova18:06
*** penick has quit IRC18:06
*** AJaeger has left #openstack-nova18:06
*** READ10 has quit IRC18:09
*** marzif has quit IRC18:09
*** claudiub has joined #openstack-nova18:13
*** penick has joined #openstack-nova18:13
*** ijw has joined #openstack-nova18:13
*** ijw has quit IRC18:14
*** vilobhmm11 has joined #openstack-nova18:16
*** emagana has quit IRC18:17
*** Marga_ has joined #openstack-nova18:19
*** ildikov has joined #openstack-nova18:19
*** ijw has joined #openstack-nova18:23
*** moshele has joined #openstack-nova18:24
*** tdurakov has joined #openstack-nova18:25
*** boris-42 has quit IRC18:29
*** armax has joined #openstack-nova18:29
mtreinishdims__: so the reqs file is wrong on that patch, but other than that LGTM18:34
*** moshele has quit IRC18:34
*** su_zhang has quit IRC18:36
*** Vek_ has joined #openstack-nova18:37
*** Vek has quit IRC18:37
*** setuid has quit IRC18:37
*** aix has quit IRC18:38
*** flwang has quit IRC18:38
*** flwang has joined #openstack-nova18:38
*** setuid has joined #openstack-nova18:42
*** nikhil has joined #openstack-nova18:42
*** nikhil_k has quit IRC18:44
*** Piet has joined #openstack-nova18:46
*** electrocucaracha has quit IRC18:46
*** jasondotstar is now known as jasondotstar_afk18:47
*** pixelbeat has joined #openstack-nova18:48
*** whenry has quit IRC18:50
*** electrocucaracha has joined #openstack-nova18:50
*** electrocucaracha has quit IRC18:51
*** kiranr has quit IRC18:52
*** sahid has joined #openstack-nova18:53
*** e0ne has quit IRC18:54
*** eharney has quit IRC18:55
*** ijuwang has quit IRC18:56
*** eharney has joined #openstack-nova19:01
*** stevemar has quit IRC19:01
*** ijuwang has joined #openstack-nova19:02
*** artom has quit IRC19:03
*** whenry has joined #openstack-nova19:05
*** stevemar has joined #openstack-nova19:08
*** davideagnello has quit IRC19:09
alaskidansmith: commented on https://review.openstack.org/#/c/229062, calling it out here since I didn't vote yet19:10
*** ctrath has joined #openstack-nova19:10
dansmithcool thanks19:11
*** angdraug has quit IRC19:14
*** pixelbeat has quit IRC19:16
*** Daisy has joined #openstack-nova19:18
*** davideagnello has joined #openstack-nova19:20
*** baoli has joined #openstack-nova19:21
*** tsekiyama has joined #openstack-nova19:22
*** Daisy has quit IRC19:23
mriedemccarmack: http://lists.openstack.org/pipermail/openstack-dev/2015-August/072797.html19:24
mriedemif you want to post devil's advocate questions19:24
*** ijw has quit IRC19:24
*** apoorvad has quit IRC19:25
*** digimonde has joined #openstack-nova19:28
*** baoli has quit IRC19:31
*** diegows has joined #openstack-nova19:31
*** baoli has joined #openstack-nova19:32
*** eharney has quit IRC19:32
*** sileht has quit IRC19:39
*** angdraug has joined #openstack-nova19:39
*** krtaylor has quit IRC19:40
*** krtaylor has joined #openstack-nova19:43
*** eharney has joined #openstack-nova19:45
*** sileht has joined #openstack-nova19:45
*** baoli has quit IRC19:45
mriedemanyone have thoughts on this? https://review.openstack.org/#/c/218975/2/nova/compute/manager.py19:45
*** clduser_ has joined #openstack-nova19:46
*** baoli has joined #openstack-nova19:46
*** clduser has quit IRC19:46
*** sileht has quit IRC19:47
*** sileht has joined #openstack-nova19:48
*** tonytan4ever has quit IRC19:50
*** tonytan4ever has joined #openstack-nova19:51
*** electrocucaracha has joined #openstack-nova19:51
tdurakovalaski, hi, this could be interesting to you: https://review.openstack.org/#/c/225910/19:53
*** otter768 has joined #openstack-nova19:55
tdurakovmelwitt, hi, are you around? could we discuss this:  https://review.openstack.org/#/c/227897/19:56
*** tjones has joined #openstack-nova19:56
alaskitdurakov: thanks.  opened to look at later19:56
*** baoli has quit IRC19:57
tdurakovalaski, thank you19:57
*** erlon has quit IRC19:58
mriedemctrath: apparently reset-state only allows the admin to put the instance in active or error state19:58
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/reset_server_state.py#L2319:58
*** ZZelle_ has joined #openstack-nova19:59
mtreinishdims__: yes, the requirements job would fail on that patch, but it doesn't mean the requirements you listed were correct19:59
alaskimriedem: I think that situation in that review is messy no matter what.  But I agree with your point about bringing state from the hypervisor into Nova.  I'll comment on the review19:59
mtreinishwe need to bump g-r to reflect that nova will have a hard dep on ostestr >=0.4.019:59
openstackgerritDan Smith proposed openstack/nova-specs: Add service-version-behavior spec  https://review.openstack.org/22906219:59
dimsmtreinish: :)19:59
*** su_zhang has joined #openstack-nova20:00
dimsmtreinish: right20:00
*** tdurakov has quit IRC20:00
*** otter768 has quit IRC20:00
mtreinishdims: I just like making your life difficult :)20:00
dimshahaha20:00
mtreinishalthough you're g-r core now, I'll handle that patch so you can +2 it20:00
*** penick has quit IRC20:01
*** earlephilhower has quit IRC20:01
dimsmtreinish: probably need a few days, i think we just cut a stable/liberty this morning for requirements20:01
mriedemalaski: so ctrath had an idea about putting the instance into error state and then the user can do something to it,20:01
mriedemlike either reset-state or reboot it20:02
mriedemhard-reboot in this case https://github.com/openstack/nova/blob/master/nova/compute/vm_states.py#L5120:02
*** tdurakov has joined #openstack-nova20:02
mriedemwe could also do reset-state and put it in active state automatically if it's running on the hypervisor20:02
mtreinishdims: heh, that means the gates are open20:02
mriedemthat'd basically be the same flow as the task putting it in error state, then the admin doing reset-state active on it20:02
mtreinishdims: well after we cut the branches for devstack and grenade tomorrow I guess20:02
dimsright20:03
melwitttdurakov: yes, I was looking over it earlier20:03
ctrathmriedem, alaski: the main issue that I see with putting in error state is how to tell the user the reasoning why it's in error state20:03
mtreinishdims: https://review.openstack.org/#/c/229129/20:03
tdurakovmelwitt, so, i've left comment for you, what do you think?20:04
mriedemctrath: i think we'd store an instance fault with the error state if we did that20:04
dimsmtreinish: haven't gotten my wings yet. so +1 for now :)20:04
*** yamahata has quit IRC20:04
mtreinishdims: well let's poke dhellmann to make that happen20:05
*** penick has joined #openstack-nova20:05
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Use os-testr for py34 tox target  https://review.openstack.org/22906920:06
dimsthrew in a Depends-On ^^20:06
mtreinishcool20:07
mtreinish+120:07
melwitttdurakov: my initial thought is that we can't assume dhcp because the network might not be using it20:08
melwitttdurakov: but overall it's not clear to me from the bug details what state the instance is left in when it fails network teardown during a rollback. is it in error state, etc20:09
dimsmtreinish: love it when a plan comes together :)20:09
*** diegows has quit IRC20:09
tdurakovmelwitt, nope, it could be in active state20:10
*** twinklechawla has joined #openstack-nova20:10
*** Marga_ has quit IRC20:12
*** Marga_ has joined #openstack-nova20:13
*** e0ne has joined #openstack-nova20:14
tdurakovmelwitt, for example if nova-network accidentally stops, rollback method would fail before driver cleanup resources, while with this patch driver try to clean them up anyway20:15
*** mrda has quit IRC20:18
raildomelwitt, ping I think that you can help me with a doubt :) Do you know how the remains quotas is calculated in this tests here? https://github.com/openstack/nova/blob/master/nova/tests/unit/test_quota.py#L1209-L1214, the values sounds strange to me20:19
openstackgerritJoshua Harlow proposed openstack/nova: Add timing logging around each filter being ran  https://review.openstack.org/22435520:20
melwitttdurakov: yeah. so with this patch it would leave the network allocated on the destination instead of both the network and the instance dir left allocated. I'm was thinking if we can do something better, because this would silently leave network allocated20:21
melwitttdurakov: and it seems like in either case, there's no total recovery in that, there's no way to free that network allocated in the case of non-dhcp20:22
*** diegows has joined #openstack-nova20:22
tdurakovmelwitt, non-dhcp for nova-network is?20:22
melwitttdurakov: for example FlatManager, not using dhcp20:23
melwittraildo: I don't know off the top of my head. I'd have to figure it out from what's there20:23
raildomelwitt, I know that this value is calculated here: https://github.com/openstack/nova/blob/master/nova/quota.py#L206 but I didn't understand this values on this tests =/20:25
*** stevemar has quit IRC20:25
*** apoorvad has joined #openstack-nova20:26
*** salv-orlando has quit IRC20:27
*** dims has quit IRC20:28
tdurakovmelwitt, yep, there is no way to clean up network properly, IMO we could improve this now by at least trying to clean up driver resources. there is a spec for live-migration, that will improve this situation(https://review.openstack.org/#/c/225910/)20:29
*** stevemar has joined #openstack-nova20:29
*** dims has joined #openstack-nova20:29
*** apoorvad has quit IRC20:31
*** Marga_ has quit IRC20:32
*** Marga_ has joined #openstack-nova20:33
*** salv-orlando has joined #openstack-nova20:33
*** diegows has quit IRC20:34
*** sahid has quit IRC20:35
*** yamahata has joined #openstack-nova20:36
melwittraildo: so, it looks like "remains" starts out equal to "limit" and it's calculated each _process_quotas as "remains -= hard_limit" and in the test you can find the quota is stubbed out to set instances hard_limit as 5 and cores hard_limit as 220:36
alaskictrath: mriedem sorry, got pulled into a call20:37
alaskiI'm looking at the options and none of them seem good20:37
melwittraildo: so for the first one instances it's 5 - 5 = 0 and the second one cores 10 - 2 = 8 and the rest didn't have hard_limit set so they are just the limit20:37
mriedemalaski: well there is always punt and do nothing, but that kind of sucks too20:38
alaskictrath: mriedem I think the best course would be to understand how an instance gets to a state where Nova thinks it's stopped but it's not20:38
mriedemapparently we just had a customer have their instances stopped by that task20:38
*** baoli has joined #openstack-nova20:38
mriedemwell garyk's case was HA something or other in the backend vcenter20:39
melwitttdurakov: yeah, I understand. I'll think about it more and we'll get some more people to take a look20:39
tdurakovmelwitt, thanks:)20:39
alaskimriedem: yeah.  I wonder if we should distinguish between a user initiated stop and a sync_power_state stop20:39
raildomelwitt, I'm trying to find this hard_limit=2 for core.... this is hard coded in somewhere?20:40
*** electrocucaracha has quit IRC20:40
alaskimriedem: and let the former continue to use force_stop, then solve for the latter20:40
*** electrocucaracha has joined #openstack-nova20:40
mriedemi guess i'm not totally following20:41
mriedemlike an action event or something?20:41
*** thangp has quit IRC20:41
melwittraildo: it's here https://github.com/openstack/nova/blob/master/nova/tests/unit/test_quota.py#L1094-L1100 and you can see _stub_get_by_project is called in the beginning of the test20:41
alaskimriedem: like have another elif in sync_power_state for vm_state == vm_states.SYNC_STOPPED or something20:42
*** karimb has joined #openstack-nova20:42
*** twinklechawla has quit IRC20:42
alaskithen a reboot seems more reasonable to me20:42
*** ildikov has quit IRC20:42
raildomelwitt, oh! now this makes sense! thanks melwitt, you're the best :D20:42
mriedemalaski: oh so you're thinking the 2nd pass20:43
melwittraildo: haha, you're welcome20:43
alaskimriedem: yeah20:43
*** twinklechawla has joined #openstack-nova20:43
mriedembut what does that buy us?  we just ignore SYNC_STOPPED?20:43
mriedemor reboot on SYNC_STOPPED?20:44
alaskithen we shut down the instance if it's user initiated, and reboot on SYNC_STOPPED so we end up active again20:44
mriedemi'm not sure we know it's user initiated though20:44
mriedemif it were user initiated we could always just say don't do that and reject the bug20:44
mriedemunless you're grouping user initiated with 3rd party HA software initiated20:45
mriedemidk, i kind of like the error state idea because that puts the next action in the hands of the operator20:45
alaskithe bug is because the vm_state ends up stopped because of the blip in vmware, right20:45
mriedemyeah, it's like the reboot case with the libvirt driver and the lifecycle event stuff,20:46
mriedemthat was stopping the instance then starting it but it raced with the task and it'd be running in libvirt and the task would stop it20:46
mriedemthe fix there was adding a 15 second sleep to the libvirt driver in the reboot case20:46
alaskimy thinking is that we don't know the right thing to do in the periodic because we don't know if the instance should go down, or stay up20:47
alaskiwe just assume now that if the vm_state says it should be down we kill it20:47
mriedemalaski: yeah, and i think we can agree that's not good20:47
*** su_zhang has quit IRC20:48
alaskiso I thought we could distinguish between a user calling the stop api, and a vm that's stopped because the hypervisor said it should be20:48
*** ildikov has joined #openstack-nova20:48
alaskiin the first case we don't want the instance coming back up, in the second we do20:48
alaski(assuming now the power state says it's up)20:48
mriedemyeah, was going to say, in the nova-api user case the vm_state should be stopped and power state should be shutdown20:49
mriedemthe only way power state goes to running is if the user restarted it on the backend20:49
mriedemwhich is the bug that we reject20:49
alaskiright20:49
mriedemso.....i'm still not really seeing a difference with just making that assumption20:50
*** su_zhang has joined #openstack-nova20:50
mriedemi might just need the steps written down in the hypervisor blip case20:51
mriedemand how a new SYNC_STOPPED state makes it better20:51
alaskiI'm just thinking of a way to make it clear what the right corrective action is20:52
alaskiis vm_state == stopped, but hypervisor says it's running20:52
alaskiwhich one is correct?20:52
mriedemare you thinking on pass 1 we stop it and set SYNC_STOPPED, and on pass 2 we see SYNC_STOPPED and hypervisor says it's running, so we reboot?20:52
alaskiyes20:53
*** pixelbeat has joined #openstack-nova20:53
mriedemso at most by default your pet is only down for 10 minutes20:53
mriedembut it's not actually down20:53
alaskiyeah, just the API view of it is wrong20:54
mriedemyeah...i still think operators are going to be pissed that nova stops it in the first place (the SYNC_STOPPED case)20:54
alaskiwell, that's the real fix here.  but people seemed convinced that couldn't be fixed20:54
mriedemwhich is why i was thinking putting it in error state and letting the operator handle correcting it with reset-state is marginally better20:54
mriedemb/c if it's actually running and you just want it showing as ACTIVE (w/o rebooting it), you can do that with nova reset-state --active20:55
*** VW_ has joined #openstack-nova20:55
mriedemif it's 'running' but not really, you could hard reboot it20:55
*** VW has quit IRC20:55
mriedemputting it in error state from nova's end is basically saying, we don't know wtf happened, but something is wrong, you sort it out20:56
mriedemwe could of course make that configurable (the action to take on the instance when we get into this case)20:56
ctrathmriedem: is there a way to gracefully sync the state?20:57
mriedemgracefully?20:57
alaskisure, that works too.  I was simply considering that in one case (user called stop api) we know what happened and how to fix it20:57
ctrathmeaning, can somebody run a command after the instance is in error state in order to update Nova with the correct state?20:57
mriedemctrath: nova reset-state20:58
ctrathok, cool20:58
mriedembut you can only put it in active or error state with that api20:58
*** ijw has joined #openstack-nova20:58
*** VW_ has quit IRC20:58
mriedemalaski: well if the user stops the instance and then it's running, they want the task to stop the instance again so they aren't billed right?20:59
mriedemor whatever20:59
*** VW has joined #openstack-nova20:59
alaskiright.  we don't want the resources still in use.20:59
alaskiit's actually moot for us because we don't allow stop, but I'll gloss over that21:00
mriedemheh21:00
alaskimy concern is that the new config would change that21:00
mriedemwell, the config could default to stop as it does today for backwards compat21:01
mriedemi'm basically thinking actions are stop, reboot, error, noop21:01
alaskiyeah, but changing it to fix the "we don't know why it stopped" case breaks the "user stopped it" case21:01
*** earlephilhower has joined #openstack-nova21:01
mriedemtrue21:01
*** apoorvad has joined #openstack-nova21:02
mriedemwe know it stopped b/c larry stopped it explicitly and larry wants to keep it that way21:02
mriedemb/c gdi larry hates that thing running for whatever reason21:02
alaskia good pet listens to its owner21:02
mriedemshiiiiit21:02
ctrathgdi larry21:02
mriedemalaski: you've heard about mortimer right?21:02
alaskiI've heard some of the tales21:03
*** hemna is now known as hemnafk21:03
mriedemtales of woe21:03
*** ijw has quit IRC21:03
mriedemi'm not crazy about a new vm_state, could we just set a flag on the instance?21:03
mriedemsysmeta?21:03
alaskisure.  new vm_state isn't pleasant to me either21:03
sdaguemriedem: https://review.openstack.org/#/c/227135/1 - backport of the name relaxation to kilo21:03
mriedemalaski: i feel like this is getting into spec territory21:04
mriedemelse, let's just ram this through w/o consensus when everyone is in tokyo :)21:04
*** rlrossit has left #openstack-nova21:04
mriedemsdague: ok sec21:04
alaskiheh, if we can get a third party to write it we've got two +2s21:05
*** whenry has quit IRC21:05
alaskimriedem: honestly short term a config option seems reasonable if this is causing problems.  I was just thinking we could solve both cases eventually21:06
mriedemyeah, i think covering both is a spec21:06
mriedemhell, a config option might be a specless blueprint, idk21:06
mriedemmaybe i'll update the WIP i have to see what the new config option would look with the stop/reboot/error/noop actions21:07
*** twinklechawla has quit IRC21:07
*** mudassirlatif_ has joined #openstack-nova21:08
*** twinklechawla has joined #openstack-nova21:08
*** aysyd has quit IRC21:08
*** hemna has joined #openstack-nova21:09
mriedemalaski: now can you just like, you know, summarize all of that discussion as a comment in the change so we dont' forget about it?21:09
mriedem:P21:09
*** raildo is now known as raildo-afk21:10
*** ociuhandu has joined #openstack-nova21:10
*** mudassirlatif has quit IRC21:11
*** mudassirlatif_ is now known as mudassirlatif21:11
*** twinklechawla has quit IRC21:12
*** alexpilotti has joined #openstack-nova21:14
alaskiheh, I'll try21:16
*** MVenesio has quit IRC21:17
mriedemi can also write it down21:17
mriedemwas just joking21:17
mriedemsort of21:17
alaskiwell now I've already started21:17
alaskiso I'm not stopping21:17
*** baoli has quit IRC21:22
*** baoli has joined #openstack-nova21:22
*** haypo has left #openstack-nova21:23
*** mudassirlatif has quit IRC21:27
*** thorst has quit IRC21:28
*** mudassirlatif has joined #openstack-nova21:28
*** baoli has quit IRC21:30
*** mudassirlatif has quit IRC21:30
*** baoli has joined #openstack-nova21:32
*** baoli has quit IRC21:32
*** baoli has joined #openstack-nova21:32
mriedemalaski: we have a logic problem i think with "are you thinking on pass 1 we stop it and set SYNC_STOPPED, and on pass 2 we see SYNC_STOPPED and hypervisor says it's running, so we reboot?"21:32
*** mudassirlatif has joined #openstack-nova21:33
mriedemif we stop it and set the flag, in pass 2 even if the flag is set, if we stopped it in pass 1 it's probably no longer running on the hypervisor21:33
alaskiI'm not sure on the libvirt case, but for vmware my understanding was that on one pass the power state was stopped and then on the next run it wasn't21:34
mriedemoh right, vm_state is active and hypervisor power state is stopped, so we stop it21:34
mriedem2nd pass vm_state is stopped and hypervisor power state is running21:34
alaskiyeah21:35
mriedemtoday we stop, but if flag is set we (reboot)21:35
alaskiyep21:35
openstackgerritJoshua Harlow proposed openstack/nova: Avoid needless list copy in 'scheduler_host_subset_size' case  https://review.openstack.org/22644321:35
alaskiI don't know if this will help the libvirt case though21:35
*** mudassirlatif has quit IRC21:35
alaskiI'm not clear on what happens there yet21:36
mriedemok, clarified in the comments21:37
mriedemso garyk can enjoy all of this light reading when he's up21:37
mriedemhonestly i don't think this is really a problem in the libvirt case21:37
mriedemthe problem in the libvirt case was the race with reboot and the lifecycle event stuff, which has been fixed21:38
*** e0ne has quit IRC21:38
alaskiokay cool21:39
openstackgerritAlvaro Lopez Garcia proposed openstack/nova: SameHostFilter should fail if host does not have instances  https://review.openstack.org/22903021:39
*** ccarmack has quit IRC21:40
*** harlowja has quit IRC21:40
*** harlowja has joined #openstack-nova21:40
*** salv-orl_ has joined #openstack-nova21:43
*** mudassirlatif has joined #openstack-nova21:45
*** salv-orlando has quit IRC21:46
*** amotoki has quit IRC21:46
*** annegentle has quit IRC21:47
*** ccarmack has joined #openstack-nova21:47
*** annegentle has joined #openstack-nova21:48
*** jichen has quit IRC21:48
*** tdurakov has quit IRC21:49
*** ctrath has quit IRC21:49
*** mudassirlatif has quit IRC21:49
*** devlaps has joined #openstack-nova21:52
*** ijw has joined #openstack-nova21:52
*** zzzeek has quit IRC21:52
*** mudassirlatif has joined #openstack-nova21:53
*** digimonde has quit IRC21:53
*** ctrath has joined #openstack-nova21:56
*** hemna has quit IRC21:56
*** otter768 has joined #openstack-nova21:56
*** ijw has quit IRC21:57
*** ijw has joined #openstack-nova21:57
*** gyee has joined #openstack-nova21:59
*** asettle has joined #openstack-nova22:00
*** otter768 has quit IRC22:01
*** zzzeek has joined #openstack-nova22:01
*** hemna has joined #openstack-nova22:01
*** Piet has quit IRC22:02
*** hemna has quit IRC22:04
*** hemnafk is now known as hemna22:04
openstackgerritMatt Riedemann proposed openstack/nova: vmware: set default value in fake _db_content when creating objects  https://review.openstack.org/22916422:05
mriedem^ the most productive thing i've done today22:05
*** ociuhandu has quit IRC22:06
*** burt has quit IRC22:07
*** annegentle has quit IRC22:08
*** mdrabe has quit IRC22:08
*** mriedem is now known as mriedem_away22:09
*** mriedem_away has quit IRC22:09
*** tonytan_brb has joined #openstack-nova22:10
*** matrohon has quit IRC22:11
*** boris-42 has joined #openstack-nova22:12
*** baoli has quit IRC22:12
*** baoli has joined #openstack-nova22:13
*** tonytan4ever has quit IRC22:14
*** marcusvrn_ has quit IRC22:15
*** mwagner_ has quit IRC22:20
*** yamahata has quit IRC22:24
*** yamahata has joined #openstack-nova22:24
*** rfolco has quit IRC22:26
*** tonytan_brb has quit IRC22:27
*** VW has quit IRC22:28
*** VW has joined #openstack-nova22:28
*** VW has quit IRC22:28
*** VW has joined #openstack-nova22:29
*** VW has quit IRC22:29
*** rfolco has joined #openstack-nova22:29
*** VW has joined #openstack-nova22:29
*** tonytan4ever has joined #openstack-nova22:33
*** mc_nair has quit IRC22:34
*** stevemar has quit IRC22:38
*** rfolco has quit IRC22:42
*** baoli has quit IRC22:44
*** baoli has joined #openstack-nova22:44
*** thorst has joined #openstack-nova22:46
*** zzzeek has quit IRC22:46
*** amotoki has joined #openstack-nova22:46
*** mudassirlatif has quit IRC22:47
*** rfolco has joined #openstack-nova22:49
*** ijuwang has quit IRC22:50
*** emagana has joined #openstack-nova22:51
*** amotoki has quit IRC22:51
*** edev has joined #openstack-nova22:52
edev#openstack22:53
*** edev has left #openstack-nova22:53
*** alejandrito has quit IRC22:56
*** ctrath has quit IRC22:56
*** mwagner_ has joined #openstack-nova22:57
*** su_zhang has quit IRC22:58
*** mudassirlatif has joined #openstack-nova22:59
*** jhesketh has quit IRC23:01
*** jhesketh has joined #openstack-nova23:02
*** browne has quit IRC23:05
*** browne has joined #openstack-nova23:05
*** su_zhang has joined #openstack-nova23:06
*** Piet has joined #openstack-nova23:07
*** signed8bit has joined #openstack-nova23:07
*** rfolco has quit IRC23:12
*** julien_ZTE has quit IRC23:13
*** julien_ZTE has joined #openstack-nova23:13
*** yamahata has quit IRC23:15
*** tonytan4ever has quit IRC23:16
*** baoli has quit IRC23:16
*** rfolco has joined #openstack-nova23:17
*** ijw has quit IRC23:18
*** mnestratov|2 has quit IRC23:18
*** salv-orl_ has quit IRC23:19
*** mnestratov|2 has joined #openstack-nova23:19
*** xyang1 has quit IRC23:19
*** dims_ has joined #openstack-nova23:19
*** mudassirlatif has quit IRC23:21
*** dims has quit IRC23:22
*** thorst has quit IRC23:22
*** eharney has quit IRC23:23
*** mudassirlatif has joined #openstack-nova23:23
*** tpeoples has quit IRC23:24
*** su_zhang has quit IRC23:24
*** aloga has quit IRC23:24
*** su_zhang has joined #openstack-nova23:24
*** aloga has joined #openstack-nova23:25
*** ZZelle_ has quit IRC23:25
*** markmcclain has quit IRC23:25
*** apoorvad has quit IRC23:26
*** Apoorva has joined #openstack-nova23:30
*** irenab_ has joined #openstack-nova23:30
*** markmcclain has joined #openstack-nova23:31
*** ccarmack1 has joined #openstack-nova23:31
*** mdbooth_ has joined #openstack-nova23:31
*** dims_ has quit IRC23:31
*** bauzas_ has joined #openstack-nova23:32
*** dims_ has joined #openstack-nova23:32
*** andrearo1 has joined #openstack-nova23:32
*** sambetts_ has joined #openstack-nova23:32
*** mdbooth has quit IRC23:32
*** flaper87 has quit IRC23:32
*** bauzas has quit IRC23:32
*** rfolco has quit IRC23:32
*** sambetts has quit IRC23:32
*** htruta has quit IRC23:32
*** johnthetubaguy has quit IRC23:32
*** tristanC has quit IRC23:32
*** bswartz has joined #openstack-nova23:32
*** mdbooth_ is now known as mdbooth23:32
*** bauzas_ is now known as bauzas23:32
*** htruta` has joined #openstack-nova23:32
*** flaper87 has joined #openstack-nova23:32
*** tristanC has joined #openstack-nova23:33
*** ccarmack has quit IRC23:33
*** irenab has quit IRC23:33
*** albertom has quit IRC23:33
*** mcarden has quit IRC23:33
*** andrearosa has quit IRC23:33
*** brad[] has quit IRC23:33
*** rfolco has joined #openstack-nova23:33
*** irenab_ is now known as irenab23:33
*** Apoorva is now known as apoorvad23:33
*** aloga has quit IRC23:33
*** keekz has quit IRC23:33
*** loquacities has quit IRC23:33
*** aloga has joined #openstack-nova23:33
*** loquacities has joined #openstack-nova23:33
*** mcarden has joined #openstack-nova23:34
*** albertom has joined #openstack-nova23:34
*** johnthetubaguy has joined #openstack-nova23:34
*** keekz has joined #openstack-nova23:34
*** asettle has quit IRC23:37
*** rfolco has quit IRC23:40
*** edmondsw has quit IRC23:41
*** signed8bit is now known as signed8bit_ZZZzz23:41
*** mudassirlatif has quit IRC23:43
*** hemna is now known as hemnafk23:43
*** rfolco has joined #openstack-nova23:44
*** achanda_ has joined #openstack-nova23:44
*** julien_ZTE has quit IRC23:44
*** coreywright_ has joined #openstack-nova23:44
*** achanda_ has quit IRC23:45
*** coreywright_ is now known as coreywright23:46
*** pm90_ has quit IRC23:46
*** achanda has quit IRC23:48
*** emagana has quit IRC23:48
*** signed8bit_ZZZzz is now known as signed8bit23:49
*** mudassirlatif has joined #openstack-nova23:51
*** otter768 has joined #openstack-nova23:57
*** Piet has quit IRC23:57
*** Piet has joined #openstack-nova23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!