| *** otter768 has quit IRC | 00:01 | |
| *** SourabhP has quit IRC | 00:01 | |
| *** pixelbeat has joined #openstack-nova | 00:01 | |
| *** tjones has quit IRC | 00:03 | |
| *** achanda has quit IRC | 00:04 | |
| *** mriedem_away has quit IRC | 00:06 | |
| *** pixelbeat has quit IRC | 00:07 | |
| *** mriedem has joined #openstack-nova | 00:07 | |
| *** mriedem1 has joined #openstack-nova | 00:09 | |
| *** markvoelker has quit IRC | 00:10 | |
| *** zxyf has joined #openstack-nova | 00:11 | |
| *** mriedem has quit IRC | 00:12 | |
| *** angdraug has quit IRC | 00:16 | |
| *** thorst has joined #openstack-nova | 00:16 | |
| *** mwagner_lap has joined #openstack-nova | 00:17 | |
| *** shoutm has quit IRC | 00:18 | |
| melwitt | mriedem1: I saw this patch today about encrypted volume attach failure https://review.openstack.org/#/c/196482/ and thought you might have some input about it | 00:18 |
|---|---|---|
| *** thorst has quit IRC | 00:20 | |
| *** zxyf has quit IRC | 00:20 | |
| *** zxyf has joined #openstack-nova | 00:21 | |
| *** shoutm has joined #openstack-nova | 00:21 | |
| mriedem1 | oh boy | 00:23 |
| mriedem1 | i added hemnafk, i'd want to dig into the os-brick code before i score the nova change | 00:25 |
| mriedem1 | and i probably don't have the energy for that tonight | 00:25 |
| *** achanda has joined #openstack-nova | 00:26 | |
| mriedem1 | melwitt: -1 since i think there is maybe an upgrade impact on that one | 00:27 |
| melwitt | mriedem1: okay. I thought it wasn't related to the os-brick | 00:28 |
| mriedem1 | well os-brick does the iscsi stuff for libvirt now | 00:28 |
| melwitt | mriedem1: yeah, I guess I thought this was just a file naming collision | 00:28 |
| mriedem1 | unfortunately the output from cryptsetup when it fails sucks | 00:30 |
| mriedem1 | and no stderr | 00:30 |
| melwitt | yeah, I did see that | 00:30 |
| *** markvoelker has joined #openstack-nova | 00:31 | |
| melwitt | mriedem1: I removed my vote. thanks for looking at it | 00:33 |
| mriedem1 | np | 00:33 |
| *** dannywilson has quit IRC | 00:35 | |
| *** shoutm_ has joined #openstack-nova | 00:38 | |
| *** shoutm has quit IRC | 00:40 | |
| *** Sukhdev has quit IRC | 00:43 | |
| *** dims__ has quit IRC | 00:46 | |
| *** dims__ has joined #openstack-nova | 00:47 | |
| *** swamireddy has quit IRC | 00:48 | |
| *** lbragstad has quit IRC | 00:48 | |
| *** erhudy has quit IRC | 00:48 | |
| *** BadCub has quit IRC | 00:48 | |
| *** wendar has quit IRC | 00:48 | |
| *** gus has quit IRC | 00:48 | |
| *** Nakato has quit IRC | 00:48 | |
| *** toanster has quit IRC | 00:48 | |
| *** darrenc has quit IRC | 00:48 | |
| *** erhudy has joined #openstack-nova | 00:48 | |
| *** wendar has joined #openstack-nova | 00:49 | |
| *** apmelton_ has quit IRC | 00:49 | |
| *** darrenc has joined #openstack-nova | 00:49 | |
| *** jamielennox has quit IRC | 00:49 | |
| *** flwang has quit IRC | 00:49 | |
| *** raorn has quit IRC | 00:49 | |
| *** jaypipes has quit IRC | 00:50 | |
| *** StevenK has quit IRC | 00:50 | |
| *** toan has joined #openstack-nova | 00:50 | |
| *** shoutm_ has quit IRC | 00:50 | |
| *** shoutm has joined #openstack-nova | 00:50 | |
| *** d34dh0r53 has quit IRC | 00:50 | |
| *** comstud has quit IRC | 00:50 | |
| *** jroll has quit IRC | 00:50 | |
| *** ttx has quit IRC | 00:50 | |
| *** Nakato has joined #openstack-nova | 00:50 | |
| *** raorn has joined #openstack-nova | 00:50 | |
| *** mgagne has quit IRC | 00:50 | |
| *** BadCub has joined #openstack-nova | 00:51 | |
| *** StevenK has joined #openstack-nova | 00:51 | |
| *** gus has joined #openstack-nova | 00:51 | |
| alex_xu | oomichi: o ha yo | 00:51 |
| *** lhcheng has left #openstack-nova | 00:51 | |
| *** apmelton has joined #openstack-nova | 00:51 | |
| oomichi | alex_xu: morning :) | 00:51 |
| alex_xu | oomichi: finally we agreement on fix hint for v2.1 | 00:52 |
| oomichi | alex_xu: without microversion? | 00:52 |
| *** ttx has joined #openstack-nova | 00:53 | |
| alex_xu | oomichi: but we still want https://review.openstack.org/220791 only fix for v2. so this https://review.openstack.org/221129 still useful | 00:53 |
| oomichi | alex_xu: or just for v2.0 compatible? | 00:53 |
| alex_xu | oomichi: yea | 00:53 |
| alex_xu | oomichi: oops sorry | 00:53 |
| *** jroll has joined #openstack-nova | 00:53 | |
| *** d34dh0r53 has joined #openstack-nova | 00:53 | |
| *** comstud has joined #openstack-nova | 00:53 | |
| alex_xu | oomichi: hint for v2.1 compatible only | 00:53 |
| *** mgagne has joined #openstack-nova | 00:54 | |
| *** jamielennox has joined #openstack-nova | 00:54 | |
| oomichi | alex_xu: ok, thanks for notification | 00:54 |
| *** lbragstad has joined #openstack-nova | 00:54 | |
| *** swamireddy has joined #openstack-nova | 00:54 | |
| alex_xu | oomichi: np, cloud you remove -w for https://review.openstack.org/221129 | 00:54 |
| oomichi | alex_xu: https://review.openstack.org/221129 is fine for me now, and will remove -W for ready for review | 00:54 |
| oomichi | alex_xu: ok, will soon | 00:54 |
| alex_xu | oomichi: thanks, will try to review soon | 00:55 |
| oomichi | alex_xu: done, thanks in advance for your review ;) | 00:55 |
| alex_xu | oomichi: np :) | 00:55 |
| *** flwang has joined #openstack-nova | 00:56 | |
| *** jaypipes has joined #openstack-nova | 00:56 | |
| *** zhangjn has joined #openstack-nova | 00:56 | |
| *** thorst has joined #openstack-nova | 00:57 | |
| *** zhangjn has quit IRC | 00:58 | |
| *** ijw_ has joined #openstack-nova | 00:58 | |
| *** thorst has quit IRC | 00:58 | |
| *** tpeoples has quit IRC | 00:59 | |
| *** zzzeek has quit IRC | 01:01 | |
| *** zhenguo has joined #openstack-nova | 01:02 | |
| *** kse201 has joined #openstack-nova | 01:03 | |
| *** kse has quit IRC | 01:06 | |
| *** zhangjn has joined #openstack-nova | 01:06 | |
| *** penick has joined #openstack-nova | 01:10 | |
| *** zhangjn_ has joined #openstack-nova | 01:11 | |
| *** zhangjn has quit IRC | 01:14 | |
| *** yonglihe has joined #openstack-nova | 01:15 | |
| *** mriedem1 is now known as mriedem_away | 01:15 | |
| *** vladikr has quit IRC | 01:15 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: Handle InstanceUnknownCell exceptions https://review.openstack.org/212965 | 01:21 |
| *** tri2sing has quit IRC | 01:24 | |
| *** vilobhmm_11 has quit IRC | 01:24 | |
| *** lyanchih has joined #openstack-nova | 01:25 | |
| *** tjones has joined #openstack-nova | 01:25 | |
| *** penick has quit IRC | 01:26 | |
| *** baoli has joined #openstack-nova | 01:28 | |
| *** salv-orlando has joined #openstack-nova | 01:29 | |
| *** baoli has quit IRC | 01:31 | |
| *** baoli has joined #openstack-nova | 01:31 | |
| *** Jeffrey4l has joined #openstack-nova | 01:34 | |
| *** salv-orlando has quit IRC | 01:36 | |
| *** haomaiwang has joined #openstack-nova | 01:37 | |
| gmann | oomichi: alex_xu : that looks good for me, it will cover server name and hint schema fixes. - https://review.openstack.org/#/c/221129/ | 01:38 |
| *** baoli has quit IRC | 01:38 | |
| *** tjones has quit IRC | 01:42 | |
| *** darrenc is now known as darrenc_afk | 01:42 | |
| *** salv-orlando has joined #openstack-nova | 01:43 | |
| oomichi | gmann: thanks for your review!! | 01:43 |
| *** salv-orlando has quit IRC | 01:47 | |
| openstackgerrit | Xiaowei Qian proposed openstack/python-novaclient: Modify "nova keypair-show" Positional arguments help information CLI "nova keypair-show <keypair>", Positional arguments: <keypair> Name or ID of keypair But in fact, it does not support ID,when using ID, the error is as follows: [root]# nova keypair-sh https://review.openstack.org/221181 | 01:48 |
| *** otter768 has joined #openstack-nova | 01:56 | |
| *** deepthi has joined #openstack-nova | 01:59 | |
| *** armax has joined #openstack-nova | 01:59 | |
| *** Marga__ has quit IRC | 02:00 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-nova | 02:01 | |
| *** otter768 has quit IRC | 02:01 | |
| *** kse201 has quit IRC | 02:06 | |
| *** kse has joined #openstack-nova | 02:07 | |
| *** ijw_ has quit IRC | 02:07 | |
| *** asettle has quit IRC | 02:09 | |
| alex_xu | gmann: will review in next minutes | 02:10 |
| *** baoli has joined #openstack-nova | 02:10 | |
| openstackgerrit | Alex Xu proposed openstack/nova: api: allow any scheduler hints https://review.openstack.org/217727 | 02:11 |
| alex_xu | gmann: oomichi ^ | 02:11 |
| *** baoli has quit IRC | 02:12 | |
| *** baoli has joined #openstack-nova | 02:12 | |
| openstackgerrit | Alex Xu proposed openstack/nova: api: allow any scheduler hints https://review.openstack.org/217727 | 02:12 |
| *** Apoorva_ has quit IRC | 02:14 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: make sure os_password is set https://review.openstack.org/221568 | 02:14 |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: not all apis have the versions available https://review.openstack.org/221569 | 02:14 |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: add tests for api_version Unauthorized https://review.openstack.org/221570 | 02:14 |
| alex_xu | gmann: hi | 02:15 |
| gmann | alex_xu: hi | 02:15 |
| alex_xu | gmann: a question, so after we change service catalog: compute point to v2.1 | 02:15 |
| alex_xu | gmann: so now, all the CI agasint the v2.1 now, so the bug report about API back-compatible is about v2.1, not v2.1 compat | 02:16 |
| *** tpeoples has joined #openstack-nova | 02:16 | |
| *** darrenc_afk is now known as darrenc | 02:17 | |
| alex_xu | gmann: right? Am I clear of my mind | 02:17 |
| gmann | alex_xu: yes, you are right. all gate jobs will be running against /v2.1 | 02:18 |
| gmann | alex_xu: any new bugs come up:) ? | 02:18 |
| *** yamahata has quit IRC | 02:19 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: make sure os_password is set https://review.openstack.org/221570 | 02:20 |
| alex_xu | gmann: no new bug, just want to clear my mind... | 02:20 |
| alex_xu | gmann: thanks :) | 02:20 |
| gmann | alex_xu: ok, np | 02:21 |
| gmann | alex_xu: actually tempest use 'compute' as default catalog for all tests | 02:21 |
| *** unicell has quit IRC | 02:22 | |
| gmann | alex_xu: and we changed 'compute' catalog to point to /v2.1 from /v2.0- https://review.openstack.org/#/c/219347/2/lib/nova | 02:22 |
| jwcroppe | alex_xu: FYI - https://review.openstack.org/#/c/219153/ - revamped metrics stuff that we discussed previously | 02:22 |
| * alex_xu feel nervous recently | 02:24 | |
| alex_xu | gmann: got it, thanks | 02:24 |
| alex_xu | jwcroppe: yea, I notice that, just didn't get chance revisit it again. will try later | 02:24 |
| jwcroppe | alex_xu: no problem - thanks! | 02:24 |
| *** zxyf has quit IRC | 02:26 | |
| *** zxyf has joined #openstack-nova | 02:26 | |
| *** baoli has quit IRC | 02:27 | |
| *** changbl has joined #openstack-nova | 02:28 | |
| alex_xu | jwcroppe: np | 02:28 |
| *** markvoelker has quit IRC | 02:31 | |
| *** baoli has joined #openstack-nova | 02:32 | |
| *** baoli has quit IRC | 02:32 | |
| *** ijw_ has joined #openstack-nova | 02:37 | |
| *** otter768 has joined #openstack-nova | 02:39 | |
| *** baoli has joined #openstack-nova | 02:39 | |
| *** vilobhmm_11 has joined #openstack-nova | 02:40 | |
| alex_xu | oomichi: just reviewed https://review.openstack.org/#/c/221129/2, I have one comment, hope to get your opinion. | 02:43 |
| *** zhangjn has joined #openstack-nova | 02:46 | |
| *** VW_ has joined #openstack-nova | 02:47 | |
| oomichi | alex_xu: thanks, can you take a look at that again? | 02:48 |
| *** garyk has quit IRC | 02:49 | |
| *** hparekh has joined #openstack-nova | 02:49 | |
| *** zhangjn_ has quit IRC | 02:49 | |
| *** chenzeng has joined #openstack-nova | 02:51 | |
| *** SourabhP has joined #openstack-nova | 02:51 | |
| *** SourabhP_ has joined #openstack-nova | 02:53 | |
| alex_xu | oomichi: yea, sure | 02:54 |
| *** shyu has joined #openstack-nova | 02:54 | |
| *** shoutm has quit IRC | 02:55 | |
| *** SourabhP has quit IRC | 02:55 | |
| *** SourabhP_ is now known as SourabhP | 02:55 | |
| *** haomaiwang has quit IRC | 02:55 | |
| *** albertom has quit IRC | 02:56 | |
| *** dims_ has joined #openstack-nova | 02:56 | |
| *** haomaiwa_ has joined #openstack-nova | 02:57 | |
| *** asettle has joined #openstack-nova | 02:57 | |
| alex_xu | oomichi: actually wsgi.Controller.api_version always start from v2.1 | 02:57 |
| *** asettle has quit IRC | 02:58 | |
| *** asettle has joined #openstack-nova | 02:58 | |
| *** dims__ has quit IRC | 02:58 | |
| *** albertom has joined #openstack-nova | 02:59 | |
| *** humble_ has quit IRC | 03:00 | |
| *** haomaiwa_ has quit IRC | 03:01 | |
| *** haomaiwa_ has joined #openstack-nova | 03:01 | |
| *** salv-orlando has joined #openstack-nova | 03:03 | |
| alex_xu | oomichi: anyway all of those will remove when v2 disapear. so I can live with the current patch also. anyway thanks for the feedback :) | 03:03 |
| *** SourabhP has quit IRC | 03:04 | |
| *** SourabhP has joined #openstack-nova | 03:05 | |
| oomichi | alex_xu: that is a nice point, it will be a nice working item in Mitaka :) | 03:05 |
| *** armax has quit IRC | 03:05 | |
| *** Piet has quit IRC | 03:05 | |
| alex_xu | oomichi: yea, anyway let me catch up time update my patch to based on yours | 03:06 |
| *** shoutm has joined #openstack-nova | 03:06 | |
| openstackgerrit | Zhongcheng Lao proposed openstack/nova: VMware: Omit exceptions during snapshot cleanup https://review.openstack.org/216086 | 03:06 |
| alex_xu | oomichi: and hope you take a look at https://review.openstack.org/217727 again :) | 03:07 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:07 |
| oomichi | alex_xu: sure, will do that after reading log of yesterday meeting. | 03:08 |
| alex_xu | oomichi: thanks :) | 03:08 |
| *** chenzeng has quit IRC | 03:09 | |
| *** zhangjn_ has joined #openstack-nova | 03:09 | |
| *** salv-orlando has quit IRC | 03:10 | |
| *** baoli has quit IRC | 03:11 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 03:11 |
| *** zhangjn has quit IRC | 03:13 | |
| *** Marga_ has joined #openstack-nova | 03:15 | |
| *** VW_ has quit IRC | 03:15 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 03:15 |
| *** VW_ has joined #openstack-nova | 03:16 | |
| *** zhangjn has joined #openstack-nova | 03:16 | |
| *** zhangjn_ has quit IRC | 03:19 | |
| *** kse has quit IRC | 03:21 | |
| *** VW_ has quit IRC | 03:21 | |
| *** armax has joined #openstack-nova | 03:22 | |
| *** kse has joined #openstack-nova | 03:23 | |
| *** bswartz has quit IRC | 03:30 | |
| *** markvoelker has joined #openstack-nova | 03:31 | |
| *** VikasC has joined #openstack-nova | 03:32 | |
| *** apmelton has quit IRC | 03:32 | |
| *** armax has quit IRC | 03:33 | |
| *** apmelton has joined #openstack-nova | 03:34 | |
| *** markvoelker has quit IRC | 03:36 | |
| *** zhangjn_ has joined #openstack-nova | 03:36 | |
| *** nelsnels_ has joined #openstack-nova | 03:36 | |
| *** zhangjn has quit IRC | 03:40 | |
| *** nelsnelson has quit IRC | 03:40 | |
| *** lyanchih has quit IRC | 03:46 | |
| *** bswartz has joined #openstack-nova | 03:46 | |
| *** garyk has joined #openstack-nova | 03:48 | |
| *** nelsnels_ has quit IRC | 03:49 | |
| *** nelsnelson has joined #openstack-nova | 03:49 | |
| *** baoli has joined #openstack-nova | 03:49 | |
| *** nelsnelson has quit IRC | 03:50 | |
| *** dave-mccowan has quit IRC | 03:51 | |
| *** achanda has quit IRC | 03:53 | |
| *** otter768 has quit IRC | 03:53 | |
| *** baoli has quit IRC | 03:54 | |
| *** baoli has joined #openstack-nova | 03:56 | |
| *** lyanchih has joined #openstack-nova | 03:57 | |
| *** salv-orlando has joined #openstack-nova | 03:59 | |
| *** hparekh has quit IRC | 04:01 | |
| *** haomaiwa_ has quit IRC | 04:01 | |
| *** 7F1AAJQF9 has joined #openstack-nova | 04:01 | |
| *** vilobhmm_11 has quit IRC | 04:01 | |
| *** wverdugo500 has quit IRC | 04:04 | |
| *** salv-orlando has quit IRC | 04:04 | |
| *** alex_xu has quit IRC | 04:04 | |
| *** lyanchih has quit IRC | 04:05 | |
| *** alex_xu has joined #openstack-nova | 04:05 | |
| *** deepakcs has joined #openstack-nova | 04:10 | |
| *** Sree has joined #openstack-nova | 04:10 | |
| *** Sree has quit IRC | 04:10 | |
| *** Sree has joined #openstack-nova | 04:11 | |
| *** dims_ has quit IRC | 04:13 | |
| *** hparekh has joined #openstack-nova | 04:14 | |
| *** baoli has quit IRC | 04:16 | |
| *** armax has joined #openstack-nova | 04:16 | |
| *** achanda has joined #openstack-nova | 04:28 | |
| *** Sukhdev has joined #openstack-nova | 04:28 | |
| *** zxyf has quit IRC | 04:33 | |
| *** moshele has joined #openstack-nova | 04:34 | |
| *** zxyf has joined #openstack-nova | 04:37 | |
| *** vilobhmm_11 has joined #openstack-nova | 04:39 | |
| *** Marga_ has quit IRC | 04:41 | |
| *** baoli has joined #openstack-nova | 04:41 | |
| *** tri2sing has joined #openstack-nova | 04:41 | |
| *** baoli has quit IRC | 04:43 | |
| *** tri2sing has quit IRC | 04:44 | |
| *** tri2sing has joined #openstack-nova | 04:45 | |
| *** salv-orlando has joined #openstack-nova | 04:55 | |
| *** tpeoples has quit IRC | 04:57 | |
| *** salv-orlando has quit IRC | 04:58 | |
| *** 7F1AAJQF9 has quit IRC | 05:01 | |
| *** shoutm has quit IRC | 05:01 | |
| *** haomaiwa_ has joined #openstack-nova | 05:01 | |
| *** shoutm has joined #openstack-nova | 05:05 | |
| *** zhangjn_ has quit IRC | 05:11 | |
| *** Chandan_p has joined #openstack-nova | 05:12 | |
| *** chhavi has joined #openstack-nova | 05:13 | |
| *** Apoorva has joined #openstack-nova | 05:17 | |
| *** tri2sing has quit IRC | 05:17 | |
| *** shoutm has quit IRC | 05:22 | |
| *** tojuvone has joined #openstack-nova | 05:22 | |
| *** Kevin_Zheng has quit IRC | 05:25 | |
| *** SourabhP has quit IRC | 05:26 | |
| *** vivekd has joined #openstack-nova | 05:26 | |
| *** changbl has quit IRC | 05:30 | |
| *** raildo-afk has quit IRC | 05:30 | |
| *** Chandan_p has quit IRC | 05:32 | |
| *** markvoelker has joined #openstack-nova | 05:32 | |
| *** Apoorva has quit IRC | 05:33 | |
| *** raildo-afk has joined #openstack-nova | 05:34 | |
| *** markvoelker has quit IRC | 05:37 | |
| *** ekarlso- has joined #openstack-nova | 05:37 | |
| *** salv-orlando has joined #openstack-nova | 05:38 | |
| *** ishant has joined #openstack-nova | 05:41 | |
| *** nihilifer has joined #openstack-nova | 05:41 | |
| *** deepthi has quit IRC | 05:45 | |
| *** lyanchih has joined #openstack-nova | 05:46 | |
| *** unicell has joined #openstack-nova | 05:46 | |
| *** unicell has quit IRC | 05:49 | |
| *** ekarlso- has quit IRC | 05:50 | |
| *** chhavi has quit IRC | 05:52 | |
| *** otter768 has joined #openstack-nova | 05:54 | |
| *** unicell has joined #openstack-nova | 05:55 | |
| *** asettle has quit IRC | 05:57 | |
| *** vilobhmm_11 has quit IRC | 05:57 | |
| *** otter768 has quit IRC | 05:59 | |
| *** wanghua has joined #openstack-nova | 05:59 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-nova | 06:01 | |
| *** chhavi has joined #openstack-nova | 06:05 | |
| *** alex_klimov has joined #openstack-nova | 06:06 | |
| *** shoutm has joined #openstack-nova | 06:13 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221609 | 06:22 |
| *** chhavi has quit IRC | 06:24 | |
| *** cristicalin has joined #openstack-nova | 06:24 | |
| *** EinstCrazy has joined #openstack-nova | 06:26 | |
| *** Sukhdev has quit IRC | 06:28 | |
| *** Murali has joined #openstack-nova | 06:31 | |
| *** mpaolino has joined #openstack-nova | 06:31 | |
| *** chhavi has joined #openstack-nova | 06:36 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor provider_fw_rule_get_all() https://review.openstack.org/216241 | 06:38 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused provider firewall rules functionality in nova https://review.openstack.org/184027 | 06:38 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove provider_fw_rules tables and associated db api methods https://review.openstack.org/216242 | 06:38 |
| *** deepthi has joined #openstack-nova | 06:38 | |
| *** unicell1 has joined #openstack-nova | 06:39 | |
| *** lyanchih has quit IRC | 06:39 | |
| *** lyanchih has joined #openstack-nova | 06:40 | |
| *** unicell has quit IRC | 06:41 | |
| *** irenab has joined #openstack-nova | 06:41 | |
| *** cfriesen has quit IRC | 06:43 | |
| *** paul-carlton has joined #openstack-nova | 06:46 | |
| *** ttx has quit IRC | 06:48 | |
| *** ttx has joined #openstack-nova | 06:48 | |
| *** hanzhang has quit IRC | 06:49 | |
| *** venkat_p has joined #openstack-nova | 06:51 | |
| *** Sree has quit IRC | 06:53 | |
| *** Sree has joined #openstack-nova | 06:53 | |
| *** haypo has joined #openstack-nova | 06:55 | |
| *** ildikov has quit IRC | 06:55 | |
| *** abhishekk has joined #openstack-nova | 06:55 | |
| *** hparekh has left #openstack-nova | 06:56 | |
| *** Sree has quit IRC | 06:58 | |
| *** rdopiera has joined #openstack-nova | 06:58 | |
| *** jaypipes has quit IRC | 07:00 | |
| *** haomaiwang has quit IRC | 07:01 | |
| gmann | alex_xu: sdague : johnthetubaguy : For v2.0 jobs as experimental in Tempest gate- https://review.openstack.org/#/c/221608/ | 07:01 |
| *** haomaiwang has joined #openstack-nova | 07:01 | |
| *** armax has quit IRC | 07:02 | |
| alex_xu | gmann: thanks a lot | 07:03 |
| gmann | alex_xu: np :) | 07:03 |
| *** lsmola has joined #openstack-nova | 07:03 | |
| *** matrohon has joined #openstack-nova | 07:10 | |
| *** coolsvap is now known as coolsvap|brb | 07:14 | |
| *** rubasov has joined #openstack-nova | 07:14 | |
| *** vivekd has quit IRC | 07:14 | |
| *** romainh has joined #openstack-nova | 07:16 | |
| *** armax has joined #openstack-nova | 07:18 | |
| *** alexschm has joined #openstack-nova | 07:19 | |
| openstackgerrit | Yingxin proposed openstack/nova: Fix MetricWeigher to use MonitorMetricList https://review.openstack.org/221620 | 07:20 |
| *** ildikov has joined #openstack-nova | 07:23 | |
| *** shoutm has quit IRC | 07:28 | |
| *** shoutm has joined #openstack-nova | 07:29 | |
| *** shoutm_ has joined #openstack-nova | 07:31 | |
| *** achanda has quit IRC | 07:32 | |
| openstackgerrit | Yingxin proposed openstack/nova: Fix MetricWeigher to use MonitorMetricList https://review.openstack.org/221620 | 07:33 |
| *** shoutm has quit IRC | 07:33 | |
| *** markvoelker has joined #openstack-nova | 07:33 | |
| *** pilgrimstack1 has left #openstack-nova | 07:33 | |
| *** irenab has quit IRC | 07:35 | |
| *** ildikov has quit IRC | 07:36 | |
| *** browne has quit IRC | 07:36 | |
| *** irenab has joined #openstack-nova | 07:36 | |
| *** achanda has joined #openstack-nova | 07:36 | |
| *** markvoelker has quit IRC | 07:38 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 07:38 |
| *** ijw_ has quit IRC | 07:40 | |
| *** jlanoux has joined #openstack-nova | 07:40 | |
| *** adun153 has joined #openstack-nova | 07:44 | |
| *** Sree has joined #openstack-nova | 07:44 | |
| *** gszasz has joined #openstack-nova | 07:44 | |
| *** karimb has joined #openstack-nova | 07:45 | |
| *** alexpilotti_ has joined #openstack-nova | 07:47 | |
| *** ildikov has joined #openstack-nova | 07:49 | |
| *** apuimedo has joined #openstack-nova | 07:51 | |
| *** adun153 has left #openstack-nova | 07:51 | |
| *** salv-orlando has quit IRC | 07:51 | |
| *** Jeffrey4l has quit IRC | 07:52 | |
| bauzas | oomichi: still around for a few ? | 07:55 |
| *** otter768 has joined #openstack-nova | 07:55 | |
| oomichi | bauzas: Bonjour | 07:58 |
| bauzas | oomichi: ohayou gozaimazu | 08:00 |
| *** otter768 has quit IRC | 08:00 | |
| * bauzas just in the middle of learning Japanese since 1 month | 08:00 | |
| oomichi | bauzas: :) | 08:00 |
| bauzas | oomichi: well, actually, it's the evening for you | 08:00 |
| *** achanda has quit IRC | 08:00 | |
| bauzas | so, konbanwa | 08:00 |
| oomichi | bauzas: yeah, that's right | 08:00 |
| * bauzas still needs to learn the hiragana | 08:00 | |
| *** haomaiwang has quit IRC | 08:01 | |
| oomichi | bauzas: you can enjoy tokyo summit by these words :) | 08:01 |
| *** haomaiwang has joined #openstack-nova | 08:01 | |
| bauzas | oomichi: well, I hope to say more than that :) | 08:01 |
| oomichi | bauzas: very nice! | 08:02 |
| bauzas | but only by romaji :/ | 08:02 |
| bauzas | anyway | 08:02 |
| bauzas | so, yeah I had two points for you | 08:02 |
| *** achanda has joined #openstack-nova | 08:02 | |
| oomichi | ok, I'd like to know them | 08:03 |
| bauzas | #1 https://review.openstack.org/#/c/220440/ I agree it deserves a spec, but I'd like to discuss with you about some implementation thoughts | 08:03 |
| oomichi | ok, that is interesting | 08:04 |
| *** lucasagomes has joined #openstack-nova | 08:04 | |
| bauzas | #2 https://review.openstack.org/#/c/220893/ alaski and I were discussing about that yesterday | 08:04 |
| oomichi | what is #2? | 08:04 |
| bauzas | and we had a question for you | 08:04 |
| bauzas | that's mostly for my knowledge too | 08:04 |
| bauzas | so, maybe #2 is the quickiest to disucss | 08:05 |
| oomichi | ok, what is #3? | 08:05 |
| bauzas | discuss even | 08:05 |
| bauzas | there is no #3 :D | 08:05 |
| oomichi | bauzas: I see :) | 08:05 |
| oomichi | bauzas: ok, let's talk about #2 | 08:05 |
| bauzas | so, what happens atm when someone is providing an hint that's not in the list ? | 08:05 |
| bauzas | gracefully ignored ? | 08:05 |
| oomichi | bauzas: on legacy v2.0 or v2.1? | 08:06 |
| bauzas | v2.1 in general I'd say | 08:06 |
| bauzas | because v2.0 was having no input validation | 08:06 |
| oomichi | bauzas: currently, nova returns BadRequest response on v2.1 | 08:07 |
| oomichi | due to input validation | 08:07 |
| bauzas | oomichi: and https://review.openstack.org/#/c/220893/ is targeting to fix v2.1 | 08:07 |
| *** achanda has quit IRC | 08:07 | |
| bauzas | oomichi: oh ? | 08:07 |
| bauzas | oomichi: any code you could share ? | 08:07 |
| bauzas | oomichi: you mean that if I was just providing "foo=bar", I'd get a 400 ? | 08:07 |
| oomichi | bauzas: yes, "foo=bar" returns 400 | 08:08 |
| *** danpb has joined #openstack-nova | 08:08 | |
| bauzas | oh... | 08:08 |
| oomichi | that is very difficult point. | 08:08 |
| bauzas | oomichi: that's a very strict policy IMHO | 08:08 |
| bauzas | oomichi: at least for the hints | 08:08 |
| oomichi | yes, right. | 08:08 |
| bauzas | oomichi: but I don't want to break the consensus | 08:09 |
| bauzas | oomichi: so back to your change | 08:09 |
| bauzas | oomichi: that means that what was previously returning a 404 would now return a 202, right? | 08:09 |
| oomichi | to be honest, I didn't know we are saying "you can create scheduler as you like" in nova document | 08:09 |
| *** Jeffrey4l has joined #openstack-nova | 08:10 | |
| bauzas | oomichi: so I guess that alaski made a very valid point, it could potentially require a microversion, nope? | 08:10 |
| bauzas | oomichi: because it changes the behaviour | 08:10 |
| bauzas | even for a bugfix | 08:10 |
| * bauzas digs into the API microversions rules document | 08:11 | |
| oomichi | like https://github.com/openstack/nova/blob/master/doc/source/filter_scheduler.rst#filtering | 08:11 |
| *** mdbooth has joined #openstack-nova | 08:11 | |
| *** yassine__ has joined #openstack-nova | 08:11 | |
| oomichi | bauzas: yeah, that was my point also | 08:11 |
| bauzas | oomichi: well, I think we're opening a can of worms | 08:11 |
| *** alexpilotti_ has quit IRC | 08:11 | |
| bauzas | oomichi: because #1 is also pointing that problem | 08:11 |
| oomichi | bauzas: but I can accept these changes without microversions also | 08:11 |
| oomichi | because the above link seems to accept customized scheduler | 08:12 |
| bauzas | oomichi: well, gimme 2 sec, explaining you how all of that work | 08:12 |
| oomichi | bauzas: yeah, that is right. we are on difficult position | 08:13 |
| oomichi | on #1 | 08:13 |
| *** alexpilotti_ has joined #openstack-nova | 08:13 | |
| bauzas | oomichi: so, given an operator picks the default choice of running the FilterScheduler | 08:14 |
| bauzas | oomichi: then, he will have to decide which filters to run | 08:14 |
| bauzas | oomichi: ie. doing that http://sbauza.github.io/2015/05/18/#/7 | 08:14 |
| bauzas | oomichi: just a conf flag | 08:14 |
| bauzas | oomichi: that's not using stevedore but the nova base loader IIRCF | 08:14 |
| bauzas | IIRC | 08:14 |
| bauzas | oomichi: so, since each filter can query for a specific hint, that makes the input validation very variable | 08:15 |
| oomichi | bauzas: cool!! thanks for your explanation :) | 08:15 |
| bauzas | because I don't want to take too much time on discussing #2, could you maybe please put some comment in the commit msg explaining why you think it doesn't require a microversion ? | 08:16 |
| oomichi | bauzas: that will be nice to get available validation pattern from available schedulers | 08:16 |
| bauzas | oomichi: so, about that, more closely related to #1 | 08:17 |
| bauzas | oomichi: about the modulariy | 08:17 |
| bauzas | modularity | 08:17 |
| *** chhavi has quit IRC | 08:17 | |
| bauzas | oomichi: what I'd like to avoid is by some extend to have the scheduler assume the input validation | 08:17 |
| *** Jeffrey4l has quit IRC | 08:17 | |
| oomichi | bauzas: yeah, nice idea. but before that, I'd like to post patch for adding scheduler-hints parameters as exception of microversion bump as microversion rule. | 08:17 |
| bauzas | oomichi: fair point | 08:18 |
| bauzas | oomichi: very fair point even | 08:18 |
| *** lpetrut has joined #openstack-nova | 08:18 | |
| bauzas | oomichi: so, about #1, I think we're just talking about making sure that two components are able to discuss | 08:19 |
| bauzas | oomichi: hence my idea to consider a NovaObject for that | 08:19 |
| *** shoutm has joined #openstack-nova | 08:21 | |
| *** rotbeard has quit IRC | 08:23 | |
| bauzas | oomichi: but like I said in the review, feel free to create a spec, I'd be glad to help you on that one | 08:23 |
| *** shoutm_ has quit IRC | 08:24 | |
| *** rotbeard has joined #openstack-nova | 08:24 | |
| *** rotbeard has quit IRC | 08:25 | |
| oomichi | bauzas: thank you so much, maybe nova-specs is good to explain/get the idea | 08:25 |
| *** rotbeard has joined #openstack-nova | 08:26 | |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 08:26 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: use guest as parameter for get serial ports https://review.openstack.org/220519 | 08:26 |
| bauzas | oomichi: I'd like to see some other people reviewing that too | 08:28 |
| *** rotbeard has quit IRC | 08:28 | |
| bauzas | oomichi: so yeah, for v2.1 we need to tackle that anyway | 08:28 |
| *** haypo has left #openstack-nova | 08:28 | |
| bauzas | oomichi: for v2.0 on v2.1, we just need to relax the input validation | 08:28 |
| *** asettle has joined #openstack-nova | 08:29 | |
| bauzas | oomichi: and for the meantime, until the spec is approved and the implementation done, just make sure that all hints are provided in api validation without necessarly requiring a microversion bump | 08:29 |
| bauzas | oomichi: the latter is IMHO highly debatable | 08:29 |
| *** rotbeard has joined #openstack-nova | 08:30 | |
| bauzas | oomichi: hence the additionalProperties point | 08:30 |
| *** Jeffrey4l has joined #openstack-nova | 08:30 | |
| *** jcoufal has quit IRC | 08:31 | |
| *** jistr has joined #openstack-nova | 08:32 | |
| johnthetubaguy | bauzas: oomichi: just checking, but this all sounds like mitaka stuff for properly fixing the scheduler hint stuff? | 08:32 |
| bauzas | johnthetubaguy: yep | 08:32 |
| *** Daisy has joined #openstack-nova | 08:33 | |
| oomichi | bauzas: johnthetubaguy: I found interesting thing. we don't have a docment which requires microversion bump when adding a new parameter to request body. | 08:33 |
| oomichi | bauzas: johnthetubaguy: maybe that is a document bug. | 08:33 |
| oomichi | bauzas: johnthetubaguy: but we can add a new parameter at this time without microversion as rule | 08:33 |
| bauzas | johnthetubaguy: I'm actually a bit concerned by having the input validation returning a 400 if an additional hint is provided - I thought it was just gracefully ignored | 08:34 |
| johnthetubaguy | oomichi: thats a document bug, that extra param should only ever apper in the new version, I believe | 08:34 |
| bauzas | hence the additionalProperties=True I'd like to see it set | 08:34 |
| johnthetubaguy | oomichi: at least the original spec said something like that | 08:34 |
| oomichi | https://github.com/openstack/nova/blob/master/doc/source/api_microversion_dev.rst#when-do-i-need-a-new-microversion | 08:34 |
| johnthetubaguy | bauzas: I have a change up to relax that | 08:34 |
| bauzas | johnthetubaguy: for v2.0 on v2.1 or for v2.1 in general ? | 08:35 |
| oomichi | johnthetubaguy: yeah I know, but we can from the doc ;) | 08:35 |
| johnthetubaguy | oomichi: it says, bump the version when adding new attributes right? | 08:35 |
| johnthetubaguy | bauzas: thats the debate on that patch | 08:35 |
| *** irenab has quit IRC | 08:35 | |
| oomichi | johnthetubaguy: when adding it to response, not request on current doc | 08:35 |
| *** irenab has joined #openstack-nova | 08:36 | |
| johnthetubaguy | oomichi: hmm, yes, its missing on that side, I see what you mean now | 08:36 |
| oomichi | johnthetubaguy: yeah, just kidding :) | 08:36 |
| *** dguitarbite has joined #openstack-nova | 08:36 | |
| johnthetubaguy | oomichi: I don't see us getting these rules correct for a release or two yet | 08:37 |
| johnthetubaguy | much closer than 6 months ago now, but still not ready | 08:37 |
| oomichi | johnthetubaguy: because the API is super big and still continue growing | 08:37 |
| *** karimb has quit IRC | 08:38 | |
| bauzas | johnthetubaguy: okay, that's probably already in my list, lemme check | 08:39 |
| bauzas | johnthetubaguy: gotcha https://review.openstack.org/#/c/217727/ ? | 08:40 |
| *** ijw_ has joined #openstack-nova | 08:40 | |
| bauzas | oomichi: thanks anyway for that discussion, greatly useful | 08:41 |
| *** derekh has joined #openstack-nova | 08:44 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion rule when adding attr to request https://review.openstack.org/221642 | 08:45 |
| *** ijw_ has quit IRC | 08:45 | |
| oomichi | bauzas: johnthetubaguy: ^^^ is a new try for fixing the lack of rule | 08:46 |
| johnthetubaguy | oomichi: can we get all these important patches into https://etherpad.openstack.org/p/liberty-nova-priorities-tracking that should get all the cores looking out for them | 08:47 |
| johnthetubaguy | (also, mostly, because I will forget otherwise) | 08:47 |
| oomichi | johnthetubaguy: sure, nice advice :) | 08:48 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion rule when adding attr to request https://review.openstack.org/221642 | 08:49 |
| openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 08:50 |
| openstackgerrit | Alex Xu proposed openstack/nova: Separate API schemas for v2.0 compatible API https://review.openstack.org/221129 | 08:50 |
| bauzas | oomichi: ack, in my queue | 08:53 |
| *** e0ne has joined #openstack-nova | 08:54 | |
| *** jcoufal has joined #openstack-nova | 08:55 | |
| *** karimb has joined #openstack-nova | 08:55 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add API schema for different_cell filter https://review.openstack.org/220893 | 08:55 |
| *** karimb has quit IRC | 08:56 | |
| *** karimb has joined #openstack-nova | 08:56 | |
| *** karimb has quit IRC | 08:56 | |
| *** salv-orlando has joined #openstack-nova | 08:56 | |
| *** karimb has joined #openstack-nova | 08:57 | |
| *** karimb has quit IRC | 08:57 | |
| *** karimb has joined #openstack-nova | 08:57 | |
| gmann | johnthetubaguy: this BP is completed (in l-3) but not marked - https://blueprints.launchpad.net/nova/+spec/add-vif-net-id-in-vif-list | 08:58 |
| johnthetubaguy | gmann: seems like it only just merged, so it was completed during the RC period I guess? | 09:00 |
| gmann | johnthetubaguy: on the last day of L3 (3rd sept) :) | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| gmann | I also forgot to check the LP | 09:01 |
| *** haomaiwang has joined #openstack-nova | 09:01 | |
| *** oomichi has quit IRC | 09:01 | |
| andreykurilin | johnthetubaguy: hi! sorry, I was offline in IRC at night. About the use of client vs v2.client : official novaclient documentation says taht users should use novaclient.client module, alse, documentation for novaclient.v2.client says the same:) | 09:02 |
| johnthetubaguy | gmann: I will just pop in in RC1 thats easier I think, does that look better now | 09:02 |
| johnthetubaguy | andreykurilin: cool, just making sure we have something to point those folks to | 09:02 |
| *** VikasC_ has joined #openstack-nova | 09:02 | |
| johnthetubaguy | andreykurilin: did you add that comment in the bug already? | 09:03 |
| gmann | johnthetubaguy: yea. Thanks | 09:03 |
| *** markvoelker has joined #openstack-nova | 09:04 | |
| andreykurilin | johnthetubaguy: yes, I added it. Can I move this bug to "Invalid" for novaclient? | 09:04 |
| *** e0ne has quit IRC | 09:04 | |
| *** e0ne has joined #openstack-nova | 09:07 | |
| *** ankit_ag has joined #openstack-nova | 09:07 | |
| *** markvoelker has quit IRC | 09:08 | |
| *** moshele has quit IRC | 09:15 | |
| *** Marga_ has joined #openstack-nova | 09:16 | |
| *** ociuhandu has quit IRC | 09:16 | |
| *** Kennan_Vacation2 has quit IRC | 09:17 | |
| *** asettle has quit IRC | 09:18 | |
| *** Daisy has quit IRC | 09:18 | |
| johnthetubaguy | andreykurilin: yes, feel free | 09:19 |
| andreykurilin | johnthetubaguy: ok:) done | 09:19 |
| johnthetubaguy | andreykurilin: are we 100% sure we default to v2.0 version? | 09:19 |
| johnthetubaguy | bauzas: I am not sure about dropping this AZ cache: https://review.openstack.org/#/c/221384/2 | 09:19 |
| johnthetubaguy | bauzas: I am thinking about list instances, will that not suck now? | 09:19 |
| bauzas | johnthetubaguy: on a call | 09:19 |
| johnthetubaguy | bauzas: OK, catch you later on | 09:20 |
| openstackgerrit | Yingxin proposed openstack/nova: Fix MetricWeigher to use MonitorMetricList https://review.openstack.org/221620 | 09:20 |
| andreykurilin | johnthetubaguy: novaclient's documentation recommends to use novaclient.client.Client method. It has first argument - version, which doesn't have default value, so all existing scripts, which use this entry point, specified "2" as a version and novaclient uses "2.0" and they continue work as expected. | 09:21 |
| johnthetubaguy | andreykurilin: ah, I see | 09:22 |
| johnthetubaguy | andreykurilin: thanks for digging into that for me | 09:22 |
| andreykurilin | johnthetubaguy: you're welcome:) today I'll post a change with updating novaclient's docs with note that nova-developers can change novaclient.v2.Client interface and we don't recommend to use it. Also, I want to add warning message, if novaclient.v2.Client is initialized directly. | 09:24 |
| johnthetubaguy | andreykurilin: sounds like a good plan, awesome | 09:25 |
| *** Kennan_Vacation has joined #openstack-nova | 09:25 | |
| johnthetubaguy | andreykurilin: lets be sure we get that into the liberty release, we may need to backport it to the stable branch, if that gets created soon | 09:25 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221663 | 09:28 |
| andreykurilin | johnthetubaguy: I'll try to post a patches to novaclient and to know affected projects(manila and horizon) asap | 09:30 |
| *** venkat_p has quit IRC | 09:35 | |
| *** venkat_p has joined #openstack-nova | 09:37 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion rule when adding attr to request https://review.openstack.org/221642 | 09:40 |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add API schema for different_cell filter https://review.openstack.org/220893 | 09:40 |
| alex_xu | andreykurilin: the novaclient's documentation only describe use novaclient.client.Client. But it didn't mention anyting about novaclient.v2.client. I prefer to get more opinion from other people | 09:40 |
| alex_xu | before we close the bug | 09:41 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Call unprovison for nodes in DEPLOYING state https://review.openstack.org/209457 | 09:41 |
| andreykurilin | alex_xu: "But it didn't mention anyting about novaclient.v2.client" not exactly. http://docs.openstack.org/developer/python-novaclient/ref/v2/client.html | 09:41 |
| andreykurilin | we should update this doc | 09:41 |
| *** ijw_ has joined #openstack-nova | 09:41 | |
| *** coolsvap|brb is now known as coolsvap | 09:42 | |
| wanghao | johnthetubaguy: hi, john. here you are:) We have updated this patch("Add nova-manage command for cleaning attachment") and tested it pass, could you help to have a look? https://review.openstack.org/#/c/184537/ | 09:43 |
| alex_xu | andreykurilin: yea, that looks like wrong | 09:44 |
| * alex_xu go home now. back after few hours | 09:45 | |
| andreykurilin | alex_xu: but "python-novaclient as a lib" page recommends to use novaclient.client.Client, so we can ignore v2.client doc while talking about horizon bug | 09:45 |
| *** ijw_ has quit IRC | 09:46 | |
| alex_xu | andreykurilin: do you have link? | 09:46 |
| andreykurilin | alex_xu: sure, one moment | 09:47 |
| *** pixelbeat has joined #openstack-nova | 09:47 | |
| andreykurilin | alex_xu: http://docs.openstack.org/developer/python-novaclient/api.html | 09:47 |
| *** karimb has quit IRC | 09:47 | |
| alex_xu | andreykurilin: thanks | 09:48 |
| *** ociuhandu has joined #openstack-nova | 09:48 | |
| andreykurilin | alex_xu: I'll update docs today to contain more info | 09:49 |
| alex_xu | andreykurilin: yea, good for we have page talk about the right thing | 09:49 |
| alex_xu | andreykurilin: thanks a lot for working on this. also hope sdague and melwitt take a look at this when they wake up | 09:50 |
| *** f13o has joined #openstack-nova | 09:50 | |
| andreykurilin | alex_xu: you're welcome:) | 09:51 |
| alex_xu | andreykurilin: :) | 09:52 |
| bauzas | johnthetubaguy: I'm back | 09:53 |
| bauzas | RH meetings are a little bit longer than RAX ones :p | 09:54 |
| bauzas | johnthetubaguy: so, about https://review.openstack.org/#/c/221384/ | 09:54 |
| bauzas | johnthetubaguy: the cache is only storing the host AZ info | 09:55 |
| bauzas | johnthetubaguy: so I don't think it's beneficial from an instance list standpoint | 09:56 |
| bauzas | unless I misunderstood | 09:56 |
| *** otter768 has joined #openstack-nova | 09:56 | |
| *** karimb has joined #openstack-nova | 09:57 | |
| *** Murali has quit IRC | 09:58 | |
| *** ociuhandu_ has joined #openstack-nova | 09:59 | |
| *** venkat_p has joined #openstack-nova | 09:59 | |
| *** Sree has quit IRC | 09:59 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** otter768 has quit IRC | 10:01 | |
| bauzas | johnthetubaguy: I mean, from an API PoV, it's called by https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extended_availability_zone.py#L30 which is a separate API resource (os-extended-availability-zone) | 10:01 |
| *** tojuvone has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-nova | 10:02 | |
| *** dims__ has joined #openstack-nova | 10:02 | |
| *** ociuhandu has quit IRC | 10:02 | |
| *** ociuhandu_ is now known as ociuhandu | 10:02 | |
| *** f13o has quit IRC | 10:02 | |
| johnthetubaguy | bauzas: ah, OK, so its only on instance details we show the AZ? | 10:08 |
| bauzas | johnthetubaguy: that's what I'm doublechecking | 10:08 |
| *** alex_klimov has quit IRC | 10:10 | |
| bauzas | johnthetubaguy: well , the InstanceMetadata object is also using that helper for knowing the instance AZ | 10:10 |
| *** ishant has quit IRC | 10:11 | |
| johnthetubaguy | bauzas: but we generally read from the host right, if the host is present? | 10:11 |
| *** zhenguo has quit IRC | 10:11 | |
| johnthetubaguy | bauzas: seems like its the detail list that would be impacted: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extended_availability_zone.py#L51 | 10:11 |
| bauzas | johnthetubaguy: correct | 10:11 |
| johnthetubaguy | bauzas: thats a really expensive call, thats now even more expensive I guess | 10:12 |
| bauzas | johnthetubaguy: the original motivation for removing that is https://bugs.launchpad.net/nova/+bug/1390033/comments/5 | 10:12 |
| openstack | Launchpad bug 1390033 in OpenStack Compute (nova) "Inconsistent info of availability zone (az) if the default az is replaced" [Low,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 10:12 |
| johnthetubaguy | bauzas: I just worry about removing an optimisation that was added in 2013 or something like that | 10:12 |
| johnthetubaguy | bauzas: agreed there are bugs in the thing | 10:12 |
| bauzas | johnthetubaguy: yeah, hence me discussing with jaypipes and sdague on that - we thought it was nice to remove that, but we should maybe identify how expensive the removal would be | 10:13 |
| *** ishant has joined #openstack-nova | 10:13 | |
| bauzas | meh, lunch time / | 10:13 |
| *** mdbooth has quit IRC | 10:13 | |
| *** IanGovett has joined #openstack-nova | 10:13 | |
| johnthetubaguy | bauzas: it would be nice to know, roughly at least, like 50 instances detail list, 50 hosts, how bad is the impact. | 10:14 |
| *** mdbooth has joined #openstack-nova | 10:14 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 10:14 |
| *** gcb has joined #openstack-nova | 10:15 | |
| bauzas | johnthetubaguy: we can probably fake that in a test like you did for the CachingScheduler, I need to consider that | 10:15 |
| sdague | johnthetubaguy: yeh, during freeze is probably the least best time to remove it as well, but I do think we need to not assume that all these cache layers that go back forever still apply | 10:15 |
| johnthetubaguy | sdague: yeah, its totally worth a revisit | 10:16 |
| bauzas | sdague: agreed on waiting Mitaka for that | 10:16 |
| bauzas | that's pretty sensitive to merge that by RC1 | 10:16 |
| bauzas | unless we are sure of the performance impact | 10:17 |
| *** smatzek_ has joined #openstack-nova | 10:17 | |
| johnthetubaguy | bauzas: yeah, so I put a procedural -2 on there, if we work out its fine early next week, I can probably be talked around, but probably better to focus elsewhere | 10:17 |
| johnthetubaguy | bauzas: honestly, I would look at the functional db tests, and see if you can run the API code in that context, so it uses a real DB (ideally mysql instead of sql lite) | 10:18 |
| *** takedakn has joined #openstack-nova | 10:20 | |
| openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 10:20 |
| *** Murali has joined #openstack-nova | 10:24 | |
| *** logan2 has quit IRC | 10:24 | |
| *** ishant has quit IRC | 10:27 | |
| *** gcb has quit IRC | 10:28 | |
| *** logan2 has joined #openstack-nova | 10:28 | |
| *** gcb has joined #openstack-nova | 10:33 | |
| *** moshele has joined #openstack-nova | 10:34 | |
| *** chhavi has joined #openstack-nova | 10:36 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova: DO NOT MERGE - Triggering experimental pipeline https://review.openstack.org/220229 | 10:42 |
| *** ijw_ has joined #openstack-nova | 10:42 | |
| *** gcb has quit IRC | 10:43 | |
| *** gcb has joined #openstack-nova | 10:44 | |
| *** EinstCrazy has quit IRC | 10:45 | |
| *** irenab has quit IRC | 10:46 | |
| *** mpaolino has quit IRC | 10:47 | |
| * johnthetubaguy goes for some food | 10:47 | |
| *** ijw_ has quit IRC | 10:47 | |
| *** irenab has joined #openstack-nova | 10:48 | |
| *** ZZelle has quit IRC | 10:49 | |
| *** ZZelle has joined #openstack-nova | 10:49 | |
| *** beagles_ has quit IRC | 10:50 | |
| *** kmartin__ has quit IRC | 10:52 | |
| *** bradjones has quit IRC | 10:55 | |
| *** kse has quit IRC | 10:57 | |
| *** asselin_ has quit IRC | 10:59 | |
| *** sayali has quit IRC | 11:00 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-nova | 11:01 | |
| *** mwagner_lap has quit IRC | 11:02 | |
| *** sayali has joined #openstack-nova | 11:03 | |
| *** markvoelker has joined #openstack-nova | 11:04 | |
| *** irenab has quit IRC | 11:06 | |
| *** shyu has quit IRC | 11:06 | |
| *** aix has quit IRC | 11:06 | |
| * alex_xu back to work | 11:07 | |
| *** alex_klimov has joined #openstack-nova | 11:07 | |
| mhorban | johnthetubaguy: Hello and how are you? | 11:09 |
| *** EinstCrazy has joined #openstack-nova | 11:09 | |
| *** markvoelker has quit IRC | 11:09 | |
| mhorban | johnthetubaguy: Could you please merge it https://review.openstack.org/#/c/209957/ :) | 11:10 |
| *** irenab has joined #openstack-nova | 11:12 | |
| *** e0ne has quit IRC | 11:16 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 11:17 |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: use guest as parameter for get serial ports https://review.openstack.org/220519 | 11:18 |
| andreykurilin | johnthetubaguy, alex_xu, sdague: https://review.openstack.org/221706 | 11:19 |
| alex_xu | andreykurilin: thanks | 11:20 |
| *** y_sawai has joined #openstack-nova | 11:21 | |
| *** y_sawai_ has joined #openstack-nova | 11:23 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 11:23 |
| openstackgerrit | Yingxin proposed openstack/nova: Fix MetricWeigher to use MonitorMetricList https://review.openstack.org/221620 | 11:23 |
| *** irenab has quit IRC | 11:24 | |
| *** y_sawai has quit IRC | 11:25 | |
| *** irenab has joined #openstack-nova | 11:25 | |
| *** moshele has quit IRC | 11:30 | |
| bauzas | johnthetubaguy: ack | 11:31 |
| *** thorst has joined #openstack-nova | 11:32 | |
| *** y_sawai_ has quit IRC | 11:33 | |
| *** y_sawai has joined #openstack-nova | 11:33 | |
| *** matrohon has quit IRC | 11:35 | |
| *** ildikov has quit IRC | 11:35 | |
| *** irenab has quit IRC | 11:35 | |
| openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 11:37 |
| *** logan2 has quit IRC | 11:38 | |
| *** moshele has joined #openstack-nova | 11:40 | |
| *** ijw_ has joined #openstack-nova | 11:40 | |
| *** logan2 has joined #openstack-nova | 11:40 | |
| *** moshele has quit IRC | 11:41 | |
| *** lucasagomes is now known as lucas-hungry | 11:42 | |
| bauzas | johnthetubaguy: I actually wonder whether it's possible to mock 50 hosts for the functional tests, do you know if it's possible ? | 11:44 |
| *** dave-mccowan has joined #openstack-nova | 11:44 | |
| bauzas | johnthetubaguy: by looking at some tests, it sounds really easy to add a performance check for the servers list, but I need to mock 50 hosts and 50 instances | 11:44 |
| *** ijw_ has quit IRC | 11:45 | |
| bauzas | johnthetubaguy: nevermind, found it, that's not possible yet | 11:46 |
| *** moshele has joined #openstack-nova | 11:50 | |
| *** logan2 has quit IRC | 11:50 | |
| *** EinstCrazy has quit IRC | 11:51 | |
| *** VikasC_ has quit IRC | 11:52 | |
| openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 11:52 |
| *** logan2 has joined #openstack-nova | 11:54 | |
| *** otter768 has joined #openstack-nova | 11:57 | |
| johnthetubaguy | bauzas: bummer | 11:58 |
| bauzas | johnthetubaguy: I'm about to amend https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py | 11:59 |
| openstackgerrit | Jamie Lennox proposed openstack/nova: Put a lock around fetching a token https://review.openstack.org/221717 | 11:59 |
| *** y_sawai has quit IRC | 12:00 | |
| bauzas | johnthetubaguy: I can create 50 instances easily, but I wonder how to make 50 n-cpus | 12:00 |
| bauzas | johnthetubaguy: but I'm working on it | 12:00 |
| bauzas | johnthetubaguy: yeah, sounds doable | 12:00 |
| *** e0ne has joined #openstack-nova | 12:00 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwa_ has joined #openstack-nova | 12:01 | |
| *** otter768 has quit IRC | 12:01 | |
| openstackgerrit | Jamie Lennox proposed openstack/nova: Put a lock around fetching a token https://review.openstack.org/221717 | 12:01 |
| johnthetubaguy | bauzas: sweet | 12:01 |
| *** lyanchih has quit IRC | 12:02 | |
| *** y_sawai has joined #openstack-nova | 12:02 | |
| *** markvoelker has joined #openstack-nova | 12:02 | |
| *** venkat_p has quit IRC | 12:03 | |
| *** aysyd has joined #openstack-nova | 12:03 | |
| *** y_sawai_ has joined #openstack-nova | 12:04 | |
| *** rfolco has joined #openstack-nova | 12:06 | |
| *** y_sawai has quit IRC | 12:07 | |
| *** mpaolino has joined #openstack-nova | 12:10 | |
| sdague | jamielennox: why isn't that being addressed in upstream? I really don't like the idea of wedging a work around in on nova | 12:12 |
| jamielennox | sdague: yea, i'm looking to move it into keystoneclient, i was talking to dims__ about https://review.openstack.org/#/c/220767/ and was thinking this was better | 12:14 |
| *** krtaylor has joined #openstack-nova | 12:14 | |
| dims__ | sdague: i need something for kilo, yes +1 to address upstream too | 12:14 |
| sdague | jamielennox: so the other thing I guess I don't understand at all is why Nova is managing globals there. It feels like if there should be a cache for tokens it should live on the keystone side of the interface | 12:15 |
| dims__ | jamielennox: reviewing the LockingAuthShim, looks good so far | 12:15 |
| *** e0ne has quit IRC | 12:15 | |
| dims__ | tdurakov: are you around? https://review.openstack.org/#/c/221717 | 12:15 |
| sdague | dims__: so this was all tripped over because you are running nova api under apache? | 12:16 |
| sdague | or was there a different exposure for why you want it on kilo | 12:16 |
| dims__ | sdague: no, the token times out and things start to fail | 12:16 |
| jamielennox | sdague: what do you mean? there's the user token which isn't a problem, but there is admin credentials in nova and all the workers should share the token | 12:17 |
| *** logan2 has quit IRC | 12:17 | |
| sdague | jamielennox: I'd expect that token caching to be behind a library, not something nova had to actively have code in tree for | 12:17 |
| dims__ | sdague: from the auth plugin we create a temporary token_endpoint.Token which does not handle 401 | 12:17 |
| *** matrohon has joined #openstack-nova | 12:19 | |
| dims__ | sdague: tdurakov and i were looking at this https://review.openstack.org/#/c/220207/ which i did not like, then i came up with https://review.openstack.org/#/c/220767/ which was a bit better but not ideal, i like jamielennox's review better than either one. jamielennox's review is here - https://review.openstack.org/#/c/221717 | 12:20 |
| jamielennox | we've got most of the way with creating the plugin factory methods from any auth, and if you're willing to have one token per thread it's fairly easy but i'm not sure what else we would provide for token caching | 12:20 |
| *** logan2 has joined #openstack-nova | 12:20 | |
| jamielennox | ideally here we just wouldn't have nova admin auth | 12:20 |
| tdurakov | dims__ hi there | 12:21 |
| *** deepakcs has quit IRC | 12:21 | |
| dims__ | tdurakov: see jamielennox's review please, if that works, that would be better than our previous attempts | 12:22 |
| *** takedakn has quit IRC | 12:22 | |
| tdurakov | dims__, ok | 12:22 |
| dims__ | jamielennox: thanks much!! | 12:22 |
| *** raildo-afk is now known as raildo | 12:23 | |
| *** deepthi has quit IRC | 12:23 | |
| sdague | so why aren't we using oslo locking methods and instead jumping back to native threading, we have a whole locking context manager in oslo for stuff like this | 12:23 |
| dims__ | sdague: if the idea works, we can switch the locking methods for sure. we are still debating approaches | 12:24 |
| sdague | I also want a critical bug against keystone client before we let in any work around like this | 12:24 |
| *** marzif has quit IRC | 12:25 | |
| jamielennox | sdague: i don't know what oslo locking provides that a regular thread lock doesn't | 12:25 |
| *** marzif has joined #openstack-nova | 12:25 | |
| sdague | jamielennox: a consistent interface | 12:25 |
| jamielennox | we don't need to do cross process locks | 12:25 |
| sdague | the whole point is that's our locking interface | 12:25 |
| jamielennox | ok | 12:25 |
| jamielennox | i don't mind | 12:26 |
| dims__ | tdurakov: one main thing i had problem with was...since master uses one single global token, any patch should keep that and not switch to per thread admin token. | 12:26 |
| sdague | because if we have different random locking interfaces throughout the code the code becomes a lot more confusing | 12:26 |
| *** amrith is now known as _amrith_ | 12:26 | |
| dims__ | sdague: i am with you on using what's usually used in other nova files | 12:27 |
| *** coolsvap has quit IRC | 12:27 | |
| tdurakov | dims__, need to check patch | 12:27 |
| dims__ | tdurakov: yes, please | 12:27 |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Detach and attach boot volumes https://review.openstack.org/221732 | 12:28 |
| jamielennox | sdague: also for keystoneauth i added a lock to all the existing plugins so it would become a non-issue, but that won't be until mid next cycle | 12:28 |
| sdague | jamielennox: that's not backportable? | 12:28 |
| jamielennox | sdague: probably, it's like 10 lines | 12:29 |
| sdague | because it's really unpalatable to put in work arounds like this in all the consumers | 12:29 |
| sdague | it would be much better to backport a fix like that to stable lib release | 12:29 |
| *** armax has quit IRC | 12:29 | |
| *** e0ne has joined #openstack-nova | 12:30 | |
| sdague | right, that's my concern, it feels like this is a small patch in a keystone lib, or it's a bunch of patches in a bunch of projects, which might land in different states, then we have to back them all out later. | 12:30 |
| *** coolsvap has joined #openstack-nova | 12:30 | |
| *** edmondsw has joined #openstack-nova | 12:33 | |
| jamielennox | ok, bug 1493835 | 12:34 |
| openstack | bug 1493835 in python-keystoneclient "Global Plugins across Threads" [Undecided,New] https://launchpad.net/bugs/1493835 | 12:34 |
| *** tpeoples has joined #openstack-nova | 12:35 | |
| *** mwagner_lap has joined #openstack-nova | 12:36 | |
| *** venkat_p has joined #openstack-nova | 12:36 | |
| *** shuquan has joined #openstack-nova | 12:36 | |
| *** changbl has joined #openstack-nova | 12:37 | |
| *** amotoki has joined #openstack-nova | 12:37 | |
| *** baoli has joined #openstack-nova | 12:38 | |
| jamielennox | dims__: so i think if we merge https://review.openstack.org/#/c/221738/ we can just do _AUTH_PLUGIN = load_auth_plugin() and assume the plugin controls the lock process | 12:41 |
| *** logan2 has quit IRC | 12:41 | |
| *** logan2 has joined #openstack-nova | 12:42 | |
| *** baoli has quit IRC | 12:42 | |
| jamielennox | but we would need to get that merged and deps updated | 12:42 |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221739 | 12:43 |
| *** baoli has joined #openstack-nova | 12:43 | |
| jamielennox | dims__: on the other hand if you don't have the lock the worst that can happen is that a couple of threads all request there own token and overwrite the same place | 12:43 |
| jamielennox | so you have extra auth requests however you will end up with a useful token | 12:44 |
| *** lucas-hungry is now known as lucasagomes | 12:45 | |
| *** eharney has joined #openstack-nova | 12:46 | |
| dims__ | jamielennox: works for me! | 12:47 |
| *** y_sawai_ has quit IRC | 12:49 | |
| *** y_sawai has joined #openstack-nova | 12:50 | |
| *** haomaiwa_ has quit IRC | 12:50 | |
| *** aix has joined #openstack-nova | 12:51 | |
| *** pixelbeat has quit IRC | 12:51 | |
| *** pixelbeat has joined #openstack-nova | 12:51 | |
| *** VikasC has quit IRC | 12:51 | |
| *** nelsnelson has joined #openstack-nova | 12:52 | |
| *** dims__ is now known as dims | 12:52 | |
| *** Sree has joined #openstack-nova | 12:56 | |
| *** ctrath has joined #openstack-nova | 12:57 | |
| *** shuquan has quit IRC | 12:58 | |
| *** mdrabe has joined #openstack-nova | 12:59 | |
| *** zhenguo has joined #openstack-nova | 12:59 | |
| *** Sree has quit IRC | 13:00 | |
| *** lucasagomes has quit IRC | 13:03 | |
| *** ctrath has quit IRC | 13:04 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 13:04 |
| *** Sree has joined #openstack-nova | 13:04 | |
| *** rlrossit has joined #openstack-nova | 13:05 | |
| *** dustins has joined #openstack-nova | 13:07 | |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: Detach and attach boot volumes https://review.openstack.org/221732 | 13:08 |
| *** armax has joined #openstack-nova | 13:10 | |
| *** Jeffrey4l has quit IRC | 13:10 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 13:10 |
| *** irenab has joined #openstack-nova | 13:13 | |
| *** jecarey has joined #openstack-nova | 13:13 | |
| *** lucasagomes has joined #openstack-nova | 13:15 | |
| *** marcusvrn_ has joined #openstack-nova | 13:16 | |
| *** raildo is now known as raildo-afk | 13:19 | |
| *** moon_ has joined #openstack-nova | 13:19 | |
| openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 13:20 |
| *** zzzeek has joined #openstack-nova | 13:21 | |
| *** baoli has quit IRC | 13:22 | |
| *** keekz_ is now known as keekz | 13:23 | |
| *** raildo-afk is now known as raildo | 13:26 | |
| *** lyanchih has joined #openstack-nova | 13:27 | |
| *** haomaiwang has joined #openstack-nova | 13:28 | |
| *** mriedem_away is now known as mriedem | 13:29 | |
| *** vladikr has joined #openstack-nova | 13:31 | |
| andreykurilin | johnthetubaguy: good news, fix for horizon is approved( https://review.openstack.org/#/c/221711/ ), so we need wait until gates are finished and issue with key-pairs in horizon should gone. | 13:33 |
| johnthetubaguy | andreykurilin: awesome, thanks for the update | 13:33 |
| *** tongli has joined #openstack-nova | 13:33 | |
| alex_xu | andreykurilin: cool! | 13:34 |
| *** smatzek_ has quit IRC | 13:34 | |
| *** chhavi has quit IRC | 13:37 | |
| andreykurilin | johnthetubaguy, alex_xu: Also, manila and cinder guys are working on correct usage of novaclient. Neutron and openstackclient can be affected too. | 13:39 |
| tdurakov | johnthetubaguy, hi, updated ml thread with list of failing tests for multinode ci-job | 13:39 |
| *** rook has joined #openstack-nova | 13:41 | |
| johnthetubaguy | andreykurilin: I wondering if we should rename those to _v2 or something like that? to show its private? | 13:42 |
| *** ctrath has joined #openstack-nova | 13:43 | |
| johnthetubaguy | tdurakov: OK, do you mean the tests that sometimes fail in the gate, or something else? | 13:43 |
| tdurakov | johnthetubaguy, yep, tests that fails from time to time and amount of fails in week period | 13:44 |
| andreykurilin | johnthetubaguy: unfortunately, we can't hide _v2 fully. For example, horizon uses resources from v2 (i.e ServerResource cls and etc). Currently, I added additional var to v2.Client to print warning message - https://review.openstack.org/#/c/221706/2/novaclient/v2/client.py . It can help a bit | 13:44 |
| johnthetubaguy | tdurakov: cool, thats a good place to start | 13:45 |
| garyk | sdague: is there any chance that you can please look at https://review.openstack.org/#/c/221146/ (this had a +1 from kyle and aaron). we need this to be able to unblock the external neutron CI's | 13:45 |
| johnthetubaguy | andreykurilin: on dear, I see | 13:45 |
| johnthetubaguy | andreykurilin: yeah, the message seems like a good idea | 13:45 |
| *** ankit_ag has quit IRC | 13:46 | |
| *** baoli has joined #openstack-nova | 13:46 | |
| *** apuimedo has quit IRC | 13:46 | |
| *** abhishekk has quit IRC | 13:47 | |
| *** romainh has left #openstack-nova | 13:47 | |
| *** sudipto has joined #openstack-nova | 13:47 | |
| dansmith | johnthetubaguy: you were +2 on this until I asked for more test coverage: https://review.openstack.org/#/c/209457/3 | 13:50 |
| *** r-daneel has joined #openstack-nova | 13:51 | |
| johnthetubaguy | dansmith: ah, cool, I will take a peak | 13:51 |
| dansmith | johnthetubaguy: well, your mountain-climbing efforts aside, you might also want to take a peek | 13:51 |
| johnthetubaguy | :) | 13:52 |
| * johnthetubaguy puts on his boots | 13:52 | |
| *** VW_ has joined #openstack-nova | 13:53 | |
| *** y_sawai has quit IRC | 13:54 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 13:54 |
| dansmith | johnthetubaguy: whoa, hans has already proposed the conductor bump | 13:55 |
| lxsli | anyone with 2mins who understands CastAsCall please? | 13:56 |
| johnthetubaguy | dansmith: sorry, I mean to point you at that one, looks kinda cool how much we get to drop soon | 13:56 |
| dansmith | yeah | 13:56 |
| johnthetubaguy | lxsli: do you mean Cast vs Call? | 13:56 |
| dansmith | johnthetubaguy: I'm a little concerned about deprecating object_backport already, so I need to go do some thinking on this | 13:56 |
| dansmith | johnthetubaguy: he means our test fixture | 13:56 |
| lxsli | johnthetubaguy: no - my tests have this line: self.useFixture(cast_as_call.CastAsCall(self.stubs)) | 13:56 |
| dansmith | for making casts behave like calls | 13:56 |
| dansmith | lxsli: what about it? | 13:56 |
| lxsli | johnthetubaguy: which is supposed to make ... exactly | 13:56 |
| lxsli | it's not working for me | 13:56 |
| johnthetubaguy | ah, gotcha | 13:56 |
| lxsli | I changed some tests from mox to mock, does that break it? | 13:57 |
| dansmith | lxsli: all it does it mock rpc.cast to be an rpc.call, AFAIK | 13:57 |
| dansmith | lxsli: shouldn't, no | 13:57 |
| *** READ10 has joined #openstack-nova | 13:57 | |
| lxsli | do I need to register compute_rpcapi with self.stubs.Set? | 13:57 |
| *** shoutm has quit IRC | 13:58 | |
| *** otter768 has joined #openstack-nova | 13:58 | |
| *** obedmr has joined #openstack-nova | 13:58 | |
| bauzas | johnthetubaguy: so... I have good news | 13:58 |
| dansmith | lxsli: I don't even know what that means | 13:58 |
| johnthetubaguy | dansmith: yeah, I was a bit uneasy about that one | 13:58 |
| johnthetubaguy | dansmith: but couldn't find a way it would be bad, when you follow the rules | 13:58 |
| johnthetubaguy | bauzas: is listening | 13:58 |
| *** y_sawai has joined #openstack-nova | 13:59 | |
| dansmith | johnthetubaguy: well, the deal is that we fall back to the old method in the library in certain cases | 13:59 |
| bauzas | johnthetubaguy: well, my git local repo seems to need some garbage collection :D | 13:59 |
| lxsli | dansmith: well, CastAsCall gets passed self.stubs, which implies that needs to be populated. The _BaseTestCase gives it the rpc.RequestContextSerializer though which might be enough | 13:59 |
| *** smatzek has joined #openstack-nova | 13:59 | |
| dansmith | johnthetubaguy: so it shouldn't happen, but it also feels wrong for that to fail with a there-is-no-function-in-this-class error | 13:59 |
| bauzas | johnthetubaguy: but I finally wrote a performance test for 50 instances scheduled to up 50 hosts | 13:59 |
| *** rods has left #openstack-nova | 13:59 | |
| johnthetubaguy | dansmith: oh... thats funky | 14:00 |
| *** ahilan has joined #openstack-nova | 14:00 | |
| johnthetubaguy | dansmith: I figured with the unit tests passing and it dropped form RPCAPI, all was well | 14:00 |
| *** Sree has quit IRC | 14:00 | |
| dansmith | johnthetubaguy: well, it's a highly synthetic environment, unit tests :) | 14:00 |
| johnthetubaguy | dansmith: agreed | 14:00 |
| *** cfriesen has joined #openstack-nova | 14:00 | |
| dansmith | johnthetubaguy: I think I'd be more comfortable with either just leaving it for safety, or putting something there that failed with a "ok, here's what happened..." message | 14:01 |
| *** haomaiwang has quit IRC | 14:01 | |
| *** Sree has joined #openstack-nova | 14:01 | |
| dansmith | lxsli: if you pass it the proper rpcapi object it should work, mock or mox aside | 14:01 |
| *** haomaiwang has joined #openstack-nova | 14:01 | |
| dansmith | lxsli: however, it would be good to convert that to use monkeypatch instead | 14:01 |
| johnthetubaguy | dansmith: yeah, safety first is very tempting, if a little more work | 14:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove cache from the AZ helper https://review.openstack.org/221384 | 14:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Consolidate code to get the correct availability zone of an instance https://review.openstack.org/149562 | 14:01 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a performance test for getting a detailed list of instances https://review.openstack.org/221779 | 14:01 |
| bauzas | johnthetubaguy: https://review.openstack.org/221779 FYI | 14:01 |
| *** _amrith_ is now known as amrith | 14:01 | |
| lxsli | dansmith: do you have an example please? | 14:01 |
| johnthetubaguy | bauzas: how bad did it look in the end? | 14:01 |
| *** Jeffrey4l has joined #openstack-nova | 14:02 | |
| bauzas | johnthetubaguy: not bad, I asked for less than 1.5sec, and it was nice too | 14:02 |
| dansmith | lxsli: look for uses of fixtures.MonkeyPatch in our tests | 14:02 |
| *** otter768 has quit IRC | 14:02 | |
| lxsli | dansmith: ok cheers | 14:02 |
| johnthetubaguy | bauzas: I was meaning the before and after numbers really? | 14:02 |
| bauzas | johnthetubaguy: my local venv is taking between 1.1 and 1.3 secs with the cache | 14:03 |
| *** dbite has joined #openstack-nova | 14:03 | |
| johnthetubaguy | is that sqllite? | 14:03 |
| bauzas | johnthetubaguy: I haven't checked for without the cache yet, but the assert is not failing | 14:03 |
| bauzas | johnthetubaguy: yep | 14:03 |
| *** dbite has quit IRC | 14:03 | |
| bauzas | johnthetubaguy: that's inheriting from TestCase | 14:04 |
| *** dbite has joined #openstack-nova | 14:04 | |
| *** Sree has quit IRC | 14:05 | |
| *** ijuwang has joined #openstack-nova | 14:05 | |
| *** browne has joined #openstack-nova | 14:05 | |
| johnthetubaguy | bauzas: yeah, we probably want a mysql test, ideally, make sure all its goodness does make the gap bigger | 14:05 |
| johnthetubaguy | bauzas: but good to get some ball park numbers | 14:06 |
| *** Daisy has joined #openstack-nova | 14:06 | |
| bauzas | johnthetubaguy: tbh, that test is taking 30sec on my local machine for the setup | 14:07 |
| *** salv-orlando has quit IRC | 14:07 | |
| bauzas | johnthetubaguy: so I haven't provided the mysql cleanup style-ish | 14:07 |
| bauzas | johnthetubaguy: which makes me wonder how we could have some performance metrics that could be out of functional tests | 14:08 |
| *** mmedvede has quit IRC | 14:09 | |
| *** Murali has quit IRC | 14:09 | |
| *** devanand1 is now known as devananda | 14:10 | |
| lxsli | dansmith: what's the advantage of fixtures.MonkeyPatch over @mock.patch.object? | 14:10 |
| ahilan | sudipto: hey, how do i get the review process completed for my patch ? | 14:10 |
| dansmith | lxsli: it's just the usage model | 14:10 |
| sudipto | ahilan, i think you need to wait now and propose it for mitaka. johnthetubaguy can probably give you a better insight though. | 14:11 |
| dansmith | lxsli: you can't really be a fixture and use the decorator syntax effectively, so monkeypatch lets a fixture like CastAsCall mock out a thing that can be unmocked later | 14:11 |
| *** dbite has quit IRC | 14:12 | |
| lxsli | dansmith: aha, you were proposing I convert CastAsCall to use MonkeyPatch rather than my test to use MonkeyPatch directly | 14:12 |
| dansmith | lxsli: yes | 14:12 |
| ahilan | sudipto: ok thanks | 14:12 |
| lxsli | dansmith: thanks | 14:12 |
| *** thangp has joined #openstack-nova | 14:13 | |
| *** whenry__ has joined #openstack-nova | 14:15 | |
| ahilan | johnthetubaguy: hi, can you please tell me what is the next step for https://review.openstack.org/#/c/214772/ ? | 14:15 |
| *** jaypipes has joined #openstack-nova | 14:16 | |
| mriedem | ahilan: is https://review.openstack.org/#/c/214772/ part of a larger series? seems like there is something missing there, i'm assuming that's for feature enablement and the other changes aren't up yet, or it's enabling something to work out of tree | 14:17 |
| *** gszasz has quit IRC | 14:20 | |
| *** kodokuu_ has joined #openstack-nova | 14:21 | |
| *** moshele has quit IRC | 14:21 | |
| *** moshele has joined #openstack-nova | 14:22 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 14:22 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate 'novaclient.client.get_client_class' https://review.openstack.org/221789 | 14:22 |
| ahilan | mriedem: its actually an improvement over the base change that enabled the nova metrics as objects | 14:22 |
| mriedem | improvement how? | 14:23 |
| mriedem | it's marginally cleaner | 14:23 |
| *** moshele has quit IRC | 14:23 | |
| *** moshele has joined #openstack-nova | 14:23 | |
| mriedem | but it's not a bug fix | 14:23 |
| ahilan | mriedem: everytime you add new metrics fields to object, you can update them in the plugin code instead of modifying the base.py | 14:24 |
| *** electrocucaracha has joined #openstack-nova | 14:25 | |
| *** moshele has quit IRC | 14:25 | |
| mriedem | ahilan: do you plan on having another change which builds on / uses this change? | 14:25 |
| *** burt has joined #openstack-nova | 14:25 | |
| mhorban | johnthetubaguy: Hello | 14:25 |
| ahilan | mriedem: since its a abstract method, the plugin code itself can handle the setting of the metric object fields instead of updating the base everytime | 14:26 |
| kodokuu_ | Hi, is no possible to add quota for root disk or ephemeral disk ? https://review.openstack.org/#/c/27181/ I see status Abandoned | 14:26 |
| mriedem | ahilan: is there a concept of required fields? how is the base going to validate the the plugins are setting new fields? | 14:26 |
| johnthetubaguy | mhorban: hi, just on a call with nikhil_k_ | 14:26 |
| ahilan | mriedem: yes i am planning on providing new metrics that require different type of fields that currently defined | 14:27 |
| mriedem | ahilan: then i think this change should wait until those patches are up and in this series | 14:27 |
| *** jordanP has joined #openstack-nova | 14:27 | |
| mriedem | and that sounds like a blueprint, which would wait for mitaka | 14:27 |
| ahilan | mriedem: ok. yea currently working on the bp :-) | 14:28 |
| mhorban | johnthetubaguy:sorry, i haven't known about your call, if you have time, please look at https://review.openstack.org/#/c/209957/ | 14:29 |
| jordanP | mriedem, could you help me increase awareness on https://review.openstack.org/#/c/192736/ (libvirt:on snapshot delete, use qemu-img to blockRebase if VM is stopped) It's been there for 3 month now, I don"t know what to do anymore. I think I have always updated the patch according to the reviews I got but now this patch seems stuck... Any help appreciated :) | 14:29 |
| mriedem | jordanP: i've been meaning to get back to it, i'll put it in the browser tab queue - there are a few in that boat | 14:30 |
| jordanP | mriedem, thanks a lot. I know you have lot on your plate | 14:31 |
| *** yamahata has joined #openstack-nova | 14:31 | |
| *** baoli has quit IRC | 14:32 | |
| openstackgerrit | Paul Carlton proposed openstack/nova: Mask the token used to allow access to vnc console https://review.openstack.org/220622 | 14:32 |
| *** baoli has joined #openstack-nova | 14:32 | |
| mriedem | hyperv ci people around? | 14:33 |
| mriedem | ociuhandu: are you hyperv ci? | 14:33 |
| ociuhandu | mriedem: I’m working on that, yes | 14:33 |
| mriedem | ociuhandu: ok, i noticed it was reporting success here https://review.openstack.org/#/c/214493/ but it's actually failing with some weird looking merge issues | 14:34 |
| mriedem | http://64.119.130.115/214493/11/Hyper-V_logs/hv-compute2/nova-compute.log.gz | 14:34 |
| *** baoli_ has joined #openstack-nova | 14:34 | |
| ociuhandu | mriedem: we have been investigating that, it’s a zuul bug from what we can tell, as the job is set to non-voting | 14:34 |
| mriedem | ociuhandu: also, we really shouldn't be reporting a +1 from hyper-v CI on patches when it's obviously failng | 14:34 |
| mriedem | Microsoft Hyper-V CIÂ Â +1 <- in that change | 14:35 |
| ociuhandu | mriedem: we’re now working on stabilizing nova ci, this is why we marked the job non-voting | 14:35 |
| johnthetubaguy | mhorban: its deep in the libvirt, so I am not a great person to approve stuff in there | 14:35 |
| mriedem | ociuhandu: was it made non-voting in the last 2 days? | 14:35 |
| *** yamahata has quit IRC | 14:35 | |
| ociuhandu | mriedem: zuul insists on sending a +1 :( | 14:35 |
| mriedem | oh fun | 14:35 |
| *** yamahata has joined #openstack-nova | 14:36 | |
| *** dbite has joined #openstack-nova | 14:36 | |
| mriedem | there is no way to change that to a -1? | 14:36 |
| mriedem | ociuhandu: actually, i just removed hyper-v ci from this group https://review.openstack.org/#/admin/groups/511,members | 14:36 |
| mriedem | so that should fix the misreporting on nova changes until it's fixed | 14:36 |
| mriedem | ping me or johnthetubaguy when it's fixed and we can add it back to that group | 14:36 |
| ociuhandu | mriedem: i think it’s related to the fact that a noon-voting job is seen by zuul code as succes anyway, and we can’t turn the voting off completely as same acount is used for neutron :( | 14:37 |
| *** y_sawai has quit IRC | 14:37 | |
| *** ujjain- has quit IRC | 14:37 | |
| *** ujjain- has joined #openstack-nova | 14:37 | |
| ociuhandu | mriedem: thank you, will surely do so, we expect to have it back stable by tomorrow, there are a few tempest test failures we investigate | 14:38 |
| *** baoli has quit IRC | 14:38 | |
| mhorban | johnthetubaguy: ok thanks | 14:38 |
| mriedem | ociuhandu: thanks. i also posted to the ML for awareness. | 14:39 |
| *** mmedvede has joined #openstack-nova | 14:39 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Handle race in allocate_for_instance https://review.openstack.org/221803 | 14:41 |
| ociuhandu | mriedem: once the CI is fixed we also want to take a look at the zuul code as this seems like a significant bug for any operator running more than a single CI on one account. | 14:41 |
| *** dbite has quit IRC | 14:41 | |
| mriedem | ociuhandu: that's probably something to bring up in the 3rd party CI meeting | 14:42 |
| mriedem | i know some teams use multiple accounts for different CI jobs | 14:43 |
| ociuhandu | mriedem: sure, will add it to the discussion | 14:43 |
| bauzas | johnthetubaguy: sdague: considering again the opportunity to remove the AZ cache vs. providing a bugfix, I think I'll provide the bugfix first and leave the AZ cache removal on the last patch of the series | 14:44 |
| *** y_sawai has joined #openstack-nova | 14:45 | |
| bauzas | johnthetubaguy: sdague: because while the former is highly debatable, fixing a bugfix by returning " when the host is not provided sounds a quickwin | 14:45 |
| *** emagana has joined #openstack-nova | 14:47 | |
| *** karimb has quit IRC | 14:47 | |
| *** edtubill has joined #openstack-nova | 14:49 | |
| *** maishsk has joined #openstack-nova | 14:49 | |
| maishsk | Hello almight nova people | 14:49 |
| maishsk | question about spawning a new instance. | 14:49 |
| maishsk | does nova verify that the md5sum of the image matches the md5 of that same image registered in glance - before booting the instance? | 14:50 |
| *** bradjones has joined #openstack-nova | 14:52 | |
| *** bradjones has quit IRC | 14:52 | |
| *** bradjones has joined #openstack-nova | 14:52 | |
| sdague | bauzas: yes, I feel like the bug fix is fine for now | 14:53 |
| *** obedmr has quit IRC | 14:54 | |
| sdague | and the cache removal should come in M | 14:54 |
| *** armax has quit IRC | 14:54 | |
| *** emagana has quit IRC | 14:54 | |
| *** kylek3h has joined #openstack-nova | 14:55 | |
| *** emagana has joined #openstack-nova | 14:55 | |
| *** thedodd has joined #openstack-nova | 14:56 | |
| *** kylek3h_ has joined #openstack-nova | 14:56 | |
| *** irenab has quit IRC | 14:57 | |
| *** obedmr has joined #openstack-nova | 14:57 | |
| *** irenab has joined #openstack-nova | 14:57 | |
| *** IanGovett has quit IRC | 14:58 | |
| *** VW__ has joined #openstack-nova | 14:58 | |
| *** ildikov has joined #openstack-nova | 14:59 | |
| *** kmartin has joined #openstack-nova | 14:59 | |
| *** maishsk has quit IRC | 15:00 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-nova | 15:01 | |
| *** kylek3h has quit IRC | 15:01 | |
| *** READ10 has quit IRC | 15:01 | |
| *** VW_ has quit IRC | 15:01 | |
| *** dave-mccowan has quit IRC | 15:02 | |
| *** jistr is now known as jistr|call | 15:02 | |
| *** tpeoples has quit IRC | 15:03 | |
| *** VW__ has quit IRC | 15:03 | |
| *** baoli_ has quit IRC | 15:03 | |
| *** baoli has joined #openstack-nova | 15:04 | |
| *** romainh has joined #openstack-nova | 15:06 | |
| *** VW_ has joined #openstack-nova | 15:06 | |
| *** VW_ has quit IRC | 15:06 | |
| *** sudipto has quit IRC | 15:06 | |
| *** maishsk has joined #openstack-nova | 15:06 | |
| *** garyk has quit IRC | 15:06 | |
| *** VW_ has joined #openstack-nova | 15:07 | |
| *** unicell has joined #openstack-nova | 15:08 | |
| andreykurilin | sdague: hi! Can you help me with functional tests in novaclient? I launches "cinder" via self.cli_clients.cinder(...), but subprocess fails to run command... | 15:08 |
| *** unicell1 has quit IRC | 15:09 | |
| *** kylek3h_ has quit IRC | 15:09 | |
| *** jwcroppe has quit IRC | 15:09 | |
| *** kylek3h has joined #openstack-nova | 15:10 | |
| *** jwcroppe has joined #openstack-nova | 15:10 | |
| *** marzif has quit IRC | 15:10 | |
| *** mdrabe has quit IRC | 15:10 | |
| *** kodokuu_ has quit IRC | 15:11 | |
| *** Piet has joined #openstack-nova | 15:11 | |
| *** electrocucaracha has quit IRC | 15:12 | |
| *** tpeoples has joined #openstack-nova | 15:12 | |
| *** erlon has joined #openstack-nova | 15:13 | |
| *** Marga_ has quit IRC | 15:13 | |
| *** jwcroppe has quit IRC | 15:14 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove cache from the AZ helper https://review.openstack.org/221384 | 15:15 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Invalidate AZ cache when the instance AZ information is different https://review.openstack.org/172906 | 15:15 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a performance test for getting a detailed list of instances https://review.openstack.org/221779 | 15:15 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Consolidate code to get the correct availability zone of an instance https://review.openstack.org/149562 | 15:15 |
| *** eharney has quit IRC | 15:16 | |
| *** dave-mccowan has joined #openstack-nova | 15:16 | |
| *** apuimedo has joined #openstack-nova | 15:17 | |
| johnthetubaguy | maishsk: I know the xenapi driver does that, unsure about libvirt, I assume it does, but its worth a double check | 15:20 |
| maishsk | johnthetubaguy: I just got answer on the mailing list http://lists.openstack.org/pipermail/openstack-dev/2015-September/073987.html | 15:21 |
| *** salv-orlando has joined #openstack-nova | 15:21 | |
| johnthetubaguy | maishsk: even better :) | 15:22 |
| maishsk | ;) | 15:22 |
| maishsk | Thanks | 15:22 |
| *** eharney has joined #openstack-nova | 15:22 | |
| *** baoli_ has joined #openstack-nova | 15:23 | |
| openstackgerrit | dane-fichter proposed openstack/nova: Nova support for image-signing https://review.openstack.org/189843 | 15:23 |
| *** gszasz has joined #openstack-nova | 15:25 | |
| *** baoli has quit IRC | 15:25 | |
| *** haomaiwang has quit IRC | 15:26 | |
| *** gszasz has quit IRC | 15:26 | |
| *** mdrabe has joined #openstack-nova | 15:26 | |
| *** gszasz has joined #openstack-nova | 15:27 | |
| *** hemnafk is now known as hemna | 15:28 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova: DO NOT MERGE - Triggering experimental pipeline https://review.openstack.org/220229 | 15:29 |
| *** baoli_ has quit IRC | 15:30 | |
| *** baoli has joined #openstack-nova | 15:30 | |
| *** haomaiwang has joined #openstack-nova | 15:30 | |
| *** armax has joined #openstack-nova | 15:33 | |
| *** IanGovett has joined #openstack-nova | 15:33 | |
| *** maishsk has quit IRC | 15:33 | |
| *** venkat_p has quit IRC | 15:33 | |
| *** teju has joined #openstack-nova | 15:37 | |
| *** maishsk has joined #openstack-nova | 15:37 | |
| *** xyang1 has joined #openstack-nova | 15:39 | |
| *** chhavi has joined #openstack-nova | 15:40 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Add support for microversion https://review.openstack.org/221848 | 15:40 |
| *** eharney has quit IRC | 15:40 | |
| *** salv-orl_ has joined #openstack-nova | 15:40 | |
| *** maishsk_ has joined #openstack-nova | 15:40 | |
| *** eharney has joined #openstack-nova | 15:41 | |
| *** electrocucaracha has joined #openstack-nova | 15:42 | |
| *** maishsk has quit IRC | 15:42 | |
| *** maishsk_ is now known as maishsk | 15:42 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 15:42 |
| *** __maurosr__ has joined #openstack-nova | 15:44 | |
| *** salv-orlando has quit IRC | 15:44 | |
| *** asselin_ has joined #openstack-nova | 15:44 | |
| *** marcusvrn_ has quit IRC | 15:45 | |
| *** shoutm has joined #openstack-nova | 15:46 | |
| *** teju has quit IRC | 15:46 | |
| *** claudiub has joined #openstack-nova | 15:46 | |
| *** IanGovett1 has joined #openstack-nova | 15:49 | |
| *** cristicalin has quit IRC | 15:49 | |
| *** kylek3h_ has joined #openstack-nova | 15:49 | |
| *** maurosr has quit IRC | 15:50 | |
| *** __maurosr__ is now known as maurosr | 15:50 | |
| *** tongli has quit IRC | 15:51 | |
| *** IanGovett2 has joined #openstack-nova | 15:51 | |
| *** IanGovett has quit IRC | 15:51 | |
| *** tongli has joined #openstack-nova | 15:51 | |
| *** maurosr has left #openstack-nova | 15:51 | |
| *** maurosr has joined #openstack-nova | 15:52 | |
| *** kylek3h has quit IRC | 15:53 | |
| *** IanGovett1 has quit IRC | 15:53 | |
| *** Sukhdev has joined #openstack-nova | 15:55 | |
| *** jistr|call is now known as jistr | 15:55 | |
| *** bswartz has quit IRC | 15:55 | |
| *** tongli has quit IRC | 15:55 | |
| *** bswartz has joined #openstack-nova | 15:56 | |
| *** salv-orl_ has quit IRC | 15:57 | |
| *** diogogmt has joined #openstack-nova | 15:57 | |
| *** salv-orlando has joined #openstack-nova | 15:58 | |
| *** med_ has quit IRC | 15:58 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Add support for microversion https://review.openstack.org/221848 | 15:58 |
| *** otter768 has joined #openstack-nova | 15:59 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-nova | 16:01 | |
| *** alexschm has quit IRC | 16:02 | |
| *** lpetrut has quit IRC | 16:02 | |
| *** otter768 has quit IRC | 16:03 | |
| *** maishsk has quit IRC | 16:04 | |
| *** baoli_ has joined #openstack-nova | 16:06 | |
| *** jlanoux has quit IRC | 16:07 | |
| *** unicell has quit IRC | 16:08 | |
| *** baoli has quit IRC | 16:08 | |
| *** IanGovett has joined #openstack-nova | 16:09 | |
| *** IanGovett2 has quit IRC | 16:09 | |
| *** matrohon has quit IRC | 16:09 | |
| *** dims has quit IRC | 16:10 | |
| *** salv-orl_ has joined #openstack-nova | 16:10 | |
| *** dims has joined #openstack-nova | 16:10 | |
| *** Daisy has quit IRC | 16:12 | |
| *** Daisy has joined #openstack-nova | 16:13 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 16:13 |
| *** irenab has quit IRC | 16:14 | |
| *** salv-orlando has quit IRC | 16:14 | |
| *** Marga_ has joined #openstack-nova | 16:15 | |
| *** IanGovett has quit IRC | 16:17 | |
| *** Daisy has quit IRC | 16:17 | |
| *** IanGovett has joined #openstack-nova | 16:17 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove cache from the AZ helper https://review.openstack.org/221384 | 16:19 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova: Add a performance test for getting a detailed list of instances https://review.openstack.org/221779 | 16:19 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Lightweight fetching of nodes https://review.openstack.org/221057 | 16:21 |
| *** nic has joined #openstack-nova | 16:21 | |
| *** garyk has joined #openstack-nova | 16:27 | |
| *** baoli_ has quit IRC | 16:28 | |
| *** baoli has joined #openstack-nova | 16:28 | |
| *** venkat_p has joined #openstack-nova | 16:29 | |
| *** ijw_ has joined #openstack-nova | 16:30 | |
| *** vilobhmm_11 has joined #openstack-nova | 16:30 | |
| *** VW_ has quit IRC | 16:31 | |
| *** VW_ has joined #openstack-nova | 16:31 | |
| *** vilobhmm_111 has joined #openstack-nova | 16:32 | |
| *** salv-orl_ has quit IRC | 16:33 | |
| johnthetubaguy | garyk: are you around to catch up about this change? https://review.openstack.org/#/c/163864/ | 16:34 |
| *** jordanP has quit IRC | 16:34 | |
| *** vilobhmm_11 has quit IRC | 16:35 | |
| garyk | johnthetubaguy: i need to head off to a meeting. can we chat about that tomorrow. basically the API was broken and I fixed accoringly. Not sure that anyone uses this though | 16:35 |
| *** VW_ has quit IRC | 16:36 | |
| johnthetubaguy | garyk: yeah, the big picture looks good, just worried about a few nits in there | 16:37 |
| johnthetubaguy | garyk: lets catch up tomorrow, no problems | 16:37 |
| cfriesen | Is the help text for the database "idle_timeout" parameter accurate? It says 'Timeout before idle SQL connections are reaped.', but it seems to be mapping against sqlalchemy's 'pool_recycle', which seems to mean something different. | 16:37 |
| *** VW_ has joined #openstack-nova | 16:37 | |
| garyk | if there are some nits then you can comment and i'll address them first thing in the morning. but i'll ping you in the morning and we can chat | 16:38 |
| *** apuimedo is now known as apuimedo|away | 16:40 | |
| *** jistr has quit IRC | 16:42 | |
| *** amotoki has quit IRC | 16:43 | |
| *** romainh has left #openstack-nova | 16:44 | |
| *** belmoreira has joined #openstack-nova | 16:46 | |
| *** Apoorva has joined #openstack-nova | 16:47 | |
| *** lsmola has quit IRC | 16:48 | |
| *** lyanchih has quit IRC | 16:49 | |
| *** jwcroppe has joined #openstack-nova | 16:49 | |
| *** unicell has joined #openstack-nova | 16:49 | |
| *** derekh has quit IRC | 16:49 | |
| *** tjones has joined #openstack-nova | 16:50 | |
| *** xgsa has quit IRC | 16:51 | |
| *** lyanchih has joined #openstack-nova | 16:53 | |
| *** achanda has joined #openstack-nova | 16:53 | |
| *** alex_klimov has quit IRC | 16:55 | |
| *** jistr has joined #openstack-nova | 16:55 | |
| *** marcusvrn_ has joined #openstack-nova | 16:57 | |
| *** tongli has joined #openstack-nova | 16:58 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** luapsil has joined #openstack-nova | 17:01 | |
| *** haomaiwang has joined #openstack-nova | 17:01 | |
| *** tjones has left #openstack-nova | 17:03 | |
| *** venkat_p has quit IRC | 17:03 | |
| *** xgsa has joined #openstack-nova | 17:03 | |
| *** zxyf has quit IRC | 17:04 | |
| *** luapsil has quit IRC | 17:04 | |
| *** zxyf has joined #openstack-nova | 17:04 | |
| *** cfarquhar has joined #openstack-nova | 17:08 | |
| *** cfarquhar has quit IRC | 17:08 | |
| *** cfarquhar has joined #openstack-nova | 17:08 | |
| *** e0ne has quit IRC | 17:08 | |
| *** zxyf has quit IRC | 17:08 | |
| *** zxyf has joined #openstack-nova | 17:08 | |
| *** maishsk has joined #openstack-nova | 17:09 | |
| *** burt has quit IRC | 17:10 | |
| *** alexpilotti_ is now known as alexpilotti | 17:12 | |
| *** zxyf has quit IRC | 17:15 | |
| *** yamahata has quit IRC | 17:16 | |
| *** maishsk has quit IRC | 17:16 | |
| openstackgerrit | Paul Carlton proposed openstack/nova: Mask the token used to allow access to vnc console https://review.openstack.org/220622 | 17:16 |
| openstackgerrit | bharaththiruveedula proposed openstack/nova-specs: Returning Compute Node IP address in hypervisor list https://review.openstack.org/215207 | 17:18 |
| *** zxyf has joined #openstack-nova | 17:18 | |
| *** salv-orlando has joined #openstack-nova | 17:19 | |
| *** salv-orl_ has joined #openstack-nova | 17:21 | |
| *** dannywilson has joined #openstack-nova | 17:22 | |
| *** zxyf has quit IRC | 17:23 | |
| *** yassine__ has quit IRC | 17:23 | |
| *** salv-orlando has quit IRC | 17:23 | |
| *** zxyf has joined #openstack-nova | 17:24 | |
| *** electrocucaracha has quit IRC | 17:25 | |
| *** kylek3h_ has quit IRC | 17:26 | |
| *** exploreshaifali has joined #openstack-nova | 17:26 | |
| *** kylek3h has joined #openstack-nova | 17:27 | |
| *** zxyf has quit IRC | 17:27 | |
| *** zxyf has joined #openstack-nova | 17:27 | |
| *** jistr has quit IRC | 17:28 | |
| *** burt has joined #openstack-nova | 17:28 | |
| *** haomaiwang has quit IRC | 17:28 | |
| bauzas | belmoreira: lalit not there ? | 17:29 |
| belmoreira | hi bauzas | 17:30 |
| *** kylek3h has quit IRC | 17:30 | |
| bauzas | belmoreira: so, re: https://review.openstack.org/#/c/213041 | 17:30 |
| *** Sukhdev has quit IRC | 17:30 | |
| bauzas | belmoreira: checkout http://logs.openstack.org/41/213041/17/check/gate-grenade-dsvm/8d6cfed/logs/new/screen-n-api.txt.gz?level=TRACE#_2015-09-01_09_57_57_974 | 17:31 |
| *** kylek3h has joined #openstack-nova | 17:31 | |
| bauzas | belmoreira: for the grenade job | 17:31 |
| bauzas | belmoreira: which is corresponding to http://logs.openstack.org/41/213041/17/check/gate-grenade-dsvm/8d6cfed/logs/grenade.sh.txt.gz#_2015-09-01_09_57_57_981 | 17:32 |
| *** zxyf has quit IRC | 17:32 | |
| *** devlaps has joined #openstack-nova | 17:32 | |
| *** zxyf has joined #openstack-nova | 17:33 | |
| *** lalit has joined #openstack-nova | 17:33 | |
| *** kmartin has quit IRC | 17:33 | |
| bauzas | belmoreira: so the backwards compat' is probably broken, I need to dig into the review | 17:33 |
| *** achanda has quit IRC | 17:34 | |
| *** jcoufal has quit IRC | 17:34 | |
| belmoreira | bauzas: thank you for having a look | 17:34 |
| belmoreira | I will point lalitd to it | 17:34 |
| *** ijw_ has quit IRC | 17:34 | |
| *** salv-orlando has joined #openstack-nova | 17:35 | |
| bauzas | lalit: belmoreira: well, the issue is pretty simple, you miss the connection string when updating the flavor | 17:36 |
| *** tjones has joined #openstack-nova | 17:36 | |
| *** zxyf has quit IRC | 17:36 | |
| bauzas | lalit: belmoreira: now, how to fix that is another story... | 17:36 |
| bauzas | s/updating the flavor/getting the flavors | 17:36 |
| *** zxyf has joined #openstack-nova | 17:36 | |
| lalit | bauzas: thanks for review.. but I am not getting where to put the connection string to resolve it | 17:38 |
| *** salv-orl_ has quit IRC | 17:38 | |
| *** achanda has joined #openstack-nova | 17:38 | |
| alaski | it looks like it's missing in the configuration | 17:38 |
| belmoreira | I just sent everything to lalit | 17:39 |
| *** zxyf has quit IRC | 17:39 | |
| alaski | the connection string should come from http://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n78 | 17:40 |
| *** chhavi has quit IRC | 17:40 | |
| *** zxyf has joined #openstack-nova | 17:40 | |
| alaski | that may not be getting set properly in grenade | 17:40 |
| *** tjones has left #openstack-nova | 17:42 | |
| lalit | alaski: do we have to include in the patch ? | 17:43 |
| *** rdopiera has quit IRC | 17:43 | |
| alaski | lalit: not in the patch. it would be in devstack I think | 17:43 |
| *** Jeffrey4l has quit IRC | 17:45 | |
| lalit | alaski: regarding functions outside to the Flavor object, I menstioned the problem of failing nova.tests.unit.objects.test_flavor.TestFlavorRemote | 17:46 |
| lalit | s/menstioned/mentioned | 17:46 |
| alaski | lalit: I would need to see the failure | 17:47 |
| alaski | we do the same thing in other objects and it's worked, so I'm not sure what the problem would be | 17:47 |
| *** nikeshm__ has joined #openstack-nova | 17:48 | |
| lalit | alaski: okay, I will resubmit the patch with changes you suggested. | 17:49 |
| lalit | so I will keep soft-delete as it is.. | 17:50 |
| alaski | lalit: for now, yes | 17:51 |
| *** mpaolino has quit IRC | 17:51 | |
| lalit | alaski: thanks | 17:51 |
| belmoreira | alaski, bauzas: thank you for looking on it | 17:52 |
| *** shoutm has quit IRC | 17:55 | |
| bauzas | lalit: belmoreira: sorry was afk | 17:55 |
| tpeoples | edleafe-: regarding your comment on https://review.openstack.org/#/c/220634... unfortunately the pools = objects.PciDevicePoolList.obj_from_primitive call returns a PciDevicePoolList itself, so doing a return objects.PciDevicePoolList(objects=pools) would fail there and would require an additional if check anyways. would you prefer that? | 17:55 |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Split out resize_image logic from create_image https://review.openstack.org/187857 | 17:55 |
| *** belmoreira has quit IRC | 17:56 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Split out resize_image logic from create_image https://review.openstack.org/187857 | 17:56 |
| lalit | bazuas: thanks for having look..gn | 17:56 |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images https://review.openstack.org/187395 | 17:57 |
| edleafe- | tpeoples: good point. You could change that to: if not pools: return objects.Pci... | 17:57 |
| tpeoples | edleafe-: yeah, that's what i have right now. i'll get it up for review. thanks | 17:57 |
| bauzas | lalit: so I think alaski made a very valid point, devstack has to be updated with that kind of details | 17:58 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances https://review.openstack.org/176925 | 17:58 |
| *** armax has quit IRC | 17:58 | |
| alaski | lalit: bauzas I'm trying to track that down now. I'm not sure why it's not set right now | 17:58 |
| *** VW__ has joined #openstack-nova | 17:58 | |
| *** rook has quit IRC | 17:58 | |
| *** agireud has joined #openstack-nova | 17:58 | |
| bauzas | alaski: I guess it's because of partial-ncpu and grenade special devstacks | 17:59 |
| bauzas | alaski: I guess the vanilla lib/nova devstack is providing that now ? | 17:59 |
| *** paul-carlton has quit IRC | 17:59 | |
| *** danpb has quit IRC | 17:59 | |
| alaski | bauzas: yes | 17:59 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 17:59 |
| *** otter768 has joined #openstack-nova | 17:59 | |
| alaski | and I don't fully understand what grenade does differently | 18:00 |
| bauzas | alaski: so that goes down to how grenoble is doing differently | 18:00 |
| bauzas | hah | 18:00 |
| bauzas | s/grenoble/grenade | 18:00 |
| lalit | bauzas: alaski but I am working with devstack it is working fine... | 18:00 |
| *** VW__ has quit IRC | 18:00 | |
| *** VW___ has joined #openstack-nova | 18:00 | |
| alaski | yeah, something with grenade | 18:01 |
| alaski | see http://logs.openstack.org/41/213041/17/check/gate-grenade-dsvm/8d6cfed/logs/etc/nova/nova.conf.txt.gz is the grenade failure | 18:01 |
| lalit | even I install fresh devstack and tested on that , that too working fine ... | 18:01 |
| alaski | http://logs.openstack.org/77/183977/3/check/gate-tempest-dsvm-cells/07aee0b/logs/etc/nova/nova.conf.txt.gz is a normal cells config | 18:01 |
| *** ZZelle_ has joined #openstack-nova | 18:01 | |
| bauzas | lalit: that's not devstack | 18:01 |
| alaski | notice the missing api_database section | 18:01 |
| bauzas | alaski: yup | 18:01 |
| bauzas | digging into infra details :) | 18:01 |
| lalit | okay.. | 18:01 |
| *** VW_ has quit IRC | 18:02 | |
| bauzas | lemme see the grenade job | 18:02 |
| bauzas | unless sdague is around ? :) | 18:02 |
| *** agireud has quit IRC | 18:02 | |
| lalit | alaski : just for information this change in grenade will required some spec or what ? | 18:03 |
| mtreinish | alaski: grenade runs nova master with the old config from kilo | 18:03 |
| bauzas | oh that | 18:04 |
| mtreinish | alaski: are you looking for this change: https://review.openstack.org/#/c/190399/ | 18:04 |
| *** otter768 has quit IRC | 18:04 | |
| bauzas | but the opts were added in kilo AFAICR | 18:04 |
| mtreinish | bauzas: sure but if the opts were never set to anything then they won't be in the config used to deploy the kilo cloud | 18:05 |
| alaski | mtreinish: something like that, but we just want a setting to be present | 18:05 |
| bauzas | mtreinish: I see... | 18:05 |
| *** penick has joined #openstack-nova | 18:06 | |
| alaski | lalit: I don't think grenade has specs. just some discussion on the right thing to do | 18:06 |
| *** agireud has joined #openstack-nova | 18:06 | |
| bauzas | mtreinish: so, by some way, the kilo version was having those opts, so I guess we should modify grenade to provide those, yet? | 18:06 |
| mtreinish | bauzas: kilo devstack | 18:06 |
| bauzas | snap | 18:06 |
| mtreinish | that's where the configs come from | 18:07 |
| bauzas | okay, I misunderstood | 18:07 |
| lalit | okay | 18:07 |
| mtreinish | bauzas: grenade used stable devstack to deploy a stable cloud | 18:07 |
| bauzas | alaski: any idea when the devstack change was merged ? | 18:07 |
| alaski | bauzas: git blaming now | 18:07 |
| mtreinish | and then it updates the code and restarts the services | 18:07 |
| bauzas | mtreinish: gotcha | 18:07 |
| *** agireud has quit IRC | 18:08 | |
| bauzas | all of that was just magic to me | 18:08 |
| mtreinish | alaski: fwiw, qa-specs covers grenade, although we don't get too many spec proposals for grenade | 18:08 |
| *** agireud has joined #openstack-nova | 18:08 | |
| alaski | mtreinish: ahh, cool | 18:08 |
| alaski | https://review.openstack.org/#/c/190289/ | 18:08 |
| bauzas | well, it's rather a bug than a feature ? :) | 18:08 |
| mtreinish | I don't have any context on what's going on :) | 18:08 |
| bauzas | alaski: heh, liberty... | 18:08 |
| mtreinish | I'm just answering questions | 18:08 |
| bauzas | mtreinish: and you're answering pretty well :D | 18:09 |
| *** electrocucaracha has joined #openstack-nova | 18:09 | |
| alaski | mtreinish: cellsv2 stuff is failing grenade because the db wasn't configured in kilo | 18:09 |
| bauzas | mtreinish: so, FYI we're discussing around some grenade jobs failing | 18:09 |
| bauzas | for the cells v2 stuff | 18:09 |
| alaski | mtreinish: https://review.openstack.org/#/c/190289/2 would need to be in kilo to get them to pass | 18:09 |
| bauzas | jinxed by alaski | 18:09 |
| *** SourabhP has joined #openstack-nova | 18:10 | |
| mtreinish | alaski: or the dansmith patch to add the database as part of the upgrade procedure from kilo->liberty | 18:10 |
| alaski | mtreinish: a better question right now is when does grenade switch to liberty->M upgrades | 18:10 |
| mtreinish | alaski: at the release normally, there are some infra bits we have to land and then branch devstack and grenade to do that | 18:10 |
| alaski | mtreinish: yes | 18:10 |
| bauzas | alaski: yeah I think we can wait for the Muppet release | 18:10 |
| alaski | mtreinish: okay, this is somewhat moot then. The code failing won't merge until M at which point grenade should have the right configs | 18:11 |
| mtreinish | bauzas, alaski: just as a normal fyi whenever this kinda thing comes up I point people to: http://docs.openstack.org/developer/grenade/readme.html#theory-of-upgrade | 18:11 |
| *** med_ has joined #openstack-nova | 18:11 | |
| *** med_ has joined #openstack-nova | 18:11 | |
| alaski | mtreinish: thanks | 18:12 |
| *** xgsa has quit IRC | 18:12 | |
| alaski | the big miss here was not adding that config to devstack when it was added to Nova | 18:12 |
| bauzas | mtreinish: very valuable info | 18:12 |
| bauzas | alaski: yup, missed a Depends-On | 18:12 |
| *** krtaylor has quit IRC | 18:13 | |
| bauzas | definitely good knowledge | 18:13 |
| *** zxyf has quit IRC | 18:13 | |
| bauzas | lalit: so tl;dr: we have to wait till Mitaka opens for the job to be happy | 18:13 |
| *** eharney_ has joined #openstack-nova | 18:13 | |
| *** zxyf has joined #openstack-nova | 18:14 | |
| *** ociuhandu has quit IRC | 18:14 | |
| *** VW___ has quit IRC | 18:14 | |
| *** VW_ has joined #openstack-nova | 18:15 | |
| lalit | bauzas: correct :) | 18:15 |
| *** thedodd has quit IRC | 18:15 | |
| openstackgerrit | Taylor Peoples proposed openstack/nova: Return empty PciDevicePoolList obj instead of None https://review.openstack.org/220634 | 18:17 |
| *** eharney has quit IRC | 18:17 | |
| *** zxyf has quit IRC | 18:18 | |
| *** zxyf has joined #openstack-nova | 18:18 | |
| *** VW_ has quit IRC | 18:19 | |
| *** xgsa has joined #openstack-nova | 18:20 | |
| *** baoli_ has joined #openstack-nova | 18:20 | |
| openstackgerrit | dane-fichter proposed openstack/nova-specs: Nova Support of Glance Image Signing https://review.openstack.org/188874 | 18:21 |
| *** zxyf has quit IRC | 18:21 | |
| *** lyanchih has quit IRC | 18:21 | |
| *** eharney_ is now known as eharney | 18:22 | |
| *** READ10 has joined #openstack-nova | 18:22 | |
| *** e0ne has joined #openstack-nova | 18:23 | |
| lalit | bauzas , alaski : bye for now, see you later | 18:23 |
| lalit | quit | 18:23 |
| *** lalit has quit IRC | 18:23 | |
| *** baoli has quit IRC | 18:24 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor object_backport() https://review.openstack.org/220730 | 18:25 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Add version 3.0 of conductor RPC interface https://review.openstack.org/168857 | 18:25 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove lazy-loading property compute_task_api from compute api https://review.openstack.org/168859 | 18:25 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove conductor 2.x RPC API https://review.openstack.org/168858 | 18:25 |
| *** xgsa has quit IRC | 18:25 | |
| *** zxyf has joined #openstack-nova | 18:26 | |
| dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L502 | 18:27 |
| dansmith | mriedem: that doesn't format those variables | 18:27 |
| dansmith | do I have to pass them as a positional argument dict? | 18:28 |
| *** maishsk has joined #openstack-nova | 18:28 | |
| *** VW_ has joined #openstack-nova | 18:28 | |
| *** zxyf has quit IRC | 18:29 | |
| mriedem | balls | 18:29 |
| *** aix has quit IRC | 18:29 | |
| mriedem | yea | 18:29 |
| mriedem | {'obj': obj, 'manifest': manifest, etc} | 18:29 |
| mriedem | god who approved that?! | 18:30 |
| *** zxyf has joined #openstack-nova | 18:30 | |
| dansmith | someone who can't keep it straight either | 18:30 |
| mriedem | oh jaypipes, i should have known :P | 18:30 |
| dansmith | I don't blame them | 18:30 |
| mriedem | revert! | 18:30 |
| mriedem | yeah, didn't even register with me | 18:30 |
| dansmith | I was just testing all this new backporting stuff for real and wanted to see that debug show me the right details | 18:31 |
| dansmith | so I fixed it and tested it for reals locally | 18:32 |
| dansmith | I'll put up a patch | 18:32 |
| *** vilobhmm_111 has quit IRC | 18:32 | |
| *** jhesketh has quit IRC | 18:32 | |
| *** rotbeard has quit IRC | 18:32 | |
| dansmith | I'll even file a bug | 18:32 |
| mriedem | ping me when it's up | 18:32 |
| mriedem | yeah, that'd be good | 18:32 |
| * mriedem slinks off back to git diff / rpm spec hell | 18:33 | |
| *** zxyf has quit IRC | 18:33 | |
| *** rotbeard has joined #openstack-nova | 18:33 | |
| *** jhesketh has joined #openstack-nova | 18:34 | |
| *** tongli has quit IRC | 18:35 | |
| openstackgerrit | Matt Rabe proposed openstack/nova: Use six.test_type instead of str in serialize_args https://review.openstack.org/221905 | 18:36 |
| *** josecastroleon has quit IRC | 18:36 | |
| *** agireud has quit IRC | 18:36 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 18:39 |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 18:40 |
| *** zxyf has joined #openstack-nova | 18:40 | |
| *** DinaBelova has quit IRC | 18:40 | |
| *** mrsoul has quit IRC | 18:40 | |
| *** rubasov has quit IRC | 18:40 | |
| *** josecastroleon has joined #openstack-nova | 18:41 | |
| *** danieru_ has joined #openstack-nova | 18:41 | |
| *** danieru has quit IRC | 18:41 | |
| *** rubasov has joined #openstack-nova | 18:41 | |
| *** lennyb has quit IRC | 18:41 | |
| *** leseb has quit IRC | 18:41 | |
| *** agireud has joined #openstack-nova | 18:42 | |
| *** ZZelle_ has quit IRC | 18:42 | |
| *** lennyb has joined #openstack-nova | 18:42 | |
| *** mrsoul has joined #openstack-nova | 18:42 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 18:42 |
| *** leseb has joined #openstack-nova | 18:43 | |
| *** zxyf has quit IRC | 18:43 | |
| *** DinaBelova has joined #openstack-nova | 18:43 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 18:43 |
| openstackgerrit | Dan Smith proposed openstack/nova: Fix debug log format in object_backport_versions() https://review.openstack.org/221910 | 18:47 |
| *** e0ne has quit IRC | 18:47 | |
| dansmith | mriedem: ^ | 18:47 |
| *** zxyf has joined #openstack-nova | 18:47 | |
| *** krtaylor has joined #openstack-nova | 18:48 | |
| *** zxyf has quit IRC | 18:50 | |
| *** kylek3h has quit IRC | 18:50 | |
| *** kylek3h has joined #openstack-nova | 18:51 | |
| dansmith | mriedem: ctrath +1d so it's like obviously right | 18:54 |
| ctrath | ha.. | 18:54 |
| *** Sukhdev has joined #openstack-nova | 18:55 | |
| *** kmartin has joined #openstack-nova | 18:55 | |
| mriedem | ctrath: there is no compile tile | 18:56 |
| mriedem | *time | 18:56 |
| *** yamahata has joined #openstack-nova | 18:57 | |
| mriedem | dansmith: assuming you ran pep8? | 18:57 |
| ctrath | well, the runtime does a scan though, right. I consider this a 'compile' | 18:57 |
| dansmith | mriedem: yep | 18:57 |
| dansmith | ctrath: if the log method takes **kwargs it wouldn't catch it | 18:57 |
| mriedem | this is the wild west, most anything goes | 18:57 |
| *** vilobhmm_11 has joined #openstack-nova | 18:57 | |
| * mriedem shoots pistols in air | 18:57 | |
| dansmith | actually, even the AST parse wouldn't catch it | 18:57 |
| ctrath | dansmith, mriedem: good to know :-) | 18:58 |
| mriedem | your best bet on a thing like this would be some kind of monkey patch / fixture validation | 18:58 |
| dansmith | mriedem: alaski: I was so excited to get my box set up to make sure the new method was being called, and after all the hours of setup, I got %s, %s | 18:58 |
| dansmith | very disappointing | 18:58 |
| bauzas | alaski: was just seeing that you provided the logstash query for the cells failure, but I now use http://goo.gl/xGnRW6 | 18:58 |
| mriedem | to trap all logged messages during unit test and check if unsubb'ed vars show up in the message | 18:58 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances https://review.openstack.org/176925 | 18:58 |
| *** ociuhandu has joined #openstack-nova | 18:58 | |
| mriedem | which reminds me, i still think our debug logging fixture to detect missing %s subs is still broken | 18:59 |
| mriedem | i never wrote a bug about that | 18:59 |
| alaski | dansmith: http://www.sadtrombone.com/ | 19:00 |
| *** thedodd has joined #openstack-nova | 19:00 | |
| *** krtaylor has quit IRC | 19:00 | |
| ctrath | mriedem: where can I find that fixture? | 19:00 |
| *** krtaylor has joined #openstack-nova | 19:00 | |
| dansmith | alaski: indeed | 19:01 |
| *** amrith is now known as _amrith_ | 19:01 | |
| mriedem | ctrath: http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/fixtures.py#n61 | 19:01 |
| ctrath | ty | 19:01 |
| mriedem | used in the StandardLogging fixture | 19:01 |
| *** zxyf has joined #openstack-nova | 19:01 | |
| mriedem | the idea is if you have a unit test that hits a LOG.debug message and that has %s which isn't replaced, it should fail | 19:01 |
| mriedem | but last time i fixed one of these it wasn't catching it | 19:01 |
| *** thangp_ has joined #openstack-nova | 19:01 | |
| alaski | bauzas: nice | 19:02 |
| mriedem | might need help from lifeless on that if it's someting to do i nthe logging fixtures | 19:02 |
| *** Apoorva has quit IRC | 19:02 | |
| ctrath | ok | 19:02 |
| *** burgerk has joined #openstack-nova | 19:03 | |
| *** thangp has quit IRC | 19:04 | |
| mtreinish | mriedem: ugh, that logging fixture | 19:04 |
| mriedem | seems we should be using http://git.openstack.org/cgit/openstack/oslo.log/tree/oslo_log/fixture/logging_error.py somewehre | 19:04 |
| mtreinish | it took jogo and I a long time to get it to do the right thing | 19:04 |
| mriedem | my guess is this all worked when jogo added it | 19:04 |
| mriedem | but now it's regressed and no one noticed | 19:04 |
| *** zxyf has quit IRC | 19:05 | |
| melwitt | what's the right thing to do when a fix didn't fix the entire problem and a bug is closed? should I reopen it and let the patch be "Closes-Bug" again or open a new bug? it's for the novaclient versions list bug https://bugs.launchpad.net/python-novaclient/+bug/1491579 | 19:05 |
| openstack | Launchpad bug 1491579 in python-novaclient "can not get nova version info on some public clouds, causing nova client hangs" [Critical,Fix released] - Assigned to Sean Dague (sdague) | 19:05 |
| *** lpetrut has joined #openstack-nova | 19:05 | |
| *** zxyf has joined #openstack-nova | 19:06 | |
| mriedem | melwitt: i'd open a new one, reference the old one | 19:06 |
| dansmith | melwitt: the former I think | 19:06 |
| dansmith | alright. | 19:06 |
| *** SourabhP has quit IRC | 19:06 | |
| mriedem | it gets pretty confusing otherwise | 19:06 |
| dansmith | the old bug won't have anything in it about the new bug though, | 19:07 |
| dansmith | so if someone is going to go backport the old one and doesn't realize there was more... | 19:07 |
| melwitt | yeah, I think that makes sense | 19:07 |
| dansmith | at least put linkage in the old bug, but IMHO, just reopen | 19:07 |
| *** e0ne has joined #openstack-nova | 19:07 | |
| *** thangp_ has quit IRC | 19:08 | |
| *** nic has quit IRC | 19:08 | |
| melwitt | dansmith: when I reopen it, do I clear out the Milestone then I guess? | 19:09 |
| dansmith | melwitt: is the problem that the patch was incomplete or that the scope of the problem is larger than the original bug? | 19:10 |
| *** angdraug has joined #openstack-nova | 19:10 | |
| *** boris-42 has quit IRC | 19:10 | |
| dansmith | another reason to repoen, IMHO, is people looking at launchpad to find out when a thing was fixed | 19:10 |
| dansmith | and if we didn't fix it in X.Y, then the bug shouldn't indicate that we did | 19:10 |
| melwitt | dansmith: patch incomplete. it only worked around the rax problem in the case of the session client and didn't handle the non-session client | 19:11 |
| dansmith | but if we fixed a piece, but there was more | 19:11 |
| dansmith | melwitt: yeah, I'd reopen and clear the milestone then | 19:11 |
| dansmith | with a comment about what's going on of course | 19:11 |
| melwitt | okay, thanks | 19:11 |
| dansmith | melwitt: you discovered this with your own testing or something? | 19:11 |
| melwitt | dansmith: no, someone put up some patches today in novaclient because they ran into it | 19:12 |
| dansmith | ah | 19:12 |
| dansmith | even better I guess :) | 19:12 |
| melwitt | yeah :) | 19:12 |
| *** kylek3h has quit IRC | 19:12 | |
| *** achanda has quit IRC | 19:13 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:13 |
| dansmith | speak of the devil | 19:14 |
| *** thangp has joined #openstack-nova | 19:14 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate 'novaclient.client.get_client_class' https://review.openstack.org/221789 | 19:15 |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:15 |
| *** _amrith_ is now known as amrith | 19:16 | |
| *** nic has joined #openstack-nova | 19:17 | |
| *** kiran-r has joined #openstack-nova | 19:17 | |
| *** alex_klimov has joined #openstack-nova | 19:18 | |
| alaski | bugs with rackspace, that's absurd | 19:19 |
| *** y_sawai_ has joined #openstack-nova | 19:19 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: make sure os_password is set for auth_plugins https://review.openstack.org/221921 | 19:20 |
| *** SourabhP has joined #openstack-nova | 19:20 | |
| *** y_sawai has quit IRC | 19:22 | |
| *** alexpilotti has quit IRC | 19:24 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 19:25 |
| *** edmondsw has quit IRC | 19:25 | |
| *** y_sawai_ has quit IRC | 19:27 | |
| *** y_sawai has joined #openstack-nova | 19:27 | |
| *** y_sawai has quit IRC | 19:27 | |
| *** exploreshaifali has quit IRC | 19:28 | |
| *** rotbeard has quit IRC | 19:29 | |
| *** kiran-r has quit IRC | 19:29 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:29 |
| *** emagana has quit IRC | 19:30 | |
| *** emagana has joined #openstack-nova | 19:31 | |
| *** y_sawai has joined #openstack-nova | 19:32 | |
| *** e0ne has quit IRC | 19:32 | |
| *** aix has joined #openstack-nova | 19:33 | |
| *** SourabhP has quit IRC | 19:34 | |
| *** lpetrut has quit IRC | 19:35 | |
| *** maishsk_ has joined #openstack-nova | 19:38 | |
| *** Piet has quit IRC | 19:38 | |
| *** maishsk has quit IRC | 19:38 | |
| *** maishsk_ is now known as maishsk | 19:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/221934 | 19:40 |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:42 |
| melwitt | I wonder why the infra bot doesn't always update bugs with "Fix proposed" and a link to the review | 19:42 |
| bauzas | melwitt: how is the bug tag in the commit msg ? | 19:43 |
| *** amrith is now known as _amrith_ | 19:43 | |
| *** Apoorva has joined #openstack-nova | 19:43 | |
| melwitt | bauzas: Closes-Bug: #1491579 | 19:43 |
| openstack | bug 1491579 in python-novaclient "can not get nova version info on some public clouds, causing nova client hangs" [Critical,In progress] https://launchpad.net/bugs/1491579 - Assigned to Daniel Wallace (danielwallace) | 19:43 |
| *** devlaps has quit IRC | 19:43 | |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:43 |
| melwitt | bauzas: it assigned the bug to the author but didn't put the message about the patch | 19:43 |
| edleafe- | 19:44 | |
| melwitt | bauzas: I verified the infra user is a member of the nova bug team too. so I dunno | 19:44 |
| bauzas | melwitt: strange | 19:44 |
| openstackgerrit | Matt Rabe proposed openstack/nova: Use six.text_type instead of str in serialize_args https://review.openstack.org/221905 | 19:45 |
| bauzas | melwitt: is it for https://review.openstack.org/#/c/221570/ ? | 19:46 |
| *** zxyf has quit IRC | 19:46 | |
| melwitt | bauzas: yes | 19:46 |
| sdague | ok, anyone else up for +Aing the last couple of bits of v3 removal from naming - https://review.openstack.org/#/c/214311 | 19:46 |
| bauzas | melwitt: I wonder if it's because N closes-Bug | 19:46 |
| *** ijw_ has joined #openstack-nova | 19:46 | |
| bauzas | N>1 | 19:46 |
| *** edleafe- is now known as edleafe | 19:47 | |
| melwitt | hm, maybe | 19:47 |
| openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: Fix bugs with rackspace https://review.openstack.org/221570 | 19:48 |
| bauzas | sdague: https://review.openstack.org/#/c/214311/7/nova/api/openstack/__init__.py,cm is modifying a string, is it okay per the new StringFreeze rules ? | 19:48 |
| bauzas | L340 | 19:48 |
| sdague | bauzas: I have to believe yes it's ok, otherwise we tell people they have disabled V3 | 19:49 |
| sdague | which doesn't exist | 19:49 |
| sdague | I also think we're only in soft freeze at the moment | 19:49 |
| edleafe | bauzas: mriedem looked into that. See comment on PS6 | 19:49 |
| bauzas | edleafe: coolness | 19:50 |
| *** maishsk_ has joined #openstack-nova | 19:51 | |
| mriedem | yeah, see johnthetubaguy's update to the ML on soft string freeze | 19:51 |
| bauzas | that totally makes sense | 19:52 |
| *** maishsk has quit IRC | 19:53 | |
| *** maishsk_ is now known as maishsk | 19:53 | |
| *** y_sawai has quit IRC | 19:53 | |
| *** ZZelle_ has joined #openstack-nova | 19:54 | |
| *** gszasz has quit IRC | 19:55 | |
| mriedem | ctrath: this is the bug i reported for that log fixture thing https://bugs.launchpad.net/nova/+bug/1493980 | 19:56 |
| openstack | Launchpad bug 1493980 in OpenStack Compute (nova) "The NullHandler and StandardLogging test fixtures don't appear to be detecting formatting errors" [Undecided,New] | 19:56 |
| mriedem | i'm playing with trying to recreate the failures locally | 19:56 |
| jroll | melwitt: sometimes that hook just doesn't fire and/or breaks :/ | 19:56 |
| mriedem | doffm: rlrossit: ^ | 19:56 |
| ctrath | mriedem: ok.. I'll see if I can repro locally | 19:57 |
| sdague | mriedem: if you can build a unit test to expose it, it's fixable. I was pretty careful in refactoring that code and thought the logic was line for line what we had before | 19:58 |
| mriedem | i was able to verify one failure | 19:58 |
| melwitt | mriedem: I didn't know we had something set up intended to catch log formatting problems. I've caught several in reviews that always passed tests | 19:58 |
| melwitt | I should have realized there was something broken | 19:59 |
| *** zxyf has joined #openstack-nova | 19:59 | |
| *** boris-42 has joined #openstack-nova | 20:00 | |
| *** otter768 has joined #openstack-nova | 20:00 | |
| mriedem | sdague: there is an example in here | 20:01 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1493980/comments/2 | 20:01 |
| openstack | Launchpad bug 1493980 in OpenStack Compute (nova) "The NullHandler and StandardLogging test fixtures don't appear to be detecting formatting errors" [Undecided,New] | 20:01 |
| mriedem | ^ is what dansmith just fixed | 20:01 |
| *** lucasagomes has quit IRC | 20:02 | |
| mriedem | these could also be limitations in python logging | 20:02 |
| *** zxyf has quit IRC | 20:02 | |
| sdague | mriedem: ok, I'll look tomorrow | 20:03 |
| *** baoli_ has quit IRC | 20:03 | |
| *** maishsk_ has joined #openstack-nova | 20:04 | |
| *** maishsk has quit IRC | 20:04 | |
| *** maishsk_ is now known as maishsk | 20:04 | |
| *** otter768 has quit IRC | 20:05 | |
| lifeless | mriedem: ? | 20:05 |
| lifeless | mriedem: logging? | 20:06 |
| mriedem | sdague: i think i know what's wrong, and i think it was a regression with the move to oslo.log | 20:06 |
| mriedem | lifeless: v | 20:06 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1493980 | 20:06 |
| openstack | Launchpad bug 1493980 in OpenStack Compute (nova) "The NullHandler and StandardLogging test fixtures don't appear to be detecting formatting errors" [Medium,Confirmed] | 20:06 |
| mriedem | trying something | 20:07 |
| *** kmartin has quit IRC | 20:07 | |
| *** zxyf has joined #openstack-nova | 20:07 | |
| *** VW__ has joined #openstack-nova | 20:09 | |
| mriedem | nvm, wrong | 20:09 |
| *** VW__ has quit IRC | 20:09 | |
| *** VW__ has joined #openstack-nova | 20:10 | |
| *** Piet has joined #openstack-nova | 20:10 | |
| *** e0ne has joined #openstack-nova | 20:11 | |
| *** VW_ has quit IRC | 20:12 | |
| *** zxyf has quit IRC | 20:12 | |
| *** achanda has joined #openstack-nova | 20:12 | |
| *** gibi has quit IRC | 20:14 | |
| openstackgerrit | Corey Wright proposed openstack/nova: Ephemeral block devices start at xvde for XenAPI https://review.openstack.org/221946 | 20:14 |
| *** lucasagomes has joined #openstack-nova | 20:17 | |
| *** achanda has quit IRC | 20:18 | |
| *** thangp has quit IRC | 20:21 | |
| *** zxyf has joined #openstack-nova | 20:21 | |
| *** lucasagomes has quit IRC | 20:21 | |
| *** salv-orlando has quit IRC | 20:22 | |
| *** salv-orlando has joined #openstack-nova | 20:22 | |
| *** y_sawai has joined #openstack-nova | 20:22 | |
| *** smatzek has quit IRC | 20:24 | |
| *** zxyf has quit IRC | 20:24 | |
| *** y_sawai has quit IRC | 20:24 | |
| *** zxyf has joined #openstack-nova | 20:25 | |
| *** VW__ has quit IRC | 20:25 | |
| *** VW_ has joined #openstack-nova | 20:25 | |
| *** _amrith_ is now known as amrith | 20:26 | |
| *** moshele has joined #openstack-nova | 20:27 | |
| *** zxyf has quit IRC | 20:28 | |
| *** achanda has joined #openstack-nova | 20:28 | |
| *** VW_ has quit IRC | 20:29 | |
| *** kmartin has joined #openstack-nova | 20:29 | |
| *** SourabhP has joined #openstack-nova | 20:30 | |
| *** zxyf has joined #openstack-nova | 20:32 | |
| jogo | mtreinish: the logging fixture broke :( | 20:35 |
| mtreinish | jogo: that's what mriedem was saying | 20:36 |
| mtreinish | I haven't looked at it | 20:36 |
| mriedem | well, it works in some cases | 20:36 |
| *** zxyf has quit IRC | 20:36 | |
| mriedem | specifically if you call out a kwarg in the log message but don't provide that kwarg in the log method | 20:36 |
| mriedem | but if you have %s and don't provide any attributes, it doesn't work | 20:37 |
| mriedem | doesn't work as in doesn't fail | 20:37 |
| mriedem | like, this is fine: LOG.debug('this is a test %s') | 20:38 |
| mriedem | so is: LOG.debug('this is a %(test)s', test='test') | 20:38 |
| mriedem | but those don't actually format properly with oslo.log | 20:38 |
| jogo | mriedem: try 'print "ab %s"' in an interpreter | 20:39 |
| jogo | python just prints things out | 20:40 |
| *** amrith is now known as _amrith_ | 20:40 | |
| *** salv-orlando has quit IRC | 20:40 | |
| mriedem | jogo: yeah, which is the bug that dansmith fixed here: https://review.openstack.org/#/c/221910/1/nova/conductor/manager.py | 20:41 |
| *** salv-orlando has joined #openstack-nova | 20:41 | |
| mriedem | so, my bug about those not failing is maybe 'works as designed', but seems we should still detect those and fail | 20:41 |
| mriedem | like if after formatting the log record the message still has %s in it, that's wrong | 20:41 |
| *** salv-orl_ has joined #openstack-nova | 20:42 | |
| jogo | mriedem: agreed, looks like you need to detect if a string is supposed to be interpolated | 20:42 |
| jogo | and if not raise an error | 20:42 |
| jogo | rather if it is, but isn't interpolated ... | 20:42 |
| jogo | why does python make this hard to do | 20:43 |
| *** zxyf has joined #openstack-nova | 20:43 | |
| *** salv-or__ has joined #openstack-nova | 20:44 | |
| *** salv-orl_ has quit IRC | 20:44 | |
| *** salv-orlando has quit IRC | 20:46 | |
| *** zxyf has quit IRC | 20:46 | |
| *** achanda has quit IRC | 20:49 | |
| *** thedodd has quit IRC | 20:51 | |
| *** dave-mccowan has quit IRC | 20:51 | |
| *** SourabhP has quit IRC | 20:52 | |
| *** Sukhdev has quit IRC | 20:55 | |
| *** burgerk has quit IRC | 20:55 | |
| *** emagana has quit IRC | 20:56 | |
| *** SourabhP has joined #openstack-nova | 20:56 | |
| *** achanda has joined #openstack-nova | 20:59 | |
| *** zxyf has joined #openstack-nova | 21:01 | |
| *** moon_ has quit IRC | 21:01 | |
| *** darrenc_ has joined #openstack-nova | 21:02 | |
| *** darrenc has quit IRC | 21:03 | |
| *** jhesketh has quit IRC | 21:03 | |
| *** zxyf has quit IRC | 21:04 | |
| *** zxyf has joined #openstack-nova | 21:04 | |
| *** agireud has quit IRC | 21:05 | |
| *** angdraug has quit IRC | 21:05 | |
| *** krtaylor has quit IRC | 21:05 | |
| *** jhesketh has joined #openstack-nova | 21:07 | |
| *** dustins has quit IRC | 21:08 | |
| edleafe | mriedem: '%s' is valid text | 21:09 |
| edleafe | mriedem: unless you want to make it explicitly invalid | 21:09 |
| *** edmondsw has joined #openstack-nova | 21:10 | |
| mriedem | edleafe: in the context of a log message, i think %s is probably wrong if it's not %%s | 21:10 |
| mriedem | after you've formatted the log message | 21:10 |
| *** obedmr_ has joined #openstack-nova | 21:10 | |
| edleafe | mriedem: after you've formatted, %%s become %s, %%%s becomes %%s, etc | 21:11 |
| mriedem | maybe allowing but not formatting someting like "LOG.debug('this is a %(test)s', test='test')" is more of a bug in oslo.log | 21:11 |
| *** xiaohui has quit IRC | 21:11 | |
| edleafe | mriedem: what I'm saying is you need to look for those chanracters after formatting. It's nothing python will complaiin about | 21:11 |
| mriedem | i.e. all kwargs could be subs unless we have a whitelist, like instance= and instance_uuid= which oslo.log already knows about | 21:11 |
| *** xiaohui has joined #openstack-nova | 21:11 | |
| mriedem | edleafe: i know, i'm saying the same thing | 21:12 |
| mriedem | if after we've formatted the log message, we still have %s in there, it's wrong | 21:12 |
| dansmith | mriedem: you're allowed to have unformatted strings | 21:12 |
| edleafe | mriedem: ah, I misunderstood when you said "it's wrong" | 21:12 |
| dansmith | mriedem: it's just that if you try to format it, it has to be complete | 21:12 |
| *** obedmr has quit IRC | 21:13 | |
| dims | mriedem: LOG.debug() where LOG is from python logging or oslo_log.log should behave the same | 21:13 |
| mriedem | dansmith: would be nice if you could be strict about unformatted strings | 21:13 |
| dansmith | mriedem: well, it breaks the language I think | 21:14 |
| dansmith | mriedem: because it's common to do this: | 21:14 |
| dansmith | string = 'foo %s bar' | 21:14 |
| dansmith | val = calculate() | 21:14 |
| dansmith | print string % val | 21:14 |
| mriedem | sure | 21:14 |
| mriedem | that's fine | 21:14 |
| mriedem | but | 21:14 |
| dansmith | the problem is, this is common too: | 21:14 |
| dansmith | print 'foo %s bar' % locals() | 21:15 |
| dansmith | so you can't really be strict about everything in the dict being formatted | 21:15 |
| mriedem | if i'm doing LOG.debug('foo %s bar') and not even attempting to format that %s, i think that's a problem | 21:15 |
| *** salv-orlando has joined #openstack-nova | 21:15 | |
| openstackgerrit | Andrew Laski proposed openstack/nova-specs: Instance tasks backlog spec https://review.openstack.org/221963 | 21:15 |
| *** ssurana has joined #openstack-nova | 21:15 | |
| dansmith | mriedem: the logging thing should maybe complain about that, | 21:15 |
| dansmith | or try to format it with {} or something | 21:15 |
| dansmith | agree with that for sure | 21:15 |
| mriedem | that's the bug imo | 21:15 |
| mriedem | that the logger doesn't complain | 21:15 |
| *** thorst has quit IRC | 21:16 | |
| dansmith | yeah | 21:17 |
| *** salv-or__ has quit IRC | 21:17 | |
| dansmith | does the log fixture not try to format the string? | 21:17 |
| dansmith | it must not else my thing would have failed I gues | 21:18 |
| melwitt | is there something afoot with the hyper-v-ci? it seems to be failing a lot | 21:18 |
| dansmith | melwitt: now you're just *trying* to say afoot :) | 21:18 |
| melwitt | dansmith: you're right :) | 21:18 |
| dansmith | yeah, I know :) | 21:19 |
| melwitt | I'm too transparent | 21:19 |
| mriedem | melwitt: yeah, it's off the rails, ociuhandu is working on it | 21:19 |
| mriedem | i removed hyper-v from the nova-ci group in gerrit until fixed | 21:19 |
| melwitt | mriedem: oh, good. thanks | 21:19 |
| ociuhandu | melwitt: hi, we have some internal issues we are debugging now | 21:19 |
| mriedem | dansmith: yeah, i've confirmed that if i have nova code that does: LOG.debug('test %s', instance=instance) it doesn't complain or fail the log handler scrubbing | 21:20 |
| dansmith | yeah that's broken | 21:20 |
| mriedem | comments 2 and 3 in here https://bugs.launchpad.net/nova/+bug/1493980 | 21:21 |
| openstack | Launchpad bug 1493980 in OpenStack Compute (nova) "The NullHandler and StandardLogging test fixtures don't appear to be detecting formatting errors" [Medium,Confirmed] | 21:21 |
| mriedem | are the test cases | 21:21 |
| melwitt | ociuhandu: okay, cool. thanks for working on it | 21:21 |
| *** VW_ has joined #openstack-nova | 21:23 | |
| *** obedmr_ has quit IRC | 21:24 | |
| *** zxyf has quit IRC | 21:27 | |
| *** zxyf has joined #openstack-nova | 21:27 | |
| *** agireud has joined #openstack-nova | 21:27 | |
| *** VW_ has quit IRC | 21:28 | |
| *** electroc_ has joined #openstack-nova | 21:28 | |
| *** obedmr has joined #openstack-nova | 21:28 | |
| openstackgerrit | Corey Wright proposed openstack/nova: Ephemeral block devices start at xvde for XenAPI https://review.openstack.org/221946 | 21:28 |
| openstackgerrit | Corey Wright proposed openstack/nova: Set XenAPI-specific swap and ephemeral device_name https://review.openstack.org/221968 | 21:28 |
| mriedem | oh snap | 21:30 |
| mriedem | TypeError: Log message is not properly formatted: Explicitly disassociating fixed IP %s from instance. | 21:30 |
| mriedem | i have a fix | 21:30 |
| mriedem | for a thing | 21:30 |
| *** zxyf has quit IRC | 21:31 | |
| *** dave-mccowan has joined #openstack-nova | 21:32 | |
| *** electrocucaracha has quit IRC | 21:32 | |
| *** obedmr has quit IRC | 21:32 | |
| *** Piet has quit IRC | 21:33 | |
| *** obedmr_ has joined #openstack-nova | 21:38 | |
| *** eharney has quit IRC | 21:39 | |
| *** emagana has joined #openstack-nova | 21:39 | |
| *** e0ne has quit IRC | 21:39 | |
| *** maishsk has quit IRC | 21:40 | |
| *** maishsk has joined #openstack-nova | 21:40 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 21:41 |
| *** mestery has quit IRC | 21:41 | |
| *** zxyf has joined #openstack-nova | 21:41 | |
| *** mestery has joined #openstack-nova | 21:42 | |
| *** dave-mccowan has quit IRC | 21:42 | |
| *** tsekiyama has joined #openstack-nova | 21:42 | |
| *** VW_ has joined #openstack-nova | 21:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Check for unformatted %s in logged messages during test runs https://review.openstack.org/221973 | 21:43 |
| mriedem | edleafe: ctrath: melwitt: jogo: dims: dansmith: sdague: ^ partial fix, i haven't done a full tox run yet to see what that is going to pick up - just wondering if it's sane to start with | 21:43 |
| ctrath | sweet | 21:43 |
| ctrath | ugh.. regex :-/ | 21:44 |
| mriedem | handling unformatted kwargs is trickier | 21:44 |
| dansmith | mriedem: you should check for other format chars, right? %i, etc | 21:44 |
| *** obedmr has joined #openstack-nova | 21:44 | |
| dansmith | %d %f %r | 21:44 |
| *** zxyf has quit IRC | 21:44 | |
| mriedem | dansmith: sure | 21:44 |
| *** rlrossit has left #openstack-nova | 21:45 | |
| mriedem | you could add that comment, i just wanted to get this up before i have to be done for the day | 21:45 |
| mriedem | like i said, i havne't done a full tox run either | 21:45 |
| dansmith | I took the review stat point because I'm a whore | 21:46 |
| *** obedmr_ has quit IRC | 21:46 | |
| ctrath | mriedem: will this catch the error that dansmith fixed? | 21:46 |
| dansmith | should | 21:46 |
| ctrath | s/error/bug | 21:46 |
| dansmith | if it's doing what I think it is | 21:46 |
| mriedem | ctrath: i still have to add the kwarg check | 21:46 |
| *** edtubill has quit IRC | 21:46 | |
| *** asettle has joined #openstack-nova | 21:46 | |
| mriedem | busy building ifixes on the side | 21:47 |
| mriedem | for icehouse, my favorite | 21:47 |
| melwitt | dansmith: lol! | 21:47 |
| *** zxyf has joined #openstack-nova | 21:49 | |
| *** agireud has quit IRC | 21:50 | |
| *** obedmr has quit IRC | 21:50 | |
| mriedem | dansmith: %f will be tricky | 21:52 |
| mriedem | unless you have suggestions | 21:52 |
| *** zxyf has quit IRC | 21:52 | |
| dansmith | %[0-9]+(.[0-9]+)f | 21:53 |
| dansmith | is probably close enough | 21:53 |
| dansmith | if you include %f in the simple case | 21:53 |
| *** ssurana has quit IRC | 21:53 | |
| *** obedmr has joined #openstack-nova | 21:53 | |
| *** Sukhdev has joined #openstack-nova | 21:57 | |
| *** moshele has quit IRC | 21:57 | |
| *** nikeshm__ has quit IRC | 21:58 | |
| *** penick has quit IRC | 21:58 | |
| ctrath | mriedem: kwargs? : .*[^%]%.*\)s.* | 22:00 |
| *** otter768 has joined #openstack-nova | 22:01 | |
| *** Marga_ has quit IRC | 22:03 | |
| *** Marga_ has joined #openstack-nova | 22:03 | |
| *** VW__ has joined #openstack-nova | 22:04 | |
| *** krtaylor has joined #openstack-nova | 22:04 | |
| *** mdrabe has quit IRC | 22:06 | |
| *** otter768 has quit IRC | 22:06 | |
| *** zxyf has joined #openstack-nova | 22:06 | |
| *** Piet has joined #openstack-nova | 22:06 | |
| *** VW_ has quit IRC | 22:06 | |
| *** humble_ has joined #openstack-nova | 22:07 | |
| *** _amrith_ is now known as amrith | 22:08 | |
| *** wanghua has quit IRC | 22:08 | |
| *** burt has quit IRC | 22:08 | |
| *** VW__ has quit IRC | 22:08 | |
| *** zxyf has quit IRC | 22:09 | |
| *** bradjones is now known as bradjones|away | 22:09 | |
| *** penick has joined #openstack-nova | 22:11 | |
| *** ctrath has quit IRC | 22:12 | |
| *** shoutm has joined #openstack-nova | 22:12 | |
| *** shoutm has quit IRC | 22:12 | |
| *** irenab has joined #openstack-nova | 22:12 | |
| *** zxyf has joined #openstack-nova | 22:12 | |
| *** Daisy has joined #openstack-nova | 22:13 | |
| *** angdraug has joined #openstack-nova | 22:13 | |
| *** ijw_ has quit IRC | 22:15 | |
| *** zxyf has quit IRC | 22:17 | |
| *** zxyf has joined #openstack-nova | 22:17 | |
| *** pixelbeat has quit IRC | 22:20 | |
| *** kylek3h has joined #openstack-nova | 22:20 | |
| *** zxyf has quit IRC | 22:20 | |
| *** masayukig has quit IRC | 22:24 | |
| *** ijw_ has joined #openstack-nova | 22:25 | |
| *** masayukig has joined #openstack-nova | 22:26 | |
| *** mwagner_lap has quit IRC | 22:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Check for unformatted logged messages during test runs https://review.openstack.org/221973 | 22:28 |
| *** kylek3h has quit IRC | 22:28 | |
| *** kylek3h has joined #openstack-nova | 22:29 | |
| *** tjones1 has joined #openstack-nova | 22:30 | |
| *** IanGovett has quit IRC | 22:31 | |
| *** zxyf has joined #openstack-nova | 22:31 | |
| *** vladikr has quit IRC | 22:31 | |
| *** irenab has quit IRC | 22:32 | |
| *** rajesht has quit IRC | 22:33 | |
| *** kylek3h has quit IRC | 22:33 | |
| *** zxyf has quit IRC | 22:34 | |
| *** electroc_ has quit IRC | 22:36 | |
| *** jecarey has quit IRC | 22:36 | |
| *** dannywil_ has joined #openstack-nova | 22:38 | |
| *** dannywilson has quit IRC | 22:42 | |
| *** Daisy has quit IRC | 22:43 | |
| *** Daisy has joined #openstack-nova | 22:43 | |
| *** ijuwang has quit IRC | 22:46 | |
| *** Daisy has quit IRC | 22:47 | |
| *** kylek3h has joined #openstack-nova | 22:48 | |
| *** dannywil_ has quit IRC | 22:49 | |
| *** kylek3h has quit IRC | 22:50 | |
| *** kylek3h has joined #openstack-nova | 22:50 | |
| *** aysyd has quit IRC | 22:50 | |
| *** darrenc_ is now known as darrenc | 22:51 | |
| *** erhudy1 has joined #openstack-nova | 22:53 | |
| *** whenry__ has quit IRC | 22:55 | |
| *** hemna is now known as hemnafk | 22:55 | |
| *** markvoelker has quit IRC | 22:56 | |
| *** obedmr has quit IRC | 22:56 | |
| *** xyang1 has quit IRC | 22:56 | |
| *** dannywilson has joined #openstack-nova | 22:57 | |
| *** rushil has joined #openstack-nova | 22:59 | |
| *** Apoorva has quit IRC | 23:00 | |
| *** rcarrillocruz has quit IRC | 23:05 | |
| *** achanda has quit IRC | 23:08 | |
| *** rcarrillocruz has joined #openstack-nova | 23:08 | |
| *** erlon has quit IRC | 23:08 | |
| mtreinish | mriedem: http://logs.openstack.org/87/214987/9/check/gate-tempest-dsvm-postgres-full/88910d0/logs/screen-n-net.txt.gz#_2015-09-09_06_03_26_402 | 23:10 |
| mtreinish | that's a fun quota bug | 23:10 |
| mtreinish | last time I checked 3 < 99, but I could be wrong | 23:10 |
| *** david-lyle has quit IRC | 23:11 | |
| mtreinish | jamielennox: ^^^ so that's the nova bug on the postgres run for your patch | 23:11 |
| *** david-lyle has joined #openstack-nova | 23:12 | |
| jamielennox | yuk | 23:14 |
| *** kylek3h has quit IRC | 23:15 | |
| *** kylek3h has joined #openstack-nova | 23:15 | |
| *** kylek3h has quit IRC | 23:15 | |
| *** kylek3h has joined #openstack-nova | 23:16 | |
| *** rdo has quit IRC | 23:17 | |
| *** zzzeek has quit IRC | 23:17 | |
| *** Apoorva has joined #openstack-nova | 23:17 | |
| *** electrocucaracha has joined #openstack-nova | 23:19 | |
| *** darrenc is now known as darrenc_afk | 23:20 | |
| *** achanda has joined #openstack-nova | 23:20 | |
| *** kylek3h has quit IRC | 23:21 | |
| *** david-lyle has quit IRC | 23:22 | |
| *** emagana has quit IRC | 23:22 | |
| *** edmondsw has quit IRC | 23:23 | |
| *** david-lyle has joined #openstack-nova | 23:23 | |
| *** kylek3h has joined #openstack-nova | 23:24 | |
| openstackgerrit | Corey Wright proposed openstack/nova: Ephemeral block devices start at xvde for XenAPI https://review.openstack.org/221946 | 23:24 |
| *** rdo has joined #openstack-nova | 23:25 | |
| *** diogogmt has quit IRC | 23:26 | |
| mtreinish | mriedem: oh, that looks like a dup of bug 1353962 | 23:28 |
| openstack | bug 1353962 in OpenStack Compute (nova) "Test job fails with FixedIpLimitExceeded with nova network" [Medium,Confirmed] https://launchpad.net/bugs/1353962 | 23:28 |
| openstackgerrit | Corey Wright proposed openstack/nova: Set XenAPI-specific swap and ephemeral device_name https://review.openstack.org/221968 | 23:28 |
| mtreinish | I guess logstash was backed up so e-r didn't report on it | 23:28 |
| *** electrocucaracha has quit IRC | 23:29 | |
| *** kylek3h has quit IRC | 23:31 | |
| *** kylek3h has joined #openstack-nova | 23:32 | |
| *** kse has joined #openstack-nova | 23:33 | |
| *** zxyf has joined #openstack-nova | 23:33 | |
| *** kylek3h has quit IRC | 23:36 | |
| openstackgerrit | Corey Wright proposed openstack/nova: Set XenAPI-specific swap and ephemeral device_name https://review.openstack.org/221968 | 23:38 |
| *** alex_klimov has quit IRC | 23:38 | |
| mriedem | mtreinish: yeah that's old news | 23:42 |
| mtreinish | mriedem: I thought it looked familiar but I hadn't seen it in a while | 23:43 |
| mtreinish | so I thought maybe it was closed or something | 23:43 |
| mtreinish | just wishful thinking I guess | 23:44 |
| *** mriedem1 has joined #openstack-nova | 23:44 | |
| *** shoutm has joined #openstack-nova | 23:44 | |
| *** Sukhdev has quit IRC | 23:45 | |
| *** Sukhdev has joined #openstack-nova | 23:45 | |
| *** ZZelle_ has quit IRC | 23:46 | |
| *** mriedem has quit IRC | 23:47 | |
| *** penick_ has joined #openstack-nova | 23:48 | |
| *** penick has quit IRC | 23:48 | |
| *** penick_ is now known as penick | 23:48 | |
| *** nic has quit IRC | 23:51 | |
| *** angdraug has quit IRC | 23:52 | |
| *** RuiChen has joined #openstack-nova | 23:53 | |
| *** jwcroppe has quit IRC | 23:55 | |
| *** mmedvede has quit IRC | 23:55 | |
| *** jwcroppe has joined #openstack-nova | 23:56 | |
| *** markvoelker has joined #openstack-nova | 23:57 | |
| *** thorst has joined #openstack-nova | 23:58 | |
| *** apuimedo|away has quit IRC | 23:58 | |
| *** thorst has quit IRC | 23:59 | |
| *** thorst has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!