| *** VW_ has quit IRC | 00:01 | |
| *** VW_ has joined #openstack-nova | 00:01 | |
| *** david-lyle has quit IRC | 00:03 | |
| -openstackstatus- NOTICE: Zuul was restarted due to an error; events (such as approvals or new patchsets) since 23:01 UTC have been lost and affected changes will need to be rechecked | 00:05 | |
| *** VW_ has quit IRC | 00:05 | |
| *** sachin has quit IRC | 00:11 | |
| *** mdrabe has joined #openstack-nova | 00:11 | |
| *** otter768 has joined #openstack-nova | 00:12 | |
| *** diogogmt has quit IRC | 00:12 | |
| *** sachin has joined #openstack-nova | 00:13 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 00:13 |
|---|---|---|
| openstackgerrit | zhengyue proposed openstack/nova: Fix abnormal quota usage after restore by admin https://review.openstack.org/211432 | 00:14 |
| *** sachin has quit IRC | 00:14 | |
| *** sachin has joined #openstack-nova | 00:15 | |
| *** otter768 has quit IRC | 00:16 | |
| *** meghal has quit IRC | 00:19 | |
| *** meghal has joined #openstack-nova | 00:19 | |
| *** sachin has quit IRC | 00:21 | |
| *** mrodden has quit IRC | 00:21 | |
| *** sachin has joined #openstack-nova | 00:22 | |
| alex_xu | edleafe: cool, thanks | 00:22 |
| *** oomichi has joined #openstack-nova | 00:23 | |
| *** sachin has quit IRC | 00:23 | |
| *** IanGovett has quit IRC | 00:23 | |
| *** nelsnelson has quit IRC | 00:24 | |
| *** sachin has joined #openstack-nova | 00:25 | |
| *** sachin has quit IRC | 00:26 | |
| *** sachin has joined #openstack-nova | 00:27 | |
| *** otter768 has joined #openstack-nova | 00:27 | |
| *** sachin has quit IRC | 00:27 | |
| *** sachin_ has joined #openstack-nova | 00:27 | |
| *** mdrabe has quit IRC | 00:30 | |
| *** kylek3h_ has joined #openstack-nova | 00:31 | |
| *** kylek3h has quit IRC | 00:33 | |
| *** claudiub has quit IRC | 00:34 | |
| *** achanda_ has joined #openstack-nova | 00:35 | |
| *** ijw_ has joined #openstack-nova | 00:35 | |
| *** thorst has joined #openstack-nova | 00:36 | |
| *** achanda has quit IRC | 00:38 | |
| *** ijw has quit IRC | 00:39 | |
| *** achanda_ has quit IRC | 00:39 | |
| *** nelsnelson has joined #openstack-nova | 00:40 | |
| *** thumpba has quit IRC | 00:42 | |
| *** sachin_ has quit IRC | 00:44 | |
| *** sachin has joined #openstack-nova | 00:44 | |
| *** ssurana has quit IRC | 00:45 | |
| *** browne1 has quit IRC | 00:45 | |
| *** shyu has joined #openstack-nova | 00:47 | |
| alex_xu | edleafe: are you still around? | 00:49 |
| *** tsekiyam_ has joined #openstack-nova | 00:50 | |
| *** xyang1 has quit IRC | 00:51 | |
| *** vivekd has joined #openstack-nova | 00:52 | |
| *** mtanino has quit IRC | 00:53 | |
| *** tsekiyama has quit IRC | 00:53 | |
| *** david-lyle has joined #openstack-nova | 00:54 | |
| *** ijw_ has quit IRC | 00:54 | |
| oomichi | edleafe: hello | 00:55 |
| *** tsekiyam_ has quit IRC | 00:55 | |
| *** ijw_ has joined #openstack-nova | 00:55 | |
| *** thumpba has joined #openstack-nova | 00:56 | |
| openstackgerrit | zhengyue proposed openstack/nova: Fix abnormal quota usage after restore by admin https://review.openstack.org/211432 | 00:59 |
| *** meghal has quit IRC | 00:59 | |
| *** thumpba has quit IRC | 00:59 | |
| *** skylerberg has quit IRC | 00:59 | |
| *** sachin has quit IRC | 01:00 | |
| *** sachin has joined #openstack-nova | 01:00 | |
| oomichi | alex_xu: hi, morning | 01:02 |
| oomichi | alex_xu: re: https://review.openstack.org/#/c/211390/ | 01:03 |
| oomichi | alex_xu: you are one of authors of this patch. so can you update it for fixing your points and my point? | 01:04 |
| *** praneshp has quit IRC | 01:04 | |
| oomichi | alex_xu: I'd like to merge this today :) | 01:04 |
| *** eliqiao has quit IRC | 01:07 | |
| *** thumpba has joined #openstack-nova | 01:08 | |
| *** haomaiwang has quit IRC | 01:09 | |
| *** baoli has joined #openstack-nova | 01:12 | |
| *** tpeoples has quit IRC | 01:12 | |
| *** thumpba_ has joined #openstack-nova | 01:13 | |
| *** thumpba has quit IRC | 01:14 | |
| *** annashen has joined #openstack-nova | 01:15 | |
| *** thumpba_ has quit IRC | 01:15 | |
| *** thumpba has joined #openstack-nova | 01:15 | |
| *** thorst has quit IRC | 01:16 | |
| *** zhenguo has joined #openstack-nova | 01:16 | |
| *** tjones has quit IRC | 01:17 | |
| *** liusheng has quit IRC | 01:19 | |
| *** annashen has quit IRC | 01:19 | |
| *** Marga__ has joined #openstack-nova | 01:19 | |
| *** liusheng has joined #openstack-nova | 01:19 | |
| *** Marga_ has quit IRC | 01:20 | |
| *** wanghua has joined #openstack-nova | 01:20 | |
| *** skylerberg has joined #openstack-nova | 01:21 | |
| *** shuquan has joined #openstack-nova | 01:24 | |
| *** agireud has joined #openstack-nova | 01:24 | |
| *** humble_ has joined #openstack-nova | 01:26 | |
| *** diogogmt has joined #openstack-nova | 01:28 | |
| *** wanghua has quit IRC | 01:29 | |
| *** lyanchih has joined #openstack-nova | 01:31 | |
| *** shuquan has quit IRC | 01:32 | |
| oomichi | edleafe: can you remove WIP from https://review.openstack.org/#/c/211356/ ? | 01:32 |
| *** shuquan has joined #openstack-nova | 01:34 | |
| tonyb | mriedem: Are you still around? | 01:35 |
| mriedem | barely | 01:36 |
| tonyb | mriedem: I was thinking I'd have a stab at lifeless's suggestion for large ops | 01:36 |
| mriedem | tonyb: go nuts | 01:37 |
| tonyb | if you had 5-10 to point me in the right direction that'd help | 01:37 |
| mriedem | oh i see how it is | 01:37 |
| tonyb | but alos if you're ready to quit I understand | 01:37 |
| mriedem | you know, if i took the 10 minutes to figure it out i'd just do it and take the credit right? | 01:37 |
| tonyb | mriedem: ;P | 01:38 |
| tonyb | mriedem: I'll see what I can find then no stress. | 01:38 |
| *** tobe_ has joined #openstack-nova | 01:39 | |
| *** shuquan has quit IRC | 01:39 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add project-id when list server-groups https://review.openstack.org/209018 | 01:39 |
| mriedem | tonyb: so i think the thing was getting novaclient installed first | 01:39 |
| mriedem | before some uncapped deps pull in 2.26 | 01:39 |
| mriedem | https://github.com/openstack/requirements/blob/stable/juno/global-requirements.txt#L118 | 01:40 |
| mriedem | python-novaclient>=2.18.0,<=2.20.0 | 01:40 |
| mriedem | the large ops job doesn't install cinder, else cinder would handle the capped deps on novaclient | 01:40 |
| mriedem | https://github.com/openstack/cinder/blob/stable/juno/requirements.txt#L27 | 01:41 |
| mriedem | which would satisfy osc 1.0.1 so it wouldn't pull in uncapped novaclient | 01:41 |
| mriedem | all making sense?! | 01:41 |
| mriedem | :P | 01:41 |
| mriedem | so the hack fix is, blatantly "pip install python-novaclient>=2.18.0,<=2.20.0" in the large ops job | 01:41 |
| mriedem | before osc is installed | 01:41 |
| mriedem | in devstack, you can tell the large ops job because it uses the nova fake virt driver | 01:42 |
| tonyb | mriedem: okay, that's pretty much what I thought. | 01:42 |
| mriedem | so i guess use that as your flag to tell your large ops, then do the pip install of novaclient capped before osc is installed | 01:42 |
| mriedem | in devstack stable/juno | 01:42 |
| mriedem | then, riches and fame be unto thee | 01:42 |
| tonyb | mriedem: don't we have DEVSTACK_GATE_TEMPEST_LARGE_OPS set? | 01:43 |
| *** nelsnelson has quit IRC | 01:44 | |
| tonyb | mriedem: anyway you weer on your way out and you've pinted me in the right direction. | 01:44 |
| mriedem | tonyb: yeah i think that's the flag that's used to set the virt driver to fake | 01:44 |
| * mriedem kind of wants to fix this now | 01:44 | |
| * mriedem kind of also wants to finish ex machina | 01:44 | |
| tonyb | mriedem: do the later | 01:44 |
| *** vivekd has quit IRC | 01:45 | |
| mriedem | dansmith: ex machina ^ | 01:45 |
| mriedem | so far so good | 01:46 |
| mriedem | i know it won't end well though | 01:46 |
| mriedem | tonyb: btw, thanks for taking a crack at the stable thing, hard to find people that want to help | 01:46 |
| tonyb | mriedem: I *want* to help but it's scary and seem to require deep knowledge | 01:47 |
| mriedem | you've seen he-man right? | 01:47 |
| tonyb | mriedem: which is probably a chicken and egg thing | 01:47 |
| *** shuquan has joined #openstack-nova | 01:47 | |
| tonyb | mriedem: Nah I was born in NZ and that was never a thing ;P | 01:47 |
| mriedem | sad | 01:47 |
| mriedem | https://www.youtube.com/watch?v=GPPqDUDzsek | 01:48 |
| mriedem | just watch that, get amped up, and you know, do good | 01:48 |
| *** ijw_ has quit IRC | 01:48 | |
| *** mriedem is now known as mriedem_movie | 01:49 | |
| *** baoli has quit IRC | 01:49 | |
| *** ijw has joined #openstack-nova | 01:49 | |
| tonyb | mriedem_movie: yes sir! | 01:49 |
| *** shuquan has quit IRC | 01:53 | |
| *** alejandrito has quit IRC | 01:55 | |
| *** annashen has joined #openstack-nova | 01:56 | |
| *** shuquan has joined #openstack-nova | 01:59 | |
| *** rushil has joined #openstack-nova | 02:03 | |
| *** erlon has quit IRC | 02:03 | |
| *** thumpba has quit IRC | 02:04 | |
| *** patrickeast has quit IRC | 02:04 | |
| *** baoli has joined #openstack-nova | 02:04 | |
| *** thumpba has joined #openstack-nova | 02:05 | |
| *** thumpba has quit IRC | 02:05 | |
| *** svalleru has joined #openstack-nova | 02:05 | |
| *** vilobhmm has quit IRC | 02:05 | |
| *** nelsnelson has joined #openstack-nova | 02:06 | |
| *** marzif has quit IRC | 02:06 | |
| *** sachin has quit IRC | 02:09 | |
| *** eliqiao has joined #openstack-nova | 02:11 | |
| *** y_sawai has joined #openstack-nova | 02:14 | |
| *** y_sawai has quit IRC | 02:14 | |
| *** yamahata has quit IRC | 02:15 | |
| *** svalleru has quit IRC | 02:17 | |
| *** rushil has quit IRC | 02:19 | |
| *** shuquan has quit IRC | 02:19 | |
| *** nelsnelson has quit IRC | 02:20 | |
| *** shuquan has joined #openstack-nova | 02:20 | |
| *** unicell has quit IRC | 02:20 | |
| *** wanghua has joined #openstack-nova | 02:20 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: Fix model query for non-admin flavor lookups https://review.openstack.org/211809 | 02:21 |
| *** haomaiwa_ has joined #openstack-nova | 02:21 | |
| *** humble_ has quit IRC | 02:21 | |
| *** arif-ali has quit IRC | 02:21 | |
| *** nic has quit IRC | 02:22 | |
| *** jwcroppe has joined #openstack-nova | 02:23 | |
| *** shuquan_ has joined #openstack-nova | 02:24 | |
| *** shuquan has quit IRC | 02:25 | |
| *** shuquan_ is now known as shuquan | 02:25 | |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extensions https://review.openstack.org/211258 | 02:25 |
| *** arif-ali has joined #openstack-nova | 02:26 | |
| *** gyee has quit IRC | 02:27 | |
| *** mdbooth has quit IRC | 02:29 | |
| *** Marga__ has quit IRC | 02:30 | |
| *** Marga_ has joined #openstack-nova | 02:30 | |
| *** david-lyle has quit IRC | 02:33 | |
| openstackgerrit | whitekid proposed openstack/nova: use memcache.get_multi instead of memcache.get better performance https://review.openstack.org/211250 | 02:34 |
| *** mdbooth has joined #openstack-nova | 02:34 | |
| *** shyu has quit IRC | 02:35 | |
| openstackgerrit | whitekid proposed openstack/nova: use memcache.get_multi instead of memcache.get better performance https://review.openstack.org/211250 | 02:37 |
| *** nelsnelson has joined #openstack-nova | 02:38 | |
| *** sachin has joined #openstack-nova | 02:39 | |
| *** browne has joined #openstack-nova | 02:39 | |
| *** nelsnelson has quit IRC | 02:42 | |
| *** agireud has quit IRC | 02:42 | |
| *** jdandrea has quit IRC | 02:43 | |
| *** sachin has quit IRC | 02:43 | |
| *** angdraug has quit IRC | 02:46 | |
| *** wendar has quit IRC | 02:46 | |
| *** wendar has joined #openstack-nova | 02:46 | |
| *** shuquan has quit IRC | 02:49 | |
| *** shuquan has joined #openstack-nova | 02:50 | |
| *** shyu has joined #openstack-nova | 02:51 | |
| *** hakimo has joined #openstack-nova | 02:52 | |
| *** shuquan has quit IRC | 02:53 | |
| *** otter768 has quit IRC | 02:54 | |
| *** hakimo_ has quit IRC | 02:54 | |
| *** patrickeast has joined #openstack-nova | 02:55 | |
| *** Sree has joined #openstack-nova | 02:55 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 - step 3 https://review.openstack.org/211777 | 03:00 |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 - step 2 https://review.openstack.org/211390 | 03:00 |
| *** Sree has quit IRC | 03:00 | |
| alex_xu | oomichi: ^ address the comments in the step2 | 03:00 |
| *** agireud has joined #openstack-nova | 03:00 | |
| *** Sree has joined #openstack-nova | 03:00 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incorrect result of host-describe https://review.openstack.org/211083 | 03:01 |
| *** Sree has quit IRC | 03:01 | |
| oomichi | alex_xu: thanks :) | 03:01 |
| alex_xu | oomichi: thanks for your review also | 03:01 |
| *** Sree has joined #openstack-nova | 03:02 | |
| *** humble_ has joined #openstack-nova | 03:02 | |
| *** vilobhmm has joined #openstack-nova | 03:02 | |
| *** venkat_p has joined #openstack-nova | 03:04 | |
| *** vilobhmm1 has joined #openstack-nova | 03:04 | |
| *** wanghua has quit IRC | 03:05 | |
| *** kiwik-chenrui has quit IRC | 03:07 | |
| *** vilobhmm has quit IRC | 03:07 | |
| *** RuiChen has joined #openstack-nova | 03:07 | |
| *** agireud has quit IRC | 03:10 | |
| *** mriedem_movie has quit IRC | 03:14 | |
| *** patrickeast has quit IRC | 03:15 | |
| *** jwcroppe has quit IRC | 03:15 | |
| *** tobe_ has quit IRC | 03:15 | |
| *** tobe_ has joined #openstack-nova | 03:16 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: network_request_obj: Clean up outdated code https://review.openstack.org/201425 | 03:20 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:21 |
| *** fawadkhaliq has joined #openstack-nova | 03:22 | |
| *** baoli has quit IRC | 03:23 | |
| *** Sree has quit IRC | 03:23 | |
| *** Sree has joined #openstack-nova | 03:24 | |
| *** humble__ has joined #openstack-nova | 03:24 | |
| *** tpeoples has joined #openstack-nova | 03:25 | |
| *** danieru has quit IRC | 03:25 | |
| *** danieru has joined #openstack-nova | 03:25 | |
| *** dan has quit IRC | 03:26 | |
| *** adreznec has quit IRC | 03:26 | |
| *** dan has joined #openstack-nova | 03:26 | |
| *** achanda has joined #openstack-nova | 03:27 | |
| *** adreznec has joined #openstack-nova | 03:27 | |
| *** baoli has joined #openstack-nova | 03:28 | |
| *** Sree has quit IRC | 03:28 | |
| *** diogogmt has quit IRC | 03:29 | |
| *** david-lyle has joined #openstack-nova | 03:30 | |
| *** shyu has quit IRC | 03:33 | |
| *** htruta has quit IRC | 03:36 | |
| *** dikonoor has joined #openstack-nova | 03:36 | |
| *** sachin has joined #openstack-nova | 03:38 | |
| *** htruta has joined #openstack-nova | 03:40 | |
| *** sachin has quit IRC | 03:42 | |
| *** shyu has joined #openstack-nova | 03:44 | |
| *** tjones has joined #openstack-nova | 03:48 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add methods for RequestContext to switch db connection https://review.openstack.org/161906 | 03:53 |
| *** annashen has quit IRC | 03:54 | |
| *** baoli has quit IRC | 03:55 | |
| *** shuquan_ has joined #openstack-nova | 03:56 | |
| *** ijw has quit IRC | 04:00 | |
| *** annashen_ has joined #openstack-nova | 04:02 | |
| *** vilobhmm has joined #openstack-nova | 04:03 | |
| *** vilobhmm1 has quit IRC | 04:03 | |
| *** shuquan has joined #openstack-nova | 04:06 | |
| *** shuquan_ has quit IRC | 04:06 | |
| *** unicell has joined #openstack-nova | 04:06 | |
| *** vivekd has joined #openstack-nova | 04:10 | |
| *** rajesht has joined #openstack-nova | 04:12 | |
| *** Sukhdev_ has joined #openstack-nova | 04:19 | |
| *** annashen_ has quit IRC | 04:23 | |
| *** morgan_404 is now known as morgan_410 | 04:26 | |
| *** morgan_410 is now known as morgan_404 | 04:26 | |
| *** vivekd_ has joined #openstack-nova | 04:38 | |
| *** vivekd has quit IRC | 04:40 | |
| *** vivekd_ is now known as vivekd | 04:40 | |
| *** links has joined #openstack-nova | 04:42 | |
| *** tjones has quit IRC | 04:43 | |
| *** chhavi has joined #openstack-nova | 04:45 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 - step 3 https://review.openstack.org/211777 | 04:48 |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 - step 2 https://review.openstack.org/211390 | 04:48 |
| *** tobe_ has quit IRC | 04:53 | |
| *** otter768 has joined #openstack-nova | 04:55 | |
| *** tjones has joined #openstack-nova | 04:56 | |
| *** otter768 has quit IRC | 04:59 | |
| *** tobe_ has joined #openstack-nova | 05:04 | |
| *** lyanchih has quit IRC | 05:07 | |
| *** chhavi_ has joined #openstack-nova | 05:07 | |
| *** chhavi has quit IRC | 05:07 | |
| *** chhavi_ has quit IRC | 05:08 | |
| *** chhavi_ has joined #openstack-nova | 05:08 | |
| *** deepakcs has joined #openstack-nova | 05:12 | |
| *** tjones has quit IRC | 05:15 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move v2.1 code to the main compute directory - remove v3 step 3 https://review.openstack.org/211777 | 05:19 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove 'v3' direcotry for v2.1 json-schemas - remove v3 step4 https://review.openstack.org/211846 | 05:19 |
| alex_xu | edleafe: ^ step4! | 05:20 |
| *** liusheng has quit IRC | 05:20 | |
| *** kmARC has joined #openstack-nova | 05:20 | |
| *** liusheng has joined #openstack-nova | 05:20 | |
| *** kmARC has quit IRC | 05:21 | |
| *** kmARC has joined #openstack-nova | 05:22 | |
| *** shyu has quit IRC | 05:23 | |
| *** shyu has joined #openstack-nova | 05:24 | |
| *** n0ano has quit IRC | 05:28 | |
| *** shuquan has quit IRC | 05:28 | |
| *** tpeoples has quit IRC | 05:29 | |
| *** Sree has joined #openstack-nova | 05:29 | |
| *** chhavi_ has quit IRC | 05:29 | |
| *** shuquan has joined #openstack-nova | 05:30 | |
| *** skylerberg has quit IRC | 05:32 | |
| *** vilobhmm has quit IRC | 05:32 | |
| *** ankit_ag has joined #openstack-nova | 05:35 | |
| *** fawadkhaliq has quit IRC | 05:38 | |
| *** sachin has joined #openstack-nova | 05:39 | |
| *** sachin has quit IRC | 05:44 | |
| *** rook has quit IRC | 05:44 | |
| *** chhavi_ has joined #openstack-nova | 05:46 | |
| *** praneshp has joined #openstack-nova | 05:46 | |
| *** humble__ has quit IRC | 05:48 | |
| *** shunliz_ has joined #openstack-nova | 05:50 | |
| *** shuquan_ has joined #openstack-nova | 05:50 | |
| *** shuquan has quit IRC | 05:51 | |
| *** shuquan_ is now known as shuquan | 05:51 | |
| *** cfriesen_ has quit IRC | 05:51 | |
| *** cfriesen_ has joined #openstack-nova | 05:51 | |
| *** haomaiwa_ has quit IRC | 05:53 | |
| *** Murali_ has joined #openstack-nova | 05:53 | |
| *** haomaiwang has joined #openstack-nova | 05:54 | |
| *** lyanchih has joined #openstack-nova | 05:55 | |
| *** yonglihe has joined #openstack-nova | 05:56 | |
| *** yonglihe has quit IRC | 05:56 | |
| *** yonglihe has joined #openstack-nova | 05:57 | |
| *** Sukhdev_ has quit IRC | 05:58 | |
| *** fawadkhaliq has joined #openstack-nova | 05:59 | |
| *** josecastroleon has joined #openstack-nova | 06:00 | |
| *** shuquan has quit IRC | 06:03 | |
| *** nagyz has quit IRC | 06:04 | |
| *** haomaiwang has quit IRC | 06:04 | |
| *** shuquan has joined #openstack-nova | 06:06 | |
| *** browne has quit IRC | 06:07 | |
| *** zhenguo has quit IRC | 06:13 | |
| *** irenab has quit IRC | 06:14 | |
| *** rook has joined #openstack-nova | 06:14 | |
| *** Jeffrey4l has joined #openstack-nova | 06:14 | |
| *** haomaiwang has joined #openstack-nova | 06:15 | |
| *** cfriesen_ has quit IRC | 06:16 | |
| *** Nikolay_St has joined #openstack-nova | 06:18 | |
| *** rook has quit IRC | 06:19 | |
| *** lyanchih has quit IRC | 06:21 | |
| *** lyanchih has joined #openstack-nova | 06:22 | |
| *** shuquan has quit IRC | 06:22 | |
| *** echoingumesh has joined #openstack-nova | 06:23 | |
| *** jeffrey4l_ has joined #openstack-nova | 06:23 | |
| *** shyu has quit IRC | 06:24 | |
| *** jeffrey4l_ is now known as Jeffrey4l|afk | 06:25 | |
| *** shyu has joined #openstack-nova | 06:25 | |
| *** unicell1 has joined #openstack-nova | 06:28 | |
| *** unicell has quit IRC | 06:28 | |
| *** exploreshaifali has joined #openstack-nova | 06:29 | |
| *** echoingumesh has quit IRC | 06:30 | |
| *** moshele has joined #openstack-nova | 06:30 | |
| *** vivekd has quit IRC | 06:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/209780 | 06:32 |
| *** exploreshaifali has quit IRC | 06:32 | |
| *** sachin has joined #openstack-nova | 06:33 | |
| *** sahid has joined #openstack-nova | 06:34 | |
| *** shyu has quit IRC | 06:34 | |
| *** sachin has quit IRC | 06:38 | |
| *** alexschm has joined #openstack-nova | 06:39 | |
| *** scheuran has joined #openstack-nova | 06:40 | |
| *** shyu has joined #openstack-nova | 06:42 | |
| *** irenab has joined #openstack-nova | 06:43 | |
| *** exploreshaifali has joined #openstack-nova | 06:43 | |
| *** Vikas has joined #openstack-nova | 06:43 | |
| *** shyu has quit IRC | 06:47 | |
| *** rdo has quit IRC | 06:49 | |
| *** shyu has joined #openstack-nova | 06:49 | |
| *** abhishekk has joined #openstack-nova | 06:51 | |
| *** rdo has joined #openstack-nova | 06:51 | |
| *** rdopiera has joined #openstack-nova | 06:52 | |
| *** shyu has quit IRC | 06:54 | |
| *** otter768 has joined #openstack-nova | 06:56 | |
| *** yonglihe has quit IRC | 06:57 | |
| *** ildikov has quit IRC | 07:00 | |
| *** otter768 has quit IRC | 07:00 | |
| venkat_p | Hi all | 07:01 |
| venkat_p | In the code, | 07:01 |
| lyanchih | Hi!!! | 07:01 |
| venkat_p | why class Scheduler(object) is not an abstract class | 07:01 |
| venkat_p | https://github.com/openstack/nova/blob/master/nova/scheduler/driver.py#L39 | 07:03 |
| venkat_p | Hi lyanchich, | 07:03 |
| *** alex_klimov has joined #openstack-nova | 07:03 | |
| *** alex_klimov has quit IRC | 07:03 | |
| *** alex_klimov has joined #openstack-nova | 07:04 | |
| *** Jeffrey4l has quit IRC | 07:04 | |
| *** humble__ has joined #openstack-nova | 07:04 | |
| *** _gryf has quit IRC | 07:04 | |
| *** xek has quit IRC | 07:04 | |
| *** _gryf has joined #openstack-nova | 07:05 | |
| *** xek has joined #openstack-nova | 07:05 | |
| lyanchih | It is base class. | 07:06 |
| venkat_p | yes, it has abstract methods, which subclass should override ... | 07:06 |
| venkat_p | If it is abtract class , it improves readability .. | 07:07 |
| *** humble_ has quit IRC | 07:08 | |
| venkat_p | lynachich : is this correct ? | 07:09 |
| *** Vikas has quit IRC | 07:11 | |
| *** fawadkhaliq has quit IRC | 07:12 | |
| *** fawadk has joined #openstack-nova | 07:13 | |
| *** chhavi_ has quit IRC | 07:13 | |
| *** ig0r_ has joined #openstack-nova | 07:14 | |
| *** ishant has joined #openstack-nova | 07:16 | |
| *** praneshp has quit IRC | 07:18 | |
| *** garyk has joined #openstack-nova | 07:21 | |
| *** gszasz has joined #openstack-nova | 07:22 | |
| *** yamahata has joined #openstack-nova | 07:24 | |
| *** markus_z has joined #openstack-nova | 07:26 | |
| lyanchih | venkat_p: Abstract class needs all methods are abstract methods, but schduler still needs some default methods | 07:27 |
| *** chhavi_ has joined #openstack-nova | 07:28 | |
| *** achanda has quit IRC | 07:31 | |
| *** afazekas has joined #openstack-nova | 07:31 | |
| *** _ has joined #openstack-nova | 07:32 | |
| *** moshele has quit IRC | 07:32 | |
| *** _ is now known as Guest23 | 07:32 | |
| *** Guest23 has quit IRC | 07:33 | |
| abhishekk | hi, mitaka directory is created under nova-specs, is it open to submit the specs for mitaka? | 07:33 |
| *** Marga__ has joined #openstack-nova | 07:33 | |
| *** moshele has joined #openstack-nova | 07:33 | |
| abhishekk | garyk: hi, you around? | 07:34 |
| *** rgerganov has joined #openstack-nova | 07:35 | |
| *** achanda has joined #openstack-nova | 07:36 | |
| *** zhenguo has joined #openstack-nova | 07:36 | |
| *** Marga_ has quit IRC | 07:37 | |
| *** ig0r__ has joined #openstack-nova | 07:37 | |
| *** rdo has quit IRC | 07:38 | |
| *** shuquan has joined #openstack-nova | 07:38 | |
| garyk | abhishekk: i am away on vacation. just online to check a few emails | 07:39 |
| abhishekk | garyk:ok | 07:39 |
| *** ig0r_ has quit IRC | 07:41 | |
| *** rgerganov has quit IRC | 07:42 | |
| tonyb | abhishekk: Yes I believe that mitaka specs are open. but they wont be a review priority for cores | 07:43 |
| *** romainh has joined #openstack-nova | 07:43 | |
| abhishekk | tonyb: thank you, so should I move my specs for liberty/backlog to mitaka? | 07:44 |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extensions https://review.openstack.org/211258 | 07:44 |
| tonyb | abhishekk: That'd depend on the spec and I don't feel able to advise there. | 07:44 |
| *** tobe_ has quit IRC | 07:44 | |
| tonyb | abhishekk: Perhaps an email to os-dev would be a good idea to save others asking the same questions? | 07:45 |
| *** jlanoux has joined #openstack-nova | 07:45 | |
| abhishekk | tonyb: sure thank you for input | 07:45 |
| *** rdo has joined #openstack-nova | 07:45 | |
| tonyb | abhishekk: yw sorry it wasn't more helpful | 07:46 |
| abhishekk | tonyb: no problem, i will shoot a mail on mailing list | 07:46 |
| *** achanda has quit IRC | 07:46 | |
| *** chhavi_ has quit IRC | 07:47 | |
| openstackgerrit | Atsushi SAKAI proposed openstack/nova: Fix three typos on nova/pci directory https://review.openstack.org/211883 | 07:48 |
| *** chhavi_ has joined #openstack-nova | 07:49 | |
| *** boris-42 has quit IRC | 07:50 | |
| *** tobe_ has joined #openstack-nova | 07:50 | |
| *** _gryf has quit IRC | 07:53 | |
| *** _gryf has joined #openstack-nova | 07:55 | |
| *** rgerganov has joined #openstack-nova | 07:55 | |
| *** _gryf has quit IRC | 07:56 | |
| *** chhavi_ has quit IRC | 07:57 | |
| *** _gryf has joined #openstack-nova | 07:58 | |
| *** tobe_ has quit IRC | 08:00 | |
| *** claudiub has joined #openstack-nova | 08:03 | |
| *** tobe_ has joined #openstack-nova | 08:05 | |
| *** shuquan has quit IRC | 08:05 | |
| *** yamahata has quit IRC | 08:08 | |
| *** ildikov has joined #openstack-nova | 08:08 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Scheduler: Send notifier.info in ChanceScheduler https://review.openstack.org/211887 | 08:09 |
| *** lyanchih has quit IRC | 08:10 | |
| *** rgerganov has quit IRC | 08:12 | |
| *** ig0r__ has quit IRC | 08:13 | |
| *** ig0r_ has joined #openstack-nova | 08:16 | |
| *** Marga__ has quit IRC | 08:17 | |
| *** Marga_ has joined #openstack-nova | 08:18 | |
| *** ig0r_ has quit IRC | 08:19 | |
| *** yassine__ has joined #openstack-nova | 08:19 | |
| *** liusheng has quit IRC | 08:19 | |
| *** lyanchih has joined #openstack-nova | 08:20 | |
| *** liusheng has joined #openstack-nova | 08:20 | |
| *** eglynn has joined #openstack-nova | 08:20 | |
| *** jistr has joined #openstack-nova | 08:21 | |
| *** sachin has joined #openstack-nova | 08:21 | |
| markus_z | Good morning Nova, it's bug review day, wohoo! | 08:22 |
| kashyap | markus_z: Morning, when you have a moment, and have a DevStack setup handy, wondering if you'd like to do a small test | 08:22 |
| kashyap | Ah, we were typing at the same time :-) | 08:22 |
| markus_z | kashyap: sure, can do that | 08:22 |
| kashyap | markus_z: Yeah, just need a second pair of eyes. | 08:23 |
| kashyap | markus_z: Here's the test -- https://kashyapc.fedorapeople.org/virt/openstack/Attach-Cinder-volume-test.txt | 08:23 |
| kashyap | Nothing complicated, very straight-forward: | 08:23 |
| kashyap | (1) Ensure DevStack is setup with 'iscsi_helper=lioadm' in cinder.conf | 08:23 |
| kashyap | You can use CINDER_ISCSI_HELPER=lioadm in you localrc | 08:24 |
| markus_z | kashyap: Ah, there was a rebuild bug which I tried to reproduce, is it that one? | 08:24 |
| kashyap | (2) Create a simple Cinder volume, as noted in the above URL | 08:24 |
| kashyap | (3) Attach it to a freshly booted Nova instance | 08:24 |
| kashyap | (4) Perform `nova rebuild vm1 image` | 08:24 |
| *** Maike has joined #openstack-nova | 08:25 | |
| kashyap | See if step-(4) fails, with "Failed to terminate process $PID with SIGKILL: Device or resource busy" | 08:25 |
| kashyap | markus_z: Got a URL to the bug that you allude to? | 08:25 |
| *** sachin has quit IRC | 08:25 | |
| *** humble_ has joined #openstack-nova | 08:26 | |
| markus_z | kashyap: https://bugs.launchpad.net/nova/+bug/1471167 | 08:26 |
| openstack | Launchpad bug 1471167 in OpenStack Compute (nova) "A volume attached one instance not working properly in K version" [Undecided,Incomplete] | 08:26 |
| kashyap | In my tests from last evening, this seems to work just fine. But, in Juno-based deployments, I've seen some bugs where the 'rebuild' doesn't succeed due to a possible race condition between Nova and Cinder | 08:26 |
| *** humble__ has quit IRC | 08:27 | |
| kashyap | In my tests on Git Master, i.e. And, I could reproduce it on Juno. | 08:27 |
| markus_z | oh, nevermind, that bug is about reboot, not rebuild | 08:27 |
| markus_z | kashyap: I do the test as you described. Takes a few minutes. | 08:28 |
| kashyap | markus_z: Take your time. | 08:29 |
| * kashyap notes - in 30 min I need to step out to do some paperwork here, will be back around 12 CET. | 08:29 | |
| *** humble_ has quit IRC | 08:31 | |
| *** humble_ has joined #openstack-nova | 08:31 | |
| BobBall | XenServer CI is broken | 08:32 |
| BobBall | Trying to understand why - but this is a very confusing one | 08:32 |
| *** humble_ has quit IRC | 08:32 | |
| *** humble_ has joined #openstack-nova | 08:33 | |
| kashyap | markus_z: Once your test is done, would be able to post your n-cpu.log and c-vol.log somewhere? Would like to compare w/ the results of my test. | 08:37 |
| kashyap | No rush. | 08:37 |
| *** garyk has quit IRC | 08:37 | |
| BobBall | dansmith, johnthetubaguy: I saw the discussions yesterday about a change breaking the XenAPI tests - Was that a change that was accepted? The XenServer CI is currently broken on every change and I'm very confused by the logs! :) | 08:37 |
| *** sudipto has joined #openstack-nova | 08:40 | |
| *** imcsk8 has quit IRC | 08:50 | |
| *** lucasagomes has joined #openstack-nova | 08:54 | |
| *** RuiChen has quit IRC | 08:55 | |
| *** RuiChen has joined #openstack-nova | 08:56 | |
| *** otter768 has joined #openstack-nova | 08:57 | |
| markus_z | @cores: There is a patch set with 2x+2 and W+1 but not yet merged, could you w it again? https://review.openstack.org/#/c/198934/ | 08:57 |
| ndipanov | markus_z, haha that's not how it works | 08:57 |
| markus_z | ndipanov: Oh, not? What do I have to do? I thought that this looks like a gate issue? | 08:58 |
| ndipanov | markus_z, you can check http://status.openstack.org/zuul/ to see where it is in the queue | 08:58 |
| markus_z | ndipanov: It doesn't appear in any of the queues | 08:59 |
| ndipanov | markus_z, hmm | 09:00 |
| markus_z | ndipanov: Does another "recheck" make sense? | 09:00 |
| ndipanov | maybe | 09:01 |
| *** otter768 has quit IRC | 09:01 | |
| ndipanov | see if it places it on a queue | 09:01 |
| markus_z | ndipanov: Ah, ok, it's in the check queue again. I'll wait and see. Thanks. I was sure I had to speak magic words only a core would know. | 09:02 |
| *** apuimedo has joined #openstack-nova | 09:06 | |
| venkat_p | HI | 09:07 |
| mnestratov | ndipanov: hi, clould you please look if you are ok with a new patchset https://review.openstack.org/#/c/204231/ | 09:08 |
| *** Ratnaker has joined #openstack-nova | 09:08 | |
| johnthetubaguy | BobBall: I haven't looked into that myself | 09:10 |
| Ratnaker | Do we have any subcommand to (nova list) to get a value from inside dict? | 09:10 |
| *** atuvenie has joined #openstack-nova | 09:10 | |
| johnthetubaguy | BobBall: did you find which change it was? | 09:10 |
| *** sachin has joined #openstack-nova | 09:15 | |
| markus_z | Ratnaker: I'm not sure I understand your question. Which value do you want? | 09:16 |
| BobBall | No idea, no | 09:16 |
| BobBall | I can't look further ATM - have pinged josh to see if he can help | 09:16 |
| BobBall | I'm on a critical path for an OpenStack demo next week | 09:16 |
| BobBall | Seems that we don't even try to create VMs | 09:16 |
| BobBall | nova-conductor says not enough hosts | 09:17 |
| BobBall | but nova-cpu doesn't even get a chance to start a VM | 09:17 |
| johnthetubaguy | BobBall: oh, did nova-compute fail to start? | 09:17 |
| BobBall | Nope - all running and sitting there waiting for things to do | 09:17 |
| BobBall | http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/26/156126/6/7934/index.html is an example failure if you have any thoughts | 09:18 |
| *** park_heijlong has joined #openstack-nova | 09:18 | |
| BobBall | No TRACE's in n-api or n-cpu | 09:18 |
| BobBall | or n-sch | 09:18 |
| BobBall | just n-cond saying not enough hosts | 09:18 |
| johnthetubaguy | BobBall: I really need to find someone else to take a look... but I will have a quick peak | 09:19 |
| BobBall | I wondered if the filter scheduler had changed but no code changes to the filter scheduler in the last few days that I can see | 09:19 |
| johnthetubaguy | BobBall: have you stopped the CI voting for the moment? | 09:19 |
| BobBall | yes I have | 09:19 |
| BobBall | I just wondered if you had any ideas from a conceptual high level :) | 09:20 |
| *** sachin has quit IRC | 09:20 | |
| BobBall | Cuz it doesn't seem to be a low level bug from what I can tell... | 09:20 |
| BobBall | I don't know what's changed recently at a high level but you might have heard something? :) | 09:20 |
| *** sayali has quit IRC | 09:21 | |
| johnthetubaguy | 2015-08-12 06:11:20.460 DEBUG nova.scheduler.filters.disk_filter [req-296c58b0-a685-41bf-8712-3b8a76e40f03 tempest-TestServerAdvancedOps-923907221 tempest-TestServerAdvancedOps-1856891645] (devstack, localhost.localdomain) ram:7675 disk:-13312 io_ops:0 instances:0 does not have 0 MB usable disk, it only has -13312.0 MB usable disk. | 09:21 |
| johnthetubaguy | seems like the disk usage is not being reported correctly | 09:21 |
| *** sachin has joined #openstack-nova | 09:22 | |
| BobBall | ohhh | 09:22 |
| johnthetubaguy | BobBall: https://github.com/openstack/nova/commit/e239060e41e208674701c80b15b8e754ce1c98cd | 09:23 |
| BobBall | yay | 09:23 |
| BobBall | thanks | 09:23 |
| *** exploreshaifali has quit IRC | 09:23 | |
| BobBall | I can take it from there | 09:23 |
| johnthetubaguy | BobBall: cool | 09:24 |
| johnthetubaguy | BobBall: I vote we just fix the disk reporting | 09:24 |
| Ratnaker | Markus: For ex: in nova list --fields name would return the names of the instancec. But if we want to get the health_value (which is inside health_status dict), is there any subcommand for the same? | 09:24 |
| johnthetubaguy | BobBall: bit if you revert this commit, in the CI, stuff should pass: https://github.com/openstack/nova/commit/6739df76ece9128e895bc13499ed8e3bf172d67e | 09:24 |
| johnthetubaguy | BobBall: i.e. add a config for the filter list | 09:24 |
| BobBall | Yes | 09:25 |
| BobBall | Well I'd rather revert the Nova change | 09:25 |
| BobBall | and make sure that nova cores dont approve changes that break 3rd party CIs | 09:25 |
| BobBall | XenServer CI clearly voted against this change | 09:25 |
| *** exploreshaifali has joined #openstack-nova | 09:25 | |
| johnthetubaguy | BobBall: not sure that makes sense in this case, it just exposing a valid bug in the driver | 09:25 |
| BobBall | The issue is that it's a nova change that was merged that specifically broke an existing driver without anyone mentioning it to the third party CI maintainers :) | 09:26 |
| BobBall | I don't think anyone could argue that was a valid thing to do | 09:26 |
| BobBall | Particularly as there is no investigation on the change in gerrit as to why xenserver was failing | 09:26 |
| BobBall | the CI was just ignored | 09:26 |
| johnthetubaguy | the real fix is to be very clear on how stable each third party CI system is, so people care about the votes more | 09:27 |
| BobBall | I would expect that all core reviewers understand the impact on third party CIs rather than just ignoring them | 09:27 |
| BobBall | XenServer CI is very stable | 09:27 |
| BobBall | I've not heard anyone suggesting otherwise | 09:27 |
| johnthetubaguy | right, but folks don't think that due to all the null votes | 09:27 |
| *** kmARC has quit IRC | 09:28 | |
| *** park_heijlong has quit IRC | 09:28 | |
| BobBall | I'd be very happy to look at any evidence that the XenServer CI is giving bad or null votes | 09:28 |
| johnthetubaguy | BobBall: its the zuul bug we spoke about before | 09:28 |
| BobBall | The zuul bug was affecting the libvirt+xen CI and was fixed a while ago | 09:29 |
| BobBall | XenServer CI does not use zuul | 09:29 |
| johnthetubaguy | true, people just read Xen though | 09:29 |
| BobBall | OK - but my argument is that we should expect all core reviewers to understand the differences between the CIs and which are stable | 09:29 |
| BobBall | so they don't just push through a change that breaks a stable CI and a stable driver | 09:30 |
| johnthetubaguy | thing is, its changing the scheduler, its easy to assume the drivers would all be fine with that | 09:30 |
| johnthetubaguy | anyways, we could do a fast revert if you wanted, I am just not sure thats the best approach here | 09:31 |
| openstackgerrit | sulochan-acharya proposed openstack/nova: xapi: ensure pv driver info is present prior to live-migration https://review.openstack.org/189731 | 09:31 |
| BobBall | Depends how much you want the XenServer CI to be voting :) | 09:31 |
| BobBall | I would definitely support a fast revert | 09:31 |
| BobBall | because I think it should be voting _now_ | 09:31 |
| BobBall | We can of course fix the filter as a matter of priority | 09:31 |
| BobBall | but it's likely to take a few days to fix + review to a point where it can be reviewed by cores | 09:32 |
| *** exploreshaifali has quit IRC | 09:32 | |
| *** exploreshaifali has joined #openstack-nova | 09:33 | |
| *** sayali has joined #openstack-nova | 09:33 | |
| johnthetubaguy | BobBall: but you can just tweak the config right, so its green while the fix merges? | 09:33 |
| markus_z | kashyap: I did the test, but with the image "cirros-0.3.4-x86_64-uec", if this is important. | 09:33 |
| *** ishant_ has joined #openstack-nova | 09:34 | |
| BobBall | Ah, maybe. Let me look into that. | 09:34 |
| markus_z | kashyap: I didn't get an error when I rebuilt the instance. | 09:34 |
| johnthetubaguy | BobBall: thats was I was saying above, its just this config you need to add: https://github.com/openstack/nova/commit/e239060e41e208674701c80b15b8e754ce1c98cd#diff-978b9f8734365934eaf8fbb01f11a7d7R54 | 09:34 |
| BobBall | Actually, that's hard to do | 09:34 |
| BobBall | Because we're running devstack-gate it geenrates the localrc etc | 09:34 |
| BobBall | Looking to see if the fitlers are configurable in d-g | 09:35 |
| BobBall | Seems that devstack doesn't support setting the filter at all | 09:35 |
| BobBall | So it's not possible to tweak the config in a CI | 09:36 |
| *** ishant has quit IRC | 09:36 | |
| abhishekk | johnthetubaguy: hi, mitaka directory is created under nova-specs, is it open to submit the specs for mitaka? should I move my specs for liberty/backlog to mitaka? | 09:38 |
| johnthetubaguy | abhishekk: mitaka is open, I would go straight there now | 09:38 |
| *** exploreshaifali_ has joined #openstack-nova | 09:38 | |
| johnthetubaguy | BobBall: can't you use something like this: https://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate-wrap.sh#n534 | 09:39 |
| *** exploreshaifali has quit IRC | 09:39 | |
| abhishekk | johnthetubaguy: thank you, I will move the specs to mitaka | 09:39 |
| *** danpb has joined #openstack-nova | 09:39 | |
| johnthetubaguy | BobBall: oh, actually, I think this is it: https://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate.sh#n495 | 09:41 |
| openstackgerrit | Bob Ball proposed openstack/nova: Revert "Include DiskFilter in the default list" https://review.openstack.org/211931 | 09:41 |
| BobBall | Can't use the localrc as I said because devstack does not have a way of setting the nova filters from localrc | 09:42 |
| *** Kennan2 is now known as Kennan | 09:42 | |
| BobBall | Might be able to hack something in the script - but that's very ugly | 09:42 |
| johnthetubaguy | BobBall: I thought devstack had a generic passthrough thingy | 09:42 |
| BobBall | only when using local.conf | 09:42 |
| BobBall | I didn't think that d-g supported local.conf | 09:43 |
| BobBall | Maybe it does | 09:43 |
| BobBall | e.g. https://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate.sh#n565 | 09:44 |
| BobBall | I can look at adding a local.conf or using the script for a custom hack in the XenServer CI; but I'd still argue that the nova change should never have been accepted and on that basis it should be quick reverted | 09:45 |
| johnthetubaguy | BobBall: we can fast revert it, just a fast fix would be preferable | 09:47 |
| markus_z | ndipanov: The patch set I mentioned earlier, which I thought is "stuck". It uses the "depends-on" to a patch set in "nova-specs". I didn't see that. JFYI | 09:47 |
| BobBall | I can get a fix within a week I suspect but I can't focus on it today because I'm on critical path for something else ATM | 09:48 |
| *** dikonoor has quit IRC | 09:48 | |
| *** jwcroppe has joined #openstack-nova | 09:49 | |
| *** Marga__ has joined #openstack-nova | 09:50 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova-specs: Improve performance of UnShelve API https://review.openstack.org/135387 | 09:51 |
| *** Marga_ has quit IRC | 09:52 | |
| *** IanGovett has joined #openstack-nova | 09:54 | |
| *** mdbooth has quit IRC | 09:55 | |
| *** moshele has quit IRC | 09:58 | |
| *** mdbooth has joined #openstack-nova | 10:01 | |
| *** rgerganov has joined #openstack-nova | 10:01 | |
| *** claudiub has quit IRC | 10:03 | |
| *** marzif has joined #openstack-nova | 10:05 | |
| *** jcoufal has joined #openstack-nova | 10:05 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Return v2 version info with v2 legacy compatible wrapper https://review.openstack.org/206930 | 10:07 |
| *** ig0r_ has joined #openstack-nova | 10:09 | |
| *** kmARC has joined #openstack-nova | 10:13 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: resize ploop disks with prl_disk_tool https://review.openstack.org/182390 | 10:17 |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 10:17 |
| *** sudipto_ has joined #openstack-nova | 10:18 | |
| *** claudiub has joined #openstack-nova | 10:19 | |
| *** jkraj has joined #openstack-nova | 10:19 | |
| *** exploreshaifali_ has quit IRC | 10:20 | |
| *** sudipto has quit IRC | 10:21 | |
| *** bole has joined #openstack-nova | 10:25 | |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extensions https://review.openstack.org/211258 | 10:25 |
| *** gszasz has quit IRC | 10:27 | |
| mnestratov | johnthetubaguy: hi! I recall that when I submitted https://blueprints.launchpad.net/nova/+spec/virtuozzo-instance-resize-support and | 10:28 |
| mnestratov | https://blueprints.launchpad.net/nova/+spec/ploop-snapshot-support someone said that they should have been bugfixes rather than blueprints | 10:28 |
| mnestratov | but I didn't pay much attention to it, though I should. Now when we missed deadline and our FFEs were rejected, is it possible to make these reviews bugfixes | 10:28 |
| mnestratov | and to have a chance to get them merged in this release cycle? | 10:28 |
| *** bole has left #openstack-nova | 10:29 | |
| kashyap | markus_z: Downloaded the logs, thank you. You can remove them, if you prefer. | 10:29 |
| johnthetubaguy | mnestratov: good question, I will take a quick look | 10:29 |
| *** lucasagomes has quit IRC | 10:30 | |
| *** jcoufal has quit IRC | 10:35 | |
| *** jwcroppe has quit IRC | 10:35 | |
| *** jwcroppe has joined #openstack-nova | 10:36 | |
| johnthetubaguy | mnestratov: so being honest, it looks like new functionality to me... This one is really tiny though, and seems like we could treat it as a bug: https://review.openstack.org/#/c/184153/4 | 10:36 |
| openstackgerrit | John Garbutt proposed openstack/nova: libvirt: support snapshots with parallels virt_type https://review.openstack.org/184153 | 10:37 |
| mnestratov | johnthetubaguy: cool, thanks a lot, I will file a bug then for this one? | 10:38 |
| johnthetubaguy | mnestratov: yeah, its worth attaching a wishlist bug for that one, I think | 10:39 |
| johnthetubaguy | mnestratov: its up to the folks that know the libvirt code, what they think is the best thing to do with it | 10:39 |
| *** jwcroppe has quit IRC | 10:40 | |
| BobBall | johnthetubaguy: Looks like maybe the filter actually works for XS. Don't understand how we are requesting a flavor of 0mb all the time but the disk reported might actually be 'correct' according to the filter | 10:41 |
| BobBall | The issue is that the SR has a virtual-allocation which is larger than the physical size | 10:41 |
| *** fawadk has quit IRC | 10:41 | |
| BobBall | As such the filter correctly excludes the host because in theory we might not be able to grow the disk to full size | 10:41 |
| johnthetubaguy | BobBall: 0 is the size of disk in the tiny flavor size, I think | 10:42 |
| BobBall | Oh, weird. Because it does actually have a disk | 10:42 |
| johnthetubaguy | BobBall: correct, it just means "default to size of glance image" | 10:42 |
| johnthetubaguy | BobBall: it does feels like changing the config is the correct way to go... | 10:43 |
| BobBall | Really not to me | 10:44 |
| johnthetubaguy | BobBall: I am clearly missing something then | 10:44 |
| BobBall | it should work but I don't get it | 10:45 |
| johnthetubaguy | BobBall: lets have a quick google hangout, maybe? | 10:45 |
| *** ig0r_ has quit IRC | 10:46 | |
| *** moshele has joined #openstack-nova | 10:48 | |
| *** kmartin has quit IRC | 10:48 | |
| *** exploreshaifali has joined #openstack-nova | 10:50 | |
| *** humble_ has quit IRC | 10:52 | |
| sdague | BobBall: one of the reasons XenServerCI is getting ignored is that it's not reporting in the standard way so it's not in the results rollup | 10:52 |
| BobBall | No point in having a hangout - I'm just trying to do more digging. It's not a high level question ATM just the technical. | 10:54 |
| *** ishant_ has quit IRC | 10:54 | |
| BobBall | Good point sdague. I'll make sure that's fixed in the next few weeks. My team is up and running now so we can actually commit to fixing that! | 10:54 |
| sdague | BobBall: it's the *only* CI that's voting which isn't, and there is another Xen system which does report, which I'm sure confuses things | 10:55 |
| *** alexpilotti has joined #openstack-nova | 10:55 | |
| BobBall | *nod* | 10:55 |
| *** ishant has joined #openstack-nova | 10:56 | |
| *** ishant has quit IRC | 10:56 | |
| johnthetubaguy | sdague: I forgot about that, but you are right, I mostly review with the CI toggled off these days | 10:56 |
| *** ishant has joined #openstack-nova | 10:57 | |
| johnthetubaguy | BobBall: well, I was offering to try speed up the process, just curious where the confusion is right now? | 10:57 |
| BobBall | On where the disk space is going | 10:57 |
| *** otter768 has joined #openstack-nova | 10:57 | |
| johnthetubaguy | alex_xu: got a concern about the version->version21 rename in here: https://review.openstack.org/#/c/211777/4 | 10:57 |
| BobBall | I have a VDI that I'm trying to track down ATM which is apparently 20G virtual size but only 4M physical utilisation | 10:58 |
| johnthetubaguy | BobBall: ah, gotcah, is that not the disk you add for the cinder volumes, or something like that? | 10:58 |
| BobBall | which is taking all the space on the SR | 10:58 |
| BobBall | Probably | 10:58 |
| *** IanGovett1 has joined #openstack-nova | 10:58 | |
| BobBall | Trying to track down where it's created though | 10:59 |
| sdague | johnthetubaguy: ok, so edleafe has WIPed - https://review.openstack.org/#/c/211356 which means it's blocked until he gets up, or I could make a trivial change and reset votes / tests and approve | 10:59 |
| *** ishant_ has joined #openstack-nova | 10:59 | |
| sdague | johnthetubaguy: I'm leaning on option 2 to get us moving | 10:59 |
| johnthetubaguy | sdague: oh, good point, I just +2ed step 2 | 11:00 |
| johnthetubaguy | sdague: its tempting | 11:00 |
| *** jcoufal has joined #openstack-nova | 11:00 | |
| sdague | ok, I'm going to just pull the trigger so we can start merging | 11:00 |
| *** IanGovett has quit IRC | 11:00 | |
| markus_z | kashyap: you're welcome | 11:00 |
| openstackgerrit | Sean Dague proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/211356 | 11:01 |
| *** jcoufal has quit IRC | 11:01 | |
| *** ishant__ has joined #openstack-nova | 11:01 | |
| *** jcoufal has joined #openstack-nova | 11:01 | |
| kashyap | markus_z: So, looking at your n-cpu.log, so the said test worked just fine for you. | 11:01 |
| *** otter768 has quit IRC | 11:02 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: support snapshots with parallels virt_type https://review.openstack.org/184153 | 11:02 |
| *** jcoufal has quit IRC | 11:02 | |
| *** mwagner_lap has quit IRC | 11:02 | |
| *** ishant has quit IRC | 11:02 | |
| *** jcoufal has joined #openstack-nova | 11:02 | |
| *** tobe_ has quit IRC | 11:03 | |
| *** zhenguo has quit IRC | 11:03 | |
| *** tobe_ has joined #openstack-nova | 11:04 | |
| *** lyanchih has quit IRC | 11:04 | |
| *** ishant_ has quit IRC | 11:05 | |
| *** oomichi has quit IRC | 11:05 | |
| sdague | johnthetubaguy: ok, I triggered new test runs, and +A | 11:05 |
| *** markus_z has quit IRC | 11:05 | |
| johnthetubaguy | sdague: sweet, looks like the v3 move might have a few minor gremlins | 11:06 |
| *** tobe_ has quit IRC | 11:09 | |
| BobBall | Fantastic. Looks like devstack deprecated support for the backing volumes, so we were creating one and setting VOLUME_BACKING_DEVICE but actually devstack was creating a backing file anyway and so not using the VOLUME_BACKING_DEVICE | 11:10 |
| johnthetubaguy | BobBall: ouch | 11:10 |
| * BobBall is surprised it was working at all | 11:11 | |
| BobBall | volume backing file was 24G but there is only 16G available in the domu | 11:11 |
| BobBall | Anyway - I think we can remove the volume-backing-device | 11:11 |
| alex_xu | johnthetubaguy: it won't affect any config, because at line 154 of https://review.openstack.org/#/c/211777/4/setup.cfg will still call it as versions | 11:12 |
| BobBall | Just can't figure out where VOLUME_BACKING_DEVICE is set... | 11:12 |
| johnthetubaguy | alex_xu: ah, sweet, just reading that one, why did we drop it from the list? | 11:13 |
| alex_xu | johnthetubaguy: but I'm not sure why this patch remove versions from core list. I didn't change it because the core list is meanless anymore, we will remove core api list when remove extension | 11:13 |
| alex_xu | johnthetubaguy: I think I can add versions back to the list | 11:13 |
| johnthetubaguy | alex_xu: cool, I am a +2 after thats done | 11:13 |
| *** gszasz has joined #openstack-nova | 11:13 | |
| alex_xu | johnthetubaguy: cool, let me update now | 11:13 |
| BobBall | Found it *sigh* | 11:13 |
| johnthetubaguy | alex_xu: oh, sorry, there was one more thing, I added comments | 11:14 |
| johnthetubaguy | alex_xu: this bit doesn't seem right: https://review.openstack.org/#/c/211777/4/nova/hacking/checks.py,cm | 11:14 |
| *** jcoufal has quit IRC | 11:15 | |
| johnthetubaguy | alex_xu: in a related point, I wasn't quite sure about why these changes were included: https://review.openstack.org/#/c/211777/4/nova/network/security_group/neutron_driver.py,cm | 11:15 |
| * alex_xu is checking | 11:15 | |
| alex_xu | johnthetubaguy: I think all the comment make sense. let me fix it | 11:16 |
| *** haomaiwang has quit IRC | 11:19 | |
| johnthetubaguy | alex_xu: awesome thank you, I just gave step4 a +2, that looks good | 11:19 |
| alex_xu | johnthetubaguy: thanks! | 11:19 |
| *** markus_z has joined #openstack-nova | 11:21 | |
| *** marcusvrn has joined #openstack-nova | 11:28 | |
| *** baoli has joined #openstack-nova | 11:33 | |
| *** IanGovett1 has quit IRC | 11:33 | |
| *** tobe_ has joined #openstack-nova | 11:33 | |
| *** IanGovett has joined #openstack-nova | 11:33 | |
| *** baoli has quit IRC | 11:35 | |
| *** baoli has joined #openstack-nova | 11:35 | |
| *** thorst has joined #openstack-nova | 11:37 | |
| *** tobe_ has quit IRC | 11:39 | |
| *** sudipto_ has quit IRC | 11:40 | |
| *** Marga__ has quit IRC | 11:40 | |
| *** Marga_ has joined #openstack-nova | 11:41 | |
| *** matrohon has joined #openstack-nova | 11:41 | |
| *** chhavi has joined #openstack-nova | 11:41 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move v2.1 code to the main compute directory - remove v3 step3 https://review.openstack.org/211777 | 11:44 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove 'v3' direcotry for v2.1 json-schemas - remove v3 step4 https://review.openstack.org/211846 | 11:44 |
| alex_xu | johnthetubaguy: sdague ^ | 11:44 |
| sdague | alex_xu: thanks, will look shortly, need another cup of coffee | 11:44 |
| alex_xu | sdague: thanks | 11:44 |
| * alex_xu rush to take a bath for baby | 12:00 | |
| *** Sree has quit IRC | 12:02 | |
| *** lucasagomes has joined #openstack-nova | 12:07 | |
| *** tellesnobrega_ has joined #openstack-nova | 12:08 | |
| *** VW_ has joined #openstack-nova | 12:11 | |
| *** diogogmt has joined #openstack-nova | 12:11 | |
| *** dave-mccowan has quit IRC | 12:12 | |
| *** markus_z has quit IRC | 12:13 | |
| openstackgerrit | jichenjc proposed openstack/nova: Catch OverQuota in volume create function https://review.openstack.org/173985 | 12:14 |
| *** markus_z has joined #openstack-nova | 12:14 | |
| *** shunliz_ has quit IRC | 12:15 | |
| *** tellesnobrega_ has quit IRC | 12:16 | |
| *** rotbeard has joined #openstack-nova | 12:20 | |
| *** deepakcs has quit IRC | 12:21 | |
| *** aysyd has joined #openstack-nova | 12:23 | |
| *** diogogmt has quit IRC | 12:24 | |
| johnthetubaguy | alex_xu: taking another look for you now | 12:24 |
| alex_xu | johnthetubaguy: thanks, I will be there | 12:25 |
| *** raildo-afk is now known as raildo | 12:26 | |
| johnthetubaguy | alex_xu: so thats way better, thank you, I did spot this though: https://review.openstack.org/#/c/211777/5/nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py,cm | 12:29 |
| *** IanGovett1 has joined #openstack-nova | 12:29 | |
| alex_xu | johnthetubaguy: yea, I missed that | 12:30 |
| *** IanGovett has quit IRC | 12:30 | |
| *** erlon has joined #openstack-nova | 12:31 | |
| *** bapalm has joined #openstack-nova | 12:31 | |
| *** liusheng has quit IRC | 12:31 | |
| *** Ratnaker has quit IRC | 12:31 | |
| johnthetubaguy | alex_xu: I am happy to do that little fix if you need to do the bath? | 12:33 |
| alex_xu | johnthetubaguy: the bath already done, I'm updating the patch now | 12:34 |
| *** ishant__ has quit IRC | 12:34 | |
| johnthetubaguy | alex_xu: thats impressive bathing skill, thank you! | 12:34 |
| *** Kevin_Zheng_ has quit IRC | 12:35 | |
| alex_xu | johnthetubaguy: heh :) | 12:35 |
| *** bnemec has joined #openstack-nova | 12:35 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move v2.1 code to the main compute directory - remove v3 step3 https://review.openstack.org/211777 | 12:35 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove 'v3' direcotry for v2.1 json-schemas - remove v3 step4 https://review.openstack.org/211846 | 12:35 |
| alex_xu | johnthetubaguy: done ^ | 12:36 |
| *** rfolco has joined #openstack-nova | 12:37 | |
| *** mdrabe has joined #openstack-nova | 12:37 | |
| johnthetubaguy | alex_xu: so we have a merge conflict, somehow, but otherwise, its looking good | 12:39 |
| johnthetubaguy | alex_xu: oh, funny, look what just merged: https://github.com/openstack/nova/commit/2e2c710989dd88c022af7d96d06ad45e8a293813 | 12:40 |
| alex_xu | johnthetubaguy: hmm... | 12:41 |
| *** edmondsw has joined #openstack-nova | 12:41 | |
| alex_xu | johnthetubaguy: another one may trigger conflict https://review.openstack.org/#/c/198934/ | 12:42 |
| johnthetubaguy | alex_xu: its OK, the spec has not merged yet | 12:43 |
| johnthetubaguy | alex_xu: we can win, I thjink | 12:44 |
| *** alexpilotti has quit IRC | 12:44 | |
| alex_xu | johnthetubaguy: ha, there is depend-on flag | 12:44 |
| *** alexpilotti has joined #openstack-nova | 12:45 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move v2.1 code to the main compute directory - remove v3 step3 https://review.openstack.org/211777 | 12:45 |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 - step 2 https://review.openstack.org/211390 | 12:45 |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/211356 | 12:45 |
| openstackgerrit | Alex Xu proposed openstack/nova: Remove 'v3' direcotry for v2.1 json-schemas - remove v3 step4 https://review.openstack.org/211846 | 12:45 |
| *** jcoufal has joined #openstack-nova | 12:46 | |
| *** jcoufal has quit IRC | 12:46 | |
| *** jcoufal has joined #openstack-nova | 12:46 | |
| alex_xu | johnthetubaguy: ^ the first patch need approve again | 12:47 |
| *** Nikolay_St has quit IRC | 12:49 | |
| *** busterswt has joined #openstack-nova | 12:50 | |
| alex_xu | edleafe: I moved original step5 to step7 https://etherpad.openstack.org/p/remove_v3 , because I think original step5 just a set of small thing, let's focus main thing | 12:53 |
| *** irenab has quit IRC | 12:53 | |
| openstackgerrit | sulochan-acharya proposed openstack/nova: xapi: ensure pv driver info is present prior to live-migration https://review.openstack.org/189731 | 12:54 |
| johnthetubaguy | alex_xu: taking a look now | 12:54 |
| johnthetubaguy | edleafe: added some ideas on your logging patch, it looks super close now: https://review.openstack.org/#/c/192184/4 | 12:54 |
| *** IanGovett has joined #openstack-nova | 12:55 | |
| *** ankit_ag has quit IRC | 12:56 | |
| *** IanGovett1 has quit IRC | 12:56 | |
| *** VW_ has quit IRC | 12:56 | |
| *** VW_ has joined #openstack-nova | 12:56 | |
| *** rlrossit has joined #openstack-nova | 12:56 | |
| *** chhavi has quit IRC | 12:57 | |
| *** otter768 has joined #openstack-nova | 12:58 | |
| johnthetubaguy | sdague: edleafe: the main bits of the v3 move looks ready from what I can see: https://review.openstack.org/#/c/211777 | 12:59 |
| *** josecastroleon has quit IRC | 12:59 | |
| sdague | ok, let me go through them | 13:00 |
| sdague | was fighting with our newly activated post/split expense system. Splitting a large IT company in half, turns out to have some bumps :) | 13:00 |
| edleafe | Good UGT morning, all! | 13:00 |
| *** VW_ has quit IRC | 13:01 | |
| * edleafe goes over the recent v3 changes | 13:01 | |
| *** nelsnelson has joined #openstack-nova | 13:01 | |
| johnthetubaguy | edleafe: was looking at your scheduler logging patch, I think its very close, added some ideas about reducing how much gets logged, in the hope there is a middle ground | 13:02 |
| sdague | alex_xu: we're going to eventually rename the entry point names as well, right? | 13:02 |
| *** nelsnelson has joined #openstack-nova | 13:02 | |
| sdague | https://review.openstack.org/#/c/211777/7/setup.cfg,cm - the left hand side of those | 13:02 |
| edleafe | sdague: we've been avoiding changing too much in the code, e.g., v3 references | 13:03 |
| *** otter768 has quit IRC | 13:03 | |
| edleafe | sdague: right now the focus is simply on the directory structure | 13:03 |
| sdague | ok, that's fine for now | 13:03 |
| openstackgerrit | venkatesh proposed openstack/nova: make the driver.Scheduler as abstract class https://review.openstack.org/212016 | 13:03 |
| sdague | ok, +A on the whole stack | 13:03 |
| johnthetubaguy | yeah, that feels consistent | 13:03 |
| johnthetubaguy | sdague: :D | 13:04 |
| *** josecastroleon has joined #openstack-nova | 13:04 | |
| sdague | alex_xu: thanks very much for digging in here | 13:04 |
| edleafe | sdague: FWIW, that's why we chose 'Partial-bug' in the commit message - there will be more cleanup work to do after | 13:04 |
| sdague | yep, that's fine | 13:04 |
| johnthetubaguy | edleafe: alex_xu: I guess the next bit is moving the tests, following the same pattern of three/four changes? | 13:04 |
| sdague | this is the painful part | 13:04 |
| venkat_p | Hi all | 13:04 |
| venkat_p | Please review the following change | 13:05 |
| venkat_p | https://review.openstack.org/212016 | 13:05 |
| sdague | internal changes like the entry point names won't be merge conflict tar pits | 13:05 |
| johnthetubaguy | sdague: +1 thats the bit I saw as a release blocker | 13:05 |
| edleafe | johnthetubaguy: yes: https://etherpad.openstack.org/p/remove_v3 | 13:05 |
| *** sudipto_ has joined #openstack-nova | 13:05 | |
| edleafe | Do we care very much about the commit message in https://review.openstack.org/#/c/211846/? There are spelling and line length problems | 13:06 |
| *** venkat_p has quit IRC | 13:06 | |
| edleafe | Or can we just let it slide? | 13:06 |
| sdague | edleafe: I'd let it slide | 13:07 |
| johnthetubaguy | although, I mean if you fix it now, we can just reapply our votes | 13:07 |
| johnthetubaguy | but yeah, its not terrible | 13:07 |
| *** jecarey has joined #openstack-nova | 13:07 | |
| johnthetubaguy | edleafe: yeah, the etherpad seems good, I guess you are thinking three separate patches for those test changes? | 13:09 |
| *** lyanchih has joined #openstack-nova | 13:10 | |
| *** jwcroppe has joined #openstack-nova | 13:10 | |
| edleafe | johnthetubaguy: yes, that seems like it'll be right | 13:11 |
| *** ferest has joined #openstack-nova | 13:11 | |
| edleafe | johnthetubaguy: so about the commit message: I already have it corrected; do you want me to update and then you guys re-approve? | 13:11 |
| johnthetubaguy | edleafe: I am good with that | 13:13 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove 'v3' directory for v2.1 json-schemas https://review.openstack.org/211846 | 13:13 |
| edleafe | johnthetubaguy: sdague: ^ Done | 13:13 |
| *** ferest has quit IRC | 13:14 | |
| johnthetubaguy | cool, I added +2, will let sdague +2+W it | 13:14 |
| *** obondarev has quit IRC | 13:15 | |
| *** snikitin has quit IRC | 13:15 | |
| *** pkholkin has quit IRC | 13:15 | |
| *** tdurakov has quit IRC | 13:15 | |
| *** apuimedo has quit IRC | 13:16 | |
| *** chuckcarmack has joined #openstack-nova | 13:17 | |
| *** chhavi has joined #openstack-nova | 13:18 | |
| *** Sree has joined #openstack-nova | 13:19 | |
| sdague | done | 13:19 |
| *** mwagner_lap has joined #openstack-nova | 13:19 | |
| *** dustins has joined #openstack-nova | 13:19 | |
| *** xyang1 has joined #openstack-nova | 13:21 | |
| *** irenab has joined #openstack-nova | 13:21 | |
| *** tdurakov has joined #openstack-nova | 13:23 | |
| *** jwcroppe has quit IRC | 13:23 | |
| *** pkholkin has joined #openstack-nova | 13:23 | |
| *** snikitin has joined #openstack-nova | 13:23 | |
| *** lyanchih has quit IRC | 13:23 | |
| *** jwcroppe has joined #openstack-nova | 13:23 | |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: resize ploop disks with prl_disk_tool https://review.openstack.org/182390 | 13:23 |
| openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 13:23 |
| *** edmondsw has quit IRC | 13:24 | |
| *** ujjain has quit IRC | 13:25 | |
| *** jcoufal has quit IRC | 13:25 | |
| *** jwcroppe has quit IRC | 13:27 | |
| *** mriedem has joined #openstack-nova | 13:29 | |
| *** ijuwang has joined #openstack-nova | 13:29 | |
| openstackgerrit | jichenjc proposed openstack/nova: Cleanup HTTPRequest for security_groups test https://review.openstack.org/182630 | 13:30 |
| *** lyanchih has joined #openstack-nova | 13:33 | |
| johnthetubaguy | sdague: I remember I had to approve a blueprint for the API work, did we get that created now? is it this one? https://blueprints.launchpad.net/nova/+spec/nova-api-remove-extensions | 13:34 |
| edleafe | johnthetubaguy: responded to your comments: https://review.openstack.org/#/c/192184 | 13:34 |
| *** VW_ has joined #openstack-nova | 13:34 | |
| *** mdrabe_ has joined #openstack-nova | 13:34 | |
| johnthetubaguy | edleafe: I don't understand the comment really | 13:34 |
| johnthetubaguy | edleafe: I am basically saying the most important bit is the list of hosts just before your list goes to zero, usually | 13:35 |
| johnthetubaguy | edleafe: logging the counts for all the other filters is usually enough of a hint | 13:35 |
| *** zzzeek has joined #openstack-nova | 13:36 | |
| edleafe | johnthetubaguy: so ops would be ok not knowing which filter removed HostX, unless it was the last one? | 13:36 |
| sdague | johnthetubaguy: yeh, that's the blueprint to approve | 13:36 |
| sdague | then we mostly need to wrangle all the right bits there | 13:36 |
| johnthetubaguy | edleafe: not usually, the count is often all you need to know | 13:36 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from Flavor object https://review.openstack.org/212026 | 13:37 |
| edleafe | johnthetubaguy: ok. It was explained to me very differently at the summit | 13:37 |
| *** mdrabe has quit IRC | 13:37 | |
| *** ctrath has joined #openstack-nova | 13:40 | |
| edleafe | alex_xu: still around? | 13:42 |
| *** jaypipes has joined #openstack-nova | 13:42 | |
| alex_xu | edleafe: I'm here | 13:43 |
| *** abhishekk has quit IRC | 13:44 | |
| sdague | johnthetubaguy: so is your concern that there are 1000 hosts, and the last filter removes all them? Then we log 1000 hosts? | 13:45 |
| edleafe | alex_xu: about the changes to 'common.raise_feature_not_supported()' - I couldn't get pep8 to pass without that. | 13:45 |
| edleafe | alex_xu: I don't know why it started failing on that patch set | 13:45 |
| sdague | because I do think knowing which hosts were attempted and dropped in that last set is important | 13:46 |
| rlrossit | dansmith: I found this: https://review.openstack.org/#/c/212030/ | 13:46 |
| alex_xu | edleafe: it because this https://review.openstack.org/#/c/211777/7/nova/hacking/checks.py | 13:46 |
| alex_xu | edleafe: that tests only apply to v2.1 | 13:46 |
| sdague | though it would be fine to have a host list object which stringified to Total count, the first 10 hostnames | 13:46 |
| dansmith | rlrossit: mm, yeah | 13:47 |
| alex_xu | edleafe: after we move the directory, the check at line 516 is broke | 13:47 |
| rlrossit | dansmith: I'm contemplating if I want to add unit tests to that one, or if you trust me, I will add plenty of unit tests to that do_backport function in my bigger patch | 13:47 |
| edleafe | alex_xu: ok - it did seem strange. I thought perhaps a change to the hacking rules merged | 13:48 |
| alex_xu | johnthetubaguy: edleafe, yea, the next step is unittest, I wrote some note at etherpad at step5 https://etherpad.openstack.org/p/remove_v3 | 13:48 |
| edleafe | alex_xu: thanks - I'll work on that today | 13:49 |
| dansmith | rlrossit: well, I kinda think this should have a test with it, and it should be really small, right? | 13:49 |
| alex_xu | edleafe: thanks! | 13:49 |
| rlrossit | dansmith: yeah, it will just require patching a bunch of stuff | 13:50 |
| dansmith | rlrossit: we probably need to make sure we get a o.vo release fairly soon so we can actually implement this multi backport thing in nova | 13:50 |
| rlrossit | dansmith: I will go as fast as I can :) | 13:50 |
| *** tsekiyama has joined #openstack-nova | 13:50 | |
| dansmith | rlrossit: should be mostly just like the test I wrote for the non-list case though right? | 13:50 |
| *** links has quit IRC | 13:51 | |
| *** chhavi has quit IRC | 13:51 | |
| rlrossit | dansmith: well.... you don't really test if the backport function is using the manifest function | 13:51 |
| *** chhavi has joined #openstack-nova | 13:51 | |
| dansmith | oh/ | 13:51 |
| * dansmith looks | 13:51 | |
| dansmith | dims did kinda merge that before I was ready :) | 13:52 |
| *** edmondsw has joined #openstack-nova | 13:52 | |
| openstackgerrit | jichenjc proposed openstack/nova: Return HTTPForbidden if over quota https://review.openstack.org/180469 | 13:53 |
| dansmith | rlrossit: oh, I see what you mean | 13:53 |
| dansmith | rlrossit: how about I write a test for this and you can use it to write one for yours? | 13:53 |
| *** Piet has quit IRC | 13:54 | |
| *** VW__ has joined #openstack-nova | 13:54 | |
| rlrossit | dansmith: sure | 13:54 |
| *** diogogmt has joined #openstack-nova | 13:55 | |
| *** diogogmt has quit IRC | 13:55 | |
| *** annegentle has joined #openstack-nova | 13:56 | |
| *** VW_ has quit IRC | 13:57 | |
| *** jistr is now known as jistr|mtg | 13:57 | |
| *** ctrath has quit IRC | 13:58 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: ironic: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189362 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: convert config drive to use ImageMeta object https://review.openstack.org/189323 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188119 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: make instance compulsory in blockinfo APIs https://review.openstack.org/188118 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: hyperv: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189302 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 13:58 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: xenapi: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188790 | 13:58 |
| *** VW__ has quit IRC | 13:59 | |
| *** VW_ has joined #openstack-nova | 14:00 | |
| *** mriedem has quit IRC | 14:01 | |
| *** dave-mccowan has joined #openstack-nova | 14:01 | |
| *** VW_ has quit IRC | 14:02 | |
| *** burt has joined #openstack-nova | 14:02 | |
| *** tsekiyama has quit IRC | 14:03 | |
| *** VW_ has joined #openstack-nova | 14:03 | |
| openstackgerrit | jichenjc proposed openstack/nova: Catch invalid id input in service_delete https://review.openstack.org/198753 | 14:03 |
| *** thangp has joined #openstack-nova | 14:04 | |
| dansmith | rlrossit: that actually fixes a bug | 14:04 |
| dansmith | hmm, I think | 14:04 |
| dansmith | yeah | 14:05 |
| rlrossit | dansmith: which bug? | 14:06 |
| *** mriedem has joined #openstack-nova | 14:06 | |
| dansmith | rlrossit: it passes version_manifest to obj_make_compatible(), which isn't valid | 14:07 |
| *** chhavi has quit IRC | 14:07 | |
| rlrossit | dansmith: yeah that's what made me think this wasn't tested because that would give a kw error | 14:07 |
| dansmith | cha | 14:07 |
| *** chhavi has joined #openstack-nova | 14:07 | |
| *** rushil has joined #openstack-nova | 14:12 | |
| *** sudipto_ has quit IRC | 14:12 | |
| dansmith | rlrossit: just pushed a revision and a patch underneath.. what do you think? | 14:13 |
| rlrossit | dansmith: I'm currently being mesmerized listening to mriedem talk, I'll look when he's done | 14:13 |
| dansmith | sure | 14:14 |
| *** yamahata has joined #openstack-nova | 14:14 | |
| *** thumpba has joined #openstack-nova | 14:15 | |
| *** Sree__ has joined #openstack-nova | 14:15 | |
| *** garyk has joined #openstack-nova | 14:16 | |
| *** Sree has quit IRC | 14:18 | |
| *** tpeoples has joined #openstack-nova | 14:18 | |
| sdague | edleafe: 211777 failed one of the unit tests around hacking rules enforcement | 14:18 |
| sdague | you up for respinning that, or should I? | 14:18 |
| edleafe | sdague: I can grab it | 14:19 |
| sdague | nova.tests.unit.test_hacking.HackingTestCase.test_check_http_not_implemented is the thing that failed | 14:19 |
| edleafe | sdague: ok, I know what that one is | 14:20 |
| *** xyang2 has joined #openstack-nova | 14:20 | |
| sdague | console log in case it's useful - http://logs.openstack.org/77/211777/7/check/gate-nova-python27/a0ba6eb/console.html#_2015-08-12_13_03_23_661 | 14:21 |
| *** lyanchih has quit IRC | 14:23 | |
| *** Sree__ has quit IRC | 14:24 | |
| garyk | johnthetubaguy: do you have a few minutes to discuss https://review.openstack.org/#/c/165750/? | 14:24 |
| *** Sree has joined #openstack-nova | 14:24 | |
| johnthetubaguy | garyk: yes | 14:25 |
| garyk | johnthetubaguy: this patch is required to support the neutron plugin that we are working on in Liberty. This is near completion in Neutron and needs a few tweaks in the Nova code. | 14:26 |
| garyk | origianlly i opened this as a bug as this was what we suspected when we started to test a few months ago. | 14:26 |
| garyk | a few days ago matt asked me to open a BP and that was after the deadline | 14:26 |
| garyk | my concern is that the neutron plugin is going to land in liberty and the nova code will noe | 14:26 |
| garyk | this code is really self contained within the driver | 14:27 |
| *** Sree has quit IRC | 14:27 | |
| johnthetubaguy | at this point, the nova code will not land | 14:27 |
| garyk | what do you suggest here? | 14:27 |
| garyk | ok. | 14:27 |
| *** Sree has joined #openstack-nova | 14:27 | |
| garyk | it puts us between a rock and a hard place for people wanting to use the liberty driver | 14:28 |
| johnthetubaguy | garyk: I know its frustraighting, but we need to focus on bug fixes and priorities now, we are struggling with the review load in all areas, this is the only tool we have to try and distribute that right now :( | 14:28 |
| *** shunliz has joined #openstack-nova | 14:29 | |
| johnthetubaguy | garyk: as mentioned at the summit, midcycle and ML, I want us to move to a kanban model, where we could easily include these kinds of things, and delegate the review slots to the subteams, so you can make the right decisions for your plugin, etc | 14:29 |
| johnthetubaguy | garyk: right now we have the tooling of a big sledge hammer, so to be fair, its got to be exceptional to make exceptions (mostly in a customer will see a regression, or similar) | 14:30 |
| *** mtanino has joined #openstack-nova | 14:30 | |
| garyk | johnthetubaguy: a customer here will not be able to use openstack here with stable/liberty. not only is the frustrating for them but it will enatil that they patch the code locally to get this up and running. | 14:31 |
| garyk | in all fairness the patch was added in march before the summit so i was certain that it would land in L | 14:32 |
| *** Sree has quit IRC | 14:32 | |
| johnthetubaguy | garyk: agreed, and I think thats true for the other 20-30 blueprints (if my memory is correct) that got blocked due to review bandwidth | 14:32 |
| garyk | i guess i was wrong. i understand the average x days for a review, but 6 months was a little over :) | 14:32 |
| *** ildikov has quit IRC | 14:33 | |
| *** yamahata has quit IRC | 14:33 | |
| *** Murali_ has quit IRC | 14:35 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Move v2.1 code to the main compute directory - remove v3 step3 https://review.openstack.org/211777 | 14:35 |
| edleafe | sdague: ^ should be fixed | 14:35 |
| sdague | edleafe: thanks | 14:37 |
| sdague | need to rebase the patch on top of it? | 14:37 |
| edleafe | sdague: lemme check | 14:37 |
| *** jistr|mtg is now known as jistr | 14:38 | |
| *** chhavi has quit IRC | 14:38 | |
| edleafe | sdague: that patch didn't touch that file, so it should be good, but gonna run the tests anyway | 14:38 |
| sdague | edleafe: great, thanks | 14:38 |
| *** cfriesen_ has joined #openstack-nova | 14:39 | |
| *** chhavi has joined #openstack-nova | 14:39 | |
| *** thedodd has joined #openstack-nova | 14:39 | |
| *** mdrabe_ has quit IRC | 14:39 | |
| *** mdrabe_ has joined #openstack-nova | 14:40 | |
| *** mdrabe_ has quit IRC | 14:40 | |
| *** mdrabe_ has joined #openstack-nova | 14:41 | |
| johnthetubaguy | garyk: I have a lot of hope for the etherpad to help focus the review: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 14:41 |
| *** gszasz has quit IRC | 14:41 | |
| *** annegentle has quit IRC | 14:41 | |
| *** exploreshaifali has quit IRC | 14:42 | |
| johnthetubaguy | garyk: it was missing a blueprint, which would have helped it get some review, in theory, being trying to write up those kinds of tips here: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule#How_can_I_get_my_code_merged_faster.3F | 14:42 |
| *** mriedem1 has joined #openstack-nova | 14:43 | |
| *** mriedem has quit IRC | 14:44 | |
| *** afazekas has quit IRC | 14:44 | |
| *** Piet has joined #openstack-nova | 14:45 | |
| garyk | johnthetubaguy: will try better in the M cycle. | 14:45 |
| openstackgerrit | Matthew Booth proposed openstack/nova: Don't check flavor disk size when booting from volume https://review.openstack.org/204635 | 14:47 |
| johnthetubaguy | garyk: I hope everyone reviews more of the things in that etherpad | 14:47 |
| johnthetubaguy | garyk: and that we can get people to review more code | 14:47 |
| *** chhavi has quit IRC | 14:48 | |
| johnthetubaguy | garyk: please, is there any chance you could fill up the VMware section with some of the most important bugs for VMware: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 14:49 |
| openstackgerrit | Ed Leafe proposed openstack/nova: Remove 'v3' directory for v2.1 json-schemas https://review.openstack.org/211846 | 14:49 |
| johnthetubaguy | garyk: I want people to have a good reason to keep looking in there, so we get in the habbit for when its time to get all the features back up for review | 14:49 |
| edleafe | sdague: rebased step 4 and pushed | 14:50 |
| *** tonytan4ever has joined #openstack-nova | 14:50 | |
| mriedem1 | garyk: it's not fair to use https://review.openstack.org/#/c/165750/ being up since march as a cudgel | 14:50 |
| garyk | johnthetubaguy: when i get back from my vacation will do that. the problem is that the patches that we wanted there are all blocked and the bug fixes are not getting reviewed. | 14:50 |
| mriedem1 | garyk: that's obviously a feature add with a cross repo dependency | 14:50 |
| mriedem1 | garyk: and no one from the vmware team was reviewing it for that long | 14:51 |
| garyk | mriedem1: not sure what cudge is? | 14:51 |
| *** dannywilson has joined #openstack-nova | 14:51 | |
| *** tsekiyama has joined #openstack-nova | 14:51 | |
| mriedem1 | "a short thick stick used as a weapon" | 14:51 |
| garyk | ok, thanks | 14:51 |
| garyk | mriedem1: the fact that no one from the team was reviewing it is an issue. | 14:52 |
| mriedem1 | and it's not a bug that neutron added a feature that nova isn't using | 14:52 |
| openstackgerrit | Baodong (Robert) Li proposed openstack/nova: Handle port delete initiated by neutron https://review.openstack.org/179390 | 14:52 |
| garyk | mriedem1: when one develops a plugin they usualyy test it with nova. correct? | 14:52 |
| garyk | we needed to make changes to the driver to get instances spawned correctly for the VC support | 14:53 |
| garyk | mriedem1: at the end of the day it is my fault. | 14:53 |
| garyk | so the question is how can we address this in the future. | 14:53 |
| mriedem1 | garyk: that's part of the bp process then when working on the thing | 14:54 |
| mriedem1 | which is totally fine, but don't call it a bug | 14:54 |
| garyk | 1. we will get vmware reviewrs to review. problem is getting your trust. | 14:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Fix the peer review link in the 'Patches and Reviews' policy section https://review.openstack.org/212056 | 14:54 |
| garyk | 2. we will darft BP's. problem is hoping to get enough priority to get stuff in. | 14:54 |
| garyk | other than that is is more of the same. | 14:54 |
| *** jdandrea has joined #openstack-nova | 14:54 | |
| *** vilobhmm has joined #openstack-nova | 14:54 | |
| garyk | mriedem1: did i write on the review that it is a bug? | 14:55 |
| mriedem1 | "(9:26:32 AM) garyk: origianlly i opened this as a bug as this was what we suspected when we started to test a few months ago." | 14:55 |
| johnthetubaguy | garyk: OK, after vacation is totally the correct call, the bug fixes are not on the etherpad though, I am hoping when they get added there they will get reviewed | 14:56 |
| garyk | mriedem1: now in my defense when we started to test that we saw that 2 neutron ports were bing created. is that a bug? | 14:56 |
| garyk | anyways, it is my fault and i will make sure that my descriptions are better | 14:56 |
| mriedem1 | baoli: +2 on https://review.openstack.org/#/c/179390/ now - melwitt, want to look at that again? | 14:56 |
| *** diogogmt has joined #openstack-nova | 14:57 | |
| garyk | mriedem1: so basically i hope that whatever we do will make the process more efficient and effective. | 14:57 |
| *** browne has joined #openstack-nova | 14:58 | |
| mriedem1 | agreed | 14:59 |
| *** otter768 has joined #openstack-nova | 14:59 | |
| *** patrickeast has joined #openstack-nova | 15:00 | |
| *** jdandrea has left #openstack-nova | 15:00 | |
| baoli | mriedem1: thanks | 15:01 |
| *** mhorban has joined #openstack-nova | 15:02 | |
| johnthetubaguy | garyk: been adding notes trying to officially encourage more reviews, I hope that helps a little: https://wiki.openstack.org/wiki/Nova/Mentoring#Why_do_code_reviews_if_I_am_not_in_nova-core.3F | 15:02 |
| *** alexpilotti has quit IRC | 15:03 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: ScalityVolume:fix how remote FS mount is detected https://review.openstack.org/210468 | 15:03 |
| *** diogogmt has quit IRC | 15:03 | |
| *** diogogmt has joined #openstack-nova | 15:04 | |
| *** otter768 has quit IRC | 15:04 | |
| *** chhavi has joined #openstack-nova | 15:04 | |
| mriedem1 | tonyb: did you ever get a change up for that juno large ops thing? | 15:04 |
| *** DuncanT has quit IRC | 15:05 | |
| *** BadCub has quit IRC | 15:05 | |
| *** flwang has quit IRC | 15:06 | |
| *** serverascode has quit IRC | 15:06 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Limit parallel live migrations in progress https://review.openstack.org/212065 | 15:06 |
| *** gus has quit IRC | 15:06 | |
| *** freyes has quit IRC | 15:06 | |
| mriedem1 | wait, it's not good to run 100 live migrations at once from the same node? | 15:06 |
| *** atuvenie has quit IRC | 15:07 | |
| *** DuncanT has joined #openstack-nova | 15:08 | |
| *** gus has joined #openstack-nova | 15:08 | |
| *** BadCub has joined #openstack-nova | 15:08 | |
| *** serverascode has joined #openstack-nova | 15:09 | |
| *** dave-mccowan has quit IRC | 15:09 | |
| *** ctrath has joined #openstack-nova | 15:09 | |
| *** freyes has joined #openstack-nova | 15:10 | |
| *** lyanchih has joined #openstack-nova | 15:12 | |
| *** flwang has joined #openstack-nova | 15:13 | |
| dansmith | mriedem1: yeah, it is actually, assuming you're testing your failure procedures :) | 15:13 |
| *** xgsa has quit IRC | 15:13 | |
| mriedem1 | we don't have a QA dept | 15:14 |
| mriedem1 | sorry | 15:14 |
| dansmith | well, then take my word for it | 15:14 |
| mriedem1 | PRS has some thing like this in an API which limits evacuates | 15:14 |
| mriedem1 | that was never upstreamed | 15:14 |
| *** artom_ has quit IRC | 15:15 | |
| *** kmartin has joined #openstack-nova | 15:15 | |
| dansmith | there's no reason to limit evacuates, AFAIK, but maybe you mean the client's notion of host-evacuate, which is a bunch of live migrations.. | 15:15 |
| mriedem1 | yes, that | 15:15 |
| dansmith | yeah, this patch comes from that usage | 15:15 |
| dansmith | "I had a failing node, so I did host-evacuate and my network went ... away" | 15:16 |
| mriedem1 | yeah | 15:16 |
| mriedem1 | https://github.com/stackforge/powervc-driver/blob/master/nova-powervc/powervc/nova/extension/host_maintenance_mode.py#L55 | 15:16 |
| mriedem1 | i remember fighting powervc/prs on forking some host maintenance mode api of theirs | 15:16 |
| *** IanGovett has quit IRC | 15:16 | |
| *** tjones has joined #openstack-nova | 15:19 | |
| *** tjones has left #openstack-nova | 15:19 | |
| *** tonytan4ever has quit IRC | 15:19 | |
| *** yassine__ has quit IRC | 15:20 | |
| *** haomaiwang has joined #openstack-nova | 15:23 | |
| *** artom has joined #openstack-nova | 15:23 | |
| *** alexschm has quit IRC | 15:23 | |
| *** rushil has quit IRC | 15:23 | |
| *** vilobhmm has quit IRC | 15:23 | |
| *** angdraug has joined #openstack-nova | 15:24 | |
| tpeoples | mriedem1: powervc has something similar for live migration too. hosts are interrogated to determine how many live migrations they support and that value is used to limit | 15:24 |
| *** chhavi has quit IRC | 15:24 | |
| *** yassine__ has joined #openstack-nova | 15:25 | |
| mriedem1 | nice that was upstreamed... | 15:25 |
| *** IanGovett has joined #openstack-nova | 15:26 | |
| mriedem1 | dansmith: would there be value in making migration.status a nullable enum field at some point? | 15:27 |
| dansmith | mriedem1: well, we were discussing something recently, I think it'd maybe be better to add a state field and strictly define the machine that drives that | 15:28 |
| dansmith | mriedem1: so that we can have status for what it is today, which is mostly a string of what's going on | 15:28 |
| *** annegentle has joined #openstack-nova | 15:28 | |
| mriedem1 | so is migration.status = 'queued' read anywhere? | 15:28 |
| mriedem1 | or that's just info for the op? | 15:28 |
| dansmith | just for the op | 15:28 |
| mriedem1 | it's almost like migration.task_state | 15:29 |
| dansmith | yeah | 15:29 |
| *** thumpba has quit IRC | 15:31 | |
| *** thumpba has joined #openstack-nova | 15:33 | |
| dansmith | johnthetubaguy: the xenapi driver's live migration command is blocking, right? meaning, it doesn't return until the migration is finished or failed? | 15:36 |
| *** zhenguo has joined #openstack-nova | 15:36 | |
| dansmith | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L2224-L2262 for reference | 15:36 |
| dansmith | alaski: BobBall ^ | 15:36 |
| johnthetubaguy | dansmith: yeah, but I think it was happeing in a cast | 15:37 |
| *** salv-orl_ has joined #openstack-nova | 15:37 | |
| dansmith | johnthetubaguy: yep, definitely a cast, just wanted to make sure it was synchronous within compute, which it seems to be | 15:37 |
| mriedem1 | https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L2199 | 15:37 |
| sdague | dansmith: so https://review.openstack.org/#/c/201733/ still is failing both grenade jobs | 15:37 |
| openstackgerrit | Shunli Zhou proposed openstack/nova: A test commit of nova code. https://review.openstack.org/212075 | 15:37 |
| sdague | which makes me think it's not random | 15:37 |
| *** lyanchih has quit IRC | 15:37 | |
| dansmith | sdague: yeah, I haven't gone back to look, although it was only failing the non-partial one before | 15:38 |
| sdague | it's failing on both now, at the same point | 15:38 |
| *** agireud has joined #openstack-nova | 15:38 | |
| sdague | post upgrade, it attempts to delete the long lived resources, and triggers 500 errors in the server | 15:38 |
| dansmith | sdague: okay | 15:38 |
| *** chhavi has joined #openstack-nova | 15:39 | |
| dansmith | sdague: I haven't really looked at it, so that's fine | 15:39 |
| sdague | http://logs.openstack.org/33/201733/13/check/gate-grenade-dsvm/36ce293/logs/new/screen-n-api.txt.gz#_2015-08-11_20_24_53_964 | 15:39 |
| dansmith | danpb: yeah, libvirt is the only driver that does live migration async I think, so I'll just stuff it into that patch after all | 15:39 |
| BobBall | Correct dansmith | 15:39 |
| *** lyanchih has joined #openstack-nova | 15:39 | |
| dansmith | danpb: xenapi, hyperv and vmware are all sync | 15:39 |
| dansmith | BobBall: thanks | 15:39 |
| *** IanGovett1 has joined #openstack-nova | 15:40 | |
| dansmith | sdague: http://logs.openstack.org/33/201733/13/check/gate-grenade-dsvm/36ce293/logs/new/screen-n-cpu.txt.gz?level=TRACE | 15:40 |
| dansmith | sdague: it's johnthetubaguy's fault | 15:40 |
| dansmith | (no not really) | 15:40 |
| *** salv-orlando has quit IRC | 15:40 | |
| *** kylek3h_ has quit IRC | 15:41 | |
| *** IanGovett has quit IRC | 15:41 | |
| sdague | ah, gotcha | 15:41 |
| *** zhenguo has quit IRC | 15:42 | |
| *** scheuran has quit IRC | 15:43 | |
| *** marzif has quit IRC | 15:43 | |
| *** praneshp has joined #openstack-nova | 15:43 | |
| *** marzif has joined #openstack-nova | 15:44 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Limit parallel live migrations in progress https://review.openstack.org/212065 | 15:45 |
| *** josecastroleon has quit IRC | 15:46 | |
| *** rajesht has quit IRC | 15:46 | |
| *** josecastroleon has joined #openstack-nova | 15:47 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Add version counter to Service object https://review.openstack.org/201733 | 15:47 |
| *** moshele has quit IRC | 15:48 | |
| *** bapalm has quit IRC | 15:49 | |
| *** bapalm has joined #openstack-nova | 15:49 | |
| *** praneshp_ has joined #openstack-nova | 15:51 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Add version counter to Service object https://review.openstack.org/201733 | 15:51 |
| *** praneshp has quit IRC | 15:52 | |
| *** praneshp_ is now known as praneshp | 15:52 | |
| *** mdrabe__ has joined #openstack-nova | 15:53 | |
| *** morganfainberg_ has quit IRC | 15:55 | |
| *** mdrabe_ has quit IRC | 15:56 | |
| *** praneshp has quit IRC | 15:57 | |
| *** thumpba has quit IRC | 15:57 | |
| *** praneshp has joined #openstack-nova | 15:57 | |
| *** thumpba has joined #openstack-nova | 15:57 | |
| *** geekinutah has joined #openstack-nova | 15:57 | |
| *** thumpba has quit IRC | 15:58 | |
| *** thumpba has joined #openstack-nova | 15:58 | |
| rlrossit | dansmith: so the tests themselves look good to me on the manifest fix, but the class you use scares me (https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/tests/test_objects.py#L50-L60) | 15:59 |
| *** jcoufal has joined #openstack-nova | 15:59 | |
| rlrossit | dansmith: the class has a list of objects in it, but it isn't using the ObjectListBase mixin, which isn't bad for those tests, but I feel like if it's attempted to use in some place that wants lists, it will break hardcore | 16:00 |
| *** chhavi has quit IRC | 16:00 | |
| *** edtubill` has joined #openstack-nova | 16:00 | |
| rlrossit | it's just a really weird object in general | 16:00 |
| *** skylerberg has joined #openstack-nova | 16:00 | |
| *** vilobhmm has joined #openstack-nova | 16:01 | |
| dansmith | rlrossit: well, it uses a listofobjectsfield | 16:01 |
| dansmith | rlrossit: feel free to slap another test in there to test an actual list-mixed object.. probably a good idea | 16:02 |
| rlrossit | dansmith: I think I will leave that to my bigger patch, because _do_backport in this patch essentially just cares if the field is a ListOfObjectsField, which that is | 16:03 |
| dansmith | cool | 16:03 |
| rlrossit | dansmith: I'm going to be testing do_backport on its own in my other patch along with the actual compat code, which will require ObjectListBase use, so it will get covered then | 16:04 |
| rlrossit | no need to add the complexity in this code | 16:04 |
| dansmith | okay | 16:04 |
| rlrossit | is it normal for me to +1 what's technically my own patch? you did most of the heavy lifting on that patch | 16:04 |
| *** tjones has joined #openstack-nova | 16:04 | |
| *** jlanoux has quit IRC | 16:06 | |
| *** sudipto_ has joined #openstack-nova | 16:06 | |
| dansmith | I do it, yeah | 16:07 |
| dansmith | just to ack the things that aren't mine | 16:07 |
| *** garyk has quit IRC | 16:09 | |
| *** deepakcs has joined #openstack-nova | 16:10 | |
| *** mdbooth has quit IRC | 16:10 | |
| *** jkraj has quit IRC | 16:11 | |
| *** alex_klimov has quit IRC | 16:11 | |
| *** mdbooth has joined #openstack-nova | 16:12 | |
| *** shunliz has quit IRC | 16:12 | |
| *** edtubill` has quit IRC | 16:12 | |
| *** jistr has quit IRC | 16:13 | |
| *** sahid has quit IRC | 16:13 | |
| *** haomaiwang has quit IRC | 16:16 | |
| *** tjones has left #openstack-nova | 16:16 | |
| *** tonytan4ever has joined #openstack-nova | 16:18 | |
| openstackgerrit | Cale Rath proposed openstack/nova: Make generate_password more secure https://review.openstack.org/210092 | 16:20 |
| *** rotbeard has quit IRC | 16:20 | |
| *** josecastroleon has quit IRC | 16:23 | |
| *** unicell1 has quit IRC | 16:25 | |
| *** josecastroleon has joined #openstack-nova | 16:26 | |
| *** VW__ has joined #openstack-nova | 16:27 | |
| *** VW_ has quit IRC | 16:29 | |
| *** Marga_ has quit IRC | 16:30 | |
| *** Marga_ has joined #openstack-nova | 16:31 | |
| *** lucasagomes has quit IRC | 16:33 | |
| *** Maike has quit IRC | 16:35 | |
| *** dave-mccowan has joined #openstack-nova | 16:37 | |
| *** chhavi has joined #openstack-nova | 16:37 | |
| *** Piet has quit IRC | 16:39 | |
| *** salv-orl_ has quit IRC | 16:40 | |
| *** salv-orlando has joined #openstack-nova | 16:41 | |
| mriedem1 | ndipanov: mnestratov: fyi, update on https://review.openstack.org/#/c/204231/ from the cinder meeting, | 16:42 |
| *** Marga_ has quit IRC | 16:42 | |
| mriedem1 | sounds like they are in favor of changing the 400 from cinder to a 200 | 16:42 |
| *** sudipto_ has quit IRC | 16:42 | |
| mriedem1 | if you ask to detach a volume that isn't attached, to not raise the error | 16:42 |
| *** Marga_ has joined #openstack-nova | 16:43 | |
| mriedem1 | ndipanov: mnestratov: so this would be changed to a log message https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L885 | 16:43 |
| mriedem1 | that doesn't really fix kilo however | 16:43 |
| mriedem1 | and i'm not totally sure if it's ok as an api change | 16:43 |
| mriedem1 | but it's time for lunch so i will literally chew on this | 16:43 |
| ndipanov | mriedem1, yeah I was advocating for that change in Nova too | 16:44 |
| ndipanov | instead of the dreaded force detach | 16:44 |
| *** kmARC has quit IRC | 16:44 | |
| ndipanov | yeah - it's a questionable API change | 16:44 |
| ndipanov | definitely not so clear cut as I could imagine useful code relying on that property | 16:45 |
| *** rfolco has quit IRC | 16:45 | |
| *** matrohon has quit IRC | 16:45 | |
| *** rfolco has joined #openstack-nova | 16:48 | |
| *** unicell has joined #openstack-nova | 16:48 | |
| *** bapalm has quit IRC | 16:52 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: adds oslo.windows library https://review.openstack.org/212102 | 16:52 |
| *** salv-orlando has quit IRC | 16:54 | |
| *** salv-orlando has joined #openstack-nova | 16:54 | |
| *** apoorvad has joined #openstack-nova | 16:55 | |
| *** romainh has left #openstack-nova | 16:56 | |
| *** rushil has joined #openstack-nova | 16:56 | |
| deepakcs | johnthetubaguy: danpb Reg: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/volume-snapshot-improvements,n,z | 16:58 |
| deepakcs | johnthetubaguy: danpb are we sure we don't want to consider this, since it blocks the Cinder side of work too | 16:58 |
| deepakcs | johnthetubaguy: you mentioned you would relook after considering the Cinder impact | 16:59 |
| * deepakcs thus is trying one last time :) | 16:59 | |
| *** eliqiao has quit IRC | 17:00 | |
| *** nic has joined #openstack-nova | 17:00 | |
| *** otter768 has joined #openstack-nova | 17:00 | |
| johnthetubaguy | deepakcs: is the cinder stuff all ready now? | 17:01 |
| *** Piet has joined #openstack-nova | 17:02 | |
| deepakcs | johnthetubaguy: nova side is ready, just keeps needing rebases. cinder side is ready, just for 2 reviews from thangp on the object part of it. | 17:02 |
| *** rushil has quit IRC | 17:02 | |
| *** josecastroleon has quit IRC | 17:03 | |
| *** garyk has joined #openstack-nova | 17:03 | |
| deepakcs | johnthetubaguy: syncing up nova and cinder patches might be difficult as both are fast moving. Nova side is a dep on Cinder side. So nova getting in first is good for Cinder to move quickly | 17:03 |
| dansmith | johnthetubaguy: we said no to this because of lack of review on the nova side, right? | 17:03 |
| johnthetubaguy | dansmith: yes | 17:03 |
| deepakcs | johnthetubaguy: and Nova side is compatible with old cinder, so it should be ok | 17:03 |
| *** eliqiao has joined #openstack-nova | 17:03 | |
| deepakcs | dansmith: I have +2 from danpb on one of the patch and had +1 from sahid in the past for the other (IIRC). | 17:04 |
| johnthetubaguy | deepakcs: honestly, that sounds back to front, I would expect cinder to add an API, then nova to start using it. | 17:04 |
| dansmith | yeah, but ISTR danpb saying he wouldn't have +2d that if he had seen the second one | 17:04 |
| johnthetubaguy | deepakcs: it was the following too patches that needed a lot of review | 17:04 |
| deepakcs | johnthetubaguy: in this case, its the other way, since cinder needs to send "enuf" info to Nova for it to return back the volume format info and file_to_delete info | 17:05 |
| *** josecastroleon has joined #openstack-nova | 17:05 | |
| deepakcs | dansmith: was that before i did the split ? bcos post the split he gave a +2 again :) | 17:05 |
| *** otter768 has quit IRC | 17:05 | |
| johnthetubaguy | deepakcs: with the split, there is still a lot of code to review, that we haven't been able to review | 17:05 |
| deepakcs | dansmith: so its a set of 3 patches | 17:05 |
| deepakcs | Vs 2 in the past | 17:05 |
| dansmith | right, it's all new things to review, post-deadline | 17:06 |
| dansmith | sdague: service version patch is +1 from jenkins now | 17:06 |
| johnthetubaguy | deepakcs: I think its just unfair to all the other blueprints to let this one in now | 17:06 |
| deepakcs | johnthetubaguy: dansmith ok :( FWIW the patches were up for review for a loong time, sahid and danpb had done reviews in the past. I am only pushing since this bp already got pushed from J to L, and now its going to be further pushed | 17:06 |
| johnthetubaguy | deepakcs: if it were a smaller patch, we could do something | 17:07 |
| *** lyanchih has quit IRC | 17:07 | |
| johnthetubaguy | deepakcs: but there are a few hundred lines of extra code to review | 17:07 |
| johnthetubaguy | deepakcs: we have to go fix the bugs in the stuff we already have, our users are going crazy about us not doing that | 17:07 |
| deepakcs | johnthetubaguy: ok , thanks for the patience to hear me out. will try my luck in M then | 17:07 |
| *** danpb has quit IRC | 17:07 | |
| *** xek has quit IRC | 17:08 | |
| *** _gryf has quit IRC | 17:09 | |
| *** deepakcs has quit IRC | 17:10 | |
| *** chhavi has quit IRC | 17:11 | |
| *** pkoniszewski has quit IRC | 17:12 | |
| *** isq_ has quit IRC | 17:12 | |
| *** Marga_ has quit IRC | 17:12 | |
| *** xek has joined #openstack-nova | 17:13 | |
| *** achanda has joined #openstack-nova | 17:13 | |
| *** isq_ has joined #openstack-nova | 17:13 | |
| *** marzif has quit IRC | 17:14 | |
| *** patrickeast has quit IRC | 17:16 | |
| *** obondarev has joined #openstack-nova | 17:17 | |
| *** chhavi has joined #openstack-nova | 17:17 | |
| *** belmoreira has joined #openstack-nova | 17:19 | |
| *** belmoreira has quit IRC | 17:21 | |
| *** _gryf has joined #openstack-nova | 17:22 | |
| *** yassine__ has quit IRC | 17:24 | |
| openstackgerrit | melanie witt proposed openstack/nova: Add methods for RequestContext to switch db connection https://review.openstack.org/161906 | 17:25 |
| *** vishwanathj has joined #openstack-nova | 17:27 | |
| *** chhavi has quit IRC | 17:28 | |
| *** dave-mcc_ has joined #openstack-nova | 17:28 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Limit parallel live migrations in progress https://review.openstack.org/212065 | 17:29 |
| *** VW__ has quit IRC | 17:30 | |
| *** jwcroppe has joined #openstack-nova | 17:30 | |
| *** dave-mccowan has quit IRC | 17:31 | |
| *** VW_ has joined #openstack-nova | 17:31 | |
| *** patrickeast has joined #openstack-nova | 17:31 | |
| *** winston-d is now known as winston-d_zZZ | 17:33 | |
| *** kmARC has joined #openstack-nova | 17:34 | |
| *** VW_ has quit IRC | 17:35 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Re-arrange the unit test directories https://review.openstack.org/212120 | 17:35 |
| *** dave-mccowan has joined #openstack-nova | 17:38 | |
| *** dave-mcc_ has quit IRC | 17:40 | |
| *** josecastroleon has quit IRC | 17:42 | |
| *** rajesht has joined #openstack-nova | 17:43 | |
| *** josecastroleon has joined #openstack-nova | 17:43 | |
| *** annegentle has quit IRC | 17:44 | |
| *** garyk has quit IRC | 17:45 | |
| sdague | dansmith: cool, I'll look again | 17:47 |
| *** rajesht has quit IRC | 17:47 | |
| *** earlephilhower has quit IRC | 17:47 | |
| sdague | dansmith: ok, can you explain in simple terms to me what went wrong with the readonly version expectation? | 17:48 |
| sdague | just so I know for future | 17:49 |
| sdague | also, yay upgrade testing for checking that | 17:49 |
| dansmith | yeah, so... | 17:49 |
| dansmith | the readonly flag is basically "write once". If it's set and you try to set it, it fails | 17:49 |
| dansmith | the goal is so that when you pull something out of the DB, we set the id field based on the database, and then if someone tries to change it, it spanks them | 17:50 |
| dansmith | it has nothing to do with RPC, it's purely a developer convenience | 17:50 |
| dansmith | to help shape behavior | 17:50 |
| dansmith | this version thing is special in that we always need it to be initialized to the version of the current service | 17:51 |
| dansmith | so I wanted to mark it as readonly so people couldn't mess with it, | 17:51 |
| dansmith | but when we deserialize an object, we first create one (with our service version) and then write all the bits from the message into it, which counts as the second write, | 17:51 |
| dansmith | which was failed | 17:51 |
| dansmith | so for now, just not making it readonly is what we want so we can get this in | 17:52 |
| dansmith | and I'll try to figure out some other sneaky way to continue spanking people if they try to mess with it | 17:52 |
| dansmith | basically, I was abusing readonly and grenade caught me with my pants down | 17:52 |
| dansmith | er, hmm, that doesn't sound right | 17:52 |
| dansmith | anyway... | 17:52 |
| *** jcoufal_ has joined #openstack-nova | 17:53 | |
| sdague | ok, so the issue is conceptually you want it write once, but where it inflates vs. where it gets filled out are too far away from each other? | 17:55 |
| sdague | so it can't be | 17:55 |
| dansmith | yeah | 17:55 |
| sdague | ack | 17:55 |
| sdague | ok, +2 from me | 17:55 |
| dansmith | thanks | 17:55 |
| rlrossit | dansmith: what is https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L441 supposed to do? just return if obj is null? or does "not set" cause it to return also? | 17:56 |
| *** jcoufal has quit IRC | 17:57 | |
| rlrossit | dansmith: those 2 lines just look redundant to me because if obj is None, then we won't pass any of the instance checks later right? | 17:57 |
| sdague | johnthetubaguy: so patch 3 and 4 on the moves looks ready to got - https://review.openstack.org/#/c/211846 and +1 from jenkins | 17:58 |
| dansmith | rlrossit: it's for a nullable subobject where the object is set to None | 17:58 |
| dansmith | rlrossit: which two lines? | 17:58 |
| dansmith | rlrossit: oh I see | 17:58 |
| rlrossit | dansmith: 2 meaning the if and the return. | 17:58 |
| *** markus_z has quit IRC | 17:58 | |
| dansmith | you mean because we won't pass the isinstance calls? | 17:58 |
| rlrossit | yeah | 17:58 |
| dansmith | yeah I guess | 17:59 |
| rlrossit | I mean I can leave them in but they just seem redundant to me. If I leave them in I just won't test against that situation then | 17:59 |
| *** ildikov has joined #openstack-nova | 17:59 | |
| dansmith | I think that this came from when the code was a little different, | 17:59 |
| dansmith | before we tested to see if it was an object or a list | 17:59 |
| *** salv-orl_ has joined #openstack-nova | 17:59 | |
| dansmith | because we didn't always allow listofobjectsfield in a non-list object | 17:59 |
| dansmith | so it was either None or an actual object | 17:59 |
| rlrossit | oh because you probably just handled everything in one way before? | 17:59 |
| rlrossit | yep | 18:00 |
| dansmith | yes | 18:00 |
| rlrossit | gotcha | 18:00 |
| *** earlephilhower has joined #openstack-nova | 18:00 | |
| dansmith | rlrossit: make sure this doesn't differ between py2 and py3 and if not, then it can come out I guess | 18:00 |
| dansmith | py3 is different with respect to == None or some such | 18:00 |
| rlrossit | oh gosh then I need to get a py3 interpreter... | 18:00 |
| *** VW_ has joined #openstack-nova | 18:01 | |
| dansmith | or make sure there's a test to cover that and then push up a change and let jenkins use its py3 interpreter :) | 18:01 |
| *** Marga_ has joined #openstack-nova | 18:01 | |
| *** salv-orlando has quit IRC | 18:01 | |
| *** dannywilson has quit IRC | 18:04 | |
| mnestratov | mriedem1: so did they decide to fix the bug on cinder side? | 18:04 |
| mriedem1 | mnestratov: i just sat down after getting back, so i'm not sure where its ending up :) | 18:04 |
| mriedem1 | was just about to check on that | 18:04 |
| *** ijw has joined #openstack-nova | 18:05 | |
| *** pkoniszewski has joined #openstack-nova | 18:05 | |
| *** ijw_ has joined #openstack-nova | 18:08 | |
| *** ijw has quit IRC | 18:11 | |
| *** ijw has joined #openstack-nova | 18:11 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: Fix model query for non-admin flavor lookups https://review.openstack.org/211809 | 18:11 |
| *** angdraug has quit IRC | 18:12 | |
| *** ijw_ has quit IRC | 18:14 | |
| *** bapalm_ has joined #openstack-nova | 18:14 | |
| *** ijw has quit IRC | 18:16 | |
| *** tonytan4ever has quit IRC | 18:17 | |
| *** ijw has joined #openstack-nova | 18:18 | |
| *** ssurana has joined #openstack-nova | 18:18 | |
| *** tonytan4ever has joined #openstack-nova | 18:19 | |
| *** josecastroleon has quit IRC | 18:19 | |
| sdague | windows threshold is windows 10? - https://review.openstack.org/#/c/192617 | 18:20 |
| *** Maike has joined #openstack-nova | 18:20 | |
| *** josecastroleon has joined #openstack-nova | 18:21 | |
| *** ijw has quit IRC | 18:22 | |
| *** xyang2 has quit IRC | 18:22 | |
| *** ijw has joined #openstack-nova | 18:23 | |
| cfriesen_ | is there any particular reason why we don't support cold migration of suspended instances? Or is it just that nobody has wired it up yet? | 18:23 |
| *** bapalm has joined #openstack-nova | 18:23 | |
| *** bapalm has quit IRC | 18:24 | |
| cfriesen_ | or is it an actual libvirt limitation? | 18:25 |
| *** xyang2 has joined #openstack-nova | 18:25 | |
| dansmith | sdague: yeah, I think so | 18:25 |
| dansmith | cfriesen_: suspended or stopped? | 18:25 |
| cfriesen_ | dansmith: suspended | 18:27 |
| dansmith | cfriesen_: suspended in libvirt is paused, which means it's still running | 18:27 |
| dansmith | so you'd have to live migrate that | 18:27 |
| cfriesen_ | dansmith: was just looking at the code for suspend...don't we do a managedSave? | 18:27 |
| dansmith | virsh suspend is paused | 18:29 |
| cfriesen_ | no, nova suspend not virsh suspend | 18:29 |
| dansmith | okay | 18:29 |
| cfriesen_ | which looks like it ends up calling dom.managedSave() | 18:29 |
| *** meghal has joined #openstack-nova | 18:30 | |
| cfriesen_ | but I'm not clear whether libvirt would support migrating that suspended instance | 18:30 |
| dansmith | yeah, not sure | 18:30 |
| dansmith | I can see it being machine-specific if you're using certain types of network adapters | 18:30 |
| dansmith | but I dunno | 18:30 |
| dansmith | not really sure why we even have that support in nova, TBH | 18:30 |
| *** jcoufal has joined #openstack-nova | 18:32 | |
| cfriesen_ | Yeah, unless the provider charges less for a suspended instance it doesn't really make sense. | 18:32 |
| dansmith | I don't know of any clouds that charge less for even stopped instances | 18:33 |
| *** jcoufal__ has joined #openstack-nova | 18:35 | |
| *** jcoufal_ has quit IRC | 18:36 | |
| cfriesen_ | there we go, we can remove pause/unpause/suspend/resume/stop/start. :) | 18:36 |
| *** skylerberg has quit IRC | 18:36 | |
| *** ijw_ has joined #openstack-nova | 18:37 | |
| *** Sukhdev_ has joined #openstack-nova | 18:37 | |
| *** jcoufal has quit IRC | 18:38 | |
| *** ijw has quit IRC | 18:40 | |
| *** kmARC has quit IRC | 18:42 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused refresh_security_group_members() call https://review.openstack.org/182632 | 18:42 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Make secgroup rules refresh with refresh_instance_security_rules() https://review.openstack.org/182633 | 18:42 |
| *** salv-orl_ has quit IRC | 18:46 | |
| *** xyang2 has quit IRC | 18:48 | |
| *** salv-orlando has joined #openstack-nova | 18:49 | |
| alaski | we rely on the ability to recoverably 'disable' an instance for policy/billing infractions. doesn't matter if it's suspend or pause, but we need something | 18:51 |
| dansmith | alaski: I think he was kidding | 18:52 |
| dansmith | alaski: and you use suspend or pause to freeze them if they haven't paid? | 18:52 |
| *** meghal has quit IRC | 18:53 | |
| *** baoli has quit IRC | 18:53 | |
| alaski | dansmith: I know. I more meant to point out the use case, not make a case for keeping them | 18:53 |
| dansmith | ah | 18:53 |
| alaski | dansmith: yes | 18:53 |
| dansmith | cool | 18:53 |
| *** baoli has joined #openstack-nova | 18:54 | |
| alaski | we're moving from suspend to pause because xenserver tries to write the contents of an attached volume to disk on a suspend :( | 18:54 |
| dansmith | gwow | 18:54 |
| *** boris-42 has joined #openstack-nova | 18:54 | |
| alaski | yeah, that was a fun revelation | 18:54 |
| *** exploreshaifali has joined #openstack-nova | 18:56 | |
| *** IanGovett has joined #openstack-nova | 18:56 | |
| *** IanGovett1 has quit IRC | 18:56 | |
| *** ijw has joined #openstack-nova | 18:57 | |
| *** dannywilson has joined #openstack-nova | 18:59 | |
| *** ijw_ has quit IRC | 19:00 | |
| *** otter768 has joined #openstack-nova | 19:01 | |
| *** meghal has joined #openstack-nova | 19:04 | |
| *** otter768 has quit IRC | 19:06 | |
| *** ijw has quit IRC | 19:07 | |
| *** Sukhdev__ has joined #openstack-nova | 19:07 | |
| *** ijw has joined #openstack-nova | 19:07 | |
| *** Sukhdev_ has quit IRC | 19:11 | |
| *** meghal has quit IRC | 19:11 | |
| dansmith | mriedem1: seems that test_virt_drivers was only passing _because_ libvirt was not actually running the live migration code because of the spawn | 19:13 |
| *** Sukhdev_ has joined #openstack-nova | 19:13 | |
| mriedem1 | \o/ | 19:13 |
| *** shyama has quit IRC | 19:13 | |
| mriedem1 | test_virt_drivers is probably actually not all that useful | 19:13 |
| mriedem1 | at least for what it was intended | 19:13 |
| *** Sukhdev__ has quit IRC | 19:14 | |
| *** angdraug has joined #openstack-nova | 19:14 | |
| dansmith | indeed | 19:14 |
| mriedem1 | indubitably | 19:14 |
| dansmith | fo' shizzle | 19:15 |
| mriedem1 | i'm going to have to go ahead and stop you right there | 19:15 |
| dansmith | heh | 19:16 |
| *** meghal has joined #openstack-nova | 19:16 | |
| *** apoorvad has quit IRC | 19:19 | |
| *** suresh12 has joined #openstack-nova | 19:19 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Add logging when filtering returns nothing. https://review.openstack.org/192184 | 19:20 |
| *** Nikolay_St has joined #openstack-nova | 19:22 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Limit parallel live migrations in progress https://review.openstack.org/212065 | 19:22 |
| *** mriedem1 is now known as mriedem | 19:24 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 19:30 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Move objects registration in tests directory https://review.openstack.org/212159 | 19:30 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: WIP: Hyper-V: adds oslo.windows library https://review.openstack.org/212102 | 19:32 |
| *** VW_ has quit IRC | 19:33 | |
| *** VW_ has joined #openstack-nova | 19:34 | |
| *** Jeffrey4l|afk has quit IRC | 19:34 | |
| *** VW_ has quit IRC | 19:38 | |
| *** kmARC has joined #openstack-nova | 19:39 | |
| *** echoingumesh has joined #openstack-nova | 19:39 | |
| *** annegentle has joined #openstack-nova | 19:40 | |
| *** suresh12 has quit IRC | 19:41 | |
| *** echoingumesh has quit IRC | 19:41 | |
| *** VW_ has joined #openstack-nova | 19:41 | |
| cfriesen_ | alaski: thanks for the info above on suspend/pause. useful background. | 19:41 |
| *** echoingumesh has joined #openstack-nova | 19:42 | |
| *** exploreshaifali has quit IRC | 19:44 | |
| *** sc68cal has quit IRC | 19:44 | |
| cfriesen_ | in the nova unit tests, if I call self.assertRaises(webob.exc.HTTPConflict, etc...) is there a way for me to specify that I'm expecting a particular error message? | 19:45 |
| *** suresh12 has joined #openstack-nova | 19:46 | |
| *** Maike has quit IRC | 19:46 | |
| *** echoingumesh has quit IRC | 19:46 | |
| *** sc68cal has joined #openstack-nova | 19:46 | |
| mriedem | cfriesen_: self.assertRaises returns the exception that's caught | 19:47 |
| mriedem | from that | 19:47 |
| cfriesen_ | mriedem: okay, that should be doable. thanks | 19:47 |
| mriedem | self.assertEqual or self.assertIn('blarg', six.text_type(ex)) | 19:47 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 19:47 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Move objects registration in tests directory https://review.openstack.org/212159 | 19:47 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add fields to request spec object https://review.openstack.org/212168 | 19:47 |
| melwitt | mriedem: been meaning to ask you this, this bug is about a broken novaclient version on stable/kilo and requests a new release https://bugs.launchpad.net/python-novaclient/+bug/1481885 | 19:47 |
| openstack | Launchpad bug 1481885 in python-novaclient "python-novaclient 2.23.1 unsable: ImportError: No module named utils" [Undecided,New] | 19:47 |
| mriedem | melwitt: i thought that happened this week? | 19:48 |
| *** tonytan4ever has quit IRC | 19:48 | |
| melwitt | mriedem: I didn't know that. looking... | 19:48 |
| mriedem | melwitt: https://review.openstack.org/#/c/209629/ | 19:48 |
| mriedem | https://github.com/openstack/python-novaclient/tree/2.23.2 | 19:48 |
| mriedem | contains https://github.com/openstack/python-novaclient/commit/4ab9db648653f7ea6b9f8b1c78bff672b20b913f | 19:49 |
| mriedem | which has the oslo.utils bump | 19:49 |
| melwitt | mriedem: oh, cool! | 19:49 |
| mriedem | problem solved :) | 19:49 |
| * mriedem dusts off hands | 19:50 | |
| melwitt | haha yeah, the best scenario! I had it open in my browser tab to remind me to ask and then didn't refresh it today | 19:50 |
| *** rdopiera has quit IRC | 19:50 | |
| *** meghal has quit IRC | 19:51 | |
| melwitt | oh, you just updated it (duh). I wonder why the bot didn't post to it from the patch | 19:54 |
| *** Jeffrey4l|afk has joined #openstack-nova | 19:54 | |
| cfriesen_ | mriedem: are there known issues with tox unit tests in current master? http://paste.openstack.org/show/412768/ | 19:54 |
| *** tjones has joined #openstack-nova | 19:57 | |
| mriedem | cfriesen_: not that i'm aware of | 19:57 |
| mriedem | rebuild your venv | 19:57 |
| cfriesen_ | I deleted the whole .tox subdir | 19:57 |
| mriedem | NO!!! | 19:58 |
| melwitt | lol | 19:58 |
| *** ijw_ has joined #openstack-nova | 19:58 | |
| melwitt | I've been running unit tests fine. cfriesen_ are you running in an environment where you installed devstack by chance? | 19:59 |
| cfriesen_ | possibly, but a long time ago | 19:59 |
| cfriesen_ | it seems to not be actual dependencies, but rather not liking the formatting of the requirements.txt file | 19:59 |
| cfriesen_ | ValueError: ("Expected ',' or end-of-list in", "Routes!=2.0,!=2.1,>=1.12.3;python_version=='2.7'", 'at', ";python_version=='2.7'") | 20:00 |
| melwitt | there might be a version conflict with something installed in the base os (not in the venv) I'm guessing | 20:00 |
| melwitt | oh | 20:00 |
| mriedem | cfriesen_: which pip/tox versions do you have? | 20:00 |
| mriedem | maybe update those | 20:00 |
| cfriesen_ | pip 1.3.1 | 20:00 |
| cfriesen_ | tox 1.8.1 | 20:00 |
| cfriesen_ | fedora 19 | 20:01 |
| *** kmARC has quit IRC | 20:01 | |
| mriedem | i'm on 2.0 for pip and tox | 20:01 |
| mriedem | try updating | 20:01 |
| mriedem | oops | 20:01 |
| mriedem | pip 7.0.3 | 20:01 |
| mriedem | tox 2.0.2 | 20:01 |
| kashyap | Since I'm still awake at this hour, I'll post it here, anyway (thanks mriedem for the backport!): any cores who can ack upstream stable/kilo backports: https://review.openstack.org/#/c/203236/1 | 20:02 |
| mriedem | if you're on pip 1.3.1, man | 20:02 |
| mriedem | claudiub: ^ | 20:02 |
| cfriesen_ | been working fine till now. :) | 20:02 |
| mriedem | famous last words | 20:02 |
| *** ijw has quit IRC | 20:02 | |
| kashyap | (It fixes the straight-forward case of `nova rebuild` with a Cinder volume attached being broken in stable/kilo) | 20:02 |
| *** dustins has quit IRC | 20:03 | |
| melwitt | I'm even more modern, tox 2.1.1 | 20:05 |
| *** apoorvad has joined #openstack-nova | 20:07 | |
| *** skylerberg has joined #openstack-nova | 20:10 | |
| cfriesen_ | mriedem: melwitt: upgraded pip/tox to 7.10./2.1.1 and still getting the same ValueError exception | 20:10 |
| *** apoorvad has quit IRC | 20:10 | |
| *** apoorvad has joined #openstack-nova | 20:11 | |
| cfriesen_ | If I remove the second "Routes" line and remove ";python_version=='2.7'" from the first Routes line, then it works okay. | 20:13 |
| *** meghal has joined #openstack-nova | 20:13 | |
| rlrossit | cfriesen_: using same versions as you, blew away .tox and I'm ok on Ubuntu 14.04 | 20:13 |
| cfriesen_ | I assume the problem lies in whatever is actually parsing the requirements. This looks suspicious: "/usr/lib/python2.7/site-packages/tox/config.py:9: UserWarning: Module argparse was already imported from /usr/lib64/python2.7/argparse.pyc, but /usr/lib/python2.7/site-packages is being added to sys.path" | 20:14 |
| melwitt | cfriesen_: do you have Routes installed outside the venv? | 20:15 |
| *** achanda has quit IRC | 20:15 | |
| cfriesen_ | don't think so | 20:16 |
| cfriesen_ | "pip search Routes" doesn't show it as installed | 20:16 |
| melwitt | cfriesen_: what about yum list | 20:17 |
| *** tonytan4ever has joined #openstack-nova | 20:18 | |
| *** tsbot_ has joined #openstack-nova | 20:18 | |
| cfriesen_ | melwitt: nope. The problem seems to be whatever is parsing the requirements.txt file rather than the versions specified in the file. | 20:18 |
| cfriesen_ | It doesn't like the ";python_version=='2.7'" in the Routes line | 20:18 |
| melwitt | cfriesen_: oh. what parses that.. pbr? | 20:19 |
| cfriesen_ | melwitt: no idea. :) | 20:19 |
| melwitt | haha | 20:19 |
| cfriesen_ | looking at the traceback I posted, it seems to be pip | 20:19 |
| mriedem | lifeless is the person to ask about this | 20:20 |
| melwitt | dhellmann: do you know what thing parses the requirements.txt where an older version might not understand the ";python_version=='2.7'" designation? | 20:21 |
| cfriesen_ | looks like somehow I end up with pip 1.5.6 in the venv | 20:21 |
| *** tonytan4ever has quit IRC | 20:21 | |
| *** tonytan4ever has joined #openstack-nova | 20:21 | |
| *** dustins has joined #openstack-nova | 20:21 | |
| *** echoingumesh has joined #openstack-nova | 20:23 | |
| melwitt | I have pip 1.5.4 outside the venv and pip 7.1.0 inside the venv | 20:23 |
| lifeless | cfriesen_: hi | 20:24 |
| lifeless | melwitt: or hi; who is having the problem ? | 20:24 |
| cfriesen_ | lifeless: me | 20:24 |
| lifeless | cfriesen_: I haven't read backscroll; tl;dr it for me? | 20:24 |
| mriedem | http://paste.openstack.org/show/412768/ | 20:25 |
| cfriesen_ | lifeless: my tox is choking on the python_version in the Routes requirement in requirements.txt http://paste.openstack.org/show/412768/ | 20:25 |
| cfriesen_ | lifeless: melwitt: how do I tell it what version of pip to run in the venv? | 20:25 |
| lifeless | you need a newer virtualenv in the environment tox is running from | 20:26 |
| lifeless | https://rbtcollins.wordpress.com/2015/07/12/bootstrapping-developer-environments-for-openstack/ may help explain why | 20:26 |
| melwitt | cfriesen_: it did it automatically for me | 20:26 |
| melwitt | I have virtualenv 13.1.0 | 20:26 |
| cfriesen_ | lifeless: I've got python-virtualenv-1.10.1-1.fc19.noarch | 20:26 |
| lifeless | cfriesen_: yah, too old | 20:27 |
| lifeless | well at least upstream release is too old | 20:27 |
| lifeless | who knows what fedora do | 20:27 |
| lifeless | they may unbundle things | 20:27 |
| lifeless | in which case your rpm of pip will be what you get in a new virtualenv | 20:28 |
| cfriesen_ | lifeless: was working fine until whenever the Routes line got split into two. guess I have to upgrade away from the distro version | 20:28 |
| lifeless | cfriesen_: you can manually see | 20:28 |
| lifeless | virtualenv scratchdir | 20:28 |
| lifeless | . scratchdir/bin/activate | 20:29 |
| lifeless | pip list | 20:29 |
| *** xyang2 has joined #openstack-nova | 20:29 | |
| *** ijw has joined #openstack-nova | 20:29 | |
| *** VW__ has joined #openstack-nova | 20:29 | |
| cfriesen_ | lifeless: cool. I get: | 20:30 |
| cfriesen_ | pip 1.5.6, setuptools 3.6, wsgiref 0.1.2 | 20:30 |
| *** apuimedo has joined #openstack-nova | 20:30 | |
| lifeless | and this your trouble ;) | 20:30 |
| lifeless | openstack as a whole only tests the latest release of all the packaging tools | 20:31 |
| lifeless | so, personally, I think using system versions of them is a difficult path with few rewards | 20:31 |
| lifeless | [hence my blog post] | 20:31 |
| *** VW___ has joined #openstack-nova | 20:31 | |
| *** ijw_ has quit IRC | 20:32 | |
| *** VW__ has quit IRC | 20:32 | |
| cfriesen_ | just read your blog post. makes sense. guess I'd been lucky so far | 20:32 |
| *** VW_ has quit IRC | 20:33 | |
| *** Nikolay_St has quit IRC | 20:33 | |
| *** mwagner_lap has quit IRC | 20:35 | |
| lifeless | cfriesen_: this will also get you the wheel cache feature of pip, and better https support | 20:35 |
| lifeless | cfriesen_: so you'll be able to make a fresh nova tox venv in a few seconds | 20:35 |
| cfriesen_ | lifeless: once I get a local copy of virtualenv, how do I set it up so that running "tox" invokes it? | 20:36 |
| lifeless | cfriesen_: you make a virtualenv with it, then inside that install tox and virtualenv, and then run the tox from within it - e.g. ln -s ~/devtools/bin/tox ~/bin/tox | 20:36 |
| lifeless | cfriesen_: (step 8 in my blog post) | 20:37 |
| cfriesen_ | lifeless: okay, I think I got it. will give it a shot | 20:37 |
| *** chuckcarmack has left #openstack-nova | 20:37 | |
| *** Marga_ has quit IRC | 20:39 | |
| *** Marga_ has joined #openstack-nova | 20:39 | |
| *** thumpba has quit IRC | 20:40 | |
| *** VW___ has quit IRC | 20:43 | |
| *** VW_ has joined #openstack-nova | 20:44 | |
| *** mriedem is now known as mriedem_away | 20:47 | |
| *** mriedem_away has quit IRC | 20:48 | |
| *** xyang2 has quit IRC | 20:49 | |
| *** xyang2 has joined #openstack-nova | 20:51 | |
| cfriesen_ | lifeless: I've got the venv setup as you suggested with the symlink to ~/bin/tox. However, when I run " ~/bin/tox --version" it gives me an error "bash: /usr/bin/tox: No such file or directory" | 20:52 |
| cfriesen_ | lifeless: do I need to activate the venv each time or something? | 20:52 |
| cfriesen_ | lifeless: this is weird. if I run it as "tox --version" it complains, if I run it as "~/bin/tox --version" it's fine. "which tox" gives "~/bin/tox" | 20:54 |
| *** rfolco has quit IRC | 20:55 | |
| cfriesen_ | lifeless: not sure what was going on, but it was specific to one bash session. the others seem fine | 20:57 |
| *** krtaylor has quit IRC | 20:58 | |
| *** achanda has joined #openstack-nova | 21:01 | |
| *** otter768 has joined #openstack-nova | 21:02 | |
| *** echoingumesh has quit IRC | 21:02 | |
| *** echoingumesh has joined #openstack-nova | 21:03 | |
| *** echoingumesh has quit IRC | 21:04 | |
| *** thangp has quit IRC | 21:04 | |
| *** echoingumesh has joined #openstack-nova | 21:04 | |
| lifeless | cfriesen_: 'hash tox' ? | 21:05 |
| *** otter768 has quit IRC | 21:07 | |
| *** IanGovett has quit IRC | 21:09 | |
| *** ijw has quit IRC | 21:09 | |
| *** ijw has joined #openstack-nova | 21:10 | |
| *** alex_klimov has joined #openstack-nova | 21:11 | |
| *** krtaylor has joined #openstack-nova | 21:11 | |
| *** Sukhdev_ has quit IRC | 21:13 | |
| *** thorst has quit IRC | 21:16 | |
| *** prometheanfire has joined #openstack-nova | 21:17 | |
| prometheanfire | who's leg do we have to hump to get https://review.openstack.org/#/c/209856/ reviewed? | 21:17 |
| prometheanfire | the pre-release announcement was sent out about two months ago :P | 21:18 |
| dansmith | okay, I'm going to reward you purely for your crassness | 21:18 |
| claudiub | prometheanfire: will review, but please don?t hump my leg. :) | 21:18 |
| prometheanfire | claudiub: since you asked nicely :P | 21:18 |
| prometheanfire | dansmith: thanks | 21:18 |
| *** aysyd has quit IRC | 21:19 | |
| *** rlrossit has left #openstack-nova | 21:20 | |
| *** VW_ has quit IRC | 21:21 | |
| *** zul has quit IRC | 21:21 | |
| *** VW_ has joined #openstack-nova | 21:21 | |
| dansmith | prometheanfire: now, don't ask in here again unless you can top "leg humping" | 21:23 |
| prometheanfire | I'm sure I can come up with something | 21:23 |
| dansmith | I look forward to it | 21:24 |
| prometheanfire | mainly want it so I can cherrypick the patch into our kilo package | 21:24 |
| *** VW__ has joined #openstack-nova | 21:25 | |
| *** VW_ has quit IRC | 21:26 | |
| *** zul has joined #openstack-nova | 21:34 | |
| *** xyang2 has quit IRC | 21:41 | |
| *** mwagner_lap has joined #openstack-nova | 21:41 | |
| *** fawadkhaliq has joined #openstack-nova | 21:43 | |
| openstackgerrit | Cale Rath proposed openstack/nova: Make generate_password more secure https://review.openstack.org/210092 | 21:45 |
| *** dustins has quit IRC | 21:48 | |
| *** fawadkhaliq has quit IRC | 21:50 | |
| *** ctrath has quit IRC | 21:50 | |
| claudiub | prometheanfire: dansmith: I have a concern for https://review.openstack.org/#/c/209856/ | 21:52 |
| claudiub | prometheanfire: dansmith: IMO, it doesn't behave as expected, as the on_execute and on_completion kwargs are not in oslo_concurrency 1.8.0, which is set for Kilo. | 21:53 |
| openstackgerrit | Chris Friesen proposed openstack/nova: Improve error logs for start/stop of locked instance https://review.openstack.org/210689 | 21:53 |
| dansmith | claudiub: depends on the processing of our child signal | 21:53 |
| cfriesen_ | ^ trivial little fix to improve error message | 21:53 |
| dansmith | claudiub: but if we want to change it, we need to do so in master | 21:53 |
| *** jcoufal__ has quit IRC | 21:54 | |
| dansmith | claudiub: generally the rules for merging things to stable are "landed in master" and "appropriate for stable" | 21:54 |
| dansmith | claudiub: and this meets both of those things | 21:54 |
| *** annegentle has quit IRC | 21:54 | |
| claudiub | dansmith: I meant that the kwargs passed in this method https://review.openstack.org/#/c/209856/2/nova/virt/libvirt/utils.py are not used at all by oslo_concurrency v1.8.0 | 21:54 |
| claudiub | meaning those callbacks aren't called | 21:55 |
| dansmith | ah, sorry I missed the second line | 21:55 |
| claudiub | np. :) | 21:55 |
| dansmith | claudiub: but they're just ignored right? | 21:55 |
| dansmith | I remember this coming up for the master review | 21:56 |
| dansmith | as long as they're either honored or ignored, | 21:56 |
| dansmith | this is the best we can do, optionally with a change to the oslo.concurrency pin, right? | 21:56 |
| claudiub | I'll check, but if they are ignored, then the whole process tracking gimmick is useless, since the jobs are never registered, or never marked as completed | 21:56 |
| *** VW__ has quit IRC | 21:56 | |
| dansmith | well, | 21:56 |
| dansmith | it means that it will work if the person is running a new enough oslo.concurrency | 21:57 |
| *** VW_ has joined #openstack-nova | 21:57 | |
| dansmith | since stable is mostly for the distros, that becomes their responsibility | 21:57 |
| claudiub | actually, I think it doesn't ignore those arguments | 21:57 |
| dansmith | but if we can lift the pin in stable, we can/should do that too | 21:57 |
| claudiub | it pops the kwargs, and if kwargs: raise UnknownArgumentError | 21:57 |
| dansmith | okay | 21:57 |
| claudiub | e.g., unexpected kwargs, like in this case. | 21:57 |
| *** agireud has quit IRC | 21:57 | |
| *** VW_ has quit IRC | 21:58 | |
| *** VW__ has joined #openstack-nova | 21:58 | |
| claudiub | seems like a breaking commit for Kilo, IMO. But yeah, the oslo.concurrency pin should change before the commit merges. 1.8.1 maybe? | 21:58 |
| dansmith | claudiub: the live migration test seems to have passed though | 21:59 |
| dansmith | http://logs.openstack.org/56/209856/2/check/gate-tempest-dsvm-multinode-full/c5fcb77/console.html#_2015-08-11_16_30_57_583 | 21:59 |
| dansmith | the job failed because of the ssh bug, but I think that means it passed those arguments and nothing failed, right? | 21:59 |
| * dansmith checks the compute lots | 21:59 | |
| dansmith | er, logs | 21:59 |
| prometheanfire | ya, agreed about lifting the concurrency pin first | 22:00 |
| dansmith | yeah, compute logs are clean | 22:00 |
| *** otter768 has joined #openstack-nova | 22:01 | |
| *** mdrabe__ has quit IRC | 22:01 | |
| claudiub | wierd... | 22:01 |
| *** mdrabe__ has joined #openstack-nova | 22:01 | |
| claudiub | wasn't there supposed to be a pip freeze output file as well in jenkins? or did I become old and forgetful? | 22:02 |
| dansmith | so, are we sure this isn't actually handled in our own execute? | 22:02 |
| claudiub | there is, nvm | 22:02 |
| prometheanfire | claudiub: do you know when those kwargs were introduced? | 22:02 |
| claudiub | prometheanfire: https://github.com/openstack/oslo.concurrency/commit/d8307005bfac7d680bb1975733928e52e9053b77 | 22:02 |
| dansmith | ISTR some of that moved to oslo from here, so maybe in kilo we had these ourselves? | 22:02 |
| *** VW__ has quit IRC | 22:02 | |
| claudiub | prometheanfire: seems tagged for 2.4.0, 2.3.0, 2.2.0 and 2.1.0 | 22:02 |
| *** VW_ has joined #openstack-nova | 22:03 | |
| dansmith | hmm, nope I guess not | 22:03 |
| prometheanfire | claudiub: https://github.com/openstack/oslo.concurrency/blob/stable/kilo/oslo_concurrency/processutils.py#L150 | 22:03 |
| claudiub | dansmith: you mean this? https://github.com/openstack/nova/blob/stable/kilo/nova/utils.py#L207 | 22:03 |
| prometheanfire | seems to be in stable-kilo | 22:03 |
| dansmith | claudiub: yeah | 22:04 |
| prometheanfire | ya, 1.8.1 and 1.8.2 have it | 22:04 |
| *** burt has quit IRC | 22:04 | |
| prometheanfire | and the deps in kilo for oslo-concur are 1.8.x, so I think we are actually safe | 22:05 |
| *** lucasagomes has joined #openstack-nova | 22:05 | |
| claudiub | i downloaded 1.8.0, there is no on_execute or on_completion | 22:05 |
| prometheanfire | claudiub: https://github.com/openstack/nova/blob/2015.1.1/requirements.txt#L31 | 22:05 |
| *** apoorvad has quit IRC | 22:05 | |
| prometheanfire | claudiub: it's not forced to 1.8.0, 1.8.1 and 1.8.2 are allowed | 22:05 |
| dansmith | claudiub: but it's installing 1.8.2 | 22:05 |
| prometheanfire | oslo.concurrency<1.9.0,>=1.8.0 # Apache-2.0 | 22:05 |
| claudiub | dansmith: yeah, looking at the jenkins job pip freeze, it says: oslo.concurrency==1.8.2 | 22:06 |
| *** edmondsw has quit IRC | 22:06 | |
| dansmith | yeah | 22:06 |
| claudiub | still, I think the requirements should be raised to 1.8.2, to be on the safe side | 22:06 |
| dansmith | claudiub: so maybe we need to pin to 1.8.2 | 22:06 |
| dansmith | yeah | 22:06 |
| claudiub | cool | 22:06 |
| dansmith | claudiub: that should be a separate patch from this though, afaik | 22:07 |
| claudiub | ditto | 22:07 |
| prometheanfire | ya, needs to be at least 1.8.1 (when it was introduced) | 22:07 |
| *** VW_ has quit IRC | 22:07 | |
| claudiub | yeah, 1.8.1, I can confirm that. | 22:08 |
| prometheanfire | well, 1.8.2 has this https://github.com/openstack/oslo.concurrency/commit/2855b6e66256f7189c2298b2968e831480443ff2 | 22:09 |
| prometheanfire | which we might want lol | 22:09 |
| claudiub | lol, yes | 22:10 |
| prometheanfire | looks like the add might have been botched in 1.8.2 | 22:10 |
| prometheanfire | .1 | 22:10 |
| prometheanfire | whatever | 22:10 |
| *** mdrabe__ has quit IRC | 22:10 | |
| *** mdrabe__ has joined #openstack-nova | 22:11 | |
| *** apoorvad has joined #openstack-nova | 22:15 | |
| *** lucasagomes has quit IRC | 22:16 | |
| *** jecarey has quit IRC | 22:18 | |
| *** tonytan4ever has quit IRC | 22:19 | |
| *** diogogmt has quit IRC | 22:22 | |
| *** mdrabe__ has quit IRC | 22:22 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Limit parallel live migrations in progress https://review.openstack.org/212065 | 22:26 |
| *** tpeoples has quit IRC | 22:28 | |
| *** nic has quit IRC | 22:29 | |
| *** krtaylor has quit IRC | 22:30 | |
| *** wasmum has quit IRC | 22:31 | |
| *** marcusvrn has quit IRC | 22:33 | |
| *** penick has joined #openstack-nova | 22:36 | |
| *** achanda has quit IRC | 22:40 | |
| *** bnemec has quit IRC | 22:41 | |
| *** erlon has quit IRC | 22:43 | |
| *** annegentle has joined #openstack-nova | 22:44 | |
| *** devlaps has joined #openstack-nova | 22:44 | |
| *** annegentle has quit IRC | 22:45 | |
| *** annegentle has joined #openstack-nova | 22:46 | |
| *** sabari has quit IRC | 22:51 | |
| *** annegentle has quit IRC | 22:52 | |
| *** sabari has joined #openstack-nova | 22:53 | |
| *** moshele has joined #openstack-nova | 22:56 | |
| *** busterswt has quit IRC | 22:56 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add persistence to the RequestSpec object https://review.openstack.org/211753 | 23:00 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Move objects registration in tests directory https://review.openstack.org/212159 | 23:00 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Add fields to request spec object https://review.openstack.org/212168 | 23:00 |
| openstackgerrit | Andrew Laski proposed openstack/nova: Create RequestSpec object https://review.openstack.org/145528 | 23:00 |
| *** ijuwang has quit IRC | 23:01 | |
| *** zzz_pczesno has quit IRC | 23:08 | |
| *** tjones1 has joined #openstack-nova | 23:09 | |
| *** tjones has quit IRC | 23:11 | |
| *** alex_klimov has quit IRC | 23:11 | |
| *** moshele has quit IRC | 23:11 | |
| *** ijw_ has joined #openstack-nova | 23:12 | |
| *** markvoelker has quit IRC | 23:14 | |
| *** ijw has quit IRC | 23:15 | |
| *** claudiub has quit IRC | 23:16 | |
| *** achanda has joined #openstack-nova | 23:16 | |
| *** wasmum has joined #openstack-nova | 23:17 | |
| *** zul has quit IRC | 23:17 | |
| *** agireud has joined #openstack-nova | 23:17 | |
| *** suresh12 has quit IRC | 23:23 | |
| *** prometheanfire has left #openstack-nova | 23:25 | |
| *** RuiChen has quit IRC | 23:29 | |
| *** RuiChen has joined #openstack-nova | 23:34 | |
| *** meghal has quit IRC | 23:35 | |
| *** salv-orl_ has joined #openstack-nova | 23:35 | |
| *** salv-orlando has quit IRC | 23:37 | |
| *** Alexandra_ has joined #openstack-nova | 23:41 | |
| *** ijw_ has quit IRC | 23:44 | |
| *** geekinutah has quit IRC | 23:44 | |
| *** ijw has joined #openstack-nova | 23:44 | |
| *** oomichi has joined #openstack-nova | 23:51 | |
| *** Marga_ has quit IRC | 23:52 | |
| *** baoli has quit IRC | 23:52 | |
| *** penick has quit IRC | 23:55 | |
| *** suresh12 has joined #openstack-nova | 23:56 | |
| *** baoli has joined #openstack-nova | 23:56 | |
| *** veena has joined #openstack-nova | 23:57 | |
| *** xyang2 has joined #openstack-nova | 23:59 | |
| *** achanda has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!