Friday, 2015-08-07

*** ritesh has joined #openstack-nova00:00
alex_xudansmith: hi, may I update this patch https://review.openstack.org/#/c/209240/ if I found something today?00:01
openstackgerritShiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI  https://review.openstack.org/20261700:02
*** achanda_ has quit IRC00:03
*** salv-orlando has quit IRC00:03
*** achanda has quit IRC00:05
*** diogogmt has quit IRC00:07
*** skylerberg has quit IRC00:11
*** armax has joined #openstack-nova00:11
*** mriedem1 has joined #openstack-nova00:15
*** ijw_ has joined #openstack-nova00:16
*** mriedem has quit IRC00:17
openstackgerritGhanshyam Mann proposed openstack/nova-specs: Spec for "tenant_id" "user_id" filter implies "all_tenant"  https://review.openstack.org/19818400:18
openstackgerritGhanshyam Mann proposed openstack/nova-specs: Spec for "tenant_id" "user_id" filter implies "all_tenant"  https://review.openstack.org/19818400:18
*** ijw has quit IRC00:19
riteshHas anyone tried booting an instance with a nic each on 2 subnets on 1 network ? I see that only one interface is up in the instance...00:19
ritesh^^ HELP HELP!00:19
*** skylerberg has joined #openstack-nova00:20
*** tsekiyam_ has joined #openstack-nova00:21
dansmithalex_xu: I guess00:22
openstackgerritGhanshyam Mann proposed openstack/nova-specs: Spec to add vif 'net-id' in virtual interfaces API  https://review.openstack.org/19862200:23
*** mtanino has quit IRC00:24
*** otter768 has joined #openstack-nova00:25
*** tsekiyama has quit IRC00:25
*** tsekiyam_ has quit IRC00:26
*** markvoelker has quit IRC00:27
*** markvoelker has joined #openstack-nova00:28
*** ssurana has joined #openstack-nova00:28
*** tjones has joined #openstack-nova00:29
*** otter768 has quit IRC00:29
*** iamjarvo has joined #openstack-nova00:33
alex_xudansmith: ok, let me give one more try  :)00:34
*** iamjarvo has quit IRC00:37
*** asselin_ has left #openstack-nova00:41
openstackgerritShiina, Hironori proposed openstack/nova-specs: Fix spec: Inject NMI to an instance  https://review.openstack.org/20700400:42
*** tjones has quit IRC00:46
openstackgerritZhenguo Niu proposed openstack/nova: [Ironic]Not count available resources of deployed ironic node  https://review.openstack.org/20408800:49
*** dims_ has quit IRC00:53
*** liusheng has joined #openstack-nova00:55
*** ijw_ has quit IRC00:58
*** ijw has joined #openstack-nova00:59
*** praneshp has quit IRC01:00
*** tjones has joined #openstack-nova01:00
*** leeantho has quit IRC01:01
*** ijw_ has joined #openstack-nova01:03
*** atuvenie has quit IRC01:05
openstackgerritVilobh Meshram proposed openstack/nova-specs: Quota by Flavor, Quota by AZ, Quota by X  https://review.openstack.org/20616001:05
*** ijw has quit IRC01:06
*** xyang has quit IRC01:08
*** dave-mccowan has joined #openstack-nova01:09
*** dims_ has joined #openstack-nova01:09
*** dims__ has joined #openstack-nova01:15
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API  https://review.openstack.org/20991701:16
*** dims__ has quit IRC01:16
*** thorst has joined #openstack-nova01:16
*** thorst has quit IRC01:17
*** dims_ has quit IRC01:17
*** dims_ has joined #openstack-nova01:18
*** tongli has joined #openstack-nova01:18
*** bnemec has quit IRC01:19
*** ssurana has quit IRC01:19
*** jyuso1 has quit IRC01:21
*** angdraug has quit IRC01:23
*** tpeoples has joined #openstack-nova01:25
*** lyanchih has joined #openstack-nova01:26
*** bnemec has joined #openstack-nova01:27
*** meghal has quit IRC01:32
*** pixelbeat has quit IRC01:33
*** kylek3h has quit IRC01:39
*** tjones has quit IRC01:41
*** dims__ has joined #openstack-nova01:42
*** dims_ has quit IRC01:44
*** mriedem1 has quit IRC01:44
*** tpeoples has quit IRC01:50
*** shuquan has joined #openstack-nova01:51
*** vilobhmm has quit IRC01:51
*** ijw_ has quit IRC01:52
*** Sukhdev has quit IRC01:53
*** dims_ has joined #openstack-nova01:54
*** unicell has quit IRC01:56
*** dims__ has quit IRC01:56
*** zul has joined #openstack-nova02:11
openstackgerritShiina, Hironori proposed openstack/nova: Add a compute RPC API to inject an NMI  https://review.openstack.org/20260502:15
*** tongli has quit IRC02:16
openstackgerritShiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI  https://review.openstack.org/20261702:18
*** baoli has joined #openstack-nova02:22
*** baoli has quit IRC02:22
*** achanda has joined #openstack-nova02:24
*** baoli has joined #openstack-nova02:24
*** otter768 has joined #openstack-nova02:25
*** baoli has quit IRC02:29
*** markvoelker has quit IRC02:30
*** otter768 has quit IRC02:30
*** shuquan has quit IRC02:34
openstackgerritZhenyu Zheng proposed openstack/nova: CONF.allow_resize_to_same_host should check only once in controller  https://review.openstack.org/18623602:41
*** dave-mccowan has quit IRC02:42
openstackgerritJay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device status  https://review.openstack.org/21018002:43
openstackgerritJay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device type  https://review.openstack.org/21018102:43
openstackgerritJay Pipes proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker  https://review.openstack.org/21018202:43
openstackgerritJay Pipes proposed openstack/nova: pci: Remove get_pci_devices_filter() method  https://review.openstack.org/21018302:43
*** wanghua has joined #openstack-nova02:43
*** rushiagr_away is now known as rushiagr02:45
*** dave-mccowan has joined #openstack-nova02:46
*** Murali has joined #openstack-nova02:51
*** hakimo_ has joined #openstack-nova02:52
*** hakimo has quit IRC02:55
*** rushiagr is now known as rushiagr_away03:02
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Use Version Independent Identity Plugins for Neutron handshake  https://review.openstack.org/20959903:06
openstackgerritZhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails  https://review.openstack.org/20237903:08
*** Murali has quit IRC03:10
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Use Version Independent Identity Plugins for Neutron handshake  https://review.openstack.org/20959903:10
openstackgerritAlex Xu proposed openstack/nova: Remove tie between system_metadata and extra.flavor  https://review.openstack.org/20924003:12
*** baoli has joined #openstack-nova03:12
*** baoli has quit IRC03:12
*** shuquan has joined #openstack-nova03:13
*** sakaYK has joined #openstack-nova03:14
openstackgerritShiina, Hironori proposed openstack/python-novaclient: Add support for injecting an NMI  https://review.openstack.org/20709203:21
*** salv-orlando has joined #openstack-nova03:24
*** markvoelker has joined #openstack-nova03:30
*** shuquan_ has joined #openstack-nova03:31
*** shuquan has quit IRC03:32
*** shuquan_ is now known as shuquan03:32
*** salv-orlando has quit IRC03:33
*** Guest57802 is now known as jgriffith03:34
*** markvoelker has quit IRC03:35
*** tjones has joined #openstack-nova03:37
*** zzzeek has quit IRC03:38
*** shyu has joined #openstack-nova03:39
*** diogogmt has joined #openstack-nova03:40
*** shuquan has quit IRC03:44
*** vilobhmm has joined #openstack-nova03:45
*** apuimedo has quit IRC03:46
*** humble_ has joined #openstack-nova03:47
*** vivekd has joined #openstack-nova03:48
*** wanghua has quit IRC03:49
*** boris-42 has quit IRC03:50
*** skylerberg has quit IRC03:50
*** humble__ has joined #openstack-nova03:51
*** humble_ has quit IRC03:55
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API  https://review.openstack.org/20991703:56
*** achanda has quit IRC03:56
*** shuquan has joined #openstack-nova03:57
*** shuquan has quit IRC04:02
*** dims_ has quit IRC04:04
*** hshiina has joined #openstack-nova04:05
*** shuquan has joined #openstack-nova04:05
*** rajesht has joined #openstack-nova04:08
*** rajesht has quit IRC04:09
*** rajesht has joined #openstack-nova04:10
*** shuquan has quit IRC04:10
*** shuquan_ has joined #openstack-nova04:10
*** gyee has quit IRC04:13
*** baoli has joined #openstack-nova04:13
*** lyanchih has quit IRC04:14
*** baoli has quit IRC04:18
*** sudipto has joined #openstack-nova04:21
*** otter768 has joined #openstack-nova04:26
*** yushiro has joined #openstack-nova04:28
*** ildikov has quit IRC04:29
*** otter768 has quit IRC04:31
*** Sukhdev_ has joined #openstack-nova04:34
*** salv-orlando has joined #openstack-nova04:34
*** kiran-r has joined #openstack-nova04:34
*** tjones has quit IRC04:34
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API  https://review.openstack.org/20991704:35
yushirosdague, ping04:37
*** jswarren has quit IRC04:38
*** jdandrea has quit IRC04:39
*** dave-mccowan has quit IRC04:39
*** salv-orlando has quit IRC04:39
*** xyang2 has quit IRC04:40
*** sakaYK has quit IRC04:41
*** sakaYK has joined #openstack-nova04:41
*** deepakcs has joined #openstack-nova04:41
*** dave-mccowan has joined #openstack-nova04:42
*** Nikolay_St has joined #openstack-nova04:42
*** vilobhmm has quit IRC04:44
*** vilobhmm has joined #openstack-nova04:44
*** tjones has joined #openstack-nova04:47
*** tjones has quit IRC04:48
*** unicell has joined #openstack-nova04:49
*** diogogmt has quit IRC05:00
*** ishant has joined #openstack-nova05:03
*** lyanchih has joined #openstack-nova05:04
*** _kiran_ has joined #openstack-nova05:06
*** kiran-r has quit IRC05:07
openstackgerritJohnson koil raj proposed openstack/nova: Provide an option to set disk.EnableUUID in vmx  https://review.openstack.org/20526905:10
*** haomaiwang has quit IRC05:11
*** haomaiwa_ has joined #openstack-nova05:11
*** flwang1 has quit IRC05:11
*** ildikov has joined #openstack-nova05:12
openstackgerritZachary Sais proposed openstack/nova: Move existing V2 to legacy_v2  https://review.openstack.org/19372505:14
*** unicell has quit IRC05:15
*** _kiran_ has quit IRC05:16
*** unicell has joined #openstack-nova05:19
*** dave-mcc_ has joined #openstack-nova05:21
*** moshele has joined #openstack-nova05:22
*** baoli has joined #openstack-nova05:22
*** dave-mccowan has quit IRC05:23
deepakcsjohnthetubaguy: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/volume-snapshot-improvements,n,z (splitted the patch as per your and danpb's suggestion)05:24
deepakcsdansmith: danpb ^^05:24
*** achanda has joined #openstack-nova05:25
*** vilobhmm has quit IRC05:25
*** baoli has quit IRC05:27
*** shihanzhang has quit IRC05:29
*** shihanzhang has joined #openstack-nova05:29
*** echoingumesh has joined #openstack-nova05:31
*** cfriesen has quit IRC05:31
*** markvoelker has joined #openstack-nova05:31
*** echoingu_ has joined #openstack-nova05:34
*** markvoelker has quit IRC05:36
*** echoingumesh has quit IRC05:37
*** shuquan_ has quit IRC05:39
*** lyanchih has quit IRC05:39
*** shuquan has joined #openstack-nova05:39
*** salv-orlando has joined #openstack-nova05:40
*** sakaYK has quit IRC05:41
*** shuquan has quit IRC05:42
*** shuquan has joined #openstack-nova05:43
*** Nikolay_St has quit IRC05:46
*** salv-orlando has quit IRC05:46
*** belmoreira has quit IRC05:47
*** Murali has joined #openstack-nova05:48
*** praneshp has joined #openstack-nova05:49
openstackgerritAlex Xu proposed openstack/nova: Remove tie between system_metadata and extra.flavor  https://review.openstack.org/20924005:52
*** josecastroleon has joined #openstack-nova05:54
openstackgerritZoltan Arnold Nagy proposed openstack/nova: libvirt: add encrypted rbd volume support  https://review.openstack.org/20657605:55
*** lyanchih has joined #openstack-nova05:56
*** jwitko has quit IRC05:58
*** ankit_ag has joined #openstack-nova06:02
*** setuid has quit IRC06:02
*** jwitko has joined #openstack-nova06:02
*** melwitt has quit IRC06:04
*** zul has quit IRC06:06
*** ftersin has joined #openstack-nova06:07
*** praneshp has quit IRC06:09
*** setuid has joined #openstack-nova06:09
*** alex_klimov has joined #openstack-nova06:09
*** ttrumm has joined #openstack-nova06:10
openstackgerritjunxu proposed openstack/nova-specs: Allow force stop server in nova rest api  https://review.openstack.org/19541806:11
openstackgerritgaryk proposed openstack/nova: Compute: replace incorrect instance object with dict  https://review.openstack.org/20958306:15
*** ftersin_ has joined #openstack-nova06:17
*** moshele has quit IRC06:18
*** ftersin has quit IRC06:19
*** sakaYK has joined #openstack-nova06:22
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/20978006:22
*** otter768 has joined #openstack-nova06:27
*** otter768 has quit IRC06:32
*** alex_klimov has quit IRC06:33
*** Sukhdev_ has quit IRC06:34
*** sahid has joined #openstack-nova06:34
*** alex_klimov has joined #openstack-nova06:34
*** Nikolay_St has joined #openstack-nova06:38
*** rdopiera has joined #openstack-nova06:38
*** belmoreira has joined #openstack-nova06:38
*** humble__ has quit IRC06:40
*** humble__ has joined #openstack-nova06:41
*** lyanchih has quit IRC06:44
*** sahid has quit IRC06:46
*** jyuso1 has joined #openstack-nova06:46
*** salv-orlando has joined #openstack-nova06:51
*** Vikas has joined #openstack-nova06:51
VikasHi Folks..one small query06:52
*** sahid has joined #openstack-nova06:52
Vikaswhat does "cleaned" instance variable in a VM instance class represents.https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L10606:53
*** sahid has quit IRC06:53
Vikasdoes it mean if hypervisor resources have been freed?06:54
*** jwitko has quit IRC06:54
*** sahid has joined #openstack-nova06:54
*** shuquan has quit IRC06:55
*** vilobhmm has joined #openstack-nova06:55
*** shuquan has joined #openstack-nova06:55
*** jwitko has joined #openstack-nova06:56
*** salv-orlando has quit IRC06:56
*** shuquan has quit IRC06:57
*** sahid has quit IRC06:58
*** setuid has quit IRC06:59
*** sahid has joined #openstack-nova07:01
*** lyanchih has joined #openstack-nova07:01
*** dave-mcc_ has quit IRC07:01
*** vilobhmm has quit IRC07:01
*** dave-mccowan has joined #openstack-nova07:02
*** winston-d_zZZ is now known as winston-d07:04
*** romainh has joined #openstack-nova07:06
*** yushiro has quit IRC07:10
*** shuquan has joined #openstack-nova07:11
humble__#openstack-fuel07:12
*** Marga_ has joined #openstack-nova07:13
*** salv-orlando has joined #openstack-nova07:13
*** achanda has quit IRC07:15
*** shuquan has quit IRC07:15
*** romainh has left #openstack-nova07:16
*** humble_ has joined #openstack-nova07:17
*** shuquan has joined #openstack-nova07:17
*** kiran-r has joined #openstack-nova07:17
*** yamahata has quit IRC07:17
*** ttrumm_ has joined #openstack-nova07:19
*** lyanchih has quit IRC07:20
*** ttrumm has quit IRC07:20
*** tojuvone has joined #openstack-nova07:23
*** Marga_ has quit IRC07:23
*** Marga_ has joined #openstack-nova07:24
*** sahid has quit IRC07:26
*** sahid has joined #openstack-nova07:26
*** setuid has joined #openstack-nova07:27
*** abhishekk has joined #openstack-nova07:28
*** markvoelker has joined #openstack-nova07:32
*** baoli has joined #openstack-nova07:34
*** markvoelker has quit IRC07:37
*** baoli has quit IRC07:39
openstackgerritAnkit Agrawal proposed openstack/nova: Detach volume after deleting instance with no host  https://review.openstack.org/19406307:39
*** shuquan has quit IRC07:43
*** browne has quit IRC07:44
*** vivekd has quit IRC07:47
*** shuquan has joined #openstack-nova07:50
*** jlanoux has joined #openstack-nova07:51
openstackgerritZhuChunzhan proposed openstack/python-novaclient: Correct the files's description "overrwriter" The parameter of method create files's description contains incorrect word Modify "overrwrite" to "overwrite". Fixes Bug1482081  https://review.openstack.org/21023507:51
*** chhavi has joined #openstack-nova07:51
*** ssurana has joined #openstack-nova07:51
openstackgerritEduard Biceri-Matei proposed openstack/nova: libvirt: New driver for volumes backed by local file.  https://review.openstack.org/13413407:51
*** wanghua has joined #openstack-nova07:52
*** alexschm has joined #openstack-nova07:52
*** jcoufal has joined #openstack-nova07:52
*** shuquan_ has joined #openstack-nova07:54
*** humble__ has quit IRC07:54
*** shuquan has quit IRC07:55
*** shuquan_ is now known as shuquan07:55
*** venkatesh has joined #openstack-nova08:00
*** liusheng has quit IRC08:00
openstackgerritZhenyu Zheng proposed openstack/nova: Add instance action events for live migration  https://review.openstack.org/19537208:04
*** jistr has joined #openstack-nova08:06
*** alexpilotti has joined #openstack-nova08:07
*** ttrumm_ has quit IRC08:14
*** yassine_ has joined #openstack-nova08:15
*** afazekas_ has joined #openstack-nova08:17
*** sudipto has quit IRC08:22
*** scheuran has joined #openstack-nova08:22
*** sudipto has joined #openstack-nova08:22
*** shuquan has quit IRC08:24
*** ttrumm_ has joined #openstack-nova08:25
*** atuvenie has joined #openstack-nova08:25
*** shuquan has joined #openstack-nova08:25
*** danpb has joined #openstack-nova08:26
*** otter768 has joined #openstack-nova08:28
*** shuquan has quit IRC08:28
*** atuvenie has quit IRC08:29
*** shuquan has joined #openstack-nova08:30
*** ssurana has quit IRC08:32
ankit_agftersin_: hi ..08:33
*** otter768 has quit IRC08:33
ftersin_hi there08:33
ankit_agftersin_: want to discuss about review https://review.openstack.org/#/c/194063/ if you have some time08:34
ftersin_sure08:34
johnthetubaguydeepakcs: that split looks better, sorry if it was not clear, but that is now hit by the feature exception freeze at this point, although that is one we debated quite a lot, its clearly important, there maybe a slim chance of bringing that back if we think its good now08:34
ankit_agyou first concern is _delete destroys the instance with empty host locally08:34
deepakcsjohnthetubaguy: thanks for the update.. so you mean there will be one more round of discussions on that ?08:35
ankit_agnow instance will be deleted localy from local_delete08:35
deepakcsjohnthetubaguy: also my bp is not really a feature, si it ? its more of improving existing feature :)08:35
ankit_agand the code which I have removed is duplicate of _local_delete08:35
ankit_agso there is no need to keep that in _delete method.08:36
*** gszasz has joined #openstack-nova08:36
ankit_ag2. L1583: instance is refreshed and gets non empty host08:36
ankit_agIt is handled in _local_delete now in my patch08:36
ankit_ag3. L1593: is_local_delete is evaluated as False08:37
ankit_agit is evaluted similar to the master code in my patch as well08:37
johnthetubaguydeepakcs: possibly, I would love to get some reviews from cinder folks on there I guess, to make sure its what they expected, I am curious about if danpb if OK to take a quick look at that, and see how close we are now?08:37
ankit_ag4. L1614: delete operation is redirected to compute node08:37
ftersin_ankit_ag: you numer lines by master or your code?08:37
ankit_agthese lines are from your comments on PS308:38
deepakcsjohnthetubaguy: sure from Cinder eharney can look ( He is in cinder mid-cycle meetup right now) and danpb had given a +1 to the objects patch (before u gave -2 :) )08:38
ftersin_ankit_ag: give me a minute...08:39
ankit_agthose are from master code08:39
ankit_agyes sure08:39
deepakcs(The other patch in the series had +1 from others in the past)08:39
ftersin_ankit_ag: the difference is that in your patch is_local_delete is evaluated with empty host, but master code evaluates it after instance refresh, so its host is not empty08:40
*** ttrumm has joined #openstack-nova08:41
ftersin_ankit_ag: when destroy is failed with the error, master code may redirect destroy to a compute node08:42
ftersin_ankit_ag: but your patch cannot08:42
ankit_agftersin_: With my patch _local_delete will only be called if instance host is not set, so there is no need to redirect to compute node08:44
*** vivekd has joined #openstack-nova08:44
ankit_agftersin_: and if host is up and running is will redirect to compute node and terminate the instance08:44
*** markus_z has joined #openstack-nova08:44
ankit_agftersin_: in case when control is redirected to the compute node, it cleansup everything properly08:45
*** ttrumm_ has quit IRC08:45
ankit_agftersin_: The issue was only in case of deleting the instance locallu08:45
ankit_aglocally08:45
johnthetubaguydeepakcs: its a procedural -2, not a code review one, just to be clear08:46
ftersin_ankit_ag: but the reason of reverting your original patch is that when _delete starts, the instance has empty host08:46
johnthetubaguydeepakcs: I probably missed the previous +1s, my bad08:46
ankit_agftersin_: I have ran this pacth several times on jenkins successfully08:46
ftersin_ankit_ag: but it becomes not empty during execution08:46
ftersin_ankit_ag: so when you evaluates is_local_delete host field is empty08:47
ftersin_ankit_ag: but when you go to destroy the instance, host is no longer empty08:48
ankit_agftersin_: Can you please help me to find a single case where this patch fails in actual scenario08:48
*** Vikas has quit IRC08:49
ankit_agftersin_: Even host is not empty it is cleaning up everything while destoying the instance08:49
deepakcsjohnthetubaguy: yes i know u said in the comment, no issues :)08:49
ankit_agftersin_: I have verified host, network, volume, info_cache everything is cleaned up properly with this patch08:50
ftersin_ankit_ag: the scenario should be described  in 99811708:50
*** shuquan has quit IRC08:50
ftersin_ankit_ag: i understand that now all your tests passes, but your patch deletes instance locally when it has not empty host, which was desided as an error by 99811708:53
*** neelabh has joined #openstack-nova08:53
*** shuquan has joined #openstack-nova08:53
ftersin_ankit_ag: master code cathes the renewal of host and redirects the flow to compute node08:54
ankit_agftersin_: What if compute service is down with master code08:54
ftersin_ankit_ag: it checks it when it evaluates is_local_delete08:55
ankit_agand based on that it decides to delete instance locally or to redirect to compute manager08:56
neelabhHey Guys, I want to use open-stack "nova-api" to make similar application in flask, So I do should I start....08:56
ankit_agftersin_: If we talk about the bug 998117 this is the code which has caused the issues I am trying to fix08:57
openstackbug 998117 in OpenStack Compute (nova) "compute api delete race condition" [Undecided,Fix released] https://launchpad.net/bugs/998117 - Assigned to Mark Washenberger (markwash)08:57
ankit_agftersin_: so we can not keep those changes08:58
*** shuquan has quit IRC08:58
*** shuquan_ has joined #openstack-nova08:58
ftersin_ankit_ag: that bug says that locally deleting of instance when it accures host value is an error08:59
*** vivekd has quit IRC09:00
ftersin_ankit_ag: and to fix this error the exception was introduced and raised09:00
ankit_agftersin_: OK let me check that host point and will come back to you09:00
ankit_agftersin_: Thank you09:01
ftersin_ankit_ag: and this exception handler redirects deleting to compute node09:01
*** vivekd has joined #openstack-nova09:02
*** vivekd_ has joined #openstack-nova09:02
johnthetubaguyneelabh: I would read the API docs: http://developer.openstack.org/ but Nova is only going to let you start VMs, I don't think its what you are looking for, but this is more a conversation for #openstack as they have folks on there to help with usage questions, this is a development focused channel09:02
ftersin_ankit_ag: so i think if now there is no objections to locally delete an instance in such conditions, it's better to remove the excetion at all, instead of re-run instance.destroy09:05
*** vivekd has quit IRC09:06
*** vivekd_ is now known as vivekd09:06
*** lucasagomes has joined #openstack-nova09:06
ankit_agftersin_: There is still that exception is raised in race condition due to which my original patch got reverted. After analysing the every possible race conditions I came to the conclusion to add that exception back09:07
*** shuquan_ has quit IRC09:10
ftersin_ankit_ag: what do you mean? did you already think to remove that exception at all, but decided to leave it?09:10
ftersin_ankit_ag: i mean that the exception is raised to catch certain condition to do rediredt09:11
ankit_agftersin_: Yes in my original patch I had removed that exception which was causing issues in race condition09:12
ftersin_ankit_ag: if you do not do redirection in this condition, you do not need this exception at all09:12
ftersin_ankit_ag: could you please give me a link?09:12
ankit_agftersin_: sure, give me a min please09:13
ankit_agftersin_: https://review.openstack.org/#/c/145738/09:14
*** humble__ has joined #openstack-nova09:16
ftersin_ankit_ag: in which patchset you tryed to remove ObjectActionError exception?09:16
*** vivekd_ has joined #openstack-nova09:17
openstackgerritZhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API  https://review.openstack.org/20991709:17
ftersin_ankit_ag: probably we talk about different exceptions? I talk about ObjectActionError09:17
ftersin_ankit_ag: sorry, not about it...09:18
*** schwicke has quit IRC09:18
ankit_agftersin_: we are talking about ObjectActionError ?09:18
ftersin_ankit_ag: ConstraintNotMet09:19
*** wanghua has quit IRC09:19
ankit_agftersin_: Yes ObjectActionError exception is caught in case of  ConstraintNotMet exception is raised09:20
ftersin_ankit_ag: it was introduced to catch the race to redirect to compute node09:20
*** vivekd has quit IRC09:21
*** vivekd_ is now known as vivekd09:21
ftersin_ankit_ag: so if you do not redirect there in the race condition, why we should keep this exception?09:21
ankit_agftersin_: in master code ConstraintNotMet is moved down the flow of instance.destroy and raised  ObjectActionError from there09:21
ankit_agftersin_: If you see my original patch https://review.openstack.org/#/c/145738/, I had removed this exception but it caused race condition and got reverted09:23
ftersin_ankit_ag: but what the value of this exception? why instance object and db level catch this condition and raise the exception?09:23
ftersin_ankit_ag: in you previous patch you removed handling of this exception, right? or i miss something?09:24
ankit_agftersin_: yes in my previos patch I had removed that09:26
ftersin_ankit_ag: as i understand, this exception is raised specially to catch them in _delete to redirect deletion to compute node09:26
ankit_agftersin_: The exception was caught to handle the condition raised from https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1693 while destoying the instance09:28
*** humble_ has quit IRC09:28
ankit_agftersin_: This is when instance is not found while callinf instance.destroy09:29
ankit_agftersin_: so after catching that exception its the _delete api task to decide how can we cleanup the environment.09:30
ftersin_ankit_ag: not really. The instance is not found with a condition. The condition is host=None09:30
ftersin_ankit_ag: Why this condition is added?09:31
openstackgerritTomi Juvonen proposed openstack/nova-specs: Get valid server state  https://review.openstack.org/19224609:31
ftersin_ankit_ag: It is added to catch the race condition when compute node just set host field, but api node does not know about it09:32
*** markvoelker has joined #openstack-nova09:33
ankit_agftersin_: Or may be the case host has been deleted by another thread09:34
ftersin_ankit_ag: Why this race condition is important, why code catches it? The only handling of it - is redirection to compute node09:34
neelabhI am trying to create the nova client "nova=client.Client(2, 'admin', '1234', 'admin', 'http://10.0.2.15:5000')" But getting error =>novaclient.exceptions.ClientException: Unknown Error (HTTP 300)09:35
ftersin_ankit_ag: i digged the history and found that it was added to catch the same race09:35
ftersin_ankit_ag: see https://review.openstack.org/#/c/7345/09:36
*** markvoelker has quit IRC09:37
ankit_agftersin_: OK I'll test my patch against this race and will come back to you09:38
ankit_agftersin_: Thanks again for your time and help09:38
ftersin_ankit_ag: what if you tests will not find an error?09:39
ftersin_ankit_ag: your09:39
*** shuquan has joined #openstack-nova09:39
*** vivekd has quit IRC09:40
*** vivekd has joined #openstack-nova09:41
ankit_agftersin_: Then I think there should be no issues in merging the pacth as it is :)09:42
*** IanGovett has joined #openstack-nova09:45
ftersin_ankit_ag: But since we do not know what was a reason of 998117, we can not perform an approppriate test, so we can not be sure that 998117 will not return09:45
*** vivekd_ has joined #openstack-nova09:46
*** humble__ has quit IRC09:47
*** vivekd has quit IRC09:48
ankit_agftersin_: If there would have been any race with this patch then IMO jenking would have been failed atleast once on this patch09:48
*** vivekd_ is now known as vivekd09:48
ankit_agftersin_: I have tried running jenkins successfully a number of time before submitting this patch09:48
*** vivekd_ has joined #openstack-nova09:49
*** alexschm has quit IRC09:50
ftersin_ankit_ag: on the other hand, if we're sure that 998117 will not return with you patch which doesn't redirect to compute node, why do we need constraint arg in db.instance_destroy which is intended to redirect destruction to compute node?09:51
*** vivekd__ has joined #openstack-nova09:53
*** vivekd has quit IRC09:53
*** vivekd__ is now known as vivekd09:53
neelabhaarefiev: Hi09:54
*** dims_ has joined #openstack-nova09:54
ankit_agftersin_: we'll need to catch that exception to give another change to destroy instance. In a case when instance is deleted by another thread or api while the main thread is in  db.instance_destroy call.09:54
*** sakaYK has quit IRC09:54
ankit_agftersin_: If that happens we'll need to set database and to clean bdm and network info09:55
*** echoingu_ has quit IRC09:56
*** echoingumesh has joined #openstack-nova09:57
*** vivekd_ has quit IRC09:57
*** apuimedo has joined #openstack-nova09:57
ftersin_ankit_ag: but instance.refresh() fails if the instance is deleted, does not?09:59
*** ttrumm has quit IRC09:59
*** marzif has joined #openstack-nova09:59
ankit_agftersin_: No, instance.refresh() fails if we have deleted instance info_cache10:00
ankit_agbut not the instance10:00
mdboothI saw some discussion yesterday about segfaults in the gate running unit tests10:00
mdboothLooks like one of my patches just hit that, so I'm wondering if anybody has a status10:00
*** echoingumesh has quit IRC10:01
mdboothShortcutting Jenkins on first failure would be really useful. I'm sure this has come up before. Does anybody know why we don't do it?10:04
*** alexschm has joined #openstack-nova10:04
johnthetubaguymdbooth: I think mriedem opened a bug for that, it should be in the nova-meeting log, if that helps10:05
*** p01s0n has joined #openstack-nova10:05
johnthetubaguymdbooth: I think its to avoid it taking several rounds to spot you fail the last test, and its a valid failure, but I can't say I have debated that with infra myself10:06
ftersin_ankit_ag: it calls db.instance_get_by_uuid which calls db._build_instance_get which calls model_query with no read_deleted=True. So i think db.instance_get_by_uuid raises InstanceNotFound for a deleted instance10:06
*** shuquan has quit IRC10:06
p01s0nis there any way to have different allocation ratio for each availability zones .First AZ with default ram/cpu allocation and another with high over provisioning or no over provisioning10:07
mdboothjohnthetubaguy: Thanks10:07
*** kmARC_ has joined #openstack-nova10:08
*** kmARC has joined #openstack-nova10:08
mdboothIt's https://bugs.launchpad.net/nova/+bug/148223010:09
openstackLaunchpad bug 1482230 in OpenStack Compute (nova) "LibvirtConnTestCase.test_clean_shutdown_first_time segfaults" [High,In progress] - Assigned to Matt Riedemann (mriedem)10:09
*** mpaolino has joined #openstack-nova10:10
ankit_agftersin_: For that case InstanceNotFound exception is handled by _delete method https://github.com/openstack/nova/blob/master/nova/compute/api.py#L163510:11
*** mestery_ has joined #openstack-nova10:11
mdboothftersin_: Hey, regarding the image checks thing, I'm going to move some code around anyway, despite what I said yesterday10:12
mdboothReason is, even to reliably know that you don't need to do the tests, you need to know the type of the root device10:12
mdboothAnd given the byzantine possibilities, it seems silly to work that out twice10:13
mdboothHaven't yet decided whether to do the min_disk test, but if it falls out of the code move relatively easily then I'll do it10:14
mdboothBecause it's much nicer to the user10:14
*** Vek has quit IRC10:14
*** mestery has quit IRC10:15
*** masayukig has quit IRC10:15
*** dansmith has quit IRC10:15
ftersin_ankit_ag: ok, but why to call instance.refresh() if it raises this error?10:16
*** loquacities has quit IRC10:16
*** apuimedo has quit IRC10:17
*** apuimedo has joined #openstack-nova10:17
*** dansmith has joined #openstack-nova10:17
*** dansmith is now known as Guest4554110:17
*** masayukig has joined #openstack-nova10:18
*** nikhil_k has quit IRC10:18
ankit_agftersin_:  That is not always true, sometimes we need to call instance.refresh to destroy the instance successfully10:18
*** dosaboy has quit IRC10:18
*** nikhil_k has joined #openstack-nova10:18
*** dosaboy has joined #openstack-nova10:19
*** jistr has quit IRC10:20
*** bradjones has quit IRC10:20
*** ttrumm has joined #openstack-nova10:20
*** beagles has quit IRC10:20
*** jistr has joined #openstack-nova10:20
ftersin_jmdbooth: hi, i agree that user experience is awful now.with that pended test10:21
*** jeblair has quit IRC10:21
*** pixelbeat has joined #openstack-nova10:21
*** loquacities has joined #openstack-nova10:22
*** jeblair has joined #openstack-nova10:22
ftersin_jmdbooth: but it's also good to check not only root bdm parameter, but also other bdms, since thay can also request volumes from images10:24
ftersin_mdbooth: sorry, missed in your nick ^^^^^10:25
mdboothftersin_: I would have to work out what that means10:25
*** shyu has quit IRC10:27
mdboothftersin_: To have that make sense, you'd have to reduce over all bdms with image metadata and take the max of any non-disk requirements you're going to test10:27
mdboothI'm not going there today :)10:28
mdboothI think robustly checking the root disk is a reasonable goal10:28
mdboothThis is a can of works10:28
*** zhenguo has quit IRC10:28
mdbooths/works/worms/10:28
*** otter768 has joined #openstack-nova10:29
mdboothYeah, testing image metadata other than for the boot disk would be a change of behaviour10:29
mdboothI've been burned by that already, so I'd be inclined to do it very carefully. Probably run it past operators first to see if anybody is actually doing that, and if it would break them.10:30
*** bradjones_ has joined #openstack-nova10:30
*** mjturek1 has quit IRC10:30
*** bradjones_ is now known as bradjones10:30
*** mpaolino has quit IRC10:31
*** mpaolino has joined #openstack-nova10:31
*** tsbot_ has quit IRC10:33
*** b3nt_pin_ has joined #openstack-nova10:34
*** ttrumm_ has joined #openstack-nova10:34
*** otter768 has quit IRC10:34
*** baoli has joined #openstack-nova10:35
*** ttrumm has quit IRC10:36
ftersin_mdbooth: compute.api's _validate_bdm is the best place for me to test that10:37
mdboothI looked there. It hasn't finished messing with it at that point10:37
mdboothAfter _check_and_transform_bdm looks the most robust10:38
mdboothAnd no resources have been allocated up to that point in the function10:38
*** josecastroleon has quit IRC10:38
mdboothSo failing later should make no material difference10:38
ftersin_mdbooth: _validate_bdm gets all parts of the bdm, incliding image10:39
mdboothAre you sure?10:39
*** vivekd_ has joined #openstack-nova10:39
*** baoli has quit IRC10:39
mdboothLooks to me like that doesn't happen until _check_and_transform10:39
mdboothSee image_defined_bdms10:39
mdboothAlso, after _check_and_transform they have been converted to object format10:40
mdboothSo you don't have to worry about legacy format10:40
*** vivekd__ has joined #openstack-nova10:43
ftersin_mdbooth: it's called from _provision_instances, this is the last stage of preparation work on api node10:44
mdboothftersin_: I think we're looking at different code10:44
ftersin_mdbooth: all bdm are converted there, user defined and image definde bdms are merged10:44
*** bradjones has quit IRC10:45
*** vivekd has quit IRC10:45
*** chhavi has quit IRC10:45
*** kiran-r has quit IRC10:45
*** alex_klimov has quit IRC10:45
*** shihanzhang has quit IRC10:45
*** ishant has quit IRC10:45
*** hshiina has quit IRC10:45
*** harlowja has quit IRC10:45
*** mtreinish has quit IRC10:45
*** krtaylor has quit IRC10:45
*** openstackgerrit has quit IRC10:45
*** HenryG has quit IRC10:45
*** tobasco has quit IRC10:45
*** _gryf has quit IRC10:45
*** ccesario has quit IRC10:45
*** sdague has quit IRC10:45
*** aignatov has quit IRC10:45
*** _cerberus_ has quit IRC10:45
*** leseb has quit IRC10:45
*** danieru has quit IRC10:45
*** raginbajin has quit IRC10:45
*** dhellmann has quit IRC10:45
*** s1rp_ has quit IRC10:45
*** thomasem has quit IRC10:45
*** vivekd__ is now known as vivekd10:45
gmannalex_xu: hi10:45
mdboothftersin_: You definitely want to do the check before _provision_instances10:45
ftersin_mdbooth: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L124810:45
*** alexschm has quit IRC10:46
gmannalex_xu: I would not be able to join today meeting due to some personal work. I added bug spec in agenda just to ask review on that.10:46
*** tsbot_ has joined #openstack-nova10:46
*** ttrumm_ has quit IRC10:46
gmannalex_xu: sorry for not attending meeting.10:47
mdboothftersin_: Eesh, that's a mess10:47
*** vivekd_ has quit IRC10:47
mdboothThat's wrong. I'm not putting checks there :)10:47
mdboothWe can fix the existing code another time.10:47
mdboothPerhaps that's what you were referring to?10:48
*** rotbeard has joined #openstack-nova10:48
*** mjturek1 has joined #openstack-nova10:49
*** bradjones has joined #openstack-nova10:49
*** chhavi has joined #openstack-nova10:49
*** kiran-r has joined #openstack-nova10:49
*** alex_klimov has joined #openstack-nova10:49
*** shihanzhang has joined #openstack-nova10:49
*** ishant has joined #openstack-nova10:49
*** hshiina has joined #openstack-nova10:49
*** harlowja has joined #openstack-nova10:49
*** mtreinish has joined #openstack-nova10:49
*** krtaylor has joined #openstack-nova10:49
*** openstackgerrit has joined #openstack-nova10:49
*** HenryG has joined #openstack-nova10:49
*** tobasco has joined #openstack-nova10:49
*** ccesario has joined #openstack-nova10:49
*** _gryf has joined #openstack-nova10:49
*** sdague has joined #openstack-nova10:49
*** aignatov has joined #openstack-nova10:49
*** _cerberus_ has joined #openstack-nova10:49
*** leseb has joined #openstack-nova10:49
*** danieru has joined #openstack-nova10:49
*** raginbajin has joined #openstack-nova10:49
*** dhellmann has joined #openstack-nova10:49
*** s1rp_ has joined #openstack-nova10:49
*** thomasem has joined #openstack-nova10:49
*** bradjones has quit IRC10:49
*** mjturek1 has quit IRC10:49
*** mjturek1 has joined #openstack-nova10:49
*** bradjones has joined #openstack-nova10:49
*** bradjones has quit IRC10:49
*** bradjones has joined #openstack-nova10:49
openstackgerritMarian Horban proposed openstack/nova: Added processing /compute URL  https://review.openstack.org/19530310:49
ftersin_ankit_ag: sorry for the pause. Sometimes - when exactly? I know the only reason - it is ConstraintNotMet exception. instance.refresh was added to _delete to honour this exception exactly.10:50
openstackgerritMarian Horban proposed openstack/nova: Added processing /compute URL  https://review.openstack.org/19530310:51
ftersin_mdbooth: as i remember ndipanov wanted to move _validate_bdm outside of create_db_entry_for_new_instance10:53
ftersin_mdbooth: the reason it stays there is races in attachment checks10:54
*** armax has quit IRC10:54
mdboothI was just looking at those10:54
ftersin_mdbooth: but of course, it contains a lot of static checks, which can be performed early10:55
mdboothSo we actually pass instance to check_attach10:55
mdboothThat's unfortunate, because it seems all it needs to check is an availability zone10:55
*** armax has joined #openstack-nova10:55
mdboothftersin_: Do you know what races?10:56
mdboothThe volume can obviously be claimed by something else before it gets to the compute host10:57
*** echoingumesh has joined #openstack-nova10:57
*** mpaolino has quit IRC10:58
*** alexschm has joined #openstack-nova10:58
ftersin_mdbooth: https://review.openstack.org/#/c/95394/10:58
*** Piet has quit IRC10:58
*** kmARC has quit IRC11:00
nagyz_danpb, around?11:00
*** dan has quit IRC11:00
*** kylek3h has joined #openstack-nova11:00
*** sahid has quit IRC11:00
mdboothftersin_: That's exactly the feedback I was looking for, thanks.11:01
*** kmARC_ has quit IRC11:01
*** sahid has joined #openstack-nova11:01
*** echoingumesh has quit IRC11:02
*** dan has joined #openstack-nova11:03
ftersin_mdbooth: see there my suggestion on PS3 and ndipanov's response on PS511:03
mdboothYeah, read that11:03
*** xottabich has joined #openstack-nova11:04
*** vivekd has quit IRC11:04
*** kylek3h has quit IRC11:05
*** kylek3h has joined #openstack-nova11:05
*** kmARC_ has joined #openstack-nova11:05
danpbnagyz_: ?11:05
*** kmARC has joined #openstack-nova11:05
nagyz_danpb, can we discuss the rbd encryption patch from https://review.openstack.org/#/c/206576/ ?11:08
*** kylek3h has quit IRC11:08
*** jaypipes is now known as leakypipes11:11
*** tojuvone has quit IRC11:12
danpbnagyz_: i saw your comments, but i still consider this a feature11:12
danpbthe original crypt code was design for drivers which have a device exposed in the filesystem11:13
danpbso supporting anything else is a feature enhancement for which we should review the design options11:13
nagyz_which none of them had except iSCSI11:13
nagyz_as it was (is?) broken for FC as well11:13
danpbas your change is switching rbd to use the host driver, instead of the direct qemu connection, which is a significant enough change to warrant review11:14
nagyz_no, it's not switching it11:14
nagyz_at least not for the current use cases11:14
nagyz_the switch only occures if someone is using encryption; else it just falls back for the current implementation11:14
danpbthat's still a significant change in architecture11:15
danpbbecause there are now 2 completely different  RBD code paths in play11:15
danpbthat's not something we're going to do as a bug fix11:15
*** lucasagomes is now known as lucas-hungry11:15
nagyz_then we just have to agree to disagree11:15
ftersin_ankit_ag: i have to go out now. i'll think over your arguments. now i think i was not clear in my concern explanation. i'll think over all again and write something in your review11:16
nagyz_so you'd rather ship something that's completely broken in L than have an 8 line fix included?11:16
nagyz_in M everything is moving to os-brick anyway11:16
nagyz_so basically the nova part will be gone11:16
danpbos-brick can't magically solve this11:16
danpbbecause the RBD client is in QEMU11:16
danpbos-brick can't alter that fact11:16
ankit_agftersin_: sorry I was not on my desk.11:17
ankit_agftersin_: I will also looks into the scenario of ConstraintNotMet exception and will check what may be the possible issue.11:18
ankit_agftersin_: Thank you11:18
*** kmARC has quit IRC11:18
nagyz_danpb, IIRC you were here when we were discussing this numerous times before the spec freeze and you haven't objected to it back then. I'd really like to get this into L instead of rolling it into our own tree11:19
*** kylek3h has joined #openstack-nova11:19
*** kmARC_ has quit IRC11:20
danpbnagyz_: discussing problems is not the same as agreeing to implement them in a particular release11:21
*** smatzek has joined #openstack-nova11:22
nagyz_I specifically asked here if it could be considered a bug fix thus not need a spec and the consensus seemed to be a yes :(11:22
danpband in the discussions my focus was on ensuring we have suitable error reporting in the case where encryption is not supported11:22
danpbso that we dont silently ignore the request11:22
nagyz_the only thing that encryption works today AFAIK is iSCSI (maybe FC)11:23
nagyz_*with11:23
*** baoli has joined #openstack-nova11:24
*** baoli has quit IRC11:24
*** baoli has joined #openstack-nova11:26
*** baoli has quit IRC11:26
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor  https://review.openstack.org/21033411:26
*** baoli has joined #openstack-nova11:27
*** yassine_ has quit IRC11:28
*** b3nt_pin_ is now known as b3nt_pin11:28
*** b3nt_pin is now known as Guest397311:29
leakypipesdanpb: morning Dan. I have a refactor/cleanup series for PCI stuff here: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-cleanup,n,z. Would love some reviews if you have a chance. thx in advance :)11:30
danpbleakypipes: is it intended for Lemming ?11:31
leakypipesdanpb: yeah. no bp or bug though... it's cleanup stuff. should I submit a bug for it?11:32
danpblemme see what the codes like :-)11:33
leakypipesdanpb: I'm trying to clean this stuff up to make the resource-objects work (which is priority scheduler stuff) easier to consume and review.11:33
leakypipesdanpb: of course, no worries :)11:33
leakypipesthx for even looking!11:33
danpbright, so if its related to the schedular priority, i don't think cleanups need bugs11:33
* danpb hopes that https://review.openstack.org/#/c/210334/ will fix the gate crashiness11:34
*** markvoelker has joined #openstack-nova11:34
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Support keystone /v3 API url in [neutron]admin_auth_url  https://review.openstack.org/20959911:34
*** rdopiera has quit IRC11:35
*** haomaiwa_ has quit IRC11:37
*** haomaiwa_ has joined #openstack-nova11:38
*** markvoelker has quit IRC11:39
*** chhavi has quit IRC11:39
*** thorst has joined #openstack-nova11:40
*** jcoufal has quit IRC11:40
*** santosh has joined #openstack-nova11:41
santoshHi All11:41
santoshI am facing following problem while restarting nova network at RHEL openstack 6.0 setup11:41
*** p01s0n has quit IRC11:42
santoshAnyone using RHEL openstack?11:43
*** josecastroleon has joined #openstack-nova11:44
leakypipessantosh: pls see /topic :)11:45
*** eliqiao1 has joined #openstack-nova11:46
leakypipesdanpb: reviewed 210334.11:47
eliqiao1hi johnthetubaguy11:47
johnthetubaguyeliqiao1: hello11:47
*** ttrumm has joined #openstack-nova11:47
eliqiao1johnthetubaguy: nice, you are here, alex_xu is not blocking by a heavy rain on his way home, so he can not help to host the nova-api meeting11:48
*** dprince has joined #openstack-nova11:49
*** sudipto_ has joined #openstack-nova11:49
eliqiao1johnthetubaguy:  he's ask if you or sdague can help to host it ? or would you like to cancel it ?11:49
johnthetubaguyeliqiao1: I can start it off, lets see who is around I guess11:49
sdagueyeh, I'm around. Need more coffee though.11:50
eliqiao1johnthetubaguy: okay , cool, thank you11:50
*** sudipto has quit IRC11:51
sdaguedanpb: thanks for digging in on that gate break, looks good11:51
*** chhavi has joined #openstack-nova11:51
danpbsdague: NB, i've no idea if this will fix it, but its worth a punt11:52
danpbif this fails, then i guess we should just try reverting the multiqueue patch entirely to confirm it as the cause11:52
*** sudipto__ has joined #openstack-nova11:54
*** ttrumm has quit IRC11:54
*** Guest3973 is now known as beagles11:56
*** sudipto_ has quit IRC11:56
*** santosh has quit IRC11:58
*** echoingumesh has joined #openstack-nova11:58
mdboothftersin_ ndipanov: Why don't we check_attach a snapshot?12:00
leakypipesdanpb: guh, looks like a search/replace goof in the unit tests for that patch. thanks for the catch. will push a new rev shortly.12:03
*** ttrumm has joined #openstack-nova12:04
mdboothdanpb: I know you -2d mriedem's patch, but I'm pretty sure that mock is a no-op anyway, right?12:07
*** echoingumesh has quit IRC12:07
mdboothThat just creates a context manager, and then throws it away, surely12:07
mdboothWithout ever doing anything with it12:07
mdboothSo it should probably come out anyway, because it's confusing12:08
*** raildo has joined #openstack-nova12:08
mdboothFor reference: https://review.openstack.org/#/c/210036/1/nova/tests/unit/virt/libvirt/test_driver.py,cm12:08
danpbmdbooth: yep, but my patch kills that and more12:08
mdboothAh, ok12:09
danpbi just reverted all the changes to that test suite12:09
danpbinstead of just that 1 line12:09
*** MVenesio has joined #openstack-nova12:09
*** ishant has quit IRC12:10
openstackgerritIldiko Vancsa proposed openstack/nova: api: add soft-affinity policies for server groups  https://review.openstack.org/14752012:10
openstackgerritIldiko Vancsa proposed openstack/nova: Add functional tests to soft affinity capabilities  https://review.openstack.org/14752112:10
*** ttrumm_ has joined #openstack-nova12:12
*** Vek has joined #openstack-nova12:13
openstackgerritRoman Bogorodskiy proposed openstack/nova: Skip SO_REUSEADDR tests on BSD  https://review.openstack.org/19152212:13
*** dave-mccowan has quit IRC12:13
*** ttrumm has quit IRC12:15
*** deepakcs has quit IRC12:15
*** jcoufal has joined #openstack-nova12:18
mdboothdanpb: Have you noticed the pep8 failure in the libvirt patch, btw?12:19
*** GeraldK has joined #openstack-nova12:19
mdbooth./nova/tests/unit/virt/libvirt/test_vif.py:32:1: H306  imports not in alphabetical order (nova.virt.libvirt.vif, nova.virt.libvirt.host)12:20
danpboh dog damn it12:20
*** tojuvone has joined #openstack-nova12:21
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor  https://review.openstack.org/21033412:22
*** lxsli is now known as lexloofah12:22
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor  https://review.openstack.org/21033412:23
*** lucas-hungry is now known as lucasagomes12:24
dims_nova cores, updated quick hit bugs list - https://etherpad.openstack.org/p/liberty-nova-priorities-tracking12:28
dims_leakypipes: sdague: danpb: ^^^12:29
*** moshele has joined #openstack-nova12:29
*** scheuran has quit IRC12:29
*** markvoelker has joined #openstack-nova12:29
*** otter768 has joined #openstack-nova12:30
*** yassine_ has joined #openstack-nova12:31
openstackgerritDmitry Tantsur proposed openstack/nova: Use ironicclient native retries  https://review.openstack.org/21036912:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add api samples impact to microversion devref  https://review.openstack.org/21037012:31
*** dims_ has quit IRC12:33
*** dims_ has joined #openstack-nova12:34
*** otter768 has quit IRC12:35
*** afazekas_ has quit IRC12:36
*** tongli has joined #openstack-nova12:38
*** rdopiera has joined #openstack-nova12:38
*** rdopiera has quit IRC12:39
*** rdopiera has joined #openstack-nova12:39
*** bapalm has joined #openstack-nova12:39
openstackgerritHans Lindgren proposed openstack/nova: Remove/deprecate unused parts of the compute node object  https://review.openstack.org/18675712:41
openstackgerritHans Lindgren proposed openstack/nova: Make ComputeNode.service_id nullable to match db schema  https://review.openstack.org/16928412:41
openstackgerritHans Lindgren proposed openstack/nova: Avoid querying for Service in resource tracker  https://review.openstack.org/16928812:43
*** rdopiera has quit IRC12:46
*** aysyd has joined #openstack-nova12:46
openstackgerritDmitry Tantsur proposed openstack/nova: Ironic: Use ironicclient native retries in ClientWrapper  https://review.openstack.org/21036912:47
*** rdopiera has joined #openstack-nova12:48
*** chuckcarmack has joined #openstack-nova12:51
*** claudiub has joined #openstack-nova12:53
*** hshiina has quit IRC12:54
*** rfolco has joined #openstack-nova12:58
*** zzzeek has joined #openstack-nova12:59
*** tojuvone has quit IRC12:59
*** claudiub has quit IRC13:01
*** ctrath has joined #openstack-nova13:02
sdaguejohnthetubaguy: so can you explain that last bit just for context13:02
sdague<johnthetubaguy> so the history there is, when downloading and uploading, its nice not to have a loadbalancer in the way13:02
sdague<johnthetubaguy> at least, thats why I care about it13:02
sdaguebecause, the only large data flow through nova would be the image proxy, right?13:03
sdaguewhich we're kind of telling people not to use13:03
johnthetubaguywell, how do you avoid using it?13:03
*** rushil has joined #openstack-nova13:03
johnthetubaguywhen you have swift as your backend13:04
johnthetubaguyI could be missing something13:04
*** kiran-r has quit IRC13:04
*** dustins has joined #openstack-nova13:05
*** echoingumesh has joined #openstack-nova13:05
*** rlrossit has joined #openstack-nova13:05
openstackgerritHans Lindgren proposed openstack/nova: Add a VolumeUsage object  https://review.openstack.org/18044213:08
openstackgerritHans Lindgren proposed openstack/nova: Replace conductor proxying calls with the new VolumeUsage object  https://review.openstack.org/18044313:08
openstackgerritHans Lindgren proposed openstack/nova: Remove and deprecate unused conductor method vol_usage_update()  https://review.openstack.org/18044413:08
*** ctrath has quit IRC13:09
sdaguejohnthetubaguy: ok, so maybe I'm missing a bit of the flow13:09
*** eliqiao1 has quit IRC13:09
sdaguebecause if we create a server, POST /v2/{tenant_id}/servers ... not a lot of data anywhere there13:10
johnthetubaguysdague: its the upload and download to swift, that still goes through glance (i wish it didn't, but thats another conversation)13:10
sdaguenova ends up making calls to glance13:10
johnthetubaguyyeah13:10
johnthetubaguysends the disk image to/from glance13:10
sdaguebut that's glance's SC entry13:10
sdaguenot nova's13:10
*** echoingumesh has quit IRC13:10
sdagueGET glance/v2/....13:10
*** logan2 has quit IRC13:11
sdaguefrom nova13:11
johnthetubaguyits more POST glance/v1 <chunked upload of image>13:11
sdaguesure13:11
sdaguebut, the important thing is that the sharding you care about is in glance13:11
sdaguenot in nova13:11
johnthetubaguy(so that v1 shouldn't be exposed to end users, and should only be exposed to nova)13:12
johnthetubaguywell, what we have right now is a list of servers to randomly pick from13:12
johnthetubaguyto distribute the load between glance API boxes13:12
johnthetubaguyif its down, it just tries the next one13:12
sdagueright, which is about glance's service catalog entries13:12
*** logan2 has joined #openstack-nova13:12
johnthetubaguyyeah, thats true13:12
sdaguewhich I'm not currently concerned about13:13
johnthetubaguyOK13:13
sdagueI'm concerned about Nova's service catalog entries that users and other services call13:13
sdaguewhich currently require {tenant_id} in them13:13
sdaguefor I believe no value13:13
johnthetubaguyyes13:13
*** ankit_ag has quit IRC13:14
sdaguethat's the thing I think we should make go away in M & N13:14
openstackgerritJoel Coffman proposed openstack/nova: libvirt: Disconnect dm-crypt on instance suspend/stop  https://review.openstack.org/14148513:14
openstackgerritJoel Coffman proposed openstack/nova: libvirt: Add unit tests for methods  https://review.openstack.org/19888013:14
johnthetubaguynow the one (poor) argument I heard was you can have a proxy infront of the API validate the token matches the tenant in the URL, but thats a layer violation in my book13:14
johnthetubaguyyeah, I was fixating on the dropping our config that hard codes the glance URLs13:14
sdagueoh, right, that's a different thing13:15
*** busterswt has joined #openstack-nova13:15
sdagueoh, so that's why it's still there? you do poor man's sharding by pushing out variants to compute nodes?13:15
sdagueor would {tenant_id} in the glance SC entries be fine for you13:16
johnthetubaguyah, the URL doesn't matter13:17
johnthetubaguyits just the list of hosts I was fixating on13:17
*** jswarren has joined #openstack-nova13:19
johnthetubaguysdague: so totally don't mean to run away mid conversation, but I totally need to go get some lunch from somewhere, back in a little bit13:19
sdagueyep13:19
sdaguewell, I'll write all the details down13:19
*** jdandrea has joined #openstack-nova13:21
*** dustins has quit IRC13:21
*** mriedem has joined #openstack-nova13:21
*** tjones has joined #openstack-nova13:22
* leakypipes now running into this libvirt shutdown bug that danpb was working13:25
*** kylek3h_ has joined #openstack-nova13:25
*** browne has joined #openstack-nova13:25
leakypipesit's hosed up a few test runs now...13:25
danpbleakypipes: yeah its hosed all my patches13:26
*** kylek3h has quit IRC13:27
openstackgerritRyan Rossiter proposed openstack/nova: Fix test_relationships() for subobject versions  https://review.openstack.org/19890413:27
*** cfriesen has joined #openstack-nova13:28
*** edleafe is now known as figleaf13:30
*** rajesht has quit IRC13:30
*** browne has quit IRC13:31
mriedemsudipto__: are you around?13:32
*** ijuwang has joined #openstack-nova13:32
*** leakypipes has quit IRC13:32
*** ctrath has joined #openstack-nova13:33
alex_xujohnthetubaguy: sdague sorry for missing api meeting. One thing I want to ask, so we probably need merged each microversion support on order like server side merged, right? should we send out email to reminder people can write microversion client support now. I'm afraid some contributor already forget that after waiting for such long time.13:34
*** lyanchih has joined #openstack-nova13:34
sdaguealex_xu: sure13:35
sdagueok, well as soon as the nova job completes, danpb's patch should get into the gate13:35
sdaguesorry, the neutron job, which passed, is just uploading logs now13:36
alex_xusdague: ok, thanks, let me send a reminder13:36
*** pixelbeat has quit IRC13:36
andreykurilinsdague, alex_xu: hi! should we update spec due to changes of implementation?13:36
*** VW_ has joined #openstack-nova13:37
danpbsdague: looks like it passed the check queue, so fingers crossed for the gate queue now13:37
*** claudiub has joined #openstack-nova13:37
alex_xuandreykurilin: it will be better, can help people understand how those works, and how they add microversion support.13:37
sdaguedanpb: yep13:37
sdagueandreykurilin: yeh, changes that were made should come back as a spec patch now to just keep it all reflecting reality13:38
*** abhishekk has quit IRC13:38
andreykurilinalex_xu, sdague: ok, I'll change spec13:38
alex_xuandreykurilin: thanks13:38
*** ftersin_ has quit IRC13:39
*** jaypipes has joined #openstack-nova13:39
*** mestery_ is now known as mestery13:40
*** jaypipes is now known as leakypipes13:41
*** dustins has joined #openstack-nova13:42
*** hshiina has joined #openstack-nova13:44
*** tongli has quit IRC13:45
*** mwagner_lap has joined #openstack-nova13:47
mdboothWhat's the difference between the check and gate queues? Assume it's related to what they do with git.13:47
mriedemmdbooth: in the check queue changes are tested in isolation against HEAD, in the gate queue i believe multiple changes are all tested together13:48
mriedemwhich is why sometimes when one thing gets in ahead of you it can break your stuff in the gate queue but not check queue13:48
mriedemsdague and mtreinish can explain it better13:49
*** mnestratov has joined #openstack-nova13:49
mdboothRight, so check literally runs against the commit you submitted, but gate runs against your commit merged to head?13:49
sdaguemdbooth: no13:49
sdaguecheck runs against HEAD13:49
*** edmondsw has joined #openstack-nova13:49
sdaguegate runs speculatively against everything in front of it in the gate13:50
mdboothi.e. your patch rebased on to head?13:50
sdaguethe top of GATE is against HEAD13:50
sdagueyes13:50
*** venkatesh has quit IRC13:50
sdaguehttps://dague.net/2013/02/21/the-openstack-gate/13:51
sdaguesome pictures13:51
mdboothsdague: Thanks13:51
*** jwitko has quit IRC13:52
*** ndipanov has quit IRC13:53
*** tongli has joined #openstack-nova13:57
*** garyk has quit IRC13:57
*** tjones has quit IRC13:58
*** Marga_ has quit IRC13:59
*** jianghua_ has joined #openstack-nova14:00
*** Marga_ has joined #openstack-nova14:01
*** ftersin has joined #openstack-nova14:02
*** eglynn has joined #openstack-nova14:03
mriedemit's interesting that a third party ci system would be running with a different version of oslo.versionedobjects than what jenkins runs do https://review.openstack.org/#/c/210445/14:03
mriedemunless they are using a pypi mirror that didn't have ovo 0.014:03
mriedem*0.6.014:03
*** tjones has joined #openstack-nova14:03
*** ndipanov has joined #openstack-nova14:04
sudipto__mriedem, hi14:06
*** echoingumesh has joined #openstack-nova14:06
dims_mriedem: y, fishy14:07
mriedemdims_: fishy but it did catch that gap in the minimum required version of ovo14:08
mriedemsudipto__: nevermind, i sorted it out ^14:08
dims_mriedem: right14:08
dims_if you remember in mid-cycle we thought there was nothing left for keystone v3...found one - https://review.openstack.org/#/c/209599/14:09
*** diogogmt has joined #openstack-nova14:10
*** lpetrut has joined #openstack-nova14:10
*** jianghua_ has quit IRC14:10
*** echoingumesh has quit IRC14:11
*** alexschm has quit IRC14:11
*** diogogmt has quit IRC14:11
*** ttrumm_ has quit IRC14:11
openstackgerritCale Rath proposed openstack/nova: Make generate_password more secure  https://review.openstack.org/21009214:12
sudipto__mriedem, got it...14:12
*** diogogmt has joined #openstack-nova14:13
*** READ10 has joined #openstack-nova14:15
*** lucas___ has joined #openstack-nova14:15
openstackgerritChuck Carmack proposed openstack/nova: Fix DeprecationWarning when using BaseException.message  https://review.openstack.org/20756014:18
cfriesenalaski: you around?14:18
alaskicfriesen: yep14:19
*** baoli has quit IRC14:20
cfriesenI just reported bug 1482416, was wondering if you might have any suggestions on where to look.14:20
openstackbug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New] https://launchpad.net/bugs/148241614:20
*** baoli has joined #openstack-nova14:20
*** lpetrut has quit IRC14:21
*** alaski is now known as lascii14:21
lasciinothing really jumps out at me.  it's very strange that the constraint would be an issue here since it doesn't affect the column you want to change14:22
openstackgerritAlexis Lee proposed openstack/nova: Make generate_password more secure  https://review.openstack.org/21009214:24
cfriesenlascii: huh..yeah, that's a good point.  even weirder than I thought. :)14:26
lasciicfriesen: I don't think that alter command will work directly with sqlite, so you may want to see what sqlalchemy-migrate is doing under the hood there.  it may be creating a new table and losing the constraint that way14:27
*** diogogmt has quit IRC14:28
lasciicfriesen: you may want to ping zzzeek on this14:28
*** ferest has joined #openstack-nova14:29
*** edmund has joined #openstack-nova14:29
openstackgerritAlexis Lee proposed openstack/nova: Walk through the API, Conductor and Compute code  https://review.openstack.org/21046714:30
openstackgerritJordan Pittier proposed openstack/nova: ScalityVolume:fix how remote FS mount is detected  https://review.openstack.org/21046814:30
*** otter768 has joined #openstack-nova14:31
*** garyk has joined #openstack-nova14:33
*** diogogmt has joined #openstack-nova14:33
*** dane-fichter has joined #openstack-nova14:34
*** otter768 has quit IRC14:35
*** dboik_ has joined #openstack-nova14:36
*** garyk1 has joined #openstack-nova14:37
*** garyk has quit IRC14:37
*** ferest has quit IRC14:38
*** Guest55 has joined #openstack-nova14:39
*** jgriffith is now known as Guest8148614:39
*** Guest55 is now known as jgriffith14:40
*** nelsnelson has joined #openstack-nova14:41
openstackgerritSudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from numa object  https://review.openstack.org/21048014:41
*** hshiina has quit IRC14:46
*** hshiina has joined #openstack-nova14:46
*** ferest has joined #openstack-nova14:46
mriedemdid someone actually give superdan the day off?14:47
Guest45541heh14:47
*** Guest45541 is now known as superdan14:47
mriedemi knew you were hiding14:47
*** superdan is now known as Guest2022214:48
*** xyang has joined #openstack-nova14:48
*** moshele has quit IRC14:49
*** gszasz has quit IRC14:50
*** ttrumm has joined #openstack-nova14:50
*** edmund1 has joined #openstack-nova14:50
*** edmund1 has quit IRC14:50
*** sulo has quit IRC14:50
*** patrickeast has joined #openstack-nova14:51
*** edmund1 has joined #openstack-nova14:51
*** GeraldK has quit IRC14:51
*** ferest has quit IRC14:51
*** xottabich has quit IRC14:51
*** Piet has joined #openstack-nova14:52
*** edmund has quit IRC14:52
*** dims_ is now known as dimsum__14:53
*** dave-mccowan has joined #openstack-nova14:56
*** moshele has joined #openstack-nova14:57
*** moshele has quit IRC14:57
*** Nikolay_St has quit IRC14:57
*** nagyz_ is now known as nagyz14:58
*** tonytan4ever has joined #openstack-nova14:59
*** ildikov has quit IRC14:59
*** lpetrut has joined #openstack-nova14:59
*** sulo has joined #openstack-nova14:59
*** yamahata has joined #openstack-nova15:00
*** kevinbenton has quit IRC15:02
*** ijw has joined #openstack-nova15:02
openstackgerritEd Leafe proposed openstack/nova: Move existing V2 to legacy_v2  https://review.openstack.org/19372515:02
*** kevinbenton has joined #openstack-nova15:03
*** pixelb has joined #openstack-nova15:03
*** ferest has joined #openstack-nova15:03
*** dave-mcc_ has joined #openstack-nova15:03
openstackgerritSudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from network object  https://review.openstack.org/21049015:04
*** sahid has quit IRC15:05
markus_zIf one want's to look at a small review => https://review.openstack.org/#/c/209187/15:05
*** dave-mc__ has joined #openstack-nova15:06
*** sahid has joined #openstack-nova15:06
*** dave-mccowan has quit IRC15:07
*** echoingumesh has joined #openstack-nova15:07
*** browne has joined #openstack-nova15:07
*** dave-mcc_ has quit IRC15:08
johnthetubaguyfigleaf: I just took a look at this: https://review.openstack.org/#/c/193725/3015:09
*** mtanino has joined #openstack-nova15:09
rlrossitleakypipes: Guest20222: https://review.openstack.org/#/c/198904/ needed a rebase but it's back up and raring to go15:09
*** ferest has quit IRC15:09
*** ttrumm has quit IRC15:10
figleafjohnthetubaguy: that was quick!15:10
johnthetubaguyfigleaf: there are two things that looked a bit odd to me15:10
*** nelsnelson has quit IRC15:10
Guest20222whisky tango foxtrot15:10
*** dave-mccowan has joined #openstack-nova15:11
johnthetubaguyfigleaf: literally just got out a meeting15:11
*** Guest20222 is now known as dansmith15:11
figleafjohnthetubaguy: literally just got off a candidate interview :)15:11
*** shyama has quit IRC15:11
rlrossitno need for that type of language dansmith15:11
figleafgs15:11
rlrossitthere are children present15:11
*** echoingumesh has quit IRC15:12
dansmithrlrossit: leakypipes: I just hit that one, it's on its way15:12
*** dave-mcc_ has joined #openstack-nova15:12
alex_xufigleaf: what I can help for https://review.openstack.org/#/c/193725/?15:12
alex_xufigleaf: I saw still have test failed, you get trouble for that? do you need me help on something?15:13
*** dave-mc__ has quit IRC15:13
figleafalex_xu: the ps I just pushed should be working15:14
*** unicell1 has joined #openstack-nova15:14
*** dave-mc__ has joined #openstack-nova15:14
alex_xufigleaf: cool, will catch up review it15:14
figleafalex_xu: the real problems are with the second in the series: https://review.openstack.org/#/c/210131/15:14
*** tsekiyama has joined #openstack-nova15:14
*** dave-mccowan has quit IRC15:15
figleafjohnthetubaguy: yeah, I don't know how those odd changes snuck in. I'll work on cleaning them up15:15
*** dave-mccowan has joined #openstack-nova15:16
alex_xufigleaf: oops, a lot of error15:16
*** unicell has quit IRC15:16
figleafjohnthetubaguy: looks like some git ugliness. Gimme a few to clean them up15:16
alex_xufigleaf: if it is trouble, I can help on debug15:16
*** venkatesh has joined #openstack-nova15:16
*** dave-mcc_ has quit IRC15:17
dane-fichterjcook: I like that comment alot, it does a great job of clarifying your patch's relationship to glanceclient. Definitely will give a +1 as soon as you upload a version in the mitaka folder15:17
*** dave-mcc_ has joined #openstack-nova15:17
venkateshHI all,15:18
venkateshwhat is the current status of the work "Related to blueprint liberty-objects"15:18
alex_xujohnthetubaguy: we have priority feature propose freeze at 17.Aug?15:19
*** dave-mc__ has quit IRC15:19
venkateshi want to start work on it ..15:19
*** dave-m___ has joined #openstack-nova15:19
johnthetubaguyalex_xu: yeah, its down as 18th on my list, but thats the current plan15:19
figleafalex_xu: the second patch set in the series is close. There seems to be a problem in the wsgi mocks that I don't understand15:19
johnthetubaguyalex_xu: that might be a bit too soon I guess15:19
alex_xufigleaf: ok, let me try to debug that15:20
*** kurtmartin has joined #openstack-nova15:20
alex_xujohnthetubaguy: yea, I'm a little afraid remove extension a little slow now15:20
*** dave-mc__ has joined #openstack-nova15:20
*** dave-mccowan has quit IRC15:21
johnthetubaguyalex_xu: yeah, I think we need to look at reducing the scope to the key bits15:21
johnthetubaguyalex_xu: my priority is deprecating v2.0 I guess15:21
johnthetubaguyand deprecating all the configs, etc15:21
alex_xujohnthetubaguy: and freeze the extension API15:22
alex_xujohnthetubaguy: or remove it15:22
*** dave-mcc_ has quit IRC15:22
*** r-daneel has joined #openstack-nova15:22
*** dave-mccowan has joined #openstack-nova15:22
*** mdrabe has quit IRC15:22
*** mdrabe has joined #openstack-nova15:23
johnthetubaguyalex_xu: yeah, we can't remove it, and its already frozen as I understand it, we could remove it in a microversion I guess, but the config stuff is more important, in some ways15:23
alex_xujohnthetubaguy: ok, I see now15:23
mtreinishdimsum__: is it really invalid on nova: https://bugs.launchpad.net/nova/+bug/1482609 the only reason os-testr stack traced was because of a broken subunit stream caused by a segfault15:23
openstackLaunchpad bug 1482609 in os-testr "Intermittent py27 failure - TypeError: unsupported operand type(s" [Medium,Fix released] - Assigned to Matthew Treinish (treinish)15:23
johnthetubaguyalex_xu: next release we can look at dropping the ability to turn stuff off, thats the bit I think thats crazy important15:23
*** dave-m___ has quit IRC15:24
johnthetubaguyalex_xu: unless I am missing something, which I totally could be15:24
*** tjones has quit IRC15:24
alex_xujohnthetubaguy: you mean drop the plugin stuff?15:24
dimsum__mtreinish: there's another bug tracking test_clean_shutdown_failure15:24
johnthetubaguyalex_xu: yeah, next release15:24
johnthetubaguyalex_xu: once we have removed the config, after it was deprecated15:25
alex_xujohnthetubaguy: yea, agree, that need a lot of work also, we can't done in this release15:25
*** dave-mc__ has quit IRC15:25
mtreinishdimsum__: ah ok15:25
johnthetubaguyalex_xu: just want to make sure we get the super critical bits landed, I think sdague is looking at helping make a list of that15:25
*** patrickeast has quit IRC15:25
alex_xujohnthetubaguy: ok, got it15:25
johnthetubaguyalex_xu: I hope you got out of the water OK, BTW15:26
*** dave-mcc_ has joined #openstack-nova15:26
*** dave-mccowan has quit IRC15:27
*** patrickeast has joined #openstack-nova15:27
jcookdane-fichter: thanks :)15:27
alex_xujohnthetubaguy: yea, thanks :) just terrible traffic, stuck on the road two hours...15:27
*** VW_ has quit IRC15:27
*** VW_ has joined #openstack-nova15:28
*** ttrumm has joined #openstack-nova15:28
dane-fichterjcook: np. feel free to ask me for reviews on that whenever.15:28
*** dave-mccowan has joined #openstack-nova15:28
jcookdane-fichter: will do, thanks :)15:29
*** jcoufal has quit IRC15:29
*** ttrumm has quit IRC15:29
*** dave-mc__ has joined #openstack-nova15:30
alex_xusdague: do you need me continue push https://review.openstack.org/202900 or waiting for your devref, I feel the time tight for now.15:30
*** Murali has quit IRC15:31
*** dave-m___ has joined #openstack-nova15:31
*** dave-mcc_ has quit IRC15:31
openstackgerritBalazs Gibizer proposed openstack/nova: Add functional tests to soft affinity capabilities  https://review.openstack.org/14752115:32
*** VW__ has joined #openstack-nova15:32
*** browne has quit IRC15:32
*** VW_ has quit IRC15:32
alex_xusdague: let me know if you need me help on that. I have to go to bed now, otherwise the baby will wakeup after a hour again....15:33
*** dave-mccowan has quit IRC15:33
*** dave-mc__ has quit IRC15:34
mriedemcomstud: https://www.youtube.com/watch?v=z0yYHNEy5Hs15:34
*** dave-mccowan has joined #openstack-nova15:35
*** dave-m___ has quit IRC15:36
*** rdopiera has quit IRC15:37
ftersindansmith: hi. do you know what jaypipes meant in https://review.openstack.org/#/c/170031/4/nova/compute/manager.py15:38
ftersindansmith: why not to get image metadata from instance system metadata?15:38
*** logan2 has quit IRC15:38
dansmithjust a sec15:38
*** mnestratov has quit IRC15:39
*** dave-mcc_ has joined #openstack-nova15:39
dansmithdanpb: we're not persisting the ImageMeta object anywhere yet, so we should still pull things from system_metadata if we just have the instance, right?15:39
danpb yeah15:39
openstackgerritDaniel Berrange proposed openstack/nova: ironic: convert driver to use nova.objects.ImageMeta  https://review.openstack.org/18936215:40
openstackgerritDaniel Berrange proposed openstack/nova: objects: convert config drive to use ImageMeta object  https://review.openstack.org/18932315:40
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: convert driver to use nova.objects.ImageMeta  https://review.openstack.org/18811915:40
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: make instance compulsory in blockinfo APIs  https://review.openstack.org/18811815:40
openstackgerritDaniel Berrange proposed openstack/nova: hyperv: convert driver to use nova.objects.ImageMeta  https://review.openstack.org/18930215:40
openstackgerritDaniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object  https://review.openstack.org/19014515:40
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property  https://review.openstack.org/19014615:40
openstackgerritDaniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta  https://review.openstack.org/18968515:40
openstackgerritDaniel Berrange proposed openstack/nova: xenapi: convert driver to use nova.objects.ImageMeta  https://review.openstack.org/18879015:40
dansmithand you have patches up to return an ImageMeta from that call or something, instead of a dict?15:40
dansmithspeak of the devil :)15:40
danpbinitially we use  objects.ImageMeta.from_instance()  or with that patchset just   instance.image_meta15:40
*** dave-mc__ has joined #openstack-nova15:40
dansmithah, 19014515:41
danpbthe only place the data is persisted is in instance.system_metadata, or in glance / cinder itself15:41
dansmithyeah15:41
*** logan2 has joined #openstack-nova15:41
dansmithftersin: leakypipes: I replied15:41
leakypipesdansmith: ty sir.15:42
leakypipessuperdan.15:42
*** dave-mccowan has quit IRC15:43
ftersindansmith: thanks15:43
dansmithgrr, nickserv is having troubles today15:44
dansmithkeeps flipping me back15:44
*** dave-mcc_ has quit IRC15:44
*** dave-mccowan has joined #openstack-nova15:44
*** rfolco has quit IRC15:44
*** dave-mc__ has quit IRC15:45
*** dave-mcc_ has joined #openstack-nova15:46
*** dave-mc__ has joined #openstack-nova15:47
openstackgerritEd Leafe proposed openstack/nova: Move existing V2 to legacy_v2  https://review.openstack.org/19372515:47
*** dave-mccowan has quit IRC15:48
*** dave-mccowan has joined #openstack-nova15:49
mriedemleakypipes: do you know if there is any reason why nova sends the service catalog in the header when making glance requests?15:49
mriedemhttps://github.com/openstack/nova/blob/master/nova/image/glance.py#L11215:49
leakypipesmriedem: lol, no idea.15:49
mriedemif you have a bunch of endpoints in your service catalog that shit blows up15:50
mriedem400 Header Line Too Long15:50
*** dave-mcc_ has quit IRC15:50
figleafjohnthetubaguy: pushed the fixes15:50
*** dave-mcc_ has joined #openstack-nova15:50
*** belmoreira has quit IRC15:51
mriedemleakypipes: i'll push a change to remove that15:51
mriedemsince we use the auth_token middleware it's unused15:51
mtreinishmriedem: I think the catalog gets returned from keystone on get token requests, but that's different15:51
johnthetubaguyfigleaf: cool, I am attempting to dig into those other test failures15:51
mriedemmorganfainberg_: ^ can you confirm?15:51
johnthetubaguyfigleaf: just having setup issues, but getting to the end of those now I hope15:51
leakypipesmriedem: yes, please do. git blame isn't really showing the source of that.15:51
figleafjohnthetubaguy: thx15:51
mriedemleakypipes: it's uber hold15:51
mriedem*old15:51
*** dave-mc__ has quit IRC15:52
*** belmoreira has joined #openstack-nova15:52
dansmithif glance needs it for some reason, it'd get it from keystone when it auths the token anyway, right?15:52
*** belmoreira has quit IRC15:52
leakypipesmriedem: ichi setthi: https://github.com/openstack/nova/commit/5bb1803cfd82eceec09765fb3c41e9e571364a9415:52
mriedemdansmith: yeah15:52
mriedemprobably predated the keystone auth token middleware stuff15:52
*** dave-mc__ has joined #openstack-nova15:53
*** Nikolay_St has joined #openstack-nova15:53
leakypipesmriedem: I was at AT&T working in Chef Hell.15:53
leakypipesmriedem: I accept no responsibility :)15:53
mriedemleakypipes: well15:53
mriedemthat's a funny coincidence15:53
mriedemit's AT&T hitting this :)15:54
*** dave-mccowan has quit IRC15:54
dansmithkarma is a bitch15:54
*** dansmith is now known as superdan15:54
*** tjones has joined #openstack-nova15:54
*** dave-mccowan has joined #openstack-nova15:54
*** dave-mcc_ has quit IRC15:55
leakypipeslol15:55
*** echirivella has quit IRC15:56
*** dave-mcc_ has joined #openstack-nova15:56
*** sajeesh has joined #openstack-nova15:57
*** dave-mc__ has quit IRC15:57
*** dave-mccowan has quit IRC15:59
johnthetubaguyfigleaf: going to rebase phase 2 on top of your latest phase 1, to see if that helps the test failures15:59
superdanmriedem: what is the patch we're waiting on to fix the gate?15:59
johnthetubaguyfigleaf: I have the tests passing on your latest phase 1, which is a start16:00
mriedemsuperdan: my efforts failed16:00
mriedemsuperdan: so there isn't one16:00
superdanI thought danpb had a patch16:00
superdanalso it appears to not be 100% fail.. I thought it was16:00
*** dave-mccowan has joined #openstack-nova16:01
mriedemyeah apparently not http://status.openstack.org/elastic-recheck/index.html16:01
mriedemit's top though16:01
danpbmy patch merged about 40 mins ago16:02
openstackgerritJay Pipes proposed openstack/nova: Allow compute monitors in different namespaces  https://review.openstack.org/20949916:02
mriedemhttps://review.openstack.org/#/c/210334/16:02
leakypipessudipto__, alex_xu: fix for the compute monitor namespace thing...16:02
mriedemdanpb: there is no reason to -2 my fix16:02
mriedemit's still a fix16:02
danpbhave we seen any failures for builds which started /after/16:02
danpbmriedem: my fix included your fix too, as i simply reverted all the changes too that test file16:02
mriedemdanpb: https://review.openstack.org/#/c/210036 still cleans up a useless thing, it doesn't close the bug, so i can remove that if it's contentious16:02
danpbthe whole set of changes was bogus16:03
superdanmriedem: I still don't understand why you think that's a useless mock16:03
*** dave-mc__ has joined #openstack-nova16:03
mriedemsuperdan: because as i understand it mock.patch.object is only useful as a decorator or context manager16:03
superdanmriedem: I think that's not true16:04
*** dave-mcc_ has quit IRC16:04
superdanmriedem: but the thing being mocked needs to return true in order for the tests to behave properly, right?16:04
mriedemthe test cases were already decorated with the same thing16:04
mriedemto pass the host.min_version check16:04
*** dave-mcc_ has joined #openstack-nova16:04
superdanah, I missed that16:04
superdanmriedem: seems to work fine as a regular patcher, fwiw16:06
*** dave-m___ has joined #openstack-nova16:06
*** salv-orl_ has joined #openstack-nova16:06
*** dave-mccowan has quit IRC16:06
superdanI just tested16:06
mriedemdanpb: so https://review.openstack.org/#/c/210334/ is a total revert of https://review.openstack.org/#/c/128829/ ?16:06
*** jlanoux has quit IRC16:07
mriedemno16:07
*** MarcF has quit IRC16:07
*** dave-mccowan has joined #openstack-nova16:07
danpbmriedem: no, its a total revert of the test suite changes to test_driver.py16:08
*** dave-mc__ has quit IRC16:08
danpbalong with fixing the brokeness in driver.py16:08
*** echoingumesh has joined #openstack-nova16:08
*** salv-orlando has quit IRC16:08
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: set caps on maximum live migration time  https://review.openstack.org/16225416:08
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: take account of disks in migration data size  https://review.openstack.org/20663216:08
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: support management of downtime during migration  https://review.openstack.org/16225316:08
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: add helper methods for getting guest devices/disks  https://review.openstack.org/20663116:08
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: ensure LibvirtConfigGuestDisk parses readonly/shareable flags  https://review.openstack.org/20663016:08
*** dave-mcc_ has quit IRC16:09
*** dave-mcc_ has joined #openstack-nova16:09
openstackgerritRyan Rossiter proposed openstack/nova: Add hacking check for greenthread.spawn() and eventlet.spawn()  https://review.openstack.org/19571316:09
*** josecastroleon has quit IRC16:09
rlrossitmriedem: I think ^ stopped just being a trivial rebase because moving from eventlet to nova utils caused a unit test failure in hyperv stuff.16:10
*** gordc has joined #openstack-nova16:10
*** tjones has quit IRC16:10
mriedemi knew adding eventlet.spawn() to that would make it more complicated16:10
gordchi folks, had a historical question. when glance/cinder split from nova, do you know how quickly the existing code in nova was removed? was there a cycle of deprecation or was it immediate?16:10
rlrossithere's the failure if you care about that: https://jenkins04.openstack.org/job/gate-nova-python27/1697/console16:10
*** dave-m___ has quit IRC16:10
*** dave-mc__ has joined #openstack-nova16:10
superdanmriedem: so if I change that mock from True to False, I get more test failures16:10
superdanmriedem: so I think it does need to be mocked in setUp(), we just need to properly start() it to be correct16:11
mriedemgordc: it's still a work in progress16:11
mriedemsuperdan: gross16:11
*** patrickeast has quit IRC16:11
mriedemi'd prefer to just see the actual test cases that need it to mock it for their test cases, not all test cases16:11
*** meghal has joined #openstack-nova16:11
mriedemsince that would fudge up negative tests too16:11
*** dave-m___ has joined #openstack-nova16:11
superdanmriedem: yep, happy to have that too, just saying I think removing it means we're dependent on what that thing actually returns, which is wrong16:12
gordcmriedem: ... oh. so there's still cinder code in nova?16:12
*** patrickeast has joined #openstack-nova16:12
*** dave-mccowan has quit IRC16:13
*** echoingumesh has quit IRC16:13
gordci guess the followup question when did the nova-version of cinder stopped being packaged16:13
*** dave-mccowan has joined #openstack-nova16:13
mriedemgordc: i remember nova-volume being in folsom16:13
mriedemgone in grizzly https://github.com/openstack/nova/tree/grizzly-eol/bin16:13
*** alex_klimov has quit IRC16:13
mriedemgordc: the comment was a bit misleading on my part,16:14
*** dave-mcc_ has quit IRC16:14
mriedemthe libvirt volume drivers are just now getting pulled out of nova per os-brick16:14
mriedemthey are duplicated into cinder originally, now that's all be lifted into os-brick and re-used in cinder and nova16:14
mriedemand nova still have volume apis16:14
*** dave-mcc_ has joined #openstack-nova16:15
mriedemthe actual nova-volume service stuff was gone in grizzly though16:15
gordc... yikes. ok. glance was released in essex?16:15
*** dave-mc__ has quit IRC16:15
mriedemthe glance split was before i hit puberty i think, ask leakypipes :)16:15
leakypipesgordc: cactus.16:15
mriedemhi-o!16:15
leakypipesmaybe bexar16:15
gordcdaaaamnnnn...lol16:16
openstackgerritDaniel Berrange proposed openstack/nova: libvirt: check min required qemu/libvirt versions on s390/s390x  https://review.openstack.org/18348616:16
openstackgerritEmma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size  https://review.openstack.org/20956416:16
figleafleakypipes: yeah, it was probably in bexar16:16
* leakypipes retreats with smoking jacket, billfold, and pipe into the drawing room16:16
*** dave-mc__ has joined #openstack-nova16:16
superdanheh16:16
*** dave-m___ has quit IRC16:16
*** ftersin has quit IRC16:16
*** unicell1 has quit IRC16:17
mriedemimagine there is bear skin rugs, a fire, well oiled leather and mahogeny16:17
gordcwe're splitting off some code in ceilometer, and was wondering how long i had to keep original code around... seems like 'immediate removal' is not an optoin16:17
mriedemgnocchi?16:17
gordcleakypipes: thanks for history lesson16:17
*** dave-mccowan has quit IRC16:17
*** dave-m___ has joined #openstack-nova16:18
gordcmriedem: aodh... we've move alarming code into it's own repo16:18
*** eglynn has quit IRC16:18
gordcgnocchi was all new so it was always separate16:18
*** venkatesh has quit IRC16:18
*** burgerk has joined #openstack-nova16:18
*** leeantho has joined #openstack-nova16:19
*** patrickeast has quit IRC16:19
*** dave-mcc_ has quit IRC16:19
mriedemwell i'd say at least 6 month deprecation cycle16:19
*** dave-mccowan has joined #openstack-nova16:20
*** armax has quit IRC16:20
mriedemN at earliest?16:20
*** nic has joined #openstack-nova16:20
*** echoingumesh has joined #openstack-nova16:20
*** echoingumesh has quit IRC16:20
gordcmriedem: yeah seems like that's what needs to be done here.16:20
openstackgerritShiina, Hironori proposed openstack/nova: Add a compute RPC API to inject an NMI  https://review.openstack.org/20260516:20
*** dave-mc__ has quit IRC16:20
gordcmriedem: we've already stopped development this cycle so we'll aim for M* removal.16:21
mriedemgordc: but when did the deprecation warning go into release notes and code?16:21
mriedemK or L?16:21
* gordc needs to make sure packagers make both ceilo-alarms and aodh16:21
openstackgerritMatt Riedemann proposed openstack/nova: Don't pass the service catalog when making glance requests  https://review.openstack.org/21051516:22
mriedemleakypipes: superdan: ^ should be trivial16:22
*** dave-m___ has quit IRC16:22
*** patrickeast has joined #openstack-nova16:23
gordcit was decided at summit... or pre-summit. we definitely want it gone as soon as it can16:23
*** dave-mcc_ has joined #openstack-nova16:23
*** dave-mccowan has quit IRC16:24
*** ijuwang has quit IRC16:25
*** xyang1 has joined #openstack-nova16:26
*** ssurana has joined #openstack-nova16:27
*** sahid has quit IRC16:27
*** patrickeast has quit IRC16:28
*** jistr has quit IRC16:28
*** ericksonfgds is now known as ericksonsantos16:28
*** dave-mccowan has joined #openstack-nova16:29
openstackgerritCarlos Gonçalves proposed openstack/python-novaclient: Support forcing service down  https://review.openstack.org/18584916:30
*** xyang1 has quit IRC16:30
*** agireud has joined #openstack-nova16:30
johnthetubaguyfigleaf: this change is doing my head in, the tests are super confusing...16:30
*** dave-mcc_ has quit IRC16:30
johnthetubaguyfigleaf: I really think we would be better of moving all the code, then moving all the tests16:31
johnthetubaguyfigleaf: change set wise16:31
*** bapalm has quit IRC16:31
*** dave-mcc_ has joined #openstack-nova16:31
*** otter768 has joined #openstack-nova16:32
*** lucas___ has quit IRC16:32
figleafjohnthetubaguy: you mean start all over again?16:33
smatzekdanpb: should disk_format be a field on ImageMeta? There are several places in the drivers that are using it.  Some go to system metadata directly even though image_meta is local, some are in snapshot and are using meta from glance, those are OK.  A a few places are like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L426, and I don't know how that will work once image_meta is an object.16:34
*** dave-mccowan has quit IRC16:34
*** lucas___ has joined #openstack-nova16:35
johnthetubaguyfigleaf: yeah, it sounds bad like that16:35
johnthetubaguyfigleaf: lets see how this goes16:35
*** dave-mccowan has joined #openstack-nova16:35
*** gordc has left #openstack-nova16:35
johnthetubaguyfigleaf: currently doing a manual rebase of all the test files, so its kinda being re-done in some ways16:36
*** otter768 has quit IRC16:36
*** dave-mcc_ has quit IRC16:37
*** dave-mc__ has joined #openstack-nova16:37
danpbsmatzek: err, it is already a field in ImageMeta16:37
figleafjohnthetubaguy: yeah, since the test files reference the moved api files, they always have to change16:37
figleafgs16:37
figleafdoh!16:37
danpbsmatzek: this series converts all existing code to use ImageMeta object  https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:virtimageprops-19,n,z16:38
*** patrickeast has joined #openstack-nova16:39
*** dave-mcc_ has joined #openstack-nova16:39
*** lucas___ has quit IRC16:39
*** dave-mccowan has quit IRC16:40
*** unicell has joined #openstack-nova16:40
*** dave-mc__ has quit IRC16:41
*** ildikov has joined #openstack-nova16:42
smatzekdanpb:  smatzek face-palms.  Thank for pointing out the obvious. I was so focused on the fields in ImageMetaProps I completely missed the ImageMeta fields.16:43
*** jgriffith has quit IRC16:44
*** rotbeard has quit IRC16:44
*** marzif has quit IRC16:45
*** kiran has joined #openstack-nova16:45
*** dave-mccowan has joined #openstack-nova16:45
*** xyang2 has joined #openstack-nova16:45
dimsum__mriedem: was there a bug opened for that segmentation fault in test_clean_shutdown_failure?16:47
*** iamjarvo has joined #openstack-nova16:47
leakypipesmriedem: done16:47
*** dave-mcc_ has quit IRC16:47
danpbdimsum__: https://bugs.launchpad.net/nova/+bug/148223016:47
openstackLaunchpad bug 1482230 in OpenStack Compute (nova) "LibvirtConnTestCase.test_clean_shutdown_first_time segfaults" [High,Fix committed] - Assigned to Daniel Berrange (berrange)16:47
*** meghal has quit IRC16:48
openstackgerritCarlos Gonçalves proposed openstack/python-novaclient: Support forcing service down  https://review.openstack.org/18584916:48
*** tojuvone has joined #openstack-nova16:49
dimsum__thanks danpb16:49
danpbfingers crossed it is fixed now16:49
superdanleakypipes: is it worth getting a sign-off from another glance person?16:50
*** dave-mcc_ has joined #openstack-nova16:50
leakypipesdanpb: I've rebased onto that patch for 3 different branches locally and have not run into the bug again yet (about 5 test runs)16:50
dimsum__:)16:50
superdanI mean if it passes tests, then it's probably good, but we do use v1 and something else could lurk16:50
leakypipessuperdan: sorry, for what?16:50
superdanleakypipes: the glance service catalog thing16:50
*** claudiub has quit IRC16:50
leakypipessuperdan: no, I don't think so. It's really the keystone folks that are the correct SMEs there.16:51
superdanokay16:51
*** kiran-r has joined #openstack-nova16:51
*** dave-mccowan has quit IRC16:51
*** dave-mccowan has joined #openstack-nova16:51
*** tonytan4ever has quit IRC16:52
openstackgerritEd Leafe proposed openstack/nova: Move existing V2 to legacy_v2  https://review.openstack.org/19372516:52
openstackgerritEd Leafe proposed openstack/nova: Move the v3 files into the main directories  https://review.openstack.org/21013116:52
figleafjohnthetubaguy: alex_xu: ^ pushed a rebased version of step 216:52
*** penick has joined #openstack-nova16:53
*** rfolco has joined #openstack-nova16:53
*** dave-mc__ has joined #openstack-nova16:54
*** dave-mcc_ has quit IRC16:54
kiranHi Every one, I'm from Cisco Nexus 1000v team. I have a question on the 'vhost-user' VIF driver. Today the  'plug' api 'plug_vhostuser()' in 'vif.py' supports OVS plug. We need to extend it to Nexus1000v plug. I want to check if there is some work to extend vhost-user interface to other than OVS plug.16:55
johnthetubaguyfigleaf: I have just finished that myself, hence the note above, never mind16:55
*** claudiub has joined #openstack-nova16:55
johnthetubaguyI think i screwed it up though, so I will try the other one16:56
*** dave-mccowan has quit IRC16:56
*** MentalRay has joined #openstack-nova16:57
*** dave-mccowan has joined #openstack-nova16:57
*** penick has quit IRC16:57
*** iamjarvo has quit IRC16:57
*** lucasagomes is now known as lucas-beer16:58
*** dave-mcc_ has joined #openstack-nova16:58
*** dave-mc__ has quit IRC16:59
*** lucas___ has joined #openstack-nova16:59
*** meghal has joined #openstack-nova16:59
*** MentalRay has quit IRC17:00
*** meghal has quit IRC17:00
*** dprince has quit IRC17:01
*** dave-mccowan has quit IRC17:02
openstackgerritZhongcheng Lao proposed openstack/nova: Skip detach when volume is no longer in-use  https://review.openstack.org/21053417:02
*** salv-orlando has joined #openstack-nova17:02
*** MentalRay has joined #openstack-nova17:03
*** lucas___ has quit IRC17:03
*** dave-mccowan has joined #openstack-nova17:04
*** MentalRay has quit IRC17:04
*** lucas___ has joined #openstack-nova17:05
*** dave-mcc_ has quit IRC17:06
*** salv-orl_ has quit IRC17:06
*** kiran-r has quit IRC17:07
johnthetubaguyfigleaf: looking at that first patch, its this bit that confuses me: nova/tests/functional/test_access_ips.py17:07
johnthetubaguyfigleaf: why did you move those?17:07
*** dave-mcc_ has joined #openstack-nova17:08
*** exploreshaifali has joined #openstack-nova17:09
*** dannywilson has joined #openstack-nova17:09
*** browne has joined #openstack-nova17:10
figleafjohnthetubaguy: because you asked me to? :) See your comment on PS 24 from Aug 5 09:3817:11
*** dave-mccowan has quit IRC17:11
johnthetubaguyfigleaf: that was not about nova/tests/functional/v3/test_networks.py that was about nova/tests/unit/api/openstack/compute/contrib/test_access_ips.py right?17:12
johnthetubaguythe v3 ones are v3, the contrib ones are v217:13
johnthetubaguyanyways, I think its getting closer now here17:13
*** danpb has quit IRC17:13
*** dave-mccowan has joined #openstack-nova17:13
figleafjohnthetubaguy: ah - wrong 'test_access_ips' :(17:14
*** kiran has left #openstack-nova17:14
*** dave-mcc_ has quit IRC17:14
johnthetubaguyfigleaf: those ones in the functional directory really really need to be in a sub directory, maybe api_v21 or something like that17:15
figleafjohnthetubaguy: it moved from nova/tests/functional/v3 to nova/tests/functional. Probably should have been in phase 217:15
johnthetubaguyyeah, should have been phase2, and into a sub directory, but lets level that for right this second, just finishing off the tests17:15
*** dave-mcc_ has joined #openstack-nova17:16
*** vilobhmm has joined #openstack-nova17:16
*** dave-mc__ has joined #openstack-nova17:18
*** dave-mccowan has quit IRC17:18
*** apuimedo has quit IRC17:20
*** meghal has joined #openstack-nova17:21
*** dave-mcc_ has quit IRC17:21
*** apuimedo has joined #openstack-nova17:22
*** VW__ has quit IRC17:22
*** tjones has joined #openstack-nova17:23
*** VW_ has joined #openstack-nova17:23
*** VW_ has quit IRC17:23
*** VW_ has joined #openstack-nova17:24
*** nic1 has joined #openstack-nova17:24
johnthetubaguyfigleaf: seeing the same failures we had before, once I fixed up the rebase17:25
*** dave-mccowan has joined #openstack-nova17:25
johnthetubaguyfigleaf: I think we need to go back and tidy up that first change, there is stuff thats moved to odd locations, let me add comments17:25
*** nic has quit IRC17:26
johnthetubaguyfigleaf: I am thinking we should go back to patchset 24, were life was simpler?17:27
*** praneshp has joined #openstack-nova17:27
*** dave-mcc_ has joined #openstack-nova17:27
*** markus_z has quit IRC17:27
*** dave-mc__ has quit IRC17:28
johnthetubaguyfigleaf: I wonder if we should do this in a feature branch, so we get the single commit merge back in, that might be easier17:28
*** VW__ has joined #openstack-nova17:28
*** VW_ has quit IRC17:28
*** thorst has quit IRC17:28
johnthetubaguyfigleaf: sorry, I am exhausted now, and not making progress, I am probably going to call it a day in a little bit17:29
*** ijw has quit IRC17:29
figleafjohnthetubaguy: understood. I'm stressed a bit too - closing on a house later this afternoon :)17:29
*** dave-mccowan has quit IRC17:30
*** meghal has quit IRC17:31
_gryfsuperdan, hi :)17:31
*** dave-mcc_ has quit IRC17:31
*** hshiina has quit IRC17:31
*** meghal has joined #openstack-nova17:31
*** shyama has joined #openstack-nova17:32
superdan_gryf: hola17:32
*** dave-mccowan has joined #openstack-nova17:32
*** meghal has quit IRC17:32
*** meghal has joined #openstack-nova17:32
*** ndipanov has quit IRC17:32
_gryfsuperdan, about the patch https://review.openstack.org/#/c/209766/ . Is there still nothing we can do about that mr jenkins failure?17:32
*** VW__ has quit IRC17:32
*** ftersin has joined #openstack-nova17:33
superdan_gryf: I think the patch we think will fix it just landed17:33
superdan_gryf: so, try a recheck17:33
superdanif it passes, it'll go in17:33
*** READ10 has quit IRC17:33
_gryfsuperdan, cool. I'm on it17:33
*** dave-mcc_ has joined #openstack-nova17:33
*** bertys_ has joined #openstack-nova17:34
leakypipessuperdan: https://review.openstack.org/#/c/146887/ if you have a chance. had a +2 from danpb before a rebase, but danpb is gone now.17:35
superdanokay in a sec17:36
*** dave-mccowan has quit IRC17:36
*** dave-mccowan has joined #openstack-nova17:38
*** dave-mcc_ has quit IRC17:39
*** dave-mcc_ has joined #openstack-nova17:43
*** achanda has joined #openstack-nova17:44
*** dave-mccowan has quit IRC17:45
*** bertys_ has quit IRC17:46
*** dave-mccowan has joined #openstack-nova17:46
*** dave-mcc_ has quit IRC17:47
sdaguejohnthetubaguy: ok, here's kind of a new standing agenda for the API meeting - https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda17:48
cfriesenzzzeek: you around?17:48
zzzeekcfriesen: hey17:50
*** dave-mcc_ has joined #openstack-nova17:51
*** thorst has joined #openstack-nova17:51
*** ijuwang has joined #openstack-nova17:52
*** ijw has joined #openstack-nova17:52
*** dave-mccowan has quit IRC17:53
*** burgerk has quit IRC17:55
cfriesenzzzeek: I recently reported bug 1482416 and alaski suggested I ping you.17:55
openstackbug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New] https://launchpad.net/bugs/148241617:55
*** hshiina has joined #openstack-nova17:55
*** VW_ has joined #openstack-nova17:55
*** lucas___ has quit IRC17:56
*** dave-mccowan has joined #openstack-nova17:56
cfriesenzzzeed: it seems to be due to the fact that sqlite doesn't support altering columns, but it's colliding with constraints on other columns and I don't know enough about what's going on under the hood17:57
*** iamjarvo has joined #openstack-nova17:57
*** dave-mc__ has joined #openstack-nova17:58
*** dave-mcc_ has quit IRC17:59
zzzeekim goign to guess this is the same code that iterates through tables in test teardown and emits DROP CONSTRAINT for all the foreign keys ?18:01
zzzeekoh18:01
*** dave-mccowan has quit IRC18:01
zzzeekcfriesen: nova doesnt support changes in column types anymore18:02
zzzeekcfriesen: that wont work with non-scripted online schema migrations18:02
*** dave-mccowan has joined #openstack-nova18:02
harlowjais there a scheduling subchannel ?18:05
harlowjaand/or gantt channel?18:05
*** ssurana has quit IRC18:05
*** hshiina has quit IRC18:05
*** dave-mc__ has quit IRC18:05
*** dannywilson has quit IRC18:05
harlowjaand/or other place?18:05
*** dannywilson has joined #openstack-nova18:06
*** salv-orlando has quit IRC18:07
*** dave-mcc_ has joined #openstack-nova18:07
*** dave-mccowan has quit IRC18:09
mriedemfigleaf: ^18:09
cfriesenzzzeek: we supported it before, so what changed? (And what's the issue, since it seems to work at runtime with a "real" DB.)18:09
*** rushil has quit IRC18:10
*** jdandrea has left #openstack-nova18:10
mriedemcfriesen: it's part of the larger effort to have no downtime upgrades, so the schema changes are additive until there is one big constraction that you opt into when ready18:10
mriedemfrom what i understand anyway18:10
cfriesenzzzeed: also, what's the "correct" way to handle something like this?18:10
*** dave-mccowan has joined #openstack-nova18:11
mriedemcfriesen: see https://review.openstack.org/#/c/197349/18:11
cfriesenmriedem: okay, will take a look18:11
*** kmARC has joined #openstack-nova18:11
zzzeekcfriesen: im not a nova dev.   take a look at http://docs.openstack.org/developer/nova/devref/upgrade.html18:12
zzzeekcfriesen: as far as “whats the issue”, noted on the bug report.   nova should not be testing migrations against sqlite18:12
*** kmARC_ has joined #openstack-nova18:12
*** dave-mc__ has joined #openstack-nova18:12
cfriesenzzzeek: are the nova devs aware of this? :)18:13
*** dave-mcc_ has quit IRC18:13
zzzeekcfriesen: probably18:13
cfriesenmriedem: I see.  And changing a column type counts as a subtractive change.18:14
*** armax has joined #openstack-nova18:14
mriedemcfriesen: well, sqlite doesn't support alter18:14
mriedemso in sqlite land you have to drop and add18:14
*** kurtmartin has quit IRC18:14
*** dave-mcc_ has joined #openstack-nova18:15
cfriesenmriedem: okay, makes sense.  thanks.18:15
mriedeme.g. https://github.com/stackforge/sqlalchemy-migrate/commit/ae64d828df9debe61283ca7aa436bdbf0b49d0e718:15
*** dave-mccowan has quit IRC18:15
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Copy cli arguments in api_versions.wraps decorator  https://review.openstack.org/21056318:16
*** ijw_ has joined #openstack-nova18:16
*** dave-mccowan has joined #openstack-nova18:16
openstackgerritSergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP  https://review.openstack.org/17372318:17
*** dave-mc__ has quit IRC18:17
openstackgerritVilobh Meshram proposed openstack/nova-specs: Quota by Flavor, Quota by AZ, Quota by X  https://review.openstack.org/20616018:18
*** shyama has quit IRC18:18
mriedemcfriesen: notes in https://bugs.launchpad.net/nova/+bug/1482416/comments/418:18
openstackLaunchpad bug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New]18:18
openstackgerritRyan Rossiter proposed openstack/nova: Set vif and allocated when associating fixed ip  https://review.openstack.org/19713518:19
*** ijw has quit IRC18:19
openstackgerritSergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP  https://review.openstack.org/17372318:19
*** rlrossit has left #openstack-nova18:19
*** dave-mcc_ has quit IRC18:20
*** dave-mccowan has quit IRC18:21
*** josecastroleon has joined #openstack-nova18:21
cfriesenmriedem: zzzeek: thanks guys.  mriedem: are you aware of any plans to drop migration testing on sqlite?  or do we just live with the limitations?18:21
*** sudipto__ has quit IRC18:21
mriedemeliqiao: are you going to rebase this at some point? https://review.openstack.org/#/c/156112/18:22
mriedemcfriesen: i'm not aware of plans to stop using sqlite in db migration testing18:22
*** lpetrut has quit IRC18:22
*** dave-mccowan has joined #openstack-nova18:24
*** patrickeast has quit IRC18:24
*** ssurana has joined #openstack-nova18:25
*** xyang2 has quit IRC18:26
*** bapalm has joined #openstack-nova18:26
*** imcsk8 has joined #openstack-nova18:27
imcsk8hello, is the nova v3 api still experimental?18:28
mriedemimcsk8: v3 is v2.1 and no18:28
mriedemit's CURRENT18:28
*** dave-mcc_ has joined #openstack-nova18:29
mriedemhttp://docs.openstack.org/developer/nova/index.html#compute-api-references18:29
mriedemimcsk8: maybe helpful https://www.openstack.org/summit/vancouver-2015/summit-videos/presentation/introduction-of-a-new-nova-rest-api-why-we-need-to-use-nova-v2-1-api18:30
* mriedem thinks maybe we should link that summit video into the docs18:30
imcsk8mriedem: thanks18:31
*** dave-mc__ has joined #openstack-nova18:31
*** dave-mccowan has quit IRC18:32
*** otter768 has joined #openstack-nova18:33
*** xyang2 has joined #openstack-nova18:33
*** dave-mcc_ has quit IRC18:33
*** melwitt has joined #openstack-nova18:33
*** xyang2 has quit IRC18:34
figleafharlowja: no, no separate scheduling channel. Dis is da place18:34
harlowjafigleaf ok, i just started https://review.openstack.org/#/c/210549/ which thought those folks might be interested in18:35
harlowja(imho something long overdue, and i *think* gantt  folks and others want to get there to...)18:35
*** meghal has quit IRC18:36
*** dave-mccowan has joined #openstack-nova18:36
figleafharlowja: be sure to add it to the scheduler for Monday's meeting at 1400UTC18:36
harlowjak, i'll try :-P18:36
harlowjaor will just use spec/ML for this stuff, ha18:36
*** dave-mcc_ has joined #openstack-nova18:37
figleafharlowja: fwiw, I think that you might need a bit more detail. We all want a scheduler-for-all-the-things, but how to achieve that is where it gets contentious18:37
*** otter768 has quit IRC18:37
*** bapalm has quit IRC18:38
harlowjafigleaf of course, its a WIP after all ;)18:38
harlowjaand thats why we have this cross-project stuff in the first place, and a TC body and blah blah18:38
*** dave-mc__ has quit IRC18:38
figleafharlowja: heh18:38
harlowjaif we can't get past the 'contentious' part, we are all screwed18:38
harlowja*imho*18:38
figleafharlowja: I just meant that actual designs get more eyeballs than generic "we need to be better" stuff18:39
*** lyanchih has quit IRC18:39
*** dave-mc__ has joined #openstack-nova18:39
chhavijohnthetubaguy: We are looking at the proposed shared volume feature.  We'd like to implement it for our PowerVM driver as well, but if there is anything more general that we can do to help in the M release, can you let me know?18:39
figleafharlowja: of course, there will be dozens of people ready to tell you why your ideas can never work, but that seems to be typical around here18:39
harlowjafigleaf understood, imho its a balance because, actual designs to early create locally optimally project decisions, which is how we got in this situation in the first place18:40
harlowja:-P18:40
*** dave-mccowan has quit IRC18:40
figleafharlowja: only if they have a single project in mind.18:40
mriedemlascii: http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/screen-n-cpu.txt.gz18:40
mriedembw_usage[field] = db_bw_usage['uuid']18:40
mriedemTypeError: 'NoneType' object has no attribute '__getitem__'18:41
figleafharlowja: if they are designed to be project-agnostic, much less so18:41
*** yassine_ has quit IRC18:41
mriedemlascii: that's from https://review.openstack.org/#/c/189397/ but that's a long time ago18:41
mriedemhrm oslo.versionedobjects==0.7.018:41
*** dave-mccowan has joined #openstack-nova18:41
harlowjafigleaf agreed, its a multi-dimensonal strike force kind of effort required here, haha18:41
mriedem0.7.0 released on 8/318:42
*** dave-mcc_ has quit IRC18:42
harlowjau take the left flank, lol18:42
*** ftersin has quit IRC18:42
*** xyang2 has joined #openstack-nova18:43
*** dave-mcc_ has joined #openstack-nova18:43
figleafharlowja: https://www.youtube.com/watch?v=Nrh5YOQHvFw18:43
mriedemBobBall: are you around?18:43
*** dave-mc__ has quit IRC18:43
harlowjafigleaf nice :)18:44
harlowjapew pew pew18:44
harlowjalol18:44
*** xyang2 has quit IRC18:44
*** dave-mc__ has joined #openstack-nova18:44
dimsum__"I don't listen to hip-hop"!18:45
*** dave-m___ has joined #openstack-nova18:46
lasciimriedem: is that a xenserver run?18:46
mriedemyeah18:46
*** dave-mccowan has quit IRC18:46
openstackgerritJay Pipes proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker  https://review.openstack.org/21018218:47
openstackgerritJay Pipes proposed openstack/nova: pci: Remove get_pci_devices_filter() method  https://review.openstack.org/21018318:47
openstackgerritJay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device status  https://review.openstack.org/21018018:47
openstackgerritJay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device type  https://review.openstack.org/21018118:47
lasciithat needs another, related, fix.  but I thought it had merged a while ago18:47
*** meghal has joined #openstack-nova18:47
*** dave-mccowan has joined #openstack-nova18:47
*** dave-mcc_ has quit IRC18:47
mriedemhttps://bugs.launchpad.net/nova/+bug/148273818:47
openstackLaunchpad bug 1482738 in OpenStack Compute (nova) "_poll_bandwidth_usage task fails to create bw usage object with TypeError" [Undecided,New]18:47
mriedemi guess since it's a periodic task no one would notice18:47
lasciiyeah, and only on xen18:47
mriedemthat task only works for xen18:48
mriedem?18:48
*** bapalm has joined #openstack-nova18:48
*** bapalm has quit IRC18:48
lasciipossibly others now, but xen is the only driver I know of that implements the method it relies on18:48
mriedemInterval to pull network bandwidth usage info. Not '                     'supported on all hypervisors. Set to -1 to disable. '                     'Setting this to 0 will run at the default rate.18:49
mriedemyeah, i guess the help says that18:49
*** dave-mc__ has quit IRC18:49
*** dave-mcc_ has joined #openstack-nova18:49
lasciioh, the other fix didn't merge yet18:49
lasciihttps://review.openstack.org/#/c/172524/18:50
*** chhavi has quit IRC18:50
lasciimissed that it was still open18:50
mriedemrechecked :)18:50
mriedemc'mon lascii!18:50
*** dave-m___ has quit IRC18:50
lasciiI know, my shame is visible to all now18:51
melwittI was about to ask if that review is needed to stop this bug. I'm too slow18:51
openstackgerritJay Pipes proposed openstack/nova: Refactor unit test for InstanceGroup objects  https://review.openstack.org/19722818:51
*** dave-mccowan has quit IRC18:51
*** josecastroleon has quit IRC18:51
*** dave-mccowan has joined #openstack-nova18:52
mriedemlascii: is there potentially any goofy thing with the xenserver driver and how it uploads images to glance via some plugin that it requires the x-service-catalog entry in the glance api request header?18:53
*** rfolco has quit IRC18:53
mriedemplease say no, please say no, please say no18:53
*** agireud_ has joined #openstack-nova18:53
lasciimriedem: ye... no18:54
mriedemFailure: ['XENAPI_PLUGIN_FAILURE', 'upload_vhd', 'PluginError', 'Got Permanent Error response [404] while uploading image [a19c924d-50f7-4649-a78b-ad80543ba8d9] to glance host [192.168.33.1:9292]']18:54
*** dave-mcc_ has quit IRC18:54
mriedemhttp://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/screen-n-cpu.txt.gz18:54
*** dave-mcc_ has joined #openstack-nova18:54
*** ttrumm has joined #openstack-nova18:54
*** kmARC has quit IRC18:55
*** kmARC_ has quit IRC18:55
*** agireud has quit IRC18:55
*** agireud_ is now known as agireud18:55
lasciimriedem: the interesting logs for that are going to be on the dom0, not the compute logs18:56
*** dboik_ has quit IRC18:57
*** dave-mccowan has quit IRC18:57
mriedemdo those get published for xenserver ci runs?18:57
mriedemnot seeing anything18:58
*** jecarey has joined #openstack-nova18:58
mriedemooo http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/var/log/index.html18:58
*** dave-mccowan has joined #openstack-nova18:59
*** neelabh has quit IRC18:59
*** yamahata has quit IRC18:59
*** dave-mcc_ has quit IRC19:00
lasciihmm, not finding the plugin logs.  though I can never remember which log they're in19:01
*** Piet has quit IRC19:02
lasciiAug 07 17:30:40 localhost glance: ERROR    Unexpected response while doing a HEAD call to image 7bc054ef-a379-4259-8369-e9a82d47d1ed , url = http://192.168.33.1:9292/v1/images/7bc054ef-a379-4259-8369-e9a82d47d1ed , Response Status: 40419:02
*** dave-mcc_ has joined #openstack-nova19:02
*** Piet has joined #openstack-nova19:02
*** xyang2 has joined #openstack-nova19:03
*** xyang2 has quit IRC19:04
*** tjones has quit IRC19:05
*** dave-mccowan has quit IRC19:05
*** tjones has joined #openstack-nova19:07
*** burgerk has joined #openstack-nova19:09
openstackgerritMatt Riedemann proposed openstack/nova: docs: add link to liberty summit session on v2.1 API  https://review.openstack.org/21058719:09
mriedemlascii: ok, i just wanted to make sure that glance wasn't expecting x-service-catalog per https://review.openstack.org/#/c/210515/19:09
mriedem*xenapi19:09
mriedemsince it was added for some xen thing back in the day, and there are related xenapi unit tests19:09
*** dave-mccowan has joined #openstack-nova19:10
*** jecarey has quit IRC19:11
*** smatzek has quit IRC19:11
*** davideagnello has joined #openstack-nova19:12
*** ttrumm has quit IRC19:13
*** dave-mcc_ has quit IRC19:13
*** busterswt has quit IRC19:13
lasciimriedem: gotcha.  that was never really a xen thing, it was for our noauth glance setup19:13
lasciixen just passed it through19:14
*** jecarey has joined #openstack-nova19:15
*** davideag_ has quit IRC19:15
lasciiand as far as I can tell it's not something we use.  I can't find any code for it19:15
mriedemok, cool19:16
*** dave-mcc_ has joined #openstack-nova19:16
mriedemi know you rax boyz and your crazy glance adventures19:16
lasciiyep, it mostly consists of glance drinking too much and making a mess for the rest of us to clean up19:16
mriedemlike this http://logs.openstack.org/00/209200/11/check/gate-neutron-lbaasv1-dsvm-api/e205cb7/logs/screen-g-api.txt.gz#_2015-08-07_18_47_55_31319:18
*** dave-mccowan has quit IRC19:18
*** burgerk has quit IRC19:18
mriedemhttp://goo.gl/C459X619:18
*** dave-mccowan has joined #openstack-nova19:19
*** echoingumesh has joined #openstack-nova19:19
*** dave-mcc_ has quit IRC19:20
mriedemmtreinish: figured it out19:20
mriedemhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/disable_by_file.py#L4919:20
mriedemhttp://git.openstack.org/cgit/openstack/glance/tree/etc/glance-api-paste.ini#n5619:20
mriedem/etc/glance/healthcheck_disable doesn't exist19:21
mriedemhttp://logs.openstack.org/00/209200/11/check/gate-neutron-lbaasv1-dsvm-api/e205cb7/logs/etc/glance/19:21
mriedemblam19:21
mtreinishah, ok that would do it19:22
*** dave-mcc_ has joined #openstack-nova19:22
*** xyang2 has joined #openstack-nova19:22
*** xyang2 has quit IRC19:24
*** agireud has quit IRC19:24
*** dave-mccowan has quit IRC19:24
*** agireud has joined #openstack-nova19:27
*** tongli has quit IRC19:28
*** yamahata has joined #openstack-nova19:28
*** dave-mccowan has joined #openstack-nova19:30
*** dave-mcc_ has quit IRC19:32
*** claudiub has quit IRC19:33
*** dave-mcc_ has joined #openstack-nova19:33
*** meghal has quit IRC19:33
*** exploreshaifali has quit IRC19:34
*** alexpilotti has quit IRC19:35
*** dave-mccowan has quit IRC19:36
*** tjones has quit IRC19:36
*** ildikov has quit IRC19:37
*** claudiub has joined #openstack-nova19:38
*** dave-mccowan has joined #openstack-nova19:39
*** boris-42 has joined #openstack-nova19:40
*** dave-mcc_ has quit IRC19:41
*** MVenesio has quit IRC19:45
*** andrewbogott has left #openstack-nova19:46
*** dannywilson has quit IRC19:47
*** dave-mcc_ has joined #openstack-nova19:47
melwittlascii: I was just looking at https://review.openstack.org/#/c/207587/ and was wondering, if the instance doesn't exist in the child cell, how does instance_destroy_at_top get called by that child? I thought it would error out before it could call destroy_at_top19:48
*** dave-mccowan has quit IRC19:50
*** dave-mccowan has joined #openstack-nova19:51
lasciimelwitt: let me dig that up.  That's what I would have expected as well since this case isn't really accounted for, but it was getting called somewhere19:52
*** dave-mc__ has joined #openstack-nova19:52
*** dave-mcc_ has quit IRC19:52
*** echoingumesh has quit IRC19:53
*** dave-mcc_ has joined #openstack-nova19:54
*** dane-fichter has quit IRC19:54
*** echoingumesh has joined #openstack-nova19:54
melwittlascii: and getting called without "id" set, I also didn't yet find how that's possible since I thought the instance is looked up in the db at the top first, then passed down to the child and back up. I didn't find the Instance construction with just the uuid19:54
lasciimelwitt: there's still some spots where objects are getting converted to uuids to be passed around in cells19:55
*** salv-orlando has joined #openstack-nova19:55
*** dave-mccowan has quit IRC19:55
*** xyang1 has joined #openstack-nova19:55
*** dave-mccowan has joined #openstack-nova19:55
*** dave-mc__ has quit IRC19:57
*** ildikov has joined #openstack-nova19:57
melwittlascii: I think maybe I see it, in cells/messaging.py L68719:57
*** iamjarvo has quit IRC19:57
lasciimelwitt: close, 83219:58
*** VW_ has quit IRC19:58
lasciicalled from http://git.openstack.org/cgit/openstack/nova/tree/nova/cells/messaging.py#n86819:58
*** echoingumesh has quit IRC19:58
*** dave-mcc_ has quit IRC19:58
melwittlascii: ah, okay. there we go19:58
*** VW_ has joined #openstack-nova19:58
lasciiI could try reusing instance there, but I'm not sure what state it's in after the failed refresh19:59
lasciimaybe I should copy it first, in case19:59
*** dave-mcc_ has joined #openstack-nova20:00
*** dave-mcc_ has quit IRC20:00
*** salv-orlando has quit IRC20:01
*** dave-mccowan has quit IRC20:01
*** VW_ has quit IRC20:03
melwittlascii: hm, yeah maybe. I was just trying to wrap my brain around what was going on. it would seem like we could reuse it, a copy, considering we must have looked it up at the top in the first place20:03
melwittI'm not against looking it up again20:07
*** achanda has quit IRC20:08
*** salv-orlando has joined #openstack-nova20:09
*** echoingumesh has joined #openstack-nova20:12
*** meghal has joined #openstack-nova20:12
lasciimelwitt: okay.  looking it up again keeps the fix in one place.  otherwise I think there's 3 places that would need to be updated.  not a big deal, but the current fix is a bit more future proof20:14
*** Guest81486 is now known as jgriffith20:16
*** meghal has quit IRC20:17
melwittlascii: yeah, I think that makes sense20:20
*** albertom has joined #openstack-nova20:23
openstackgerritShiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI  https://review.openstack.org/20261720:23
*** xyang has quit IRC20:28
*** lucas-beer has quit IRC20:29
*** otter768 has joined #openstack-nova20:33
*** zul has joined #openstack-nova20:36
*** ijw has joined #openstack-nova20:36
*** tojuvone has quit IRC20:36
*** otter768 has quit IRC20:38
*** ijw_ has quit IRC20:40
*** dustins has quit IRC20:41
*** rushil has joined #openstack-nova20:43
*** agireud has quit IRC20:50
leakypipeslascii, melwitt: would love reviews/feedback from you guys on this patch series, if you have any free time :) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-cleanup,n,z20:55
*** logan2 has quit IRC20:56
*** raildo has quit IRC20:57
melwittleakypipes: sure, will take a look20:58
*** agireud has joined #openstack-nova20:58
*** chuckcarmack has left #openstack-nova20:59
openstackgerritHans Lindgren proposed openstack/nova: Remove/deprecate unused parts of the compute node object  https://review.openstack.org/18675720:59
openstackgerritHans Lindgren proposed openstack/nova: Make ComputeNode.service_id nullable to match db schema  https://review.openstack.org/16928420:59
openstackgerritHans Lindgren proposed openstack/nova: Avoid querying for Service in resource tracker  https://review.openstack.org/16928821:00
*** salv-orlando has quit IRC21:00
leakypipesmelwitt: cheers21:00
lasciileakypipes: it's at the front of the queue for monday.  company is arriving so I need to bail here21:00
leakypipeslascii: no worries, thanks Andrew! :) enjoy company21:01
*** htruta has quit IRC21:02
*** lascii is now known as alaski21:02
alaskileakypipes: thanks21:02
*** meghal has joined #openstack-nova21:07
*** agireud has quit IRC21:08
*** achanda has joined #openstack-nova21:10
*** lpetrut has joined #openstack-nova21:10
*** aysyd has quit IRC21:12
*** ijw_ has joined #openstack-nova21:14
*** Piet has quit IRC21:14
mriedemleakypipes: i added rlrossit21:16
mriedemhe'll be happy to review objects patches21:16
*** ijw has quit IRC21:16
leakypipesthx!21:17
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Copy cli arguments in api_versions.wraps decorator  https://review.openstack.org/21056321:18
*** meghal has quit IRC21:20
*** mvensky has joined #openstack-nova21:22
*** mriedem has quit IRC21:24
*** markvoelker has quit IRC21:28
*** Piet has joined #openstack-nova21:30
*** baoli has quit IRC21:31
*** meghal has joined #openstack-nova21:33
*** meghal has quit IRC21:34
*** meghal has joined #openstack-nova21:34
*** logan2 has joined #openstack-nova21:39
*** VW_ has joined #openstack-nova21:40
*** ctrath has quit IRC21:44
*** patrickeast has joined #openstack-nova21:48
*** VW__ has joined #openstack-nova21:50
*** tjones has joined #openstack-nova21:50
*** salv-orlando has joined #openstack-nova21:52
*** VW_ has quit IRC21:53
openstackgerritHans Lindgren proposed openstack/nova: Remove/deprecate conductor instance_update()  https://review.openstack.org/18915521:54
openstackgerritHans Lindgren proposed openstack/nova: Make compute manager instance updates use objects  https://review.openstack.org/18915421:54
openstackgerritHans Lindgren proposed openstack/nova: Consolidate _set_instance_error_state() methods  https://review.openstack.org/21061421:54
*** VW__ has quit IRC21:54
*** mriedem has joined #openstack-nova21:54
mvenskyany hints are where to start with nova source; any good docs/references21:57
mvensky?21:57
melwittmvensky: http://docs.openstack.org/developer/nova/21:59
*** salv-orlando has quit IRC22:02
mvenskythanks melwitt22:04
*** mdrabe has quit IRC22:07
*** thorst has quit IRC22:08
*** tjones has quit IRC22:13
*** lpetrut1 has joined #openstack-nova22:15
*** lpetrut has quit IRC22:18
*** dims_ has joined #openstack-nova22:18
*** nikhil_k has quit IRC22:19
*** nikhil_k has joined #openstack-nova22:20
*** tjones has joined #openstack-nova22:21
*** sulo has quit IRC22:21
*** edmondsw has quit IRC22:21
*** dimsum__ has quit IRC22:22
*** sulo has joined #openstack-nova22:23
*** rushil has quit IRC22:24
cfriesenI'm running "nova stop" as a regular user but nova-api is seeing the command come in with an admin context.  Anyone have any ideas what might cause that?  (This is with a modified kilo/stable, so it's entirely possible we screwed something up.)22:25
cfriesenThe "nova start" command is seen as having the expected context.22:26
*** Piet has quit IRC22:26
zzzeekOK, I am totally at a loss for how https://review.openstack.org/#/c/192760/14 is passing tests on the gate, the same tests that run there fail as expected for me at http://paste.openstack.org/show/412236/, because the code is wrong22:26
*** figleaf is now known as edleafe22:26
zzzeekmaybe oslo.db versions are different22:26
*** markvoelker has joined #openstack-nova22:28
*** tsekiyama has quit IRC22:30
*** r-daneel has quit IRC22:31
*** mtanino has quit IRC22:31
*** tsekiyama has joined #openstack-nova22:33
*** claudiub has quit IRC22:33
*** markvoelker has quit IRC22:33
*** otter768 has joined #openstack-nova22:34
*** davideagnello has quit IRC22:37
*** davideagnello has joined #openstack-nova22:37
*** tjones has quit IRC22:39
*** otter768 has quit IRC22:39
*** edmund1 has quit IRC22:39
mvenskyI'm relatively new to python and wanted to use openstack/nova to get deeper into the language; I've downloaded the source; any hints on where to start in the code to start understanding it; or architectual docs that will help guide me along?22:42
* zzzeek suggests, get a drink first 22:43
mvenskydone thank, next22:43
zzzeekthat’s all I know about nova source :)22:43
*** salv-orlando has joined #openstack-nova22:44
mvenskyoh good, I thought it was going to be difficult22:44
*** leeantho has quit IRC22:45
*** Nikolay_St has quit IRC22:45
zzzeekmvensky: if you want to study source code to learn more about python, id suggest reading armin ronacher’s code.  like the source to jinja222:47
zzzeekmvensky: plenty of deep things there22:48
zzzeekmvensky: and he writes the cleanest most sophisticated code of like anyone22:48
*** nic1 has quit IRC22:49
*** zul has quit IRC22:49
*** mwagner_lap has quit IRC22:49
*** bradjones has quit IRC22:49
*** changbl has quit IRC22:49
*** mtanino has joined #openstack-nova22:49
mvenskyzzzeek: what about looking at "main" for nova and trying to see how the system  "boots" or is that just way too deep?22:49
zzzeekmvensky: i cannot follow that code, and just tried again a couple of weeks ago and gave up again, and I wrote SQLAlchemy22:51
*** mwagner_lap has joined #openstack-nova22:51
openstackgerritAlberto Murillo proposed openstack/nova: Create additional hosts file for dnsmasq before using it.  https://review.openstack.org/21062722:52
mvenskywelp, that gives me some pause; I think I'll try armin's code22:52
*** zul has joined #openstack-nova22:54
*** meghal has quit IRC22:54
*** bradjones has joined #openstack-nova22:55
*** bradjones has quit IRC22:55
*** bradjones has joined #openstack-nova22:55
*** changbl has joined #openstack-nova22:56
*** claudiub has joined #openstack-nova22:56
zzzeekmvensky: i think nova’s startup syssttem is just very very spread out among different libraries22:56
zzzeekmvensky: it just does one little thing here , one little thing there, and there’s a lot going on w/ eventlet and such22:56
*** patrickeast has quit IRC22:57
*** salv-orl_ has joined #openstack-nova22:57
*** salv-orlando has quit IRC22:59
*** jdurgin has quit IRC23:05
openstackgerritPengtao Huang proposed openstack/nova: change the volue "vol" to "bdm"  https://review.openstack.org/20821123:07
*** otter768 has joined #openstack-nova23:11
*** zzzeek has quit IRC23:12
*** logan2 has quit IRC23:15
*** meghal has joined #openstack-nova23:16
*** salv-orl_ has quit IRC23:17
*** salv-orlando has joined #openstack-nova23:19
*** mwagner_lap has quit IRC23:22
*** kevinbenton has quit IRC23:25
*** kevinbenton has joined #openstack-nova23:27
*** salv-orlando has quit IRC23:28
*** salv-orlando has joined #openstack-nova23:28
*** ijw has joined #openstack-nova23:28
*** ijw_ has quit IRC23:30
alex_xusdague: nice agenda, it also helpful clear what worktiem we track now. learn a lot, thanks23:30
openstackgerritNicolas Simonds proposed openstack/nova: EC2 API: make describe_instances() respect filters  https://review.openstack.org/21063723:34
*** Piet has joined #openstack-nova23:49
*** tsekiyam_ has joined #openstack-nova23:54
*** mtanino has quit IRC23:56
*** tsekiyama has quit IRC23:57
*** mvensky has quit IRC23:57
*** tsekiyam_ has quit IRC23:58
*** salv-orlando has quit IRC23:59
*** markvoelker has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!