Wednesday, 2015-05-27

*** emagana has quit IRC00:01
*** annegentle has quit IRC00:04
*** ijw_ has joined #openstack-nova00:08
*** annegentle has joined #openstack-nova00:09
*** ZZelle_ has quit IRC00:10
*** ijw has quit IRC00:11
*** nelsnelson has quit IRC00:11
*** markvoelker has joined #openstack-nova00:16
*** tjones1 has joined #openstack-nova00:16
*** alanf-mc has joined #openstack-nova00:19
*** david-lyle has quit IRC00:20
*** annegentle has quit IRC00:21
*** Sukhdev has joined #openstack-nova00:22
*** wwriverrat has quit IRC00:22
*** sdake has quit IRC00:22
*** davideagnello has quit IRC00:23
*** markvoelker has quit IRC00:23
*** markvoelker has joined #openstack-nova00:23
*** salv-orlando has joined #openstack-nova00:25
*** davideagnello has joined #openstack-nova00:25
*** exploreshaifali has quit IRC00:26
*** annegentle has joined #openstack-nova00:27
*** mohitsharma has joined #openstack-nova00:29
*** davideagnello has quit IRC00:29
*** yingjun has joined #openstack-nova00:31
*** davideagnello has joined #openstack-nova00:33
*** ddutta has joined #openstack-nova00:34
*** mohitsharma has quit IRC00:34
*** annegentle has quit IRC00:36
*** otter768 has joined #openstack-nova00:39
*** otter768 has quit IRC00:44
*** yamahata has quit IRC00:44
*** nelsnelson has joined #openstack-nova00:46
*** zhenguo has joined #openstack-nova00:46
*** ddutta has quit IRC00:58
*** salv-orlando has quit IRC01:03
*** tobe has joined #openstack-nova01:09
*** dims has quit IRC01:12
*** tjones1 has left #openstack-nova01:12
*** patrickeast has quit IRC01:14
*** mohitsharma has joined #openstack-nova01:17
*** dsanders has quit IRC01:18
*** jamielennox|away is now known as jamielennox01:23
*** garloff has joined #openstack-nova01:26
*** mohitsharma has quit IRC01:26
*** alanf-mc has quit IRC01:27
*** annegentle has joined #openstack-nova01:27
*** annegentle has quit IRC01:28
*** garloff_ has quit IRC01:29
*** david-lyle has joined #openstack-nova01:35
*** thorst has quit IRC01:39
*** ijw has joined #openstack-nova01:39
*** popw has joined #openstack-nova01:42
*** ijw_ has quit IRC01:42
*** electrocucaracha has quit IRC01:44
*** annegentle has joined #openstack-nova01:49
*** kaufer has joined #openstack-nova01:50
*** Sukhdev has quit IRC01:51
*** jyuso has quit IRC01:51
wanghaoandrearosa: hi~, I see the review in https://review.openstack.org/#/c/84048. Will update it today.:)01:52
*** yamahata has joined #openstack-nova01:53
*** kiran-r has joined #openstack-nova01:55
*** dave-mccowan has joined #openstack-nova02:00
*** bzhao has joined #openstack-nova02:02
*** salv-orlando has joined #openstack-nova02:04
*** zhangtralon has joined #openstack-nova02:04
*** pixelb has quit IRC02:09
*** salv-orlando has quit IRC02:09
openstackgerritwanghao proposed openstack/nova-specs: Support force detach volume to nova  https://review.openstack.org/8404802:09
*** unicell has quit IRC02:11
*** kiran-r has quit IRC02:17
*** salv-orlando has joined #openstack-nova02:21
*** yingjun has quit IRC02:21
*** salv-orlando has quit IRC02:25
openstackgerritChangBo Guo(gcb) proposed openstack/nova: libvirt: simplify logic of checking PCI device's existence  https://review.openstack.org/14540002:29
*** kiran-r has joined #openstack-nova02:31
*** yingjun has joined #openstack-nova02:31
*** david-lyle has quit IRC02:33
*** gyee has quit IRC02:36
*** annegentle has quit IRC02:38
*** ijw has quit IRC02:39
*** otter768 has joined #openstack-nova02:40
*** annegentle has joined #openstack-nova02:40
*** claudiub has quit IRC02:41
*** zhangtralon has quit IRC02:44
*** dsanders has joined #openstack-nova02:44
*** otter768 has quit IRC02:44
*** yingjun has quit IRC02:46
*** whenry has joined #openstack-nova02:47
*** nic has quit IRC02:47
*** gokrokve has joined #openstack-nova02:52
*** nelsnelson has quit IRC02:53
*** yingjun has joined #openstack-nova02:53
*** nelsnelson has joined #openstack-nova02:54
*** whenry has quit IRC02:56
*** browne has quit IRC03:00
*** dave-mccowan has quit IRC03:04
*** bzhao has quit IRC03:04
openstackgerritSabari proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0  https://review.openstack.org/18583003:05
*** gokrokve has quit IRC03:06
*** gokrokve has joined #openstack-nova03:07
*** tobe has quit IRC03:08
*** RuiChen has joined #openstack-nova03:10
*** gokrokve has quit IRC03:11
*** david-lyle has joined #openstack-nova03:11
*** veena has joined #openstack-nova03:13
*** kiran-r has quit IRC03:18
*** norman has joined #openstack-nova03:18
*** kaisers has quit IRC03:20
*** salv-orlando has joined #openstack-nova03:21
*** fawadkhaliq has joined #openstack-nova03:22
*** tobe has joined #openstack-nova03:26
*** VW has joined #openstack-nova03:26
*** salv-orl_ has joined #openstack-nova03:28
*** salv-orlando has quit IRC03:29
*** browne has joined #openstack-nova03:30
*** salv-orl_ has quit IRC03:32
*** annegentle has quit IRC03:32
*** changbl has joined #openstack-nova03:32
*** triggerz has quit IRC03:34
*** dave-mccowan has joined #openstack-nova03:36
*** salv-orlando has joined #openstack-nova03:36
*** annegentle has joined #openstack-nova03:37
*** dsanders has quit IRC03:40
*** salv-orlando has quit IRC03:41
*** salv-orl_ has joined #openstack-nova03:43
*** salv-orl_ has quit IRC03:43
*** VW has quit IRC03:44
*** VW has joined #openstack-nova03:45
*** diga has joined #openstack-nova03:51
*** emagana has joined #openstack-nova03:51
*** yingjun has quit IRC03:52
*** armax has quit IRC03:54
*** Sukhdev has joined #openstack-nova03:58
*** tobe has quit IRC03:58
*** deepthi has joined #openstack-nova04:01
*** achanda has joined #openstack-nova04:02
*** krtaylor has joined #openstack-nova04:03
*** dsanders has joined #openstack-nova04:06
*** rajesht has joined #openstack-nova04:06
*** rajesht has quit IRC04:08
*** dave-mccowan has quit IRC04:09
*** dbyte has joined #openstack-nova04:10
*** abhishekk has joined #openstack-nova04:13
*** links has joined #openstack-nova04:15
openstackgerritEric Brown proposed openstack/nova: VMware: use predefined constant for os_type  https://review.openstack.org/18583604:19
*** xyang1 has quit IRC04:20
*** Nikolay_St has quit IRC04:23
*** annegentle has quit IRC04:26
*** markvoelker has quit IRC04:31
*** nihilifer has quit IRC04:32
*** unicell has joined #openstack-nova04:34
*** tobe has joined #openstack-nova04:34
*** zhangtralon has joined #openstack-nova04:35
*** dsanders has quit IRC04:35
*** amotoki_ has joined #openstack-nova04:35
*** otter768 has joined #openstack-nova04:41
*** zhangtralon has quit IRC04:42
*** otter768 has quit IRC04:45
openstackgerritEric Brown proposed openstack/nova: VMware: replace hardcoded strings with constants  https://review.openstack.org/18583604:48
*** irenab has joined #openstack-nova04:50
*** bkopilov is now known as bkopilov_wfh04:52
*** mdbooth has quit IRC04:55
*** pradipta has joined #openstack-nova04:55
*** gokrokve has joined #openstack-nova04:56
*** VW has quit IRC04:58
*** mdbooth has joined #openstack-nova04:59
*** kiran-r has joined #openstack-nova05:00
*** matrohon has joined #openstack-nova05:01
*** tobe has quit IRC05:04
*** nkrinner has joined #openstack-nova05:05
*** gokrokve has quit IRC05:14
*** salv-orlando has joined #openstack-nova05:16
*** sdake has joined #openstack-nova05:18
*** leopoldj has joined #openstack-nova05:18
*** achanda has quit IRC05:19
*** whenry has joined #openstack-nova05:19
*** salv-orlando has quit IRC05:21
*** penick has quit IRC05:23
*** belmoreira has joined #openstack-nova05:23
*** penick has joined #openstack-nova05:24
*** matrohon has quit IRC05:27
openstackgerritAlex Xu proposed openstack/nova-specs: Correct resource name for consolidate console API  https://review.openstack.org/18584405:27
*** whenry has quit IRC05:33
*** Sukhdev has quit IRC05:34
*** fawadk has joined #openstack-nova05:37
*** fawadk has quit IRC05:37
*** fawadk has joined #openstack-nova05:37
*** fawadk is now known as fawadkhaliq_05:37
*** deepthi has quit IRC05:38
*** fawadkhaliq has quit IRC05:39
*** sdake has quit IRC05:40
*** salv-orlando has joined #openstack-nova05:44
*** IanGovett has joined #openstack-nova05:44
*** salv-orl_ has joined #openstack-nova05:47
*** salv-orlando has quit IRC05:48
*** whenry has joined #openstack-nova05:50
*** tobe has joined #openstack-nova05:50
*** achanda has joined #openstack-nova05:52
*** bfic has joined #openstack-nova05:54
*** whenry has quit IRC05:54
*** salv-or__ has joined #openstack-nova05:55
*** salv-orl_ has quit IRC05:55
*** salv-orl_ has joined #openstack-nova05:57
*** achanda_ has joined #openstack-nova05:58
*** achanda has quit IRC05:59
*** salv-or__ has quit IRC06:00
*** IanGovett has quit IRC06:00
*** emagana has quit IRC06:00
*** emagana has joined #openstack-nova06:01
*** kaisers has joined #openstack-nova06:01
*** salv-orlando has joined #openstack-nova06:01
openstackgerritQin Zhao proposed openstack/nova: Refactor show_port() in neutron api  https://review.openstack.org/13502006:02
*** salv-orl_ has quit IRC06:02
*** kaisers has quit IRC06:02
*** fawadkhaliq has joined #openstack-nova06:03
*** flashgordon is now known as jogo06:04
*** garyk has joined #openstack-nova06:04
*** emagana has quit IRC06:05
*** fawadkhaliq_ has quit IRC06:05
*** garyk has quit IRC06:06
*** salv-orlando has quit IRC06:06
*** fawadk has joined #openstack-nova06:06
*** kaisers has joined #openstack-nova06:06
*** garyk has joined #openstack-nova06:06
*** salv-orlando has joined #openstack-nova06:06
*** yingjun has joined #openstack-nova06:07
*** garyk has quit IRC06:07
*** fawadkhaliq has quit IRC06:08
*** unicell has quit IRC06:09
*** unicell has joined #openstack-nova06:09
*** unicell1 has joined #openstack-nova06:14
*** achanda_ has quit IRC06:15
*** unicell has quit IRC06:16
*** tobe has quit IRC06:20
*** dsanders has joined #openstack-nova06:21
*** salv-orlando has quit IRC06:21
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/17963806:22
*** ankit_ag has joined #openstack-nova06:22
*** garyk has joined #openstack-nova06:23
garykhi, are there any cores around. if so then please look at https://review.openstack.org/#/c/185830/ - this will unblock the gate06:23
*** sahid has joined #openstack-nova06:27
*** salv-orl_ has joined #openstack-nova06:28
*** cfriesen has quit IRC06:29
*** kaisers has quit IRC06:30
*** salv-orlando has joined #openstack-nova06:31
*** salv-or__ has joined #openstack-nova06:33
*** salv-orl_ has quit IRC06:33
openstackgerritCarlos Gonçalves proposed openstack/python-novaclient: Support forcing service down  https://review.openstack.org/18584906:33
*** yingjun has quit IRC06:33
*** rotbeard has joined #openstack-nova06:34
*** salv-orlando has quit IRC06:35
*** salv-or__ has quit IRC06:37
*** tobe has joined #openstack-nova06:38
*** ZZelle_ has joined #openstack-nova06:39
*** rajesht has joined #openstack-nova06:39
*** yingjun has joined #openstack-nova06:40
*** oomichi has joined #openstack-nova06:41
*** otter768 has joined #openstack-nova06:42
*** kaufer has quit IRC06:46
*** otter768 has quit IRC06:46
*** deepthi has joined #openstack-nova06:47
*** moshele has joined #openstack-nova06:48
*** salv-orlando has joined #openstack-nova06:49
*** Murali has joined #openstack-nova06:50
*** yingjun has quit IRC06:51
*** yingjun has joined #openstack-nova06:51
*** fawadkhaliq has joined #openstack-nova06:51
*** User17 has quit IRC06:52
*** pece has joined #openstack-nova06:53
*** salv-orl_ has joined #openstack-nova06:53
*** oomichi has quit IRC06:53
*** salv-orlando has quit IRC06:53
*** fawadk has quit IRC06:54
*** lpetrut has joined #openstack-nova06:55
*** yingjun has quit IRC06:56
*** yingjun has joined #openstack-nova06:57
*** salv-orl_ has quit IRC06:58
*** salv-orlando has joined #openstack-nova06:58
*** mpaolino has joined #openstack-nova06:59
gilliardGood Morning all!06:59
*** salv-orl_ has joined #openstack-nova07:00
*** achanda has joined #openstack-nova07:02
*** salv-orlando has quit IRC07:03
*** mpaolino has quit IRC07:04
*** claudiub has joined #openstack-nova07:04
*** salv-orl_ has quit IRC07:05
*** dbyte has quit IRC07:06
*** dbyte has joined #openstack-nova07:07
*** dbyte has quit IRC07:07
*** dbite has quit IRC07:07
*** dguitarbite has quit IRC07:07
*** dguitarbite has joined #openstack-nova07:07
*** abhishekk has quit IRC07:07
*** romainh has joined #openstack-nova07:09
openstackgerritQin Zhao proposed openstack/nova: Update sqlalchemy-migrate to 0.9.6  https://review.openstack.org/17005007:10
*** mpavone has joined #openstack-nova07:11
*** Administrator__ has joined #openstack-nova07:13
*** dsanders has quit IRC07:14
*** Administrator_ has quit IRC07:16
*** IanGovett has joined #openstack-nova07:17
*** markvoelker has joined #openstack-nova07:17
*** radek__ has joined #openstack-nova07:18
*** bkopilov_wfh has quit IRC07:20
*** dulek has joined #openstack-nova07:20
*** salv-orlando has joined #openstack-nova07:23
*** matrohon has joined #openstack-nova07:24
*** emagana has joined #openstack-nova07:25
*** bkopilov has joined #openstack-nova07:25
*** annegentle has joined #openstack-nova07:27
*** salv-orlando has quit IRC07:27
*** salv-orlando has joined #openstack-nova07:27
*** dsanders has joined #openstack-nova07:28
openstackgerritZhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase  https://review.openstack.org/18586007:29
*** emagana has quit IRC07:30
*** pbrooko has joined #openstack-nova07:31
*** salv-orlando has quit IRC07:31
*** annegentle has quit IRC07:32
*** salv-orlando has joined #openstack-nova07:32
*** pbrooko has quit IRC07:32
*** markus_z has joined #openstack-nova07:32
*** alex_klimov has joined #openstack-nova07:34
openstackgerritZhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase  https://review.openstack.org/18586007:34
*** salv-orl_ has joined #openstack-nova07:35
*** salv-orlando has quit IRC07:36
* bauzas suffers terrible headache - thanks jetlag07:36
*** achanda has quit IRC07:36
* gilliard recommends some nice cheese07:36
bauzasgilliard: a beer would be more welcome07:37
gilliardbit early for beer?07:37
*** tobe has quit IRC07:37
*** achanda has joined #openstack-nova07:38
lxsligaryk: do you happen to know what the correct bug # for that patch is please?07:38
bauzasgilliard: depending on the TZ, nope07:38
lxsliAlso, morning07:38
*** dims has joined #openstack-nova07:38
*** tobe has joined #openstack-nova07:38
gilliardgaryk lxsli: https://bugs.launchpad.net/nova/+bug/145902107:39
openstackLaunchpad bug 1459021 in oslo.vmware "nova vmware unit tests failing with oslo.vmware 0.13.0" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem)07:39
garyklxsli: there is a patch which fixes nova07:39
gilliard^^ that patch has the wrong bug # in the commit :(07:40
garykhttps://review.openstack.org/#/c/185830/07:40
garykgilliard: not sure why you -1'ed - i think that is a better fix than the revert of the oslo.vmware07:40
openstackgerritMatthew Gilliard proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0  https://review.openstack.org/18583007:41
garykgilliard: is that due to the commit message?07:41
*** pbrooko has joined #openstack-nova07:41
gilliardyes. updated.07:41
garykgilliard: thanks!07:41
*** veena has quit IRC07:41
garykgilliard: i feel that this is better than reverting the oslo patch07:42
gilliardit's a bit of a core-drought at this time of day though :(07:42
*** jlanoux has joined #openstack-nova07:42
lxslijohnthetubaguy: should be online soon, maybe ndipanov ?07:42
*** dims has quit IRC07:44
*** toan-tran has joined #openstack-nova07:46
*** toan-tran has left #openstack-nova07:46
*** achanda has quit IRC07:47
*** fawadkhaliq has quit IRC07:50
*** jistr has joined #openstack-nova07:52
*** Nikolay_St has joined #openstack-nova07:53
openstackgerritZhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase  https://review.openstack.org/18586007:59
*** yingjun has quit IRC07:59
*** achanda has joined #openstack-nova08:00
*** emagana has joined #openstack-nova08:04
*** dsanders has quit IRC08:09
*** emagana has quit IRC08:09
*** xgsa has joined #openstack-nova08:10
openstackgerritYongli He proposed openstack/nova-specs: test cases for third party CI  https://review.openstack.org/14127008:11
*** matrohon has quit IRC08:14
*** yassine_ has joined #openstack-nova08:15
*** whenry has joined #openstack-nova08:20
*** apuimedo|away has joined #openstack-nova08:22
*** lucasagomes has joined #openstack-nova08:23
*** ildikov has joined #openstack-nova08:23
*** whenry has quit IRC08:25
openstackgerritMaxim Nestratov proposed openstack/nova: libvirt: rename parallels driver to virtuozzo  https://review.openstack.org/18431108:26
*** ZZelle has quit IRC08:27
*** ZZelle has joined #openstack-nova08:27
andrearosawanghao: are u around? ref "add force detach to nova"08:28
*** pixelb has joined #openstack-nova08:29
wanghaoYes08:30
*** danpb has joined #openstack-nova08:31
*** mpavone has quit IRC08:31
andrearosawanghao: thanks for adding me as co-author of the spec. Are you ok if I edit the spec? or do you prefer to edit it and I'll add my comments? or both :)08:31
wanghaoOf course, you can edit this spec.08:32
*** ashishjain has joined #openstack-nova08:33
andrearosawanghao: thanks08:33
ashishjainHello08:33
wanghaoandrearosa: :)08:33
ashishjainwhile deploying a nova server using nova-docker driver metadata as seen by nova api is different from as seen by docker view08:33
ashishjainAny reason for this difference?08:33
ashishjainIs it possible to sync this up?08:34
*** heyongli has joined #openstack-nova08:34
*** ndipanov has joined #openstack-nova08:36
*** mpavone has joined #openstack-nova08:37
wanghaoandrearosa: BTW, if you commit new code patch for this feature, please let me know it. Thanks.08:37
*** markus_z has quit IRC08:38
andrearosawanghao: yes. I hope I'll be able to put a WIP next week, At the moment the cindeclient doesn't expose a way to call the cinder force_detach. I talked to cinder guys yesterday and they are going to put a patch as soon as possible08:39
*** haypo has joined #openstack-nova08:40
openstackgerritZhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase  https://review.openstack.org/18586008:40
*** beagles has quit IRC08:42
wanghaoandrearosa: That's good to hear that.08:42
*** tobe has quit IRC08:42
ashishjainGuys another question08:42
*** mariusv has quit IRC08:42
*** otter768 has joined #openstack-nova08:43
ashishjainWhen I run "nova list" using admin I am unable to see the nova servers deployed by say a user "demo"08:43
*** Guest4835 has joined #openstack-nova08:43
*** tobe has joined #openstack-nova08:43
ashishjainhowever when I log-in to horizon console as admin same ispossible08:43
*** yingjun has joined #openstack-nova08:43
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Adds VolumeOps unit tests  https://review.openstack.org/13979708:43
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: removes test_hypervapi tests  https://review.openstack.org/13979808:43
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: Adds HyperVDriver unit tests  https://review.openstack.org/14898008:43
ashishjainCan I use nova commands to get the list of all nova-servers running08:43
ashishjainirrespective of tenant which it belongs to08:44
*** lpetrut has quit IRC08:46
gilliardyou would need to be an admin user. "nova list --all" would work in that case, IIRC08:46
gilliard(assuming by "servers" you mean "instances"?)08:46
gilliard* --all-tenants08:47
ashishjainaah able to make it work "nova list --all-tenants08:47
*** mariusv has joined #openstack-nova08:47
*** otter768 has quit IRC08:47
ashishjaingilliard: thanks , I just used the same command08:47
gilliard:)08:47
ashishjainbtw is there an restful api which does the same stuff08:47
gilliardeverything in the CLI uses the restful api to communicate with nova.08:48
*** mariusv has quit IRC08:48
gilliard"nova --debug list --all-tenants" will show you the details08:48
*** mariusv has joined #openstack-nova08:49
ashishjaingilliard: thanks a lot. This debug option gives all the details including the rest call08:50
*** markus_z has joined #openstack-nova08:51
mikalndipanov: you around?08:52
ashishjaingilliard: Do you know someone who can help here with nova-docker08:52
gilliardashishjain: Not my thing, sorry08:53
ashishjaingilliard: no problems, thanks for your help.08:53
*** mariusv has quit IRC08:54
gilliardmikal: while you're waiting for ndipanov, this is blocking the gate: https://review.openstack.org/#/c/185830/ ;)08:56
mikalgilliard: /me looks08:57
ndipanovyo08:58
*** achanda has quit IRC08:58
ndipanovmikal, what up08:58
mikalndipanov: can you help me with a bug?08:58
gilliardthanks mikal - sorry to jump at you like that08:58
ndipanovI can try08:58
mikalndipanov: I noticed https://bugs.launchpad.net/nova/+bug/1457527 while at the summit and I started digging08:58
openstackLaunchpad bug 1457527 in OpenStack Compute (nova) "Image-cache deleting active swap backing images" [Critical,In progress] - Assigned to Michael Still (mikalstill)08:58
*** emagana has joined #openstack-nova08:59
* ndipanov reads08:59
mikalndipanov: however, I've gotten sick since coming back home after the summit and have been basically asleep for the last two days08:59
mikalndipanov: the root cause of the problem seems to be that swap disks don't get saved to the db bdms by the libvirt driver08:59
mikalndipanov: I am still unclear on if that's by design, or is a bug08:59
ndipanovright08:59
ndipanovI have a patch for that08:59
mikalndipanov: so the cache cleanup code declares all swap files to be unused09:00
*** lifeless has quit IRC09:00
mikalndipanov: which causes instance corruption for instances using swap in kilo09:00
*** lifeless_ has joined #openstack-nova09:00
ndipanovhttps://review.openstack.org/#/c/83516/09:00
* ndipanov note: typing with a baby in arms harder than typing without one09:01
bauzaslol09:01
mikalndipanov: I don't feel coherant enough to review that right now, but it doesn't seem bonkers to me09:02
ndipanovmikal but imagecache code should still look at instance.swap_mb09:02
ndipanovfor old instances09:02
mikalndipanov: can you please do the thing where it gets associated with that bug?09:02
mikalndipanov: ok09:02
ndipanovyes09:02
*** exploreshaifali has joined #openstack-nova09:02
mikalndipanov: I think we need to do a backport of this for kilo09:02
ndipanovwill add that09:02
mikalndipanov: thanks, sorry I sat on this one without talking to you for so long09:03
ndipanovnp09:03
*** emagana has quit IRC09:03
ndipanovwill look into this a bit more09:04
ndipanovI think more work would be needed on top of this iiuc09:04
mikalndipanov: ok cool. I will bravely go back to bed then.09:04
*** mpavone has quit IRC09:04
*** chaochin has joined #openstack-nova09:04
ndipanovmikal, brave on09:05
openstackgerritwanghao proposed openstack/nova-specs: Support force detach volume to nova  https://review.openstack.org/8404809:08
chaochingaryk: Hi gary, about bug https://bugs.launchpad.net/nova/+bug/1459021, does nova ci job always load the latest code of oslo.vmware code?09:09
openstackLaunchpad bug 1459021 in OpenStack Compute (nova) "nova vmware unit tests failing with oslo.vmware 0.13.0" [Critical,In progress] - Assigned to Matthew Gilliard (matthew-gilliard-u)09:09
garykchaochin: yes. it should use the latest and greatest09:10
garykchaochin: last patch it voted on was https://review.openstack.org/#/c/175243/09:11
chaochingaryk: So if anyone merge wrong code in oslo.vmware, it might has possibility to break nova ci, correct?09:12
*** amotoki_ has quit IRC09:14
*** belmoreira has quit IRC09:15
garykchaochin: not sure i understand.09:16
*** ekarlso has quit IRC09:16
garykchaochin: in the case of nova it just breaks the unit tests - the patch https://review.openstack.org/185830 should address this09:17
garyki just hope that cores can take a look at this...09:17
openstackgerritSergey Nikitin proposed openstack/nova-specs: Implement server instance tagging  https://review.openstack.org/17711209:18
chaochingaryk: yes, that patch can fix the problem.09:18
garykchaochin: i am not sure why the CI is not working now. Will check soon09:18
*** rushiagr_away is now known as rushiagr09:18
*** rotbeard has quit IRC09:19
chaochingaryk: I see there is no oslo.vmware in requirement.txt. Should we limit oslo.vmware version <= XXX for nova? If we make a new version of oslo.vmware, we need to make a code change in requirement.txt, so that unit test can detect whether or not the new version of oslo.vmware is compatible with current nova code.09:22
chaochingaryk: Is that a right way?09:22
*** ekarlso has joined #openstack-nova09:22
garykchaochin: that was moved to test_requirements09:23
garykchaochin: matt and joe wanted it this way09:23
*** amotoki_ has joined #openstack-nova09:23
garykoriginally i was not convinced but their argument was that is was driver specific09:23
*** yingjun has quit IRC09:24
chaochingaryk: ok. in test_requirements oslo.vmware>=0.11.1, so it always load latest version. If latest version of oslo.vmware is incompatible with current driver code, I feel it will break ut. Not sure if it is necessary to add <=09:28
chaochingaryk: just some personal comments09:28
garykchaochin: if you look in the test requirements file then you will see ironic etc. so its good09:28
garykyeah, we always want the latest. no reason to cap it at the moment09:29
chaochingaryk:ok09:29
*** lpetrut has joined #openstack-nova09:33
*** diga has quit IRC09:33
*** diga has joined #openstack-nova09:35
*** dosaboy_ has quit IRC09:36
*** dosaboy has joined #openstack-nova09:36
*** derekh has joined #openstack-nova09:37
*** amotoki_ has quit IRC09:39
*** kaisers has joined #openstack-nova09:39
*** mpavone has joined #openstack-nova09:42
johnthetubaguygaryk: can we get the CI to vote on this patch? https://review.openstack.org/#/c/18583009:43
*** moshele has quit IRC09:46
dave-mcnallyI have a change here looking for a second core to approve if anyone has a second: https://review.openstack.org/#/c/176805/09:46
garykjohnthetubaguy: yes. i am trying to see what the issue is there - seems like glance did not start. working on09:48
claudiubhello. I would require a little bit of assistance. I'm currently trying to do a db migration and add a new element to an Enum column. Do you know any proper ways to do so?09:48
johnthetubaguygaryk: eek, OK, thanks for digging09:48
garykjohnthetubaguy: we may sadly have to wait for the guys in palo alto to wake up for this one. humble apoligies to all09:49
johnthetubaguyclaudiub: whats the actually real type for that column in the DB09:50
*** veena has joined #openstack-nova09:50
johnthetubaguygaryk: hey, no worries, it happens, usually at the worst possible moments09:50
*** eliqiao has quit IRC09:50
claudiubjohnthetubaguy: Enum of strings: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L73609:51
johnthetubaguyclaudiub: right, not sure you need a DB migration then, assuming you just add an extra type?09:51
claudiubjohnthetubaguy: yeah, I want to add an extra type.09:52
johnthetubaguyclaudiub: I could be wrong, there might be some constraint that needs updating, but I am unsure of the details, not attempted that mysel09:52
openstackgerritsahid proposed openstack/nova: libvirt: Enchance libvirt to set admin root password  https://review.openstack.org/18591009:52
*** emagana has joined #openstack-nova09:53
claudiubjohnthetubaguy: well, I would assume it needs a db migration, otherwise it would result in errors, trying to store that extra type.09:53
*** eliqiao has joined #openstack-nova09:53
openstackgerritsahid proposed openstack/nova: libvirt: enchance libvirt to set admin root password  https://review.openstack.org/18591009:53
johnthetubaguyclaudiub: maybe, I would just look for an example where we have changed that in the past09:54
johnthetubaguyclaudiub: sorry, I have to run away and deal with some emergency internal fires09:54
claudiubjohnthetubaguy: no worries, good luck. :)09:55
*** ashishjain_ has joined #openstack-nova09:57
*** emagana has quit IRC09:57
*** ashishjain has quit IRC09:59
sahiddanpb: whaoo, thanks !09:59
*** pbrooko has quit IRC09:59
*** ashishjain has joined #openstack-nova10:00
*** ashishjain_ has quit IRC10:02
*** eliqiao1 has joined #openstack-nova10:07
*** rushiagr has quit IRC10:08
*** eliqiao has quit IRC10:08
*** dims has joined #openstack-nova10:09
*** achanda has joined #openstack-nova10:09
*** moshele has joined #openstack-nova10:17
*** pbrooko has joined #openstack-nova10:20
dimsgaryk: my only objection would be that the unit tests behave differently with the 2 different oslo.vmware versions...i.e, the newer unit tests would fail with the older oslo.vmware10:24
openstackgerritsahid proposed openstack/nova: libvirt: enchance libvirt to set admin password  https://review.openstack.org/18591010:28
openstackgerritsahid proposed openstack/nova: libvirt: add os_admin_user to use with set admin password  https://review.openstack.org/18592110:28
*** pbrooko has quit IRC10:32
*** veena has quit IRC10:37
*** exploreshaifali has quit IRC10:43
*** otter768 has joined #openstack-nova10:44
*** emagana has joined #openstack-nova10:47
*** pbrooko has joined #openstack-nova10:47
*** pbrooko has quit IRC10:48
*** emagana has quit IRC10:48
*** otter768 has quit IRC10:48
*** emagana has joined #openstack-nova10:48
*** pradipta has quit IRC10:49
*** pbrooko has joined #openstack-nova10:52
*** emagana has quit IRC10:53
*** romainh has quit IRC10:56
*** romainh1 has joined #openstack-nova10:56
*** dulek_ has joined #openstack-nova10:57
*** romainh1 has quit IRC10:58
*** romainh has joined #openstack-nova10:58
*** dulek has quit IRC10:59
*** rushiagr_away has joined #openstack-nova11:00
*** ildikov has quit IRC11:01
*** deepthi has quit IRC11:04
garykdims: i hear you.11:06
dims:)11:07
garykdims: it is not clear what our direction is - do we drop the current requirements or move with the patch by sabari. problem on our side is that we do not have CI running on this - there is some glance issue (unrelated)11:13
*** ildikov has joined #openstack-nova11:16
*** matrohon has joined #openstack-nova11:17
dimsgaryk: ack, i'd wait on mriedem_away's input11:17
garykdims: ok11:17
garykdims: i think that the lesson here is to try and see how we can test something like this prior to publishing - it can happen with all oslo libraries (and we have seen it happen with external ones too)11:18
*** dguitarbite has quit IRC11:18
openstackgerritMh Raies proposed openstack/nova: Enable tenant/user specific instance filtering  https://review.openstack.org/13902511:19
*** romainh has quit IRC11:20
*** achanda has quit IRC11:20
*** dguitarbite has joined #openstack-nova11:21
*** achanda has joined #openstack-nova11:25
*** openstack has joined #openstack-nova11:38
*** jdurgin has joined #openstack-nova11:38
*** apuimedo|away has joined #openstack-nova11:38
*** thorst has joined #openstack-nova11:39
*** baffle_ has joined #openstack-nova11:40
*** lucasagomes is now known as lucas-hungry11:41
*** romainh has joined #openstack-nova11:41
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: make default_device_names DRY-er  https://review.openstack.org/18063611:42
openstackgerritNikola Dipanov proposed openstack/nova: virt: add get_device_name_for_instance to the base driver class  https://review.openstack.org/18063711:42
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: implement get_device_name_for_instance  https://review.openstack.org/18063811:42
openstackgerritNikola Dipanov proposed openstack/nova: virt: Move building the block_device_info dict into a method  https://review.openstack.org/18063511:42
*** emagana has joined #openstack-nova11:43
*** gszasz has joined #openstack-nova11:43
garykgilliard: agree. but not sure how can go about verifying stuff like this. in this specific case only the unit tests are broken the rest is a ok11:44
gilliardgaryk: I'm not sure either. In my previous jobs we've pinned everything and had some tooling to alert us to new deps being available, but always need to manually test that the code will work with them.11:46
*** aix has joined #openstack-nova11:47
gilliard^^ That would be a pretty time-consuming job in Nova.  More so than dealing with broken gates? I don't know.11:47
gilliardAt least it concentrates the work rather than stopping the whole machine.11:47
*** emagana has quit IRC11:48
ndipanovwell that's the whole point of CI right - to catch stuff like this11:48
ndipanovas for aggressively pinning dependencies - I am not sure about that11:49
ndipanovif we have a dep on something - it's assumed that we are happy not only with the code itself but with the upstream too11:50
ndipanovso vetting every single release might be an overkill11:50
gilliardIt would really be arduous, I know.11:51
gilliardIt does seem to me to be automatable, though.11:51
ndipanovwell isn't automated testing just that11:51
*** tobe has joined #openstack-nova11:52
*** dprince has joined #openstack-nova11:52
openstackgerritRitesh proposed openstack/nova: Bug : when running nova image-create with --poll we continues to report even when instance is desroyed  https://review.openstack.org/18594211:52
ndipanovI mean seems like a good deal to me - we get to follow upstream releases of our deps for the price of breaking changes halting our merging for a day11:52
gilliardI mean - we could automate the aggressive pinning and upgrading of dependencies.11:52
ndipanovgilliard, what does that get us that we don't already have?11:52
gilliarda gate which only fails if the code being tested doesn't work.11:53
ndipanovgilliard, well that's not what the gate is supposed to do is it11:53
ndipanovI mean11:53
ndipanovthere are tradeoffs11:53
ndipanovbut I think we are doing the right thing here11:53
ndipanovgiven the number and diversity of libs we depend on11:54
gilliardThat's the key thing. My previous life was all on the JVM where you can be pretty concise about your dependencies.11:54
gilliardNova is on a different scale.11:54
ndipanovyou mean Python is11:54
ndipanov:)11:54
*** tobe has quit IRC11:56
*** tobe has joined #openstack-nova11:57
*** dulek___ has quit IRC11:58
*** dulek___ has joined #openstack-nova11:58
gilliardWe effectively pin dependencies here by having a curated repo with only one version of everything. I guess that's how most operators do it.11:58
ndipanovgilliard, right - so for stable we should surely pin them12:00
ndipanovfor master - I think this is a good setup personally12:01
*** baoli has joined #openstack-nova12:01
*** markvoelker has quit IRC12:04
*** markvoelker has joined #openstack-nova12:04
*** ashishjain has quit IRC12:05
*** dulek_ has joined #openstack-nova12:06
danpbndipanov: can you check this numa docs patch i did https://review.openstack.org/#/c/178773/12:07
*** ildikov has quit IRC12:07
*** bkopilov is now known as bkopilov_wfh12:08
*** dulek___ has quit IRC12:09
danpbgaryk: does vmware have or need any kind of cap on the maximum duration of live migration operations ?12:10
danpbBobBall: same Q about XenServer & migration ...12:10
garykdanpb: sadly at the moment the driver does not support this via the nova api's12:11
garykthe implementation is broken :(12:11
danpbin this libvirt review it was suggested that the 'live_migration_completion_timeout' config param be put in nova/virt/driver.py instead of libvirt/driver.py   https://review.openstack.org/#/c/162254/4/nova/virt/libvirt/driver.py12:11
danpbbut i'm really loathe todo that unless other drivers positively affirm that such a config parameter is actually going to be usable for them12:11
danpbas all this live migration tuning stuff ends up getting rather hypervisor driver specific imho12:12
garykdanpb: i agree with you12:13
danpbif you could comment on that review from vmware's pov that'd be helpful12:13
garykdanpb: sure, will do12:13
*** aysyanne has joined #openstack-nova12:14
*** amotoki_ has joined #openstack-nova12:19
*** achanda has quit IRC12:20
*** ildikov has joined #openstack-nova12:21
*** raildo has joined #openstack-nova12:27
*** ashishjain has joined #openstack-nova12:27
*** mwagner_lap has joined #openstack-nova12:31
*** dims has quit IRC12:31
*** mwagner_lap is now known as mwagner12:31
*** dims has joined #openstack-nova12:32
*** dulek_ has quit IRC12:32
*** emagana has joined #openstack-nova12:37
*** eharney has quit IRC12:40
*** lucas-hungry is now known as lucasagomes12:41
*** emagana has quit IRC12:41
*** annegentle has joined #openstack-nova12:41
openstackgerritBartosz Fic proposed openstack/nova: Rollback on destination host after deleting vm during live migration  https://review.openstack.org/18595812:42
*** matrohon has quit IRC12:44
*** otter768 has joined #openstack-nova12:44
*** kaisers has quit IRC12:45
*** otter768 has quit IRC12:49
*** josecastroleon has joined #openstack-nova12:49
*** dguitarbite has quit IRC12:51
openstackgerritClaudiu Belu proposed openstack/nova: Adds live resize task states and instance action  https://review.openstack.org/18458512:52
openstackgerritClaudiu Belu proposed openstack/nova: Adds instance live resize nova-api microversion  https://review.openstack.org/18458412:53
openstackgerritClaudiu Belu proposed openstack/nova: db: Adds live-resize to Migration model migration_type  https://review.openstack.org/18596112:53
openstackgerritClaudiu Belu proposed openstack/nova: objects: Adds live-resize to Migration object migration_type  https://review.openstack.org/18596212:53
*** ashishjain has quit IRC12:53
*** ekarlso has quit IRC12:53
*** ekarlso has joined #openstack-nova12:53
openstackgerritBartosz Fic proposed openstack/nova: Rollback on dest host after deleting vm during live migration  https://review.openstack.org/18595812:54
*** xyang1 has joined #openstack-nova12:56
*** bfic has left #openstack-nova12:57
*** dulek has joined #openstack-nova12:58
*** abhishekk has joined #openstack-nova12:58
*** fawadkhaliq has joined #openstack-nova13:00
*** jecarey has joined #openstack-nova13:01
openstackgerritZhang Ni proposed openstack/nova-specs: improve nova attach volume api to support disk-bus The purpose of this spec is to add disk-bus paramter to nova attach volume api.  https://review.openstack.org/18597313:04
dimsgaryk: anyway to tickle the CI for https://review.openstack.org/#/c/185830/?13:04
*** dboik has joined #openstack-nova13:05
*** cknight has joined #openstack-nova13:06
*** annegentle has quit IRC13:06
*** kaufer has joined #openstack-nova13:06
*** kaufer has quit IRC13:07
garykdims: sadly we need to wait for ryan/sabari - it is a glance issue13:07
openstackgerritZhang Ni proposed openstack/nova-specs: Improve nova attach volume api to support disk-bus  https://review.openstack.org/18597313:08
dimsgaryk: how do we do this better next time?13:09
dimswe'll need oslo.vmware trunk run against glance and nova ?13:09
dimsin the NSX CI?13:09
garykdims: i do not think that it is specific to oslo.vmware it is the same issue for all libraries13:09
*** lpetrut has quit IRC13:10
garykis it possible to change a tag name?13:10
garykif so we could create a version say oslo.vmware.proposed, we could then see if that works locally and if so then rename to 0.x13:11
dimsdon't want to mess up pypi though13:12
garykok13:15
*** abhishekk has quit IRC13:15
garyki am terribly sorry for the mess. had it been last week you guys could have tarred and feathered us…13:17
*** salv-orl_ has quit IRC13:17
*** mriedem_away is now known as mriedem13:17
*** VW has joined #openstack-nova13:17
garyki would suggest approving the patch by sabari to unblock the gate and we get the CI sorted in parallel13:18
mriedemwhat's going on?13:19
mriedemgaryk: dims: so nova is the only user in the planet of oslo.vmware?13:20
danpbam i right in thinking that   nova.utils.instance_sys_meta is essentially useless now we can assume Instance objects everywhere13:20
garykmriedem: no, glance, cinder,…13:21
garykcinder ci is passing13:21
danpbit seems like we could replace  utils.instance_sys_meta(instance) with just   instance.system_metadata everywhere13:21
danpbunless there's a dark corner still using a dict instead of Instance object ??13:21
*** kaufer has joined #openstack-nova13:21
garykdanpb: my guess would be that there are some tests that may need tweaking13:22
mriedemgaryk: glance is failing on the same VimFaultException stuff?13:22
garykmriedem: no.13:22
garykin the nova CI glance is not starting. hence we do not have a vote on this patch13:23
garykmriedem: that is some glance issue that we need to resolve13:23
garykbut it is unrelated13:23
*** lpetrut has joined #openstack-nova13:23
mriedemgaryk: how can you say that the 0.13.0 release of oslo.vmware isn't backwards incompatible?13:24
mriedemit makes a thing that didn't fail before now fail bya change to the behaviour of the API13:24
garykmriedem: there is no change in the API13:24
garykthe fact that nova was catching an exception that is different to the one returned is not a break in the API.13:24
mriedemhow so?13:25
mriedemoslo.vmware used to return a VMwareDriverException13:25
garykdid you look at the patch posted by sabari?13:25
mriedemso clients would handle that13:25
garykmriedem: but clients did not handle that in the past13:25
mriedemumm13:25
mriedemapparently nova was13:25
*** matrohon has joined #openstack-nova13:25
garykit was just to handle a specific case where one was trying to get some additional information about the root cause13:26
garykkind of trying to make debugging a little easier - but that would not have even helped if a later VC version was used13:27
mriedembut...https://review.openstack.org/#/c/185830/2/nova/virt/vmwareapi/vm_util.py13:27
mriedemthat's still changing the runtime code to handle a different type of exception from the library13:28
mriedemi don't see how that's not backwards incompatible13:28
*** busterswt has joined #openstack-nova13:28
mriedemany other client using oslo.vmware would have to make a similar change13:28
*** annegentle has joined #openstack-nova13:28
mriedemif they were catching VMwareDriverException13:28
garykmriedem: can you pleease show me where in the nova api we are actually catching that exception?13:29
mriedemgaryk: i'm not literally talking about nova "API"13:29
garykthat exception was only being caught to see if there was a problem with the geust os being run13:29
mriedemi'm talking about a contract with the library13:29
garykguest13:29
*** vladikr has joined #openstack-nova13:29
*** eharney has joined #openstack-nova13:30
mriedemso i decided that i didn't like returning FooError from sqlahcmey-migrate when everyone was used to FooError, and i started raising BarError13:30
mriedemthat's a break in the contract of how the library behaves13:30
mriedemw/o a deprecation cycle13:30
mriedem*say i decided13:30
*** annegentle has quit IRC13:30
*** oomichi has joined #openstack-nova13:31
garyki disagree in this specific case. this code in nova was just to add information to try and help identify the error.13:31
*** emagana has joined #openstack-nova13:31
garykit is not breaking any API13:31
*** sdake_ has joined #openstack-nova13:31
mriedem_wait_for_task was returning VMwareDriverException, now it returns VimFaultException13:31
mriedemthat's a contractual break imo13:32
mriedemi'm not saying, 'this breaks the nova compute API for spawning instances'13:32
mriedemyou're taking my usage of 'API' too literally13:32
garykin the oslo api's this should have been VimFaultException13:33
mriedem'should have been'13:33
garyki think that it was a bug and the fact that nova used it was incorrect13:33
*** annegentle has joined #openstack-nova13:33
mriedemnova used what the library was providing13:33
garykthat is a mistake in hindsight13:33
gilliardmriedem: is your suggestion to roll back this specific change to oslo.vmware??13:33
mriedemhttp://specs.openstack.org/openstack/api-wg/guidelines/evaluating_api_changes.html#guidance13:33
mriedem"A change such that a request which was successful before now results in an error response (unless the success reported previously was hiding an existing error condition)."13:33
mriedemgilliard: yes13:34
gilliardmriedem: and release a new version of it.13:34
lxsli+113:34
mriedemgilliard: https://review.openstack.org/#/c/185748/ and https://review.openstack.org/#/c/185744/13:34
mriedemrevert the backwards incompatible change, release oslo.vmware 0.13.113:34
mriedemblock 0.13.0 in g-r13:34
mriedemthen have a deprecation cycle and redo the change the right way13:34
mriedemrather than just dropping a thing and changing a 'should have been' this different error into something else, because we felt like it13:35
garykguys, have you read the code in vm_util?13:35
garykhttps://review.openstack.org/#/c/185830/2/nova/virt/vmwareapi/vm_util.py,cm13:35
garykthe only thing that this does is log a warning13:35
*** emagana has quit IRC13:35
mriedemgaryk: it doesn't matter13:35
garyknow is that breaking an API?13:35
garykmriedem: it does13:35
garykthe problem is the tests raising the wrong execption13:36
garykthat is the problem13:36
mriedemthe tests were not raising the wrong exception before the oslo.vmware change13:36
mriedemthe tests were stubbing out oslo.vmware13:36
mriedemand raising what it was before 0.13.013:36
garyknot the fake tests13:36
lxsligaryk: you're assuming we're the only consumer of oslo.vmware13:36
mriedemhttps://review.openstack.org/#/c/185830/2/nova/tests/unit/virt/vmwareapi/fake.py13:36
lxslithe impact on Nova is immaterial. What's important is that oslo.vmware released a backwards-incompatible version13:37
mriedemhonestly with the terrible state of the vmware driver tests i don't know which are mocks and which are stubbed and what fakes are being used and how far down into oslo.vmware we are stubbing things out when we shouldn't be13:37
garykmriedem: that is a bit of an exageration. when last did you try and write a test in the libvirt driver?13:37
mriedemlast week?13:37
garyk:)13:37
garykuse 'terrible' is not something which is characteristic of the driver especially when you were the one advocating the rewirte in the past cycle13:38
garykbut lest move on.13:38
mriedemlet's say libvirt-python decided to return newLibvirtError instead of libvirtError, that'd be a backwards incompatible change from a library13:38
*** zz_jgrimm is now known as jgrimm13:38
garykyes, there were cases when the exeptions there were changed. i can try and dig them up if you wish. i did not see you making a fuss then13:39
danpbmriedem: yeah, we'd never do that13:41
danpbbut we do reserve the right to change the error codes we use for some certain scenarios13:41
*** links has quit IRC13:41
danpbwhich in theory can cause breakage if an app was looking for a specific error code13:41
mriedemdanpb: would you have a deprecation / warning cycle for that?13:42
danpbnope13:42
danpbgenerally this happens when we switch from the general VIR_ERR_INTERNAL_ERROR to a new error constant VIR_ERR_SOME_SPECIFIC_PROBLEM13:42
danpbso apps generally like this13:42
mriedemb/c it's more specific, i get that13:42
garykmriedem: i think that this could happen with any library13:42
mriedemi agree that any library could break it's users, yes13:43
garyki have spun up a devstack installation with this latest oslo.vmware and it works.13:43
mriedemuntil you hit the code path that the unit test is hitting13:43
garykthe fact that we have a issue in our CI should not block this. that is my opinion13:43
mriedemand then it doesn't work13:43
garykthe problem with the CI at the moment is that the glance does not start13:44
*** apuimedo|away is now known as apuimedo13:44
mriedemwhich ci?13:44
garyknova CI for the vmware driver13:45
garykso we cannot get a vote on https://review.openstack.org/#/c/185830/13:45
openstackgerritRadoslav Gerganov proposed openstack/nova: Consolidate the APIs for getting consoles  https://review.openstack.org/14850913:47
*** sdake has joined #openstack-nova13:47
*** dave-mccowan has joined #openstack-nova13:48
*** burt has joined #openstack-nova13:48
*** _gryf|afk is now known as _gryf13:50
*** sdake_ has quit IRC13:51
gilliardIf j-random-library releases and breaks our CI, we work around it and move on. Honest Q: Why is olso.vmware get special in this regard?13:51
*** annegentle has quit IRC13:52
*** annegentle has joined #openstack-nova13:53
*** rook has joined #openstack-nova13:53
garykmriedem: one way we could address this in the future is to have our oslo ci running to try and prevent issues like this.13:53
garykit may take a lot of work on our side13:53
openstackgerritBrent Eagles proposed openstack/nova-specs: VIF plug script support for Nova  https://review.openstack.org/16246813:54
*** amotoki_ has quit IRC13:54
mriedemgilliard: we have also black listed versions of libraries for backwards incompatible changes in the past13:55
mriedemincluding oslo libraries13:55
mriedemgaryk: what's 'our ci'? vmware ci on oslo.vmware changes?13:55
mriedemit's not going to hit that edge case as you pointed out anyway13:56
rgerganovgaryk: I think the oslo.vmware CI should use the patch under review instead of the pypi version when running tempest13:56
*** garloff_ has joined #openstack-nova13:56
*** cbits has joined #openstack-nova13:56
mriedemoslo.vmware ci is not even testing the changes under review?13:56
*** cbits has left #openstack-nova13:57
rgerganovmriedem: let me check this13:57
garykmriedem: not sure i understand your last comment13:57
BobBalldanpb: None needed I think;  we will abort the live migration if  it's taking 'too long' but because it's an iterative process I'm not sure if there is a fixed upper limit13:57
rgerganovmriedem: ok, it does test the patch under review but obviously it doesn't run Nova unit tests :)13:58
mriedemrgerganov: no, and i wouldn't expect it to, it's a tempest run13:58
BobBalldanpb: Why are you thinking of adding a fixed upper limit?13:58
rgerganovmriedem: right, sorry for the confusion13:58
mriedemrgerganov: it was a review fail13:58
*** pradipta has joined #openstack-nova13:59
*** garloff has quit IRC14:00
danpbBobBall: in libvirt / kvm we don't automatically abort migration that's taking too long14:00
danpbBobBall: it is upto the app like nova to decide when/whether to abort it14:00
BobBallAh ok - what sort of limit are you thinking of?14:00
BobBallor something based on flavor?14:00
danpbso what i've proposed for libvirt/driver.py was a live_migration_completion_timeout= opt in nova.conf's  [libvirt] group14:01
danpbbut some people thought it should be in the [default] group for other virt drivers to use14:01
BobBallLet me just quickly check14:01
danpbbut i'm not convinced it will be generally used14:01
*** radek__ has quit IRC14:01
*** radek__ has joined #openstack-nova14:02
danpbBobBall: this was the suggestion https://review.openstack.org/#/c/162254/4/nova/virt/libvirt/driver.py14:03
danpbif you have comments from XenServer POV please add them14:03
BobBallWill do.14:03
garykmdbooth: around14:03
openstackgerritBrent Eagles proposed openstack/nova-specs: VIF plug script support for Nova  https://review.openstack.org/16246814:04
mdboothgaryk: I am14:04
lpetrutHi guys. I have a small question related to the way the nova compute manager handles lifecycle events14:05
garykmdbooth: wanted your two cents on the following https://review.openstack.org/#/c/185830/ - as you added the code that is breaking :)14:05
dimsholy cow, you guys have been busy :) garyk, mriedem, is there consensus?14:05
*** oomichi_ has joined #openstack-nova14:05
*** ferest has joined #openstack-nova14:06
dimsgaryk: haha :)14:06
mdboothgaryk: Impossible! ;)14:06
lpetrutShouldn't it ignore events when the instance has a pending task?14:06
mriedemlpetrut: it does14:06
garykdims: i think that we are between a rock and a hard place.14:06
mriedemif instance.task_state != None14:06
mriedemlpetrut: see _sync_instance_power_state14:06
openstackgerritBrent Eagles proposed openstack/nova-specs: VIF plug script support for Nova  https://review.openstack.org/16246814:06
dimsjohnthetubaguy: i got a volunteer for switching on the nova-docker job on nova reviews - https://review.openstack.org/#/c/185992/14:07
garykdims: mriedem: the question is is there a contract broken. i think not and mriedem disagrees (which is legit)14:07
garyki have asked mdbooth what he thinks as he wrote that code14:07
dimsgaryk: from a practical point of view, if we can fix the nova tests to work with both old and new oslo.vmware library, i'd be happy. but others may not agree14:08
*** ferest has quit IRC14:08
mdboothWhat's the relationship between VMwareDriverException and VimFaultException?14:08
garykdims that can certainly work14:08
*** tonytan4ever has joined #openstack-nova14:09
*** oomichi has quit IRC14:09
dimsmdbooth: different hierarchy from what i recall14:09
mdboothIIRC, this is basically passing on an exception raised by vsphere14:09
lpetrutmriedem: you're right. now that's odd. Basically, I'm trying to add an event listener to the Hyper-V driver as used by the Libvirt Driver. The issue is that when an instance is destroyed, the instance is stopped. The event listener emits the power off event, calls the stop API and then I get this: http://paste.openstack.org/show/240003/14:09
lpetrutI get this UnexpectedDeletingTaskStateError14:10
mdboothgaryk: I seemed to be quite clear when I wrote it that the exception raised was a VMwareDriverException14:10
garykmdbooth: yes, that is correct - we are now passing the Vim exception instead of using the VMwareDriverException14:10
mdboothIt's possible I was wrong about that14:11
garykin Nova we could check for both and that will resolve the issue14:11
garykmdbooth: we have all learnt a lot over the last few years.14:11
mdboothTBH, it *is* a vim exception14:11
mdboothSo if the library has changed to make it a vim exception, then that seems like a good idea14:12
garykmdbooth: thanks14:12
lxslithe question isn't whether it's a good idea14:12
garykmriedem: ^^14:12
*** READ10 has joined #openstack-nova14:12
mdboothIt's not as if we don't control the users of oslo.vmware14:12
mriedemmdbooth: do you?14:12
lxsliit's whether it should have gone through a deprecation cycle before making an incompatible change to a client-facing exception14:12
garykmriedem: we can extend the exception hadnling to handle both exception if you wnat14:12
mdboothmriedem: I agree with you that it indicates a change in behaviour of the oslo.vmware library14:13
mriedemcan VimFaultException extend VMwareDriverException in the library?14:13
mdboothI'm not sure I'm bothered about that, though14:13
mdboothBut I'll leave that discussion to others :)14:13
*** vladikr has quit IRC14:14
garykmriedem: what about we have vm_util do:14:14
*** popw has quit IRC14:14
gilliardmriedem: That would be a good idea.14:14
garykexcept (vexc.VimFaultException, vexc.VMwareDriverException)14:14
*** vladikr has joined #openstack-nova14:14
garykthen we can depreacte that in L14:15
*** tobe has quit IRC14:15
mriedemlpetrut: you'd need debug logging on to see what all of the vm/task/power states are when _sync_instance_power_state runs14:15
garykdoes that work for you?14:15
mriedemlpetrut: that code is racy so i wouldn't be surprised if you're hitting something - the stack trace at least doesn't blow anything up, but it's ugly14:15
mriedemgaryk: can VimFaultException extend VMwareDriverException in the library?14:15
*** oomichi has joined #openstack-nova14:16
mriedemgaryk: nova handling both is only marginally better than what's the solution proposed now14:16
garykmriedem: it would require a change. i would actually have it the other way around14:16
lpetrutmriedem: got it, thanks!14:16
mriedemgaryk: i know you would, but the other way around doesn't fix the compat issue14:16
mriedemhonestly at this point i'm not sure how much i care14:17
garykin pracical terms the only issue is a message being logged14:17
*** annegentle has quit IRC14:17
mriedemgaryk: again, in this one little nova case14:17
kashyapIs this reasonably up2date? - https://wiki.openstack.org/wiki/BlockDeviceConfig14:17
mriedemthere is a bigger picture14:17
*** leopoldj has quit IRC14:17
garykin an ideal world there is a bigger picture, but in our little openstack world this is the only case14:18
mriedemkashyap: no idea, looks like it was written in havana so probably now, i'd ask ndipanov14:18
*** oomichi_ has quit IRC14:18
mriedemkashyap: stuff like that should live in the devref so it can be updated with the code14:18
mriedem*probably not14:18
kashyapmriedem: No worries, I'll refer code or unit tests to see the exact behavior.14:18
kashyapAnd, yes - I think more and more such docs are being submitted as part of devref. Maybe should be submitted there too.14:19
mriedemkashyap: we should actually probably have big warnings at the tops of those old design wikis (before spec reviews) saying 'this may be way out of date by now, check the code'14:19
*** artom has joined #openstack-nova14:20
kashyapYep14:23
ndipanovkashyap, resonably - I think so14:24
ndipanovbut could be improved for sure14:24
*** kiran-r has quit IRC14:25
*** kiran-r has joined #openstack-nova14:25
*** ashishjain has joined #openstack-nova14:25
mriedemkashyap: i added a note at the top of the page14:27
kashyapndipanov: Which doc doesn't couldn't use more love :-) . mriedem: Thanks!14:27
kashyaps/doesn't couldn't/couldn't/14:27
*** moshele_ has joined #openstack-nova14:29
*** moshele has quit IRC14:29
openstackgerritAlex Xu proposed openstack/nova-specs: Correct resource name for consolidate console API  https://review.openstack.org/18584414:29
*** bnemec has quit IRC14:30
*** thangp has joined #openstack-nova14:30
*** claudiub has quit IRC14:31
*** kiran-r has quit IRC14:32
*** annegentle has joined #openstack-nova14:32
*** ashishjain has quit IRC14:32
*** mestery has quit IRC14:33
*** mtanino has joined #openstack-nova14:33
*** mestery has joined #openstack-nova14:34
*** bnemec has joined #openstack-nova14:35
*** dims has quit IRC14:35
*** nelsnelson has quit IRC14:38
*** achanda has joined #openstack-nova14:40
*** emagana has joined #openstack-nova14:40
*** dulek has quit IRC14:41
bauzasdanpb: around ? while working on providing a to_dict, I'm seeing some bugs with your patch14:41
*** eharney has quit IRC14:42
bauzasdanpb: do you prefer me giving you reviews, or me providing a new patchset ?14:42
bauzasdanpb: eg. https://review.openstack.org/#/c/76234/35/nova/objects/image_meta.py,cm L413 needs to be changed to getattr(self, name)14:43
danpbsince the rest of my series is merged i'm fine if you wnat to just upload the new patch14:43
danpbi can easily pull it back down to my workspace now14:43
bauzasdanpb: okay14:43
danpbperhaps put comments inline in the current patch though to show what you're changing14:43
bauzasdanpb: ackl14:44
*** salv-orlando has joined #openstack-nova14:45
*** cfriesen has joined #openstack-nova14:45
*** otter768 has joined #openstack-nova14:45
*** electrocucaracha has joined #openstack-nova14:46
alex_xujogo: hi, are you around? Just want to ask whether you mean the propose of custom cpu feature and cpu model is too complex? sorry, I didn't catch up at summit, the discussion is too fast for me. Thanks for if you can give me short explain!14:46
*** otter768 has quit IRC14:50
*** hemnafk is now known as hemna14:50
*** patrickeast has joined #openstack-nova14:51
*** achanda has quit IRC14:52
*** nelsnelson has joined #openstack-nova14:53
*** Kennan has quit IRC14:55
openstackgerritZhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase  https://review.openstack.org/18586014:55
*** amotoki_ has joined #openstack-nova14:55
*** dims_ has joined #openstack-nova14:55
*** Kennan has joined #openstack-nova14:56
kashyapHow do I find what is the swap drive size allowed for a given instance type/flavor?14:58
mriedemkashyap: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/flavors.py#n82 ?14:58
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/objects/flavor.py#n4114:59
mriedeminstance.flavor.swap14:59
*** gokrokve has joined #openstack-nova14:59
kashyapHmm, I invoked an instance this way:14:59
kashyap$ nova boot --flavor 2 --block-device source=image,id=4955be94-9af4-44f2-8803-8eb362796037,dest=volume,size=2,shutdown=PRESERVE,bootindex=0 vm1 --swap 51214:59
*** amotoki_ has quit IRC15:00
*** claudiub has joined #openstack-nova15:00
kashyapAnd, I get the exception thrown by this part of the code from compute/api.py:15:00
kashyap   1276             if swap_size > instance_type['swap']:15:00
kashyap   1277                 raise exception.InvalidBDMSwapSize()15:00
mriedemso, swap_size is 512, what's the swap value for flavor 2?15:00
*** salv-orlando has quit IRC15:00
*** Hosam has joined #openstack-nova15:01
kashyapTrying to look up, I haven't done any tests before with "--swap"15:01
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: make default_device_names DRY-er  https://review.openstack.org/18063615:01
openstackgerritNikola Dipanov proposed openstack/nova: virt: add get_device_name_for_instance to the base driver class  https://review.openstack.org/18063715:01
openstackgerritNikola Dipanov proposed openstack/nova: libvirt: implement get_device_name_for_instance  https://review.openstack.org/18063815:01
openstackgerritNikola Dipanov proposed openstack/nova: virt: Move building the block_device_info dict into a method  https://review.openstack.org/18063515:01
*** armax has joined #openstack-nova15:01
openstackgerritgaryk proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0  https://review.openstack.org/18583015:02
garykmriedem: ^15:02
kashyapHmm, I don't see any "Swap" value when I invoke `nova flavor-list`, w/ Nova from current git.15:03
*** tsekiyama has joined #openstack-nova15:04
bauzasdanpb: left a few comments on https://review.openstack.org/#/c/76234/35, will see if I have time to work on delivering a new patchset15:04
* kashyap updates flavor properties.15:04
mriedemkashyap: nova flavor-show 2 ?15:04
kashyapmriedem: Already did that - nothing is enumerated there.15:05
mriedemkashyap: v2 api doesn't show swap in the view builder15:05
mriedemv2.1 api does15:05
kashyapYeah, so I read from an old bug comment.15:06
mriedemis the bug marked won't fix?15:06
mriedemsince we probably aren't going to change the v2 api for that15:06
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support  https://review.openstack.org/18225715:06
*** apuimedo has quit IRC15:06
*** dprince has quit IRC15:07
kashyapmriedem: Yeah - https://bugs.launchpad.net/nova/+bug/135454615:07
openstackLaunchpad bug 1354546 in OpenStack Compute (nova) "nova flavor-list does not show swap value" [Undecided,Invalid] - Assigned to Takashi Sogabe (sogabe)15:07
mriedemkashyap: thanks, added some notes in there15:09
openstackgerritgaryk proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0  https://review.openstack.org/18583015:09
garykmriedem: take two ^15:10
*** ddaskal has joined #openstack-nova15:10
mriedemkashyap: from reading the novaclient code, if you specify --swap with a bdm it sets the guest_format in the bdm dict to 'swap' and sets the volume_size to the --swap value15:11
kashyapmriedem: Oh, that's not helpful, is it?15:12
mriedemwell, it adds a swap bdm15:12
mriedemso i think you end up with 2 bdms?15:13
*** rajesht has quit IRC15:14
* kashyap is still testing15:14
*** pbrooko has quit IRC15:14
*** tobe has joined #openstack-nova15:15
ndipanovmriedem, related https://review.openstack.org/#/c/83516/15:19
*** dulek_home has joined #openstack-nova15:20
*** tobe has quit IRC15:20
*** sahid has quit IRC15:21
kashyapndipanov: Do you know if the CLI I posted above is valid?15:22
kashyapSpecifying "--block-device" and "--swap" together w/ one of the default flavors, this is testing from current Nova git.15:23
*** claudiub has quit IRC15:23
openstackgerritMikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support  https://review.openstack.org/18225715:24
mriedemkashyap: yeah according to the novaclient code it's valid15:24
*** nelsnelson has quit IRC15:24
ndipanovkashyap, I think so but you need to check the swap value in flavor15:25
mriedemlike i said, it creates a 2nd bdm dict for the swap device15:25
ndipanovmriedem, it doesn't now15:25
kashyapEven a simple boot with "swap" disk doesn't work either? - nova boot --config-drive false --flavor 1234  --swap 512 --key_name oskey1 --image cirros-0.3.3-x86_64-disk cirrvm115:25
ndipanovnot without the patch I just linked15:25
mriedemndipanov: oh15:25
*** dprince has joined #openstack-nova15:25
mriedemwell, novaclient sends the thing - it's entirely different if nova works with that or not :)15:25
mriedemfrom the amazon docs it sounds like you use swap volumes with smaller flavors15:25
*** wwriverrat has joined #openstack-nova15:26
*** Murali has quit IRC15:26
ndipanovah no if it sends it then it will be there15:26
ndipanovsorry you are right15:26
ndipanovmriedem, ^15:26
* kashyap creates a flavor with swap: `nova flavor-create flav-with-swap 1234 512 10 1 --swap 512 --is-public true` and boots an instance with it.15:26
kashyapndipanov: mriedem: Why I'm trying this, noticed this bug and thought I'd see if I can reproduce it at all - https://bugs.launchpad.net/nova/+bug/145752715:27
openstackLaunchpad bug 1457527 in OpenStack Compute (nova) "Image-cache deleting active swap backing images" [Critical,In progress] - Assigned to Michael Still (mikalstill)15:27
*** gokrokve has quit IRC15:27
ndipanovah y es mikal mentioned that one earlier it's on my list of things to look into today15:27
*** gokrokve has joined #openstack-nova15:28
*** tsekiyama has quit IRC15:28
kashyapYep, my latter test works:15:28
kashyap$ sudo virsh domblklist 315:28
kashyapTarget     Source15:28
kashyap------------------------------------------------15:28
kashyapvda        /home/kashyapc/src/cloud/data/nova/instances/92e6e003-a3da-4c2f-8c18-752706d8ef49/disk15:28
kashyapvdb        /home/kashyapc/src/cloud/data/nova/instances/92e6e003-a3da-4c2f-8c18-752706d8ef49/disk.swap15:28
ndipanovkashyap, yeah - flavor swap will limit you on the size15:28
ndipanovthat's a feature15:28
*** tsekiyama1 has joined #openstack-nova15:28
kashyapndipanov: Oh, okay. I was only curious, as it involves backing chains and I usually test them at libvirt/QEMU layer from git.15:29
*** romainh has left #openstack-nova15:30
kashyapndipanov: Noted, thanks for furthering my education :-)15:30
kashyapmriedem: Thanks for the hint to look at the client code, learnt a few things from the unit tests there.15:31
*** marun has joined #openstack-nova15:31
*** eharney has joined #openstack-nova15:32
*** gokrokve has quit IRC15:32
*** claudiub has joined #openstack-nova15:37
ndipanovkashyap, I will look at that bug now15:38
ndipanovand also link the other patch I mentioned there as well15:38
kashyapndipanov: Sure.15:39
*** VW has quit IRC15:39
*** browne has quit IRC15:39
kashyapndipanov: Maybe I'm being dense, but I don't see an intuitive way to find what's the swap size associated w/ a flavor? (It's not enumerated when you do a 'flavor-show')15:39
ndipanovkashyap, but iiuc the problem is not there when you pass --swap but when it's only given by flavor15:39
ndipanovkashyap, select id, swap_mb from instance_type;15:40
*** VW has joined #openstack-nova15:40
*** pbrooko has joined #openstack-nova15:40
*** Nikolay_St has quit IRC15:42
*** tsekiyam has joined #openstack-nova15:42
*** gokrokve has joined #openstack-nova15:42
*** tsekiyama1 has left #openstack-nova15:43
*** Guest4835 is now known as beagles15:44
*** penick has quit IRC15:45
*** nelsnelson has joined #openstack-nova15:46
*** annegentle has quit IRC15:47
*** jwcroppe has quit IRC15:48
*** jwcroppe has joined #openstack-nova15:48
kashyapndipanov: This did it: select id, swap from instance_types;15:50
openstackgerritAlexis Lee proposed openstack/nova-specs: Purge soft deleted rows  https://review.openstack.org/18463715:50
kashyap(It was 0 for all instances, by default. Hence it is not shown apparently.)15:50
ndipanovkashyap, yeah potato potato15:50
*** Sukhdev has joined #openstack-nova15:50
kashyap:-)15:50
kashyapSo, I can't dynamically provide a swap size as opposed to the flavor swap feature?15:51
*** lpetrut has quit IRC15:52
*** lpetrut has joined #openstack-nova15:52
*** lifeless_ is now known as lifeless15:53
ndipanovkashyap, you can but not larger than what's there15:54
*** barra204 has quit IRC15:54
ndipanovwhich actually makes it kinda useless... :/15:54
kashyapHmm, /me didn't wanted to say that out loud15:55
*** amotoki_ has joined #openstack-nova15:56
*** pbrooko_ has joined #openstack-nova15:58
*** alanf-mc has joined #openstack-nova15:59
*** jwcroppe has quit IRC15:59
*** baoli has quit IRC16:00
*** emagana has quit IRC16:00
*** pbrooko has quit IRC16:00
*** yamahata has quit IRC16:00
*** ildikov has quit IRC16:01
*** yamahata has joined #openstack-nova16:01
*** amotoki_ has quit IRC16:01
*** baoli_ has joined #openstack-nova16:02
*** emagana has joined #openstack-nova16:02
*** matrohon has quit IRC16:02
*** oomichi has quit IRC16:06
*** jistr has quit IRC16:07
*** alanf-mc_ has joined #openstack-nova16:09
*** mpavone has quit IRC16:10
*** jlanoux has quit IRC16:10
*** alanf-mc_ has quit IRC16:11
*** alanf-mc has quit IRC16:11
*** alanf-mc has joined #openstack-nova16:12
*** unicell1 has quit IRC16:12
*** dsanders has joined #openstack-nova16:13
*** jogo has quit IRC16:13
*** alex_klimov has quit IRC16:15
*** jogo has joined #openstack-nova16:17
*** achanda has joined #openstack-nova16:17
*** browne has joined #openstack-nova16:17
openstackgerritBrent Eagles proposed openstack/nova: WIP: Add support for VIF plugin script to Nova  https://review.openstack.org/16247016:18
*** gokrokve has quit IRC16:19
*** moshele_ has quit IRC16:19
*** gokrokve has joined #openstack-nova16:19
openstackgerritPetrut Lucian proposed openstack/nova: Hyper-V: Implement nova rescue  https://review.openstack.org/12715916:20
*** derekh_ has joined #openstack-nova16:21
*** gokrokve has quit IRC16:21
beaglesdansmith: can you take a look at https://review.openstack.org/#/c/167287/ when you get a sec to see if I'm on the right track, what I'm missing, etc? If your swamped, can you recommend someone else I can ping?16:22
*** vilobhmm has joined #openstack-nova16:22
mriedembeagles: he's out until tomorrow16:22
mriedemvacation16:22
*** lpetrut has quit IRC16:23
* beagles facepalm ...16:23
beaglesokay16:23
mriedemway2go!16:23
beaglesI'll retreat into my own little world :)16:23
*** destiny has quit IRC16:24
*** claudiub has quit IRC16:24
*** pkoniszewski has joined #openstack-nova16:25
*** derekh has quit IRC16:25
*** pboldin has joined #openstack-nova16:28
*** tjones1 has joined #openstack-nova16:28
*** pboldin has left #openstack-nova16:29
*** ankit_ag has quit IRC16:29
*** fawadkhaliq has quit IRC16:30
*** haypo has quit IRC16:31
*** pbrooko_ has quit IRC16:31
garykjohnthetubaguy: mriedem: https://review.openstack.org/#/c/185830/ has VMware CI +116:31
garykCan we get this approved to unblock the gate if possible.16:31
mriedemputting out other fires atm16:32
garykack16:32
garykndipanov: danpb: any chance you guys can please look at https://review.openstack.org/#/c/185830/16:32
garykthis will unblock the gate16:32
openstackgerritBrent Eagles proposed openstack/nova: WIP: Add support for VIF plugin script to Nova  https://review.openstack.org/16247016:35
danpbgaryk: i +2d on the basis that vmware ci passed16:35
garykdanpb: thanks16:36
ndipanovgaryk, I kind of agree with mriedem - why are we not fixing oslo.vmware?16:36
garykndipanov: the problem is not oslo.vmware it is nova16:36
ndipanovhow so?16:36
garykwe were raisning the wrong exception16:37
ndipanovin tests?16:37
garykin nova we were catching the wrong exception - due to misunderstanding, noyt good enough docs,16:37
johnthetubaguygaryk: hey, I think its looking close now, just worried a bit about adding an extra comment and some more testing16:37
garykthe only purpose of that code in nova was to log a warning for the admin16:37
mriedemoslo.vmware raised A, nova caught A. oslo.vmware changed A to B, nova was catching A, kaboom16:37
mriedemso their solution now is catch A and B16:38
garykmriedem: it is not kaboom16:38
mriedemfor older and latest versions of oslo.vmware16:38
ndipanovyeah let me stay out of this - I really agree with mriedem though - oslo.vmware should not have done this16:38
mriedemgaryk: i'm not sure what your definition of kaboom is then16:38
garykthat is making a mountain out or an antjill - we are going in a loop now16:38
ndipanovthey should revert the change and do a release16:38
mriedemi blame ndipanov for being late to the party16:38
mriedemndipanov: that's what i had originally proposed but -1s all over16:38
mriedemhttps://review.openstack.org/#/c/185744/16:38
mriedemhttps://review.openstack.org/#/c/185748/16:39
ndipanovand we should only block that version in the requirements16:39
mriedemanyway, reviewing the nova workaorund now16:39
mriedemndipanov: yeah, see ^ :)16:39
ndipanovyeah I'm 100% with you on this16:39
dims_mriedem: hey, come back to #oslo and work on the kazoo stuff :)16:39
ndipanovyou can't do that, and if you do and break ppl you should fix it16:39
garyki disagree.16:40
ndipanovbut whatever16:40
ndipanovgaryk, how so16:40
mriedemdims_: yes i also need lunch at some point here16:40
dims_mriedem: haha :)16:40
ndipanovyou can't change a publicly visible exception in a non major update16:40
ndipanovperiod16:40
garykthe reasons are explained in the -116:41
garykguys the only change is a warning being logged. seriously16:41
johnthetubaguyndipanov: mriedem: so my take is we merge the support for both exceptions, while we have the debate about reverting the API break in oslo.vmware, so the debate is less heated, but I duno, maybe thats the wrong way around16:41
garykeven matt who wrote it said that it is wrong16:41
ndipanovyeah not really important I guess16:41
ndipanovmerge the fix in Nova16:41
mriedemgaryk: but you understand that's not a very solid argument right?16:41
ndipanovbut don't try to argue how it's "better" - it's not16:42
garykmriedem: i think that at times you need to be pragmatic and see things as they are16:42
mriedemjust because i only killed one puppy and not 20 doesn't make it less wrong16:42
ndipanovbetter is not breaking publicly visible contracts in minor revisions of a library16:42
garykwe should not break api's16:42
ndipanovabsolutely not16:42
garykis this an api? not 100% sure.16:42
mriedemgaryk: this is not a REST API16:42
danpbthe thing is that with exceptions, if you take that argument to its conclusion16:42
ndipanovthe fact that it happens all the time is a different story16:42
mriedemAPI does not necessarily mean REST API16:42
danpbyou can't ever change anything about any exception you raise16:42
*** unicell has joined #openstack-nova16:42
ndipanovEVA!16:42
mriedemgaryk: a contract with a library is also an API16:43
danpbi think that's untenable as a position in general even if the modules aims to provide API compat16:43
mriedemwhich you shouldn't break w/o major version updates per semver16:43
danpbits unfortunate Nova broke when a new exception became possible to be thrown16:43
garykmriedem: so why does nova break every few months with the ec2 boto library16:43
danpbbut i don't think it is entirely unreasonable for oslo.vmware to have done that16:43
mriedemb/c boto sucks and we're trying to move ec2 out of tree16:43
garyki am sure that a few guys at amazon may disagree...16:44
danpbif nova wanted to be more robust it could have catch a more general exception rather than the specific exception subclass that particular version of oslo happened to be raising16:44
garykdanpb: agree16:44
danpbso just fix the exception catching in nova and move on16:44
johnthetubaguydims_: do we define what the oslo API is already?16:44
dhellmannjohnthetubaguy: we do normally include exceptions in the API definition16:45
garykdanpb: that is what has been done16:45
danpbgaryk: yep, and i agre with that16:46
mriedemgaryk: i'm still -1 on the deprecation todo in the code, it doesn't make sense to me16:46
*** otter768 has joined #openstack-nova16:46
johnthetubaguymriedem: if we bump the min supported version of the lib, we could drop the extra bit I guess right?16:46
garyki'll look at the comments and address16:46
mriedemjohnthetubaguy: http://git.openstack.org/cgit/openstack/oslo.vmware/tree/oslo_vmware/exceptions.py#n12616:47
johnthetubaguymriedem: its was assuming its not raised on that code patch any more16:48
*** dulek has joined #openstack-nova16:48
mriedemwhile the library still defines a VMwareDriverException type, it makes 0 sense to me for nova to be saying 'we're going to deprecate the usage of this thing that we have 0 control over'16:48
*** ssurana has joined #openstack-nova16:48
johnthetubaguygaryk: maybe the real think here is just to do the log message for all exceptions?16:48
*** annegentle has joined #openstack-nova16:48
*** nic has joined #openstack-nova16:48
*** timsim has joined #openstack-nova16:48
garykmriedem: the exception handling in nova is incorrect. the VIM exception is what is raised by the VC and this should be treated. Not a exception the other exception. but we are going in circles.16:48
garykjohnthetubaguy: i am fine with that16:49
johnthetubaguymriedem: agreed they broke the API though, even if its kinda only a soft squishy bit16:49
*** lpetrut has joined #openstack-nova16:50
johnthetubaguyhonestly, I would have expected exception inheritence to have been added to isolate users from such changes, or not bother making the change, but I am not sure what the general oslo policy is there16:50
mriedemgaryk: then the deprecation is not 'M', it's whenever nova requires oslo.vmware>=0.13.016:50
dhellmannjohnthetubaguy, garyk : we are supposed to avoid breaks like this16:50
*** yamahata has quit IRC16:51
johnthetubaguydhellmann: right, thats what I thought was true too, see: https://review.openstack.org/#/c/185744/16:51
dhellmannjohnthetubaguy: I just voted +2 on that16:51
johnthetubaguyoh wait, i see you commented there, thanks16:51
johnthetubaguycool16:51
*** otter768 has quit IRC16:51
garykdhellmann: i would agree if the calling code was catching the correct exception16:51
johnthetubaguydhellmann: I guess we then exclude the bad version in global deps, I guess someone mentioned that already?16:52
dhellmanngaryk: it makes no difference, we've changed the behavior in a way that broke something. We need to find a way to fix that behavior without breaking existing callers.16:52
vilobhmmjohnthetubaguy : hey john….as discussed in the Nova unconference session at the Summit …I have updated the doc impact section with the summary of the migration plan and release plan with new Tooz drivers….can you have a look at the spec https://review.openstack.org/#/c/138607/16:52
*** alanf-mc has quit IRC16:52
mriedemdhellmann: also https://review.openstack.org/#/c/185748/16:52
dims_dhellmann: agree in principle. wanted to see if there was a way forward given the team feels that it's the right way forward16:52
vilobhmmjohnthetubaguy : ^^16:52
garykdhellmann: you guys can override the -1 for the requirements16:52
ndipanovdanpb, fwiw - the only more specific thing than VMwareDriverException is Exception16:52
ndipanovso really nova could not have done anything else afaict16:52
ndipanov(other than catch Exception - bad)16:53
dims_dhellmann: i'd have leaned towards the immediate revert if the runtime was affected16:53
ndipanovand it broke16:53
ndipanovbut whatevs16:53
dims_ndipanov: remember this code was in nova and then we are trying to fix it slowly16:53
johnthetubaguyndipanov: so I guess the new exception could have just inherited from the less specific one right, and we are done?16:53
*** alanf-mc has joined #openstack-nova16:53
*** annegentle has quit IRC16:53
johnthetubaguydims_: it should have been incubator then?16:53
*** emagana has quit IRC16:53
dims_let's not open up that can of worms :)16:53
dhellmanngaryk: do you have a patch up to oslo.vmware to fix the class hierarchy for those exceptions or something, or are we going with the revert?16:54
mriedemjohnthetubaguy: i proposed that earlier but by definition they are supposed to inherit the other way around, i.e. VMwareDriverException extends from VimFaultException i  guess16:54
ndipanovyeah like I said - whatever - in this case it's prolly fine as we are not reverting a cleaner change16:54
ndipanovbut don't go and argue how it's right16:54
johnthetubaguymriedem: gotcha, missed that bit, sorry16:54
ndipanovcause it ain't!16:54
dims_dhellmann: there's a patch to fix nova tests16:54
ndipanov:)16:54
dims_that works with both old and new oslo.vmware versions16:54
dhellmanndims_: ok, does cinder have a similar issue?16:54
mriedemdhellmann: this is the nova change https://review.openstack.org/#/c/185830/16:54
*** electrocucaracha has quit IRC16:54
openstackgerritThang Pham proposed openstack/nova: VMware: Add support for swap disk  https://review.openstack.org/14217416:55
dhellmannmriedem: ok, whether or not that is right will depend some on how we fix things in oslo.vmware16:56
*** amotoki_ has joined #openstack-nova16:57
garyki am heading home will be back online in about 45 minutes16:57
dims_dhellmann: haven't heard any issue from cinder16:57
garykdims_: there are no issues with cinder/glance16:57
dhellmanndims_, garyk : ok, good16:58
garykonly problem is the code in nova that logs a warning (which is not really that useful either)16:58
*** claudiub has joined #openstack-nova16:58
garykthe exception is still raised.16:58
garykkind of you try to boot a vm and nova gets into an error state16:58
garykthe admin may have a warning in addition to the exception16:58
garykthe fact that the fake unit test driver behaves differently is the bug...16:59
dims_garyk: either way we should have been more careful next time16:59
garykdims_: agree. but that is the same with all libraries.16:59
dhellmannwe may also want to move that fake into the library where we can keep it up to date with the API16:59
dims_in addition to NSX CI, we have to run unit tests in all the projects before release. lesson learnt16:59
garykdims_: when you make a library change do you test all of the porjcets units tests - no.16:59
garykdims_: agree - lesson learnt. not sure how to check this17:00
dims_dhellmann: y we cleaned up suds stuff, have to get fake stuff as well17:00
dhellmannyep17:00
dhellmanndims_, garyk : so, short term, what's the plan? revert the change and re-release oslo.vmware or block it in requirements and release a fixed version?17:01
dhellmannor some other combination?17:01
*** amotoki_ has quit IRC17:01
dims_dhellmann: there's a block in requirements https://review.openstack.org/#/c/185744/ but vacillating between that and https://review.openstack.org/#/c/185830/17:03
*** hemna is now known as hemnafk17:03
*** garyk has quit IRC17:04
*** tobe has joined #openstack-nova17:04
dims_dhellmann: one of us have to break the logjam17:04
*** gszasz has quit IRC17:05
dhellmanndims_: I vote for blocking this release for now, and then working with the nova team more closely on a fix when we're under less pressure17:05
*** danpb has quit IRC17:05
johnthetubaguydhellmann: that sounds good, I don't mind landing the patch in Nova if thats quicker, but I prefer the blocking of the version for now, if thats easy enough17:06
johnthetubaguy+ dims_: ^17:06
dhellmanndims_: I approved the requirements block in https://review.openstack.org/#/c/185748/117:06
*** jwcroppe has joined #openstack-nova17:06
dims_dhellmann: let's get that requirements block in that will unblock nova folks17:06
dims_we don't need to make a release or revert yet17:07
dhellmanndims_: right, if there's a simple fix we can apply that and release 0.1417:07
*** dboik has quit IRC17:07
dims_johnthetubaguy: https://review.openstack.org/#/c/185830/ or https://review.openstack.org/#/c/185748/ should unblock you17:07
dims_dhellmann: we'll still need the g-r block of the "bad" version17:08
johnthetubaguydims_: sweet17:08
dims_so let's find someone to do that17:08
dhellmanndims_: right, I approved the g-r block17:09
dhellmanndims_: that's https://review.openstack.org/#/c/185748/17:09
*** tobe has quit IRC17:09
*** ijw has joined #openstack-nova17:09
dims_thanks dhellmann17:09
*** rajesht has joined #openstack-nova17:10
*** annegentle has joined #openstack-nova17:10
dims_johnthetubaguy: do you want to wait for the ci job to propose the update or i can add a review17:10
mriedemdims_: wait17:11
mriedemit's not like we haven't waited long enough anyway17:11
dims_ack17:12
mriedemmeanwhile17:12
dhellmannif we do that update by hand we can approve it and it should merge right after the g-r change17:12
*** dboik has joined #openstack-nova17:12
johnthetubaguydims_: I was just going to say, mriedem has a good handle on this stuff, I will defer to him (including the fact I am about to sign off for the day)17:12
*** vilobhmm has quit IRC17:12
*** ociuhandu has joined #openstack-nova17:12
dims_dhellmann: was going to add a Depends-On17:12
*** pkoniszewski has quit IRC17:12
dhellmanndims_: right17:12
mriedemdims_: we'd have to recheck anyway until the g-r change is merged17:12
mriedemoh17:12
*** baoli_ has quit IRC17:12
mriedemthat17:12
mriedemgo for it17:12
dhellmannyeah, we can piggy-back right on that change17:12
johnthetubaguyah, depends-on, thats cool17:12
johnthetubaguyI keep forgetting we have that17:13
*** annegentle has quit IRC17:13
* mriedem goes back to the oslo channel to babysit tooz17:13
*** vilobhmm has joined #openstack-nova17:13
*** markus_z has quit IRC17:14
*** sdake_ has joined #openstack-nova17:14
*** rajesht has quit IRC17:14
jogomriedem: you seem to be doing a lot of babysitting these days :)17:14
*** alanf-mc has quit IRC17:14
mriedemjogo: welcome17:15
mriedemto hell17:15
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Block oslo.vmware 0.13.0 due to a backwards incompatible change  https://review.openstack.org/18608717:15
*** ijw has quit IRC17:15
*** vilobhmm has quit IRC17:16
*** alanf-mc has joined #openstack-nova17:16
*** jfding has quit IRC17:16
jogohaha17:16
*** dboik has quit IRC17:16
*** ijw has joined #openstack-nova17:16
*** gokrokve has joined #openstack-nova17:17
*** sdake has quit IRC17:17
*** zzzeek has joined #openstack-nova17:18
*** alanf-mc has quit IRC17:18
*** alanf-mc has joined #openstack-nova17:20
*** fawadkhaliq has joined #openstack-nova17:22
*** krtaylor has quit IRC17:22
dims_mriedem: jogo has seen the light :)17:23
*** lucasagomes is now known as lucas-dinner17:23
*** yamahata has joined #openstack-nova17:23
jogodims_: and the light isn't coming from hell17:24
dims_haha17:25
melwittsome people are hitting a VersionConflict error installing novaclient because pbr required version ranges aren't meshing between novaclient and oslo libs https://bugs.launchpad.net/python-novaclient/+bug/145710017:26
openstackLaunchpad bug 1457100 in python-novaclient "pbr version conflict" [Undecided,Confirmed]17:26
*** baoli has joined #openstack-nova17:26
melwittis there anything we usually do to stay in sync with pbr version requires?17:26
*** fawadkhaliq has quit IRC17:27
dhellmannmelwitt: do you have a full traceback for that error? we've fixed a couple of other places by changing the way entry points are loaded17:28
melwittdhellmann: BobBall made a paste http://paste.openstack.org/show/239540/17:28
dhellmannmelwitt: the global requirements syncs have happened, but we haven't released the related oslo libs yet. We have 2 other requirements-related issues in play right now, so it's probably best to wait on more releases if we can.17:28
* dhellmann notices the scrollbar on that bug report17:29
dims_melwitt: dhellmann: they also probably have older oslo.config in their environment17:29
dims_melwitt: please bless https://review.openstack.org/#/c/186087/ so the nova unit tests can unblock quickly after the g-r and this review merges17:30
*** emagana has joined #openstack-nova17:31
*** VW has quit IRC17:31
openstackgerritMatt Riedemann proposed openstack/nova: Block oslo.vmware 0.13.0 due to a backwards incompatible change  https://review.openstack.org/18608717:32
mriedemdims_: i added the bug reference17:32
dims_mriedem: ack thanks17:32
melwittmriedem: it's good to go now?17:32
*** kfox1111 has joined #openstack-nova17:33
kfox1111Is there a way to boot a new instance already paused?17:33
mriedemmelwitt: yeah17:33
mriedemmelwitt: we're just expediting the g-r sync for this one17:33
mriedemhence the depends-on tag17:33
*** busterswt has quit IRC17:34
*** aix has quit IRC17:35
*** vilobhmm has joined #openstack-nova17:35
*** isd has joined #openstack-nova17:37
*** vilobhmm has quit IRC17:38
*** hemnafk is now known as hemna17:39
*** ijw_ has joined #openstack-nova17:41
dhellmannmelwitt: I'm working on a novaclient patch to fix up the requirements issue you're having, give me a few minutes17:43
*** sudipto has joined #openstack-nova17:44
*** ijw has quit IRC17:44
*** yassine_ has quit IRC17:44
*** garyk has joined #openstack-nova17:45
garykdhellmann: i have just arrived home17:45
melwittdhellmann: cool, though I don't yet understand why it won't install pbr==0.11.0 to fit both requirements17:45
garyknot sure what the conclusion is. i would prefer making changes to nova17:46
dhellmannmelwitt: pip doesn't have a good requirements resolver yet17:46
*** ildikov has joined #openstack-nova17:46
garyki think that is the healthier path to take17:46
garykdims_: dhellmann: what do you guys suggest?17:46
mriedemmelwitt: lifeless is working on the be all end all requirements resolver17:46
mriedemand will put us all out of a job17:47
dhellmanngaryk: we have a patch in the queue to block 0.13 from g-r, and then we're going to regroup the oslo.vmware team to find a way to make the desired change there without breaking nova17:47
dims_garyk: g-r block is in progress. we should put out another release of oslo.vmware which does not immediately break nova upon release and we need to figure out what that should have (a revert or something else)17:47
*** vilobhmm has joined #openstack-nova17:48
*** vilobhmm has quit IRC17:48
*** vilobhmm has joined #openstack-nova17:49
garyktwo options:17:49
garyk1. approve the requirement change17:49
*** dboik has joined #openstack-nova17:49
garyk2. approve the nova change17:49
melwittmriedem: oh, oops. I didn't realize this problem was that17:49
mriedemgaryk: the requirements change is approved17:50
*** emagana has quit IRC17:50
mriedemhttps://review.openstack.org/#/c/185748/17:50
garykdue to the fact that everyone says that we are breaking the API's lets go for #1, then fix nova to catch another exception and then update the lib17:50
*** Sukhdev has quit IRC17:50
mriedemdims has a preemptive g-r sync to nova here https://review.openstack.org/#/c/186087/17:50
mriedemthat will unblock nova17:50
dhellmanngaryk, dims_, mriedem : I started an etherpad with notes for the issue: https://etherpad.openstack.org/p/oslo-vmware-1317:52
*** vilobhmm has quit IRC17:53
dims_garyk: dhellmann: mriedem: added some options17:55
*** sdake has joined #openstack-nova17:55
*** Hosam has quit IRC17:55
*** electrocucaracha has joined #openstack-nova17:56
garyki added comments too. i will start to work on the nova side of thinsg if that is ok17:56
*** isd has quit IRC17:56
mriedemi'm distracted with fixing stable/juno and kilo atm17:57
dims_garyk: fine with me. you may end up blocking haypo's python34 work17:57
dims_since the nova change may take a while to land. i was hoping to get a 0.14.0 quickly17:57
dims_or a 0.13.117:58
*** isd has joined #openstack-nova17:58
*** isd has quit IRC17:58
*** sdake_ has quit IRC17:58
garykdims_: if that is the case let me sync with vipin and rado tomorrow morning and we can get a fix in oslo.vmware. lets sync up tomorrow and we'll have something18:00
*** pradipta has quit IRC18:00
*** rushiagr_away is now known as rushiagr18:00
dims_garyk: perfect. thanks18:00
*** isd has joined #openstack-nova18:01
*** IanGovett has quit IRC18:01
*** isd has quit IRC18:01
*** isd has joined #openstack-nova18:02
*** dims_ has quit IRC18:02
*** isd has quit IRC18:02
*** achanda_ has joined #openstack-nova18:03
*** dims_ has joined #openstack-nova18:03
*** dulek_home has quit IRC18:03
*** penick has joined #openstack-nova18:05
*** isd has joined #openstack-nova18:05
*** achanda has quit IRC18:05
*** isd has quit IRC18:05
*** alanf-mc has quit IRC18:06
*** ijw has joined #openstack-nova18:07
*** alanf-mc has joined #openstack-nova18:07
nicAm I reading the code right, and resize-revert is completely unimplemented for RBD/Ceph instances?18:08
*** isd has joined #openstack-nova18:08
*** isd has quit IRC18:08
nicSpinning up a test cluster to try it is a significant time-sink, so if there's a quicker answer here, you have my attention18:08
*** Sukhdev has joined #openstack-nova18:08
nici.e., resize-revert puts RBD-backed instances in an ERROR state currently?18:09
mriedemjbernard: ^18:10
mriedemi'm pretty sure the ceph job is running resize tests18:10
*** ijw_ has quit IRC18:11
mriedemnic: which release?18:11
nicI'm looking at master currently18:11
openstackgerritDoug Hellmann proposed openstack/python-novaclient: Do not check requirements when loading entry points  https://review.openstack.org/18611118:11
nicalso, I'm talking about the libvirt driver w/ Ceph and KVM18:11
dhellmannmelwitt: ^^18:11
mriedemnic: http://logs.openstack.org/59/127159/27/check/check-tempest-dsvm-full-ceph/7de8b17/console.html#_2015-05-27_16_53_47_73618:11
mriedemnic: http://logs.openstack.org/59/127159/27/check/check-tempest-dsvm-full-ceph/7de8b17/console.html#_2015-05-27_16_55_43_93718:12
*** Nikolay_St has joined #openstack-nova18:12
mriedemit's working in our test job on master18:12
*** VW has joined #openstack-nova18:12
nicI see no code to support rolling back a resize, though18:12
nicI tried it against stable/icehouse and it blew up in my face18:13
mriedemnic: ceph probably wasn't working until maybe juno, more like kilo18:13
mriedemthe ceph job wasn't passing until kilo18:13
melwittdhellmann: thanks!18:13
*** Sukhdev has quit IRC18:13
nicOK, I'll stand up a test cluster and put this to the burden of proof18:13
nicThanks18:14
mriedemnic: the compute manager resize revert method is here http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n335218:14
dhellmannmelwitt: it's not pretty, and note the suggestions for an alternative approach18:14
nicI used RBD snapshots for it in our Grizzly; it works like a dream and is really fast18:14
*** krtaylor has joined #openstack-nova18:16
*** annashen has joined #openstack-nova18:17
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/18611618:17
cfriesenanyone have any thoughts on bug 1458122?  Is this something that would need a spec?18:17
openstackbug 1458122 in OpenStack Compute (nova) "nova shouldn't error if we can't schedule all of max_count instances at boot time" [Undecided,New] https://launchpad.net/bugs/145812218:17
cfriesenif everyone is fine with the current behaviour I'll drop it, but I don't think the current behaviour makes sense given the expected semantics of "min count"18:18
nicI've always taken those arguments to be mutually exclusive, and a touch poorly-named18:20
cfriesennic: they're not mutually exclusive though18:20
nicGiving the end-user something other than exactly what they asked for and claiming it's OK is a great way to generate support tickets for us18:21
cfriesennic: if the user says "I want at least 4 and at most 6" instances, and we can give them 5...18:21
*** dboik has quit IRC18:22
nicBut that's not what those args mean18:22
*** kmartin has quit IRC18:22
*** vilobhmm has joined #openstack-nova18:23
cfriesennic: min_count "The minimum number of servers to launch when the service provider enables multiple server launch."18:24
cfriesennic: max_count: "The maximum number of servers to launch when the service provider enables multiple server launch. "18:24
*** ankit_ag has joined #openstack-nova18:25
cfriesennic: and actually, the API explicitly supports setting both min/max in one request18:26
cfriesenhttp://developer.openstack.org/api-ref-compute-v2.1.html#os-agents-v2.118:26
cfriesenwhoops, wrong hash18:26
cfriesenhttp://developer.openstack.org/api-ref-compute-v2.1.html#os-multiple-create-v2.118:26
*** vilobhmm1 has joined #openstack-nova18:27
*** vishwanathj has joined #openstack-nova18:27
*** isd has joined #openstack-nova18:27
*** isd has quit IRC18:28
*** apmelton is now known as apmelton_away18:29
*** ankit_ag has quit IRC18:30
*** vilobhmm has quit IRC18:30
*** dboik_ has joined #openstack-nova18:30
openstackgerritNikola Dipanov proposed openstack/nova: Add the swap and ephemeral BDMs if needed  https://review.openstack.org/8351618:32
jogodims_: re oslo.vmware  I was pointing out we don't do a great job in Openstack (me included) of using semvers 1.0.0 clause18:32
*** moshele_ has joined #openstack-nova18:32
jogodims_: and being the API should be considered stable why not a 1.0.0 release?18:33
*** dulek has quit IRC18:33
*** isd has joined #openstack-nova18:34
*** sudipto has quit IRC18:34
*** kmartin has joined #openstack-nova18:34
dims_jogo: ah, fair point. several other libraries got promoted at the kilo boundary, we were not sure about oslo.vmware yet at that point to make the jump18:35
jogodims_:  responding to the post, I didn't mean to belittle the effort the oslo.vmware team put in18:35
*** rotbeard has joined #openstack-nova18:35
dims_jogo: context, policy and vmware are stuck < 118:35
*** ijw_ has joined #openstack-nova18:37
jogodims_: any responded on the ML. Thanks again18:38
dims_will definitely push them to go 1.x before liberty jogo!18:38
jogodims_: thanks!18:39
*** ijw has quit IRC18:40
openstackgerritJay Pipes proposed openstack/nova-specs: Add generic scheduling/placement API  https://review.openstack.org/18383718:41
*** isd has quit IRC18:41
*** amotoki_ has joined #openstack-nova18:46
*** achanda_ has quit IRC18:47
*** otter768 has joined #openstack-nova18:47
*** sdake_ has joined #openstack-nova18:47
*** sudipto has joined #openstack-nova18:47
*** vilobhmm has joined #openstack-nova18:47
*** electrocucaracha has quit IRC18:48
*** vilobhmm1 has quit IRC18:48
*** Sukhdev has joined #openstack-nova18:49
*** VW has quit IRC18:49
sabaridims_ mriedem garyk I abandoned https://review.openstack.org/#/c/185830/ as I just saw that we already blocked oslo.vmware 0.13.0 in nova.18:49
dims_sabari: thanks18:50
dims_sabari: please add your ideas/thoughts here - https://etherpad.openstack.org/p/oslo-vmware-1318:50
dims_how best to proceed next18:50
*** amotoki_ has quit IRC18:51
*** sdake has quit IRC18:51
sabaridims_ sure, I initially thought we could bump up min version in nova to use the latest oslo.vmware and also fix the tests.18:51
sabariI will add my thoughts on the etherpad.18:51
*** cknight has left #openstack-nova18:51
dims_sabari: y, we need a deprecation period at least18:51
*** otter768 has quit IRC18:52
sabaridims_: but we are not deprecating any exception in oslo.vmware. chk out my last comments in https://review.openstack.org/#/c/185830/18:52
*** dave-mccowan has quit IRC18:52
*** tobe has joined #openstack-nova18:53
*** gokrokve has quit IRC18:53
*** gokrokve has joined #openstack-nova18:56
*** Hosam has joined #openstack-nova18:56
*** dboik_ has quit IRC18:57
*** dboik has joined #openstack-nova18:57
jbernardmriedem: it is, ill take a look18:58
*** tobe has quit IRC18:58
mriedemjbernard: yeah the ceph job passes the resize confirm/revert tests, i think it was an issue with someone testing on < kilo nova code18:58
jbernardmriedem: yeah, that could be the case18:59
mriedemi'm pretty sure the ceph / shared storage stuff in nova is probably just busted < juno18:59
jbernardmriedem: it should work in kilo, if not then i have a bug18:59
jbernardmriedem: im certain it is :)18:59
mriedemwe backported your shared storage fix to juno so that should be ok18:59
mriedembut wedon't test it18:59
mriedemoh i'm sure red hat tests it18:59
*** isd has joined #openstack-nova19:00
*** alex_klimov has joined #openstack-nova19:00
*** achanda has joined #openstack-nova19:00
jbernardnic: let me know how your tests go19:01
nicI just resized an instance from m1.nano (24576k root disk) to m1.small (20GB root disk).  It claims it worked, but Ceph reports no change in the size of the volume19:01
jbernardnic: kilo?19:01
nicmaster19:01
*** fawadkhaliq has joined #openstack-nova19:01
*** rushiagr is now known as rushiagr_away19:01
nicFreshly pulled as of an hour ago (give or take)19:01
jbernardnic: crap19:02
*** isd has quit IRC19:02
jbernardnic: alright, ill take a look; thanks for the info19:02
jbernardnic: might be good to file a bug19:02
nicI made this work relatively well against grizzly, and can forward-port the code if need be19:02
jbernardnic: things should be distintly better in kilo, so i need to find out what's going on there19:03
nicIt's not particularly complicated: make a snapshot, resize the volume, and either pivot or rollback depending on user confirm/cancel19:03
*** penick has quit IRC19:04
*** ijw_ has quit IRC19:05
*** fawadkhaliq has quit IRC19:06
*** sdake has joined #openstack-nova19:06
nic@jbernard: as you wish: https://bugs.launchpad.net/nova/+bug/145939919:08
openstackLaunchpad bug 1459399 in OpenStack Compute (nova) "Nova + Ceph: resize-instance doesn't resize anything, lies about it" [Undecided,New]19:08
*** eharney has quit IRC19:08
jbernardnic: thank you19:08
*** vishwanathj has quit IRC19:09
*** dave-mccowan has joined #openstack-nova19:10
*** sdake_ has quit IRC19:10
*** VW has joined #openstack-nova19:12
*** fawadkhaliq has joined #openstack-nova19:14
*** annashen has quit IRC19:14
*** eharney has joined #openstack-nova19:15
*** kmartin has quit IRC19:20
*** sudipto has quit IRC19:21
*** electrocucaracha has joined #openstack-nova19:28
*** rgerganov has quit IRC19:31
*** electrocucaracha has quit IRC19:31
*** fawadkhaliq has quit IRC19:33
*** moshele_ has quit IRC19:34
*** jgriffith has quit IRC19:36
*** jgriffith has joined #openstack-nova19:36
*** fungi has joined #openstack-nova19:38
*** fungi has left #openstack-nova19:38
*** haypo has joined #openstack-nova19:40
*** Mike_D_laptop has joined #openstack-nova19:41
*** thorst has left #openstack-nova19:45
*** jgrimm is now known as zz_jgrimm19:49
*** ociuhandu has quit IRC19:55
*** gokrokve has quit IRC19:55
*** mestery_ has joined #openstack-nova20:00
*** kmartin has joined #openstack-nova20:00
*** matrohon has joined #openstack-nova20:03
*** mestery has quit IRC20:03
bauzasalaski_vanc: mmm, you there for the cells meeting tonight ?20:03
bauzasunless vanc means "Very Awaiting Next Cycle" ?20:04
* bauzas shouldn't try joking in English during evenings20:05
*** tonytan4ever has quit IRC20:05
melwittbauzas: I think last meeting we said we were skipping the next two meetings, so last week and this week20:07
*** sdake_ has joined #openstack-nova20:07
bauzasmelwitt: ooooooh20:07
bauzasmelwitt: right20:07
*** electrocucaracha has joined #openstack-nova20:08
*** sdake has quit IRC20:11
*** tonytan4ever has joined #openstack-nova20:11
*** achanda has quit IRC20:14
*** READ10 has quit IRC20:15
*** annashen has joined #openstack-nova20:15
*** IanGovett has joined #openstack-nova20:16
*** slagle_ is now known as slagle20:20
*** VW has quit IRC20:21
*** matrohon has quit IRC20:24
*** inara has quit IRC20:32
*** inara has joined #openstack-nova20:34
*** VW has joined #openstack-nova20:34
*** amotoki_ has joined #openstack-nova20:34
*** barra204 has joined #openstack-nova20:35
*** annegentle has joined #openstack-nova20:37
*** claudiub has quit IRC20:38
*** amotoki_ has quit IRC20:39
*** vladikr has quit IRC20:39
*** IanGovett has quit IRC20:41
*** electrocucaracha has quit IRC20:41
*** tobe has joined #openstack-nova20:42
*** adreznec has joined #openstack-nova20:45
*** tobe has quit IRC20:46
*** annashen has quit IRC20:47
*** nkrinner has quit IRC20:48
bauzasmriedem: saw https://review.openstack.org/#/c/184968/ wedged by the oslo.vmware issue, I rechecked it since the partial bug was merged20:48
openstackgerritEric Brown proposed openstack/nova: Use oslo_config choices support  https://review.openstack.org/15857320:48
bauzasmriedem: IIUC, we can now recheck since https://review.openstack.org/#/c/186087/ merged ?20:48
openstackgerritEric Brown proposed openstack/nova: VMware: replace hardcoded strings with constants  https://review.openstack.org/18583620:48
*** Sukhdev has quit IRC20:49
bauzasmriedem: at least your comment on bug 1459021 is explicit but I would like to make sure20:49
openstackbug 1459021 in OpenStack Compute (nova) "nova vmware unit tests failing with oslo.vmware 0.13.0" [Critical,In progress] https://launchpad.net/bugs/1459021 - Assigned to Matt Riedemann (mriedem)20:49
*** barra204 has quit IRC20:50
mriedembauzas: yeah, recheck20:51
bauzascool20:53
*** baoli has quit IRC20:56
bauzasmriedem: while you're here, question20:57
mriedemi'm not here20:57
bauzasmriedem: lol20:58
bauzasmriedem: your nick is not registered, you're a fake then20:58
bauzasmriedem: about https://review.openstack.org/#/c/118010/4/nova/conductor/manager.py,cm I'm torn since I'm working on RequestSpec20:58
bauzasmriedem: I thought we agreed on the summit that we should avoid any change related to what we provide to the scheduler until we get resource-object and request-spec BPs implemented, do you confirm ?20:59
mriedemjwcroppe: https://review.openstack.org/#/c/118010/ is still a -220:59
mriedemb/c the dependent change has a -2 from me21:00
mriedembauzas: i wasn't in the scheduler session21:00
mriedembauzas: those have -2 anyway for now21:00
mriedemgoing to require a blueprint for the new filter21:00
mriedemand probably a spec21:00
mriedemwhere those more in the know about wtf goes on in scheduler land can advise21:00
bauzasmriedem: okay, will wait jaypipes coming back from his dream location21:00
mriedemha21:00
mriedemjaypipes needs to get out of my dreams and into my car21:01
bauzasmriedem: I'll put a note on that21:01
*** ociuhandu has joined #openstack-nova21:01
*** electrocucaracha has joined #openstack-nova21:01
bauzasthose -2s are procedural21:01
mriedembauzas: yes21:01
mriedemi'm the king of procedural -2, don't you know?21:01
mriedembauzas: btw, fyi https://www.youtube.com/watch?v=zNgcYGgtf8M in case you didn't know21:02
mriedemmelwitt: dansmith: ^ you too!21:02
*** ociuhandu has quit IRC21:02
bauzasmriedem: :)21:02
*** ildikov has quit IRC21:03
mriedemnow just imagine jay is the one dancing around21:03
bauzasman...21:03
mriedemlet me have this21:03
mriedemit's been a long day21:03
*** ociuhandu has joined #openstack-nova21:04
*** sdake has joined #openstack-nova21:04
bauzasmriedem: I'm still jetlagged, that evening doesn't count for me21:04
*** alanf-mc_ has joined #openstack-nova21:05
mriedemi'm not sure why there is an animated duck with a boombox in this video21:05
mriedembut i mean, why not, right?21:05
bauzas:)21:07
melwittlol21:07
*** alanf-mc has quit IRC21:08
*** sdake_ has quit IRC21:08
*** artom has quit IRC21:10
*** alanf-mc_ has quit IRC21:10
*** artom has joined #openstack-nova21:10
*** mestery_ is now known as mestery21:12
*** Mike_D_laptop has quit IRC21:12
*** alanf-mc has joined #openstack-nova21:12
*** bkopilov_wfh has quit IRC21:13
*** lsmola_ has quit IRC21:13
openstackgerritDavid Bingham proposed openstack/nova: Allow cleanup completion when serial ports already released  https://review.openstack.org/17997821:16
*** mwagner has quit IRC21:16
jwcroppemriedem, bauzas: Re: https://review.openstack.org/#/c/118010/ - fully agree we can create a blueprint.  A spec seems a little heavyweight though to put back something that was there already (Icehouse) and a simple scheduler filter?21:18
mriedemjwcroppe: i told him to at least put the bp in the nova meeting agenda to see if a spec is needed21:19
mriedemi'm not sure what was there already in icehouse thoug21:19
mriedem*though21:19
mriedemthe requested network stuff?21:19
jwcroppemriedem: yes, the requested network identifier was there - was removed since nothing was using it (in treee)21:19
mriedemright21:20
*** alanf-mc_ has joined #openstack-nova21:20
mriedemso there isn't a point in adding it back until something is using it21:20
mriedemhence the new filter and bp21:20
jwcroppeAgree, hence the blueprint and filter21:20
jwcroppeYou just type faster :)21:20
*** alanf-mc has quit IRC21:20
*** ildikov has joined #openstack-nova21:21
jwcroppeSo I'm all for Stephen creating a blueprint (I'm happy to do it too, I'll check w/ him) and then try to get it through.  Spec just seems like a lot of overhead for a trivial thing... but it could be done if that's the consensus21:22
mriedemwell, given what bauzas brings up above, it might not be trivial, idk21:22
mriedemwe have like a million scheduler filters, i think a design doc, even if smallish, is probably worth a spec to lay out the use case21:23
*** bkopilov has joined #openstack-nova21:23
*** lucas-dinner has quit IRC21:23
mriedemand ops people can comment on spec reviewsw21:23
jwcroppemriedem: Yeah, all fair points... I'll see what Stephen says in the reviews.  Is he already signed up for one of the meetings?21:28
*** dave-mccowan has quit IRC21:28
mriedemi haven't seen a meeting agenda update21:28
mriedemor his reply on the patch21:28
*** dave-mccowan has joined #openstack-nova21:29
jwcroppeok... hopefully this shouldn't be too problematic overall; I'd like to hear bauzas's thoughts on if he has a better option for getting the network ID into the request spec as well21:30
*** bkopilov has quit IRC21:31
*** dave-mccowan has quit IRC21:34
*** pece has quit IRC21:34
*** rbradfor has joined #openstack-nova21:34
*** lucas-dinner has joined #openstack-nova21:36
*** nihilifer has joined #openstack-nova21:38
*** thangp has quit IRC21:43
*** rbradfor has left #openstack-nova21:43
*** annashen has joined #openstack-nova21:48
*** bkopilov has joined #openstack-nova21:49
*** nic has quit IRC21:49
*** burt has quit IRC21:49
*** dboik has quit IRC21:49
*** mriedem has quit IRC21:51
*** penick has joined #openstack-nova21:51
*** annashen has quit IRC21:53
*** kaufer has quit IRC21:55
*** mjturek1 has quit IRC21:55
*** electrocucaracha has quit IRC21:56
*** VW has quit IRC21:56
*** VW has joined #openstack-nova21:57
*** mwagner has joined #openstack-nova21:58
*** jwcroppe has quit IRC21:58
*** VW has quit IRC21:59
*** VW has joined #openstack-nova21:59
*** jwcroppe has joined #openstack-nova21:59
*** electrocucaracha has joined #openstack-nova22:00
*** gokrokve has joined #openstack-nova22:02
*** radek__ has quit IRC22:02
*** mriedem has joined #openstack-nova22:03
*** VW has quit IRC22:04
*** annashen has joined #openstack-nova22:04
*** Sukhdev has joined #openstack-nova22:04
*** amotoki_ has joined #openstack-nova22:05
*** VW has joined #openstack-nova22:06
*** VW has quit IRC22:06
*** VW has joined #openstack-nova22:07
cfriesensomeone tell me if I'm sniffing glue here...if instance storage is not shared, then _is_instance_storage_shared() will say that we're on shared storage if it can't contact the other compute node.  If called from _destroy_evacuated_instances() that could cause it to leave instance disks lying around, which then could cause the instance_on_disk() call in a subsequent evac call to think that the instance is on shared storage.22:07
cfriesenI'm wondering if it might make sense to have an "shared_storage_id" value in nova.conf which could be "None" for nova-compute with local storage.  That would let us short-circuit the _is_instance_storage_shared() for the local storage case, making it more robust.22:09
*** amotoki_ has quit IRC22:10
*** VW_ has joined #openstack-nova22:11
*** VW has quit IRC22:11
*** rotbeard has quit IRC22:11
*** lpetrut has quit IRC22:19
*** annegentle has quit IRC22:20
*** annegentle has joined #openstack-nova22:24
*** ijw has joined #openstack-nova22:26
tjones1i asked this on #openstack but no answer.  does nova have the ability to dump a stack trace if i do a kill -i SIGUSR1 <pid>?  It kind of looks like it should but i am not seeing the stack dump .  any ideas?22:29
tjones1by nova i mean nova-compute22:30
*** ndipanov has quit IRC22:30
*** tobe has joined #openstack-nova22:30
*** ijw_ has joined #openstack-nova22:31
anteayatonyb: care to join us in -infra?22:32
*** nelsnelson has quit IRC22:32
mriedemtjones1: you might read this http://docs.openstack.org/developer/nova/devref/gmr.html22:32
mriedemnot sure if it helps though22:33
tjones1im looking at https://wiki.openstack.org/wiki/GuruMeditationReport22:33
*** kmartin_ has joined #openstack-nova22:34
tjones1which would be awesome22:34
*** fawadkhaliq has joined #openstack-nova22:34
*** artom_ has joined #openstack-nova22:34
*** kmartin has quit IRC22:34
cfriesentjones1: I think you want "kill -USR1 <pid>", and the report goes to stderr, wherever that is for nova22:34
*** artom has quit IRC22:34
*** patrickeast_ has joined #openstack-nova22:34
tjones1ah  - let me try i did -i SIGUSR122:34
*** ijw has quit IRC22:34
*** tobe has quit IRC22:35
*** patrickeast has quit IRC22:36
*** patrickeast_ is now known as patrickeast22:36
tjones1i think stderr goes nowhere…22:37
*** fawadkhaliq has quit IRC22:38
*** salv-orlando has joined #openstack-nova22:41
*** VW_ has quit IRC22:41
*** derekh_ has quit IRC22:42
*** aysyanne has quit IRC22:43
*** annashen has quit IRC22:43
*** annegentle has quit IRC22:46
*** otter768 has joined #openstack-nova22:49
*** annashen has joined #openstack-nova22:50
*** krtaylor has quit IRC22:50
*** electrocucaracha has quit IRC22:51
*** ddaskal has quit IRC22:51
*** electrocucaracha has joined #openstack-nova22:51
*** otter768 has quit IRC22:54
openstackgerritStephen Pierce proposed openstack/nova: per-aggregate filter to select hosts based on requested networks  https://review.openstack.org/18520423:00
*** haypo has quit IRC23:01
*** jecarey has quit IRC23:01
*** ijw_ has quit IRC23:02
tjones1mriedem: cfriesen: thanks for the info.  once i redirect stderr somewhere i get info.  I just have to restart the process to redirect unfortuately23:03
*** electroc_ has joined #openstack-nova23:03
*** mriedem has quit IRC23:04
*** gokrokve has quit IRC23:04
*** ijw has joined #openstack-nova23:05
*** electrocucaracha has quit IRC23:06
*** wuhg has joined #openstack-nova23:07
*** tjones1 has quit IRC23:09
*** tonytan4ever has quit IRC23:10
*** electroc_ has quit IRC23:10
*** annashen has quit IRC23:12
*** electrocucaracha has joined #openstack-nova23:12
*** annashen has joined #openstack-nova23:13
*** electrocucaracha has quit IRC23:14
*** salv-orlando has quit IRC23:14
*** electrocucaracha has joined #openstack-nova23:15
*** sdake_ has joined #openstack-nova23:16
*** annashen has quit IRC23:17
*** electrocucaracha has quit IRC23:17
*** tjones1 has joined #openstack-nova23:17
*** sdake has quit IRC23:19
*** annashen has joined #openstack-nova23:21
*** ZZelle_ has quit IRC23:22
*** ijw_ has joined #openstack-nova23:22
*** Hosam has quit IRC23:23
*** electrocucaracha has joined #openstack-nova23:24
*** electrocucaracha has quit IRC23:25
*** ijw has quit IRC23:26
*** electrocucaracha has joined #openstack-nova23:26
*** annashen has quit IRC23:29
*** annashen has joined #openstack-nova23:30
*** tobe has joined #openstack-nova23:31
*** annashen has quit IRC23:35
*** tobe has quit IRC23:36
*** nelsnelson has joined #openstack-nova23:36
*** dims_ has quit IRC23:38
*** fawadkhaliq has joined #openstack-nova23:38
*** lucas-dinner has quit IRC23:39
*** krtaylor has joined #openstack-nova23:39
*** dims_ has joined #openstack-nova23:40
*** tjones1 has left #openstack-nova23:49
*** ddutta has joined #openstack-nova23:50
*** lsmola has joined #openstack-nova23:51
*** amotoki_ has joined #openstack-nova23:51
*** nelsnelson has quit IRC23:52
*** penick has quit IRC23:53
*** amotoki_ has quit IRC23:56
*** ddutta has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!