| *** ijw has quit IRC | 00:00 | |
| *** melwitt has quit IRC | 00:03 | |
| *** otter768 has joined #openstack-nova | 00:10 | |
| *** zzzeek has quit IRC | 00:11 | |
| *** otter768 has quit IRC | 00:14 | |
| *** claudiub has quit IRC | 00:15 | |
| *** iamjarvo has joined #openstack-nova | 00:16 | |
| *** salv-orlando has quit IRC | 00:16 | |
| *** tsekiyama has quit IRC | 00:18 | |
| *** mtanino_ has quit IRC | 00:21 | |
| *** ijw has joined #openstack-nova | 00:22 | |
| *** achanda has joined #openstack-nova | 00:23 | |
| *** iamjarvo has quit IRC | 00:24 | |
| *** armax has joined #openstack-nova | 00:29 | |
| *** jwcroppe_ has quit IRC | 00:30 | |
| *** jwcroppe has joined #openstack-nova | 00:30 | |
| *** david-lyle has quit IRC | 00:32 | |
| *** browne has quit IRC | 00:33 | |
| *** jwcroppe has quit IRC | 00:35 | |
| *** ijw has quit IRC | 00:35 | |
| *** yingjun has joined #openstack-nova | 00:39 | |
| *** yingjun_ has joined #openstack-nova | 00:40 | |
| *** IanGovett has quit IRC | 00:40 | |
| *** promulo_ has joined #openstack-nova | 00:42 | |
| *** Marga_ has quit IRC | 00:42 | |
| openstackgerrit | Shilla Saebi proposed openstack/nova: minor change to aggregates.rst https://review.openstack.org/178462 | 00:43 |
|---|---|---|
| openstackgerrit | Eli Qiao proposed openstack/nova: API/Object: Remove _get_flavor in simple_tenant_usage api https://review.openstack.org/178056 | 00:43 |
| *** yingjun has quit IRC | 00:44 | |
| *** promulo__ has quit IRC | 00:46 | |
| openstackgerrit | Shilla Saebi proposed openstack/nova: minor edit to policy_enforcement.rst https://review.openstack.org/178463 | 00:49 |
| *** asettle has joined #openstack-nova | 00:49 | |
| *** Nic has quit IRC | 00:50 | |
| *** asettle has quit IRC | 00:54 | |
| *** asettle has joined #openstack-nova | 00:56 | |
| *** asettle has quit IRC | 00:56 | |
| *** signed8bit has joined #openstack-nova | 00:58 | |
| *** asettle has joined #openstack-nova | 00:59 | |
| *** tjones1 has joined #openstack-nova | 01:01 | |
| openstackgerrit | Lianhao Lu proposed openstack/nova: Convert bandwidth_usage related timestamp to UTC native datetime https://review.openstack.org/173213 | 01:03 |
| *** xyang1 has quit IRC | 01:05 | |
| *** emagana has joined #openstack-nova | 01:06 | |
| *** Marga_ has joined #openstack-nova | 01:09 | |
| openstackgerrit | Eli Qiao proposed openstack/nova-specs: Improve lock_server api return code https://review.openstack.org/163275 | 01:10 |
| *** emagana has quit IRC | 01:10 | |
| *** emagana has joined #openstack-nova | 01:11 | |
| *** ijw has joined #openstack-nova | 01:11 | |
| *** yingjun_ has quit IRC | 01:13 | |
| *** ijw has quit IRC | 01:16 | |
| *** salv-orlando has joined #openstack-nova | 01:17 | |
| *** david-lyle has joined #openstack-nova | 01:20 | |
| *** tjones1 has quit IRC | 01:21 | |
| *** zhangtralon has joined #openstack-nova | 01:22 | |
| *** salv-orlando has quit IRC | 01:22 | |
| *** dsanders has quit IRC | 01:23 | |
| *** popw has joined #openstack-nova | 01:24 | |
| *** joefides has joined #openstack-nova | 01:24 | |
| *** joefides_ has quit IRC | 01:27 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: remove admin require from compute_node_get_all_by_* from db layer https://review.openstack.org/175334 | 01:31 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: Add policy enforcement test cases for pci API https://review.openstack.org/175745 | 01:31 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: remove instance_get_all_by_host hard-code admin check from db https://review.openstack.org/177673 | 01:31 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: remove admin require for compute_node(get_all/search_by_hyperviso) from db https://review.openstack.org/175744 | 01:31 |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: remove admin require for compute_node_create/update/delete from db layer https://review.openstack.org/175693 | 01:31 |
| *** Jeffrey4l has joined #openstack-nova | 01:36 | |
| *** markvoelker has quit IRC | 01:36 | |
| *** marun has quit IRC | 01:38 | |
| *** zhenguo has joined #openstack-nova | 01:38 | |
| *** annashen has joined #openstack-nova | 01:39 | |
| *** otter768 has joined #openstack-nova | 01:41 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: API: remove instance_get_all_by_host hard-code admin check from db https://review.openstack.org/177673 | 01:42 |
| *** annashen has quit IRC | 01:42 | |
| openstackgerrit | Alex Xu proposed openstack/nova: API: remove instance_get_all_by_host hard-code admin check from db https://review.openstack.org/177673 | 01:46 |
| openstackgerrit | Alex Xu proposed openstack/nova: API: remove instance_get_all_by_host hard-code admin check from db https://review.openstack.org/177673 | 01:47 |
| openstackgerrit | Alex Xu proposed openstack/nova: API: remove instance_get_all_by_host hard-code admin check from db https://review.openstack.org/177673 | 01:47 |
| *** yamahata has quit IRC | 01:48 | |
| *** signed8bit has quit IRC | 01:48 | |
| *** mwagner_lap has quit IRC | 01:49 | |
| *** baoli has joined #openstack-nova | 01:49 | |
| *** erkules_ has joined #openstack-nova | 01:50 | |
| *** erkules has quit IRC | 01:50 | |
| openstackgerrit | heijlong proposed openstack/nova: Merge servers-ips functional tests of v2 and v2.1 https://review.openstack.org/174237 | 01:51 |
| *** vilobhmm1 has quit IRC | 01:51 | |
| *** dims_ is now known as dims | 01:52 | |
| *** baoli has quit IRC | 01:53 | |
| *** vilobhmm1 has joined #openstack-nova | 01:53 | |
| *** baoli has joined #openstack-nova | 01:53 | |
| *** xuhanp has joined #openstack-nova | 01:53 | |
| *** xuhanp_ has joined #openstack-nova | 01:53 | |
| *** vilobhmm1 has quit IRC | 01:53 | |
| *** vilobhmm1 has joined #openstack-nova | 01:54 | |
| *** bnemec has quit IRC | 01:56 | |
| *** asettle has quit IRC | 01:57 | |
| openstackgerrit | melanie witt proposed openstack/nova: WIP: send object to cells instance_update_at_top https://review.openstack.org/176518 | 01:57 |
| *** bnemec has joined #openstack-nova | 01:59 | |
| *** browne has joined #openstack-nova | 02:00 | |
| *** harlowja is now known as harlowja_away | 02:03 | |
| *** vilobhmm1 has quit IRC | 02:04 | |
| *** mwagner_lap has joined #openstack-nova | 02:06 | |
| *** VW_ has joined #openstack-nova | 02:07 | |
| *** baoli has quit IRC | 02:11 | |
| *** baoli has joined #openstack-nova | 02:12 | |
| *** tjones1 has joined #openstack-nova | 02:20 | |
| *** tjones1 has quit IRC | 02:21 | |
| *** tjones1 has joined #openstack-nova | 02:21 | |
| *** tjones1 has left #openstack-nova | 02:22 | |
| *** unicell1 has quit IRC | 02:24 | |
| *** angdraug has quit IRC | 02:25 | |
| *** yingjun has joined #openstack-nova | 02:27 | |
| *** dave-mccowan has joined #openstack-nova | 02:28 | |
| *** david-lyle has quit IRC | 02:30 | |
| *** david-lyle has joined #openstack-nova | 02:31 | |
| *** patrickeast has quit IRC | 02:32 | |
| *** jwcroppe has joined #openstack-nova | 02:32 | |
| *** david-lyle has quit IRC | 02:36 | |
| *** tralon_ has joined #openstack-nova | 02:37 | |
| *** emagana has quit IRC | 02:40 | |
| *** markvoelker has joined #openstack-nova | 02:41 | |
| *** jwcroppe has quit IRC | 02:45 | |
| *** asettle has joined #openstack-nova | 02:51 | |
| *** ildikov has quit IRC | 02:51 | |
| *** gyee has quit IRC | 02:53 | |
| *** VW_ has quit IRC | 02:53 | |
| *** VW_ has joined #openstack-nova | 02:54 | |
| *** yingjun has quit IRC | 02:59 | |
| *** ildikov has joined #openstack-nova | 03:04 | |
| *** yingjun has joined #openstack-nova | 03:08 | |
| *** dave-mccowan has quit IRC | 03:12 | |
| *** salv-orlando has joined #openstack-nova | 03:14 | |
| *** salv-orlando has quit IRC | 03:25 | |
| *** tojuvone has joined #openstack-nova | 03:26 | |
| *** coolsvap|afk is now known as coolsvap | 03:27 | |
| *** yamahata has joined #openstack-nova | 03:27 | |
| *** david-lyle has joined #openstack-nova | 03:32 | |
| *** changbl has joined #openstack-nova | 03:33 | |
| *** baoli has quit IRC | 03:34 | |
| *** jwcroppe has joined #openstack-nova | 03:42 | |
| *** sudipto has joined #openstack-nova | 03:43 | |
| *** tralon_ has quit IRC | 03:54 | |
| *** yingjun has quit IRC | 04:01 | |
| *** sdake_ has joined #openstack-nova | 04:04 | |
| *** vilobhmm1 has joined #openstack-nova | 04:08 | |
| *** sdake has quit IRC | 04:08 | |
| *** armax has quit IRC | 04:09 | |
| *** sdake_ has quit IRC | 04:11 | |
| *** kiran-r has joined #openstack-nova | 04:13 | |
| *** VW_ has quit IRC | 04:18 | |
| *** rushiagr_away is now known as rushiagr | 04:21 | |
| *** garyk has quit IRC | 04:21 | |
| *** kiran-r has quit IRC | 04:22 | |
| *** jyuso1 has quit IRC | 04:23 | |
| *** krak has joined #openstack-nova | 04:28 | |
| krak | Hey Guys, seeing some errors. Folks from heat list have suggested its a bug between neutron and nova. | 04:29 |
| krak | could someone please have a look at the logs and help me with that to confirm it. | 04:29 |
| *** asettle has quit IRC | 04:30 | |
| krak | It usually occurs when deleting a vm. the server ends up in error state. | 04:30 |
| krak | I have the logs. kindly let me know if someone can have a look. | 04:30 |
| *** asettle has joined #openstack-nova | 04:34 | |
| *** mwagner_lap has quit IRC | 04:36 | |
| *** ildikov has quit IRC | 04:44 | |
| *** rushiagr is now known as rushiagr_away | 04:45 | |
| *** zhangtralon has quit IRC | 04:46 | |
| *** asettle has quit IRC | 04:47 | |
| *** mwagner_lap has joined #openstack-nova | 04:52 | |
| *** unicell has joined #openstack-nova | 04:53 | |
| *** ildikov has joined #openstack-nova | 04:57 | |
| *** nkrinner has joined #openstack-nova | 04:57 | |
| *** unicell1 has joined #openstack-nova | 05:00 | |
| *** gtt116_ has joined #openstack-nova | 05:00 | |
| *** unicell has quit IRC | 05:01 | |
| *** gtt116 has quit IRC | 05:04 | |
| *** sudipto has quit IRC | 05:04 | |
| *** krak has quit IRC | 05:08 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Add version bump guideline in microversion devref https://review.openstack.org/177778 | 05:08 |
| *** Nikolay_St has quit IRC | 05:09 | |
| *** yingjun has joined #openstack-nova | 05:14 | |
| *** yingjun has quit IRC | 05:14 | |
| *** salv-orlando has joined #openstack-nova | 05:15 | |
| *** xuhanp_ has quit IRC | 05:16 | |
| *** xuhanp has quit IRC | 05:16 | |
| *** asettle has joined #openstack-nova | 05:19 | |
| *** asettle has quit IRC | 05:20 | |
| openstackgerrit | Chris Friesen proposed openstack/nova: fix network setup on evacuate https://review.openstack.org/169827 | 05:21 |
| *** irenab has joined #openstack-nova | 05:21 | |
| *** salv-orlando has quit IRC | 05:26 | |
| *** ildikov has quit IRC | 05:28 | |
| *** vilobhmm1 has quit IRC | 05:28 | |
| *** atuvenie has joined #openstack-nova | 05:30 | |
| *** Marga_ has quit IRC | 05:34 | |
| *** wanghao has quit IRC | 05:35 | |
| *** kiran-r has joined #openstack-nova | 05:35 | |
| *** ajayaa has joined #openstack-nova | 05:38 | |
| *** cfriesen has quit IRC | 05:40 | |
| *** josecastroleon has joined #openstack-nova | 05:40 | |
| *** jichen has joined #openstack-nova | 05:41 | |
| *** park_heijlong has joined #openstack-nova | 05:45 | |
| *** annashen has joined #openstack-nova | 05:45 | |
| *** mwagner_lap has quit IRC | 05:46 | |
| *** jecarey has quit IRC | 05:46 | |
| *** Murali has joined #openstack-nova | 05:49 | |
| openstackgerrit | Mh Raies proposed openstack/nova: Enable tenant/user specific instance filtering https://review.openstack.org/139025 | 05:52 |
| *** atuvenie has quit IRC | 05:53 | |
| *** yingjun has joined #openstack-nova | 05:55 | |
| *** annashen has quit IRC | 05:57 | |
| *** atuvenie has joined #openstack-nova | 05:59 | |
| *** Hosam has joined #openstack-nova | 06:00 | |
| *** doron_afk has joined #openstack-nova | 06:00 | |
| *** dulek has joined #openstack-nova | 06:02 | |
| *** romainh has joined #openstack-nova | 06:02 | |
| *** Longgeek has joined #openstack-nova | 06:03 | |
| *** mwagner_lap has joined #openstack-nova | 06:03 | |
| *** kiwik-chenrui has quit IRC | 06:03 | |
| *** kiwik-chenrui has joined #openstack-nova | 06:03 | |
| *** vilobhmm1 has joined #openstack-nova | 06:03 | |
| *** otter768 has quit IRC | 06:04 | |
| *** sudipto has joined #openstack-nova | 06:06 | |
| *** igordcard_ has quit IRC | 06:06 | |
| *** doude has quit IRC | 06:07 | |
| *** Longgeek has quit IRC | 06:08 | |
| *** exploreshaifali has joined #openstack-nova | 06:09 | |
| *** pcaruana has joined #openstack-nova | 06:09 | |
| *** park_heijlong has quit IRC | 06:11 | |
| *** leseb has quit IRC | 06:12 | |
| *** jlvillal has quit IRC | 06:14 | |
| *** igordcard_ has joined #openstack-nova | 06:14 | |
| *** jlvillal has joined #openstack-nova | 06:16 | |
| *** eliqiao has quit IRC | 06:16 | |
| *** zul has joined #openstack-nova | 06:17 | |
| *** leseb has joined #openstack-nova | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/178055 | 06:18 |
| *** kiwik-chenrui has quit IRC | 06:19 | |
| *** kiwik-chenrui has joined #openstack-nova | 06:19 | |
| *** pkoniszewski has joined #openstack-nova | 06:19 | |
| *** jyuso1 has joined #openstack-nova | 06:22 | |
| *** zul has quit IRC | 06:24 | |
| *** zul has joined #openstack-nova | 06:25 | |
| *** zhangtralon has joined #openstack-nova | 06:25 | |
| *** xuhanp has joined #openstack-nova | 06:25 | |
| *** xuhanp_ has joined #openstack-nova | 06:25 | |
| *** salv-orlando has joined #openstack-nova | 06:34 | |
| *** Kevin_Zheng has joined #openstack-nova | 06:37 | |
| *** ildikov has joined #openstack-nova | 06:40 | |
| *** salv-orlando has quit IRC | 06:42 | |
| *** sudipto has quit IRC | 06:45 | |
| *** dulek has quit IRC | 06:46 | |
| *** vilobhmm1 has quit IRC | 06:46 | |
| *** vilobhmm1 has joined #openstack-nova | 06:47 | |
| *** vilobhmm1 has quit IRC | 06:48 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added method is_exist to the Tag object https://review.openstack.org/178103 | 06:48 |
| *** jcoufal has joined #openstack-nova | 06:49 | |
| *** sudipto has joined #openstack-nova | 06:50 | |
| *** garyk has joined #openstack-nova | 06:50 | |
| *** dulek has joined #openstack-nova | 06:52 | |
| *** Longgeek has joined #openstack-nova | 06:56 | |
| *** garyk1 has joined #openstack-nova | 07:00 | |
| *** tdurakov has quit IRC | 07:00 | |
| *** ajo has quit IRC | 07:01 | |
| *** Longgeek has quit IRC | 07:02 | |
| *** garyk has quit IRC | 07:02 | |
| *** tdurakov has joined #openstack-nova | 07:03 | |
| *** Longgeek has joined #openstack-nova | 07:06 | |
| *** sahid has joined #openstack-nova | 07:06 | |
| *** browne has quit IRC | 07:09 | |
| *** exploreshaifali has quit IRC | 07:09 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Changed logic in _compare_result api_samples_test_base https://review.openstack.org/178191 | 07:12 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Removed 'PYTHONHASHSEED=0' from tox.ini https://review.openstack.org/163877 | 07:12 |
| *** pask81 has joined #openstack-nova | 07:15 | |
| *** mpavone has joined #openstack-nova | 07:20 | |
| *** xuhanp_ has quit IRC | 07:21 | |
| *** xuhanp has quit IRC | 07:21 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Changed logic in _compare_result api_samples_test_base https://review.openstack.org/178191 | 07:22 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Removed 'PYTHONHASHSEED=0' from tox.ini https://review.openstack.org/163877 | 07:22 |
| *** garyk has joined #openstack-nova | 07:23 | |
| *** bfic has joined #openstack-nova | 07:25 | |
| *** garyk1 has quit IRC | 07:26 | |
| *** doron_afk is now known as doron | 07:26 | |
| *** mwagner_lap has quit IRC | 07:28 | |
| openstackgerrit | Bartosz Fic proposed openstack/nova: Live migration failure in API doesn't set vm_state to Error https://review.openstack.org/168916 | 07:30 |
| *** zul has quit IRC | 07:32 | |
| *** zul has joined #openstack-nova | 07:32 | |
| *** exploreshaifali has joined #openstack-nova | 07:38 | |
| *** kaisers has quit IRC | 07:39 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Changed logic in _compare_result api_samples_test_base https://review.openstack.org/178191 | 07:39 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Removed 'PYTHONHASHSEED=0' from tox.ini https://review.openstack.org/163877 | 07:39 |
| *** kaisers has joined #openstack-nova | 07:41 | |
| *** eliqiao has joined #openstack-nova | 07:42 | |
| *** jlanoux has joined #openstack-nova | 07:43 | |
| *** ildikov has quit IRC | 07:43 | |
| *** moshele has joined #openstack-nova | 07:44 | |
| *** jwcroppe has quit IRC | 07:44 | |
| *** ildikov has joined #openstack-nova | 07:44 | |
| *** dsanders has joined #openstack-nova | 07:45 | |
| *** jwcroppe has joined #openstack-nova | 07:45 | |
| *** kaisers has quit IRC | 07:45 | |
| *** mwagner_lap has joined #openstack-nova | 07:46 | |
| tdurakov | gilliard: hi! thanks for comment^) | 07:46 |
| *** doron is now known as doron_afk | 07:46 | |
| gilliard | hello tdurakov :) | 07:47 |
| *** kaisers has joined #openstack-nova | 07:47 | |
| *** achanda has quit IRC | 07:48 | |
| gilliard | You're welcome. Is that the last of those patches now? | 07:48 |
| *** Nikolay_St has joined #openstack-nova | 07:49 | |
| *** jwcroppe has quit IRC | 07:49 | |
| *** ajo has joined #openstack-nova | 07:51 | |
| *** exploreshaifali has quit IRC | 07:51 | |
| *** achanda has joined #openstack-nova | 07:56 | |
| *** jeblair has quit IRC | 07:56 | |
| *** jeblair has joined #openstack-nova | 07:56 | |
| *** jistr has joined #openstack-nova | 07:58 | |
| openstackgerrit | Yongli He proposed openstack/nova: resource tracker style pci resource management https://review.openstack.org/131321 | 08:00 |
| *** derekh has joined #openstack-nova | 08:01 | |
| *** otter768 has joined #openstack-nova | 08:05 | |
| *** Longgeek has quit IRC | 08:05 | |
| *** salv-orlando has joined #openstack-nova | 08:08 | |
| *** zul has quit IRC | 08:09 | |
| *** otter768 has quit IRC | 08:10 | |
| *** dims has quit IRC | 08:10 | |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Changed logic in _compare_result api_samples_test_base https://review.openstack.org/178191 | 08:11 |
| openstackgerrit | Timofey Durakov proposed openstack/nova: Removed 'PYTHONHASHSEED=0' from tox.ini https://review.openstack.org/163877 | 08:11 |
| *** ndipanov has quit IRC | 08:12 | |
| *** ndipanov has joined #openstack-nova | 08:12 | |
| *** dsanders has quit IRC | 08:12 | |
| *** lucasagomes has joined #openstack-nova | 08:14 | |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused db.aggregate_metadata_get_by_metadata_key() call https://review.openstack.org/159053 | 08:15 |
| openstackgerrit | Alex Xu proposed openstack/nova: Add the rule of separate plugin for Nova REST API in devref https://review.openstack.org/162913 | 08:18 |
| *** yassine_ has joined #openstack-nova | 08:18 | |
| *** eglynn has joined #openstack-nova | 08:24 | |
| openstackgerrit | Marian Horban proposed openstack/nova: Disassociating of floating IPs corrected https://review.openstack.org/149358 | 08:24 |
| *** zul has joined #openstack-nova | 08:25 | |
| *** yamahata has quit IRC | 08:25 | |
| *** zhangtralon has quit IRC | 08:27 | |
| openstackgerrit | Noel Nelson Dsouza proposed openstack/nova: Nova can stop instance when Fake/Actual compute driver used https://review.openstack.org/174746 | 08:29 |
| *** achanda has quit IRC | 08:33 | |
| *** jeblair has quit IRC | 08:33 | |
| *** achanda has joined #openstack-nova | 08:33 | |
| *** achanda has quit IRC | 08:35 | |
| *** gszasz has joined #openstack-nova | 08:35 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 08:36 | |
| bauzas | johnthetubaguy: morning (hassling you quite early eh) | 08:40 |
| bauzas | johnthetubaguy: I have some points to discuss with you about requestspec objecft | 08:40 |
| bauzas | johnthetubaguy: first, it would be cool if you could just quickly review a spec modification https://review.openstack.org/#/c/176083/ | 08:41 |
| bauzas | johnthetubaguy: just because it's how it will be needed to be | 08:41 |
| bauzas | johnthetubaguy: and that prevents me further work | 08:41 |
| bauzas | johnthetubaguy: the second point is on the same spec, I should mention that I'll make use of an ImageMeta object | 08:42 |
| *** yingjun has quit IRC | 08:42 | |
| bauzas | johnthetubaguy: https://review.openstack.org/#/c/76234/25 having a procedural -2, I think it would be ideal if you could remove that one just because my spec will need it (provided we merge the spec change), or just because it's part of the global objects effort | 08:43 |
| *** yingjun has joined #openstack-nova | 08:43 | |
| *** johnthetubaguy is now known as zz_johnthetubagu | 08:44 | |
| *** zz_johnthetubagu is now known as johnthetubaguy | 08:45 | |
| *** jwcroppe has joined #openstack-nova | 08:46 | |
| *** ferest has joined #openstack-nova | 08:49 | |
| *** jeblair has joined #openstack-nova | 08:51 | |
| johnthetubaguy | bauzas: sorry, I was fighting IRC there, looking at your requests | 08:53 |
| johnthetubaguy | bauzas: can't remove the -2 until the spec is merged and blueprint is approved | 08:54 |
| *** bfic has quit IRC | 08:54 | |
| eliqiao | hi johnthetubaguy: can you kindly help review this spec https://review.openstack.org/#/c/177671/ , it's about console-auth service HA support. | 08:54 |
| *** ferest has quit IRC | 08:54 | |
| *** mwagner_lap has quit IRC | 08:55 | |
| bauzas | johnthetubaguy: makes sense | 08:55 |
| johnthetubaguy | eliqiao: its on my list, but we are about a week behind or so at the moment, hope to get to yours very soon | 08:55 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Amend RequestSpec blueprint by using an ImageMeta object https://review.openstack.org/178563 | 08:55 |
| bauzas | johnthetubaguy: hence what's just coming in ^ | 08:55 |
| johnthetubaguy | bauzas: I usually remove the -2 when I approve the blueprint, assuming I understand the blueprint dashboard at the time I approve the blueprint | 08:56 |
| eliqiao | johnthetubaguy: thanks in advance :) | 08:56 |
| *** doron_afk is now known as doron | 08:56 | |
| bauzas | johnthetubaguy: tbh it was overkill to mention a separate BP for https://review.openstack.org/#/c/76234/ | 08:56 |
| bauzas | johnthetubaguy: but I understand your point which is valid | 08:57 |
| bauzas | johnthetubaguy: so I or dan will update the change by changing the commit msg to point to the RequestSpec bp | 08:57 |
| *** annashen has joined #openstack-nova | 08:57 | |
| johnthetubaguy | bauzas: sorry, I am confused now | 08:58 |
| bauzas | johnthetubaguy: okay, rewinding :) | 08:58 |
| johnthetubaguy | bauzas: what blueprints do you want to track the work? which are approved right now? | 08:58 |
| bauzas | johnthetubaguy: so, danpb worked on https://review.openstack.org/#/c/76234/ on his side separately | 08:58 |
| bauzas | johnthetubaguy: because he wanted that for the virt drivers | 08:58 |
| bauzas | johnthetubaguy: on my side, I'm working on implementing http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/request-spec-object.html | 08:59 |
| bauzas | johnthetubaguy: but I discovered some last minute issues that need to amend the spec | 08:59 |
| johnthetubaguy | bauzas: OK | 08:59 |
| bauzas | johnthetubaguy: the first one is that we need to explode the Instance object into smaller fields, ie. https://review.openstack.org/#/c/176083/ | 09:00 |
| johnthetubaguy | bauzas: we need to add that blueprint into liberty, and get it approved, not sure it needs a spec: https://blueprints.launchpad.net/nova/+spec/convert-image-meta-into-nova-object | 09:00 |
| bauzas | johnthetubaguy: the second one is that we can't accept a DictofStrings for the image info, hence https://review.openstack.org/178563 | 09:00 |
| bauzas | so, https://review.openstack.org/#/c/176083/ and https://review.openstack.org/178563 are just there for making sure the spec is matching what will be implemented | 09:01 |
| bauzas | johnthetubaguy: then, a new patchset for https://review.openstack.org/#/c/76234/ will be the implementation of https://review.openstack.org/178563 so I will change the commit msg to refer to request-spec-object instead of that convert-image-meta-into-nova-object BP | 09:02 |
| *** annashen has quit IRC | 09:02 | |
| bauzas | johnthetubaguy: that would allow to consider https://review.openstack.org/#/c/76234/ as implementation of https://review.openstack.org/178563 which would be approved, so the -2 would no longer be needed | 09:02 |
| *** gtt116 has joined #openstack-nova | 09:03 | |
| *** popw has quit IRC | 09:03 | |
| *** popw has joined #openstack-nova | 09:03 | |
| *** dulek_ has joined #openstack-nova | 09:03 | |
| *** dulek has quit IRC | 09:03 | |
| *** bfic has joined #openstack-nova | 09:04 | |
| *** bfic has quit IRC | 09:04 | |
| johnthetubaguy | bauzas: we just need the patch to point at an approved blueprint, added it to the meeting agenda to get approved | 09:05 |
| johnthetubaguy | bauzas: changing the patch to point to an approved blueprint is also fine | 09:05 |
| bauzas | johnthetubaguy: agreed | 09:05 |
| *** gtt116_ has quit IRC | 09:05 | |
| *** Longgeek has joined #openstack-nova | 09:06 | |
| *** apuimedo has quit IRC | 09:09 | |
| openstackgerrit | Noel Nelson Dsouza proposed openstack/nova: Nova can stop instance when Fake/Actual compute driver used https://review.openstack.org/174746 | 09:10 |
| *** doron is now known as doron_afk | 09:10 | |
| *** mwagner_lap has joined #openstack-nova | 09:11 | |
| *** Longgeek has quit IRC | 09:12 | |
| *** Longgeek has joined #openstack-nova | 09:13 | |
| *** yingjun has quit IRC | 09:13 | |
| *** yingjun_ has joined #openstack-nova | 09:13 | |
| *** jwcroppe has quit IRC | 09:14 | |
| *** jyuso1 has quit IRC | 09:14 | |
| *** jyuso1 has joined #openstack-nova | 09:14 | |
| *** zhangtralon has joined #openstack-nova | 09:17 | |
| *** jyuso1 has quit IRC | 09:17 | |
| *** zul has quit IRC | 09:27 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Added method exists to the Tag object https://review.openstack.org/178103 | 09:30 |
| *** josecastroleon has quit IRC | 09:33 | |
| *** yingjun_ has quit IRC | 09:35 | |
| *** sudipto has quit IRC | 09:36 | |
| *** sorrison has quit IRC | 09:38 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Add functional test for server group https://review.openstack.org/147514 | 09:40 |
| *** aswadr has joined #openstack-nova | 09:44 | |
| *** sorrison has joined #openstack-nova | 09:46 | |
| johnthetubaguy | alex_xu: hey, I attempted to update that spec for the API relax validation: https://review.openstack.org/#/c/173243/ | 09:46 |
| alex_xu | johnthetubaguy: hi, what you want to update? | 09:47 |
| *** atuvenie has quit IRC | 09:48 | |
| *** pixelb has joined #openstack-nova | 09:49 | |
| alex_xu | johnthetubaguy: oops, I guess you mean you 'updated' the spec | 09:49 |
| *** oro has joined #openstack-nova | 09:49 | |
| alex_xu | johnthetubaguy: will review the spec today | 09:49 |
| *** markmcclain has quit IRC | 09:49 | |
| *** zul has joined #openstack-nova | 09:51 | |
| *** dims has joined #openstack-nova | 09:51 | |
| *** sudipto has joined #openstack-nova | 09:52 | |
| *** redbeard has joined #openstack-nova | 09:52 | |
| *** yassine_ has quit IRC | 09:54 | |
| *** ajayaa has quit IRC | 09:57 | |
| *** Hosam has quit IRC | 09:57 | |
| *** markmcclain has joined #openstack-nova | 09:59 | |
| *** IanGovett has joined #openstack-nova | 10:00 | |
| *** bfic has joined #openstack-nova | 10:02 | |
| johnthetubaguy | alex_xu: thank you :) | 10:02 |
| *** jeblair has quit IRC | 10:03 | |
| alex_xu | johnthetubaguy: np :) | 10:03 |
| *** jeblair has joined #openstack-nova | 10:03 | |
| *** dulek_ has quit IRC | 10:06 | |
| *** otter768 has joined #openstack-nova | 10:06 | |
| *** mtreinish has quit IRC | 10:07 | |
| openstackgerrit | John Garbutt proposed openstack/nova: devref: update the nova architecture doc https://review.openstack.org/177374 | 10:07 |
| sudipto | johnthetubaguy, quick question....Would you be able to tell me, why the scheduled_at field is not longer being updated in the nova instances table? | 10:08 |
| *** doude has joined #openstack-nova | 10:09 | |
| *** ajayaa has joined #openstack-nova | 10:10 | |
| *** otter768 has quit IRC | 10:10 | |
| kashyap | Anyone else see the "check-grenade-dsvm" job failing? -- http://logs.openstack.org/61/178061/1/check/check-grenade-dsvm/92458a9/console.html | 10:11 |
| bauzas | sudipto: that reminds me a good explanation | 10:11 |
| sudipto | bauzas, ok :) | 10:11 |
| bauzas | sudipto: sec, finding the link | 10:11 |
| sudipto | bauzas, it looks like this https://review.openstack.org/#/c/143725/2 removed it? | 10:12 |
| johnthetubaguy | sudipto: bauzas: I didn't know that was the case, if I am honest | 10:12 |
| sudipto | bauzas, and if did remove the updating of the field - then having it defined in the models.py probably means we need to clean it up? | 10:12 |
| bauzas | sudipto: johnthetubaguy: http://lists.openstack.org/pipermail/openstack-dev/2015-March/059603.html | 10:13 |
| bauzas | sudipto: since the scheduler is no longer always involved in migration tasks, the scheduled_at field is unrelevant | 10:14 |
| johnthetubaguy | bauzas: it just looks like a bug in the build_and_run_instance method we added, if I am being honest | 10:14 |
| *** ociuhandu has joined #openstack-nova | 10:15 | |
| bauzas | johnthetubaguy: I think it's confusing to fix that | 10:15 |
| johnthetubaguy | bauzas: granted we don't want the scheduler writing that in the DB, just not sure why the conductor does't do that | 10:15 |
| bauzas | johnthetubaguy: since a nova evacuate vm host can just bypass the scheduler | 10:15 |
| sudipto | bauzas, johnthetubaguy the launched_at field is something that gains more significance in this case? | 10:15 |
| johnthetubaguy | bauzas: I didn't think it worked for that either | 10:16 |
| bauzas | johnthetubaguy: yeah, so the real metric is launched_at IMHO | 10:16 |
| johnthetubaguy | bauzas: we need migration records for evacuate really, thats how you should track VMs moving around, be we haven't got those for everything yet | 10:16 |
| bauzas | johnthetubaguy: because it's now decoupled between scheduling and booting | 10:16 |
| bauzas | johnthetubaguy: as formerly, the scheduler was proxying the boot call | 10:16 |
| johnthetubaguy | bauzas: thats an excuse not a reason, but anyways, its mostly a useless statistic | 10:17 |
| bauzas | johnthetubaguy: launched_at is updated when migratingh | 10:17 |
| bauzas | johnthetubaguy: as I said, what comes if a VM is scheduled yesterday to an host and then evacuated to a second host by specifying its destination ? | 10:18 |
| jichen | hi, do anyone know if cherrypick to old branch , reported cherry pick error, what kind of actions should I take? | 10:18 |
| bauzas | johnthetubaguy: then the current_time - scheduled_at would makes no sense | 10:18 |
| bauzas | jichen: I don't get it ? you have conflicts N | 10:18 |
| bauzas | ? | 10:19 |
| bauzas | jichen: if so, git mergetool and git cherry-pick --continue | 10:19 |
| *** doude has quit IRC | 10:19 | |
| *** zul has quit IRC | 10:19 | |
| jichen | bauzas: ok, so I need to get the code locally and do it ? | 10:19 |
| sudipto | bauzas, johnthetubaguy Ok - from a stats per say - how would one be able to determine the uptime of a VM on a given host? | 10:19 |
| johnthetubaguy | sudipto: right now you can't really, we should be able to use the migration records | 10:20 |
| bauzas | jichen: oh, just chekout your stable branch and cherry-pick on the master sha | 10:20 |
| *** arif-ali has quit IRC | 10:20 | |
| johnthetubaguy | sudipto: but we only update migration records for migrates and resizes at this point | 10:20 |
| bauzas | sudipto: current_time - launched_at as said by jaypipes | 10:20 |
| jichen | bauzas: ok, let me try it, thanks | 10:20 |
| *** apuimedo has joined #openstack-nova | 10:20 | |
| johnthetubaguy | bauzas: hmm, not so sure about that, but OK…. does that work with evacuate etc? | 10:21 |
| sudipto | bauzas, the launched_at is updated for a operation like re-size as well... | 10:21 |
| *** dikonoor has joined #openstack-nova | 10:21 | |
| johnthetubaguy | sudipto: for resize you can look at migrate records in the DB | 10:21 |
| sudipto | bauzas, if that's the case, then what Jay Pipes has suggested would only give me the time for that instance on a given host since the last operation. | 10:21 |
| sudipto | bauzas, ok. | 10:21 |
| bauzas | johnthetubaguy: yeah, sounds like but I can double-check | 10:22 |
| *** zhangtralon has quit IRC | 10:22 | |
| sudipto | bauzas, johnthetubaguy IMHO this isn't a very direct way of figuring out the age of a VM on a host. | 10:22 |
| bauzas | sudipto: then call the bus :) | 10:22 |
| bauzas | sudipto: ie. look at your notifications | 10:23 |
| bauzas | sudipto: querying a DB doesn't sound very handy IMHO | 10:23 |
| bauzas | sudipto: that's the whole purpose of Ceilometer btw. | 10:23 |
| bauzas | sudipto: but you don't need Ceilo, just subsribe to the RPC notifications | 10:23 |
| johnthetubaguy | stachtach does that too, but that is another way | 10:23 |
| sudipto | Ceilo is also fine... | 10:24 |
| bauzas | johnthetubaguy: agreed, as I said, it's just all about getting stats from the queue | 10:24 |
| bauzas | so any oslo.messing notification poller is good | 10:24 |
| bauzas | oh | 10:24 |
| bauzas | s/messing/messaging | 10:24 |
| * bauzas made a unvoluntary but funny pun | 10:25 | |
| bauzas | dims: ^ | 10:25 |
| sudipto | bauzas, johnthetubaguy atleast it sounds like I can work on a cleanup task to clear out the scheduled_at field from the models and subsequently from the DB? | 10:26 |
| bauzas | so yeah, IMHO getting stats from DB is just one way for operators to troubleshoot | 10:26 |
| sudipto | bauzas, johnthetubaguy but that may lead to some migration issues? | 10:26 |
| bauzas | sudipto: I would tend to say yes, if the field is unused - but that needs to be triaged on how - just because we're working on online migrations | 10:26 |
| *** wznoinsk has quit IRC | 10:27 | |
| *** doude has joined #openstack-nova | 10:27 | |
| sudipto | bauzas, triaged on how - i guess you mean - a trace to confirm that it's completely unused? | 10:28 |
| bauzas | sudipto: no no | 10:28 |
| bauzas | sudipto: I mean, you can't just write a migration script which would remove that col | 10:29 |
| bauzas | sudipto: so a spec should be needed anyway | 10:29 |
| bauzas | sudipto: because that's a DB migration | 10:29 |
| bauzas | but I leave that ^ to johnthetubaguy | 10:30 |
| johnthetubaguy | it needs a spec | 10:30 |
| bauzas | voila | 10:30 |
| bauzas | and we need to discuss on how migrations should be managed in Liberty right ? | 10:30 |
| sudipto | bauzas, ok a relatively dumb question, do we support backward compatibility of the tables? as in, since this field is not being used in the newer releases, will we have the operator do migration to an older release? | 10:31 |
| johnthetubaguy | sudipto: appreciate the appetite for tidying up the DB thought, awesome stuff :) | 10:31 |
| *** ociuhandu has quit IRC | 10:31 | |
| johnthetubaguy | the spec should be really short, which is nice | 10:31 |
| sudipto | johnthetubaguy, If i have to write a spec, would you please help me with any existing ones that may have done such a thing? | 10:31 |
| sudipto | johnthetubaguy, I relatively new to openstack contributions, hence asking :) | 10:32 |
| bauzas | sudipto: that's what objects are used to | 10:32 |
| bauzas | sudipto: in general, you write a compatibility layer in the object, then you do your DB change | 10:32 |
| johnthetubaguy | sudipto: there is a data model impact section, you just need to say which column you drop, and at the top in the problem, just say its no longer used, and that should all you need | 10:32 |
| sudipto | bauzas, yeah - the sqlalchemy layer - models.py i guess? | 10:32 |
| bauzas | sudipto: no no | 10:33 |
| bauzas | sudipto: NovaObjects | 10:33 |
| sudipto | bauzas, Ah i see... | 10:33 |
| sudipto | johnthetubaguy, ok thanks :) | 10:33 |
| bauzas | sudipto: some NovaObjects can be persisted | 10:33 |
| bauzas | some are not | 10:33 |
| bauzas | sudipto: so, when calling the .save() method, it writes the content to DB | 10:33 |
| sudipto | bauzas, gotcha! | 10:34 |
| *** ociuhandu has joined #openstack-nova | 10:34 | |
| johnthetubaguy | bauzas: it will need to change both I suspect | 10:34 |
| bauzas | sudipto: there is also a _from_db_object() method for hydrating the object from an SQLA model | 10:34 |
| sudipto | bauzas, ok | 10:34 |
| bauzas | johnthetubaguy: yes, my point was just about the compat layer | 10:34 |
| bauzas | johnthetubaguy: the compat layer is in the object, and the model and migrations are necessary too | 10:34 |
| *** atuvenie has joined #openstack-nova | 10:35 | |
| sudipto | bauzas, so it's not an easy job :'( | 10:35 |
| bauzas | now the real 1M USD question is : are all the writes to the instances table being objectified ? | 10:35 |
| bauzas | sudipto: well, it requires some ramp-up I agree | 10:36 |
| bauzas | sudipto: but that's the price to pay for allowing Nova to live upgrade | 10:36 |
| sudipto | bauzas, hmm yeah! But it should be a good exercise I suppose. | 10:36 |
| bauzas | sudipto: agreed | 10:36 |
| sudipto | bauzas, any other spec has done a similar thing that you are aware of? | 10:37 |
| bauzas | sudipto: oh yes, plenty of | 10:37 |
| bauzas | sudipto: I would just recommend you the one I wrote :) | 10:37 |
| sudipto | bauzas, that'd be awesome :) Please give me :) | 10:37 |
| bauzas | sudipto: http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/detach-service-from-computenode.html | 10:38 |
| sudipto | bauzas, atleast the ramp up would be taken care of via this I would hope... | 10:38 |
| sudipto | bauzas, thanks! | 10:38 |
| bauzas | sudipto: well the detach-service-from-computenode patch series is a beast | 10:39 |
| bauzas | sudipto: an ugly monster who can make nightmares to children | 10:39 |
| sudipto | bauzas, lol | 10:39 |
| bauzas | sudipto: so you have to care about the level of abstraction you need to understand | 10:39 |
| sudipto | bauzas, I will take my time and get back to you with questions... | 10:40 |
| bauzas | sudipto: I would rather recommend you to understand how writes are coming in to DB using the NovaObjects | 10:40 |
| bauzas | sudipto: sure | 10:40 |
| sudipto | bauzas, Sure... | 10:40 |
| bauzas | sudipto: and how the NovaObjects are mediators to DB | 10:40 |
| sudipto | bauzas, Ok... | 10:40 |
| *** mwagner_lap has quit IRC | 10:41 | |
| *** mmedvede has quit IRC | 10:45 | |
| *** dulek has joined #openstack-nova | 10:47 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs: New API for get service info from id https://review.openstack.org/172412 | 10:49 |
| *** mmedvede has joined #openstack-nova | 10:53 | |
| *** bfic has joined #openstack-nova | 10:56 | |
| *** bfic has quit IRC | 10:57 | |
| *** bfic has joined #openstack-nova | 10:58 | |
| johnthetubaguy | jogo: would be cool if you could take a quick look at this for me please: https://review.openstack.org/#/c/141108/5 | 10:59 |
| *** mwagner_lap has joined #openstack-nova | 10:59 | |
| *** wznoinsk has joined #openstack-nova | 10:59 | |
| *** jwcroppe has joined #openstack-nova | 11:00 | |
| *** jichen has quit IRC | 11:00 | |
| *** yassine_ has joined #openstack-nova | 11:01 | |
| *** dulek_ has joined #openstack-nova | 11:02 | |
| *** dulek has quit IRC | 11:05 | |
| *** atuvenie has quit IRC | 11:07 | |
| *** jwcroppe has quit IRC | 11:08 | |
| *** atuvenie has joined #openstack-nova | 11:08 | |
| *** leseb has quit IRC | 11:09 | |
| kashyap | Has anyone else noticed this CI job failing w/ SSH timeouts? - http://logs.openstack.org/61/178061/1/check/check-grenade-dsvm/92458a9/console.html | 11:13 |
| *** ociuhandu has quit IRC | 11:13 | |
| *** Hosam has joined #openstack-nova | 11:14 | |
| kashyap | Hmm, seems like this is the offending test - TestVolumeBootPattern.test_volume_boot_pattern, | 11:14 |
| kashyap | where it's failing to invoke: '/bin/bash tools/pretty_tox.sh (?!.*\\[.*\\bslow\\b.*\\])((smoke)|(^tempest\\.scenario)) --concurrency=4' | 11:14 |
| * kashyap looks for ER signatures | 11:14 | |
| *** dims has quit IRC | 11:18 | |
| *** sudipto has quit IRC | 11:20 | |
| *** leseb has joined #openstack-nova | 11:20 | |
| *** tojuvone has quit IRC | 11:21 | |
| *** igordcard has joined #openstack-nova | 11:23 | |
| *** overlayer has joined #openstack-nova | 11:23 | |
| *** Hosam has quit IRC | 11:23 | |
| kashyap | Just about 11 hits in the last 48h though, logstash says. | 11:25 |
| *** ajayaa has quit IRC | 11:30 | |
| *** dulek_ has quit IRC | 11:33 | |
| *** coolsvap is now known as coolsvap|afk | 11:33 | |
| openstackgerrit | Mh Raies proposed openstack/nova: Enable tenant/user specific instance filtering https://review.openstack.org/139025 | 11:33 |
| *** overlayer has quit IRC | 11:34 | |
| *** igordcard has quit IRC | 11:34 | |
| *** aix has joined #openstack-nova | 11:35 | |
| *** sudipto has joined #openstack-nova | 11:35 | |
| *** igordcard has joined #openstack-nova | 11:37 | |
| jaypipes | sudipto: what did I suggest? :) | 11:38 |
| *** dulek has joined #openstack-nova | 11:39 | |
| sudipto | jaypipes, Sorry my bad - I was just making sure we don't need this column anymore :) | 11:39 |
| *** arif-ali has joined #openstack-nova | 11:40 | |
| *** bfic has quit IRC | 11:40 | |
| *** igordcard has quit IRC | 11:40 | |
| *** lucasagomes is now known as lucas-hungry | 11:40 | |
| *** ajayaa has joined #openstack-nova | 11:42 | |
| sudipto | jaypipes, and you too would agree with a spec to drop it i suppose? | 11:43 |
| openstackgerrit | John Garbutt proposed openstack/nova: devref: add information to clarify nova scope https://review.openstack.org/178623 | 11:43 |
| bauzas | jaypipes: it was re: http://lists.openstack.org/pipermail/openstack-dev/2015-March/059603.html | 11:45 |
| *** mmedvede has quit IRC | 11:46 | |
| bauzas | johnthetubaguy: oh oh thanks for https://review.openstack.org/#/c/177374/3/doc/source/devref/architecture.rst,cm | 11:46 |
| johnthetubaguy | bauzas: trying to go through and update that, and add bit missing bits that we want to talk about at the summit | 11:47 |
| bauzas | johnthetubaguy: since a long time, I was thinking about updating it :) | 11:47 |
| bauzas | johnthetubaguy: actually since 2 yrs I work with Nova :) | 11:47 |
| bauzas | well, 1.5yo | 11:48 |
| jaypipes | sudipto: gotcha. yeah, I don't really think it's worth having two columns... | 11:49 |
| jaypipes | is that bauzas' opinion as well? | 11:50 |
| bauzas | jaypipes: yep, I think scheduled_at is no longer needed | 11:50 |
| *** baoli has joined #openstack-nova | 11:50 | |
| bauzas | jaypipes: just because when migrating, the scheduler can't be checked | 11:50 |
| jaypipes | right. | 11:50 |
| bauzas | jaypipes: and also because the scheduler no longer proxies the compute boot | 11:51 |
| jaypipes | bauzas: right. it still grabs the destrination host, but the conductor does all the rest, along with the target and source compute nodes. | 11:51 |
| *** haomaiwa_ has quit IRC | 11:52 | |
| bauzas | jaypipes: yeah, as the conductor is also actually an RPC cast... | 11:52 |
| bauzas | jaypipes: so if we would like to know when the conductor is running for the instance, it should be conducted_at | 11:53 |
| *** kiran-r has quit IRC | 11:53 | |
| *** baoli has quit IRC | 11:53 | |
| bauzas | jaypipes: because then scheduler check is an RPC call so synced | 11:53 |
| *** zul has joined #openstack-nova | 11:53 | |
| *** ferest has joined #openstack-nova | 11:53 | |
| bauzas | jaypipes: and last point, I don't see why all of that is needed, just because we now have RPC notifications | 11:54 |
| *** baoli has joined #openstack-nova | 11:54 | |
| jaypipes | bauzas: right. this is one reason why moving to a task-record persistence system is appealing to me. having these timestamp fields on the instance record doesn't fit in many cases. | 11:54 |
| bauzas | jaypipes: so I'm like -1 on querying DB for knowing when an instance is running, and preferring more using the oslo.messaging notifications | 11:54 |
| *** igordcard has joined #openstack-nova | 11:54 | |
| jaypipes | bauzas: would be better to have a tasks table that recorded the start and end time of each task. | 11:54 |
| *** mmedvede has joined #openstack-nova | 11:54 | |
| bauzas | using Ceilo, Stacktach or whatever else | 11:54 |
| sudipto | jaypipes, bauzas the task table sounds interesting... | 11:55 |
| bauzas | jaypipes: but in Nova, we don't have a right tasks management cycle | 11:55 |
| jaypipes | bauzas: well, yes, I know :) | 11:55 |
| openstackgerrit | John Garbutt proposed openstack/nova: devref: add a description of flavors https://review.openstack.org/178628 | 11:55 |
| bauzas | I mean, we don't have a -- man, I don't remember the name | 11:55 |
| jaypipes | bauzas: and I agree with you that a notification that the VM was started (and its timestamp) is the most accurate way of determining when a VM was actually running. | 11:55 |
| jaypipes | sudipto: so, have we sufficiently confused you yet? ;) | 11:56 |
| *** dims has joined #openstack-nova | 11:56 | |
| sudipto | jaypipes, nope nope, i followed through :) | 11:56 |
| jaypipes | :) | 11:56 |
| jaypipes | cool | 11:56 |
| sudipto | jaypipes, I was actually coming from running an algorithm to figure out the oldest VM on a given host...and i think subscribing to the bus also is a good solution. | 11:57 |
| bauzas | sudipto: I think so too, just because you don't need to hack DB | 11:58 |
| jaypipes | sudipto: right (though of course that won't give you historical data... only from the time you start listening ;) | 11:58 |
| bauzas | sudipto: just because the notification events are self-explanatory | 11:58 |
| bauzas | ah ah, state diagram ! | 11:58 |
| bauzas | man, it's just 10 mins I'm thinking about that without remembering the name... | 11:59 |
| bauzas | or state machine, even | 11:59 |
| bauzas | jaypipes: ^ I remember alaski's session in ATL about providing an API tasks module | 12:00 |
| sudipto | jaypipes, bauzas this is where i am a bit lost... | 12:00 |
| bauzas | sounds like it was just stale ? | 12:00 |
| bauzas | sudipto: about what ? | 12:00 |
| sudipto | bauzas, the comment for jaypipes about the subscription time and the state diagram stuffd | 12:00 |
| bauzas | sudipto: we manage states of the VMs using a single module as an helper | 12:00 |
| jaypipes | alaski is indeed the man. | 12:01 |
| bauzas | sudipto: so you know which states are referring to 'running' | 12:01 |
| bauzas | sudipto: but we don't really manage the transitions | 12:01 |
| jaypipes | that's right. | 12:01 |
| bauzas | sudipto: it's just each time a new event is fired that we just update the state by going to a state that we know | 12:01 |
| openstackgerrit | John Garbutt proposed openstack/nova: devref: discuss current state of error handling https://review.openstack.org/178635 | 12:01 |
| *** bfic has joined #openstack-nova | 12:01 | |
| bauzas | sudipto: but we're not telling the direction, rather the target, which is not good for many reasons | 12:02 |
| *** moshele has quit IRC | 12:02 | |
| *** dulek has quit IRC | 12:02 | |
| sudipto | bauzas, okk | 12:02 |
| bauzas | sudipto: so provided you would like to monitor the notifications, you would have to match with the semantics of what means "running" for Nova | 12:02 |
| sudipto | bauzas, ok.. | 12:03 |
| bauzas | sudipto: all of that is not provided as an external API information that you can synchronize | 12:03 |
| bauzas | or gather or whatever | 12:03 |
| sudipto | bauzas, got it... | 12:03 |
| *** raildo has joined #openstack-nova | 12:03 | |
| sudipto | bauzas, thanks! I will get back to you for doubts! Making a drive back home now... | 12:03 |
| bauzas | sudipto: so, if someone is just creating a new state (like we did for the shelve actions), you have to figure out if that's running or not | 12:04 |
| sudipto | bauzas, ok.. | 12:04 |
| bauzas | sudipto: one last point | 12:04 |
| bauzas | sudipto: for some reason, the documentation is up-to-date about that, which is excellent | 12:04 |
| *** dprince has joined #openstack-nova | 12:04 | |
| bauzas | sudipto: http://docs.openstack.org/developer/nova/devref/vmstates.html | 12:04 |
| sudipto | bauzas, great. I should go through this... | 12:05 |
| bauzas | above is the state transition diagram | 12:05 |
| sudipto | bauzas, and bug you back in sometime... | 12:05 |
| *** igordcard has quit IRC | 12:05 | |
| bauzas | sudipto: eh eh | 12:05 |
| *** tojuvone has joined #openstack-nova | 12:05 | |
| sudipto | bauzas, :D | 12:05 |
| *** bauzas is now known as bauzas_notme | 12:05 | |
| sudipto | lol | 12:05 |
| sudipto | thanks for your time! | 12:06 |
| bauzas_notme | np | 12:06 |
| bauzas_notme | argh, faced | 12:06 |
| *** moshele has joined #openstack-nova | 12:06 | |
| sudipto | lol | 12:06 |
| *** bauzas_notme is now known as bauzas | 12:06 | |
| *** igordcard has joined #openstack-nova | 12:06 | |
| *** openstackgerrit has quit IRC | 12:07 | |
| *** otter768 has joined #openstack-nova | 12:07 | |
| *** openstackgerrit has joined #openstack-nova | 12:07 | |
| *** thomasem has joined #openstack-nova | 12:08 | |
| *** Marga_ has joined #openstack-nova | 12:10 | |
| *** sudipto has quit IRC | 12:10 | |
| *** Marga_ has quit IRC | 12:10 | |
| *** Marga_ has joined #openstack-nova | 12:11 | |
| *** otter768 has quit IRC | 12:12 | |
| *** xylan_kong has joined #openstack-nova | 12:12 | |
| xylan_kong | hey, guys, would anyone please take a look at my patch https://review.openstack.org/163842, to fix the problem of wrong az property of instance. Sylvain and I have different opinions about the patch, so want to hear more suggestions. really appreciate your comments. | 12:15 |
| *** atuvenie has quit IRC | 12:15 | |
| jaypipes | _cerberus_: heya, https://review.openstack.org/#/c/178190/ patch series could use your re-review. thx in advance. | 12:18 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: define the ImageMeta & ImageMetaProps objects https://review.openstack.org/76234 | 12:20 |
| *** rfolco has joined #openstack-nova | 12:22 | |
| openstackgerrit | Takenori Yoshimatsu proposed openstack/nova: Avoid AttributeError at instance.info_cache.delete https://review.openstack.org/167905 | 12:23 |
| *** igordcard has quit IRC | 12:25 | |
| *** igordcard has joined #openstack-nova | 12:25 | |
| *** bfic has quit IRC | 12:26 | |
| *** vladikr has joined #openstack-nova | 12:26 | |
| tdurakov | johnthetubaguy: Hi, John!Could you look at blueptint: https://blueprints.launchpad.net/nova/+spec/nova-api-hypervsor-cpu-info ? | 12:27 |
| *** atuvenie has joined #openstack-nova | 12:31 | |
| *** doron_afk is now known as doron | 12:31 | |
| *** dave-mccowan has joined #openstack-nova | 12:31 | |
| *** joefides has quit IRC | 12:32 | |
| *** jwcroppe has joined #openstack-nova | 12:35 | |
| *** claudiub has joined #openstack-nova | 12:36 | |
| *** EmilienM is now known as EmilienM|afk | 12:41 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed unused variables, methods and classes https://review.openstack.org/164666 | 12:41 |
| *** ajayaa has quit IRC | 12:41 | |
| openstackgerrit | garyk proposed openstack/nova: Scheduler: enhance debug messages for multitenancy aggregates https://review.openstack.org/178652 | 12:42 |
| *** lifeless has quit IRC | 12:43 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed twice declared variables https://review.openstack.org/178653 | 12:43 |
| garyk | xylan_kong: i think that your proposal is valid | 12:43 |
| garyk | xylan_kong: i think that in cases like this there are a number of options: i. wait for cores to get involved in the discussion (this may take a very very … very long time) II. write a mail to the list and let the discussion take place on the list iii. try and collaborate with him to come to a general concensus | 12:45 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed variables used not in the scope that they are declared https://review.openstack.org/178654 | 12:45 |
| *** lucas-hungry is now known as lucasagomes | 12:47 | |
| *** Jeffrey4l has quit IRC | 12:48 | |
| *** tojuvone has quit IRC | 12:49 | |
| *** neelashah has joined #openstack-nova | 12:49 | |
| *** mpaolino has joined #openstack-nova | 12:51 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Set power state to None when evacuate fails due to recreate not supported https://review.openstack.org/173150 | 12:52 |
| *** VW_ has joined #openstack-nova | 12:52 | |
| *** moshele has quit IRC | 12:52 | |
| *** lpetrut has joined #openstack-nova | 12:52 | |
| *** doron has quit IRC | 12:53 | |
| *** moshele has joined #openstack-nova | 12:55 | |
| *** jungleboyj has joined #openstack-nova | 12:55 | |
| *** Hosam has joined #openstack-nova | 12:55 | |
| jaypipes | johnthetubaguy: https://review.openstack.org/#/c/177112/ could use fast-tracking, if you wouldn't mind... it's been approved the last 3 cycles. just the API microversion isn't merged. snikitin has updated the spec to align with the API working group guidance on tagging. | 12:55 |
| openstackgerrit | Joe Cropper proposed openstack/nova-specs: Proposal for Flexible Resize Scheduling https://review.openstack.org/175115 | 12:57 |
| *** doron has joined #openstack-nova | 12:58 | |
| *** VW_ has quit IRC | 12:58 | |
| *** bfic has joined #openstack-nova | 12:59 | |
| *** Jeffrey4l has joined #openstack-nova | 12:59 | |
| *** sandywalsh has joined #openstack-nova | 13:00 | |
| *** ir2ivps3_ has quit IRC | 13:01 | |
| *** Alexandra_ has joined #openstack-nova | 13:02 | |
| openstackgerrit | Ph. Marek proposed openstack/nova-specs: Connecting Nova to DRBD storage nodes directly. https://review.openstack.org/134153 | 13:02 |
| johnthetubaguy | jaypipes: its changed quite a lot since the previous version, so technically needs another +2, but it looks good to me now | 13:02 |
| *** dulek has joined #openstack-nova | 13:03 | |
| jaypipes | johnthetubaguy: thx! | 13:03 |
| *** annegentle has joined #openstack-nova | 13:03 | |
| johnthetubaguy | tdurakov: I think your suggest API change makes a lot of sense, but you will need to submit a spec for an API change I am afraid | 13:05 |
| johnthetubaguy | tdurakov: we want a spec to make sure we can get API folks to check all changes, because we generally have to support any API change for ever, so we want to try and get it correct first time | 13:06 |
| johnthetubaguy | tdurakov: I hope that helps | 13:06 |
| tdurakov | johnthetubaguy, yep, thanks! | 13:06 |
| tdurakov | so, start with the spec:) | 13:06 |
| *** doron is now known as doron_afk | 13:07 | |
| *** ZZelle has quit IRC | 13:08 | |
| *** ZZelle has joined #openstack-nova | 13:09 | |
| kashyap | Would anyone else like to take a look this easy set of cleanups, it already has a +2 and Jenkins seems to behave just fine? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:cleanups_in_create_cow_image,n,z | 13:09 |
| garyk | any chance that we can geta +2 on https://review.openstack.org/#/c/174480/ - it is blocking all features, bug fixes with DB migrations … | 13:09 |
| *** joefides has joined #openstack-nova | 13:12 | |
| *** ociuhandu has joined #openstack-nova | 13:12 | |
| *** Madkiss has quit IRC | 13:13 | |
| garyk | kashyap: the queue is pretty long for review requests … | 13:14 |
| *** burt has joined #openstack-nova | 13:15 | |
| kashyap | garyk: Yep, I think the one you pointed out above sounds a bit of high prio | 13:15 |
| kashyap | Mine can wait. | 13:15 |
| *** atuvenie has quit IRC | 13:16 | |
| garyk | kashyap: i think that they are all equally important. i have reviewed yours and they look good. nice cleanup. | 13:18 |
| kashyap | Thanks for taking a look. | 13:19 |
| *** dulek has quit IRC | 13:21 | |
| *** dulek has joined #openstack-nova | 13:21 | |
| johnthetubaguy | dansmith: do we know what turbo hipster is waiting for with this one? https://review.openstack.org/#/c/174480 | 13:22 |
| *** atuvenie has joined #openstack-nova | 13:26 | |
| sdague | so I thought that mikal and jhesketh were going to fix the data sets for that | 13:26 |
| sdague | I'm going to see if I can trigger another db ci run on it | 13:27 |
| jhesketh | sdague: waiting on seeing if https://review.openstack.org/#/c/176574/ goes in | 13:28 |
| jhesketh | once that goes in it should pass | 13:28 |
| jhesketh | sdague: re-triggering won't help, I have it not voting on failures from the gerrit stream breaking up earlier | 13:28 |
| sdague | jhesketh: well... that had a -2 from jenkins | 13:28 |
| jhesketh | I need to turn it back on, but I've been monitoring the failures myself | 13:29 |
| sdague | I just rechecked | 13:29 |
| jhesketh | sdague: right, so need to figure out if that was legit or not | 13:29 |
| jhesketh | (haven't looked at the logs yet) | 13:29 |
| sdague | the fail runs are 18s long | 13:29 |
| sdague | which means there is no chance they are legit | 13:29 |
| jhesketh | ah, well noted | 13:29 |
| sdague | that's like super early gerrit setup | 13:29 |
| jhesketh | okay, once that goes in I can get th to pass on the wedge migrations thingy | 13:30 |
| jhesketh | but that'll probably have to wait until tomorrow sorry | 13:30 |
| johnthetubaguy | ah, thanks folks for the context, and keeping it going | 13:30 |
| *** matrohon has joined #openstack-nova | 13:30 | |
| *** artom has joined #openstack-nova | 13:32 | |
| sdague | ok, well, in future when we have a critical patch stack like this, it would be nice to be a bit more aggressive staying on top of them. Those fail results came back 14 hrs ago. | 13:32 |
| *** ir2ivps3_ has joined #openstack-nova | 13:33 | |
| *** ajayaa has joined #openstack-nova | 13:34 | |
| *** jungleboyj has quit IRC | 13:34 | |
| *** Hosam has quit IRC | 13:35 | |
| *** EmilienM|afk is now known as EmilienM | 13:37 | |
| *** VW_ has joined #openstack-nova | 13:38 | |
| *** lifeless has joined #openstack-nova | 13:38 | |
| *** josecastroleon has joined #openstack-nova | 13:39 | |
| *** VW_ has quit IRC | 13:39 | |
| *** VW_ has joined #openstack-nova | 13:40 | |
| *** popw has quit IRC | 13:41 | |
| jhesketh | sdague: sorry, I didn't realise it was critical/urgent | 13:42 |
| *** ferest has quit IRC | 13:44 | |
| *** thangp has joined #openstack-nova | 13:45 | |
| *** Jeffrey4l has quit IRC | 13:46 | |
| *** Alexandra_ has quit IRC | 13:46 | |
| dansmith | johnthetubaguy: yeah, not really blocked on t-h, but I don't think there's a rush to land it so waiting until we have a good ack makes sense to me | 13:46 |
| mriedem_away | https://review.openstack.org/#/c/176574/ is back in the queue | 13:47 |
| *** atuvenie has quit IRC | 13:48 | |
| sdague | mriedem_away: right, I just rechecked :) | 13:49 |
| *** mriedem_away has quit IRC | 13:51 | |
| johnthetubaguy | alex_xu: have you reviewed this spec, it seems similar to some you are suggesting: https://review.openstack.org/#/c/168982/ | 13:52 |
| *** mtreinish has joined #openstack-nova | 13:54 | |
| *** iamjarvo has joined #openstack-nova | 13:55 | |
| *** iamjarvo has quit IRC | 13:56 | |
| *** iamjarvo has joined #openstack-nova | 13:57 | |
| *** iamjarvo has quit IRC | 13:57 | |
| *** ujjain- is now known as ujjain | 13:57 | |
| *** iamjarvo has joined #openstack-nova | 13:57 | |
| *** iamjarvo has quit IRC | 13:58 | |
| *** iamjarvo has joined #openstack-nova | 13:58 | |
| *** iamjarvo has quit IRC | 13:58 | |
| *** iamjarvo has joined #openstack-nova | 13:59 | |
| *** Jeffrey4l has joined #openstack-nova | 13:59 | |
| *** iamjarvo has quit IRC | 13:59 | |
| *** cfriesen has joined #openstack-nova | 13:59 | |
| *** iamjarvo has joined #openstack-nova | 14:00 | |
| *** jecarey has joined #openstack-nova | 14:01 | |
| *** zz_jgrimm is now known as jgrimm | 14:01 | |
| *** jichen has joined #openstack-nova | 14:02 | |
| *** mriedem has joined #openstack-nova | 14:03 | |
| *** marun has joined #openstack-nova | 14:04 | |
| *** rushiagr_away has quit IRC | 14:05 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs: New API for get service info from id https://review.openstack.org/172412 | 14:05 |
| *** alexpilotti has joined #openstack-nova | 14:05 | |
| *** mtreinish has quit IRC | 14:05 | |
| *** joefides_ has joined #openstack-nova | 14:06 | |
| alex_xu | johnthetubaguy: yes, I noticed after work out my spec. In the intial I just want to propose this https://review.openstack.org/#/c/170396, then I extended it to custom cpu model also. I hope can work with the author of https://review.openstack.org/#/c/168982 . I think the custom cpu feature and cpu model both depend on how we repor cpu model info | 14:06 |
| -openstackstatus- NOTICE: gerrit has been restarted to clear a stuck events queue. any change events between 13:29-14:05 utc should be rechecked or have their approval votes reapplied to trigger jobs | 14:06 | |
| *** bfic has quit IRC | 14:06 | |
| *** otter768 has joined #openstack-nova | 14:08 | |
| *** joefides has quit IRC | 14:08 | |
| *** cbits has joined #openstack-nova | 14:08 | |
| *** exploreshaifali has joined #openstack-nova | 14:08 | |
| *** cbits has left #openstack-nova | 14:09 | |
| *** haomaiwang has joined #openstack-nova | 14:10 | |
| *** pkoniszewski has quit IRC | 14:11 | |
| *** apuimedo has quit IRC | 14:12 | |
| *** otter768 has quit IRC | 14:12 | |
| *** annegentle has quit IRC | 14:12 | |
| johnthetubaguy | alex_xu: the new version of their spec seems to cover that now, if you could review their latest spec and add anything you think is missing, that would be awesome | 14:13 |
| johnthetubaguy | alex_xu: as a heads up, I am really worried about the "bad API" extra-specs and image properties are becoming, so I hope we can get this all validated soon-ish | 14:13 |
| *** yamahata has joined #openstack-nova | 14:14 | |
| alex_xu | johnthetubaguy: looking the spec now | 14:15 |
| *** lpetrut has quit IRC | 14:15 | |
| johnthetubaguy | alex_xu: awesome, no rush, but that would be great | 14:15 |
| alex_xu | johnthetubaguy: yea, that's worth to think for API | 14:15 |
| *** rushiagr_away has joined #openstack-nova | 14:16 | |
| *** annegentle has joined #openstack-nova | 14:17 | |
| dansmith | mriedem: before I respond, aren't restore-able instances in SOFT_DELETED state and not actually deleted=1 ? | 14:17 |
| *** zhenguo has quit IRC | 14:17 | |
| mriedem | dansmith: hrm, will have to look | 14:18 |
| mriedem | btw, we set the deleted value to the id of the row that we're deleting? | 14:18 |
| mriedem | never dug into why deleted wasn't a boolean | 14:19 |
| *** exploreshaifali has quit IRC | 14:20 | |
| dansmith | mriedem: yes | 14:20 |
| dansmith | mriedem: it's something related to the constraints and indexing | 14:20 |
| dansmith | mriedem: we can surely add a --also-deleted flag that will let people migrate them if they want, or a --uuid= flag | 14:21 |
| johnthetubaguy | dansmith: was it the unique constraint, so two deleted things can actually have all the same values, or something like that? | 14:21 |
| dansmith | mriedem: but blocking their upgrade because of deleted instances is going to be hard to justify | 14:21 |
| dansmith | johnthetubaguy: yeah, probably | 14:21 |
| mriedem | dansmith: i'm not -1 | 14:21 |
| mriedem | just asking questions | 14:21 |
| dansmith | mriedem: yep, and they're good | 14:21 |
| mriedem | i know some people hate asking questions in reviews :) | 14:21 |
| dansmith | mriedem: hah | 14:22 |
| bauzas | mriedem: -1 for your sentence | 14:22 |
| mriedem | *hate being asked questions | 14:22 |
| dansmith | I got it :) | 14:22 |
| mriedem | that was for bauzas | 14:23 |
| bauzas | mriedem: eh, seriously, kidding :) | 14:23 |
| bauzas | but we can just open the can of worms | 14:23 |
| openstackgerrit | jichenjc proposed openstack/nova-specs: New API for get service info from id https://review.openstack.org/172412 | 14:23 |
| *** Murali has quit IRC | 14:24 | |
| *** nkrinner has quit IRC | 14:24 | |
| PaulMurray | johnthetubaguy, jaypipes I have a question about api versions - one of my outstanding patches for RT objects corrects api samples for pci | 14:25 |
| PaulMurray | johnthetubaguy, jaypipes does that need an api version bump? | 14:25 |
| PaulMurray | note the samples were wrong - I haven't changed the api behavior | 14:25 |
| bauzas | PaulMurray: I tend to say no, that's examples | 14:26 |
| *** asrangne has joined #openstack-nova | 14:26 | |
| bauzas | PaulMurray: just because it doesn't need a dialog between the client and the API | 14:26 |
| PaulMurray | bauzas, johnthetubaguy ok - but I assume it would need a docimpact though - I think samples are included in docs - is that right? | 14:27 |
| johnthetubaguy | PaulMurray: if you don't change what the API is doing, seems like you don't need to bump the version, don't know about the docs, I would have to check | 14:27 |
| jaypipes | PaulMurray: if the *actual* API is correct, just the api samples tests are incorrect, then no. if the actual API changes, then yes, it would need a spec, a microversion, and approval. | 14:27 |
| jaypipes | or, what johnthetubaguy said, simply :) | 14:28 |
| *** jungleboyj has joined #openstack-nova | 14:28 | |
| PaulMurray | :) | 14:28 |
| *** aswadr has quit IRC | 14:28 | |
| dansmith | bauzas: api_samples are not just examples :) | 14:28 |
| openstackgerrit | Tomi Juvonen proposed openstack/nova-specs: New nova API call to mark nova-compute down https://review.openstack.org/169836 | 14:28 |
| openstackgerrit | Hans Lindgren proposed openstack/nova: Cleanup conductor unused methods https://review.openstack.org/168856 | 14:28 |
| openstackgerrit | Marian Horban proposed openstack/nova: Disassociating of floating IPs corrected https://review.openstack.org/149358 | 14:29 |
| PaulMurray | dansmith, there is a test that passes in something like the sample and checks it - it only works because the dict data structure is not checked - the incorrect fields just pass through | 14:29 |
| openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 14:29 |
| PaulMurray | dansmith, when I put th ecompute node object in it checks the structure and blows up because its incorrect | 14:29 |
| dansmith | PaulMurray: right, so like jaypipes said, you need a bump if the api has to change, not if the tests were broken and you fix them | 14:30 |
| bauzas | dansmith: orly ? in which situation are they more than just docs ? | 14:30 |
| bauzas | dansmith: except tests of course | 14:30 |
| dansmith | bauzas: they're validating input and output from the api | 14:30 |
| bauzas | oh man... | 14:30 |
| dansmith | bauzas: they generate doc samples as a side effect :) | 14:30 |
| bauzas | dansmith: you mean v2 then ? | 14:30 |
| dansmith | bauzas: both | 14:31 |
| bauzas | dansmith: because I thought input validation was done other way for v2.1 | 14:31 |
| dansmith | bauzas: we have them for v2 and v2.1 to make sure they're the same, but we had v3 as well | 14:31 |
| bauzas | ok, stop chatting, bauzas and RTFC | 14:31 |
| dansmith | bauzas: right, but these are actually testing it | 14:31 |
| dansmith | they don't really test anything other than that the output for a command given a certain input matches what we expect | 14:32 |
| dansmith | but they do catch some very subtle things sometimes | 14:32 |
| bauzas | I see | 14:32 |
| dansmith | and in general, | 14:32 |
| bauzas | I was previously working using Pecan/WSME, so I'm missing how input validation is done now in Nova | 14:32 |
| dansmith | any time someone *changes* one of the api samples without adding a version or extension, that's a pointer to them probably changing the api in a bad way :) | 14:32 |
| bauzas | dansmith: agreed | 14:33 |
| bauzas | good to know | 14:33 |
| mriedem | bauzas: jsonschema validation is used with the v2.1 stuff | 14:33 |
| bauzas | PaulMurray: so, FWIW, I think it needs more than just a simple answer | 14:33 |
| * bauzas RTFC | 14:33 | |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/v3 | 14:33 |
| mriedem | bauzas: e.g. http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/migrate_server.py#n64 | 14:34 |
| mriedem | live migration calls into the schema validation for that | 14:34 |
| bauzas | mriedem: yeah, that's what I was reading for the validators | 14:34 |
| mriedem | which is this http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/v3/migrate_server.py#n23 | 14:35 |
| bauzas | mriedem: gotcha | 14:35 |
| bauzas | mriedem: just reading now for v2 | 14:36 |
| bauzas | ok, that's on purpose | 14:37 |
| PaulMurray | bauzas, I think in this case the api verson does not need to bump - just the test and sample needs correcting | 14:38 |
| *** lpetrut has joined #openstack-nova | 14:38 | |
| PaulMurray | bauzas, the reason is incorrect data is provided in the test and a passes through to be checked against incorrect sample output | 14:39 |
| *** wznoinsk has quit IRC | 14:39 | |
| PaulMurray | bauzas, if generated by the virt driver the inccroect data isn't given | 14:39 |
| *** Marga_ has quit IRC | 14:39 | |
| PaulMurray | bauzas, adding the compute node object makes the test fail because for the first time its checking that format of the data - and its incorrect | 14:39 |
| PaulMurray | so I fix the test and the sample and we're done I think | 14:40 |
| bauzas | PaulMurray: I remember your change | 14:40 |
| PaulMurray | but still not sure if I need a docimpact in the commit - I need to find the wiki page I think | 14:40 |
| bauzas | PaulMurray: yeah, by reading it, I was thinking it was not used as input validation, hence my "yes, it doesn't need a bump" | 14:40 |
| bauzas | PaulMurray: I should now ramp-up on the validation side before giving you a vote | 14:41 |
| *** dims has quit IRC | 14:42 | |
| *** bkopilov has quit IRC | 14:42 | |
| PaulMurray | bauzas, don't worry - I was updating the spec and realised I might need to mention this | 14:42 |
| *** dims has joined #openstack-nova | 14:42 | |
| *** mtreinish has joined #openstack-nova | 14:45 | |
| *** bkopilov has joined #openstack-nova | 14:45 | |
| *** mriedem has quit IRC | 14:46 | |
| *** jwcroppe has quit IRC | 14:47 | |
| *** jwcroppe has joined #openstack-nova | 14:47 | |
| bauzas | dansmith: so I looked at the code, and IIUC api_samples are used for functionally testing that both inputs and outputs match the requirements, right ? | 14:48 |
| *** alexpilotti has quit IRC | 14:49 | |
| dansmith | I dunno about "requirements" but they're used to make sure the input/output doesn't drift | 14:49 |
| dansmith | for example, | 14:49 |
| *** marcusvrn_ has joined #openstack-nova | 14:49 | |
| dansmith | we used to sometimes return an id of "1" and other times an id of 1, depending on where we got the data from | 14:49 |
| *** tonytan4ever has joined #openstack-nova | 14:49 | |
| *** mtreinish has quit IRC | 14:49 | |
| bauzas | dansmith: understood, I was more thinking of something decorating the API method saying "eh, this is the format I'm waiting" | 14:49 |
| dansmith | this (helps to) ensure that we don't have that happen | 14:50 |
| dansmith | right, we have that | 14:50 |
| dansmith | that's the schema | 14:50 |
| dansmith | these are the tests | 14:50 |
| bauzas | dansmith: that, I can find it for v2.1 | 14:50 |
| dansmith | right | 14:50 |
| bauzas | I mean the jsonvalidation | 14:50 |
| dansmith | right | 14:50 |
| bauzas | but that's not reading the api_samples IIUC | 14:50 |
| dansmith | right | 14:51 |
| *** ajayaa has quit IRC | 14:52 | |
| sdague | PaulMurray: if the tests were wrong, fixing the tests is fine | 14:52 |
| bauzas | ok, then that's what I was meaning to say when I said "api_samples are just used for docs and tests :)" | 14:52 |
| *** mriedem has joined #openstack-nova | 14:52 | |
| bauzas | but that's fine | 14:52 |
| dansmith | bauzas: you said just docs :) | 14:52 |
| *** jwcroppe has quit IRC | 14:52 | |
| *** claudiub has quit IRC | 14:52 | |
| dansmith | <bauzas> PaulMurray: I tend to say no, that's examples | 14:52 |
| bauzas | (16:30:11) bauzas: dansmith: orly ? in which situation are they more than just docs ? | 14:52 |
| bauzas | (16:30:19) bauzas: dansmith: except tests of course | 14:52 |
| bauzas | but I think I was unclear :) | 14:53 |
| dansmith | I didn't interpret that "except tests" to mean what you say now | 14:53 |
| dansmith | but that's fine, you get it now | 14:53 |
| bauzas | :D | 14:53 |
| *** pkoniszewski has joined #openstack-nova | 14:53 | |
| *** garyk has quit IRC | 14:53 | |
| bauzas | yeah, excellent opportunity to consider how Nova is doing input/output validation | 14:53 |
| bauzas | and trust me, that's far simplier than WSME types :( | 14:54 |
| *** tteggel_ has quit IRC | 14:54 | |
| *** garyk has joined #openstack-nova | 14:55 | |
| bauzas | dansmith: thanks for having helped me to sort out that stuff :) | 14:55 |
| *** emagana has joined #openstack-nova | 14:55 | |
| *** tteggel has joined #openstack-nova | 14:56 | |
| dansmith | np | 14:56 |
| *** unicell has joined #openstack-nova | 14:57 | |
| *** garyk has quit IRC | 14:57 | |
| *** unicell1 has quit IRC | 14:57 | |
| jaypipes | sdague: Hey, trying to get one of your Gerrit queries workin... | 14:57 |
| jaypipes | https://review.openstack.org/#/q/status:open+-Verified-1+Verified%252B1+-CodeReview%252B2+-CodeReview%252B1+-CodeReview-1+-CodeReview-2+(project:openstack/nova+OR+project:openstack/python-novaclient)+branch:master,n,z | 14:57 |
| *** sirushti has left #openstack-nova | 14:58 | |
| jaypipes | sdague: wondering why it doesn't filter out CodeReview properly. | 14:58 |
| sdague | so.... column references changed from gerrit 2.4 -> 2.8 | 14:58 |
| jaypipes | sdague: this is your "Lost Patches" query, BTW, from your blog post | 14:58 |
| jaypipes | sdague: gotcha... do I need the Label: thing? | 14:58 |
| sdague | instead you need things like label:CodeReview>=-1 | 14:59 |
| sdague | yeh | 14:59 |
| sdague | the gerrit dash creator has some examples | 14:59 |
| jaypipes | sdague: got it. ty sir :) | 14:59 |
| sdague | https://github.com/stackforge/gerrit-dash-creator/blob/master/dashboards/compute-program.dash | 14:59 |
| sdague | oh, it's Code-Review as well | 14:59 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Add documentation for nova-cells and nova-idmapshift commands https://review.openstack.org/166553 | 14:59 |
| *** patrickeast has joined #openstack-nova | 15:00 | |
| sdague | anyway, personally, when I'm building new queries like this I just make local dash files in gerrit dash creator and build the urls from tehre | 15:00 |
| sdague | I find it easier than hacking urls | 15:00 |
| jaypipes | gotcha. | 15:01 |
| jaypipes | thx again, sean | 15:01 |
| *** garyk has joined #openstack-nova | 15:01 | |
| sdague | no prob | 15:01 |
| *** packet has joined #openstack-nova | 15:02 | |
| *** nelsnelson has joined #openstack-nova | 15:02 | |
| *** browne has joined #openstack-nova | 15:02 | |
| *** dulek has quit IRC | 15:02 | |
| cfriesen | dansmith: re https://review.openstack.org/#/c/169836/ Russel is saying that you can't evacuate _from_ disabled (but "up") compute services. | 15:03 |
| openstackgerrit | Zhenguo Niu proposed openstack/nova: Ironic hypervisor should not be counted when in maintenance status https://review.openstack.org/177575 | 15:03 |
| cfriesen | s/Russel/Russell | 15:03 |
| *** ganso__ has joined #openstack-nova | 15:04 | |
| *** ijw has joined #openstack-nova | 15:05 | |
| *** ajayaa has joined #openstack-nova | 15:05 | |
| *** ijw has quit IRC | 15:06 | |
| *** ijw has joined #openstack-nova | 15:06 | |
| *** erkules_ is now known as erkules | 15:08 | |
| *** erkules has joined #openstack-nova | 15:08 | |
| dansmith | cfriesen: yeah | 15:08 |
| bauzas | cfriesen: we already discussed that IIRC | 15:09 |
| bauzas | cfriesen: I thought we were agreeing on seeing why the service_is_up() check was still needed, particularly if you have distributed computes | 15:10 |
| cfriesen | sorry...I scrolled up a bit but must have missed it. | 15:10 |
| bauzas | cfriesen: it was like a week before | 15:10 |
| openstackgerrit | Oleg Bondarev proposed openstack/nova: Log a warning if sec-groups and port id are provided on boot https://review.openstack.org/154068 | 15:10 |
| cfriesen | bauzas: ah, yes. thought you were referring to something recent. ?) | 15:11 |
| cfriesen | :) | 15:11 |
| cfriesen | can't type today | 15:11 |
| *** alexpilotti has joined #openstack-nova | 15:11 | |
| *** claudiub has joined #openstack-nova | 15:13 | |
| *** erkules has left #openstack-nova | 15:13 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 15:14 |
| *** Jeffrey4l has quit IRC | 15:14 | |
| *** dprince has quit IRC | 15:16 | |
| claudiub | jaypipes: hello | 15:16 |
| jaypipes | claudiub: ciao amico | 15:17 |
| jogo | johnthetubaguy: re: https://review.openstack.org/#/c/141108/5 | 15:18 |
| jogo | what do the neutron folks think? | 15:18 |
| claudiub | jaypipes: :)) bonjour monsieur. Do you have a little bit of time to take a look at 2 very small commits? One of them has a +2: https://review.openstack.org/#/c/170433/ and https://review.openstack.org/#/c/176817/ | 15:18 |
| *** tjones2 has joined #openstack-nova | 15:18 | |
| jaypipes | claudiub: certo! | 15:18 |
| claudiub | jaypipes: merci! :D | 15:19 |
| *** joefides_ has quit IRC | 15:19 | |
| jaypipes | claudiub: you are not Italian? :) | 15:19 |
| johnthetubaguy | jogo: we have a rep to ask now, I should activate them somehow | 15:19 |
| bauzas | je peux parler Francais moi aussi hein | 15:19 |
| *** joefides has joined #openstack-nova | 15:19 | |
| claudiub | jaypipes: actually, no. :D alexpilotti is. I'm just romanian. :P | 15:19 |
| jaypipes | ha! ok then! | 15:20 |
| *** tjones2 has left #openstack-nova | 15:20 | |
| claudiub | jaypipes: but you are partly corect, since we have the same roots. :D | 15:20 |
| jaypipes | claudiub: Credeam că ești italian | 15:20 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Fix disconnect_volume issue when find_multipath_device returns None https://review.openstack.org/159626 | 15:20 |
| claudiub | jaypipes: :O sunt surprins să văd romănă pe irc. :)) | 15:21 |
| jogo | johnthetubaguy: I see a few neutron folks are signed up on the spec itself | 15:21 |
| jogo | johnthetubaguy: so +Wed | 15:21 |
| jaypipes | claudiub: actually, we have a couple Romanians at Mirantis :) Including our CEO :) | 15:21 |
| *** heyongli has quit IRC | 15:21 | |
| claudiub | jaypipes: I've actually heard that, when we were at the paris summit. I was shocked when I heard. :)) | 15:22 |
| *** heyongli has joined #openstack-nova | 15:22 | |
| johnthetubaguy | jogo: its a spec thats probably best reviewed in code anyway really, if it looks like a dogs dinner, then we need to try something else | 15:22 |
| jaypipes | claudiub: actually, I should have known... if you were Italian, I think your name would be "Claudio", not "Claudiu", right? | 15:22 |
| claudiub | jaypipes: yeah, that's right. :) | 15:23 |
| *** Nikolay_St has quit IRC | 15:23 | |
| * jaypipes laments his lame and mono-syllabic names. | 15:23 | |
| *** eharney has quit IRC | 15:23 | |
| *** jwcroppe has joined #openstack-nova | 15:23 | |
| jogo | johnthetubaguy: yeah | 15:24 |
| claudiub | jaypipes: but you don't have to worry about people butchering your name, like I do. :D | 15:24 |
| jaypipes | heh, true enough :) | 15:24 |
| dansmith | jaypipes: at least you have an interesting last name | 15:25 |
| jaypipes | dansmith: :) | 15:25 |
| jaypipes | claudiub: k, https://review.openstack.org/#/c/176817/ approved. | 15:25 |
| claudiub | jaypipes: awesome, mulțumesc. :D | 15:26 |
| jaypipes | claudiub: nici o problema | 15:27 |
| *** moshele has quit IRC | 15:28 | |
| mriedem | jogo: i'm -1 on that spec | 15:28 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 15:28 |
| * dims needs google auto translation now on slack AND irc :) | 15:28 | |
| mriedem | jogo: johnthetubaguy: -1 on https://review.openstack.org/#/c/141108/ but it's already merged | 15:29 |
| mriedem | was just leaving comments | 15:29 |
| johnthetubaguy | mriedem: sorry, I totally missed the nonsense in the testing section | 15:30 |
| * mriedem storms out | 15:31 | |
| johnthetubaguy | mriedem: my take is, "I want to see the code" before we can tell if this works properly, so I wasn't really keeping the bar that high | 15:31 |
| mriedem | yeah we'll see i guess | 15:32 |
| mriedem | we could have had wip code up for 6 months now | 15:32 |
| *** Jeffrey4l has joined #openstack-nova | 15:32 | |
| *** sdake has joined #openstack-nova | 15:34 | |
| johnthetubaguy | mriedem: yes, that would have made it easier, honestly, I wonder about just deleting the spec and calling it a spec-less blueprint | 15:35 |
| mriedem | meh | 15:36 |
| *** iamjarvo has quit IRC | 15:36 | |
| mriedem | the spec is pretty nebulous, it has some goals but doesn't have details | 15:36 |
| mriedem | so yeah, the spec is kind of pointless | 15:36 |
| *** VW__ has joined #openstack-nova | 15:36 | |
| mriedem | code talks | 15:36 |
| mriedem | plus i'm just grumpy | 15:36 |
| *** redbeard has quit IRC | 15:36 | |
| *** moshele has joined #openstack-nova | 15:37 | |
| *** tjones2 has joined #openstack-nova | 15:37 | |
| *** VW_ has quit IRC | 15:37 | |
| *** mtanino has joined #openstack-nova | 15:38 | |
| johnthetubaguy | mriedem: yeah, I kinda read too many specs, it just doesn't seem as bad as the others, I appreciate the kick :) | 15:38 |
| jaypipes | mriedem: https://review.openstack.org/#/c/170433/ looks to be familiar to you... | 15:39 |
| *** kiran-r has joined #openstack-nova | 15:39 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: define the ImageMeta & ImageMetaProps objects https://review.openstack.org/76234 | 15:39 |
| mriedem | jaypipes: yeah | 15:39 |
| *** VW__ has quit IRC | 15:41 | |
| bauzas | alaski: morning, I guess you would be interested in https://review.openstack.org/#/c/178563/ | 15:41 |
| bauzas | jaypipes: ^ too | 15:41 |
| *** dulek has joined #openstack-nova | 15:41 | |
| *** ildikov has quit IRC | 15:41 | |
| *** atuvenie has joined #openstack-nova | 15:42 | |
| jaypipes | bauzas: hells yeah. +1 | 15:42 |
| bauzas | jaypipes: there is also https://review.openstack.org/#/c/176083/ that you could care about | 15:43 |
| alaski | bauzas: that technically adds a dependency to the spec. but +1 on the change | 15:43 |
| dansmith | sahid: left some comments on your console objects spec, looking for some more detail | 15:43 |
| bauzas | alaski: the spec already needs a couple of new objects to be created :( | 15:43 |
| * artom tries asking here, since some people are bound to be familiar with Neutron. I can't figure out how to "trigger" pagination in Neutron. The _pagination method in the client seems to indicate it's supported for all resources, but I haven't been able to obtain a response with the link elements.. | 15:43 | |
| jaypipes | bauzas: also an easy +1. thx. | 15:43 |
| *** mtreinish has joined #openstack-nova | 15:44 | |
| dansmith | artom: try #openstack-neutron | 15:44 |
| dansmith | oh, you did | 15:44 |
| sahid | dansmith: cool i will see that, thanks | 15:44 |
| dansmith | heh | 15:44 |
| artom | dansmith, it's kinda dead in there :P | 15:45 |
| *** armax has joined #openstack-nova | 15:45 | |
| alaski | bauzas: hmm, there should probably be another update to add those all as dependencies | 15:45 |
| *** mhorban has quit IRC | 15:45 | |
| *** jcoufal has quit IRC | 15:45 | |
| bauzas | alaski: all of those nested objects will each one be a separate change, for sure | 15:45 |
| *** rushiagr_away is now known as rushiagr | 15:46 | |
| bauzas | alaski: but that fortunately doesn't require a spec for each of those :D | 15:46 |
| *** browne has quit IRC | 15:46 | |
| *** jwcroppe has quit IRC | 15:47 | |
| *** sdake_ has joined #openstack-nova | 15:47 | |
| *** garyk1 has joined #openstack-nova | 15:48 | |
| *** yassine_ has quit IRC | 15:48 | |
| *** tjones2 has quit IRC | 15:48 | |
| *** dsanders has joined #openstack-nova | 15:48 | |
| *** igordcard has quit IRC | 15:48 | |
| dansmith | mriedem: seen this? http://logs.openstack.org/80/174480/15/check/check-tempest-dsvm-full/27b3bb4/console.html | 15:49 |
| dansmith | don't see an e-r bug for it | 15:49 |
| *** ferest has joined #openstack-nova | 15:50 | |
| mriedem | nope | 15:50 |
| *** garyk has quit IRC | 15:50 | |
| mriedem | it's very descriptive though | 15:50 |
| mriedem | http://goo.gl/ivd4Zk | 15:51 |
| mriedem | mtreinish: ^ | 15:51 |
| dansmith | dammit | 15:51 |
| dansmith | my logstash fu is too slow | 15:51 |
| *** sdake has quit IRC | 15:51 | |
| mriedem | dansmith: http://logs.openstack.org/80/174480/15/check/check-tempest-dsvm-full/27b3bb4/logs/tempest.txt.gz?level=TRACE#_2015-04-29_15_22_12_234 | 15:51 |
| dansmith | we've seen this 20-30 times a day in a couple cases | 15:52 |
| mriedem | that's the real error | 15:52 |
| dansmith | weird | 15:52 |
| *** tjones2 has joined #openstack-nova | 15:52 | |
| mtreinish | ugh, I hate boto | 15:52 |
| mriedem | i'll open a bug | 15:52 |
| mriedem | and dibs on the e-r query | 15:52 |
| dansmith | let me know the bug number so I can recheck against it | 15:52 |
| *** annegentle has quit IRC | 15:53 | |
| *** asrangne has quit IRC | 15:53 | |
| dansmith | jhesketh: your force patch landed, so can you get t-h on board? | 15:54 |
| *** ferest has quit IRC | 15:54 | |
| mriedem | dansmith: https://bugs.launchpad.net/tempest/+bug/1450110 | 15:55 |
| openstack | Launchpad bug 1450110 in tempest "boto tests randomly fail in resource_cleanup" [Undecided,New] | 15:55 |
| dansmith | mriedem: thanks | 15:55 |
| *** Sukhdev has joined #openstack-nova | 15:55 | |
| johnthetubaguy | jaypipes: has the API group spoken about using 409 conflict in this way, I can see good arguments both sides really: https://review.openstack.org/#/c/163275/5 | 15:56 |
| mriedem | also this http://logs.openstack.org/40/164340/4/gate/gate-tempest-dsvm-postgres-full/4ef4e88/logs/tempest.txt.gz?level=TRACE#_2015-04-24_17_27_55_963 | 15:56 |
| mriedem | mtreinish: ^ | 15:57 |
| mtreinish | mriedem: oh so it's nova fault then :) | 15:57 |
| mriedem | hey, let them eat cake | 15:58 |
| *** tjones2 has quit IRC | 15:58 | |
| jaypipes | johnthetubaguy: I'll have a looksie. | 15:59 |
| *** dulek has quit IRC | 15:59 | |
| mriedem | cool, so there are multiple boto teardown timeout failures | 16:00 |
| mriedem | mtreinish: heh, nova problem? http://logs.openstack.org/40/164340/4/gate/gate-tempest-dsvm-postgres-full/4ef4e88/logs/screen-c-vol.txt.gz?level=TRACE | 16:00 |
| mtreinish | mriedem: heh, I guess I can't read today. That tempest stack trace totally says volume errored too | 16:02 |
| johnthetubaguy | jaypipes: thanks | 16:02 |
| *** igordcard has joined #openstack-nova | 16:02 | |
| *** dprince has joined #openstack-nova | 16:03 | |
| openstackgerrit | dave-mcnally proposed openstack/nova: Create a reserved aggregate filter https://review.openstack.org/178750 | 16:03 |
| *** dulek_home has joined #openstack-nova | 16:03 | |
| *** VW_ has joined #openstack-nova | 16:04 | |
| *** igordcard has quit IRC | 16:05 | |
| *** jlanoux has quit IRC | 16:05 | |
| *** vilobhmm1 has joined #openstack-nova | 16:06 | |
| *** dulek_home is now known as dulek | 16:06 | |
| *** hemnafk is now known as hemna | 16:06 | |
| *** ildikov has joined #openstack-nova | 16:08 | |
| *** otter768 has joined #openstack-nova | 16:09 | |
| *** mriedem is now known as mriedem_lunch | 16:09 | |
| *** eharney has joined #openstack-nova | 16:09 | |
| *** moshele has quit IRC | 16:11 | |
| *** sudipto has joined #openstack-nova | 16:11 | |
| *** jistr has quit IRC | 16:11 | |
| *** Nic has joined #openstack-nova | 16:13 | |
| *** yuntong has quit IRC | 16:13 | |
| *** otter768 has quit IRC | 16:13 | |
| *** yuntong has joined #openstack-nova | 16:14 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Reschedules sometimes do not allocate networks https://review.openstack.org/177470 | 16:14 |
| *** zul has quit IRC | 16:15 | |
| *** mpaolino has quit IRC | 16:15 | |
| *** oro has quit IRC | 16:17 | |
| *** josecastroleon has quit IRC | 16:17 | |
| *** unicell has quit IRC | 16:19 | |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: define the ImageMeta & ImageMetaProps objects https://review.openstack.org/76234 | 16:19 |
| *** ociuhandu has quit IRC | 16:20 | |
| *** alexpilotti has quit IRC | 16:20 | |
| *** pcaruana has quit IRC | 16:22 | |
| *** mpaolino has joined #openstack-nova | 16:28 | |
| *** atuvenie has quit IRC | 16:28 | |
| *** dikonoor has quit IRC | 16:31 | |
| *** dulek_home_ has joined #openstack-nova | 16:34 | |
| *** dulek has quit IRC | 16:35 | |
| *** dulek_home_ is now known as dulek | 16:35 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: remove dependance with libvirt https://review.openstack.org/177223 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: monitor: fix tests to use fakelibvirt https://review.openstack.org/178154 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get hardware info to Host https://review.openstack.org/177222 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to compare cpu to Host https://review.openstack.org/177331 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to list pci devices to Host https://review.openstack.org/177330 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get device by name to Host https://review.openstack.org/177329 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: avoid call of listDefinedDomains when post live migration https://review.openstack.org/177328 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to define instance to host https://review.openstack.org/174314 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduces a Guest to wrap arround virConnect https://review.openstack.org/174313 | 16:35 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add todo note to avoid call to libvirt from the driver https://review.openstack.org/177332 | 16:35 |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Adds Hyper-V vNic hot-plug implementation https://review.openstack.org/138255 | 16:35 |
| openstackgerrit | Adelina Tuvenie proposed openstack/nova: Adds Hyper-V OVS ViF driver https://review.openstack.org/140045 | 16:35 |
| *** Jeffrey4l has quit IRC | 16:37 | |
| *** VW__ has joined #openstack-nova | 16:38 | |
| *** VW__ has quit IRC | 16:38 | |
| *** doron_afk has quit IRC | 16:39 | |
| *** VW__ has joined #openstack-nova | 16:39 | |
| *** garyk1 has quit IRC | 16:39 | |
| *** VW_ has quit IRC | 16:40 | |
| *** gszasz has quit IRC | 16:41 | |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get cpu stats to host https://review.openstack.org/177223 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: monitor: remove dependance with libvirt https://review.openstack.org/178154 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to compare cpu to Host https://review.openstack.org/177331 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to list pci devices to Host https://review.openstack.org/177330 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get device by name to Host https://review.openstack.org/177329 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add method to define instance to host https://review.openstack.org/174314 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: introduces a Guest to wrap arround virConnect https://review.openstack.org/174313 | 16:42 |
| openstackgerrit | sahid proposed openstack/nova: libvirt: add todo note to avoid call to libvirt from the driver https://review.openstack.org/177332 | 16:42 |
| *** sahid has quit IRC | 16:43 | |
| *** achanda has joined #openstack-nova | 16:43 | |
| *** mriedem_lunch is now known as mriedem | 16:44 | |
| *** zzzeek has joined #openstack-nova | 16:44 | |
| *** sudipto has quit IRC | 16:44 | |
| *** pask81 has quit IRC | 16:44 | |
| *** armax has quit IRC | 16:46 | |
| *** armax has joined #openstack-nova | 16:48 | |
| *** Jeffrey4l has joined #openstack-nova | 16:49 | |
| *** matrohon has quit IRC | 16:50 | |
| *** unicell has joined #openstack-nova | 16:50 | |
| *** unicell1 has joined #openstack-nova | 16:51 | |
| *** unicell has quit IRC | 16:51 | |
| openstackgerrit | Mathieu Gagné proposed openstack/nova: Add ability to override network templace from InstanceMetadata https://review.openstack.org/178340 | 16:53 |
| *** _gryf is now known as _gryf|afk | 16:54 | |
| *** ganso__ is now known as ganso_ | 16:54 | |
| *** annegentle has joined #openstack-nova | 16:54 | |
| *** marcusvrn_ is now known as marcusvrn | 16:55 | |
| *** romainh has left #openstack-nova | 16:56 | |
| *** ndipanov has quit IRC | 16:56 | |
| *** ndipanov has joined #openstack-nova | 16:56 | |
| *** gilliard has quit IRC | 16:57 | |
| *** gilliard has joined #openstack-nova | 16:58 | |
| *** derekh has quit IRC | 16:59 | |
| *** sdake_ has quit IRC | 16:59 | |
| *** sdake has joined #openstack-nova | 16:59 | |
| *** patrickeast has quit IRC | 17:00 | |
| *** annegentle has quit IRC | 17:01 | |
| *** pkoniszewski has quit IRC | 17:01 | |
| *** sdake has quit IRC | 17:02 | |
| *** signed8bit has joined #openstack-nova | 17:03 | |
| *** sdake has joined #openstack-nova | 17:03 | |
| *** annegentle has joined #openstack-nova | 17:03 | |
| *** mpavone has quit IRC | 17:04 | |
| *** tjones2 has joined #openstack-nova | 17:05 | |
| *** unicell1 has quit IRC | 17:06 | |
| *** tonytan4ever has quit IRC | 17:06 | |
| *** unicell has joined #openstack-nova | 17:06 | |
| *** igordcard has joined #openstack-nova | 17:07 | |
| *** sdake has quit IRC | 17:07 | |
| *** Nic has quit IRC | 17:07 | |
| *** aix has quit IRC | 17:10 | |
| *** yamahata has quit IRC | 17:11 | |
| *** browne has joined #openstack-nova | 17:12 | |
| *** igordcard has quit IRC | 17:12 | |
| openstackgerrit | Paul Murray proposed openstack/nova-specs: (Re)Propose: make resource tracker use objects https://review.openstack.org/178768 | 17:13 |
| *** igordcard has joined #openstack-nova | 17:13 | |
| *** igordcard has joined #openstack-nova | 17:14 | |
| PaulMurray | johnthetubaguy, jaypipes ^^^ re-submitted RT objects spec | 17:14 |
| *** penick has joined #openstack-nova | 17:14 | |
| johnthetubaguy | PaulMurray: I think I already approved that one for liberty, without a spec, my bad, I assumed it hadn't been approved | 17:16 |
| *** eglynn has quit IRC | 17:16 | |
| *** tellesnobrega_ has joined #openstack-nova | 17:16 | |
| johnthetubaguy | PaulMurray: I can fast approve it though I supose. | 17:16 |
| *** neelashah has quit IRC | 17:16 | |
| jaypipes | PaulMurray: read, and +1 from me. | 17:16 |
| *** igordcard has quit IRC | 17:17 | |
| *** VW__ has quit IRC | 17:17 | |
| johnthetubaguy | PaulMurray: I think you are all approved on this now for liberty | 17:18 |
| *** marcusvrn has quit IRC | 17:19 | |
| *** melwitt has joined #openstack-nova | 17:19 | |
| *** tellesnobrega_ has quit IRC | 17:21 | |
| *** IanGovett has quit IRC | 17:21 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Scheduler: Introduce a FilterRequestSpec class https://review.openstack.org/158245 | 17:23 |
| PaulMurray | johnthetubaguy, jaypipes thank you very much gentlemen | 17:24 |
| jaypipes | PaulMurray: your welcome, m'lady. | 17:24 |
| *** sdake has joined #openstack-nova | 17:24 | |
| jaypipes | or even you're welcome. where are my grammanners. | 17:24 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: remove tracked changes in NUMA objects https://review.openstack.org/178772 | 17:24 |
| *** patrickeast has joined #openstack-nova | 17:25 | |
| *** tonytan4ever has joined #openstack-nova | 17:26 | |
| *** dikonoor has joined #openstack-nova | 17:26 | |
| PaulMurray | jaypipes, I knew I recognised you - your lady Penelope's chauffeur from thunderbirds | 17:27 |
| alaski | dansmith: if you have a bit to look at https://review.openstack.org/#/c/177470/4 you could tell me how terrible that is and that there's a better way to do it | 17:27 |
| jaypipes | PaulMurray: lol :) | 17:27 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: docs: fixup libvirt NUMA testing docs to match reality https://review.openstack.org/178773 | 17:28 |
| alaski | dansmith: besides ripping out the async networking stuff, which I would like to do | 17:28 |
| *** iamjarvo has joined #openstack-nova | 17:30 | |
| *** iamjarvo has quit IRC | 17:30 | |
| *** dprince has quit IRC | 17:30 | |
| *** dprince has joined #openstack-nova | 17:30 | |
| *** iamjarvo has joined #openstack-nova | 17:31 | |
| *** iamjarvo has quit IRC | 17:31 | |
| *** moshele has joined #openstack-nova | 17:31 | |
| *** yamahata has joined #openstack-nova | 17:31 | |
| *** iamjarvo has joined #openstack-nova | 17:31 | |
| *** iamjarvo has quit IRC | 17:32 | |
| *** iamjarvo has joined #openstack-nova | 17:32 | |
| *** moshele has quit IRC | 17:33 | |
| *** neelashah has joined #openstack-nova | 17:33 | |
| *** emagana has quit IRC | 17:33 | |
| *** neelashah1 has joined #openstack-nova | 17:34 | |
| *** neelashah has quit IRC | 17:37 | |
| *** mpaolino has quit IRC | 17:38 | |
| mriedem | jogo: checked out sahid's comment here https://review.openstack.org/#/c/169520/ | 17:40 |
| mriedem | jogo: i don't think that's a problem though, they aren't asynchronous operations | 17:40 |
| mriedem | re: the calls to driver.unfilter_instance | 17:40 |
| mriedem | and driver.cleanup (which calls unfilter_instance) | 17:40 |
| mriedem | jogo: so i'm going to just rebase my retry change | 17:42 |
| jogo | mriedem: sounds goo | 17:43 |
| jogo | d | 17:43 |
| jogo | I was wondering about that myself | 17:43 |
| jogo | I thought maybe libvirt is async in the background magically | 17:43 |
| jogo | either way | 17:43 |
| mriedem | i'll add some debug logging in the compute manager though | 17:43 |
| *** tjones2 has quit IRC | 17:43 | |
| mriedem | jogo: maybe it is | 17:43 |
| mriedem | idk | 17:44 |
| mriedem | if libvirt's nwfilter.undefine() was asynch, then yeah that would be a problem | 17:44 |
| mriedem | but we still couldn't fix it with a lock | 17:44 |
| jogo | debugging info will be useful | 17:44 |
| jogo | right | 17:44 |
| jogo | so a retry is needed even in that case | 17:44 |
| mriedem | yeah | 17:44 |
| *** ganso_ has quit IRC | 17:47 | |
| *** iamjarvo has quit IRC | 17:48 | |
| dansmith | alaski: I took a peek earlier | 17:50 |
| dansmith | alaski: it seems icky and fragile if we don't have every such path protected | 17:50 |
| dansmith | alaski: I was thinking, could we do a clone of the instance object when we fire off the async helper, and let it use that for its update? That way we can ensure that it's clean before, and the only thing it will do is update sysmeta | 17:51 |
| alaski | dansmith: hmm, that could work. there is an instance.refresh in the conductor on a reschedule so it should pick up the change | 17:53 |
| alaski | we could also look at moving the sys_meta update to right before a reschedule, outside of the alloc thread | 17:54 |
| *** Sukhdev has quit IRC | 17:55 | |
| *** iamjarvo has joined #openstack-nova | 17:55 | |
| *** iamjarvo has quit IRC | 17:55 | |
| *** iamjarvo has joined #openstack-nova | 17:56 | |
| dansmith | alaski: true, jsut setting it on the object is all you need to do, right? you don't need to actually save it? | 17:58 |
| dansmith | if the thread waiting for async just makes sure to do a save for some reason once that completes.. | 17:59 |
| dansmith | that'll save a db hit too | 17:59 |
| dansmith | when that async code was designed, we didn't have a way to avoid that | 17:59 |
| *** harlowja_away is now known as harlowja | 18:00 | |
| *** emagana has joined #openstack-nova | 18:01 | |
| alaski | dansmith: ahh, good point | 18:01 |
| alaski | yeah, that's probably the easiest solution here | 18:02 |
| dansmith | if so, it's easy and gainful | 18:02 |
| alaski | JoshNang: ^ | 18:03 |
| JoshNang | oh. wow, yeah that should work | 18:04 |
| *** beagles is now known as beagles_brb | 18:04 | |
| *** davidlenwell has quit IRC | 18:05 | |
| *** davidlenwell has joined #openstack-nova | 18:05 | |
| *** dhellmann has quit IRC | 18:05 | |
| JoshNang | alaski: i'll write up that change | 18:05 |
| *** lpetrut has quit IRC | 18:06 | |
| alaski | JoshNang: cool | 18:07 |
| artom | Pagination in Nova happens at the database level, yes? | 18:08 |
| artom | And it seems to not be universally applied to all resources? Specifically, for floating ips I can't find anything. | 18:08 |
| *** otter768 has joined #openstack-nova | 18:09 | |
| *** claudiub has quit IRC | 18:10 | |
| *** moshele has joined #openstack-nova | 18:12 | |
| *** otter768 has quit IRC | 18:14 | |
| *** harlowja has quit IRC | 18:16 | |
| *** harlowja has joined #openstack-nova | 18:16 | |
| *** harlowja has quit IRC | 18:17 | |
| *** harlowja has joined #openstack-nova | 18:20 | |
| dansmith | artom: I think those statements are truthy | 18:21 |
| mriedem | artom: yeah, i only see paging for instances and flavors | 18:21 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n2072 | 18:21 |
| *** beagles_brb is now known as beagles | 18:21 | |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/db/sqlalchemy/api.py#n4675 | 18:21 |
| *** vilobhmm1 has quit IRC | 18:22 | |
| *** ijw has quit IRC | 18:23 | |
| artom | dansmith, mriedem, cool, thanks! It's always nice to have someone with more experience confirm what I think is happening ;) | 18:27 |
| artom | At least there's paginate_query in oslo.db | 18:27 |
| *** VW_ has joined #openstack-nova | 18:27 | |
| melwitt | jogo: would you mind taking a quick look at this when you get a chance, small novaclient functional test refactor https://review.openstack.org/#/c/175854/ | 18:28 |
| *** markvoelker has quit IRC | 18:28 | |
| jogo | melwitt: heading to lunch, but will look at it this afternoon | 18:29 |
| melwitt | cool thanks | 18:29 |
| *** harlowja has quit IRC | 18:29 | |
| *** sdake has quit IRC | 18:29 | |
| *** harlowja has joined #openstack-nova | 18:29 | |
| mriedem | jaypipes: you know this guy? https://review.openstack.org/#/c/177824/ | 18:30 |
| *** IanGovett has joined #openstack-nova | 18:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: retry to undefine network filters during _post_live_migration https://review.openstack.org/169520 | 18:31 |
| *** Nikolay_St has joined #openstack-nova | 18:31 | |
| *** thangp has quit IRC | 18:35 | |
| *** thangp has joined #openstack-nova | 18:35 | |
| *** oro has joined #openstack-nova | 18:35 | |
| *** annegentle has quit IRC | 18:36 | |
| *** emagana has quit IRC | 18:36 | |
| *** sdake has joined #openstack-nova | 18:37 | |
| *** marun has quit IRC | 18:39 | |
| bauzas | mriedem: woah, was just wondering why I was CC'd on https://review.openstack.org/#/c/177824/ with all the gurus | 18:42 |
| mriedem | bauzas: i added you since $scheduler | 18:43 |
| *** emagana has joined #openstack-nova | 18:43 | |
| mriedem | before i noticed that he was just copying the content from the other docs | 18:43 |
| mriedem | which led to me barfing on duplicate docs | 18:43 |
| bauzas | mriedem: eh, was just kidding :) | 18:43 |
| bauzas | sounds like someone wants an ATC discount code... :D | 18:44 |
| artom | https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L199 | 18:45 |
| artom | "If 'limit' is not specified, 0, or > max_limit, we default to max_limit" | 18:45 |
| artom | if 'limit' in request.GET: | 18:45 |
| artom | params['limit'] = _get_int_param(request, 'limit') | 18:45 |
| artom | So this is a fun contradiction :D | 18:45 |
| artom | params['limit'] is only set if 'limit' is in the GET request. | 18:46 |
| artom | None of this 'we use max_limit if it's not set' business :P | 18:46 |
| mriedem | artom: there is here: https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L268 | 18:47 |
| mriedem | and here: https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L276 | 18:47 |
| mriedem | and here https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L491 | 18:47 |
| mriedem | get_pagination_params is creating the dict which is used https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L275 which does the min | 18:48 |
| *** matrohon has joined #openstack-nova | 18:48 | |
| *** kaufer has joined #openstack-nova | 18:48 | |
| mriedem | artom: so the docstring is misleading | 18:48 |
| mriedem | but doesn't look like a gaping bug | 18:48 |
| mriedem | the code was probably just refactored over time | 18:48 |
| mriedem | and the docstring should move to get_limit_and_marker | 18:48 |
| mriedem | artom: patches welcome :) | 18:49 |
| artom | mriedem, haha, for sure :) | 18:49 |
| mriedem | kaufer: go back to your day job, crisis averted | 18:49 |
| artom | Even if it was a gaping bug, it would have been expected behaviour, and the docstring should have been changed to match it, not the other way around. | 18:49 |
| *** annegentle has joined #openstack-nova | 18:49 | |
| mriedem | artom: not necessarily | 18:49 |
| mriedem | sometimes docs are wrong | 18:49 |
| artom | mriedem, the thing is, get_pagination_params is actually called as is from other places in the code | 18:50 |
| artom | Without going through get_limit_and_marker | 18:50 |
| mriedem | ok, so i guess the docstring there is telling the callers what to do? idk, that's pretty weak if it is. | 18:50 |
| artom | The docstring needs fixing to match what the code is doing, for sure. | 18:51 |
| artom | Not as confident about what to do with code that calls get_pagination_params without going through get_limit_and_marker | 18:51 |
| *** annegentle has quit IRC | 18:52 | |
| *** annegentle has joined #openstack-nova | 18:53 | |
| *** dikonoor has quit IRC | 18:53 | |
| *** annashen has joined #openstack-nova | 18:55 | |
| *** Marga_ has joined #openstack-nova | 18:56 | |
| *** redbeard has joined #openstack-nova | 18:57 | |
| dims | melwitt: +1 to https://review.openstack.org/#/c/159626/ | 18:58 |
| dims | (your comment i mean) | 18:58 |
| melwitt | dims: got it, thanks :) | 18:58 |
| *** erlon has joined #openstack-nova | 18:58 | |
| dansmith | melwitt: FYI you can fix my tests whenever you want, no permission required :P | 18:58 |
| melwitt | dansmith: haha :P | 18:59 |
| mriedem | if you want something to do, | 19:00 |
| mriedem | i've had on my board for awhile to organize test_volume.py into classes per volume type | 19:01 |
| *** emagana has quit IRC | 19:01 | |
| mriedem | right now it's just a big gorp | 19:01 |
| *** annashen has quit IRC | 19:01 | |
| mriedem | noticed that when i was helping move the s390x fibre channel changes | 19:01 |
| *** vilobhmm1 has joined #openstack-nova | 19:01 | |
| *** annashen has joined #openstack-nova | 19:02 | |
| * dansmith just threw up in his mouth a little | 19:02 | |
| mriedem | swallow it back down | 19:02 |
| dims | dansmith: that's very nice of you! (fix my tests) | 19:03 |
| mriedem | https://www.youtube.com/watch?v=CuQO33FM604 | 19:03 |
| dansmith | dims: I'm very gracious about letting other people fix my crap | 19:03 |
| *** Nikolay_St has quit IRC | 19:03 | |
| *** emagana has joined #openstack-nova | 19:04 | |
| dansmith | mriedem: gross | 19:04 |
| mriedem | you're welcome | 19:04 |
| *** dhellmann has joined #openstack-nova | 19:06 | |
| *** annashen has quit IRC | 19:06 | |
| *** jaypipes has quit IRC | 19:06 | |
| *** Marga_ has quit IRC | 19:07 | |
| artom | Top score for control though. | 19:07 |
| * lbragstad shakes head at mriedem | 19:07 | |
| *** pixelb has quit IRC | 19:08 | |
| *** VW_ has quit IRC | 19:10 | |
| bauzas | mriedem: FYI if you want to comment on... http://lists.openstack.org/pipermail/openstack-dev/2015-April/062964.html | 19:10 |
| *** vilobhmm1 has quit IRC | 19:13 | |
| *** rushiagr is now known as rushiagr_away | 19:15 | |
| *** vilobhmm1 has joined #openstack-nova | 19:17 | |
| *** salv-orl_ has joined #openstack-nova | 19:18 | |
| *** unicell has quit IRC | 19:18 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Add functional test for server group https://review.openstack.org/147514 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: scheduler:refactor group info in filter_properties https://review.openstack.org/148275 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: api: add soft-affinity policies for server groups https://review.openstack.org/147520 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: Add functional tests to soft affinity capabilities https://review.openstack.org/147521 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: scheduler: add num of instance per host in a group https://review.openstack.org/148277 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: object:add count_members_by_hosts to InstanceGroup https://review.openstack.org/147517 | 19:19 |
| openstackgerrit | Ildiko Vancsa proposed openstack/nova: scheduler: add soft-(anti-)affinity weighers https://review.openstack.org/147516 | 19:19 |
| *** vilobhmm1 has quit IRC | 19:20 | |
| mriedem | bauzas: thanks, will comment | 19:21 |
| bauzas | mriedem: by looking at the reference docs, it seems they are only provided each time a new release is coming in... | 19:21 |
| bauzas | mriedem: they don't have a master running branch | 19:22 |
| *** salv-orlando has quit IRC | 19:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/176844 | 19:22 |
| bauzas | mriedem: so it sounds little price to pay to take the existing devref and copy that to the reference docs, either manually or by a magic tool | 19:22 |
| mriedem | bauzas: i'd prefer to keep the 'golden' docs on scheduler filters in the nova devref | 19:23 |
| *** vilobhmm1 has joined #openstack-nova | 19:23 | |
| *** jaypipes has joined #openstack-nova | 19:23 | |
| bauzas | mriedem: but I can't hardly accept a change which woudn't provide a good doc | 19:23 |
| mriedem | since they are versioned and reviewed at the same time as changes to the scheduler filters are changed or added, like you said | 19:23 |
| *** ajayaa has quit IRC | 19:23 | |
| bauzas | mriedem: yeah, that's my point | 19:23 |
| mriedem | i don't think nova devs are doing much in the way of reviews in other docs repos | 19:23 |
| bauzas | mriedem: exactly | 19:23 |
| bauzas | mriedem: and that would create some confusion | 19:23 |
| bauzas | mriedem: so yes, it's like the API docs | 19:24 |
| bauzas | mriedem: that's up to the developer to make sure he updates the in-tree docs | 19:24 |
| *** isd has joined #openstack-nova | 19:24 | |
| openstackgerrit | Josh Gachnang proposed openstack/nova: Reschedules sometimes do not allocate networks https://review.openstack.org/177470 | 19:25 |
| *** vilobhmm1 has quit IRC | 19:26 | |
| *** lucasagomes is now known as lucas-dinner | 19:26 | |
| *** luv_ has joined #openstack-nova | 19:27 | |
| *** luv_ has quit IRC | 19:27 | |
| *** luv_ has joined #openstack-nova | 19:28 | |
| *** VW_ has joined #openstack-nova | 19:28 | |
| *** nkrinner has joined #openstack-nova | 19:29 | |
| *** luv_ is now known as luv | 19:29 | |
| dansmith | alaski: JoshNang: that patch looks good if it really passes your tests, aside from the small complaint I added there | 19:30 |
| *** neelashah1 has quit IRC | 19:30 | |
| *** Nikolay_St has joined #openstack-nova | 19:31 | |
| alaski | dansmith: they'll be testing it in a real environment in a bit | 19:31 |
| dansmith | alaski: okay cool | 19:31 |
| *** lucas-dinner has quit IRC | 19:31 | |
| dansmith | it's just about the best outcome for a patch, | 19:32 |
| *** Mike_D_laptop has joined #openstack-nova | 19:32 | |
| dansmith | removing a db hit, fixing a bug, with nothing but code removal :D | 19:32 |
| dansmith | actually, | 19:32 |
| dansmith | doing all that with just removing a single line of code | 19:32 |
| dansmith | impressive | 19:32 |
| alaski | yeah, it's an excellent solution if it works | 19:32 |
| JoshNang | heh :D i've got a meeting in a sec, but plan to get it into preprod and hammer on it this afternoon | 19:32 |
| JoshNang | and ++ on the test bit | 19:33 |
| melwitt | I notice the comment mentions _spawn shares a reference to the instance, and recently I found _spawn is the deprecated code path that's part of run_instance. this anyway works in the current code path (build_and_run_instance) I assume? | 19:36 |
| *** Nikolay_St has quit IRC | 19:36 | |
| alaski | melwitt: always with the sharp eyes | 19:37 |
| dansmith | melwitt: it's a generic thing | 19:37 |
| alaski | it works in the current path too | 19:37 |
| dansmith | yeah, he means the thread doing the driver._spawn | 19:37 |
| dansmith | or whatever it is | 19:37 |
| alaski | it probably came from the test_default_access_ip test which was failing on the previous solution, and tests the old run_instance path | 19:38 |
| melwitt | okay, cool. I figured it must be working but when I saw "_spawn" I felt alerted | 19:38 |
| alaski | we spent a lot of time looking at that path | 19:38 |
| dansmith | if this works, it was totally my idea to drop that save() | 19:40 |
| dansmith | and if it leads to lots of failures in lemming because of flaky saves, then I dunno, I think I heard alaski say it | 19:40 |
| mriedem | the channel isn't logged so sure | 19:41 |
| alaski | dansmith: hah | 19:41 |
| alaski | it is logged now | 19:41 |
| alaski | I came looking for advice and was totally tricked into that idea | 19:42 |
| *** unicell has joined #openstack-nova | 19:43 | |
| *** Nic has joined #openstack-nova | 19:43 | |
| *** liusheng has quit IRC | 19:43 | |
| *** david-lyle has quit IRC | 19:44 | |
| *** liusheng has joined #openstack-nova | 19:44 | |
| *** david-lyle has joined #openstack-nova | 19:44 | |
| mriedem | oh no http://eavesdrop.openstack.org/irclogs/%23openstack-nova/ | 19:47 |
| bauzas | call me stupid or os-services is not presented in http://developer.openstack.org/api-ref-compute-v2.1.html ? | 19:47 |
| mtreinish | mriedem: you didn't realize that :) | 19:47 |
| *** ajayaa has joined #openstack-nova | 19:48 | |
| mriedem | mtreinish: nope | 19:48 |
| mriedem | bauzas: don't see it either | 19:49 |
| *** FL1SK has quit IRC | 19:49 | |
| bauzas | mriedem: okay, will ask alex_xu tomorrow morning CET | 19:49 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: Fix rebuild of an instance with a volume attached https://review.openstack.org/176891 | 19:49 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: rebuild: make sure server is shut down before volumes are detached https://review.openstack.org/176892 | 19:49 |
| bauzas | because I'm just facing the extension in front of my IDE :) | 19:50 |
| *** Mike_D_laptop has quit IRC | 19:52 | |
| *** dprince has quit IRC | 19:52 | |
| *** Nikolay_St has joined #openstack-nova | 19:54 | |
| mriedem | ssshhhh | 19:55 |
| mriedem | don't let them know you use an IDE | 19:55 |
| *** arif-ali has quit IRC | 19:56 | |
| artom | Integrated Development Emacs. | 19:56 |
| artom | Aka just emacs. | 19:56 |
| *** doude has quit IRC | 20:01 | |
| *** doude has joined #openstack-nova | 20:01 | |
| bauzas | mriedem: well, Sublime Text is technically not an IDE | 20:04 |
| bauzas | it was just a shortcut :) | 20:04 |
| * bauzas would love LimeText to be as nice as ST3... :( | 20:05 | |
| bauzas | but we're not on Friday, right? | 20:05 |
| *** eharney has quit IRC | 20:07 | |
| *** otter768 has joined #openstack-nova | 20:10 | |
| *** emagana has quit IRC | 20:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: Add DB2 support https://review.openstack.org/69047 | 20:11 |
| *** jungleboyj has quit IRC | 20:11 | |
| *** emagana has joined #openstack-nova | 20:14 | |
| *** otter768 has quit IRC | 20:15 | |
| *** annegentle has quit IRC | 20:15 | |
| *** kiran-r has quit IRC | 20:19 | |
| *** gtt116_ has joined #openstack-nova | 20:19 | |
| *** tonytan4ever has quit IRC | 20:21 | |
| *** gtt116 has quit IRC | 20:22 | |
| *** annegentle has joined #openstack-nova | 20:23 | |
| *** jungleboyj has joined #openstack-nova | 20:24 | |
| *** marun has joined #openstack-nova | 20:26 | |
| bauzas | alaski: buzz me when the meeting is starting, I should miss the start | 20:28 |
| bauzas | alaski: thanks | 20:29 |
| *** jungleboyj has quit IRC | 20:35 | |
| *** eharney has joined #openstack-nova | 20:41 | |
| *** artom has quit IRC | 20:43 | |
| *** jcoufal has joined #openstack-nova | 20:45 | |
| *** mtreinish_ has joined #openstack-nova | 20:45 | |
| *** liusheng has quit IRC | 20:46 | |
| *** liusheng has joined #openstack-nova | 20:46 | |
| *** oro has quit IRC | 20:48 | |
| *** matrohon has quit IRC | 20:48 | |
| *** mtreinish has quit IRC | 20:51 | |
| *** mtreinish_ is now known as mtreinish | 20:51 | |
| *** ajo has quit IRC | 20:51 | |
| *** dulek has quit IRC | 20:52 | |
| *** belmoreira has joined #openstack-nova | 20:55 | |
| *** raildo has quit IRC | 20:58 | |
| *** iamjarvo has quit IRC | 20:58 | |
| *** VW_ has quit IRC | 21:01 | |
| *** tonytan4ever has joined #openstack-nova | 21:01 | |
| *** jcoufal has quit IRC | 21:03 | |
| *** iamjarvo has joined #openstack-nova | 21:06 | |
| *** iamjarvo has quit IRC | 21:06 | |
| *** iamjarvo has joined #openstack-nova | 21:07 | |
| *** marun has quit IRC | 21:08 | |
| *** ajayaa has quit IRC | 21:13 | |
| *** iamjarvo has quit IRC | 21:14 | |
| *** Sukhdev has joined #openstack-nova | 21:14 | |
| openstackgerrit | jichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host() https://review.openstack.org/164132 | 21:15 |
| *** mriedem has quit IRC | 21:17 | |
| openstackgerrit | jichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host() https://review.openstack.org/164132 | 21:17 |
| *** arif-ali has joined #openstack-nova | 21:18 | |
| *** VW_ has joined #openstack-nova | 21:20 | |
| *** annashen has joined #openstack-nova | 21:21 | |
| *** achanda has quit IRC | 21:22 | |
| *** pixelb has joined #openstack-nova | 21:24 | |
| *** nkrinner has quit IRC | 21:25 | |
| *** Longgeek has quit IRC | 21:29 | |
| *** flwang1 has joined #openstack-nova | 21:29 | |
| *** marun has joined #openstack-nova | 21:29 | |
| *** annashen has quit IRC | 21:33 | |
| *** vilobhmm1 has joined #openstack-nova | 21:33 | |
| *** joefides has quit IRC | 21:33 | |
| *** vilobhmm1 has quit IRC | 21:34 | |
| *** vilobhmm1 has joined #openstack-nova | 21:34 | |
| *** IanGovett has quit IRC | 21:34 | |
| *** angdraug has joined #openstack-nova | 21:35 | |
| *** marun has quit IRC | 21:35 | |
| *** achanda has joined #openstack-nova | 21:36 | |
| *** harlowja is now known as harlowja_away | 21:36 | |
| *** harlowja_away is now known as harlowja | 21:37 | |
| *** joefides has joined #openstack-nova | 21:38 | |
| *** Jeffrey4l has quit IRC | 21:38 | |
| *** vilobhmm1 has quit IRC | 21:39 | |
| *** unicell has quit IRC | 21:40 | |
| *** unicell has joined #openstack-nova | 21:40 | |
| *** pixelb has quit IRC | 21:42 | |
| *** thangp has quit IRC | 21:42 | |
| *** marun has joined #openstack-nova | 21:44 | |
| *** isd has quit IRC | 21:44 | |
| *** jichen has quit IRC | 21:44 | |
| *** FL1SK has joined #openstack-nova | 21:48 | |
| *** Jeffrey4l has joined #openstack-nova | 21:51 | |
| *** annegentle has quit IRC | 21:51 | |
| *** bnemec has quit IRC | 21:52 | |
| *** vilobhmm1 has joined #openstack-nova | 21:53 | |
| *** tonytan4ever has quit IRC | 21:54 | |
| flwang1 | dansmith: ping re patch https://review.openstack.org/#/c/164494/ | 21:58 |
| *** Jeffrey4l has quit IRC | 21:58 | |
| dansmith | in a meeting, but go ahead | 21:58 |
| *** kaufer has quit IRC | 21:58 | |
| flwang1 | dansmith: cool, thanks, you can replay at your most convenience | 21:59 |
| *** joefides has quit IRC | 21:59 | |
| flwang1 | 1. so at https://review.openstack.org/#/c/164494/12/nova/compute/manager.py do we still need a new version, like 4.1? | 21:59 |
| flwang1 | 2. based on you and matt's latest comments, seems we're backing to the ps6 solution, adding a new parameter | 22:00 |
| flwang1 | so which will cause same change for cell's rpcapi, the question is do we still need a version change for cell's rpcapi? | 22:00 |
| *** tjones1 has joined #openstack-nova | 22:01 | |
| *** jecarey has quit IRC | 22:01 | |
| *** bnemec has joined #openstack-nova | 22:02 | |
| *** melwitt has quit IRC | 22:02 | |
| *** melwitt has joined #openstack-nova | 22:02 | |
| *** VW_ has quit IRC | 22:03 | |
| *** patrickeast_ has joined #openstack-nova | 22:04 | |
| dansmith | 1. yes 2. Since mriedem said it explicitly, yes | 22:04 |
| dansmith | cells, if we're changing the call, then yes | 22:05 |
| *** patrickeast has quit IRC | 22:05 | |
| *** patrickeast_ is now known as patrickeast | 22:05 | |
| dansmith | flwang1: ^ | 22:05 |
| flwang1 | dansmith: but when i changed the version of https://review.openstack.org/#/c/164494/12/nova/compute/manager.py to 4.1 it will cause some other unrelated test failures | 22:06 |
| *** VW_ has joined #openstack-nova | 22:06 | |
| melwitt | dansmith: I was curious about the difference between instance_info_cache and instance objects save method https://github.com/openstack/nova/blob/master/nova/objects/instance_info_cache.py#L88-L98 here we don't do self._from_db_object(rv), does it not really matter? I'm looking at passing an info_cache object here | 22:07 |
| melwitt | currently it passes rv, so I thought is it wrong to pass self instead if self hasn't been updated as rv? | 22:08 |
| dansmith | flwang1: anything that depends on the rpc version being 4.0 will need to change, yeah | 22:08 |
| *** VW_ has quit IRC | 22:09 | |
| *** VW_ has joined #openstack-nova | 22:09 | |
| dansmith | melwitt: meaning we don't refresh the info_cache object on save? | 22:09 |
| melwitt | dansmith: I mean updating our "self" with the result from the db | 22:10 |
| dansmith | melwitt: that looks like a terrifically horrible bug/oversight, and may be why everyone wants to refresh that thing all the damn time | 22:10 |
| dansmith | melwitt: I would recommend fixing that, let's put it into the tree and, uh, see how things go | 22:11 |
| melwitt | dansmith: okay, I'll cook it :) | 22:11 |
| dansmith | melwitt: I'm suddenly terrified that that may be related to the never-ending "SSH timeout" bugs | 22:11 |
| *** Jeffrey4l has joined #openstack-nova | 22:11 | |
| dansmith | if so, you're an instant legend | 22:11 |
| *** otter768 has joined #openstack-nova | 22:11 | |
| flwang1 | dansmith: ok, thanks, i will dig it | 22:15 |
| *** VW_ has quit IRC | 22:16 | |
| *** otter768 has quit IRC | 22:16 | |
| openstackgerrit | Praveen Yalagandula proposed openstack/nova: neutron api: removing an obsolete comment to avoid confusion https://review.openstack.org/166019 | 22:17 |
| dansmith | melwitt: it's probably because there is only one thing, and we just saved it, so it doesn't seem like it should have changed | 22:17 |
| dansmith | melwitt: so probably not as severe as I was thinking, but definitely not right | 22:18 |
| melwitt | dansmith: yeah, I was thinking that | 22:18 |
| *** belmoreira has quit IRC | 22:18 | |
| dansmith | melwitt: i.e. good for fixing | 22:18 |
| *** nelsnelson has quit IRC | 22:18 | |
| *** salv-orlando has joined #openstack-nova | 22:19 | |
| *** salv-orl_ has quit IRC | 22:23 | |
| *** dsanders1 has joined #openstack-nova | 22:24 | |
| *** dsanders has quit IRC | 22:27 | |
| dansmith | alaski: I'm very unforgiving with my definitions of things like "decent" as you can tell | 22:27 |
| * dansmith takes some xanex | 22:27 | |
| alaski | dansmith: I am now keenly aware | 22:27 |
| dansmith | :) | 22:27 |
| openstackgerrit | Andrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties https://review.openstack.org/176083 | 22:28 |
| alaski | dansmith: it was a good discussion though and some of it should probaly get transcribed into the spec | 22:29 |
| dansmith | alaski: got it | 22:29 |
| *** fazal_ has joined #openstack-nova | 22:29 | |
| dansmith | alaski: I guess I thought I had made it clear enough | 22:29 |
| alaski | dansmith: thanks | 22:29 |
| *** Nic has quit IRC | 22:30 | |
| dansmith | alaski: I'll add some more scary words | 22:30 |
| dansmith | when I fix my typos | 22:30 |
| fazal_ | I have one routable public IP which I have assigned to my control node to access the dashboard and also the novnc consoles of the VMs. I can access the dashboard on the Public IP but not the novnc consoles. when i open the novnc of any VM, it gets directed to my <Public IP>:6080/vnc_auto.html but that doesn't come up. What should I do? | 22:30 |
| dansmith | fazal_: please see topic | 22:31 |
| fazal_ | sorry. didn't see it. | 22:32 |
| *** Jeffrey4l has quit IRC | 22:33 | |
| alaski | dansmith: scary words are good. what I took away from our parley was that there are unintentional things that could cause it, which isn't really called out | 22:34 |
| alaski | like even if you're careful you could have bad things happen | 22:34 |
| dansmith | alaski: yeah, that's the main point, so clearly I need clarity | 22:34 |
| dansmith | yeah | 22:34 |
| dansmith | I also wrote that in the middle of the big discussion we had on it, so I probably assumed the reader would have the context | 22:35 |
| alaski | yeah. it's scary, but the uninformed reader should need to change their pants afterwards | 22:37 |
| *** dsanders1 has quit IRC | 22:37 | |
| alaski | and +1 for robustify | 22:37 |
| *** ZZelle_ has joined #openstack-nova | 22:37 | |
| dansmith | alaski: "swap disks and reboot -> delete everything" should be pants-soiling | 22:38 |
| dansmith | heh | 22:38 |
| *** dsanders has joined #openstack-nova | 22:38 | |
| mgagne | I'm reading this spec: http://specs.openstack.org/openstack/nova-specs/specs/kilo/approved/metadata-service-network-info.html and its proposed implementation: https://review.openstack.org/#/c/102649/20 | 22:40 |
| mgagne | Is the network id supposed to be unique across all networks irregardless of IP version? Or is the actual network identifier a composite of network id and network type? | 22:40 |
| *** melwitt has quit IRC | 22:41 | |
| *** melwitt has joined #openstack-nova | 22:41 | |
| *** redbeard has quit IRC | 22:42 | |
| *** Jeffrey4l has joined #openstack-nova | 22:45 | |
| *** josecastroleon has joined #openstack-nova | 22:46 | |
| *** josecastroleon has quit IRC | 22:48 | |
| *** joefides has joined #openstack-nova | 22:49 | |
| *** dboik has quit IRC | 22:51 | |
| *** dboik has joined #openstack-nova | 22:51 | |
| *** ZZelle_ has quit IRC | 22:53 | |
| *** ndipanov has quit IRC | 22:54 | |
| *** Raildo has joined #openstack-nova | 22:57 | |
| *** penick has quit IRC | 22:59 | |
| *** Raildo is now known as raildo | 23:00 | |
| *** patrickeast has quit IRC | 23:03 | |
| *** signed8bit has quit IRC | 23:05 | |
| *** ildikov has quit IRC | 23:08 | |
| *** patrickeast has joined #openstack-nova | 23:09 | |
| *** joefides_ has joined #openstack-nova | 23:09 | |
| jogo | dansmith: any reason not to +W this https://review.openstack.org/#/c/174480/ | 23:09 |
| dansmith | jogo: yeah, hoping to get a clean run from t-h when jhesketh wakes up | 23:10 |
| *** bkopilov has quit IRC | 23:10 | |
| jogo | dansmith: ahh added a comment | 23:10 |
| dansmith | jogo: thanks | 23:11 |
| jhesketh | dansmith, jogo: I'll take a look in a minute, it's high on my list :-) | 23:11 |
| dansmith | jhesketh: thanks | 23:11 |
| *** joefides has quit IRC | 23:12 | |
| *** Sukhdev has quit IRC | 23:14 | |
| *** kmartin_ has quit IRC | 23:17 | |
| *** kmartin has joined #openstack-nova | 23:17 | |
| *** baoli has quit IRC | 23:20 | |
| *** penick has joined #openstack-nova | 23:21 | |
| *** Raildo_ has joined #openstack-nova | 23:21 | |
| *** ildikov has joined #openstack-nova | 23:22 | |
| *** bkopilov has joined #openstack-nova | 23:25 | |
| *** raildo has quit IRC | 23:25 | |
| *** packet has quit IRC | 23:25 | |
| *** Raildo_ has quit IRC | 23:27 | |
| *** penick has quit IRC | 23:30 | |
| *** melwitt has quit IRC | 23:33 | |
| *** marun has quit IRC | 23:39 | |
| *** emagana has quit IRC | 23:40 | |
| *** dsanders has quit IRC | 23:47 | |
| *** dims has quit IRC | 23:50 | |
| *** annashen has joined #openstack-nova | 23:52 | |
| *** moshele has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!