Thursday, 2015-04-23

jheskethYep00:00
*** browne has quit IRC00:00
*** mtanino has quit IRC00:00
*** markvoelker has joined #openstack-nova00:01
*** browne has joined #openstack-nova00:01
*** tsekiyam_ has quit IRC00:01
*** redbeard has quit IRC00:04
openstackgerritJoe Gordon proposed openstack/nova: Removing dummy mac address in the dhcp conf during shelving  https://review.openstack.org/8524900:05
jogoclarkb: ^ cleaned up the unit tests for that patch lets see if it helps at all00:06
*** otter768 has joined #openstack-nova00:06
clarkbjogo: ya I am not sure if that will make a difference00:06
clarkbjogo: the issue is when unshelving the mac addr isn't added to dnsmasq00:07
*** zzzeek has quit IRC00:08
jogonot sure either00:09
*** otter768 has quit IRC00:11
*** Marga_ has quit IRC00:11
jogobut figured it was worth a try00:13
*** Marga_ has joined #openstack-nova00:13
*** davideagnello has quit IRC00:14
*** signed8bit_ZZZzz is now known as signed8b_00:19
*** signed8b_ is now known as signed8bit_ZZZzz00:19
*** VW_ has joined #openstack-nova00:21
*** marun has quit IRC00:26
*** ijw has quit IRC00:29
*** oro has quit IRC00:31
*** Marga_ has quit IRC00:31
*** yingjun has joined #openstack-nova00:32
jheskethdansmith: Looks like your patch fixes the migrate_flavor command... however once migrated it just marks the system_metadata as deleted00:33
jheskethshould https://review.openstack.org/#/c/174480/7/nova/db/sqlalchemy/migrate_repo/versions/291_enforce_flavors_migrated.py include a check that system_metadata.deleted = 0?00:33
dansmithjhesketh: there are other things in sysmeta than the flavor00:34
dansmithjhesketh: it should delete the rows related to flavor things,00:34
dansmithjhesketh: and leave the rest00:34
jheskethdansmith: right, but I think we still need to select deleted = 0. I have 1506 instances that need migrating. I've done 40 of them00:36
jheskethif  Ido00:36
jheskethhttp://paste.openstack.org/show/205155/00:36
jheskeththe migrate_flavor_data just updates deleted on the instance_type_id rows which are still selected by your migration afaik00:37
dansmithjhesketh: oh, I see00:38
* dansmith looks at something00:38
dansmithokay, we're soft deleting those rows00:39
jheskethright, yes00:39
dansmithI think it needs to be instance_system_metadata.deleted != null00:39
dansmithand not just == 000:39
jheskethnot on my dataset00:39
jheskethin fact, show create table says its a non-null field00:40
dansmithreally?00:40
jhesketheh, no, sorry, it's default NULL00:40
dansmithI was going to say, I thought that was part of the base model00:40
jheskethyeah sorry00:41
*** vilobhmm1 has quit IRC00:41
jheskethdansmith: http://paste.openstack.org/show/205157/00:41
jhesketh(I took out the uuid's and just showed two rows of interest)00:41
openstackgerritDan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete  https://review.openstack.org/17448000:42
jheskethdansmith: selecting deleted = null returns no rows00:42
dansmithjhesketh: yeah, it should be deleted=id in most cases I think00:42
dansmithjhesketh: so try that ^ ?00:42
dansmithnot sure about the deleted=0, that's strange00:42
dansmithoh, are you saying deleted=0 are the not deleted ones?00:43
jheskethdansmith: right00:43
dansmithhrm00:43
jheskethwell I'm assuming they aren't deleted00:43
jheskethI have no null values for deleted in that table00:43
*** sdake has joined #openstack-nova00:44
dansmithhuh, delete defaults to zero in the model00:44
dansmithI could have sword they were supposed to be default to NULL00:44
dansmithabove, did you mean the table definition defaults to NULL?00:44
jheskethyes00:44
dansmithyuck00:45
jhesketh  `deleted` int(11) DEFAULT NULL,00:45
dansmithI wonder if that changed when this stuff moved out to oslo00:45
dansmithI think that means that older nova people could have NULL there00:45
dansmithor zero if the rows are newer00:45
*** annashen has joined #openstack-nova00:45
jheskethcould be older nova's have 0 in there and newer ones are null00:46
jheskeththis dataset is, admittedly, old00:46
dansmiththe current oslo model mixin says zero00:46
jheskethah00:48
jheskethso maybe we need to do an ugly OR00:48
jheskethor perhaps another migration to bring it into line (make everything NULL or 0's as it should be)00:48
dansmithI dunno, I'm futzing with it, just a sec00:49
*** promulo__ has joined #openstack-nova00:49
*** sdake has quit IRC00:50
jheskethcool00:50
dansmithsomething is weird because if I put !=0 in my query, I get no rows, even for not-deleted things00:50
dansmithoh duh00:50
* dansmith really needs dinner00:50
dansmithso deleted=id is what signals the deletedness, regardless of the default00:51
dansmithjhesketh: I think it's this:00:52
openstackgerritDan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete  https://review.openstack.org/17448000:52
*** igordcard has quit IRC00:52
dansmithactually,00:53
dansmiththat should probably be the case for the instances deleted check too00:53
*** promulo_ has quit IRC00:54
openstackgerritDan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete  https://review.openstack.org/17448000:54
*** doude has quit IRC00:55
dansmithjhesketh: if that looks right to you, tomorrow I'll write some extra unit tests here to make sure that it properly ignores deleted sysmeta rows and deleted instances00:55
*** mtanino has joined #openstack-nova00:58
*** annashen has quit IRC01:01
jheskethdansmith: that looks right to me.. but why in earlier patches were you checking instances.deleted != null. Wouldn't that have selected all of the deleted instances?01:04
dansmithyeah01:04
dansmithI don't know what I was thinking01:05
dansmithbut it passed tests because the sqla model is defaulting them to 0, which is not null01:05
jheskethah right01:05
dansmithI mean to do == NULL of course, but that wouldn't have worked because apparently we're defaulting them to 0 in software :/01:05
*** annashen has joined #openstack-nova01:06
dansmithI'll try to chase that down, because our schema should, like, match our models and stuff :/01:06
*** annashen has quit IRC01:06
jheskethyeah, if oslo.db uses 0 or the id to denote a deleted row then maybe all the deleted fields should be non-null01:07
*** dboik has joined #openstack-nova01:15
dansmithwell, I'm pretty sure that in the past nova defaulted them to NULL01:16
*** tjones2 has quit IRC01:16
dansmithwhich means there could be data sets out there that need more than just a schema change I think01:17
*** dboik has quit IRC01:19
*** yuntong1 has quit IRC01:21
*** wuhg has joined #openstack-nova01:21
*** otter768 has joined #openstack-nova01:22
*** VW_ has quit IRC01:22
*** achanda has quit IRC01:22
*** yuntong has joined #openstack-nova01:23
*** marun has joined #openstack-nova01:26
jheskethright, I meant data and schema fixed01:29
*** sdake has joined #openstack-nova01:31
*** kaisers has quit IRC01:31
*** yuntong has quit IRC01:31
*** Kevin_Zheng has joined #openstack-nova01:32
*** kaisers has joined #openstack-nova01:32
*** markvoelker has quit IRC01:33
*** yuntong has joined #openstack-nova01:34
*** erkules_ has joined #openstack-nova01:37
*** Administrator_ has joined #openstack-nova01:37
*** erkules has quit IRC01:40
*** Kevin_Zheng has quit IRC01:41
*** Administrator_ has quit IRC01:41
*** popw has joined #openstack-nova01:41
*** haigang has joined #openstack-nova01:41
*** VW_ has joined #openstack-nova01:43
*** IanGovett has quit IRC01:44
openstackgerritJoshua Hesketh proposed openstack/nova: Add support for forcing migrate_flavor_data  https://review.openstack.org/17657401:45
*** Longgeek has joined #openstack-nova01:46
*** Marga_ has joined #openstack-nova01:49
*** otter768 has quit IRC01:51
*** browne has quit IRC01:52
*** Longgeek has quit IRC01:56
*** ijw has joined #openstack-nova01:56
*** Longgeek has joined #openstack-nova01:56
*** david-lyle has quit IRC01:59
*** davideagnello has joined #openstack-nova02:02
*** ijw has quit IRC02:02
*** davideagnello has quit IRC02:07
*** annashen has joined #openstack-nova02:07
*** baoli has joined #openstack-nova02:09
*** annashen has quit IRC02:12
*** haigang has quit IRC02:12
*** harlowja is now known as harlowja_away02:12
*** annegentle has joined #openstack-nova02:14
*** VW_ has quit IRC02:14
*** patrickeast has quit IRC02:18
openstackgerritVincent Hou proposed openstack/nova: Correct the order of the parameters to call swap_volume  https://review.openstack.org/17430702:19
*** annegentle has quit IRC02:19
*** browne has joined #openstack-nova02:22
*** markvoelker has joined #openstack-nova02:22
*** marun has quit IRC02:23
*** dave-mccowan has quit IRC02:24
*** dave-mccowan has joined #openstack-nova02:25
*** VW_ has joined #openstack-nova02:26
*** rfolco has quit IRC02:28
*** dikonoor has joined #openstack-nova02:30
*** yingjun has quit IRC02:31
*** park_heijlong has joined #openstack-nova02:33
*** unicell1 has quit IRC02:38
*** yingjun has joined #openstack-nova02:39
*** haigang has joined #openstack-nova02:39
*** yingjun has quit IRC02:51
*** achanda has joined #openstack-nova02:53
openstackgerritShaoHe Feng proposed openstack/nova: Disassociate before delete network in os-tenant-networks delete method  https://review.openstack.org/16456302:59
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_associate  https://review.openstack.org/16123402:59
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe  https://review.openstack.org/16162602:59
openstackgerritShaoHe Feng proposed openstack/nova: Pass project_id when create networks by os-tenant-networks  https://review.openstack.org/16454902:59
*** achanda has quit IRC02:59
*** VW_ has quit IRC03:08
*** VW_ has joined #openstack-nova03:08
openstackgerritShaoHe Feng proposed openstack/nova: Disassociate before deleting network in os-tenant-networks delete method  https://review.openstack.org/16456303:08
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe  https://review.openstack.org/16162603:08
openstackgerritShaoHe Feng proposed openstack/nova: Pass project_id when create networks by os-tenant-networks  https://review.openstack.org/16454903:08
*** vilobhmm1 has joined #openstack-nova03:10
*** lan_ is now known as lan03:10
*** mmedvede has quit IRC03:10
*** signed8bit_ZZZzz is now known as signed8b_03:13
*** signed8b_ is now known as signed8bit_ZZZzz03:14
*** mmedvede has joined #openstack-nova03:18
*** VW_ has quit IRC03:22
*** VW_ has joined #openstack-nova03:25
*** annashen has joined #openstack-nova03:30
*** VW_ has quit IRC03:31
*** yingjun has joined #openstack-nova03:45
*** Marga_ has quit IRC03:50
*** Marga_ has joined #openstack-nova03:50
*** otter768 has joined #openstack-nova03:52
*** oomichi has joined #openstack-nova03:52
*** oomichi has quit IRC03:52
*** yingjun has quit IRC03:53
*** yingjun has joined #openstack-nova03:53
*** otter768 has quit IRC03:57
*** yingjun has quit IRC03:58
*** annashen has quit IRC04:04
*** TobiasE has quit IRC04:04
*** baoli has quit IRC04:05
*** wverdugo500 has quit IRC04:05
*** davideagnello has joined #openstack-nova04:07
*** krtaylor has quit IRC04:08
*** thomasem has quit IRC04:10
*** krtaylor has joined #openstack-nova04:11
*** xuhanp has joined #openstack-nova04:12
*** xuhanp_ has joined #openstack-nova04:12
*** rajesht has joined #openstack-nova04:12
*** thomasem has joined #openstack-nova04:14
*** wverdugo500 has joined #openstack-nova04:14
*** Sukhdev has joined #openstack-nova04:17
*** unicell has joined #openstack-nova04:25
*** deepthi has joined #openstack-nova04:30
*** coolsvap|afk is now known as coolsvap04:31
*** coolsvap is now known as coolsvap|afk04:32
*** annashen has joined #openstack-nova04:35
*** sdake has quit IRC04:41
*** fawadkhaliq has joined #openstack-nova04:45
*** sdake has joined #openstack-nova04:46
*** yingjun has joined #openstack-nova04:47
*** annashen has quit IRC04:48
*** sdake_ has joined #openstack-nova04:49
*** sdake has quit IRC04:50
*** whenry has quit IRC04:58
*** david-lyle has joined #openstack-nova04:59
*** mtanino has quit IRC05:01
*** pradipta has joined #openstack-nova05:04
*** sdake has joined #openstack-nova05:05
*** mmedvede has quit IRC05:08
*** tojuvone has joined #openstack-nova05:10
*** sdake_ has quit IRC05:10
*** jcoufal has joined #openstack-nova05:12
*** nkrinner has joined #openstack-nova05:12
*** whenry has joined #openstack-nova05:13
*** unicell1 has joined #openstack-nova05:14
*** vilobhmm1 has quit IRC05:15
*** jcoufal has quit IRC05:15
*** unicell has quit IRC05:16
*** vilobhmm1 has joined #openstack-nova05:17
*** wverdugo500 has quit IRC05:17
*** krtaylor has quit IRC05:19
*** vilobhmm11 has joined #openstack-nova05:19
*** fawadk has joined #openstack-nova05:19
*** garyk has joined #openstack-nova05:19
*** thomasem has quit IRC05:19
*** annashen has joined #openstack-nova05:20
*** markvoelker_ has joined #openstack-nova05:21
*** markvoelker has quit IRC05:21
*** mmedvede has joined #openstack-nova05:21
*** rwsu has quit IRC05:21
*** vilobhmm1 has quit IRC05:22
*** fawadkhaliq has quit IRC05:22
*** xylan has joined #openstack-nova05:23
*** med_ has quit IRC05:24
*** jcoufal has joined #openstack-nova05:25
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_*  https://review.openstack.org/16020205:26
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update  https://review.openstack.org/16020305:26
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_*  https://review.openstack.org/16020105:26
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update  https://review.openstack.org/16021505:26
*** davideagnello has quit IRC05:30
*** ajayaa has joined #openstack-nova05:31
*** armax has quit IRC05:32
*** thomasem has joined #openstack-nova05:32
*** achanda has joined #openstack-nova05:33
*** krtaylor has joined #openstack-nova05:33
*** sks has joined #openstack-nova05:35
*** med_ has joined #openstack-nova05:36
*** med_ has quit IRC05:36
*** med_ has joined #openstack-nova05:36
*** wverdugo500 has joined #openstack-nova05:38
*** josecastroleon has joined #openstack-nova05:38
sks[stack@images]$ nova console-log fedora-20.x86_64.qcow205:39
sksERROR (CommandError): No server with a name or ID of 'fedora-20.x86_64.qcow2' exists.05:39
sks[stack@images]$05:39
sksany idea what could be the issue?05:40
dikonooralex_xu : Hi alex_xu ..This is about https://bugs.launchpad.net/nova/+bug/1447084 . I guess the final decision made is to elevate the context just before the db api call05:40
openstackLaunchpad bug 1447084 in OpenStack Compute (nova) "view hypervisor details should be controlled by policy.json" [High,Confirmed] - Assigned to Divya K Konoor (dikonoor)05:40
alex_xudikonoor: yes, as my understand it is05:41
dikonooralex_xu : also , based on the discussion mriedem and bauzas had later in the evening , the change has to go into master and then backported05:41
alex_xudikonoor: yes05:41
*** Hosam has joined #openstack-nova05:42
alex_xudikonoor: so we stop to merge this patch https://review.openstack.org/160089 , it will continue after that fix merged05:42
openstackgerritJoshua Hesketh proposed openstack/nova: Add support for forcing migrate_flavor_data  https://review.openstack.org/17657405:42
dikonooralex_xu : ok..let me make the changes then..I see that https://review.openstack.org/#/c/175739/ and https://review.openstack.org/#/c/176461/ are failing because of same set of errors: http://logs.openstack.org/61/176461/1/check/check-tempest-dsvm-postgres-full/2577299/logs/devstacklog.txt.gz05:42
*** whenry has quit IRC05:43
dikonooralex_xu : "ImportError: No module named pathlib" .They don;t seem related to the changes proposed.05:43
dikonoordikonoor: I added a recheck comment on both but I am not sure if that's the next step05:44
alex_xudikonoor: looks like unrelated error, just recheck the patchset05:44
alex_xudikonoor: yea, recheck was right05:44
*** Longgeek has quit IRC05:44
dikonooralex_xu : ok , then I will wait..Thanks05:44
alex_xudikonoor: np, thanks for the fix too05:45
openstackgerritgaryk proposed openstack/nova: VMware: add in folder support on VC  https://review.openstack.org/16506005:45
*** dave-mccowan has quit IRC05:46
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update  https://review.openstack.org/16020605:46
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name  https://review.openstack.org/16020505:46
openstackgerritAlex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context  https://review.openstack.org/15035105:46
*** mmedvede has quit IRC05:46
*** xyang1 has quit IRC05:48
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update  https://review.openstack.org/16020605:49
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name  https://review.openstack.org/16020505:49
openstackgerritAlex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context  https://review.openstack.org/15035105:49
*** isd has quit IRC05:50
*** lpetrut has joined #openstack-nova05:50
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_*  https://review.openstack.org/16020205:52
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update  https://review.openstack.org/16020305:52
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_*  https://review.openstack.org/16020105:52
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update  https://review.openstack.org/16021505:52
*** otter768 has joined #openstack-nova05:53
*** kiran-r has joined #openstack-nova05:53
*** haomaiwang has quit IRC05:55
*** Longgeek has joined #openstack-nova05:57
*** otter768 has quit IRC05:57
openstackgerritgaryk proposed openstack/nova: VMware: improve instance names on VC  https://review.openstack.org/16660805:59
*** emagana has joined #openstack-nova05:59
*** yingjun_ has joined #openstack-nova05:59
*** Maike has joined #openstack-nova06:01
*** yingjun has quit IRC06:04
*** mmedvede has joined #openstack-nova06:04
*** pkoniszewski has joined #openstack-nova06:04
*** ankit_ag has joined #openstack-nova06:08
*** afazekas_ has joined #openstack-nova06:11
openstackgerritChris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support  https://review.openstack.org/17078006:11
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns  https://review.openstack.org/15071006:12
winston-dwin 306:14
*** Longgeek has quit IRC06:16
openstackgerritChris Friesen proposed openstack/nova: unify libvirt driver checks for qemu  https://review.openstack.org/17554206:16
*** Sukhdev has quit IRC06:17
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update  https://review.openstack.org/16020606:20
openstackgerritAlex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context  https://review.openstack.org/15035106:20
*** cfriesen has quit IRC06:22
openstackgerritVilobh Meshram proposed openstack/nova-specs: Replace service groups with the tooz groups  https://review.openstack.org/13860706:22
*** lpetrut has quit IRC06:23
*** ildikov has quit IRC06:25
*** Longgeek has joined #openstack-nova06:26
*** fawadkhaliq has joined #openstack-nova06:26
vilobhmm11johnthetubaguy: Can you please have a look at https://review.openstack.org/138607 I have summarised your concerns and have answered the question that you had posted…06:26
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for keypair  https://review.openstack.org/17623106:27
*** fawadk has quit IRC06:29
*** Marga_ has quit IRC06:31
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_disassociate  https://review.openstack.org/16162406:39
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/17194306:40
*** Longgeek_ has joined #openstack-nova06:43
*** Longgeek has quit IRC06:46
*** annashen has quit IRC06:46
*** xuhanp has quit IRC06:47
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host  https://review.openstack.org/16162506:48
*** sileht has quit IRC06:48
openstackgerritTrung Trinh proposed openstack/nova: Fix bug in function get_instance_availability_zone  https://review.openstack.org/14995206:48
*** xuhanp_ has quit IRC06:49
*** sahid has joined #openstack-nova06:49
*** erkules_ is now known as erkules06:50
*** erkules has joined #openstack-nova06:50
*** eglynn-pto has quit IRC06:52
*** eglynn-pto has joined #openstack-nova06:52
*** haomaiwang has joined #openstack-nova06:54
*** vilobhmm11 has quit IRC06:54
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for fixed_ip_associate_*  https://review.openstack.org/15068706:55
*** divya_ has joined #openstack-nova06:57
*** mpaolino has joined #openstack-nova06:57
*** eglynn-pto has quit IRC06:57
*** dikonoor has quit IRC06:59
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk  https://review.openstack.org/15070407:00
*** welldannit has quit IRC07:03
*** Maike has quit IRC07:06
*** achanda has quit IRC07:07
*** pkoniszewski has quit IRC07:07
*** jcoufal_ has joined #openstack-nova07:07
*** pkoniszewski has joined #openstack-nova07:07
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy  https://review.openstack.org/16025707:07
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create  https://review.openstack.org/15071807:07
*** Longgeek_ has quit IRC07:09
*** sileht has joined #openstack-nova07:10
*** Longgeek has joined #openstack-nova07:11
*** jcoufal has quit IRC07:11
*** pkoniszewski has quit IRC07:12
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_*  https://review.openstack.org/16020207:12
*** rushiagr_away is now known as rushiagr07:12
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update  https://review.openstack.org/16020307:12
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_*  https://review.openstack.org/16020107:12
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update  https://review.openstack.org/16021507:12
*** jyuso has joined #openstack-nova07:13
*** oro has joined #openstack-nova07:13
*** ildikov has joined #openstack-nova07:14
*** gzhai1 has quit IRC07:15
*** jcoufal_ has quit IRC07:15
*** heyongli has quit IRC07:15
*** atuvenie has joined #openstack-nova07:15
*** alex_xu has quit IRC07:15
*** jcoufal has joined #openstack-nova07:15
*** alex_xu_ has joined #openstack-nova07:15
*** jyuso1 has quit IRC07:15
*** gzhai1 has joined #openstack-nova07:16
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_get_all_by_host  https://review.openstack.org/16162907:17
*** lpetrut has joined #openstack-nova07:17
*** heyongli has joined #openstack-nova07:17
*** davideagnello has joined #openstack-nova07:18
*** jichen has joined #openstack-nova07:19
divya_alex_xu : for the changes that we discussed for https://bugs.launchpad.net/nova/+bug/1447084 , I am trying to figure out where unite test case changes can be made. I guess https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py uses the fake policy file at http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/fake_policy.py#L252 which expects and admin role07:20
openstackLaunchpad bug 1447084 in OpenStack Compute (nova) "view hypervisor details should be controlled by policy.json" [High,Confirmed] - Assigned to Divya K Konoor (dikonoor)07:20
*** xuhanp has joined #openstack-nova07:23
*** xuhanp_ has joined #openstack-nova07:23
*** davideagnello has quit IRC07:23
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update  https://review.openstack.org/16020607:25
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name  https://review.openstack.org/16020507:25
openstackgerritAlex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context  https://review.openstack.org/15035107:25
*** bkopilov has quit IRC07:26
*** browne has quit IRC07:27
*** xuhanp has quit IRC07:28
*** xuhanp_ has quit IRC07:28
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for fixed_ip_get_*  https://review.openstack.org/16010307:31
openstackgerritEli Qiao proposed openstack/nova: API: remove admin require from certificate_* from db layer  https://review.openstack.org/17664807:32
*** xuhanp_ has joined #openstack-nova07:33
*** xuhanp has joined #openstack-nova07:33
*** jistr has joined #openstack-nova07:38
*** apuimedo_ has joined #openstack-nova07:38
*** popw has quit IRC07:38
openstackgerritsahid proposed openstack/nova: Correct the legacy serialization of NUMATopology  https://review.openstack.org/15268907:39
openstackgerritDivya K Konoor proposed openstack/nova: view hypervisor details rest api should be allowed for non-admins  https://review.openstack.org/17665107:40
*** jlanoux has joined #openstack-nova07:40
*** jcoufal has quit IRC07:40
*** jcoufal has joined #openstack-nova07:41
*** bkopilov has joined #openstack-nova07:44
*** popw has joined #openstack-nova07:44
*** jcoufal has quit IRC07:45
*** sudipto has joined #openstack-nova07:48
*** coolsvap|afk is now known as coolsvap07:52
*** coolsvap is now known as coolsvap|afk07:53
*** Maike has joined #openstack-nova07:53
*** otter768 has joined #openstack-nova07:54
*** jcoufal has joined #openstack-nova07:54
*** matrohon has joined #openstack-nova07:55
*** divya_ has quit IRC07:58
*** otter768 has quit IRC07:58
*** sudipto has quit IRC07:59
*** eglynn-pto has joined #openstack-nova08:05
*** zz_johnthetubagu is now known as johnthetubaguy08:08
*** jyuso has quit IRC08:10
*** eliqiao1 has joined #openstack-nova08:14
*** eliqiao1 has left #openstack-nova08:15
*** eglynn-pto has quit IRC08:16
*** yingjun_ has quit IRC08:16
*** lucasagomes has joined #openstack-nova08:17
*** yassine_ has joined #openstack-nova08:19
*** Nikolay_St has joined #openstack-nova08:19
*** romainh has joined #openstack-nova08:19
*** yassine_ has quit IRC08:19
*** bkopilov has quit IRC08:19
johnthetubaguymikal: thanks the the mails, I will take a look at those reviews, its mostly a case of checking the blueprint and getting that approved first08:21
*** yassine_ has joined #openstack-nova08:21
*** yingjun has joined #openstack-nova08:23
*** eglynn-pto has joined #openstack-nova08:26
*** andreykurilin__ has joined #openstack-nova08:27
*** Longgeek has quit IRC08:31
*** Longgeek has joined #openstack-nova08:31
*** dikonoor has joined #openstack-nova08:32
*** zhangtralon has joined #openstack-nova08:34
*** doude has joined #openstack-nova08:34
*** redbeard has joined #openstack-nova08:37
*** eglynn-pto is now known as eglynn08:38
openstackgerritzhangtralon proposed openstack/nova: filter_class_names is never passed  https://review.openstack.org/14328508:41
*** doude has quit IRC08:42
*** dave-mcnally has joined #openstack-nova08:42
dave-mcnallyhey folks I have a small fix up for a bug in rebuild that I'd appreciate some reviews on: https://review.openstack.org/#/c/172951/08:43
*** tdurakov has joined #openstack-nova08:48
tdurakovHi08:49
tdurakovwho could give some details about https://bugs.launchpad.net/nova/+bug/1398999 and the way, how it was fixed?08:50
openstackLaunchpad bug 1398999 in OpenStack Compute (nova) "Block migrate with attached volumes copies volumes to themselves" [Undecided,Confirmed] - Assigned to Chris St. Pierre (stpierre)08:50
*** alexpilotti has joined #openstack-nova08:52
tdurakovwhy current implementation doesn't allow block-migration at all if volume is attached?08:53
*** jwang has joined #openstack-nova08:54
*** jwang_ has quit IRC08:57
tdurakovsdague, dansmith, could you help me with this? There is bug in launchpad, connected with previous: https://bugs.launchpad.net/nova/+bug/127663908:57
openstackLaunchpad bug 1276639 in OpenStack Compute (nova) "block live migration does not work when a volume is attached" [Medium,In progress] - Assigned to Timofey Durakov (tdurakov)08:57
*** fawadkhaliq has quit IRC08:58
openstackgerritDivya K Konoor proposed openstack/nova: view hypervisor details rest api should be allowed for non-admins  https://review.openstack.org/17665108:58
*** jwang_ has joined #openstack-nova08:59
*** jwang has quit IRC09:01
*** haomaiwang has quit IRC09:05
*** ildikov has quit IRC09:06
*** davideagnello has joined #openstack-nova09:08
*** jcoufal_ has joined #openstack-nova09:10
*** davideagnello has quit IRC09:12
*** jcoufal has quit IRC09:13
*** ndipanov has joined #openstack-nova09:18
*** kaisers has quit IRC09:20
*** ildikov has joined #openstack-nova09:21
*** kaisers has joined #openstack-nova09:23
*** zhangtralon has quit IRC09:24
*** exploreshaifali has joined #openstack-nova09:27
johnthetubaguybauzas: wondering if we could do with a blueprint for this patch I spotted: https://review.openstack.org/#/c/15824509:30
ndipanovjohnthetubaguy, well it's really only refactoring, and the BP could be general objects work09:31
*** haigang has quit IRC09:31
*** xgsa has joined #openstack-nova09:32
*** yingjun has quit IRC09:33
*** aix has joined #openstack-nova09:35
*** park_heijlong has quit IRC09:36
*** moshele has joined #openstack-nova09:36
*** pask81 has joined #openstack-nova09:40
*** derekh has joined #openstack-nova09:41
johnthetubaguyndipanov: yeah, its more to raise it up the review priority, and track it, its required09:42
*** mmedvede has quit IRC09:43
ndipanovjohnthetubaguy, I think bauzas is on PTO today, but I'll talk to him09:43
ndipanovhe has a BP up that may make that work moot09:43
ndipanovPTO = day off09:44
*** andreykurilin__ has quit IRC09:44
bauzasjohnthetubaguy : yeah on PTO09:44
bauzasWell I need further thoughts about the patch, I would say its a nice workaround until we merge ReqSpec09:46
openstackgerritdave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly  https://review.openstack.org/17295109:46
*** annashen has joined #openstack-nova09:47
bauzasI'm planning to work on the Bp by next week09:47
bauzasbut hard to give more context using my Android phone :/09:48
*** sudipto has joined #openstack-nova09:49
bauzasjohnthetubaguy: ^09:50
*** josecastroleon has quit IRC09:51
*** annashen has quit IRC09:51
*** moshele has quit IRC09:51
*** otter768 has joined #openstack-nova09:54
*** jcoufal_ is now known as jcoufal09:55
*** fawadkhaliq has joined #openstack-nova09:57
*** Longgeek has quit IRC09:57
*** Longgeek has joined #openstack-nova09:59
*** doude has joined #openstack-nova09:59
*** otter768 has quit IRC09:59
*** mmedvede has joined #openstack-nova10:00
johnthetubaguybauzas: have a good holiday!10:05
*** fawadkhaliq has quit IRC10:08
sudiptojohnthetubaguy, Can i ask for a couple of reviews?10:10
*** doude has quit IRC10:11
*** IanGovett has joined #openstack-nova10:13
*** yingjun has joined #openstack-nova10:13
*** ildikov has quit IRC10:13
*** afazekas_ has quit IRC10:14
*** amotoki_ has joined #openstack-nova10:15
sudiptojohnthetubaguy, one is here: https://review.openstack.org/#/c/173187/ and the other is https://review.openstack.org/#/c/175357/ (this is  very minor one)10:17
*** yingjun has quit IRC10:19
openstackgerritSergey Nikitin proposed openstack/nova: Removed unused variables, methods and classes  https://review.openstack.org/16466610:21
*** inhumanitas has left #openstack-nova10:21
*** mpaolino has quit IRC10:26
*** zul has quit IRC10:27
*** zul has joined #openstack-nova10:28
*** fawadkhaliq has joined #openstack-nova10:29
*** ildikov has joined #openstack-nova10:29
sudiptosahid, hoping for a merge on the patches!10:29
*** inhumanitas has joined #openstack-nova10:31
*** afazekas has joined #openstack-nova10:32
*** exploreshaifali has quit IRC10:32
sahid:)10:34
*** haomaiwa_ has joined #openstack-nova10:38
*** zul has quit IRC10:38
*** zul has joined #openstack-nova10:39
johnthetubaguysudipto: so, bit confused about one bit in the first patch10:39
*** rushiagr is now known as rushiagr_away10:40
johnthetubaguysudipto: https://review.openstack.org/#/c/173187/21/nova/virt/libvirt/driver.py,cm L4489 in the new side, don't those need to be sorted first?10:40
*** kim__ has joined #openstack-nova10:40
sudiptojohnthetubaguy, umm, i didn't think so. Let me write a dummy code.10:41
sudiptosets don't have to be sorted to be compared right?10:41
sahidsets are always sorted10:41
johnthetubaguysudipto: oh, it wasn't clear to me that they are both sets, I thought they were lists10:41
sudiptojohnthetubaguy, ah - they are sets...10:42
sahidjohnthetubaguy: made the same mistake in my first review10:42
johnthetubaguysudipto: L4496 really sends you off thinking about sorting10:43
*** xgsa has quit IRC10:44
kim__I am working on a nova project and i m very new to openstack. I would like to know can nova pass information to Ironic?10:44
johnthetubaguykim__: nova makes REST API calls to Ironic, see the ironic nova virt driver for details: https://github.com/openstack/nova/tree/master/nova/virt/ironic10:45
sudiptojohnthetubaguy, sahid I don't see sets being sorted by default. But yeah if you are doing set operations on them, i don't think need to be sorted before doing so.10:45
sahidsudipto: >>> set([3, 2, 1])10:47
sahidset([1, 2, 3])10:47
sudiptosahid, woah! I see different. Wonder why.10:47
sudiptoa = set([9, 5])10:48
sudiptoprint a10:48
sahidit's easy to find duplicate when a list is sorted10:48
ndipanovsahid, fwiw - internally sets are hashes so - they are not sorted really - they might be by your repr10:48
ndipanovnot that it matters10:48
sahidndipanov: oh really10:48
ndipanovwell yeah...10:48
sudiptosahid, yeah for me, it seems like they aren't set([9, 5]) this is the o/p10:48
*** pkoniszewski has joined #openstack-nova10:48
sahidhum...some operation can be heavy without to keep that list sorted10:49
ndipanovsahid, ?10:50
*** pask81 has quit IRC10:52
sahidndipanov: hum yes.. you probably aez right forget about me :)10:52
ndipanovhttp://svn.python.org/view/python/trunk/Objects/setobject.c10:53
ndipanovpretty straightforward open addressing hash table10:53
ndipanovI mean10:53
*** xgsa has joined #openstack-nova10:53
ndipanovbattle tested of course10:53
sahidndipanov: yes actually it makes sens that is why we cannot have two same element, the key will be the same10:54
ndipanovright10:55
sudiptosahid, if you see alex_xu_ 's comment there - he is suggesting we should not throw an exception - something that i had in the first patch sets...your thoughts?10:55
sudiptondipanov, If i may get your thoughts too on https://review.openstack.org/#/c/175357/ ...10:56
sudiptojohnthetubaguy, thanks!10:56
*** davideagnello has joined #openstack-nova10:56
*** zul has quit IRC10:57
*** zul has joined #openstack-nova10:57
ndipanovsudipto, my thoughts are that it seems approved :)10:58
ndipanovhope it helps10:58
sudiptondipanov, ok thanks! :)10:58
*** atuvenie has quit IRC10:59
johnthetubaguyI figure we can loosen it in a follow up patch, but probably best to fix the bug first11:01
*** davideagnello has quit IRC11:01
sudiptojohnthetubaguy, yeah - just that - i feel we have to re-look at what we want to support.11:04
sudiptojohnthetubaguy, to me it appears that even in the previous scenario (that didn't have this patch set code) - you'd not be able to specify or allow offline cpuset numbers in some cases.11:04
*** kim__ has quit IRC11:04
*** Maike has quit IRC11:04
sudiptojohnthetubaguy, this is my argument on the patch:  while I agree that the operator may specify some cpusets that might not be online - and later expect them to be online - in which case, the below check too doesn't suffice that need. Let's say the operator specifies 1-4 as the cpuset to use. (and my code above is not present). Let's say there are only 2 active cpus, so total_pcpus will be 2. In such a case, you wouldn't allow the compute to start11:05
sudipto as per the old behavior. Hence, it needs a complete re-look at how we would want to support this scenario that goes beyond this patch IMHO.11:05
openstackgerritsahid proposed openstack/nova: libvirt: introduces a new Guest object  https://review.openstack.org/17431311:10
*** subscope has quit IRC11:21
*** aix has quit IRC11:22
*** xuhanp has quit IRC11:24
*** xuhanp_ has quit IRC11:24
*** david-lyle has quit IRC11:29
*** eglynn is now known as eglynn-lunch11:30
*** pask81 has joined #openstack-nova11:32
*** divya_ has joined #openstack-nova11:37
*** alex_xu_ has quit IRC11:38
*** atuvenie has joined #openstack-nova11:39
*** dikonoor has quit IRC11:40
*** alex_xu has joined #openstack-nova11:41
*** tojuvone has quit IRC11:41
*** divya__ has joined #openstack-nova11:41
*** subscope has joined #openstack-nova11:42
*** Maike has joined #openstack-nova11:43
*** josecastroleon has joined #openstack-nova11:43
*** divya_ has quit IRC11:43
*** pask81 has quit IRC11:49
*** dave-mccowan has joined #openstack-nova11:53
*** pask81 has joined #openstack-nova11:53
openstackgerritTimofey Durakov proposed openstack/nova: Fixed nova-network dhcp-hostsfile update during live-migration  https://review.openstack.org/17391311:54
*** rahuk_ has joined #openstack-nova11:54
*** samueldmq has joined #openstack-nova11:55
*** otter768 has joined #openstack-nova11:55
rahuk_hey guys has anyone ever try to run xenserver (6.2) as a vm/instance on openstack (juno) ? is it possible ?11:56
*** pixelb has joined #openstack-nova11:57
*** ociuhandu has joined #openstack-nova11:59
tdurakovdansmith, Hi, could you review my patch again  https://review.openstack.org/#/c/173913/11:59
*** aix has joined #openstack-nova12:00
*** otter768 has quit IRC12:00
*** aix has quit IRC12:00
*** aix has joined #openstack-nova12:00
*** david-lyle has joined #openstack-nova12:05
*** raildo has joined #openstack-nova12:05
*** VW_ has joined #openstack-nova12:06
*** sudipto has quit IRC12:09
*** VW_ has quit IRC12:11
*** VW_ has joined #openstack-nova12:11
*** zhenguo has quit IRC12:12
*** jgrimm is now known as zz_jgrimm12:15
wanghaohi guys, could you review my patch https://review.openstack.org/#/c/171984/?12:16
*** whenry has joined #openstack-nova12:17
*** VW_ has quit IRC12:17
*** deepthi has quit IRC12:18
*** pask811 has joined #openstack-nova12:20
*** dprince has joined #openstack-nova12:23
*** pask81 has quit IRC12:23
*** divya__ has quit IRC12:27
*** josecastroleon has quit IRC12:28
*** rahuk_ has quit IRC12:30
*** david-lyle has quit IRC12:31
*** joefides_ has quit IRC12:33
*** kaisers has quit IRC12:33
*** dikonoor has joined #openstack-nova12:33
rajeshtalaski: you around ?12:34
*** eglynn-lunch is now known as eglynn12:35
*** vladikr has joined #openstack-nova12:37
*** kaisers has joined #openstack-nova12:37
*** signed8bit_ZZZzz has quit IRC12:39
*** ajayaa has quit IRC12:39
*** mpaolino has joined #openstack-nova12:40
BobBallrahuk_: Yes, it is possible - if you're running Xen underneath you can have a nested XenServer instance.12:41
*** davideagnello has joined #openstack-nova12:45
*** xyang1 has joined #openstack-nova12:45
*** amotoki_ has quit IRC12:46
*** Longgeek has quit IRC12:47
*** erlon has joined #openstack-nova12:47
*** apmelton_away is now known as apmelton12:48
*** Longgeek has joined #openstack-nova12:48
*** pradipta has quit IRC12:49
*** davideagnello has quit IRC12:50
openstackgerritsahid proposed openstack/nova: Correct the legacy serialization of NUMATopology  https://review.openstack.org/15268912:54
*** Longgeek_ has joined #openstack-nova12:55
*** Longgeek has quit IRC12:56
*** mjturek1 has joined #openstack-nova12:57
openstackgerritdave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly  https://review.openstack.org/17295112:58
*** rushil has joined #openstack-nova13:00
*** ferest has joined #openstack-nova13:01
alaskirajesht: yep13:01
*** neelashah has joined #openstack-nova13:01
*** apmelton is now known as apmelton_away13:03
*** ferest has quit IRC13:04
*** joefides has joined #openstack-nova13:05
*** alexschm has joined #openstack-nova13:05
johnthetubaguydansmith: I am wondering if we should back port all these flavor migration issues joshua H is finding?13:06
*** apuimedo_ has quit IRC13:06
*** baoli has joined #openstack-nova13:06
*** baoli_ has joined #openstack-nova13:07
*** busterswt has joined #openstack-nova13:07
*** baoli__ has joined #openstack-nova13:08
*** sdake_ has joined #openstack-nova13:10
*** baoli has quit IRC13:11
alexschmI'm looking for reviewers on https://review.openstack.org/#/c/168961/13:11
alexschmit's nearly a month old and did not get a lot of attention, does anybody care to have a look?13:11
*** baoli_ has quit IRC13:12
*** josecastroleon has joined #openstack-nova13:13
*** jecarey has joined #openstack-nova13:13
*** sdake has quit IRC13:14
*** Marga_ has joined #openstack-nova13:14
*** ivasev has joined #openstack-nova13:16
*** thomasem has quit IRC13:16
*** mriedem_away has quit IRC13:21
*** pask811 has quit IRC13:22
*** annegentle has joined #openstack-nova13:22
*** pask81 has joined #openstack-nova13:23
*** sks has quit IRC13:25
*** claudiub has joined #openstack-nova13:26
*** pask81 has quit IRC13:27
*** rfolco has joined #openstack-nova13:28
*** thomasem has joined #openstack-nova13:29
*** mpaolino has quit IRC13:29
*** mjturek1 has quit IRC13:30
*** aswadr has joined #openstack-nova13:30
*** kiran-r has quit IRC13:32
dansmithjohnthetubaguy: backport, definitely, we have to13:32
dansmithjohnthetubaguy: did you mean backport for rc2?13:32
*** fawadkhaliq has quit IRC13:33
*** fawadkhaliq has joined #openstack-nova13:36
*** kiran-r has joined #openstack-nova13:36
*** mjturek1 has joined #openstack-nova13:37
*** dboik has joined #openstack-nova13:39
*** wuhg has quit IRC13:39
*** burt has joined #openstack-nova13:42
dansmithjohnthetubaguy: I think there are only two issues though13:43
johnthetubaguydansmith: I was thinking for RC2, but we shipped that now, could be in RC3 if we end up needing one13:44
johnthetubaguydansmith: glad there are only the two issues, but realised we didn't have bugs to track those patches13:45
dansmithjohnthetubaguy: well, I figure that people running stable/kilo have until we cut the rc for lemming to do this, so, it's not super time critical I don't think13:45
dansmiththe only pressing thing is getting it to work so we can drop the stuff in master13:45
dansmithjohnthetubaguy: we have a bug for the really important one:13:45
dansmith144713213:46
dansmithjohnthetubaguy: here's the backport, for whenever: https://review.openstack.org/17674113:46
*** mriedem has joined #openstack-nova13:47
johnthetubaguydansmith: ah, I see now, its tagged for backport not RC, but thats fine13:47
mriedemflwang: i'm around now if you still are13:47
dansmithjohnthetubaguy: if we do another rc, we should put this in there, but not justify it with it13:47
dansmithso should I tag and say that on the bug?13:47
johnthetubaguydansmith: +1 that13:48
johnthetubaguydansmith: +1 both actually13:48
johnthetubaguythanks13:48
*** vladikr has quit IRC13:48
dansmithokay13:48
dansmithjohnthetubaguy: I suppose I should feel bad about this not being perfect,13:49
dansmithbut it was our first time doing such a thing, and it was flavors, so it was like worst case scenario13:49
johnthetubaguydansmith: I am just glad we have started doing it, thats a great step forward13:49
dansmithyeah13:50
*** Marga_ has quit IRC13:52
anteaya613:53
mriedem5?13:56
*** otter768 has joined #openstack-nova13:56
*** sdake_ has quit IRC13:58
*** rdo has quit IRC13:58
dikonooralex_xu : On your comments in https://review.openstack.org/#/c/176651/ on adding test cases , I am not sure if this file considers the rules from a real or fake policy.json file >> https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py14:00
*** kaisers has quit IRC14:00
*** rdo has joined #openstack-nova14:00
*** otter768 has quit IRC14:01
dikonooralex_xu: do you know if it checks for the policy.json rules.. I see a fake_policy file and policy_fixtures file under the tests but I am not sure if it's getting used here14:01
*** READ10 has joined #openstack-nova14:01
*** kaisers has joined #openstack-nova14:02
*** vladikr has joined #openstack-nova14:02
*** signed8bit has joined #openstack-nova14:02
mriedemdikonoor: it uses the fake policy http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/fake_policy.py?id=2015.1.0rc214:03
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/test.py?id=2015.1.0rc2#n24914:03
*** ganso_ has joined #openstack-nova14:03
mriedemhttp://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/policy_fixture.py?id=2015.1.0rc2#n6114:04
mriedemdikonoor: why are you only elevating the context in show for v2 api?14:04
alex_xudikonoor: yea it use fake policy14:04
mriedemshouldn't it be on all calls to host_api.service_get_by_compute_host?14:04
*** VW_ has joined #openstack-nova14:04
alex_xudikonoor: and you can follow this way https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_agents.py#L401 to fake a policy can accept normal user request14:05
alex_xudikonoor: then you can assert the non-admin context was elevated14:05
mriedemjohnthetubaguy: this was marked for kilo-rc-potential but i'm not sure it should be? https://review.openstack.org/#/c/160266/14:06
dikonoormriedem : thanks for pointing me to test.py. I wasn't sure how it all fit in . alex_xu : Let me check that file..Thanks14:06
alex_xumriedem: it because other method have another call which have hard-code permission checks before for example:https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/hypervisors.py#L8614:07
johnthetubaguymriedem: yeah, I think its because its a crazy meta bug on lots of project, and some other project wanted it in their RC14:07
alex_xumriedem: so in that bug, only the show method was break14:07
BobBallasselin: ping14:07
alex_xudikonoor: np14:08
*** eharney has joined #openstack-nova14:08
*** ajayaa has joined #openstack-nova14:08
johnthetubaguyBobBall: I replied on the ML to anthony about a Xen+libvirt issue and volumes14:09
BobBallthanks johnthetubaguy - I saw it and forwarded to Anthony.  Will let you know when we have a follow up.14:09
dikonooralex_xu : so I can override a rule in the fake_policy in this manner to " " or some other role14:09
mriedemalex_xu: i don't understand the reference to https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/hypervisors.py#L8614:09
alex_xudikonoor: no, if you change the fake_policy, I guess you will break some other unittest14:10
*** doude has joined #openstack-nova14:11
dikonooralex_xu : I don't have to change the fake_policy but I should be able to override a specific rule14:11
mriedemdikonoor: yes you can do that, sec, trying to find an example14:11
dikonoormriedem : on your question on - why are you only elevating the context in show for v2 api? , ideally it should be fixed for all.. but I wasn't sure if someone else was taking care of that..14:12
alex_xumriedem: the problem is self.host_api.service_get_by_compute_host was added in the code. And it have hard-code permission checks, then the show only can be called by admin user14:12
mriedemdikonoor: https://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_api.py#L7414:12
mriedemalex_xu: yes i understand that14:13
mriedembut dikonoor's patch is only fixing the 'show' method in the api extension14:13
*** cfriesen has joined #openstack-nova14:13
alex_xumriedem: but for other method, like index, there is call to compute_nodes = self.host_api.compute_node_get_all(context) it include hard-code permission checks before also14:13
mriedemnot the other operations where host_api.service_get_by_compute_host is called14:13
*** signed8b_ has joined #openstack-nova14:13
mriedemalex_xu: you mean in the db api?14:13
mriedemah14:14
mriedem@require_admin_context14:14
mriedemdef compute_node_get_all(context):14:14
alex_xumriedem: so the self.host_api.service_get_by_compute_host was added after that compute node db call, so index behavior isn't changed14:14
alex_xumriedem: yes14:14
mriedemok, makes sense14:14
mriedemman i hate reviewing these changes :)14:14
alex_xu:)14:14
alex_xudikonoor:14:15
dikonoormriedem : I am quite confused with how the other flows work in this respect and I would want to make small changes at a time14:15
alex_xudikonoor: that is way I suggest you can try this way https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_agents.py#L40114:15
*** lpetrut has quit IRC14:15
*** nkrinner has quit IRC14:16
*** signed8bit has quit IRC14:16
*** doude has quit IRC14:17
dikonooralex_xu : ok ..I will try adding something like this.. one for v2 and one for v2.1 ..14:17
*** doude has joined #openstack-nova14:17
dikonooralex_xu: mriedem :Thanks14:17
alex_xudikonoor: np14:17
*** browne has joined #openstack-nova14:18
*** johnthetubaguy is now known as zz_johnthetubagu14:20
mriedemdikonoor: alex_xu: i went through the other api opertations that call host_api.service_get_by_compute_host and the uptime method looks like it's also regresse14:20
mriedem*regressed14:20
*** zz_johnthetubagu is now known as johnthetubaguy14:21
mriedemoh nvm, service_get_by_compute_host is called from host_api._assert_host_exists14:21
*** haomaiw__ has joined #openstack-nova14:22
*** haomaiwa_ has quit IRC14:22
openstackgerritAdelina Tuvenie proposed openstack/nova: Adds Hyper-V vNic hot-plug implementation  https://review.openstack.org/13825514:23
openstackgerritAdelina Tuvenie proposed openstack/nova: Adds Hyper-V OVS ViF driver  https://review.openstack.org/14004514:23
*** rwsu has joined #openstack-nova14:24
alex_xumriedem: yea :)14:28
*** mtanino has joined #openstack-nova14:28
*** rdo has quit IRC14:29
mtaninoHi, does anyone give me comments for this patch? This is a bug fix for medium bug. https://review.openstack.org/#/c/175067/14:30
*** haomaiw__ has quit IRC14:32
*** haomaiwa_ has joined #openstack-nova14:32
*** Marga_ has joined #openstack-nova14:34
*** achanda has joined #openstack-nova14:34
*** jistr is now known as jistr|mtg14:35
*** BadCub_Hiding is now known as BadCub14:36
*** Marga_ has quit IRC14:36
*** artom has joined #openstack-nova14:36
*** Marga_ has joined #openstack-nova14:37
*** haomaiwa_ has quit IRC14:38
*** haomaiwang has joined #openstack-nova14:39
openstackgerritAndrew Laski proposed openstack/nova: Remove downgrade support from the cellsv2 api db  https://review.openstack.org/17555114:40
*** thangp has joined #openstack-nova14:41
openstackgerritsahid proposed openstack/nova: Correct the legacy serialization of NUMATopology  https://review.openstack.org/15268914:41
*** emagana has quit IRC14:41
sahidvladikr: +1 on functional tests you have added for numa ! you made my day :)14:42
*** rdo has joined #openstack-nova14:42
sahidhttp://logs.openstack.org/89/152689/14/check/gate-nova-tox-functional/7b2859f/testr_results.html.gz14:42
*** emagana has joined #openstack-nova14:42
openstackgerritSean Dague proposed openstack/nova: sync oslo: service child process normal SIGTERM exit  https://review.openstack.org/17677714:42
vladikrsahid, I was hoping to :)14:42
sdaguedansmith: ok, ^^^ is the oslo sync14:42
sahidahah14:43
dansmithsdague: and what are your intentions for kilo?14:43
sdaguewe should backport to kilo14:43
dansmithbackport not rc3, yes?14:43
sdaguethat's what we did for keystone and cinder14:44
dansmithsdague: also, the wait_interval bit was proposed for nova at one point.. did that go in?14:44
*** achanda has quit IRC14:44
sdagueI don't know14:44
dansmithsdague: to be clear, you mean a normal backport to stable/kilo, and not make this force an rc3, yes?14:45
sdagueI think that's probably fine, our CI won't be reliable until we have this, but other people are probably kill -9ing things in init scripts14:45
dansmithcool, I was going to say, -1 on this being rc3 :)14:46
dansmithsdague: so, question... if this is really a problem with an inbound wsgi connection or something,14:46
sdaguedansmith: I don't know14:46
dansmithsdague: can I keep SIGTERMing it until everything is clean and then have it exit14:46
*** emagana has quit IRC14:46
sdaguedansmith: sure, so we could change the test infrastructure to go into a hard loop and term term term term14:47
sdaguehowever, the current approach did expose a real issue14:47
dansmithsdague: no, I mean for workaround until the backport14:47
dansmithlike something to put into the release notes about known issues14:47
*** nelsnelson has joined #openstack-nova14:48
dansmithmriedem: needs +W ^14:48
mriedemlooking14:48
dansmithmriedem: I put an explanation of what we found in -qa14:48
mriedemi guess this is pulling in other changes14:48
mriedemsince hte last sync14:48
sdagueok, so... I guess the question is do you oppose landing this on the stable/kilo branch now? or this triggering an rc3? or are the 2 too coupled to ask that question.14:49
dansmithone other change14:49
*** ankit_ag has quit IRC14:49
sdaguemriedem: it's actually pulling in the aggregate of a revert - revert + fix14:49
*** beagles has quit IRC14:49
*** haomaiwang has quit IRC14:49
sdaguebecause that's how this code rolled this release14:49
dansmithsdague: I don't oppose anything, I just thought we couldn't land anything else into stable/kilo until the release is done14:49
sdaguejohnthetubaguy: ?14:49
dansmithsdague: given that I can't +2 things there right now14:50
*** haomaiwang has joined #openstack-nova14:50
*** nithyag_ has quit IRC14:50
dansmithcouldn't land, unless we want it for an rc3 that is14:50
mriedemwhich is https://review.openstack.org/#/c/175851/14:50
mriedemrevert revert revert, nice14:50
sdaguelet me ask ttx what he wants to do14:50
openstackgerritsahid proposed openstack/nova: Correct the legacy serialization of NUMATopology  https://review.openstack.org/15268914:51
dansmithsdague: so all I meant was, if there will be a delay between kilo-final and people getting this fix, it would be nice if we could say that term term term is a workaround14:51
sdaguedansmith: sure14:51
dansmithbut not critical of course14:51
*** ildikov has quit IRC14:51
mriedem+W14:52
dansmithmriedem: thanks14:52
tdurakovdansmith, Hi,  could you review https://review.openstack.org/#/c/173913/ again?14:53
dansmithtdurakov: yeah, I'll get to it14:54
*** signed8b_ is now known as signed8bit_ZZZzz14:54
tdurakovdansmith: thanks!14:54
*** alexpilotti has quit IRC14:55
tdurakovthere are some bug in launchpad about buggy live block migration with attached volume, should we mark them as Invalid?14:56
tdurakovone for example: https://bugs.launchpad.net/nova/+bug/130369014:57
openstackLaunchpad bug 1303690 in OpenStack Compute (nova) "nova live-migration slow when using volumes" [Medium,Confirmed]14:57
*** signed8bit_ZZZzz is now known as signed8b_14:57
*** josecastroleon has quit IRC14:57
tdurakovsdague, what do you think?14:57
*** thangp has quit IRC14:58
*** thomasem has quit IRC14:59
*** ajayaa has quit IRC14:59
*** Guest93081 is now known as beagles15:01
*** ildikov has joined #openstack-nova15:01
gilliardtdurakov: should be invalid, since https://review.openstack.org/#/c/139085/15:03
*** whenry has quit IRC15:03
tdurakovgilliard, ok15:04
*** marun has joined #openstack-nova15:04
gilliardtdurakov: I see you've backported that to stable/juno15:04
tdurakovyep15:05
*** zzzeek has joined #openstack-nova15:05
gilliardMakes sense. IDK if 'invalid' or 'fixed' is more appropriate though, actually?15:06
tdurakovas for me Invalid is more appropriate, we doesn't actually fix it, we close this functionality at all)15:07
*** baoli__ has quit IRC15:07
*** lpetrut has joined #openstack-nova15:08
gilliard"we doesn't actually fix it" <-- true :)15:09
*** baoli has joined #openstack-nova15:09
dansmithtdurakov: spelling nit, then I'm good15:09
openstackgerritTimofey Durakov proposed openstack/nova: Fixed nova-network dhcp-hostsfile update during live-migration  https://review.openstack.org/17391315:10
johnthetubaguysdague: sorry, still getting dragged into meetings, as I escape them15:10
johnthetubaguysdague: whats up?15:10
dansmithjohnthetubaguy: question about merging things to stable/kilo now..15:10
dansmithjohnthetubaguy: I think the answer is, we have to wait until final release, unless we're pushing something for rcN, right?15:11
dansmithjohnthetubaguy: (that was sdague's ping)15:11
sdaguettx is processing rc efforts, once he gets a breath, lets get him in the conversation15:11
tdurakovdansmith: done)15:11
johnthetubaguydansmith: +1 I think15:11
johnthetubaguydansmith: but yeah, ttx will be able to answer fully15:11
sdagueI'm also working on test work around code in parallel, so we can decide15:11
dansmithcool15:12
dansmithtdurakov: thanks15:12
*** ajayaa has joined #openstack-nova15:12
*** Marga_ has quit IRC15:13
johnthetubaguydansmith: sdague: FWIW I saw -2 on patches before we decided they go into an RC15:13
mriedemdansmith: i'd agree that we can't merge things to stable/kilo unless we want them in an rc....although the 2015.1 release tag could be based on the rc2 tag15:13
*** Marga_ has joined #openstack-nova15:13
dansmithI'm going based on the fact that I don't have +2 privs on stable/kilo right now :)15:14
*** unicell has joined #openstack-nova15:14
dansmithassume that means ttx wants us hands off that branch :)15:14
sdaguehmmm.... the work around here is going to be more invasive than I thought15:14
sdaguewe rm the pid file once we send the kill in devstack15:14
dansmithsdague: I don't think we need to care about the workaround in grenade,15:14
dansmithI just wanted to know if we could offer some help to ops that might hit this15:14
sdaguedansmith: yeh, sure, that's a "keep killing"15:15
dansmithyeah15:15
dansmithwe just don't know if that actually works yet right??15:15
dansmiths/?$/15:15
*** unicell1 has quit IRC15:15
*** jlanoux has quit IRC15:16
sdagueyeh, I'm trying to figure out how we'd validate that15:16
dansmithI was just going to test it locally15:17
sdagueok15:17
*** nelsnelson has quit IRC15:18
openstackgerritdave-mcnally proposed openstack/nova: Add conf option to prevent snapshotting of volume backed instances  https://review.openstack.org/17680515:18
*** Marga_ has quit IRC15:18
*** dboik has quit IRC15:18
*** whenry has joined #openstack-nova15:19
*** Nikolay_St has quit IRC15:20
dansmithI was delayed because my devstack was giving me shit15:20
*** claudiub has quit IRC15:20
sdagueheh15:23
*** tonytan4ever has joined #openstack-nova15:24
*** johnthetubaguy has left #openstack-nova15:24
*** Nikolay_St has joined #openstack-nova15:24
*** johnthetubaguy has joined #openstack-nova15:24
*** apmelton_away is now known as apmelton15:24
openstackgerritClaudiu Belu proposed openstack/nova: Fixes X509 keypair creation failure  https://review.openstack.org/17681715:25
dansmithgah15:25
*** claudiub has joined #openstack-nova15:25
dansmithfriggin cinder and loopdev15:25
dansmithsdague: help: Unable to add physical volume '/dev/loop0' to volume group 'stack-volumes-default'.15:26
dansmithclean.sh isn't getting me clean15:26
*** IanGovett has quit IRC15:26
sdagueanything still left for mounted devices after a ./clean.sh?15:26
dansmithI booted this fresh this morning so I don't think so, but let me try again15:27
*** dboik has joined #openstack-nova15:29
dansmithsdague: nothing mounted, loop0 is empty15:29
*** david-lyle has joined #openstack-nova15:29
dansmithfigure I'll nuke /opt/stack15:29
*** armax has joined #openstack-nova15:30
*** thangp has joined #openstack-nova15:30
*** matrohon has quit IRC15:35
*** derekh has quit IRC15:36
*** oro has quit IRC15:36
*** sandywalsh has quit IRC15:37
*** popw has quit IRC15:37
*** sandywalsh has joined #openstack-nova15:38
*** Mike_D_laptop has joined #openstack-nova15:38
dansmithgah15:38
sdaguedansmith: ok, so this is going to trigger rc315:39
dansmithsdague: what is?15:39
sdaguethe patch15:39
dansmithwhy?15:39
sdaguebecause it's the only way we can get it on the stable/kilo branch15:40
dansmithI'm confused15:40
dansmithwe can just wait on the backport, right?15:40
sdagueif it's ok that neutron master is blocked until then15:40
*** davideagnello has joined #openstack-nova15:41
dansmithoh, I didn't think anything was blocking all the time, I thought it was just spotty?15:41
dansmithand, I choose not to answer that question :)15:41
*** Nikolay_St has quit IRC15:41
sdagueso, this started with trying to fix - https://review.openstack.org/#/c/176723/15:42
dansmithI think my problem is lib/cinder breaking my lvm.conf15:43
dansmithsdague: okay, I don't have the context on that rename15:44
dansmithbut regardless, I thought this was only a sometimes-things-don't-exit thing15:45
sdaguedansmith: sometimes became a lot15:45
dansmithhmm15:45
dansmithfeels like something else is going on15:45
sdagueit could be15:45
*** bkopilov has joined #openstack-nova15:46
cfriesensdague: any plans to update https://review.openstack.org/#/c/169827/ ?15:47
*** fawadkhaliq has quit IRC15:47
sdaguecfriesen: honestly, I was trying to rescue a patch out of the tracker, feel free to take if over15:47
sdagueI'm not likely to get back to it for a couple weeks15:47
cfriesensdague: okay, may do that depending on time constraints15:48
sdaguecfriesen: ok, great15:48
*** signed8b_ has quit IRC15:49
*** nelsnelson has joined #openstack-nova15:49
*** angdraug has joined #openstack-nova15:50
*** atuvenie has quit IRC15:51
*** tsekiyama has joined #openstack-nova15:52
openstackgerritVictor Stinner proposed openstack/nova-specs: Add "Port Nova to Python 3" spec  https://review.openstack.org/17686815:53
*** dboik has quit IRC15:56
*** alexschm has quit IRC15:56
*** david-lyle has quit IRC15:56
*** thomasem has joined #openstack-nova15:56
*** claudiub has quit IRC15:57
*** otter768 has joined #openstack-nova15:57
*** amotoki_ has joined #openstack-nova15:59
*** dboik has joined #openstack-nova16:00
*** otter768 has quit IRC16:02
*** sahid has quit IRC16:04
*** VW_ has quit IRC16:04
*** hemnafk is now known as hemna16:07
*** emagana has joined #openstack-nova16:08
*** tjones1 has joined #openstack-nova16:08
*** rajesht has quit IRC16:10
*** VW_ has joined #openstack-nova16:10
*** VW_ has quit IRC16:11
*** pkoniszewski has quit IRC16:11
*** VW_ has joined #openstack-nova16:11
*** emagana has quit IRC16:13
openstackgerritLucas Alvares Gomes proposed openstack/nova: Ironic: Parse and validate Node's properties  https://review.openstack.org/17689016:14
*** exploreshaifali has joined #openstack-nova16:14
openstackgerritRoman Podoliaka proposed openstack/nova: Fix rebuild of an instance with a volume attached  https://review.openstack.org/17689116:15
openstackgerritRoman Podoliaka proposed openstack/nova: rebuild: make sure server is shut down before volumes are detached  https://review.openstack.org/17689216:15
*** emagana has joined #openstack-nova16:16
*** aix has quit IRC16:17
*** jistr|mtg is now known as jistr16:18
*** unicell has quit IRC16:20
*** ivasev has quit IRC16:20
*** vilobhmm1 has joined #openstack-nova16:25
*** kiran-r has quit IRC16:28
*** vilobhmm1 has quit IRC16:29
*** dikonoor has quit IRC16:29
*** patrickeast has joined #openstack-nova16:31
*** mwagner_lap has quit IRC16:31
*** Nikolay_St has joined #openstack-nova16:32
*** zz_jgrimm is now known as jgrimm16:36
sc68calsdague: jaypipes: If you get a chance, could you take a look at https://review.openstack.org/#/c/168701/ ? It's the last patch before we can merge the dual stack testing change (https://review.openstack.org/#/c/160856/)16:38
jaypipessc68cal: will do!16:39
*** jcoufal has quit IRC16:41
*** yassine_ has quit IRC16:42
*** jistr has quit IRC16:43
*** signed8bit has joined #openstack-nova16:44
*** unicell has joined #openstack-nova16:46
*** penick has joined #openstack-nova16:47
*** unicell has quit IRC16:48
*** unicell has joined #openstack-nova16:49
*** signed8bit has quit IRC16:49
*** oro has joined #openstack-nova16:49
*** dboik has quit IRC16:51
*** signed8bit has joined #openstack-nova16:51
*** mpaolino has joined #openstack-nova16:52
*** unicell has quit IRC16:54
*** unicell has joined #openstack-nova16:54
*** Nikolay_St has quit IRC16:55
*** vilobhmm11 has joined #openstack-nova16:57
*** dboik has joined #openstack-nova16:57
*** vilobhmm12 has joined #openstack-nova16:58
*** fawadkhaliq has joined #openstack-nova16:59
*** vilobhmm11 has quit IRC17:01
*** johnthetubaguy is now known as zz_johnthetubagu17:01
*** rushil has quit IRC17:02
*** cbader has quit IRC17:03
*** cbader has joined #openstack-nova17:03
*** rushil has joined #openstack-nova17:04
*** alexpilotti has joined #openstack-nova17:05
*** ildikov has quit IRC17:05
*** lucasagomes has quit IRC17:05
*** jichen has quit IRC17:06
*** rushiagr_away is now known as rushiagr17:07
*** Longgeek_ has quit IRC17:07
*** ivasev has joined #openstack-nova17:07
*** Nikolay_St has joined #openstack-nova17:08
*** neelashah has quit IRC17:08
mriedemdansmith: trying to re-wrap my head around flwang's patch here https://review.openstack.org/#/c/164494/ - we need an rpcapi version bump to know that volume-backed backup won't work on a juno compute, but i'm at a loss for where we fail that case17:10
mriedemin a previous patch set (6) he was actually passing is_volume_backed kwarg to the rpc api17:10
dansmithmriedem: if we send this message as 4.x juno will refuse to accept it17:11
dansmithso that part is automatic17:11
dansmithand 4.1 will cause kilo to refuse it17:11
dansmithbecause kilo understands only 4.017:11
dansmithwhat he's doing here though breaks compatibility17:12
dansmithI'll comment17:12
*** romainh has left #openstack-nova17:13
*** harlowja_away is now known as harlowja17:13
*** tonytan4ever has quit IRC17:13
*** pmyers has joined #openstack-nova17:14
*** pmyers has left #openstack-nova17:16
*** alexpilotti has quit IRC17:16
*** Nikolay_St has quit IRC17:18
*** Hosam has quit IRC17:19
*** browne has quit IRC17:20
*** achanda has joined #openstack-nova17:21
*** Nikolay_St has joined #openstack-nova17:22
*** neelashah has joined #openstack-nova17:22
*** Maike has quit IRC17:23
vilobhmm12johnthetubaguy : ping if you are still around17:23
*** ndipanov has quit IRC17:23
*** neelashah1 has joined #openstack-nova17:23
dansmithvilobhmm12: he's not17:23
dansmithnot until around the meeting time, AIUI17:24
vilobhmm12ok17:24
vilobhmm12thanks for letting me know17:24
mriedemdansmith: your comment made sense, the only thing i'm wondering about was how to explicitly fail if you can't send 4.1 and is_volume_backed==True?17:25
dansmithmriedem: raise something17:25
mriedemok, that's too simple. :) i didn't see any other ops doing this in there already so figured it was something else17:26
*** neelashah has quit IRC17:27
dansmithwell, usually we're just converting the call into the thing that is compatible17:27
dansmithbut here we don't have any such thing17:27
dansmithso we need to signal to the upper layers that it can't do this17:27
*** jwcroppe has joined #openstack-nova17:28
dansmithwhich is basically, some exception, where it will do the same thing it does now if it's unsupported17:28
dansmithand once the pin is lifted, then it'll just start working17:28
*** sdake has joined #openstack-nova17:28
*** doude has quit IRC17:28
*** doude has joined #openstack-nova17:29
mriedemok, this is a fun little patch17:29
*** alanf-mc has joined #openstack-nova17:30
openstackgerritChris Friesen proposed openstack/nova: fix network setup on evacuate  https://review.openstack.org/16982717:31
*** signed8bit has quit IRC17:31
*** kiran-r has joined #openstack-nova17:34
*** signed8bit has joined #openstack-nova17:34
*** marun has quit IRC17:34
*** claudiub has joined #openstack-nova17:35
*** tonytan4ever has joined #openstack-nova17:35
*** patrickeast_ has joined #openstack-nova17:36
*** patrickeast has quit IRC17:37
*** patrickeast_ is now known as patrickeast17:37
*** dprince has quit IRC17:38
*** dboik has quit IRC17:38
*** dboik has joined #openstack-nova17:39
openstackgerritJim Rollenhagen proposed openstack/nova: Objects: Fix instance.system_metadata tracking  https://review.openstack.org/17692017:39
jrolldansmith: ^ how (in)valid is this test case?17:40
dansmithVERY INVALID17:41
jroll(it should fail, to be clear, I think I've found a bug here)17:41
jrollheh17:41
* dansmith actually looks at it17:41
dansmithjroll: that says "fix it" but it just adds a test17:41
*** ZZelle_ has joined #openstack-nova17:41
jrolldansmith: right, it's incomplete17:41
dansmithit should be tracked now17:41
* jroll WIPs17:41
jrollso, for background, I've had cases where this isn't taking: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L249117:42
*** isd1 has joined #openstack-nova17:42
dansmithjroll: hmm, not sure why that would be17:42
dansmithjroll: regardless, the test shouldn't need to create rows in the db17:43
jrolldansmith: right, I'm not either, reading the code. but I finally wrote a failing test case, which is why I wanted to poke you and see if you see immediate problems with it17:43
dansmiththat fails?17:43
jrollyes17:43
jrollI created rows in the db, because it was otherwise failing with orphaned instances errors17:44
jrollmocking obj_load_attr may handle that though17:44
dansmithare you trying to simulate the case where it's set when it's not loaded?17:44
dansmithbecause that's what you're doing and why you're getting that lazy load17:44
*** sileht has quit IRC17:44
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742717:45
*** lpetrut has quit IRC17:45
tjones1dansmith: ^^ blush…  that's what i get for doing too many things at the same time.17:45
dansmithtjones1: yeah :-(17:45
jrolldansmith: I'm thinking so, but honestly unsure17:45
*** annegent_ has joined #openstack-nova17:46
tjones1sorry about that17:46
dansmithjroll: so, what you have there is too invasive to be legit I think, unless you're poking some really obscure thing17:46
*** thomasem has quit IRC17:46
dansmithjroll: if you add this to the instance object creation:17:46
dansmithinst = instance.Instance(context=self.context, system_metadata={})17:47
*** eglynn has quit IRC17:47
dansmithjroll: then you shouldn't need to inst.create() it, nor the mocks for lazy load, etc17:47
dansmithjroll: the actual code in the manager you're pointing to there should never arrive at a place where system_metadata is unset, I think17:47
dansmithjroll: if it is, then *that* is probably what needs fixing17:47
jrolldansmith: ok, I'll play with it17:48
dansmithcool17:48
*** jwcroppe has quit IRC17:48
jrolldansmith: I also just realized I'm not actually changing the value, I meant to have baz in there somewhere17:48
*** jwcroppe has joined #openstack-nova17:48
dansmithheh17:49
*** annegentle has quit IRC17:50
jrolldansmith: so if system_metadata isn't set in that manager code, why would that be a problem, wouldn't it just load it at that point?17:52
dansmithjroll: it should yeah17:52
jrollyeah, don't see why that would cause this17:53
*** dprince has joined #openstack-nova17:53
*** lennyb has joined #openstack-nova17:55
jrollfwiw, doing the sm = inst.system_metadata; sm['network_allocated'] = 'False'; inst.system_metadata = sm; dance seems to have fixed this in my environment, though it's hard to tell since it's on reschedule17:55
*** sileht has joined #openstack-nova17:55
openstackgerritChris Friesen proposed openstack/nova: fix network setup on evacuate  https://review.openstack.org/16982717:56
openstackgerritAndrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances  https://review.openstack.org/17692517:56
dansmithjroll: well, that'd be a classic example of missing noticing that it's changed, of course17:56
jrolldansmith: right, it's really odd17:56
dansmithjroll: any chance the thing is already False, we set it to False, so the save() doesn't do anything because nothing is changed, and the thing that fails is actually because we didn't do other things in save?17:57
dansmithmeaning the workaround you do above will always make us save, even if the value was already False17:57
dansmithmaybe log the value first to see if we're really changing it?17:57
jrolldansmith: well, the thing failing is because it's True, and in the same thread and whatnot17:57
jrollI have some logs, sec17:58
*** otter768 has joined #openstack-nova17:58
*** jwcroppe has quit IRC17:59
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/17684418:00
*** ildikov has joined #openstack-nova18:00
*** aswadr has quit IRC18:01
jrolldansmith: https://gist.github.com/jimrollenhagen/67b06f73c698cc07dd9318:01
dansmithjroll: oh you mean the save is yanking it back to true?18:02
jrolldansmith: yes18:02
dansmithokay, this is different I tink18:02
*** ijw has joined #openstack-nova18:02
*** otter768 has quit IRC18:03
*** claudiub has quit IRC18:03
jrolldansmith: and just to be clear, this code is 20 days behind master and running in cells18:04
dansmithoh cells18:04
*** browne has joined #openstack-nova18:04
jrollx.x18:04
*** kiran-r has quit IRC18:04
*** jwcroppe has joined #openstack-nova18:05
*** rajesht has joined #openstack-nova18:06
jrolldansmith: this is within the same request/thread/etc, so I'm hoping cells doesn't matter... but there's cells code in save() so you never know18:07
*** tjones1 has quit IRC18:07
dansmithjroll: well, this kinda seems like a race to update the DB, and that you're getting True back because that's what is in the database18:07
*** david-lyle has joined #openstack-nova18:07
dansmithjroll: have you tried adding logging to see if it's actually saving the system_metadata in that call?18:07
dansmithlike, you were concerned that maybe it's not noticing the change, but have you tried like running obj_what_changed() right before the save call?18:08
*** tjones1 has joined #openstack-nova18:08
dansmithalso maybe alaski has some ideas if it happens to be cells-related18:08
alaskiI don't think it is, I looked at it a bit yesterdya18:08
dansmithokay18:08
alaskiI'm also interested in what some logging would find18:08
jrolldansmith: I think those logs are the best I've got right now18:09
dansmithjroll: well, I don't think they tell us much18:09
dansmithjroll: can you repro with more?18:09
jrolland I don't know why what we're seeing there would be a db race or whatever18:09
dansmithwell,18:09
jrollI guess I don't understand why calling save() would change the contents of sysmeta18:10
dansmiththe instance refreshes itself during the save18:10
jrollmmmm18:10
jrollright.18:10
jrollfun18:10
alaskiyeah, it seems like the object sysmeta is set to true and the db is false, but the db doesn't get updated18:10
jrollbut those *should* be talking to the same db, alaski correct me if I'm wrong there with our env18:10
dansmithopposite I think18:10
jrollyeah, opposite18:11
dansmithsure18:11
*** rajesht has quit IRC18:11
alaskiright, opposite18:11
*** melwitt has joined #openstack-nova18:11
dansmithbut if something else changes it between when you changed it and it returns..18:11
alaskijroll: yeah, same db18:11
dansmithbecause we do sync the metadata in a separate transaction, because $reasons18:11
jrollright18:11
jrollare there any periodic tasks that update sysmeta?18:12
dansmithprobably :)18:12
jrollgoody18:12
jrolldansmith: I'll drop some extra logging and whatnot in there, might be this afternoon before I really get into it18:13
jrollthanks for the help18:13
dansmithokay18:13
dansmithany chance we can just pretend this isn't happening? :)18:14
jrollheh, dunno, seems people get upset when their instances don't have networking :)18:14
dansmithto quote mriedem, "let them eat cake"18:15
*** gyee has joined #openstack-nova18:15
*** dboik_ has joined #openstack-nova18:15
jroll:P18:15
mriedemheh18:15
mriedemi said that at least twice yesterday18:15
mriedemand still have my head18:15
mriedemon the plus side for me,18:16
mriedema guy internally has been bugging me for a week about why his compute node won't register with his controller,18:16
mriedemgot on the controller and the disk was full, rpc was going insane in neutron eating up the logs, db connection was lost, the whole shebang18:17
alaskihmm, I'm sort of suprised our periodic tasks don't use a lock18:17
mriedemalaski: sync_instance_power_state does18:17
mriedemwell.....the periodic task does, the lifecycle event stuff does not18:17
jrollalaski: sooo about this clustered compute thing.....18:17
*** derekh has joined #openstack-nova18:17
* jroll hides18:17
alaskijroll: yeah, I was about to get to that :)18:18
jrollI'm curious if we can drop a compute and still reproduce this18:18
*** dboik has quit IRC18:18
alaskimriedem: cool.  just found that.  none of the others seem to18:18
*** redbeard has quit IRC18:19
*** mpaolino has quit IRC18:23
*** morganfainberg is now known as grebniafnagrom18:24
*** grebniafnagrom is now known as morganfainberg18:24
*** yassine_ has joined #openstack-nova18:24
*** yassine_ has quit IRC18:25
*** alexpilotti has joined #openstack-nova18:27
*** exploreshaifali has quit IRC18:28
*** MVenesio has joined #openstack-nova18:28
*** gyee has quit IRC18:30
*** VW_ has quit IRC18:35
*** ArxCruz_ has joined #openstack-nova18:35
*** ArxCruz_ has quit IRC18:36
*** VW_ has joined #openstack-nova18:38
*** VW__ has joined #openstack-nova18:39
*** nikhil_k is now known as nikhil_k-bbiab18:40
*** VW_ has quit IRC18:42
*** lennyb has quit IRC18:45
*** lennyb has joined #openstack-nova18:46
*** alexpilotti_ has joined #openstack-nova18:46
wasmumrunning centos 7 following the juno docs, line by line.  getting a vif_binding_fail and no host found.  Anyone else seen that following those docs?18:47
wasmum*vif_type_binding18:47
dansmithwasmum: please see topic18:48
wasmumsorry wrong room, thanks dansmith18:48
*** ZZelle has quit IRC18:48
*** ZZelle has joined #openstack-nova18:49
*** alexpilotti has quit IRC18:49
*** derekh has quit IRC18:49
*** alexpilotti_ is now known as alexpilotti18:49
mikehnhey guys, how can i avoid "mysql server has gone away" errors? i tweaked all the timeout settings and stuff but they continue to happen, just like with keystone and glance etc18:52
*** jwcroppe has quit IRC18:54
*** doude has quit IRC18:55
*** doude has joined #openstack-nova18:55
*** amotoki_ has quit IRC18:57
*** jwcroppe_ has joined #openstack-nova18:58
mriedemmikehn: see topic,18:58
*** angdraug has quit IRC18:58
mriedemalso, a google search and ask.openstack.org search on that error shows several hits to dig into18:58
mikehnmriedem: well nova-api gives the errors too :)18:59
mikehnoh well18:59
openstackgerritAndrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances  https://review.openstack.org/17692518:59
mikehndev18:59
mikehntrue18:59
mikehngoogle and ask dont give me the solution, only the max packet size and timeout18:59
*** derekh has joined #openstack-nova19:00
*** mwagner_lap has joined #openstack-nova19:03
*** kaisers has quit IRC19:05
*** ivasev has quit IRC19:06
*** kaisers has joined #openstack-nova19:06
*** sdake_ has joined #openstack-nova19:09
*** patrickeast has quit IRC19:10
*** sdake has quit IRC19:12
*** jichen has joined #openstack-nova19:14
*** rushiagr is now known as rushiagr_away19:14
*** ivasev has joined #openstack-nova19:15
*** marun has joined #openstack-nova19:15
*** VW__ has quit IRC19:15
*** nelsnelson has quit IRC19:17
*** tjones1 has quit IRC19:17
*** browne has quit IRC19:18
*** tjones1 has joined #openstack-nova19:19
*** browne has joined #openstack-nova19:19
*** nikhil_k-bbiab is now known as nikhil_k19:20
openstackgerritChris Friesen proposed openstack/nova: unify libvirt driver checks for qemu  https://review.openstack.org/17554219:30
*** penick has quit IRC19:32
*** liusheng has quit IRC19:34
*** penick has joined #openstack-nova19:37
*** ociuhandu has quit IRC19:38
*** annegent_ has quit IRC19:40
*** annegentle has joined #openstack-nova19:41
*** ildikov has quit IRC19:41
*** lpetrut has joined #openstack-nova19:41
openstackgerritDan Smith proposed openstack/nova: Add some testing for flavor migrations with deleted things  https://review.openstack.org/17695519:41
*** yuntong has quit IRC19:41
*** jecarey has quit IRC19:42
*** yuntong has joined #openstack-nova19:42
*** smccully has quit IRC19:45
*** smccully has joined #openstack-nova19:45
*** Nikolay_St has quit IRC19:46
*** pixelb has quit IRC19:50
*** Nikolay_St has joined #openstack-nova19:52
cfriesenlooks like I'm going to the summit...is there a cutoff for merged submissions after which the ATC pass is only good for the next summit?19:55
*** MVenesio has quit IRC19:55
*** yuntong has quit IRC19:56
*** yuntong has joined #openstack-nova19:56
*** amotoki_ has joined #openstack-nova19:57
*** ajayaa has quit IRC19:58
*** annashen has joined #openstack-nova19:58
*** mtanino has quit IRC19:58
*** otter768 has joined #openstack-nova19:59
*** patrickeast has joined #openstack-nova19:59
*** Sukhdev has joined #openstack-nova19:59
dansmithcfriesen: if you haven't used your ATC pass yet, it's too late20:02
dansmithas I understand it20:02
dansmithfor vancouver, that is20:02
*** angdraug has joined #openstack-nova20:02
*** Nikolay_St has quit IRC20:03
cfriesenI never actually got one...was just wondering when the cutoff date for merged patches was to qualify for ATC.20:03
dansmithI would expect it was just before the cutoff for using the ATC pass20:03
*** Nikolay_St has joined #openstack-nova20:03
dansmithas if they issued you one now, it wouldn't matter because it's not a valid discount anymore20:04
dansmithso my point is, if you don't have one, you won't get one until next cycle20:04
*** otter768 has quit IRC20:04
mriedemcfriesen: http://stackalytics.com/?metric=commits&user_id=cbf123&release=kilo20:04
mriedemyeah a bit late20:04
mriedemcfriesen: you will have one for liberty though20:04
*** annashen has quit IRC20:04
mriedemhttp://stackalytics.com/?metric=commits&user_id=cbf123&release=liberty20:04
mriedemso...see you in tokyo!20:05
cfriesenhopefully20:05
dansmithwell,20:05
dansmithhe could still come20:05
dansmithhe'd just have to pay :)20:05
mriedemtrue20:05
cfriesenI'm coming to vancouver...just got approval20:05
mriedemor concoct some elaborate 80s style movie scheme to get in20:05
mriedemwith antics to ensue20:05
*** annashen has joined #openstack-nova20:06
* cfriesen creates fake badge and sneaks in20:06
melwittcfriesen here's some info, if you still are curious about cutoff date https://ask.openstack.org/en/question/45531/atc-pass-for-the-openstack-summit/20:06
mriedemi'm thinking more along the lines of weekend at barneys20:07
mriedem*bernies20:07
cfriesenmelwitt: I saw that...it doesn't actually give the cutoff date for kilo, just the start date.20:07
melwittcfriesen: oh, well it says "the last batch of invites is sent right after the Feature Freeze"20:07
melwittwhich I think was around march 19 or so20:08
dansmithand all the emails said "no exceptions at all"20:08
dansmithso I dunno if that's a hard line or not20:08
cfriesenokay, thanks all.  full price it is.20:09
*** annashen has quit IRC20:12
*** hanzhang has quit IRC20:12
*** mtanino has joined #openstack-nova20:12
*** hanzhang has joined #openstack-nova20:13
*** Nikolay_St has quit IRC20:13
*** Mike_D_laptop has quit IRC20:13
*** Nikolay_St has joined #openstack-nova20:14
*** fawadkhaliq has quit IRC20:14
openstackgerritDan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete  https://review.openstack.org/17448020:17
openstackgerritAndrew Laski proposed openstack/nova-specs: WIP RequestSpec object split instance_properties  https://review.openstack.org/17696720:18
openstackgerritAndrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties  https://review.openstack.org/17696720:19
openstackgerritAndrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties  https://review.openstack.org/17608320:20
*** marun has quit IRC20:21
*** igordcard has joined #openstack-nova20:26
*** overlayer has joined #openstack-nova20:26
*** jecarey has joined #openstack-nova20:26
*** overlayer has quit IRC20:27
*** matrohon has joined #openstack-nova20:28
*** andreykurilin__ has joined #openstack-nova20:28
zigodansmith: jaypipes: I noticed that the generated nova.conf.sample is wrong, with the keystone_authtoken missing half of the directives. I first noticed the issue in Cinder, and as a consequence, jgriffith wrote a patch to stop using tools/config/generate_sample.sh and to use oslo-config-generator directly, which fixed the issue.20:29
zigoSo, both nova & cinder have the issue...20:29
dansmithzigo: okay, is there a question coming? :)20:31
zigodansmith: Hum.... Can you fix it? :)20:32
zigo:D20:32
mriedemzigo: link to jgriffith's cinder patch?20:32
dansmithzigo: probably no better than you can20:32
dansmithheh, my next question :)20:32
zigohttps://review.openstack.org/#/c/176857/20:33
zigoThat's probably not so helpful, as nova is using a different set of libs, so the oslo-config-generator call must be different.20:33
dansmiththat was abandoned?20:33
*** fawadkhaliq has joined #openstack-nova20:34
zigoThis one must be better: https://review.openstack.org/#/c/165431/20:34
mriedem"better"20:34
mriedemit's not trivial20:34
dansmithyeah, jeez20:35
mriedemi think jogo is the oslo liasion so let's just make him fix it20:35
dansmith+220:35
*** dboik_ has quit IRC20:36
*** artom has quit IRC20:36
*** Nikolay_St has quit IRC20:38
zigoI don't mind the way it's done, but the fact is, we can't leave nova.conf.sample with half of the keystone_authtoken directives removed (including tenant_name, password, URI and so on...).20:38
*** marun has joined #openstack-nova20:39
*** achanda has quit IRC20:41
*** neelashah1 has quit IRC20:41
*** tonytan4ever has quit IRC20:42
*** annashen has joined #openstack-nova20:42
*** signed8bit has quit IRC20:43
*** jgrimm is now known as zz_jgrimm20:43
*** Nikolay_St has joined #openstack-nova20:43
*** gtt116 has quit IRC20:44
*** gtt116 has joined #openstack-nova20:44
*** raildo has quit IRC20:45
*** tonytan4ever has joined #openstack-nova20:46
*** n0ano has joined #openstack-nova20:51
jgriffithmriedem: Had to make an adjustment: https://review.openstack.org/#/c/176930/20:51
*** derekh has quit IRC20:51
*** samueldmq has quit IRC20:51
mriedemjgriffith: that's much nicer short-term :)20:51
jgriffithmriedem: yeah20:52
*** aruban has joined #openstack-nova20:52
mriedemadded nova to the bug20:52
*** aruban has quit IRC20:52
jgriffithmriedem: although honestly when I looked at what others are doing with the opts.py file I'm considering polishing slightly and keeping it long term :)20:52
*** aruban has joined #openstack-nova20:53
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742720:53
*** dboik has joined #openstack-nova20:55
*** fawadkhaliq has quit IRC20:57
*** ijw has quit IRC20:59
mriedemmeeting time?21:01
bauzasnova meeting now ?21:01
bauzas(back from PTO today)21:01
*** unicell has quit IRC21:01
*** unicell1 has joined #openstack-nova21:01
bauzaseh, zombie meeting ?21:03
openstackgerritJoel Coffman proposed openstack/nova: Remove comment inconsistent with code  https://review.openstack.org/17698421:05
*** zz_johnthetubagu is now known as johnthetubaguy21:05
*** Nikolay_St has quit IRC21:05
*** ivasev has quit IRC21:06
*** Nikolay_St has joined #openstack-nova21:06
*** aruban has quit IRC21:07
*** lpetrut has quit IRC21:07
*** tonytan4ever has quit IRC21:09
*** signed8bit has joined #openstack-nova21:11
*** baoli has quit IRC21:14
*** annegentle has quit IRC21:15
*** thangp has quit IRC21:15
*** tonytan4ever has joined #openstack-nova21:16
*** annegentle has joined #openstack-nova21:20
zigodansmith: mriedem: jgriffith just pinged and gave me this as a new patch for Cinder: https://review.openstack.org/gitweb?p=openstack%2Fcinder.git;a=commitdiff;h=51a22591a44932463847ed3247899db32ac49444 maybe the same approach could be used to fix Nova?21:21
mriedemzigo: yes, jgriffith already did that ^21:22
zigo:)21:22
mriedemzigo: feel free to push the patch for nova that mimics that :)21:22
mriedemnova meeting atm21:22
*** dboik has quit IRC21:22
zigomriedem: I'm busy finishing the Debian packages for Kilo, I have no time to do "upstream work", sorry.21:22
*** apmelton is now known as apmelton_away21:26
*** cbader has quit IRC21:26
*** jichen has quit IRC21:26
jgriffithmriedem: I'm pushing it now assuming you guys are ok with it?21:27
mriedemsure21:27
*** eharney has quit IRC21:28
openstackgerritDan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete  https://review.openstack.org/17448021:29
jgriffithmriedem: I *think* the same libs in Nova (as far as ones that take conf options)21:30
*** Nikolay_St has quit IRC21:32
*** busterswt has quit IRC21:32
openstackgerritJohn Griffith proposed openstack/nova: Add external genconfig calls  https://review.openstack.org/17699521:35
*** pixelb has joined #openstack-nova21:36
openstackgerritJohn Griffith proposed openstack/nova: Add external genconfig calls  https://review.openstack.org/17699521:36
*** Nikolay_St has joined #openstack-nova21:38
*** oro has quit IRC21:38
*** achanda has joined #openstack-nova21:41
*** thumpba_ has joined #openstack-nova21:43
mikal.21:44
*** annegentle has quit IRC21:44
*** mpaolino has joined #openstack-nova21:45
*** gyee has joined #openstack-nova21:48
*** mpaolino has quit IRC21:49
thumpba_im having an issue where vm's on the same compute cannot talk to each other21:49
thumpba_im running nova on each compute21:50
thumpba_not sure how to solve this. it started happening after the compute was rebooted21:50
*** derekh has joined #openstack-nova21:51
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/17684421:51
*** dprince has quit IRC21:53
*** matrohon has quit IRC21:55
mriedemanother wonderful nova meeting21:59
*** burt has quit IRC21:59
*** Sukhdev has quit IRC21:59
*** Nikolay_St has quit IRC21:59
bauzasmriedem: I liked the topic titles :p22:00
*** otter768 has joined #openstack-nova22:00
*** Nikolay_St has joined #openstack-nova22:00
*** joefides has quit IRC22:00
mriedemas in 0 topic titles?22:01
mriedemlast time i tried doing those i screwed it up and everyone laughed me out of the room so i gave up22:01
mriedem*sniff*22:01
*** Sukhdev has joined #openstack-nova22:01
bauzasyeah, no topics plus no actions == perfect meeting :)22:01
thumpba_im having an issue where vm's on the same compute cannot talk to each other22:01
*** johnthetubaguy is now known as zz_johnthetubagu22:01
mriedemthumpba_: see the topic of the channel please22:01
bauzasthumpba_: see $subject22:01
thumpba_thanks22:02
*** thumpba_ has left #openstack-nova22:02
bauzasmriedem: you know #undo right ? :)22:02
*** rushil has quit IRC22:02
*** Guest47750 has joined #openstack-nova22:03
mriedemno22:03
mriedemonly #startmeeting and #endmeeting22:03
mriedemmaybe #action22:03
mriedem#slap22:03
*** keekz has quit IRC22:03
mriedemcrap i have to run22:03
bauzas:)22:03
*** keekz has joined #openstack-nova22:04
*** derekh has quit IRC22:04
*** mriedem is now known as mriedem_away22:04
*** andreykurilin__ has quit IRC22:04
*** otter768 has quit IRC22:05
*** dboik has joined #openstack-nova22:06
*** lennyb has quit IRC22:06
*** dboik_ has joined #openstack-nova22:08
*** unicell1 has quit IRC22:08
*** unicell has joined #openstack-nova22:08
*** openstackstatus has quit IRC22:09
*** dboik has quit IRC22:10
*** tjones1 has quit IRC22:17
*** greghaynes has quit IRC22:18
*** pixelb has quit IRC22:22
*** browne has quit IRC22:25
*** ijw has joined #openstack-nova22:26
*** gtt116_ has joined #openstack-nova22:26
*** Nikolay_St has quit IRC22:27
*** isd1 has quit IRC22:27
openstackgerritFeodor Tersin proposed openstack/nova: Convert NetworkDuplicated to HTTPBadRequest for v2.1 API  https://review.openstack.org/17701822:27
*** Nikolay_St has joined #openstack-nova22:28
*** gtt116 has quit IRC22:29
*** jwcroppe_ has quit IRC22:30
*** browne has joined #openstack-nova22:33
*** Hosam has joined #openstack-nova22:36
*** alexpilotti has quit IRC22:36
*** signed8b_ has joined #openstack-nova22:37
*** signed8bit has quit IRC22:40
*** Guest47750 has quit IRC22:44
*** leseb has quit IRC22:45
*** leseb has joined #openstack-nova22:45
*** erlon has quit IRC22:51
*** Nikolay_St has quit IRC22:52
*** Nikolay_St has joined #openstack-nova22:53
*** Hosam has quit IRC22:59
*** ijw has quit IRC23:00
*** annashen has quit IRC23:00
*** annashen has joined #openstack-nova23:00
*** penick has quit IRC23:01
*** derekh has joined #openstack-nova23:02
*** melwitt has quit IRC23:02
*** annegentle has joined #openstack-nova23:03
*** derekh has quit IRC23:04
*** annashen has quit IRC23:05
*** joefides has joined #openstack-nova23:05
*** hemna is now known as hemnafk23:07
*** signed8b_ has quit IRC23:07
*** joefides_ has joined #openstack-nova23:08
*** ijw has joined #openstack-nova23:11
*** joefides has quit IRC23:11
*** annegentle has quit IRC23:14
*** ijw_ has joined #openstack-nova23:14
*** sdake has joined #openstack-nova23:16
*** ganso_ has quit IRC23:17
*** ijw has quit IRC23:17
*** sdake_ has quit IRC23:20
*** isd1 has joined #openstack-nova23:20
*** Nikolay_St has quit IRC23:20
*** browne has quit IRC23:20
*** Nikolay_St has joined #openstack-nova23:21
*** apuimedo has quit IRC23:22
*** angdraug has quit IRC23:24
*** signed8bit has joined #openstack-nova23:27
*** wuhg has joined #openstack-nova23:28
*** ijw_ has quit IRC23:30
jrolldansmith: I have a present for you :D23:30
jrollhttps://gist.github.com/pcsforeducation/9b79956a6057d16ed5dc23:31
jrollthis is single compute, too, no clustered compute shenanigans23:31
jrollalaski: ^ if you're curious23:31
*** ijw has joined #openstack-nova23:34
*** marun has quit IRC23:34
*** zhenguo has joined #openstack-nova23:34
*** baoli has joined #openstack-nova23:35
*** baoli has quit IRC23:37
*** baoli has joined #openstack-nova23:37
*** Marga_ has joined #openstack-nova23:38
dansmithjroll: well, it's hard to tell exactly what's going on without seeing the diff,23:39
dansmithbut are you thinking that going into the save, system_metadata is not in the list?23:39
dansmiththe changed list, that is23:39
jrolldansmith: exactly23:39
*** ZZelle_ has quit IRC23:40
dansmithjroll: and the log is between sysmeta = False and instance.save()23:41
dansmith?23:41
jrolltriple-checking23:41
*** vilobhmm12 has quit IRC23:42
jrollnope, I lied, grr23:42
jrollI'm sorry23:42
* jroll fixes23:42
*** vilobhmm1 has joined #openstack-nova23:42
dansmithokay23:43
dansmithwould be really helpful to see the diff23:43
jrollyeah, it isn't a git repo on this server, but I'll do what I can there23:43
dansmithdoes it have diff? :)23:44
jrollheh23:44
jrollI don't have a clean copy there23:45
dansmithwell, who's fault is that? :)23:45
jrollbut yeah, I'll get a diff and more logs, and file a bug if necessary23:45
jrollshhh :)23:45
dansmithfwiw,23:45
*** igordcard has quit IRC23:45
dansmithI think the next thing I would do, is log out inst.system_metadata and inst._orig_system_metadata23:45
dansmithbecause that's the logic it uses to determine if the the thing is changed23:46
jrollnod23:46
*** vilobhmm11 has joined #openstack-nova23:46
dansmithbecause maybe deallocate_for_instance is breaking something23:46
dansmithor23:46
dansmithsetting it to False there too and doing a reset_changes or something crazy like that23:46
*** Nikolay_St has quit IRC23:46
*** vilobhmm1 has quit IRC23:47
jrollyeah23:47
*** Nikolay_St has joined #openstack-nova23:47
jrollalright, thank you23:47
dansmithwe can pick it up tomorrow23:48
jrollindeed23:48
dansmithjust need to figure out how to pin it on neutron, ironic, or you (in that order) :P23:48
jrollheh23:48
*** sorrison has quit IRC23:53
*** apuimedo has joined #openstack-nova23:53
*** sorrison has joined #openstack-nova23:54
*** ijw has quit IRC23:55
*** sdake_ has joined #openstack-nova23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!