| *** dboik has quit IRC | 00:00 | |
| *** achanda has quit IRC | 00:02 | |
| *** promulo_ has joined #openstack-nova | 00:02 | |
| *** otter768 has joined #openstack-nova | 00:03 | |
| *** asettle has quit IRC | 00:03 | |
| *** promulo__ has quit IRC | 00:05 | |
| *** otter768 has quit IRC | 00:07 | |
| *** Nic1 has joined #openstack-nova | 00:14 | |
| *** deepthi has joined #openstack-nova | 00:16 | |
| *** Nic has quit IRC | 00:16 | |
| *** deepthi has quit IRC | 00:16 | |
| *** heyongli_1 has quit IRC | 00:17 | |
| *** dave-mccowan has joined #openstack-nova | 00:23 | |
| *** mtanino_ has joined #openstack-nova | 00:24 | |
| *** mtanino has quit IRC | 00:25 | |
| *** dave-mccowan has quit IRC | 00:29 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Store context in local store after spawn_n https://review.openstack.org/173112 | 00:29 |
|---|---|---|
| *** emagana has quit IRC | 00:30 | |
| *** asettle has joined #openstack-nova | 00:32 | |
| *** kmartin has quit IRC | 00:32 | |
| *** patrickeast has quit IRC | 00:33 | |
| *** ijw has quit IRC | 00:35 | |
| *** zhenguo has joined #openstack-nova | 00:39 | |
| *** ozialien has joined #openstack-nova | 00:44 | |
| *** oro has quit IRC | 00:47 | |
| *** yuntongjin has joined #openstack-nova | 00:50 | |
| *** browne has quit IRC | 00:56 | |
| *** heyongli_ has joined #openstack-nova | 00:58 | |
| *** liusheng has joined #openstack-nova | 01:01 | |
| *** ociuhandu has joined #openstack-nova | 01:08 | |
| *** eliqiao has joined #openstack-nova | 01:09 | |
| *** marun has joined #openstack-nova | 01:11 | |
| *** Nic1 has quit IRC | 01:15 | |
| *** ozialien has quit IRC | 01:19 | |
| *** baoli has joined #openstack-nova | 01:20 | |
| *** erkules_ has joined #openstack-nova | 01:21 | |
| *** erkules has quit IRC | 01:23 | |
| *** jecarey has joined #openstack-nova | 01:24 | |
| *** tjones1 has joined #openstack-nova | 01:26 | |
| *** shaohe_feng has joined #openstack-nova | 01:27 | |
| *** aysyd has quit IRC | 01:31 | |
| *** neelashah has joined #openstack-nova | 01:33 | |
| *** popw has joined #openstack-nova | 01:34 | |
| *** eliqiao1 has joined #openstack-nova | 01:36 | |
| *** eliqiao has quit IRC | 01:36 | |
| *** dsanders has quit IRC | 01:41 | |
| *** igordcard_ has quit IRC | 01:44 | |
| *** browne has joined #openstack-nova | 01:45 | |
| *** salv-orlando has joined #openstack-nova | 01:46 | |
| openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for volume-backed instance https://review.openstack.org/164494 | 01:50 |
| *** wuhg has joined #openstack-nova | 01:53 | |
| *** salv-orlando has quit IRC | 01:53 | |
| *** diegows has quit IRC | 01:54 | |
| *** baoli has quit IRC | 01:55 | |
| *** unicell has quit IRC | 01:56 | |
| *** unicell has joined #openstack-nova | 01:56 | |
| *** tjones1 has quit IRC | 01:57 | |
| *** kaisers1 has joined #openstack-nova | 01:59 | |
| *** erlon has quit IRC | 02:01 | |
| *** kaisers has quit IRC | 02:01 | |
| *** tjones1 has joined #openstack-nova | 02:01 | |
| *** baoli has joined #openstack-nova | 02:03 | |
| *** otter768 has joined #openstack-nova | 02:04 | |
| *** mtanino_ has quit IRC | 02:04 | |
| *** otter768 has quit IRC | 02:08 | |
| *** sbfox has joined #openstack-nova | 02:09 | |
| openstackgerrit | Eli Qiao proposed openstack/nova: Set power state to None when evaucate failed do to recreate not support https://review.openstack.org/173150 | 02:14 |
| *** zhangtralon has joined #openstack-nova | 02:15 | |
| *** baoli has quit IRC | 02:17 | |
| *** VW_ has joined #openstack-nova | 02:20 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: word spell mistake in nova/compute/api.py https://review.openstack.org/173151 | 02:21 |
| *** achanda has joined #openstack-nova | 02:21 | |
| *** Raildo__ has quit IRC | 02:21 | |
| *** bkopilov has quit IRC | 02:22 | |
| *** panbalag has quit IRC | 02:22 | |
| *** yamahata has quit IRC | 02:23 | |
| *** VW_ has quit IRC | 02:23 | |
| *** VW_ has joined #openstack-nova | 02:24 | |
| *** dims_ has quit IRC | 02:28 | |
| *** baoli has joined #openstack-nova | 02:28 | |
| *** asettle has quit IRC | 02:32 | |
| openstackgerrit | Lianhao Lu proposed openstack/nova: Fixed some misspellings https://review.openstack.org/173153 | 02:33 |
| *** isd has quit IRC | 02:37 | |
| *** claudiub has quit IRC | 02:41 | |
| openstackgerrit | shihanzhang proposed openstack/nova: Add config option to override url for versions https://review.openstack.org/160266 | 02:42 |
| *** oro has joined #openstack-nova | 02:43 | |
| *** sbfox has quit IRC | 02:44 | |
| openstackgerrit | zhangtralon proposed openstack/nova: DB:support for migration objects multi-statues https://review.openstack.org/169604 | 02:45 |
| *** annegentle has joined #openstack-nova | 02:46 | |
| *** DinaBelova has quit IRC | 02:48 | |
| *** DinaBelova has joined #openstack-nova | 02:48 | |
| *** unicell has quit IRC | 02:50 | |
| *** tsekiyam_ has joined #openstack-nova | 02:52 | |
| openstackgerrit | zhangtralon proposed openstack/nova: add support for muti_statuses_query from migration https://review.openstack.org/169631 | 02:53 |
| *** tsekiyama has quit IRC | 02:55 | |
| *** annegentle has quit IRC | 02:55 | |
| *** tsekiyam_ has quit IRC | 02:56 | |
| *** wolsen_ has joined #openstack-nova | 03:01 | |
| *** tjones1 has quit IRC | 03:02 | |
| *** tjones1 has joined #openstack-nova | 03:04 | |
| *** tojuvone has joined #openstack-nova | 03:05 | |
| *** dsanders has joined #openstack-nova | 03:06 | |
| *** wuhg has quit IRC | 03:06 | |
| *** mmedvede has quit IRC | 03:06 | |
| *** timello has quit IRC | 03:06 | |
| *** ndipanov has quit IRC | 03:06 | |
| *** tdurakov has quit IRC | 03:06 | |
| *** anthonyper has quit IRC | 03:06 | |
| *** L33 has quit IRC | 03:06 | |
| *** wolsen has quit IRC | 03:06 | |
| *** tristanC has quit IRC | 03:06 | |
| *** tjones1 has quit IRC | 03:12 | |
| *** tristanC has joined #openstack-nova | 03:13 | |
| *** wuhg has joined #openstack-nova | 03:13 | |
| *** mmedvede has joined #openstack-nova | 03:13 | |
| *** timello has joined #openstack-nova | 03:13 | |
| *** ndipanov has joined #openstack-nova | 03:13 | |
| *** tdurakov has joined #openstack-nova | 03:13 | |
| *** anthonyper has joined #openstack-nova | 03:13 | |
| *** L33 has joined #openstack-nova | 03:13 | |
| *** achanda has quit IRC | 03:14 | |
| *** dave-mccowan has joined #openstack-nova | 03:14 | |
| *** xyang1 has quit IRC | 03:15 | |
| *** marun has quit IRC | 03:16 | |
| *** asettle has joined #openstack-nova | 03:18 | |
| *** asettle has quit IRC | 03:19 | |
| *** asettle has joined #openstack-nova | 03:19 | |
| *** sbfox has joined #openstack-nova | 03:20 | |
| *** tjones1 has joined #openstack-nova | 03:22 | |
| openstackgerrit | Lianhao Lu proposed openstack/nova: Fixed some misspellings https://review.openstack.org/173153 | 03:25 |
| *** yamahata has joined #openstack-nova | 03:27 | |
| *** dims has joined #openstack-nova | 03:28 | |
| *** otter768 has joined #openstack-nova | 03:32 | |
| *** dims has quit IRC | 03:33 | |
| *** oro has quit IRC | 03:37 | |
| *** VW_ has quit IRC | 03:37 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: word spell mistake in nova/compute/api.py https://review.openstack.org/173151 | 03:39 |
| openstackgerrit | wangxiyuan proposed openstack/nova: word spell mistake in nova/compute/api.py https://review.openstack.org/173151 | 03:39 |
| *** jwcroppe has joined #openstack-nova | 03:41 | |
| *** dsanders has quit IRC | 03:43 | |
| *** ajayaa has joined #openstack-nova | 03:44 | |
| openstackgerrit | wangxiyuan proposed openstack/nova: word spell mistake in nova/compute/api.py https://review.openstack.org/173151 | 03:54 |
| *** jecarey has quit IRC | 03:54 | |
| openstackgerrit | wanghao proposed openstack/nova: fix 'Ignoring EndpointNotFound' error in init host https://review.openstack.org/147042 | 03:56 |
| *** sdake has joined #openstack-nova | 03:56 | |
| *** armax has quit IRC | 03:57 | |
| *** salv-orlando has joined #openstack-nova | 03:57 | |
| *** harlowja is now known as harlowja_away | 03:58 | |
| *** sdake_ has quit IRC | 03:58 | |
| *** tjones1 has quit IRC | 03:59 | |
| *** tjones1 has joined #openstack-nova | 04:01 | |
| *** bkopilov has joined #openstack-nova | 04:02 | |
| *** sdake_ has joined #openstack-nova | 04:02 | |
| *** otter768 has quit IRC | 04:03 | |
| *** salv-orlando has quit IRC | 04:04 | |
| *** sdake has quit IRC | 04:04 | |
| *** sbfox has quit IRC | 04:05 | |
| *** rajesht has joined #openstack-nova | 04:11 | |
| *** rajesht has quit IRC | 04:11 | |
| *** sbfox has joined #openstack-nova | 04:13 | |
| *** neelashah has quit IRC | 04:17 | |
| *** baoli has quit IRC | 04:19 | |
| *** ajayaa has quit IRC | 04:21 | |
| *** zhangtralon has quit IRC | 04:21 | |
| *** unicell has joined #openstack-nova | 04:23 | |
| *** krtaylor has quit IRC | 04:35 | |
| *** garyk has quit IRC | 04:37 | |
| *** dsanders has joined #openstack-nova | 04:38 | |
| *** krtaylor has joined #openstack-nova | 04:38 | |
| *** popw1 has joined #openstack-nova | 04:43 | |
| *** popw has quit IRC | 04:45 | |
| *** zhangtralon has joined #openstack-nova | 04:47 | |
| *** asettle has quit IRC | 04:50 | |
| *** asettle has joined #openstack-nova | 04:51 | |
| *** achanda has joined #openstack-nova | 04:52 | |
| *** jcoufal has joined #openstack-nova | 04:53 | |
| *** aswadr has joined #openstack-nova | 04:53 | |
| *** asettle has quit IRC | 04:53 | |
| *** asettle has joined #openstack-nova | 04:53 | |
| *** deepthi has joined #openstack-nova | 04:57 | |
| openstackgerrit | Eric Brown proposed openstack/nova: Don't raise exception on resize of 0 disk flavors https://review.openstack.org/173170 | 04:59 |
| *** _gryf|afk is now known as _gryf | 05:00 | |
| openstackgerrit | Eric Brown proposed openstack/nova: VMware: Don't raise exception on resize of 0 disk https://review.openstack.org/173170 | 05:01 |
| *** tjones1 has quit IRC | 05:06 | |
| *** aswadr has quit IRC | 05:06 | |
| *** erkules_ is now known as erkules | 05:07 | |
| *** erkules has joined #openstack-nova | 05:07 | |
| *** aswadr has joined #openstack-nova | 05:07 | |
| *** flwang1 has quit IRC | 05:08 | |
| *** ajayaa has joined #openstack-nova | 05:08 | |
| *** zhangtralon has quit IRC | 05:12 | |
| *** oomichi has joined #openstack-nova | 05:13 | |
| *** ishant has joined #openstack-nova | 05:14 | |
| openstackgerrit | shihanzhang proposed openstack/nova: Add config option to override url for versions https://review.openstack.org/160266 | 05:16 |
| *** gmann has quit IRC | 05:17 | |
| *** gmann has joined #openstack-nova | 05:18 | |
| *** tjones1 has joined #openstack-nova | 05:19 | |
| *** welldannit has quit IRC | 05:19 | |
| *** tjones1 has quit IRC | 05:20 | |
| *** oro has joined #openstack-nova | 05:22 | |
| *** salv-orlando has joined #openstack-nova | 05:23 | |
| *** tjones1 has joined #openstack-nova | 05:23 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add min/max of API microversions to version API https://review.openstack.org/172856 | 05:24 |
| oomichi | alex_xu: hi | 05:25 |
| alex_xu | oomichi: hi | 05:25 |
| oomichi | alex_xu: thanks for reviewing https://review.openstack.org/172856 :) | 05:25 |
| oomichi | alex_xu: that seems important for microversion | 05:26 |
| alex_xu | oomichi: yea, thanks for the explain, just know already wrote in spec | 05:26 |
| oomichi | alex_xu: clients cannot know what microversion specify. | 05:26 |
| oomichi | alex_xu: is it ok for you? | 05:26 |
| alex_xu | oomichi: yes, I'm thinking of that case also | 05:26 |
| oomichi | alex_xu: thanks, but we need to wait for jenkins job | 05:27 |
| alex_xu | oomichi: just think about we version always return two items, one for v2, another one for v2.1 | 05:27 |
| oomichi | alex_xu: yeah, right. | 05:27 |
| alex_xu | oomichi: and there 'v2.1' is special one | 05:27 |
| oomichi | alex_xu: nice point. | 05:28 |
| oomichi | alex_xu: so I felt it was enough to add "version" and "min_version" to "v2.1" only. | 05:28 |
| oomichi | alex_xu: but that seemed inconsistent for "version" API. | 05:29 |
| oomichi | alex_xu: and current patch adds the parameters to both APIs. | 05:29 |
| *** Mike_D_laptop has joined #openstack-nova | 05:29 | |
| oomichi | alex_xu: but I still have this concern now.. | 05:29 |
| alex_xu | oomichi: emm.... looks like we need a note resolve user's confuse | 05:29 |
| *** salv-orlando has quit IRC | 05:30 | |
| alex_xu | oomichi: can we just list as {version: [{id: v2.1...}, {id:v2.2..}, ...]} | 05:30 |
| alex_xu | oomichi: and is there any plan for version info in your json-home? | 05:31 |
| oomichi | alex_xu: but after v2.100, version API needs to return 100 microversions list | 05:31 |
| oomichi | alex_xu: that seems not good, and current patch is based on the spec. | 05:32 |
| *** ociuhandu has quit IRC | 05:32 | |
| alex_xu | oomichi: emm..., that's problem also :( | 05:32 |
| *** Mike_D_laptop has quit IRC | 05:32 | |
| alex_xu | oomichi: another way as I know and also used by ironic is return http header about the version info when the requested version didn't support | 05:33 |
| oomichi | alex_xu: json-home just covers API URIs. microvresions don't change API URIs, so json-home cannot cover what is available microversions. | 05:33 |
| *** sahid has joined #openstack-nova | 05:33 | |
| alex_xu | oomichi: and I register a bug for it https://bugs.launchpad.net/nova/+bug/1443494 | 05:33 |
| openstack | Launchpad bug 1443494 in OpenStack Compute (nova) "Return supported micro-version by http headers when request with invalid micro-version" [Undecided,In progress] - Assigned to Alex Xu (xuhj) | 05:33 |
| *** rushiagr_away is now known as rushiagr | 05:33 | |
| alex_xu | oomichi: what means for 'covers API URIs'? | 05:34 |
| oomichi | alex_xu: API URIs means API resources or something like "/v2/{tenant-id}/servers" | 05:35 |
| alex_xu | oomichi: ok, probably know what mean now | 05:35 |
| alex_xu | oomichi: I will try think about more if there is better way resolve this confuse | 05:36 |
| oomichi | alex_xu: json-home just provides available API URIs, but we need to expose available microversions now. | 05:36 |
| oomichi | alex_xu: so we cannot use json-home for this problem. | 05:36 |
| alex_xu | oomichi: ok | 05:36 |
| *** tjones1 has quit IRC | 05:37 | |
| alex_xu | oomichi: which line talk about verison api in http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/v2-on-v3-api.html? | 05:37 |
| alex_xu | oomichi: oops, sorry I know now | 05:37 |
| *** zhangtralon has joined #openstack-nova | 05:37 | |
| openstackgerrit | zhangtralon proposed openstack/nova: resize-revert can break anti-affinity policy https://review.openstack.org/160110 | 05:37 |
| oomichi | alex_xu: I have another concern about this problem. | 05:38 |
| oomichi | alex_xu: we have added an extension for API changes as API change manner. | 05:38 |
| *** tjones1 has joined #openstack-nova | 05:39 | |
| oomichi | alex_xu: but current patch doesn't add an extension even if adding new parameters "version" and "min_version". | 05:39 |
| *** salv-orlando has joined #openstack-nova | 05:39 | |
| alex_xu | oomichi: you mean for v2? | 05:40 |
| oomichi | alex_xu: version API is independent from v2 and v2.1 | 05:40 |
| *** Nikolay_1t has quit IRC | 05:40 | |
| oomichi | alex_xu: because the API URI is just "/" without "/v2" and "/v2.1" | 05:41 |
| alex_xu | oomichi: so why we need add an extension for add new parameters? | 05:41 |
| oomichi | alex_xu: ah, nice point. really thanks! | 05:41 |
| oomichi | alex_xu: I will write the reason why the patch doesn't add a new extension on the commit message :) | 05:42 |
| alex_xu | oomichi: np, cool :) | 05:42 |
| alex_xu | oomichi: what would you think about return http header for microversion? | 05:42 |
| *** unicell1 has joined #openstack-nova | 05:42 | |
| oomichi | alex_xu: from http://docs-draft.openstack.org/71/172771/3/check/gate-nova-specs-docs/8f6dc33//doc/build/html/specs/kilo/implemented/api-microversions.html | 05:43 |
| oomichi | alex_xu: the response should include "X-OpenStack-Nova-API-Version: version_number, experimental Vary: X-OpenStack-Nova-API-Version" | 05:44 |
| *** unicell has quit IRC | 05:44 | |
| alex_xu | oomichi: but that didn't include max and min version | 05:45 |
| oomichi | alex_xu: yeah, I feel it is enough to used microversion only in the header. | 05:45 |
| oomichi | alex_xu: yeah, I feel it is enough to include the used microversion only in the header. | 05:46 |
| alex_xu | oomichi: ok, if we have version api, the header didn't very usefule | 05:46 |
| *** nkrinner has joined #openstack-nova | 05:46 | |
| alex_xu | s/usefule/useful | 05:47 |
| oomichi | alex_xu: and API change is very important and we need bp/spec for the changes. | 05:48 |
| oomichi | alex_xu: so at this time, we need to change version API based on the approved nova-spec. | 05:48 |
| alex_xu | oomichi: ok | 05:49 |
| *** salv-orlando has quit IRC | 05:50 | |
| alex_xu | oomichi: should we back port this patch? | 05:52 |
| oomichi | alex_xu: yeah, I think so. this patch is very important for microversion users. | 05:52 |
| alex_xu | oomichi: ok cool | 05:53 |
| *** Longgeek has joined #openstack-nova | 05:53 | |
| *** salv-orlando has joined #openstack-nova | 05:53 | |
| *** tjones1 has quit IRC | 05:54 | |
| *** dsanders has quit IRC | 05:56 | |
| *** popw1 has quit IRC | 05:56 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add min/max of API microversions to version API https://review.openstack.org/172856 | 05:56 |
| *** tjones1 has joined #openstack-nova | 05:58 | |
| *** yamahata has quit IRC | 05:58 | |
| *** yamahata has joined #openstack-nova | 05:59 | |
| *** salv-orlando has quit IRC | 06:00 | |
| alex_xu | oomichi: another question, should we change api sample file when microversion bump eachtime? | 06:01 |
| alex_xu | oomichi: or we should just fake a version in the api sample test? | 06:01 |
| alex_xu | oomichi: I mean this sample file https://review.openstack.org/#/c/172856/4/nova/tests/functional/api_samples/versions/versions-get-resp.json.tpl | 06:02 |
| *** asettle has quit IRC | 06:03 | |
| openstackgerrit | yuntongjin proposed openstack/nova: Add missing policy for limits extention https://review.openstack.org/173178 | 06:04 |
| *** otter768 has joined #openstack-nova | 06:04 | |
| *** garyk has joined #openstack-nova | 06:05 | |
| *** doron_ has joined #openstack-nova | 06:07 | |
| *** doron_ is now known as doron_afk | 06:07 | |
| *** otter768 has quit IRC | 06:09 | |
| *** hdd has joined #openstack-nova | 06:10 | |
| *** tojuvone has quit IRC | 06:10 | |
| *** devananda has quit IRC | 06:10 | |
| *** sahid has quit IRC | 06:10 | |
| *** _gryf has quit IRC | 06:11 | |
| *** zhangtralon has quit IRC | 06:11 | |
| *** krtaylor has quit IRC | 06:11 | |
| *** _gryf has joined #openstack-nova | 06:11 | |
| oomichi | alex_xu: sorry, I am back. | 06:13 |
| alex_xu | oomichi: np | 06:13 |
| oomichi | alex_xu: I think we need to change "version" api sample file when microversion bump eachtime. | 06:13 |
| oomichi | alex_xu: because the sample file should show current microversion as the sample. | 06:14 |
| oomichi | alex_xu: your concern is that the patch will be big when microversion bump, right? | 06:15 |
| alex_xu | oomichi: yea, just need update every time | 06:15 |
| alex_xu | oomichi: but I think what you said is make sense, update it each time won't be too much extra work | 06:16 |
| oomichi | alex_xu: yeah, maybe the review will be easy for that because the same change pattern for every microversion :) | 06:16 |
| alex_xu | oomichi: ok, got it, thanks for the explain :) | 06:17 |
| *** devananda has joined #openstack-nova | 06:17 | |
| *** doron_afk is now known as doron_ | 06:17 | |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix empty instance nw_info cache https://review.openstack.org/146036 | 06:17 |
| oomichi | alex_xu: np, and thank you also for nice points :-) | 06:17 |
| alex_xu | oomichi: np | 06:17 |
| *** apuimedo has joined #openstack-nova | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/171943 | 06:18 |
| openstackgerrit | wangxiyuan proposed openstack/nova: word spell mistake in nova/compute/api.py https://review.openstack.org/173151 | 06:20 |
| *** ankit_ag has joined #openstack-nova | 06:20 | |
| *** krtaylor has joined #openstack-nova | 06:22 | |
| chaochin | garyk: Hi Gary | 06:27 |
| chaochin | garyk: I am testing ephemeral disk, and notice that vmware driver does not create filesystem in the ephemeral disk | 06:29 |
| openstackgerrit | Juliane Aulbach proposed openstack/nova: Change config drive attachement from virtio-scsi to virtio-blk. https://review.openstack.org/173184 | 06:29 |
| chaochin | garyk: after I input guest_format=ext3 into block_device_mapping_v2 and boot the VM, I can not mount that disk in guest OS | 06:30 |
| chaochin | garyk: Is that a limitition of VCenter? Or you plan to implement that in your next step? | 06:31 |
| openstackgerrit | wanghao proposed openstack/nova: Nova can't detach volume in init host routine https://review.openstack.org/147042 | 06:31 |
| *** TobiasE has joined #openstack-nova | 06:32 | |
| *** jwcroppe has quit IRC | 06:32 | |
| *** zhangtralon has joined #openstack-nova | 06:32 | |
| *** Marga_ has quit IRC | 06:33 | |
| garyk | chaochin: the guest should be responsible to do that | 06:33 |
| openstackgerrit | Yongli He proposed openstack/nova: resource tracker style pci resource management https://review.openstack.org/131321 | 06:33 |
| *** jwcroppe_ has joined #openstack-nova | 06:33 | |
| chaochin | garyk: but libvirt driver can read guest_format, and create the filesystem for the guest OS. Is that technically doable for VMware? | 06:35 |
| *** zhangtralon has quit IRC | 06:35 | |
| garyk | chaochin: i will check - do you have vmware tools installed on your guest? | 06:36 |
| *** jwcroppe_ has quit IRC | 06:38 | |
| chaochin | garyk: my image does not have vmware tool installed. What libvirt driver does is to create a file, and run mkfs against that file before attaching it to guest os. | 06:38 |
| chaochin | garyk: will we do it in that way for VCenter? | 06:39 |
| *** doron_ is now known as doron_afk | 06:39 | |
| garyk | chaochin: if you look at the settings then you will see that a new disk has been created for the ephemeral disk | 06:39 |
| garyk | from your gues you should be able to see the disk and configure it - similar to the way that you would have worked if it was a cinder volume | 06:40 |
| chaochin | garyk: yes. I can see the new disk, and can create FS by myself in the guest os. | 06:40 |
| chaochin | garyk: just hope to make sure if we can make guest_format parameter in api request to take effect for vmware driver. | 06:41 |
| garyk | chaochin: i am not sure that is the right way to go. i will invetigate | 06:42 |
| chaochin | garyk: ok, thank you! | 06:43 |
| openstackgerrit | zhangtralon proposed openstack/nova: Change the reboot rpc call to local during init_host https://review.openstack.org/170110 | 06:43 |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning https://review.openstack.org/173187 | 06:48 |
| garyk | ttx: are you around? | 06:49 |
| *** park_heijlong has joined #openstack-nova | 06:50 | |
| *** sudipto has joined #openstack-nova | 06:51 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning https://review.openstack.org/173187 | 06:52 |
| openstackgerrit | Mike Durnosvistov proposed openstack/nova: libvirt: Decomposition plug methods in vif https://review.openstack.org/148719 | 06:55 |
| *** tojuvone has joined #openstack-nova | 06:58 | |
| *** dave-mccowan has quit IRC | 06:58 | |
| *** tjones1 has quit IRC | 06:59 | |
| *** andreykurilin has joined #openstack-nova | 07:00 | |
| ttx | garyk: yes | 07:01 |
| *** jamielennox is now known as jamielennox|away | 07:02 | |
| openstackgerrit | Li Yingjun proposed openstack/nova: Validate maximum limit for quota https://review.openstack.org/165069 | 07:02 |
| garyk | ttx: sorted thanks! | 07:02 |
| ttx | cool :) | 07:02 |
| *** sahid has joined #openstack-nova | 07:03 | |
| *** tjones1 has joined #openstack-nova | 07:06 | |
| *** pask81 has joined #openstack-nova | 07:06 | |
| *** hdd has quit IRC | 07:07 | |
| *** hdd has joined #openstack-nova | 07:08 | |
| *** lpetrut has joined #openstack-nova | 07:08 | |
| garyk | ttx: i am sure that i will need to pick your brain when we go from the proposed to stable :) | 07:10 |
| ttx | heh, not that hard actually. Documented at https://wiki.openstack.org/wiki/Release_Team/How_To_Release | 07:12 |
| *** andreykurilin has quit IRC | 07:13 | |
| openstackgerrit | Juliane Aulbach proposed openstack/nova: Change config drive attachement from virtio-scsi to virtio-blk. https://review.openstack.org/173184 | 07:13 |
| *** irenab has joined #openstack-nova | 07:17 | |
| *** Maike has joined #openstack-nova | 07:18 | |
| *** sbfox has quit IRC | 07:20 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server personality tests between v2 and v2.1 https://review.openstack.org/173196 | 07:22 |
| *** arnaud___ has joined #openstack-nova | 07:23 | |
| *** ildikov has joined #openstack-nova | 07:24 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix quota-update when nova-compute startup finish https://review.openstack.org/170118 | 07:26 |
| *** achanda has quit IRC | 07:26 | |
| *** jichen has joined #openstack-nova | 07:27 | |
| *** dsanders has joined #openstack-nova | 07:27 | |
| *** mpaolino has joined #openstack-nova | 07:27 | |
| *** rajesht has joined #openstack-nova | 07:27 | |
| *** jistr has joined #openstack-nova | 07:29 | |
| rajesht | jogo: you around ? | 07:29 |
| rajesht | jogo: I have submitted patch for quota update issue on nova-compute restart | 07:29 |
| rajesht | jogo: you can give your suggestions: | 07:29 |
| rajesht | jogo: [1] https://review.openstack.org/#/c/122347 | 07:30 |
| rajesht | jogo: [2] https://review.openstack.org/#/c/170118/ | 07:30 |
| *** yamahata has quit IRC | 07:30 | |
| *** park_heijlong has quit IRC | 07:30 | |
| *** dulek has joined #openstack-nova | 07:36 | |
| *** ndipanov has quit IRC | 07:41 | |
| *** romainh has joined #openstack-nova | 07:42 | |
| *** ndipanov has joined #openstack-nova | 07:42 | |
| *** jlanoux has joined #openstack-nova | 07:43 | |
| *** markus_z has joined #openstack-nova | 07:44 | |
| *** park_heijlong has joined #openstack-nova | 07:44 | |
| *** eglynn has joined #openstack-nova | 07:49 | |
| *** oro has quit IRC | 07:49 | |
| *** browne has quit IRC | 07:50 | |
| *** park_heijlong has quit IRC | 07:55 | |
| *** oro has joined #openstack-nova | 07:57 | |
| *** wuhg has quit IRC | 07:59 | |
| *** otter768 has joined #openstack-nova | 08:05 | |
| *** jcoufal_ has joined #openstack-nova | 08:06 | |
| *** tdurakov has quit IRC | 08:06 | |
| *** dims has joined #openstack-nova | 08:07 | |
| *** park_heijlong has joined #openstack-nova | 08:07 | |
| *** dulek has quit IRC | 08:08 | |
| *** dsanders has quit IRC | 08:08 | |
| *** jcoufal has quit IRC | 08:09 | |
| *** otter768 has quit IRC | 08:10 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Do not specify default security group to Neutron by default https://review.openstack.org/173204 | 08:10 |
| *** derekh has joined #openstack-nova | 08:10 | |
| *** BobBall_AWOL is now known as BobBall | 08:11 | |
| BobBall | mriedem_away: There was a new race condition introduced in test_snapshot_pattern which seems to be hitting it quite hard. We've not understood it yet. | 08:11 |
| *** zz_johnthetubagu is now known as johnthetubaguy | 08:11 | |
| *** dims has quit IRC | 08:12 | |
| BobBall | mriedem_away: Am considering disabling that test in our CI to get it back up and running, but have resisted so far | 08:12 |
| *** gszasz has joined #openstack-nova | 08:14 | |
| *** oro has quit IRC | 08:17 | |
| *** gszasz has quit IRC | 08:18 | |
| *** doron_afk is now known as doron_ | 08:19 | |
| *** gszasz has joined #openstack-nova | 08:19 | |
| *** ujjain has joined #openstack-nova | 08:20 | |
| *** pixelb has joined #openstack-nova | 08:21 | |
| *** sdake has joined #openstack-nova | 08:22 | |
| *** gszasz has quit IRC | 08:23 | |
| *** gszasz has joined #openstack-nova | 08:23 | |
| *** lucasagomes has joined #openstack-nova | 08:26 | |
| *** arnaud___ has quit IRC | 08:26 | |
| *** sdake_ has quit IRC | 08:26 | |
| *** ildikov has quit IRC | 08:27 | |
| openstackgerrit | wanghao proposed openstack/nova: Allow bdm boot_index=1 when creating vm from image https://review.openstack.org/171984 | 08:29 |
| openstackgerrit | Oleg Bondarev proposed openstack/nova: Log a warning if sec-groups and port id are provided on boot https://review.openstack.org/154068 | 08:30 |
| openstackgerrit | Oleg Bondarev proposed openstack/nova: Log a warning if sec-groups and port id are provided on boot https://review.openstack.org/154068 | 08:30 |
| *** sdake has quit IRC | 08:30 | |
| heyongli_ | ndipanov: patch updated accorrding discuss :) | 08:32 |
| *** Nikolay_St has joined #openstack-nova | 08:32 | |
| openstackgerrit | yuntongjin proposed openstack/nova: Add missing policy for extension_info in API https://review.openstack.org/173210 | 08:32 |
| *** eliqiao1 has quit IRC | 08:32 | |
| *** dulek has joined #openstack-nova | 08:32 | |
| *** yuntongjin has quit IRC | 08:33 | |
| *** heyongli_ has quit IRC | 08:33 | |
| openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning https://review.openstack.org/173187 | 08:34 |
| *** heyongli_ has joined #openstack-nova | 08:34 | |
| *** shaohe_feng has quit IRC | 08:35 | |
| *** oro has joined #openstack-nova | 08:36 | |
| ndipanov | heyongli_, awesome - will take a look | 08:36 |
| *** gszasz has quit IRC | 08:36 | |
| *** gszasz has joined #openstack-nova | 08:36 | |
| openstackgerrit | Lianhao Lu proposed openstack/nova: Convert timestamp string in bandwidth_usage object https://review.openstack.org/173213 | 08:36 |
| *** heyongli_ has quit IRC | 08:37 | |
| *** heyongli_1 has joined #openstack-nova | 08:37 | |
| *** oro has quit IRC | 08:45 | |
| *** heyongli_1 has quit IRC | 08:46 | |
| *** heyongli_ has joined #openstack-nova | 08:46 | |
| *** marun has joined #openstack-nova | 08:46 | |
| *** lpetrut has quit IRC | 08:47 | |
| oomichi | mikal, johnthetubaguy: hi | 08:48 |
| johnthetubaguy | oomichi: hi, hows things? | 08:48 |
| oomichi | johnthetubaguy: I found a problem on api microversions, can you take time for it? | 08:49 |
| *** ujjain has quit IRC | 08:49 | |
| johnthetubaguy | oomichi: possibly, whats up? | 08:49 |
| oomichi | johnthetubaguy: thanks. now we don't have the way to notify available microversions to clients. | 08:50 |
| *** ujjain has joined #openstack-nova | 08:50 | |
| openstackgerrit | heijlong proposed openstack/nova: Merge extended-volume functional tests of v2 and v2.1 https://review.openstack.org/173216 | 08:50 |
| *** lpetrut has joined #openstack-nova | 08:50 | |
| oomichi | johnthetubaguy: the way is described on the nova-spec, but it is not done yet. | 08:50 |
| johnthetubaguy | oomichi: ah, did we not get that implemented… I know there was talk that | 08:50 |
| oomichi | johnthetubaguy: yeah, https://review.openstack.org/#/c/172856/ is for fixing it. | 08:50 |
| johnthetubaguy | oomichi: OK, so python-novaclient needs that I guess | 08:50 |
| oomichi | johnthetubaguy: yes, right. novaclient also needs it. | 08:51 |
| *** marun has quit IRC | 08:51 | |
| johnthetubaguy | oomichi: OK, I marked it critical, lets get this into RC2 | 08:51 |
| *** pkoniszewski has joined #openstack-nova | 08:51 | |
| oomichi | johnthetubaguy: that is basic/important part of microversions. | 08:51 |
| johnthetubaguy | oomichi: agreed | 08:51 |
| oomichi | johnthetubaguy: that is great, thanks :) | 08:51 |
| gilliard | oomichi: do you have any reviews? | 08:52 |
| gilliard | oomichi: I am sure I saw something about it on the ML | 08:52 |
| oomichi | gilliard: https://review.openstack.org/#/c/172856/ is that | 08:52 |
| *** aix has quit IRC | 08:53 | |
| johnthetubaguy | oomichi: question about the min version | 08:54 |
| johnthetubaguy | oomichi: maybe it should be "" | 08:54 |
| johnthetubaguy | oomichi: given v2.1 currently accepts requests with no version | 08:54 |
| *** heyongli_ has quit IRC | 08:54 | |
| gilliard | oomichi: I was thinking of http://lists.openstack.org/pipermail/openstack-dev/2015-April/061183.html | 08:54 |
| ndipanov | johnthetubaguy, so kilo backport potential gets cherry-picked to a branch or? how does that work | 08:55 |
| oomichi | johnthetubaguy: yes, right. client can use v2.1 without specifying a microversion, and nova works as v2 default behavior | 08:55 |
| johnthetubaguy | ndipanov: after we ship, if it didn't make it into an RC we get those backported onto the stable branch | 08:55 |
| johnthetubaguy | oomichi: but how should the min_version report that? | 08:56 |
| *** park_heijlong has quit IRC | 08:56 | |
| johnthetubaguy | oomichi: one day we might not allow those requests, I guess | 08:56 |
| ndipanov | johnthetubaguy, ah no I meant - how to get it into RC | 08:56 |
| ndipanov | johnthetubaguy, when the time rolls around - we just decide on a meeting? | 08:56 |
| johnthetubaguy | ndipanov: to get it into RC, you need the kilo-rc-potential tag | 08:56 |
| johnthetubaguy | baically thiery makes the final call on what could get in there | 08:57 |
| *** ujjain has quit IRC | 08:57 | |
| johnthetubaguy | ndipanov: I think we just backport into this branch to get it into the RC: https://github.com/openstack/nova/tree/proposed/kilo | 08:57 |
| oomichi | johnthetubaguy: you mean when raising microversions(v2.10, etc), nova should deny requrest without microversion? | 08:57 |
| johnthetubaguy | oomichi: no | 08:57 |
| ndipanov | right ok let me make sure that the stuff I am interested in (2) is tagged then | 08:57 |
| johnthetubaguy | oomichi: it might want to do that in the future | 08:58 |
| johnthetubaguy | ndipanov: be clear to explain the impact in the bug, to make sure its clear, probably good to get the changes up for the backport as well, to save time | 08:58 |
| ndipanov | johnthetubaguy, right - makes sense | 08:59 |
| ndipanov | will do | 08:59 |
| bauzas | johnthetubaguy: morning | 09:00 |
| oomichi | gilliard: thanks for the point. I missed it, will reply to it. | 09:00 |
| bauzas | johnthetubaguy: I'm reviewing all the stuff needing to be targeted for Liberty re: sched | 09:01 |
| bauzas | johnthetubaguy: a couple of proposals are in https://etherpad.openstack.org/p/liberty-nova-summit-ideas L50 and below | 09:01 |
| bauzas | johnthetubaguy: wrt that, I'm planning to work on https://blueprints.launchpad.net/nova/+spec/allocation-ratio-to-resource-tracker | 09:01 |
| bauzas | johnthetubaguy: the spec was approved for Juno, could we target the bp as a series goal for Liberty ? | 09:02 |
| bauzas | johnthetubaguy: I'll repropose the specs for all the bps I mentioned, as I don't exactly know jaypipes's support for Liberty | 09:03 |
| johnthetubaguy | ndipanov: as a heads up the current plan is to cut RC2 on friday, after talking about it in the nova meeting | 09:04 |
| *** frickler_ is now known as frickler | 09:06 | |
| johnthetubaguy | bauzas: the main thing is you need a spec merged for liberty, but I can fast approve that, if you add previous-approved in the commit message, and ping me on here | 09:07 |
| bauzas | johnthetubaguy: sure, that's my next steps | 09:07 |
| johnthetubaguy | bauzas: cool, thanks | 09:07 |
| bauzas | johnthetubaguy: do you have any idea on if jay will have some commitment time by L N | 09:08 |
| bauzas | ? | 09:08 |
| bauzas | johnthetubaguy: I totally understand he's just overbusy | 09:08 |
| ndipanov | johnthetubaguy, ok that makes sense | 09:08 |
| johnthetubaguy | bauzas: I have no idea, whats L N? | 09:10 |
| johnthetubaguy | ndipanov: same as last time, is the summary, basically | 09:11 |
| ndipanov | I think it's L (french keyboard questionmark key) :D | 09:11 |
| bauzas | johnthetubaguy: my bad, "L ?" ie. 'Liberty ?' | 09:11 |
| bauzas | ndipanov: well it's more that I have fat fingers... | 09:11 |
| bauzas | ndipanov: it's not chilling today, sunny but I'm still typing with gloves | 09:11 |
| *** ildikov has joined #openstack-nova | 09:12 | |
| johnthetubaguy | bauzas: your guess is a good as mine, I suspect | 09:13 |
| ndipanov | bauzas, some backports to warm you up https://review.openstack.org/#/c/173225/ | 09:13 |
| bauzas | ndipanov: cool | 09:13 |
| ndipanov | I had to work around your service migration thing so would be good for you to ack it | 09:13 |
| bauzas | ndipanov: woah, I love them both | 09:13 |
| bauzas | ndipanov: okay, will look into them | 09:14 |
| ndipanov | PaulMurray, ^^ | 09:14 |
| ndipanov | if you could take a look it would be awesome | 09:14 |
| *** mpavone has joined #openstack-nova | 09:14 | |
| oomichi | alex_xu: hi, I'd like to know your point on https://review.openstack.org/#/c/172771/ | 09:15 |
| *** pkoniszewski has quit IRC | 09:16 | |
| *** TobiasE1 has joined #openstack-nova | 09:16 | |
| *** TobiasE has quit IRC | 09:17 | |
| *** asrangne has joined #openstack-nova | 09:18 | |
| *** aswadr has quit IRC | 09:18 | |
| johnthetubaguy | oomichi: thats probably mostly my fault, we can't deploy v2.1 at rackspace because of the fear it will break too many clients, we need a way to answer that question, or reduce the impact | 09:20 |
| *** aix has joined #openstack-nova | 09:20 | |
| johnthetubaguy | oomichi: talking with alex_xu we are thinking about relaxing additional properties checks when API calls don't have a version in them, and go into v2.1 | 09:21 |
| johnthetubaguy | oomichi: that should get us the best of both worlds, although as alex_xu points out, there are still other things that could cause problems, but I am OK with that | 09:21 |
| johnthetubaguy | oomichi: so rather than error out, I would want our code to just drop the attributes that are not expected before passing the user request to the API code | 09:22 |
| johnthetubaguy | but if there is a version specified, we error out with bad request, as planned | 09:22 |
| *** ujjain has joined #openstack-nova | 09:23 | |
| oomichi | johnthetubaguy: interesting, is it fine to have an option for disabling additional properties checks ? | 09:23 |
| johnthetubaguy | oomichi: no | 09:24 |
| PaulMurray | ndipanov, will do | 09:24 |
| johnthetubaguy | oomichi: reason why, I want the API to be the same for everyone when you use v2.1 | 09:24 |
| johnthetubaguy | oomichi: except for policy | 09:25 |
| oomichi | johnthetubaguy: ah, I see. when a client pass microversion, additional properties checks will work. | 09:25 |
| johnthetubaguy | oomichi: right | 09:25 |
| oomichi | johnthetubaguy: maybe it is possible, but we need time for bp/spec but it would be helpful for real world | 09:26 |
| johnthetubaguy | oomichi: I want to deprecate v2.0 at the end of liberty, so we can rip out that code when M opens | 09:26 |
| johnthetubaguy | oomichi: if we can get agreement, I can try get hands on keyboards to help with it, as it should help our adoption of v2.1 | 09:27 |
| oomichi | johnthetubaguy: ok, will write bp/spec for Liberty. | 09:28 |
| *** jlanoux_ has joined #openstack-nova | 09:28 | |
| *** TobiasE1 has quit IRC | 09:30 | |
| johnthetubaguy | oomichi: I can do that if it helps free you up for other things? | 09:30 |
| *** jlanoux has quit IRC | 09:30 | |
| *** TobiasE has joined #openstack-nova | 09:32 | |
| *** doron_ is now known as doron_afk | 09:33 | |
| *** jwcroppe has joined #openstack-nova | 09:34 | |
| gilliard | oomichi: johnthetubaguy: Do you plan for a future change to make requests-without-a-version illegal? | 09:35 |
| johnthetubaguy | gilliard: I think we need to have the option of doing that, honestly, I can't see it happening for years | 09:36 |
| gilliard | OK, so I'm +1 on oomichi's patch then. | 09:36 |
| oomichi | gilliard: I feel requests-without-a-version is fine forever. | 09:36 |
| gilliard | It would be a breaking change which could not be covered with a microversion increment... | 09:36 |
| johnthetubaguy | oomichi: OK, but does that mean it never makes sense to raise the min microversion, that seems very imilar | 09:37 |
| oomichi | gilliard: nova just work on min microversion as the default behavior at the time. | 09:37 |
| *** jlanoux has joined #openstack-nova | 09:37 | |
| PaulMurray | ndipanov, I think there is a missing decorator in https://review.openstack.org/#/c/173225/1/nova/tests/pci/test_pci_manager.py | 09:37 |
| johnthetubaguy | oomichi: I am wondering if the current min_version = "" for v2.1, so its consistent with v2.0 | 09:37 |
| johnthetubaguy | but that links the two together in a bad way | 09:38 |
| oomichi | johnthetubaguy: yeah, that is a point when we need to raises min microversion. I guess it is very difficult.. | 09:38 |
| *** jwcroppe has quit IRC | 09:38 | |
| ndipanov | PaulMurray, hmm you are right but tests did seem to pass for me which should not have happened... | 09:38 |
| ndipanov | good catch! | 09:39 |
| johnthetubaguy | oomichi: honestly, its almost going to be never, due to the same arguments | 09:39 |
| bauzas | ndipanov: the tests didn't fail ? | 09:40 |
| oomichi | johnthetubaguy: ah, your previous request(relax validation) would make the version info difficult.. | 09:40 |
| ndipanov | bauzas, I think so... | 09:40 |
| bauzas | ndipanov: it should, because the signature is different, nope ? | 09:40 |
| ndipanov | right | 09:40 |
| ndipanov | weird - well jenkins will tell us soon | 09:40 |
| bauzas | ndipanov: I missed that, my bad | 09:40 |
| *** jlanoux_ has quit IRC | 09:40 | |
| ndipanov | anyway - go look at the next one too | 09:40 |
| oomichi | johnthetubaguy: on the request, the behaviors will be different between specifying "2.1" and non-specifying. | 09:40 |
| oomichi | johnthetubaguy: when client specifying "2.1", I think additional-properties check should work. but if not specifying any microversion, the check will not work. | 09:42 |
| johnthetubaguy | oomichi: right | 09:42 |
| johnthetubaguy | oomichi: shall I write up the spec for this, so its clearer? | 09:43 |
| oomichi | johnthetubaguy: so min_version meaning will be changed. | 09:43 |
| bauzas | ndipanov: I left a comment on the next patch | 09:43 |
| johnthetubaguy | oomichi: in a way, yes I guess it is | 09:43 |
| ndipanov | bauzas, awesome - will look into it | 09:43 |
| oomichi | johnthetubaguy: yeah, that is nice :) | 09:43 |
| rajesht | johnthetubaguy: hi, | 09:43 |
| bauzas | ndipanov: basically, except the minor miss you did, I'm OK but I'm concerned by the test coverage | 09:43 |
| ndipanov | bauzas, thanks a lot | 09:43 |
| johnthetubaguy | rajesht: hello | 09:43 |
| rajesht | johnthetubaguy: I have submitted quota update patch, please give your suggestion whenever you get time | 09:44 |
| bauzas | ndipanov: so I was asking for lxsli's help | 09:44 |
| *** ZZelle has quit IRC | 09:44 | |
| rajesht | johnthetubaguy: thanks :) | 09:44 |
| sudipto | bauzas, Hello, whenever you have time - https://review.openstack.org/#/c/173187/ could you please provide your thoughts | 09:44 |
| bauzas | ndipanov: as he was deeply involved in the test refactoring | 09:44 |
| *** eglynn has quit IRC | 09:44 | |
| johnthetubaguy | rajesht: whats the patch? | 09:44 |
| rajesht | johnthetubaguy: https://review.openstack.org/#/c/170118/ | 09:44 |
| *** ZZelle has joined #openstack-nova | 09:44 | |
| bauzas | sudipto: ack, CC'ing me | 09:44 |
| *** doron_afk has quit IRC | 09:44 | |
| johnthetubaguy | rajesht: OK, I am slammed with release stuff right now, so not totally sure when that will be, but thanks for the heads up | 09:44 |
| *** moshele has joined #openstack-nova | 09:45 | |
| sudipto | bauzas, thanks! | 09:45 |
| rajesht | johnthetubaguy: updating quota for instance which are stuck in deleting task_state on compute start-up | 09:45 |
| rajesht | johnthetubaguy: np, will wait for community suggestions | 09:46 |
| openstackgerrit | Abhijeet Malawade proposed openstack/nova: log request-id mapping of nova and cinder https://review.openstack.org/173234 | 09:46 |
| johnthetubaguy | rajesht: not sure only doing things in the start up task are a good idea, but its better than never, I should read the patch | 09:50 |
| sudipto | PaulMurray, I have a concern on object versions in Nova and hence wanted to get your thoughts. I saw that currently there isn't a great way to determine whether your nova-compute process is of a different release than your controller instance, unless you implicitly know what those IncompatibleObjectVersion...Is there a reason for such versioning that doesn't a very explicit way of telling the user about what went wrong? | 09:51 |
| *** tjones1 has quit IRC | 09:51 | |
| sudipto | PaulMurray, I mean - the general openstack versions and the object versions didn't seem to match... | 09:52 |
| bauzas | sudipto: that's not exactly done that way | 09:53 |
| rajesht | johnthetubaguy: sure, if you get any other ideas, please feel free to comment on patch. | 09:53 |
| sudipto | bauzas, the object versioning? | 09:53 |
| *** BobBall_ has joined #openstack-nova | 09:54 | |
| bauzas | sudipto: long story short, we consider that 2 objects should be able to talk between themselves, provided the backportability is done | 09:54 |
| *** lifeless1 has joined #openstack-nova | 09:54 | |
| bauzas | sudipto: so, each time you're bumping a new version, you need to carry out the backwards compatibility | 09:54 |
| *** Maike has quit IRC | 09:56 | |
| sudipto | bauzas, Yeah i have absolutely no issues with the versions being compatible, I would take a recent case, I was using Openstack Juno controller, and then tried to add a debian node to it. The debian node by default got icehouse, even though it's again a user error to not check what version of nova-compute got installed. | 09:57 |
| sudipto | bauzas, With that said, the error was detected correctly and it was reported that the remote objects aren't compatible. But there still wasn't enough information to map - what versions of openstack releases did these versions belong to... | 09:58 |
| *** tjones1 has joined #openstack-nova | 09:58 | |
| *** Maike has joined #openstack-nova | 09:58 | |
| sudipto | bauzas, Just a thought, to see if that's the way it's meant to be handled :) | 09:58 |
| bauzas | sudipto: well, it's a little different between RPC versions and objects versions | 09:59 |
| bauzas | RPC versions have indeed a release field for saying the corresponding version number but objects don't | 10:00 |
| PaulMurray | sudipto, if the conductor isn't more up to date than the compute-node there are likely to be problems. It won't be able to backport to a future version | 10:00 |
| bauzas | sudipto: I honestly don't think it's necessary | 10:00 |
| bauzas | yeah, as PaulMurray said, you need to upgrade the conductor first | 10:00 |
| sudipto | bauzas, hmm yeah, I agree that the upgrade is a necessity, I was just wondering about the detectability aspect... | 10:01 |
| PaulMurray | sudipto, so I think question is how do I know that your controller is on icehouse and your compute-nodes are on juno | 10:01 |
| sudipto | PaulMurray, bang on! That's my question! | 10:01 |
| *** ondergetekende_ has joined #openstack-nova | 10:02 | |
| PaulMurray | sudipto, there is a verison number for nova | 10:02 |
| sudipto | PaulMurray, I did a dpkg -l | grep nova and then figured the nova version | 10:02 |
| sudipto | PaulMurray, Then went to the openstack releases link and mapped it | 10:02 |
| *** bkopilov has quit IRC | 10:02 | |
| *** READ10 has quit IRC | 10:02 | |
| *** yuntong has quit IRC | 10:02 | |
| *** lifeless has quit IRC | 10:02 | |
| *** harlowja_away has quit IRC | 10:02 | |
| *** ondergetekende has quit IRC | 10:02 | |
| *** BobBall has quit IRC | 10:02 | |
| *** jerdfelt has quit IRC | 10:02 | |
| *** TobiasE has quit IRC | 10:02 | |
| sudipto | PaulMurray, whilst that really worked - I was just wondering if that's the most comfortable way to determine (unless you have a different suggestion and jumped the gun) | 10:03 |
| sudipto | *I jumped the gun | 10:03 |
| PaulMurray | sudipto, I don't think there is anything in nova that is going to warn you about controller nodes being on an older version than compute-nodes other than the interactions failing to work | 10:04 |
| PaulMurray | sudipto, which is what they are supposed to do | 10:04 |
| sudipto | PaulMurray, Ok. | 10:04 |
| PaulMurray | you might need something in your configuration management system/monitoring for that | 10:04 |
| sudipto | PaulMurray, hmm, ok. | 10:05 |
| sudipto | PaulMurray, I might be wrong, but for me, the controller was on Juno and the compute was on Icehouse, and it didn't work due to the object miss match. | 10:06 |
| *** otter768 has joined #openstack-nova | 10:06 | |
| sudipto | PaulMurray, I was thinking, we should atleast include the supported object version in this class : IncompatibleObjectVersion in the exception.py - do you agree? | 10:07 |
| sudipto | PaulMurray, As in the object version that is supported. | 10:07 |
| *** tjones1 has quit IRC | 10:07 | |
| PaulMurray | yes - I do agree - that would be helpful | 10:07 |
| sudipto | PaulMurray, Ok let me work on getting that in... | 10:10 |
| *** otter768 has quit IRC | 10:11 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 10:12 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 10:13 |
| *** IanGovett has joined #openstack-nova | 10:14 | |
| johnthetubaguy | oomichi: alex_xu: uploaded a spec to describe what I was talking about, let me know if that makes any sense now: https://review.openstack.org/#/c/173243 | 10:14 |
| oomichi | johnthetubaguy: thanks. that is good for production envs, WIP seems unnecessary ;) | 10:17 |
| oomichi | johnthetubaguy: for getting more feedback | 10:17 |
| sudipto | bauzas, do you like the patchset, sorry if i am asking too early. | 10:17 |
| johnthetubaguy | oomichi: I was expecting lots of typos, maybe there are not so many | 10:17 |
| gilliard | johnthetubaguy :) | 10:19 |
| johnthetubaguy | gilliard: thanks you spotted them for me :) | 10:21 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes allocation ratios to the Resource Tracker https://review.openstack.org/173252 | 10:25 |
| *** jlanoux_ has joined #openstack-nova | 10:28 | |
| *** eglynn has joined #openstack-nova | 10:29 | |
| *** jlanoux has quit IRC | 10:30 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 10:31 |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 10:31 |
| *** ildikov has quit IRC | 10:33 | |
| johnthetubaguy | oomichi: alex_xu: I just realized, we can use the presence of the v2.0 entry to say if you can send a request that does not include a version | 10:39 |
| *** ijw has joined #openstack-nova | 10:43 | |
| *** ijw has quit IRC | 10:43 | |
| *** doron_afk has joined #openstack-nova | 10:44 | |
| *** ijw has joined #openstack-nova | 10:44 | |
| *** jlanoux has joined #openstack-nova | 10:45 | |
| *** jlanoux_ has quit IRC | 10:48 | |
| *** ishant has quit IRC | 10:50 | |
| *** dims has joined #openstack-nova | 10:54 | |
| PaulMurray | Vek, you hve a -1 on https://review.openstack.org/#/c/163328/ due to string freeze, would you lift that now please, thanks | 10:54 |
| *** lsmola_ has joined #openstack-nova | 10:58 | |
| *** dims has quit IRC | 10:58 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 10:59 |
| *** ijw has quit IRC | 11:01 | |
| *** ijw has joined #openstack-nova | 11:01 | |
| openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: WIP: Update hypervisor support matrix with column for kvm on system z https://review.openstack.org/172391 | 11:02 |
| *** xgsa has quit IRC | 11:09 | |
| *** irenab has quit IRC | 11:13 | |
| *** panbalag has joined #openstack-nova | 11:15 | |
| *** ijw_ has joined #openstack-nova | 11:15 | |
| *** ijw has quit IRC | 11:16 | |
| *** irenab has joined #openstack-nova | 11:18 | |
| *** mwagner_lap has quit IRC | 11:23 | |
| *** irenab has quit IRC | 11:23 | |
| *** irenab has joined #openstack-nova | 11:24 | |
| *** irenab has quit IRC | 11:25 | |
| *** ujjain has quit IRC | 11:27 | |
| *** asrangne__ has joined #openstack-nova | 11:28 | |
| *** asrangne has quit IRC | 11:32 | |
| *** aix has quit IRC | 11:32 | |
| *** aix has joined #openstack-nova | 11:33 | |
| *** asrangne__ has quit IRC | 11:37 | |
| *** Anticimex has quit IRC | 11:41 | |
| *** tojuvone has quit IRC | 11:41 | |
| *** jistr is now known as jistr|class | 11:47 | |
| ndipanov | johnthetubaguy, heyongli - see my comment #35 on https://bugs.launchpad.net/nova/+bug/1383465 | 11:49 |
| openstack | Launchpad bug 1383465 in OpenStack Compute (nova) "[pci-passthrough] nova-compute fails to start" [High,In progress] - Assigned to Yongli He (yongli-he) | 11:49 |
| ndipanov | and tell me if you agree | 11:49 |
| *** lucasagomes is now known as lucas-hungry | 11:49 | |
| *** READ10 has joined #openstack-nova | 11:54 | |
| *** yuntong has joined #openstack-nova | 11:56 | |
| *** Marga_ has joined #openstack-nova | 11:57 | |
| *** tiagogomes_ has joined #openstack-nova | 11:57 | |
| *** mpavone has quit IRC | 11:59 | |
| *** sudipto has quit IRC | 12:01 | |
| *** mwagner_lap has joined #openstack-nova | 12:02 | |
| *** deepthi has quit IRC | 12:03 | |
| *** baoli has joined #openstack-nova | 12:04 | |
| *** sahid has quit IRC | 12:04 | |
| *** salv-orlando has joined #openstack-nova | 12:04 | |
| *** ritesh has joined #openstack-nova | 12:06 | |
| *** dprince has joined #openstack-nova | 12:07 | |
| *** otter768 has joined #openstack-nova | 12:07 | |
| ritesh | Hi | 12:07 |
| ritesh | Could anyone help me for the question asked in this link | 12:08 |
| ritesh | https://ask.openstack.org/en/question/65056/use-nova-context-to-get-image-details/ | 12:08 |
| *** mpavone has joined #openstack-nova | 12:11 | |
| markus_z | ritesh: Do you want to use the python API of the nova client? | 12:11 |
| *** otter768 has quit IRC | 12:12 | |
| *** oomichi has quit IRC | 12:12 | |
| *** eharney has quit IRC | 12:12 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge preserve_ephemeral_rebuild tests between v2 & v2.1 https://review.openstack.org/173284 | 12:12 |
| ritesh | @mpavone : we are trying to invoke glance api from nova api, to get the image reference | 12:14 |
| ritesh | @mpavone : we are writing our own service , which is perioidic task it will retrive the image reference when we give image uuid. but we are not able to perform this operation becuase our context object does not have auth token , service catalgo , etc | 12:17 |
| markus_z | ritesh: I posted an answer, maybe it helps | 12:20 |
| dulek | Hi! I'm trying to test performing volume-backed live migration. The problem is my instances have CDROM device attached which counts as local disk. | 12:20 |
| dulek | How can I turn the CD-ROM devices off? | 12:20 |
| markus_z | dulek: In the file "/etc/nova/nova.conf" set the option "force_config_drive=False" | 12:22 |
| dulek | markus_z: Ah, this seems to be it. | 12:22 |
| markus_z | dulek: On each compute node where you don't want automatically a config drive for the guests. | 12:22 |
| ritesh | HI markus_z | 12:23 |
| ritesh | def get_nova_client(ip, tenant="demo", user="admin", password="openstack"): | 12:23 |
| ritesh | this funtion has predefined values | 12:23 |
| dulek | markus_z: Thanks a lot! | 12:23 |
| ritesh | for keystone | 12:23 |
| ritesh | who do we do by not keeping hardcode values | 12:23 |
| markus_z | ritesh: right, you have to change that accordingly. | 12:23 |
| markus_z | ritesh: oh, sorry, maybe I got your question wrong, sorry | 12:24 |
| *** flaper87 has quit IRC | 12:24 | |
| *** flaper87 has joined #openstack-nova | 12:24 | |
| *** marun has joined #openstack-nova | 12:24 | |
| ritesh | can we get it from some configuration file or some request object ? I don't have any request object at that moment.. | 12:25 |
| *** lpetrut has quit IRC | 12:28 | |
| *** marun has quit IRC | 12:29 | |
| *** shi has quit IRC | 12:29 | |
| *** tojuvone has joined #openstack-nova | 12:30 | |
| *** shi has joined #openstack-nova | 12:30 | |
| markus_z | ritesh: I'm not quite sure where you want to extend something. Your service is not triggered by a logged in user, is it? | 12:31 |
| *** TobiasE has joined #openstack-nova | 12:31 | |
| *** doron_afk is now known as doron_ | 12:31 | |
| ritesh | markus_z : Yes service will not trigger by a logged in user. Its a periodic task running in background. | 12:32 |
| *** claudiub has joined #openstack-nova | 12:32 | |
| *** ijw_ has quit IRC | 12:33 | |
| bauzas | ndipanov: I think you should be interested in https://review.openstack.org/#/c/173187/3 | 12:33 |
| ritesh | The code in the periodic task will get the image details . we wiill provide only uuid of the image and want the reference otf that imagme | 12:33 |
| bauzas | ndipanov: I can't really review it as the NUMA effort is like out to me | 12:33 |
| *** aysyd has joined #openstack-nova | 12:34 | |
| markus_z | ritesh: I'm not an expert in this topic, but I assume you could use the python-glanceclient and set the environment variables (like OS_USERNAME and OS_PASSWORD). As your service has to create the request object with proper authentication itself, I'm not aware of other ways doing that. | 12:37 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes allocation ratios to the Resource Tracker https://review.openstack.org/173252 | 12:38 |
| ritesh | markus_z : Thank you... I will try to do as you said. | 12:39 |
| *** tiagogomes_ has quit IRC | 12:41 | |
| *** MVenesio has joined #openstack-nova | 12:42 | |
| *** busterswt has joined #openstack-nova | 12:42 | |
| *** tiagogomes has joined #openstack-nova | 12:42 | |
| *** ajayaa has quit IRC | 12:45 | |
| *** lucas-hungry is now known as lucasagomes | 12:46 | |
| *** setuid has quit IRC | 12:46 | |
| ndipanov | bauzas, thanks | 12:46 |
| kashyap | mdbooth: Just as an info fyi, this is the multi-node DevStack configs w/ Neutron I settled -- https://kashyapc.fedorapeople.org/virt/openstack/multi-node-configs/ | 12:48 |
| mdbooth | kashyap: Thanks | 12:49 |
| *** irenab has joined #openstack-nova | 12:49 | |
| *** irenab has quit IRC | 12:49 | |
| *** setuid has joined #openstack-nova | 12:51 | |
| *** irenab has joined #openstack-nova | 12:52 | |
| *** dims has joined #openstack-nova | 12:52 | |
| johnthetubaguy | ndipanov: yeah, I think that makes sense, but I haven't tried it out | 12:53 |
| openstackgerrit | Ankit Agrawal proposed openstack/nova: 'deleted' filter does not work properly https://review.openstack.org/173296 | 12:53 |
| ndipanov | johnthetubaguy, the reporter is our QE so we should get some feedback soon | 12:53 |
| *** ociuhandu has joined #openstack-nova | 12:53 | |
| *** tjones1 has joined #openstack-nova | 12:55 | |
| *** xgsa has joined #openstack-nova | 12:57 | |
| *** xyang1 has joined #openstack-nova | 12:58 | |
| *** smccully has quit IRC | 12:59 | |
| *** markvoelker has joined #openstack-nova | 13:00 | |
| *** mitz has quit IRC | 13:01 | |
| *** ozialien has joined #openstack-nova | 13:02 | |
| *** jistr|class is now known as jistr | 13:03 | |
| *** doron_mtg has joined #openstack-nova | 13:04 | |
| *** doron_ has quit IRC | 13:04 | |
| *** mitz has joined #openstack-nova | 13:04 | |
| *** jecarey has joined #openstack-nova | 13:05 | |
| *** markvoelker_ has joined #openstack-nova | 13:06 | |
| *** TobiasE1 has joined #openstack-nova | 13:06 | |
| *** wanghao_ is now known as wanghao | 13:06 | |
| *** jecarey_ has joined #openstack-nova | 13:06 | |
| *** TobiasE has quit IRC | 13:06 | |
| *** jecarey has quit IRC | 13:07 | |
| *** jecarey__ has joined #openstack-nova | 13:07 | |
| *** markvoelker has quit IRC | 13:09 | |
| *** jecarey__ has quit IRC | 13:09 | |
| *** TobiasE1 has quit IRC | 13:11 | |
| *** jecarey_ has quit IRC | 13:11 | |
| *** claudiub has quit IRC | 13:11 | |
| *** changbl has quit IRC | 13:12 | |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: Add new image cache monitor in compute nodes https://review.openstack.org/173303 | 13:12 |
| openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova: scheduler: weight nodes based on their cached images https://review.openstack.org/173304 | 13:12 |
| *** ozialien_ has joined #openstack-nova | 13:12 | |
| *** ozialien has quit IRC | 13:12 | |
| *** ozialien_ is now known as ozialien | 13:12 | |
| *** adalbas has joined #openstack-nova | 13:13 | |
| *** ferest has joined #openstack-nova | 13:13 | |
| *** dosaboy has quit IRC | 13:14 | |
| *** dosaboy has joined #openstack-nova | 13:14 | |
| *** mriedem has joined #openstack-nova | 13:15 | |
| *** mriedem_away has quit IRC | 13:15 | |
| *** neelashah has joined #openstack-nova | 13:18 | |
| *** ferest has quit IRC | 13:18 | |
| mriedem | sdague: johnthetubaguy: ndipanov: would be nice to have live migration working for kilo https://review.openstack.org/#/c/173099/1 | 13:18 |
| *** irenab has quit IRC | 13:18 | |
| mriedem | dansmith: ^ that does depend on the logging patch | 13:18 |
| mriedem | but the backport doesn't need to | 13:19 |
| sdague | mriedem: ... is there a regression test that could have caught the issue in https://review.openstack.org/#/c/173099/1 ? | 13:20 |
| *** liusheng has quit IRC | 13:20 | |
| mriedem | sdague: yes, aiopcpu full | 13:20 |
| *** irenab has joined #openstack-nova | 13:20 | |
| sdague | mriedem: a narrower one? | 13:20 |
| *** liusheng has joined #openstack-nova | 13:21 | |
| mriedem | sdague: that rpc proxy code goes away when we drop compute rpc 3.0 i think | 13:21 |
| mriedem | dansmith: ^? | 13:21 |
| *** haomaiwang has joined #openstack-nova | 13:21 | |
| mriedem | sdague: so that proxy code is temporary and we remove in liberty | 13:21 |
| mriedem | and the aiopcpu job hits live migration | 13:21 |
| sdague | ok | 13:21 |
| mriedem | we want to get that job voting so we don't regress | 13:22 |
| mriedem | which is what we did last week | 13:22 |
| sdague | and then migrate_data becomes non optional? | 13:22 |
| sdague | I guess that's my question, if things don't work if we don't pass it, why is it optional | 13:22 |
| mriedem | that i do'nt know | 13:22 |
| mriedem | but seems it shouldn't be | 13:22 |
| mriedem | it's optional in the compute manager, i'd have to dig into the history to know why | 13:23 |
| johnthetubaguy | sdague: I thought that was backwards compatibility at some point | 13:23 |
| johnthetubaguy | at one point, we didn't send it | 13:23 |
| mriedem | yeah idk, maybe some older rpc version? | 13:23 |
| sdague | johnthetubaguy: ok, but apparently it doesn't work at all if it's not there | 13:23 |
| mriedem | right | 13:23 |
| *** ozialien has quit IRC | 13:23 | |
| mriedem | live block migration doesn't at least | 13:23 |
| sdague | so backwards compat to broken seems.... sub optimal | 13:23 |
| mriedem | shared storage live migration might work | 13:23 |
| mriedem | the libvirt driver assumes you have shared storage if migrate_data=None | 13:24 |
| mriedem | that could probably be smarter | 13:24 |
| *** jecarey has joined #openstack-nova | 13:25 | |
| *** irenab has quit IRC | 13:25 | |
| sdague | ok, fine with the fix, I see johnthetubaguy already +Aed as well | 13:26 |
| sdague | just wanted to figure out if I was missing something. Seems like a good cleanup as well | 13:26 |
| *** mpavone has quit IRC | 13:26 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes Implements RequestSpec object https://review.openstack.org/173316 | 13:28 |
| *** eharney has joined #openstack-nova | 13:29 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes Implements RequestSpec object https://review.openstack.org/173316 | 13:30 |
| *** VW_ has joined #openstack-nova | 13:31 | |
| *** dims has quit IRC | 13:31 | |
| *** irenab has joined #openstack-nova | 13:32 | |
| *** tjones1 has quit IRC | 13:32 | |
| *** dims has joined #openstack-nova | 13:32 | |
| *** irenab has quit IRC | 13:32 | |
| *** ajayaa has joined #openstack-nova | 13:33 | |
| *** coolsvap|afk is now known as coolsvap | 13:34 | |
| dansmith | mriedem: sdague yeah, that code is all gone in a few days, and testing it specifically would be really synthetic | 13:34 |
| sdague | dansmith: sure, that's fine if we're making it non optional soon | 13:35 |
| *** sudipto has joined #openstack-nova | 13:35 | |
| *** sdake has joined #openstack-nova | 13:35 | |
| dansmith | sdague: indeed | 13:36 |
| sudipto | bauzas, Thanks for the review. Regarding the UT aspect, I actually did a grep in the code to figure out where I could fit this in, Found that there were no existing UTs for existing method either. Can you suggest a placeholder for the UTs? | 13:36 |
| bauzas | sudipto: you mean, there is no coverage yet ? | 13:37 |
| bauzas | sudipto: lemme check | 13:37 |
| sudipto | bauzas, Yeah for the existing parent method. it just had a mocked return in the test_driver.py module. | 13:37 |
| bauzas | sudipto: orly ? :O | 13:38 |
| bauzas | sudipto: indeed, you're right | 13:39 |
| bauzas | sudipto: well, I think then you should add some tests for this method, because it's not just a proxy method | 13:39 |
| *** sdake has quit IRC | 13:40 | |
| *** ferest has joined #openstack-nova | 13:41 | |
| *** rushil has joined #openstack-nova | 13:41 | |
| *** emagana has joined #openstack-nova | 13:41 | |
| bauzas | sudipto: to answer your question, you should add them at the tail of test_update_status(self, mock_open): | 13:41 |
| *** sudipto has quit IRC | 13:42 | |
| *** jwcroppe has joined #openstack-nova | 13:44 | |
| *** dboik has joined #openstack-nova | 13:44 | |
| *** rushiagr is now known as rushiagr_away | 13:44 | |
| mriedem | dansmith: who is going to reply to the direct email spam for reviews to this ben grassart? :) | 13:44 |
| dansmith | mriedem: I figure someone will ;) | 13:45 |
| *** ferest has quit IRC | 13:46 | |
| *** burt has joined #openstack-nova | 13:47 | |
| *** ajayaa has quit IRC | 13:49 | |
| *** oro has joined #openstack-nova | 13:52 | |
| *** r-daneel has joined #openstack-nova | 13:52 | |
| *** jwcroppe has quit IRC | 13:52 | |
| bauzas | oh man, he's French | 13:52 |
| *** armax has joined #openstack-nova | 13:53 | |
| mriedem | sic'em | 13:53 |
| *** sudipto has joined #openstack-nova | 13:55 | |
| *** sdake has joined #openstack-nova | 13:57 | |
| *** apuimedo has quit IRC | 13:58 | |
| *** mpavone has joined #openstack-nova | 13:58 | |
| *** armax has quit IRC | 13:58 | |
| *** armax_ has joined #openstack-nova | 13:58 | |
| *** apuimedo has joined #openstack-nova | 13:58 | |
| *** dims has quit IRC | 14:00 | |
| *** dims has joined #openstack-nova | 14:00 | |
| mriedem | kashyap: btw, the fc21 job is on nova's experimental queue now and there were some results in https://review.openstack.org/#/c/147332/ | 14:01 |
| * kashyap clicks | 14:01 | |
| mriedem | kashyap: test_volume_boot_pattern had failed, but the original test that was failing with live snapshot passed | 14:01 |
| mriedem | i just rechecked it | 14:01 |
| mriedem | http://logs.openstack.org/32/147332/3/experimental/check-tempest-dsvm-f21/ea2dfbb/ | 14:01 |
| *** rushiagr_away is now known as rushiagr | 14:01 | |
| kashyap | mriedem: Oh, the "original test" being the infamous bug report you filed? :-) | 14:01 |
| *** vladikr has joined #openstack-nova | 14:02 | |
| mriedem | kashyap: yeah | 14:02 |
| Mike_D_wk | :) | 14:02 |
| mriedem | test_images_one_server or whatever | 14:02 |
| *** browne has joined #openstack-nova | 14:02 | |
| mriedem | that used to fail about 25% of the time in the gate with live snapshot, | 14:02 |
| mriedem | so we'd probably want to recheck it a few times to see if it shows up with newer libvirt/qemu | 14:02 |
| *** ajayaa has joined #openstack-nova | 14:02 | |
| kashyap | Yeah, for the life of me I couldn't get it reproduced locally, I simply ran out of motivation on getting it reproduced. | 14:02 |
| kashyap | Yep, looking at the logs. mriedem, I also noticed a Nova patch fly by where you've enabled a bit more debugging for live migration | 14:03 |
| *** mtanino has joined #openstack-nova | 14:04 | |
| *** thangp has joined #openstack-nova | 14:04 | |
| mriedem | kashyap: yeah, b/c we broke live migration on friday but pre_live_migration had no debug logging | 14:04 |
| mriedem | to see what the flags were in that code | 14:04 |
| *** mleroy has quit IRC | 14:05 | |
| *** jaypipes has joined #openstack-nova | 14:06 | |
| kashyap | mriedem: Maybe I'm being pedantic, you say "recheck", but it's actually 'check experimental' given your "Add check-tempest-dsvm-f21 to experimental queue for openstack/nova" commit. | 14:06 |
| mriedem | kashyap: yes, i did 'check experimental' | 14:06 |
| mriedem | 'recheck' is fewer chars to type :) | 14:07 |
| *** doron_mtg is now known as doron_afk | 14:07 | |
| kashyap | And, thanks for chasing this down with unwavering patience! | 14:08 |
| *** Nikolay_St has quit IRC | 14:08 | |
| *** otter768 has joined #openstack-nova | 14:08 | |
| mriedem | np | 14:08 |
| mriedem | patience is my middle name, just ask my family | 14:08 |
| *** irenab has joined #openstack-nova | 14:08 | |
| kashyap | Seemed like so, patience and speed - pretty deadly combination you seem to possess there. | 14:09 |
| *** dboik_ has joined #openstack-nova | 14:09 | |
| dansmith | mriedem: so, the last live fix is in the gate, | 14:10 |
| dansmith | and proposed against kilo | 14:10 |
| dansmith | so I think we're all good until rc2 happens, yes? | 14:10 |
| *** dboik has quit IRC | 14:11 | |
| mriedem | dansmith: yeah i think so | 14:12 |
| mriedem | i have another patch for a race seen in live migrate testing, | 14:12 |
| mriedem | but it hasn't seemed to be a huge issue | 14:12 |
| *** irenab has quit IRC | 14:12 | |
| mriedem | amazingly after i pushed my patch up for it :) | 14:12 |
| *** otter768 has quit IRC | 14:13 | |
| dansmith | okay | 14:13 |
| *** Anticimex has joined #openstack-nova | 14:14 | |
| dansmith | I feel like we need to do some release notes editing | 14:14 |
| *** irenab has joined #openstack-nova | 14:14 | |
| dansmith | alaski: there are probably multiple things we want folks to do relating to the new cells cb, right? are those things on the release notes yet? | 14:14 |
| mriedem | dansmith: release notes editing for live migration? such as? | 14:14 |
| mriedem | 'tested with live block migration but not shared storage?' | 14:14 |
| alaski | dansmith: they are not. but I'm not sure we want people doing anything yet | 14:15 |
| alaski | dansmith: but I'm happy to add some info in case people would like to try them | 14:15 |
| mriedem | we should do a scrub of commits with UpgradeImpact that merged in kilo to make sure they have corresponding entries in the release notes | 14:15 |
| *** cfriesen has quit IRC | 14:16 | |
| *** cfriesen has joined #openstack-nova | 14:16 | |
| *** irenab has quit IRC | 14:16 | |
| mriedem | https://review.openstack.org/gitweb?p=openstack%2Fnova.git&a=search&h=refs%2Fheads%2Fmaster&st=commit&s=UpgradeImpact | 14:17 |
| *** cfriesen has quit IRC | 14:17 | |
| *** cfriesen has joined #openstack-nova | 14:17 | |
| *** zhenguo has quit IRC | 14:17 | |
| bauzas | mriedem: just to be clear, when do we need to add an UpgradeImpact tag ? | 14:17 |
| mriedem | there aren't that many, i'll post something to the ML | 14:17 |
| mriedem | bauzas: if there is an upgrade impact? :) | 14:18 |
| bauzas | mriedem: awesome, like changing a py file ? woah | 14:18 |
| *** irenab has joined #openstack-nova | 14:18 | |
| mriedem | bauzas: https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references | 14:18 |
| mriedem | there is a more formal description there | 14:18 |
| bauzas | damned, beated by the manual | 14:18 |
| *** nelsnelson has joined #openstack-nova | 14:18 | |
| *** markvoelker has joined #openstack-nova | 14:19 | |
| bauzas | mriedem: I was knowing all of them but not this one, so my detach-service series was probably also related to an UpgradeImpact tag | 14:19 |
| *** markvoelker_ has quit IRC | 14:19 | |
| dansmith | mriedem: no, I just meant in general for the release, not necessarily for live migration things | 14:19 |
| dansmith | alaski: okay, I thought we needed them to bootstrap the new database and such | 14:19 |
| dansmith | alaski: aren't we writing to the instance index tables already? | 14:20 |
| alaski | dansmith: not yet | 14:20 |
| mriedem | dansmith: yeah, i'll post to the ML | 14:20 |
| dansmith | alaski: okay | 14:20 |
| cfriesen | mriedem: is there any documented ordering for upgrading nova-compute, nova-conductor, nova-api, nova-scheduler, DB? | 14:20 |
| mriedem | cfriesen: it's doc'ed, sec | 14:21 |
| dansmith | cfriesen: all the control plane services (not compute) have to go at the same time, then you can do computes one at a time | 14:21 |
| mriedem | cfriesen: http://docs.openstack.org/developer/nova/devref/upgrade.html | 14:21 |
| mriedem | if there is anything wrong there, we should update those docs | 14:21 |
| cfriesen | okay. I'm looking at http://docs.openstack.org/openstack-ops/content/ops_upgrades-general-steps.html and it just says "Upgrade OpenStack Compute (nova)" | 14:22 |
| dansmith | cfriesen: that is the high-level upgrade across the stack | 14:22 |
| dansmith | cfriesen: within nova you have more options about how you do step 3 | 14:22 |
| *** irenab has quit IRC | 14:24 | |
| cfriesen | mriedem: thanks. What's step 9 talking about? "Run the new nova-manage command that ensures all DB records are “upgraded” to new data version" | 14:25 |
| *** gszasz has quit IRC | 14:25 | |
| cfriesen | that sounds like something other than the db sync command | 14:25 |
| dansmith | flavor-migrate is one | 14:25 |
| *** irenab has joined #openstack-nova | 14:26 | |
| dansmith | cfriesen: https://wiki.openstack.org/wiki/ReleaseNotes/Kilo#Upgrade_Notes_2 | 14:26 |
| *** tonytan4ever has joined #openstack-nova | 14:27 | |
| *** sudipto has quit IRC | 14:28 | |
| *** zzzeek has joined #openstack-nova | 14:30 | |
| dansmith | sdague: we probably need something on the release notes about ec2 api deprecation too | 14:30 |
| *** xyang1 has quit IRC | 14:31 | |
| sdague | dansmith: agreed, I'll work on writing something up today | 14:31 |
| *** diegows has joined #openstack-nova | 14:31 | |
| dansmith | cool | 14:31 |
| *** moshele has quit IRC | 14:31 | |
| *** zz_jgrimm is now known as jgrimm | 14:32 | |
| *** ankit_ag has quit IRC | 14:33 | |
| *** Marga_ has quit IRC | 14:34 | |
| *** BobBall_ is now known as BobBall | 14:35 | |
| mriedem | dansmith: sdague: yeah that had UpgradeImpact on it | 14:37 |
| mriedem | still drafting that email, got sidetracked | 14:37 |
| kashyap | mriedem: For completenss' sake, maybe you'd also want to update the bug 1334398 with your new finding (that the offending test passed) from the experimental queue, and reassign yourself the bug? | 14:37 |
| openstack | bug 1334398 in OpenStack Compute (nova) "libvirt live_snapshot periodically explodes on libvirt 1.2.2 in the gate" [High,In progress] https://launchpad.net/bugs/1334398 - Assigned to Chet Burgess (cfb-n) | 14:37 |
| *** irenab has quit IRC | 14:37 | |
| *** irenab has joined #openstack-nova | 14:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: cleanup unused lifecycle event handling variables from driver https://review.openstack.org/173354 | 14:39 |
| mriedem | kashyap: yeah i'm not there yet | 14:39 |
| *** Maike has quit IRC | 14:39 | |
| *** sahid has joined #openstack-nova | 14:39 | |
| *** gszasz has joined #openstack-nova | 14:40 | |
| kashyap | mriedem: Yeah, didn't mean to rush, I realize you're doing more investigation. | 14:41 |
| *** n0ano has joined #openstack-nova | 14:42 | |
| *** bkopilov has joined #openstack-nova | 14:43 | |
| *** Hosam has joined #openstack-nova | 14:44 | |
| bauzas | alaski: I'm just code reviewing the cells modules and I see the Cells scheduler having a build_instances() which creates new instances ?! | 14:44 |
| mriedem | garyk: did you see my question in the ML about the broken vmware ci? | 14:44 |
| openstackgerrit | zhangjl proposed openstack/nova: Check if destination_type in block_device_mapping_v2 https://review.openstack.org/173357 | 14:45 |
| mriedem | garyk: it said that https://review.openstack.org/#/c/136935/ broke vmware ci but vmware ci passed on that change | 14:45 |
| *** oro has quit IRC | 14:45 | |
| mriedem | we have a shitload of DocImpact changes in master (kilo) | 14:47 |
| *** xyang1 has joined #openstack-nova | 14:48 | |
| mriedem | dims: can you update the release notes for 1153a46 ? | 14:49 |
| garyk | mriedem: yes, i saw the mail. was in the process of answering. seems like there was a shange in tempest that caused the issue | 14:50 |
| mriedem | garyk: passing network uuid on create? | 14:51 |
| mriedem | that was new and shook out a few bugs | 14:51 |
| garyk | shange => change | 14:51 |
| *** dave-mccowan has joined #openstack-nova | 14:51 | |
| garyk | i need to speak with ryan who investigated it - then i can get back to you. | 14:51 |
| mriedem | johnthetubaguy: is it worth adding http://docs.openstack.org/developer/nova/devref/upgrade.html to the kilo release notes upgrade section? or is that more of a 'this is where we want to get to for upgrades, but maybe not there yet'? | 14:51 |
| garyk | issue i that there are many moving targets | 14:52 |
| johnthetubaguy | mriedem: its forward looking at this point | 14:52 |
| mriedem | johnthetubaguy: ok | 14:52 |
| openstackgerrit | dave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly https://review.openstack.org/172951 | 14:52 |
| *** thedodd has joined #openstack-nova | 14:52 | |
| cfriesen | this is maybe a bit esoteric, hoping maybe someone knows the answer. I'm trying to figure out where in nova we end up updating the port 'binding:host_id' for neutron when doing an evacuation. Saw a case where we failed to bring up the instance on the new host because the 'binding:host_id' was still pointing to the previous host. | 14:53 |
| *** hdd has quit IRC | 14:54 | |
| *** cbader has quit IRC | 14:55 | |
| *** marun has joined #openstack-nova | 14:55 | |
| *** cbader has joined #openstack-nova | 14:57 | |
| *** irenab has quit IRC | 14:58 | |
| *** irenab has joined #openstack-nova | 14:59 | |
| mriedem | cfriesen: hmm, the neutronv2 api code would do that on deallocate (if that's called from the compute manager on evacuate/rebuild) | 14:59 |
| *** mleroy has joined #openstack-nova | 14:59 | |
| *** dboik_ has quit IRC | 14:59 | |
| *** Nikolay_St has joined #openstack-nova | 14:59 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect dhcp_server value during nova-network creation https://review.openstack.org/173362 | 15:00 |
| openstackgerrit | zhangtralon proposed openstack/nova: resize-revert can break anti-affinity policy https://review.openstack.org/160110 | 15:00 |
| mriedem | cfriesen: http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n344 | 15:00 |
| *** coolsvap is now known as coolsvap|afk | 15:00 | |
| *** ozialien has joined #openstack-nova | 15:01 | |
| *** zhangtralon has joined #openstack-nova | 15:01 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect dhcp_server value during nova-network creation https://review.openstack.org/173362 | 15:01 |
| *** dulek has quit IRC | 15:01 | |
| *** rushil_ has joined #openstack-nova | 15:01 | |
| *** rushil has quit IRC | 15:02 | |
| alaski | bauzas: yes, the cells scheduler has to write the instance to the db before calling conductor because conductor assumes it exists | 15:02 |
| *** kmartin has joined #openstack-nova | 15:02 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect dhcp_server value during nova-network creation https://review.openstack.org/173362 | 15:02 |
| bauzas | alaski: okay | 15:02 |
| alaski | bauzas: in meetings all morning so a bit slow atm | 15:02 |
| bauzas | alaski: no worries, just code reviewing for fixing the bug | 15:02 |
| cfriesen | mriedem: thanks, will try following that | 15:02 |
| bauzas | alaski: making sure I can do that correctly | 15:03 |
| *** nkrinner has quit IRC | 15:03 | |
| *** mtanino has quit IRC | 15:03 | |
| bauzas | alaski: was thinking about providing an indirection field for the instance object | 15:03 |
| *** sbfox has joined #openstack-nova | 15:05 | |
| mriedem | cfriesen: so i think in the evacuate case, recreate=True, so when you get here | 15:06 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n2871 | 15:06 |
| *** Nikolay_St has quit IRC | 15:06 | |
| mriedem | that won't call driver.destroy which would have deallocated the port | 15:06 |
| *** zhangtralon has quit IRC | 15:07 | |
| mriedem | cfriesen: the only other method that's called in the rebuild operation is this, which is not implemented for neutron | 15:07 |
| mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n232 | 15:07 |
| mriedem | cfriesen: so i think http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n2871 is probably the issue | 15:07 |
| mriedem | cfriesen: is there a bug reported? | 15:08 |
| *** Nikolay_St has joined #openstack-nova | 15:08 | |
| *** jwcroppe has joined #openstack-nova | 15:08 | |
| cfriesen | mriedem: not that I know of. This was an internal bug that one of our testers caught. | 15:09 |
| cfriesen | mriedem: it only happens occasionally though, most of the time evac works | 15:09 |
| mriedem | hmm | 15:09 |
| cfriesen | mriedem: also, this is effectively on kilo-2. we're in the process up moving to a newer version | 15:10 |
| mriedem | hmm, wonder if we test rebuild in tempest with neutron | 15:11 |
| *** tojuvone has quit IRC | 15:11 | |
| mriedem | with the aiopcpu job we could start testing evacuate | 15:11 |
| mriedem | jogo: dansmith: ^ | 15:11 |
| dansmith | mriedem: aye | 15:12 |
| dansmith | mriedem: especially since I'm going to effing fix it | 15:12 |
| mriedem | there is no evacuate test in tempest today... | 15:12 |
| dansmith | really? I thought there was | 15:12 |
| clarkb | dansmith: mriedem where is the live migrate fix at? | 15:12 |
| mriedem | dansmith: oh it's rebuild | 15:13 |
| mriedem | clarkb: sec | 15:13 |
| mriedem | clarkb: oh status wise? should be in the gate for master, proposed to proposed/kilo | 15:13 |
| mriedem | clarkb: https://review.openstack.org/#/c/173099/ | 15:13 |
| mriedem | merged to master | 15:13 |
| clarkb | woot I can rerun tests for things, thanks | 15:14 |
| *** mtanino has joined #openstack-nova | 15:14 | |
| *** ozialien has quit IRC | 15:14 | |
| *** jwcroppe has quit IRC | 15:14 | |
| *** Nikolay_St has quit IRC | 15:15 | |
| openstackgerrit | sahid proposed openstack/nova: virt: remove small pages request https://review.openstack.org/172079 | 15:15 |
| *** marun has quit IRC | 15:15 | |
| *** dboik has joined #openstack-nova | 15:15 | |
| *** Nikolay_St has joined #openstack-nova | 15:16 | |
| openstackgerrit | Dan Smith proposed openstack/nova-specs: Add config-filter spec https://review.openstack.org/173375 | 15:16 |
| *** marun has joined #openstack-nova | 15:16 | |
| *** marun has quit IRC | 15:17 | |
| *** marun has joined #openstack-nova | 15:17 | |
| *** smccully has joined #openstack-nova | 15:18 | |
| *** dboik_ has joined #openstack-nova | 15:18 | |
| mriedem | dansmith: so we have rebuild tests in tempest, a lot of them, but no evacuate tests | 15:18 |
| dansmith | wow | 15:18 |
| mriedem | so that's a todo for liberty with the aiopcpu job and we can validate it against your spec changes | 15:19 |
| dansmith | mriedem: maybe it should be a pre-work-item for this: https://review.openstack.org/#/c/161444/ | 15:19 |
| mriedem | yeah | 15:19 |
| mriedem | i'll add that comment | 15:19 |
| *** ekhugen has quit IRC | 15:20 | |
| dansmith | okay, I have more to address in that one anyway, so that'll be good | 15:20 |
| *** timello has quit IRC | 15:21 | |
| mriedem | mtreinish: do i need a qa-spec to add os-evacuate testing to tempest? it's going to require a config option probably for multi-node support | 15:21 |
| *** dboik has quit IRC | 15:21 | |
| *** maurosr has quit IRC | 15:21 | |
| *** jgrimm has quit IRC | 15:21 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova-specs: Ironic: Configdrive extra data https://review.openstack.org/173379 | 15:22 |
| *** Nikolay_St has quit IRC | 15:22 | |
| *** smccully has quit IRC | 15:22 | |
| mtreinish | mriedem: http://specs.openstack.org/openstack/qa-specs/README.html#tempest-specs-for-new-tests | 15:23 |
| *** flaper87 has quit IRC | 15:23 | |
| mtreinish | mriedem: short answer is for a single resource test the answer is no | 15:23 |
| mtreinish | mriedem: although you can check the api for multiple nodes like we do for the migration tests | 15:23 |
| *** yamahata has joined #openstack-nova | 15:24 | |
| mtreinish | or is this a flag to say evacuate actually works with multi-node | 15:24 |
| mriedem | mtreinish: is that just using the hosts API to see if there are multiple compute hosts? | 15:24 |
| mtreinish | yep | 15:24 |
| mriedem | if not, then we skip the evacuate test | 15:24 |
| mriedem | ok | 15:24 |
| mriedem | then i guess we wouldn't need a config option | 15:25 |
| *** flaper87 has joined #openstack-nova | 15:25 | |
| *** flaper87 has quit IRC | 15:25 | |
| *** flaper87 has joined #openstack-nova | 15:25 | |
| clarkb | I think we use a config option for the migration test | 15:25 |
| mriedem | we do | 15:25 |
| mtreinish | clarkb: there are config options to say the nova supports migration, and the other features | 15:25 |
| mriedem | but that's for live block migration and block migration with a backing volume - two different tests | 15:25 |
| openstackgerrit | Sergey Nikitin proposed openstack/nova: Fixed incorrect dhcp_server value during nova-network creation https://review.openstack.org/173362 | 15:25 |
| mtreinish | but it also checks to make sure there is >1 host available | 15:25 |
| mriedem | the only case that evacuate might be special case is baremetal? | 15:25 |
| *** Nikolay_St has joined #openstack-nova | 15:25 | |
| clarkb | I see, so the criteria for evacuate is much simpler and tempest can just figure that out | 15:26 |
| mtreinish | mriedem: that's always the case with baremetal | 15:26 |
| mriedem | i think ironic was the only driver that had it's own custom rebuild method | 15:26 |
| mriedem | mtreinish: :) | 15:26 |
| mriedem | well, this is very early and i probably won't get to it today, but it's on my list now | 15:26 |
| mtreinish | mriedem: btw, I think we should totally do an evacuate test on a single node. :) | 15:27 |
| mriedem | mtreinish: you mean negative test? | 15:28 |
| *** amotoki has joined #openstack-nova | 15:28 | |
| mtreinish | would it just scheduler error? or is it caught before that | 15:28 |
| *** doron_afk has quit IRC | 15:28 | |
| *** diegows has quit IRC | 15:28 | |
| mriedem | it's caught in the api | 15:28 |
| mtreinish | mriedem: oh then, that's something you might want to test in nova's functional tests | 15:29 |
| mriedem | probably | 15:29 |
| mriedem | it would only be unit tested today | 15:29 |
| mriedem | there is some os-extended-evacuate-find-host extension which makes host optional i guess | 15:29 |
| *** Longgeek has quit IRC | 15:29 | |
| mriedem | so if you specify host on the request and it's the same host the the instance is already on, you get a 400 back right away | 15:30 |
| mriedem | if you don't specify host, the scheduler picks on | 15:30 |
| mriedem | *one | 15:30 |
| *** Nikolay_St has quit IRC | 15:30 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs: Allow adjust ephemeral disks during resize https://review.openstack.org/145736 | 15:30 |
| mtreinish | mriedem: wait you make an evacuate call and don't specify a host? That seems weird to me | 15:30 |
| mriedem | right | 15:31 |
| mriedem | then the scheduler tries to find a host | 15:31 |
| *** Nikolay_St has joined #openstack-nova | 15:32 | |
| *** oro has joined #openstack-nova | 15:32 | |
| *** dsanders has joined #openstack-nova | 15:32 | |
| *** dboik_ has quit IRC | 15:33 | |
| bauzas | yeah, the logic is now the same for evacuate and migrate | 15:33 |
| *** dboik has joined #openstack-nova | 15:33 | |
| bauzas | no dest host => ask the scheduler | 15:33 |
| mriedem | was going to say, i'm not familiar with the scheduler code that knows not to pick the host the instance is already on | 15:33 |
| cfriesen | mriedem: currently the evacuate code will only let you evacuate if the old compute service fails the is_up() test. | 15:33 |
| bauzas | mriedem: everything is done on the conductor side | 15:34 |
| *** WannabeCloudHost has joined #openstack-nova | 15:34 | |
| WannabeCloudHost | There is a way to change or reset an instance root password througth API OR CLI please ? nobody has an answer in room 101 ... | 15:34 |
| bauzas | mriedem: that's only if you're not specifying a dest host that then it does call select_dest() | 15:34 |
| mriedem | cfriesen: do you have a link to the code where that check is made? | 15:34 |
| mriedem | the is_up() check? | 15:34 |
| bauzas | mriedem: but as the request_spec object is not persisted, that's just... lottery :) | 15:35 |
| mriedem | cfriesen: nvm, found it | 15:35 |
| cfriesen | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n3254 | 15:35 |
| mriedem | yeah | 15:35 |
| mriedem | damn, well, .... | 15:36 |
| *** changbl has joined #openstack-nova | 15:36 | |
| mriedem | we can't really test that w/o isolation in tempest... | 15:36 |
| mriedem | mtreinish: ^ | 15:36 |
| mriedem | you'd have to lock out all other tests from running, take down the source host service, evacuate to host B, then bring up the service on host A in tearDown | 15:36 |
| cfriesen | mriedem: bauzas: actually, was wondering if that is_up() check is correct for the scenario where one compute service maps to multiple compute nodes. (ironic, vmware) | 15:37 |
| bauzas | cfriesen: it doesn't | 15:37 |
| bauzas | cfriesen: because is_up() is checking the service db entry | 15:37 |
| bauzas | cfriesen: so saying that you have distributed hosts behind a nova-compute service, it would be possible to have a service up but a node down | 15:38 |
| cfriesen | bauzas: right, so what happens if one host goes down? how do we get the stuff that was running on that host onto a different host? | 15:38 |
| cfriesen | or is that outside of nova's responsibility? | 15:38 |
| bauzas | cfriesen: that's not Nova | 15:39 |
| bauzas | cfriesen: but there are some efforts to fence that | 15:39 |
| mriedem | can i cue jaypipes to rant on this? :P | 15:39 |
| bauzas | cfriesen: http://blog.russellbryant.net/2015/04/08/implementation-of-pacemaker-managed-openstack-vm-recovery/ | 15:39 |
| * jaypipes flies in from side stage | 15:39 | |
| mtreinish | mriedem: well there is definitely no mechanism for doing that in tempest | 15:39 |
| bauzas | cfriesen: you mean auto-evacuate ? | 15:40 |
| *** gszasz has quit IRC | 15:40 | |
| mtreinish | mriedem: but it doesn't work at the same time other api requests are being made? Like what happens if a node is in the middle of an evacuate and it gets a delete request for a server it's moving? | 15:40 |
| cfriesen | bauzas: no, I'm just trying to figure out how evacuate is supposed to work if a host goes down but the compute service that controls it is still up. The self.servicegroup_api.service_is_up() call will pass, so it will prevent us from doing an evacuate. | 15:41 |
| bauzas | cfriesen: oh that | 15:42 |
| bauzas | cfriesen: because you hitted a flaw with distributed computes | 15:42 |
| bauzas | cfriesen: there is a spec trying to fix that, hold on | 15:42 |
| *** unicell has joined #openstack-nova | 15:42 | |
| *** ajayaa has quit IRC | 15:42 | |
| cfriesen | bauzas: I'm commenting on the spec about dealing with host faults. (https://review.openstack.org/#/c/169836/8/specs/liberty/approved/report-host-fault-to-update-server-state-immediately.rst) | 15:43 |
| openstackgerrit | Przemyslaw Czesnowicz proposed openstack/nova: Fix handling of pci_requests in consume_from_instance. https://review.openstack.org/173394 | 15:43 |
| *** unicell1 has quit IRC | 15:43 | |
| *** ekhugen has joined #openstack-nova | 15:44 | |
| bauzas | cfriesen: yeah, I was thinking about that spec | 15:44 |
| *** markvoelker has quit IRC | 15:44 | |
| bauzas | cfriesen: but IMHO, it's just insane to consider that service == compute | 15:44 |
| *** jgrimm has joined #openstack-nova | 15:44 | |
| cfriesen | bauzas: with the current code I think if the compute service goes down we'd have to mark all the hosts controlled by it as "down" too, and fence them all. Really not polite. | 15:44 |
| pczesno | ndipanov: are you there? | 15:44 |
| cfriesen | bauzas: in the case of kvm it works okay since we have the service running on each host | 15:45 |
| bauzas | cfriesen: yeah, that's exactly the point of my first comment on that spec | 15:45 |
| cfriesen | bauzas: but for multiple hosts controlled by one service it sort of falls apart | 15:45 |
| *** maurosr_ has joined #openstack-nova | 15:45 | |
| *** ajayaa has joined #openstack-nova | 15:46 | |
| bauzas | cfriesen: the scheduler knows about nodes, and return nodes | 15:46 |
| *** dprince has quit IRC | 15:46 | |
| *** timello has joined #openstack-nova | 15:46 | |
| bauzas | cfriesen: the scheduler doesn't care about services, except only for checking that the attached service is not marked as disabled | 15:46 |
| cfriesen | bauzas: yes, but I think that's a flaw in the current nova design, not in that spec. Ideally we should be able to report a single host down and the evac code should be checking whether the host is up | 15:46 |
| cfriesen | bauzas: yes, but it should also be checking whether the host is up, no? | 15:46 |
| cfriesen | or is that another level of scheduling | 15:47 |
| bauzas | cfriesen: that's what I'm trying to explain : the proposal is wrong because it makes wrong assumptions | 15:47 |
| *** dsanders has quit IRC | 15:47 | |
| bauzas | cfriesen: well, that's a good question, but it already does that kind of things in the HostManager | 15:47 |
| cfriesen | bauas: so what's your suggested solution? The problem statement is that if a kvm host goes down, it takes 60 seconds for nova to notice. An external monitor notices in say 5 seconds, and wants to tell nova that it should allow evacuation of all instances running on that host. | 15:48 |
| cfriesen | make that bauzas. :) | 15:48 |
| bauzas | cfriesen: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L559-L565 | 15:48 |
| bauzas | cfriesen: I would just propose to amend os-hypervisors, that's what I said in the spec :) | 15:49 |
| *** smccully has joined #openstack-nova | 15:49 | |
| bauzas | cfriesen: but it would probably require to change a little more of logic | 15:49 |
| *** arnaud___ has joined #openstack-nova | 15:50 | |
| bauzas | cfriesen: like making sure that ComputeNodeList.get_all() doesn't return these disabled hosts | 15:50 |
| cfriesen | bauzas: what about the case where a compute service goes down? Technically at that point we know nothing about what is going on for the hosts it controls, so the "reliable" thing to do would be to fence them all and evacuate them all. But that seems a bit drastic. | 15:51 |
| *** dave-mccowan has quit IRC | 15:51 | |
| *** jistr has quit IRC | 15:51 | |
| mriedem | bauzas: cfriesen: so http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n3254 is pretty harsh, right? shouldn't that be more conditional based on the type of deployment or capabilities of the driver? | 15:51 |
| bauzas | cfriesen: if a service goes down, then ComputeFilter fences the attached nodes | 15:52 |
| mriedem | like you said, if the service is talking to hosts A and B, and the instance is on A and it's down, couldn't we evacuate to B? | 15:52 |
| mriedem | ah | 15:52 |
| cfriesen | mriedem: yes, I think that would make sense. (But I've only ever used nova with kvm.) | 15:53 |
| bauzas | cfriesen: mriedem: I don't think it's necessary | 15:53 |
| openstackgerrit | dave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly https://review.openstack.org/172951 | 15:53 |
| bauzas | either the service is down and then all related computes are fenced | 15:53 |
| bauzas | which is the behaviour we want | 15:53 |
| cfriesen | bauzas: the issue is if the service is up, and one of the hosts that service controls goes down. Currently that check would prevent us from evacuating to another host controlled by the same service. | 15:54 |
| bauzas | or the service is up but an host is down and then we need something to tell that we want to prevent the scheduler to serve that host | 15:54 |
| cfriesen | bauzas: actually, it's worse. if the service is still up it won't let us evacuate anywhere | 15:54 |
| bauzas | cfriesen: if the service is up and the host is down, it's still considered as valid | 15:55 |
| bauzas | cfriesen: oh right, inversed logic | 15:55 |
| *** irenab has quit IRC | 15:55 | |
| mriedem | bauzas: cfriesen: well the good news is the service is_up check is there from the original impl https://review.openstack.org/#/c/11086/ | 15:55 |
| bauzas | so, yeah, it would require a few additions, I agree | 15:55 |
| mriedem | since grizzly | 15:55 |
| *** garyk has quit IRC | 15:56 | |
| mriedem | so in the compute api could we just change that to not checking the service but checking the host? | 15:56 |
| *** dave-mccowan has joined #openstack-nova | 15:57 | |
| mriedem | this doesn't help adding a test to tempest.... :( | 15:57 |
| bauzas | mriedem: mmm | 15:57 |
| *** krtaylor has quit IRC | 15:57 | |
| cfriesen | mriedem: https://review.openstack.org/#/c/169836/8/specs/liberty/approved/report-host-fault-to-update-server-state-immediately.rst is looking at telling nova that a host is down. maybe you could use that to fake it out as long as you're on local storage. | 15:58 |
| mriedem | cfriesen: yeah, i wanted to read that spec, just hadn't done it yet | 15:58 |
| mriedem | will check that out | 15:58 |
| cfriesen | mriedem: when using openstack with vmware, do they have vmware-specific controls for doing evacuation from host to host? | 15:59 |
| cfriesen | mriedem: that spec is interesting but incomplete. I think we need to handle both cases--the compute service being reported as down as well as the host being reported as down. (and in the case of kvm those reports could come in at the same time) | 16:00 |
| bauzas | cfriesen: agreed, provided it uses the right endpoints :) | 16:00 |
| *** Longgeek has joined #openstack-nova | 16:00 | |
| cfriesen | mriedem: bauzas: internally we already have something that basically does exactly what's in that spec. but since we only use kvm we could short-circuit it and just report the service as down | 16:01 |
| *** Longgeek has quit IRC | 16:01 | |
| bauzas | cfriesen: that's what is commonly done | 16:01 |
| bauzas | cfriesen: hence the flaw | 16:01 |
| *** Longgeek has joined #openstack-nova | 16:01 | |
| bauzas | cfriesen: because the 1:N relationship just breaks that assumption | 16:01 |
| *** irenab has joined #openstack-nova | 16:02 | |
| *** erkules_ has joined #openstack-nova | 16:02 | |
| cfriesen | bauzas: it'd be interesting to find out from someone actually using 1:N how they handle evac on host failure | 16:02 |
| *** erkules has quit IRC | 16:02 | |
| bauzas | cfriesen: do you really want an answer ? :) | 16:02 |
| *** doron_afk has joined #openstack-nova | 16:03 | |
| bauzas | cfriesen: I honestly doubt that VMware clusters are doing that feature on the OpenStack side | 16:03 |
| cfriesen | bauzas: well, if they have a hypervisor-specific method of doing it already, then maybe nova doesn't need to | 16:03 |
| *** Nikolay_St has quit IRC | 16:03 | |
| *** oro has quit IRC | 16:03 | |
| bauzas | cfriesen: for Ironic, there is a one-size-fits-all thing for instances | 16:04 |
| mriedem | cfriesen: i honestly don't know the details on the vmware stuff | 16:04 |
| mriedem | garyk and tjones aren't around either | 16:04 |
| mriedem | dims might know | 16:04 |
| *** mpavone has quit IRC | 16:04 | |
| cfriesen | it would be wasteful to spend a bunch of time making a generic 1:N solution for host failure if nobody is actually going to use it | 16:05 |
| *** sahid has quit IRC | 16:05 | |
| *** ijw has joined #openstack-nova | 16:05 | |
| bauzas | cfriesen: but we need to support it, for the worst or the good | 16:05 |
| *** ociuhandu has quit IRC | 16:06 | |
| *** Longgeek has quit IRC | 16:06 | |
| bauzas | cfriesen: we can't just say "eh, nobody uses it *now* so we can make assumptions" because that's how we create tech deby | 16:06 |
| bauzas | debt | 16:06 |
| dims | cfriesen: vmware driver does not expose esxi hosts in the vsphere cluster anywhere in the Nova API or CLI. | 16:07 |
| cfriesen | dims: okay, so if a host goes down vmware will handle evacuation internally? | 16:08 |
| dims | cfriesen: yes | 16:08 |
| mriedem | dims: how is that synced back up to the instance.host entry in the nova db? | 16:08 |
| *** unicell has quit IRC | 16:09 | |
| bauzas | mriedem: dims: IIUC, the whole cluster is considered as a single compute | 16:09 |
| *** otter768 has joined #openstack-nova | 16:09 | |
| bauzas | mdbooth: correct ? | 16:09 |
| mriedem | oh | 16:09 |
| mriedem | so nova doesn't know how many hosts are behind that single cluster, so instance.host doesn't change | 16:09 |
| bauzas | mriedem: dims: and a second compute mapped to the same service just means that's a second cluster | 16:09 |
| bauzas | mriedem: yeah | 16:09 |
| mriedem | ok | 16:10 |
| bauzas | mriedem: so having to evacuate inst1 from hostA to hostB means "move from cluster A to cluster B" | 16:10 |
| bauzas | AFAIK | 16:10 |
| mriedem | hrm | 16:10 |
| dims | bauzas: no way to do that in nova vmware driver through nova cli / api | 16:10 |
| dims | see https://wiki.openstack.org/wiki/HypervisorSupportMatrix :) evacuate is empty | 16:11 |
| bauzas | dims: ok, you mean that rebuild_instance is not supported ? | 16:11 |
| *** jcoufal_ has quit IRC | 16:11 | |
| *** sdake_ has joined #openstack-nova | 16:11 | |
| *** sdake_ has quit IRC | 16:11 | |
| *** krtaylor has joined #openstack-nova | 16:11 | |
| mriedem | well.... | 16:11 |
| mriedem | evacuate has a default impl in the compute manager | 16:12 |
| *** Marga_ has joined #openstack-nova | 16:12 | |
| *** sdake_ has joined #openstack-nova | 16:12 | |
| mriedem | the only virt driver that does a unique thing with that is ironic | 16:12 |
| cfriesen | hmm..that matrix says that ironic doesn't do evacuate either | 16:12 |
| bauzas | let me check the driver.rebuild() implementation | 16:13 |
| cfriesen | wait...http://docs.openstack.org/developer/nova/support-matrix.html shows that libvirt doesn't do evacuate. that seems odd | 16:13 |
| mriedem | dims: hmm, hypervisor support matrix says that evacuate doesn't work for kvm either :) http://docs.openstack.org/developer/nova/support-matrix.html | 16:13 |
| mriedem | cfriesen: you beat me to it :) | 16:13 |
| cfriesen | :) | 16:13 |
| dims | haha, don't know about that :) | 16:13 |
| *** otter768 has quit IRC | 16:14 | |
| bauzas | okay, IIRC rebuild() is not implemented for VMware | 16:14 |
| bauzas | in the driver I mean | 16:14 |
| dims | so, using Nova API / CLI you can't move a vm from one vsphere cluster to another cluster | 16:14 |
| mriedem | cfriesen: dims: bauzas: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n3027 | 16:14 |
| *** Marga_ has quit IRC | 16:14 | |
| mriedem | that's where the driver is called, but if it doesn't impelement rebuild we use the compute manager default | 16:14 |
| mriedem | bauzas: it's only implemented in the ironic driver | 16:14 |
| mriedem | historically | 16:14 |
| *** markvoelker has joined #openstack-nova | 16:14 | |
| *** rushil_ has quit IRC | 16:15 | |
| dansmith | jaypipes: https://review.openstack.org/#/c/133663/20 <-- converts service and servicegroup to objects | 16:15 |
| *** Marga_ has joined #openstack-nova | 16:15 | |
| bauzas | mriedem: yeah that's what I'm saying, driver's rebuild is not implemented for vmware | 16:15 |
| jaypipes | dansmith: k, will look in a bit. | 16:15 |
| *** Nikolay_St has joined #openstack-nova | 16:15 | |
| jaypipes | dansmith: you mean just for the DB driver, right? | 16:15 |
| mriedem | bauzas: it's not implemented for libvrit either :) | 16:15 |
| mriedem | bauzas: it's an optional override | 16:15 |
| *** sdake has quit IRC | 16:15 | |
| bauzas | mriedem: I see | 16:16 |
| dims | i am talking from a customer pov, i have not looked in the code :) | 16:16 |
| dansmith | jaypipes: yeah, although the mc driver uses the db to list service hostnames, so it is affected too | 16:16 |
| *** emagana has quit IRC | 16:16 | |
| jaypipes | dansmith: right. design fail there. | 16:16 |
| bauzas | mriedem: reading the default impl, can see it's a destroy/respawn | 16:16 |
| mriedem | bauzas: yeah | 16:16 |
| *** emagana has joined #openstack-nova | 16:16 | |
| mriedem | it just re-uses stuff that the drivers implement | 16:17 |
| bauzas | mriedem: so that's technically possible for vmware too... | 16:17 |
| *** mtanino has quit IRC | 16:17 | |
| *** Marga_ has quit IRC | 16:18 | |
| bauzas | mriedem: not related, are you aware of the cells job progress ? | 16:18 |
| mriedem | bauzas: i'm not | 16:19 |
| *** Marga_ has joined #openstack-nova | 16:19 | |
| mriedem | it was nearly clean last week | 16:19 |
| mriedem | i'm still trying to get the cells job logs indexed | 16:19 |
| bauzas | mriedem: okay, so we have a few failures left | 16:19 |
| mriedem | speaking of, clarkb can you help here? https://review.openstack.org/#/c/172231/ | 16:19 |
| bauzas | mriedem: there is one which will be blacklisted by me | 16:19 |
| bauzas | mriedem: and there are a few left which are due to a race cond. on instance.save() | 16:20 |
| mriedem | bauzas: are there bugs/patches up for the remaining failures? | 16:20 |
| bauzas | mriedem: yeah | 16:20 |
| *** ajayaa has quit IRC | 16:20 | |
| bauzas | https://bugs.launchpad.net/nova/+bug/1443640 | 16:20 |
| openstack | Launchpad bug 1443640 in OpenStack Compute (nova) "Cells: race condition when saving an instance" [Undecided,New] - Assigned to Sylvain Bauza (sylvain-bauza) | 16:20 |
| *** dboik_ has joined #openstack-nova | 16:20 | |
| bauzas | mriedem: I'm working on fixing ^ | 16:20 |
| clarkb | mriedem can you point to a job with those logs? | 16:21 |
| *** emagana has quit IRC | 16:22 | |
| mriedem | clarkb: http://logs.openstack.org/63/133663/20/check/check-tempest-dsvm-cells/597717a/logs/ | 16:23 |
| openstackgerrit | jichenjc proposed openstack/nova-specs: Allow adjust ephemeral disks during resize https://review.openstack.org/145736 | 16:23 |
| *** Marga_ has quit IRC | 16:23 | |
| *** dboik has quit IRC | 16:23 | |
| *** panbalag has left #openstack-nova | 16:24 | |
| *** obedmr has joined #openstack-nova | 16:25 | |
| *** masayukig has quit IRC | 16:25 | |
| *** markvoelker has quit IRC | 16:26 | |
| *** Nikolay_St has quit IRC | 16:26 | |
| *** ijw has quit IRC | 16:26 | |
| *** jlanoux has quit IRC | 16:27 | |
| *** emagana has joined #openstack-nova | 16:27 | |
| *** jwcroppe has joined #openstack-nova | 16:28 | |
| mriedem | jgrimm: krtaylor: can you find someone from powerkvm that can comment on the pkvm support for numa and hugepages in this review? https://review.openstack.org/#/c/170780/ | 16:28 |
| mriedem | zkvm said it's not supported | 16:28 |
| jgrimm | mriedem, i just posted note to internal ml on it | 16:28 |
| *** baoli has quit IRC | 16:29 | |
| jgrimm | mriedem, i'm confident hugepages is supported.. i thought numa was supported, but maybe there are caveats/limitations with respect to your note about qemu 2.1 | 16:29 |
| mriedem | jgrimm: more interested in someone saying they've tested pkvm with those | 16:30 |
| markus_z | mriedem: Do you have a pointer for which openstack scenarios we (zkvm) cannot do without this support? | 16:30 |
| *** baoli_ has joined #openstack-nova | 16:30 | |
| *** annashen has joined #openstack-nova | 16:30 | |
| jgrimm | mriedem, understood. lacking a spare system atm to test quickly.. so hoping to short cut with experts on what is doable | 16:31 |
| mriedem | markus_z: http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/input-output-based-numa-scheduling.html | 16:31 |
| *** dboik has joined #openstack-nova | 16:31 | |
| *** masayukig has joined #openstack-nova | 16:31 | |
| mriedem | markus_z: http://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/virt-driver-cpu-pinning.html | 16:31 |
| *** irenab has quit IRC | 16:31 | |
| cfriesen | jgrimm: the issue is that if we enabled numa and hugepages it tries to use the new "memory-backend-file" API introduced in qemu 2.1....but there's a note there saying that it's only for x86 | 16:32 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova-specs: Ironic: Configdrive extra data https://review.openstack.org/173379 | 16:32 |
| markus_z | Thanks! | 16:32 |
| *** emagana has quit IRC | 16:32 | |
| *** irenab has joined #openstack-nova | 16:32 | |
| *** jwcroppe has quit IRC | 16:32 | |
| jgrimm | cfriesen, and we've started exploiting that API in kilo? | 16:33 |
| *** emagana has joined #openstack-nova | 16:33 | |
| *** Nic has joined #openstack-nova | 16:33 | |
| jgrimm | markus_z, also useful: https://blueprints.launchpad.net/nova/+spec/virt-driver-numa-placement | 16:33 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/nova-specs: Ironic: Configdrive extra data https://review.openstack.org/173379 | 16:33 |
| lucasagomes | :-( typo | 16:33 |
| *** artom has joined #openstack-nova | 16:34 | |
| cfriesen | jgrimm: yes, with the new NUMA pinning stuff. We now support multiple numa nodes in the guest, and each guest numa node will map to a host numa node. | 16:34 |
| markus_z | jgrimm: thanks, I will take a look | 16:34 |
| WannabeCloudHost | There is a way to change or reset an instance root password througth API OR CLI please ? nobody has an answer in room 101 ... | 16:34 |
| *** kmartin has quit IRC | 16:34 | |
| cfriesen | So if you enable cpu pinning, or multiple numa nodes in guest, or hugepages in guest, it now wants to use the new qemu API | 16:34 |
| *** amotoki has quit IRC | 16:35 | |
| *** dboik_ has quit IRC | 16:35 | |
| jgrimm | cfriesen, ok, will try to understand plans around that feature | 16:35 |
| *** pask81 has quit IRC | 16:35 | |
| *** romainh has left #openstack-nova | 16:36 | |
| *** garyk has joined #openstack-nova | 16:37 | |
| jgrimm | cfriesen, do you happen to have any handy reference to bp that droppedin the memory-backend-file API exploitation? | 16:37 |
| cfriesen | jgrimm: one sec | 16:37 |
| ndipanov | pczesno, hey | 16:37 |
| jgrimm | cfriesen, no worries, thanks | 16:37 |
| pczesno | ndipanov: will https://review.openstack.org/169245 be backported to kilo? | 16:38 |
| ndipanov | pczesno, for sure | 16:39 |
| cfriesen | jgrimm: looks like some of it was introduced by https://bugs.launchpad.net/nova/+bug/1385308 | 16:39 |
| openstack | Launchpad bug 1385308 in OpenStack Compute (nova) "Nova libvirt driver does not bind guest memory to NUMA nodes" [Medium,Fix released] - Assigned to Daniel Berrange (berrange) | 16:39 |
| pczesno | ndipanov: i found couple of issues with that patch | 16:40 |
| jgrimm | cfriesen, thanks sir | 16:40 |
| ndipanov | pczesno, go on | 16:40 |
| pczesno | ndipanov: https://bugs.launchpad.net/nova/+bug/1444021 | 16:40 |
| openstack | Launchpad bug 1444021 in OpenStack Compute (nova) "HostState.consume_from_instance fails when instance has numa topology" [Undecided,In progress] - Assigned to Przemyslaw Czesnowicz (pczesno) | 16:40 |
| *** arnaud___ has quit IRC | 16:40 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Handle config drives being stored on rbd https://review.openstack.org/123073 | 16:41 |
| *** maurosr_ is now known as maurosr | 16:41 | |
| *** rajesht has quit IRC | 16:41 | |
| *** nelsnels_ has joined #openstack-nova | 16:42 | |
| *** unicell has joined #openstack-nova | 16:42 | |
| *** unicell has quit IRC | 16:43 | |
| *** nelsnelson has quit IRC | 16:43 | |
| *** unicell has joined #openstack-nova | 16:43 | |
| *** derekh has quit IRC | 16:43 | |
| *** salv-orlando has quit IRC | 16:44 | |
| *** irenab has quit IRC | 16:45 | |
| ndipanov | pczesno, sad | 16:45 |
| *** Marga_ has joined #openstack-nova | 16:46 | |
| *** Marga_ has quit IRC | 16:46 | |
| *** nelsnels_ has quit IRC | 16:46 | |
| clarkb | mriedem: approved. I like seeing the logs before hand to make sure we got the names right and that they are in a format we can index | 16:46 |
| *** ijw has joined #openstack-nova | 16:47 | |
| ndipanov | pczesno, "and change the order in which apply_requests and numa_fit_instance_to_host | 16:47 |
| ndipanov | are called. Calling apply_requests first will remove devices from pools | 16:47 |
| ndipanov | and may make numa_fit_instance_to_host fail." | 16:47 |
| *** nelsnelson has joined #openstack-nova | 16:47 | |
| bauzas | alaski: still around for a cell question ? | 16:47 |
| ndipanov | pczesno, this is pretty much a separate bug | 16:47 |
| ndipanov | and also races could contribute to this as well | 16:48 |
| *** irenab has joined #openstack-nova | 16:48 | |
| ndipanov | so changing this means it wont' fall for the one request but may fall in the same way numa was failing before that fix | 16:48 |
| ndipanov | this is just horrible :( | 16:48 |
| ndipanov | that fix = my fix that broke it | 16:49 |
| ndipanov | sigh | 16:49 |
| bauzas | alaski: nvm, I think I understood : grand-parent cell is said 'api' for the cell_type while children and grand-children cells are both said as 'cell' for the cell_type | 16:49 |
| *** markus_z has quit IRC | 16:49 | |
| *** apuimedo has quit IRC | 16:49 | |
| *** unicell has quit IRC | 16:50 | |
| alex_xu | johnthetubaguy: cool for spec, will catch up it asap. I'm in travel, sorry for will reply late in this few days, but will try to catch up asap. | 16:51 |
| *** Marga_ has joined #openstack-nova | 16:51 | |
| dansmith | jaypipes: also in the queue for you is this: https://review.openstack.org/#/c/155006/ | 16:52 |
| dansmith | jaypipes: my -1 is just for a spelling nit, so don't let that deter you | 16:52 |
| pczesno | ndipanov: ok, i can split the patch in two | 16:52 |
| jaypipes | kk | 16:52 |
| ndipanov | pczesno, meh | 16:52 |
| ndipanov | the issue is not only that | 16:52 |
| *** apuimedo has joined #openstack-nova | 16:52 | |
| ndipanov | the issue is that apply_requests is also racy | 16:52 |
| ndipanov | and can blow up in the same way nova did | 16:53 |
| pczesno | ndipanov: hmm, i'm not sure | 16:53 |
| ndipanov | yeah I'm pretty sure | 16:53 |
| ndipanov | three concurrent requests pass the filter for 1 device | 16:54 |
| ndipanov | all of them try to claim it | 16:54 |
| ndipanov | second one blows up in consume from instance | 16:54 |
| ndipanov | fails the request | 16:54 |
| *** dsanders has joined #openstack-nova | 16:55 | |
| ndipanov | sad sad code | 16:55 |
| *** salv-orlando has joined #openstack-nova | 16:55 | |
| pczesno | yes, you are right | 16:56 |
| cfriesen | what's the proper notification driver to use with ceilometer currently? A bunch of instructions say to use "notification_driver=nova.openstack.common.notifier.rpc_notifier" but I'm pretty sure that doesn't exist anymore. | 16:56 |
| ndipanov | pczesno, anyway I will coment on it tomorrow | 16:57 |
| pczesno | ndipanov: ok, thanks | 16:57 |
| *** Marga_ has quit IRC | 16:58 | |
| alaski | bauzas: correct. cells got into a weird state where some things support more than 2 tiers and other things assume 2 | 16:58 |
| pczesno | ndipanov: the CI to test the numa stuff is alomost ready, should be commenting in a week or two | 16:59 |
| *** apuimedo has quit IRC | 16:59 | |
| *** harlowja has joined #openstack-nova | 16:59 | |
| pczesno | ndipanov: that would catch at least some of those problems | 16:59 |
| bauzas | alaski: trying to understand the need of that instance_update_at_top() stuff | 16:59 |
| bauzas | alaski: because it just assumes that we're changing something on the compute side which was not done on the api side | 17:00 |
| johnthetubaguy | alex_xu: no problems, thanks for looking | 17:00 |
| bauzas | alaski: which is acceptable, but with problems | 17:00 |
| bauzas | I'm goint to get that cells job green ! | 17:00 |
| alaski | bauzas: things can definitely change in a cell without coming in from the api | 17:01 |
| alaski | so instance_update_at_top is necessary | 17:01 |
| *** ijw has quit IRC | 17:01 | |
| *** rmstar has joined #openstack-nova | 17:02 | |
| *** ijw has joined #openstack-nova | 17:02 | |
| rmstar | hi guys. i just want to run something by you and see if this it shoule fixed or not. | 17:02 |
| alaski | bauzas: what we need is some way to call instance.save(sync_cell=False), but preferable without actually modifying the save signature | 17:02 |
| *** aswadr has joined #openstack-nova | 17:03 | |
| bauzas | alaski: yeah, I don't like amending signatured | 17:03 |
| bauzas | s* | 17:03 |
| rmstar | i am using icehouse, and noticed that we are able to rename a flavor that is being used by an instance. This should not happen, right? | 17:03 |
| bauzas | alaski: but I'm also taking time for reviewing cells code | 17:03 |
| bauzas | alaski: messaging module is reponsible for propagating manager's messages to either a specific cell or more ? | 17:04 |
| *** tonytan4ever has quit IRC | 17:04 | |
| alaski | bauzas: the messaging module is for cell->cell communication, yes | 17:05 |
| bauzas | alaski: ok, I can see the manager passing the CellStateManager to the MessageRunner | 17:05 |
| bauzas | alaski: so the messaging.MessageRunner knows how to triage those messages using the statemanager, understood | 17:06 |
| *** irenab has quit IRC | 17:06 | |
| *** sdake has joined #openstack-nova | 17:07 | |
| *** sudipto has joined #openstack-nova | 17:08 | |
| *** Marga_ has joined #openstack-nova | 17:08 | |
| *** annashen has quit IRC | 17:08 | |
| *** doron_afk has quit IRC | 17:09 | |
| *** jwcroppe has joined #openstack-nova | 17:09 | |
| *** armax_ has left #openstack-nova | 17:09 | |
| *** armax has joined #openstack-nova | 17:09 | |
| *** sdake_ has quit IRC | 17:11 | |
| *** tonytan4ever has joined #openstack-nova | 17:11 | |
| mriedem | clarkb: nice, thanks | 17:12 |
| *** sdake_ has joined #openstack-nova | 17:14 | |
| *** jwcroppe has quit IRC | 17:16 | |
| *** dprince has joined #openstack-nova | 17:18 | |
| *** sdake has quit IRC | 17:18 | |
| *** aix has quit IRC | 17:18 | |
| *** dkliban_afk is now known as dkliban | 17:19 | |
| *** raph__ has quit IRC | 17:20 | |
| *** ndipanov has quit IRC | 17:22 | |
| *** isd has joined #openstack-nova | 17:23 | |
| *** jichen has quit IRC | 17:23 | |
| *** kmartin has joined #openstack-nova | 17:24 | |
| * artom tries his luck again since it wasn't fully cleared up yesterday. | 17:25 | |
| artom | About the SPICE html5 console. | 17:25 |
| *** mpaolino has quit IRC | 17:25 | |
| artom | The server_proxyclient_address config option is "The address to which proxy clients (like nova-spicehtml5proxy) should connect" | 17:26 |
| artom | I understand that as "the SPICE proxy will use that address as the SPICE server (ie, the compute host on which the instance being console'd is running) | 17:26 |
| *** patrickeast has joined #openstack-nova | 17:26 | |
| artom | Testing does confirm that - ie, setting it to 'foobar' will see nova-spicehtml5proxy attempt to connect to foobar and fail. | 17:27 |
| artom | I'm clearly missing something here, how was this meant to work in deployments with more than one compute? | 17:27 |
| dansmith | artom: that is so that the compute host knows what the client-visible proxy address is going to be right? | 17:29 |
| dansmith | artom: like vladikr said yesterday, the intent is to run one proxy out front that proxies connections for all the compute hosts, so that you don't expose the compute hosts directly | 17:30 |
| dansmith | spice could be different or broken, but that's the goal of the console proxy in general | 17:30 |
| *** browne has quit IRC | 17:30 | |
| dansmith | (and to do the openstack auth bit, of course) | 17:30 |
| *** sdake has joined #openstack-nova | 17:31 | |
| artom | dansmith, yeah, I get the intent. | 17:31 |
| artom | It "reassures" me to hear you say that SPICE might be broken... | 17:32 |
| dansmith | I expect it's not, | 17:32 |
| dansmith | but fewer people here probably know the details of the spice implementation | 17:32 |
| artom | Like you said, one proxy in front of all/many compute hosts. That implies code to look up which compute host the instance is on. And I can't find that code anywhere. | 17:33 |
| artom | All I managed to find is that config option which apparently hardcodes it. | 17:33 |
| vladikr | artom, no, it's not, I think you are looking at the part that creates the socket on the host and then provides that socket to the proxy, in order to connect it to the source connected socket) | 17:33 |
| dansmith | yeah | 17:33 |
| dansmith | artom: get_spice_console() calls the correct compute host based on the instance | 17:34 |
| dansmith | and gets the console connection information, right? | 17:34 |
| dansmith | that's where the which-compute-host switch happens | 17:34 |
| dansmith | (rpcapi.py) | 17:34 |
| dansmith | (compute/rpcapi.py) | 17:34 |
| *** sdake_ has quit IRC | 17:35 | |
| *** Marga_ has quit IRC | 17:35 | |
| artom | https://github.com/openstack/nova/blob/master/nova/compute/rpcapi.py#L535 | 17:35 |
| *** VW_ has quit IRC | 17:35 | |
| artom | dansmith ^^ | 17:35 |
| dansmith | artom: right | 17:35 |
| artom | The server=_compute_host(None, instance) bit? | 17:35 |
| *** Marga_ has joined #openstack-nova | 17:35 | |
| artom | Goddammit, of course. | 17:36 |
| *** Marga_ has quit IRC | 17:36 | |
| artom | That's so unlike what I was expecting... | 17:36 |
| artom | And so "innocuous" | 17:36 |
| *** Marga_ has joined #openstack-nova | 17:36 | |
| dansmith | it's how almost everything we do host-per-instance happens | 17:36 |
| artom | So the RPC API handles sending the call to the right compute node. | 17:36 |
| *** boris-42 has quit IRC | 17:38 | |
| artom | And so then server_proxyclient_address is for the compute node to know it's "external" IP address. | 17:38 |
| *** rushil has joined #openstack-nova | 17:39 | |
| artom | More precisely, the IP address through which the proxy can reach it. | 17:39 |
| *** ajayaa has joined #openstack-nova | 17:40 | |
| *** hdd has joined #openstack-nova | 17:41 | |
| jogo | johnthetubaguy: https://review.openstack.org/#/c/139272/ dropped my -2 on that one, anything else? | 17:41 |
| *** lucasagomes is now known as lucas-dinner | 17:42 | |
| johnthetubaguy | jogo: I don't remember, I think there were a few at the back end of the list of spec reviews: https://review.openstack.org/#/q/project:openstack/nova-specs+status:open,n,0032ddd30001ff67 | 17:42 |
| *** tonytan4ever has quit IRC | 17:44 | |
| *** sdake_ has joined #openstack-nova | 17:44 | |
| *** johnthetubaguy is now known as zz_johnthetubagu | 17:45 | |
| *** sdake has quit IRC | 17:45 | |
| artom | dansmith, much thanks :) I was missing that crucial rpcapi bit. | 17:46 |
| *** eglynn has quit IRC | 17:46 | |
| *** dboik has quit IRC | 17:47 | |
| *** dboik has joined #openstack-nova | 17:48 | |
| *** sdake_ has quit IRC | 17:48 | |
| *** sdake has joined #openstack-nova | 17:48 | |
| *** diegows has joined #openstack-nova | 17:48 | |
| *** ganso_ has joined #openstack-nova | 17:49 | |
| jogo | zz_johnthetubagu: thanks | 17:49 |
| ganso_ | mriedem: Hello | 17:49 |
| ganso_ | mriedem: I have not been able to recreate the problem, I rebuilt the Red Hat OpenStack 6 environment from scratch, and now either the problem is gone, or is random and has not appeared since | 17:50 |
| *** achanda has joined #openstack-nova | 17:51 | |
| ganso_ | mriedem: It could be a configuration problem present in the previous environment | 17:51 |
| mriedem | ganso_: ok | 17:51 |
| mriedem | we still have it in the community gate i think | 17:51 |
| mriedem | so maybe i'll just recheck until we hit it, but it's rare | 17:52 |
| *** sdake has quit IRC | 17:52 | |
| *** sdake has joined #openstack-nova | 17:52 | |
| ganso_ | mriedem: ok, I will let you know if I find anything related to it. Thanks for creating the patch, sorry for not being able to test it for you :\ | 17:52 |
| mriedem | ganso_: np | 17:53 |
| *** eharney_ has joined #openstack-nova | 17:53 | |
| *** pczesno is now known as zzz_pczesno | 17:54 | |
| *** eharney has quit IRC | 17:54 | |
| dansmith | artom: no problem | 17:54 |
| *** eharney_ is now known as eharney | 17:55 | |
| *** Nic1 has joined #openstack-nova | 17:58 | |
| *** heyongli has quit IRC | 17:58 | |
| *** aswadr has quit IRC | 17:59 | |
| *** Nic has quit IRC | 17:59 | |
| *** dboik_ has joined #openstack-nova | 18:00 | |
| *** baoli_ has quit IRC | 18:01 | |
| *** hdd has quit IRC | 18:01 | |
| *** tonytan4ever has joined #openstack-nova | 18:02 | |
| *** dboik has quit IRC | 18:03 | |
| *** ajayaa has quit IRC | 18:04 | |
| *** jamielennox|away is now known as jamielennox | 18:05 | |
| *** baoli has joined #openstack-nova | 18:06 | |
| *** Hosam has quit IRC | 18:07 | |
| *** Hosam has joined #openstack-nova | 18:08 | |
| *** VW_ has joined #openstack-nova | 18:08 | |
| *** otter768 has joined #openstack-nova | 18:10 | |
| *** krtaylor has quit IRC | 18:12 | |
| *** heyongli has joined #openstack-nova | 18:12 | |
| *** Hosam has quit IRC | 18:12 | |
| rwsu | anyone know to which queue the compute.instance.create.{start,error,end} amqp messages are sent? | 18:13 |
| rwsu | I'm not seeing them in notifications.info | 18:14 |
| *** otter768 has quit IRC | 18:14 | |
| *** jwcroppe has joined #openstack-nova | 18:15 | |
| *** Mike_D_laptop has joined #openstack-nova | 18:19 | |
| *** yamahata has quit IRC | 18:22 | |
| *** salv-orlando has quit IRC | 18:25 | |
| *** tellesnobrega has quit IRC | 18:25 | |
| *** markvoelker has joined #openstack-nova | 18:25 | |
| *** sdake_ has joined #openstack-nova | 18:25 | |
| *** tellesnobrega has joined #openstack-nova | 18:26 | |
| *** jwcroppe has quit IRC | 18:27 | |
| *** tellesnobrega_ has joined #openstack-nova | 18:27 | |
| *** tellesnobrega_ has quit IRC | 18:27 | |
| *** sdake has quit IRC | 18:29 | |
| *** Marga_ has quit IRC | 18:29 | |
| *** tellesnobrega has quit IRC | 18:29 | |
| *** tellesnobrega has joined #openstack-nova | 18:29 | |
| *** tpatil has joined #openstack-nova | 18:30 | |
| *** markvoelker has quit IRC | 18:31 | |
| *** nelsnels_ has joined #openstack-nova | 18:31 | |
| *** Anticimex has quit IRC | 18:33 | |
| *** Anticimex has joined #openstack-nova | 18:33 | |
| *** nelsnels_ has quit IRC | 18:34 | |
| *** nelsnelson has quit IRC | 18:34 | |
| *** rushil has quit IRC | 18:34 | |
| *** nelsnelson has joined #openstack-nova | 18:34 | |
| *** rajesht has joined #openstack-nova | 18:39 | |
| *** sdake has joined #openstack-nova | 18:39 | |
| *** mleroy has quit IRC | 18:41 | |
| *** rajesht has quit IRC | 18:43 | |
| *** sdake_ has quit IRC | 18:43 | |
| *** yamahata has joined #openstack-nova | 18:45 | |
| *** browne has joined #openstack-nova | 18:45 | |
| *** pixelb has quit IRC | 18:47 | |
| *** baoli has quit IRC | 18:48 | |
| cfriesen | rwsu: for what it's worth, I'm having issues with notifications as well. I'm on a wonky setup though, so could very well be something local. | 18:48 |
| cfriesen | rwsu: are you getting other notifications from nova? | 18:49 |
| *** Marga_ has joined #openstack-nova | 18:50 | |
| *** annegentle has joined #openstack-nova | 18:50 | |
| rwsu | cfriesen: I am seeing the internal notifications. I think my probem is I don't have config files setup to send notifications, https://ask.openstack.org/en/question/56034/how-to-make-nova-send-notifications/ | 18:52 |
| *** VW_ has quit IRC | 18:53 | |
| *** oro has joined #openstack-nova | 18:53 | |
| *** mleroy has joined #openstack-nova | 18:54 | |
| openstackgerrit | Radoslaw Smigielski proposed openstack/nova: New sensible network bandwidth quota values in Nova tests https://review.openstack.org/173467 | 18:54 |
| *** VW_ has joined #openstack-nova | 18:54 | |
| *** annashen has joined #openstack-nova | 18:56 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Handle config drives being stored on rbd https://review.openstack.org/123073 | 19:02 |
| dansmith | mriedem: wanna take a look at this one ^ ? | 19:03 |
| *** baoli has joined #openstack-nova | 19:03 | |
| dansmith | it's been hanging for a long time and I've been trying to keep it fresh | 19:03 |
| *** krtaylor has joined #openstack-nova | 19:03 | |
| mriedem | dansmith: bad time today for in depth reviews, locked in a CR all day today | 19:04 |
| dansmith | okay | 19:04 |
| mriedem | dansmith: callback on that another day? | 19:04 |
| dansmith | sure | 19:04 |
| *** vilobhmm11 has joined #openstack-nova | 19:07 | |
| *** rushiagr is now known as rushiagr_away | 19:10 | |
| *** dave-mccowan has quit IRC | 19:10 | |
| *** sudipto has quit IRC | 19:12 | |
| *** diegows has quit IRC | 19:16 | |
| *** oro has quit IRC | 19:17 | |
| *** mtanino has joined #openstack-nova | 19:18 | |
| *** annashen has quit IRC | 19:22 | |
| *** aix has joined #openstack-nova | 19:23 | |
| *** aysyd has quit IRC | 19:25 | |
| *** aysyd has joined #openstack-nova | 19:25 | |
| *** kmartin has quit IRC | 19:26 | |
| *** salv-orlando has joined #openstack-nova | 19:26 | |
| openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Replace service groups with the tooz groups https://review.openstack.org/138607 | 19:28 |
| *** markvoelker has joined #openstack-nova | 19:29 | |
| *** dguitarbite has quit IRC | 19:29 | |
| *** welldannit has joined #openstack-nova | 19:32 | |
| *** andreykurilin has joined #openstack-nova | 19:32 | |
| *** moshele has joined #openstack-nova | 19:33 | |
| *** nelsnels_ has joined #openstack-nova | 19:33 | |
| *** dave-mccowan has joined #openstack-nova | 19:33 | |
| *** markvoelker has quit IRC | 19:34 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Start the conversion to oslo.versionedobjects https://review.openstack.org/173479 | 19:34 |
| *** nelsnelson has quit IRC | 19:36 | |
| mikal | . | 19:36 |
| *** sdake_ has joined #openstack-nova | 19:37 | |
| *** dave-mccowan has quit IRC | 19:37 | |
| mtreinish | mikal: .... . .-.. .-.. --- | 19:37 |
| *** salv-orlando has quit IRC | 19:37 | |
| *** sdake has quit IRC | 19:41 | |
| *** dboik_ has quit IRC | 19:42 | |
| moshele | hi can nova cores review https://review.openstack.org/#/c/168317/ and https://review.openstack.org/#/c/168680/ ? | 19:43 |
| *** obondarev_ has joined #openstack-nova | 19:43 | |
| *** vilobhmm11 has quit IRC | 19:47 | |
| dims | mtreinish: .... .- .... .- | 19:47 |
| *** vilobhmm1 has joined #openstack-nova | 19:47 | |
| mtreinish | dims: heh, it looses something in the translation :) | 19:49 |
| *** mtanino has quit IRC | 19:49 | |
| mtreinish | s/looses/loses | 19:49 |
| dims | :) | 19:49 |
| *** obondarev has quit IRC | 19:49 | |
| *** jwcroppe has joined #openstack-nova | 19:49 | |
| vilobhmm1 | dansmith : ping | 19:49 |
| dansmith | vilobhmm1: ack | 19:49 |
| vilobhmm1 | :) | 19:50 |
| vilobhmm1 | i could not understand your comment on https://review.openstack.org/#/c/138607/ | 19:50 |
| vilobhmm1 | please let me know if you have any feedback would be happy to discuss | 19:50 |
| vilobhmm1 | incorporate | 19:50 |
| dansmith | vilobhmm1: which comment? | 19:50 |
| *** jwcroppe has quit IRC | 19:50 | |
| vilobhmm1 | Dan Smith | 19:51 |
| vilobhmm1 | 9:04 AM | 19:51 |
| vilobhmm1 | Patch Set 11: -Code-Review | 19:51 |
| *** sdake has joined #openstack-nova | 19:51 | |
| vilobhmm1 | not sure what that means so thought will check with you | 19:51 |
| dansmith | vilobhmm1: that was me dropping my -2 now that liberty is open | 19:51 |
| dansmith | it's a vote of 0 | 19:51 |
| vilobhmm1 | oh ok | 19:51 |
| vilobhmm1 | cool sounds good… | 19:51 |
| *** ozialien has joined #openstack-nova | 19:52 | |
| vilobhmm1 | johnthetubaguy : ping | 19:53 |
| dansmith | vilobhmm1: probably a little late for him.. he'll get to dropping his -2 too | 19:53 |
| vilobhmm1 | sounds good dansmith; thanks :) | 19:54 |
| *** sdake_ has quit IRC | 19:54 | |
| *** kmartin has joined #openstack-nova | 19:57 | |
| moshele | dansmith: when you have time please review https://review.openstack.org/#/c/168317/ | 19:57 |
| vilobhmm1 | dansmith : same for https://review.openstack.org/#/c/138607/ when you get time please have a look | 19:59 |
| *** setuid has quit IRC | 19:59 | |
| *** setuid has joined #openstack-nova | 20:01 | |
| *** achanda has quit IRC | 20:01 | |
| *** jdurgin has joined #openstack-nova | 20:01 | |
| *** garyk has quit IRC | 20:02 | |
| *** sdake_ has joined #openstack-nova | 20:05 | |
| *** sdake has quit IRC | 20:07 | |
| *** otter768 has joined #openstack-nova | 20:11 | |
| *** jgrimm is now known as zz_jgrimm | 20:11 | |
| *** unicell has joined #openstack-nova | 20:11 | |
| *** nelsnels_ has quit IRC | 20:12 | |
| *** ozialien has quit IRC | 20:12 | |
| *** nelsnelson has joined #openstack-nova | 20:13 | |
| *** andreykurilin has quit IRC | 20:13 | |
| *** oro has joined #openstack-nova | 20:13 | |
| *** jwcroppe has joined #openstack-nova | 20:14 | |
| *** dave-mccowan has joined #openstack-nova | 20:14 | |
| *** otter768 has quit IRC | 20:16 | |
| *** lucas-dinner has quit IRC | 20:17 | |
| *** jwcroppe has quit IRC | 20:17 | |
| *** annashen has joined #openstack-nova | 20:18 | |
| *** erkules_ is now known as erkules | 20:19 | |
| *** signed8bit has joined #openstack-nova | 20:22 | |
| *** eharney has quit IRC | 20:23 | |
| *** pixelb has joined #openstack-nova | 20:23 | |
| *** sdake has joined #openstack-nova | 20:23 | |
| openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Skip initial sync of block_device_mapping https://review.openstack.org/173502 | 20:24 |
| *** ijw has quit IRC | 20:24 | |
| *** achanda has joined #openstack-nova | 20:25 | |
| *** ijw has joined #openstack-nova | 20:25 | |
| *** sdake_ has quit IRC | 20:25 | |
| *** ganso_ has quit IRC | 20:27 | |
| *** Marga_ has quit IRC | 20:28 | |
| *** Hosam has joined #openstack-nova | 20:28 | |
| *** Nikolay_St has joined #openstack-nova | 20:29 | |
| *** ijw has quit IRC | 20:29 | |
| *** claudiub has joined #openstack-nova | 20:30 | |
| *** baoli has quit IRC | 20:32 | |
| *** ijw has joined #openstack-nova | 20:33 | |
| *** salv-orlando has joined #openstack-nova | 20:33 | |
| *** thangp has quit IRC | 20:33 | |
| *** markvoelker has joined #openstack-nova | 20:33 | |
| *** vladikr has quit IRC | 20:33 | |
| *** vilobhmm1 has quit IRC | 20:35 | |
| *** tjones1 has joined #openstack-nova | 20:36 | |
| *** changbl has quit IRC | 20:37 | |
| *** lifeless1 is now known as lifeless | 20:37 | |
| *** markvoelker has quit IRC | 20:37 | |
| *** apuimedo has joined #openstack-nova | 20:40 | |
| cfriesen | mriedem: you around? | 20:42 |
| *** moshele has quit IRC | 20:43 | |
| mriedem | cfriesen: sort of | 20:43 |
| *** neelashah has quit IRC | 20:43 | |
| *** dboik has joined #openstack-nova | 20:43 | |
| jogo | have we cut the last release of novaclient for Kilo? | 20:44 |
| jogo | if so we should get ready to create the stable/kilo branch of novaclient | 20:44 |
| *** ivasev has joined #openstack-nova | 20:45 | |
| mriedem | jogo: this came up last week https://review.openstack.org/#/c/165932/ | 20:46 |
| mriedem | i'm not sure if that needs a new bug fix release though | 20:47 |
| *** ozialien has joined #openstack-nova | 20:47 | |
| mriedem | it depends on this nova change https://review.openstack.org/#/c/166401/ | 20:47 |
| mriedem | so it's a bit wonky | 20:47 |
| *** apuimedo has quit IRC | 20:47 | |
| *** dboik has quit IRC | 20:49 | |
| jogo | mriedem: we could release a bug fix for it but not bump the minimum | 20:49 |
| *** dboik has joined #openstack-nova | 20:49 | |
| jogo | but we should create the stable/kilo novaclient branch around the same time a stable branch shows up in g-r | 20:50 |
| cfriesen | mriedem: I've been digging into the evacuate issues with another guy here. in libvirt/driver.py in _create_domain_and_network() we call self._get_neutron_events() to figure out what events to wait for. In the successful evacuates the events list is empty, while in the unsuccessful ones the event list is not empty. | 20:50 |
| jogo | dhellmann: ^^ does that sound about right? | 20:50 |
| mriedem | jogo: i haven't kept up to speed on the stable branches for the clients | 20:50 |
| mriedem | not sure what those are for | 20:50 |
| cfriesen | mriedem: in the unsuccessful case nova sits waiting for the events, but because the new host doesn't match the binding neutron will never send it the event | 20:51 |
| mriedem | are we going to release bug fix releases off the stable branches for the clients? | 20:51 |
| *** sbfox has quit IRC | 20:51 | |
| *** dboik has quit IRC | 20:51 | |
| mriedem | cfriesen: hmmm, and then we timeout after 5 minutes and fail the build | 20:52 |
| *** dboik has joined #openstack-nova | 20:52 | |
| jogo | mriedem: maybe, we want to keep the option open to do so | 20:52 |
| mriedem | cfriesen: i'd have to dig into what's populating the event list | 20:52 |
| cfriesen | mriedem: in the successful cases the binding is still wrong in neutron, but because we don't wait for it it doesn't cause problems | 20:52 |
| mriedem | cfriesen: right | 20:52 |
| jogo | mriedem: without a massive reqs change | 20:52 |
| mriedem | jogo: yeah, i see the appearl | 20:52 |
| mriedem | *appeal | 20:52 |
| cfriesen | mriedem: so interestingly, most of the time with 2 compute nodes you can evac back and forth okay because in one direction we don't wait and in the other direction the binding is correct. | 20:53 |
| *** hdd has joined #openstack-nova | 20:53 | |
| dansmith | cfriesen: is neutron at fault or are we? | 20:53 |
| jogo | mikal: ^ stable/kilo for novaclient | 20:53 |
| mikal | jogo: in the tc meeting, please hold | 20:53 |
| cfriesen | dansmith: I think we are...we need to call _update_port_binding_for_instance() during the evacuate I think, same as we do for live migration | 20:53 |
| dansmith | meaning neutron needs to be told that the host is changing or something? | 20:54 |
| cfriesen | dansmith: yes | 20:54 |
| dansmith | so it knows the host is different and fires the event? | 20:54 |
| dansmith | okay | 20:54 |
| cfriesen | dansmith: the guy I was working with has done more neutron work...he said something about neutron ignoring events where the host doesn't match what it expects from the binding | 20:55 |
| dansmith | s/events/requests, I assume you mean | 20:56 |
| mriedem | cfriesen: dansmith: yeah, we definitely aren't updating the port binding in the neutronv2 api code in the evacuate flow | 20:56 |
| dansmith | so wait | 20:56 |
| dansmith | WAIT | 20:56 |
| dansmith | evacuate is broken? | 20:56 |
| mriedem | ha | 20:56 |
| cfriesen | :) | 20:56 |
| mriedem | surprise! | 20:56 |
| dansmith | broken-er | 20:56 |
| * dansmith gets out the torch | 20:56 | |
| *** signed8bit is now known as signed8bit_ZZZzz | 20:57 | |
| mriedem | cfriesen: so can you play with calling network_api.setup_instance_network_on_host in evacuate? | 20:57 |
| *** dkliban is now known as dkliban_afk | 20:57 | |
| cfriesen | dansmith: mriedem: so currently even on a "successful" evacuate, nova shows the ports in the BUILD status | 20:57 |
| cfriesen | whoops, neutron | 20:58 |
| *** raildo has quit IRC | 20:58 | |
| cfriesen | dansmith: mriedem: that's for the ones where nova isn't waiting but the host doesn't match the port binding | 20:58 |
| cfriesen | mriedem: do we want to call that or just _update_port_binding_for_instance()? | 20:59 |
| *** signed8bit_ZZZzz is now known as signed8bit | 20:59 | |
| cfriesen | mriedem: oh wait, it's basically the same thing. | 20:59 |
| cfriesen | mriedem: will give it a shot | 21:00 |
| *** ozialien has left #openstack-nova | 21:01 | |
| *** jecarey has quit IRC | 21:02 | |
| *** vilobhmm1 has joined #openstack-nova | 21:02 | |
| *** vilobhmm1 has quit IRC | 21:03 | |
| *** vilobhmm1 has joined #openstack-nova | 21:03 | |
| *** hdd has quit IRC | 21:04 | |
| *** obedmr has left #openstack-nova | 21:06 | |
| *** vilobhmm1 has quit IRC | 21:07 | |
| *** vilobhmm1 has joined #openstack-nova | 21:08 | |
| *** aysyd has quit IRC | 21:08 | |
| mikal | jogo: ok, so hello. What are we talking about? | 21:10 |
| mriedem | cfriesen: yeah, you have to call the public network api, which calls the internal method | 21:10 |
| *** marun has quit IRC | 21:13 | |
| dansmith | mikal: are we going to have a conversation about the rc2 bugs? | 21:14 |
| *** annegentle has quit IRC | 21:14 | |
| dansmith | mikal: the list is pretty long and probably some of them can be early backports, IMHO | 21:14 |
| dansmith | but there are some that are really critical and I don't want those to get missed | 21:14 |
| *** dprince has quit IRC | 21:14 | |
| *** apuimedo has joined #openstack-nova | 21:14 | |
| *** ivasev has quit IRC | 21:15 | |
| jogo | mikal: we should get cut a stable/juno novaclient branch | 21:16 |
| jogo | so that if we need to backport a bug fix to novaclient version in stable/kilo we can | 21:17 |
| mikal | dansmith: I am not allowed to say that there will be a rc2, but I think its very very likely | 21:17 |
| mikal | dansmith: so, things which are ready in that list get into rc2 I imagine | 21:17 |
| dansmith | mikal: right, I meant, you know, hypothetically, if we had one | 21:17 |
| dansmith | mikal: the list seems too long for an rc2, is my point | 21:17 |
| mikal | dansmith: if it shouldn't be in rc2, we should untag it and just work it through the nromal stabel backport process | 21:17 |
| mikal | stable even | 21:18 |
| mikal | dansmith: yeah, I agree | 21:18 |
| dansmith | right, so what I'm saying is, are we going to run through that list and decide what should be dropped? | 21:18 |
| mikal | dansmith: I think we dal with that as tag hygiene | 21:18 |
| mikal | dansmith: yes, but we can't do that until we "decide" to do an rc2 | 21:18 |
| *** oro has quit IRC | 21:18 | |
| mikal | So, next week ish? | 21:18 |
| dansmith | okay, just want to make sure we do that review, if and when we do an rc2 | 21:19 |
| mikal | dansmith: its a fair point. Want to reply to that effect to my email so we have a written reminder? | 21:20 |
| mikal | jogo: I am unsure how to do that thing? How do we make branches like that? | 21:20 |
| mikal | jogo: not opposed, just unsure of the process | 21:20 |
| dansmith | okay | 21:20 |
| *** pixelb has quit IRC | 21:20 | |
| *** annashen has quit IRC | 21:21 | |
| *** annashen has joined #openstack-nova | 21:22 | |
| jogo | mikal: same process as cutting a branch on nova | 21:22 |
| alaski | looking for a third perspective on https://review.openstack.org/#/c/171299/ to tell me if I'm overthinking it | 21:22 |
| jogo | mikal: https://review.openstack.org/#/admin/projects/openstack/python-novaclient,branches | 21:23 |
| mikal | jogo: how are they made? Some config file in infra land somewhere? | 21:24 |
| *** WannabeCloudHost has quit IRC | 21:24 | |
| *** jecarey has joined #openstack-nova | 21:26 | |
| *** cbader has quit IRC | 21:30 | |
| jogo | mikal: no, you just pass in a sha1 and a name | 21:31 |
| mikal | jogo: so, the gerrit UI is read only for me | 21:31 |
| mikal | jogo: I don't see a place to actually make the branch? | 21:31 |
| * mikal has asked infra for a hint | 21:31 | |
| jogo | https://wiki.openstack.org/wiki/ReleaseTeam/How_To_Release | 21:31 |
| jogo | mikal: its self service | 21:31 |
| jogo | mikal: you may not have the power to make a branch | 21:32 |
| mikal | Hmmmm, fungi recons the release managers might be helping do those | 21:33 |
| mikal | I will ping ttx and ask | 21:34 |
| *** tonytan4ever has quit IRC | 21:34 | |
| *** busterswt has quit IRC | 21:35 | |
| *** boris-42 has joined #openstack-nova | 21:39 | |
| *** annashen has quit IRC | 21:40 | |
| *** jwcroppe has joined #openstack-nova | 21:42 | |
| mikal | jogo: ttx says he and dhellmann are going to do all the stable branches tomorrow | 21:42 |
| * mikal wanders off to get out of pjs | 21:43 | |
| jogo | mikal: cool that works | 21:44 |
| jogo | mikal: thanks for sharing, 'the more you know' :) | 21:44 |
| mikal | jogo: well, I have been here for your entertainment since 5:30am my time | 21:44 |
| mikal | :P | 21:44 |
| jogo | wow | 21:45 |
| *** signed8bit has quit IRC | 21:46 | |
| *** tpatil has quit IRC | 21:47 | |
| bauzas | alaski: eh you beated me by https://review.openstack.org/#/c/173513/1 :) | 21:47 |
| alaski | bauzas: heh. I'm looking at the disk_config failure again so I haven't opened one for that and the idempotent failure | 21:48 |
| cfriesen | mreidem: dansmith: in compute.manager.ComputeManager.rebuild_instance I added a call to self.network_api.setup_instance_network_on_host() right below the existing call to self.network_api.setup_networks_on_host(). That seems to fix the issue with the neutron binding:host_id. I wonder if it would make sense to just have neutron's setup_networks_on_host() (which is currently empty) call self._update_port_binding_for_instance() | 21:48 |
| cfriesen | instead? | 21:48 |
| *** apuimedo has quit IRC | 21:49 | |
| *** mwagner_lap has quit IRC | 21:50 | |
| cfriesen | hmm...setup_networks_on_host() gets called from a bunch of places | 21:50 |
| bauzas | alaski: I'm rebooting my cells devstack to see if adding a new private field for the Instance object could help the race issue | 21:50 |
| bauzas | alaski: because we're passing the same object down to the child cell | 21:51 |
| *** annegentle has joined #openstack-nova | 21:51 | |
| cfriesen | why do we have setup_networks_on_host() (which also does teardown), setup_instance_network_on_host(), and cleanup_instance_network_on_host()? | 21:51 |
| alaski | bauzas: great | 21:52 |
| bauzas | alaski: yeah, instance_update_from_api() is called in Instance.save() | 21:52 |
| bauzas | then it goes to the messaging module, and then do an instance.save() too | 21:53 |
| bauzas | alaski: as it's now on the child cell, that's why it goes back up | 21:53 |
| alaski | bauzas: yeah. we need something like 'with dont_sync_cells: instance.save()' | 21:53 |
| alaski | just for when it's called in instance_update_from_api | 21:54 |
| alaski | and later when we add it to instance_update_at_top | 21:54 |
| *** mriedem is now known as mriedem_away | 21:56 | |
| *** asettle has joined #openstack-nova | 21:56 | |
| cfriesen | Any chance of getting another core to look at https://review.openstack.org/#/c/162746/ ? It's already got a bunch of +1s and a +2. | 21:58 |
| *** mriedem_away has quit IRC | 22:00 | |
| bauzas | alaski: you mean in the save method ? | 22:01 |
| *** marun has joined #openstack-nova | 22:01 | |
| alaski | bauzas: something needs to tell save that it shouldn't call instance_update_at|from_top|api | 22:03 |
| bauzas | alaski: yeah, that's why I think we need to leave an indirection field | 22:04 |
| bauzas | alaski: anyway, I will work on it by tomorrow | 22:05 |
| *** isd has quit IRC | 22:05 | |
| *** thomasem has quit IRC | 22:05 | |
| jogo | dansmith: looking over https://bugs.launchpad.net/nova/+bugs?field.tag=kilo-rc-potential | 22:07 |
| jogo | and there are a e few we can remove I think | 22:08 |
| bauzas | jogo: yeah I have one I can remove | 22:08 |
| jogo | alaski: I was thinking we can remove https://bugs.launchpad.net/nova/+bug/1404268 | 22:08 |
| openstack | Launchpad bug 1404268 in OpenStack Compute (nova) "Missing nova context during spawn" [High,In progress] - Assigned to Andrew Laski (alaski) | 22:08 |
| *** burt has quit IRC | 22:08 | |
| jogo | bauzas: link? | 22:08 |
| bauzas | jogo: just did https://bugs.launchpad.net/nova/+bug/1431291 | 22:09 |
| openstack | Launchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 22:09 |
| alaski | jogo: I think that one is worth having. logs are problematic atm on computes | 22:09 |
| jogo | alaski: no one is working on it | 22:09 |
| jogo | alaski: we can backport right away | 22:09 |
| jogo | oh are you working on it now? | 22:10 |
| alaski | jogo: I have a review open for it | 22:10 |
| *** markvoelker has joined #openstack-nova | 22:10 | |
| jogo | alaski: that changes things | 22:10 |
| jogo | link? | 22:10 |
| alaski | jogo: https://review.openstack.org/#/c/171299/ | 22:10 |
| *** armax has quit IRC | 22:10 | |
| *** markvoelker_ has joined #openstack-nova | 22:10 | |
| *** ociuhandu has joined #openstack-nova | 22:11 | |
| jogo | alaski: cool, I'll let you and dims hash that one out | 22:11 |
| *** otter768 has joined #openstack-nova | 22:12 | |
| jogo | alaski: when your ready for a review poke me as getting that in would be great | 22:12 |
| jogo | just don't think we should block on it | 22:12 |
| *** annegentle has quit IRC | 22:12 | |
| alaski | jogo: cool. if no one speaks up by tomorrow I'll go with dims suggestion | 22:12 |
| alaski | jogo: yeah, don't want to block. but if we do have an rc2 I think it's a good one for it | 22:12 |
| jogo | alaski: agreed | 22:13 |
| jogo | looks like https://review.openstack.org/#/c/172856/ is the only critical for RC2 that is still pending | 22:14 |
| *** markvoelker has quit IRC | 22:14 | |
| jogo | alaski dansmith: https://review.openstack.org/#/c/172856/ | 22:14 |
| *** otter768 has quit IRC | 22:16 | |
| *** artom has quit IRC | 22:17 | |
| *** annashen has joined #openstack-nova | 22:18 | |
| *** nelsnelson has quit IRC | 22:19 | |
| *** Marga_ has joined #openstack-nova | 22:21 | |
| jogo | sdague: https://review.openstack.org/#/c/163700/ is ready to be un-2d | 22:23 |
| *** VW_ has quit IRC | 22:25 | |
| bauzas | grrr, call me stupid but I can't find where the host field is set on the Instance object within build_and_run_instance(), anyone remembers ? | 22:26 |
| dansmith | it's in there | 22:27 |
| *** jecarey has quit IRC | 22:27 | |
| bauzas | I can find where it's set for all the other cases (shelve, migrate, etc.) | 22:27 |
| bauzas | dansmith: then I'm blind | 22:27 |
| cfriesen | dansmith: I just opened a bug on the evacuate issue: https://bugs.launchpad.net/nova/+bug/1444171 | 22:27 |
| openstack | Launchpad bug 1444171 in OpenStack Compute (nova) "evacuate code path is not updating binding:host_id in neutron" [Undecided,New] | 22:27 |
| bauzas | dansmith: that's maybe because I saw Netflix's Daredevil... | 22:27 |
| *** irenab has joined #openstack-nova | 22:28 | |
| dansmith | bauzas: resource_tracker.py, _set_instance_host_and_node() | 22:29 |
| dansmith | cfriesen: cool, thanks | 22:29 |
| bauzas | dansmith: oh, when claiming ? damn. | 22:29 |
| cfriesen | dansmith: I found a hack that'll work for neutron, but I think it might break nova-network. | 22:29 |
| bauzas | dansmith: I was actually reviewing https://review.openstack.org/#/c/163842/10/nova/compute/resource_tracker.py,cm but I didn't like to see the AZ info provided in there as I was thinking it was just done elsewhere | 22:30 |
| dansmith | cfriesen: does this apply at all to nova-network? | 22:30 |
| cfriesen | dansmith: and there's weird stuff around setup_networks_on_host(), setup_instance_network_on_host(), and cleanup_instance_network_on_host() being used on one or the other or neithr | 22:30 |
| bauzas | dansmith: but I'll need to change my mind then | 22:30 |
| cfriesen | dansmith: I have no idea | 22:30 |
| cfriesen | dansmith: but we are already calling setup_networks_on_host(), which actually does something for nova-network and is empty for neutron | 22:31 |
| bauzas | erm, for some reason, we do that when claiming() for the build_and_run_instance() but not when migrating like in _prep_resize() for example | 22:31 |
| *** eglynn has joined #openstack-nova | 22:31 | |
| dansmith | okay, I really don't have context on all that, so I can't comment without looking | 22:31 |
| cfriesen | dansmith: setup_instance_network_on_host() appears to do something for neutron but goes all the way to network-manager and then does nothing for nova-network | 22:31 |
| bauzas | that's just... ugly :/ | 22:31 |
| *** ijw has quit IRC | 22:32 | |
| *** Sukhdev has joined #openstack-nova | 22:32 | |
| cfriesen | bauzas: there's an open bug about claiming resources when migrating | 22:33 |
| bauzas | cfriesen: I know | 22:33 |
| bauzas | cfriesen: the claiming system is just... erm, ugly ? | 22:34 |
| bauzas | cfriesen: fixing the open bug you mentioned is just a can of worms | 22:34 |
| cfriesen | bauzas: indeed. and then you combine it with having to allocate specific CPUs when you live-migrate an instance with dedicated CPUs... | 22:34 |
| *** smccully has quit IRC | 22:35 | |
| cfriesen | bauzas: also, we're bad about freeing up resources on live migration...it waits around till the audit. So you could live-migrate and then try to live-migrate back and it'll tell you that there are insufficient resources to go back to where you came from. | 22:36 |
| *** markvoelker has joined #openstack-nova | 22:36 | |
| *** achanda has quit IRC | 22:36 | |
| *** thedodd has quit IRC | 22:36 | |
| bauzas | cfriesen: I know that too, that's why I say it's a can of worms | 22:36 |
| *** markvoelker_ has quit IRC | 22:37 | |
| bauzas | cfriesen: instead of bugfixing stuff with a huge tech debt, we have to refactor it | 22:37 |
| bauzas | cfriesen: that's something we discussed 6 months ago and that's still open - but basically claims should be a scheduler thing | 22:37 |
| bauzas | cfriesen: unless the operator wants to directly go to a specific compute by giving a dest, and then that's his responsibility | 22:38 |
| openstackgerrit | Mitsuhiro Tanino proposed openstack/nova: Prevent unintentional detaching volume from instance https://review.openstack.org/166695 | 22:38 |
| *** markvoelker_ has joined #openstack-nova | 22:41 | |
| *** achanda has joined #openstack-nova | 22:41 | |
| *** ociuhandu has quit IRC | 22:42 | |
| *** markvoelker has quit IRC | 22:44 | |
| *** eglynn has quit IRC | 22:44 | |
| *** tjones1 has quit IRC | 22:47 | |
| *** armax has joined #openstack-nova | 22:49 | |
| *** tjones1 has joined #openstack-nova | 22:49 | |
| *** Marga_ has quit IRC | 22:49 | |
| *** dave-mccowan has quit IRC | 22:54 | |
| *** sbfox has joined #openstack-nova | 23:06 | |
| *** sbfox has quit IRC | 23:06 | |
| *** dboik has quit IRC | 23:06 | |
| *** mwagner_lap has joined #openstack-nova | 23:06 | |
| *** sbfox has joined #openstack-nova | 23:06 | |
| *** mriedem has joined #openstack-nova | 23:07 | |
| *** Marga_ has joined #openstack-nova | 23:07 | |
| *** eglynn has joined #openstack-nova | 23:10 | |
| *** zzzeek has quit IRC | 23:10 | |
| *** dave-mccowan has joined #openstack-nova | 23:10 | |
| *** ijw has joined #openstack-nova | 23:11 | |
| *** Sukhdev has quit IRC | 23:13 | |
| *** mriedem has quit IRC | 23:13 | |
| *** Sukhdev has joined #openstack-nova | 23:13 | |
| *** nelsnelson has joined #openstack-nova | 23:14 | |
| *** dave-mccowan has quit IRC | 23:15 | |
| *** ociuhandu has joined #openstack-nova | 23:16 | |
| *** mriedem has joined #openstack-nova | 23:17 | |
| mriedem | cfriesen: just saw your question, i'm not sure why we have two similar network setup on host methods, would have to dig into the history and usage of each. i assume cleanup is post-migration. | 23:18 |
| *** dave-mccowan has joined #openstack-nova | 23:19 | |
| *** Mike_D_laptop has quit IRC | 23:20 | |
| cfriesen | mriedem: I dug a bit more. looks like all three functions actually do something for FlatDHCPManager/VlanManager due to the FloatingIP class mixin | 23:20 |
| cfriesen | mriedem: for neutron only setup_instance_network_on_host() actually does anything | 23:21 |
| *** Hosam has quit IRC | 23:21 | |
| mriedem | cfriesen: yeah i figured there was a bunch of nova-network-isms in here | 23:21 |
| mriedem | alex_xu: had some patches in kilo to normalize some of that, not sure if it all landed though | 23:21 |
| cfriesen | In most cases where we call setup_networks_on_host() we also call migrate_instance_finish(), which on neutron will also end up calling _update_port_binding_for_instance | 23:22 |
| cfriesen | mriedem: but it looks like we missed the evacuate case. | 23:22 |
| cfriesen | mriedem: not sure how to make evacuate work sanely for both neutron and nova-network | 23:22 |
| cfriesen | mriedem: I opened https://bugs.launchpad.net/nova/+bug/1444171 in case you want to point the appropriate people at it. | 23:23 |
| openstack | Launchpad bug 1444171 in OpenStack Compute (nova) "evacuate code path is not updating binding:host_id in neutron" [Undecided,New] | 23:23 |
| mriedem | cfriesen: i think you're the appropriate person :) | 23:24 |
| *** irenab has quit IRC | 23:24 | |
| cfriesen | mriedem: gee, thanks! | 23:24 |
| mriedem | cfriesen: so where is setup_instance_network_on_host() used? | 23:24 |
| *** salv-orlando has quit IRC | 23:24 | |
| cfriesen | mriedem: _unshelve_instance() and _build_networks_for_instance() | 23:25 |
| cfriesen | and _build_networks_for_instance() is used only from _build_resources() | 23:25 |
| mriedem | so it's the build path rather than migrate | 23:26 |
| mriedem | the other is migrate only it sounds like, for nova-network | 23:26 |
| cfriesen | migrate_instance_finish() takes migration as an argument...for neutron it ends up calling down into the same underlying _update_port_binding_for_instance() | 23:27 |
| cfriesen | mriedem: could do a really hacky thing and only call setup_instance_network_on_host() in rebuild_instance if we're using neutron. | 23:28 |
| mriedem | cfriesen: yeah, thought about that | 23:28 |
| mriedem | super hack | 23:28 |
| *** jwcroppe has quit IRC | 23:28 | |
| mriedem | or just have setup_network_on_host() in neutron call the _update_port_binding | 23:28 |
| cfriesen | mriedem: setup_network_on_host() gets called all over the place though | 23:30 |
| cfriesen | mriedem: wasn't sure about side effects in neutron | 23:31 |
| mriedem | well, _update_port_binding only changes the host if the host changes | 23:32 |
| mriedem | but yeah i hear you | 23:32 |
| mriedem | cfriesen: you could do a WIP patch and just see if the neutron full job falls over | 23:33 |
| *** Sukhdev has quit IRC | 23:35 | |
| cfriesen | mriedem: sure...may be able to have setup_network_on_host() call _update_port_binding_for_instance(). Then if we're lucky when we call migrate_instance_finish() it'll get called again for neutron and decide it has nothing to do. | 23:35 |
| mriedem | yeah | 23:36 |
| mriedem | we definitely dno't want the compute manager to have to know that the neutronv2 network api has to be called differently for rebuild | 23:38 |
| cfriesen | mriedem: will try that. gotta run it by someone first unfortunately. maybe late tonight or sometime tomorrow. | 23:40 |
| *** READ10 has quit IRC | 23:43 | |
| *** tjones1 has quit IRC | 23:44 | |
| *** Sukhdev has joined #openstack-nova | 23:46 | |
| mriedem | cfriesen: ok, i might be able to wip that up quick | 23:47 |
| mriedem | that was a little pun | 23:47 |
| *** annashen has quit IRC | 23:49 | |
| cfriesen | :) | 23:49 |
| cfriesen | mriedem: sorry, corporate policy stuff | 23:49 |
| *** zhenguo has joined #openstack-nova | 23:51 | |
| *** markvoelker_ has quit IRC | 23:54 | |
| *** tjones1 has joined #openstack-nova | 23:55 | |
| cfriesen | mriedem: you send in that patch yet? If not I got the okay to send it in. | 23:57 |
| *** mriedem1 has joined #openstack-nova | 23:59 | |
| mriedem1 | cfriesen: that was fast - go nuts | 23:59 |
| cfriesen | mriedem1: got lucky, he was online from home | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!