| *** yuntongjin has joined #openstack-nimble | 01:43 | |
| *** RuiChen has joined #openstack-nimble | 02:46 | |
| shaohe_feng | liusheng: hi. | 03:32 |
|---|---|---|
| liusheng | shaohe_feng: hi | 03:32 |
| shaohe_feng | liusheng: just a reminder. when you write functional test, you case may failed for authorization | 03:33 |
| shaohe_feng | liusheng: you can pass the roles to avoid this | 03:33 |
| shaohe_feng | liusheng: https://review.openstack.org/#/c/399820/3/nimble/tests/unit/api/v1/test_instance.py@79 | 03:34 |
| shaohe_feng | liusheng: such as this. pass the roles in HTTP headers, in this way, we can not use fixpolicy | 03:34 |
| shaohe_feng | liusheng: we do not need fixpolicy | 03:35 |
| liusheng | shaohe_feng: thanks for reminding me | 03:35 |
| *** yuntongjin has quit IRC | 03:36 | |
| shaohe_feng | liusheng: :P | 03:36 |
| liusheng | shaohe_feng: btw, do you think nimble-api should be able to interact with Ironic directly ? | 03:39 |
| liusheng | shaohe_feng: or only nimble-engine can interact with Ironic | 03:40 |
| shaohe_feng | liusheng: what's the pros and cons? | 03:41 |
| liusheng | shaohe_feng: seems like the Ironic is an driver of Nimble, so may it can only interact with nimble-engine | 03:42 |
| liusheng | shaohe_feng: the change https://review.openstack.org/#/c/398924/ has broken the instance-show API, just want to fix it, that need api to init an Ironicclient | 03:43 |
| liusheng | zhenguo: ping | 03:43 |
| zhenguo | liusheng: hi | 03:43 |
| liusheng | zhenguo: ^^ what do you think ? | 03:44 |
| shaohe_feng | liusheng: instance-show still interact with Ironic directly? | 03:45 |
| liusheng | https://github.com/openstack/nimble/blob/master/nimble/api/controllers/v1/instances.py#L337 this line of code need to pass an ironicclient now | 03:45 |
| liusheng | shaohe_feng: yes | 03:46 |
| zhenguo | liusheng, shaohe_feng: seems it's better to do this on engine side, but don't have strong option. | 03:46 |
| liusheng | after change https://review.openstack.org/#/c/398924/ | 03:46 |
| zhenguo | liusheng: oh, yes | 03:48 |
| liusheng | https://github.com/openstack/nimble/blob/master/nimble/api/controllers/v1/instances.py#L283-L285 and here, I have search all the api's code, just these two places | 03:48 |
| zhenguo | liusheng: after that refactor, we only initizlize ironicclient on engine side | 03:48 |
| liusheng | zhenguo: yes | 03:49 |
| zhenguo | liusheng: good find :) | 03:49 |
| shaohe_feng | liusheng: yes, also a get_node_list. | 03:49 |
| liusheng | shaohe_feng, zhenguo, so we should better to use "pecan.request.rpcapi.xxx" and expose these api in engine side, or init an ironicclient ? | 03:51 |
| zhenguo | liusheng, shaohe_feng: I think it's better to interact with ironic on engine side, but I don't think out what's the cros and pros now. | 03:53 |
| liusheng | zhenguo: I also think so :) | 03:57 |
| shaohe_feng | zhenguo: seems code is more readable. the other components, at present, just nimble-api, juct call engine api, do not care ironic. engine layer help to comunication with ironic | 03:58 |
| zhenguo | shaohe_feng: yes | 03:58 |
| zhenguo | shaohe_feng: i have to be away for lunch, ttyl | 03:59 |
| * zhenguo away | 03:59 | |
| * liusheng lunch | 03:59 | |
| *** kevinz has quit IRC | 05:35 | |
| *** yuntongjin has joined #openstack-nimble | 05:44 | |
| openstackgerrit | liusheng proposed openstack/nimble: Add instance CURD related functional tests https://review.openstack.org/398068 | 06:09 |
| *** yuntongjin has quit IRC | 06:34 | |
| *** yuntongjin has joined #openstack-nimble | 06:43 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add engine api interfaces https://review.openstack.org/399476 | 06:54 |
| *** kevinz has joined #openstack-nimble | 07:28 | |
| *** kevinz has quit IRC | 07:38 | |
| *** kevinz has joined #openstack-nimble | 07:39 | |
| shaohe_feng | zhenguo: hi, liusheng | 07:50 |
| liusheng | shaohe_feng: hi | 07:50 |
| zhenguo | shaohe_feng: hi | 07:50 |
| shaohe_feng | where is the api doc | 07:50 |
| shaohe_feng | after I run tox -e docs | 07:50 |
| zhenguo | shaohe_feng: you mean api-ref? | 07:50 |
| shaohe_feng | zhenguo: yes. | 07:51 |
| zhenguo | shaohe_feng: for api-ref you should use tox -eapi-ref | 07:51 |
| shaohe_feng | I what to start a local httpserver to browse it | 07:51 |
| shaohe_feng | zhenguo: got it. | 07:52 |
| shaohe_feng | zhenguo: not docs commant. | 07:52 |
| shaohe_feng | zhenguo: I run the wrong command | 07:52 |
| zhenguo | shaohe_feng: for offical project, api-ref will publish to docs.openstack.org | 07:52 |
| shaohe_feng | zhenguo: thanks | 07:52 |
| shaohe_feng | zhenguo: that's great | 07:52 |
| zhenguo | shaohe_feng: for use, it just generate a api-ref/build/html directory :( | 07:53 |
| zhenguo | shaohe_feng: so we need to put that directory under apache root dir | 07:53 |
| * liusheng also learning from zhenguo :) | 07:54 | |
| zhenguo | shaohe_feng: IIRC, you can just copy the html dir to /var/www/html on ubuntu env, and restart httpd service | 07:54 |
| zhenguo | liusheng: hah | 07:54 |
| zhenguo | shaohe_feng, liusheng: then on http://yourip you can see our api doc | 07:55 |
| shaohe_feng | zhenguo: yes. $ python -m SimpleHTTPServer 8000 | 07:56 |
| zhenguo | shaohe_feng: hah, yes that's more easy | 07:57 |
| shaohe_feng | zhenguo: http://yourip:8000 is also OK. | 07:57 |
| shaohe_feng | zhenguo: in this way, do not need copy it ot /var/www/html | 07:57 |
| shaohe_feng | s/ot/to | 07:57 |
| zhenguo | shaohe_feng: yes, and seems we have this mentioned in our dev doc | 07:57 |
| shaohe_feng | zhenguo: yes. in our dev doc | 07:58 |
| liusheng | found it | 07:58 |
| shaohe_feng | zhenguo: python is easy to use. also easy to setup an simple http server | 07:58 |
| shaohe_feng | zhenguo: Warning, treated as error: | 07:58 |
| shaohe_feng | api-ref/source/instances.inc:210: WARNING: Title underline too short. | 07:58 |
| shaohe_feng | Delete Instance | 07:58 |
| shaohe_feng | ============= | 07:58 |
| shaohe_feng | zhenguo: I build failed. | 07:59 |
| zhenguo | shaohe_feng: oh, | 07:59 |
| zhenguo | shaohe_feng: as we don't have api-ref check in our gate :( | 07:59 |
| shaohe_feng | zhenguo: Oh. got it. | 08:00 |
| zhenguo | shaohe_feng: maybe you can help to fix that :P | 08:00 |
| shaohe_feng | zhenguo: OK. | 08:00 |
| zhenguo | shaohe_feng: thansk | 08:00 |
| shaohe_feng | zhenguo: still other errors. | 08:00 |
| shaohe_feng | zhenguo: /opt/stack/nimble/api-ref/source/api-ref/source/instances.inc:225 .rst:: WARNING: No field definition for ``instances_uuid_path`` found in ``/opt/stack/nimble/api-ref/source/parameters.yaml``. Skipping. | 08:00 |
| shaohe_feng | zhenguo: let's fix it together. | 08:01 |
| zhenguo | shahe_feng: sorry for that, seems because I just merged the api-ref patches, not use tox to check whether it's ok | 08:01 |
| zhenguo | shaohe_feng: ok, will check the errors | 08:02 |
| shaohe_feng | zhenguo: we do not define instances_uuid_path | 08:02 |
| shaohe_feng | zhenguo: we can use instances_uuid directly | 08:02 |
| zhenguo | shaohe_feng: seems we have instance_uuid in both path and body | 08:03 |
| zhenguo | shaohe_feng: not sure they are same, like it's required or optional attribute | 08:04 |
| shaohe_feng | zhenguo: some difference. we need add a instances_uuid_path | 08:04 |
| zhenguo | shaohe_feng: ok | 08:04 |
| shaohe_feng | zhenguo: instances_uuid_path to instance_uuid_path is OK? singular? | 08:05 |
| zhenguo | shaohe_feng: I think so, as it just one instance's uuid :) | 08:05 |
| shaohe_feng | zhenguo: yes. | 08:06 |
| shaohe_feng | zhenguo: the description of instance_uuid: | 08:08 |
| shaohe_feng | zhenguo: The UUID of the server instance | 08:09 |
| shaohe_feng | zhenguo: do we need server? | 08:09 |
| zhenguo | shaohe_feng: seems not | 08:09 |
| shaohe_feng | zhenguo: we have a instance_ident in path | 08:10 |
| shaohe_feng | so do not need define instance_uuid_path | 08:10 |
| zhenguo | shaohe_feng: if so, we can just use that | 08:10 |
| shaohe_feng | zhenguo: well, build successfully. | 08:11 |
| zhenguo | shaohe_feng: hah, so you may find more errors while scanning the docs | 08:12 |
| shaohe_feng | zhenguo: yes. first, let the api-ref building successfully | 08:22 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: fix some api-ref error https://review.openstack.org/400094 | 08:23 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: update api-ref for admin tenant filter. https://review.openstack.org/400107 | 08:34 |
| shaohe_feng | zhenguo: liusheng: about the instance functional test. https://review.openstack.org/#/c/398068/3 | 08:36 |
| shaohe_feng | zhenguo: liusheng: some edge case are not covered. such as fields in query for get, all_test for get_all, and other. | 08:37 |
| shaohe_feng | zhenguo: liusheng: do we still need unit test for API? or these edge cases will covered in functional testes? | 08:38 |
| liusheng | shaohe_feng: ok, I wll add more tests, I'd like UT for API may foucus on method, right ? | 08:40 |
| zhenguo | shaohe_feng, liusheng: yes, I think we must have UT for api | 08:40 |
| shaohe_feng | liusheng: yes. UT should focus on method. | 09:04 |
| shaohe_feng | liusheng: zhenguo: In neutron doc, they says, the UT more than functional test, and more than full-stack test | 09:05 |
| zhenguo | shaohe_feng, liusheng: yes, it should be | 09:07 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Import ironicclient directly https://review.openstack.org/400139 | 09:26 |
| *** kevinz has quit IRC | 09:42 | |
| *** kevinz has joined #openstack-nimble | 09:43 | |
| *** yuntongjin has quit IRC | 09:59 | |
| -openstackstatus- NOTICE: We are currently having capacity issues with our ubuntu-xenial nodes. We have addressed the issue but will be another few hours before new images have been uploaded to all cloud providers. | 12:19 | |
| openstackgerrit | Merged openstack/nimble: fix some api-ref error https://review.openstack.org/400094 | 13:18 |
| *** kevinz has quit IRC | 15:21 | |
| *** RuiChen has quit IRC | 16:10 | |
| *** liusheng has quit IRC | 20:24 | |
| *** liusheng has joined #openstack-nimble | 20:31 | |
| *** openstack has joined #openstack-nimble | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!