| *** yuntongjin has joined #openstack-nimble | 01:45 | |
| *** lei-zh has joined #openstack-nimble | 01:51 | |
| zhenguo | liusheng, yuntongjin, lei-zh: shaohe_feng is absent today, we have added db,object base test case yesterday and the API test is already under review. But seems like the tests work is more than we expected at the meeting. After discussing with shaohe, he suggested that everyone should assign more db tests to himself to make sure we can finish the task by | 02:43 |
|---|---|---|
| zhenguo | this week, the example test case is already there, it should not be very hard to add more, thank you all. | 02:43 |
| zhenguo | yuntongjin, lei-zh: added Zhong Luyao, seems he is not in our irc channel :( | 02:45 |
| zhenguo | s/he/she | 02:46 |
| lei-zh | ok, I'll add here | 03:06 |
| zhenguo | lei-zh: thanks | 03:06 |
| openstackgerrit | Merged openstack/nimble: Add base API tests and utils https://review.openstack.org/395688 | 03:24 |
| openstackgerrit | Merged openstack/nimble: change the type of extra to JsonEncodedDict https://review.openstack.org/395508 | 03:24 |
| liusheng | zhenguo: the tests based on db are unit tests ? I may prefer functional tests :P | 03:28 |
| zhenguo | liusheng: yes, you can focus on functional tests | 03:29 |
| zhenguo | liusheng: but all functional tests :P | 03:29 |
| liusheng | zhenguo: but I found the change https://review.openstack.org/#/c/395688/1 has added the tests based on db back to tests/unit/ which I moved to tests/functional/ | 03:31 |
| liusheng | and there are some "print()" statements in nimble/tests/unit/api/base.py :( | 03:32 |
| zhenguo | liusheng: oh sorry, I don't notice that, let me check | 03:32 |
| zhenguo | liusheng: oh, yes it's duplicate :( | 03:35 |
| liusheng | addtionally, our functional tests are based on sqlite, do we need a real mysql backend ? I don't know the difference between sqlite and mysql, we can only face sqlalchemy :) | 03:37 |
| zhenguo | liusheng: seems sqlite is fine which is more lightweight thant mysql | 03:38 |
| liusheng | zhenguo: yes, it is convenient for testing | 03:39 |
| zhenguo | liusheng: do we still need api tests in unit? | 03:39 |
| *** yuntongjin has quit IRC | 03:40 | |
| liusheng | zhenguo: I think we are testing real api request, so they are functal tests, am I right ? | 03:40 |
| zhenguo | liusheng: yes, I think so | 03:40 |
| liusheng | I think the unit test for api can be added only when the functional test cannot cover | 03:43 |
| zhenguo | liusheng: ok, so we can just keep functional tests now, will remove the duplicate part. | 03:44 |
| liusheng | zhenguo: ok | 03:45 |
| *** luyao has joined #openstack-nimble | 03:47 | |
| lei-zh | welcome luyao:) | 03:47 |
| *** yuntongjin has joined #openstack-nimble | 03:49 | |
| luyao | 大家好:) | 03:49 |
| *** yuntongjin has quit IRC | 03:51 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Revert "Add base API tests and utils" https://review.openstack.org/395926 | 03:55 |
| zhenguo | luyao: welcome! | 03:56 |
| liusheng | luyao: welcome! | 03:56 |
| * zhenguo is away for lunch... | 03:56 | |
| *** lei-zh has quit IRC | 04:18 | |
| *** yuntongjin has joined #openstack-nimble | 04:49 | |
| *** luyao has quit IRC | 05:26 | |
| *** shaohe_feng has quit IRC | 05:35 | |
| *** shaohe_feng has joined #openstack-nimble | 05:36 | |
| *** lei-zh has joined #openstack-nimble | 05:58 | |
| *** luyao has joined #openstack-nimble | 06:04 | |
| openstackgerrit | Merged openstack/nimble: Revert "Add base API tests and utils" https://review.openstack.org/395926 | 06:06 |
| RuiChen | luyao: \o/ | 06:30 |
| openstackgerrit | yuntongjin proposed openstack/nimble: Add unittest test_filter_scheduler https://review.openstack.org/387814 | 06:32 |
| zhenguo | liusheng, RuiChen, yuntongjin, lei-zh, luyao: do you have some concerns about using really db for objects tests instead of mock db calls? https://review.openstack.org/#/c/395610/ | 06:32 |
| zhenguo | it's time consuming but can cover really db calls, or db tests cases have already guaranteed it. | 06:35 |
| zhenguo | and Kevin_Zheng :) | 06:39 |
| *** luyao has quit IRC | 06:43 | |
| liusheng | looks the tests in Nova, the objects' related tests are located in tests/unit/ and db calls mocked. the tests of real db calls are in tests/functional | 06:43 |
| zhenguo | liusheng: yes, other projects all use mock db calls... | 06:45 |
| liusheng | I am not concern with time consuming | 06:48 |
| liusheng | but may they are a bit duplicated ? :) | 06:48 |
| zhenguo | the purpuse of that patch is to cover the db column type not consistent with object field type as we find a bug for our instance.extra field, seems when we have enough functional tests, that should be covered, and we don't need really db calls? | 06:48 |
| zhenguo | liusheng: lol, yes seems duplicated | 06:49 |
| zhenguo | liusheng:Ｉthink we can hold on that patch and wait for shaohe_feng back to office. | 06:50 |
| liusheng | zhenguo: sure :) | 06:51 |
| liusheng | zhenguo: about the functional tests of instance CURD, do you think it is ok to mock the RPC call to nimble-engine ? | 06:54 |
| zhenguo | liusheng: not sure, but as we already setup the whole env with devstack for functional, it should be really call tests or that should be tempest things? | 06:56 |
| liusheng | zhenguo:hmm, so the functioan tests can cover api->engine->ironic, tbh, I also not sure about this should be in tempest :) | 06:58 |
| zhenguo | liusheng: maybe mocked ironic,neutron,glance calls, but not for engine calls? | 06:59 |
| RuiChen | we are talking about unit tests? | 07:00 |
| zhenguo | RuiChen: yes, unit tests and functional tests | 07:00 |
| liusheng | RuiChen: about unit tests and instance CURD functional tests | 07:01 |
| liusheng | zhenguo: make sense to me | 07:01 |
| RuiChen | I think we should mock db call in UT, but not in functional test | 07:01 |
| zhenguo | and I'm confused about tempest and functional tests, does tempest already covered functional tests things? | 07:02 |
| RuiChen | yeah, I have the same question about the difference between tempest and functional | 07:03 |
| *** luyao has joined #openstack-nimble | 07:03 | |
| *** luyao has left #openstack-nimble | 07:06 | |
| *** luyao has joined #openstack-nimble | 07:06 | |
| liusheng | may tempest if for a whole process with real backends and configs ? and functional tests if for a sub-process, and UT is for a method ? personal thoughts | 07:06 |
| RuiChen | zhenguo: how to add gerritbot for nimbleclient? seems we lack the notify from client project | 07:06 |
| zhenguo | RuiChen: add nimbleclient under nimble https://review.openstack.org/#/c/385786/2/gerritbot/channels.yaml | 07:09 |
| zhenguo | liusheng: seems correct | 07:09 |
| RuiChen | thanks zhenguo, I commit a patch to add it. | 07:10 |
| zhenguo | RuiChen: thanks :) | 07:10 |
| *** lei-zh has quit IRC | 07:11 | |
| RuiChen | liusheng: zhenguo I'm not sure what's means about sub-process in functional tests, part of test cases of tempest? | 07:12 |
| zhenguo | RuiChen: I just check Ironic functional tests dir, it's empty... and api tests are all in unit dir | 07:13 |
| RuiChen | hmmm, I have no idea about it, might we can check Nova, Neutron or Cinder? | 07:15 |
| zhenguo | RuiChen, liusheng: I find the ironic functional job defination with a comment 'No post_test_hook is needed while tests live in tempest' | 07:15 |
| zhenguo | really confused | 07:15 |
| liusheng | http://stackoverflow.com/questions/3670729/what-is-the-difference-between-integration-testing-and-functional-testing | 07:15 |
| liusheng | that is the difference between functional tests and intergration tests | 07:16 |
| *** lei-zh has joined #openstack-nimble | 07:16 | |
| RuiChen | ^^ make sense | 07:16 |
| zhenguo | it's clear | 07:18 |
| zhenguo | liusheng: so just like we discussed, fuctional tests should cover really calls of nimble and mock calls for ironic, neutron, glance, right? | 07:19 |
| liusheng | there is an auto-scalling test in Ceilometer's tempest :) | 07:19 |
| openstackgerrit | yuntongjin proposed openstack/nimble: Add unittest test_node_filters for scheduler https://review.openstack.org/395985 | 07:20 |
| liusheng | zhenguo: seems like, but in other words, the ironic is a part of nimble's funtionality, right ? | 07:21 |
| liusheng | zhenguo: also confused .. | 07:22 |
| zhenguo | liusheng, RuiChen: we can assume ironic works, | 07:22 |
| liusheng | so let | 07:23 |
| zhenguo | liusheng: we can assume all other services work, only tests nimble logic, from api to object then to really db | 07:23 |
| liusheng | so let's mock ironic ? hah | 07:23 |
| zhenguo | liusheng: yes, just gurantee ourself ok | 07:23 |
| zhenguo | liusheng: but I still believe tempest can cover all cases | 07:24 |
| zhenguo | liusheng: but currently I think it's ok to use functional tests like we discussed | 07:24 |
| RuiChen | liusheng: nimble-specs project had been added in infra? I can add the gerritbot for it in my patch | 07:24 |
| liusheng | RuiChen: no +2 and +A for now :( | 07:25 |
| RuiChen | no worried, lots of core in vacation, hah | 07:26 |
| RuiChen | so i only add nimbleclient in my patch, any update, please ping me | 07:26 |
| liusheng | zhenguo: so I will try to add functional tests of instance CURD | 07:27 |
| zhenguo | liusheng, RuiChen: ok, we can update the patch for specs to be added to gerritbot itself | 07:27 |
| zhenguo | liusheng: thanks, tempest should be considerd after we are public | 07:27 |
| liusheng | zhenguo: ok | 07:28 |
| liusheng | zhenguo: seems your reverted patch use a real token authentication for api tests, but I skipped the token authentication previously, may because I am lazy :P | 07:34 |
| zhenguo | liusheng: haha | 07:35 |
| RuiChen | zhenguo and liusheng, add you into a review list https://review.openstack.org/#/c/395989/ gerritbot | 07:35 |
| zhenguo | RuiChen: ok | 07:35 |
| zhenguo | liusheng: for ACL tests we need real token | 07:36 |
| liusheng | zhenguo: yeah, but I added "'acl_public_routes': ['/', '/v1/.*']" in nimble.tests.functional.api.BaseApiTest#_make_app which skip the token auth | 07:37 |
| liusheng | zhenguo: so should I stole your code and add it now ? | 07:37 |
| zhenguo | liusheng: seems not needed now, | 07:38 |
| zhenguo | liusheng: but does functional tests cover cases that non admin users forbbiden to do things like admin or other policies | 07:38 |
| liusheng | that seems related with RBCA than ACL, but we may also need tests for ACL ... | 07:43 |
| zhenguo | liusheng: yes, should that be in functional or unit tests? | 07:44 |
| liusheng | zhenguo: in funtional | 07:46 |
| zhenguo | liusheng: ok | 07:47 |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-nimble | 07:49 | |
| *** yuntongjin has quit IRC | 08:11 | |
| *** yuntongjin has joined #openstack-nimble | 08:21 | |
| *** luyao has quit IRC | 08:22 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add extra field to instance API https://review.openstack.org/396034 | 09:12 |
| zhenguo | liusheng: I added 'extra' field to instance API, maybe will affect the functional tests you are working on | 09:14 |
| liusheng | zhenguo: thanks for reminding me | 09:14 |
| zhenguo | liusheng: hah | 09:15 |
| zhenguo | RuiChen: seems hanzhang is absent, I added an extra field to instance API, client needs to be updated accordingly | 09:27 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: use really DB for instance object test https://review.openstack.org/395610 | 09:30 |
| shaohe_feng | zhenguo: I'm back | 09:31 |
| zhenguo | shaohe_feng: regarding the really db calls, we discussed about it this afternoon | 09:32 |
| zhenguo | shaohe_feng: seems it's somewhat duplicate | 09:32 |
| zhenguo | shaohe_feng: oh, forget to say "welcome back..." sorry :P | 09:33 |
| *** shihanzhang has joined #openstack-nimble | 09:35 | |
| RuiChen | zhenguo: shihanzhang disconnect from irc channel, he will be back soon. | 09:35 |
| zhenguo | RuiChen: ok, got it, thanks | 09:35 |
| zhenguo | shaohe_feng: you can scroll back to see the history, as the object and db types inconsistent is because we don't really use the field and there's no functional tests cover it | 09:36 |
| shihanzhang | hi all, i am online | 09:36 |
| zhenguo | shiahnzhang: hi, I updated the instance API to add a new filed extra | 09:37 |
| shihanzhang | do i need to modify the nimble client? | 09:38 |
| zhenguo | shihanzhang: yes, need to add a new option when creating instance | 09:38 |
| zhenguo | shihanzhang: like metadata or extra | 09:38 |
| shihanzhang | ok, i will check it latter | 09:38 |
| zhenguo | shihanzhang: thanks | 09:39 |
| shihanzhang | np | 09:39 |
| *** luyao has joined #openstack-nimble | 09:39 | |
| *** luyao has left #openstack-nimble | 09:39 | |
| *** luyao has joined #openstack-nimble | 09:39 | |
| shaohe_feng | zhenguo: Got it. then we still need mock DB. | 09:45 |
| zhenguo | shaohe_feng: yes, thanks | 09:46 |
| shaohe_feng | zhenguo: And we really need functional test cover ervery thing. That is hard. | 09:46 |
| zhenguo | shaohe_feng: yes, and I have abandon the api tests patch in unit tests, it's duplicate with functional | 09:47 |
| shaohe_feng | zhenguo: Actually, the test case and the our application code should be parallel | 09:47 |
| zhenguo | shaohe_feng: only functional tests have really db calls, it can test with the really env | 09:48 |
| shaohe_feng | zhenguo: the commerce product do well than open source for test case. | 09:48 |
| zhenguo | shaohe_feng: sure, | 09:49 |
| shaohe_feng | zhenguo: For the commerce company hire a lot of testers for their product. | 09:49 |
| *** yuntongjin has quit IRC | 09:50 | |
| zhenguo | shaohe_feng: sorry, I have to be away for dinner, will be back in about 1h, | 09:50 |
| * zhenguo away | 09:50 | |
| zhenguo | shaohe_feng: ttyl | 09:51 |
| *** luyao has quit IRC | 10:01 | |
| openstackgerrit | Merged openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 10:05 |
| *** lei-zh has quit IRC | 10:07 | |
| openstackgerrit | liusheng proposed openstack/nimble: Clean some redundant default log levels settings https://review.openstack.org/396083 | 10:31 |
| *** liusheng has quit IRC | 10:44 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Add project filtering for instance api https://review.openstack.org/389562 | 10:49 |
| *** liusheng has joined #openstack-nimble | 11:26 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add db instance_type base test case https://review.openstack.org/396136 | 11:49 |
| openstackgerrit | Merged openstack/nimble: Clean some redundant default log levels settings https://review.openstack.org/396083 | 12:12 |
| openstackgerrit | Merged openstack/nimble: Add extra field to instance API https://review.openstack.org/396034 | 12:12 |
| *** shihanzhang has quit IRC | 12:17 | |
| *** shihanzhang has joined #openstack-nimble | 12:19 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: missing comma in samples json file, add it https://review.openstack.org/396164 | 12:25 |
| openstackgerrit | Merged openstack/nimble: Add project filtering for instance api https://review.openstack.org/389562 | 12:27 |
| openstackgerrit | Merged openstack/nimble: missing comma in samples json file, add it https://review.openstack.org/396164 | 12:54 |
| *** RuiChen has quit IRC | 13:26 | |
| *** Kevin_Zheng has quit IRC | 13:26 | |
| *** RuiChen has joined #openstack-nimble | 13:26 | |
| *** Kevin_Zheng has joined #openstack-nimble | 13:28 | |
| *** lei-zh has joined #openstack-nimble | 14:53 | |
| *** lei-zh has quit IRC | 15:58 | |
| *** openstackgerrit has quit IRC | 19:48 | |
| *** openstackgerrit has joined #openstack-nimble | 19:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!