Thursday, 2023-12-07

opendevreviewMiguel Lavalle proposed openstack/neutron master: Router flavors and service type for OVN  https://review.opendev.org/c/openstack/neutron/+/88398801:12
opendevreviewMerged openstack/neutron master: Support rarp protocol for egress table  https://review.opendev.org/c/openstack/neutron/+/66192104:38
opendevreviewFrode Nordahl proposed openstack/neutron-tempest-plugin master: Add Active Active L3 GW scenario test cases  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89881006:02
*** elodilles_pto is now known as elodilles07:34
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/2023.2: [Fullstack] Double check that agent is dead when it should be dead  https://review.opendev.org/c/openstack/neutron/+/90288107:46
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/2023.1: [Fullstack] Double check that agent is dead when it should be dead  https://review.opendev.org/c/openstack/neutron/+/90288207:47
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/zed: [Fullstack] Double check that agent is dead when it should be dead  https://review.opendev.org/c/openstack/neutron/+/90288307:47
opendevreviewMerged openstack/neutron-tempest-plugin master: Test job for VPNaaS on OVN  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/84700710:16
opendevreviewMax proposed openstack/ovsdbapp master: add Port_Binding to lookup_table  https://review.opendev.org/c/openstack/ovsdbapp/+/90287810:47
*** sfinucan is now known as stephenfin10:58
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:06
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:07
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:08
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:12
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:12
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:14
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:17
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651512:18
*** tobias-urdin9 is now known as tobias-urdin13:03
opendevreviewMichel Nederlof proposed openstack/neutron master: [OVN] Update lsp host id when virtual parent moves  https://review.opendev.org/c/openstack/neutron/+/89688314:07
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:17
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:18
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:19
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:19
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:20
opendevreviewFelipe Figueroa Vergara proposed openstack/tap-as-a-service master: Enables external network mirroring  https://review.opendev.org/c/openstack/tap-as-a-service/+/89651514:21
opendevreviewMerged openstack/neutron stable/2023.1: [Fullstack] Double check that agent is dead when it should be dead  https://review.opendev.org/c/openstack/neutron/+/90288216:47
*** tobias-urdin34 is now known as tobias-urdin17:27
haleybotherwiseguy: question on ovsdb transations... sometimes running ovn-db-sync-util we see timeouts due to too many items in a transaction, for example 10K. Is it safe to split them into groups? I'm thinking some are maybe related and need to be together?17:38
otherwiseguyYeah, it's one of those things where it's hard to really know what the unit of work should be. We need to group into transactions otherwise it takes *forever* to run. Doing everything in one can mean you blow your timeout, or if there is something wrong with 1/10k, it fails, etc.17:40
otherwiseguyIf it were me, I'd just make the timeout for the connections in the db-sync util higher than normal runtime.17:41
otherwiseguyatomicity of the txn isn't super important since we're syncing to another source of truth anyway, so I don't think there's anything inherently wrong with breaking up txns. We don't normally do a lot of transaction ops that *have* to be in the same txn to work, but I'd have to audit to make sure.17:44
haleybotherwiseguy: i've seen even high timeouts fail, like 600+17:45
otherwiseguyIs that because a lot of other work is going on on the ovsdb-server at the same time or something?17:46
otherwiseguyhaleyb: in general, we usually recommend people disable access to neutron API entirely when running db sync.17:46
haleybotherwiseguy: i only have a black box sometimes, and the api is supposedly off17:47
otherwiseguyMostly because adding ports, etc. while syncing isn't particularly safe. But performance could also play a part.17:47
otherwiseguyHmm.17:47
otherwiseguyWhere does it usually time out? ACLs?17:47
haleybport dhcp options strangely17:48
* otherwiseguy looks17:48
* otherwiseguy notes that vim brought him right to `_sync_port_dhcp_options()`17:49
haleybi was going to play with batching them like we did for agent sync code17:50
opendevreviewFrode Nordahl proposed openstack/neutron-tempest-plugin master: Add Active Active L3 GW API test cases  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89782317:55
opendevreviewFrode Nordahl proposed openstack/neutron-tempest-plugin master: Add Active Active L3 GW scenario test cases  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89881017:55
otherwiseguyhaleyb: is this for something like "there is no OVN db, and we're syncing the whole neutron db to OVN" ?18:07
haleybotherwiseguy: no, it's more "OVN has gone to shit and there are inconsistencies, let's run a sync"18:10
otherwiseguyhaleyb: it just seems weird that it would be out of sync enough in normal operation to have 600+s worth of dhcp options to sync.18:11
haleybotherwiseguy: is sure does, and these are all SetLSwitchPortCommand(). it could just another false positive18:12
otherwiseguyPart of me thinks we should just write a SyncDhcpOptionsCommand that just does all reads and writes in the command.18:14
otherwiseguyIn general having Command objects that do everything you want to do is better than a bunch of separate commands that do a bunch of lookups by name, etc. that you probably don't need.18:15
otherwiseguyBut there's kind of a lot to trace in this code to figure out everything that's going on. 18:15
otherwiseguybut if it's timing out because the commit() is taking to long, that doesn't really matter.18:19
otherwiseguys/to/too/18:19
otherwiseguyAs that would really just be taking too long *generating* the txn in python-ovs (either or both could be the culprit). Is there a bug w/ logs?18:20
otherwiseguyhaleyb: ^18:20
haleybotherwiseguy: there is no bug at the moment, is there something i can collect to point fingers at what might be happening?18:23
haleybotherwiseguy: the best i can say is commit() is timing out, so TimeoutException, sometimes see a weird _queue.Empty18:24
haleybi can create one18:24
otherwiseguyI'm assuming there are a bunch of Running txn n=(x) command(idx=y)" log messages? Basically the 1st one of those and last one of those w/ timestamps, and then any errors or related logs around them.18:26
otherwiseguyit occurs to me that changing that to printing out idx=y/len(commands) might be useful info.18:27
haleybotherwiseguy: i would have to get the ovsdb log, i only have the neutron side of things18:27
otherwiseguythat should be in the neutron debug logs.18:28
haleybotherwiseguy: hmm, the sync tool seems to generate it's own log (or dumps to stdout)18:31
otherwiseguyoh, yeah, i'm dumb. :D18:37
otherwiseguyMaintenance task is when the sync stuff would show up in neutron.18:38
otherwiseguyhaleyb: I cannot express the number of times I've cursed us from changing from OVN plugin to ML2 driver.18:47
otherwiseguyDealing with syncing multiple databases is just terrible.18:48
otherwiseguy(I am going to ignore that that is basically what northd is also doing.)18:48
opendevreviewMerged openstack/neutron master: [Trivial] speed up l3_db floating IP port janitor DB query  https://review.opendev.org/c/openstack/neutron/+/88820018:52
opendevreviewMerged openstack/neutron stable/zed: [Fullstack] Double check that agent is dead when it should be dead  https://review.opendev.org/c/openstack/neutron/+/90288318:52
haleybotherwiseguy: who designed this thing? :-p19:02
otherwiseguyRussell initially designed it as a plugin and was pressured to change it to an ml2 driver. I seem to remember him being like "ok, you all are the neutron experts, but ..." :)19:03
haleyband thanks for looking, i'm almost done with my hack at splitting into smaller chunks19:04
otherwiseguyGranted, it's nice to be able to use other drivers w/o having to reimplement them, etc. but man I hate db syncing.19:04
otherwiseguyhaleyb: if we can get logs from a run of the sync util, it'd be interesting to see the various "out of sync" messages etc. as well.19:20
haleybotherwiseguy: i'll add what i can to the bug, but i don't see any messages regarding what it's syncing in that method, just a traceback19:35
otherwiseguyis debug enabled?19:35
otherwiseguyIf so, I wonder if somehow the ovsdbapp vlog.use_python_logging() isn't called or something when done from the sync util?19:36
haleybhah, maybe not, but can ask the next time we run to add --debug=True or whatever it is19:37
otherwiseguys/logging/logger/19:37
* haleyb shrugs19:37
* haleyb takes off for a bit19:37
otherwiseguylooks like it should be called as get_ovn_idls() calls it.19:38
opendevreviewzhaobo proposed openstack/neutron stable/zed: [OVN] Prevent binding a virtual type port  https://review.opendev.org/c/openstack/neutron/+/90310420:26

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!