Friday, 2023-12-01

opendevreviewMiguel Lavalle proposed openstack/neutron master: Router flavors and service type for OVN  https://review.opendev.org/c/openstack/neutron/+/88398800:43
opendevreviewMerged openstack/neutron master: Replace network type names by constants  https://review.opendev.org/c/openstack/neutron/+/90204601:19
opendevreviewMerged openstack/neutron master: Remove ovn_l3_mode configuration option  https://review.opendev.org/c/openstack/neutron/+/90150501:48
opendevreviewMerged openstack/neutron master: Fix releasenote location  https://review.opendev.org/c/openstack/neutron/+/90163101:48
opendevreviewyatin proposed openstack/neutron stable/xena: [DNM] Check xena nftables job issue  https://review.opendev.org/c/openstack/neutron/+/90229606:48
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [OVN] Fail to start Neutron server when OVN and FIP PF config is invalid  https://review.opendev.org/c/openstack/neutron/+/89254206:53
opendevreviewyatin proposed openstack/neutron stable/xena: [DNM] Check xena nftables job issue  https://review.opendev.org/c/openstack/neutron/+/90229607:05
opendevreviewyatin proposed openstack/neutron stable/xena: [DNM] Check xena nftables job issue  https://review.opendev.org/c/openstack/neutron/+/90229607:23
sahido/ 08:55
sahidan other question guys regarding ovs, on a host without any VMs running we can see it receiving lot of ARPs packets08:56
sahidand it looks like this creates high cpu consumtion from ovs-vswitchd08:56
sahidwhen i shou stat of the fdb entries I can see more than 5000 rows08:57
sahidlooks like related to https://bugs.launchpad.net/neutron/+bug/173206709:16
opendevreviewMerged openstack/neutron stable/yoga: [DHCP agent] Fetch OVN Metadata port from plugin  https://review.opendev.org/c/openstack/neutron/+/90185009:33
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-bgp-agent master: Ensure proxy arp and ndp is configure for flat provider networks  https://review.opendev.org/c/openstack/ovn-bgp-agent/+/90226309:43
mgoddardlucasagomes: Hi! Do you know if ML2/OVN works with (bluefield v3) smart NICs on (ironic) bare metal?10:16
opendevreviewMerged openstack/ovn-bgp-agent master: Ensure proxy arp and ndp is configure for flat provider networks  https://review.opendev.org/c/openstack/ovn-bgp-agent/+/90226310:55
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-bgp-agent stable/2023.2: Ensure proxy arp and ndp is configure for flat provider networks  https://review.opendev.org/c/openstack/ovn-bgp-agent/+/90238411:10
mnasiadkaHello - is there an option to force sync of ovn-octavia-provider LBs to OVN NB? like Neutron has a sync script?11:12
opendevreviewMerged openstack/neutron master: Remove agent veth_mtu configuration option  https://review.opendev.org/c/openstack/neutron/+/90147611:27
opendevreviewMerged openstack/ovn-bgp-agent stable/2023.2: Ensure proxy arp and ndp is configure for flat provider networks  https://review.opendev.org/c/openstack/ovn-bgp-agent/+/90238411:31
opendevreviewMerged openstack/neutron stable/wallaby: [DHCP agent] Fetch OVN Metadata port from plugin  https://review.opendev.org/c/openstack/neutron/+/90185212:27
opendevreviewMerged openstack/neutron stable/wallaby: [DHCP agent] Fix route to OVN metadata port for non-isolated networks  https://review.opendev.org/c/openstack/neutron/+/90178112:39
opendevreviewMerged openstack/neutron stable/2023.2: Fix the common/ovn functional tests  https://review.opendev.org/c/openstack/neutron/+/90215412:39
opendevreviewMerged openstack/neutron-tempest-plugin master: Update the contributor information  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/90104312:39
opendevreviewMerged openstack/neutron stable/2023.2: [fullstack] Unify ``TestQoSPolicyIsDefault`` tests  https://review.opendev.org/c/openstack/neutron/+/89895613:11
opendevreviewMerged openstack/neutron stable/2023.2: [fullstack] Unify ``TestMTUScenarios`` tests  https://review.opendev.org/c/openstack/neutron/+/89895513:11
opendevreviewMerged openstack/neutron master: Remove a print statement from the iptables unit test  https://review.opendev.org/c/openstack/neutron/+/89725113:11
opendevreviewMerged openstack/neutron master: [ovn]Only synchronize non dynamic segments  https://review.opendev.org/c/openstack/neutron/+/89193013:11
opendevreviewMerged openstack/neutron master: TestSegmentHostMappingNoStore class is missing config  https://review.opendev.org/c/openstack/neutron/+/89725213:11
opendevreviewMerged openstack/neutron master: Add python3.10 support in testing runtime  https://review.opendev.org/c/openstack/neutron/+/89027513:11
opendevreviewMerged openstack/neutron stable/xena: docs: update default value of metadata workers for ml2/ovn  https://review.opendev.org/c/openstack/neutron/+/90149913:11
sahidquick auestion, why don't we have this option configured to true by default for OVS? explicitly_egress_direct13:21
sahidmy understanding is that without this option networking equipments do not handle the packet as a normal packet13:26
sahidand for example it seems that ovs does not learn mac addresses13:27
sahidbut I would be interested to understand the reason of having it defaulted to False13:27
sahidI guess there are side effect as-well13:27
opendevreviewBrian Haley proposed openstack/neutron master: Remove the SubresourceTest class  https://review.opendev.org/c/openstack/neutron/+/90233513:38
*** ykarel is now known as ykarel|away13:51
haleyb#startmeeting neutron_drivers14:00
opendevmeetMeeting started Fri Dec  1 14:00:40 2023 UTC and is due to finish in 60 minutes.  The chair is haleyb. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'neutron_drivers'14:00
mlavalle\o14:00
lajoskatonao/14:00
haleybi'm hoping ihrachys_ saw my email about his RFE14:01
haleybbut we don't have quorom yet, lets wait14:02
haleyb#link https://bugs.launchpad.net/neutron/+bug/204505814:02
haleybin case anyone wants to read14:02
obondarevo/14:02
ihrachys_I did not see it yet but I will check14:04
* mlavalle reading14:05
haleybihrachys_: since it was tagged as an rfe i added it to the agenda14:05
ihrachys_so long story short, neutron manually manages long RPC calls; and oslo.messaging already supports something similar (or better) so we could adopt it14:05
ihrachys_(better because clients heartbeat and not just timeout on long calls)14:06
haleybihrachys_: yes, it seemed to me like a good change, especially since another project has a blueprint to follow14:07
obondarevcan we adopt it without disabling neutron mechanism? Thus we'll have some backup mechanism and potentially we can see which is working better in our case14:07
obondarevand eventually disable another14:08
lajoskatonaThis is the oslo patch which introduces the option (I can't find the doc); https://review.opendev.org/c/openstack/oslo.messaging/+/54676314:08
haleybi forgot the ping...14:08
haleybping ykarel, mlavalle, mtomaska, slawek, obondarev, tobias-urdin, lajoskatona, amotoki14:08
mlavalleLOL14:08
ihrachys_I think we can adopt step by step and it seems like a good approach14:08
mlavalleI'm here14:08
haleybit was just a blind copy/paste :)14:08
lajoskatonaThe nova patch you referenced in RFE do this only for longer than 60sec calls, or am I misunderstood?14:09
ihrachys_backoff client activates its logic on MessagingTimeout so if oslo.msg doesn't return it, it should be NOOP14:09
ihrachys_lajoskatona I think so and I believe it's because they don't expect timeouts from calls that are shorter than 60s?14:09
lajoskatonaihrachys_: good explanation, so possible14:10
obondarevihrachys_: perfect then, so no need to immediately disable neutron lib backoff14:10
ihrachys_probably some optimization not to send too many heartbeats; good point and we should check with nova why they do it14:10
ihrachys_I can check with dan who posted the nova patch14:11
ihrachys_actually he's here dansmith 14:11
mlavallewow, what an honor... dansmith is here!14:12
ihrachys_"keep the failure timing characteristics that our code likely expects (from history)" in code, not sure what it means :)14:12
haleybwas that really from 5 years ago in nova? wow14:13
mlavallethat;s what the commit says14:14
ihrachys_yes. Dan told me about it half a year ago and I just got to post it in launchpad so...14:14
haleybi would be curious if it worked as they intended, and also if it code has changed since then14:15
lajoskatona+114:16
ihrachys_Dan mentioned it to me when he heard that we still manually bump timeouts in high scale envs; and said this approach works for them fine.14:16
ihrachys_(and so we should adopt it)14:17
haleybihrachys_: ack14:17
haleybso i think the only problem is we don't have quorom to vote, i only counted 4 of us14:17
mlavalleit looks very reasonable to me14:18
mlavalleihrachys_: will you implement it?14:18
haleybbut i think it's a good idea, on the fence if it even needs a spec14:18
ihrachys_mlavalle: I will14:18
mlavalleI don't feel we need a spec. Maybe use the first few revisions to the patch as a PoC and see how it goes14:19
lajoskatonaagree14:19
mlavallecount my vote as +1, either today or next meeting14:22
lajoskatonaI would say, let's add some more details to the RFE like how it works for nova, how to handle shorter that 60sec calls etc, and push PoCn ad if we need formal vote lets do it in a following drivers meting or even team meeting14:22
ihrachys_ack14:22
lajoskatona+1 from me also14:22
ihrachys_I will probably post patches in the next year though :)14:22
haleyball sounds good, +1 from me as well, if you want to start work we can just table vote until next meeting14:23
mlavallelajoskatona: good approach. this way we don't waste ihrachys_ time and he can move forward, whenever the upcoming holidays season allow him14:23
obondarev+1 for the RFE14:23
lajoskatona+1for holiday season :P14:24
haleybihrachys_: i will keep on agenda for next week if you like and will be around14:24
mlavalleihrachys_: I don't think we are in a rush for this. We've waited 5 years, I think we will survive another couple of months :-)14:24
mlavalleand thanks for bringing this up!14:25
mlavalleI think it is a worthwhile optimization14:25
haleybare there any other rfe's to discuss? otherwise i can let everyone go back to Review Days! :)14:25
haleybi will take that as a No14:26
ihrachys_o/14:27
haleybhave a good weekend everyone, and thanks ihrachys_ 14:27
haleyb#endmeeting14:27
opendevmeetMeeting ended Fri Dec  1 14:27:19 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:27
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-12-01-14.00.html14:27
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-12-01-14.00.txt14:27
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-12-01-14.00.log.html14:27
lajoskatonaBye, Have a nice weekend14:27
mlavallehaleyb, lajoskatona, obondarev and others participating in the reviews day: https://review.opendev.org/c/openstack/neutron/+/883988 is good to review. The coverage job is punishing me for modules I didn't even touch, so I think I deserve a review14:29
haleybmlavalle: ack, i'll need more coffee for that :)14:46
haleybmaybe i should have created an etherpad for everyone to put a list, instead of going to the large list14:46
haleybhttps://review.opendev.org/q/project:openstack/neutron+status:open14:46
haleybalthough that only shows around 200 open reviews in neutron14:47
mlavallehaleyb: so I have two questions: 1) Just review away what draws our attention for as long as possible today?14:55
mlavallewould it be helpful if I focus on https://review.opendev.org/c/openstack/neutron-vpnaas/+/765353. Or do you want me to look at other things?14:56
haleybmlavalle: that was my plan, looking back should have created a board for things14:56
mlavallehaleyb: ok, I'll look at https://review.opendev.org/c/openstack/neutron-vpnaas/+/765353 and then review other things as time allows14:59
haleybregarding the vpnaas change, and this is just my opinion, i'd rather not spend half the day looking at one change if possible, but you might need the dedicated time to get through it. i'm just herding the cats15:00
mlavallehaleyb: ok, then I'll just review from the Neutron queue15:00
mlavalleand will look at the vpnaas change some other day15:01
haleybi didn't mean to pop that balloon :(15:01
mlavallehaleyb: I'll return to vpnaas other day soon15:02
mlavalleso you didn't really pop anything15:02
lajoskatonahaleyb, mlavalle: ok, so no priority list or similar now for the review day?15:19
haleyblajoskatona: that's my fault, for next week maybe i create an etherpad15:20
haleybbecause there are changes that block other changes, like the IPv6 metadata one15:21
haleybhttps://review.opendev.org/c/openstack/neutron/+/89402615:22
lajoskatonaif you (or others who need quick review) set the review priority works also for me15:26
haleyblajoskatona: oh yeah we do have that field15:33
haleybmlavalle: just finished quick review of OVN router flavors, coffee has kicked-in15:34
mlavallehaleyb: Thanks! How do you want me to deal with the coverage issue? I'm thinking create another patch adding some unit tests (since the guilty modules were not touched by me) and rebase my patch on top of it. Makes sense?15:37
haleybmlavalle: i suppose. looking at the coverage report it does list neutron/services/ovn_l3/service_providers/user_defined.py at 0%, but it looked like you just moved the code?15:41
haleybi almost don't want to look closely at that report as it will distract me15:44
mlavallehaleyb: good point. In that case I'll add unit tests for neutron/services/ovn_l3/service_providers/user_defined.py in the current patch and see if that fixes the issue. And of course I'll address your comments. Thanks15:46
haleybmlavalle: thanks, and not sure all my comments are valid, thanks for working on the patch!15:47
opendevreviewLajos Katona proposed openstack/neutron master: FIP QoS: check policy id before blindly updating FIP  https://review.opendev.org/c/openstack/neutron/+/89946915:48
opendevreviewLajos Katona proposed openstack/networking-sfc master: Remove usage of LBaaS constants  https://review.opendev.org/c/openstack/networking-sfc/+/90242715:52
opendevreviewMerged openstack/networking-bgpvpn master: Add python3.10 support in testing runtime  https://review.opendev.org/c/openstack/networking-bgpvpn/+/89486516:10
opendevreviewEduardo Olivares proposed openstack/neutron stable/zed: [DNM] Skip StatelessSecurityGroup Tobiko tests  https://review.opendev.org/c/openstack/neutron/+/90243016:34
opendevreviewMerged openstack/neutron-lib master: Update default for BFD/ECMP router extra attributes  https://review.opendev.org/c/openstack/neutron-lib/+/89302617:22
opendevreviewEduardo Olivares proposed openstack/neutron stable/zed: [DNM] Skip StatelessSecurityGroup Tobiko tests  https://review.opendev.org/c/openstack/neutron/+/90243017:55
opendevreviewMerged openstack/neutron master: Remove ovs_integration_bridge configuration option  https://review.opendev.org/c/openstack/neutron/+/90147418:20
opendevreviewBrian Haley proposed openstack/neutron master: DNM - testing functional test failures  https://review.opendev.org/c/openstack/neutron/+/90244721:30
haleybmlavalle: thanks for all the reviews, i'm done for the day. if you're looking for an old one i just noticed https://review.opendev.org/c/openstack/neutron/+/618208 8-o23:07
opendevreviewMerged openstack/neutron master: l3_extra_gws: Listing GW ports requires admin context  https://review.opendev.org/c/openstack/neutron/+/89779823:58
opendevreviewMerged openstack/neutron master: l3_extra_gws: Fix KeyError when removing extra GW port  https://review.opendev.org/c/openstack/neutron/+/89779923:58

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!