| opendevreview | Miguel Lavalle proposed openstack/neutron master: [PoC][DNM] Router flavors and service type for OVN https://review.opendev.org/c/openstack/neutron/+/883988 | 00:53 |
|---|---|---|
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Increase neutron-tempest-plugin-bgpvpn-bagpipe timeout https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/883991 | 01:37 |
| opendevreview | Merged openstack/neutron master: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/883582 | 05:42 |
| opendevreview | yatin proposed openstack/neutron master: [DNM] check grenade https://review.opendev.org/c/openstack/neutron/+/883282 | 06:01 |
| opendevreview | ZhouHeng proposed openstack/neutron master: [ovn]disable security group notifier https://review.opendev.org/c/openstack/neutron/+/873850 | 06:15 |
| opendevreview | ZhouHeng proposed openstack/neutron master: Set result when lswitch port exist https://review.opendev.org/c/openstack/neutron/+/881771 | 06:40 |
| opendevreview | ZhouHeng proposed openstack/neutron master: Set result when lswitch port exist https://review.opendev.org/c/openstack/neutron/+/881771 | 07:03 |
| opendevreview | ZhouHeng proposed openstack/neutron master: [ovn]l3 plugin support floating ip distributed attribues https://review.opendev.org/c/openstack/neutron/+/856955 | 07:15 |
| opendevreview | Lajos Katona proposed openstack/neutron-specs master: ERSPAN and GRE mirroring for tap-as-a-service https://review.opendev.org/c/openstack/neutron-specs/+/882151 | 07:21 |
| opendevreview | liuxie proposed openstack/neutron master: [OVN] Support address group for ovn driver https://review.opendev.org/c/openstack/neutron/+/851509 | 07:25 |
| *** elvira1 is now known as elvira | 07:46 | |
| sahid | o/ hello lajoskatona I think that you have some context on https://review.opendev.org/c/openstack/neutron/+/880131 and you also have validated the fix locally. | 07:53 |
| sahid | if you have chance to make a second look :) | 07:54 |
| lajoskatona | sahid: I will check it, thanks for warning ;) | 07:56 |
| sahid | cool thanks a lot | 07:57 |
| ralonsoh | hello folks, I've sent a patch to deprecate networking-odl | 08:06 |
| ralonsoh | https://review.opendev.org/c/openstack/governance/+/884002 | 08:06 |
| ralonsoh | please review this patch | 08:06 |
| opendevreview | Lajos Katona proposed openstack/neutron master: Add connection.close() to CommonAgentLoop stop method https://review.opendev.org/c/openstack/neutron/+/884004 | 08:09 |
| ralonsoh | lajoskatona, there is another patch | 08:09 |
| ralonsoh | https://review.opendev.org/c/openstack/neutron/+/883685 | 08:10 |
| slaweq | ralonsoh I will check it after the meeting I'm in now | 08:14 |
| opendevreview | Rodolfo Alonso proposed openstack/python-neutronclient master: OSC: Remove BGPVPN calls to neutronclient https://review.opendev.org/c/openstack/python-neutronclient/+/875728 | 08:18 |
| lajoskatona | ralonsoh: ack, I just realised | 08:22 |
| ralonsoh | np | 08:22 |
| slaweq | ralonsoh You have my RC +1 in https://review.opendev.org/c/openstack/governance/+/884002 but You will need also votes from other TC members there | 08:35 |
| slaweq | ralonsoh I also updated topic for this patch to the correct one according to https://governance.openstack.org/tc/reference/house-rules.html#other-project-team-updates | 08:36 |
| ralonsoh | slaweq, thanks! | 08:38 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Improve "sync_ha_chassis_group" method https://review.opendev.org/c/openstack/neutron/+/872023 | 08:39 |
| opendevreview | yatin proposed openstack/neutron master: [DNM] reproduce grenade issue https://review.opendev.org/c/openstack/neutron/+/883629 | 08:44 |
| ralonsoh | lajoskatona, qq: do we need to backport https://review.opendev.org/c/openstack/neutron/+/883582? If I'm not wrong, the patch was merged up to Xena | 08:53 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Improve "sync_ha_chassis_group" method https://review.opendev.org/c/openstack/neutron/+/872023 | 08:56 |
| opendevreview | Lajos Katona proposed openstack/python-neutronclient master: OSC: Remove BGPVPN calls to neutronclient https://review.opendev.org/c/openstack/python-neutronclient/+/875728 | 09:53 |
| opendevreview | Lajos Katona proposed openstack/neutron stable/2023.1: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/883927 | 09:54 |
| lajoskatona | raonsoh: yes we must, and I go back to this topic to find a way of fixing it without affecting OVN (or other drivers), I started the backport | 09:55 |
| ralonsoh | lajoskatona, thanks for the confirmation | 10:06 |
| ralonsoh | guilhermesp_____, I've commented on https://review.opendev.org/c/openstack/neutron/+/883235 | 10:24 |
| ges | ralonsoh: thanks ! I am going to eat now, but if you're here this afternoon we can discuss it more here on on the patch. What we have observed is that the bulk_pull is still performed upon SG deletion, probably because the rules are inserted in the cache through a push call when they are created. | 10:55 |
| ges | There is also another issue that someone here is looking into (I don't know if it affects master though): when restarting the agent, the cache is empty and only the SG rules belonging to a port owned by the agent are populated in the resource cache, and no SG is set. This means that, upon an SG deletion, in _clear_child_sg_rules, since we return early "if not existing", we | 10:58 |
| ges | will not clear the cache here either. | 10:58 |
| ralonsoh | we cache all resources needed by the agent, including SGs and SG rules | 11:02 |
| ralonsoh | we are just reading from the RPC updates | 11:03 |
| ralonsoh | slaweq, qq, did you open a LP bug for the centos periodic job issues? | 11:16 |
| ralonsoh | if not, I'll open one now | 11:16 |
| opendevreview | Lajos Katona proposed openstack/python-neutronclient master: BGPVPN: make resource_association method calls logic simpler https://review.opendev.org/c/openstack/python-neutronclient/+/884180 | 11:25 |
| lajoskatona | slaweq, ralonsoh: Hi, could you please check this fwaas patch for standard attrs: https://review.opendev.org/c/openstack/neutron-fwaas/+/866988 ? | 11:51 |
| ralonsoh | lajoskatona, sure (I'm going for lunch now, but just after lunch) | 11:51 |
| lajoskatona | ralonsoh: thanks | 12:05 |
| lajoskatona | ralonsoh: not urgent and not a big or risky patch | 12:05 |
| opendevreview | Elod Illes proposed openstack/networking-odl master: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884185 | 12:25 |
| frickler | lajoskatona: slaweq: just stumbled about https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/846360 and https://review.opendev.org/c/openstack/networking-bagpipe/+/847644, do you want to go on with that or abandon the former? | 12:30 |
| opendevreview | Merged openstack/neutron master: [sqlalchemy-20] Add the transaction context to the upgrade checks methods https://review.opendev.org/c/openstack/neutron/+/882865 | 12:35 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/2023.1: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884188 | 12:38 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/zed: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884189 | 12:39 |
| lajoskatona | frickler: sorry I am out of context for this now :-) For https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/846360 we have to merge https://review.opendev.org/c/openstack/networking-bagpipe/+/847644 but that failed in zuul as I remember | 12:39 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/yoga: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884190 | 12:39 |
| lajoskatona | frickler: I can reopen it to have fresh results | 12:39 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/xena: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884191 | 12:40 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/wallaby: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884192 | 12:41 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/victoria: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884193 | 12:41 |
| frickler | lajoskatona: I just want to clean up open openstack-zuul-jobs reviews, auto-abandoning them like neutron does might also be a valid approach | 12:42 |
| opendevreview | Elod Illes proposed openstack/networking-odl stable/ussuri: Remove periodic-stable-jobs template https://review.opendev.org/c/openstack/networking-odl/+/884195 | 12:44 |
| lajoskatona | frickler: I see, I restored the bagpipe patch and keep an eye on it to push it, let's give it a try, if fails we can abandon the zuul-jobs one | 12:45 |
| lajoskatona | frickler: thanks for asking | 12:45 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Increase the waiting period to receive a port creation event https://review.opendev.org/c/openstack/neutron/+/884201 | 13:20 |
| ralonsoh | slaweq, apart from the members in https://review.opendev.org/admin/groups/q/filter:neutron (neutron-core and neutron-drivers-core) | 13:26 |
| ralonsoh | where is the core list? is there any repository? | 13:27 |
| slaweq | ralonsoh no, there's no any repo with that | 13:28 |
| slaweq | it's just in gerrit | 13:28 |
| ralonsoh | slaweq, thanks! | 13:28 |
| slaweq | and maybe in launchpad, let me check | 13:28 |
| lajoskatona | ralonsoh: I know this list: https://review.opendev.org/admin/groups/9b227d5d1b27471dacbe9a9161904ec115a74138,members but no repo | 13:29 |
| ralonsoh | lajoskatona, thanks! | 13:29 |
| ralonsoh | I'm going to send a mail updating the list | 13:30 |
| ralonsoh | actually you both were in those mails | 13:30 |
| ralonsoh | but before changing anything in gerrit, I'm sending a mail first | 13:30 |
| opendevreview | Merged openstack/neutron stable/train: Fix not working use_random_fully config option https://review.opendev.org/c/openstack/neutron/+/883429 | 13:30 |
| *** haleyb_ is now known as haleyb | 13:30 | |
| haleyb | i'm wondering if the neutron-core list needs some pruning? | 13:31 |
| ralonsoh | yes, I'm going to send a mail today | 13:34 |
| haleyb | ack | 13:34 |
| opendevreview | Merged openstack/neutron stable/wallaby: [ovn] Avoid unwanted ACL_NOT_FOUND error when deleting log objects https://review.opendev.org/c/openstack/neutron/+/883721 | 13:48 |
| zigo | frickler: Regarding https://bugs.launchpad.net/neutron/+bug/1667329, I believe it's addressed since I took over https://review.opendev.org/c/openstack/neutron/+/669395 and it was merged. However, there's still the issue that it doesn't work for router's external gateway. Unfortunately, this is too much for my skills, but it'd be super nice of someone could implement it... | 14:01 |
| zigo | I wrote this part of the Neutron docs too, explaining how to do the setup: https://docs.openstack.org/neutron/latest/admin/config-bgp-floating-ip-over-l2-segmented-network.html | 14:01 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovsdbapp master: Ensure LrpAddCommand may_exits works without peers https://review.opendev.org/c/openstack/ovsdbapp/+/882269 | 14:02 |
| opendevreview | Merged openstack/neutron stable/xena: [ovn] Avoid unwanted ACL_NOT_FOUND error when deleting log objects https://review.opendev.org/c/openstack/neutron/+/883720 | 14:04 |
| opendevreview | Merged openstack/neutron stable/yoga: [ovn] Avoid unwanted ACL_NOT_FOUND error when deleting log objects https://review.opendev.org/c/openstack/neutron/+/883719 | 14:08 |
| opendevreview | Merged openstack/neutron stable/zed: [ovn] Avoid unwanted ACL_NOT_FOUND error when deleting log objects https://review.opendev.org/c/openstack/neutron/+/883718 | 14:08 |
| opendevreview | Merged openstack/neutron stable/2023.1: [ovn] Avoid unwanted ACL_NOT_FOUND error when deleting log objects https://review.opendev.org/c/openstack/neutron/+/883717 | 14:08 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Improve the ``PortBindingUpdateVirtualPortsEvent`` match filter https://review.opendev.org/c/openstack/neutron/+/883681 | 14:10 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: gate: bump ovn to the latest LTS release (22.03) https://review.opendev.org/c/openstack/neutron/+/880890 | 14:11 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/zed: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/884205 | 14:13 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/yoga: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/884206 | 14:13 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/xena: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/884207 | 14:14 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Improve "sync_ha_chassis_group" method https://review.opendev.org/c/openstack/neutron/+/872023 | 14:37 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [sqlalchemy-20] Open a connection to execute a command https://review.opendev.org/c/openstack/neutron/+/883521 | 14:43 |
| ralonsoh | folks, if you have 1 min: | 14:43 |
| ralonsoh | * https://review.opendev.org/c/openstack/neutron/+/883421 | 14:43 |
| ralonsoh | * https://review.opendev.org/c/openstack/neutron/+/883521 | 14:43 |
| ralonsoh | easy reviews | 14:44 |
| sahid | o/ ralonsoh just noticed your comment on https://review.opendev.org/c/openstack/neutron/+/880131 and replied on it, let me kknoow if you have a preference on fixing the issue from agent, you may have some visions that i'm missing | 14:44 |
| ralonsoh | I'll check the patch later today | 14:44 |
| sahid | sure, give me a moment to minus one your two patches ;) | 14:45 |
| ralonsoh | 8) | 14:46 |
| opendevreview | Merged openstack/ovn-octavia-provider stable/wallaby: Add retry on case of sqlite3.InterfaceError on FT https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883805 | 14:46 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovsdbapp master: Ensure LrpAddCommand may_exits works without peers https://review.opendev.org/c/openstack/ovsdbapp/+/882269 | 14:49 |
| ges | ralonsoh: I'm back from the (extended) lunch break. Maybe in the later versions, the cache is properly populated upon restart, but we still observe all the agents running the bulk_pull upon SG deletion in xena. | 14:51 |
| ges | From what I understand this would be because to be in _satisfied_server_queries, we should have performed a call to _flood_cache_for_query for the deleted SG at least once. But I think we don't do that. | 14:53 |
| ralonsoh | the SG resource should have been populated when the agent is started | 14:54 |
| ralonsoh | I see that when I restart the agent and after some seconds, I delete the SG from the port | 14:54 |
| ralonsoh | (using master) | 14:54 |
| ralonsoh | but this code has not change in a while | 14:55 |
| ralonsoh | not changed* | 14:55 |
| opendevreview | liuxie proposed openstack/neutron-fwaas master: Support standard_attrs for fwaas resources https://review.opendev.org/c/openstack/neutron-fwaas/+/866988 | 14:58 |
| ges | I think it's not populated through the same mechanism. When you create the SG, it gets pushed because the agents subscribe to some topics I think, but that doesn't seem to fill-up _satisfied_server_queries. | 15:01 |
| ralonsoh | ok then you should fix that (if possible), but not shortcut the cache lookup | 15:02 |
| ges | And about populating the cache upon startup, when i dump the cache on startup, I only see the rules that are associated to a port managed by the agent. But that could be because either our antique code, or some weird changes we made here. | 15:02 |
| ralonsoh | this is what is expected, only the SG rules used by the host ports | 15:02 |
| ges | so in this case, we will never go through with the _clear_child_sg_rules, because it will exit early if the secgroup is not in the cache | 15:03 |
| ges | (that's probably another bug though) | 15:05 |
| ges | I can see if there's an easy way to populate _satisfied_server_queries when the agent receives a push for a resource_update or created, but that seems like we'll be caching stuff twice (in _satisfied_server_queries and in the good old resource_cache itself) | 15:07 |
| ges | Either way, do you think there cases where we don't want to rely on the cache alone and need to query neutron-rpc for the rules belonging to an SG we are deleting? | 15:10 |
| ralonsoh | I'm checking this code now, one sec | 15:11 |
| frickler | zigo: thx for the pointers, will take a closer look | 15:30 |
| ralonsoh | ges, in this case we maybe need a different way to remove the SG rules from the cache, without retrieving the whole SG | 15:45 |
| ralonsoh | I'm checking what is in the cache and if we can do a search of SGrules using the SG id | 15:46 |
| ges | We can | 15:46 |
| ges | (that is what my patch is doing) | 15:46 |
| ralonsoh | right, I need to agree with you indeed | 15:49 |
| ralonsoh | let me review again the patch with this new perspective | 15:49 |
| ges | although we could find another way than using match_resources_with_func. but for sure the rules are stored with their IDs, so worst case we will have an easy O(N) search | 15:49 |
| opendevreview | Merged openstack/ovn-octavia-provider stable/yoga: Add retry on case of sqlite3.InterfaceError on FT https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883803 | 15:49 |
| ralonsoh | this could be optimized but I would spend time on this now | 15:50 |
| ralonsoh | I wouldn't * | 15:50 |
| ges | yeah, I don't think it's too bad either | 15:50 |
| ralonsoh | ges I'm commenting on the patch now | 15:53 |
| ralonsoh | I would like some testing on this, please | 15:53 |
| ralonsoh | but the code looks OK | 15:54 |
| opendevreview | Merged openstack/neutron-dynamic-routing stable/zed: Fix address_scope calculation https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/883583 | 15:54 |
| opendevreview | Juan Pablo Suazo proposed openstack/tap-as-a-service master: Support for ovs-dpdk https://review.opendev.org/c/openstack/tap-as-a-service/+/884239 | 15:54 |
| ges | Thanks for your help. Do you have some specific points you would like to be tested ? | 15:55 |
| ralonsoh | ges, you can check ``RemoteResourceCacheTestCase`` class and add some testing adding/removing SG rules and checking you remove from the local cache only the expected ones | 15:56 |
| ges | Sounds good. Thanks again for the discussion and the review and have a good evening! | 16:01 |
| opendevreview | Juan Pablo Suazo proposed openstack/tap-as-a-service master: Support for ovs-dpdk https://review.opendev.org/c/openstack/tap-as-a-service/+/884239 | 16:11 |
| opendevreview | Merged openstack/neutron stable/2023.1: Revert "Delete sg rule which remote is the deleted sg" https://review.opendev.org/c/openstack/neutron/+/883927 | 16:19 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-fwaas master: Support standard_attrs for fwaas resources https://review.opendev.org/c/openstack/neutron-fwaas/+/866988 | 16:24 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Test devstack patch https://review.opendev.org/c/openstack/neutron/+/884248 | 16:28 |
| rammses | G'day everyone | 16:53 |
| rammses | I have some questions about traffic flow while implementing bgpaas | 16:53 |
| rammses | is this the correct place ? | 16:54 |
| opendevreview | Merged openstack/ovn-octavia-provider stable/xena: Add retry on case of sqlite3.InterfaceError on FT https://review.opendev.org/c/openstack/ovn-octavia-provider/+/883804 | 17:38 |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Make neutron-tempest-plugin-bgpvpn-bagpipe non-voting https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/884270 | 18:23 |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Make neutron-tempest-plugin-bgpvpn-bagpipe non-voting https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/884270 | 18:30 |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Make neutron-tempest-plugin-bgpvpn-bagpipe non-voting https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/884270 | 18:33 |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Make neutron-tempest-plugin-bgpvpn-bagpipe non-voting https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/884270 | 18:37 |
| opendevreview | Alfredo Moralejo proposed openstack/neutron master: Test devstack patch https://review.opendev.org/c/openstack/neutron/+/884279 | 19:11 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: [PoC][DNM] Router flavors and service type for OVN https://review.opendev.org/c/openstack/neutron/+/883988 | 20:23 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: [PoC][DNM] Router flavors and service type for OVN https://review.opendev.org/c/openstack/neutron/+/883988 | 20:39 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: Allow Multiple External Gateways https://review.opendev.org/c/openstack/neutron/+/873593 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: Add extra router attributes for ECMP and BFD https://review.opendev.org/c/openstack/neutron/+/874797 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Implement support for external-gateway-multihoming extension https://review.opendev.org/c/openstack/neutron/+/874199 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Honor `enable_default_route_ecmp` attribute https://review.opendev.org/c/openstack/neutron/+/878531 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Allow L3 scheduler to be aware of current transaction https://review.opendev.org/c/openstack/neutron/+/874760 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Add helper for retrieving LR associated with LRP https://review.opendev.org/c/openstack/neutron/+/873698 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Apply soft anti-affinity for LRs with multiple LRPs when scheduling https://review.opendev.org/c/openstack/neutron/+/873699 | 23:27 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/neutron master: [ovn] Add support for enable_default_route_bfd attribute https://review.opendev.org/c/openstack/neutron/+/878543 | 23:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!