| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 00:19 |
|---|---|---|
| opendevreview | Miguel Lavalle proposed openstack/os-vif master: Fix race with DPDK and vhostuserclient mode https://review.opendev.org/c/openstack/os-vif/+/830103 | 00:36 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: More robust fix to trunk deletion race condition https://review.opendev.org/c/openstack/neutron/+/829139 | 00:39 |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 01:46 |
| *** congnt1 is now known as congnt | 03:24 | |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 04:19 |
| *** prometheanfire is now known as Guest2 | 04:59 | |
| *** Guest2 is now known as prometheanfire | 05:09 | |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 05:36 |
| opendevreview | shanyunfan33 proposed openstack/neutron master: change skydive source to skydive-project https://review.opendev.org/c/openstack/neutron/+/830114 | 05:49 |
| zhouhenglc | ralonsoh, slaweq revive the neutron-fwaas patch, has fixed the problem of functional test. Can patch be merged first and then fix other problems? | 06:41 |
| zhouhenglc | patch is https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 06:41 |
| ralonsoh | ok | 06:41 |
| zhouhenglc | :) | 06:42 |
| opendevreview | ZhouHeng proposed openstack/neutron-tempest-plugin master: Readd jobs for neutron-fwaas master branch https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/828443 | 06:51 |
| slaweq | zhouhenglc hi, done | 07:19 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/victoria: DNM Revert "Use Port_Binding up column to set Neutron port status" https://review.opendev.org/c/openstack/neutron/+/830062 | 08:14 |
| zhouhenglc | slaweq: sorry, disturb you again. I replied to you https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 08:45 |
| ralonsoh | zhouhenglc, replied to the reply | 08:52 |
| zhouhenglc | ralonsoh, got it, thanks, I need to understand | 09:00 |
| zhouhenglc | for a while | 09:00 |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 09:21 |
| opendevreview | Luis Tomas Bolivar proposed openstack/neutron stable/victoria: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830123 | 09:25 |
| opendevreview | Luis Tomas Bolivar proposed openstack/neutron stable/ussuri: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830064 | 09:26 |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 09:33 |
| opendevreview | Luis Tomas Bolivar proposed openstack/neutron stable/victoria: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830123 | 09:46 |
| opendevreview | Luis Tomas Bolivar proposed openstack/neutron stable/ussuri: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830064 | 09:46 |
| opendevreview | Luis Tomas Bolivar proposed openstack/networking-ovn stable/train: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/networking-ovn/+/830125 | 09:53 |
| opendevreview | Luis Tomas Bolivar proposed openstack/networking-ovn stable/train: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/networking-ovn/+/830126 | 09:54 |
| opendevreview | ZhouHeng proposed openstack/neutron-fwaas master: Revert "Retire neutron-fwaas project" https://review.opendev.org/c/openstack/neutron-fwaas/+/828149 | 10:33 |
| opendevreview | Maor Blaustein proposed openstack/neutron-tempest-plugin master: Fix dependencies and PEP 8 new comments. https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/827292 | 11:19 |
| slaweq | ralonsoh hi, if You will have some time, can You take a look at my last comment in https://bugs.launchpad.net/neutron/+bug/1955008 ? Maybe that will ring a bell for You somehow :) | 11:44 |
| slaweq | thx in advance | 11:44 |
| ralonsoh | slaweq, sure | 11:45 |
| slaweq | thx | 11:47 |
| slaweq | lajoskatona hi, qq about https://review.opendev.org/c/openstack/neutron/+/816800 and whole series related to that, do You think we will merge all this week before feature freeze? | 11:48 |
| slaweq | or maybe should we simply wait with all those patches to the Zed release? | 11:48 |
| slaweq | wdyt? | 11:48 |
| slaweq | lajoskatona nvm, I just noticed that most patches have at least one +2 already | 11:49 |
| slaweq | so I will review them and we should be good to go with it this week hopefully | 11:49 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron master: Allow ovn_db_sync to continue on duplicate normalised CIDR https://review.opendev.org/c/openstack/neutron/+/801707 | 11:57 |
| slaweq | ralonsoh lajoskatona please also check https://review.opendev.org/c/openstack/neutron/+/801707 when You will have some time, we have now new bug reported for that issue | 11:58 |
| ralonsoh | sure | 11:58 |
| slaweq | thx a lot | 11:59 |
| opendevreview | Merged openstack/neutron master: Doc: Due to recent grafana upgrade change urls in doc https://review.opendev.org/c/openstack/neutron/+/828507 | 12:01 |
| lajoskatona | slaweq: Hi, you are right, this week is feature freeze, the pps limitation stayed under radar for too long time... | 12:02 |
| opendevreview | Merged openstack/neutron-specs master: smartnic-dpu: Update implementation details https://review.opendev.org/c/openstack/neutron-specs/+/829715 | 12:07 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/ussuri: Allow to create ovn loadbalancer on dual-stack provider networks https://review.opendev.org/c/openstack/ovn-octavia-provider/+/830150 | 12:12 |
| opendevreview | Luis Tomas Bolivar proposed openstack/networking-ovn stable/train: Allow to create ovn loadbalancer on dual-stack provider networks https://review.opendev.org/c/openstack/networking-ovn/+/830152 | 12:24 |
| sean-k-mooney | slaweq: ralonsoh, lajoskatona im sure ye are aware of https://review.opendev.org/c/openstack/neutron/+/829247 from the last irc meeting but this looks to be in reasonably good shape if ye have time to review. context is sriov PF mac change on move operations | 12:47 |
| ralonsoh | sean-k-mooney, let me check after lunch | 12:47 |
| sean-k-mooney | as a bug fix its not directly impacted by feature freeze but still nice to have | 12:47 |
| lajoskatona | sean-k-mooney: thanks, it is in front of me :-) | 12:47 |
| sean-k-mooney | :) one thing i spoke to gibi about and just wanted to confirm. we should be able to backport this upstream correct. downstream we have customers that have requested we adress this uscae in osp and i hate doing downstream only backports so if we think this has backport potentil it might be nice to mark the bug as such | 12:49 |
| sean-k-mooney | im fine with defering that desiion to the sable team but i think there should not be an issue backporting it | 12:50 |
| sean-k-mooney | anyway thanks in advance | 12:51 |
| opendevreview | Merged openstack/ovn-octavia-provider stable/xena: Allow to create ovn loadbalancer on dual-stack provider networks https://review.opendev.org/c/openstack/ovn-octavia-provider/+/829439 | 13:01 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/wallaby: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828729 | 13:19 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/victoria: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828728 | 13:19 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/ussuri: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828730 | 13:19 |
| opendevreview | Merged openstack/ovn-octavia-provider stable/wallaby: Allow to create ovn loadbalancer on dual-stack provider networks https://review.opendev.org/c/openstack/ovn-octavia-provider/+/829440 | 13:19 |
| lucasagomes | bcafarel, ralonsoh ^ I had to fix a merge conflict in those stable branch patches there | 13:20 |
| lucasagomes | I know u had reviewed/approved those already sorry for the inconvenience there | 13:21 |
| ralonsoh | lucasagomes, sure, let me check | 13:30 |
| lucasagomes | no rush! Thanks a lot ralonsoh | 13:30 |
| bcafarel | lucasagomes: sure, looking | 13:35 |
| lucasagomes | thanks! | 13:40 |
| opendevreview | Merged openstack/neutron stable/xena: Wait longer before deleting DPDK vhu trunk bridges https://review.opendev.org/c/openstack/neutron/+/829039 | 13:41 |
| opendevreview | Merged openstack/neutron stable/wallaby: Wait longer before deleting DPDK vhu trunk bridges https://review.opendev.org/c/openstack/neutron/+/829040 | 13:46 |
| mlavalle | ralonsoh, slaweq, njohnston: when you have a chance (no rush) please look at: https://review.opendev.org/c/openstack/neutron/+/829139 and https://review.opendev.org/c/openstack/os-vif/+/830103 | 14:06 |
| ralonsoh | ok | 14:06 |
| njohnston | mlavalle: will do | 14:06 |
| opendevreview | Merged openstack/neutron-tempest-plugin master: Fix test_port_resource_request_inherited_policy test https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/817356 | 14:15 |
| opendevreview | Merged openstack/neutron-tempest-plugin master: Test port.resource_request format with min bw and min pps rules https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/817358 | 14:18 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/victoria: Allow to create ovn loadbalancer on dual-stack provider networks https://review.opendev.org/c/openstack/ovn-octavia-provider/+/829441 | 14:23 |
| ralonsoh | sean-k-mooney, I'm not sure about https://review.opendev.org/c/openstack/neutron/+/829247 | 15:24 |
| ralonsoh | please, read my comment | 15:24 |
| opendevreview | Merged openstack/neutron master: Allow ovn_db_sync to continue on duplicate normalised CIDR https://review.opendev.org/c/openstack/neutron/+/801707 | 15:33 |
| sean-k-mooney | ralonsoh: ah so its incompelete its not commitign the port update? | 15:39 |
| ralonsoh | sean-k-mooney, I'll check it again (faking the value) | 15:40 |
| ralonsoh | but no, the DB port is not updated | 15:40 |
| ralonsoh | sean-k-mooney, let me check that again | 15:40 |
| sean-k-mooney | im not super familar with this but i would have assuemd it was saved here https://review.opendev.org/c/openstack/neutron/+/829247/2/neutron/plugins/ml2/plugin.py#762 | 15:44 |
| sean-k-mooney | or here https://review.opendev.org/c/openstack/neutron/+/829247/2/neutron/plugins/ml2/plugin.py#793 | 15:45 |
| sean-k-mooney | but yes its not clear that it will propegate to there | 15:46 |
| ralonsoh | sean-k-mooney, https://review.opendev.org/c/openstack/neutron/+/829247/2/neutron/plugins/ml2/plugin.py#793 is just to update the port dict | 15:52 |
| ralonsoh | https://review.opendev.org/c/openstack/neutron/+/829247/2/neutron/plugins/ml2/plugin.py#762 calls the driver precommit method | 15:52 |
| ralonsoh | but this is after any DB update | 15:53 |
| ralonsoh | in other words: the port register is updated before | 15:53 |
| ralonsoh | but let me confirm that | 15:53 |
| sean-k-mooney | i guess in either case there is a testing gap | 15:58 |
| sean-k-mooney | as we should be able to assert that with the tests | 15:58 |
| sean-k-mooney | with that said the unit test is trying to get teh port info via a port show | 15:59 |
| sean-k-mooney | _get_port_mac does | 16:00 |
| sean-k-mooney | port = self._show('ports', port_id)['port'] | 16:00 |
| sean-k-mooney | so that imples the unit test are mocking too much | 16:00 |
| sean-k-mooney | from the testign that was written its resonable to expect that the port update was done to the db | 16:01 |
| *** ykarel is now known as ykarel|away | 16:03 | |
| ralonsoh | sean-k-mooney, if, for example, I do this in this method | 16:06 |
| ralonsoh | if port['id'] == "1fe3f264-10ed-42a6-9cee-f3690ced2ff6": | 16:06 |
| ralonsoh | port[port_def.PORT_MAC_ADDRESS] = "ca:fe:ca:fe:ca:fe" | 16:06 |
| ralonsoh | this port ID is one port created manually | 16:06 |
| ralonsoh | every time I retrieve this port (show, list, binding, etc) | 16:06 |
| ralonsoh | the neutron server will return the new MAC address | 16:07 |
| ralonsoh | I've created a VM with this port | 16:07 |
| ralonsoh | the MAC of this port is | 16:07 |
| ralonsoh | root@server1:~# ip l show dev ens3 | 16:07 |
| ralonsoh | 2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000 | 16:07 |
| ralonsoh | link/ether ca:fe:ca:fe:ca:fe brd ff:ff:ff:ff:ff:ff | 16:07 |
| ralonsoh | but in the neutron DB | 16:07 |
| ralonsoh | fa:16:3e:dd:4d:2f | 16:08 |
| ralonsoh | (the original one, never modified) | 16:08 |
| sean-k-mooney | ralonsoh: hum ok so it sound like for all intents the update has worked but the db is never updated | 17:14 |
| ralonsoh | sean-k-mooney, correct. In Nova you receive the json from the Neutron API | 17:21 |
| ralonsoh | this is built with the port dict | 17:21 |
| ralonsoh | that is updated in this method | 17:21 |
| opendevreview | Merged openstack/neutron stable/wallaby: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828729 | 17:40 |
| opendevreview | Merged openstack/neutron stable/ussuri: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828730 | 18:51 |
| opendevreview | Merged openstack/neutron stable/victoria: [OVN] Migrate "reside-on-redirect-chassis" for distributed FIP https://review.opendev.org/c/openstack/neutron/+/828728 | 19:44 |
| opendevreview | Merged openstack/neutron stable/victoria: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830123 | 23:12 |
| opendevreview | Merged openstack/neutron stable/ussuri: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/830064 | 23:12 |
| opendevreview | Merged openstack/networking-ovn stable/train: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/networking-ovn/+/830126 | 23:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!