*** EugenMayer1 is now known as EugenMayer | 03:02 | |
*** tbachman_ is now known as tbachman | 04:18 | |
opendevreview | Slawek Kaplonski proposed openstack/neutron stable/xena: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824872 | 07:08 |
---|---|---|
opendevreview | Slawek Kaplonski proposed openstack/neutron stable/wallaby: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824873 | 07:08 |
opendevreview | Slawek Kaplonski proposed openstack/neutron stable/victoria: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824874 | 07:08 |
opendevreview | Slawek Kaplonski proposed openstack/neutron stable/ussuri: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824875 | 07:08 |
opendevreview | Slawek Kaplonski proposed openstack/neutron stable/train: Fix ObjectChangeHandler thread usage https://review.opendev.org/c/openstack/neutron/+/822522 | 07:14 |
opendevreview | yatin proposed openstack/neutron stable/xena: [Stable Xena Only] Drop TripleO periodic jobs https://review.opendev.org/c/openstack/neutron/+/824863 | 07:42 |
ralonsoh | slaweq, hi! sorry for the revert | 08:16 |
ralonsoh | is it possible that you can use BUILD_OVS_FROM_SOURCE instead of Q_BUILD_OVS_FROM_GIT? | 08:17 |
opendevreview | Lajos Katona proposed openstack/neutron master: [Functional/fullstack] Remove tools from irrelevant list https://review.opendev.org/c/openstack/neutron/+/824773 | 08:21 |
opendevreview | yatin proposed openstack/neutron stable/wallaby: Recheck irrelevant files https://review.opendev.org/c/openstack/neutron/+/824901 | 08:50 |
opendevreview | Merged openstack/neutron master: [OVN] Check if OVN SB supports virtual ports https://review.opendev.org/c/openstack/neutron/+/816383 | 09:28 |
slaweq | ralonsoh: hi, no problem, thx for fixing the gate quickly | 09:48 |
slaweq | I will take a look at it and propose it once again but without breaking anything :) | 09:48 |
ralonsoh | I'll review it | 09:49 |
slaweq | ralonsoh: lajoskatona_ hi, please check backports https://review.opendev.org/q/I40b72316bd0f4281484d3cf07542177297028e34 and https://review.opendev.org/c/openstack/neutron/+/822522 when You will have some time, I really need them :) | 10:28 |
slaweq | thx in advance | 10:28 |
lajoskatona | slaweq: sure | 10:29 |
jpic__ | lajoskatona: i mean I changed both dhcp.py's Dnsmasq code and, to a smaller extent, neutron | 10:29 |
ralonsoh | right now | 10:29 |
lajoskatona | slaweq, ralonsoh: I gerrit related question: I try to move this patch: https://review.opendev.org/c/openstack/tap-as-a-service/+/823492 (and https://review.opendev.org/c/openstack/neutron-lib/+/823475) , but I can't make it "ready for review", could you please check if it is a missing permission from my side or a general missing premissions | 10:35 |
ralonsoh | lajoskatona, I don't think you can | 10:37 |
lajoskatona | jpic__: you mean this class: https://opendev.org/openstack/neutron/src/branch/master/neutron/agent/linux/dhcp.py#L362 , than cool? | 10:37 |
ralonsoh | because this is not yours | 10:37 |
lajoskatona | jpic__: I mean if all code changes covered in https://review.opendev.org/c/openstack/neutron/+/824718 ? | 10:38 |
ralonsoh | You need to (1) ask the owner or (2) abandon and propose a new one | 10:38 |
lajoskatona | ralonsoh: yeah, the guy already left my organization, so I suppose I have to abandon/repropose | 10:38 |
ralonsoh | exactly | 10:38 |
slaweq | ralonsoh: can You maybe +W https://review.opendev.org/c/openstack/neutron/+/821132/ ? | 10:42 |
slaweq | thx in advance | 10:42 |
ralonsoh | yes | 10:43 |
slaweq | or wait | 10:45 |
slaweq | it was on top of the patch which You reverted | 10:45 |
slaweq | so I will check it | 10:46 |
slaweq | first :) | 10:46 |
ralonsoh | ah right, we need first the options for centos | 10:47 |
opendevreview | Slawek Kaplonski proposed openstack/neutron master: Make configure_for_func_testing compatible with e.g. Centos https://review.opendev.org/c/openstack/neutron/+/824924 | 11:17 |
slaweq | ralonsoh: ^^ iit's second attempt now | 11:17 |
ralonsoh | let's go | 11:17 |
slaweq | it should works better now, and also it should run functional tests job on that patch so we will see if that breaks anything or not | 11:18 |
slaweq | :) | 11:18 |
ralonsoh | slaweq, but we shouldn't use Q_* variables | 11:18 |
slaweq | why? | 11:18 |
ralonsoh | those are private and internal to the scripts | 11:18 |
slaweq | Q_BUILD_OVS_FROM_GIT is devstack's variable | 11:18 |
slaweq | we are already using it in e.g. neutron's devstack plugin: https://opendev.org/openstack/neutron/src/branch/master/devstack/plugin.sh#L23 | 11:19 |
ralonsoh | heheheh because you added it | 11:19 |
ralonsoh | I think we should not use them, but maybe devstack folks will know that better | 11:19 |
slaweq | but what's the point of having additional variable used in the functional tests job just to set the Q_BUILD_OVS_FROM_GIT later? | 11:21 |
slaweq | do we really need it to be like that? | 11:21 |
opendevreview | Merged openstack/neutron master: [Functional/fullstack] Remove tools from irrelevant list https://review.opendev.org/c/openstack/neutron/+/824773 | 11:22 |
ralonsoh | slaweq, I think at some point, we started to misuse this variable | 11:23 |
opendevreview | Lajos Katona proposed openstack/neutron-lib master: Move API definitions of taas to neutron-lib https://review.opendev.org/c/openstack/neutron-lib/+/824926 | 11:24 |
opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: WIP: Modify taas extensions to use neutron-lib API def https://review.opendev.org/c/openstack/tap-as-a-service/+/824927 | 11:27 |
slaweq | ralonsoh: so do You think we should use in FT job some other variable? | 11:27 |
slaweq | I don't really see any value in that, especially that it's only for the CI purpose, nothing else | 11:27 |
jpic_ | lajoskatona: yes, i'm asking if i can leave them changes all together or if i need to split the RFE and patch | 11:27 |
ralonsoh | slaweq, I'm checking devstack now and we have removed "BUILD_OVS_FROM_SOURCE" from there | 11:27 |
ralonsoh | so at this point makes sense to use the other one | 11:27 |
slaweq | ++ | 11:28 |
ralonsoh | slaweq, there is a merge conflict | 11:30 |
ralonsoh | can you update it? | 11:30 |
slaweq | yes, with https://review.opendev.org/c/openstack/neutron/+/824773 :) | 11:30 |
slaweq | I will update my patch right now | 11:30 |
opendevreview | Slawek Kaplonski proposed openstack/neutron master: Make configure_for_func_testing compatible with e.g. Centos https://review.opendev.org/c/openstack/neutron/+/824924 | 11:32 |
opendevreview | yatin proposed openstack/neutron stable/xena: [Functional] Add extra logs to the L3 HA router transitions https://review.opendev.org/c/openstack/neutron/+/824886 | 11:51 |
opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Modify taas extensions to use neutron-lib API def https://review.opendev.org/c/openstack/tap-as-a-service/+/824927 | 12:11 |
lajoskatona | pic_: as I see your current patch it is not too big, so can be consumed in one, but please push changes to master not to stable/ branches | 12:14 |
lajoskatona | jpic_: and a suggestion: you can locally execute easily some tests with tox, i.e.: tox -epep8 to run static code check | 12:15 |
lajoskatona | jpic_: for executing all the unit tests, you need a lot of CPU time, but even that is possible with tox -epy39 (or py3x depending on your python binary at hand) | 12:16 |
opendevreview | Merged openstack/neutron stable/xena: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824872 | 12:35 |
opendevreview | Merged openstack/neutron stable/wallaby: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824873 | 12:35 |
*** dasm|off is now known as dasm | 13:13 | |
slaweq | ralonsoh: lajoskatona can You check https://review.opendev.org/c/openstack/neutron/+/823412? It's breaking some Tripleo CI jobs | 13:29 |
slaweq | thx a lot in advance | 13:29 |
ralonsoh | sure | 13:30 |
lajoskatona | slaweq: sure | 13:33 |
ralonsoh | ltomasbo, hi! do you mind to rebase https://review.opendev.org/c/openstack/neutron/+/824378 in top of https://review.opendev.org/c/openstack/neutron/+/823412? | 13:38 |
ralonsoh | just to check that both patches solve all trunk port issues | 13:38 |
ralonsoh | thanks in advance! | 13:38 |
ltomasbo | ralonsoh, of course! | 14:00 |
opendevreview | Luis Tomas Bolivar proposed openstack/neutron master: Ensure subports status is aligned with parent port https://review.opendev.org/c/openstack/neutron/+/824378 | 14:03 |
ltomasbo | ralonsoh, done | 14:03 |
ralonsoh | thanks | 14:03 |
ltomasbo | ralonsoh, anyway, regarding https://review.opendev.org/c/openstack/neutron/+/824378, I think there is no testing coverage for it anyway | 14:03 |
ralonsoh | yeah, I know | 14:03 |
ralonsoh | It could be interesting at least to have something in FT | 14:04 |
ralonsoh | is that possible? | 14:04 |
ralonsoh | I say FT because this is usually faster to develop and test | 14:04 |
ralonsoh | and we can simulate trunk ports in the OVN DB | 14:04 |
opendevreview | Merged openstack/neutron stable/victoria: Register cleanup hooks for the object change handlers only when needed https://review.opendev.org/c/openstack/neutron/+/824874 | 14:19 |
opendevreview | Maximilian Stinsky proposed openstack/neutron master: Return true if we are not keepalived primary https://review.opendev.org/c/openstack/neutron/+/824947 | 14:40 |
opendevreview | Merged openstack/ovsdbapp master: Update QoS register in "QoSAddCommand" if exists https://review.opendev.org/c/openstack/ovsdbapp/+/822138 | 15:24 |
gmann | lajoskatona: slaweq ralonsoh mlavalle Not sure if you have discussed about bringing neutron-fwaas back (as discussion going on on ML) but there is project-config change to maintain it outside of openstack because it is deprecated in openstack - https://review.opendev.org/c/openstack/project-config/+/824905/ | 15:36 |
ralonsoh | gmann, it was discussed last friday | 15:36 |
ralonsoh | in the drivers meeting. It was approved to keep it in /x namespace | 15:36 |
ralonsoh | and continue the development there for now | 15:37 |
slaweq | not keep but move it to x/ namespace :) | 15:37 |
lajoskatona | gmann, ralonsoh: yes, exactly | 15:37 |
gmann | ohk, | 15:37 |
slaweq | but all other is correct :) | 15:37 |
gmann | can either of you please update it on ML thread. we will proceed from governance and project-config side. | 15:37 |
slaweq | *everything else is correct | 15:38 |
slaweq | IMO lajoskatona is the best guy to update it | 15:38 |
lajoskatona | slaweq: +1 :P | 15:38 |
gmann | I think this was last reply http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026550.html | 15:38 |
gmann | thanks. | 15:38 |
lajoskatona | gmann: I answer it to the same thread then | 15:39 |
gmann | lajoskatona: perfect, thanks again | 15:39 |
opendevreview | Slawek Kaplonski proposed openstack/neutron master: Don't publish PROVISIONING_COMPLETE notification if there wasn't block https://review.opendev.org/c/openstack/neutron/+/824981 | 15:56 |
opendevreview | Merged openstack/neutron stable/train: Fix ObjectChangeHandler thread usage https://review.opendev.org/c/openstack/neutron/+/822522 | 16:00 |
opendevreview | Slawek Kaplonski proposed openstack/neutron master: Call enable DHCP only if there are subnets with enabled DHCP in network https://review.opendev.org/c/openstack/neutron/+/824982 | 16:07 |
opendevreview | Merged openstack/ovn-octavia-provider master: Set listeners back to ACTIVE upon pool/member action failures https://review.opendev.org/c/openstack/ovn-octavia-provider/+/823544 | 17:03 |
opendevreview | Maximilian Stinsky proposed openstack/neutron master: Return true if we are not keepalived primary https://review.opendev.org/c/openstack/neutron/+/824947 | 17:32 |
opendevreview | Merged openstack/neutron master: Exclude router gw subnet ports from port list while port delete. https://review.opendev.org/c/openstack/neutron/+/824008 | 17:44 |
opendevreview | Merged openstack/networking-ovn stable/train: [OVN] Prevent deleting the only IP of a router port https://review.opendev.org/c/openstack/networking-ovn/+/823787 | 19:37 |
*** eagles_ is now known as eagles | 20:24 | |
opendevreview | Slawek Kaplonski proposed openstack/neutron master: Add FIPS enabled scenario jobs https://review.opendev.org/c/openstack/neutron/+/797537 | 20:27 |
opendevreview | Ade Lee proposed openstack/neutron master: Add FIPS enabled scenario jobs https://review.opendev.org/c/openstack/neutron/+/797537 | 20:32 |
opendevreview | Elod Illes proposed openstack/networking-odl master: Update pylint version https://review.opendev.org/c/openstack/networking-odl/+/823428 | 20:54 |
opendevreview | Elod Illes proposed openstack/networking-odl master: Update pylint version https://review.opendev.org/c/openstack/networking-odl/+/823428 | 21:11 |
*** tbachman_ is now known as tbachman | 23:01 | |
*** dasm is now known as dasm|off | 23:11 | |
*** tbachman_ is now known as tbachman | 23:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!