Tuesday, 2021-08-17

« Monday, 2021-08-16 Index Wednesday, 2021-08-18 »
opendevreviewIhar Hrachyshka proposed openstack/neutron master: DNM ovn: use stateless NAT rules for FIPs  https://review.opendev.org/c/openstack/neutron/+/80480700:51
opendevreviewwushiming proposed openstack/networking-odl master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/networking-odl/+/79372501:59
opendevreviewBoxiang Zhu proposed openstack/neutron-lib master: Fix url display in bpg_speaker  https://review.opendev.org/c/openstack/neutron-lib/+/80481203:52
opendevreviewliuyulong proposed openstack/neutron master: Add table for pps limitaion  https://review.opendev.org/c/openstack/neutron/+/80421304:36
opendevreviewliuyulong proposed openstack/neutron master: Reuse the qos constants from neuron-lib  https://review.opendev.org/c/openstack/neutron/+/80438004:36
opendevreviewliuyulong proposed openstack/neutron-lib master: Move packet_rate_limit type to neutron-lib  https://review.opendev.org/c/openstack/neutron-lib/+/80437805:57
opendevreviewLajos Katona proposed openstack/tap-as-a-service master: Tests: remove tempest plugin from taas repository  https://review.opendev.org/c/openstack/tap-as-a-service/+/80470707:46
*** rpittau|afk is now known as rpittau07:54
opendevreviewMerged openstack/os-ken master: Enhance os-ken to support Nicira PacketIn2  https://review.opendev.org/c/openstack/os-ken/+/79596308:01
opendevreviewSlawek Kaplonski proposed openstack/networking-bgpvpn stable/train: [EM releases] Move non-voting jobs to the experimental queue  https://review.opendev.org/c/openstack/networking-bgpvpn/+/79647608:04
opendevreviewMerged openstack/os-ken master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/os-ken/+/80422808:11
opendevreviewMerged openstack/networking-odl master: Changed minversion in tox to 3.18.0  https://review.opendev.org/c/openstack/networking-odl/+/79372508:17
opendevreviewYi Yang proposed openstack/neutron master: Add a new rpc get_subnet for L2 agent  https://review.opendev.org/c/openstack/neutron/+/80483208:22
slaweqjlibosva: hi, I just checked why patch https://review.opendev.org/c/openstack/neutron/+/803936 got -2 and it seems it failed with the reason which You were going to understand better after that change will be merged :)08:24
slaweqhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_046/803936/1/gate/neutron-functional-with-uwsgi/046de61/testr_results.html08:25
jlibosvaslaweq: yeah, I commented on the change :)08:25
jlibosvaslaweq: seems like the issue might be with instantiating the idls08:25
slaweqjlibosva: ok, sorry08:25
slaweqI checked failures but not last comments :)08:25
jlibosvaslaweq: the question is if we want that patch in - I think it would be good but I may add some additional debug messages if I may :)08:25
slaweqok08:26
slaweqthat's what I was going to ask :)08:26
slaweqso I'm not rechecking it now again08:26
opendevreviewOleg Bondarev proposed openstack/neutron-specs master: Add Node-Local Virtual IP Spec  https://review.opendev.org/c/openstack/neutron-specs/+/79779809:27
opendevreviewOleg Bondarev proposed openstack/neutron master: [WIP] Add Local IP Extension and DB  https://review.opendev.org/c/openstack/neutron/+/80452309:30
opendevreviewMerged openstack/neutron-lib master: Fix url display in bpg_speaker  https://review.opendev.org/c/openstack/neutron-lib/+/80481209:49
opendevreviewOleg Bondarev proposed openstack/neutron-specs master: Add Node-Local Virtual IP Spec  https://review.opendev.org/c/openstack/neutron-specs/+/79779810:52
opendevreviewSlawek Kaplonski proposed openstack/neutron-lib master: extension for adding bfd monitors to extraroutes  https://review.opendev.org/c/openstack/neutron-lib/+/77885911:20
opendevreviewZhouHeng proposed openstack/neutron master: [WIP][ovn]support read chassis update time from nb_cfg_timetamp  https://review.opendev.org/c/openstack/neutron/+/80283411:22
opendevreviewyangjianfeng proposed openstack/neutron master: Improve Router callback system's publish events  https://review.opendev.org/c/openstack/neutron/+/80484611:35
opendevreviewLajos Katona proposed openstack/neutron-lib master: extension for adding bfd monitors to extraroutes  https://review.opendev.org/c/openstack/neutron-lib/+/77885911:49
opendevreviewMerged openstack/neutron-lib master: Add port-resource-request-groups shim API ext  https://review.opendev.org/c/openstack/neutron-lib/+/80390512:27
kklimondahmm, for some reason when I'm doing amphora failover in octavia with ovn ml2 driver, virtual port configuration in ovn nb is lost..12:39
kklimondaso, ovn driver, when deciding whether given port is virtual, checks if device_owner is not set13:01
kklimondaoctavia sets device_owner to "Octavia"13:01
kklimondahilarity ensues 13:02
opendevreviewRodolfo Alonso proposed openstack/neutron master: Do not fail if the agent load is not bumped  https://review.opendev.org/c/openstack/neutron/+/80421813:36
opendevreviewManu B proposed openstack/neutron-lib master: Introduce new bgp_associations API definition  https://review.opendev.org/c/openstack/neutron-lib/+/79277413:59
slaweq#startmeeting networking14:00
opendevmeetMeeting started Tue Aug 17 14:00:38 2021 UTC and is due to finish in 60 minutes.  The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'networking'14:00
mlavalleo/14:00
njohnstono/14:00
slaweqo/14:00
obondarevhi14:01
ralonsohhi14:01
amotokio/14:01
rubasovo/14:01
lajoskatonao/14:02
slaweqok, let's start14:02
slaweq#topic Announcements14:02
slaweqXena cycle calendar https://releases.openstack.org/xena/schedule.html14:02
slaweqthis week is final release for non-client libraries 14:02
opendevreviewManu B proposed openstack/neutron-lib master: Introduce new bgp_associations API definition  https://review.opendev.org/c/openstack/neutron-lib/+/79277414:03
amotokiit is different from past releases. it was one week before the feature freeze but it is two weeks before the freeze.14:03
amotokios-ken, ovsdbapp and neutron-lib are affected.14:04
slaweqyes14:04
slaweqI checked today opened patches14:04
slaweqfor os-ken and ovsdbapp we should be good now14:04
slaweqfor neutron-lib I saw some patches with review priority +1 so I assumed those are the ones we want to get in still14:04
slaweq     https://review.opendev.org/c/openstack/neutron-lib/+/80390514:04
slaweq    https://review.opendev.org/c/openstack/neutron-lib/+/79277414:04
slaweq    https://review.opendev.org/c/openstack/neutron-lib/+/77542014:05
slaweq    https://review.opendev.org/c/openstack/neutron-lib/+/77885914:05
slaweq    https://review.opendev.org/c/openstack/neutron-lib/+/80437814:05
slaweqany comments on those patches?14:05
slaweqmaybe some of them don't need to be released now14:05
slaweqif not, let's try to review and (hopefully) merge those patches ASAP this week14:07
amotoki804378 is in queue and 803905 has landed today.14:07
ralonsohand 775420 could be merge too14:08
ralonsohmerged*14:08
amotokithe others are related to BFD and bgp associations. do we expect them to be part of xena release?14:08
slaweqamotoki: that I wanted to ask also :)14:08
slaweqthx14:08
slaweqit's mostly for lajoskatona, manub and rubasov14:08
manubyes, it would be good if we could merge those14:08
lajoskatonayes, we discussed it last week's meeting14:09
slaweqok, so we can move on with review of them ASAP14:10
lajoskatonayes, would be good, and apreciated14:10
slaweqok, next announcement then14:11
slaweqTC & PTL Nominations starts today: https://governance.openstack.org/election/14:11
slaweqhttp://lists.openstack.org/pipermail/openstack-discuss/2021-August/024093.html14:11
slaweqif You are considering nominating Yourself for PTL and have any questions, I'll be happy to help You, please reach out to me on irc or email14:12
slaweqnext one14:13
slaweqstable/pike and stable/queens in networking-{bgpvpn,bagpipe} are EOL now14:13
slaweqbranches are deleted and we have eol- tags in both repos14:13
slaweqand speaking about stable branches14:14
slaweqWelcome Lajos in the neutron-stable-maint team!14:14
ralonsohwelcome14:14
slaweqlajoskatona was member of that group this week, so now You can bother him to +2 Your backports :)14:14
mlavalle+114:14
lajoskatonathanks, for the opprotunity and confidence14:15
slaweqnext one14:16
slaweqOctober PTG14:16
slaweqetherpad https://etherpad.opendev.org/p/neutron-yoga-ptg14:16
slaweqplease add Your topics there :)14:16
slaweqand the last one for today14:16
slaweqOperators pain points: http://lists.openstack.org/pipermail/openstack-discuss/2021-July/023659.html14:16
slaweqPlease collect Neutron pain points in the https://etherpad.opendev.org/p/pain-point-elimination14:17
slaweqI'm sure, You have some issues which may be pointed there :)14:17
slaweqand that's all announcements/reminders from me14:17
slaweqanything else You want to add here?14:18
slaweqif not, I think we can go to the next topic14:19
slaweq#topic Blueprints14:19
slaweqNeutron Xena-3 https://bugs.launchpad.net/neutron/+milestone/xena-314:19
slaweqany updates?14:19
slaweqI don't have any updates for today neighter14:21
slaweq@owners of the BPs, please check them and update with list of opened patches/progress/etc.14:22
slaweqthx in advance14:22
slaweqok, let's move on14:23
slaweqnext topic14:23
slaweq#topic Bugs14:23
slaweqmlavalle was bug deputy last week14:23
slaweqreport is here: http://lists.openstack.org/pipermail/openstack-discuss/2021-August/024187.html14:24
slaweqmlavalle: any bugs You want to bring up for discussion now?14:24
mlavalleThe two incomplte bugs in the report. They need follow up14:25
mlavallethat's all14:25
slaweqthx mlavalle14:26
slaweqthose bugs are https://bugs.launchpad.net/neutron/+bug/1939723 and https://bugs.launchpad.net/neutron/+bug/193972614:26
slaweqI would also raise https://bugs.launchpad.net/neutron/+bug/193992414:26
slaweqall of them seems to be ovn related14:26
slaweqand unassigned14:27
slaweqjlibosva: lucasagomes: can You help with triaging those bugs ^^ ?14:27
slaweqok, any other bugs anyone wants to discuss today14:29
slaweq?14:29
ralonsohno thanks14:29
slaweqok14:31
slaweqthis week I'm bug deputy14:31
slaweq(and I'm aware of it ;))14:31
slaweqnext week will be hongbin and he already confirmed me that he will do it14:31
slaweqand that's all what I had for today14:31
slaweq#topic On Demand Agenda14:32
slaweqdo You have anything else You want to discuss today?14:32
slaweqif not, I will give You few minutes back today14:33
slaweqthx for attending the meeting and see You online :)14:33
slaweq#endmeeting14:33
opendevmeetMeeting ended Tue Aug 17 14:33:34 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:33
opendevmeetMinutes:        https://meetings.opendev.org/meetings/networking/2021/networking.2021-08-17-14.00.html14:33
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/networking/2021/networking.2021-08-17-14.00.txt14:33
opendevmeetLog:            https://meetings.opendev.org/meetings/networking/2021/networking.2021-08-17-14.00.log.html14:33
slaweqo/14:33
ralonsohsee you in 25 mins14:33
lajoskatonaBye14:33
rubasovbye14:33
amotokio/14:33
jlibosvaslaweq: I looked at the first 2 this morning but seemed to me Miguel had good questions that we need more info14:35
slaweqjlibosva: ok, thx that You are keeping an eye on them14:36
opendevreviewLajos Katona proposed openstack/neutron-lib master: extension for adding bfd monitors to extraroutes  https://review.opendev.org/c/openstack/neutron-lib/+/77885914:37
opendevreviewTerry Wilson proposed openstack/neutron master: Support SB OVSDB connections to non-leader servers  https://review.opendev.org/c/openstack/neutron/+/80326814:38
slaweq#startmeeting neutron_ci15:00
opendevmeetMeeting started Tue Aug 17 15:00:07 2021 UTC and is due to finish in 60 minutes.  The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'neutron_ci'15:00
slaweqhi15:00
lajoskatonaHi15:00
ralonsohhi15:00
obondarevhi15:01
slaweqGrafana dashboard: http://grafana.openstack.org/dashboard/db/neutron-failure-rate15:01
slaweqand let's move on15:01
slaweq#topic Actions from previous meetings15:01
slaweqslaweq to report failure in test_ipv6_router_advts_and_fwd_after_router_state_change_backup functional test15:01
slaweq    Bug reported https://bugs.launchpad.net/neutron/+bug/193950715:01
slaweqI proposed some patch with extra logs for now15:02
slaweqas I don't know exactly why it was failing15:02
slaweqwith extra logs hopefully I will know better what happened there15:02
slaweqok, next one15:03
slaweqralonsoh to send email about memory in CI vms15:03
ralonsohI forgot that, I'll do it right now15:03
slaweqthx15:03
slaweqbut please wait a bit15:03
ralonsohsure15:03
slaweqI have this topic to discuss more today15:03
ralonsohok15:04
slaweqso let's wait until end of the meeting at least :)15:04
slaweqnext one15:04
slaweqralonsoh to check neutron-ovn-tempest-ovs-master-fedora job failures15:04
ralonsohthere are several devstack patches ongoing15:04
ralonsoh(let me find the bug)15:04
ralonsohhttps://bugs.launchpad.net/neutron/+bug/193942915:04
ralonsohpatches: https://review.opendev.org/q/topic:%22uncap-pip-url-resolver%22+(status:open%20OR%20status:merged)15:05
ralonsohactually, all of them are merged now15:05
ralonsohthe periodic job should work now15:05
slaweqit is fine indeed15:05
slaweqthx a lot15:05
slaweqYou can close LP bug :)15:05
slaweqnext one15:06
slaweqobondarev to promote dvr-ha job to be voting15:06
obondarevdone: https://review.opendev.org/c/openstack/neutron/+/80421115:06
slaweqobondarev: can You also update our grafana dashboard with that change?15:06
slaweqand great work with stabilizing that job finally15:06
obondarevsure, please remind which repo is it?15:06
slaweqthx a lot obondarev for all that work15:07
slaweqit's project-config15:07
slaweqlet me find link15:07
obondarevah, got it, thanks15:07
slaweqhttps://opendev.org/openstack/project-config/15:07
slaweq:)15:07
obondarevplease set an AI for me15:07
slaweq#action obondarev to update grafana after promoting dvr-ha job to be voting15:07
slaweqthx a lot15:07
obondarevthanks!15:08
slaweqthat's all AI from last week15:08
slaweqnext topic15:08
slaweq#topic Stadium projects15:08
slaweqlajoskatona: any updates?15:08
lajoskatonathings are fine, a lot ot patches merged :-)15:08
slaweqthat's good to hear :)15:09
slaweqso let's move on to the next topic15:10
slaweq#topic Stable branches15:10
slaweqthere is no bcafarel today15:10
slaweqbut I just wanted to ask You for review https://review.opendev.org/c/openstack/networking-bgpvpn/+/796476/ and https://review.opendev.org/c/openstack/networking-bagpipe/+/79647715:10
lajoskatonasure, I just seen them :-)15:11
slaweqthx15:11
slaweqlajoskatona: now You should have +2 power there15:12
lajoskatonayes, I used it today for some other patches :P15:12
slaweqgreat :)15:13
slaweqanything else regarding stable branches' ci?15:13
slaweqok, so let's move on15:14
slaweq#topic Grafana15:14
slaweqhttps://grafana.opendev.org/d/BmiopeEMz/neutron-failure-rate?orgId=115:14
slaweqI don't see anything new what would be urgent there15:14
slaweqwe still have same issues with functional and scenario jobs15:14
slaweq:/15:14
slaweqbut maybe You see something what You would like to raise regarding our dashboard15:15
slaweqif not, let's move on15:16
slaweqI will go strictly to the scenario jobs as I don't have anything new to discuss regarding functional/fullstack today15:16
slaweq#topic Tempest/Scenario15:16
slaweqSeems that we have serious problem with oom-killer in neutron_tempest_plugin.scenario.* jobs15:17
slaweqI opened bug today https://bugs.launchpad.net/neutron/+bug/194024315:17
slaweqI found at least 10 examples from last week :/15:17
slaweqso it's a lot15:17
ralonsohindeed15:17
slaweqafter initial look, I think that we have now more tests which are spawning Ubuntu vms15:18
slaweqand that's causing problem15:18
slaweqin one case for example I saw that mysql was using around 8.8% of memory15:18
lajoskatonaso it happens with all backends?15:18
slaweqbut then there were 4 different qemu processes which used around 8% each15:18
slaweqlajoskatona: yes, all backends15:18
slaweqmy proposal is to somehow extract tests which are using advanced image and run them with --concurrency 1 as second "stage" in the job15:19
slaweqsomething similar what we are doing in fullstack job for example15:19
ralonsohright15:19
slaweqthat way we shouldn't have so many Ubuntu vms spawned in same time15:20
slaweqbut maybe You have other ideas15:20
ralonsohat least big ones15:20
ralonsohask for bigger testing VMs... (that's easy)15:20
slaweqralonsoh: but I don't know if that is even possible to get bigger vms15:20
slaweqother possibility maybe could be to use different flavor for Ubuntu vms15:21
slaweqmaybe flavor with slightly smaller memory would be still ok for our needs15:21
ralonsohwe are suing cirros256 15:21
lajoskatonaI asked once for ODL, but I got it only temporarily15:21
ralonsohand for advance?15:21
slaweqralonsoh: but for advanced I think we are using d1 (or something like that) which is 512MB15:22
ralonsohthe point is that the VM memory is dynamic15:22
ralonsohqemu won't reserve all the flavor requested mem15:22
ralonsohso we are safe on this15:22
slaweqbut if Ubuntu vm have 512M, it may try to use it15:22
ralonsohwell, we can reduce it to 38415:23
ralonsohat least we can try15:23
slaweqthat should buy us some time at least :)15:23
ralonsohyes15:23
lajoskatonaand we can tag the advanced tests and run them with concurency 115:23
lajoskatonaas slaweq suggested15:24
ralonsohyes. I can push this patch (but I won't send the mail yet top request bigger VMs)15:24
slaweqralonsoh: yes, that's why I wanted You to hold on until end of the meeting :)15:25
ralonsohperfect then15:25
slaweqso ralonsoh, will You push patch to use smaller flavor in our jobs? and/or tag advanced tests to run them with concurency 1?15:25
ralonsohboth patches15:26
slaweqthx a lot15:26
slaweq#action ralonsoh to send patches to use smaller flavors and concurency 1 for advanced scenario tests15:26
slaweqI hope that this will help with that issue as this is killing us now15:26
slaweqanything else regarding scenario jobs?15:27
ralonsohnot from me15:27
slaweqif not, let's move one15:28
slaweqwe have one more topic for today15:28
slaweq#topic Periodic15:28
slaweqI opened today bug https://bugs.launchpad.net/neutron/+bug/194022415:28
slaweqit seems that since few days our UT running with neutron-lib from master branch are broken15:28
slaweqso we probably need quick fix for it or we will have broken neutron gate when we will do new release15:29
ralonsohI'll check this tomorrow15:29
opendevreviewBodo Petermann proposed openstack/neutron-vpnaas master: VPNaaS support for OVN  https://review.opendev.org/c/openstack/neutron-vpnaas/+/76535315:29
slaweqthx ralonsoh15:29
slaweqI didn't had time to look into it yet,  sorry15:29
slaweqralonsoh: if You will find that fix needs to be in neutron-lib, please let me know asap and/or please comment in https://review.opendev.org/c/openstack/releases/+/80466615:30
slaweqso we will not release broken neutron-lib15:30
ralonsohsure, I'll check it asap15:30
slaweqthx a lot15:30
slaweq#action ralonsoh to check UT failing with neutron-lib master15:30
slaweqand that's all from me for today :)15:31
slaweqanything else regarding our CI?15:31
slaweqor if not, we can finish earlier today15:31
ralonsohI'm fine15:31
lajoskatonanothing from me15:31
slaweqok, thx for attending the meeting15:32
slaweqsee You online and have a great evening :)15:32
slaweqo/15:32
slaweq#endmeeting15:32
opendevmeetMeeting ended Tue Aug 17 15:32:19 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:32
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-08-17-15.00.html15:32
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-08-17-15.00.txt15:32
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-08-17-15.00.log.html15:32
ralonsohbye15:32
lajoskatonaBye15:32
opendevreviewMerged openstack/neutron-lib master: BFD api def  https://review.opendev.org/c/openstack/neutron-lib/+/77542015:45
lajoskatonaralonsoh, slaweq: after running unit tests with latest n-lib and checking what was merged this patch seems suspicious: https://review.opendev.org/c/openstack/neutron-lib/+/80202915:59
ralonsohlajoskatona, exactly15:59
ralonsohit is changing the rules15:59
ralonsoh[<oslo_policy._checks.RuleCheck object at 0x7f61f53736d0>, <oslo_policy._checks.RuleCheck object at 0x7f61ee7e1640>]16:00
ralonsohrule:create_router:external_gateway_info16:00
ralonsoh^^ this is the rule with this patch16:00
ralonsohand before it:16:00
ralonsoh(rule:create_router:external_gateway_info and (rule:create_router:external_gateway_info:network_id and rule:create_router:external_gateway_info:external_fixed_ips))16:00
ralonsohit is removing all additional checks16:01
ralonsohI still don't know why16:01
ralonsohlajoskatona, I think "enforce_policy" is missing16:10
ralonsohhttps://github.com/openstack/neutron-lib/commit/75057767eb98c302524e566c79e251ab334af8a1#diff-932843b7f9d02b2514d2c8a8d982679c637535ba94d3ea189eb5a22739c6e8c0R3016:10
rubasovralonsoh: definitely did not intend to change those policy rules16:10
ralonsohyes but you didn't add this field in the API16:10
ralonsohlet me check this again adding this field16:11
lajoskatonaralonsoh, rubasov: these _policy verbs were always tricky to me.....16:11
ralonsohfor me too16:11
rubasovI remember reading about enforce_policy and not being sure but the n-lib tests passed16:12
rubasovhowever please note that the line linked above is for an attribute external_gateways which is not the same as the old external_gateway_info16:16
ralonsohrubasov, https://review.opendev.org/c/openstack/neutron-lib/+/802029/3/neutron_lib/api/definitions/l3_ext_gw_mode.py16:23
ralonsohthis change is modifying the policy16:23
ralonsohbecause now, in neutron.policy._build_match_rule16:24
ralonsohwe don't validate the sub_attributes16:24
rubasovhmm, I guess we can change that back to in-line16:26
rubasovwould that work?16:26
ralonsohI really don't know16:28
rubasovand that would mean in-lining the list version of the validator as well 16:28
ralonsohrubasov, ahhh yes16:30
ralonsohyou created validate_external_gw_info16:30
ralonsohok yes, I think that could work16:30
ralonsohrubasov, if I'm not wrong, validate_external_gw_info is the same as what we had before16:31
ralonsohright?16:31
rubasovyes, to refactor the validator in order to have a validator-for-one16:31
rubasovand a validator-for-a-list16:31
ralonsohperfect, I'll push a patch removing that16:31
*** rpittau is now known as rpittau|afk16:31
rubasovand I did not intend to change the for-one variant at all16:32
rubasovralonsoh: thanks16:32
ralonsohrubasov, what I don't know (because we don't have any test) is what will happen with https://review.opendev.org/c/openstack/neutron-lib/+/802029/3/neutron_lib/api/definitions/l3_multi_ext_gw.py#3516:32
ralonsohbecause we'll have the same problem 16:33
rubasovthat's what I mean that we need to in-line that validator too I guess16:34
rubasovhowever I'm not sure16:35
rubasovbecause that validator may not be needed at all16:35
ralonsohok, we must add policy checks for the actions16:35
ralonsoh    'add_external_gateways': 'PUT',16:35
ralonsoh    'update_external_gateways': 'PUT',16:35
ralonsoh    'remove_external_gateways': 'PUT',16:35
rubasovsince that's a read-only attribute16:35
ralonsohthis is what will guarantee the validation of those actions16:36
rubasovyes, that's where we write it16:36
ralonsohbut this is not in neutron yet, right?16:36
rubasovnot yet16:36
ralonsohok then16:36
rubasovbut that should not break existing tests16:36
ralonsohI'll change back only the gw info16:36
rubasovmakes sense16:36
opendevreviewRodolfo Alonso proposed openstack/neutron-lib master: Use explicit "dict_or_nodata" validation for "external_gateway_info"  https://review.opendev.org/c/openstack/neutron-lib/+/80489416:42
opendevreviewMerged openstack/networking-bagpipe stable/train: [EM releases] Move non-voting jobs to the experimental queue  https://review.opendev.org/c/openstack/networking-bagpipe/+/79647716:44
opendevreviewLajos Katona proposed openstack/neutron-lib master: extension for adding bfd monitors to extraroutes  https://review.opendev.org/c/openstack/neutron-lib/+/77885916:45
opendevreviewBodo Petermann proposed openstack/neutron-vpnaas master: VPNaaS support for OVN  https://review.opendev.org/c/openstack/neutron-vpnaas/+/76535316:49
opendevreviewMerged openstack/neutron-lib master: Move packet_rate_limit type to neutron-lib  https://review.opendev.org/c/openstack/neutron-lib/+/80437817:01
opendevreviewMerged openstack/networking-bgpvpn stable/train: [EM releases] Move non-voting jobs to the experimental queue  https://review.opendev.org/c/openstack/networking-bgpvpn/+/79647618:19
opendevreviewThiago Paiva Brito proposed openstack/neutron stable/ussuri: stable-only: Fix network segment allocation logic  https://review.opendev.org/c/openstack/neutron/+/80398618:22
opendevreviewSlawek Kaplonski proposed openstack/neutron master: DNM It's just test of the neutron-lib patch  https://review.opendev.org/c/openstack/neutron/+/80491921:06
opendevreviewAde Lee proposed openstack/neutron master: WIP/DNM - Add FIPS enabled jobs  https://review.opendev.org/c/openstack/neutron/+/79753721:26
« Monday, 2021-08-16 Index Wednesday, 2021-08-18 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!