Wednesday, 2018-08-08

*** namnh has joined #openstack-neutron00:00
*** namnh has quit IRC00:01
openstackgerritMerged openstack/os-vif master: Update reno for stable/rocky  https://review.openstack.org/58610600:24
*** gildub has joined #openstack-neutron00:34
*** longkb has joined #openstack-neutron00:42
*** Nel1x has joined #openstack-neutron00:45
*** hongbin has joined #openstack-neutron00:53
*** markstur_ has quit IRC01:03
*** mriedem has quit IRC01:06
*** hongbin has quit IRC01:13
*** hongbin has joined #openstack-neutron01:13
*** yushiro has joined #openstack-neutron01:19
openstackgerritMerged openstack/networking-ovn master: migration: reduce possible downtime to the minimum  https://review.openstack.org/58654501:29
*** reedip has joined #openstack-neutron01:33
*** bbbbzhao_ has joined #openstack-neutron01:38
*** huntxu has joined #openstack-neutron01:42
*** Dinesh_Bhor has joined #openstack-neutron01:50
*** mpjetta has quit IRC02:07
*** mpjetta has joined #openstack-neutron02:14
*** gkadam_ has joined #openstack-neutron02:24
openstackgerritMerged openstack/neutron-fwaas master: Add notification callback events for FWaaS v2  https://review.openstack.org/57871802:25
*** gkadam__ has joined #openstack-neutron02:26
*** gkadam_ has quit IRC02:29
*** ramishra has joined #openstack-neutron02:36
openstackgerritMerged openstack/neutron-fwaas master: Add neutron as required-projects  https://review.openstack.org/58942102:47
*** Dinesh_Bhor has quit IRC02:54
*** dave-mccowan has quit IRC02:57
*** dklyle has quit IRC02:58
*** Nel1x has quit IRC02:58
*** zhurong has joined #openstack-neutron03:01
*** Dinesh_Bhor has joined #openstack-neutron03:04
*** yushiro has quit IRC03:48
*** hongbin has quit IRC03:51
*** links has joined #openstack-neutron03:56
*** gildub has quit IRC04:01
*** ratailor has joined #openstack-neutron04:06
openstackgerritNguyen Phuong An proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373804:19
*** zhurong has quit IRC04:20
*** jenglisch has quit IRC04:27
*** yamamoto has joined #openstack-neutron04:29
*** Leo_m_ has quit IRC04:32
*** janki has joined #openstack-neutron04:34
*** gildub has joined #openstack-neutron04:41
*** yamamoto has quit IRC04:46
*** yamamoto has joined #openstack-neutron04:50
*** ksambor has joined #openstack-neutron04:57
*** kobis1 has joined #openstack-neutron05:06
openstackgerritNuman Siddique proposed openstack/networking-ovn master: Support octavia provider driver for OVN  https://review.openstack.org/57739505:14
*** kobis1 has quit IRC05:20
*** hoonetorg has quit IRC05:31
*** mosulica has joined #openstack-neutron05:40
*** gkadam__ has quit IRC05:42
openstackgerritNuman Siddique proposed openstack/networking-ovn master: WIP : DO NOT MERGE: Add ovn octavia CI jobs  https://review.openstack.org/58971205:44
*** gkadam has joined #openstack-neutron05:44
openstackgerritCao Xuan Hoang proposed openstack/neutron-fwaas master: Add log validator for FWaaS v2 logging  https://review.openstack.org/53279205:45
*** yamamoto has quit IRC05:49
*** hoonetorg has joined #openstack-neutron05:52
bzhao__@our core reviewers, could you please look at https://review.openstack.org/#/c/588997/? Just need a +A . ;-)05:57
openstackgerritReedip proposed openstack/neutron-fwaas master: Add new protocols in Firewalls  https://review.openstack.org/44033105:58
*** zhurong has joined #openstack-neutron05:58
openstackgerritNuman Siddique proposed openstack/networking-ovn master: Support octavia provider driver for OVN  https://review.openstack.org/57739505:59
openstackgerritNuman Siddique proposed openstack/networking-ovn master: WIP : DO NOT MERGE: Add ovn octavia CI jobs  https://review.openstack.org/58971206:01
*** nicolasbock has joined #openstack-neutron06:03
openstackgerritNguyen Phuong An proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069406:04
*** hoonetorg has quit IRC06:06
*** gkadam has quit IRC06:09
*** kobis1 has joined #openstack-neutron06:18
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: Add new protocols in Firewalls  https://review.openstack.org/44033106:20
*** gkadam has joined #openstack-neutron06:24
*** pcaruana has joined #openstack-neutron06:27
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Add log validator for FWaaS v2 logging  https://review.openstack.org/53279206:32
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log]: Add rpc stuff for logging  https://review.openstack.org/53071506:32
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Adding resources callback handler for FWaaS v2 logging  https://review.openstack.org/58097606:32
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069406:32
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373806:32
*** mdih has quit IRC06:34
*** mdih has joined #openstack-neutron06:51
*** s10 has joined #openstack-neutron06:58
*** luksky has joined #openstack-neutron06:59
*** Dinesh_Bhor has quit IRC07:03
*** mattgo has joined #openstack-neutron07:04
*** s10 has quit IRC07:08
*** mdih has quit IRC07:13
openstackgerritCao Xuan Hoang proposed openstack/neutron-fwaas master: Ignore sphinx-docs job for logapi path  https://review.openstack.org/58973507:15
openstackgerritNuman Siddique proposed openstack/networking-ovn master: WIP : DO NOT MERGE: Add ovn octavia CI jobs  https://review.openstack.org/58971207:17
*** cshen has joined #openstack-neutron07:17
openstackgerritCao Xuan Hoang proposed openstack/neutron-fwaas master: Add log validator for FWaaS v2 logging  https://review.openstack.org/53279207:18
*** tmorin has joined #openstack-neutron07:22
*** tmorin has quit IRC07:25
*** tmorin has joined #openstack-neutron07:27
*** maciejjozefczyk has joined #openstack-neutron07:28
*** rcernin has quit IRC07:35
openstackgerritCao Xuan Hoang proposed openstack/neutron-fwaas master: Adding 'logapi' in apidoc_excluded_paths for sphinx-docs job  https://review.openstack.org/58973507:35
*** velizarx has joined #openstack-neutron07:38
*** jawadahmed has joined #openstack-neutron07:42
*** jpena|off is now known as jpena07:46
*** pmannidi has quit IRC07:46
*** gildub has quit IRC07:47
*** abaindur has quit IRC07:47
openstackgerritNguyen Phuong An proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069407:48
*** chason has quit IRC07:49
*** velizarx has quit IRC07:56
jawadahmedHi all, OVS/ODL or SRIOV for HPC Openstack? Any recommendations?07:58
*** jawadahmed is now known as Jay_07:59
*** velizarx has joined #openstack-neutron08:01
*** moshele has joined #openstack-neutron08:02
openstackgerritBence Romsics proposed openstack/neutron-lib master: Placement client: always return body  https://review.openstack.org/58974908:04
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373808:08
*** jlibosva has joined #openstack-neutron08:13
*** Conqueror has joined #openstack-neutron08:15
*** ktibi has joined #openstack-neutron08:24
*** nmagnezi_ has joined #openstack-neutron08:24
*** zhurong has quit IRC08:26
*** tssurya has joined #openstack-neutron08:28
*** nmagnezi_ has quit IRC08:37
openstackgerritKobi Samoray proposed openstack/neutron master: Open Stein DB branch  https://review.openstack.org/58976108:51
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log]: Add rpc stuff for logging  https://review.openstack.org/53071509:03
*** salmankhan has joined #openstack-neutron09:17
*** mosulica has quit IRC09:22
*** ktibi has quit IRC09:23
*** ktibi has joined #openstack-neutron09:27
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Adding resources callback handler for FWaaS v2 logging  https://review.openstack.org/58097609:29
*** ktibi has quit IRC09:30
*** ktibi has joined #openstack-neutron09:31
openstackgerritOpenStack Release Bot proposed openstack/python-neutronclient master: Update reno for stable/rocky  https://review.openstack.org/58979409:35
*** mosulica has joined #openstack-neutron09:35
*** mosulica has quit IRC09:41
*** luksky has quit IRC09:44
*** edmondsw has joined #openstack-neutron09:45
*** diliprenkila_ has joined #openstack-neutron09:48
diliprenkila_Hi all, Did anybody encounterd this issue when listing ip namespaces09:48
*** kobis1 has quit IRC09:48
*** edmondsw has quit IRC09:49
diliprenkila_Hi all, Did anybody encounterd this issue when listing ip namespaces https://etherpad.openstack.org/p/K8J4O0wlPG09:49
*** ratailor_ has joined #openstack-neutron09:56
*** ratailor_ has quit IRC09:56
*** ratailor has quit IRC09:58
*** davidsha has joined #openstack-neutron09:59
*** ratailor has joined #openstack-neutron10:01
*** cshen has quit IRC10:02
*** ratailor has quit IRC10:03
*** ratailor has joined #openstack-neutron10:03
*** ratailor has quit IRC10:04
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log]: Add rpc stuff for logging  https://review.openstack.org/53071510:07
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Adding resources callback handler for FWaaS v2 logging  https://review.openstack.org/58097610:07
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069410:07
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373810:07
openstackgerritMiguel Angel Ajo proposed openstack/networking-ovn master: DevStack: Correctly stop ovn-northd and ovn-controller  https://review.openstack.org/57711710:11
openstackgerritMiguel Angel Ajo proposed openstack/networking-ovn master: Grenade: Upgrade OVS/OVN as part of the job run  https://review.openstack.org/57712310:11
*** nplanel_ has quit IRC10:16
*** tonyb has quit IRC10:16
*** luksky has joined #openstack-neutron10:16
*** nplanel_ has joined #openstack-neutron10:20
*** mosulica has joined #openstack-neutron10:20
*** ratailor has joined #openstack-neutron10:20
*** tonyb has joined #openstack-neutron10:23
*** madorn has quit IRC10:25
openstackgerritMerged openstack/python-neutronclient master: Update reno for stable/rocky  https://review.openstack.org/58979410:27
*** madorn has joined #openstack-neutron10:27
*** kobis1 has joined #openstack-neutron10:28
*** dave-mccowan has joined #openstack-neutron10:59
*** rmart04 has joined #openstack-neutron11:02
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: Add log validator for FWaaS v2 logging  https://review.openstack.org/53279211:05
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: [log]: Add rpc stuff for logging  https://review.openstack.org/53071511:06
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: Adding resources callback handler for FWaaS v2 logging  https://review.openstack.org/58097611:06
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069411:06
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373811:06
*** ratailor has quit IRC11:09
*** huntxu has quit IRC11:12
*** cshen has joined #openstack-neutron11:15
*** tbachman has joined #openstack-neutron11:23
openstackgerritvenkata anil proposed openstack/neutron master: Use sqlalchemy baked query  https://review.openstack.org/43097311:24
*** jpena is now known as jpena|lunch11:35
*** tpsilva has joined #openstack-neutron11:42
*** chason has joined #openstack-neutron11:52
openstackgerritVan Hung Pham proposed openstack/neutron master: Use Router OVO in l3_db.py  https://review.openstack.org/54916812:05
*** diliprenkila_ has quit IRC12:05
*** tssurya has quit IRC12:13
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log]: Add rpc stuff for logging  https://review.openstack.org/53071512:19
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Adding resources callback handler for FWaaS v2 logging  https://review.openstack.org/58097612:19
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069412:19
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373812:19
*** longkb has quit IRC12:20
*** pfo has joined #openstack-neutron12:20
pfoanyone in here using hw-accelerated OVS offload with pike (RHOSP 12)?12:21
*** nplanel__ has joined #openstack-neutron12:22
*** nplanel_ has quit IRC12:23
*** amuller has joined #openstack-neutron12:24
*** panda|rover is now known as panda|ruck12:25
*** jpena|lunch is now known as jpena12:35
*** tssurya has joined #openstack-neutron12:36
*** lajoskatona has quit IRC12:42
openstackgerritLajos Katona proposed openstack/neutron-lib master: Introduce Port resource request extension  https://review.openstack.org/58490312:48
*** tbachman has quit IRC12:50
*** velizarx has quit IRC12:52
*** velizarx has joined #openstack-neutron12:56
*** lajoskatona has joined #openstack-neutron12:57
*** pfo has quit IRC12:58
*** mosulica has quit IRC12:58
*** mriedem has joined #openstack-neutron12:59
*** mosulica has joined #openstack-neutron13:01
*** nplanel__ is now known as nplanel_13:03
*** edmondsw has joined #openstack-neutron13:05
openstackgerritSlawek Kaplonski proposed openstack/neutron master: Remove fdb entries for ha router interfaces when going DOWN  https://review.openstack.org/58988513:07
*** mosulica has quit IRC13:10
*** maciejjozefczyk has quit IRC13:11
*** mosulica has joined #openstack-neutron13:15
openstackgerritTerry Wilson proposed openstack/networking-ovn master: Make get_agents wait for sb_cfg to increment  https://review.openstack.org/58502713:15
openstackgerritTerry Wilson proposed openstack/networking-ovn master: Make get_agents wait for sb_cfg to increment  https://review.openstack.org/58502713:16
*** tbachman has joined #openstack-neutron13:19
*** tbachman has quit IRC13:23
*** mosulica has quit IRC13:25
*** maciejjozefczyk has joined #openstack-neutron13:26
*** mosulica has joined #openstack-neutron13:28
*** maciejjozefczyk has quit IRC13:28
openstackgerritDavid Hill proposed openstack/neutron master: Use system protocol assigments for iptables protocol map  https://review.openstack.org/58548913:28
*** maciejjozefczyk has joined #openstack-neutron13:30
lajoskatonahaleyb: for Install and configure controller node in Neutron (https://bugs.launchpad.net/neutron/+bug/1785025), what is the policy, shall I propose the doc fix, or shall we wait till the proposer uploads it? It is an easy quick thing, so I thought let's do it13:31
openstackLaunchpad bug 1785025 in neutron "Install and configure controller node in Neutron" [Low,Confirmed]13:31
*** tbachman has joined #openstack-neutron13:31
openstackgerritLakshmi Prasanna Goutham Pratapa proposed openstack/python-neutronclient master: Port TaaS APIs to OpenStack CLI  https://review.openstack.org/58925313:32
haleyblajoskatona: i would think the way nova does it (and others as you said), assuming that's what you tested?13:34
*** mosulica has quit IRC13:36
lajoskatonahaleyb: it was not me who wrote the bug,13:37
haleyblajoskatona: you can just propose with that change then13:38
lajoskatonahaleyb: ok, thanks I upload then the doc fix, as the controller install doc is for nova13:39
*** mosulica has joined #openstack-neutron13:40
*** Jay_ has quit IRC13:47
openstackgerritLucas Alvares Gomes proposed openstack/networking-ovn master: Consolidate add/remove router interface OVS transactions  https://review.openstack.org/55385313:48
*** _ix has joined #openstack-neutron13:49
openstackgerritDavid Hill proposed openstack/neutron master: Use system protocol assigments for iptables protocol map  https://review.openstack.org/58548913:57
openstackgerritLajos Katona proposed openstack/neutron master: Remove -u root as mysql is executed with root user  https://review.openstack.org/58990714:05
*** maciejjozefczyk has quit IRC14:07
openstackgerritAkihiro Motoki proposed openstack/neutron master: Add FIP port forwarding to Networking Guide  https://review.openstack.org/58899714:07
*** annp_ has joined #openstack-neutron14:07
openstackgerritAkihiro Motoki proposed openstack/neutron master: Add FIP port forwarding to Networking Guide  https://review.openstack.org/58899714:08
*** _ix has quit IRC14:13
annp_mlavalle: ping14:13
annp_mlavalle: Could you please have a look at https://review.openstack.org/#/c/587681/?14:14
annp_mlavalle, thanks in advance.14:14
*** nplanel__ has joined #openstack-neutron14:14
openstackgerritHamdy Khader proposed openstack/neutron master: Add SmartNIC representor port to integeration bridge  https://review.openstack.org/58625214:17
*** hongbin has joined #openstack-neutron14:18
*** HW-Peter has joined #openstack-neutron14:21
*** _ix has joined #openstack-neutron14:22
*** maciejjozefczyk has joined #openstack-neutron14:22
*** diliprenkil has joined #openstack-neutron14:23
diliprenkilHi all14:23
diliprenkilneutron-dhcp-agent is unable to set network namespaces14:24
openstackgerritMerged openstack/neutron-fwaas master: Adding 'logapi' in apidoc_excluded_paths for sphinx-docs job  https://review.openstack.org/58973514:24
*** tmorin has quit IRC14:27
*** moshele has quit IRC14:29
*** tmorin has joined #openstack-neutron14:31
*** diliprenkil has quit IRC14:33
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: Add python binding for libnetfilter_log  https://review.openstack.org/53069414:33
*** reedip is now known as reedip|afk14:35
*** gkadam has quit IRC14:43
*** markstur has joined #openstack-neutron14:51
*** markstur has quit IRC14:51
*** markstur has joined #openstack-neutron14:52
openstackgerritBrian Haley proposed openstack/neutron master: Correctly call is_distributed_router()  https://review.openstack.org/58957314:53
*** kobis1 has quit IRC14:56
*** mosulica has quit IRC15:01
openstackgerritBrian Haley proposed openstack/neutron master: Fix import style  https://review.openstack.org/58993315:01
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373815:03
*** tbachman has quit IRC15:05
*** chason has quit IRC15:06
*** chason has joined #openstack-neutron15:07
*** chason has quit IRC15:07
*** chason has joined #openstack-neutron15:08
openstackgerritDongcan Ye proposed openstack/neutron-vpnaas master: Match IPSEC SA established state  https://review.openstack.org/58211315:08
*** ksambor has quit IRC15:08
*** jlibosva has quit IRC15:10
*** links has quit IRC15:10
*** mlavalle has joined #openstack-neutron15:18
mlavallehaleyb: would you take a look at https://review.openstack.org/#/c/588844/? I don't intend to make any more changes to it. I want to keep it simple15:18
*** velizarx has quit IRC15:20
*** gkadam has joined #openstack-neutron15:24
*** luksky has quit IRC15:24
*** cshen has quit IRC15:29
haleybmlavalle: i agree, does anyone even read the manuals anyways :)15:30
mlavallehaleyb: LOL15:30
*** Leo_m has joined #openstack-neutron15:34
*** pcaruana has quit IRC15:34
*** tbachman has joined #openstack-neutron15:34
*** mattgo has quit IRC15:37
*** jlvillal is now known as jlv-sick15:40
*** Leo_m_ has joined #openstack-neutron15:41
*** rmart04 has quit IRC15:42
*** Leo_m has quit IRC15:42
*** aojea has joined #openstack-neutron15:51
*** dklyle has joined #openstack-neutron15:55
*** tssurya has quit IRC15:57
*** david-lyle has joined #openstack-neutron15:59
*** mattgo has joined #openstack-neutron16:00
*** dklyle has quit IRC16:01
*** david-lyle is now known as dklyle16:02
*** sambetts|afk is now known as sambetts16:03
*** mattgo has quit IRC16:08
*** tmorin has quit IRC16:13
*** pfo has joined #openstack-neutron16:16
mlavallehave to reboot system. BRB16:25
*** mlavalle has quit IRC16:25
*** ktibi has quit IRC16:27
*** mlavalle has joined #openstack-neutron16:28
*** moshele has joined #openstack-neutron16:30
*** davidsha has quit IRC16:35
*** pfo has quit IRC16:36
*** lajoskatona has quit IRC16:37
*** imacdonn has quit IRC16:38
*** imacdonn has joined #openstack-neutron16:39
*** dklyle has quit IRC16:43
*** marlinc has quit IRC16:45
*** moshele has quit IRC16:45
*** marlinc has joined #openstack-neutron16:59
*** lajoskatona has joined #openstack-neutron17:00
*** gkadam has quit IRC17:01
*** dklyle has joined #openstack-neutron17:21
*** ramishra has quit IRC17:27
*** sambetts is now known as sambetts|afk17:29
*** annp_ has quit IRC17:39
*** moshele has joined #openstack-neutron17:40
*** moshele has quit IRC17:44
*** gkadam has joined #openstack-neutron17:46
*** jlibosva has joined #openstack-neutron17:57
*** dklyle has quit IRC17:57
*** jpena is now known as jpena|off18:07
*** dklyle has joined #openstack-neutron18:09
*** salmankhan has quit IRC18:13
*** moshele has joined #openstack-neutron18:20
*** moshele has quit IRC18:21
*** abaindur has joined #openstack-neutron18:25
*** itlinux has joined #openstack-neutron18:25
*** ircuser-1 has quit IRC18:30
*** dklyle has quit IRC18:31
*** dklyle has joined #openstack-neutron18:34
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas master: Add releasenote for FWaaS v2 logging  https://review.openstack.org/58999118:34
abaindurhaleyb: you there? wanted to discuss the unit tests you requested for https://review.openstack.org/#/c/587234/18:35
*** amuller has quit IRC18:36
haleybabaindur: yes, i'm here18:37
*** janki has quit IRC18:37
haleybcould you find any existing tests that exercise this code?  or are very close?18:38
abaindurSo I already see unit tests for binding the snat ports, where it even verifies the expected dvr_to_srvc_mac flow is called: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py#L302818:39
abaindurI also see individual unit tests to exercise the get_subnet_for_dvr, where it is invoked with and without a subnet18:39
abaindurhere: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_dvr_mac_db.py#L14518:40
openstackgerritKim Bao Long proposed openstack/neutron-fwaas master: [log] FWaaS L3 Logging driver based iptables  https://review.openstack.org/55373818:40
*** PagliaccisCloud has left #openstack-neutron18:42
haleybabaindur: well, if you can create a new unit test that can call with two fixed_ips where the first has the wrong subnet - i.e. fails on old code, then we can verify the new code won't regress18:43
abaindur"two fixed_ips where the first has the wrong subnet" - I don't know what you mean18:45
abaindurthe subnet would be the same18:45
abaindurIt was just the behavior of the get_subnet_for_dvr which filled in the subnet's GW mac with the port passed in18:46
abaindurI guess you want me to add a test where we add an expected mock call for get_subnet_for_dvr with the correct format (no fixed_ips arg)18:47
abaindursince in the currentl example _port_bound_for_dvr_with_csnat_ports, the call is patch'd out, and the MAC is hardcoded18:48
abaindur?18:48
abaindurin current test, the only expected call we check for is  mock.call.install_dvr_to_src_mac is called. The mac here is hardcoded18:49
*** sapd has quit IRC18:49
haleybabaindur: yeah, maybe i'm thinking how to test this wrong... if both fixed_ips are in the same subnet, but the first isn't the gateway IP, then passing it causes a problem, right?18:52
abaindur*only* if that port happens to come up first in binding order, before the port we want as the actual gateway (the distributed router port)18:53
abaindurbecause that causes the subnet_info to be cached by the agent18:53
abaindurotherwise subnetinfo is in local dvr map18:54
abaindurWhat i observed was that this ordering is random. We noticed flows added with correct MAC on a hypervisor with dvr_snat agent mode. We restarted ovs-agent, and those src VM mac flows came up w/ the different MAC (of csnat port)18:55
haleybrandom isn't good for functional testing, which is why a unit test would be better where we can mock things to our needs18:56
abainduryea so i think we just need to mock the call to get_subnet_for_dvr, and ensure it isn't invoked with a fixed_ip argument18:57
abaindurthe get_subnet_for_dvr is unit tested separatly to ensure correct behavior elsewhere18:57
*** dklyle has quit IRC18:59
abaindurthe get_subnet_for_dvr RPC call is patch'd out, and we hardcode the return value: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py#L308819:01
*** nplanel__ has quit IRC19:03
*** nplanel_ has quit IRC19:03
*** nplanel_ has joined #openstack-neutron19:03
*** nplanel__ has joined #openstack-neutron19:04
*** tbachman has quit IRC19:17
*** gkadam has quit IRC19:18
*** mdih has joined #openstack-neutron19:26
mdihhello, gooday everyone. just would like to ask if is it possible to use external dhcp rather than relying on neutron dhcp? does this mean also that theres no need to specify the subnet address range?19:27
openstackgerritTerry Wilson proposed openstack/networking-ovn master: Make get_agents wait for sb_cfg to increment  https://review.openstack.org/58502719:30
*** jlibosva has quit IRC19:31
openstackgerritDavid Hill proposed openstack/neutron master: Use system protocol assigments for iptables protocol map  https://review.openstack.org/58548919:33
*** tbachman has joined #openstack-neutron19:34
*** tbachman has quit IRC19:39
johnsommlavalle FYI, UDP made it into Rocky19:45
*** rmart04 has joined #openstack-neutron19:45
mlavallejohnsom: yeah, thanks!19:45
*** rmart04 has quit IRC19:45
*** tbachman has joined #openstack-neutron19:46
mlavallejohnsom: are you merginf the api ref as well?19:47
johnsommlavalle Yes, I wrote the API ref update for him. It merged last night as well.19:48
mlavallejohnsom: I did the same for him in port forwarding19:49
johnsommlavalle Hmmm, it doesn't look like it has posted though. I will check on that19:49
mlavallejohnsom: yeah, I can see an api-ref pack still there: 58889319:49
johnsommlavalle There are two, there is our internal API for the amphora, which he wrote.  There is also the main Octavia API ref which I wrote19:50
johnsommlavalle it was part of https://review.openstack.org/#/c/587690/19:50
mlavalleand 589180 and 589748 are still there, johnsom19:51
johnsomYes, but those are less critical to get into Rocky.19:52
johnsomMore edge cases than core functionality19:52
mlavallejohnsom: ah ok, so with what was merged, we can claim udp is implemented, right?19:52
johnsommlavalle Correct19:52
johnsomIt works pretty good too!19:52
mlavallejohnsom: \o/19:52
openstackgerritMerged openstack/neutron master: Add FIP port forwarding to Networking Guide  https://review.openstack.org/58899720:01
*** dklyle has joined #openstack-neutron20:05
*** ircuser-1 has joined #openstack-neutron20:05
*** anupn has quit IRC20:06
abaindurhaleyb: did you see my msg above20:07
abainduri think we just need to mock the call to get_subnet_for_dvr, and ensure it isn't invoked with a fixed_ip argument. the get_subnet_for_dvr is unit tested separatly to ensure correct behavior elsewhere20:07
haleybabaindur: no, i've been out20:07
abaindurnp20:07
haleybok20:07
abaindurI think we need to assert its called w/ the correct args, in addition to jsut patching an object for its return value here: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py#L308820:08
*** itlinux has quit IRC20:12
*** luksky has joined #openstack-neutron20:13
*** SumitNaiksatam has joined #openstack-neutron20:25
*** gildub has joined #openstack-neutron20:39
openstackgerritBrian Haley proposed openstack/neutron master: Use system protocol assigments for iptables protocol map  https://review.openstack.org/58548920:47
*** gildub has quit IRC20:50
*** dklyle has quit IRC20:58
*** tbachman has quit IRC21:00
openstackgerritBrian Haley proposed openstack/neutron master: Use system protocol assigments for iptables protocol map  https://review.openstack.org/58548921:01
*** dklyle has joined #openstack-neutron21:02
*** dklyle has quit IRC21:07
*** pcaruana has joined #openstack-neutron21:07
*** salmankhan has joined #openstack-neutron21:08
*** salmankhan has quit IRC21:13
openstackgerritMerged openstack/neutron master: Add note to RBAC chapter of Networking Guide  https://review.openstack.org/58884421:19
*** armax has quit IRC21:23
*** mriedem has quit IRC21:30
*** mriedem has joined #openstack-neutron21:31
openstackgerritMerged openstack/neutron-tempest-plugin master: Wait until all router ports are DOWN before migration  https://review.openstack.org/58941021:38
*** SumitNaiksatam has left #openstack-neutron21:52
*** aojea has quit IRC21:55
*** imacdonn has quit IRC21:59
*** pcaruana has quit IRC22:02
*** nicolasbock has quit IRC22:06
*** moshele has joined #openstack-neutron22:06
*** mdih has quit IRC22:08
*** aojea has joined #openstack-neutron22:08
*** mlavalle has quit IRC22:09
*** aojea has quit IRC22:09
*** edmondsw has quit IRC22:10
*** aojea has joined #openstack-neutron22:11
*** imacdonn has joined #openstack-neutron22:12
*** rcernin has joined #openstack-neutron22:19
*** moshele has quit IRC22:25
*** aojea has quit IRC22:30
*** markstur has quit IRC22:33
*** hamzy_ has joined #openstack-neutron22:40
*** hamzy has quit IRC22:42
*** tbachman has joined #openstack-neutron22:48
*** rkukura_ has joined #openstack-neutron22:53
*** hongbin has quit IRC22:54
*** zioproto_ has joined #openstack-neutron22:55
*** gmann_ has joined #openstack-neutron22:55
*** r-daneel has joined #openstack-neutron22:59
*** amotoki_ has joined #openstack-neutron23:01
*** Leo_m_ has quit IRC23:01
*** evrardjp has quit IRC23:02
*** SamYaple has quit IRC23:02
*** Tahvok has quit IRC23:02
*** kevinbenton has quit IRC23:02
*** kailun has quit IRC23:02
*** rkukura has quit IRC23:02
*** adreznec has quit IRC23:02
*** weezhard has quit IRC23:02
*** yamahata__ has quit IRC23:02
*** sean-k-mooney has quit IRC23:02
*** openstackrecheck has quit IRC23:02
*** mtreinish has quit IRC23:02
*** irenab has quit IRC23:02
*** penick has quit IRC23:02
*** oanson has quit IRC23:02
*** dulek has quit IRC23:02
*** lucasagomes has quit IRC23:02
*** russellb has quit IRC23:02
*** amotoki has quit IRC23:02
*** dosaboy has quit IRC23:02
*** gmann has quit IRC23:02
*** zioproto has quit IRC23:02
*** rickflare has quit IRC23:02
*** rkukura_ is now known as rkukura23:02
*** gmann_ is now known as gmann23:02
*** zioproto_ is now known as zioproto23:02
*** Tahvok has joined #openstack-neutron23:03
*** kevinbenton has joined #openstack-neutron23:03
*** mtreinish has joined #openstack-neutron23:04
*** safchain has quit IRC23:05
*** safchain has joined #openstack-neutron23:08
*** abaindur has quit IRC23:09
*** tpsilva has quit IRC23:18
*** luksky has quit IRC23:26
*** nplanel_ has quit IRC23:30
openstackgerritMerged openstack/networking-ovn master: DevStack: Correctly stop ovn-northd and ovn-controller  https://review.openstack.org/57711723:32
*** gildub has joined #openstack-neutron23:35
*** slaweq has quit IRC23:37
*** slaweq has joined #openstack-neutron23:37
*** moshele has joined #openstack-neutron23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!