*** salv-orlando has quit IRC | 00:04 | |
*** yamamoto has quit IRC | 00:05 | |
*** yamahata has quit IRC | 00:06 | |
*** daneyon has joined #openstack-neutron | 00:08 | |
*** amotoki has joined #openstack-neutron | 00:14 | |
*** itsAmeMario0o has quit IRC | 00:18 | |
*** yamahata has joined #openstack-neutron | 00:18 | |
*** shaohe_feng has quit IRC | 00:19 | |
*** dboik has quit IRC | 00:22 | |
*** itsAmeMario0o has joined #openstack-neutron | 00:28 | |
*** aranjan has quit IRC | 00:31 | |
*** itsAmeMario0o has quit IRC | 00:40 | |
*** dttocs has joined #openstack-neutron | 00:52 | |
*** zhenguo has joined #openstack-neutron | 00:54 | |
*** dttocs has quit IRC | 00:57 | |
*** signed8bit has joined #openstack-neutron | 00:58 | |
*** dboik has joined #openstack-neutron | 01:04 | |
*** salv-orlando has joined #openstack-neutron | 01:05 | |
*** yalie has joined #openstack-neutron | 01:08 | |
*** signed8bit has quit IRC | 01:09 | |
*** salv-orlando has quit IRC | 01:11 | |
*** luqas has joined #openstack-neutron | 01:17 | |
*** alex_xu has quit IRC | 01:18 | |
*** luqas has quit IRC | 01:21 | |
*** alex_xu has joined #openstack-neutron | 01:23 | |
*** shaohe_feng has joined #openstack-neutron | 01:25 | |
*** shaohe_feng1 has joined #openstack-neutron | 01:28 | |
*** yamamoto has joined #openstack-neutron | 01:29 | |
*** popw has joined #openstack-neutron | 01:29 | |
*** shaohe_feng has quit IRC | 01:29 | |
*** shaohe_feng1 has left #openstack-neutron | 01:31 | |
*** yalie1 has joined #openstack-neutron | 01:31 | |
*** salv-orlando has joined #openstack-neutron | 01:32 | |
*** yalie has quit IRC | 01:34 | |
*** salv-orlando has quit IRC | 01:35 | |
*** banix has joined #openstack-neutron | 01:38 | |
*** itsAmeMario0o has joined #openstack-neutron | 01:38 | |
*** stanzgy has joined #openstack-neutron | 01:39 | |
*** erkules has joined #openstack-neutron | 01:40 | |
*** dboik has quit IRC | 01:40 | |
*** ivar-lazzaro has joined #openstack-neutron | 01:40 | |
*** salv-orlando has joined #openstack-neutron | 01:41 | |
*** erkules_ has quit IRC | 01:43 | |
*** julim has quit IRC | 01:47 | |
*** julim has joined #openstack-neutron | 01:48 | |
*** julim has quit IRC | 01:48 | |
*** ivar-lazzaro has quit IRC | 01:50 | |
*** salv-orlando has quit IRC | 01:51 | |
*** achanda has joined #openstack-neutron | 01:53 | |
*** dttocs has joined #openstack-neutron | 01:53 | |
*** banix has quit IRC | 01:53 | |
*** baoli has quit IRC | 01:54 | |
*** dttocs has quit IRC | 01:57 | |
*** jbell8 has joined #openstack-neutron | 01:58 | |
*** jbell8_ has joined #openstack-neutron | 02:06 | |
*** jbell8 has quit IRC | 02:09 | |
*** jbell8_ has quit IRC | 02:10 | |
*** britthou_ has quit IRC | 02:13 | |
openstackgerrit | gongysh proposed openstack/neutron: Simplify keepalived.virtual_routes https://review.openstack.org/160430 | 02:13 |
---|---|---|
*** britthouser has joined #openstack-neutron | 02:13 | |
*** banix has joined #openstack-neutron | 02:14 | |
*** banix has quit IRC | 02:18 | |
*** shwetaap has joined #openstack-neutron | 02:20 | |
*** seizadi has joined #openstack-neutron | 02:23 | |
*** tflynn has joined #openstack-neutron | 02:30 | |
*** itsAmeMario0o has quit IRC | 02:31 | |
*** itsAmeMario0o has joined #openstack-neutron | 02:31 | |
*** itsAmeMario0o has quit IRC | 02:32 | |
*** chem has quit IRC | 02:39 | |
*** tflynn has quit IRC | 02:44 | |
*** carl_baldwin has quit IRC | 02:44 | |
*** seizadi has quit IRC | 02:48 | |
*** tflynn has joined #openstack-neutron | 02:48 | |
*** dttocs has joined #openstack-neutron | 02:54 | |
*** chem has joined #openstack-neutron | 02:54 | |
*** baoli has joined #openstack-neutron | 02:55 | |
*** tflynn has quit IRC | 02:55 | |
*** david-lyle has quit IRC | 02:55 | |
*** tflynn has joined #openstack-neutron | 02:56 | |
*** jamielennox is now known as jamielennox|away | 02:58 | |
*** dttocs has quit IRC | 02:58 | |
*** banix has joined #openstack-neutron | 02:59 | |
*** baoli has quit IRC | 02:59 | |
*** achanda has quit IRC | 03:00 | |
*** jamielennox|away is now known as jamielennox | 03:03 | |
*** sbalukoff has quit IRC | 03:07 | |
*** aranjan has joined #openstack-neutron | 03:10 | |
*** armax has joined #openstack-neutron | 03:14 | |
*** jbell8 has joined #openstack-neutron | 03:15 | |
*** sbalukoff has joined #openstack-neutron | 03:20 | |
*** aranjan has quit IRC | 03:22 | |
*** banix has quit IRC | 03:29 | |
*** dboik has joined #openstack-neutron | 03:30 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: WIP Ryu functional tests https://review.openstack.org/172344 | 03:32 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver https://review.openstack.org/153946 | 03:32 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 03:32 |
*** itsAmeMario0o has joined #openstack-neutron | 03:32 | |
*** armax has quit IRC | 03:37 | |
*** itsAmeMario0o has quit IRC | 03:38 | |
*** coolsvap|afk is now known as coolsvap | 03:39 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 03:42 |
*** vks has quit IRC | 03:43 | |
*** ozialien has quit IRC | 03:43 | |
*** salv-orlando has joined #openstack-neutron | 03:45 | |
*** tflynn has quit IRC | 03:45 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: WIP Ryu functional tests https://review.openstack.org/172344 | 03:48 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver https://review.openstack.org/153946 | 03:48 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver https://review.openstack.org/153946 | 03:49 |
*** salv-orlando has quit IRC | 03:51 | |
*** tflynn has joined #openstack-neutron | 03:52 | |
*** dttocs has joined #openstack-neutron | 03:55 | |
*** nlahouti has quit IRC | 03:59 | |
*** tflynn has quit IRC | 03:59 | |
*** nlahouti has joined #openstack-neutron | 03:59 | |
*** dttocs has quit IRC | 04:00 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow interface https://review.openstack.org/153946 | 04:01 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 04:01 |
*** dboik has quit IRC | 04:03 | |
*** ishant has joined #openstack-neutron | 04:04 | |
*** tflynn has joined #openstack-neutron | 04:05 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 04:08 |
*** Bhavya has joined #openstack-neutron | 04:13 | |
*** bobmel_ has joined #openstack-neutron | 04:14 | |
*** dave-mccowan has quit IRC | 04:16 | |
*** bobmel has quit IRC | 04:16 | |
*** aranjan has joined #openstack-neutron | 04:17 | |
*** yfried|afk is now known as yfried__ | 04:18 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow interface https://review.openstack.org/153946 | 04:23 |
*** yatin has joined #openstack-neutron | 04:24 | |
*** subscope has joined #openstack-neutron | 04:25 | |
*** Kennan2 has joined #openstack-neutron | 04:26 | |
*** Kennan has quit IRC | 04:26 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation https://review.openstack.org/153946 | 04:32 |
*** aswadr has joined #openstack-neutron | 04:32 | |
*** ajmiller has quit IRC | 04:34 | |
*** Longgeek has joined #openstack-neutron | 04:35 | |
*** Longgeek has quit IRC | 04:35 | |
*** Longgeek has joined #openstack-neutron | 04:36 | |
*** popw has quit IRC | 04:42 | |
*** popw has joined #openstack-neutron | 04:42 | |
*** subscope has quit IRC | 04:47 | |
*** vivek-eb_ has joined #openstack-neutron | 04:48 | |
*** yfried__ is now known as yfried|afk | 04:49 | |
*** yfried|afk is now known as yfried__ | 04:51 | |
*** vivek-ebay has quit IRC | 04:51 | |
*** luqas has joined #openstack-neutron | 04:55 | |
*** dttocs has joined #openstack-neutron | 04:55 | |
*** itsAmeMario0o has joined #openstack-neutron | 04:57 | |
*** boris-42 has quit IRC | 04:58 | |
*** luqas has quit IRC | 04:59 | |
*** dttocs has quit IRC | 05:00 | |
*** itsAmeMario0o has quit IRC | 05:01 | |
*** yfried__ has quit IRC | 05:02 | |
*** chem has quit IRC | 05:07 | |
*** ishant has quit IRC | 05:13 | |
*** pal has joined #openstack-neutron | 05:13 | |
*** _kiran_ has joined #openstack-neutron | 05:15 | |
*** pal has quit IRC | 05:19 | |
*** vivek-eb_ has quit IRC | 05:20 | |
*** irenab has quit IRC | 05:23 | |
*** nlahouti has quit IRC | 05:23 | |
*** jbell8 has quit IRC | 05:27 | |
openstackgerrit | Hirofumi Ichihara proposed openstack/neutron-specs: Add enable_new_agents to agent conf in network node https://review.openstack.org/170774 | 05:28 |
*** abregman has joined #openstack-neutron | 05:31 | |
*** sbalukoff has quit IRC | 05:34 | |
*** achanda has joined #openstack-neutron | 05:37 | |
*** ishant has joined #openstack-neutron | 05:38 | |
*** vthapar has joined #openstack-neutron | 05:42 | |
*** sbalukoff has joined #openstack-neutron | 05:51 | |
*** tflynn has quit IRC | 05:51 | |
*** redbeard has joined #openstack-neutron | 05:53 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation https://review.openstack.org/153946 | 05:55 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 05:55 |
*** tflynn has joined #openstack-neutron | 05:55 | |
*** seizadi has joined #openstack-neutron | 05:55 | |
*** dttocs has joined #openstack-neutron | 05:56 | |
*** salv-orlando has joined #openstack-neutron | 05:57 | |
*** yamahata has quit IRC | 05:58 | |
*** yamahata has joined #openstack-neutron | 05:59 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation https://review.openstack.org/153946 | 06:00 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 06:00 |
*** aranjan_ has joined #openstack-neutron | 06:00 | |
*** sudipto has joined #openstack-neutron | 06:00 | |
*** dttocs has quit IRC | 06:01 | |
*** aranjan has quit IRC | 06:04 | |
*** salv-orlando has quit IRC | 06:06 | |
*** nlahouti has joined #openstack-neutron | 06:07 | |
*** anilvenkata has joined #openstack-neutron | 06:08 | |
yamamoto | dougwig: ping | 06:09 |
*** aranjan_ has quit IRC | 06:09 | |
*** afazekas_ has joined #openstack-neutron | 06:10 | |
*** aranjan has joined #openstack-neutron | 06:10 | |
*** garyk has joined #openstack-neutron | 06:12 | |
*** irenab has joined #openstack-neutron | 06:12 | |
*** anshul has joined #openstack-neutron | 06:14 | |
*** yamahata has quit IRC | 06:15 | |
*** SridharG has joined #openstack-neutron | 06:15 | |
*** zz_jgrimm is now known as jgrimm | 06:19 | |
*** yfried__ has joined #openstack-neutron | 06:19 | |
*** scheuran has joined #openstack-neutron | 06:21 | |
*** aranjan has quit IRC | 06:23 | |
*** lazy_prince has joined #openstack-neutron | 06:25 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Reduce code duplication in migration tests https://review.openstack.org/158184 | 06:25 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Expire cached db objects before reusing a session https://review.openstack.org/171520 | 06:25 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Simplify migration tests https://review.openstack.org/158182 | 06:25 |
*** shwetaap has quit IRC | 06:25 | |
openstackgerrit | watanabe isao proposed openstack/neutron: Restrict subnet create/update to avoid DHCP resync https://review.openstack.org/174228 | 06:26 |
*** bjornar_ has joined #openstack-neutron | 06:27 | |
*** anshul has quit IRC | 06:27 | |
*** yfried__ is now known as yfried|afk | 06:30 | |
*** bjornar_ has quit IRC | 06:32 | |
*** neeti has joined #openstack-neutron | 06:33 | |
*** yfried|afk is now known as yfried__ | 06:34 | |
*** nuritv has joined #openstack-neutron | 06:34 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver https://review.openstack.org/160245 | 06:35 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation https://review.openstack.org/153946 | 06:37 |
*** anshul has joined #openstack-neutron | 06:40 | |
*** gillllllliard is now known as gilliard | 06:48 | |
openstackgerrit | gongysh proposed openstack/neutron: Simplify keepalived.virtual_routes https://review.openstack.org/160430 | 06:50 |
*** anshul has quit IRC | 06:50 | |
*** jamielennox is now known as jamielennox|away | 06:52 | |
*** jyuso1 has joined #openstack-neutron | 06:54 | |
*** apuimedo has joined #openstack-neutron | 06:54 | |
*** moshele has joined #openstack-neutron | 06:56 | |
*** nlahouti has quit IRC | 06:56 | |
*** dttocs has joined #openstack-neutron | 06:57 | |
*** itzikb has joined #openstack-neutron | 07:01 | |
*** dttocs has quit IRC | 07:01 | |
openstackgerrit | Ankit Agrawal proposed openstack/neutron: Remove use of contextlib.nested https://review.openstack.org/167677 | 07:02 |
*** anshul has joined #openstack-neutron | 07:04 | |
*** enikanorov_ has joined #openstack-neutron | 07:06 | |
*** slaweq has joined #openstack-neutron | 07:07 | |
*** enikanorov_ has quit IRC | 07:07 | |
*** aranjan has joined #openstack-neutron | 07:10 | |
*** subscope has joined #openstack-neutron | 07:10 | |
*** SridharG has left #openstack-neutron | 07:12 | |
*** nmagnezi_ has joined #openstack-neutron | 07:12 | |
*** aranjan has quit IRC | 07:15 | |
*** aepifanov has joined #openstack-neutron | 07:15 | |
*** seizadi has quit IRC | 07:21 | |
*** claudiub has joined #openstack-neutron | 07:21 | |
*** devvesa has joined #openstack-neutron | 07:24 | |
*** ociuhandu has joined #openstack-neutron | 07:27 | |
*** kawa2014 has joined #openstack-neutron | 07:29 | |
*** chlong has quit IRC | 07:29 | |
*** ihrachyshka has joined #openstack-neutron | 07:31 | |
openstackgerrit | Merged openstack/neutron: Correct typo for matching non-dict ovsdb rows https://review.openstack.org/175059 | 07:34 |
*** SridharG has joined #openstack-neutron | 07:36 | |
*** pask81 has joined #openstack-neutron | 07:36 | |
*** jlanoux has joined #openstack-neutron | 07:37 | |
*** criptoverso has joined #openstack-neutron | 07:37 | |
*** luqas has joined #openstack-neutron | 07:38 | |
*** kiranr has joined #openstack-neutron | 07:38 | |
*** pask81 has quit IRC | 07:39 | |
*** _kiran_ has quit IRC | 07:39 | |
*** ociuhandu has quit IRC | 07:45 | |
*** emaray has joined #openstack-neutron | 07:46 | |
*** jistr has joined #openstack-neutron | 07:47 | |
*** achanda has quit IRC | 07:47 | |
*** moha_hunt has joined #openstack-neutron | 07:49 | |
*** roeyc has joined #openstack-neutron | 07:50 | |
*** nyechiel has joined #openstack-neutron | 07:52 | |
*** claudiub has quit IRC | 07:53 | |
*** moha_hunt has quit IRC | 07:53 | |
*** matrohon has joined #openstack-neutron | 07:55 | |
*** claudiub has joined #openstack-neutron | 07:56 | |
*** _kiran_ has joined #openstack-neutron | 07:57 | |
*** kiranr has quit IRC | 07:57 | |
*** dttocs has joined #openstack-neutron | 07:58 | |
*** jpena has joined #openstack-neutron | 07:59 | |
*** matrohon has quit IRC | 08:01 | |
*** safchain has joined #openstack-neutron | 08:01 | |
*** dttocs has quit IRC | 08:02 | |
*** matrohon1 has joined #openstack-neutron | 08:02 | |
*** dguitarbite has joined #openstack-neutron | 08:02 | |
*** claudiub has quit IRC | 08:06 | |
*** txomon|fon has quit IRC | 08:07 | |
*** salv-orlando has joined #openstack-neutron | 08:07 | |
*** matrohon1 has left #openstack-neutron | 08:09 | |
*** matrohon1 has joined #openstack-neutron | 08:10 | |
*** matrohon1 has left #openstack-neutron | 08:10 | |
*** salv-orlando has quit IRC | 08:11 | |
*** matrohon has joined #openstack-neutron | 08:11 | |
*** aranjan has joined #openstack-neutron | 08:11 | |
*** claudiub has joined #openstack-neutron | 08:11 | |
*** lionelz has joined #openstack-neutron | 08:13 | |
*** erkules has quit IRC | 08:13 | |
*** erkules has joined #openstack-neutron | 08:13 | |
*** matrohon has left #openstack-neutron | 08:14 | |
*** matrohon has joined #openstack-neutron | 08:15 | |
*** jlibosva has joined #openstack-neutron | 08:15 | |
*** ygbo has joined #openstack-neutron | 08:15 | |
*** jlibosva has quit IRC | 08:15 | |
*** jlibosva has joined #openstack-neutron | 08:16 | |
*** aranjan has quit IRC | 08:16 | |
*** salv-orlando has joined #openstack-neutron | 08:17 | |
*** numan has joined #openstack-neutron | 08:19 | |
*** txomon|fon has joined #openstack-neutron | 08:20 | |
*** salv-orlando has quit IRC | 08:21 | |
*** emaray has left #openstack-neutron | 08:22 | |
*** salv-orlando has joined #openstack-neutron | 08:23 | |
*** salv-orlando has quit IRC | 08:28 | |
*** ajo has joined #openstack-neutron | 08:28 | |
*** dmellado has joined #openstack-neutron | 08:30 | |
*** julien_ZTE has joined #openstack-neutron | 08:30 | |
openstackgerrit | watanabe isao proposed openstack/neutron: Make sure OVS restarts when Exception occurred https://review.openstack.org/169975 | 08:31 |
*** pask81 has joined #openstack-neutron | 08:32 | |
*** anshul has quit IRC | 08:32 | |
*** txomon|fon has quit IRC | 08:32 | |
*** doude has joined #openstack-neutron | 08:34 | |
*** garyk1 has joined #openstack-neutron | 08:39 | |
*** garyk has quit IRC | 08:42 | |
*** yamamoto has quit IRC | 08:45 | |
*** anshul has joined #openstack-neutron | 08:46 | |
*** f13o has joined #openstack-neutron | 08:47 | |
*** txomon|fon has joined #openstack-neutron | 08:49 | |
*** garyk1 has quit IRC | 08:50 | |
*** garyk has joined #openstack-neutron | 08:50 | |
*** devvesa has quit IRC | 08:50 | |
*** chlong has joined #openstack-neutron | 08:50 | |
*** salv-orlando has joined #openstack-neutron | 08:51 | |
*** neeti has quit IRC | 08:52 | |
*** kbyrne has joined #openstack-neutron | 08:54 | |
*** lori|away is now known as lori | 08:54 | |
*** apuimedo has quit IRC | 08:54 | |
*** sudipto has quit IRC | 08:56 | |
*** devvesa has joined #openstack-neutron | 08:56 | |
*** dttocs has joined #openstack-neutron | 08:59 | |
*** nyechiel has quit IRC | 08:59 | |
*** lukasa has joined #openstack-neutron | 08:59 | |
*** ihrachyshka has quit IRC | 09:00 | |
*** dttocs has quit IRC | 09:03 | |
*** nyechiel has joined #openstack-neutron | 09:05 | |
openstackgerrit | Neo proposed openstack/neutron-vpnaas: Provide Fedora support for StrongSwan https://review.openstack.org/174205 | 09:06 |
*** sambetts has joined #openstack-neutron | 09:06 | |
*** sudipto has joined #openstack-neutron | 09:08 | |
*** redbeard has quit IRC | 09:09 | |
openstackgerrit | Neo proposed openstack/neutron-vpnaas: Provide Fedora support for StrongSwan https://review.openstack.org/174205 | 09:09 |
*** ihrachyshka has joined #openstack-neutron | 09:11 | |
*** aranjan has joined #openstack-neutron | 09:12 | |
openstackgerrit | Hirofumi Ichihara proposed openstack/neutron-specs: Add availability_zone support https://review.openstack.org/169612 | 09:12 |
*** pask81 has quit IRC | 09:14 | |
*** jlanoux_ has joined #openstack-neutron | 09:17 | |
*** alexpilotti has joined #openstack-neutron | 09:17 | |
*** pradip has joined #openstack-neutron | 09:17 | |
*** pask81 has joined #openstack-neutron | 09:19 | |
*** chlong has quit IRC | 09:20 | |
*** jlanoux has quit IRC | 09:20 | |
*** dtynan has joined #openstack-neutron | 09:21 | |
*** hichihara has quit IRC | 09:23 | |
*** aepifanov has quit IRC | 09:26 | |
*** pcaruana has quit IRC | 09:27 | |
*** matrohon has quit IRC | 09:27 | |
*** pradip has quit IRC | 09:28 | |
*** ishant has quit IRC | 09:28 | |
*** matrohon has joined #openstack-neutron | 09:28 | |
*** matrohon has joined #openstack-neutron | 09:28 | |
*** julien_ZTE has quit IRC | 09:30 | |
*** pcaruana has joined #openstack-neutron | 09:30 | |
*** numan has quit IRC | 09:32 | |
*** chlong has joined #openstack-neutron | 09:32 | |
*** amotoki has quit IRC | 09:35 | |
*** sudipto has quit IRC | 09:35 | |
*** moha_hunt has joined #openstack-neutron | 09:36 | |
*** nyechiel has quit IRC | 09:37 | |
*** aranjan has quit IRC | 09:37 | |
*** shi has quit IRC | 09:41 | |
*** hanzhang has joined #openstack-neutron | 09:42 | |
*** yfried__ is now known as yfried|afk | 09:48 | |
*** garyk has quit IRC | 09:48 | |
*** garyk has joined #openstack-neutron | 09:49 | |
*** coolsvap is now known as coolsvap|afk | 09:51 | |
*** boris-42 has joined #openstack-neutron | 09:51 | |
*** sudipto has joined #openstack-neutron | 09:52 | |
*** yfried|afk is now known as yfried__ | 09:53 | |
*** numan has joined #openstack-neutron | 09:55 | |
*** Tiancheng has joined #openstack-neutron | 09:55 | |
*** redbeard has joined #openstack-neutron | 09:55 | |
openstackgerrit | Kevin Benton proposed openstack/neutron-specs: Role-based access control for networks https://review.openstack.org/132661 | 09:57 |
*** dttocs has joined #openstack-neutron | 09:59 | |
*** claudiub has quit IRC | 10:00 | |
*** aix has joined #openstack-neutron | 10:01 | |
*** neeti has joined #openstack-neutron | 10:01 | |
*** dttocs has quit IRC | 10:04 | |
*** doude has quit IRC | 10:07 | |
*** wznoinsk_ has joined #openstack-neutron | 10:07 | |
*** wznoinsk has quit IRC | 10:09 | |
*** pc_m has joined #openstack-neutron | 10:09 | |
openstackgerrit | Merged openstack/neutron: Drop the ovs_lib compat layer as per TODO note https://review.openstack.org/174179 | 10:12 |
*** safchain has quit IRC | 10:12 | |
*** anilvenkata has left #openstack-neutron | 10:14 | |
*** anilvenkata has joined #openstack-neutron | 10:15 | |
*** nyechiel has joined #openstack-neutron | 10:15 | |
*** moshele has quit IRC | 10:16 | |
*** Guest3939 is now known as rook | 10:22 | |
*** rook is now known as Guest89860 | 10:23 | |
*** itsAmeMario0o has joined #openstack-neutron | 10:23 | |
*** Guest89860 is now known as rook_ | 10:23 | |
*** yfried__ is now known as yfried|afk | 10:25 | |
*** itsAmeMario0o has quit IRC | 10:27 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: (DO NOT MERGE/WIP/POC) OVSFirewallDriver https://review.openstack.org/167671 | 10:29 |
*** yfried|afk is now known as yfried__ | 10:31 | |
openstackgerrit | Sridhar Gaddam proposed openstack/neutron: Support multiple IPv6 prefixes on internal router ports for an HA Router https://review.openstack.org/175342 | 10:32 |
*** roeyc has quit IRC | 10:33 | |
*** aranjan has joined #openstack-neutron | 10:34 | |
*** aranjan has quit IRC | 10:39 | |
*** anshul has quit IRC | 10:42 | |
*** numan has quit IRC | 10:43 | |
*** moshele has joined #openstack-neutron | 10:45 | |
openstackgerrit | Merged openstack/neutron: Add Kilo release milestone https://review.openstack.org/174483 | 10:50 |
_kiran_ | Hello guys! I am getting create failed (client error): Quota exceeded for resources: ['subnet'] http://paste.openstack.org/show/204862/ Please help me debug this problem. I have set Quota for subnet as -1. | 10:51 |
*** numan has joined #openstack-neutron | 10:51 | |
*** yuanying has quit IRC | 10:52 | |
*** kickinz1_mob|off has quit IRC | 10:53 | |
*** kickinz1|afk has joined #openstack-neutron | 10:53 | |
*** kickinz1_mob|off has joined #openstack-neutron | 10:53 | |
*** kickinz1|afk is now known as kickinz1 | 10:54 | |
*** anshul has joined #openstack-neutron | 10:55 | |
*** Tiancheng has quit IRC | 10:56 | |
*** stanzgy has quit IRC | 10:57 | |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Remove get_admin_roles and associated logic https://review.openstack.org/175238 | 10:59 |
*** dttocs has joined #openstack-neutron | 11:00 | |
*** numan has quit IRC | 11:02 | |
*** afaranha has quit IRC | 11:02 | |
*** txomon|fon has quit IRC | 11:03 | |
*** dttocs has quit IRC | 11:04 | |
HenryG | salv-orlando: hi, do you have a moment for a question? | 11:06 |
salv-orlando | HenryG: sure | 11:06 |
HenryG | salv-orlando: I see external_net is an extension, but some code seems to assume it is always loaded. Is it a valid assumption? | 11:07 |
openstackgerrit | venkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS https://review.openstack.org/174299 | 11:07 |
salv-orlando | HenryG: technically not. | 11:08 |
HenryG | salv-orlando: example: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/l3_db.py#n307 | 11:08 |
salv-orlando | but for l3_db is fine. Indeed the l3 extension is unlikely to work without external network, I think | 11:08 |
salv-orlando | HenryG: if you look at http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/l3.py it is kind of clear that external networks are a prerequisite for l3 | 11:10 |
salv-orlando | but for some reason we never made "officialy" a required extension for l3 | 11:10 |
HenryG | salv-orlando: I see, thanks. | 11:11 |
HenryG | salv-orlando: What about: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n1263 | 11:11 |
*** pradip has joined #openstack-neutron | 11:11 | |
*** numan has joined #openstack-neutron | 11:11 | |
salv-orlando | HenryG: that's a bug. I'm pretty sure arosen posted a patch for that a week ago. | 11:11 |
*** roeyc has joined #openstack-neutron | 11:11 | |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Drop load_admin_roles parameter https://review.openstack.org/175350 | 11:12 |
HenryG | salv-orlando: I see it, thanks | 11:12 |
pradip | hi all | 11:12 |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Revise functional test hooks https://review.openstack.org/168115 | 11:13 |
*** anshul has quit IRC | 11:14 | |
pradip | i am trying to provide internet access ti instences can any one tell me what are the initial configuration i have to do ..... i am using devstack for installing openstack on single vm all in one | 11:14 |
salv-orlando | pradip: do you control addressing on your external network? for instance if your machine has eth0 on a 10.0.0.0/24 network, can you control addressing on that network? | 11:16 |
*** kickinz1_mob|off has quit IRC | 11:17 | |
*** kickinz1 has quit IRC | 11:17 | |
*** kickinz1|afk has joined #openstack-neutron | 11:17 | |
*** kickinz1|afk is now known as kickinz1 | 11:17 | |
pradip | salv-orlando : i don't have idea how to control.. | 11:17 |
pradip | salv-orlando : i have saprate network with router and all configuration for neutron | 11:18 |
salv-orlando | pradip: I just wanted to know if you could use a chunk of your "real" network for neutron external network. it seems you cannot, and that's fine | 11:19 |
pradip | salv-orlando : yes i can use my real network.. | 11:19 |
salv-orlando | when you run devstack enabling neutron, neutron creates an external network of 172.24.4.0/24. The l3 agent will plug interfaces for the external network on br-ex | 11:19 |
pradip | salv-orlando : yes | 11:19 |
salv-orlando | if you want to use your real network, set the external network to a chunk of that | 11:20 |
salv-orlando | for instance if you have 10.0.0.0/24 use 10.0.0.128/25 | 11:20 |
salv-orlando | and then you need to manually connect br-ex to your eth interface | 11:20 |
salv-orlando | devstack does not do that in order to not mess up with networking on your machine | 11:20 |
pradip | salv-orlando : ok | 11:21 |
salv-orlando | basically the procedure is simple: 1) clear ip addresses on ethX interface; 2) add those on br-ex; 3) attach ethX to br-ex | 11:21 |
salv-orlando | and you should be up and running | 11:21 |
salv-orlando | pradip: the easiest thing imho however is to let neutron use 172.24.4.0/24 and configure a snat rule with iptables. | 11:22 |
salv-orlando | less manual steps, less chances of messing up networking in your machine | 11:22 |
*** lionelz has quit IRC | 11:23 | |
*** afazekas_ has quit IRC | 11:24 | |
*** yfried__ is now known as yfried|afk | 11:25 | |
*** jlibosva has quit IRC | 11:25 | |
*** yfried|afk is now known as yfried__ | 11:26 | |
pradip | salv-orlando : can you share me any link which help me do these steps... actualy i new for networking and neutron | 11:27 |
*** anshul has joined #openstack-neutron | 11:27 | |
*** afazekas_ has joined #openstack-neutron | 11:28 | |
*** jlibosva has joined #openstack-neutron | 11:31 | |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Remove backward compatibility for check_is_admin https://review.openstack.org/175078 | 11:33 |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Drop load_admin_roles parameter https://review.openstack.org/175350 | 11:33 |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Remove get_admin_roles and associated logic https://review.openstack.org/175238 | 11:33 |
HenryG | frickler: ping | 11:35 |
*** jpena is now known as jpena|lunch | 11:35 | |
*** aranjan has joined #openstack-neutron | 11:35 | |
*** safchain has joined #openstack-neutron | 11:36 | |
*** doude has joined #openstack-neutron | 11:36 | |
*** doude has quit IRC | 11:37 | |
*** doude has joined #openstack-neutron | 11:37 | |
*** apuimedo has joined #openstack-neutron | 11:38 | |
*** baoli has joined #openstack-neutron | 11:41 | |
*** ollivier has joined #openstack-neutron | 11:42 | |
*** baoli has quit IRC | 11:46 | |
*** popw has quit IRC | 11:47 | |
*** pask81 has quit IRC | 11:54 | |
*** apuimedo_ has joined #openstack-neutron | 11:55 | |
*** jistr has quit IRC | 11:57 | |
*** chlong has quit IRC | 11:58 | |
*** afazekas_ has quit IRC | 11:58 | |
*** jckasper_ has quit IRC | 11:59 | |
*** gsagie has joined #openstack-neutron | 11:59 | |
*** jckasper_ has joined #openstack-neutron | 11:59 | |
*** dttocs has joined #openstack-neutron | 12:01 | |
*** aranjan has quit IRC | 12:03 | |
*** jistr has joined #openstack-neutron | 12:03 | |
*** apuimedo_ has quit IRC | 12:03 | |
*** ihrachyshka has quit IRC | 12:03 | |
*** dttocs has quit IRC | 12:05 | |
*** vthapar has quit IRC | 12:06 | |
*** zhenguo has quit IRC | 12:07 | |
*** jlibosva has quit IRC | 12:09 | |
*** ronis has joined #openstack-neutron | 12:11 | |
*** tiswanso has joined #openstack-neutron | 12:14 | |
*** lazy_prince has quit IRC | 12:14 | |
*** busterswt has joined #openstack-neutron | 12:14 | |
*** dave-mccowan has joined #openstack-neutron | 12:14 | |
*** tiswanso has quit IRC | 12:16 | |
*** tiswanso has joined #openstack-neutron | 12:16 | |
*** ihrachyshka has joined #openstack-neutron | 12:19 | |
*** ihrachyshka has quit IRC | 12:19 | |
*** ihrachyshka has joined #openstack-neutron | 12:19 | |
*** itsAmeMario0o has joined #openstack-neutron | 12:20 | |
openstackgerrit | venkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS https://review.openstack.org/174299 | 12:20 |
*** nivtuckio has joined #openstack-neutron | 12:23 | |
*** sudipto has quit IRC | 12:23 | |
*** numan has quit IRC | 12:26 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/neutron: Added more Api tests for port-security extension. DependsOn: #167910 https://review.openstack.org/175372 | 12:26 |
*** salv-orlando has quit IRC | 12:28 | |
*** nfedotov has joined #openstack-neutron | 12:28 | |
*** amuller has joined #openstack-neutron | 12:29 | |
*** numan has joined #openstack-neutron | 12:30 | |
*** jckasper_ has quit IRC | 12:30 | |
*** jamielennox|away is now known as jamielennox | 12:31 | |
*** jamielennox is now known as jamielennox|away | 12:32 | |
*** jaypipes has joined #openstack-neutron | 12:33 | |
*** jschwarz has joined #openstack-neutron | 12:33 | |
*** numan has quit IRC | 12:34 | |
*** kickinz1 has left #openstack-neutron | 12:36 | |
*** gsagie has quit IRC | 12:37 | |
*** baoli has joined #openstack-neutron | 12:38 | |
*** itsAmeMario0o has quit IRC | 12:38 | |
*** prad has quit IRC | 12:40 | |
*** prad has joined #openstack-neutron | 12:40 | |
pradip | salv-orlando : thank its working | 12:43 |
*** cference_ has joined #openstack-neutron | 12:43 | |
*** cference_ has quit IRC | 12:44 | |
*** cference_ has joined #openstack-neutron | 12:44 | |
*** tiswanso has quit IRC | 12:45 | |
*** ihrachyshka has quit IRC | 12:46 | |
*** jpena|lunch is now known as jpena | 12:47 | |
openstackgerrit | Vivekanandan Narasimhan proposed openstack/neutron: vm migration needs persistent state for l2pop https://review.openstack.org/175383 | 12:49 |
*** shwetaap has joined #openstack-neutron | 12:49 | |
*** redbeard has quit IRC | 12:50 | |
frickler | HenryG: pong | 12:52 |
HenryG | frickler: Hi, I saw your comment on bug 1366326 | 12:52 |
openstack | bug 1366326 in CirrOS "ipv6 support" [Medium,Confirmed] https://launchpad.net/bugs/1366326 | 12:52 |
HenryG | frickler: Have you contributed to cirros before? | 12:53 |
*** jlibosva has joined #openstack-neutron | 12:53 | |
*** baoli has quit IRC | 12:54 | |
frickler | no, I did talk a bit with smoser though | 12:54 |
*** baoli has joined #openstack-neutron | 12:54 | |
HenryG | frickler: OK, I am looking to get some movement going on that bug | 12:55 |
HenryG | frickler: Are you interesting in helping? I also have a resource or two who can help. | 12:55 |
*** jlibosva has quit IRC | 12:55 | |
*** jlibosva has joined #openstack-neutron | 12:56 | |
*** salv-orlando has joined #openstack-neutron | 12:56 | |
HenryG | frickler: Right now though, I am struggling to understand the workflow required. | 12:56 |
frickler | sure, maybe you want to join #cirros | 12:56 |
*** wverdugo500 has joined #openstack-neutron | 12:56 | |
*** ihrachyshka has joined #openstack-neutron | 12:58 | |
*** aranjan has joined #openstack-neutron | 12:59 | |
*** baoli has quit IRC | 12:59 | |
*** baoli has joined #openstack-neutron | 13:00 | |
*** dttocs has joined #openstack-neutron | 13:02 | |
*** thomasem has joined #openstack-neutron | 13:02 | |
*** yatin has quit IRC | 13:02 | |
*** clett has quit IRC | 13:03 | |
*** neeti has quit IRC | 13:03 | |
*** aranjan has quit IRC | 13:04 | |
*** lifeless has quit IRC | 13:05 | |
*** dttocs has quit IRC | 13:06 | |
*** f13o has quit IRC | 13:07 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/neutron: Add more tests for port-security extension DependsOn: #167910 https://review.openstack.org/175389 | 13:07 |
*** moshele has quit IRC | 13:07 | |
ihrachyshka | salv-orlando, hey! | 13:07 |
*** wverdugo500 has left #openstack-neutron | 13:07 | |
ihrachyshka | salv-orlando, I wonder whether that 'backward compat' code for admin role even worked at all. __missing__ seems to be always preset in oslo policy.py (?) Or is there any other reason that broke it? | 13:08 |
*** banix has joined #openstack-neutron | 13:08 | |
*** wznoinsk_ has quit IRC | 13:08 | |
salv-orlando | ihrachyshka: yeah it did not work. didn't I state that in the commit message? | 13:09 |
ihrachyshka | salv-orlando, "However, this backward compatibility check does not work anymore" | 13:09 |
ihrachyshka | it suggested that it worked | 13:09 |
salv-orlando | ihrachyshka: and by not working it also created an interesting hole in the app security | 13:09 |
salv-orlando | ihrachyshka: right. I am positive there has been a point in time where it worked. | 13:10 |
salv-orlando | I do not remember when the openstack.common.policy started returning TrueCheck for missing policies, but it used to not be like that | 13:10 |
ihrachyshka | yeah, I'm concerned a bit. basically, people who upgraded from havana could be exposed to an issue. and we have havana releases in support in downstream. | 13:10 |
salv-orlando | ihrachyshka: they could be exposed is they have custom policy.json files with no context_is_admin rule | 13:11 |
salv-orlando | if we push a patch to stable we can secure those deployments, but we will also break them | 13:11 |
salv-orlando | obviously it is preferrable to break them. | 13:12 |
*** f13o has joined #openstack-neutron | 13:12 | |
*** thomasem has quit IRC | 13:14 | |
*** banix has quit IRC | 13:14 | |
*** thomasem has joined #openstack-neutron | 13:15 | |
*** pask81 has joined #openstack-neutron | 13:17 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas: Insert validation in creating/updating firewall https://review.openstack.org/147396 | 13:19 |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas: Insert tenant_id validation for fw and fw-policy https://review.openstack.org/175394 | 13:19 |
*** banix has joined #openstack-neutron | 13:23 | |
*** banix has quit IRC | 13:23 | |
ihrachyshka | salv-orlando, it started to behave like that as of https://review.openstack.org/#/c/14359/ which was merged long before backward compat change | 13:23 |
salv-orlando | ihrachyshka: wow 2012 is the prehistory of openstack | 13:24 |
*** rook_ has quit IRC | 13:24 | |
salv-orlando | and I approved that | 13:24 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/neutron: Add more API tests for port-security extension https://review.openstack.org/175399 | 13:25 |
*** gongysh has joined #openstack-neutron | 13:26 | |
*** crose has joined #openstack-neutron | 13:29 | |
*** alagalah has joined #openstack-neutron | 13:29 | |
salv-orlando | ihrachyshka: so we need to see what we should backport to stable branches. I would say there are two ways | 13:30 |
*** Networkn3rd has joined #openstack-neutron | 13:30 | |
salv-orlando | 1) build a rulecheck for the bw compatibility thing | 13:30 |
*** moshele has joined #openstack-neutron | 13:30 | |
salv-orlando | 2) return false is context_is_admin policy does not exist and then remove the bw compatibility thing | 13:31 |
*** superdan is now known as dansmith | 13:31 | |
*** moshele has quit IRC | 13:32 | |
*** drawsmcgraw has joined #openstack-neutron | 13:34 | |
*** ferest has joined #openstack-neutron | 13:34 | |
drawsmcgraw | Hi everyone | 13:35 |
*** annegentle has joined #openstack-neutron | 13:35 | |
*** jistr_ has joined #openstack-neutron | 13:35 | |
drawsmcgraw | I've been digging through the docs to no avail. Hoping this one is easy for someone in here. If I have more than one Nuetron network built, is there a way to tell Nova which one is the default? | 13:35 |
*** claudiub has joined #openstack-neutron | 13:36 | |
*** matrohon has quit IRC | 13:36 | |
*** matrohon has joined #openstack-neutron | 13:37 | |
HenryG | jlibosva: ping | 13:37 |
*** stanzgy has joined #openstack-neutron | 13:37 | |
*** matrohon has left #openstack-neutron | 13:38 | |
*** jistr has quit IRC | 13:38 | |
*** matrohon has joined #openstack-neutron | 13:39 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/neutron: Add more API tests for port-security extension https://review.openstack.org/175399 | 13:40 |
salv-orlando | ihrachyshka: btw, it seems it's not defaulting to a TrueCheck. That was just happening in my tests. | 13:40 |
salv-orlando | ihrachyshka: the check if the rule is missing default to whatever was there | 13:40 |
salv-orlando | ihrachyshka: as "default" rule in policy.json | 13:40 |
*** russellb has quit IRC | 13:40 | |
salv-orlando | so it's likely that the bw compatibility thing never really worked but at the same time never caused a security issue | 13:41 |
*** doude_ has joined #openstack-neutron | 13:41 | |
ihrachyshka | salv-orlando, right, that's what I see in oslo policy.py. ok, my pain is relieved. | 13:41 |
*** julim has joined #openstack-neutron | 13:41 | |
ihrachyshka | salv-orlando, __missing__ should not actually be triggered for 'in' check (python docs say it's for [] only) | 13:42 |
ihrachyshka | salv-orlando, so maybe it even worked (works?) | 13:42 |
*** rook has joined #openstack-neutron | 13:42 | |
salv-orlando | ihrachyshka: I'm sure it worked at some point. But those were times were we seldom tested anything at the gate. | 13:42 |
*** matrohon has quit IRC | 13:43 | |
*** matrohon has joined #openstack-neutron | 13:43 | |
salv-orlando | regardless, I'd say that since that patch merged for Grizzly, we can now consider that backward compatibility check not necessary anymore | 13:43 |
*** dboik has joined #openstack-neutron | 13:44 | |
*** jckasper has joined #openstack-neutron | 13:44 | |
*** jistr_ has quit IRC | 13:44 | |
*** matrohon has left #openstack-neutron | 13:44 | |
*** jistr has joined #openstack-neutron | 13:44 | |
*** zhenguo has joined #openstack-neutron | 13:44 | |
*** dboik has quit IRC | 13:45 | |
*** matrohon has joined #openstack-neutron | 13:45 | |
*** dboik has joined #openstack-neutron | 13:45 | |
*** russellb has joined #openstack-neutron | 13:45 | |
*** matrohon has joined #openstack-neutron | 13:45 | |
ihrachyshka | salv-orlando, that's fair I guess, for this specific case. though we should be more explicit with deprecations when moving forward. (the expectation would be that we issue a deprecation warning for one cycle the least) | 13:45 |
*** matrohon has left #openstack-neutron | 13:46 | |
*** matrohon has joined #openstack-neutron | 13:47 | |
drawsmcgraw | Just re-read the room description. My apologies; I'll take it over to #openstack. | 13:47 |
*** drawsmcgraw has left #openstack-neutron | 13:47 | |
*** matrohon has joined #openstack-neutron | 13:47 | |
*** matrohon has left #openstack-neutron | 13:47 | |
*** matrohon has joined #openstack-neutron | 13:48 | |
*** doude has quit IRC | 13:48 | |
pc_m | Anyone familiar with using oslo_rootwrap? I'm having problems updating a functional job and am getting a NoFilterMatched exception. | 13:48 |
*** claudiub has quit IRC | 13:48 | |
*** doude_ has quit IRC | 13:48 | |
salv-orlando | ihrachyshka: I do not have a strong opinion, so I might just convert that patch into a deprecation. However I feel like that won't be necessary in this case (Foldom/Grizzly operators hardly touched policy.json since most of the policy checks were hardcoded) | 13:49 |
ihrachyshka | salv-orlando, I agree on this particular patch, probably no need for explicit deprecation. | 13:50 |
*** gsagie has joined #openstack-neutron | 13:51 | |
*** shaohe_feng has joined #openstack-neutron | 13:53 | |
*** apuimedo has quit IRC | 13:55 | |
*** aepifanov has joined #openstack-neutron | 13:55 | |
*** shwetaap has quit IRC | 13:55 | |
HenryG | jschwarz: ping | 13:56 |
*** stanzgy has quit IRC | 13:56 | |
jlibosva | HenryG: hi | 13:58 |
*** wznoinsk has joined #openstack-neutron | 13:58 | |
*** rushil has joined #openstack-neutron | 13:59 | |
HenryG | jlibosva: IIRC you are an expert on grenade :) | 13:59 |
jlibosva | HenryG: if expert equals 'I did something' then yes :) | 13:59 |
*** aranjan has joined #openstack-neutron | 14:00 | |
*** garyk has quit IRC | 14:00 | |
jlibosva | HenryG: how can I help? | 14:00 |
*** garyk has joined #openstack-neutron | 14:00 | |
HenryG | jlibosva: Exactly :) Any idea what is the problem with bug 1435343 ? | 14:00 |
openstack | bug 1435343 in grenade "check-grenade-dsvm fails when updating CIRROS_VERSION in devstack" [Undecided,New] https://launchpad.net/bugs/1435343 | 14:00 |
* jlibosva looking | 14:00 | |
gsagie | Hello all, is there any way to block any configuration updates to the mechanism driver until some process in another thread is finished, or i have to use locks for it? | 14:02 |
*** dttocs has joined #openstack-neutron | 14:02 | |
*** jgrimm is now known as zz_jgrimm | 14:04 | |
*** smccully has joined #openstack-neutron | 14:04 | |
*** irenab has quit IRC | 14:04 | |
jschwarz | HenryG, pong | 14:05 |
HenryG | jschwarz: Is the fullstack test supposed to run in the functional job? | 14:05 |
*** dboik_ has joined #openstack-neutron | 14:06 | |
jschwarz | HenryG, yes. we didn't want to create a new gate job for the fullstack until there are more tests, so we just added it to the functional | 14:06 |
jschwarz | why do you ask? | 14:06 |
*** doude has joined #openstack-neutron | 14:06 | |
HenryG | jschwarz: The functional job is very unstable, and it seems related to the fullstack test | 14:06 |
*** dttocs has quit IRC | 14:07 | |
jschwarz | HenryG, how so? | 14:07 |
amuller | jschwarz: +1, today I saw the failure of a l3 ha functional test that I never saw fail before | 14:07 |
*** ajmiller has joined #openstack-neutron | 14:08 | |
amuller | jschwarz: ha router would not become active during the rpc bulk test | 14:08 |
amuller | jschwarz: was just on my way out, chat with you later | 14:08 |
jschwarz | amuller, ack | 14:08 |
*** dboik has quit IRC | 14:08 | |
HenryG | amuller: but some router tests also leak namespaces | 14:08 |
jschwarz | I'm curious as to why you are linking this to the full-stack? | 14:09 |
*** mwagner_lap has joined #openstack-neutron | 14:09 | |
*** alagalah has left #openstack-neutron | 14:09 | |
*** doude has quit IRC | 14:09 | |
jlibosva | HenryG: I think it depends on what we want to do. If we want to use 3.2 cirros in 'old' and 3.3 in 'new', we need to download 3.3 with grenade. I think correct thing to do here is to test 'new' version with 3.2 cirros due to backward compatibility | 14:09 |
HenryG | jschwarz: If I run "tox -e dsvm-functional -- neutron.tests.functional" then it passes every time for me. | 14:09 |
*** shwetaap has joined #openstack-neutron | 14:09 | |
jschwarz | uhm | 14:10 |
*** tflynn has quit IRC | 14:10 | |
jlibosva | HenryG: the config file for tempest was probably overwritten by new 3.3 value, thus the error | 14:10 |
HenryG | jschwarz: if I run "tox -e dsvm-functional" then it fails. | 14:10 |
jschwarz | HenryG, and running with the full-stack doesn't? | 14:10 |
*** doude has joined #openstack-neutron | 14:10 | |
jschwarz | well that sucks. | 14:10 |
*** doude_ has joined #openstack-neutron | 14:10 | |
jschwarz | HenryG, I'm thinking it might be related to the fact that the rabbitmq exchanges that are used are the same for all neutron code | 14:11 |
jschwarz | so maybe the functional tests are sending rabbitmq messages that are caught by the full-stack daemon? | 14:11 |
HenryG | jschwarz: I see "neutron-server" processes left running after tests complete | 14:11 |
jschwarz | HenryG, link? | 14:12 |
HenryG | jschwarz: I see this locally on my system | 14:12 |
*** doude_ has quit IRC | 14:12 | |
jschwarz | uhm | 14:12 |
*** zhhuabj has joined #openstack-neutron | 14:12 | |
HenryG | jlibosva: I am not sure I understand the flow there | 14:13 |
jschwarz | HenryG, and if you kill the neutron-server processes and re-run the tests, do some funcitonal still fail? | 14:13 |
HenryG | jschwarz: I have not tried that yet | 14:13 |
jschwarz | HenryG, please do. might be that there's a problem with the cleanup process of the tests (looking into it now) | 14:14 |
*** stanzgy has joined #openstack-neutron | 14:14 | |
jlibosva | HenryG: it's simple - part of devstack downloads cirros image in order to prepare some data for demo tenant, right? The URL for such image is given by the change made by the patch causing issue you sent | 14:14 |
jschwarz | multiple neutron-servers will surely make some fullstack tests more likely to fail (for the "one rabbitmq exchange" reason mentioned above), but I'm still not sure if it can effect functional tests | 14:15 |
jlibosva | HenryG: after we bump the version, tempest config file gets updated by grenade - introducing the change from patch | 14:15 |
jlibosva | HenryG: the old tempest was run with 3.2 | 14:15 |
jlibosva | HenryG: the new tempest expects 3.3 but the image wasn't downloaded as devstack wasn't run again | 14:15 |
HenryG | jlibosva: aha | 14:16 |
jlibosva | HenryG: does it make sense? | 14:16 |
HenryG | jlibosva: so we need to add a check for and download image if needed? | 14:16 |
*** jbell8 has joined #openstack-neutron | 14:16 | |
*** zhhuabj_ has joined #openstack-neutron | 14:16 | |
jlibosva | HenryG: it depends what we want to test. I believe grenade's motivation is to test backward compatibility - so my recommendation would be to use 3.2 after upgrade. | 14:17 |
jlibosva | HenryG: but if there is a necessary feature in 3.3 that is used by new tempest, we need to download a new image | 14:17 |
HenryG | jlibosva: the new image is for better ipv6 support | 14:18 |
*** apuimedo has joined #openstack-neutron | 14:18 | |
jlibosva | HenryG: then I guess it makes sense to get a new one | 14:18 |
*** afazekas_ has joined #openstack-neutron | 14:18 | |
HenryG | jlibosva: But I assume that grenade runs the same tests for old and new, so the old image should be OK | 14:18 |
*** zhhuabj has quit IRC | 14:19 | |
HenryG | jlibosva: or is that a wrong assumption? | 14:19 |
jlibosva | HenryG: I think it also updates tempest but I'm checking to make sure | 14:20 |
openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 14:20 |
*** jbell8 has quit IRC | 14:21 | |
*** zhhuabj_ has quit IRC | 14:22 | |
openstackgerrit | venkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS https://review.openstack.org/174299 | 14:24 |
*** daneyon_ has joined #openstack-neutron | 14:24 | |
jlibosva | HenryG: yep, from logs I can say we do upgrade tempest | 14:24 |
*** zhhuabj_ has joined #openstack-neutron | 14:24 | |
*** jobewan has joined #openstack-neutron | 14:24 | |
HenryG | jlibosva: thanks. Then it would make sense to update the cirros image too. | 14:25 |
*** roeyc has quit IRC | 14:26 | |
*** garyk has quit IRC | 14:26 | |
*** garyk has joined #openstack-neutron | 14:26 | |
*** daneyon has quit IRC | 14:26 | |
*** afazekas_ has quit IRC | 14:26 | |
*** dboik_ has quit IRC | 14:27 | |
jschwarz | amuller, re what we discussed earlier? | 14:27 |
*** dboik has joined #openstack-neutron | 14:27 | |
jschwarz | amuller, I'm thinking it can be because of the rabbitmq-exchange business | 14:28 |
*** emagana has joined #openstack-neutron | 14:28 | |
jschwarz | amuller, doesn't functional mock those? | 14:28 |
*** aranjan has quit IRC | 14:29 | |
*** afazekas_ has joined #openstack-neutron | 14:30 | |
*** anilvenkata has left #openstack-neutron | 14:31 | |
jlibosva | HenryG: are we talking upgrade Juno->Kilo or Kilo->Liberty? | 14:31 |
*** lifeless has joined #openstack-neutron | 14:32 | |
*** zhhuabj_ has quit IRC | 14:32 | |
*** ferest has quit IRC | 14:32 | |
*** achanda has joined #openstack-neutron | 14:32 | |
*** zhhuabj_ has joined #openstack-neutron | 14:33 | |
*** phil_h has joined #openstack-neutron | 14:33 | |
*** thedodd has joined #openstack-neutron | 14:34 | |
*** ollivier has quit IRC | 14:35 | |
*** aepifanov has quit IRC | 14:35 | |
*** aepifanov has joined #openstack-neutron | 14:35 | |
*** afazekas_ has quit IRC | 14:36 | |
*** shaohe_feng has left #openstack-neutron | 14:36 | |
*** aepifanov has quit IRC | 14:37 | |
jschwarz | HenryG, I can confirm that running the full functional job with fullstack creates errors with l3 agnet... | 14:37 |
*** aepifanov has joined #openstack-neutron | 14:37 | |
jschwarz | how do we want to proceed? | 14:37 |
*** aepifanov has quit IRC | 14:38 | |
*** aepifanov has joined #openstack-neutron | 14:38 | |
*** roeyc has joined #openstack-neutron | 14:38 | |
*** aepifanov has quit IRC | 14:38 | |
*** aepifanov has joined #openstack-neutron | 14:38 | |
*** achanda has quit IRC | 14:39 | |
*** f13o has quit IRC | 14:40 | |
HenryG | jlibosva: Juno->Kilo preferrably | 14:40 |
*** f13o has joined #openstack-neutron | 14:40 | |
jlibosva | HenryG: k, I can try to send patch then to test whether my assumption is correct | 14:41 |
HenryG | jschwarz: not sure. Any clues to root cause? | 14:41 |
HenryG | jlibosva: awesome, thanks | 14:41 |
jlibosva | HenryG: we can also consult with sdague first | 14:43 |
jlibosva | sdague: hi :) | 14:43 |
jaypipes | mestery, garyk, others: would appreciate your votes on https://review.openstack.org/#/c/173289 (it adds a Neutron VMware DVS ML2 driver project to stackforge) | 14:44 |
*** dguitarbite has quit IRC | 14:44 | |
sdague | jlibosva: what is the question? | 14:44 |
*** emagana has quit IRC | 14:44 | |
*** emagana has joined #openstack-neutron | 14:45 | |
garyk | jaypipes: sure. can take a look. please note that we have the dvs support in the vmware_nsx project. | 14:45 |
jschwarz | HenryG, as I wrote above, I think it's because neutron is using the same topics across the board | 14:45 |
garyk | i am not sure if that is relevant with what is being done here | 14:45 |
jschwarz | HenryG, so the same rabbitmq queues can be used for multiple neutron-server (or fullstack and functional) | 14:45 |
jlibosva | sdague: we need 3.3 cirros version that contains better ipv6 support - question is if uploading 3.3 image as a part of from-juno is a correct thing to do | 14:45 |
*** flaviof has joined #openstack-neutron | 14:46 | |
jschwarz | HenryG, though I'm not sure why the functional tests doesn't mock those rabbitmq function calls... | 14:46 |
HenryG | jschwarz: OK, makes sense. Can the functional tests patch the topics to be test-case unique? | 14:46 |
jschwarz | HenryG, I'm really not sure. will definetely require looking into | 14:47 |
sdague | jlibosva: cirros 0.3.3 has regressions in some of the commands which means it won't work in the gate | 14:47 |
*** gongysh_ has joined #openstack-neutron | 14:47 | |
jschwarz | HenryG, I'll ping marun and see if he has any ideas here - I started this discussion with him a while back | 14:47 |
*** afazekas_ has joined #openstack-neutron | 14:47 | |
HenryG | sdague: sad face :( | 14:47 |
*** jlanoux_ has quit IRC | 14:47 | |
*** zhhuabj_ has quit IRC | 14:47 | |
*** zhhuabj_ has joined #openstack-neutron | 14:48 | |
sdague | https://bugs.launchpad.net/cirros/+bug/1408922 | 14:48 |
openstack | Launchpad bug 1408922 in CirrOS "busybox nc: persistent server (-ll) option lost" [Undecided,In progress] - Assigned to Dr. Jens Rosenboom (j-rosenboom-j) | 14:48 |
jlibosva | sdague: HenryG then I guess this solves our concern in a most work-less way | 14:48 |
sdague | if you can get that resolved, and get a new version cut for upstream cirros, then we could move to a newer release | 14:48 |
*** russellb has quit IRC | 14:48 | |
mestery | jaypipes: done! | 14:49 |
*** banix has joined #openstack-neutron | 14:49 | |
*** gongysh has quit IRC | 14:49 | |
jlibosva | sdague: in case that happens - should we do it via from-juno/upgrade-tempest ? In devstack, image upload is part of glance but I think it should rather go to tempest | 14:50 |
SridharG | HenryG: You may want to have a look at this patch for reference - https://review.openstack.org/#/c/93949/1 (to update the version of cirros). Original patch: https://review.openstack.org/#/c/81486/3 | 14:50 |
amuller | jschwarz: the l3 agent functional tests mock the rpc layer yes | 14:51 |
*** banix has quit IRC | 14:51 | |
sdague | jlibosva: maybe, though realistically get the cirros image released first, then we'll figure it out | 14:51 |
jaypipes | mestery: cheers (though I've learned from garyk that https://review.openstack.org/#/c/152414/ might actually be better than what is proposed there...but we'll see...) | 14:51 |
HenryG | jschwarz: IIUC to mock the rabbit function calls or mock the topic depends on what is being tested. | 14:52 |
*** nmagnezi_ has quit IRC | 14:52 | |
mestery | jaypipes: Right! Collaboration with that group perhaps? | 14:52 |
ihrachyshka | mestery, are we going to create stable client branches for pre-kilo? | 14:52 |
jschwarz | amuller, I trust that work correctly.. so what else can fail here? | 14:52 |
jaypipes | mestery: heh, I'm working on that internally :) | 14:53 |
mestery | ihrachyshka: That is part of the plan, yes. | 14:53 |
mestery | jaypipes: :) | 14:53 |
ihrachyshka | ok, I just saw kilo only and decided to check whether you consider it done | 14:53 |
*** russellb has joined #openstack-neutron | 14:53 | |
amuller | jschwarz: I don't know what errors you're seeing. Are you seeing the same errors all of the time? Can you try to run the minimal set of tests that cause these errors? | 14:53 |
*** banix has joined #openstack-neutron | 14:53 | |
jlibosva | sdague: Roger that, thanks | 14:53 |
amuller | jschwarz: is this a result of tests interaction, or can you find a test that when run alone sometimes fails? | 14:54 |
salv-orlando | jaypipes, garyk, mestery: how many plugins and drivers there are for vmware's DVS? 9? | 14:54 |
salv-orlando | 99? | 14:54 |
mestery | salv-orlando: I've lost track, but they are spreading like rabbits in the spring. | 14:54 |
salv-orlando | mestery: do you know that it's an exponential models? | 14:55 |
mestery | salv-orlando: I'm not surprised :) | 14:55 |
jschwarz | amuller, I'm getting non-deterministic errors locally.. running a few runs on latest upstream to see if I can put my finger on it | 14:55 |
salv-orlando | armax and I actually did a project back in the university to model how rabbits spread | 14:55 |
mestery | salv-orlando: The bigger question is perhaps which ones support the NFV+Docker use case. | 14:55 |
mestery | salv-orlando: You and armax :) | 14:55 |
*** anshul has quit IRC | 14:56 | |
openstackgerrit | Matthew Treinish proposed openstack/python-neutronclient: Add functional test for subnet create https://review.openstack.org/172548 | 14:56 |
*** itzikb has quit IRC | 14:56 | |
*** annegentle has quit IRC | 14:57 | |
salv-orlando | mestery: I don't know. As long as it enables cloud-native applications in a hybrid Cloud scenario, that's fine for me. | 14:57 |
*** zzzeek has joined #openstack-neutron | 14:58 | |
*** strictlyb has quit IRC | 14:58 | |
*** crose has quit IRC | 14:59 | |
mestery | salv-orlando: While that's a valiant effort, if it's microservices architecture doesn't allow for a distributed, scale-out approach to declarative control, it's a waste. | 14:59 |
*** annegentle has joined #openstack-neutron | 14:59 | |
jaypipes | mestery, salv-orlando, garyk: I've asked some of the team responsible for the DVS driver work in Mirantis to please join on IRC and discuss with you all. I don't really feel like being a community proxy at this point... how hard is it to IRC anyway? ;) | 15:00 |
garyk | jaypipes: i am here | 15:00 |
salv-orlando | jaypipes: Idk I know a lot of people that have made a career out of being people proxies... | 15:00 |
mestery | lol | 15:01 |
salv-orlando | jaypipes: anyway we only talk to people which are properly dockerized and NFV-ready | 15:01 |
jaypipes | salv-orlando: I am proxy for a lot of things unfortunately :) | 15:02 |
*** rwsu has joined #openstack-neutron | 15:02 | |
mestery | I prefer it if they have a declarative interface as well. | 15:02 |
*** carl_baldwin has joined #openstack-neutron | 15:03 | |
*** marun has joined #openstack-neutron | 15:03 | |
*** annegentle has quit IRC | 15:04 | |
*** zz_jgrimm is now known as jgrimm | 15:04 | |
*** annegentle has joined #openstack-neutron | 15:05 | |
*** achanda has joined #openstack-neutron | 15:05 | |
*** annegentle has quit IRC | 15:06 | |
*** achanda has quit IRC | 15:07 | |
*** afazekas_ has quit IRC | 15:08 | |
*** annegentle has joined #openstack-neutron | 15:10 | |
*** nyechiel has quit IRC | 15:10 | |
*** vivek-ebay has joined #openstack-neutron | 15:11 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: confirm that _output_hosts_file does not log too often https://review.openstack.org/175445 | 15:12 |
*** rpothier has joined #openstack-neutron | 15:13 | |
*** vivek-ebay has quit IRC | 15:14 | |
*** jistr has quit IRC | 15:14 | |
*** xgerman has joined #openstack-neutron | 15:16 | |
*** strictlyb has joined #openstack-neutron | 15:16 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Replace custom method call logger with oslo.log helper https://review.openstack.org/168999 | 15:16 |
*** _kiran_ has quit IRC | 15:18 | |
*** annegentle has quit IRC | 15:18 | |
*** Bhavya has quit IRC | 15:19 | |
pc_m | mestery: hi | 15:19 |
*** dsneddon has joined #openstack-neutron | 15:20 | |
*** afazekas_ has joined #openstack-neutron | 15:21 | |
*** armax_ has joined #openstack-neutron | 15:22 | |
*** aepifanov has quit IRC | 15:22 | |
*** dttocs has joined #openstack-neutron | 15:25 | |
jschwarz | HenryG, amuller, so I tracked it down to the l3 agent removing namespaces that it doesn't know about (that are functional-tests owned) | 15:25 |
*** sbalukoff has quit IRC | 15:25 | |
amuller | jschwarz: good work | 15:25 |
HenryG | jschwarz: how does it do that? | 15:26 |
amuller | jschwarz: I guess this is a regression in the namespace refactor work that was merged a month or two ago | 15:26 |
*** ZZelle has quit IRC | 15:26 | |
amuller | carl_baldwin: ^ | 15:26 |
jschwarz | amuller, yep | 15:26 |
amuller | jschwarz: can you link the offending code? | 15:26 |
amuller | or are we not there yet? | 15:26 |
*** ZZelle has joined #openstack-neutron | 15:26 | |
*** afazekas_ has quit IRC | 15:26 | |
jschwarz | yes, a sec | 15:26 |
jschwarz | our uplink is a bit slow today :< | 15:26 |
HenryG | amuller: note, I also see some dvr functional tests do not clean up their test namespaces | 15:27 |
jschwarz | HenryG, amuller, https://github.com/openstack/neutron/blob/master/neutron/agent/l3/namespace_manager.py#L73 | 15:27 |
*** ihrachyshka has quit IRC | 15:27 | |
carl_baldwin | jschwarz: is there a bug number for context? | 15:27 |
*** vivek-ebay has joined #openstack-neutron | 15:28 | |
jschwarz | carl_baldwin, not yet. will have one soon enough | 15:28 |
*** safchain has quit IRC | 15:28 | |
*** jistr has joined #openstack-neutron | 15:28 | |
HenryG | amuller: https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/test_l3_agent.py#L1158 | 15:30 |
HenryG | amuller: _create_router() does not have addCleanup() | 15:30 |
amuller | HenryG: it's not supposed to be used directly, you're supposed to use manage_router | 15:31 |
amuller | I see there's two tests that use it directly =/ | 15:31 |
amuller | yeah that's gonna leak resources | 15:31 |
amuller | I'll take care of that, thanks Henry | 15:31 |
HenryG | amuller: thanks, I was not sure exactly how the fix should look | 15:32 |
jschwarz | amuller, I don't think we fixed that - we added that '@<host>' suffix and logic so it wouldn't delete namespaces that weren't his | 15:32 |
amuller | HenryG: me neither yet :) | 15:32 |
amuller | HenryG: Time to... Think. *shudders* | 15:32 |
*** roeyc has left #openstack-neutron | 15:32 | |
*** roeyc has joined #openstack-neutron | 15:32 | |
*** SridharG has left #openstack-neutron | 15:33 | |
*** nfedotov has quit IRC | 15:34 | |
*** vivek-ebay has quit IRC | 15:36 | |
*** stanzgy has quit IRC | 15:36 | |
*** afazekas_ has joined #openstack-neutron | 15:37 | |
*** vivek-ebay has joined #openstack-neutron | 15:38 | |
*** dannywilson has joined #openstack-neutron | 15:39 | |
*** safchain has joined #openstack-neutron | 15:41 | |
*** Swami has joined #openstack-neutron | 15:42 | |
*** dannywilson has quit IRC | 15:42 | |
jschwarz | carl_baldwin, HenryG, amuller, https://bugs.launchpad.net/neutron/+bug/1446284 | 15:42 |
openstack | Launchpad bug 1446284 in neutron "functional tests fail non-deterministicly because of full-stack" [Undecided,New] | 15:42 |
carl_baldwin | Thanks. | 15:42 |
*** dannywilson has joined #openstack-neutron | 15:43 | |
jschwarz | carl_baldwin, sure thing. I'd fix it but I'm not likely to have enough time on my hand in the following weeks so I'd suggest someone else for this | 15:43 |
*** nlahouti has joined #openstack-neutron | 15:44 | |
*** ygbo has quit IRC | 15:45 | |
*** yfried__ has quit IRC | 15:45 | |
*** nyechiel has joined #openstack-neutron | 15:46 | |
*** dboik_ has joined #openstack-neutron | 15:47 | |
*** afazekas_ has quit IRC | 15:47 | |
*** zhhuabj_ has quit IRC | 15:49 | |
*** zhhuabj_ has joined #openstack-neutron | 15:50 | |
*** dboik has quit IRC | 15:50 | |
*** mlavalle has joined #openstack-neutron | 15:50 | |
*** yfauser has joined #openstack-neutron | 15:50 | |
*** yfauser has left #openstack-neutron | 15:50 | |
*** dannywilson has quit IRC | 15:51 | |
*** ronis has quit IRC | 15:52 | |
*** rm_work is now known as rm_work|away | 15:52 | |
*** jistr_ has joined #openstack-neutron | 15:53 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Fix DVR functional tests resources leak https://review.openstack.org/175462 | 15:53 |
*** russellb has quit IRC | 15:53 | |
amuller | HenryG: carl_baldwin: jschwarz: ^ | 15:53 |
jschwarz | amuller, reviewing | 15:53 |
amuller | That won't solve random failures but at least we'll clean up after ourselves :) | 15:53 |
salv-orlando | amuller: like every good dog | 15:54 |
*** pradipta has joined #openstack-neutron | 15:54 | |
amuller | salv-orlando: I'm not sure who's the dog in your analogy but I love dogs, so, :) | 15:54 |
*** bjornar_ has joined #openstack-neutron | 15:55 | |
*** Marga_ has joined #openstack-neutron | 15:55 | |
jschwarz | amuller, see comment | 15:56 |
*** garyk has quit IRC | 15:56 | |
*** gongysh_ has quit IRC | 15:56 | |
*** jistr has quit IRC | 15:56 | |
*** _cjones_ has joined #openstack-neutron | 15:57 | |
*** russellb has joined #openstack-neutron | 15:58 | |
*** zhhuabj_ has quit IRC | 15:58 | |
*** ihrachyshka has joined #openstack-neutron | 15:58 | |
*** _cjones_ has quit IRC | 15:59 | |
*** _cjones_ has joined #openstack-neutron | 15:59 | |
*** zhhuabj_ has joined #openstack-neutron | 16:00 | |
*** Longgeek has quit IRC | 16:00 | |
*** moha_hunt has quit IRC | 16:01 | |
*** daneyon has joined #openstack-neutron | 16:02 | |
amuller | jschwarz: replied, I knew that would come up, I should have expanded the commit message | 16:02 |
amuller | oh well | 16:02 |
*** roeyc has quit IRC | 16:03 | |
jschwarz | amuller, weird, was sure create_router wasn't used anymore either than with manage_router | 16:04 |
jschwarz | so +1 | 16:04 |
*** daneyon_ has quit IRC | 16:04 | |
*** jistr_ is now known as jistr | 16:05 | |
*** scheuran has quit IRC | 16:05 | |
*** Marga_ has quit IRC | 16:05 | |
*** Marga_ has joined #openstack-neutron | 16:06 | |
jschwarz | amuller, so i'm thinking that a new l3 agent is needed for the fullstack, that will not delete namespaces at all? otherwise need to add a certain suffix to the test namespaces and make sure those aren't deleted? | 16:07 |
jschwarz | code seems more complicated to patch now than before | 16:07 |
amuller | some of the functional tests already use a test suffix | 16:08 |
amuller | the l3 agent ones don't | 16:08 |
amuller | prefix I mean | 16:08 |
jschwarz | amuller, why not? | 16:08 |
amuller | they're old | 16:08 |
amuller | and crumbling | 16:08 |
amuller | kind of smelly too | 16:08 |
jschwarz | amuller, just like dogs, it would seem | 16:09 |
amuller | when I created that file it was like 200 LoCs, now it's over 1.2k I think | 16:09 |
jschwarz | 1196 | 16:09 |
amuller | and tests a lot of very different things | 16:09 |
*** jorgem has joined #openstack-neutron | 16:10 | |
amuller | jschwarz: I'll have to think more deeply about this and see what I can do | 16:10 |
amuller | don't have a solution off hand | 16:10 |
*** aepifanov has joined #openstack-neutron | 16:12 | |
*** moshele has joined #openstack-neutron | 16:15 | |
*** aepifanov has quit IRC | 16:15 | |
*** aepifanov has joined #openstack-neutron | 16:15 | |
*** bobmel has joined #openstack-neutron | 16:16 | |
*** apuimedo has quit IRC | 16:16 | |
*** zhhuabj_ has quit IRC | 16:17 | |
*** zhhuabj_ has joined #openstack-neutron | 16:18 | |
*** bobmel_ has quit IRC | 16:18 | |
*** absubram has joined #openstack-neutron | 16:19 | |
*** apuimedo has joined #openstack-neutron | 16:20 | |
*** Marga_ has quit IRC | 16:22 | |
*** Marga_ has joined #openstack-neutron | 16:24 | |
*** thedodd has quit IRC | 16:24 | |
*** jistr has quit IRC | 16:24 | |
*** seizadi has joined #openstack-neutron | 16:25 | |
*** Kennan2 has quit IRC | 16:29 | |
*** baoli has quit IRC | 16:29 | |
*** Kennan has joined #openstack-neutron | 16:29 | |
*** aranjan has joined #openstack-neutron | 16:30 | |
*** dboik_ has quit IRC | 16:30 | |
*** dboik has joined #openstack-neutron | 16:30 | |
*** rm_work|away is now known as rm_work | 16:31 | |
pc_m | marun: hi | 16:31 |
marun | pc_m: Hi. I'm afraid I have a meeting for the next hourl | 16:32 |
*** ijw has joined #openstack-neutron | 16:32 | |
*** dboik has quit IRC | 16:33 | |
pc_m | marun: sure. Maybe we can hook up after? | 16:33 |
marun | pc_m: yes | 16:33 |
pc_m | marun: thanks | 16:33 |
*** baoli_ has joined #openstack-neutron | 16:33 | |
*** dboik has joined #openstack-neutron | 16:33 | |
*** moshele has quit IRC | 16:33 | |
pc_m | marun: I'm stuck and need some advise. | 16:33 |
marun | pc_m: ok | 16:34 |
*** ijw_ has joined #openstack-neutron | 16:36 | |
*** abregman has quit IRC | 16:36 | |
*** jschwarz has quit IRC | 16:37 | |
*** ijw__ has joined #openstack-neutron | 16:37 | |
*** ijw has quit IRC | 16:38 | |
*** aepifanov has quit IRC | 16:38 | |
*** ijw_ has quit IRC | 16:40 | |
*** safchain has quit IRC | 16:40 | |
*** aepifanov has joined #openstack-neutron | 16:41 | |
*** claudiub has joined #openstack-neutron | 16:41 | |
*** Swami has quit IRC | 16:41 | |
*** vivek-ebay has quit IRC | 16:42 | |
*** abregman has joined #openstack-neutron | 16:43 | |
*** pask81 has quit IRC | 16:43 | |
*** luqas has quit IRC | 16:43 | |
*** abregman has quit IRC | 16:44 | |
*** jlibosva has quit IRC | 16:45 | |
*** armax_ has left #openstack-neutron | 16:46 | |
*** jschwarz has joined #openstack-neutron | 16:47 | |
*** armax_ has joined #openstack-neutron | 16:47 | |
*** Swami has joined #openstack-neutron | 16:48 | |
jschwarz | armax_, do you have a second to talk about https://review.openstack.org/#/c/111580/ ? | 16:49 |
armax_ | sure | 16:49 |
armax_ | jschwarz: what about it? | 16:49 |
jschwarz | what's the status of that API refactor you talked about last cycle? | 16:49 |
jschwarz | I'm interested in re-opening it for submission for L | 16:49 |
jschwarz | but it was blocked due to the API work mark was supposed to do | 16:50 |
armax_ | jschwarz: then you’re best person is salv-orlando | 16:50 |
jschwarz | ahah! thanks :) | 16:50 |
jschwarz | salv-orlando, what do you think? | 16:50 |
*** matrohon has quit IRC | 16:51 | |
*** nmagnezi_ has joined #openstack-neutron | 16:51 | |
armax_ | jschwarz: dougwig was also not so fond of special casing API filters | 16:51 |
*** devvesa has quit IRC | 16:51 | |
*** shwetaap has quit IRC | 16:51 | |
dougwig | armax_, jschwarz - indeed, i was not. | 16:51 |
*** abregman has joined #openstack-neutron | 16:52 | |
jschwarz | armax_, aye, I remember it was to be a uphill battle, though it's not the first code to do so | 16:52 |
armax_ | jschwarz: I think that until we have a way to sanely add all these useful filtering capabilities I’d hold on | 16:52 |
jschwarz | doude, the ports_list code does almost exactly the same thing i'm proposing | 16:52 |
jschwarz | question is - how long? not like this is in any rush, but in the beginning of K we discussed it and I was under the impression that the work should be done by the end of K-3 | 16:53 |
dougwig | jschwarz: the pecan work slipped. that's a question for kevinbenton or blogan | 16:53 |
jschwarz | armax_, also I remember salv-orlando saying that this was a piece of sensitive code base he was willing to not edit at all because it touches so many things | 16:54 |
jschwarz | Well the list is getting bigger and bigger... :) | 16:54 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: confirm that _output_hosts_file does not log too often https://review.openstack.org/175445 | 16:54 |
*** zhhuabj_ has quit IRC | 16:54 | |
*** russellb has quit IRC | 16:55 | |
*** zhhuabj_ has joined #openstack-neutron | 16:55 | |
jschwarz | dougwig, armax_, think I'll take this to the list - the probability of me catching so many cores at once seems very unlikely :) | 16:56 |
jschwarz | thanks for the time | 16:57 |
dougwig | jschwarz: no worries, good luck. :) | 16:57 |
*** f13o has quit IRC | 16:57 | |
jschwarz | thanks | 16:58 |
armax_ | jschwarz: you could always resubmit the spec, taking the history into account and get the discussion take place on the patch itself | 16:58 |
*** russellb has joined #openstack-neutron | 16:58 | |
armax_ | jschwarz: frankly all of us need to have a serious as to whether we want to seriously do something about the API layer or shelve it for good | 16:59 |
jschwarz | armax_, good point. do we know when the spec submission deadline is yet? | 16:59 |
armax_ | jschwarz: don’t know the exact that, but there’s plenty of time | 16:59 |
*** dguitarbite has joined #openstack-neutron | 16:59 | |
jschwarz | so I'll resubmit it. perhaps we can take it from them and hopefully we'll get an open discussion on this | 17:00 |
jschwarz | s/from them/from there/g | 17:00 |
*** ijw has joined #openstack-neutron | 17:01 | |
*** baoli_ has quit IRC | 17:01 | |
*** dboik has quit IRC | 17:02 | |
*** kawa2014 has quit IRC | 17:02 | |
*** vivek-ebay has joined #openstack-neutron | 17:02 | |
*** dboik has joined #openstack-neutron | 17:02 | |
*** gsagie has quit IRC | 17:02 | |
*** dboik has quit IRC | 17:03 | |
*** dboik has joined #openstack-neutron | 17:03 | |
*** armax_ has quit IRC | 17:03 | |
*** moha_hunt has joined #openstack-neutron | 17:04 | |
*** armax_ has joined #openstack-neutron | 17:04 | |
*** ijw__ has quit IRC | 17:04 | |
openstackgerrit | Andy Hill proposed openstack/neutron: Add use_slave DB api support https://review.openstack.org/175491 | 17:05 |
ihrachyshka | obondarev, W+1 please: https://review.openstack.org/#/c/168999/ I needed to rebase to pass gate due to unrelated bug that is already fixed | 17:06 |
*** dboik has quit IRC | 17:07 | |
*** dboik has joined #openstack-neutron | 17:07 | |
*** ivar-lazzaro has joined #openstack-neutron | 17:08 | |
*** alagalah has joined #openstack-neutron | 17:09 | |
*** ivar-lazzaro has quit IRC | 17:09 | |
*** ivar-lazzaro has joined #openstack-neutron | 17:09 | |
*** shwetaap has joined #openstack-neutron | 17:10 | |
*** daneyon_ has joined #openstack-neutron | 17:11 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Fix DVR functional tests resources leak https://review.openstack.org/175462 | 17:12 |
*** daneyon has quit IRC | 17:12 | |
*** nyechiel has quit IRC | 17:13 | |
*** ronis has joined #openstack-neutron | 17:14 | |
marun | amuller: Hi | 17:14 |
amuller | marun: Hello sir | 17:14 |
amuller | HenryG: ^ | 17:15 |
marun | amuller: are you interested in tackling another dvr issue? | 17:15 |
amuller | new revision up | 17:15 |
marun | amuller: https://bugs.launchpad.net/neutron/+bug/1446261 | 17:15 |
openstack | Launchpad bug 1446261 in neutron "gate-neutron-dsvm-functional race fails HA/DVR tests with network namespace not found" [High,Confirmed] - Assigned to Maru Newby (maru) | 17:15 |
amuller | marun: depends... first on my plate is the random functional tests failure | 17:15 |
amuller | hheeyyyy | 17:15 |
jschwarz | marun, heeeeey | 17:15 |
amuller | we might have dup bug reports | 17:15 |
marun | amuller: mestery assigned to me thinking that the timeout changes might have been related | 17:15 |
jschwarz | yep | 17:15 |
jschwarz | that's fullstack fault | 17:15 |
jschwarz | well, partially | 17:15 |
marun | amuller: ah, so you're already working on it? | 17:15 |
marun | jschwarz: you too? | 17:15 |
mestery | marun: Yes, I had hoped you coudl triage, looks like you did, thanks! | 17:16 |
jschwarz | yeah\ | 17:16 |
jschwarz | marun, https://bugs.launchpad.net/neutron/+bug/1446284 | 17:16 |
openstack | Launchpad bug 1446284 in neutron "functional tests fail non-deterministicly because of full-stack" [Undecided,New] - Assigned to Carl Baldwin (carl-baldwin) | 17:16 |
amuller | marun: I'm on that yeah | 17:16 |
marun | mriedem commented on the other bug that https://github.com/openstack/neutron/commit/61aa4a57b17594bb0412f870f361a8a35ec07b62 might have something to do with it | 17:16 |
marun | the timing is suspicious, at least | 17:16 |
amuller | marun: maybe there's 2 separate issues | 17:16 |
amuller | marun: jschwarz figured out that the full stack l3 agent that starts up is destroying namespaces from concurrent functional tests | 17:17 |
jschwarz | marun, I tracked it down the the l3 agent deleting "unknown" namespaces it doesn't know | 17:17 |
jschwarz | see my bug report | 17:17 |
amuller | but that full stack test was merged after Swami's test | 17:17 |
openstackgerrit | Paul Michali proposed openstack/neutron-vpnaas: VPNaaS: Revise functional test hooks https://review.openstack.org/168115 | 17:17 |
jschwarz | I think I did see that test fail regardless of the fullstack locally | 17:18 |
jschwarz | let me check | 17:18 |
marun | jschwarz, amuller: I thought the idea was to only clean up namespaces in tests whose ownership was clear? | 17:18 |
marun | i.e. tests clearly mark resources they create so they can clean them up | 17:18 |
amuller | marun: the failure is due to agent code not test code | 17:18 |
marun | amuller: so the agents need that same constraint | 17:19 |
jschwarz | yep | 17:19 |
amuller | marun: yeah I was about to dive in to it | 17:19 |
marun | amuller: cool beans | 17:19 |
jschwarz | marun, amuller, also if I have you both here | 17:19 |
amuller | the initial gut reaction is that when the agent starts it should not delete namespaces that are marked for testing | 17:19 |
marun | amuller: can you take ownership of the other bug too, then? | 17:19 |
amuller | marun: you can assign it to me, jschwarz can you close yours as dup? | 17:19 |
marun | amuller: right. maybe any namespace that contains a : or other special identifying character should be considered off-limits | 17:20 |
jschwarz | marun, amuller, re: that whole "add a rabbitmq exchange per test" won't work probably since the "topics" that are used are basically exchanges (run rabbitmqctl list_exchanges on your devstack) | 17:20 |
marun | jschwarz: dynamic topics it is... | 17:20 |
jschwarz | marun, was afraid you'll say that | 17:20 |
jschwarz | ^_^ | 17:20 |
marun | jschwarz: if you can find a way to make exchanges work, more power to you. | 17:20 |
marun | jschwarz: the static topics are an artifact of not designing for testability, though | 17:21 |
*** zhhuabj_ has quit IRC | 17:21 | |
jschwarz | amuller, can't close it (doesn't appear in my list of "change status to") - ask marun | 17:21 |
*** zhhuabj_ has joined #openstack-neutron | 17:21 | |
marun | done | 17:21 |
jschwarz | marun, I'll need to dive into it, but not sure I'll have enough time | 17:21 |
jschwarz | carl_baldwin, ^ | 17:22 |
* carl_baldwin already reading back. | 17:22 | |
jschwarz | marun, I'll try to devote some time for this next week but management probably wants me doing some other stuff | 17:23 |
jschwarz | marun, it will probably end up with a long-term spec though | 17:23 |
marun | jschwarz: ok | 17:23 |
jschwarz | marun, how was your weekend? :) | 17:23 |
marun | jschwarz: not long enough. how about yours? :) | 17:24 |
jschwarz | marun, not long enough. not enough GTA5 :< | 17:24 |
*** achanda has joined #openstack-neutron | 17:24 | |
carl_baldwin | I’m sure I can find time to address these bugs. | 17:24 |
jschwarz | alas, 3rd world problems | 17:24 |
amuller | jschwarz: Are you familiar with the concept of vacation days? | 17:24 |
jschwarz | amuller, I am. The college I go to doesn't | 17:24 |
amuller | jschwarz: oh common | 17:25 |
amuller | you don't really have to go to classes | 17:25 |
amuller | err, I mean, don't skip school | 17:25 |
jschwarz | I feel bad if I don't | 17:25 |
jschwarz | I already skipped a few classes last week (and one today, in fact) | 17:25 |
*** sudipto has joined #openstack-neutron | 17:27 | |
*** zhenguo has quit IRC | 17:27 | |
*** tflynn has joined #openstack-neutron | 17:28 | |
jschwarz | righto, I'm off | 17:30 |
jschwarz | see you around guys :) | 17:30 |
*** jschwarz has quit IRC | 17:30 | |
*** armax_ has left #openstack-neutron | 17:32 | |
*** aswadr has quit IRC | 17:32 | |
amuller | marun: please take a look at https://review.openstack.org/#/c/175462/ | 17:32 |
*** armax_ has joined #openstack-neutron | 17:33 | |
* marun lookin | 17:33 | |
amuller | marun: there's a lot of context in the comments of the first PS | 17:33 |
*** jorgem has quit IRC | 17:33 | |
*** jpena has quit IRC | 17:34 | |
*** abregman has quit IRC | 17:34 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional/fullstack tests https://review.openstack.org/143412 | 17:35 |
*** russellb has quit IRC | 17:36 | |
marun | amuller: /url 2 | 17:36 |
marun | oops, sorry | 17:36 |
*** irenab has joined #openstack-neutron | 17:37 | |
*** dboik has quit IRC | 17:37 | |
*** dboik has joined #openstack-neutron | 17:38 | |
marun | amuller: Isn't there a more explicit exception you could trap for? | 17:38 |
*** melwitt has joined #openstack-neutron | 17:38 | |
amuller | marun: maybe Runtime, dunno | 17:38 |
*** harlowja_away is now known as harlowja | 17:38 | |
amuller | marun: it won't be fool proof | 17:38 |
amuller | or future proof | 17:39 |
marun | amuller: Maybe the underlying code needs to be fixed, then? | 17:39 |
amuller | who knows what errors you might get when you try to delete a router that's not there | 17:39 |
marun | amuller: trapping for Exception is almost entirely an anti-pattern (unless you're at least logging the problem) | 17:39 |
marun | amuller: I think there should be code in the deletion method that throws a NotFound based on any number of possible scenarios. | 17:39 |
marun | amuller: you're right that the test code shouldn't be responsible for determining that condition | 17:40 |
marun | amuller: the test wrapper should know how to differentiate between failure modes, though. | 17:40 |
*** russellb has joined #openstack-neutron | 17:40 | |
*** dboik has quit IRC | 17:40 | |
*** zhhuabj_ has quit IRC | 17:40 | |
amuller | marun: I'm OK with this since safe_delete_router can only be used with manage_router (Since I made it an internal method) during its cleanup, and we have tests that use delete_router (The non-safe version) | 17:40 |
*** zhhuabj_ has joined #openstack-neutron | 17:41 | |
*** dboik has joined #openstack-neutron | 17:41 | |
amuller | marun: I don't think this fix requires changing deletion error handling in the agent itself | 17:41 |
amuller | we have coverage for deletion | 17:41 |
marun | amuller: Can the deletion error handling indicate specifically that the targeted resources cannot be found? | 17:42 |
marun | amuller: It's not a matter of 'coverage' | 17:42 |
marun | amuller: It's a matter of encapsulating detection of expected failure conditions in the code that expects the failure. | 17:42 |
amuller | marun: we have code in the L3 agent that checks if the router exists in the in-memory cache | 17:43 |
amuller | if it doesn't, you return early | 17:43 |
marun | amuller: that doesn't sound like the case we're talking about | 17:43 |
amuller | however in the functional tests we try to simulate agent restarts in a weird way | 17:43 |
*** luqas has joined #openstack-neutron | 17:44 | |
amuller | by creating an agent and a router, then configuring the router again with a new agent instance | 17:44 |
*** moshele has joined #openstack-neutron | 17:44 | |
marun | amuller: does the l3 agent know how to clean up after itself? | 17:44 |
marun | amuller: or is that cleanup mainly the responsibility of the functional tests? | 17:44 |
amuller | marun: partially, depends... | 17:44 |
*** aranjan has quit IRC | 17:44 | |
*** ZZelle has quit IRC | 17:45 | |
marun | amuller: 'partially' sounds a bit ominous to me' | 17:45 |
*** criptoverso has quit IRC | 17:45 | |
marun | amuller: Is there a reason that resource management shouldn't be the responsibility of the agent? | 17:45 |
amuller | it's complicated I guess. The agent starts by deleting namespaces in the (get_routers RPC method) / (currently present namespaces) set | 17:45 |
amuller | marun: this is what's screwing us over in the full stack tsts | 17:46 |
amuller | tests* | 17:46 |
amuller | then you have the neutron-netns-cleanup script | 17:46 |
*** baoli has joined #openstack-neutron | 17:46 | |
amuller | marun: the agent has to be told to create and delete routers | 17:47 |
amuller | marun: what would you propose? | 17:47 |
*** russellb has quit IRC | 17:47 | |
*** yfried__ has joined #openstack-neutron | 17:48 | |
*** luqas has quit IRC | 17:48 | |
marun | amuller: I mainly want the router deletion method to indicate via an exception that a router doesn't exist to be deleted. | 17:48 |
marun | amuller: So that the method of detecting a missing router is encapsulated in the method. | 17:49 |
*** aranjan has joined #openstack-neutron | 17:50 | |
amuller | marun: that code would be pretty weird to exist in the agent. Bear with me: It'd first check that the router exists in the internal cache. If it doesn't, return. If it goes, then it goes to check if the router namespace(s) exist on the system (Why would they?), if not, it exits. There's two issues here: | 17:50 |
amuller | 1) You could have other resources on the system even without the namespace (Like processes) | 17:50 |
amuller | 2) Why would a router exist in the cache but not on the system? That can only happen in the functional testing suite, specifically because of the tests that simulate agent restarts | 17:51 |
marun | amuller: tell me about the router cache | 17:51 |
*** russellb has joined #openstack-neutron | 17:52 | |
marun | amuller: if the agent dies or is restarted in production, does the router cache persist? | 17:52 |
amuller | marun: self.router_info likes long walks and prefers dry red wine. It's favorite romantic era Czech composer is of course Tchaikovsky. | 17:52 |
*** jorgem has joined #openstack-neutron | 17:53 | |
amuller | marun: It's populated when the agent starts | 17:53 |
marun | amuller: so, agent dies | 17:53 |
*** jprovazn has joined #openstack-neutron | 17:53 | |
marun | amuller: lost cache | 17:53 |
marun | amuller: how does agent figure out the state of the system? | 17:53 |
marun | agent -> restarted agent | 17:53 |
amuller | marun: calls out to the controller when it starts to get all of the routers that are scheduled on it. It configures them, then deletes orphaned namespaces (Routers that were deleted when the agent was down basically) | 17:54 |
*** crc32 has joined #openstack-neutron | 17:54 | |
marun | amuller: so the agent does know how to manage resources, then. | 17:55 |
marun | amuller: in the context of a restart, anyway | 17:55 |
amuller | marun: OK, the term 'manage resources' in this context is very vague to me | 17:55 |
amuller | it means something to you, I don't know what it means to me | 17:55 |
*** cference_ has quit IRC | 17:56 | |
*** dttocs has quit IRC | 17:56 | |
*** nivtuckio has quit IRC | 17:56 | |
*** ijw has quit IRC | 17:58 | |
*** cference has joined #openstack-neutron | 17:58 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional/fullstack tests https://review.openstack.org/143412 | 17:58 |
*** ijw has joined #openstack-neutron | 17:59 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron-specs: Specification to run an L3 router without dedicated public IP https://review.openstack.org/175517 | 18:00 |
*** dguitarbite has quit IRC | 18:00 | |
*** dboik_ has joined #openstack-neutron | 18:01 | |
*** annegentle has joined #openstack-neutron | 18:01 | |
*** seizadi1 has joined #openstack-neutron | 18:02 | |
*** seizadi has quit IRC | 18:02 | |
*** zhhuabj_ has quit IRC | 18:03 | |
amuller | marun: So I don't know what to do about your comment, I don't know what change I could make to the agent that would make sense | 18:03 |
*** shashankhegde has joined #openstack-neutron | 18:03 | |
*** ijw has quit IRC | 18:03 | |
*** zhhuabj_ has joined #openstack-neutron | 18:03 | |
marun | amuller: I'm probably getting too esoteric (also am talking on another channel at the same time). | 18:04 |
openstackgerrit | Carl Baldwin proposed openstack/neutron-specs: Specification to eliminate the DVR fip ns https://review.openstack.org/174657 | 18:04 |
*** dboik has quit IRC | 18:05 | |
*** ijw has joined #openstack-neutron | 18:06 | |
*** alagalah has quit IRC | 18:08 | |
*** vishwanathj has quit IRC | 18:08 | |
*** vishwanathj has joined #openstack-neutron | 18:09 | |
*** jorgem has quit IRC | 18:09 | |
marun | amuller: I'd be happy if you could provide a clear indication of 'router missing' rather than requiring the caller to decide. | 18:09 |
*** rushil has quit IRC | 18:10 | |
*** zhhuabj_ has quit IRC | 18:11 | |
*** zhhuabj_ has joined #openstack-neutron | 18:11 | |
*** vishwanathj has quit IRC | 18:11 | |
*** vishwanathj has joined #openstack-neutron | 18:12 | |
*** alagalah has joined #openstack-neutron | 18:13 | |
*** sbalukoff has joined #openstack-neutron | 18:13 | |
*** vishwanathj has quit IRC | 18:16 | |
*** tsg has joined #openstack-neutron | 18:17 | |
*** zhhuabj_ has quit IRC | 18:18 | |
*** dboik_ has quit IRC | 18:19 | |
*** slaweq has quit IRC | 18:19 | |
*** ihrachyshka has quit IRC | 18:20 | |
*** zhhuabj_ has joined #openstack-neutron | 18:21 | |
*** irenab has quit IRC | 18:21 | |
*** vivek-eb_ has joined #openstack-neutron | 18:27 | |
*** vivek-ebay has quit IRC | 18:27 | |
*** zhhuabj_ has quit IRC | 18:30 | |
*** zhhuabj_ has joined #openstack-neutron | 18:31 | |
*** padkrish has joined #openstack-neutron | 18:33 | |
*** dboik has joined #openstack-neutron | 18:33 | |
*** ZZelle has joined #openstack-neutron | 18:33 | |
*** padkrish has quit IRC | 18:36 | |
*** padkrish has joined #openstack-neutron | 18:37 | |
*** padkrish has quit IRC | 18:37 | |
*** padkrish has joined #openstack-neutron | 18:37 | |
*** shivharis has joined #openstack-neutron | 18:38 | |
*** banix has quit IRC | 18:38 | |
*** sudipto has quit IRC | 18:40 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Replace BaseIPVethTestCase by FakeMachine https://review.openstack.org/160290 | 18:41 |
*** banix has joined #openstack-neutron | 18:41 | |
*** baoli has quit IRC | 18:41 | |
*** doude has quit IRC | 18:42 | |
*** ZZelle has quit IRC | 18:42 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Replace BaseIPVethTestCase by FakeMachine https://review.openstack.org/160290 | 18:43 |
*** nmagnezi_ has quit IRC | 18:43 | |
*** padkrish has quit IRC | 18:43 | |
*** seizadi1 has quit IRC | 18:44 | |
*** seizadi has joined #openstack-neutron | 18:44 | |
*** padkrish has joined #openstack-neutron | 18:44 | |
HenryG | dougwig: ping | 18:47 |
*** dboik has quit IRC | 18:48 | |
*** ZZelle has joined #openstack-neutron | 18:48 | |
*** rushil has joined #openstack-neutron | 18:49 | |
*** dannywilson has joined #openstack-neutron | 18:52 | |
*** sudipto has joined #openstack-neutron | 18:53 | |
*** shivharis has quit IRC | 18:54 | |
*** shivharis has joined #openstack-neutron | 18:54 | |
*** pradipta has quit IRC | 18:54 | |
*** imcsk8 has quit IRC | 18:54 | |
*** imcsk8 has joined #openstack-neutron | 18:54 | |
*** dannywilson has quit IRC | 18:56 | |
HenryG | marun: ping | 18:57 |
marun | HenryG: pong | 18:57 |
marun | pc_m: oh, pong | 18:57 |
pc_m | marun: hi | 18:57 |
*** dttocs has joined #openstack-neutron | 18:57 | |
*** dboik has joined #openstack-neutron | 18:57 | |
HenryG | marun: Do you know if the *aas repos will have API tests in their trees, or in the neutron tree? | 18:57 |
dougwig | HenryG: ack | 18:58 |
HenryG | dougwig: same question I asked marun ^^ | 18:58 |
dougwig | HenryG: they'll be moving into the *aas trees as soon as I can get some cycles to do so. | 18:58 |
dougwig | (or anyone else) | 18:58 |
marun | HenryG: they should have them in their own tree | 18:59 |
marun | HenryG: what dougwig said | 18:59 |
marun | pc_m: hi | 18:59 |
marun | HenryG: each repo should own their tests | 18:59 |
pc_m | marun: I'm stuck on https://review.openstack.org/#/c/168115/ and could use some help. For the StrongSwan job, which actually does some calls that use rootwrap, it is failing on the config file. | 18:59 |
*** sudipto_ has joined #openstack-neutron | 19:00 | |
pc_m | marun: I thought I had it figured out, but I guess not. The rootwrap config file and filters all seem to be placed in the right area, but I get a test failure. | 19:00 |
marun | pc_m: I recommended you not duplicate the script | 19:00 |
pc_m | marun: Which script? | 19:00 |
marun | pc_m: the neutron configure script | 19:00 |
*** zhhuabj_ has quit IRC | 19:01 | |
*** carlp has joined #openstack-neutron | 19:01 | |
pc_m | marun: well, there are some differences with what VPN needs, so just to get things working, I'm trying to copy the and get the script working. | 19:01 |
*** lori is now known as lori|away | 19:02 | |
*** zhhuabj_ has joined #openstack-neutron | 19:02 | |
*** dttocs has quit IRC | 19:02 | |
*** seizadi has quit IRC | 19:03 | |
HenryG | dougwig: what about neutron/tests/api/test_service_type_management.py ? | 19:03 |
*** seizadi has joined #openstack-neutron | 19:03 | |
HenryG | dougwig: Is that something that will stay in neutron? | 19:03 |
*** seizadi has quit IRC | 19:03 | |
*** seizadi has joined #openstack-neutron | 19:04 | |
*** seizadi has quit IRC | 19:04 | |
HenryG | dougwig: It currently has a skip on bug 1400370 | 19:04 |
openstack | bug 1400370 in neutron "Need to split advanced services out of neutron (placeholder bug to skip tempest tests temporarily)" [Medium,Confirmed] https://launchpad.net/bugs/1400370 - Assigned to Doug Wiegley (dougwig) | 19:04 |
dougwig | it think the service-type extension lives in neutron, doesn't it? | 19:04 |
*** seizadi has joined #openstack-neutron | 19:04 | |
dougwig | at the same time, neutron never has service providers by itself. | 19:04 |
pc_m | marun: any idea on the cause of the failure? | 19:05 |
marun | pc_m: where's the failure? | 19:05 |
*** jorgem has joined #openstack-neutron | 19:06 | |
HenryG | dougwig: Trying to figure out why it is skipping the (very rudimentary) test. I removed the skip and it works fine. | 19:06 |
pc_m | marun: It's just finishing the run... https://jenkins07.openstack.org/job/check-neutron-vpnaas-dsvm-functional-sswan/29/console | 19:06 |
dougwig | HenryG: might be cruft that it got left skipped | 19:06 |
pc_m | marun: /opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/bin/neutron-rootwrap-daemon: Incorrect configuration file: /opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/etc/neutron/rootwrap.conf | 19:07 |
marun | pc_m: I'm not sure what would cause that error | 19:07 |
HenryG | dougwig: do you know if more service-type management API tests are planned? We could remove the skip or delete that file since it doesn't really test anything useful. | 19:07 |
dougwig | is neutron a dependency in the tox env? | 19:07 |
dougwig | pc_m: ^^ | 19:07 |
dougwig | HenryG: none that I'm aware of. | 19:08 |
marun | pc_m: I'm not sure that file is saved as part of the run | 19:08 |
marun | (probably an oversight we should fix) | 19:08 |
marun | pc_m: it could be missing for all I know | 19:08 |
*** sudipto_ has quit IRC | 19:08 | |
*** sudipto has quit IRC | 19:08 | |
marun | pc_m: what happens when you try to run locally? | 19:08 |
*** slaweq has joined #openstack-neutron | 19:08 | |
*** aduarte has joined #openstack-neutron | 19:09 | |
pc_m | dougwig: yes neutron is a dependency in tox | 19:09 |
*** ijw has quit IRC | 19:10 | |
pc_m | marun: Well, it passes, but I had to tweak the gate-hook.sh as my dev tree is different (no '/opt/stack/new', no devstack under /opt/stack). I don't know how to run it without changing things. | 19:11 |
*** nplanel_ has joined #openstack-neutron | 19:11 | |
pc_m | marun: In looking at the log, it is placing the rootwrap.conf in the expected place, and trying to access it in the test. I'm baffled. | 19:12 |
HenryG | dougwig: OK, I am going to remove the skip so we can close the bug. Hopefully someone will add more useful tests later. | 19:12 |
*** zhhuabj_ has quit IRC | 19:13 | |
openstackgerrit | Merged openstack/neutron: Clarify the init logic for the ML2 plugin https://review.openstack.org/174555 | 19:13 |
pc_m | marun: The test failure is in PRRQ now (job finished). | 19:13 |
*** zhhuabj_ has joined #openstack-neutron | 19:13 | |
*** dboik_ has joined #openstack-neutron | 19:13 | |
*** dboik has quit IRC | 19:13 | |
*** yfried__ is now known as yfried|afk | 19:14 | |
*** tsg has quit IRC | 19:14 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove skip of service-type management API test https://review.openstack.org/175546 | 19:14 |
*** padkrish has quit IRC | 19:14 | |
marun | pc_m: I would suggest mirroring the environment in the gate locally | 19:15 |
*** padkrish has joined #openstack-neutron | 19:15 | |
marun | pc_m: that's the whole reason I wrote the configure script, so we didn't have to debug through a keyhole. | 19:15 |
pc_m | marun: ok. I'll try. | 19:15 |
marun | pc_m: I need to eat, I'll be back in a bit. | 19:15 |
pc_m | marun: ok. | 19:16 |
openstackgerrit | Merged openstack/neutron: Avoid double-hopping deletes for security group rules https://review.openstack.org/174666 | 19:16 |
openstackgerrit | Assaf Muller proposed openstack/neutron: Log caught exceptions while deleting a router https://review.openstack.org/175547 | 19:17 |
*** baoli has joined #openstack-neutron | 19:18 | |
*** ijw has joined #openstack-neutron | 19:18 | |
*** padkrish has quit IRC | 19:19 | |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Replace BaseLinuxTestCase by BaseSudoTestCase https://review.openstack.org/161913 | 19:19 |
*** baoli has quit IRC | 19:21 | |
*** nyechiel has joined #openstack-neutron | 19:21 | |
*** baoli has joined #openstack-neutron | 19:21 | |
*** padkrish has joined #openstack-neutron | 19:21 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: Log caught exceptions while deleting a router https://review.openstack.org/175547 | 19:22 |
*** ZZelle_ has joined #openstack-neutron | 19:22 | |
*** yfried|afk is now known as yfried__ | 19:22 | |
HenryG | arosen: ping | 19:23 |
*** shashankhegde has quit IRC | 19:24 | |
amuller | carl_baldwin: What do you think about this: https://review.openstack.org/#/c/175547/ | 19:25 |
*** nyechiel has quit IRC | 19:27 | |
carl_baldwin | amuller: reading... | 19:28 |
*** aix has quit IRC | 19:29 | |
*** ajmiller_ has joined #openstack-neutron | 19:29 | |
arosen | HenryG: pong | 19:31 |
carl_baldwin | Probably better to catch the exception and log it at least. | 19:31 |
carl_baldwin | amuller: ^ | 19:31 |
amuller | carl_baldwin: ack | 19:31 |
carl_baldwin | amuller: I’d hate to kick off a full sync in this case. Looks like you’ve avoided that. | 19:31 |
HenryG | arosen: https://review.openstack.org/171770 | 19:31 |
amuller | carl_baldwin: yeah that's partially why I did not set full_sync in the safe_delete method itself | 19:32 |
amuller | marun: Would you be content if I rebase https://review.openstack.org/#/c/175462/ on https://review.openstack.org/#/c/175547/, and have the functional test use the same method the agent itself uses? | 19:33 |
*** ajmiller has quit IRC | 19:33 | |
amuller | marun: instead of the functional test framework providing a safe delete method, the agent does | 19:33 |
*** ajmiller_ is now known as ajmiller | 19:34 | |
arosen | HenryG: k, let me fix that one up. | 19:34 |
HenryG | arosen: thanks | 19:34 |
*** annegentle has quit IRC | 19:36 | |
*** crose has joined #openstack-neutron | 19:37 | |
arosen | armax_: around? | 19:38 |
armax_ | arosen: yes | 19:38 |
amuller | marun: btw gongysh fixed up https://review.openstack.org/#/c/160430/ | 19:39 |
arosen | armax_: https://review.openstack.org/#/c/171770/1/neutron/db/db_base_plugin_v2.py | 19:39 |
arosen | replied | 19:39 |
*** nmagnezi_ has joined #openstack-neutron | 19:41 | |
armax_ | arosen: ok, what about the other comment I made, that was the actual reason for -1? | 19:42 |
*** nyechiel has joined #openstack-neutron | 19:42 | |
*** padkrish has quit IRC | 19:43 | |
armax_ | arosen: but hang on…I’d have to remember what I was thinking ;) | 19:43 |
armax_ | arosen: line 1256 seems to have the same conditional | 19:43 |
*** padkrish has joined #openstack-neutron | 19:43 | |
arosen | armax_: right I'll need to update that line too. | 19:43 |
armax_ | arosen: it’s said we spilled that logic in the base class | 19:44 |
armax_ | *sad | 19:44 |
arosen | I agree | 19:44 |
*** padkrish_ has joined #openstack-neutron | 19:45 | |
*** padkrish has quit IRC | 19:45 | |
*** ronis has quit IRC | 19:45 | |
*** luqas has joined #openstack-neutron | 19:46 | |
openstackgerrit | Aaron Rosen proposed openstack/neutron: _create_subnet_from_implicit_pool assumes external network extension https://review.openstack.org/171770 | 19:47 |
*** ajo has quit IRC | 19:49 | |
*** seizadi has quit IRC | 19:51 | |
*** luqas has quit IRC | 19:51 | |
*** seizadi has joined #openstack-neutron | 19:53 | |
*** nlahouti has quit IRC | 19:54 | |
*** shashankhegde has joined #openstack-neutron | 19:55 | |
*** shihanzhang has joined #openstack-neutron | 19:56 | |
*** tsg has joined #openstack-neutron | 19:56 | |
*** julim has quit IRC | 19:58 | |
*** liusheng has quit IRC | 19:58 | |
*** liusheng has joined #openstack-neutron | 19:59 | |
*** hanzhang has quit IRC | 19:59 | |
*** zhhuabj_ has quit IRC | 20:01 | |
*** amuller has quit IRC | 20:01 | |
*** zhhuabj_ has joined #openstack-neutron | 20:01 | |
*** jckasper has quit IRC | 20:04 | |
*** padkrish_ has quit IRC | 20:04 | |
*** dttocs has joined #openstack-neutron | 20:04 | |
*** padkrish has joined #openstack-neutron | 20:05 | |
openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Test patch to test dvr-multinode(*DO-NOT-MERGE*) https://review.openstack.org/175559 | 20:06 |
*** zhhuabj_ has quit IRC | 20:07 | |
* ijw is so disappointed in armax_ | 20:09 | |
armax_ | ijw: what did I do? | 20:09 |
ijw | Well, you didn't, that's the problem | 20:10 |
*** tsg has quit IRC | 20:12 | |
*** jprovazn has quit IRC | 20:13 | |
*** fawadkhaliq has joined #openstack-neutron | 20:19 | |
*** yfried__ is now known as yfried|afk | 20:20 | |
*** crose has quit IRC | 20:20 | |
*** zhhuabj_ has joined #openstack-neutron | 20:21 | |
openstackgerrit | Merged openstack/neutron: Replace custom method call logger with oslo.log helper https://review.openstack.org/168999 | 20:21 |
*** achanda has quit IRC | 20:22 | |
*** tsg has joined #openstack-neutron | 20:28 | |
openstackgerrit | Dane LeBlanc proposed openstack/neutron: Reuse callers session in ML2 DB methods https://review.openstack.org/173320 | 20:30 |
*** redbeard has joined #openstack-neutron | 20:33 | |
*** achanda has joined #openstack-neutron | 20:35 | |
*** tsg has quit IRC | 20:35 | |
*** zhhuabj_ has quit IRC | 20:37 | |
redbeard | dunno wether it is neutron related or not, but if I (in icehouse) associate a floating-ip while spawning/building an instance, it takes 10 minutes or more for "nova list" to know about the floating ip | 20:37 |
armax_ | ijw: I know, father duties got me tired at the end of the week, and the couch was so inviting that I gave in at the end:) | 20:38 |
*** jorgem has quit IRC | 20:39 | |
*** zhhuabj_ has joined #openstack-neutron | 20:39 | |
*** padkrish has quit IRC | 20:40 | |
*** jorgem has joined #openstack-neutron | 20:40 | |
*** padkrish has joined #openstack-neutron | 20:40 | |
*** padkrish_ has joined #openstack-neutron | 20:42 | |
*** padkrish has quit IRC | 20:42 | |
*** kevinbenton has joined #openstack-neutron | 20:43 | |
*** jorgem has quit IRC | 20:44 | |
*** kevinbenton has quit IRC | 20:44 | |
*** kevinbenton has joined #openstack-neutron | 20:44 | |
ijw | Children or beer? | 20:45 |
ijw | Honestly, you have all the easy choices... | 20:45 |
sc68cal | why not both? | 20:48 |
*** dboik has joined #openstack-neutron | 20:48 | |
*** padkrish_ has quit IRC | 20:50 | |
marun | redbeard: that might be a question for #openstack-nova | 20:51 |
*** dboik_ has quit IRC | 20:51 | |
*** nlahouti has joined #openstack-neutron | 20:52 | |
redbeard | marun, I think so too. thanks :) | 20:52 |
*** zhhuabj_ has quit IRC | 20:52 | |
marun | redbeard: nova's responsible for updating its cache, we can't influence that on the neutron side | 20:53 |
redbeard | mh, well. I see. neutron floating-ip-list gives me the correct output | 20:55 |
openstackgerrit | Adolfo Duarte proposed openstack/neutron: Refactoring to adhere to coding convention https://review.openstack.org/159230 | 20:55 |
*** annegent_ has joined #openstack-neutron | 20:55 | |
*** haleyb_ is now known as haleyb | 20:56 | |
*** rook_ has joined #openstack-neutron | 20:58 | |
*** jckasper has joined #openstack-neutron | 20:59 | |
*** akanksha has joined #openstack-neutron | 21:02 | |
*** zhhuabj_ has joined #openstack-neutron | 21:03 | |
*** slaweq has quit IRC | 21:06 | |
*** tiswanso has joined #openstack-neutron | 21:09 | |
openstackgerrit | Salvatore Orlando proposed openstack/neutron: Amend VMware NSX readme https://review.openstack.org/175574 | 21:10 |
*** rook_ has quit IRC | 21:11 | |
*** cgoncalves has quit IRC | 21:12 | |
*** padkrish has joined #openstack-neutron | 21:12 | |
*** jbell8 has joined #openstack-neutron | 21:12 | |
*** tiswanso has quit IRC | 21:16 | |
*** tiswanso has joined #openstack-neutron | 21:17 | |
*** banix has quit IRC | 21:19 | |
*** cference has quit IRC | 21:19 | |
*** moha_hunt has quit IRC | 21:20 | |
*** moshele has quit IRC | 21:22 | |
*** jgrimm is now known as zz_jgrimm | 21:25 | |
*** dboik has quit IRC | 21:26 | |
*** jaypipes has quit IRC | 21:26 | |
*** dboik has joined #openstack-neutron | 21:27 | |
*** cgoncalves has joined #openstack-neutron | 21:31 | |
*** rpothier has quit IRC | 21:33 | |
*** hichihara has joined #openstack-neutron | 21:34 | |
*** jbell8 has quit IRC | 21:44 | |
*** bjornar_ has quit IRC | 21:44 | |
*** tiswanso has quit IRC | 21:45 | |
*** tiswanso has joined #openstack-neutron | 21:45 | |
*** mwagner_lap has quit IRC | 21:46 | |
*** zhhuabj_ has quit IRC | 21:47 | |
ZZelle_ | marun, hi | 21:47 |
marun | ZZelle_: hi | 21:47 |
*** zhhuabj_ has joined #openstack-neutron | 21:47 | |
marun | ZZelle_: ah, recheck passed | 21:47 |
ZZelle_ | https://review.openstack.org/143412 survives jenkins checks :) | 21:47 |
*** nyechiel has quit IRC | 21:47 | |
marun | ZZelle_: I've +2'd, and will do the same for the descendents | 21:47 |
ZZelle_ | marun, thx | 21:48 |
marun | ZZelle_: we'll need a second like HenryG, armax_ or mestery to approve. | 21:48 |
*** shashankhegde has quit IRC | 21:48 | |
marun | ZZelle_: thank you for your patience. I'm hoping we can move a bit quicker this cycle | 21:48 |
marun | ZZelle_: I'm whittling away at my desire to get things perfect on merge. I think it's preferable to iterate faster and fix our mistakes as we go than try to anticipate them all. | 21:49 |
*** tsg has joined #openstack-neutron | 21:49 | |
*** yfauser has joined #openstack-neutron | 21:50 | |
*** yfauser has left #openstack-neutron | 21:50 | |
*** tiswanso has quit IRC | 21:50 | |
marun | ZZelle_: hi | 21:51 |
marun | https://review.openstack.org/#/c/130588/13/neutron/tests/unit/extensions/test_l3_ext_gw_mode.py | 21:51 |
marun | I'm not sure I understand why you would run x number of tests on a simple configuration change | 21:51 |
marun | ZZelle_: can't that change be tested in isolation? | 21:51 |
*** sripriya has joined #openstack-neutron | 21:51 | |
ZZelle_ | marun, let me look it's an old change | 21:52 |
marun | ZZelle_: I was just going through the list looking for more test-related changes. Should I not review? | 21:52 |
ZZelle_ | marun, it's a "feature" change not a test improvement | 21:53 |
marun | ZZelle_: I get that, but running x number of tests for a simple configuration change does not seem worth it | 21:53 |
marun | ZZelle_: The change should be isolated for testing purposes. | 21:53 |
*** yamahata has joined #openstack-neutron | 21:54 | |
*** busterswt has quit IRC | 21:54 | |
ZZelle_ | marun, only test_update_router_gw_* are required | 21:56 |
*** yamamoto has joined #openstack-neutron | 21:56 | |
marun | ZZelle_: right, so creating a new test case that runs all the tests in that class does not seem reasonable. | 21:56 |
ZZelle_ | marun, about 100lines for a unittest test stUP :| | 21:56 |
marun | ZZelle_: that's not a unit test :) | 21:56 |
ZZelle_ | s/stUP/setUp | 21:56 |
marun | ZZelle_: Isolate the targeted change - by refactoring if necessary - so that the test change is commensurate with the code change. | 21:57 |
ZZelle_ | ok | 21:57 |
marun | ZZelle_: If you want you can add a method like 'get_default_snat' and test that | 21:58 |
pc_m | marun: hi | 21:58 |
marun | ZZelle_: or maybe init_router_info()? It could init the dict and call setdefault() on it to set the default snat flag | 21:59 |
marun | pc_m: hi | 21:59 |
pc_m | marun: I reworked the configure_for_func_test.sh and tox.ini to be able to run under /opt/stack/new/... like the gate. I think it is working (I think is is still kludgey though). | 21:59 |
ZZelle_ | marun, good idea | 21:59 |
*** shashankhegde has joined #openstack-neutron | 22:00 | |
marun | pc_m: great! | 22:00 |
*** absubram has quit IRC | 22:00 | |
pc_m | marun: Current failure (different than what was seen before) is that a VPN script is importing net_helpers.py from neutron and it is trying to import ovs_lib, which doesn't exist. | 22:00 |
pc_m | marun: It says it cannot import, but the file is there... | 22:01 |
marun | pc_m: can you give me a github link to the import? | 22:02 |
openstackgerrit | Cedric Brandily proposed openstack/neutron: Correct inconsistent enable_snat management https://review.openstack.org/130199 | 22:02 |
pc_m | marun: here's the failure... http://paste.openstack.org/show/204926/ | 22:02 |
*** sripriya has quit IRC | 22:03 | |
*** seizadi has quit IRC | 22:03 | |
pc_m | marun: this is odd... | 22:03 |
*** seizadi has joined #openstack-neutron | 22:03 | |
*** banix has joined #openstack-neutron | 22:03 | |
pc_m | marun: In neutron repo the file exists... neutron.agent.linux ovs_lib | 22:04 |
*** sripriya has joined #openstack-neutron | 22:04 | |
marun | pc_m: which repo? | 22:04 |
*** seizadi has quit IRC | 22:04 | |
*** seizadi1 has joined #openstack-neutron | 22:04 | |
marun | pc_m: I don't see it there | 22:04 |
marun | https://github.com/openstack/neutron/tree/master/neutron/agent/linux | 22:04 |
marun | https://github.com/openstack/neutron/tree/master/neutron/agent/ovsdb | 22:04 |
marun | it's moved | 22:04 |
*** melwitt has quit IRC | 22:04 | |
pc_m | marun: Ah! I had a repo with it, but it was not under .tox/dsvm-functional-sswan/src/neutron/... | 22:05 |
marun | pc_m: you may want to 'tox -r' | 22:06 |
pc_m | so my env is old? | 22:06 |
*** yfauser has joined #openstack-neutron | 22:07 | |
*** Swami has quit IRC | 22:07 | |
*** dboik has quit IRC | 22:09 | |
*** ijw has quit IRC | 22:11 | |
*** dboik has joined #openstack-neutron | 22:11 | |
*** yfauser has quit IRC | 22:11 | |
*** yfauser has joined #openstack-neutron | 22:11 | |
*** yfauser has left #openstack-neutron | 22:11 | |
*** ijw has joined #openstack-neutron | 22:11 | |
*** zhhuabj_ has quit IRC | 22:12 | |
*** zhhuabj_ has joined #openstack-neutron | 22:13 | |
*** ijw has quit IRC | 22:16 | |
*** jbell8 has joined #openstack-neutron | 22:17 | |
*** redbeard has quit IRC | 22:17 | |
*** nmagnezi_ has quit IRC | 22:17 | |
pc_m | marun: I tried tox -r, but get a message "ERROR: unknown environment 'pylint'". I must have something wrong in the tox.ini file now. | 22:19 |
*** yfauser has joined #openstack-neutron | 22:19 | |
pc_m | marun: I did rm -rf .tox, and am trying again now. | 22:19 |
*** yfauser has left #openstack-neutron | 22:19 | |
*** jbell8 has quit IRC | 22:21 | |
*** sripriya has quit IRC | 22:22 | |
*** ijw has joined #openstack-neutron | 22:23 | |
*** fawadkhaliq has quit IRC | 22:24 | |
*** yfauser has joined #openstack-neutron | 22:24 | |
*** rook_ has joined #openstack-neutron | 22:24 | |
*** yfauser has left #openstack-neutron | 22:24 | |
*** tsg has quit IRC | 22:25 | |
*** rushil has quit IRC | 22:25 | |
marun | pc_m: tox -r requires an environment | 22:26 |
marun | pc_m: e.g. 'tox -r -e dsvm-functional' will recreate the tox env | 22:26 |
marun | pc_m: but removing .tox works as well | 22:26 |
pc_m | marun: duh... I'm geting tired, I guess... | 22:26 |
pc_m | marun: I still get the same error... it is accessing net_helpers.py in .tos area (/opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/src/neutron/neutron/tests/common/net_helpers.py) | 22:27 |
pc_m | marun: That is trying to import neutron.agent.linux ovs_lib, which doesn't exist in .tox path | 22:27 |
pc_m | marun: Looks like ovs_lib.py is in neutron/agent/common/ and not neutron/agent/linux. I don't know why net_helpers.py points to the wrong place. | 22:30 |
marun | pc_m: old code | 22:30 |
*** seizadi1 has quit IRC | 22:31 | |
*** seizadi has joined #openstack-neutron | 22:31 | |
*** achanda has quit IRC | 22:31 | |
pc_m | marun: I'm still confused... test code is accessing net_helpers.py from inside the .tox area. That file, is looking for ovs_lib.py in linux dir, but the file is in common dir in the same .tox area | 22:33 |
openstackgerrit | Maru Newby proposed openstack/neutron: Fix test discovery for api and functional paths https://review.openstack.org/171874 | 22:33 |
marun | pc_m: Isn't net_helpers simply importing a module that has moved? | 22:35 |
marun | pc_m: Updating the import in your tree should fix things. | 22:35 |
kevinbenton | carl_baldwin: i'm getting some pretty bad deadlocks while trying to add a subnet to a network that i'm also attaching ports to at the the same time | 22:36 |
kevinbenton | carl_baldwin: on the latest master | 22:36 |
kevinbenton | carl_baldwin: is this a known issue that someone is working on? | 22:36 |
kevinbenton | carl_baldwin: related to that create_port thread? | 22:37 |
*** jaypipes has joined #openstack-neutron | 22:37 | |
*** shwetaap has quit IRC | 22:38 | |
pc_m | marun: Correct. It appears net_helpers.py is importing from the wrong place. | 22:38 |
pc_m | marun: But net_helpers.py is not in the VPN tree. It is in the neutron tree. | 22:38 |
pc_m | marun: So it is broken in neutron. | 22:39 |
*** pradip has quit IRC | 22:39 | |
pc_m | https://github.com/openstack/neutron/blob/master/neutron/tests/common/net_helpers.py#L24 | 22:39 |
*** pradip has joined #openstack-neutron | 22:39 | |
pc_m | marun: Maybe this file is not tested? | 22:40 |
carl_baldwin | kevinbenton: I’m not aware. | 22:40 |
*** baoli has quit IRC | 22:40 | |
openstackgerrit | Dane LeBlanc proposed openstack/neutron: Reuse callers session in ML2 DB methods https://review.openstack.org/173320 | 22:40 |
*** Swami has joined #openstack-neutron | 22:41 | |
marun | pc_m: maybe? | 22:41 |
pc_m | marun: Am I loosing my mind? Wait don't answer that | 22:44 |
pc_m | marun: There seem to be several tests that use net_helpers import. | 22:45 |
marun | pc_m: that doesn't make a lot of sense, I agree. | 22:45 |
*** _cjones_ has quit IRC | 22:46 | |
*** wuhg has joined #openstack-neutron | 22:47 | |
marun | pc_m: That kind of thing sometimes can run locally due to stale pyc files, but that shouldn't happen in the gate. | 22:47 |
pc_m | marun: Yeah, I'm sort of shocked here... | 22:47 |
*** luqas has joined #openstack-neutron | 22:48 | |
marun | pc_m: I have it locally, I think I might be outdated. | 22:48 |
marun | pc_m: hold on | 22:48 |
marun | pc_m: ah, it was deleted recently | 22:49 |
marun | pc_m: ah... | 22:49 |
marun | pc_m: :/ | 22:49 |
*** _cjones_ has joined #openstack-neutron | 22:49 | |
marun | pc_m: I think our discovery problem masked the problem in a recent commit | 22:49 |
marun | pc_m: my change should fail the tests | 22:49 |
marun | https://review.openstack.org/#/c/171874/ | 22:49 |
marun | armax_: ^ | 22:49 |
pc_m | marun: that's what I was wondering - it the discovery problem was hiding this. | 22:50 |
armax_ | marun: way ahead of you :) | 22:50 |
armax_ | marun: for once | 22:50 |
openstackgerrit | Maru Newby proposed openstack/neutron: Fix test discovery for api and functional paths https://review.openstack.org/171874 | 22:50 |
marun | so, the rebased change should fail | 22:50 |
marun | I'll revise with a fix | 22:50 |
marun | armax_: you saw this problem? | 22:52 |
armax_ | marun: hang on, didn’t you change just the commit message? | 22:52 |
armax_ | marun: /me looks back | 22:52 |
*** luqas has quit IRC | 22:53 | |
marun | armax_: I rebased | 22:53 |
pc_m | marun: But the discovery is targeted to functional tests, not unit tests right? | 22:53 |
marun | armax_: a recent change removed neutron.agent.linux.ovs_lib, and some functional tests were importing it | 22:53 |
marun | armax_: that common path is used by the functional tests | 22:54 |
marun | oops, pc_m ^ | 22:54 |
pc_m | marun: ah. | 22:54 |
*** ijw has quit IRC | 22:54 | |
armax_ | marun: gotcha | 22:54 |
pc_m | marun: So my fucntional test, pulls in the net_helpers.py, which has an issue and is not seen because it is run only for functional tests. is that correct? | 22:55 |
armax_ | marun: I did that change I thought I had switched | 22:55 |
armax_ | marun: https://review.openstack.org/#/c/174179 | 22:55 |
marun | pc_m: it's not seen because the functional path is subject to the discovery bug | 22:56 |
armax_ | marun: oh…gotcha | 22:56 |
*** padkrish has quit IRC | 22:56 | |
marun | armax_: nasty bug, this one | 22:56 |
pc_m | marun: right. But net_helpers.py is not used in unit tests? | 22:56 |
marun | armax_: failing tests - no problem! | 22:56 |
armax_ | marun: the discoverabiltiy issue broke the functional tests without us realizing | 22:56 |
marun | armax_: multiple times | 22:57 |
*** annegent_ has quit IRC | 22:57 | |
*** padkrish has joined #openstack-neutron | 22:57 | |
armax_ | marun: well I was lazy enough to go and check where it was used darn | 22:57 |
marun | armax_: well, you relied on the tests working | 22:57 |
*** nplanel_ has quit IRC | 22:57 | |
marun | armax_: that's a pretty reasonable assumption | 22:57 |
marun | pc_m: no, we don't use it in unit tests | 22:57 |
marun | pc_m: I'm not sure why that's important | 22:57 |
armax_ | marun: but what I recall was that in tree we were already using the renamed version | 22:57 |
*** zhhuabj_ has quit IRC | 22:58 | |
armax_ | marun: do you have the patch where we fix the glitch? | 22:58 |
pc_m | marun: OK. that makes sense. I just was wondering why it wasn't seen yet. So only used by functional. | 22:58 |
marun | armax_: the module in question was updated by ZZelle_ recently | 22:58 |
marun | armax_: I'm working on it now | 22:58 |
armax_ | marun: ok understood | 22:58 |
*** zhhuabj_ has joined #openstack-neutron | 22:58 | |
armax_ | marun: ya | 22:59 |
armax_ | marun: the change came post rename | 22:59 |
*** seizadi has quit IRC | 23:00 | |
*** seizadi has joined #openstack-neutron | 23:00 | |
*** ijw has joined #openstack-neutron | 23:00 | |
*** padkrish has quit IRC | 23:01 | |
pc_m | marun: SO, are you fixing the import in the file as well? | 23:03 |
*** zhhuabj_ has quit IRC | 23:03 | |
*** zhhuabj_ has joined #openstack-neutron | 23:03 | |
*** aduarte has quit IRC | 23:04 | |
*** padkrish has joined #openstack-neutron | 23:05 | |
*** tflynn has quit IRC | 23:05 | |
*** yuanying has joined #openstack-neutron | 23:06 | |
ZZelle_ | armax_, can i help? | 23:06 |
armax_ | ZZelle_: in which regard? | 23:07 |
*** akanksha has quit IRC | 23:07 | |
ZZelle_ | about https://review.openstack.org/#/c/174179, iiuc | 23:07 |
ZZelle_ | ^^ | 23:08 |
marun | ZZelle_: I'm on it | 23:09 |
marun | ZZelle_: https://review.openstack.org/#/c/171874/ | 23:09 |
*** achanda has joined #openstack-neutron | 23:10 | |
pc_m | marun: thanks! Tomorrow, I'll retry VPN functional test, once this is in. | 23:10 |
marun | ZZelle_: pc_m cool | 23:11 |
marun | oops, sorry ZZelle_ | 23:11 |
openstackgerrit | Maru Newby proposed openstack/neutron: Fix test discovery for api and functional paths https://review.openstack.org/171874 | 23:11 |
*** jobewan has quit IRC | 23:12 | |
*** sicrano has quit IRC | 23:15 | |
*** pc_m has quit IRC | 23:17 | |
*** yamamoto has quit IRC | 23:18 | |
*** pradip has quit IRC | 23:18 | |
*** pradip has joined #openstack-neutron | 23:18 | |
*** achanda_ has joined #openstack-neutron | 23:18 | |
*** achanda_ has quit IRC | 23:18 | |
*** achanda_ has joined #openstack-neutron | 23:19 | |
*** achanda has quit IRC | 23:19 | |
lifeless | marun: hi | 23:21 |
lifeless | so https://review.openstack.org/#/c/171874/ is cleaner, but still doing the discovery-hack ? | 23:21 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Utilities for building/parsing netns names to facilitate testing https://review.openstack.org/175609 | 23:21 |
lifeless | marun: what prevent the tox based approach? | 23:21 |
*** seizadi has quit IRC | 23:21 | |
*** seizadi has joined #openstack-neutron | 23:21 | |
marun | lifeless: hi | 23:27 |
marun | lifeless: as per my comment on the review, if we discover all, and use filtering to narrow to subpaths, user filters won't work | 23:28 |
marun | lifeless: afaik, I'd be happy to hear differently | 23:28 |
marun | lifeless: is there a trick I'm missing? | 23:29 |
*** thedodd has joined #openstack-neutron | 23:30 | |
*** rm_work is now known as rm_work|away | 23:31 | |
*** padkrish has quit IRC | 23:32 | |
*** gildub has joined #openstack-neutron | 23:32 | |
*** padkrish has joined #openstack-neutron | 23:33 | |
*** dboik has quit IRC | 23:33 | |
*** arif-ali has quit IRC | 23:34 | |
*** chlong has joined #openstack-neutron | 23:34 | |
lifeless | marun: why wouldn't user filters work ? | 23:34 |
lifeless | marun: is it that they don't incrementally restrict? | 23:34 |
lifeless | marun: so the filter should be the users filter on its own, or the default filter. | 23:35 |
lifeless | (today) | 23:35 |
*** baoli has joined #openstack-neutron | 23:37 | |
marun | lifeless: the filters appear to be additive | 23:37 |
*** padkrish has quit IRC | 23:37 | |
*** shashankhegde has quit IRC | 23:37 | |
lifeless | marun: right, X || Y today | 23:38 |
marun | lifeless: so yes, they don't incrementally restrict | 23:38 |
lifeless | and there's no syntax to say 'give me an AND | 23:38 |
marun | lifeless: right. | 23:39 |
marun | lifeless: is that where the fix should go? vs allowing discover to accept multiple targets? | 23:39 |
lifeless | well | 23:39 |
lifeless | I think we should probably do all those things | 23:39 |
lifeless | I wanted to understand the change in direction in the patch is all | 23:39 |
marun | lifeless: ok | 23:40 |
lifeless | lets fix the current issue (missing tests) | 23:40 |
lifeless | and know I know whats needed to do something better in future. | 23:40 |
marun | lifeless: cool. | 23:41 |
*** marun has quit IRC | 23:42 | |
*** ZZelle_ has quit IRC | 23:42 | |
*** zhhuabj_ has quit IRC | 23:42 | |
*** crc32 has quit IRC | 23:43 | |
*** zhhuabj_ has joined #openstack-neutron | 23:43 | |
*** david-ly_ has joined #openstack-neutron | 23:44 | |
*** yfauser has joined #openstack-neutron | 23:45 | |
*** yfauser has left #openstack-neutron | 23:45 | |
*** jamielennox|away is now known as jamielennox | 23:45 | |
*** tsg has joined #openstack-neutron | 23:45 | |
*** david-ly_ is now known as david-lyle | 23:46 | |
*** jbell8 has joined #openstack-neutron | 23:50 | |
*** ajmiller has quit IRC | 23:51 | |
*** aranjan has quit IRC | 23:52 | |
*** igordcard has joined #openstack-neutron | 23:54 | |
*** yamamoto has joined #openstack-neutron | 23:55 | |
*** zhhuabj_ has quit IRC | 23:55 | |
*** aranjan has joined #openstack-neutron | 23:56 | |
*** annegentle has joined #openstack-neutron | 23:57 | |
*** openstackgerrit has quit IRC | 23:58 | |
*** openstackgerrit has joined #openstack-neutron | 23:58 | |
*** Murali has joined #openstack-neutron | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!