Friday, 2015-03-06

*** ivar-lazzaro has quit IRC00:01
*** pradip_vedams has quit IRC00:02
*** pradip_vedams has joined #openstack-neutron00:02
*** pradip_vedams has quit IRC00:03
*** pradip_vedams has joined #openstack-neutron00:04
*** achanda has quit IRC00:04
*** vivek-eb_ has quit IRC00:05
prometheanfirethis is why the length of the merge process sucks...00:05
prometheanfireThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.00:05
otherwiseguyprometheanfire: I feel your pain.00:08
*** vivek-eb_ has joined #openstack-neutron00:08
prometheanfirewe all feel the pain I think00:10
*** ZZelle has quit IRC00:10
*** markvoelker has quit IRC00:11
*** ivar-lazzaro has joined #openstack-neutron00:11
*** ZZelle has joined #openstack-neutron00:11
*** Sukhdev has quit IRC00:13
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: device driver and agent refactoring  https://review.openstack.org/16017900:14
*** dane_leblanc has quit IRC00:14
*** ivar-laz_ has joined #openstack-neutron00:16
*** ivar-lazzaro has quit IRC00:17
*** Marga_ has quit IRC00:18
*** bquan has quit IRC00:19
*** apuimedo has quit IRC00:20
*** pc_m has joined #openstack-neutron00:20
*** zzzeek has joined #openstack-neutron00:20
*** shaohe_feng has quit IRC00:20
*** dboik_ has quit IRC00:21
*** dboik has joined #openstack-neutron00:22
prometheanfirethat and jenkins randomly failing00:26
*** ruijing has joined #openstack-neutron00:26
*** yushiro has joined #openstack-neutron00:27
*** ZZelle_ has quit IRC00:28
*** tomoe_ has joined #openstack-neutron00:28
*** claudiub has quit IRC00:29
*** crc32 has quit IRC00:29
*** liusheng has quit IRC00:29
*** Marga_ has joined #openstack-neutron00:29
*** liusheng has joined #openstack-neutron00:29
openstackgerritAssaf Muller proposed openstack/neutron: Enable pylint on tests subdir  https://review.openstack.org/16195900:29
amullerarmax: I started working on that a couple of hours ago and by the time I was finished and hit git review the vmware and ofagent code was chucked00:30
amullerarmax: so, just so you know, there's some vmware unit test that has 'return' as its first line =D00:30
gusamuller: does it pass? ;)00:31
*** techcet has quit IRC00:31
amullerheh :)00:31
*** trad511 has quit IRC00:31
amullerthere was also a test that was calling a mock and then asserting that the same mock was called00:31
amullerThat also passed surprisingly00:31
amuller(It was also calling the mock with the wrong number of parameters)00:32
*** absubram has quit IRC00:32
gusfwiw, the vmware driver code has been where I've found most of the coding choices that were upsetting pylint.00:32
amulleryeah it found a few in the vmware test code, but the code is gone now anyway00:33
amullersomebody else's problem =D00:33
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook  https://review.openstack.org/16171400:34
*** techcet has joined #openstack-neutron00:34
gusamuller: so I'm not sure enabling pylint on tests is a good idea.  Using it to find/fix bugs in tests is obviously useful - but my concern is that allowing for the more exotic coding tricks that are "normal" in tests will prevent us from enabling stricter tests on the main codebase.00:34
gusurgh, I used the word tests in a potentially ambiguous way.00:35
amullergus: I understand what you mean00:35
amullerIt's a good point00:35
amullerThis patch doesn't add any exclusion00:35
*** rdo has quit IRC00:35
amullerI can imagine some angry commiter pushing a valid test, pylint coming up with a false positive and the commiter adding an exclusion00:35
amullerThat can be mitigated by reviewers but there's no certainty00:36
*** pc_m has quit IRC00:36
gusthis is when the other run_tests.sh change runs pylint on a freshly modified unittest file?00:36
amullerthat change is already merged00:37
amullerthe gate runs tox -e pep8 which runs pep8 and pylint on everything00:37
amullera commiter can manually invoke tox -e pep8 path/to/files00:37
amullerwhich will run flake8 on everything (I'll handle that) and pylint only on path/to/files00:37
gusoh right, but it runs pylint with no args which skips tests (thanks to pylintrc ignore)00:38
amullerbefore my patch yes00:38
amullerone serious downside to my proposal is that pylint takes at least twice as long now, and it's run as part of tox -e pep800:38
amullerso now tox -e pep8 takes a really long time00:38
amullerless people will run it00:38
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas: Insert validation in creating/updating firewall  https://review.openstack.org/14739600:38
amullerbut still00:38
HenryGarmax: around? The functional job on stable seem to be still broken.00:39
gusamuller: the one I'm thinking of is armax's change to run pylint on modified files only ... which I see has also merged.00:40
amullergus: yep00:40
amullerit doesn't do that by default though00:41
gusI was going to say we should make armax's script also skip files in tests and openstack.common.00:41
amullerunless I'm missing something00:41
*** achanda has joined #openstack-neutron00:41
*** leenheer has joined #openstack-neutron00:42
*** watanabe_isao has joined #openstack-neutron00:42
amullergus: maybe the default for tox -e pep8 should be to run flake8 and pylint only on modified files of current commit00:42
amullerand add an --all parameter00:42
gusamuller: yes, but ;)00:42
gusthe full set of pylint tests must be run by the gate checks, otherwise we won't catch cases where unmodified file is broken by a changed file.00:43
*** rdo has joined #openstack-neutron00:43
gusso if we make pep8 default to only modified files then we need to modify the pep8 gate check to invoke it in some other way.00:43
*** shivharis has quit IRC00:43
amullertrue00:43
*** shivharis has joined #openstack-neutron00:43
*** dims has quit IRC00:44
*** shivharis has quit IRC00:45
*** ivar-laz_ has quit IRC00:45
*** ivar-lazzaro has joined #openstack-neutron00:45
*** achanda has quit IRC00:46
openstackgerritBrian Haley proposed openstack/neutron: Change linux/ip_lib code to better handle address families  https://review.openstack.org/15755500:48
* gus is so appalled by the whole sudo-rootwrap thing.00:48
*** ivar-lazzaro has quit IRC00:48
gusthere are so many trivially abusable commands in the rootwrap filters files that nova/whatever user is trivially root-equivalent anyway.00:49
*** ivar-lazzaro has joined #openstack-neutron00:49
gusand now I look closer at the rootwrap code it's pretty easy to make it do things that wasn't intended (these are just bugs that could be fixed however).00:49
*** ijw has quit IRC00:49
*** signed8bit is now known as signed8bit_ZZZzz00:50
kevinbentonanteaya: hey, i saw on the review that you tried to reach out to me on IRC00:52
kevinbentonanteaya: when was that?00:52
amullergus: Do you know if I can enable an exclusion for a directory? I'd like to exclude bad-super-call on the tests dir00:52
anteayakevinbenton: this week00:53
gusI don't think that's possible without patching pylint.00:53
anteayaright after you answered my question about wanting the cla00:53
kevinbentonanteaya: ok, well the tags are good, thanks00:53
anteayaI asked a follow up question00:53
anteayathen twice more00:53
anteayaokay good00:53
amullergus: ack00:54
anteayaI didn't want to make a big deal about it in the review00:54
kevinbentonanteaya: i never got any of those messages on IRC00:54
anteayabut yes confirming that the author knows what is in the seed repo and wants them in that state is important to me00:54
anteayakevinbenton: really?00:54
anteayayour name was in channel00:54
anteayaI used tab complete00:54
anteayawhat are you using as a bouncer00:54
anteayaI asked for you in this channel00:55
kevinbentonanteaya: quassel00:55
anteayaI don't know it00:55
anteayado youusually get messages left for you in channel when you are offline?00:55
kevinbentonanteaya: it's possible that it came through and went far up the scrollback buffer followed by someone else pinging me00:55
kevinbentonanteaya: yes00:55
anteayaah00:55
kevinbentonanteaya: sorry for not responding00:55
anteayasee I use weechat00:55
anteayaso before I go offline I move the screen to a window that is the freenode windo00:55
anteayathen any ping in any channel alerts me00:56
anteayaso I scrollback until I find it00:56
*** shwetaap has joined #openstack-neutron00:56
anteayasince if I leave any channel open with I close the ssh connection I could miss the ping00:56
anteayaso yeah, no worries00:56
anteayaglad your seed repo is the way you wanted it00:56
*** amuller has quit IRC00:56
kevinbentonanteaya: thanks for the help. one quick question. is there a workflow doc somewhere for making new tags on the repo once it's in gerrit?00:57
anteayahmmmm00:57
* anteaya looks00:57
arif-alihi, does anyone know why the /var/lib/neutron/metadata_proxy file would not be created on the network node; been trying to debug this for approx a week00:58
anteayakevinbenton: give http://docs.openstack.org/infra/manual/drivers.html#tagging-a-release a test drive00:58
anteayakevinbenton: let me know how you do00:58
kevinbentonanteaya: thanks, i'll check it out00:59
*** tomoe_ has quit IRC00:59
anteayasure00:59
*** leenheer has quit IRC01:00
*** evgenyf has joined #openstack-neutron01:02
*** carl_baldwin has quit IRC01:02
*** xgerman has quit IRC01:03
*** mikedillion has joined #openstack-neutron01:03
*** sbalukoff has quit IRC01:03
*** shwetaap1 has joined #openstack-neutron01:05
*** mikedillion has quit IRC01:05
*** mikedillion has joined #openstack-neutron01:06
*** shwetaap has quit IRC01:08
*** tomoe_ has joined #openstack-neutron01:08
*** topshare has joined #openstack-neutron01:11
*** tomoe_ has quit IRC01:13
openstackgerritMerged openstack/neutron: Move _set_subnet_arp_info to dvr_router  https://review.openstack.org/15846001:13
*** ivar-laz_ has joined #openstack-neutron01:15
*** ivar-laz_ has quit IRC01:15
*** markvoelker has joined #openstack-neutron01:15
*** ivar-laz_ has joined #openstack-neutron01:16
*** fandi has joined #openstack-neutron01:16
*** aix has joined #openstack-neutron01:16
*** rwsu is now known as rwsu-afk01:17
openstackgerritMerged openstack/neutron: Move Neutron Policy pages into the tree  https://review.openstack.org/16179901:18
*** ivar-lazzaro has quit IRC01:18
*** pradip_vedams has quit IRC01:19
*** shaohe_feng has joined #openstack-neutron01:20
*** markvoelker has quit IRC01:20
*** melwitt has quit IRC01:22
*** tomoe_ has joined #openstack-neutron01:23
*** zzzeek has quit IRC01:23
*** shwetaap has joined #openstack-neutron01:23
openstackgerritAbhishek Raut proposed openstack/neutron: Cisco Nexus1000V ML2 Mechanism Driver  https://review.openstack.org/15724301:25
*** shwetaap1 has quit IRC01:25
*** tsg has quit IRC01:26
*** shwetaap has quit IRC01:26
*** tsg has joined #openstack-neutron01:26
*** bobmel has quit IRC01:27
*** sripriya has quit IRC01:27
*** bobmel has joined #openstack-neutron01:28
*** shwetaap has joined #openstack-neutron01:28
*** tomoe__ has joined #openstack-neutron01:28
*** r-daneel has quit IRC01:31
*** tomoe_ has quit IRC01:31
*** zhhuabj has joined #openstack-neutron01:32
*** xuhanp has joined #openstack-neutron01:32
*** fandi has quit IRC01:33
*** fandi has joined #openstack-neutron01:33
*** ruijing has quit IRC01:34
*** tsg has quit IRC01:37
*** stanzgy has joined #openstack-neutron01:38
*** stanzgy_ has joined #openstack-neutron01:38
*** manishg_ has quit IRC01:39
openstackgerritSukhdev Kapur proposed openstack/neutron: Arista L3 Service Plugin decomposition  https://review.openstack.org/16198401:40
*** manishg has joined #openstack-neutron01:40
*** vishwanathj has quit IRC01:40
*** vishwanathj has joined #openstack-neutron01:41
*** shwetaap has quit IRC01:41
*** popw has joined #openstack-neutron01:41
*** evgenyf has quit IRC01:42
*** mlavalle has quit IRC01:43
*** manishg has quit IRC01:44
*** techcet has quit IRC01:45
*** vishwanathj has quit IRC01:45
*** achanda has joined #openstack-neutron01:46
*** manishg has joined #openstack-neutron01:50
*** manishg_ has joined #openstack-neutron01:53
*** manishg__ has joined #openstack-neutron01:56
*** _cjones_ has quit IRC01:56
*** manishg has quit IRC01:57
*** rkukura has quit IRC01:57
*** SridharRamaswamy has quit IRC01:57
*** techcet has joined #openstack-neutron01:57
*** manishg_ has quit IRC01:58
*** manishg has joined #openstack-neutron02:01
*** manishg__ has quit IRC02:01
*** mikedillion has quit IRC02:02
*** techcet has quit IRC02:02
*** manishg has quit IRC02:04
*** ChuckC has quit IRC02:04
*** manishg has joined #openstack-neutron02:04
*** tiswanso has joined #openstack-neutron02:04
*** ChuckC has joined #openstack-neutron02:05
*** tiswanso has quit IRC02:05
*** tiswanso has joined #openstack-neutron02:05
*** erkules_ has joined #openstack-neutron02:07
openstackgerritItsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network  https://review.openstack.org/16194702:08
*** tiswanso has quit IRC02:08
*** tiswanso has joined #openstack-neutron02:09
*** manishg has quit IRC02:09
*** rkukura has joined #openstack-neutron02:09
*** erkules has quit IRC02:10
*** flwang has quit IRC02:10
*** manishg has joined #openstack-neutron02:13
*** tsg has joined #openstack-neutron02:14
*** shwetaap has joined #openstack-neutron02:14
*** oomichi has quit IRC02:14
*** flwang1 has joined #openstack-neutron02:15
*** ivar-laz_ has quit IRC02:16
openstackgerritSukhdev Kapur proposed openstack/neutron: Arista L3 Service Plugin decomposition  https://review.openstack.org/16198402:16
*** shaohe_robot has joined #openstack-neutron02:16
*** ivar-lazzaro has joined #openstack-neutron02:17
*** markvoelker has joined #openstack-neutron02:17
*** crc32 has joined #openstack-neutron02:17
*** manishg has quit IRC02:17
*** baoli has joined #openstack-neutron02:17
*** signed8bit_ZZZzz is now known as signed8bit02:18
*** signed8bit has quit IRC02:19
*** markvoelker has quit IRC02:21
*** ivar-lazzaro has quit IRC02:23
*** shaohe_robot is now known as shaohe_feng_onli02:24
*** ivar-lazzaro has joined #openstack-neutron02:24
*** shaohe_feng_onli is now known as shaohe_feng_02:24
*** ivar-lazzaro has quit IRC02:25
*** ivar-lazzaro has joined #openstack-neutron02:26
*** yamamoto has joined #openstack-neutron02:27
*** nlahouti has quit IRC02:30
openstackgerritSridar Kandaswamy proposed openstack/neutron-fwaas: FWaaS Insertion Model on Routers  https://review.openstack.org/15269702:33
*** catohornet has quit IRC02:36
*** zzzeek has joined #openstack-neutron02:37
*** tomoe__ has quit IRC02:38
*** tsg has quit IRC02:39
*** bandarji has quit IRC02:40
*** tomoe_ has joined #openstack-neutron02:40
*** zzzeek_ has joined #openstack-neutron02:42
*** zzzeek has quit IRC02:42
*** zzzeek_ is now known as zzzeek02:42
*** baoli has quit IRC02:43
*** zzzeek has quit IRC02:47
*** zzzeek has joined #openstack-neutron02:48
*** shwetaap1 has joined #openstack-neutron02:54
*** shaohe_feng has quit IRC02:54
*** ChuckC_ has joined #openstack-neutron02:56
*** leenheer has joined #openstack-neutron02:57
*** shwetaap has quit IRC02:57
*** amrith has left #openstack-neutron02:58
*** techcet has joined #openstack-neutron02:59
*** ChuckC has quit IRC02:59
*** baoli has joined #openstack-neutron03:02
*** techcet has quit IRC03:03
*** manishg has joined #openstack-neutron03:04
*** radez is now known as radez_g0n303:05
*** jckasper has joined #openstack-neutron03:11
*** yamahata has quit IRC03:12
*** ivar-lazzaro has quit IRC03:16
*** markvoelker has joined #openstack-neutron03:18
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394603:18
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024503:18
*** tomoe_ has quit IRC03:20
*** Murali has joined #openstack-neutron03:22
*** markvoelker has quit IRC03:22
*** ChuckC_ is now known as ChuckC03:27
*** leenheer has quit IRC03:32
openstackgerritItsuro Oda proposed openstack/neutron: Make floatingip reachable from the same network  https://review.openstack.org/16194703:34
*** anish__ has joined #openstack-neutron03:34
*** rkukura has quit IRC03:36
*** spandhe has quit IRC03:37
*** baoli has quit IRC03:42
*** david-lyle is now known as david-lyle_afk03:44
*** manishg has quit IRC03:45
*** bquan has joined #openstack-neutron03:45
*** manishg has joined #openstack-neutron03:45
*** vivek-eb_ has quit IRC03:46
*** fandi has quit IRC03:49
*** oomichi has joined #openstack-neutron03:51
*** baoli has joined #openstack-neutron03:53
*** Murali has quit IRC03:55
*** harlowja is now known as harlowja_away03:57
*** julim has quit IRC03:57
*** achanda has quit IRC03:57
openstackgerritBrandon Logan proposed openstack/python-neutronclient: Added call to retrieve the loadbalancer status tree  https://review.openstack.org/16200203:57
*** jckasper has quit IRC03:57
openstackgerritVijay Chundury proposed openstack/neutron: Replace IPv4 and IPv6 default addresses with constants  https://review.openstack.org/16078203:58
openstackgerritshihanzhang proposed openstack/neutron: Fix 'router_gateway' port status can't be updated  https://review.openstack.org/15150103:59
openstackgerritMerged openstack/neutron: Decouple L3 and VPN service plugins during router operations  https://review.openstack.org/15377603:59
*** techcet has joined #openstack-neutron04:01
*** anish_ has joined #openstack-neutron04:02
*** techcet has quit IRC04:05
*** anish__ has quit IRC04:06
*** Longgeek has joined #openstack-neutron04:08
*** mriedem_away has quit IRC04:10
*** mriedem has joined #openstack-neutron04:11
*** vivek-ebay has joined #openstack-neutron04:11
*** amotoki has joined #openstack-neutron04:16
gongysh_oda-g: hi04:17
oda-ggongysh_: hi04:17
gongysh_oda-g: is it https://review.openstack.org/161947 by you?04:18
oda-ggongysh_: yes04:19
*** markvoelker has joined #openstack-neutron04:19
*** SridharG has joined #openstack-neutron04:19
gongysh_oda-g: how do u know it is a regress bug by your previous patch?04:19
oda-ggongysh_: from my customer's test04:20
*** alexpilotti has quit IRC04:22
gongysh_oda-g: ok, but do u have an analysis how that your previous changes the traffic to lead to this bug?04:23
*** Marga_ has quit IRC04:24
*** markvoelker has quit IRC04:25
oda-ggongysh_: originally there are rules "--A neutron-l3-agent-snat -s <internal cidr> -j SNAT --to-source <gw-ip>"04:25
*** tiswanso has quit IRC04:27
*** baoli has quit IRC04:28
oda-ggongysh_: my previous patch replaces these to "-A neutron-l3-agent-snat -o <external interface> -j SNAT --to-source <gw-ip>"04:31
*** baoli has joined #openstack-neutron04:31
oda-ggongysh_: so SNAT toward internal interface is missing.04:32
*** anilvenkata has joined #openstack-neutron04:33
*** vmtrooper has joined #openstack-neutron04:33
*** marrusl has quit IRC04:35
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during delete operation  https://review.openstack.org/15547004:37
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during create/update operations  https://review.openstack.org/15377504:37
openstackgerritArmando Migliaccio proposed openstack/neutron: Decouple L3 and service plugins during DVR router migration  https://review.openstack.org/15474904:37
*** achanda has joined #openstack-neutron04:38
*** leenheer has joined #openstack-neutron04:39
*** leenheer has quit IRC04:40
*** manishg has quit IRC04:47
*** leenheer has joined #openstack-neutron04:47
*** leenheer has quit IRC04:48
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394604:52
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024504:52
*** yushiro has quit IRC04:53
*** achanda has quit IRC04:54
*** Murali has joined #openstack-neutron04:58
yamamotoarmax: ping04:58
yamamotoor any DVR folks around?04:59
*** oda-g has quit IRC05:03
*** watanabe_isao has quit IRC05:04
*** vivek-ebay has quit IRC05:06
*** baoli has quit IRC05:06
*** tomoe_ has joined #openstack-neutron05:09
*** SridharG has quit IRC05:15
*** gongysh_ has quit IRC05:16
*** shwetaap has joined #openstack-neutron05:16
openstackgerritRyan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool  https://review.openstack.org/15759705:17
*** zhenq has quit IRC05:18
*** shwetaap1 has quit IRC05:19
*** vmtrooper has quit IRC05:19
*** tidwellr has quit IRC05:19
*** oomichi has quit IRC05:20
*** Murali has quit IRC05:21
*** markvoelker has joined #openstack-neutron05:21
*** vmtrooper has joined #openstack-neutron05:21
*** markvoelker has quit IRC05:26
*** Trevor_V has joined #openstack-neutron05:27
*** gongysh_ has joined #openstack-neutron05:28
*** Trevor_V has quit IRC05:29
*** TrevorV|Home has joined #openstack-neutron05:29
*** Bhavya has joined #openstack-neutron05:33
*** SridharG has joined #openstack-neutron05:36
*** bquan has quit IRC05:36
*** Marga_ has joined #openstack-neutron05:39
*** Marga_ has quit IRC05:40
*** tomoe_ has quit IRC05:41
*** vmtrooper has quit IRC05:41
openstackgerritVijay Chundury proposed openstack/neutron: Replace IPv4 and IPv6 default addresses with constants  https://review.openstack.org/16078205:41
*** Marga_ has joined #openstack-neutron05:41
*** watanabe_isao has joined #openstack-neutron05:42
*** yushiro has joined #openstack-neutron05:43
*** numan has joined #openstack-neutron05:43
*** tflynn has quit IRC05:46
*** absubram has joined #openstack-neutron05:49
*** SridharG has left #openstack-neutron05:50
*** vivek-ebay has joined #openstack-neutron05:52
openstackgerritRomil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB  https://review.openstack.org/15389105:53
*** tomoe_ has joined #openstack-neutron05:53
*** achanda has joined #openstack-neutron05:56
*** yfried has joined #openstack-neutron05:56
*** vivek-ebay has quit IRC05:59
*** absubram has quit IRC05:59
*** lori|away is now known as lori06:00
garykmarkmcclain: you around? can you please look at https://review.openstack.org/#/c/161878/06:01
*** techcet has joined #openstack-neutron06:02
*** Networkn_ has quit IRC06:04
*** Networkn3rd has joined #openstack-neutron06:04
*** Networkn3rd has quit IRC06:05
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during delete operation  https://review.openstack.org/15547006:05
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during create/update operations  https://review.openstack.org/15377506:05
*** TrevorV|Home has quit IRC06:06
*** Networkn3rd has joined #openstack-neutron06:06
*** techcet has quit IRC06:06
*** vishwanathj has joined #openstack-neutron06:07
*** nlahouti has joined #openstack-neutron06:07
*** vishwana_ has joined #openstack-neutron06:08
*** armax has quit IRC06:09
*** Networkn3rd has quit IRC06:09
*** vishwanathj has quit IRC06:11
*** coolsvap_ has quit IRC06:11
*** Bsony has joined #openstack-neutron06:13
*** nlahouti has quit IRC06:14
*** nlahouti has joined #openstack-neutron06:14
openstackgerritOpenStack Proposal Bot proposed openstack/neutron: Imported Translations from Transifex  https://review.openstack.org/16161406:14
*** setuid has quit IRC06:15
*** Bsony has quit IRC06:17
*** Marga_ has quit IRC06:21
*** setuid has joined #openstack-neutron06:22
*** markvoelker has joined #openstack-neutron06:22
*** yushiro has quit IRC06:24
*** tomoe_ has quit IRC06:24
*** markvoelker has quit IRC06:27
*** yfauser has joined #openstack-neutron06:28
*** yfauser has left #openstack-neutron06:29
openstackgerritRyan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool  https://review.openstack.org/15759706:32
*** yog__ has joined #openstack-neutron06:37
*** pradipta has joined #openstack-neutron06:37
*** Longgeek has quit IRC06:39
*** SridharG has joined #openstack-neutron06:39
*** lennyb__ has quit IRC06:44
*** tflynn has joined #openstack-neutron06:47
*** tflynn has quit IRC06:51
*** phschwartz has quit IRC06:54
*** yushiro has joined #openstack-neutron06:55
*** tomoe_ has joined #openstack-neutron06:55
*** gildub has quit IRC06:55
*** phschwartz has joined #openstack-neutron06:57
*** Bsony has joined #openstack-neutron06:57
*** lazy_prince is now known as killer_prince06:58
*** tomoe_ has quit IRC07:00
*** yamahata has joined #openstack-neutron07:00
*** killer_prince is now known as lazy_prince07:03
*** techcet has joined #openstack-neutron07:04
yushiro07:06
*** techcet has quit IRC07:08
*** Networkn3rd has joined #openstack-neutron07:10
*** Networkn3rd has quit IRC07:14
*** jamielennox is now known as jamielennox|away07:16
openstackgerritpritesh proposed openstack/python-neutronclient: Adding VLAN Transparency support to neutronclient  https://review.openstack.org/16204007:17
openstackgerritZongKai LI proposed openstack/neutron: fix router schedule in dvr migrate case  https://review.openstack.org/15834907:18
*** ivar-lazzaro has joined #openstack-neutron07:18
*** Longgeek has joined #openstack-neutron07:19
*** kickinz1|afk is now known as kickinz107:21
*** ivar-lazzaro has quit IRC07:22
openstackgerritpritesh proposed openstack/neutron: Adding VLAN Transparency support for ML2 along with REST API changes  https://review.openstack.org/15842007:23
*** yamahata has quit IRC07:23
*** markvoelker has joined #openstack-neutron07:24
*** scheuran has joined #openstack-neutron07:27
*** markvoelker has quit IRC07:29
*** hichihara has quit IRC07:33
*** vthapar has joined #openstack-neutron07:34
*** Bsony has quit IRC07:36
*** apuimedo has joined #openstack-neutron07:39
openstackgerritKevin Benton proposed openstack/neutron: WIP: pecan install  https://review.openstack.org/16204407:40
openstackgerritKevin Benton proposed openstack/neutron: WIP: pecan install  https://review.openstack.org/16204407:41
*** kickinz1 is now known as kickinz1|afk07:41
*** kickinz1|afk is now known as kickinz107:42
openstackgerrityalei wang proposed openstack/neutron-fwaas: Implementation of Mcafee NGFW Driver  https://review.openstack.org/15209307:42
*** Longgeek has quit IRC07:43
*** achanda has quit IRC07:44
*** achanda has joined #openstack-neutron07:44
*** sbalukoff has joined #openstack-neutron07:45
*** mriedem has quit IRC07:47
*** mriedem has joined #openstack-neutron07:47
*** tflynn has joined #openstack-neutron07:47
*** achanda has quit IRC07:48
*** liusheng has quit IRC07:50
*** kawa2014 has joined #openstack-neutron07:50
*** liusheng has joined #openstack-neutron07:51
*** tflynn has quit IRC07:52
*** carlp has quit IRC07:53
*** tomoe_ has joined #openstack-neutron07:56
*** gongysh_ has quit IRC07:59
*** shwetaap has quit IRC07:59
*** tomoe_ has quit IRC08:00
*** tomoe_ has joined #openstack-neutron08:01
*** achanda has joined #openstack-neutron08:05
*** moha_hunt has joined #openstack-neutron08:06
*** carlp has joined #openstack-neutron08:06
openstackgerrityalei wang proposed openstack/neutron: Add portsecurity extension support  https://review.openstack.org/12655208:07
*** safchain has joined #openstack-neutron08:07
*** gongysh has joined #openstack-neutron08:11
*** chlong has quit IRC08:11
*** nlahouti has quit IRC08:13
*** SumitNaiksatam has quit IRC08:13
*** SumitNaiksatam has joined #openstack-neutron08:16
*** luqas__ has joined #openstack-neutron08:16
*** gongysh_ has joined #openstack-neutron08:17
*** yog__ has quit IRC08:22
*** krtaylor has quit IRC08:22
*** matrohon has joined #openstack-neutron08:24
*** ronis has joined #openstack-neutron08:24
*** markvoelker has joined #openstack-neutron08:25
*** devvesa has joined #openstack-neutron08:29
*** devvesa has quit IRC08:30
*** markvoelker has quit IRC08:31
*** karimb has joined #openstack-neutron08:35
*** krtaylor has joined #openstack-neutron08:35
*** setuid has quit IRC08:37
*** tomoe_ has quit IRC08:38
*** vthapar has quit IRC08:39
*** afazekas has joined #openstack-neutron08:39
*** watanabe_isao has quit IRC08:39
*** setuid has joined #openstack-neutron08:39
*** scheuran_ has joined #openstack-neutron08:40
*** scheuran has quit IRC08:43
*** jlanoux has joined #openstack-neutron08:44
*** crc32 has quit IRC08:46
*** aepifanov has joined #openstack-neutron08:47
*** jgrimm is now known as zz_jgrimm08:49
*** doude has joined #openstack-neutron08:49
openstackgerritElena Ezhova proposed openstack/neutron: test_wsgi: reduce code duplication and fix argument order in assertEqual  https://review.openstack.org/16205908:51
*** achanda has quit IRC08:54
*** krtaylor has quit IRC08:54
*** liusheng has quit IRC08:55
*** ygbo has joined #openstack-neutron08:55
openstackgerritElena Ezhova proposed openstack/neutron: Reduce code duplication and fix argument order in test_wsgi  https://review.openstack.org/16205908:55
*** liusheng has joined #openstack-neutron08:56
*** achanda has joined #openstack-neutron08:57
*** SumitNaiksatam has quit IRC08:58
*** Networkn3rd has joined #openstack-neutron08:59
*** tomoe_ has joined #openstack-neutron09:00
*** jistr has joined #openstack-neutron09:02
*** Networkn3rd has quit IRC09:03
*** jpena has joined #openstack-neutron09:03
*** erkules_ is now known as erkules09:04
*** ajo has joined #openstack-neutron09:05
*** devvesa has joined #openstack-neutron09:10
*** yamamoto has quit IRC09:10
*** krtaylor has joined #openstack-neutron09:10
*** achanda has quit IRC09:12
openstackgerritXu Han Peng proposed openstack/neutron: Fix dist_fip_count problem during router migration  https://review.openstack.org/15115309:13
*** achanda has joined #openstack-neutron09:13
*** achanda has quit IRC09:14
*** achanda has joined #openstack-neutron09:14
*** ronis has quit IRC09:15
openstackgerritXu Han Peng proposed openstack/neutron: Remove qg from router namespace for DVR migration  https://review.openstack.org/15118109:15
*** ronis has joined #openstack-neutron09:15
*** achanda has quit IRC09:19
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Fix validation of physical network name for flat nets  https://review.openstack.org/16084209:19
openstackgerritQin Zhao proposed openstack/python-neutronclient: Add InvalidIpForSubnetClient exception  https://review.openstack.org/16206209:22
*** SumitNaiksatam has joined #openstack-neutron09:26
openstackgerritPreeti Mirji proposed openstack/python-neutronclient: L2gateway cli extension testing  https://review.openstack.org/16206509:26
*** rotbeard has joined #openstack-neutron09:26
*** markvoelker has joined #openstack-neutron09:27
*** Longgeek has joined #openstack-neutron09:32
*** markvoelker has quit IRC09:33
*** ihrachyshka has joined #openstack-neutron09:33
*** saju_m has joined #openstack-neutron09:34
*** jistr is now known as jistr|biab09:36
*** blues-man has joined #openstack-neutron09:38
*** jp_at_hp has joined #openstack-neutron09:40
openstackgerritMerged openstack/neutron: Adding DB model changes for Nuage Plugin post decomposition  https://review.openstack.org/15928109:41
kevinbentonsalv-orlando: hi09:41
*** yfauser has joined #openstack-neutron09:42
*** yfauser has left #openstack-neutron09:42
openstackgerritMerged openstack/neutron: Updated from global requirements  https://review.openstack.org/16181509:43
openstackgerritKevin Benton proposed openstack/neutron: Big Switch Networks code split  https://review.openstack.org/16036009:43
*** tflynn has joined #openstack-neutron09:47
*** anish_ has quit IRC09:50
*** tflynn has quit IRC09:51
*** popw has quit IRC09:54
*** ihrachyshka has quit IRC09:57
salv-orlandohi kevinbenton09:58
kevinbentonsalv-orlando: had a question about a vmware unit test failure09:59
kevinbentonsalv-orlando: but i think the split that merged today may have changed that09:59
*** lazy_prince has quit IRC10:00
kevinbentonsalv-orlando: it seems there may be a legitimate timing issue here10:00
kevinbentonhttp://logs.openstack.org/60/160360/4/check/gate-neutron-python27/f6ddb1b/testr_results.html.gz10:00
*** killer_prince has joined #openstack-neutron10:00
salv-orlandokevinbenton: waiting for the page to load...10:01
*** killer_prince is now known as lazy_prince10:01
kevinbentonsalv-orlando: in that _destroy_metadata_access_network function add_router_interface is called in the exception handling without starting a new transaction10:01
kevinbentonsalv-orlando: so if the exception resulted in a rollback, i think the session can be stuck in a 'rollback called' state10:01
salv-orlandokevinbenton: thanks for analyzing that code!10:03
salv-orlandoif that is correct this should fail in this way always10:04
salv-orlandothe thing is that this unit test was coinceived to simulate this nested rollback situation10:04
salv-orlandoit's just that the failure mode should not have been this one.10:04
salv-orlandoI'm not sure if this has something to do with a recent change which does not play well with l3_dvr_db10:05
salv-orlandobut that's the only thing that can make any sense10:06
salv-orlandooh wait that code never went in master10:06
*** Longgeek has quit IRC10:06
kevinbentonit's not deterministic10:07
kevinbentoni've been trying to figure out the cause for several hours now10:07
salv-orlandokevinbenton: right. perhaps there is some racey problem which leads the metadata network handler to do the wrong thing10:07
salv-orlandobecause from _destory_metadata_access_network it should not call add_router_interface10:08
salv-orlandonot sure what triggers that10:08
kevinbentonsalv-orlando: i thought that is exactly what that was triggering?10:08
*** aepifanov has quit IRC10:08
salv-orlandoah yes it's the failure test sorry10:09
salv-orlandoI:q10:09
kevinbentonhttps://github.com/openstack/neutron/blob/2387f23f12fdc546df0a160ca791d00ce492a795/neutron/plugins/vmware/dhcp_meta/rpc.py#L20310:10
kevinbentonsalv-orlando: interestingly it seemed to be making it there in both the passing and failing condition10:11
kevinbentonsalv-orlando: so the difference was just in the state of context.session i believe10:11
*** Longgeek has joined #openstack-neutron10:14
*** topshare has quit IRC10:14
*** yog__ has joined #openstack-neutron10:15
salv-orlandokevinbenton: it might be. I just need to check whether I can do something to explicitly prevent sqlalchemy to deactivate the session.10:16
*** saikrishna has joined #openstack-neutron10:16
salv-orlandokevinbenton: it could be be because of those yields. I need to look back at the history of this module, but since the code is split anyway it does not matter. Also, I'm making all that logic asynchronous and running with its own db session10:21
salv-orlandoso I guess it does not really matter.10:21
kevinbentonsalv-orlando: ok, i just figured i would point it out in case it was indicative of some issue with the rollback logic there10:22
salv-orlandokevinbenton: I believe that for this matter we should stay on the safe side and non insist on performing reattaching the interface on rollback... anyway you're deleting the router so it does not really matter10:23
*** pask81 has joined #openstack-neutron10:23
*** liusheng has quit IRC10:23
salv-orlandoprobably there's no reason for making the delete process fail at all10:23
salv-orlandojust ignore and live with some dangling backend resources might be a better solution10:24
*** liusheng has joined #openstack-neutron10:24
kevinbentonsalv-orlando: oh, this is part of a larger router deletion process?10:25
salv-orlandoyeah the story is that you delete a router and in the process tears down the router's metadata network10:26
*** yuanying has quit IRC10:26
salv-orlandoand I this logic that fails the router deletion, and restores this metadata network in this case10:26
*** gildub has joined #openstack-neutron10:27
salv-orlandowhich probably does not make a lot of sense10:27
salv-orlandoobviously I need to go back into git history and understand why I did this in the first place10:27
kevinbentonoh, i see. to make it atomic-ish10:27
salv-orlandokevinbenton: yes, I wanted everything to be atomic because I did not want to leave stuff around (these objects are also actual admin-owned neutron objects)10:28
salv-orlandoI did everything synchronously because at that time it was the way everything in neutron was supposed to be done. But I never believed this operation should be synchronous. If nothing else because it makes some router operations 4x slower10:29
*** markvoelker has joined #openstack-neutron10:29
kevinbentonsalv-orlando: make sense10:30
kevinbentonsalv-orlando: makes*10:30
salv-orlandokevinbenton: btw, great work on the pecan switch!!!!10:33
openstackgerritXu Han Peng proposed openstack/neutron: Fix DB2 upgrade problem for Remove Hyper-V plugin  https://review.openstack.org/16208310:34
kevinbentonsalv-orlando: :(10:34
kevinbentonsalv-orlando: i don't have enough hours in the day10:34
kevinbentonsalv-orlando: i am in the process of quitting my job10:35
*** markvoelker has quit IRC10:35
kevinbentonsalv-orlando: and it has resulted in a lot of work10:35
*** carlp has quit IRC10:35
openstackgerritJian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols  https://review.openstack.org/16208410:35
salv-orlandokevinbenton: that's understandable.10:36
*** xuhanp has quit IRC10:36
*** ZZelle has quit IRC10:37
openstackgerritJian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols  https://review.openstack.org/15112810:37
kevinbentonsalv-orlando: i hope to clean up the stuff i was messing with and push something more substantial over the weekend10:39
*** jistr|biab is now known as jistr10:39
*** liusheng has quit IRC10:41
openstackgerritWaldemar Znoinski proposed openstack/neutron: Networking OVS-DPDK plugin decomposition  https://review.openstack.org/16208810:41
*** liusheng has joined #openstack-neutron10:42
openstackgerritJian LI proposed openstack/neutron: Add icmpv6 and remove None from sg_supported_protocols  https://review.openstack.org/15112810:45
*** Networkn3rd has joined #openstack-neutron10:47
*** stanzgy has quit IRC10:51
*** stanzgy_ has quit IRC10:51
*** Networkn3rd has quit IRC10:52
openstackgerritElena Ezhova proposed openstack/neutron: Prevent calling waitall() inside a GreenPool's greenthread  https://review.openstack.org/15732010:52
*** lazy_prince is now known as killer_prince10:56
openstackgerritSumit Naiksatam proposed openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo  https://review.openstack.org/16209910:57
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Test  https://review.openstack.org/16210010:57
*** dims has joined #openstack-neutron11:00
*** igordcard has joined #openstack-neutron11:04
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Refactor the ProcessMonitor API  https://review.openstack.org/15446411:09
openstackgerritAkihiro Motoki proposed openstack/neutron: NEC plugin code split  https://review.openstack.org/16210311:11
*** yog__ has quit IRC11:12
*** yamamoto has joined #openstack-neutron11:20
*** chlong has joined #openstack-neutron11:22
*** yamamoto has quit IRC11:24
*** markvoelker has joined #openstack-neutron11:31
*** markvoelker has quit IRC11:36
*** aepifanov has joined #openstack-neutron11:39
openstackgerritSumit Naiksatam proposed openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo  https://review.openstack.org/16209911:42
openstackgerritZongKai LI proposed openstack/neutron: fix router update for LegacyRouter to DvrRouter  https://review.openstack.org/16211711:42
*** aepifanov has quit IRC11:45
*** aepifanov has joined #openstack-neutron11:46
*** Bhavya has quit IRC11:46
*** tomoe_ has quit IRC11:46
*** lizk has quit IRC11:49
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Fix validation of physical network name for flat nets  https://review.openstack.org/16084211:49
*** luqas__ has quit IRC11:52
*** marrusl has joined #openstack-neutron11:55
*** Networkn3rd has joined #openstack-neutron11:56
*** yamamoto has joined #openstack-neutron11:58
*** pradipta has quit IRC11:59
*** Networkn3rd has quit IRC12:01
*** pc_m has joined #openstack-neutron12:01
*** yushiro has quit IRC12:02
*** Marga_ has joined #openstack-neutron12:07
openstackgerritZhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver  https://review.openstack.org/15856012:08
openstackgerritZhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention  https://review.openstack.org/14439112:08
*** techcet has joined #openstack-neutron12:09
*** alexpilotti has joined #openstack-neutron12:13
*** techcet has quit IRC12:14
*** yfauser has joined #openstack-neutron12:16
*** yfauser has left #openstack-neutron12:16
*** baoli has joined #openstack-neutron12:16
*** sambetts has quit IRC12:17
*** sambetts has joined #openstack-neutron12:17
*** johnbelamaric has quit IRC12:20
*** johnbelamaric has joined #openstack-neutron12:20
*** ZZelle has joined #openstack-neutron12:25
*** blues-man has quit IRC12:28
*** baoli_ has joined #openstack-neutron12:31
openstackgerritJohn Davidge proposed openstack/neutron: Implement Neutron IPv6 Prefix Delegation  https://review.openstack.org/15869712:31
*** markvoelker has joined #openstack-neutron12:32
*** gildub has quit IRC12:32
*** baoli has quit IRC12:34
*** markvoelker has quit IRC12:36
*** setuid has quit IRC12:37
*** setuid has joined #openstack-neutron12:38
*** aix has quit IRC12:38
*** yamamoto has quit IRC12:38
*** yamamoto has joined #openstack-neutron12:40
*** yamamoto has quit IRC12:46
*** raildo_away is now known as raildo12:48
*** saikrishna has quit IRC12:48
*** banix has joined #openstack-neutron12:48
*** saju_m has quit IRC12:50
*** yamamoto has joined #openstack-neutron12:51
*** banix has quit IRC12:56
*** Networkn3rd has joined #openstack-neutron12:56
*** Networkn3rd has quit IRC13:01
*** markvoelker has joined #openstack-neutron13:06
*** humble_ has joined #openstack-neutron13:06
*** yamamoto has quit IRC13:07
*** amuller has joined #openstack-neutron13:14
*** karmatronic has joined #openstack-neutron13:14
*** anilvenkata has left #openstack-neutron13:16
*** karimb has quit IRC13:17
*** techcet has joined #openstack-neutron13:25
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook  https://review.openstack.org/16171413:26
*** dane_leblanc has joined #openstack-neutron13:26
*** bobmel has quit IRC13:27
*** bobmel has joined #openstack-neutron13:27
*** aix has joined #openstack-neutron13:30
*** mwagner_lap has joined #openstack-neutron13:30
openstackgerritPavel Bondar proposed openstack/neutron: Introduce External IPAM Interface  https://review.openstack.org/13433913:37
*** banix has joined #openstack-neutron13:38
*** moha_hunt has quit IRC13:39
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook  https://review.openstack.org/16171413:39
*** karmatronic has quit IRC13:41
*** karimb has joined #openstack-neutron13:42
*** dboik has quit IRC13:43
*** radez_g0n3 is now known as radez13:46
*** SumitNaiksatam has quit IRC13:48
*** julim has joined #openstack-neutron13:52
*** Marga_ has quit IRC13:53
*** yamamoto has joined #openstack-neutron13:54
*** setuid has quit IRC13:55
*** thomasem has joined #openstack-neutron13:57
*** setuid has joined #openstack-neutron13:57
*** Marga_ has joined #openstack-neutron13:58
*** luqas__ has joined #openstack-neutron13:59
*** annegentle has joined #openstack-neutron13:59
*** blues-man has joined #openstack-neutron14:00
*** blues-man has quit IRC14:00
*** blues-man has joined #openstack-neutron14:00
*** annegentle has quit IRC14:00
*** annegentle has joined #openstack-neutron14:01
*** ihrachyshka has joined #openstack-neutron14:01
*** thomasem has quit IRC14:01
*** jamiec has quit IRC14:01
*** jamiec has joined #openstack-neutron14:01
*** thomasem has joined #openstack-neutron14:01
*** saju_m has joined #openstack-neutron14:03
*** Longgeek has quit IRC14:05
*** fifieldt_ has quit IRC14:05
mesteryajo: Do you know if kuba had code for this BP: https://blueprints.launchpad.net/neutron/+spec/new-iptables-driver14:07
*** zz_jgrimm is now known as jgrimm14:07
mesteryajo: There is no code and we're past the FPF now :(14:07
*** bjornar_ has joined #openstack-neutron14:07
*** dboik has joined #openstack-neutron14:07
mesteryajo: I'm going to move this out of Kilo now, but you folks cna propose an exception on the ML for htis if you have code ok?14:07
*** sc68cal_ has joined #openstack-neutron14:07
*** sc68cal_ has quit IRC14:07
*** sc68cal_ has joined #openstack-neutron14:07
*** dboik has quit IRC14:07
*** dboik_ has joined #openstack-neutron14:08
*** cference has joined #openstack-neutron14:08
*** jamiec has quit IRC14:09
*** sc68cal has quit IRC14:09
*** jamiec has joined #openstack-neutron14:09
*** salv-orl_ has joined #openstack-neutron14:09
*** salv-orlando has quit IRC14:09
ihrachyshkamestery, Kuba definitely does not have the code ready14:11
mesteryihrachyshka: Ack, moved out of Kilo then :)14:12
ihrachyshkamestery, and he is off to New Zealand till end of March14:12
*** Networkn3rd has joined #openstack-neutron14:12
mesteryihrachyshka: Wow, lucky guy! :)14:12
*** manishg has joined #openstack-neutron14:13
*** shwetaap has joined #openstack-neutron14:14
*** mriedem has left #openstack-neutron14:16
*** zhenq has joined #openstack-neutron14:16
*** shwetaap1 has joined #openstack-neutron14:16
*** Networkn3rd has quit IRC14:16
mesteryamotoki: Thanks for your help in marking those client bugs as "fix released", I appreciate that. :)14:16
*** saikrishna has joined #openstack-neutron14:17
amotokimestery: you made many various jobs :-)14:19
mesteryamotoki: :)14:19
*** Marga_ has quit IRC14:19
*** shwetaap has quit IRC14:20
amotokimestery: I got nasty cold from the weekend :-(  and in the latter half of the week I needed to spend queued internal items....14:20
*** Longgeek has joined #openstack-neutron14:20
*** signed8bit has joined #openstack-neutron14:21
mesteryamotoki: Get well my friend, colds are never that much fun.14:21
*** bjornar_ has quit IRC14:22
openstackgerritBaodong (Robert) Li proposed openstack/neutron: Implement Neutron IPv6 Prefix Delegation  https://review.openstack.org/15869714:22
amotokimestery: I remember I would like to ask you on neutronclient.14:23
mesteryamotoki: Sure! What about it?14:23
amotokimestery: do we use 2.4.0 or 2.3.12 for the next release?14:23
*** Murali has joined #openstack-neutron14:23
amotokiI see both milestones are open for targetting bugs.14:23
mesteryamotoki: I was thinking we'd wait until Kilo is out, then do a 2.4.0. What do you think?14:23
mesteryIf you agree, I'll remove the 2.3.12 milestone14:23
amotokimestery: 2.4.0 sounds good to me too.14:24
openstackgerritPavel Bondar proposed openstack/neutron: Implement IPAM Driver loader  https://review.openstack.org/14747914:24
amotokimestery: 2.4.0 is for Kilo?14:24
mesteryamotoki: OK, I'll remove 2.3.12 then.14:24
mesteryamotoki: I was thinking 2.4.0 for post-kilo, and we don't release another client until kilo ships. Sound ok?14:24
amotokimestery: we have some fixes for new features so I think we need at least one release for kilo.14:25
*** techcet has joined #openstack-neutron14:25
mesteryamotoki: OK, how about if we keep 2.3.12 for the last Kilo release of the client then? We just need to ensure no changes go into that one which are backwards incompatible14:26
amotokimestery: this is the reason I am a bit confused... I assumed we will have another release for kilo.14:26
mesterye.g. requirements changes14:26
mesteryamotoki: Does that make sense?14:26
amotokimestery: makese sense.14:26
mesteryamotoki: OK, cool. Thanks!14:26
*** kbringard has joined #openstack-neutron14:27
*** SumitNaiksatam has joined #openstack-neutron14:28
*** dansmith is now known as superdan14:30
*** techcet has quit IRC14:30
*** annegentle is now known as superanne14:31
*** chlong has quit IRC14:34
*** manishg has quit IRC14:36
openstackgerritAssaf Muller proposed openstack/neutron: Enable pylint on tests subdir  https://review.openstack.org/16195914:36
openstackgerritAssaf Muller proposed openstack/neutron: Remove 'free' exclusions from pylint  https://review.openstack.org/16217314:36
*** manishg has joined #openstack-neutron14:36
openstackgerritAssaf Muller proposed openstack/neutron: Remove 'free' exclusions from pylint  https://review.openstack.org/16217314:37
*** dims has quit IRC14:37
*** saju_m has quit IRC14:37
*** banix has quit IRC14:37
amullermestery: amotoki: HenryG: That last patch (https://review.openstack.org/162173) is a comprehensive list (Only 2, what can we do) of pylint exclusions that don't actually have any violations in the code14:38
*** dims has joined #openstack-neutron14:38
*** banix has joined #openstack-neutron14:38
*** tiswanso has joined #openstack-neutron14:38
*** manishg has quit IRC14:41
*** rushil_ has joined #openstack-neutron14:41
*** thomasem_ has joined #openstack-neutron14:41
*** ZZelle has quit IRC14:43
*** thomasem has quit IRC14:44
amotokiamuller: thanks for such cleanup :-)14:44
*** TrevorV|Home has joined #openstack-neutron14:44
*** alaski is now known as lascii14:44
*** lukasa_work has joined #openstack-neutron14:44
amulleramotoki: :) Going through the list of violations now, cleaning up some violations with low counts and removing the exclusions14:45
*** Networkn3rd has joined #openstack-neutron14:46
mesteryamotoki: Nice!14:47
*** Murali has quit IRC14:47
*** lukasa has quit IRC14:47
amotokinot amotoki but amuller :-)14:47
*** shwetaap1 has quit IRC14:48
*** boris-42 has quit IRC14:52
*** shwetaap has joined #openstack-neutron14:52
*** absubram has joined #openstack-neutron14:56
*** amotoki has quit IRC14:57
openstackgerritPavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM  https://review.openstack.org/15323614:58
*** absubram has quit IRC14:58
*** absubram has joined #openstack-neutron14:59
*** manishg has joined #openstack-neutron15:02
*** yfried has quit IRC15:04
*** haleyb has quit IRC15:05
*** haleyb has joined #openstack-neutron15:07
*** dims is now known as dimsum__15:07
*** igordcard has quit IRC15:08
*** radez is now known as radez_g0n315:12
*** jlanoux has quit IRC15:14
*** yfauser has joined #openstack-neutron15:14
*** yfauser has left #openstack-neutron15:15
*** armax has joined #openstack-neutron15:15
*** haleyb has quit IRC15:18
HenryGihrachyshka: ping15:19
*** changbl has quit IRC15:19
ihrachyshkaHenryG, pong15:19
HenryGihrachyshka: functional job in stable branches is still not working, it seems15:20
ihrachyshkaHenryG, right, infra is on it15:20
ihrachyshkaHenryG, potentially it's puppet not applied to jenkins15:20
ihrachyshkaHenryG, they are checking15:20
*** r-daneel has joined #openstack-neutron15:20
*** banix has quit IRC15:21
openstackgerritAssaf Muller proposed openstack/neutron: Enable pylint on tests subdir  https://review.openstack.org/16195915:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove non-parent-init-called pylint exclusion  https://review.openstack.org/16219015:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove access-member-before-definition pylint exclusion  https://review.openstack.org/16219115:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove no-method-argument pylint exclusion  https://review.openstack.org/16219215:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove duplicate-key pylint exclusion  https://review.openstack.org/16219315:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove expression-not-assigned pylint exclusion  https://review.openstack.org/16219415:22
openstackgerritAssaf Muller proposed openstack/neutron: Remove not-callable pylint exclusion  https://review.openstack.org/16219515:22
HenryGihrachyshka: thanks15:22
*** yfauser1 has joined #openstack-neutron15:23
*** yfauser1 has left #openstack-neutron15:23
*** marun has joined #openstack-neutron15:24
armaxihrachyshka: ping15:24
ihrachyshkaarmax, hi!15:25
armaxlooking at the functional job change15:25
armaxihrachyshka: I think that’s wrong15:25
armaxihrachyshka: now taht I look at it again15:25
armaxhttps://review.openstack.org/#/c/161569/2/jenkins/jobs/neutron.yaml15:25
armaxihrachyshka: it’s so painful to not being able to test before we roll out15:26
*** doude has quit IRC15:27
*** jlanoux has joined #openstack-neutron15:28
*** numan has quit IRC15:28
ihrachyshkaarmax, ok, then it's just a matter of puppet not applied, I hope15:28
armaxihrachyshka: I don’t think so actually15:28
*** techcet has joined #openstack-neutron15:29
*** changbl has joined #openstack-neutron15:32
*** tiswanso has quit IRC15:33
*** radez_g0n3 is now known as radez15:34
*** yamamoto has quit IRC15:34
*** techcet has quit IRC15:34
*** yamamoto has joined #openstack-neutron15:34
*** tiswanso_ has joined #openstack-neutron15:34
*** absubram has quit IRC15:35
*** tiswanso_ has quit IRC15:36
ihrachyshkasalv-orl_, may I ask you to look at comments at: https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py ?15:37
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Use accessors instead of private attributes for Ml2 plugin  https://review.openstack.org/16210015:39
*** lukasa_work has quit IRC15:40
*** lukasa_work has joined #openstack-neutron15:41
*** ChuckC_ has joined #openstack-neutron15:41
*** ChuckC has quit IRC15:42
*** tiswanso has joined #openstack-neutron15:43
*** zhhuabj has quit IRC15:43
*** zhhuabj has joined #openstack-neutron15:44
*** trinaths has joined #openstack-neutron15:45
*** trinaths1 has joined #openstack-neutron15:45
*** ChuckC_ has quit IRC15:46
*** manishg has quit IRC15:47
*** vishwana_ has quit IRC15:47
*** carlp has joined #openstack-neutron15:48
*** xgerman has joined #openstack-neutron15:49
*** SridharG has left #openstack-neutron15:49
*** trinaths has quit IRC15:49
openstackgerritRomil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB  https://review.openstack.org/15389115:51
*** lukasa_work has quit IRC15:52
*** lukasa has joined #openstack-neutron15:53
*** ronis has quit IRC15:53
*** lazy_prif has joined #openstack-neutron15:58
*** lazy_prif is now known as lazy_prince15:58
*** killer_prince has quit IRC15:58
*** superanne has quit IRC15:59
*** superanne has joined #openstack-neutron16:00
*** Miouge has joined #openstack-neutron16:02
openstackgerritZengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API  https://review.openstack.org/15961816:03
*** humble_ has quit IRC16:03
dboik_ihrachyshka: I just responded to your comment on https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py. I think your suggestion makes sense, and I'll upload a new patch soon.16:04
ihrachyshkadboik_, I hope it does! I wanted salv-orl_ to take a look since he introduced the quirk mentioned in the comment in the first place.16:05
openstackgerritMark Rawlings proposed openstack/python-neutronclient: Reinstate Max URI length checking to V2_0 Client  https://review.openstack.org/16092316:06
*** imcsk8 has quit IRC16:07
*** imcsk8 has joined #openstack-neutron16:07
dboik_ihrachyshka: Yes, that would be great. Want to make sure there aren't any other subtle bugs introduced, but this seems like it will work.16:07
*** superanne has quit IRC16:07
*** superanne has joined #openstack-neutron16:08
*** carl_baldwin has joined #openstack-neutron16:08
salv-orl_ihrachyshka: what did I break today?16:08
*** tyjawe has joined #openstack-neutron16:08
ihrachyshkasalv-orl_, no way!16:08
ihrachyshkasalv-orl_, just trying to get your valuable comments on https://review.openstack.org/#/c/158508/8/neutron/db/db_base_plugin_v2.py direction16:09
*** haleyb has joined #openstack-neutron16:10
salv-orl_ihrachyshka: I've just commented. Up to you to decide whether they're valuable or not16:11
*** flaviof has quit IRC16:11
*** vishwanathj has joined #openstack-neutron16:11
*** flaviof has joined #openstack-neutron16:12
*** ChuckC_ has joined #openstack-neutron16:12
*** jaypipes has joined #openstack-neutron16:14
*** jaypipes is now known as leakypipes16:14
*** techcet has joined #openstack-neutron16:15
*** moha_hunt has joined #openstack-neutron16:15
ihrachyshkasalv-orl_, to clarify: "having AUTO_DELETE_PORT_OWNERS as a dict". It's not clear how would dict apply there?16:17
*** pask81 has quit IRC16:18
*** bquan has joined #openstack-neutron16:19
dboik_salv-orl_, ihrachyshka: Thanks for taking a look. Actually, regarding the AUTO_DELETE_PORT_OWNERS, I was just going to do a filter(~_in(constants.ROUTER_INTERFACE_OWNERS)) on the query to check for all ports except router interfaces.16:19
*** techcet has quit IRC16:20
ihrachyshkadboik_, actually, leaving refactoring for a separate patch is probably a good thing16:21
ihrachyshkadboik_, that's since we may want to backport the fix16:22
salv-orl_ihrachyshka: a dict with different values according to the subnet addressing mode. I'm not sure if it's feasbile, just an idea16:23
*** krtaylor has quit IRC16:23
ihrachyshkadboik_, I'm looking thru the patch again to make sure no issues are there16:23
ihrachyshkasalv-orl_, got it16:24
anteayaHenryG: okay I'm looking at that patch16:24
*** dprince has joined #openstack-neutron16:24
anteayaHenryG: help me out here by telling me what fixed looks like16:24
anteayafix this job could mean anything to me16:24
anteayayou want it to run on stable branches?16:24
*** shivharis has joined #openstack-neutron16:24
anteayayou don't want it to run on stable branches?16:24
anteayafixed can be anything16:24
dprinceHello all. Could I get some eyes on this: https://review.openstack.org/#/c/141044/16:25
anteayaHenryG: https://review.openstack.org/#/c/161569/16:25
anteayahey dprince16:25
dprince^^ that regression has been up for 2 weeks and breaks all of our TripleO CI jobs using Ironic16:25
*** aepifanov has quit IRC16:25
*** scheuran_ has quit IRC16:25
dprincenote that we've been cherry picking the revert to keep things working for over a week now...16:26
*** banix has joined #openstack-neutron16:27
dprinceanteaya: hi :)16:27
*** garyk has quit IRC16:28
HenryGanteaya: Hi, thanks for getting back to me.16:28
anteayaHenryG: so where do we stand?16:28
dprinceihrachyshka: ^^^ might you have a look at that?16:28
anteayafor me to march along beside you I really need to know what the name of the mountain is we are trying to scale together16:28
ihrachyshkadprince, there was a bug for revert, right?16:28
*** aleksandr_null has quit IRC16:29
dprinceihrachyshka: yes, here https://bugs.launchpad.net/tripleo/+bug/142183516:29
openstackLaunchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [High,In progress]16:29
HenryGanteaya: clarkb and others are already on it, here is the latest: https://review.openstack.org/16219916:29
anteayawonderful, I hadn't gotten that far in the logs yet16:30
anteayaand having some content in the commit message body about _why_ you are doing this would be helpful16:30
anteayaHenryG: but if you want to try this setting, fine with me as neutron is the only project affected by this16:31
*** aleksandr_null has joined #openstack-neutron16:32
*** ParsectiX has joined #openstack-neutron16:32
*** amotoki has joined #openstack-neutron16:33
*** sripriya has joined #openstack-neutron16:33
openstackgerritRyan Tidwell proposed openstack/neutron: Basic subnetpool CRUD  https://review.openstack.org/14869816:33
*** chlong has joined #openstack-neutron16:33
openstackgerritRyan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool  https://review.openstack.org/15759716:33
*** krtaylor has joined #openstack-neutron16:35
*** techcet has joined #openstack-neutron16:37
ihrachyshkadprince, trying to understand how it could influence dhcp... is there something special that I need to know about neutron ports in tripleO? do they use some special states that are different from usual usage?16:40
dprinceihrachyshka: let me get more info... just digging into it today but it appears to be required to make things work16:41
*** criptoverso1 has quit IRC16:41
*** wverdugo500 has joined #openstack-neutron16:41
*** wverdugo500 has left #openstack-neutron16:42
*** busterswt has joined #openstack-neutron16:43
*** nlahouti has joined #openstack-neutron16:43
*** _cjones_ has joined #openstack-neutron16:43
*** _cjones_ has quit IRC16:43
*** _cjones_ has joined #openstack-neutron16:44
*** sthillma has joined #openstack-neutron16:44
*** sthillma has quit IRC16:47
ihrachyshkadprince, aha, I think I see the issue, but I need your help to get complete picture. so as I see, regression is because if dhcp options were updated, and _bind_port_if_needed is called with need_notify=True, we may now miss the notification if port fails to bind16:47
ihrachyshkadprince, the question is: were those ports supposed to fail to bind?16:47
*** devvesa has quit IRC16:48
*** sthillma has joined #openstack-neutron16:48
*** Marga_ has joined #openstack-neutron16:49
ihrachyshkadprince, do we have logs from tripleO failures?16:50
*** yfauser has joined #openstack-neutron16:50
ChuckC_ihrachyshka: I know that vif_type is always BINDING_FAILED for ironic server ports, if that's relevant16:51
*** kawa2014 has quit IRC16:51
openstackgerritAssaf Muller proposed openstack/neutron: Allow tools/coding-checks.sh to run flake8 on specific commits  https://review.openstack.org/16222116:52
salv-orl_ihrachyshka: rgith the logs would quickly tells us if we're  hitting "Failed to commit binding results for".16:52
*** yamahata has joined #openstack-neutron16:52
ihrachyshkaChuckC_, that's very relevant16:53
*** boris-42 has joined #openstack-neutron16:53
ihrachyshkaChuckC_, oh well, it's ironic, not tripleO16:53
ihrachyshkais it the same thing there?16:53
shivharismestery: hi, ready to bother you again16:53
*** yfauser has left #openstack-neutron16:54
salv-orl_ihrachyshka: well, if the overcloud is bare metal16:54
ChuckC_ihrachyshka: probably, but hopefully dprince can verify16:54
salv-orl_it might be that's been relying so far on the binding to be in failed status to work crrectly16:55
*** sambetts has quit IRC16:55
ChuckC_salv-orl_: I suspect not, but maybe I'm just hopeful16:56
ihrachyshkayamamoto, ping. is https://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ofagent/agent/ofa_neutron_agent.py left from oversight?16:57
openstackgerritArmando Migliaccio proposed openstack/neutron: Test the shiny new WeightScheduler  https://review.openstack.org/16223116:57
*** sambetts has joined #openstack-neutron16:57
salv-orl_ChuckC_: better not take anything for granted!16:57
ChuckC_salv-orl_: sure :)16:57
*** Miouge has quit IRC16:58
yamamotoihrachyshka: it seems so.  probably due to merge botches.  thank you.16:59
*** tyjawe has quit IRC16:59
*** techcet has quit IRC16:59
openstackgerritIhar Hrachyshka proposed openstack/neutron: ofagent: kill the left over after decomposition  https://review.openstack.org/16223416:59
ihrachyshkayamamoto, ^^16:59
*** shivharis has quit IRC17:00
*** changbl has quit IRC17:00
yamamotoihrachyshka: thank you17:01
*** techcet has joined #openstack-neutron17:01
openstackgerritArmando Migliaccio proposed openstack/neutron: DHCP Service LoadBalancing Scheduler  https://review.openstack.org/13701717:02
openstackgerritArmando Migliaccio proposed openstack/neutron: Test the shiny new WeightScheduler  https://review.openstack.org/16223117:02
amullermarun: Morning17:03
marunamuller: morning17:04
amullermarun: I'm trying to kill run_tests.sh. I moved run_tests.sh -8 like functionality to coding-checks.sh (https://review.openstack.org/#/c/162221/)17:04
amullerquestion is if post-mortem debugging can be accomplished with tox17:05
amulleror another non-run_tests.sh method17:05
*** jlanoux has quit IRC17:05
marunamuller: I do my pm debugging in emacs, so I'm probably not the right person to ask17:05
yamamotowho can change bp status?17:05
marunamuller: funny how much bash work we're doing... and here I thought this was a python project!17:06
marun(or ash, for those who care more than I do)17:06
amullermarun: Yeah and I'm the worst with Bash, fun17:06
marunamuller: shame that it's so pervasive17:07
marunamuller: like javascript of userspace17:07
marunamuller: or is javascript the shell of the browser?17:07
amullerwow if someone shows me an app written with a combination of javascript and bash I'd throw up17:08
marunamuller: I worry that we're just going to end up rewriting run_tests.sh into a bunch of smaller helpers :/17:08
*** superanne has quit IRC17:08
marunamuller: probably doesn't make much sense given that js doesn't have a concept of an fs17:08
amullerafaik the only useful thing that remains in run_tests.sh is the -8 thing, and possibly post mortem debugging which I'm figuing out now if it can be done otherwise17:09
*** sthillma has quit IRC17:09
*** b3nt_pin has quit IRC17:09
marunamuller: I wish that were true, but everytime we try to kill it we get pushback17:09
amullerand it looks like it is17:09
amullerlast time those were the only two usages that popped up17:09
marunamuller: I mean, I'm supportive of what you're trying to do.17:09
marunamuller: really?17:09
amullerdougwig: ^17:09
amulleryep17:09
amullerDoug was the last one to try :)17:09
marunamuller: so the cost of maintaining venvs wasn't an issue anymore?17:10
amullerI didn't see complaints about that17:10
ChuckC_yamamoto: if code has not been released yet, perhaps changing implementation would work, assuming you want to change status from complete to perhaps started?17:10
marunamuller: that was a pretty longstanding complaint - that running tests with tox with its sdist cost took too long17:10
amullerLet me wipe a tear off my cheek17:10
amullercommon17:11
marunamuller: my dev env consists of neutron installed editable along with its test dependencies via pip install --user17:11
marunamuller: I'm not sure why anyone would develop with tox, frankly.  it's a before-push check for me17:12
yamamotoChuckC_: this bp is done now https://blueprints.launchpad.net/neutron/+spec/ofagent-flow-based-tunneling17:12
*** rotbeard has quit IRC17:12
ChuckC_yamamoto: did it go out in kilo-2 or earlier?17:12
yamamotoChuckC_: last change has been merged today17:13
ChuckC_yamamoto: just change implementation to 'in progress', i think17:13
ChuckC_yamamoto: are you able to?17:14
yamamotoChuckC_: i made it implemented17:14
dprinceihrachyshka: getting fresh logs now...https://review.openstack.org/#/c/162212/17:14
dprinceihrachyshka: and yes, this is TripleO (which uses Ironic for baremetal provisioning)17:15
*** ronis has joined #openstack-neutron17:15
ihrachyshkadprince, are overcloud ironic?17:15
* ihrachyshka thinks those who chose the names are geniuses17:15
dprinceihrachyshka: no, only the undercloud17:15
ChuckC_yamamoto: what are you trying to accomplish?17:15
dprinceihrachyshka: undercloud uses Ironic for baremetal provisioning. And only it gets broken by this issues17:16
ihrachyshkadprince, hm, but ports that fail belong to undercloud then?17:16
dprinceihrachyshka: correct.17:16
ihrachyshkaPXE probably means it's for ports that bootstrap overcloud17:16
dougwigamuller, marun - fyi, the feedback when I tried to kill it last year.17:16
ihrachyshkaok, then it makes a lot of sense17:16
dprinceihrachyshka: undercloud deploys the overcloud17:16
yamamotoChuckC_: i wanted to notify the appropriate party the bp is done17:17
amullerdougwig: https://review.openstack.org/#/c/140139/?17:17
*** safchain has quit IRC17:17
ChuckC_yamamoto: oh, ok that's it then :)17:17
ihrachyshkadprince, I will check in next half an hour whether I can come up with a fix that is not a revert. will you be able to test it somehow in your env?17:19
*** changbl has joined #openstack-neutron17:20
dprinceihrachyshka: yes, but I'd have to do it manually17:21
dprinceihrachyshka: I'm fine w/ a roll forward fix, but in general I really hate to see a revert like this sit around (for almost to weeks in this case)17:21
openstackgerritIhar Hrachyshka proposed openstack/neutron: Migrate to oslo.log  https://review.openstack.org/15963817:22
openstackgerritMerged openstack/neutron: Remove references to 0.0.0.0/0 in iptable rules  https://review.openstack.org/16121417:22
dprinceihrachyshka: reverts are very safe...17:22
anteayaarmax: smart guy17:22
*** armax has quit IRC17:22
dprinceihrachyshka: sometimes with roll forward fixes there can be other side effects17:22
*** ajo has quit IRC17:22
ihrachyshkadprince, I'm fine with revert either way, though I wouldn't help you in any case since I don't have +2 hammer, yet :)17:22
*** sripriya has quit IRC17:23
dprinceihrachyshka: understood, and appreciate the help17:23
*** manishg has joined #openstack-neutron17:23
ihrachyshkasalv-orl_, HenryG: can we merge revert of a patch that breaks tripleo: https://review.openstack.org/#/c/156853/2 ? I think I know how to fix it properly, but it's better to revert to unblock their team first17:23
*** shwetaap has quit IRC17:25
*** shwetaap has joined #openstack-neutron17:25
*** matrohon has quit IRC17:27
HenryGihrachyshka: looking17:27
salv-orl_I love reverting stuff17:28
ihrachyshkaHenryG, so the problem is that ironic (that runs undercloud) uses BINDING_FAILED ports. And we miss notification to dhcp agent about dhcp options update due to the patch that is reverted17:28
ihrachyshkathe fix would be to notify if need_notify==True even if binding attempt failed17:29
*** Marga_ has quit IRC17:29
*** luqas__ has quit IRC17:29
salv-orl_ihrachyshka: I am on board with the plan the original bug fixed by the patch being reverted does not seem critical. Do we have logs or anything else proving the revert is actually successfull? This would be good to have to justify the action wrt the rest of the community17:30
*** mlavalle has joined #openstack-neutron17:30
*** igordcard has joined #openstack-neutron17:30
ihrachyshkasalv-orl_, tripleo failing without revert of the patch in their CI not enough?17:31
*** blues-man has quit IRC17:31
openstackgerritOpenStack Proposal Bot proposed openstack/neutron: Updated from global requirements  https://review.openstack.org/16224817:32
*** rwsu-afk is now known as rwsu17:33
*** claudiub has joined #openstack-neutron17:34
*** arif-ali has quit IRC17:34
salv-orl_ihrachyshka:  tripleo does not gate with neutorn, I wanted a link to a job run or something lke that. but people can look at the bug report17:34
salv-orl_if people are lazy it's not our problem, I gues17:34
*** vivek-ebay has joined #openstack-neutron17:35
salv-orl_ihrachyshka, dprince: one last question... as the offending patch merged on feb13th, has tripleo gate been broken for 3 weeks?17:36
ihrachyshkasalv-orl_, they carried a revert with their CI17:36
*** jistr has quit IRC17:37
salv-orl_ihrachyshka: got it17:37
dprincesalv-orl_: http://git.openstack.org/cgit/openstack-infra/tripleo-ci/commit/?id=f90760f425ec6c80da12ebee4922d799824f444017:38
dprincesalv-orl_: yes, we've had a rough go of it the last few weeks. When I took a closer look yesterday I was a bit surprised this on hadn't landed17:38
*** ivar-lazzaro has joined #openstack-neutron17:40
salv-orl_dprince: It has been brougth to my attention today only. We'll sort it out in the next few hours.17:40
*** armax has joined #openstack-neutron17:40
*** rkukura has joined #openstack-neutron17:41
dprincesalv-orl_: appreciate it. FWIW I think it was mentioned on IRC but nobody was probably directly ping'ed so it just slipped through the cracks...17:41
salv-orl_ihrachyshka: I am about to go afk now. I've chatted with armax (who's not online), and asked him to have a final look - he should be able to do that soon.17:41
*** ivar-lazzaro has quit IRC17:41
armaxsalv-orl_: I decided to pull over to look at this :)17:41
ihrachyshkadprince, I feel guilty, for I knew about the issue several days ago17:42
*** ivar-lazzaro has joined #openstack-neutron17:42
salv-orl_armax: your dedication to work is impressive.17:42
*** ivar-lazzaro has quit IRC17:42
salv-orl_pretty sure your last name actually is Stakanov17:42
*** ivar-lazzaro has joined #openstack-neutron17:43
*** david-lyle_afk is now known as david-lyle17:43
*** jprovazn has joined #openstack-neutron17:44
ihrachyshkasalv-orl_, the last time I checked, Stakhanov's achievements were considered overrated ;)17:44
*** armax has quit IRC17:45
salv-orl_ihrachyshka: I have not checked in a while I am afraid.17:46
*** tflynn has joined #openstack-neutron17:48
*** leenheer has joined #openstack-neutron17:48
*** claudiub has quit IRC17:48
*** igordcard has quit IRC17:49
*** afazekas has quit IRC17:49
openstackgerritMaru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest  https://review.openstack.org/15802117:51
*** bquan_ has joined #openstack-neutron17:53
*** bquan_ has quit IRC17:53
*** bquan_ has joined #openstack-neutron17:53
*** bquan has quit IRC17:53
*** jpena has quit IRC17:55
openstackgerritMaru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest  https://review.openstack.org/15802117:56
*** sripriya has joined #openstack-neutron17:56
openstackgerritMaru Newby proposed openstack/neutron: Initial copy of api tests from tempest  https://review.openstack.org/16225717:57
marunsalv-orl_: hi17:58
marunsalv-orl_: hopefully I've answered your questions re ^^17:58
marunsalv-orl_: I'd like to get this merged asap as the first step towards removal of the tests from tempest: https://wiki.openstack.org/wiki/QA/Tempest-test-removal17:58
marunsalv-orl_: I think there is a need for increased visibility around this effort, as per your and dkranz's comments on the review.  I plan on working with armax on this early next week.18:00
ihrachyshkadprince, ok, I think I have a patch. do you want me to send it separately, or on top of revert?18:01
dprinceihrachyshka: I'd post it separately I think18:01
ihrachyshkadprince, ok, sure.18:02
*** sbfox has joined #openstack-neutron18:02
*** banix has quit IRC18:02
marunamuller: wtf is up with this change?18:03
marunhttps://review.openstack.org/#/c/161959/3/neutron/tests/unit/agent/linux/test_async_process.py18:03
marunor this? https://review.openstack.org/#/c/161959/3/neutron/tests/unit/bigswitch/fake_server.py18:03
*** superanne has joined #openstack-neutron18:04
*** techcet has quit IRC18:05
*** igordcard has joined #openstack-neutron18:06
*** techcet has joined #openstack-neutron18:06
*** yamahata has quit IRC18:07
*** banix has joined #openstack-neutron18:07
openstackgerritSandhya Dasu proposed openstack/neutron: Cisco UCS Manager ML2 Mechanism Driver  https://review.openstack.org/15543618:07
*** spandhe has joined #openstack-neutron18:08
*** karimb has quit IRC18:08
openstackgerritIhar Hrachyshka proposed openstack/neutron: ml2: don't miss notification if binding attempt failed  https://review.openstack.org/16226018:08
*** yamamoto has quit IRC18:09
*** SumitNaiksatam has quit IRC18:09
*** techcet has quit IRC18:10
*** techcet has joined #openstack-neutron18:11
*** mlavalle has quit IRC18:11
*** mlavalle has joined #openstack-neutron18:12
openstackgerritBrian Haley proposed openstack/neutron: Change linux/ip_lib code to better handle address families  https://review.openstack.org/15755518:12
marunamuller: I wish you had lumped your trivial pylint fixes together18:12
marunamuller: the crunch is coming and I think we all need to conserve ci resources as much as possible18:13
*** ChrisNBlum has joined #openstack-neutron18:14
pc_mcarl_baldwin: I updated https://review.openstack.org/#/c/160179/, can you take a look at the new PS?18:14
ihrachyshkasalv-orl_, dprince: https://review.openstack.org/#/c/162260/118:14
ihrachyshkamarun, may I ask you for +A at https://review.openstack.org/#/c/159654/4  so that I can rebase conflicting oslo.log patch that depends on it?18:15
* ihrachyshka does not want to loose +2s18:16
*** ygbo has quit IRC18:16
*** setuid has quit IRC18:16
marunihrachyshka: can do18:16
*** mlavalle has quit IRC18:16
*** mlavalle has joined #openstack-neutron18:17
*** setuid has joined #openstack-neutron18:17
marunihrachyshka: done18:17
ihrachyshkaawesome, thanks18:17
*** igordcard has quit IRC18:18
*** morganfainberg is now known as needscoffeebadly18:19
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Enable StrongSwan in gate hook  https://review.openstack.org/16171418:21
*** needscoffeebadly is now known as CaptainMorgan18:22
*** achanda has joined #openstack-neutron18:23
*** armax has joined #openstack-neutron18:23
amullermarun: about https://review.openstack.org/#/c/161959/3/neutron/tests/unit/agent/linux/test_async_process.py18:23
amullerthere's a list of blacklisted names in pylint18:23
amullerfoo is one of them18:23
*** Marga_ has joined #openstack-neutron18:23
amullerI think that generally speaking banning something like foo is not a terrible idea for readability18:23
amullerabout https://review.openstack.org/#/c/161959/3/neutron/tests/unit/bigswitch/fake_server.py - get_cert_contents is defined as a function that doesn't return anything, it just raises an exception (Think notimplemented), and is then mocked in testing18:24
amullerthe mocking business confuses pylint18:25
*** jp_at_hp has quit IRC18:25
*** sbfox has quit IRC18:26
*** superanne has quit IRC18:27
*** salv-orl_ has quit IRC18:28
*** coolsvap has joined #openstack-neutron18:29
*** haleyb has quit IRC18:30
*** yamahata has joined #openstack-neutron18:31
enikanorov_kevinbenton: ping18:31
*** SridharRamaswamy has joined #openstack-neutron18:34
openstackgerritChuck Carlino proposed openstack/neutron: Make updating port mac_address configurable  https://review.openstack.org/15922818:35
trinaths1hi, can someone give a look into this,   https://review.openstack.org/160702  ,its an update to contribute.rst , it dont take more time.18:36
*** markvoelker has quit IRC18:39
*** aepifanov has joined #openstack-neutron18:39
*** markvoelker has joined #openstack-neutron18:40
*** jprovazn has quit IRC18:43
*** haleyb has joined #openstack-neutron18:43
*** zhenq has quit IRC18:44
*** markvoelker has quit IRC18:44
*** tflynn_ has joined #openstack-neutron18:49
*** arif-ali has joined #openstack-neutron18:50
*** sthillma has joined #openstack-neutron18:51
*** achanda has quit IRC18:52
*** tflynn has quit IRC18:52
*** absubram has joined #openstack-neutron18:52
armaxihrachyshka: ping18:52
*** ivar-lazzaro has quit IRC18:52
ihrachyshkaarmax, pong18:53
armaxihrachyshka re: https://review.openstack.org/#/c/162260/18:53
*** tflynn_ has quit IRC18:53
*** rkukura has quit IRC18:53
armaxihrachyshka: you reckon it would be better to revert and issue a cleaner fix for bug ##139924918:54
armax?18:54
*** sthillma_ has joined #openstack-neutron18:54
ihrachyshkaarmax, I think yes, in that way we get more time for reviewers to look into my patch18:54
armaxihrachyshka: ok18:54
ihrachyshkaarmax, I sent it separately because dprince asked me to do it this way18:54
ihrachyshkaI'm ok squashing later if revert goes in18:55
ihrachyshkaalso, it's easier to review it separately for now :)18:55
*** gridinv has joined #openstack-neutron18:55
armaxihrachyshka: cool, you’re taking care of this?18:55
*** sthillma has quit IRC18:55
ihrachyshkaarmax, I will definitely monitor the revert18:55
*** gongysh has quit IRC18:55
HenryGarmax: I am siding with ihrachyshka to do a revert for now18:56
* ihrachyshka understands that he should go and actually vote for revert18:56
*** gongysh_ has quit IRC18:56
armaxHenryG: ya18:56
armaxHenryG, ihrachyshka: ok, so long as we have a plan to re-fix #1399249 then we’re good with the revert18:57
*** achanda has joined #openstack-neutron18:57
armaxdprince: I wonder if you’ve given some thoughts into having tripleO in the check pipeline for Neutron, was it ever discussed?18:57
armaxdprince: or is it just a bad idea?18:57
armaxHenryG: for your joy then: https://review.openstack.org/#/c/156853/18:58
HenryGarmax: already done18:58
armaxHenryG: kwel18:58
*** tflynn has joined #openstack-neutron18:59
*** arif-ali has quit IRC18:59
ChuckC_armax: HenryG: wondering if you might have time for a couple of small reviews related to mac address update: https://review.openstack.org/#/c/151804 and https://review.openstack.org/#/c/15922818:59
*** ivar-lazzaro has joined #openstack-neutron19:00
*** arif-ali has joined #openstack-neutron19:00
*** igordcard has joined #openstack-neutron19:00
ChuckC_since you both were at least somewhat involved with the spec and main code review :)19:01
dprinceihrachyshka: I sent an email to the list about CI testing the fix19:01
ChuckC_armax: HenryG: 151804 depends on 159228, so the latter is a bit more urgent19:02
dprinceihrachyshka: but after I just sent it I had a simpler idea. I could just swap in your patch instead as a cherry pick19:02
dprinceihrachyshka: let me do that and we'll at least see if it works19:02
armaxChuckC_: to me change 159228 is borderline -219:02
*** SridharRamaswam1 has joined #openstack-neutron19:02
armaxChuckC_: I reviewed it moments ago19:02
* ChuckC_ lookin19:02
*** markvoelker has joined #openstack-neutron19:03
ihrachyshkadprince, that would be awesome to see your CI report before merging my patch19:03
*** sripriya has quit IRC19:03
*** SridharRamaswamy has quit IRC19:03
*** sripriya has joined #openstack-neutron19:04
dprinceihrachyshka: well, that is the goal. I outline one way in the email. Lets see if your cherry pick works.19:04
*** superanne has joined #openstack-neutron19:04
dprinceihrachyshka: I've still got a slight preference for reverting19:04
dprinceihrachyshka: but if your patch works then great too, lets go with it19:04
ihrachyshkadprince, we're ok with revert, it's already +A19:04
ihrachyshkadprince, it's just that we want to break you later with my fix :)19:05
ihrachyshka*we DON'T19:05
ihrachyshkahow ironic19:05
dprinceihrachyshka: ah, cool. well then, once that lands I think a simple 'check experimental' would get you a tripleO ci result19:05
ChuckC_armax: I don't really like the approach myself, but did not find the tempest support you refer to in your comments19:05
ihrachyshkadprince, ok, will do then19:05
*** rkukura has joined #openstack-neutron19:06
ihrachyshkadprince, that's after you remove the workaround?19:06
armaxChuckC_: reach out to mtreinish19:06
dprinceihrachyshka: correct19:06
armaxChuckC_: he should be able to point you in the right direction19:06
dprinceihrachyshka: honestly, I think the cherrypick fails gracefully once the patch lands19:06
ihrachyshkadprince, ok, I'll sit on the patch for a day before revert is merged, and your workaround is removed19:06
openstackgerritAssaf Muller proposed openstack/neutron: Remove access-member-before-definition pylint exclusion  https://review.openstack.org/16219119:06
openstackgerritAssaf Muller proposed openstack/neutron: Enable pylint on tests subdir  https://review.openstack.org/16195919:06
ChuckC_armax: perfect, thanks.  Do you know what timezone he's in?19:06
openstackgerritAssaf Muller proposed openstack/neutron: Remove not-callable pylint exclusion  https://review.openstack.org/16219519:06
openstackgerritAssaf Muller proposed openstack/neutron: Remove expression-not-assigned pylint exclusion  https://review.openstack.org/16219419:06
openstackgerritAssaf Muller proposed openstack/neutron: Remove duplicate-key pylint exclusion  https://review.openstack.org/16219319:06
openstackgerritAssaf Muller proposed openstack/neutron: Remove no-method-argument pylint exclusion  https://review.openstack.org/16219219:06
dprinceihrachyshka: so it should be fine regardless19:07
ihrachyshkaack19:07
dprinceihrachyshka: sounds good19:07
armaxChuckC_: he’s EST, unless he’s travelling the world19:07
ChuckC_:)19:07
*** melwitt has joined #openstack-neutron19:07
*** saikrishna has quit IRC19:08
ChuckC_armax: also, I'd like to send you a draft of an email to nova/neutron/ironic ML regarding nova's lack of api for detaching/attaching/modifying nics19:09
*** yamamoto has joined #openstack-neutron19:09
armaxChuckC_: please don’t I am already swamped as it is, I won’t be able to respond you on time :)19:09
armaxChuckC_: and I don’t want to be your bottleneck19:10
ChuckC_ok, maybe garyk19:10
ihrachyshkaeezhova, hey. I think you are one of our policy experts. may I ask you to check https://review.openstack.org/#/c/159862/ ?19:10
openstackgerritAssaf Muller proposed openstack/neutron: Enable a bunch of pylint checks  https://review.openstack.org/16219019:12
openstackgerritAssaf Muller proposed openstack/neutron: Enable pylint on tests subdir  https://review.openstack.org/16195919:12
amullermarun: squashed the patches19:12
amullerI think you're right19:12
*** yamamoto has quit IRC19:14
*** SridharRamaswam1 has quit IRC19:14
*** pritesh has joined #openstack-neutron19:15
openstackgerritMichael Smith proposed openstack/neutron: WIP delay fip namespace cleanup/destroy  https://review.openstack.org/15175819:15
*** SridharRamaswamy has joined #openstack-neutron19:16
*** sripriya has quit IRC19:16
*** igordcard has quit IRC19:16
*** _cjones_ has quit IRC19:18
openstackgerritAssaf Muller proposed openstack/neutron: Enable a bunch of pylint checks  https://review.openstack.org/16219019:20
*** shivharis has joined #openstack-neutron19:21
mtreinishChuckC_: Eastern time :)19:23
*** superanne has quit IRC19:24
ChuckC_mtreinish: hi, I'm trying to learn how to have tempest skip a test for something that's not implemented in juno19:24
*** aix has quit IRC19:24
*** ivar-lazzaro has quit IRC19:24
mtreinishChuckC_: have you seen?: http://docs.openstack.org/developer/tempest/overview.html#branchless-tempest-considerations19:25
*** coolsvap has quit IRC19:25
ChuckC_mtreinish: armax objected to adding a config flag for such a minor feature (ability to modify port's mac_address), and I agree19:26
ChuckC_mtreinish: yes, that's what made me believe a config flag was required.  What am I missing?19:26
mtreinishChuckC_: do you have a link to the patch?19:27
shivharismestery: hi19:27
mtreinishChuckC_: if it's change the api behvaior you should have a way to signal that to the end user19:27
mesteryshivharis: yo19:27
ChuckC_the original work was in https://review.openstack.org/#/c/11212919:27
ChuckC_mtreinish: ^^19:28
shivharismestery: would like to bother you again, seems the confusion regarding the account is taken care of19:28
ChuckC_mtreinish: what options are there?19:28
mesteryshivharis: Excellent! :)19:28
shivharismestery: happens when someone leaves19:29
mesteryshivharis: lol :)19:29
shivharismestery: anyways i need voting permission on "brocade vdx ci" account19:29
mesteryshivharis: Looking19:29
*** sbfox has joined #openstack-neutron19:29
shivharismestery: you may have to remove the one already, and select the same again19:29
mesteryshivharis: Done, and it even has a correct email address (openstack_gerrit@brocade.com)19:30
mtreinishChuckC_: so that actually goes against the api change guidelines, you're adding something to the api without having an extension or api version to indicate that. (which is why we're having the issue in tempest)19:30
mtreinishhttps://wiki.openstack.org/wiki/APIChangeGuidelines19:31
shivharismestery: cool, i verified already it works!!19:31
mesteryshivharis: nice!19:31
shivharismestery: thanks19:31
mtreinishas an end user I have no idea which version of the api I'm using and whether a put with a new mac address will be allowed or not19:31
ChuckC_mtreinish: ok, so I could bump api version?19:31
mtreinishChuckC_: well neutron doesn't have microversions so I don't think you can. I think this will have to be something marked on the release notes19:32
mtreinishmestery: ^^^19:32
mtreinishas for the tempest side the only option is a config flag unfortunately19:32
mesterymtreinish: Yes, we have no microversion yet19:32
*** SumitNaiksatam has joined #openstack-neutron19:32
mtreinishmestery: yeah, so you guys changed your api. I'm not sure how you want to handle that19:33
mesterymtreinish: This is for the "allow mac address of ap ort to change" right? /cc ChuckC_19:33
mtreinishyeah19:33
ChuckC_mtreinish: so https://review.openstack.org/#/c/159228 is required?19:33
ChuckC_mtreinish: mestery: or too late?19:34
*** gridinv has quit IRC19:34
mesteryChuckC_: Looks like armax is highly not in favor of that particular change19:34
*** gridinv has joined #openstack-neutron19:34
ChuckC_mestery: yep, hence this discussion :)19:35
ChuckC_not sure what options we have19:35
mesteryChuckC_: I see we've stepped into a quagmire here19:35
mtreinishwell you just need some way to signal that the api changed. A config option may not be the best way, but it would at least make the breakage optional19:35
mtreinishnormally it's done with an extension, which is also terribad but at least it's not a config option19:36
ChuckC_mtreinish: mestery: does the fact that the change is backward compatible matter?19:36
mesterymtreinish: Ack on the extension, ack on it being terribad19:36
mesteryChuckC_: It's backward compatible?19:36
*** ajo has joined #openstack-neutron19:37
ChuckC_mestery: we allow something that was previously disallowed.19:37
ChuckC_during the review, I came to believe that meant it was backward compatible, but...19:38
ChuckC_maybe I just don't understand what would break19:39
mtreinishChuckC_: but that is breaking the consistency between releases, you need some way to inidcate that19:39
mtreinishthink about it like it was an application19:39
ihrachyshkaarmax, new func fix for stable branches work19:39
armaxihrachyshka: yup, I notived19:39
armaxnoticed19:39
ChuckC_mtreinish: sure, so then what would a 'backward compatible' change be?19:39
mtreinishChuckC_: https://wiki.openstack.org/wiki/APIChangeGuidelines#Generally_Considered_OK19:40
ChuckC_mtreinish: mestery: for this to impact someone, they would be relying on the failure of the request, which could happen of course19:40
* ChuckC_ looks19:40
mtreinishalthough re-reading that it seems like this arguably fits on that list19:41
mtreinishbecause it previously resulted in a failure now doesn't19:41
*** ivar-lazzaro has joined #openstack-neutron19:41
ChuckC_mtreinish: yeah, if you consider it a 'bug'19:41
mtreinishso I think as a team you guys need to say whether it was a bug fix and if so then we can just remove the offending negative tempest test19:42
mtreinishif not we need to signal it as a breaking change somehow19:42
ChuckC_mtreinish: the failing test is a positive test case run against juno19:43
ChuckC_https://review.openstack.org/#/c/15180419:43
mesterymtreinish ChuckC_: Reading that list, I think it falls under the second bullet there19:43
mesteryThus, removing the negative test may be the best way forward.19:43
mesteryMaybe I'm simplifying it though19:43
mtreinishChuckC_: oh, you're trying to add the test to update the mac address19:44
ChuckC_well, if there was a negative test case, I guess it was removed19:44
ChuckC_mtreinish: yes19:44
mtreinishwhat is it with you guys and exposing every edge case in branchless tempest :)19:45
ChuckC_mestery: my memory isn't so young any more :P19:45
ChuckC_mtreinish: such a thrill ;)19:46
mesterymtreinish: lol19:46
mtreinishChuckC_: well since backporting is probably out of the question. (which is how we advise handling this in the tempest docs) The only option would be to add a config option to tempest19:46
openstackgerritTrinath Somanchi proposed openstack/neutron: [contribute.rst] Current status of Freescale Codebase.  https://review.openstack.org/16070219:46
mtreinishChuckC_: because we assumed that any bug which changes the api behavior would be backported19:47
ChuckC_mestery: mtreinish: armax: one thing: users of plugins/backends that don't support mac address update might prefer the neutron config variable19:47
ChuckC_some platforms never have 'unbound' ports, so cannot use this feature19:48
mtreinishheh, this is quite the mess. So basically it's a crapshoot whether you can update the mac address or not :(19:48
*** bandarji has joined #openstack-neutron19:49
mtreinishit depends on the release and the backend...19:49
ChuckC_mtreinish: it's not really useful except in certain cases, e.g. ironic servers where the nic failed and was replaced19:49
ChuckC_mtreinish: SRIOV nics as well19:50
*** CaptainMorgan is now known as morganfainberg19:50
*** superanne has joined #openstack-neutron19:50
*** banix has quit IRC19:50
armaxChuckC_: but that should be done via policy IMO19:51
armaxChuckC_: we already bloat in terms of options as we are19:51
*** spandhe_ has joined #openstack-neutron19:51
*** ijw has joined #openstack-neutron19:51
*** superanne has quit IRC19:51
*** carl_baldwin has quit IRC19:52
*** trinaths1 has quit IRC19:52
ChuckC_armax: I agree, so users I mentioned could just use policy to block the operation...19:52
*** salv-orlando has joined #openstack-neutron19:52
*** superanne has joined #openstack-neutron19:52
ChuckC_mtreinish: can tempest do the same?19:52
mtreinishChuckC_: no, because as a user you have no way to know what the policy file is19:52
ihrachyshkamestery, salv-orlando, may I ask you to check https://bugs.launchpad.net/neutron/+bug/1365727 on whether it's worth a CVE (it would influence how we move forward with a backport that was requested for the bug)19:53
openstackLaunchpad bug 1365727 in OpenStack Security Advisory "N1kv tenant able to create networks for non-shared network profiles of other N1kv tenants" [Undecided,Incomplete]19:53
mtreinishChuckC_: this fits the criteria for having a tempest config option optional feature (which depends on release and/or backend)19:53
ihrachyshkayou seem to be in neutron sec team, so...19:53
*** spandhe has quit IRC19:53
*** spandhe_ is now known as spandhe19:53
mtreinishso you'd have to add a tempest config option to you patch in network-feature-enabled, something like update-mac-address19:53
mesteryihrachyshka: I just read the description, seems like it would require a CVE to me, do you agree?19:53
ChuckC_mtreinish: I'm surprised, I thought the policy file was intended to be user modifyable19:53
ihrachyshkamestery, I would agree, though sthillma_ from Cisco says it's not worth it (see comments)19:54
mtreinishChuckC_: oh no. The policy file is a server side configuration19:54
ChuckC_mtreinish: looking19:54
mtreinishChuckC_: that being said, I'm also tempted to say give up on the tempest patch and let's pretend this doesn't exist :)19:55
ChuckC_mtreinish: lessens my load :P  but maybe my paycheck too19:55
mesteryihrachyshka: I remain unconvinced19:56
*** superanne has quit IRC19:56
mtreinishChuckC_: heh, I should talk to mordred about a paycheck linearly proportional to patch count :)19:56
mtreinishI'm not sure that would work in my favor or against it19:57
ihrachyshkamestery, ok. anyway, VMT asked @neutron-sec members to consider the bug and leave a comment there, so kindly asking :)19:57
*** superanne has joined #openstack-neutron19:57
ChuckC_mtreinish: I'd starve19:57
mesteryihrachyshka: I replied in the bug19:57
ijwmtreinish: we could use a negative factor...19:57
mesteryihrachyshka: Lets take it from there.19:57
ihrachyshkamestery++19:57
mordred:)19:58
*** yfauser has joined #openstack-neutron19:58
*** yfauser has left #openstack-neutron19:58
ChuckC_mtreinish: thanks, I'll look into the tempest config var :)19:58
openstackgerritMaru Newby proposed openstack/neutron: Add script to copy neutron api tests from tempest  https://review.openstack.org/15802119:58
*** banix has joined #openstack-neutron19:59
*** Marga_ has quit IRC19:59
mtreinishChuckC_: if you go down the config option in tempest route, just make sure you outline in the option help and the commit msg very clearly why it's needed19:59
ijwihrachyshka, mestery: Looking at it, it's not really privilege escalation, it's faulty priv checking.  What is not mentioned in that bug is the consequences of using someone else's network profile - is it dangerous or harmless?  I think that would be key to its significance19:59
ChuckC_mtreinish: will do19:59
mtreinishalso you'll have to push up stable devstack branch patches to disable the flag in tempest19:59
mtreinishand then use Depends-On in the commit message of the tempest patch20:00
mesteryijw: It's dangerous and harmless20:00
mtreinish(assuming that works with stable branches)20:00
ChuckC_armax: are you ok with a tempest config var?20:00
mesteryijw: You're using a network profile (which may contain a VLAN) that someone else created20:00
ihrachyshkaijw, well, that's terminology question. But quoting Wikipedia, "Privilege escalation is the act of exploiting a bug, design flaw or configuration oversight in an operating system or software application to gain elevated access to resources that are normally protected from an application or user"20:01
openstackgerritZhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver  https://review.openstack.org/15856020:01
openstackgerritZhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention  https://review.openstack.org/14439120:01
ChuckC_mtreinish: so the devstack patches land first, yes?20:01
*** _cjones_ has joined #openstack-neutron20:01
armaxChuckC_: what do you mean?20:01
mtreinishChuckC_: yes, otherwise the tempest patch won't get through the check queue20:01
ihrachyshkaijw, so it's not like you need to get admin to claim it's an escalation (or so I read it)20:01
ChuckC_armax: mtreinish suggests a tempest config variable instead of neutron, just so the tempest api test can skip when run against juno20:02
ijwihrachyshka: We're really playing word games, but I would argue that escalation means you've somehow acquired a priv flag that lets you do more than you should.  In this instance you haven't acquired privileges (therefore no escalation) but you can do something you shouldn't (which is a fault in your lower priv level)20:03
ijwihrachyshka: I doubt the fine distinction makes much difference.20:03
armaxChuckC_: ok, if this is the process that Tempest adopts to test Extensions per release, then I am fine with it20:03
ChuckC_mtreinish: ^^20:03
*** gridinv has quit IRC20:04
*** sripriya has joined #openstack-neutron20:04
*** Longgeek has quit IRC20:06
*** vivek-ebay has quit IRC20:06
*** vivek-ebay has joined #openstack-neutron20:07
*** vivek-ebay has quit IRC20:07
*** vivek-ebay has joined #openstack-neutron20:07
*** salv-orlando has quit IRC20:11
*** rkukura has quit IRC20:14
*** _cjones_ has quit IRC20:14
*** techcet has quit IRC20:15
openstackgerritMerged openstack/neutron: Remove 'free' exclusions from pylint  https://review.openstack.org/16217320:15
*** mlavalle has quit IRC20:19
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Fixing UT breakage.  https://review.openstack.org/16228620:20
*** _cjones_ has joined #openstack-neutron20:21
*** rkukura has joined #openstack-neutron20:22
ChuckC_mtreinish: armax: i'll take a look at the backporting option and see if my new manager is ok with whatever timeline I come up with20:23
ChuckC_otherwise, the tempest config patch will have to do20:23
*** thomasem_ has quit IRC20:25
*** _cjones_ has quit IRC20:26
*** _cjones_ has joined #openstack-neutron20:27
*** leenheer has quit IRC20:27
ChuckC_mtreinish: armax: nevermind, only bugs are backported I guess20:27
mtreinishChuckC_: heh, well you said it was a bug to fit the 2nd bullet on the change guidelines :)20:27
*** thomasem has joined #openstack-neutron20:27
ChuckC_mtreinish: what to do with a 'bug fix' that changes the api....20:29
mtreinishChuckC_: http://docs.openstack.org/developer/tempest/overview.html#bug-fix-on-core-project-needing-tempest-changes20:29
ChuckC_mtreinish: ok, but first https://wiki.openstack.org/wiki/StableBranch#Appropriate_Fixes20:31
*** radez is now known as radez_g0n320:32
ChuckC_mtreinish: not sure I could argue the importance of backporting this change...20:32
mtreinishChuckC_: heh, well if the api needs a change that's an exception. I view that stable guideline as more of the general case20:32
mtreinishChuckC_: normally this is something that we shouldn't be doing20:33
mtreinishthe tempest doc just outlines what you need to do in order to land the change20:33
ChuckC_mtreinish: yep, ok, back to the tempest config var :)20:34
mtreinishfwiw, we've done that procedure (with the backports) several times already20:34
ChuckC_mtreinish: what justifications have been made for those changes?20:34
mtreinishI don't remember, but I think there was normally just ptl buy in for doing it20:35
ChuckC_mtreinish: ok, let me see what I can do/find out regarding need in juno20:36
*** techcet has joined #openstack-neutron20:37
*** rushil_ has quit IRC20:37
*** achanda has quit IRC20:37
*** SumitNaiksatam has quit IRC20:37
*** ivar-lazzaro has quit IRC20:39
*** apuimedo has quit IRC20:39
*** tflynn has quit IRC20:40
*** TrevorV|Home has quit IRC20:41
*** rkukura has quit IRC20:41
*** raildo has quit IRC20:42
*** crc32 has joined #openstack-neutron20:43
*** rushil has joined #openstack-neutron20:45
*** Trevor_V has joined #openstack-neutron20:45
*** cference has quit IRC20:45
*** cference has joined #openstack-neutron20:46
*** sc68cal_ is now known as sc68cal20:46
*** ChrisNBlum has quit IRC20:46
*** cference has quit IRC20:51
*** ivar-lazzaro has joined #openstack-neutron20:51
*** ivar-lazzaro has quit IRC20:51
*** ivar-laz_ has joined #openstack-neutron20:52
*** ivar-laz_ has quit IRC20:52
*** cference has joined #openstack-neutron20:54
*** mlavalle has joined #openstack-neutron20:55
*** nlahouti has quit IRC20:58
*** Trevor_V has quit IRC20:58
*** dprince has quit IRC20:59
*** achanda has joined #openstack-neutron21:00
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: device driver and agent refactoring  https://review.openstack.org/16017921:00
*** dimsum__ has quit IRC21:01
*** pritesh has quit IRC21:02
*** rushil has quit IRC21:02
*** ijw has quit IRC21:05
*** ijw has joined #openstack-neutron21:08
*** tflynn has joined #openstack-neutron21:08
pc_mmestery: ping21:08
mesterypc_m: yo yo yo!21:10
pc_mmestery: I was seeing VPN UTs failing again AFTER I had committed a patch to fix breakage from a recent Neutron commit that changed internal API.21:10
*** ajo has quit IRC21:11
pc_mmestery: I fixed and posted here https://review.openstack.org/#/c/162286/121:11
pc_mmestery: It's still running through tests, but once it completes, I'd like to get quick approval, so I can retest other commits21:11
* pc_m this will be hard on a Friday21:12
*** yamamoto has joined #openstack-neutron21:12
mesterypc_m: Will do it once it's done21:12
pc_mmestery: take a look at the review. I'm totally baffled as to why this happened.21:12
pc_mEssentially Carl did a change on 2/23 (yeah Feb). I did the UT breakage fix, which just merged up and it passed tests.21:13
pc_mSo did the review that I have out now for refactoring. But another review that ran tests today failed, and sure enough, it is broken.21:13
pc_mThe UT breakage fix was for some other issue. I don't know why it didn't fail due to the 2/23 change.21:14
*** tflynn has quit IRC21:16
pc_mThere is something unexplainable going on between the two repos... :(21:16
*** yamamoto has quit IRC21:16
*** s3wong has joined #openstack-neutron21:17
*** leenheer has joined #openstack-neutron21:17
*** absubram has quit IRC21:17
*** jobewan has joined #openstack-neutron21:17
pc_mSo 160179  review passed python27 test yesterday, and review 161714 failed the test this morning.21:18
*** rkukura has joined #openstack-neutron21:18
pc_mmestery: In any case, if you can help me get review and approve for this one-liner, I can rebase the other two commits.21:22
mesterypc_m: Ack21:22
pc_mmestery: Thanks!21:22
*** absubram has joined #openstack-neutron21:23
*** rkukura has quit IRC21:24
*** ihrachyshka has quit IRC21:26
*** julim has quit IRC21:27
*** badveli has joined #openstack-neutron21:27
*** jp_at_hp has joined #openstack-neutron21:28
*** sthillma_ has quit IRC21:31
*** vivek-ebay has quit IRC21:32
*** pc_m has quit IRC21:32
*** jp_at_hp has quit IRC21:33
*** harlowja_away has quit IRC21:34
*** vivek-ebay has joined #openstack-neutron21:36
openstackgerritPhillip Toohill proposed openstack/python-neutronclient: Updating lbaas cli for TLS  https://review.openstack.org/16140421:36
*** salv-orlando has joined #openstack-neutron21:36
*** dboik_ has quit IRC21:37
*** dimsum__ has joined #openstack-neutron21:41
openstackgerritSripriya Seetharam proposed openstack/neutron: Brocade Vyatta vrouter shim plugin for vendor decomposition  https://review.openstack.org/15905621:41
*** pritesh_ has joined #openstack-neutron21:41
*** pritesh_ is now known as pritesh21:42
openstackgerritMerged openstack/neutron-fwaas: Fix for breaking UTs when creating RouterInfo  https://review.openstack.org/16209921:42
openstackgerritMerged openstack/neutron: Fix DB2 upgrade problem for Remove Hyper-V plugin  https://review.openstack.org/16208321:43
*** superanne has quit IRC21:44
openstackgerritPhillip Toohill proposed openstack/python-neutronclient: Updating lbaas cli for TLS  https://review.openstack.org/16140421:45
*** signed8bit has quit IRC21:46
*** marun has quit IRC21:47
mtreinishmestery: do you think someone could work on migrating the neutronclient cli tests out of tempest. It should be pretty simple, jogo pushed up instructions to the ML: http://lists.openstack.org/pipermail/openstack-dev/2015-February/057458.html21:47
*** amotoki has quit IRC21:48
*** signed8bit has joined #openstack-neutron21:48
*** cference has quit IRC21:48
*** baoli_ has quit IRC21:49
*** nlahouti has joined #openstack-neutron21:50
*** igordcard has joined #openstack-neutron21:50
mesterymtreinish: Ack, that seems doable, thanks for the pointer!21:51
mtreinishmestery: I'd really like to see that all be out of tempest by the end of the cycle :)21:51
mesterymtreinish: ++21:51
openstackgerritAssaf Muller proposed openstack/neutron: Replace keepalived notifier bash script with Python ip monitor  https://review.openstack.org/12538421:52
*** superanne has joined #openstack-neutron21:52
amullerarmax: New revision up, addressed your comments (And Cedric's, Akihiro's)21:52
mesterymtreinish: I'll take a stab at this over the weekend, it looks pretty simple actually and the instructions look easy, thanks!21:53
*** sthillma has joined #openstack-neutron21:53
*** b3nt_pin has joined #openstack-neutron21:53
mtreinishmestery: cool thanks21:53
*** luflores has joined #openstack-neutron21:53
mesterymtreinish: yw, and thanks for the reminder. It's hard to juggle a million things, so reminders are very helpful for me :)21:54
*** kickinz1 is now known as kickinz1|afk21:55
mtreinishmestery: yeah, completely understand. I'm trying to ping someone from every project over the next week to get them all out.21:55
mesterymtreinish: Thanks again for the reminder!21:56
* mtreinish hopes no one tracks all the things hepromised to do21:56
mesterymtreinish: It must almost be happy hour where you are, right? I'm still an hour away ;)21:56
mesterymtreinish: lol21:56
*** prad has joined #openstack-neutron21:56
mtreinishmestery: heh, yeah it's getting to be that time21:57
openstackgerritRajeev Grover proposed openstack/neutron: If configured, set the MTU for fpr/rfp intefaces  https://review.openstack.org/16231221:57
openstackgerritSripriya Seetharam proposed openstack/neutron: Brocade Vyatta vrouter shim plugin for vendor decomposition  https://review.openstack.org/15905622:00
*** vivek-ebay has quit IRC22:00
*** vivek-ebay has joined #openstack-neutron22:00
*** amuller has quit IRC22:02
*** manishg has quit IRC22:04
*** manishg has joined #openstack-neutron22:05
*** tiswanso has quit IRC22:05
*** techcet has quit IRC22:05
*** jgrimm is now known as zz_jgrimm22:06
*** ijw has quit IRC22:08
*** radez_g0n3 is now known as radez22:08
*** ijw has joined #openstack-neutron22:08
bandarjineutron subnet-update <project> —allocation-pools start=172.20.24.100,end=172.20.27.250 # this fails - anyone know if something wrong with my format?22:09
bandarjithe network is 172.20.24.0/2222:09
*** baoli has joined #openstack-neutron22:10
openstackgerritAbhishek Raut proposed openstack/neutron: Cisco Nexus1000V ML2 Mechanism Driver  https://review.openstack.org/15724322:11
*** aepifanov has quit IRC22:12
openstackgerritRyan Tidwell proposed openstack/neutron: Basic subnetpool CRUD  https://review.openstack.org/14869822:13
*** Marga_ has joined #openstack-neutron22:14
*** dimsum__ has quit IRC22:16
haleybbandarji: s/allocation-pools/allocation-pool - no 's' on the end ?22:16
*** dimsum__ has joined #openstack-neutron22:17
*** sbfox has quit IRC22:17
*** tflynn has joined #openstack-neutron22:20
*** banix has quit IRC22:21
*** sbfox has joined #openstack-neutron22:21
*** dimsum__ has quit IRC22:21
bandarjithanks - got it fixed - it was client software version22:21
*** dimsum__ has joined #openstack-neutron22:23
*** r-daneel has quit IRC22:23
*** vmtrooper has joined #openstack-neutron22:23
openstackgerritMerged openstack/neutron: Refactor the ProcessMonitor API  https://review.openstack.org/15446422:24
*** chlong has quit IRC22:24
*** tflynn has quit IRC22:25
*** leenheer has quit IRC22:28
*** ijw has quit IRC22:28
openstackgerritMerged openstack/neutron: oslo: sync all modules that depend on incubator log module  https://review.openstack.org/15965422:28
*** radez is now known as radez_g0n322:31
openstackgerritMerged openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed"  https://review.openstack.org/15685322:31
*** leenheer has joined #openstack-neutron22:34
*** vmtrooper has quit IRC22:37
*** carlp has quit IRC22:37
*** sbfox has quit IRC22:37
*** thomasem has quit IRC22:41
*** julim has joined #openstack-neutron22:41
*** igordcard has quit IRC22:42
*** dimsum__ has quit IRC22:43
*** dimsum__ has joined #openstack-neutron22:43
*** sbfox has joined #openstack-neutron22:44
*** dimsum__ has quit IRC22:48
*** zhenq has joined #openstack-neutron22:49
*** manishg_ has joined #openstack-neutron22:50
*** carlp has joined #openstack-neutron22:51
openstackgerritKyle Mestery proposed openstack/python-neutronclient: Add OS_TEST_PATH to testr  https://review.openstack.org/16232622:51
openstackgerritKyle Mestery proposed openstack/python-neutronclient: First pass at tempest-lib based functional testing  https://review.openstack.org/16232722:51
*** salv-orlando has quit IRC22:53
*** ajo has joined #openstack-neutron22:53
*** manishg has quit IRC22:54
*** leenheer has quit IRC22:54
*** bandarji has quit IRC22:54
*** techcet has joined #openstack-neutron22:55
*** igordcard has joined #openstack-neutron22:57
*** banix has joined #openstack-neutron22:58
*** banix has quit IRC22:59
*** _cjones_ has quit IRC22:59
*** superanne has quit IRC22:59
*** ParsectiX has quit IRC23:00
*** eren has quit IRC23:00
*** ParsectiX has joined #openstack-neutron23:00
*** r-daneel has joined #openstack-neutron23:02
*** achanda_ has joined #openstack-neutron23:03
*** achanda has quit IRC23:03
*** igordcard has quit IRC23:03
*** ajo has quit IRC23:03
openstackgerritKyle Mestery proposed openstack/python-neutronclient: Add post_test_hook for functional tests  https://review.openstack.org/16233123:04
mesterymtreinish: I got a good start on moving the tempest cli tests, thanks for hte pointer! I should hopefully have it finished monday pending merges.23:05
mesterymtreinish: Have a good weekend!23:05
*** claudiub has joined #openstack-neutron23:05
claudiubhello. anyone online who can answer some questions about floating ips?23:05
*** banix has joined #openstack-neutron23:05
claudiubor about how / why floating ips work?23:06
claudiubor why the way floating ips work has changes?23:06
claudiubchanged *23:06
*** r-daneel_ has joined #openstack-neutron23:06
*** ronis has quit IRC23:07
*** r-daneel has quit IRC23:07
lufloresMy understanding is that floating ips are basically nat23:07
*** _cjones_ has joined #openstack-neutron23:07
*** achanda_ has quit IRC23:07
openstackgerritRyan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool  https://review.openstack.org/15759723:07
claudiubtrue, but there has been some recent changes, that broke floating ip binding to hyper-v23:08
claudiuband I don't know what / how / when23:08
*** vmtrooper has joined #openstack-neutron23:09
claudiubfor example: ubuntu@ubuntu:/$ nova floating-ip-associate test2 172.24.4.623:09
claudiubERROR (BadRequest): Unable to associate floating ip 172.24.4.6 to fixed ip 10.0.0.4 for instance d4cddf87-f600-4d4e-8404-deed0110bf93. Error: Agent with agent_type=L3 agent and host=WIN-SRVR2 could not be found (HTTP 400) (Request-ID: req-ddef9ca4-0b80-46bd-870e-5467d74ff933)23:09
*** achanda has joined #openstack-neutron23:10
*** r-daneel_ has quit IRC23:10
mtreinishmestery: awesome23:10
*** r-daneel_ has joined #openstack-neutron23:10
claudiuband hyper-v nodes have no L3 agents, only L2 agents, named 'HyperV Agent'23:10
claudiubmtreinish: hello23:10
*** ijw has joined #openstack-neutron23:11
*** manishg_ has left #openstack-neutron23:11
claudiubmtreinish: I've uploaded a new patchset for the telemetry metrics collection commit: https://review.openstack.org/#/c/140750/ . If you have some time, could you take a look? Thanks! :D23:12
claudiubprobably wrong channel for this... sorry :)23:12
mtreinishclaudiub: sure, I'll put it on my list. But, I'm mostly done for today, so it probably won't be until enxt week23:13
*** crc32 has quit IRC23:13
*** leenheer has joined #openstack-neutron23:13
claudiubmtreinish: sure, no problem :)23:13
*** yamamoto has joined #openstack-neutron23:14
*** kbringard has quit IRC23:15
*** techcet has quit IRC23:15
claudiubmtreinish: also, I have a commit for tempest security groups, that have been awaiting reviews for a few months... currently needs rebase, which I'll do tomorrow, but can you also add it to the list? It's quite important, because without it, there is security groups test in Hyper-V CI, so there is no validation for that feature. Plus, there already was an issue regarding that feature, there were some changes that broke secu23:16
*** prad has quit IRC23:16
claudiubmtreinish: and was not caught for quite some time and the test would help prevent this from happening again. :)23:17
claudiubmtreinish: the commit is: https://review.openstack.org/#/c/117520/23:17
*** yamamoto has quit IRC23:18
*** igordcard has joined #openstack-neutron23:20
*** techcet has joined #openstack-neutron23:20
mtreinishclaudiub: sure will do23:20
*** ijw_ has joined #openstack-neutron23:21
*** Networkn3rd has quit IRC23:21
*** tflynn has joined #openstack-neutron23:21
claudiubmtreinish: thanks. :D23:21
*** techcet_ has joined #openstack-neutron23:21
*** SridharRamaswamy has quit IRC23:22
*** ijw_ has quit IRC23:22
*** ijw_ has joined #openstack-neutron23:23
*** ijw has quit IRC23:23
openstackgerritRyan Tidwell proposed openstack/neutron: Basic subnetpool CRUD  https://review.openstack.org/14869823:24
*** techcet has quit IRC23:25
*** ChuckC_ has quit IRC23:25
*** vmtrooper has quit IRC23:25
openstackgerritRyan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool  https://review.openstack.org/15759723:25
*** tflynn has quit IRC23:25
*** techcet_ has quit IRC23:26
*** armax has quit IRC23:27
openstackgerritYanping Qu proposed openstack/neutron-fwaas: Adds FWaaS driver for Cisco CSR1kv  https://review.openstack.org/16101923:28
*** leenheer has quit IRC23:29
*** luflores has quit IRC23:31
*** signed8bit has quit IRC23:32
*** sthillma has quit IRC23:38
*** s3wong has quit IRC23:38
*** ijw_ has quit IRC23:39
*** busterswt has quit IRC23:40
*** bquan_ has quit IRC23:43
*** ChuckC_ has joined #openstack-neutron23:43
*** ChuckC_ is now known as ChuckC23:44
*** leenheer has joined #openstack-neutron23:46
openstackgerritYanping Qu proposed openstack/neutron-fwaas: Provide hooks for FWaaS repo functional gate  https://review.openstack.org/16147923:49
openstackgerritYanping Qu proposed openstack/neutron-fwaas: Provide Cisco FWaaS functional tests  https://review.openstack.org/16193823:49
openstackgerritDane LeBlanc proposed openstack/neutron: Support Dual-Stack Gateway Ports on Neutron Routers  https://review.openstack.org/14906823:49
*** leenheer has quit IRC23:58
*** mlavalle has quit IRC23:58
*** dimsum__ has joined #openstack-neutron23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!